The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Unpin creation commands while records are selected (#26075)
Thomas des Francsa133c6c4e0db
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-upgrade-version-command.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-upgrade-version-command.module.tsindex 64546527dd8..218ec21c7b5 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-upgrade-version-command.module.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-upgrade-version-command.module.ts@@ -13,6 +13,7 @@ import { RemoveSeeActiveVersionCommandMenuItemCommand } from 'src/database/commaimport { NormalizeWorkflowRecordCrudRichTextFieldsCommand } from 'src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789482628000-normalize-workflow-record-crud-rich-text-fields.command';import { BackfillDeterministicPermissionUniversalIdentifiersCommand } from 'src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789553327000-backfill-deterministic-permission-universal-identifiers.command';import { SeedObjectInitialViewCommand } from 'src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789565000000-seed-object-initial-view.command';+import { UnpinCreationCommandsOnRecordSelectionCommand } from 'src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789565075331-unpin-creation-commands-on-record-selection.command';import { ApplicationModule } from 'src/engine/core-modules/application/application.module';import { WorkflowVersionCoreModule } from 'src/engine/core-modules/workflow/workflow-version-core.module';import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';@@ -46,6 +47,7 @@ import { WorkspaceSchemaMigrationRunnerActionHandlersModule } from 'src/engine/wNormalizeWorkflowRecordCrudRichTextFieldsCommand,BackfillDeterministicPermissionUniversalIdentifiersCommand,SeedObjectInitialViewCommand,+ UnpinCreationCommandsOnRecordSelectionCommand,],})export class V2_41_UpgradeVersionCommandModule {}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789565075331-unpin-creation-commands-on-record-selection.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789565075331-unpin-creation-commands-on-record-selection.command.tsnew file mode 100644index 00000000000..0f10234b57d--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789565075331-unpin-creation-commands-on-record-selection.command.ts@@ -0,0 +1,77 @@+import { Command } from 'nest-commander';+import { TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER } from 'twenty-shared/application';++import { ProvisionedWorkspaceCommandRunner } from 'src/database/commands/command-runners/provisioned-workspace.command-runner';+import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';+import { type RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspace.command-runner';+import { buildUnpinCreationCommandsOnSelectionUpdates } from 'src/database/commands/upgrade-version-command/2-41/utils/build-unpin-creation-commands-on-selection-updates.util';+import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';+import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';++@RegisteredWorkspaceCommand('2.41.0', 1789565075331)+@Command({+ name: 'upgrade:2-41:unpin-creation-commands-on-record-selection',+ description:+ 'Stop pinning the record and campaign creation command menu items while records are selected',+})+export class UnpinCreationCommandsOnRecordSelectionCommand extends ProvisionedWorkspaceCommandRunner {+ constructor(+ protected readonly workspaceIteratorService: WorkspaceIteratorService,+ private readonly workspaceCacheService: WorkspaceCacheService,+ private readonly workspaceMigrationValidateBuildAndRunService: WorkspaceMigrationValidateBuildAndRunService,+ ) {+ super(workspaceIteratorService);+ }++ override async runOnWorkspace({+ workspaceId,+ options,+ }: RunOnWorkspaceArgs): Promise<void> {+ const { flatCommandMenuItemMaps } =+ await this.workspaceCacheService.getOrRecompute(workspaceId, [+ 'flatCommandMenuItemMaps',+ ]);++ const commandMenuItemsToUpdate =+ buildUnpinCreationCommandsOnSelectionUpdates({+ flatCommandMenuItemByUniversalIdentifier:+ flatCommandMenuItemMaps.byUniversalIdentifier,+ now: new Date().toISOString(),+ });++ if (commandMenuItemsToUpdate.length === 0) {+ return;+ }++ if (options.dryRun ?? false) {+ this.logger.log(+ `[DRY RUN] Workspace ${workspaceId}: ${commandMenuItemsToUpdate.length} creation command(s) to unpin while records are selected`,+ );++ return;+ }++ const validateAndBuildResult =+ await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(+ {+ isSystemBuild: true,+ workspaceId,+ applicationUniversalIdentifier:+ TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER,+ allFlatEntityOperationByMetadataName: {+ commandMenuItem: {+ flatEntityToCreate: [],+ flatEntityToDelete: [],+ flatEntityToUpdate: commandMenuItemsToUpdate,+ },+ },+ },+ );++ if (validateAndBuildResult.status === 'fail') {+ throw new WorkspaceMigrationBuilderException(validateAndBuildResult);+ }+ }+}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/utils/__tests__/build-unpin-creation-commands-on-selection-updates.util.spec.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/utils/__tests__/build-unpin-creation-commands-on-selection-updates.util.spec.tsnew file mode 100644index 00000000000..b658dbccadf--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/utils/__tests__/build-unpin-creation-commands-on-selection-updates.util.spec.ts@@ -0,0 +1,75 @@+import { buildUnpinCreationCommandsOnSelectionUpdates } from 'src/database/commands/upgrade-version-command/2-41/utils/build-unpin-creation-commands-on-selection-updates.util';+import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';+import { STANDARD_COMMAND_MENU_ITEMS } from 'src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant';++const NOW = '2026-09-16T00:00:00.000Z';++const { universalIdentifier: CREATE_NEW_RECORD_UNIVERSAL_IDENTIFIER } =+ STANDARD_COMMAND_MENU_ITEMS.createNewRecord;++const { universalIdentifier: COMPOSE_CAMPAIGN_PINNED_UNIVERSAL_IDENTIFIER } =+ STANDARD_COMMAND_MENU_ITEMS.composeCampaignPinned;++const buildExistingItem = (+ universalIdentifier: string,+ conditionalPinnedExpression: string | null,+): FlatCommandMenuItem =>+ ({+ universalIdentifier,+ conditionalPinnedExpression,+ updatedAt: '2025-01-01T00:00:00.000Z',+ }) as FlatCommandMenuItem;++describe('buildUnpinCreationCommandsOnSelectionUpdates', () => {+ it('unpins the creation commands while records are selected', () => {+ const updates = buildUnpinCreationCommandsOnSelectionUpdates({+ flatCommandMenuItemByUniversalIdentifier: {+ [CREATE_NEW_RECORD_UNIVERSAL_IDENTIFIER]: buildExistingItem(+ CREATE_NEW_RECORD_UNIVERSAL_IDENTIFIER,+ null,+ ),+ [COMPOSE_CAMPAIGN_PINNED_UNIVERSAL_IDENTIFIER]: buildExistingItem(+ COMPOSE_CAMPAIGN_PINNED_UNIVERSAL_IDENTIFIER,+ null,+ ),+ },+ now: NOW,+ });++ expect(updates).toEqual([+ expect.objectContaining({+ universalIdentifier: CREATE_NEW_RECORD_UNIVERSAL_IDENTIFIER,+ conditionalPinnedExpression: 'numberOfSelectedRecords == 0',+ updatedAt: NOW,+ }),+ expect.objectContaining({+ universalIdentifier: COMPOSE_CAMPAIGN_PINNED_UNIVERSAL_IDENTIFIER,+ conditionalPinnedExpression: 'numberOfSelectedRecords == 0',+ updatedAt: NOW,+ }),+ ]);+ });++ it('leaves an already customized pinned expression untouched', () => {+ const updates = buildUnpinCreationCommandsOnSelectionUpdates({+ flatCommandMenuItemByUniversalIdentifier: {+ [CREATE_NEW_RECORD_UNIVERSAL_IDENTIFIER]: buildExistingItem(+ CREATE_NEW_RECORD_UNIVERSAL_IDENTIFIER,+ 'numberOfSelectedRecords == 1',+ ),+ },+ now: NOW,+ });++ expect(updates).toEqual([]);+ });++ it('returns no update when the command menu items are missing', () => {+ const updates = buildUnpinCreationCommandsOnSelectionUpdates({+ flatCommandMenuItemByUniversalIdentifier: {},+ now: NOW,+ });++ expect(updates).toEqual([]);+ });+});diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/utils/build-unpin-creation-commands-on-selection-updates.util.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/utils/build-unpin-creation-commands-on-selection-updates.util.tsnew file mode 100644index 00000000000..5db9503ba71--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/utils/build-unpin-creation-commands-on-selection-updates.util.ts@@ -0,0 +1,41 @@+import { isDefined } from 'twenty-shared/utils';++import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';+import { STANDARD_COMMAND_MENU_ITEMS } from 'src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant';++const CREATION_COMMAND_MENU_ITEMS = [+ STANDARD_COMMAND_MENU_ITEMS.createNewRecord,+ STANDARD_COMMAND_MENU_ITEMS.composeCampaignPinned,+];++export const buildUnpinCreationCommandsOnSelectionUpdates = ({+ flatCommandMenuItemByUniversalIdentifier,+ now,+}: {+ flatCommandMenuItemByUniversalIdentifier: Record<+ string,+ FlatCommandMenuItem | undefined+ >;+ now: string;+}): FlatCommandMenuItem[] =>+ CREATION_COMMAND_MENU_ITEMS.flatMap(+ ({ universalIdentifier, conditionalPinnedExpression }) => {+ const existingCommandMenuItem =+ flatCommandMenuItemByUniversalIdentifier[universalIdentifier];++ if (+ !isDefined(existingCommandMenuItem) ||+ isDefined(existingCommandMenuItem.conditionalPinnedExpression)+ ) {+ return [];+ }++ return [+ {+ ...existingCommandMenuItem,+ conditionalPinnedExpression,+ updatedAt: now,+ },+ ];+ },+ );diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.tsindex 4700abea6ed..5a43162d519 100644--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts@@ -66,6 +66,7 @@ export const STANDARD_COMMAND_MENU_ITEMS = {availabilityType: CommandMenuItemAvailabilityType.GLOBAL_OBJECT_CONTEXT,conditionalAvailabilityExpression:'pageType == "INDEX_PAGE" and objectPermissions.canUpdateObjectRecords and not hasAnySoftDeleteFilterOnView and objectMetadataItem.isUICreatable and objectMetadataItem.isUIEditable and not objectMetadataItem.isRemote',+ conditionalPinnedExpression: 'numberOfSelectedRecords == 0',availabilityObjectMetadataUniversalIdentifier: null,frontComponentUniversalIdentifier: null,engineComponentKey: EngineComponentKey.CREATE_NEW_RECORD,@@ -955,6 +956,7 @@ export const STANDARD_COMMAND_MENU_ITEMS = {availabilityType: CommandMenuItemAvailabilityType.GLOBAL_OBJECT_CONTEXT,conditionalAvailabilityExpression:'pageType == "INDEX_PAGE" and featureFlags.IS_MESSAGE_CAMPAIGN_ENABLED',+ conditionalPinnedExpression: 'numberOfSelectedRecords == 0',availabilityObjectMetadataUniversalIdentifier:STANDARD_OBJECTS.messageCampaign.universalIdentifier,frontComponentUniversalIdentifier: null,