Skip to content

The open alternative to Salesforce, designed for AI.

test(server): delete service unit specs (#24094)

Charles Bocheta31d3a68268c
diff --git a/packages/twenty-server/src/database/clickHouse/clickHouse.service.spec.ts b/packages/twenty-server/src/database/clickHouse/clickHouse.service.spec.ts
deleted file mode 100644
index 1f32368f4d0..00000000000
--- a/packages/twenty-server/src/database/clickHouse/clickHouse.service.spec.ts
+++ /dev/null
@@ -1,298 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type ClickHouseClient } from '@clickhouse/client';
-
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-import { ClickHouseService } from './clickHouse.service';
-
-// Mock the createClient function from @clickhouse/client
-jest.mock('@clickhouse/client', () => ({
- createClient: jest.fn().mockReturnValue({
- insert: jest.fn().mockResolvedValue({}),
- query: jest.fn().mockResolvedValue({
- json: jest.fn().mockResolvedValue([{ test: 'data' }]),
- }),
- ping: jest.fn().mockResolvedValue({ success: true }),
- close: jest.fn().mockResolvedValue({}),
- exec: jest.fn().mockResolvedValue({}),
- }),
- ClickHouseLogLevel: { OFF: 'OFF' },
-}));
-
-describe('ClickHouseService', () => {
- let service: ClickHouseService;
- let twentyConfigService: TwentyConfigService;
- let mockClickHouseClient: jest.Mocked<ClickHouseClient>;
- let loggerErrorSpy: jest.SpyInstance;
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- mockClickHouseClient = {
- insert: jest.fn().mockResolvedValue({}),
- query: jest.fn().mockResolvedValue({
- json: jest.fn().mockResolvedValue([{ test: 'data' }]),
- }),
- ping: jest.fn().mockResolvedValue({ success: true }),
- close: jest.fn().mockResolvedValue({}),
- exec: jest.fn().mockResolvedValue({}),
- } as unknown as jest.Mocked<ClickHouseClient>;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ClickHouseService,
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn((key) => {
- if (key === 'CLICKHOUSE_URL') return 'http://localhost:8123';
-
- return undefined;
- }),
- },
- },
- ],
- }).compile();
-
- service = module.get<ClickHouseService>(ClickHouseService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
-
- // Mock logger error method to avoid polluting test output
- loggerErrorSpy = jest
- .spyOn((service as any).logger, 'error')
- .mockImplementation();
-
- // Set the mock client
- (service as any).mainClient = mockClickHouseClient;
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('constructor', () => {
- it('should not initialize clickhouse client when clickhouse is disabled', async () => {
- jest.spyOn(twentyConfigService, 'get').mockImplementation((key) => {
- if (key === 'CLICKHOUSE_URL') return '';
-
- return undefined;
- });
-
- const newModule: TestingModule = await Test.createTestingModule({
- providers: [
- ClickHouseService,
- {
- provide: TwentyConfigService,
- useValue: twentyConfigService,
- },
- ],
- }).compile();
-
- const newService = newModule.get<ClickHouseService>(ClickHouseService);
-
- expect((newService as any).mainClient).toBeUndefined();
- });
- });
-
- describe('insert', () => {
- it('should insert data into clickhouse and return success', async () => {
- const testData = [{ id: 1, name: 'test' }];
- const result = await service.insert('test_table', testData);
-
- expect(result).toEqual({ success: true });
- expect(mockClickHouseClient.insert).toHaveBeenCalledWith({
- table: 'test_table',
- values: testData,
- format: 'JSONEachRow',
- clickhouse_settings: {
- async_insert: 1,
- wait_for_async_insert: 1,
- },
- });
- });
-
- it('should allow overriding the asynchronous insert busy timeout', async () => {
- const testData = [{ id: 1, name: 'test' }];
- const result = await service.insert('test_table', testData, {
- asyncInsertBusyTimeoutMaxMs: 100,
- });
-
- expect(result).toEqual({ success: true });
- expect(mockClickHouseClient.insert).toHaveBeenCalledWith({
- table: 'test_table',
- values: testData,
- format: 'JSONEachRow',
- clickhouse_settings: {
- async_insert: 1,
- async_insert_busy_timeout_max_ms: 100,
- wait_for_async_insert: 1,
- },
- });
- });
-
- it('should return failure when clickhouse client is not defined', async () => {
- (service as any).mainClient = undefined;
-
- const testData = [{ id: 1, name: 'test' }];
- const result = await service.insert('test_table', testData);
-
- expect(result).toEqual({ success: false });
- });
-
- it('should handle errors and return failure', async () => {
- const testError = new Error('Test error');
-
- mockClickHouseClient.insert.mockRejectedValueOnce(testError);
-
- const testData = [{ id: 1, name: 'test' }];
- const result = await service.insert('test_table', testData);
-
- expect(result).toEqual({ success: false });
- expect(loggerErrorSpy).toHaveBeenCalledWith(
- 'Error inserting data into ClickHouse',
- testError,
- );
- });
- });
-
- describe('select', () => {
- it('should execute a query and return results', async () => {
- const query = 'SELECT * FROM test_table WHERE id = {id:Int32}';
- const params = { id: 1 };
-
- mockClickHouseClient.query.mockResolvedValueOnce({
- json: jest.fn().mockResolvedValueOnce([{ id: 1, name: 'test' }]),
- } as any);
-
- const result = await service.select(query, params);
-
- expect(result).toEqual([{ id: 1, name: 'test' }]);
- expect(mockClickHouseClient.query).toHaveBeenCalledWith({
- query,
- format: 'JSONEachRow',
- query_params: params,
- });
- });
-
- it('should return empty array when clickhouse client is not defined', async () => {
- (service as any).mainClient = undefined;
-
- const query = 'SELECT * FROM test_table';
- const result = await service.select(query);
-
- expect(result).toEqual([]);
- });
-
- it('should handle errors and return empty array', async () => {
- const testError = new Error('Test error');
-
- mockClickHouseClient.query.mockRejectedValueOnce(testError);
-
- const query = 'SELECT * FROM test_table';
- const result = await service.select(query);
-
- expect(result).toEqual([]);
- expect(loggerErrorSpy).toHaveBeenCalledWith(
- 'Error executing select query in ClickHouse',
- testError,
- );
- });
- });
-
- describe('createDatabase', () => {
- it('should create a database and return true', async () => {
- const result = await service.createDatabase('test_db');
-
- expect(result).toBe(true);
- expect(mockClickHouseClient.exec).toHaveBeenCalledWith({
- query: 'CREATE DATABASE IF NOT EXISTS test_db',
- });
- });
-
- it('should return false when clickhouse client is not defined', async () => {
- (service as any).mainClient = undefined;
-
- const result = await service.createDatabase('test_db');
-
- expect(result).toBe(false);
- });
- });
-
- describe('dropDatabase', () => {
- it('should drop a database and return true', async () => {
- const result = await service.dropDatabase('test_db');
-
- expect(result).toBe(true);
- expect(mockClickHouseClient.exec).toHaveBeenCalledWith({
- query: 'DROP DATABASE IF EXISTS test_db',
- });
- });
-
- it('should return false when clickhouse client is not defined', async () => {
- (service as any).mainClient = undefined;
-
- const result = await service.dropDatabase('test_db');
-
- expect(result).toBe(false);
- });
- });
-
- describe('connectToClient', () => {
- it('should connect to a client and return it', async () => {
- jest
- .spyOn(service, 'connectToClient')
- .mockResolvedValueOnce(mockClickHouseClient);
-
- const result = await service.connectToClient('test-client');
-
- expect(result).toBe(mockClickHouseClient);
- });
-
- it('should reuse an existing client if available', async () => {
- // Set up a client in the map
- (service as any).clients.set('test-client', mockClickHouseClient);
-
- const result = await service.connectToClient('test-client');
-
- expect(result).toBe(mockClickHouseClient);
- });
- });
-
- describe('disconnectFromClient', () => {
- it('should disconnect from a client', async () => {
- // Set up a client in the map
- (service as any).clients.set('test-client', mockClickHouseClient);
-
- await service.disconnectFromClient('test-client');
-
- expect(mockClickHouseClient.close).toHaveBeenCalled();
- expect((service as any).clients.has('test-client')).toBe(false);
- });
-
- it('should do nothing if client does not exist', async () => {
- await service.disconnectFromClient('non-existent-client');
-
- expect(mockClickHouseClient.close).not.toHaveBeenCalled();
- });
- });
-
- describe('lifecycle hooks', () => {
- it('should ping server on module init', async () => {
- await service.onModuleInit();
-
- expect(mockClickHouseClient.ping).toHaveBeenCalled();
- });
-
- it('should close all clients on module destroy', async () => {
- // Set up a couple of clients
- (service as any).clients.set('client1', mockClickHouseClient);
- (service as any).clients.set('client2', mockClickHouseClient);
-
- await service.onModuleDestroy();
-
- // One for mainClient, and two for the clients in the map
- expect(mockClickHouseClient.close).toHaveBeenCalledTimes(3);
- });
- });
-});
diff --git a/packages/twenty-server/src/database/commands/__tests__/__snapshots__/instance-command-generation.service.spec.ts.snap b/packages/twenty-server/src/database/commands/__tests__/__snapshots__/instance-command-generation.service.spec.ts.snap
deleted file mode 100644
index 0d36d638a20..00000000000
--- a/packages/twenty-server/src/database/commands/__tests__/__snapshots__/instance-command-generation.service.spec.ts.snap
+++ /dev/null
@@ -1,191 +0,0 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
-
-exports[`InstanceCommandGenerationService should encode version correctly in file and class names 1`] = `
-{
- "className": "TestFastInstanceCommand",
- "fileName": "30-40-instance-command-fast-1775000000000-test.ts",
- "fileTemplate": "import { QueryRunner } from 'typeorm';
-
-import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
-import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';
-
-@RegisteredInstanceCommand('30.40.0', 1775000000000)
-export class TestFastInstanceCommand implements FastInstanceCommand {
- public async up(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('SELECT 1');
- }
-
- public async down(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('SELECT 1');
- }
-}
-",
-}
-`;
-
-exports[`InstanceCommandGenerationService should escape backslashes in SQL queries 1`] = `
-{
- "className": "UpdatePathFastInstanceCommand",
- "fileName": "10-20-instance-command-fast-1775000000000-update-path.ts",
- "fileTemplate": "import { QueryRunner } from 'typeorm';
-
-import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
-import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';
-
-@RegisteredInstanceCommand('10.20.0', 1775000000000)
-export class UpdatePathFastInstanceCommand implements FastInstanceCommand {
- public async up(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('UPDATE "core"."config" SET "value" = E\\'path\\\\\\\\to\\\\\\\\file\\'');
- }
-
- public async down(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('UPDATE "core"."config" SET "value" = NULL');
- }
-}
-",
-}
-`;
-
-exports[`InstanceCommandGenerationService should escape single quotes in SQL queries 1`] = `
-{
- "className": "UpdateConfigFastInstanceCommand",
- "fileName": "10-20-instance-command-fast-1775000000000-update-config.ts",
- "fileTemplate": "import { QueryRunner } from 'typeorm';
-
-import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
-import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';
-
-@RegisteredInstanceCommand('10.20.0', 1775000000000)
-export class UpdateConfigFastInstanceCommand implements FastInstanceCommand {
- public async up(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('UPDATE "core"."config" SET "value" = \\'it\\'\\'s done\\'');
- }
-
- public async down(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('UPDATE "core"."config" SET "value" = \\'original\\'');
- }
-}
-",
-}
-`;
-
-exports[`InstanceCommandGenerationService should generate a migration with a single up/down query 1`] = `
-{
- "className": "AddFooColumnFastInstanceCommand",
- "fileName": "10-20-instance-command-fast-1775000000000-add-foo-column.ts",
- "fileTemplate": "import { QueryRunner } from 'typeorm';
-
-import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
-import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';
-
-@RegisteredInstanceCommand('10.20.0', 1775000000000)
-export class AddFooColumnFastInstanceCommand implements FastInstanceCommand {
- public async up(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('ALTER TABLE "core"."user" ADD "foo" varchar');
- }
-
- public async down(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('ALTER TABLE "core"."user" DROP COLUMN "foo"');
- }
-}
-",
-}
-`;
-
-exports[`InstanceCommandGenerationService should generate a migration with multiple queries 1`] = `
-{
- "className": "CreateTaskTableFastInstanceCommand",
- "fileName": "10-20-instance-command-fast-1775000000000-create-task-table.ts",
- "fileTemplate": "import { QueryRunner } from 'typeorm';
-
-import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
-import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';
-
-@RegisteredInstanceCommand('10.20.0', 1775000000000)
-export class CreateTaskTableFastInstanceCommand implements FastInstanceCommand {
- public async up(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('CREATE TABLE "core"."task" ("id" uuid NOT NULL DEFAULT uuid_generate_v4(), "name" varchar NOT NULL)');
- await queryRunner.query('ALTER TABLE "core"."task" ADD CONSTRAINT "PK_task" PRIMARY KEY ("id")');
- }
-
- public async down(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('DROP TABLE "core"."task"');
- await queryRunner.query('ALTER TABLE "core"."task" DROP CONSTRAINT "PK_task"');
- }
-}
-",
-}
-`;
-
-exports[`InstanceCommandGenerationService should generate a migration with query parameters 1`] = `
-{
- "className": "SeedSettingFastInstanceCommand",
- "fileName": "10-20-instance-command-fast-1775000000000-seed-setting.ts",
- "fileTemplate": "import { QueryRunner } from 'typeorm';
-
-import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
-import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';
-
-@RegisteredInstanceCommand('10.20.0', 1775000000000)
-export class SeedSettingFastInstanceCommand implements FastInstanceCommand {
- public async up(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('INSERT INTO "core"."setting" ("key", "value") VALUES ($1, $2)', ["theme","dark"]);
- }
-
- public async down(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('DELETE FROM "core"."setting" WHERE "key" = $1', ["theme"]);
- }
-}
-",
-}
-`;
-
-exports[`InstanceCommandGenerationService should generate a slow instance command with populated up/down 1`] = `
-{
- "className": "MakeColumnNotNullableSlowInstanceCommand",
- "fileName": "10-20-instance-command-slow-1775000000000-make-column-not-nullable.ts",
- "fileTemplate": "import { DataSource, QueryRunner } from 'typeorm';
-
-import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
-import { SlowInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/slow-instance-command.interface';
-
-@RegisteredInstanceCommand('10.20.0', 1775000000000, { type: 'slow' })
-export class MakeColumnNotNullableSlowInstanceCommand implements SlowInstanceCommand {
- async runDataMigration(dataSource: DataSource): Promise<void> {
- // TODO: implement data backfill before the DDL migration
- }
-
- public async up(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('ALTER TABLE "core"."user" ALTER COLUMN "email" SET NOT NULL');
- }
-
- public async down(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('ALTER TABLE "core"."user" ALTER COLUMN "email" DROP NOT NULL');
- }
-}
-",
-}
-`;
-
-exports[`InstanceCommandGenerationService should use default migration name in class and file names 1`] = `
-{
- "className": "AutoGeneratedFastInstanceCommand",
- "fileName": "10-20-instance-command-fast-1775000000000-auto-generated.ts",
- "fileTemplate": "import { QueryRunner } from 'typeorm';
-
-import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
-import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';
-
-@RegisteredInstanceCommand('10.20.0', 1775000000000)
-export class AutoGeneratedFastInstanceCommand implements FastInstanceCommand {
- public async up(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('ALTER TABLE "core"."user" ADD "bar" integer');
- }
-
- public async down(queryRunner: QueryRunner): Promise<void> {
- await queryRunner.query('ALTER TABLE "core"."user" DROP COLUMN "bar"');
- }
-}
-",
-}
-`;
diff --git a/packages/twenty-server/src/database/commands/__tests__/instance-command-generation.service.spec.ts b/packages/twenty-server/src/database/commands/__tests__/instance-command-generation.service.spec.ts
deleted file mode 100644
index 813181e13ac..00000000000
--- a/packages/twenty-server/src/database/commands/__tests__/instance-command-generation.service.spec.ts
+++ /dev/null
@@ -1,242 +0,0 @@
-import { Test } from '@nestjs/testing';
-import { getDataSourceToken } from '@nestjs/typeorm';
-
-import { InstanceCommandGenerationService } from 'src/database/commands/instance-command-generation.service';
-import { type TwentyAllVersion } from 'src/engine/core-modules/upgrade/constants/twenty-all-versions.constant';
-
-const VERSION_A = '10.20.0' as TwentyAllVersion;
-const VERSION_B = '30.40.0' as TwentyAllVersion;
-
-const FIXED_TIMESTAMP = 1775000000000;
-
-const buildMockDataSource = (
- upQueries: { query: string; parameters?: unknown[] }[],
- downQueries: { query: string; parameters?: unknown[] }[],
-) => ({
- driver: {
- createSchemaBuilder: () => ({
- log: jest.fn().mockResolvedValue({ upQueries, downQueries }),
- }),
- },
-});
-
-describe('InstanceCommandGenerationService', () => {
- const buildService = async (
- upQueries: { query: string; parameters?: unknown[] }[] = [],
- downQueries: { query: string; parameters?: unknown[] }[] = [],
- ) => {
- const module = await Test.createTestingModule({
- providers: [
- InstanceCommandGenerationService,
- {
- provide: getDataSourceToken(),
- useValue: buildMockDataSource(upQueries, downQueries),
- },
- ],
- }).compile();
-
- return module.get(InstanceCommandGenerationService);
- };
-
- it('should return null when no schema changes are detected', async () => {
- const service = await buildService();
-
- const result = await service.generateInstanceCommand({
- migrationName: 'no-changes',
- version: VERSION_A,
- timestamp: FIXED_TIMESTAMP,
- });
-
- expect(result).toBeNull();
- });
-
- it('should generate a migration with a single up/down query', async () => {
- const service = await buildService(
- [{ query: 'ALTER TABLE "core"."user" ADD "foo" varchar' }],
- [{ query: 'ALTER TABLE "core"."user" DROP COLUMN "foo"' }],
- );
-
- const result = await service.generateInstanceCommand({
- migrationName: 'add-foo-column',
- version: VERSION_A,
- timestamp: FIXED_TIMESTAMP,
- });
-
- expect(result).toMatchSnapshot();
- });
-
- it('should generate a migration with multiple queries', async () => {
- const service = await buildService(
- [
- {
- query:
- 'CREATE TABLE "core"."task" ("id" uuid NOT NULL DEFAULT uuid_generate_v4(), "name" varchar NOT NULL)',
- },
- {
- query:
- 'ALTER TABLE "core"."task" ADD CONSTRAINT "PK_task" PRIMARY KEY ("id")',
- },
- ],
- [
- { query: 'ALTER TABLE "core"."task" DROP CONSTRAINT "PK_task"' },
- { query: 'DROP TABLE "core"."task"' },
- ],
- );
-
- const result = await service.generateInstanceCommand({
- migrationName: 'create-task-table',
- version: VERSION_A,
- timestamp: FIXED_TIMESTAMP,
- });
-
- expect(result).toMatchSnapshot();
- });
-
- it('should generate a migration with query parameters', async () => {
- const service = await buildService(
- [
- {
- query:
- 'INSERT INTO "core"."setting" ("key", "value") VALUES ($1, $2)',
- parameters: ['theme', 'dark'],
- },
- ],
- [
- {
- query: 'DELETE FROM "core"."setting" WHERE "key" = $1',
- parameters: ['theme'],
- },
- ],
- );
-
- const result = await service.generateInstanceCommand({
- migrationName: 'seed-setting',
- version: VERSION_A,
- timestamp: FIXED_TIMESTAMP,
- });
-
- expect(result).toMatchSnapshot();
- });
-
- it('should escape single quotes in SQL queries', async () => {
- const service = await buildService(
- [{ query: 'UPDATE "core"."config" SET "value" = \'it\'\'s done\'' }],
- [{ query: 'UPDATE "core"."config" SET "value" = \'original\'' }],
- );
-
- const result = await service.generateInstanceCommand({
- migrationName: 'update-config',
- version: VERSION_A,
- timestamp: FIXED_TIMESTAMP,
- });
-
- expect(result).toMatchSnapshot();
- });
-
- it('should escape backslashes in SQL queries', async () => {
- const service = await buildService(
- [
- {
- query: 'UPDATE "core"."config" SET "value" = E\'path\\\\to\\\\file\'',
- },
- ],
- [{ query: 'UPDATE "core"."config" SET "value" = NULL' }],
- );
-
- const result = await service.generateInstanceCommand({
- migrationName: 'update-path',
- version: VERSION_A,
- timestamp: FIXED_TIMESTAMP,
- });
-
- expect(result).toMatchSnapshot();
- });
-
- it('should use default migration name in class and file names', async () => {
- const service = await buildService(
- [{ query: 'ALTER TABLE "core"."user" ADD "bar" integer' }],
- [{ query: 'ALTER TABLE "core"."user" DROP COLUMN "bar"' }],
- );
-
- const result = await service.generateInstanceCommand({
- migrationName: 'auto-generated',
- version: VERSION_A,
- timestamp: FIXED_TIMESTAMP,
- });
-
- expect(result).toMatchSnapshot();
- });
-
- it('should encode version correctly in file and class names', async () => {
- const service = await buildService(
- [{ query: 'SELECT 1' }],
- [{ query: 'SELECT 1' }],
- );
-
- const result = await service.generateInstanceCommand({
- migrationName: 'test',
- version: VERSION_B,
- timestamp: FIXED_TIMESTAMP,
- });
-
- expect(result).toMatchSnapshot();
- });
-
- it('should return null for slow type when no schema changes are detected', async () => {
- const service = await buildService();
-
- const result = await service.generateInstanceCommand({
- migrationName: 'no-changes',
- version: VERSION_A,
- timestamp: FIXED_TIMESTAMP,
- type: 'slow',
- });
-
- expect(result).toBeNull();
- });
-
- it('should generate a slow instance command with populated up/down', async () => {
- const service = await buildService(
- [
- {
- query: 'ALTER TABLE "core"."user" ALTER COLUMN "email" SET NOT NULL',
- },
- ],
- [
- {
- query: 'ALTER TABLE "core"."user" ALTER COLUMN "email" DROP NOT NULL',
- },
- ],
- );
-
- const result = await service.generateInstanceCommand({
- migrationName: 'make-column-not-nullable',
- version: VERSION_A,
- timestamp: FIXED_TIMESTAMP,
- type: 'slow',
- });
-
- expect(result).toMatchSnapshot();
- });
-
- it('should use correct file naming for slow instance commands', async () => {
- const service = await buildService(
- [{ query: 'SELECT 1' }],
- [{ query: 'SELECT 1' }],
- );
-
- const result = await service.generateInstanceCommand({
- migrationName: 'backfill-data',
- version: VERSION_B,
- timestamp: FIXED_TIMESTAMP,
- type: 'slow',
- });
-
- const versionSlug = VERSION_B.split('.').slice(0, 2).join('-');
-
- expect(result?.fileName).toBe(
- `${versionSlug}-instance-command-slow-${FIXED_TIMESTAMP}-backfill-data.ts`,
- );
- expect(result?.className).toBe('BackfillDataSlowInstanceCommand');
- });
-});
diff --git a/packages/twenty-server/src/database/commands/command-runners/__tests__/command-shutdown.service.spec.ts b/packages/twenty-server/src/database/commands/command-runners/__tests__/command-shutdown.service.spec.ts
deleted file mode 100644
index ad4b9775e01..00000000000
--- a/packages/twenty-server/src/database/commands/command-runners/__tests__/command-shutdown.service.spec.ts
+++ /dev/null
@@ -1,98 +0,0 @@
-import { CommandShutdownService } from 'src/database/commands/command-runners/command-shutdown.service';
-
-describe('CommandShutdownService', () => {
- let service: CommandShutdownService;
- let exitSpy: jest.SpyInstance;
- let signalListeners: Map<string, () => void>;
- const initialExitCode = process.exitCode;
-
- beforeEach(() => {
- service = new CommandShutdownService();
- signalListeners = new Map();
-
- exitSpy = jest.spyOn(process, 'exit').mockImplementation((() => {
- // oxlint-disable-next-line typescript/no-explicit-any
- }) as any);
-
- jest
- .spyOn(process, 'on')
- .mockImplementation((event: string | symbol, listener) => {
- signalListeners.set(String(event), listener as () => void);
-
- return process;
- });
- });
-
- afterEach(() => {
- jest.restoreAllMocks();
- process.exitCode = initialExitCode;
- });
-
- it('should not install listeners until it is asked to listen', () => {
- expect(process.on).not.toHaveBeenCalled();
-
- service.listenToShutdownSignals();
-
- expect(process.on).toHaveBeenCalledWith('SIGINT', expect.any(Function));
- expect(process.on).toHaveBeenCalledWith('SIGTERM', expect.any(Function));
- });
-
- it('should install listeners only once', () => {
- service.listenToShutdownSignals();
- service.listenToShutdownSignals();
-
- const registrationsBySignal = (process.on as jest.Mock).mock.calls.reduce<
- Record<string, number>
- >((accumulator, [event]) => {
- accumulator[String(event)] = (accumulator[String(event)] ?? 0) + 1;
-
- return accumulator;
- }, {});
-
- expect(registrationsBySignal).toEqual({ SIGINT: 1, SIGTERM: 1 });
- });
-
- it('should not report a shutdown before any signal is received', () => {
- service.listenToShutdownSignals();
-
- expect(service.isShutdownRequested()).toBe(false);
- });
-
- it('should request a graceful shutdown on the first SIGINT', () => {
- service.listenToShutdownSignals();
-
- signalListeners.get('SIGINT')?.();
-
- expect(service.isShutdownRequested()).toBe(true);
- expect(process.exitCode).toBe(130);
- expect(exitSpy).not.toHaveBeenCalled();
- });
-
- it('should force an immediate exit on the second SIGINT', () => {
- service.listenToShutdownSignals();
-
- signalListeners.get('SIGINT')?.();
- signalListeners.get('SIGINT')?.();
-
- expect(exitSpy).toHaveBeenCalledWith(130);
- });
-
- it('should use the SIGTERM exit code on SIGTERM', () => {
- service.listenToShutdownSignals();
-
- signalListeners.get('SIGTERM')?.();
-
- expect(service.isShutdownRequested()).toBe(true);
- expect(process.exitCode).toBe(143);
- expect(exitSpy).not.toHaveBeenCalled();
- });
-
- it('should force an immediate exit when a second signal of another kind arrives', () => {
- service.listenToShutdownSignals();
-
- signalListeners.get('SIGTERM')?.();
- signalListeners.get('SIGINT')?.();
-
- expect(exitSpy).toHaveBeenCalledWith(130);
- });
-});
diff --git a/packages/twenty-server/src/database/typeorm/postgres-advisory-lock.service.spec.ts b/packages/twenty-server/src/database/typeorm/postgres-advisory-lock.service.spec.ts
deleted file mode 100644
index 488ff620c5b..00000000000
--- a/packages/twenty-server/src/database/typeorm/postgres-advisory-lock.service.spec.ts
+++ /dev/null
@@ -1,212 +0,0 @@
-import { Logger } from '@nestjs/common';
-
-import { type PoolClient } from 'pg';
-import { type DataSource } from 'typeorm';
-import { type PostgresDriver } from 'typeorm/driver/postgres/PostgresDriver';
-
-import { PostgresAdvisoryLockService } from 'src/database/typeorm/postgres-advisory-lock.service';
-
-describe('PostgresAdvisoryLockService', () => {
- const obtainMasterConnection = jest.fn();
- const dataSource = {
- driver: {
- obtainMasterConnection,
- } as unknown as PostgresDriver,
- } as unknown as DataSource;
-
- const createMockConnection = (isLockAcquired: boolean) => {
- let connectionErrorHandler: ((error: Error) => void) | undefined;
- const query = jest
- .fn()
- .mockResolvedValueOnce({
- rows: [{ acquired: isLockAcquired }],
- })
- .mockResolvedValueOnce({
- rows: [{ released: true }],
- });
- const connection = {
- query,
- on: jest.fn((_eventName: string, handler: (error: Error) => void) => {
- connectionErrorHandler = handler;
- }),
- removeListener: jest.fn(),
- } as unknown as PoolClient;
- const release = jest.fn();
-
- return {
- connection,
- emitConnectionError: (error: Error) => connectionErrorHandler?.(error),
- query,
- release,
- };
- };
-
- let loggerWarn: jest.SpyInstance;
-
- beforeEach(() => {
- jest.clearAllMocks();
- loggerWarn = jest.spyOn(Logger.prototype, 'warn').mockImplementation();
- });
-
- afterEach(() => {
- loggerWarn.mockRestore();
- });
-
- it('runs the callback while holding the lock', async () => {
- const { connection, query, release } = createMockConnection(true);
- const callback = jest.fn().mockResolvedValue('result');
-
- obtainMasterConnection.mockResolvedValue([connection, release]);
-
- const result = await new PostgresAdvisoryLockService(
- dataSource,
- ).tryWithLock('lock-name', callback);
-
- expect(result).toEqual({
- acquired: true,
- value: 'result',
- });
- expect(callback).toHaveBeenCalledTimes(1);
- expect(query).toHaveBeenCalledTimes(2);
- expect(query).toHaveBeenNthCalledWith(
- 2,
- expect.stringContaining('pg_advisory_unlock'),
- ['lock-name'],
- );
- expect(query.mock.invocationCallOrder[1]).toBeLessThan(
- release.mock.invocationCallOrder[0],
- );
- });
-
- it('does not run the callback when the lock is held', async () => {
- const { connection, query, release } = createMockConnection(false);
- const callback = jest.fn();
-
- obtainMasterConnection.mockResolvedValue([connection, release]);
-
- await expect(
- new PostgresAdvisoryLockService(dataSource).tryWithLock(
- 'lock-name',
- callback,
- ),
- ).resolves.toEqual({
- acquired: false,
- });
-
- expect(callback).not.toHaveBeenCalled();
- expect(query).toHaveBeenCalledTimes(1);
- expect(release).toHaveBeenCalledTimes(1);
- });
-
- it('discards the connection when acquiring the lock fails', async () => {
- const { connection, query, release } = createMockConnection(true);
- const callback = jest.fn();
- const acquisitionError = new Error('acquisition failed');
-
- query.mockReset().mockRejectedValueOnce(acquisitionError);
- obtainMasterConnection.mockResolvedValue([connection, release]);
-
- await expect(
- new PostgresAdvisoryLockService(dataSource).tryWithLock(
- 'lock-name',
- callback,
- ),
- ).rejects.toBe(acquisitionError);
-
- expect(callback).not.toHaveBeenCalled();
- expect(release).toHaveBeenCalledWith(acquisitionError);
- });
-
- it('releases the lock when the callback fails', async () => {
- const { connection, query, release } = createMockConnection(true);
- const callbackError = new Error('callback failed');
-
- obtainMasterConnection.mockResolvedValue([connection, release]);
-
- await expect(
- new PostgresAdvisoryLockService(dataSource).tryWithLock(
- 'lock-name',
- async () => {
- throw callbackError;
- },
- ),
- ).rejects.toBe(callbackError);
-
- expect(query).toHaveBeenCalledTimes(2);
- expect(release).toHaveBeenCalledWith();
- });
-
- it('discards the connection when releasing the lock fails', async () => {
- const { connection, query, release } = createMockConnection(true);
- const releaseError = new Error('release failed');
-
- query
- .mockReset()
- .mockResolvedValueOnce({
- rows: [{ acquired: true }],
- })
- .mockRejectedValueOnce(releaseError);
- obtainMasterConnection.mockResolvedValue([connection, release]);
-
- await expect(
- new PostgresAdvisoryLockService(dataSource).tryWithLock(
- 'lock-name',
- async () => undefined,
- ),
- ).rejects.toBe(releaseError);
-
- expect(release).toHaveBeenCalledWith(releaseError);
- });
-
- it('preserves the callback error when the connection fails', async () => {
- const { connection, emitConnectionError, release } =
- createMockConnection(true);
- const callbackError = new Error('callback failed');
- const connectionError = new Error('connection failed');
-
- obtainMasterConnection.mockResolvedValue([connection, release]);
-
- await expect(
- new PostgresAdvisoryLockService(dataSource).tryWithLock(
- 'lock-name',
- async () => {
- emitConnectionError(connectionError);
- throw callbackError;
- },
- ),
- ).rejects.toBe(callbackError);
-
- expect(release).toHaveBeenCalledWith(connectionError);
- expect(loggerWarn).toHaveBeenCalledWith(
- expect.stringContaining(connectionError.message),
- );
- });
-
- it('preserves the callback error when releasing the lock fails', async () => {
- const { connection, query, release } = createMockConnection(true);
- const callbackError = new Error('callback failed');
- const releaseError = new Error('release failed');
-
- query
- .mockReset()
- .mockResolvedValueOnce({
- rows: [{ acquired: true }],
- })
- .mockRejectedValueOnce(releaseError);
- obtainMasterConnection.mockResolvedValue([connection, release]);
-
- await expect(
- new PostgresAdvisoryLockService(dataSource).tryWithLock(
- 'lock-name',
- async () => {
- throw callbackError;
- },
- ),
- ).rejects.toBe(callbackError);
-
- expect(release).toHaveBeenCalledWith(releaseError);
- expect(loggerWarn).toHaveBeenCalledWith(
- expect.stringContaining(releaseError.message),
- );
- });
-});
diff --git a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/__snapshots__/data-arg-processor.service.spec.ts.snap b/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/__snapshots__/data-arg-processor.service.spec.ts.snap
deleted file mode 100644
index 94f262899c2..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/__snapshots__/data-arg-processor.service.spec.ts.snap
+++ /dev/null
@@ -1,207 +0,0 @@
-// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
-
-exports[`DataArgProcessorService failing inputs validation ADDRESS should throw for invalid input #1: "not-an-address" 1`] = `"Invalid object value 'not-an-address' for field "addressField""`;
-
-exports[`DataArgProcessorService failing inputs validation ADDRESS should throw for invalid input #2: 1 1`] = `"Invalid object value 1 for field "addressField""`;
-
-exports[`DataArgProcessorService failing inputs validation ADDRESS should throw for invalid input #3: true 1`] = `"Invalid object value true for field "addressField""`;
-
-exports[`DataArgProcessorService failing inputs validation ARRAY should throw for invalid input #1: true 1`] = `"Invalid value true for field "arrayField - Array values need to be string""`;
-
-exports[`DataArgProcessorService failing inputs validation ARRAY should throw for invalid input #2: 1 1`] = `"Invalid value 1 for field "arrayField - Array values need to be string""`;
-
-exports[`DataArgProcessorService failing inputs validation BOOLEAN should throw for invalid input #1: {} 1`] = `"Invalid boolean value {} for field "booleanField""`;
-
-exports[`DataArgProcessorService failing inputs validation BOOLEAN should throw for invalid input #2: [] 1`] = `"Invalid boolean value [] for field "booleanField""`;
-
-exports[`DataArgProcessorService failing inputs validation BOOLEAN should throw for invalid input #3: "string" 1`] = `"Invalid boolean value 'string' for field "booleanField""`;
-
-exports[`DataArgProcessorService failing inputs validation BOOLEAN should throw for invalid input #4: 1 1`] = `"Invalid boolean value 1 for field "booleanField""`;
-
-exports[`DataArgProcessorService failing inputs validation CURRENCY should throw for invalid input #1: "not-a-currency" 1`] = `"Invalid object value 'not-a-currency' for field "currencyField""`;
-
-exports[`DataArgProcessorService failing inputs validation CURRENCY should throw for invalid input #2: 1 1`] = `"Invalid object value 1 for field "currencyField""`;
-
-exports[`DataArgProcessorService failing inputs validation CURRENCY should throw for invalid input #3: true 1`] = `"Invalid object value true for field "currencyField""`;
-
-exports[`DataArgProcessorService failing inputs validation DATE should throw for invalid input #1: "malformed-date" 1`] = `"Invalid value 'malformed-date' for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE should throw for invalid input #2: {} 1`] = `"Invalid value {} for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE should throw for invalid input #3: [] 1`] = `"Invalid value [] for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE should throw for invalid input #4: true 1`] = `"Invalid value true for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE should throw for invalid input #5: 1 1`] = `"Invalid value 1 for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE should throw for invalid input #6: "2024" 1`] = `"Invalid value '2024' for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE should throw for invalid input #7: "2024-01" 1`] = `"Invalid value '2024-01' for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE should throw for invalid input #8: "2024-13-01" 1`] = `"Invalid value '2024-13-01' for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE should throw for invalid input #9: "2024-02-31" 1`] = `"Invalid value '2024-02-31' for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE_TIME should throw for invalid input #1: "malformed-date" 1`] = `"Invalid value 'malformed-date' for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE_TIME should throw for invalid input #2: {} 1`] = `"Invalid value {} for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE_TIME should throw for invalid input #3: [] 1`] = `"Invalid value [] for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE_TIME should throw for invalid input #4: true 1`] = `"Invalid value true for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE_TIME should throw for invalid input #5: 1 1`] = `"Invalid value 1 for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE_TIME should throw for invalid input #6: "2024" 1`] = `"Invalid value '2024' for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE_TIME should throw for invalid input #7: "2024-01" 1`] = `"Invalid value '2024-01' for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE_TIME should throw for invalid input #8: "2024-13-01T10:30:00Z" 1`] = `"Invalid value '2024-13-01T10:30:00Z' for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`DataArgProcessorService failing inputs validation DATE_TIME should throw for invalid input #9: "2024-01-15T25:30:00Z" 1`] = `"Invalid value '2024-01-15T25:30:00Z' for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`DataArgProcessorService failing inputs validation EMAILS should throw for invalid input #1: "not-an-email" 1`] = `"Invalid object value 'not-an-email' for field "emailsField""`;
-
-exports[`DataArgProcessorService failing inputs validation EMAILS should throw for invalid input #2: {"primaryEmail":"not-an-email"} 1`] = `"Invalid string value 'not-an-email' for email field "emailsField.primaryEmail""`;
-
-exports[`DataArgProcessorService failing inputs validation EMAILS should throw for invalid input #3: {"additionalEmails":"not-an-email"} 1`] = `"Invalid string value 'not-an-email' for email field "emailsField.additionalEmails""`;
-
-exports[`DataArgProcessorService failing inputs validation EMAILS should throw for invalid input #4: {"additionalEmails":["not-an-email"]} 1`] = `"Invalid string value 'not-an-email' for email field "emailsField.additionalEmails""`;
-
-exports[`DataArgProcessorService failing inputs validation EMAILS should throw for invalid input #5: {"primaryEmail":"[email protected]","additionalEmails":["not-an-email"]} 1`] = `"Invalid string value 'not-an-email' for email field "emailsField.additionalEmails""`;
-
-exports[`DataArgProcessorService failing inputs validation EMAILS should throw for invalid input #6: {"primaryEmail":"not-an-email","additionalEmails":["[email protected]"]} 1`] = `"Invalid string value 'not-an-email' for email field "emailsField.primaryEmail""`;
-
-exports[`DataArgProcessorService failing inputs validation EMAILS should throw for invalid input #7: {"additionalEmails":["not-an-email","[email protected]"]} 1`] = `"Invalid string value 'not-an-email' for email field "emailsField.additionalEmails""`;
-
-exports[`DataArgProcessorService failing inputs validation FILES should throw for invalid input #1: "not-an-addFiles-property" 1`] = `"Invalid value "'not-an-addFiles-property'" for FILES field "filesField" - It should be an array of objects with "fileId" and "label" properties."`;
-
-exports[`DataArgProcessorService failing inputs validation FILES should throw for invalid input #2: {"addFiles":[{"invalidField":"test"}]} 1`] = `"Invalid value "{ addFiles: [ { invalidField: 'test' } ] }" for FILES field "filesField" - : Invalid input: expected array, received object"`;
-
-exports[`DataArgProcessorService failing inputs validation FILES should throw for invalid input #3: {"addFiles":[{"fileId":"not-a-uuid","label":"Doc.pdf"}]} 1`] = `"Invalid value "{ addFiles: [ { fileId: 'not-a-uuid', label: 'Doc.pdf' } ] }" for FILES field "filesField" - : Invalid input: expected array, received object"`;
-
-exports[`DataArgProcessorService failing inputs validation FILES should throw for invalid input #4: [{"addFiles":[{"fileId":"550e8400-e29b-41d4-a716-446655440000","label":12345}]}] 1`] = `"Invalid value "[ { addFiles: [ [Object] ] } ]" for FILES field "filesField" - 0.fileId: Invalid input: expected string, received undefined, 0.label: Invalid input: expected string, received undefined, 0: Unrecognized key: "addFiles""`;
-
-exports[`DataArgProcessorService failing inputs validation FILES should throw for invalid input #5: {"addFiles":[{"fileId":"550e8400-e29b-41d4-a716-446655440000","label":"Document.pdf","extension":"not-allowed-in-input"}]} 1`] = `
-"Invalid value "{
- addFiles: [
- {
- fileId: '550e8400-e29b-41d4-a716-446655440000',
- label: 'Document.pdf',
- extension: 'not-allowed-in-input'
- }
- ]
-}" for FILES field "filesField" - : Invalid input: expected array, received object"
-`;
-
-exports[`DataArgProcessorService failing inputs validation FULL_NAME should throw for invalid input #1: "not-a-full-name" 1`] = `"Invalid object value 'not-a-full-name' for field "fullNameField""`;
-
-exports[`DataArgProcessorService failing inputs validation FULL_NAME should throw for invalid input #2: 1 1`] = `"Invalid object value 1 for field "fullNameField""`;
-
-exports[`DataArgProcessorService failing inputs validation FULL_NAME should throw for invalid input #3: true 1`] = `"Invalid object value true for field "fullNameField""`;
-
-exports[`DataArgProcessorService failing inputs validation LINKS should throw for invalid input #1: "not-a-link" 1`] = `"Invalid object value 'not-a-link' for field "linksField""`;
-
-exports[`DataArgProcessorService failing inputs validation LINKS should throw for invalid input #2: 1 1`] = `"Invalid object value 1 for field "linksField""`;
-
-exports[`DataArgProcessorService failing inputs validation LINKS should throw for invalid input #3: true 1`] = `"Invalid object value true for field "linksField""`;
-
-exports[`DataArgProcessorService failing inputs validation MORPH_RELATION should throw for invalid input #1: "not-a-morph-relation" 1`] = `"Invalid UUID value 'not-a-morph-relation' for field "manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id""`;
-
-exports[`DataArgProcessorService failing inputs validation MORPH_RELATION should throw for invalid input #2: {} 1`] = `"Invalid UUID value {} for field "manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id""`;
-
-exports[`DataArgProcessorService failing inputs validation MORPH_RELATION should throw for invalid input #3: [] 1`] = `"Invalid UUID value [] for field "manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id""`;
-
-exports[`DataArgProcessorService failing inputs validation MORPH_RELATION should throw for invalid input #4: true 1`] = `"Invalid UUID value true for field "manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id""`;
-
-exports[`DataArgProcessorService failing inputs validation MORPH_RELATION should throw for invalid input #5: 1 1`] = `"Invalid UUID value 1 for field "manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id""`;
-
-exports[`DataArgProcessorService failing inputs validation MULTI_SELECT should throw for invalid input #1: "not-a-select-option" 1`] = `"Invalid value 'not-a-select-option' for multi select field "multiSelectField""`;
-
-exports[`DataArgProcessorService failing inputs validation MULTI_SELECT should throw for invalid input #2: {} 1`] = `"Invalid value {} for field "multiSelectField - Array values need to be string""`;
-
-exports[`DataArgProcessorService failing inputs validation MULTI_SELECT should throw for invalid input #3: true 1`] = `"Invalid value true for field "multiSelectField - Array values need to be string""`;
-
-exports[`DataArgProcessorService failing inputs validation MULTI_SELECT should throw for invalid input #4: 1 1`] = `"Invalid value 1 for field "multiSelectField - Array values need to be string""`;
-
-exports[`DataArgProcessorService failing inputs validation NUMBER should throw for invalid input #1: {} 1`] = `"Invalid number value {} for field "numberField""`;
-
-exports[`DataArgProcessorService failing inputs validation NUMBER should throw for invalid input #2: [] 1`] = `"Invalid number value [] for field "numberField""`;
-
-exports[`DataArgProcessorService failing inputs validation NUMBER should throw for invalid input #3: true 1`] = `"Invalid number value true for field "numberField""`;
-
-exports[`DataArgProcessorService failing inputs validation NUMBER should throw for invalid input #4: "string" 1`] = `"Invalid number value 'string' for field "numberField""`;
-
-exports[`DataArgProcessorService failing inputs validation NUMERIC should throw for invalid input #1: {} 1`] = `"Invalid number value NaN for field "numericField""`;
-
-exports[`DataArgProcessorService failing inputs validation NUMERIC should throw for invalid input #2: "not-a-number" 1`] = `"Invalid number value NaN for field "numericField""`;
-
-exports[`DataArgProcessorService failing inputs validation PHONES should throw for invalid input #1: "not-a-phone" 1`] = `"Invalid object value 'not-a-phone' for field "phonesField""`;
-
-exports[`DataArgProcessorService failing inputs validation PHONES should throw for invalid input #2: 1 1`] = `"Invalid object value 1 for field "phonesField""`;
-
-exports[`DataArgProcessorService failing inputs validation PHONES should throw for invalid input #3: true 1`] = `"Invalid object value true for field "phonesField""`;
-
-exports[`DataArgProcessorService failing inputs validation POSITION should throw for invalid input #1: "not-a-position" 1`] = `"Invalid position value 'not-a-position' for field "position""`;
-
-exports[`DataArgProcessorService failing inputs validation POSITION should throw for invalid input #2: null 1`] = `"Invalid position value NaN for field "position""`;
-
-exports[`DataArgProcessorService failing inputs validation POSITION should throw for invalid input #3: {} 1`] = `"Invalid position value {} for field "position""`;
-
-exports[`DataArgProcessorService failing inputs validation POSITION should throw for invalid input #4: [] 1`] = `"Invalid position value [] for field "position""`;
-
-exports[`DataArgProcessorService failing inputs validation RATING should throw for invalid input #1: "not-a-rating" 1`] = `"Invalid value "not-a-rating" for field "ratingField". Valid values are: RATING_1, RATING_2, RATING_3, RATING_4, RATING_5"`;
-
-exports[`DataArgProcessorService failing inputs validation RATING should throw for invalid input #2: {} 1`] = `"Invalid string value {} for text field "ratingField""`;
-
-exports[`DataArgProcessorService failing inputs validation RATING should throw for invalid input #3: [] 1`] = `"Invalid string value [] for text field "ratingField""`;
-
-exports[`DataArgProcessorService failing inputs validation RATING should throw for invalid input #4: true 1`] = `"Invalid string value true for text field "ratingField""`;
-
-exports[`DataArgProcessorService failing inputs validation RATING should throw for invalid input #5: 1 1`] = `"Invalid string value 1 for text field "ratingField""`;
-
-exports[`DataArgProcessorService failing inputs validation RAW_JSON should throw for invalid input #1: "not-a-json" 1`] = `"Invalid object value 'not-a-json' for field "rawJsonField""`;
-
-exports[`DataArgProcessorService failing inputs validation RELATION should throw for invalid input #1: {} 1`] = `"Invalid UUID value {} for field "manyToOneRelationFieldId""`;
-
-exports[`DataArgProcessorService failing inputs validation RELATION should throw for invalid input #2: [] 1`] = `"Invalid UUID value [] for field "manyToOneRelationFieldId""`;
-
-exports[`DataArgProcessorService failing inputs validation RELATION should throw for invalid input #3: true 1`] = `"Invalid UUID value true for field "manyToOneRelationFieldId""`;
-
-exports[`DataArgProcessorService failing inputs validation RELATION should throw for invalid input #4: 1 1`] = `"Invalid UUID value 1 for field "manyToOneRelationFieldId""`;
-
-exports[`DataArgProcessorService failing inputs validation RELATION should throw for invalid input #5: "non-uuid" 1`] = `"Invalid UUID value 'non-uuid' for field "manyToOneRelationFieldId""`;
-
-exports[`DataArgProcessorService failing inputs validation RICH_TEXT should throw for invalid input #1: "not-a-rich-text" 1`] = `"Invalid object value 'not-a-rich-text' for field "richTextField""`;
-
-exports[`DataArgProcessorService failing inputs validation RICH_TEXT should throw for invalid input #2: 1 1`] = `"Invalid object value 1 for field "richTextField""`;
-
-exports[`DataArgProcessorService failing inputs validation RICH_TEXT should throw for invalid input #3: true 1`] = `"Invalid object value true for field "richTextField""`;
-
-exports[`DataArgProcessorService failing inputs validation SELECT should throw for invalid input #1: "not-a-select-option" 1`] = `"Invalid value "not-a-select-option" for field "selectField". Valid values are: OPTION_1, OPTION_2"`;
-
-exports[`DataArgProcessorService failing inputs validation SELECT should throw for invalid input #2: {} 1`] = `"Invalid string value {} for text field "selectField""`;
-
-exports[`DataArgProcessorService failing inputs validation SELECT should throw for invalid input #3: [] 1`] = `"Invalid string value [] for text field "selectField""`;
-
-exports[`DataArgProcessorService failing inputs validation SELECT should throw for invalid input #4: true 1`] = `"Invalid string value true for text field "selectField""`;
-
-exports[`DataArgProcessorService failing inputs validation SELECT should throw for invalid input #5: 1 1`] = `"Invalid string value 1 for text field "selectField""`;
-
-exports[`DataArgProcessorService failing inputs validation TEXT should throw for invalid input #1: {} 1`] = `"Invalid string value {} for text field "textField""`;
-
-exports[`DataArgProcessorService failing inputs validation TEXT should throw for invalid input #2: [] 1`] = `"Invalid string value [] for text field "textField""`;
-
-exports[`DataArgProcessorService failing inputs validation TEXT should throw for invalid input #3: true 1`] = `"Invalid string value true for text field "textField""`;
-
-exports[`DataArgProcessorService failing inputs validation TEXT should throw for invalid input #4: 1 1`] = `"Invalid string value 1 for text field "textField""`;
-
-exports[`DataArgProcessorService failing inputs validation UUID should throw for invalid input #1: {} 1`] = `"Invalid UUID value {} for field "uuidField""`;
-
-exports[`DataArgProcessorService failing inputs validation UUID should throw for invalid input #2: [] 1`] = `"Invalid UUID value [] for field "uuidField""`;
-
-exports[`DataArgProcessorService failing inputs validation UUID should throw for invalid input #3: true 1`] = `"Invalid UUID value true for field "uuidField""`;
-
-exports[`DataArgProcessorService failing inputs validation UUID should throw for invalid input #4: 1 1`] = `"Invalid UUID value 1 for field "uuidField""`;
-
-exports[`DataArgProcessorService failing inputs validation UUID should throw for invalid input #5: "non-uuid" 1`] = `"Invalid UUID value 'non-uuid' for field "uuidField""`;
diff --git a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/failing-inputs-by-field-metadata-type.constant.ts b/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/failing-inputs-by-field-metadata-type.constant.ts
deleted file mode 100644
index 6ddeba96444..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/failing-inputs-by-field-metadata-type.constant.ts
+++ /dev/null
@@ -1,201 +0,0 @@
-import { joinColumnNameForManyToOneMorphRelationField1 } from 'test/integration/graphql/suites/inputs-validation/utils/setup-test-objects-with-all-field-types.util';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-export const failingInputsByFieldMetadataType: {
- [K in FieldMetadataType]?: {
- input: Record<string, unknown>;
- }[];
-} = {
- [FieldMetadataType.TEXT]: [
- { input: { textField: {} } },
- { input: { textField: [] } },
- { input: { textField: true } },
- { input: { textField: 1 } },
- ],
- [FieldMetadataType.NUMBER]: [
- { input: { numberField: {} } },
- { input: { numberField: [] } },
- { input: { numberField: true } },
- { input: { numberField: 'string' } },
- ],
- [FieldMetadataType.UUID]: [
- { input: { uuidField: {} } },
- { input: { uuidField: [] } },
- { input: { uuidField: true } },
- { input: { uuidField: 1 } },
- { input: { uuidField: 'non-uuid' } },
- ],
- [FieldMetadataType.SELECT]: [
- { input: { selectField: 'not-a-select-option' } },
- { input: { selectField: {} } },
- { input: { selectField: [] } },
- { input: { selectField: true } },
- { input: { selectField: 1 } },
- ],
- [FieldMetadataType.RELATION]: [
- { input: { manyToOneRelationFieldId: {} } },
- { input: { manyToOneRelationFieldId: [] } },
- { input: { manyToOneRelationFieldId: true } },
- { input: { manyToOneRelationFieldId: 1 } },
- { input: { manyToOneRelationFieldId: 'non-uuid' } },
- ],
- [FieldMetadataType.RAW_JSON]: [{ input: { rawJsonField: 'not-a-json' } }],
- [FieldMetadataType.ARRAY]: [
- { input: { arrayField: true } },
- { input: { arrayField: 1 } },
- ],
- [FieldMetadataType.MORPH_RELATION]: [
- {
- input: {
- [joinColumnNameForManyToOneMorphRelationField1]: 'not-a-morph-relation',
- },
- },
- { input: { [joinColumnNameForManyToOneMorphRelationField1]: {} } },
- { input: { [joinColumnNameForManyToOneMorphRelationField1]: [] } },
- { input: { [joinColumnNameForManyToOneMorphRelationField1]: true } },
- { input: { [joinColumnNameForManyToOneMorphRelationField1]: 1 } },
- ],
- [FieldMetadataType.RATING]: [
- { input: { ratingField: 'not-a-rating' } },
- { input: { ratingField: {} } },
- { input: { ratingField: [] } },
- { input: { ratingField: true } },
- { input: { ratingField: 1 } },
- ],
- [FieldMetadataType.MULTI_SELECT]: [
- { input: { multiSelectField: 'not-a-select-option' } },
- { input: { multiSelectField: {} } },
- { input: { multiSelectField: true } },
- { input: { multiSelectField: 1 } },
- ],
- [FieldMetadataType.DATE]: [
- { input: { dateField: 'malformed-date' } },
- { input: { dateField: {} } },
- { input: { dateField: [] } },
- { input: { dateField: true } },
- { input: { dateField: 1 } },
- { input: { dateField: '2024' } },
- { input: { dateField: '2024-01' } },
- { input: { dateField: '2024-13-01' } },
- { input: { dateField: '2024-02-31' } },
- ],
- [FieldMetadataType.DATE_TIME]: [
- { input: { dateTimeField: 'malformed-date' } },
- { input: { dateTimeField: {} } },
- { input: { dateTimeField: [] } },
- { input: { dateTimeField: true } },
- { input: { dateTimeField: 1 } },
- { input: { dateTimeField: '2024' } },
- { input: { dateTimeField: '2024-01' } },
- { input: { dateTimeField: '2024-13-01T10:30:00Z' } },
- { input: { dateTimeField: '2024-01-15T25:30:00Z' } },
- ],
- [FieldMetadataType.BOOLEAN]: [
- { input: { booleanField: {} } },
- { input: { booleanField: [] } },
- { input: { booleanField: 'string' } },
- { input: { booleanField: 1 } },
- ],
- [FieldMetadataType.ADDRESS]: [
- { input: { addressField: 'not-an-address' } },
- { input: { addressField: 1 } },
- { input: { addressField: true } },
- ],
- [FieldMetadataType.CURRENCY]: [
- { input: { currencyField: 'not-a-currency' } },
- { input: { currencyField: 1 } },
- { input: { currencyField: true } },
- ],
- [FieldMetadataType.EMAILS]: [
- { input: { emailsField: 'not-an-email' } },
- { input: { emailsField: { primaryEmail: 'not-an-email' } } },
- { input: { emailsField: { additionalEmails: 'not-an-email' } } },
- { input: { emailsField: { additionalEmails: ['not-an-email'] } } },
- {
- input: {
- emailsField: {
- primaryEmail: '[email protected]',
- additionalEmails: ['not-an-email'],
- },
- },
- },
- {
- input: {
- emailsField: {
- primaryEmail: 'not-an-email',
- additionalEmails: ['[email protected]'],
- },
- },
- },
- {
- input: {
- emailsField: {
- additionalEmails: ['not-an-email', '[email protected]'],
- },
- },
- },
- ],
- [FieldMetadataType.PHONES]: [
- { input: { phonesField: 'not-a-phone' } },
- { input: { phonesField: 1 } },
- { input: { phonesField: true } },
- ],
- [FieldMetadataType.FULL_NAME]: [
- { input: { fullNameField: 'not-a-full-name' } },
- { input: { fullNameField: 1 } },
- { input: { fullNameField: true } },
- ],
- [FieldMetadataType.LINKS]: [
- { input: { linksField: 'not-a-link' } },
- { input: { linksField: 1 } },
- { input: { linksField: true } },
- ],
- [FieldMetadataType.RICH_TEXT]: [
- { input: { richTextField: 'not-a-rich-text' } },
- { input: { richTextField: 1 } },
- { input: { richTextField: true } },
- ],
- [FieldMetadataType.POSITION]: [
- { input: { position: 'not-a-position' } },
- { input: { position: NaN } },
- { input: { position: {} } },
- { input: { position: [] } },
- ],
- [FieldMetadataType.FILES]: [
- { input: { filesField: 'not-an-addFiles-property' } },
- { input: { filesField: { addFiles: [{ invalidField: 'test' }] } } },
- {
- input: {
- filesField: { addFiles: [{ fileId: 'not-a-uuid', label: 'Doc.pdf' }] },
- },
- },
- {
- input: {
- filesField: [
- {
- addFiles: [
- { fileId: '550e8400-e29b-41d4-a716-446655440000', label: 12345 },
- ],
- },
- ],
- },
- },
- {
- input: {
- filesField: {
- addFiles: [
- {
- fileId: '550e8400-e29b-41d4-a716-446655440000',
- label: 'Document.pdf',
- extension: 'not-allowed-in-input',
- },
- ],
- },
- },
- },
- ],
- [FieldMetadataType.NUMERIC]: [
- { input: { numericField: {} } },
- { input: { numericField: 'not-a-number' } },
- ],
-};
diff --git a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/field-metadata-config-by-field-name.constant.ts b/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/field-metadata-config-by-field-name.constant.ts
deleted file mode 100644
index ba5432bfa2d..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/field-metadata-config-by-field-name.constant.ts
+++ /dev/null
@@ -1,176 +0,0 @@
-import { joinColumnNameForManyToOneMorphRelationField1 } from 'test/integration/graphql/suites/inputs-validation/utils/setup-test-objects-with-all-field-types.util';
-import {
- type FieldMetadataDefaultOption,
- type FieldMetadataOptions,
- type FieldMetadataSettings,
- FieldMetadataType,
- RelationType,
-} from 'twenty-shared/types';
-
-export type FieldMetadataConfig = {
- name: string;
- type: FieldMetadataType;
- isNullable: boolean;
- options?: FieldMetadataOptions;
- settings?: FieldMetadataSettings;
- defaultValue?: unknown;
-};
-
-export const fieldMetadataConfigByFieldName: Record<
- string,
- FieldMetadataConfig
-> = {
- textField: {
- name: 'textField',
- type: FieldMetadataType.TEXT,
- isNullable: true,
- },
- numberField: {
- name: 'numberField',
- type: FieldMetadataType.NUMBER,
- isNullable: true,
- },
- numericField: {
- name: 'numericField',
- type: FieldMetadataType.NUMERIC,
- isNullable: true,
- },
- uuidField: {
- name: 'uuidField',
- type: FieldMetadataType.UUID,
- isNullable: true,
- },
- selectField: {
- name: 'selectField',
- type: FieldMetadataType.SELECT,
- isNullable: true,
- options: [
- { value: 'OPTION_1' },
- { value: 'OPTION_2' },
- ] as FieldMetadataDefaultOption[],
- },
- manyToOneRelationField: {
- name: 'manyToOneRelationField',
- type: FieldMetadataType.RELATION,
- isNullable: true,
- settings: {
- relationType: RelationType.MANY_TO_ONE,
- joinColumnName: 'manyToOneRelationFieldId',
- },
- },
- manyToOneRelationFieldId: {
- name: 'manyToOneRelationField',
- type: FieldMetadataType.RELATION,
- isNullable: true,
- settings: {
- relationType: RelationType.MANY_TO_ONE,
- joinColumnName: 'manyToOneRelationFieldId',
- },
- },
- rawJsonField: {
- name: 'rawJsonField',
- type: FieldMetadataType.RAW_JSON,
- isNullable: true,
- },
- arrayField: {
- name: 'arrayField',
- type: FieldMetadataType.ARRAY,
- isNullable: true,
- },
- ratingField: {
- name: 'ratingField',
- type: FieldMetadataType.RATING,
- isNullable: true,
- options: [
- { value: 'RATING_1' },
- { value: 'RATING_2' },
- { value: 'RATING_3' },
- { value: 'RATING_4' },
- { value: 'RATING_5' },
- ] as FieldMetadataDefaultOption[],
- },
- multiSelectField: {
- name: 'multiSelectField',
- type: FieldMetadataType.MULTI_SELECT,
- isNullable: true,
- options: [
- { value: 'OPTION_1' },
- { value: 'OPTION_2' },
- ] as FieldMetadataDefaultOption[],
- },
- dateField: {
- name: 'dateField',
- type: FieldMetadataType.DATE,
- isNullable: true,
- },
- dateTimeField: {
- name: 'dateTimeField',
- type: FieldMetadataType.DATE_TIME,
- isNullable: true,
- },
- booleanField: {
- name: 'booleanField',
- type: FieldMetadataType.BOOLEAN,
- isNullable: true,
- },
- addressField: {
- name: 'addressField',
- type: FieldMetadataType.ADDRESS,
- isNullable: true,
- },
- currencyField: {
- name: 'currencyField',
- type: FieldMetadataType.CURRENCY,
- isNullable: true,
- },
- emailsField: {
- name: 'emailsField',
- type: FieldMetadataType.EMAILS,
- isNullable: true,
- },
- phonesField: {
- name: 'phonesField',
- type: FieldMetadataType.PHONES,
- isNullable: true,
- },
- fullNameField: {
- name: 'fullNameField',
- type: FieldMetadataType.FULL_NAME,
- isNullable: true,
- },
- linksField: {
- name: 'linksField',
- type: FieldMetadataType.LINKS,
- isNullable: true,
- },
- richTextField: {
- name: 'richTextField',
- type: FieldMetadataType.RICH_TEXT,
- isNullable: true,
- },
- position: {
- name: 'position',
- type: FieldMetadataType.POSITION,
- isNullable: true,
- },
- filesField: {
- name: 'filesField',
- type: FieldMetadataType.FILES,
- isNullable: true,
- settings: {} as FieldMetadataSettings,
- },
- actorField: {
- name: 'actorField',
- type: FieldMetadataType.ACTOR,
- isNullable: true,
- },
- [joinColumnNameForManyToOneMorphRelationField1]: {
- name: joinColumnNameForManyToOneMorphRelationField1.replace(/Id$/, ''),
- type: FieldMetadataType.MORPH_RELATION,
- isNullable: true,
- settings: {
- relationType: RelationType.MANY_TO_ONE,
- joinColumnName: joinColumnNameForManyToOneMorphRelationField1,
- },
- },
-};
diff --git a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/successful-inputs-by-field-metadata-type.constant.ts b/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/successful-inputs-by-field-metadata-type.constant.ts
deleted file mode 100644
index 8d3e1c4a8ae..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/successful-inputs-by-field-metadata-type.constant.ts
+++ /dev/null
@@ -1,460 +0,0 @@
-import { joinColumnNameForManyToOneMorphRelationField1 } from 'test/integration/graphql/suites/inputs-validation/utils/setup-test-objects-with-all-field-types.util';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-const TEST_UUID = '20202020-b21e-4ec2-873b-de4264d89021';
-
-export const successfulInputsByFieldMetadataType: {
- [K in FieldMetadataType]?: {
- input: Record<string, unknown>;
- expectedOutput: Record<string, unknown>;
- }[];
-} = {
- [FieldMetadataType.TEXT]: [
- { input: { textField: 'test' }, expectedOutput: { textField: 'test' } },
- { input: { textField: '' }, expectedOutput: { textField: null } },
- { input: { textField: null }, expectedOutput: { textField: null } },
- ],
- [FieldMetadataType.NUMBER]: [
- { input: { numberField: 1 }, expectedOutput: { numberField: 1 } },
- { input: { numberField: null }, expectedOutput: { numberField: null } },
- { input: { numberField: 0 }, expectedOutput: { numberField: 0 } },
- { input: { numberField: -1.1 }, expectedOutput: { numberField: -1.1 } },
- ],
- [FieldMetadataType.UUID]: [
- {
- input: { uuidField: TEST_UUID },
- expectedOutput: { uuidField: TEST_UUID },
- },
- { input: { uuidField: null }, expectedOutput: { uuidField: null } },
- ],
- [FieldMetadataType.SELECT]: [
- {
- input: { selectField: 'OPTION_1' },
- expectedOutput: { selectField: 'OPTION_1' },
- },
- { input: { selectField: null }, expectedOutput: { selectField: null } },
- ],
- [FieldMetadataType.RELATION]: [
- {
- input: { manyToOneRelationFieldId: TEST_UUID },
- expectedOutput: { manyToOneRelationFieldId: TEST_UUID },
- },
- {
- input: { manyToOneRelationFieldId: null },
- expectedOutput: { manyToOneRelationFieldId: null },
- },
- ],
- [FieldMetadataType.MORPH_RELATION]: [
- {
- input: { [joinColumnNameForManyToOneMorphRelationField1]: TEST_UUID },
- expectedOutput: {
- [joinColumnNameForManyToOneMorphRelationField1]: TEST_UUID,
- },
- },
- {
- input: { [joinColumnNameForManyToOneMorphRelationField1]: null },
- expectedOutput: {
- [joinColumnNameForManyToOneMorphRelationField1]: null,
- },
- },
- ],
- [FieldMetadataType.RAW_JSON]: [
- {
- input: { rawJsonField: { key: 'value' } },
- expectedOutput: { rawJsonField: { key: 'value' } },
- },
- { input: { rawJsonField: {} }, expectedOutput: { rawJsonField: null } },
- { input: { rawJsonField: null }, expectedOutput: { rawJsonField: null } },
- {
- input: { rawJsonField: '{"key": "value"}' },
- expectedOutput: { rawJsonField: '{"key": "value"}' },
- },
- ],
- [FieldMetadataType.ARRAY]: [
- {
- input: { arrayField: ['item1', 'item2'] },
- expectedOutput: { arrayField: ['item1', 'item2'] },
- },
- {
- input: { arrayField: 'item1' },
- expectedOutput: { arrayField: ['item1'] },
- },
- { input: { arrayField: [] }, expectedOutput: { arrayField: null } },
- { input: { arrayField: null }, expectedOutput: { arrayField: null } },
- ],
- [FieldMetadataType.RATING]: [
- {
- input: { ratingField: 'RATING_2' },
- expectedOutput: { ratingField: 'RATING_2' },
- },
- { input: { ratingField: null }, expectedOutput: { ratingField: null } },
- ],
- [FieldMetadataType.MULTI_SELECT]: [
- {
- input: { multiSelectField: ['OPTION_1'] },
- expectedOutput: { multiSelectField: ['OPTION_1'] },
- },
- {
- input: { multiSelectField: [] },
- expectedOutput: { multiSelectField: null },
- },
- {
- input: { multiSelectField: null },
- expectedOutput: { multiSelectField: null },
- },
- ],
- [FieldMetadataType.DATE]: [
- { input: { dateField: null }, expectedOutput: { dateField: null } },
- {
- input: { dateField: '2025-01-13' },
- expectedOutput: { dateField: '2025-01-13' },
- },
- {
- input: { dateField: '20250113' },
- expectedOutput: { dateField: '20250113' },
- },
- {
- input: { dateField: '2025.01.13' },
- expectedOutput: { dateField: '2025.01.13' },
- },
- {
- input: { dateField: '2025/01/13' },
- expectedOutput: { dateField: '2025/01/13' },
- },
- {
- input: { dateField: '01-13-2025' },
- expectedOutput: { dateField: '01-13-2025' },
- },
- {
- input: { dateField: '01/13/2025' },
- expectedOutput: { dateField: '01/13/2025' },
- },
- {
- input: { dateField: '01.13.2025' },
- expectedOutput: { dateField: '01.13.2025' },
- },
- {
- input: { dateField: 'January 13, 2025' },
- expectedOutput: { dateField: 'January 13, 2025' },
- },
- {
- input: { dateField: 'Jan 13, 2025' },
- expectedOutput: { dateField: 'Jan 13, 2025' },
- },
- {
- input: { dateField: '13 January 2025' },
- expectedOutput: { dateField: '13 January 2025' },
- },
- {
- input: { dateField: '13 Jan 2025' },
- expectedOutput: { dateField: '13 Jan 2025' },
- },
- {
- input: { dateField: '13-Jan-2025' },
- expectedOutput: { dateField: '13-Jan-2025' },
- },
- {
- input: { dateField: '2025-Jan-13' },
- expectedOutput: { dateField: '2025-Jan-13' },
- },
- {
- input: { dateField: '2025-01-13T10:30:00.000Z' },
- expectedOutput: { dateField: '2025-01-13T10:30:00.000Z' },
- },
- {
- input: { dateField: '2025-01-13T10:30:00Z' },
- expectedOutput: { dateField: '2025-01-13T10:30:00Z' },
- },
- {
- input: { dateField: '2025-01-13T10:30:00.000' },
- expectedOutput: { dateField: '2025-01-13T10:30:00.000' },
- },
- {
- input: { dateField: '2025-01-13T10:30:00' },
- expectedOutput: { dateField: '2025-01-13T10:30:00' },
- },
- {
- input: { dateField: '2025-01-13 10:30:00' },
- expectedOutput: { dateField: '2025-01-13 10:30:00' },
- },
- {
- input: { dateField: '2025-01-13 10:30:00.000' },
- expectedOutput: { dateField: '2025-01-13 10:30:00.000' },
- },
- ],
- [FieldMetadataType.DATE_TIME]: [
- { input: { dateTimeField: null }, expectedOutput: { dateTimeField: null } },
- {
- input: { dateTimeField: '2025-01-13T10:30:00.000Z' },
- expectedOutput: { dateTimeField: '2025-01-13T10:30:00Z' },
- },
- {
- input: { dateTimeField: '2025-01-13T10:30:00Z' },
- expectedOutput: { dateTimeField: '2025-01-13T10:30:00Z' },
- },
- {
- input: { dateTimeField: '2025-01-13T10:30:00.000+02:00' },
- expectedOutput: { dateTimeField: '2025-01-13T08:30:00Z' },
- },
- {
- input: { dateTimeField: '2025-01-13T10:30:00+02:00' },
- expectedOutput: { dateTimeField: '2025-01-13T08:30:00Z' },
- },
- {
- input: { dateTimeField: '2025-01-13T10:30:00.000' },
- expectedOutput: { dateTimeField: '2025-01-13T10:30:00Z' },
- },
- {
- input: { dateTimeField: '2025-01-13T10:30:00' },
- expectedOutput: { dateTimeField: '2025-01-13T10:30:00Z' },
- },
- {
- input: { dateTimeField: '2025-01-13 10:30:00.000' },
- expectedOutput: { dateTimeField: '2025-01-13T10:30:00Z' },
- },
- {
- input: { dateTimeField: '2025-01-13 10:30:00' },
- expectedOutput: { dateTimeField: '2025-01-13T10:30:00Z' },
- },
- {
- input: { dateTimeField: '2025-01-13 10:30' },
- expectedOutput: { dateTimeField: '2025-01-13T10:30:00Z' },
- },
- {
- input: { dateTimeField: '2025-01-13' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '20250113' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '2025.01.13' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '2025/01/13' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '01-13-2025' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '01/13/2025' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '01.13.2025' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: 'January 13, 2025' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: 'Jan 13, 2025' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '13 January 2025' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '13 Jan 2025' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '13-Jan-2025' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- {
- input: { dateTimeField: '2025-Jan-13' },
- expectedOutput: { dateTimeField: '2025-01-13T00:00:00Z' },
- },
- ],
- [FieldMetadataType.BOOLEAN]: [
- { input: { booleanField: true }, expectedOutput: { booleanField: true } },
- { input: { booleanField: false }, expectedOutput: { booleanField: false } },
- { input: { booleanField: null }, expectedOutput: { booleanField: null } },
- ],
- [FieldMetadataType.ADDRESS]: [
- {
- input: {
- addressField: {
- addressPostcode: 'postcode',
- addressStreet1: 'street 1',
- addressStreet2: 'street 2',
- addressCity: 'city',
- addressState: 'state',
- addressCountry: 'country',
- },
- },
- expectedOutput: {
- addressField: {
- addressPostcode: 'postcode',
- addressStreet1: 'street 1',
- addressStreet2: 'street 2',
- addressCity: 'city',
- addressState: 'state',
- addressCountry: 'country',
- addressLat: undefined,
- addressLng: undefined,
- },
- },
- },
- { input: { addressField: null }, expectedOutput: { addressField: null } },
- ],
- [FieldMetadataType.CURRENCY]: [
- {
- input: { currencyField: { amountMicros: 1000000, currencyCode: 'USD' } },
- expectedOutput: {
- currencyField: { amountMicros: 1000000, currencyCode: 'USD' },
- },
- },
- { input: { currencyField: null }, expectedOutput: { currencyField: null } },
- ],
- [FieldMetadataType.EMAILS]: [
- {
- input: {
- emailsField: {
- primaryEmail: '[email protected]',
- additionalEmails: ['[email protected]'],
- },
- },
- expectedOutput: {
- emailsField: {
- primaryEmail: '[email protected]',
- additionalEmails: '["[email protected]"]',
- },
- },
- },
- { input: { emailsField: null }, expectedOutput: { emailsField: null } },
- ],
- [FieldMetadataType.PHONES]: [
- {
- input: {
- phonesField: {
- primaryPhoneNumber: '1234567890',
- primaryPhoneCountryCode: 'FR',
- primaryPhoneCallingCode: '+33',
- additionalPhones: [
- { number: '1234567890', callingCode: '+33', countryCode: 'FR' },
- ],
- },
- },
- expectedOutput: {
- phonesField: {
- primaryPhoneNumber: '1234567890',
- primaryPhoneCountryCode: 'FR',
- primaryPhoneCallingCode: '+33',
- additionalPhones:
- '[{"countryCode":"FR","callingCode":"+33","number":"1234567890"}]',
- },
- },
- },
- { input: { phonesField: null }, expectedOutput: { phonesField: null } },
- ],
- [FieldMetadataType.FULL_NAME]: [
- {
- input: { fullNameField: { firstName: 'John', lastName: 'Doe' } },
- expectedOutput: {
- fullNameField: { firstName: 'John', lastName: 'Doe' },
- },
- },
- { input: { fullNameField: null }, expectedOutput: { fullNameField: null } },
- ],
- [FieldMetadataType.LINKS]: [
- {
- input: {
- linksField: {
- primaryLinkUrl: 'https://twenty.com',
- primaryLinkLabel: 'Twenty',
- secondaryLinks: [{ url: 'twenty.com', label: 'Twenty' }],
- },
- },
- expectedOutput: {
- linksField: {
- primaryLinkUrl: 'https://twenty.com',
- primaryLinkLabel: 'Twenty',
- secondaryLinks: '[{"url":"twenty.com","label":"Twenty"}]',
- },
- },
- },
- { input: { linksField: null }, expectedOutput: { linksField: null } },
- ],
- [FieldMetadataType.RICH_TEXT]: [
- {
- input: {
- richTextField: {
- blocknote:
- '[{"type":"paragraph","content":[{"type":"text","text":"test"}]}]',
- markdown: 'test',
- },
- },
- expectedOutput: {
- richTextField: {
- blocknote:
- '[{"type":"paragraph","content":[{"type":"text","text":"test"}]}]',
- markdown: 'test',
- },
- },
- },
- {
- input: { richTextField: null },
- expectedOutput: { richTextField: null },
- },
- ],
- [FieldMetadataType.POSITION]: [
- { input: { position: 1000 }, expectedOutput: { position: 1000 } },
- { input: { position: 0 }, expectedOutput: { position: 0 } },
- { input: { position: -100 }, expectedOutput: { position: -100 } },
- ],
- [FieldMetadataType.FILES]: [
- {
- input: {
- filesField: [
- { fileId: '550e8400-e29b-41d4-a716-446655440000', label: 'Doc.pdf' },
- ],
- },
- expectedOutput: {
- filesField: [
- { fileId: '550e8400-e29b-41d4-a716-446655440000', label: 'Doc.pdf' },
- ],
- },
- },
- { input: { filesField: [] }, expectedOutput: { filesField: null } },
- { input: { filesField: null }, expectedOutput: { filesField: null } },
- ],
- [FieldMetadataType.NUMERIC]: [
- {
- input: { numericField: '123.45' },
- expectedOutput: { numericField: 123.45 },
- },
- {
- input: { numericField: 123.45 },
- expectedOutput: { numericField: 123.45 },
- },
- { input: { numericField: null }, expectedOutput: { numericField: null } },
- ],
- [FieldMetadataType.ACTOR]: [
- {
- input: {
- actorField: {
- source: 'MANUAL',
- name: 'John Doe',
- workspaceMemberId: TEST_UUID,
- },
- },
- expectedOutput: {
- actorField: {
- source: 'MANUAL',
- name: 'John Doe',
- workspaceMemberId: TEST_UUID,
- context: undefined,
- },
- },
- },
- { input: { actorField: null }, expectedOutput: { actorField: null } },
- ],
-};
diff --git a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/data-arg-processor.service.spec.ts b/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/data-arg-processor.service.spec.ts
deleted file mode 100644
index 922713c9cb9..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-args-processors/data-arg-processor/__tests__/data-arg-processor.service.spec.ts
+++ /dev/null
@@ -1,315 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { FieldMetadataType, RelationType } from 'twenty-shared/types';
-
-import { DataArgProcessorService } from 'src/engine/api/common/common-args-processors/data-arg-processor/data-arg-processor.service';
-import { type SystemWorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { RecordPositionService } from 'src/engine/core-modules/record-position/services/record-position.service';
-import { type FlatWorkspace } from 'src/engine/core-modules/workspace/types/flat-workspace.type';
-import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
-import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
-
-import { failingInputsByFieldMetadataType } from './constants/failing-inputs-by-field-metadata-type.constant';
-import { fieldMetadataConfigByFieldName } from './constants/field-metadata-config-by-field-name.constant';
-import { successfulInputsByFieldMetadataType } from './constants/successful-inputs-by-field-metadata-type.constant';
-
-// Mock the rich text v2 transformation to avoid BlockNote module issues
-jest.mock(
- 'src/engine/core-modules/record-transformer/utils/transform-rich-text.util',
- () => ({
- transformRichTextValue: jest.fn().mockImplementation((value) => value),
- }),
-);
-
-describe('DataArgProcessorService', () => {
- let dataArgProcessorService: DataArgProcessorService;
- let recordPositionService: jest.Mocked<RecordPositionService>;
-
- const mockWorkspaceId = '20202020-1234-1234-1234-123456789012';
-
- const createMockAuthContext = (): SystemWorkspaceAuthContext => ({
- type: 'system',
- workspace: { id: mockWorkspaceId } as FlatWorkspace,
- });
-
- const createFlatFieldMetadataMaps = (
- fieldNames: string[],
- ): FlatEntityMaps<FlatFieldMetadata> => {
- const byUniversalIdentifier: Record<string, FlatFieldMetadata> = {};
- const universalIdentifierById: Record<string, string> = {};
-
- for (const fieldName of fieldNames) {
- const config = fieldMetadataConfigByFieldName[fieldName];
-
- if (!config) {
- throw new Error(`No config found for field: ${fieldName}`);
- }
-
- const fieldId = `${fieldName}-id`;
- const universalId = `${fieldName}-universal-id`;
-
- byUniversalIdentifier[universalId] = {
- id: fieldId,
- name: config.name,
- type: config.type ?? FieldMetadataType.TEXT,
- isNullable: config.isNullable ?? true,
- objectMetadataId: 'object-id',
- universalIdentifier: universalId,
- options: config.options,
- settings: config.settings,
- defaultValue: config.defaultValue,
- } as FlatFieldMetadata;
-
- universalIdentifierById[fieldId] = universalId;
- }
-
- return {
- byUniversalIdentifier,
- universalIdentifierById,
- universalIdentifiersByApplicationId: {},
- };
- };
-
- const createFlatObjectMetadata = (fieldNames: string[]): FlatObjectMetadata =>
- ({
- id: 'object-id',
- nameSingular: 'testObject',
- namePlural: 'testObjects',
- fieldIds: fieldNames.map((name) => `${name}-id`),
- universalIdentifier: 'test-object-universal-id',
- labelIdentifierFieldMetadataUniversalIdentifier: null,
- imageIdentifierFieldMetadataUniversalIdentifier: null,
- }) as FlatObjectMetadata;
-
- beforeEach(async () => {
- recordPositionService = {
- overridePositionOnRecords: jest
- .fn()
- .mockImplementation(({ partialRecordInputs }) => partialRecordInputs),
- buildRecordPosition: jest.fn(),
- findByPosition: jest.fn(),
- updatePosition: jest.fn(),
- } as unknown as jest.Mocked<RecordPositionService>;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- DataArgProcessorService,
- {
- provide: RecordPositionService,
- useValue: recordPositionService,
- },
- ],
- }).compile();
-
- dataArgProcessorService = module.get<DataArgProcessorService>(
- DataArgProcessorService,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should be defined', () => {
- expect(dataArgProcessorService).toBeDefined();
- });
-
- it('should normalize relation connect where composite values', async () => {
- const flatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata> = {
- byUniversalIdentifier: {
- 'company-universal-id': {
- id: 'company-id',
- name: 'company',
- type: FieldMetadataType.RELATION,
- isNullable: true,
- objectMetadataId: 'object-id',
- universalIdentifier: 'company-universal-id',
- relationTargetObjectMetadataId: 'target-company-object-id',
- settings: {
- relationType: RelationType.MANY_TO_ONE,
- joinColumnName: 'companyId',
- },
- } as FlatFieldMetadata,
- 'emails-universal-id': {
- id: 'emails-id',
- name: 'emails',
- type: FieldMetadataType.EMAILS,
- isNullable: true,
- objectMetadataId: 'target-company-object-id',
- universalIdentifier: 'emails-universal-id',
- } as FlatFieldMetadata,
- 'domainName-universal-id': {
- id: 'domainName-id',
- name: 'domainName',
- type: FieldMetadataType.LINKS,
- isNullable: true,
- objectMetadataId: 'target-company-object-id',
- universalIdentifier: 'domainName-universal-id',
- } as FlatFieldMetadata,
- },
- universalIdentifierById: {
- 'company-id': 'company-universal-id',
- 'emails-id': 'emails-universal-id',
- 'domainName-id': 'domainName-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- };
-
- const flatObjectMetadata = {
- id: 'object-id',
- nameSingular: 'testObject',
- namePlural: 'testObjects',
- fieldIds: ['company-id'],
- universalIdentifier: 'test-object-universal-id',
- labelIdentifierFieldMetadataUniversalIdentifier: null,
- imageIdentifierFieldMetadataUniversalIdentifier: null,
- } as FlatObjectMetadata;
-
- const flatObjectMetadataMaps = {
- byUniversalIdentifier: {
- 'target-company-universal-id': {
- id: 'target-company-object-id',
- nameSingular: 'company',
- namePlural: 'companies',
- fieldIds: ['emails-id', 'domainName-id'],
- universalIdentifier: 'target-company-universal-id',
- labelIdentifierFieldMetadataUniversalIdentifier: null,
- imageIdentifierFieldMetadataUniversalIdentifier: null,
- } as FlatObjectMetadata,
- },
- universalIdentifierById: {
- 'target-company-object-id': 'target-company-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- };
-
- const result = await dataArgProcessorService.process({
- partialRecordInputs: [
- {
- company: {
- connect: {
- where: {
- emails: {
- primaryEmail: '[email protected]',
- },
- domainName: {
- primaryLinkUrl: 'HTTPS://Example.COM/path/',
- },
- },
- },
- },
- },
- ],
- authContext: createMockAuthContext(),
- flatObjectMetadata,
- flatFieldMetadataMaps,
- flatObjectMetadataMaps,
- });
-
- expect(result).toEqual([
- {
- company: {
- connect: {
- where: {
- emails: {
- primaryEmail: '[email protected]',
- },
- domainName: {
- primaryLinkUrl: 'https://example.com/path',
- },
- },
- },
- },
- },
- ]);
- });
-
- describe('failing inputs validation', () => {
- const fieldMetadataTypesToTest = Object.keys(
- failingInputsByFieldMetadataType,
- ) as FieldMetadataType[];
-
- for (const fieldMetadataType of fieldMetadataTypesToTest) {
- const testCases = failingInputsByFieldMetadataType[fieldMetadataType];
-
- if (!testCases) {
- continue;
- }
-
- describe(`${fieldMetadataType}`, () => {
- for (const [index, testCase] of testCases.entries()) {
- const fieldName = Object.keys(testCase.input)[0];
- const fieldValue = testCase.input[fieldName];
-
- it(`should throw for invalid input #${index + 1}: ${JSON.stringify(fieldValue)}`, async () => {
- const fieldNames = [fieldName];
-
- const flatFieldMetadataMaps =
- createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- await expect(
- dataArgProcessorService.process({
- partialRecordInputs: [testCase.input],
- authContext: createMockAuthContext(),
- flatObjectMetadata,
- flatFieldMetadataMaps,
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- }),
- ).rejects.toThrowErrorMatchingSnapshot();
- });
- }
- });
- }
- });
-
- describe('successful inputs validation', () => {
- const fieldMetadataTypesToTest = Object.keys(
- successfulInputsByFieldMetadataType,
- ) as FieldMetadataType[];
-
- for (const fieldMetadataType of fieldMetadataTypesToTest) {
- const testCases = successfulInputsByFieldMetadataType[fieldMetadataType];
-
- if (!testCases) {
- continue;
- }
-
- describe(`${fieldMetadataType}`, () => {
- for (const [index, testCase] of testCases.entries()) {
- const fieldName = Object.keys(testCase.input)[0];
- const fieldValue = testCase.input[fieldName];
-
- it(`should process valid input #${index + 1}: ${JSON.stringify(fieldValue)}`, async () => {
- const fieldNames = [fieldName];
-
- const flatFieldMetadataMaps =
- createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- const result = await dataArgProcessorService.process({
- partialRecordInputs: [testCase.input],
- authContext: createMockAuthContext(),
- flatObjectMetadata,
- flatFieldMetadataMaps,
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- });
-
- expect(result).toBeDefined();
- expect(result).toHaveLength(1);
- expect(result[0]).toEqual(testCase.expectedOutput);
- });
- }
- });
- }
- });
-});
diff --git a/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/__snapshots__/filter-arg-processor.service.spec.ts.snap b/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/__snapshots__/filter-arg-processor.service.spec.ts.snap
deleted file mode 100644
index 7cabfea8839..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/__snapshots__/filter-arg-processor.service.spec.ts.snap
+++ /dev/null
@@ -1,171 +0,0 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
-
-exports[`FilterArgProcessorService failing filter inputs validation ACTOR should throw for invalid filter #1: {"actorField":{"invalidSubField":{"eq":"test"}}} 1`] = `"Sub field "invalidSubField" not found for composite type: ACTOR"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation ACTOR should throw for invalid filter #2: {"actorField":{"source":{"invalidOperator":"test"}}} 1`] = `"Operator "invalidOperator" is not valid for field "actorField.source" of type SELECT - Allowed operators: eq, neq, gt, gte, lt, lte, in, containsAny, is, isEmptyArray"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation ACTOR should throw for invalid filter #3: {"actorField":{"workspaceMemberId":{"eq":"invalid-uuid"}}} 1`] = `"Invalid UUID value 'invalid-uuid' for field "actorField.workspaceMemberId""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation ADDRESS should throw for invalid filter #1: {"addressField":{"invalidSubField":{"eq":"test"}}} 1`] = `"Sub field "invalidSubField" not found for composite type: ADDRESS"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation ADDRESS should throw for invalid filter #2: {"addressField":{"addressCity":{"invalidOperator":"test"}}} 1`] = `"Operator "invalidOperator" is not valid for field "addressField.addressCity" of type TEXT - Allowed operators: eq, neq, gt, gte, lt, lte, in, is, like, ilike, startsWith, endsWith"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation ADDRESS should throw for invalid filter #3: {"addressField":{"addressCity":{}}} 1`] = `"Filter for field "addressField.addressCity" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation ARRAY should throw for invalid filter #1: {"arrayField":{"invalidOperator":"test"}} 1`] = `"Operator "invalidOperator" is not valid for field "arrayField" of type ARRAY - Allowed operators: containsIlike, is, isEmptyArray"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation ARRAY should throw for invalid filter #2: {"arrayField":{}} 1`] = `"Filter for field "arrayField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation ARRAY should throw for invalid filter #3: {"arrayField":{"containsIlike":"test","is":"NULL"}} 1`] = `"Filter for field "arrayField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation BOOLEAN should throw for invalid filter #1: {"booleanField":{"eq":{}}} 1`] = `"Invalid boolean value {} for field "booleanField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation BOOLEAN should throw for invalid filter #2: {"booleanField":{"eq":[]}} 1`] = `"Invalid boolean value [] for field "booleanField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation BOOLEAN should throw for invalid filter #3: {"booleanField":{"eq":1}} 1`] = `"Invalid boolean value 1 for field "booleanField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation BOOLEAN should throw for invalid filter #4: {"booleanField":{"invalidOperator":true}} 1`] = `"Operator "invalidOperator" is not valid for field "booleanField" of type BOOLEAN - Allowed operators: eq, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation BOOLEAN should throw for invalid filter #5: {"booleanField":{}} 1`] = `"Filter for field "booleanField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation CURRENCY should throw for invalid filter #1: {"currencyField":{"invalidSubField":{"eq":"test"}}} 1`] = `"Sub field "invalidSubField" not found for composite type: CURRENCY"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation CURRENCY should throw for invalid filter #2: {"currencyField":{"amountMicros":{"invalidOperator":"test"}}} 1`] = `"Operator "invalidOperator" is not valid for field "currencyField.amountMicros" of type NUMERIC - Allowed operators: eq, neq, gt, gte, lt, lte, in, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation CURRENCY should throw for invalid filter #3: {"currencyField":{"amountMicros":{"eq":"not-a-number"}}} 1`] = `"Invalid number value NaN for field "currencyField.amountMicros""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE should throw for invalid filter #1: {"dateField":{"eq":"malformed-date"}} 1`] = `"Invalid value 'malformed-date' for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE should throw for invalid filter #2: {"dateField":{"eq":{}}} 1`] = `"Invalid value {} for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE should throw for invalid filter #3: {"dateField":{"eq":[]}} 1`] = `"Invalid value [] for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE should throw for invalid filter #4: {"dateField":{"eq":true}} 1`] = `"Invalid value true for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE should throw for invalid filter #5: {"dateField":{"eq":1}} 1`] = `"Invalid value 1 for date field "dateField". Expected format: 'YYYY-MM-DD'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE should throw for invalid filter #6: {"dateField":{"invalidOperator":"2025-01-01"}} 1`] = `"Operator "invalidOperator" is not valid for field "dateField" of type DATE - Allowed operators: eq, neq, gt, gte, lt, lte, in, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE should throw for invalid filter #7: {"dateField":{}} 1`] = `"Filter for field "dateField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE_TIME should throw for invalid filter #1: {"dateTimeField":{"eq":"malformed-date"}} 1`] = `"Invalid value 'malformed-date' for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE_TIME should throw for invalid filter #2: {"dateTimeField":{"eq":{}}} 1`] = `"Invalid value {} for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE_TIME should throw for invalid filter #3: {"dateTimeField":{"eq":[]}} 1`] = `"Invalid value [] for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE_TIME should throw for invalid filter #4: {"dateTimeField":{"eq":true}} 1`] = `"Invalid value true for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE_TIME should throw for invalid filter #5: {"dateTimeField":{"eq":1}} 1`] = `"Invalid value 1 for date-time field "dateTimeField". Expected format: 'YYYY-MM-DDTHH:mm:ssZ'"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE_TIME should throw for invalid filter #6: {"dateTimeField":{"invalidOperator":"2025-01-01T10:00:00Z"}} 1`] = `"Operator "invalidOperator" is not valid for field "dateTimeField" of type DATE_TIME - Allowed operators: eq, neq, gt, gte, lt, lte, in, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation DATE_TIME should throw for invalid filter #7: {"dateTimeField":{}} 1`] = `"Filter for field "dateTimeField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation EMAILS should throw for invalid filter #1: {"emailsField":{"invalidSubField":{"eq":"test"}}} 1`] = `"Sub field "invalidSubField" not found for composite type: EMAILS"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation EMAILS should throw for invalid filter #2: {"emailsField":{"primaryEmail":{"invalidOperator":"test"}}} 1`] = `"Operator "invalidOperator" is not valid for field "emailsField.primaryEmail" of type TEXT - Allowed operators: eq, neq, gt, gte, lt, lte, in, is, like, ilike, startsWith, endsWith"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation FILES should throw for invalid filter #1: {"filesField":{"invalidOperator":"test"}} 1`] = `"Operator "invalidOperator" is not valid for field "filesField" of type FILES - Allowed operators: is, like"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation FILES should throw for invalid filter #2: {"filesField":{}} 1`] = `"Filter for field "filesField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation FULL_NAME should throw for invalid filter #1: {"fullNameField":{"invalidSubField":{"eq":"test"}}} 1`] = `"Sub field "invalidSubField" not found for composite type: FULL_NAME"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation FULL_NAME should throw for invalid filter #2: {"fullNameField":{"firstName":{"invalidOperator":"test"}}} 1`] = `"Operator "invalidOperator" is not valid for field "fullNameField.firstName" of type TEXT - Allowed operators: eq, neq, gt, gte, lt, lte, in, is, like, ilike, startsWith, endsWith"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation LINKS should throw for invalid filter #1: {"linksField":{"invalidSubField":{"eq":"test"}}} 1`] = `"Sub field "invalidSubField" not found for composite type: LINKS"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation LINKS should throw for invalid filter #2: {"linksField":{"primaryLinkUrl":{"invalidOperator":"test"}}} 1`] = `"Operator "invalidOperator" is not valid for field "linksField.primaryLinkUrl" of type TEXT - Allowed operators: eq, neq, gt, gte, lt, lte, in, is, like, ilike, startsWith, endsWith"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation MORPH_RELATION should throw for invalid filter #1: {"manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id":{"eq":"invalid-uuid"}} 1`] = `"Invalid UUID value 'invalid-uuid' for field "manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation MORPH_RELATION should throw for invalid filter #2: {"manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id":{"invalidOperator":"test"}} 1`] = `"Operator "invalidOperator" is not valid for field "manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id" of type MORPH_RELATION - Allowed operators: eq, neq, gt, gte, lt, lte, in, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation MORPH_RELATION should throw for invalid filter #3: {"manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id":{}} 1`] = `"Filter for field "manyToOneMorphRelationFieldApiInputValidationTargetTestObject1Id" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation MULTI_SELECT should throw for invalid filter #1: {"multiSelectField":{"invalidOperator":["OPTION_1"]}} 1`] = `"Operator "invalidOperator" is not valid for field "multiSelectField" of type MULTI_SELECT - Allowed operators: containsAny, is, isEmptyArray"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation MULTI_SELECT should throw for invalid filter #2: {"multiSelectField":{}} 1`] = `"Filter for field "multiSelectField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation MULTI_SELECT should throw for invalid filter #3: {"multiSelectField":{"containsAny":"not-an-array"}} 1`] = `"Filter operator "containsAny" requires an array value for field multiSelectField"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMBER should throw for invalid filter #1: {"numberField":{"eq":"not-a-number"}} 1`] = `"Invalid number value NaN for field "numberField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMBER should throw for invalid filter #2: {"numberField":{"eq":{}}} 1`] = `"Invalid number value {} for field "numberField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMBER should throw for invalid filter #3: {"numberField":{"eq":[]}} 1`] = `"Invalid number value [] for field "numberField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMBER should throw for invalid filter #4: {"numberField":{"eq":true}} 1`] = `"Invalid number value true for field "numberField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMBER should throw for invalid filter #5: {"numberField":{"invalidOperator":1}} 1`] = `"Operator "invalidOperator" is not valid for field "numberField" of type NUMBER - Allowed operators: eq, neq, gt, gte, lt, lte, in, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMBER should throw for invalid filter #6: {"numberField":{"eq":1,"neq":2}} 1`] = `"Filter for field "numberField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMBER should throw for invalid filter #7: {"numberField":{}} 1`] = `"Filter for field "numberField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMERIC should throw for invalid filter #1: {"numericField":{"eq":"not-a-number"}} 1`] = `"Invalid number value NaN for field "numericField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMERIC should throw for invalid filter #2: {"numericField":{"eq":{}}} 1`] = `"Invalid number value {} for field "numericField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMERIC should throw for invalid filter #3: {"numericField":{"invalidOperator":1}} 1`] = `"Operator "invalidOperator" is not valid for field "numericField" of type NUMERIC - Allowed operators: eq, neq, gt, gte, lt, lte, in, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation NUMERIC should throw for invalid filter #4: {"numericField":{}} 1`] = `"Filter for field "numericField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation PHONES should throw for invalid filter #1: {"phonesField":{"invalidSubField":{"eq":"test"}}} 1`] = `"Sub field "invalidSubField" not found for composite type: PHONES"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation PHONES should throw for invalid filter #2: {"phonesField":{"primaryPhoneNumber":{"invalidOperator":"test"}}} 1`] = `"Operator "invalidOperator" is not valid for field "phonesField.primaryPhoneNumber" of type TEXT - Allowed operators: eq, neq, gt, gte, lt, lte, in, is, like, ilike, startsWith, endsWith"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation POSITION should throw for invalid filter #1: {"position":{"eq":"not-a-number"}} 1`] = `"Invalid number value NaN for field "position""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation POSITION should throw for invalid filter #2: {"position":{"eq":{}}} 1`] = `"Invalid number value {} for field "position""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation POSITION should throw for invalid filter #3: {"position":{"invalidOperator":1}} 1`] = `"Operator "invalidOperator" is not valid for field "position" of type POSITION - Allowed operators: eq, neq, gt, gte, lt, lte, in, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation POSITION should throw for invalid filter #4: {"position":{}} 1`] = `"Filter for field "position" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RATING should throw for invalid filter #1: {"ratingField":{"invalidOperator":"RATING_1"}} 1`] = `"Operator "invalidOperator" is not valid for field "ratingField" of type RATING - Allowed operators: eq, neq, gt, gte, lt, lte, in, containsAny, is, isEmptyArray"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RATING should throw for invalid filter #2: {"ratingField":{}} 1`] = `"Filter for field "ratingField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RATING should throw for invalid filter #3: {"ratingField":{"eq":"RATING_1","neq":"RATING_2"}} 1`] = `"Filter for field "ratingField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RAW_JSON should throw for invalid filter #1: {"rawJsonField":{"invalidOperator":"test"}} 1`] = `"Operator "invalidOperator" is not valid for field "rawJsonField" of type RAW_JSON - Allowed operators: is, like"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RAW_JSON should throw for invalid filter #2: {"rawJsonField":{}} 1`] = `"Filter for field "rawJsonField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RELATION should throw for invalid filter #1: {"manyToOneRelationFieldId":{"eq":"invalid-uuid"}} 1`] = `"Invalid UUID value 'invalid-uuid' for field "manyToOneRelationFieldId""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RELATION should throw for invalid filter #2: {"manyToOneRelationFieldId":{"invalidOperator":"test"}} 1`] = `"Operator "invalidOperator" is not valid for field "manyToOneRelationFieldId" of type RELATION - Allowed operators: eq, neq, gt, gte, lt, lte, in, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RELATION should throw for invalid filter #3: {"manyToOneRelationFieldId":{}} 1`] = `"Filter for field "manyToOneRelationFieldId" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RICH_TEXT should throw for invalid filter #1: {"richTextField":{"invalidOperator":"test"}} 1`] = `"Sub field "invalidOperator" not found for composite type: RICH_TEXT"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation RICH_TEXT should throw for invalid filter #2: {"richTextField":{"markdown":{"invalidOperator":"test"}}} 1`] = `"Operator "invalidOperator" is not valid for field "richTextField.markdown" of type TEXT - Allowed operators: eq, neq, gt, gte, lt, lte, in, is, like, ilike, startsWith, endsWith"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation SELECT should throw for invalid filter #1: {"selectField":{"invalidOperator":"OPTION_1"}} 1`] = `"Operator "invalidOperator" is not valid for field "selectField" of type SELECT - Allowed operators: eq, neq, gt, gte, lt, lte, in, containsAny, is, isEmptyArray"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation SELECT should throw for invalid filter #2: {"selectField":{}} 1`] = `"Filter for field "selectField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation SELECT should throw for invalid filter #3: {"selectField":{"eq":"OPTION_1","neq":"OPTION_2"}} 1`] = `"Filter for field "selectField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation TEXT should throw for invalid filter #1: {"textField":{"invalidOperator":"test"}} 1`] = `"Operator "invalidOperator" is not valid for field "textField" of type TEXT - Allowed operators: eq, neq, gt, gte, lt, lte, in, is, like, ilike, startsWith, endsWith"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation TEXT should throw for invalid filter #2: {"textField":{"eq":"test","neq":"test"}} 1`] = `"Filter for field "textField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation TEXT should throw for invalid filter #3: {"textField":{}} 1`] = `"Filter for field "textField" must have exactly one operator"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation UUID should throw for invalid filter #1: {"uuidField":{"eq":"invalid-uuid"}} 1`] = `"Invalid UUID value 'invalid-uuid' for field "uuidField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation UUID should throw for invalid filter #2: {"uuidField":{"eq":2}} 1`] = `"Invalid UUID value 2 for field "uuidField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation UUID should throw for invalid filter #3: {"uuidField":{"eq":{}}} 1`] = `"Invalid UUID value {} for field "uuidField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation UUID should throw for invalid filter #4: {"uuidField":{"eq":[]}} 1`] = `"Invalid UUID value [] for field "uuidField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation UUID should throw for invalid filter #5: {"uuidField":{"eq":true}} 1`] = `"Invalid UUID value true for field "uuidField""`;
-
-exports[`FilterArgProcessorService failing filter inputs validation UUID should throw for invalid filter #6: {"uuidField":{"invalidOperator":"test"}} 1`] = `"Operator "invalidOperator" is not valid for field "uuidField" of type UUID - Allowed operators: eq, neq, gt, gte, lt, lte, in, is"`;
-
-exports[`FilterArgProcessorService failing filter inputs validation UUID should throw for invalid filter #7: {"uuidField":{}} 1`] = `"Filter for field "uuidField" must have exactly one operator"`;
diff --git a/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/constants/failing-filter-inputs-by-field-metadata-type.constant.ts b/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/constants/failing-filter-inputs-by-field-metadata-type.constant.ts
deleted file mode 100644
index 324b75cefaa..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/constants/failing-filter-inputs-by-field-metadata-type.constant.ts
+++ /dev/null
@@ -1,164 +0,0 @@
-import { joinColumnNameForManyToOneMorphRelationField1 } from 'test/integration/graphql/suites/inputs-validation/utils/setup-test-objects-with-all-field-types.util';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-export const failingFilterInputsByFieldMetadataType: {
- [K in FieldMetadataType]?: {
- filter: Record<string, unknown>;
- }[];
-} = {
- [FieldMetadataType.TEXT]: [
- { filter: { textField: { invalidOperator: 'test' } } },
- { filter: { textField: { eq: 'test', neq: 'test' } } },
- { filter: { textField: {} } },
- ],
- [FieldMetadataType.NUMBER]: [
- { filter: { numberField: { eq: 'not-a-number' } } },
- { filter: { numberField: { eq: {} } } },
- { filter: { numberField: { eq: [] } } },
- { filter: { numberField: { eq: true } } },
- { filter: { numberField: { invalidOperator: 1 } } },
- { filter: { numberField: { eq: 1, neq: 2 } } },
- { filter: { numberField: {} } },
- ],
- [FieldMetadataType.NUMERIC]: [
- { filter: { numericField: { eq: 'not-a-number' } } },
- { filter: { numericField: { eq: {} } } },
- { filter: { numericField: { invalidOperator: 1 } } },
- { filter: { numericField: {} } },
- ],
- [FieldMetadataType.UUID]: [
- { filter: { uuidField: { eq: 'invalid-uuid' } } },
- { filter: { uuidField: { eq: 2 } } },
- { filter: { uuidField: { eq: {} } } },
- { filter: { uuidField: { eq: [] } } },
- { filter: { uuidField: { eq: true } } },
- { filter: { uuidField: { invalidOperator: 'test' } } },
- { filter: { uuidField: {} } },
- ],
- [FieldMetadataType.BOOLEAN]: [
- { filter: { booleanField: { eq: {} } } },
- { filter: { booleanField: { eq: [] } } },
- { filter: { booleanField: { eq: 1 } } },
- { filter: { booleanField: { invalidOperator: true } } },
- { filter: { booleanField: {} } },
- ],
- [FieldMetadataType.DATE]: [
- { filter: { dateField: { eq: 'malformed-date' } } },
- { filter: { dateField: { eq: {} } } },
- { filter: { dateField: { eq: [] } } },
- { filter: { dateField: { eq: true } } },
- { filter: { dateField: { eq: 1 } } },
- { filter: { dateField: { invalidOperator: '2025-01-01' } } },
- { filter: { dateField: {} } },
- ],
- [FieldMetadataType.DATE_TIME]: [
- { filter: { dateTimeField: { eq: 'malformed-date' } } },
- { filter: { dateTimeField: { eq: {} } } },
- { filter: { dateTimeField: { eq: [] } } },
- { filter: { dateTimeField: { eq: true } } },
- { filter: { dateTimeField: { eq: 1 } } },
- { filter: { dateTimeField: { invalidOperator: '2025-01-01T10:00:00Z' } } },
- { filter: { dateTimeField: {} } },
- ],
- [FieldMetadataType.SELECT]: [
- { filter: { selectField: { invalidOperator: 'OPTION_1' } } },
- { filter: { selectField: {} } },
- { filter: { selectField: { eq: 'OPTION_1', neq: 'OPTION_2' } } },
- ],
- [FieldMetadataType.RATING]: [
- { filter: { ratingField: { invalidOperator: 'RATING_1' } } },
- { filter: { ratingField: {} } },
- { filter: { ratingField: { eq: 'RATING_1', neq: 'RATING_2' } } },
- ],
- [FieldMetadataType.MULTI_SELECT]: [
- { filter: { multiSelectField: { invalidOperator: ['OPTION_1'] } } },
- { filter: { multiSelectField: {} } },
- { filter: { multiSelectField: { containsAny: 'not-an-array' } } },
- ],
- [FieldMetadataType.ARRAY]: [
- { filter: { arrayField: { invalidOperator: 'test' } } },
- { filter: { arrayField: {} } },
- { filter: { arrayField: { containsIlike: 'test', is: 'NULL' } } },
- ],
- [FieldMetadataType.RAW_JSON]: [
- { filter: { rawJsonField: { invalidOperator: 'test' } } },
- { filter: { rawJsonField: {} } },
- ],
- [FieldMetadataType.RELATION]: [
- { filter: { manyToOneRelationFieldId: { eq: 'invalid-uuid' } } },
- { filter: { manyToOneRelationFieldId: { invalidOperator: 'test' } } },
- { filter: { manyToOneRelationFieldId: {} } },
- ],
- [FieldMetadataType.MORPH_RELATION]: [
- {
- filter: {
- [joinColumnNameForManyToOneMorphRelationField1]: { eq: 'invalid-uuid' },
- },
- },
- {
- filter: {
- [joinColumnNameForManyToOneMorphRelationField1]: {
- invalidOperator: 'test',
- },
- },
- },
- {
- filter: { [joinColumnNameForManyToOneMorphRelationField1]: {} },
- },
- ],
- [FieldMetadataType.POSITION]: [
- { filter: { position: { eq: 'not-a-number' } } },
- { filter: { position: { eq: {} } } },
- { filter: { position: { invalidOperator: 1 } } },
- { filter: { position: {} } },
- ],
- [FieldMetadataType.FILES]: [
- { filter: { filesField: { invalidOperator: 'test' } } },
- { filter: { filesField: {} } },
- ],
- [FieldMetadataType.RICH_TEXT]: [
- { filter: { richTextField: { invalidOperator: 'test' } } },
- { filter: { richTextField: { markdown: { invalidOperator: 'test' } } } },
- ],
- [FieldMetadataType.ADDRESS]: [
- { filter: { addressField: { invalidSubField: { eq: 'test' } } } },
- { filter: { addressField: { addressCity: { invalidOperator: 'test' } } } },
- { filter: { addressField: { addressCity: {} } } },
- ],
- [FieldMetadataType.CURRENCY]: [
- { filter: { currencyField: { invalidSubField: { eq: 'test' } } } },
- {
- filter: { currencyField: { amountMicros: { invalidOperator: 'test' } } },
- },
- { filter: { currencyField: { amountMicros: { eq: 'not-a-number' } } } },
- ],
- [FieldMetadataType.EMAILS]: [
- { filter: { emailsField: { invalidSubField: { eq: 'test' } } } },
- {
- filter: { emailsField: { primaryEmail: { invalidOperator: 'test' } } },
- },
- ],
- [FieldMetadataType.PHONES]: [
- { filter: { phonesField: { invalidSubField: { eq: 'test' } } } },
- {
- filter: {
- phonesField: { primaryPhoneNumber: { invalidOperator: 'test' } },
- },
- },
- ],
- [FieldMetadataType.FULL_NAME]: [
- { filter: { fullNameField: { invalidSubField: { eq: 'test' } } } },
- { filter: { fullNameField: { firstName: { invalidOperator: 'test' } } } },
- ],
- [FieldMetadataType.LINKS]: [
- { filter: { linksField: { invalidSubField: { eq: 'test' } } } },
- {
- filter: { linksField: { primaryLinkUrl: { invalidOperator: 'test' } } },
- },
- ],
- [FieldMetadataType.ACTOR]: [
- { filter: { actorField: { invalidSubField: { eq: 'test' } } } },
- { filter: { actorField: { source: { invalidOperator: 'test' } } } },
- { filter: { actorField: { workspaceMemberId: { eq: 'invalid-uuid' } } } },
- ],
-};
diff --git a/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/constants/successful-filter-inputs-by-field-metadata-type.constant.ts b/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/constants/successful-filter-inputs-by-field-metadata-type.constant.ts
deleted file mode 100644
index bd5cd2bb2c2..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/constants/successful-filter-inputs-by-field-metadata-type.constant.ts
+++ /dev/null
@@ -1,245 +0,0 @@
-import { joinColumnNameForManyToOneMorphRelationField1 } from 'test/integration/graphql/suites/inputs-validation/utils/setup-test-objects-with-all-field-types.util';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-const TEST_UUID = '20202020-b21e-4ec2-873b-de4264d89021';
-
-export const successfulFilterInputsByFieldMetadataType: {
- [K in FieldMetadataType]?: {
- filter: Record<string, unknown>;
- expected?: Record<string, unknown>;
- }[];
-} = {
- [FieldMetadataType.TEXT]: [
- { filter: { textField: { eq: 'test' } } },
- { filter: { textField: { neq: 'test' } } },
- { filter: { textField: { like: '%test%' } } },
- { filter: { textField: { ilike: '%test%' } } },
- { filter: { textField: { startsWith: 'test' } } },
- { filter: { textField: { endsWith: 'test' } } },
- { filter: { textField: { in: ['test1', 'test2'] } } },
- { filter: { textField: { is: 'NULL' } } },
- { filter: { textField: { is: 'NOT_NULL' } } },
- { filter: { textField: { eq: null } } },
- ],
- [FieldMetadataType.NUMBER]: [
- { filter: { numberField: { eq: 1 } } },
- { filter: { numberField: { neq: 1 } } },
- { filter: { numberField: { gt: 0 } } },
- { filter: { numberField: { gte: 0 } } },
- { filter: { numberField: { lt: 10 } } },
- { filter: { numberField: { lte: 10 } } },
- { filter: { numberField: { in: [1, 2, 3] } } },
- { filter: { numberField: { is: 'NULL' } } },
- { filter: { numberField: { is: 'NOT_NULL' } } },
- { filter: { numberField: { eq: null } } },
- {
- filter: { numberField: { eq: '1' } },
- expected: { numberField: { eq: 1 } },
- },
- { filter: { numberField: { eq: 0 } } },
- { filter: { numberField: { eq: -1.5 } } },
- ],
- [FieldMetadataType.NUMERIC]: [
- { filter: { numericField: { eq: 1 } } },
- { filter: { numericField: { neq: 1 } } },
- { filter: { numericField: { gt: 0 } } },
- { filter: { numericField: { gte: 0 } } },
- { filter: { numericField: { lt: 10 } } },
- { filter: { numericField: { lte: 10 } } },
- { filter: { numericField: { in: [1, 2, 3] } } },
- { filter: { numericField: { is: 'NULL' } } },
- { filter: { numericField: { is: 'NOT_NULL' } } },
- { filter: { numericField: { eq: null } } },
- ],
- [FieldMetadataType.UUID]: [
- { filter: { uuidField: { eq: TEST_UUID } } },
- { filter: { uuidField: { neq: TEST_UUID } } },
- { filter: { uuidField: { in: [TEST_UUID] } } },
- { filter: { uuidField: { is: 'NULL' } } },
- { filter: { uuidField: { is: 'NOT_NULL' } } },
- { filter: { uuidField: { eq: null } } },
- ],
- [FieldMetadataType.BOOLEAN]: [
- { filter: { booleanField: { eq: true } } },
- { filter: { booleanField: { eq: false } } },
- { filter: { booleanField: { is: 'NULL' } } },
- { filter: { booleanField: { is: 'NOT_NULL' } } },
- { filter: { booleanField: { eq: null } } },
- {
- filter: { booleanField: { eq: 'true' } },
- expected: { booleanField: { eq: true } },
- },
- {
- filter: { booleanField: { eq: 'false' } },
- expected: { booleanField: { eq: false } },
- },
- ],
- [FieldMetadataType.DATE]: [
- { filter: { dateField: { eq: '2025-01-13' } } },
- { filter: { dateField: { neq: '2025-01-13' } } },
- { filter: { dateField: { gt: '2025-01-01' } } },
- { filter: { dateField: { gte: '2025-01-01' } } },
- { filter: { dateField: { lt: '2025-12-31' } } },
- { filter: { dateField: { lte: '2025-12-31' } } },
- { filter: { dateField: { in: ['2025-01-01', '2025-01-02'] } } },
- { filter: { dateField: { is: 'NULL' } } },
- { filter: { dateField: { is: 'NOT_NULL' } } },
- { filter: { dateField: { eq: null } } },
- ],
- [FieldMetadataType.DATE_TIME]: [
- { filter: { dateTimeField: { eq: '2025-01-13T10:30:00Z' } } },
- { filter: { dateTimeField: { neq: '2025-01-13T10:30:00Z' } } },
- { filter: { dateTimeField: { gt: '2025-01-01T00:00:00Z' } } },
- { filter: { dateTimeField: { gte: '2025-01-01T00:00:00Z' } } },
- { filter: { dateTimeField: { lt: '2025-12-31T23:59:59Z' } } },
- { filter: { dateTimeField: { lte: '2025-12-31T23:59:59Z' } } },
- {
- filter: {
- dateTimeField: {
- in: ['2025-01-01T00:00:00Z', '2025-01-02T00:00:00Z'],
- },
- },
- },
- { filter: { dateTimeField: { is: 'NULL' } } },
- { filter: { dateTimeField: { is: 'NOT_NULL' } } },
- { filter: { dateTimeField: { eq: null } } },
- ],
- [FieldMetadataType.SELECT]: [
- { filter: { selectField: { eq: 'OPTION_1' } } },
- { filter: { selectField: { neq: 'OPTION_1' } } },
- { filter: { selectField: { in: ['OPTION_1', 'OPTION_2'] } } },
- { filter: { selectField: { is: 'NULL' } } },
- { filter: { selectField: { is: 'NOT_NULL' } } },
- { filter: { selectField: { gt: 'OPTION_1' } } },
- { filter: { selectField: { gte: 'OPTION_1' } } },
- { filter: { selectField: { lt: 'OPTION_1' } } },
- { filter: { selectField: { lte: 'OPTION_1' } } },
- ],
- [FieldMetadataType.RATING]: [
- { filter: { ratingField: { eq: 'RATING_1' } } },
- { filter: { ratingField: { neq: 'RATING_1' } } },
- { filter: { ratingField: { in: ['RATING_1', 'RATING_2'] } } },
- { filter: { ratingField: { is: 'NULL' } } },
- { filter: { ratingField: { is: 'NOT_NULL' } } },
- { filter: { ratingField: { gt: 'RATING_1' } } },
- { filter: { ratingField: { gte: 'RATING_1' } } },
- { filter: { ratingField: { lt: 'RATING_1' } } },
- { filter: { ratingField: { lte: 'RATING_1' } } },
- ],
- [FieldMetadataType.MULTI_SELECT]: [
- { filter: { multiSelectField: { containsAny: ['OPTION_1'] } } },
- { filter: { multiSelectField: { is: 'NULL' } } },
- { filter: { multiSelectField: { is: 'NOT_NULL' } } },
- { filter: { multiSelectField: { isEmptyArray: true } } },
- ],
- [FieldMetadataType.ARRAY]: [
- { filter: { arrayField: { containsIlike: '%test%' } } },
- { filter: { arrayField: { is: 'NULL' } } },
- { filter: { arrayField: { is: 'NOT_NULL' } } },
- { filter: { arrayField: { isEmptyArray: true } } },
- ],
- [FieldMetadataType.RAW_JSON]: [
- { filter: { rawJsonField: { is: 'NULL' } } },
- { filter: { rawJsonField: { is: 'NOT_NULL' } } },
- { filter: { rawJsonField: { like: '%test%' } } },
- ],
- [FieldMetadataType.RELATION]: [
- { filter: { manyToOneRelationFieldId: { eq: TEST_UUID } } },
- { filter: { manyToOneRelationFieldId: { neq: TEST_UUID } } },
- { filter: { manyToOneRelationFieldId: { in: [TEST_UUID] } } },
- { filter: { manyToOneRelationFieldId: { is: 'NULL' } } },
- { filter: { manyToOneRelationFieldId: { is: 'NOT_NULL' } } },
- { filter: { manyToOneRelationFieldId: { eq: null } } },
- ],
- [FieldMetadataType.MORPH_RELATION]: [
- {
- filter: {
- [joinColumnNameForManyToOneMorphRelationField1]: { eq: TEST_UUID },
- },
- },
- {
- filter: {
- [joinColumnNameForManyToOneMorphRelationField1]: { neq: TEST_UUID },
- },
- },
- {
- filter: {
- [joinColumnNameForManyToOneMorphRelationField1]: { in: [TEST_UUID] },
- },
- },
- {
- filter: {
- [joinColumnNameForManyToOneMorphRelationField1]: { is: 'NULL' },
- },
- },
- {
- filter: {
- [joinColumnNameForManyToOneMorphRelationField1]: { is: 'NOT_NULL' },
- },
- },
- ],
- [FieldMetadataType.POSITION]: [
- { filter: { position: { eq: 1 } } },
- { filter: { position: { neq: 1 } } },
- { filter: { position: { gt: 0 } } },
- { filter: { position: { gte: 0 } } },
- { filter: { position: { lt: 10 } } },
- { filter: { position: { lte: 10 } } },
- { filter: { position: { in: [1, 2, 3] } } },
- { filter: { position: { is: 'NULL' } } },
- { filter: { position: { is: 'NOT_NULL' } } },
- {
- filter: { position: { eq: '1' } },
- expected: { position: { eq: 1 } },
- },
- ],
- [FieldMetadataType.FILES]: [
- { filter: { filesField: { is: 'NULL' } } },
- { filter: { filesField: { is: 'NOT_NULL' } } },
- { filter: { filesField: { like: '%test%' } } },
- ],
- [FieldMetadataType.RICH_TEXT]: [
- { filter: { richTextField: { markdown: { ilike: '%test%' } } } },
- ],
- [FieldMetadataType.ADDRESS]: [
- { filter: { addressField: { addressCity: { eq: 'Paris' } } } },
- { filter: { addressField: { addressCity: { like: '%Paris%' } } } },
- { filter: { addressField: { addressLat: { gt: 48.0 } } } },
- { filter: { addressField: { addressStreet1: { is: 'NULL' } } } },
- ],
- [FieldMetadataType.CURRENCY]: [
- { filter: { currencyField: { amountMicros: { eq: 1000000 } } } },
- { filter: { currencyField: { amountMicros: { gt: 0 } } } },
- { filter: { currencyField: { currencyCode: { eq: 'USD' } } } },
- { filter: { currencyField: { currencyCode: { is: 'NULL' } } } },
- ],
- [FieldMetadataType.EMAILS]: [
- { filter: { emailsField: { primaryEmail: { eq: '[email protected]' } } } },
- { filter: { emailsField: { primaryEmail: { like: '%@test.com' } } } },
- { filter: { emailsField: { primaryEmail: { is: 'NULL' } } } },
- ],
- [FieldMetadataType.PHONES]: [
- { filter: { phonesField: { primaryPhoneNumber: { eq: '1234567890' } } } },
- {
- filter: { phonesField: { primaryPhoneNumber: { like: '%123%' } } },
- },
- { filter: { phonesField: { primaryPhoneCountryCode: { eq: 'FR' } } } },
- { filter: { phonesField: { primaryPhoneNumber: { is: 'NULL' } } } },
- ],
- [FieldMetadataType.FULL_NAME]: [
- { filter: { fullNameField: { firstName: { eq: 'John' } } } },
- { filter: { fullNameField: { lastName: { like: '%Doe%' } } } },
- { filter: { fullNameField: { firstName: { is: 'NULL' } } } },
- ],
- [FieldMetadataType.LINKS]: [
- { filter: { linksField: { primaryLinkUrl: { eq: 'https://test.com' } } } },
- { filter: { linksField: { primaryLinkLabel: { like: '%test%' } } } },
- { filter: { linksField: { primaryLinkUrl: { is: 'NULL' } } } },
- ],
- [FieldMetadataType.ACTOR]: [
- { filter: { actorField: { source: { eq: 'MANUAL' } } } },
- { filter: { actorField: { name: { like: '%John%' } } } },
- { filter: { actorField: { workspaceMemberId: { eq: TEST_UUID } } } },
- { filter: { actorField: { workspaceMemberId: { is: 'NULL' } } } },
- ],
-};
diff --git a/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/filter-arg-processor.service.spec.ts b/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/filter-arg-processor.service.spec.ts
deleted file mode 100644
index 841a0315944..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-args-processors/filter-arg-processor/__tests__/filter-arg-processor.service.spec.ts
+++ /dev/null
@@ -1,461 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { FieldMetadataType, RelationType } from 'twenty-shared/types';
-
-import { fieldMetadataConfigByFieldName } from 'src/engine/api/common/common-args-processors/data-arg-processor/__tests__/constants/field-metadata-config-by-field-name.constant';
-import { FilterArgProcessorService } from 'src/engine/api/common/common-args-processors/filter-arg-processor/filter-arg-processor.service';
-import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
-import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
-
-import { failingFilterInputsByFieldMetadataType } from './constants/failing-filter-inputs-by-field-metadata-type.constant';
-import { successfulFilterInputsByFieldMetadataType } from './constants/successful-filter-inputs-by-field-metadata-type.constant';
-
-describe('FilterArgProcessorService', () => {
- let filterArgProcessorService: FilterArgProcessorService;
-
- const createFlatFieldMetadataMaps = (
- fieldNames: string[],
- ): FlatEntityMaps<FlatFieldMetadata> => {
- const byUniversalIdentifier: Record<string, FlatFieldMetadata> = {};
- const universalIdentifierById: Record<string, string> = {};
-
- for (const fieldName of fieldNames) {
- const config = fieldMetadataConfigByFieldName[fieldName];
-
- if (!config) {
- throw new Error(`No config found for field: ${fieldName}`);
- }
-
- const fieldId = `${fieldName}-id`;
- const universalId = `${fieldName}-universal-id`;
-
- byUniversalIdentifier[universalId] = {
- id: fieldId,
- name: config.name,
- type: config.type ?? FieldMetadataType.TEXT,
- isNullable: config.isNullable ?? true,
- objectMetadataId: 'object-id',
- universalIdentifier: universalId,
- options: config.options,
- settings: config.settings,
- defaultValue: config.defaultValue,
- } as FlatFieldMetadata;
-
- universalIdentifierById[fieldId] = universalId;
- }
-
- return {
- byUniversalIdentifier,
- universalIdentifierById,
- universalIdentifiersByApplicationId: {},
- } as unknown as FlatEntityMaps<FlatFieldMetadata>;
- };
-
- const createFlatObjectMetadata = (fieldNames: string[]): FlatObjectMetadata =>
- ({
- id: 'object-id',
- nameSingular: 'testObject',
- namePlural: 'testObjects',
- fieldIds: fieldNames.map((name) => `${name}-id`),
- universalIdentifier: 'test-object-universal-id',
- labelIdentifierFieldMetadataUniversalIdentifier: null,
- imageIdentifierFieldMetadataUniversalIdentifier: null,
- }) as unknown as FlatObjectMetadata;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [FilterArgProcessorService],
- }).compile();
-
- filterArgProcessorService = module.get<FilterArgProcessorService>(
- FilterArgProcessorService,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('failing filter inputs validation', () => {
- const fieldMetadataTypesToTest = Object.keys(
- failingFilterInputsByFieldMetadataType,
- ) as FieldMetadataType[];
-
- for (const fieldMetadataType of fieldMetadataTypesToTest) {
- const testCases =
- failingFilterInputsByFieldMetadataType[fieldMetadataType];
-
- if (!testCases) {
- continue;
- }
-
- describe(`${fieldMetadataType}`, () => {
- for (const [index, testCase] of testCases.entries()) {
- const fieldName = Object.keys(testCase.filter)[0];
-
- it(`should throw for invalid filter #${index + 1}: ${JSON.stringify(testCase.filter)}`, () => {
- const fieldNames = [fieldName];
-
- const flatFieldMetadataMaps =
- createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- expect(() =>
- filterArgProcessorService.process({
- filter: testCase.filter,
- flatObjectMetadata,
- flatFieldMetadataMaps,
- }),
- ).toThrowErrorMatchingSnapshot();
- });
- }
- });
- }
- });
-
- describe('successful filter inputs validation', () => {
- const fieldMetadataTypesToTest = Object.keys(
- successfulFilterInputsByFieldMetadataType,
- ) as FieldMetadataType[];
-
- for (const fieldMetadataType of fieldMetadataTypesToTest) {
- const testCases =
- successfulFilterInputsByFieldMetadataType[fieldMetadataType];
-
- if (!testCases) {
- continue;
- }
-
- describe(`${fieldMetadataType}`, () => {
- for (const [index, testCase] of testCases.entries()) {
- const fieldName = Object.keys(testCase.filter)[0];
-
- it(`should process valid filter #${index + 1}: ${JSON.stringify(testCase.filter)}`, () => {
- const fieldNames = [fieldName];
-
- const flatFieldMetadataMaps =
- createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- const result = filterArgProcessorService.process({
- filter: testCase.filter,
- flatObjectMetadata,
- flatFieldMetadataMaps,
- });
-
- const expectedResult = testCase.expected ?? testCase.filter;
-
- expect(result).toBeDefined();
- expect(result).toEqual(expectedResult);
- });
- }
- });
- }
- });
-
- describe('logical operators', () => {
- it('should process filter with "and" operator', () => {
- const fieldNames = ['textField', 'numberField'];
- const flatFieldMetadataMaps = createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- const filter = {
- and: [{ textField: { eq: 'test' } }, { numberField: { gt: 0 } }],
- };
-
- const result = filterArgProcessorService.process({
- filter,
- flatObjectMetadata,
- flatFieldMetadataMaps,
- });
-
- expect(result).toEqual(filter);
- });
-
- it('should process filter with "or" operator', () => {
- const fieldNames = ['textField', 'numberField'];
- const flatFieldMetadataMaps = createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- const filter = {
- or: [{ textField: { eq: 'test' } }, { numberField: { gt: 0 } }],
- };
-
- const result = filterArgProcessorService.process({
- filter,
- flatObjectMetadata,
- flatFieldMetadataMaps,
- });
-
- expect(result).toEqual(filter);
- });
-
- it('should process filter with "not" operator', () => {
- const fieldNames = ['textField'];
- const flatFieldMetadataMaps = createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- const filter = {
- not: { textField: { eq: 'test' } },
- };
-
- const result = filterArgProcessorService.process({
- filter,
- flatObjectMetadata,
- flatFieldMetadataMaps,
- });
-
- expect(result).toEqual(filter);
- });
-
- it('should process nested logical operators', () => {
- const fieldNames = ['textField', 'numberField'];
- const flatFieldMetadataMaps = createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- const filter = {
- and: [
- {
- or: [
- { textField: { eq: 'test1' } },
- { textField: { eq: 'test2' } },
- ],
- },
- { numberField: { gt: 0 } },
- ],
- };
-
- const result = filterArgProcessorService.process({
- filter,
- flatObjectMetadata,
- flatFieldMetadataMaps,
- });
-
- expect(result).toEqual(filter);
- });
- });
-
- describe('value transformation', () => {
- it('should coerce string to number for NUMBER field', () => {
- const fieldNames = ['numberField'];
- const flatFieldMetadataMaps = createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- const result = filterArgProcessorService.process({
- filter: { numberField: { eq: '42' } },
- flatObjectMetadata,
- flatFieldMetadataMaps,
- });
-
- expect(result).toEqual({ numberField: { eq: 42 } });
- });
-
- it('should coerce string to boolean for BOOLEAN field', () => {
- const fieldNames = ['booleanField'];
- const flatFieldMetadataMaps = createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- const result = filterArgProcessorService.process({
- filter: { booleanField: { eq: 'true' } },
- flatObjectMetadata,
- flatFieldMetadataMaps,
- });
-
- expect(result).toEqual({ booleanField: { eq: true } });
- });
-
- it('should preserve null values in "in" operator', () => {
- const fieldNames = ['numberField'];
- const flatFieldMetadataMaps = createFlatFieldMetadataMaps(fieldNames);
- const flatObjectMetadata = createFlatObjectMetadata(fieldNames);
-
- const result = filterArgProcessorService.process({
- filter: { numberField: { in: [1, null, 3] } },
- flatObjectMetadata,
- flatFieldMetadataMaps,
- });
-
- expect(result).toEqual({ numberField: { in: [1, null, 3] } });
- });
- });
-
- describe('relation traversal', () => {
- // `source` has a MANY_TO_ONE `target` relation; `target` carries a
- // CURRENCY composite and a TEXT field.
- const createRelationFixture = () => {
- const sourceObjectId = 'source-obj-id';
- const targetObjectId = 'target-obj-id';
- const sourceUniversalId = 'source-obj-universal-id';
- const targetUniversalId = 'target-obj-universal-id';
-
- const relationFieldId = 'relation-field-id';
- const targetTextFieldId = 'target-text-field-id';
- const targetCurrencyFieldId = 'target-currency-field-id';
-
- const flatFieldMetadataMaps = {
- byUniversalIdentifier: {
- 'relation-field-uid': {
- id: relationFieldId,
- name: 'target',
- type: FieldMetadataType.RELATION,
- isNullable: true,
- objectMetadataId: sourceObjectId,
- universalIdentifier: 'relation-field-uid',
- relationTargetObjectMetadataId: targetObjectId,
- settings: {
- relationType: RelationType.MANY_TO_ONE,
- joinColumnName: 'targetId',
- },
- },
- 'target-text-uid': {
- id: targetTextFieldId,
- name: 'name',
- type: FieldMetadataType.TEXT,
- isNullable: true,
- objectMetadataId: targetObjectId,
- universalIdentifier: 'target-text-uid',
- },
- 'target-currency-uid': {
- id: targetCurrencyFieldId,
- name: 'annualRevenue',
- type: FieldMetadataType.CURRENCY,
- isNullable: true,
- objectMetadataId: targetObjectId,
- universalIdentifier: 'target-currency-uid',
- },
- },
- universalIdentifierById: {
- [relationFieldId]: 'relation-field-uid',
- [targetTextFieldId]: 'target-text-uid',
- [targetCurrencyFieldId]: 'target-currency-uid',
- },
- universalIdentifiersByApplicationId: {},
- } as unknown as FlatEntityMaps<FlatFieldMetadata>;
-
- const sourceObjectMetadata = {
- id: sourceObjectId,
- nameSingular: 'sourceObject',
- namePlural: 'sourceObjects',
- fieldIds: [relationFieldId],
- universalIdentifier: sourceUniversalId,
- labelIdentifierFieldMetadataUniversalIdentifier: null,
- imageIdentifierFieldMetadataUniversalIdentifier: null,
- } as unknown as FlatObjectMetadata;
-
- const targetObjectMetadata = {
- id: targetObjectId,
- nameSingular: 'targetObject',
- namePlural: 'targetObjects',
- fieldIds: [targetTextFieldId, targetCurrencyFieldId],
- universalIdentifier: targetUniversalId,
- labelIdentifierFieldMetadataUniversalIdentifier: null,
- imageIdentifierFieldMetadataUniversalIdentifier: null,
- } as unknown as FlatObjectMetadata;
-
- const flatObjectMetadataMaps = {
- byUniversalIdentifier: {
- [sourceUniversalId]: sourceObjectMetadata,
- [targetUniversalId]: targetObjectMetadata,
- },
- universalIdentifierById: {
- [sourceObjectId]: sourceUniversalId,
- [targetObjectId]: targetUniversalId,
- },
- universalIdentifiersByApplicationId: {},
- } as unknown as FlatEntityMaps<FlatObjectMetadata>;
-
- return {
- flatFieldMetadataMaps,
- flatObjectMetadataMaps,
- sourceObjectMetadata,
- };
- };
-
- it('should accept a relation traversal onto a scalar field on the target', () => {
- const {
- flatFieldMetadataMaps,
- flatObjectMetadataMaps,
- sourceObjectMetadata,
- } = createRelationFixture();
-
- const filter = { target: { name: { eq: 'Airbnb' } } };
-
- const result = filterArgProcessorService.process({
- filter,
- flatObjectMetadata: sourceObjectMetadata,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(result).toEqual({ target: { name: { eq: 'Airbnb' } } });
- });
-
- it('should accept a relation traversal onto a composite sub-field without tripping the depth cap', () => {
- // Composite sub-field navigation is not a relation hop, so it must
- // not count against MAX_RELATION_FILTER_DEPTH = 1.
- const {
- flatFieldMetadataMaps,
- flatObjectMetadataMaps,
- sourceObjectMetadata,
- } = createRelationFixture();
-
- const filter = {
- target: {
- annualRevenue: { amountMicros: { gte: 1_000_000 } },
- },
- };
-
- const result = filterArgProcessorService.process({
- filter,
- flatObjectMetadata: sourceObjectMetadata,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(result).toEqual({
- target: {
- annualRevenue: { amountMicros: { gte: 1_000_000 } },
- },
- });
- });
-
- it('should surface a field-not-found error when a relation filter uses an operator key as if it were a target field', () => {
- // `{ target: { eq: ... } }` recurses into the target object's
- // metadata and fails like any unknown field on that object.
- const {
- flatFieldMetadataMaps,
- flatObjectMetadataMaps,
- sourceObjectMetadata,
- } = createRelationFixture();
-
- expect(() =>
- filterArgProcessorService.process({
- filter: {
- target: { eq: '00000000-0000-0000-0000-000000000000' },
- },
- flatObjectMetadata: sourceObjectMetadata,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- }),
- ).toThrow(/targetObject doesn't have any "eq" field/);
- });
-
- it('should fall back to the FK-column hint when no object metadata maps are available', () => {
- // Without object metadata maps the recursion can't resolve the target,
- // so the only useful guidance left is "use the FK column".
- const { flatFieldMetadataMaps, sourceObjectMetadata } =
- createRelationFixture();
-
- expect(() =>
- filterArgProcessorService.process({
- filter: {
- target: { name: { eq: 'Anything' } },
- },
- flatObjectMetadata: sourceObjectMetadata,
- flatFieldMetadataMaps,
- }),
- ).toThrow(/use "targetId" instead/);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/api/common/common-result-getters/__tests__/common-result-getters.service.spec.ts b/packages/twenty-server/src/engine/api/common/common-result-getters/__tests__/common-result-getters.service.spec.ts
deleted file mode 100644
index 45816a0edbb..00000000000
--- a/packages/twenty-server/src/engine/api/common/common-result-getters/__tests__/common-result-getters.service.spec.ts
+++ /dev/null
@@ -1,250 +0,0 @@
-import {
- FieldMetadataType,
- FileFolder,
- RelationType,
- type ObjectRecord,
-} from 'twenty-shared/types';
-
-import { CommonResultGettersService } from 'src/engine/api/common/common-result-getters/common-result-getters.service';
-import { getFlatFieldsFromFlatObjectMetadata } from 'src/engine/api/graphql/workspace-schema-builder/utils/get-flat-fields-for-flat-object-metadata.util';
-import { type FileUrlService } from 'src/engine/core-modules/file/file-url/file-url.service';
-import { createEmptyFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-flat-entity-maps.constant';
-import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
-import { addFlatEntityToFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/add-flat-entity-to-flat-entity-maps-or-throw.util';
-import { getFlatFieldMetadataMock } from 'src/engine/metadata-modules/flat-field-metadata/__mocks__/get-flat-field-metadata.mock';
-import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { getFlatObjectMetadataMock } from 'src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock';
-import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
-
-jest.mock(
- 'src/engine/api/graphql/workspace-schema-builder/utils/get-flat-fields-for-flat-object-metadata.util',
- () => {
- const actual = jest.requireActual(
- 'src/engine/api/graphql/workspace-schema-builder/utils/get-flat-fields-for-flat-object-metadata.util',
- );
-
- return {
- ...actual,
- getFlatFieldsFromFlatObjectMetadata: jest.fn(
- actual.getFlatFieldsFromFlatObjectMetadata,
- ),
- };
- },
-);
-
-const createField = ({
- id,
- objectMetadataId,
- ...overrides
-}: Pick<FlatFieldMetadata, 'id' | 'name' | 'objectMetadataId' | 'type'> &
- Partial<FlatFieldMetadata>): FlatFieldMetadata =>
- getFlatFieldMetadataMock({
- id,
- universalIdentifier: `${id}-universal-identifier`,
- objectMetadataId,
- objectMetadataUniversalIdentifier: `${objectMetadataId}-universal-identifier`,
- ...overrides,
- });
-
-const buildFlatEntityMaps = <
- TFlatEntity extends FlatFieldMetadata | FlatObjectMetadata,
->(
- flatEntities: TFlatEntity[],
-): FlatEntityMaps<TFlatEntity> =>
- flatEntities.reduce(
- (maps, flatEntity) =>
- addFlatEntityToFlatEntityMapsOrThrow({
- flatEntity,
- flatEntityMaps: maps,
- }),
- createEmptyFlatEntityMaps() as FlatEntityMaps<TFlatEntity>,
- );
-
-describe('CommonResultGettersService', () => {
- const signFileByIdUrl = jest.fn(
- async ({ fileId }: { fileId: string }) => `signed-${fileId}`,
- );
- const fileUrlService = {
- signFileByIdUrl,
- } as unknown as FileUrlService;
-
- let service: CommonResultGettersService;
-
- beforeEach(() => {
- service = new CommonResultGettersService(fileUrlService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('runs a shared field handler once and preserves fields without metadata', async () => {
- const objectMetadataId = 'document-object-id';
- const filesField = createField({
- id: 'document-files-field-id',
- name: 'files',
- objectMetadataId,
- type: FieldMetadataType.FILES,
- });
- const attachmentsField = createField({
- id: 'document-attachments-field-id',
- name: 'attachments',
- objectMetadataId,
- type: FieldMetadataType.FILES,
- });
- const objectMetadata = getFlatObjectMetadataMock({
- id: objectMetadataId,
- universalIdentifier: 'document-object-universal-identifier',
- nameSingular: 'document',
- namePlural: 'documents',
- fieldIds: [filesField.id, attachmentsField.id],
- });
- const flatFieldMetadataMaps = buildFlatEntityMaps([
- filesField,
- attachmentsField,
- ]);
- const flatObjectMetadataMaps =
- createEmptyFlatEntityMaps() as FlatEntityMaps<FlatObjectMetadata>;
- const record: ObjectRecord = {
- id: 'document-id',
- files: [
- {
- fileId: 'file-id',
- label: 'document',
- extension: 'pdf',
- },
- ],
- attachments: [
- {
- fileId: 'attachment-id',
- label: 'attachment',
- extension: 'pdf',
- },
- ],
- ownerId: 'owner-id',
- };
-
- const result = await service.processRecord(
- record,
- objectMetadata,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- 'workspace-id',
- );
-
- expect(result).toEqual({
- ...record,
- files: [
- {
- fileId: 'file-id',
- label: 'document',
- extension: 'pdf',
- url: 'signed-file-id',
- },
- ],
- attachments: [
- {
- fileId: 'attachment-id',
- label: 'attachment',
- extension: 'pdf',
- url: 'signed-attachment-id',
- },
- ],
- });
- expect(signFileByIdUrl).toHaveBeenCalledTimes(2);
- expect(signFileByIdUrl).toHaveBeenCalledWith({
- fileId: 'file-id',
- workspaceId: 'workspace-id',
- fileFolder: FileFolder.FilesField,
- });
- expect(signFileByIdUrl).toHaveBeenCalledWith({
- fileId: 'attachment-id',
- workspaceId: 'workspace-id',
- fileFolder: FileFolder.FilesField,
- });
- });
-
- it('resolves field metadata once per object type within a single invocation', async () => {
- const companyObjectMetadataId = 'company-object-id';
- const personObjectMetadataId = 'person-object-id';
- const companyNameField = createField({
- id: 'company-name-field-id',
- name: 'name',
- objectMetadataId: companyObjectMetadataId,
- type: FieldMetadataType.TEXT,
- });
- const companyPeopleField = createField({
- id: 'company-people-field-id',
- name: 'people',
- objectMetadataId: companyObjectMetadataId,
- type: FieldMetadataType.RELATION,
- relationTargetObjectMetadataId: personObjectMetadataId,
- settings: { relationType: RelationType.ONE_TO_MANY },
- });
- const personNameField = createField({
- id: 'person-name-field-id',
- name: 'name',
- objectMetadataId: personObjectMetadataId,
- type: FieldMetadataType.TEXT,
- });
- const companyObjectMetadata = getFlatObjectMetadataMock({
- id: companyObjectMetadataId,
- universalIdentifier: 'company-object-universal-identifier',
- nameSingular: 'company',
- namePlural: 'companies',
- fieldIds: [companyNameField.id, companyPeopleField.id],
- });
- const personObjectMetadata = getFlatObjectMetadataMock({
- id: personObjectMetadataId,
- universalIdentifier: 'person-object-universal-identifier',
- nameSingular: 'person',
- namePlural: 'people',
- fieldIds: [personNameField.id],
- });
- const flatFieldMetadataMaps = buildFlatEntityMaps([
- companyNameField,
- companyPeopleField,
- personNameField,
- ]);
- const flatObjectMetadataMaps = buildFlatEntityMaps([
- companyObjectMetadata,
- personObjectMetadata,
- ]);
- const records: ObjectRecord[] = [
- {
- id: 'company-1',
- name: 'Acme',
- people: [
- { id: 'person-1', name: 'Alice' },
- { id: 'person-2', name: 'Bob' },
- ],
- },
- {
- id: 'company-2',
- name: 'Globex',
- people: [{ id: 'person-3', name: 'Carol' }],
- },
- ];
-
- const result = await service.processRecordArray(
- records,
- companyObjectMetadata,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- 'workspace-id',
- );
-
- expect(result).toEqual(records);
- expect(getFlatFieldsFromFlatObjectMetadata).toHaveBeenCalledTimes(2);
-
- await service.processRecordArray(
- records,
- companyObjectMetadata,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- 'workspace-id',
- );
-
- expect(getFlatFieldsFromFlatObjectMetadata).toHaveBeenCalledTimes(4);
- });
-});
diff --git a/packages/twenty-server/src/engine/api/graphql/__tests__/scalars-explorer.service.spec.ts b/packages/twenty-server/src/engine/api/graphql/__tests__/scalars-explorer.service.spec.ts
deleted file mode 100644
index 9b58bedeaee..00000000000
--- a/packages/twenty-server/src/engine/api/graphql/__tests__/scalars-explorer.service.spec.ts
+++ /dev/null
@@ -1,15 +0,0 @@
-import { ScalarsExplorerService } from 'src/engine/api/graphql/services/scalars-explorer.service';
-import { ConnectionCursorScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars';
-
-describe('ScalarsExplorerService', () => {
- it('registers the ConnectionCursor implementation used by rebuilt workspace schemas', () => {
- const scalar = new ScalarsExplorerService().getScalarImplementation(
- 'ConnectionCursor',
- );
-
- expect(scalar).toBe(ConnectionCursorScalarType);
- expect(() => scalar?.parseValue(42)).toThrow(
- 'ConnectionCursor must be a string',
- );
- });
-});
diff --git a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/services/__tests__/type-mapper.service.spec.ts b/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/services/__tests__/type-mapper.service.spec.ts
deleted file mode 100644
index 6fe0f9c8dd9..00000000000
--- a/packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/services/__tests__/type-mapper.service.spec.ts
+++ /dev/null
@@ -1,54 +0,0 @@
-import { isInputObjectType } from 'graphql';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { TypeMapperService } from 'src/engine/api/graphql/workspace-schema-builder/services/type-mapper.service';
-
-describe('TypeMapperService', () => {
- const typeMapperService = new TypeMapperService();
-
- describe('mapToFilterType', () => {
- it('should map DATE_TIME to a DateTimeFilter input object with operators', () => {
- const filterType = typeMapperService.mapToFilterType(
- FieldMetadataType.DATE_TIME,
- );
-
- if (!isInputObjectType(filterType)) {
- throw new Error('Expected DATE_TIME filter type to be an input object');
- }
-
- expect(filterType.name).toBe('DateTimeFilter');
-
- const fields = filterType.getFields();
-
- expect(Object.keys(fields).sort()).toEqual([
- 'eq',
- 'gt',
- 'gte',
- 'in',
- 'is',
- 'lt',
- 'lte',
- 'neq',
- ]);
-
- for (const operator of ['eq', 'gt', 'gte', 'lt', 'lte', 'neq']) {
- expect(fields[operator].type.toString()).toBe('DateTime');
- }
-
- expect(fields.in.type.toString()).toBe('[DateTime!]');
- expect(fields.is.type.toString()).toBe('FilterIs');
- });
-
- it('should map DATE to a DateFilter input object', () => {
- const filterType = typeMapperService.mapToFilterType(
- FieldMetadataType.DATE,
- );
-
- if (!isInputObjectType(filterType)) {
- throw new Error('Expected DATE filter type to be an input object');
- }
-
- expect(filterType.name).toBe('DateFilter');
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/api/mcp/services/__tests__/mcp-protocol.service.spec.ts b/packages/twenty-server/src/engine/api/mcp/services/__tests__/mcp-protocol.service.spec.ts
deleted file mode 100644
index 41789f0926d..00000000000
--- a/packages/twenty-server/src/engine/api/mcp/services/__tests__/mcp-protocol.service.spec.ts
+++ /dev/null
@@ -1,550 +0,0 @@
-import { HttpException, HttpStatus } from '@nestjs/common';
-import { Test, type TestingModule } from '@nestjs/testing';
-import { FieldActorSource } from 'twenty-shared/types';
-
-import { JSON_RPC_ERROR_CODE } from 'src/engine/api/mcp/constants/json-rpc-error-code.const';
-import { MCP_CLOSED_WORLD_READ_ONLY_TOOL_ANNOTATIONS } from 'src/engine/api/mcp/constants/mcp-closed-world-read-only-tool-annotations.const';
-import { MCP_EXECUTE_TOOL_ANNOTATIONS } from 'src/engine/api/mcp/constants/mcp-execute-tool-annotations.const';
-import { MCP_OPEN_WORLD_READ_ONLY_TOOL_ANNOTATIONS } from 'src/engine/api/mcp/constants/mcp-open-world-read-only-tool-annotations.const';
-import { MCP_PROTOCOL_VERSION } from 'src/engine/api/mcp/constants/mcp-protocol-version.const';
-import { MCP_SERVER_INFO } from 'src/engine/api/mcp/constants/mcp-server-info.const';
-import { type JsonRpc } from 'src/engine/api/mcp/dtos/json-rpc';
-import { McpInstructionBuilderService } from 'src/engine/api/mcp/services/mcp-instruction-builder.service';
-import { McpProtocolService } from 'src/engine/api/mcp/services/mcp-protocol.service';
-import { McpToolExecutorService } from 'src/engine/api/mcp/services/mcp-tool-executor.service';
-import { LIST_OBJECT_METADATA_NAMES_TOOL_NAME } from 'src/engine/api/mcp/tools/list-object-metadata-names.tool';
-import { LIST_SKILLS_TOOL_NAME } from 'src/engine/api/mcp/tools/list-skills.tool';
-import { type McpToolAnnotations } from 'src/engine/api/mcp/types/mcp-tool-annotations.type';
-import { type FlatApiKey } from 'src/engine/core-modules/api-key/types/flat-api-key.type';
-import { ApiKeyRoleService } from 'src/engine/core-modules/api-key/services/api-key-role.service';
-import { EXECUTE_TOOL_TOOL_NAME } from 'src/engine/core-modules/tool-provider/tools/execute-tool.tool';
-import { GET_TOOL_CATALOG_TOOL_NAME } from 'src/engine/core-modules/tool-provider/tools/get-tool-catalog.tool';
-import { LEARN_TOOLS_TOOL_NAME } from 'src/engine/core-modules/tool-provider/tools/learn-tools.tool';
-import { LOAD_SKILL_TOOL_NAME } from 'src/engine/core-modules/tool-provider/tools/load-skill.tool';
-import { ToolRegistryService } from 'src/engine/core-modules/tool-provider/services/tool-registry.service';
-import { type FlatWorkspace } from 'src/engine/core-modules/workspace/types/flat-workspace.type';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { SkillService } from 'src/engine/metadata-modules/skill/skill.service';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';
-
-describe('McpProtocolService', () => {
- let service: McpProtocolService;
- let _toolRegistryService: jest.Mocked<ToolRegistryService>;
- let userRoleService: jest.Mocked<UserRoleService>;
- let mcpToolExecutorService: jest.Mocked<McpToolExecutorService>;
- let apiKeyRoleService: jest.Mocked<ApiKeyRoleService>;
-
- const mockWorkspace = { id: 'workspace-1' } as FlatWorkspace;
- const mockUserWorkspaceId = 'user-workspace-1';
- const mockRoleId = 'role-1';
- const mockAdminRoleId = 'admin-role-1';
- const mockApiKey = {
- id: 'api-key-1',
- workspaceId: mockWorkspace.id,
- } as FlatApiKey;
-
- const EXPECTED_MCP_TOOL_NAMES = [
- LEARN_TOOLS_TOOL_NAME,
- EXECUTE_TOOL_TOOL_NAME,
- GET_TOOL_CATALOG_TOOL_NAME,
- LOAD_SKILL_TOOL_NAME,
- LIST_OBJECT_METADATA_NAMES_TOOL_NAME,
- LIST_SKILLS_TOOL_NAME,
- 'search_help_center',
- ] as const;
-
- const EXPECTED_MCP_TOOL_ANNOTATIONS: Record<
- (typeof EXPECTED_MCP_TOOL_NAMES)[number],
- McpToolAnnotations
- > = {
- [LEARN_TOOLS_TOOL_NAME]: MCP_CLOSED_WORLD_READ_ONLY_TOOL_ANNOTATIONS,
- [EXECUTE_TOOL_TOOL_NAME]: MCP_EXECUTE_TOOL_ANNOTATIONS,
- [GET_TOOL_CATALOG_TOOL_NAME]: MCP_CLOSED_WORLD_READ_ONLY_TOOL_ANNOTATIONS,
- [LOAD_SKILL_TOOL_NAME]: MCP_CLOSED_WORLD_READ_ONLY_TOOL_ANNOTATIONS,
- [LIST_OBJECT_METADATA_NAMES_TOOL_NAME]:
- MCP_CLOSED_WORLD_READ_ONLY_TOOL_ANNOTATIONS,
- [LIST_SKILLS_TOOL_NAME]: MCP_CLOSED_WORLD_READ_ONLY_TOOL_ANNOTATIONS,
- search_help_center: MCP_OPEN_WORLD_READ_ONLY_TOOL_ANNOTATIONS,
- };
-
- beforeEach(async () => {
- const mockSearchHelpCenterTool = {
- description: 'Search help center',
- inputSchema: { jsonSchema: { type: 'object' } },
- execute: jest.fn(),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- McpProtocolService,
- {
- provide: ToolRegistryService,
- useValue: {
- buildToolIndex: jest.fn().mockResolvedValue([]),
- getToolsByName: jest.fn().mockResolvedValue({
- search_help_center: mockSearchHelpCenterTool,
- }),
- getToolInfo: jest.fn().mockResolvedValue([]),
- resolveAndExecute: jest.fn(),
- },
- },
- {
- provide: UserRoleService,
- useValue: { getRoleIdForUserWorkspace: jest.fn() },
- },
- {
- provide: McpToolExecutorService,
- useValue: {
- handleToolCall: jest.fn(),
- handleToolsListing: jest.fn(),
- },
- },
- {
- provide: ApiKeyRoleService,
- useValue: {
- getRoleIdForApiKeyId: jest.fn().mockResolvedValue(mockAdminRoleId),
- },
- },
- {
- provide: SkillService,
- useValue: {
- findFlatSkillsByNames: jest.fn().mockResolvedValue([]),
- findAllFlatSkills: jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: McpInstructionBuilderService,
- useValue: {
- buildInstructions: jest.fn().mockResolvedValue('mock instructions'),
- },
- },
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn().mockResolvedValue({
- flatObjectMetadataMaps: { byUniversalIdentifier: {} },
- }),
- },
- },
- {
- provide: WorkspaceCacheService,
- useValue: {
- getOrRecompute: jest.fn().mockResolvedValue({
- flatWorkspaceMemberMaps: {
- idByUserId: {},
- byId: {},
- },
- }),
- },
- },
- ],
- }).compile();
-
- service = module.get<McpProtocolService>(McpProtocolService);
- _toolRegistryService = module.get(ToolRegistryService);
- userRoleService = module.get(UserRoleService);
- mcpToolExecutorService = module.get(McpToolExecutorService);
- apiKeyRoleService = module.get(ApiKeyRoleService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('handleInitialize', () => {
- it('should return spec-compliant initialization response', async () => {
- const requestId = '123';
- const result = await service.handleInitialize(
- requestId,
- mockWorkspace.id,
- );
-
- expect(result).toEqual({
- id: requestId,
- jsonrpc: '2.0',
- result: {
- protocolVersion: MCP_PROTOCOL_VERSION,
- capabilities: {
- tools: { listChanged: false },
- resources: { listChanged: false },
- prompts: { listChanged: false },
- },
- serverInfo: MCP_SERVER_INFO,
- instructions: expect.any(String),
- },
- });
- });
- });
-
- describe('getRoleId', () => {
- it('should return role ID when available', async () => {
- userRoleService.getRoleIdForUserWorkspace.mockResolvedValue(mockRoleId);
-
- const result = await service.getRoleId('workspace-1', 'user-workspace-1');
-
- expect(result).toBe(mockRoleId);
- expect(userRoleService.getRoleIdForUserWorkspace).toHaveBeenCalledWith({
- workspaceId: 'workspace-1',
- userWorkspaceId: 'user-workspace-1',
- });
- });
-
- it('should throw when userWorkspaceId is missing and no apiKey is provided', async () => {
- await expect(service.getRoleId('workspace-1', undefined)).rejects.toThrow(
- new HttpException('User workspace ID missing', HttpStatus.FORBIDDEN),
- );
- });
-
- it('should throw when role ID is missing', async () => {
- userRoleService.getRoleIdForUserWorkspace.mockResolvedValue(
- undefined as unknown as string,
- );
-
- await expect(
- service.getRoleId('workspace-1', 'user-workspace-1'),
- ).rejects.toThrow(
- new HttpException('Role ID missing', HttpStatus.FORBIDDEN),
- );
- });
-
- it('should return role ID from ApiKeyRoleService when apiKey is provided', async () => {
- const result = await service.getRoleId(
- 'workspace-1',
- undefined,
- mockApiKey,
- );
-
- expect(result).toBe(mockAdminRoleId);
- expect(apiKeyRoleService.getRoleIdForApiKeyId).toHaveBeenCalledWith(
- mockApiKey.id,
- 'workspace-1',
- );
- });
- });
-
- describe('handleMCPCoreQuery', () => {
- it('should handle initialize method', async () => {
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'initialize',
- id: '123',
- };
-
- const result = await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- result: {
- protocolVersion: MCP_PROTOCOL_VERSION,
- capabilities: {
- tools: { listChanged: false },
- resources: { listChanged: false },
- prompts: { listChanged: false },
- },
- serverInfo: MCP_SERVER_INFO,
- instructions: expect.any(String),
- },
- });
- });
-
- it('should return null for notifications (no id)', async () => {
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'notifications/initialized',
- };
-
- const result = await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(result).toBeNull();
- });
-
- it('should build the meta-tool set by name and pass it to executor for tools/call', async () => {
- userRoleService.getRoleIdForUserWorkspace.mockResolvedValue(mockRoleId);
-
- const mockToolCallResponse = {
- id: '123',
- jsonrpc: '2.0',
- result: {
- content: [{ type: 'text', text: '{}' }],
- isError: false,
- },
- };
-
- mcpToolExecutorService.handleToolCall.mockResolvedValue(
- mockToolCallResponse,
- );
-
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'tools/call',
- params: {
- name: 'execute_tool',
- arguments: { toolName: 'find_many_companies', arguments: {} },
- },
- id: '123',
- };
-
- await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(mcpToolExecutorService.handleToolCall).toHaveBeenCalledWith(
- '123',
- expect.objectContaining(
- Object.fromEntries(
- EXPECTED_MCP_TOOL_NAMES.map((name) => [
- name,
- expect.objectContaining({
- description: expect.any(String),
- annotations: EXPECTED_MCP_TOOL_ANNOTATIONS[name],
- execute: expect.any(Function),
- }),
- ]),
- ),
- ),
- mockRequest.params,
- undefined,
- );
-
- const [, toolSet] = mcpToolExecutorService.handleToolCall.mock.calls[0];
-
- expect(Object.keys(toolSet).sort()).toEqual(
- [...EXPECTED_MCP_TOOL_NAMES].sort(),
- );
- });
-
- it('should build the meta-tool set by name and pass it to executor for tools/list', async () => {
- userRoleService.getRoleIdForUserWorkspace.mockResolvedValue(mockRoleId);
-
- mcpToolExecutorService.handleToolsListing.mockReturnValue({
- id: '123',
- jsonrpc: '2.0',
- result: { tools: [] },
- });
-
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'tools/list',
- id: '123',
- };
-
- await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(mcpToolExecutorService.handleToolsListing).toHaveBeenCalledWith(
- '123',
- expect.objectContaining(
- Object.fromEntries(
- EXPECTED_MCP_TOOL_NAMES.map((name) => [
- name,
- expect.objectContaining({
- description: expect.any(String),
- annotations: EXPECTED_MCP_TOOL_ANNOTATIONS[name],
- }),
- ]),
- ),
- ),
- );
-
- const [, toolSet] =
- mcpToolExecutorService.handleToolsListing.mock.calls[0];
-
- expect(Object.keys(toolSet).sort()).toEqual(
- [...EXPECTED_MCP_TOOL_NAMES].sort(),
- );
- });
-
- it('should pass actorContext with FieldActorSource.AGENT to getToolsByName', async () => {
- userRoleService.getRoleIdForUserWorkspace.mockResolvedValue(mockRoleId);
-
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'tools/list',
- id: '123',
- };
-
- await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(_toolRegistryService.getToolsByName).toHaveBeenCalledWith(
- expect.any(Array),
- expect.objectContaining({
- actorContext: expect.objectContaining({
- source: FieldActorSource.AGENT,
- }),
- }),
- );
- });
-
- it('should return prompts list without role resolution', async () => {
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'prompts/list',
- id: '123',
- };
-
- const result = await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- result: { prompts: [] },
- });
- expect(userRoleService.getRoleIdForUserWorkspace).not.toHaveBeenCalled();
- });
-
- it('should return resources list without role resolution', async () => {
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'resources/list',
- id: '123',
- };
-
- const result = await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- result: { resources: [] },
- });
- expect(userRoleService.getRoleIdForUserWorkspace).not.toHaveBeenCalled();
- });
-
- it('should return method not found for unknown methods', async () => {
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'unknown/method',
- id: '123',
- };
-
- const result = await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- error: {
- code: JSON_RPC_ERROR_CODE.METHOD_NOT_FOUND,
- message: "Method 'unknown/method' not found",
- },
- });
- });
-
- it('should handle tools/call with apiKey authentication', async () => {
- const mockToolCallResponse = {
- id: '123',
- jsonrpc: '2.0',
- result: { content: [{ type: 'text', text: '{}' }], isError: false },
- };
-
- mcpToolExecutorService.handleToolCall.mockResolvedValue(
- mockToolCallResponse,
- );
-
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'tools/call',
- params: { name: 'execute_tool', arguments: {} },
- id: '123',
- };
-
- const result = await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- apiKey: mockApiKey,
- });
-
- expect(result).toEqual(mockToolCallResponse);
- expect(apiKeyRoleService.getRoleIdForApiKeyId).toHaveBeenCalledWith(
- mockApiKey.id,
- mockWorkspace.id,
- );
- });
-
- it('should wrap unexpected errors with INTERNAL_ERROR code', async () => {
- userRoleService.getRoleIdForUserWorkspace.mockResolvedValue(mockRoleId);
-
- mcpToolExecutorService.handleToolCall.mockRejectedValue(
- new Error('Something went wrong'),
- );
-
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'tools/call',
- params: { name: 'execute_tool', arguments: {} },
- id: '123',
- };
-
- const result = await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- error: {
- code: JSON_RPC_ERROR_CODE.INTERNAL_ERROR,
- message: 'Something went wrong',
- },
- });
- });
-
- it('should wrap HttpException errors with SERVER_ERROR code', async () => {
- userRoleService.getRoleIdForUserWorkspace.mockRejectedValue(
- new HttpException('Role ID missing', HttpStatus.FORBIDDEN),
- );
-
- const mockRequest: JsonRpc = {
- jsonrpc: '2.0',
- method: 'tools/call',
- params: { name: 'execute_tool', arguments: {} },
- id: '123',
- };
-
- const result = await service.handleMCPCoreQuery(mockRequest, {
- workspace: mockWorkspace,
- userWorkspaceId: mockUserWorkspaceId,
- apiKey: undefined,
- });
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- error: {
- code: JSON_RPC_ERROR_CODE.SERVER_ERROR,
- message: 'Role ID missing',
- },
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/api/mcp/services/__tests__/mcp-tool-executor.service.spec.ts b/packages/twenty-server/src/engine/api/mcp/services/__tests__/mcp-tool-executor.service.spec.ts
deleted file mode 100644
index d1d24004936..00000000000
--- a/packages/twenty-server/src/engine/api/mcp/services/__tests__/mcp-tool-executor.service.spec.ts
+++ /dev/null
@@ -1,213 +0,0 @@
-import { JSON_RPC_ERROR_CODE } from 'src/engine/api/mcp/constants/json-rpc-error-code.const';
-import { MCP_CLOSED_WORLD_READ_ONLY_TOOL_ANNOTATIONS } from 'src/engine/api/mcp/constants/mcp-closed-world-read-only-tool-annotations.const';
-import {
- MCP_PROGRESS_NOTIFICATION_METHOD,
- TOOL_CALL_PROGRESS_TOKEN_PREFIX,
-} from 'src/engine/api/mcp/constants/mcp-progress-notification.const';
-import { McpToolExecutorService } from 'src/engine/api/mcp/services/mcp-tool-executor.service';
-import { MetricsService } from 'src/engine/core-modules/metrics/metrics.service';
-
-describe('McpToolExecutorService', () => {
- let service: McpToolExecutorService;
-
- beforeEach(() => {
- const metricsService = {
- incrementCounterBy: jest.fn().mockResolvedValue(undefined),
- recordHistogram: jest.fn(),
- } as unknown as MetricsService;
-
- service = new McpToolExecutorService(metricsService);
- });
-
- describe('handleToolsListing', () => {
- it('should return only tools array in result', () => {
- const toolSet = {
- test_tool: {
- description: 'A test tool',
- inputSchema: {
- jsonSchema: {
- type: 'object',
- properties: { query: { type: 'string' } },
- required: ['query'],
- },
- },
- annotations: MCP_CLOSED_WORLD_READ_ONLY_TOOL_ANNOTATIONS,
- },
- } as any;
-
- const result = service.handleToolsListing('123', toolSet);
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- result: {
- tools: [
- {
- name: 'test_tool',
- description: 'A test tool',
- inputSchema: {
- type: 'object',
- properties: { query: { type: 'string' } },
- required: ['query'],
- },
- annotations: MCP_CLOSED_WORLD_READ_ONLY_TOOL_ANNOTATIONS,
- },
- ],
- },
- });
- });
-
- it('should keep inputSchema unchanged when it is already a plain schema', () => {
- const toolSet = {
- plain_tool: {
- description: 'A plain schema tool',
- inputSchema: {
- type: 'object',
- properties: { name: { type: 'string' } },
- },
- },
- } as any;
-
- const result = service.handleToolsListing('456', toolSet);
-
- expect(result).toEqual({
- id: '456',
- jsonrpc: '2.0',
- result: {
- tools: [
- {
- name: 'plain_tool',
- description: 'A plain schema tool',
- inputSchema: {
- type: 'object',
- properties: { name: { type: 'string' } },
- },
- },
- ],
- },
- });
- });
- });
-
- describe('handleToolCall', () => {
- it('should return JSON-RPC error with INVALID_PARAMS for unknown tools', async () => {
- const toolSet = {} as any;
-
- const result = await service.handleToolCall('123', toolSet, {
- name: 'nonexistent_tool',
- arguments: {},
- });
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- error: {
- code: JSON_RPC_ERROR_CODE.INVALID_PARAMS,
- message: 'Unknown tool: nonexistent_tool',
- },
- });
- });
-
- it('should return result with isError: false on success', async () => {
- const toolSet = {
- my_tool: {
- execute: jest.fn().mockResolvedValue({ data: 'ok' }),
- description: 'My tool',
- inputSchema: { type: 'object' },
- },
- } as any;
-
- const result = await service.handleToolCall('123', toolSet, {
- name: 'my_tool',
- arguments: {},
- });
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- result: {
- content: [{ type: 'text', text: '{"data":"ok"}' }],
- isError: false,
- },
- });
- });
-
- it('should return result with isError: true when tool execution throws', async () => {
- const toolSet = {
- failing_tool: {
- execute: jest.fn().mockRejectedValue(new Error('API rate limited')),
- description: 'A tool that fails',
- inputSchema: { type: 'object' },
- },
- } as any;
-
- const result = await service.handleToolCall('123', toolSet, {
- name: 'failing_tool',
- arguments: {},
- });
-
- expect(result).toEqual({
- id: '123',
- jsonrpc: '2.0',
- result: {
- content: [{ type: 'text', text: 'API rate limited' }],
- isError: true,
- },
- });
- });
-
- it('should emit progress notification via sseWriter before execution', async () => {
- const sseWriter = jest.fn();
- const toolSet = {
- my_tool: {
- execute: jest.fn().mockResolvedValue({ data: 'ok' }),
- description: 'My tool',
- inputSchema: { type: 'object' },
- },
- } as any;
-
- await service.handleToolCall(
- 'sse-1',
- toolSet,
- { name: 'my_tool', arguments: {} },
- sseWriter,
- );
-
- expect(sseWriter).toHaveBeenCalledTimes(1);
- expect(sseWriter).toHaveBeenCalledWith({
- jsonrpc: '2.0',
- method: MCP_PROGRESS_NOTIFICATION_METHOD,
- params: {
- progressToken: `${TOOL_CALL_PROGRESS_TOKEN_PREFIX}sse-1`,
- progress: 0,
- total: 1,
- },
- });
- });
-
- it('should not emit progress notification when sseWriter is undefined', async () => {
- const toolSet = {
- my_tool: {
- execute: jest.fn().mockResolvedValue({ data: 'ok' }),
- description: 'My tool',
- inputSchema: { type: 'object' },
- },
- } as any;
-
- const result = await service.handleToolCall('no-sse', toolSet, {
- name: 'my_tool',
- arguments: {},
- });
-
- // Should still return normal result without errors
- expect(result).toEqual({
- id: 'no-sse',
- jsonrpc: '2.0',
- result: {
- content: [{ type: 'text', text: '{"data":"ok"}' }],
- isError: false,
- },
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-entity-cache/services/__tests__/core-entity-cache.service.spec.ts b/packages/twenty-server/src/engine/core-entity-cache/services/__tests__/core-entity-cache.service.spec.ts
deleted file mode 100644
index 211f873f395..00000000000
--- a/packages/twenty-server/src/engine/core-entity-cache/services/__tests__/core-entity-cache.service.spec.ts
+++ /dev/null
@@ -1,48 +0,0 @@
-import { type DiscoveryService, type Reflector } from '@nestjs/core';
-
-import { CoreEntityCacheService } from 'src/engine/core-entity-cache/services/core-entity-cache.service';
-import { type CacheStorageService } from 'src/engine/core-modules/cache-storage/services/cache-storage.service';
-
-describe('CoreEntityCacheService', () => {
- let service: CoreEntityCacheService;
-
- beforeEach(() => {
- jest.useFakeTimers();
-
- service = new CoreEntityCacheService(
- {} as CacheStorageService,
- {} as DiscoveryService,
- {} as Reflector,
- );
- });
-
- afterEach(() => {
- jest.useRealTimers();
- });
-
- it('should run the local cache expiration sweep at most once per minute', async () => {
- const expirationSweepSpy = jest.spyOn(
- service as unknown as {
- evictExpiredLocalEntries: (now: number) => void;
- },
- 'evictExpiredLocalEntries',
- );
-
- await expect(
- service.get('workspaceEntity', 'invalid-entity-id'),
- ).resolves.toBeNull();
- await expect(
- service.get('workspaceEntity', 'invalid-entity-id'),
- ).resolves.toBeNull();
-
- expect(expirationSweepSpy).toHaveBeenCalledTimes(1);
-
- jest.advanceTimersByTime(60_000);
-
- await expect(
- service.get('workspaceEntity', 'invalid-entity-id'),
- ).resolves.toBeNull();
-
- expect(expirationSweepSpy).toHaveBeenCalledTimes(2);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/__mocks__/mockFlatObjectMetadatas.ts b/packages/twenty-server/src/engine/core-modules/__mocks__/mockFlatObjectMetadatas.ts
deleted file mode 100644
index 58bcaddc2b7..00000000000
--- a/packages/twenty-server/src/engine/core-modules/__mocks__/mockFlatObjectMetadatas.ts
+++ /dev/null
@@ -1,197 +0,0 @@
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
-import { getFlatFieldMetadataMock } from 'src/engine/metadata-modules/flat-field-metadata/__mocks__/get-flat-field-metadata.mock';
-import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { getFlatObjectMetadataMock } from 'src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock';
-import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
-
-const workspaceId = '20202020-0000-0000-0000-000000000000';
-
-const personNameFieldId = 'person-name-field-id';
-const personAvatarFileFieldId = 'person-avatar-file-field-id';
-const companyNameFieldId = 'company-name-field-id';
-const companyDomainNameFieldId = 'company-domain-name-field-id';
-const customObjectNameFieldId = 'custom-object-name-field-id';
-const customObjectImageFieldId = 'custom-object-image-field-id';
-
-export const mockFlatObjectMetadatas: FlatObjectMetadata[] = [
- getFlatObjectMetadataMock({
- id: '20202020-8dec-43d5-b2ff-6eef05095bec',
- nameSingular: 'person',
- namePlural: 'people',
- labelSingular: 'Person',
- labelPlural: 'People',
- description: 'A person',
- icon: 'test-person-icon',
- isSearchable: true,
- labelIdentifierFieldMetadataId: personNameFieldId,
- imageIdentifierFieldMetadataId: personAvatarFileFieldId,
- workspaceId,
- fieldIds: [personNameFieldId, personAvatarFileFieldId],
- universalIdentifier: 'person-universal-id',
- applicationId: workspaceId,
- }),
- getFlatObjectMetadataMock({
- id: '20202020-c03c-45d6-a4b0-04afe1357c5c',
- nameSingular: 'company',
- namePlural: 'companies',
- labelSingular: 'Company',
- labelPlural: 'Companies',
- description: 'A company',
- icon: 'test-company-icon',
- isSearchable: true,
- labelIdentifierFieldMetadataId: companyNameFieldId,
- imageIdentifierFieldMetadataId: companyDomainNameFieldId,
- workspaceId,
- fieldIds: [companyNameFieldId, companyDomainNameFieldId],
- universalIdentifier: 'company-universal-id',
- applicationId: workspaceId,
- }),
- getFlatObjectMetadataMock({
- id: '20202020-3d75-4aab-bacd-ee176c5f63ca',
- nameSingular: 'regular-custom-object',
- namePlural: 'regular-custom-objects',
- labelSingular: 'Regular Custom Object',
- labelPlural: 'Regular Custom Objects',
- description: 'A regular custom object',
- icon: 'test-regular-custom-object-icon',
- isSearchable: true,
- labelIdentifierFieldMetadataId: customObjectNameFieldId,
- imageIdentifierFieldMetadataId: customObjectImageFieldId,
- workspaceId,
- fieldIds: [customObjectNameFieldId, customObjectImageFieldId],
- universalIdentifier: 'custom-object-universal-id',
- applicationId: workspaceId,
- }),
- getFlatObjectMetadataMock({
- id: '20202020-540c-4397-b872-2a90ea2fb809',
- nameSingular: 'non-searchable-object',
- namePlural: 'non-searchable-objects',
- labelSingular: '',
- labelPlural: '',
- description: '',
- icon: 'test-non-searchable-object-icon',
- isSystem: true,
- isSearchable: false,
- labelIdentifierFieldMetadataId: null,
- imageIdentifierFieldMetadataId: null,
- workspaceId,
- fieldIds: [],
- universalIdentifier: 'non-searchable-object-universal-id',
- applicationId: workspaceId,
- }),
- getFlatObjectMetadataMock({
- id: '20202020-6a7c-4e3f-9b2d-1d8f7a3e5c4b',
- nameSingular: 'message',
- namePlural: 'messages',
- labelSingular: 'Message',
- labelPlural: 'Messages',
- description: 'Message',
- icon: 'IconMessage',
- isSystem: true,
- isSearchable: false,
- labelIdentifierFieldMetadataId: null,
- imageIdentifierFieldMetadataId: null,
- workspaceId,
- fieldIds: [],
- universalIdentifier: 'message-universal-id',
- applicationId: workspaceId,
- }),
-];
-
-export const mockFlatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata> = {
- byUniversalIdentifier: {
- 'person-name-field-universal-id': getFlatFieldMetadataMock({
- id: personNameFieldId,
- type: FieldMetadataType.FULL_NAME,
- icon: 'test-field-icon',
- name: 'name',
- label: 'Name',
- description: "Contact's name",
- defaultValue: { lastName: "''", firstName: "''" },
- objectMetadataId: '20202020-8dec-43d5-b2ff-6eef05095bec',
- workspaceId,
- universalIdentifier: 'person-name-field-universal-id',
- applicationId: workspaceId,
- }),
- 'person-avatar-file-field-universal-id': getFlatFieldMetadataMock({
- id: personAvatarFileFieldId,
- type: FieldMetadataType.FILES,
- icon: 'test-field-icon',
- name: 'avatarFile',
- label: 'Avatar',
- description: null,
- defaultValue: null,
- objectMetadataId: '20202020-8dec-43d5-b2ff-6eef05095bec',
- workspaceId,
- universalIdentifier: 'person-avatar-file-field-universal-id',
- applicationId: workspaceId,
- }),
- 'company-name-field-universal-id': getFlatFieldMetadataMock({
- id: companyNameFieldId,
- type: FieldMetadataType.TEXT,
- icon: 'test-field-icon',
- name: 'name',
- label: 'Name',
- description: null,
- defaultValue: '',
- objectMetadataId: '20202020-c03c-45d6-a4b0-04afe1357c5c',
- workspaceId,
- universalIdentifier: 'company-name-field-universal-id',
- applicationId: workspaceId,
- }),
- 'company-domain-name-field-universal-id': getFlatFieldMetadataMock({
- id: companyDomainNameFieldId,
- type: FieldMetadataType.LINKS,
- icon: 'test-field-icon',
- name: 'domainName',
- label: 'Domain Name',
- description: null,
- defaultValue: {
- primaryLinkLabel: '',
- primaryLinkUrl: '',
- secondaryLinks: [],
- },
- objectMetadataId: '20202020-c03c-45d6-a4b0-04afe1357c5c',
- workspaceId,
- universalIdentifier: 'company-domain-name-field-universal-id',
- applicationId: workspaceId,
- }),
- 'custom-object-name-field-universal-id': getFlatFieldMetadataMock({
- id: customObjectNameFieldId,
- type: FieldMetadataType.TEXT,
- icon: 'test-field-icon',
- name: 'name',
- label: 'Name',
- description: null,
- defaultValue: '',
- objectMetadataId: '20202020-3d75-4aab-bacd-ee176c5f63ca',
- workspaceId,
- universalIdentifier: 'custom-object-name-field-universal-id',
- applicationId: workspaceId,
- }),
- 'custom-object-image-field-universal-id': getFlatFieldMetadataMock({
- id: customObjectImageFieldId,
- type: FieldMetadataType.TEXT,
- icon: 'test-field-icon',
- name: 'imageIdentifierFieldName',
- label: 'Image Identifier Field Name',
- description: null,
- defaultValue: '',
- objectMetadataId: '20202020-3d75-4aab-bacd-ee176c5f63ca',
- workspaceId,
- universalIdentifier: 'custom-object-image-field-universal-id',
- applicationId: workspaceId,
- }),
- },
- universalIdentifierById: {
- [personNameFieldId]: 'person-name-field-universal-id',
- [personAvatarFileFieldId]: 'person-avatar-file-field-universal-id',
- [companyNameFieldId]: 'company-name-field-universal-id',
- [companyDomainNameFieldId]: 'company-domain-name-field-universal-id',
- [customObjectNameFieldId]: 'custom-object-name-field-universal-id',
- [customObjectImageFieldId]: 'custom-object-image-field-universal-id',
- },
- universalIdentifiersByApplicationId: {},
-};
diff --git a/packages/twenty-server/src/engine/core-modules/actor/services/__tests__/actor-from-auth-context.service.spec.ts b/packages/twenty-server/src/engine/core-modules/actor/services/__tests__/actor-from-auth-context.service.spec.ts
deleted file mode 100644
index 951cdb35661..00000000000
--- a/packages/twenty-server/src/engine/core-modules/actor/services/__tests__/actor-from-auth-context.service.spec.ts
+++ /dev/null
@@ -1,167 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import {
- type ActorMetadata,
- FieldActorSource,
- type FullNameMetadata,
-} from 'twenty-shared/types';
-
-import { ActorFromAuthContextService } from 'src/engine/core-modules/actor/services/actor-from-auth-context.service';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-
-type ExpectedResult = { createdBy: ActorMetadata }[];
-
-const fromFullNameMetadataToName = ({
- firstName,
- lastName,
-}: FullNameMetadata) => `${firstName} ${lastName}`;
-
-describe('ActorFromAuthContextService', () => {
- let service: ActorFromAuthContextService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ActorFromAuthContextService,
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn().mockResolvedValue({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- 'person-universal-id': {
- id: 'person-id',
- nameSingular: 'person',
- fieldIds: ['createdBy-id'],
- universalIdentifier: 'person-universal-id',
- },
- },
- universalIdentifierById: {
- 'person-id': 'person-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- 'createdBy-universal-id': {
- id: 'createdBy-id',
- name: 'createdBy',
- objectMetadataId: 'person-id',
- universalIdentifier: 'createdBy-universal-id',
- },
- },
- universalIdentifierById: {
- 'createdBy-id': 'createdBy-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- flatIndexMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- }),
- },
- },
- ],
- }).compile();
-
- service = module.get<ActorFromAuthContextService>(
- ActorFromAuthContextService,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('injectCreatedBy', () => {
- it('should build metadata from workspaceMember when user auth context', async () => {
- const workspaceMemberName = {
- firstName: 'John',
- lastName: 'Doe',
- };
-
- const authContext = {
- type: 'user',
- workspaceMemberId: '20202020-0b5c-4178-bed7-d371f6411eaa',
- userWorkspaceId: '20202020-1234-5678-9012-345678901234',
- user: {
- id: '20202020-9aae-49a8-bafc-ac44bae62d6d',
- },
- workspaceMember: {
- id: '20202020-0b5c-4178-bed7-d371f6411eaa',
- name: workspaceMemberName,
- },
- workspace: { id: '20202020-bdec-497f-847a-1bb334fefe58' },
- } as unknown as WorkspaceAuthContext;
-
- const result = await service.injectCreatedBy({
- records: [{}],
- objectMetadataNameSingular: 'person',
- authContext,
- });
-
- expect(result).toEqual<ExpectedResult>([
- {
- createdBy: {
- context: {},
- name: fromFullNameMetadataToName(workspaceMemberName),
- workspaceMemberId: '20202020-0b5c-4178-bed7-d371f6411eaa',
- source: FieldActorSource.MANUAL,
- },
- },
- ]);
- });
-
- it('should build metadata from apiKey when apiKey auth context', async () => {
- const authContext = {
- type: 'apiKey',
- apiKey: {
- id: '20202020-56c2-471b-925d-31ed3ecd0951',
- name: 'API Key Name',
- },
- workspace: { id: '20202020-bdec-497f-847a-1bb334fefe58' },
- } as unknown as WorkspaceAuthContext;
-
- const result = await service.injectCreatedBy({
- records: [{}],
- objectMetadataNameSingular: 'person',
- authContext,
- });
-
- expect(result).toEqual<ExpectedResult>([
- {
- createdBy: {
- source: FieldActorSource.API,
- workspaceMemberId: null,
- name: 'API Key Name',
- context: {},
- },
- },
- ]);
- });
-
- it('should throw error when no valid actor information is found', async () => {
- const authContext = {
- type: 'system',
- workspace: { id: 'workspace-id' },
- } as unknown as WorkspaceAuthContext;
-
- await expect(
- service.injectCreatedBy({
- records: [{}],
- objectMetadataNameSingular: 'person',
- authContext,
- }),
- ).rejects.toThrowErrorMatchingInlineSnapshot(
- `"Unable to build actor metadata - no valid actor information found in auth context"`,
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel-chat.service.spec.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel-chat.service.spec.ts
deleted file mode 100644
index d5d98d439c5..00000000000
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel-chat.service.spec.ts
+++ /dev/null
@@ -1,219 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { AdminPanelChatService } from 'src/engine/core-modules/admin-panel/services/admin-panel-chat.service';
-import { UserInputError } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import {
- AgentMessageEntity,
- AgentMessageRole,
-} from 'src/engine/metadata-modules/ai/ai-agent-execution/entities/agent-message.entity';
-import { AgentChatThreadEntity } from 'src/engine/metadata-modules/ai/ai-chat/entities/agent-chat-thread.entity';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-
-const createMessageQueryBuilderMock = (getRawManyResult: () => unknown[]) => {
- const queryBuilderMock = {
- select: jest.fn(),
- addSelect: jest.fn(),
- where: jest.fn(),
- groupBy: jest.fn(),
- getRawMany: jest
- .fn()
- .mockImplementation(() => Promise.resolve(getRawManyResult())),
- };
-
- for (const method of ['select', 'addSelect', 'where', 'groupBy'] as const) {
- queryBuilderMock[method].mockReturnValue(queryBuilderMock);
- }
-
- return queryBuilderMock;
-};
-
-describe('AdminPanelChatService', () => {
- let service: AdminPanelChatService;
- let workspaceRepositoryFindOneMock: jest.Mock;
- let threadRepositoryFindMock: jest.Mock;
- let threadRepositoryFindOneMock: jest.Mock;
- let messageRepositoryFindMock: jest.Mock;
- let messageRawManyResult: unknown[];
-
- beforeEach(async () => {
- workspaceRepositoryFindOneMock = jest.fn();
- threadRepositoryFindMock = jest.fn();
- threadRepositoryFindOneMock = jest.fn();
- messageRepositoryFindMock = jest.fn();
- messageRawManyResult = [];
-
- const messageQueryBuilderMock = createMessageQueryBuilderMock(
- () => messageRawManyResult,
- );
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AdminPanelChatService,
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: { findOne: workspaceRepositoryFindOneMock },
- },
- {
- provide: getRepositoryToken(AgentChatThreadEntity),
- useValue: {
- find: threadRepositoryFindMock,
- findOne: threadRepositoryFindOneMock,
- },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(AgentMessageEntity),
- useValue: {
- find: messageRepositoryFindMock,
- createQueryBuilder: jest.fn(() => messageQueryBuilderMock),
- },
- },
- ],
- }).compile();
-
- service = module.get<AdminPanelChatService>(AdminPanelChatService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('getWorkspaceChatThreads', () => {
- it('should merge message counts and default missing threads to zero', async () => {
- workspaceRepositoryFindOneMock.mockResolvedValue({
- id: 'workspace-1',
- allowImpersonation: true,
- });
- threadRepositoryFindMock.mockResolvedValue([
- { id: 'thread-1', title: 'A', conversationSize: 1000 },
- { id: 'thread-2', title: 'B', conversationSize: 2000 },
- ]);
- messageRawManyResult = [{ threadId: 'thread-1', messageCount: 7 }];
-
- const result = await service.getWorkspaceChatThreads('workspace-1');
-
- expect(result[0].messageCount).toBe(7);
- expect(result[1].messageCount).toBe(0);
- });
-
- it('should throw when the workspace has not enabled support access', async () => {
- workspaceRepositoryFindOneMock.mockResolvedValue({
- id: 'workspace-1',
- allowImpersonation: false,
- });
-
- await expect(
- service.getWorkspaceChatThreads('workspace-1'),
- ).rejects.toThrow(UserInputError);
- });
- });
-
- describe('getChatThreadMessages', () => {
- it('should return the hidden kickoff message with enriched parts', async () => {
- threadRepositoryFindOneMock.mockResolvedValue({
- id: 'thread-1',
- workspaceId: 'workspace-1',
- title: 'Workspace setup',
- totalInputTokens: 10,
- totalOutputTokens: 20,
- conversationSize: 1000,
- createdAt: new Date('2026-01-01'),
- updatedAt: new Date('2026-01-02'),
- });
- workspaceRepositoryFindOneMock.mockResolvedValue({
- id: 'workspace-1',
- allowImpersonation: true,
- });
- messageRepositoryFindMock.mockResolvedValue([
- {
- id: 'message-1',
- role: AgentMessageRole.USER,
- isHidden: true,
- createdAt: new Date('2026-01-01'),
- parts: [
- {
- type: 'text',
- orderIndex: 0,
- textContent: 'kickoff prompt',
- reasoningContent: null,
- toolName: null,
- toolCallId: null,
- toolInput: null,
- toolOutput: null,
- state: null,
- errorMessage: null,
- },
- ],
- },
- {
- id: 'message-2',
- role: AgentMessageRole.ASSISTANT,
- isHidden: false,
- createdAt: new Date('2026-01-01T01:00:00Z'),
- parts: [
- {
- type: 'tool-call',
- orderIndex: 1,
- textContent: null,
- reasoningContent: null,
- toolName: 'create_many_object_metadata',
- toolCallId: 'call-1',
- toolInput: { objects: [] },
- toolOutput: { success: true },
- state: 'output-available',
- errorMessage: null,
- },
- {
- type: 'reasoning',
- orderIndex: 0,
- textContent: null,
- reasoningContent: 'thinking',
- toolName: null,
- toolCallId: null,
- toolInput: null,
- toolOutput: null,
- state: null,
- errorMessage: null,
- },
- ],
- },
- ]);
-
- const result = await service.getChatThreadMessages('thread-1');
-
- expect(messageRepositoryFindMock).toHaveBeenCalledWith(
- 'workspace-1',
- expect.objectContaining({ where: { threadId: 'thread-1' } }),
- );
- expect(result.thread.messageCount).toBe(1);
- expect(result.messages[0].isHidden).toBe(true);
- expect(result.messages[1].parts.map((part) => part.orderIndex)).toEqual([
- 0, 1,
- ]);
- expect(result.messages[1].parts[1]).toEqual(
- expect.objectContaining({
- toolName: 'create_many_object_metadata',
- toolInput: { objects: [] },
- toolOutput: { success: true },
- state: 'output-available',
- }),
- );
- });
-
- it('should throw when the thread workspace has not enabled support access', async () => {
- threadRepositoryFindOneMock.mockResolvedValue({
- id: 'thread-1',
- workspaceId: 'workspace-1',
- });
- workspaceRepositoryFindOneMock.mockResolvedValue({
- id: 'workspace-1',
- allowImpersonation: false,
- });
-
- await expect(service.getChatThreadMessages('thread-1')).rejects.toThrow(
- UserInputError,
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel-global-chat-threads.service.spec.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel-global-chat-threads.service.spec.ts
deleted file mode 100644
index ef8ceb5c20a..00000000000
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel-global-chat-threads.service.spec.ts
+++ /dev/null
@@ -1,499 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { isString } from '@sniptt/guards';
-import { ASK_QUESTIONS_TOOL_NAME } from 'twenty-shared/ai';
-import { Brackets } from 'typeorm';
-import { AdminChatThreadScope } from 'src/engine/core-modules/admin-panel/enums/admin-chat-thread-scope.enum';
-import { AdminChatThreadSortDirection } from 'src/engine/core-modules/admin-panel/enums/admin-chat-thread-sort-direction.enum';
-import { AdminChatThreadSortField } from 'src/engine/core-modules/admin-panel/enums/admin-chat-thread-sort-field.enum';
-import { AdminPanelGlobalChatThreadsService } from 'src/engine/core-modules/admin-panel/services/admin-panel-global-chat-threads.service';
-import {
- AgentMessageEntity,
- AgentMessageRole,
-} from 'src/engine/metadata-modules/ai/ai-agent-execution/entities/agent-message.entity';
-import { WORKSPACE_SETUP_CHAT_THREAD_ID_NAMESPACE } from 'src/engine/metadata-modules/ai/ai-chat/constants/workspace-setup-chat-thread-id-namespace.constant';
-import { AgentChatThreadEntity } from 'src/engine/metadata-modules/ai/ai-chat/entities/agent-chat-thread.entity';
-
-const QUERY_BUILDER_CHAINABLE_METHODS = [
- 'innerJoin',
- 'leftJoin',
- 'withDeleted',
- 'setParameter',
- 'where',
- 'andWhere',
- 'select',
- 'addSelect',
- 'groupBy',
- 'addGroupBy',
- 'orderBy',
- 'addOrderBy',
- 'limit',
- 'offset',
-] as const;
-
-const SUB_QUERY_BUILDER_CHAINABLE_METHODS = [
- 'select',
- 'from',
- 'innerJoin',
- 'where',
- 'andWhere',
-] as const;
-
-type SubQueryBuilderMock = Record<
- (typeof SUB_QUERY_BUILDER_CHAINABLE_METHODS)[number],
- jest.Mock
-> & {
- getQuery: jest.Mock;
-};
-
-const createSubQueryBuilderMock = (): SubQueryBuilderMock => {
- const subQueryBuilderMock = {} as SubQueryBuilderMock;
-
- for (const method of SUB_QUERY_BUILDER_CHAINABLE_METHODS) {
- subQueryBuilderMock[method] = jest
- .fn()
- .mockReturnValue(subQueryBuilderMock);
- }
-
- subQueryBuilderMock.getQuery = jest.fn().mockReturnValue('SUBQUERY');
-
- return subQueryBuilderMock;
-};
-
-type QueryBuilderMock = Record<
- (typeof QUERY_BUILDER_CHAINABLE_METHODS)[number],
- jest.Mock
-> & {
- subQuery: jest.Mock;
- getRawMany: jest.Mock;
- getCount: jest.Mock;
-};
-
-const createQueryBuilderMock = (
- getRawManyResult: () => unknown[],
- getCountResult: () => number,
- onSubQueryCreated?: (subQueryBuilderMock: SubQueryBuilderMock) => void,
-): QueryBuilderMock => {
- const queryBuilderMock = {} as QueryBuilderMock;
-
- for (const method of QUERY_BUILDER_CHAINABLE_METHODS) {
- queryBuilderMock[method] = jest.fn().mockReturnValue(queryBuilderMock);
- }
-
- queryBuilderMock.subQuery = jest.fn().mockImplementation(() => {
- const subQueryBuilderMock = createSubQueryBuilderMock();
-
- onSubQueryCreated?.(subQueryBuilderMock);
-
- return subQueryBuilderMock;
- });
- queryBuilderMock.getRawMany = jest
- .fn()
- .mockImplementation(() => Promise.resolve(getRawManyResult()));
- queryBuilderMock.getCount = jest
- .fn()
- .mockImplementation(() => Promise.resolve(getCountResult()));
-
- return queryBuilderMock;
-};
-
-const findSubQueryBuilderByAlias = (
- subQueryBuilderMocks: SubQueryBuilderMock[],
- alias: string,
-): SubQueryBuilderMock | undefined =>
- subQueryBuilderMocks.find((subQueryBuilderMock) =>
- subQueryBuilderMock.from.mock.calls.some(
- ([, fromAlias]) => fromAlias === alias,
- ),
- );
-
-const getAndWhereConditions = (queryBuilderMock: QueryBuilderMock): string[] =>
- queryBuilderMock.andWhere.mock.calls
- .map(([condition]) => condition)
- .filter((condition): condition is string => isString(condition));
-
-const RAW_ROW = {
- id: 'thread-1',
- title: 'Workspace setup',
- workspaceId: 'workspace-1',
- workspaceDisplayName: 'Acme',
- userWorkspaceId: 'user-workspace-1',
- userEmail: '[email protected]',
- userFirstName: 'Jane',
- userLastName: 'Doe',
- messageCount: 4,
- userReplyCount: 2,
- hasError: false,
- isOnboardingThread: true,
- deletedAt: null,
- createdAt: new Date('2026-01-01'),
- updatedAt: new Date('2026-01-02'),
-};
-
-const DEFAULT_ARGS = {
- scope: AdminChatThreadScope.ONBOARDING,
- hasErrorOnly: false,
- userNeverEngagedOnly: false,
- sortBy: AdminChatThreadSortField.CREATED_AT,
- sortDirection: AdminChatThreadSortDirection.DESC,
- limit: 25,
- offset: 0,
-};
-
-describe('AdminPanelGlobalChatThreadsService', () => {
- let service: AdminPanelGlobalChatThreadsService;
- let threadQueryBuilderMocks: QueryBuilderMock[];
- let subQueryBuilderMocks: SubQueryBuilderMock[];
- let threadRawManyResult: unknown[];
- let threadCountResult: number;
-
- beforeEach(async () => {
- threadQueryBuilderMocks = [];
- subQueryBuilderMocks = [];
- threadRawManyResult = [];
- threadCountResult = 0;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AdminPanelGlobalChatThreadsService,
- {
- provide: getRepositoryToken(AgentChatThreadEntity),
- useValue: {
- createQueryBuilder: jest.fn(() => {
- const queryBuilderMock = createQueryBuilderMock(
- () => threadRawManyResult,
- () => threadCountResult,
- (subQueryBuilderMock) =>
- subQueryBuilderMocks.push(subQueryBuilderMock),
- );
-
- threadQueryBuilderMocks.push(queryBuilderMock);
-
- return queryBuilderMock;
- }),
- },
- },
- ],
- }).compile();
-
- service = module.get<AdminPanelGlobalChatThreadsService>(
- AdminPanelGlobalChatThreadsService,
- );
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('getGlobalChatThreads', () => {
- it('should apply the onboarding fingerprint predicate only for the ONBOARDING scope', async () => {
- await service.getGlobalChatThreads(DEFAULT_ARGS);
-
- const [listQueryBuilder, countQueryBuilder] = threadQueryBuilderMocks;
-
- for (const queryBuilder of [listQueryBuilder, countQueryBuilder]) {
- const conditions = getAndWhereConditions(queryBuilder);
-
- expect(
- conditions.some(
- (condition) =>
- condition.includes('uuid_generate_v5') &&
- condition.includes('EXISTS (SUBQUERY)'),
- ),
- ).toBe(true);
- expect(queryBuilder.setParameter).toHaveBeenCalledWith(
- 'setupThreadNamespace',
- WORKSPACE_SETUP_CHAT_THREAD_ID_NAMESPACE,
- );
- }
-
- const hiddenKickoffSubQueryBuilder = subQueryBuilderMocks[0];
-
- expect(hiddenKickoffSubQueryBuilder.from).toHaveBeenCalledWith(
- AgentMessageEntity,
- 'hiddenMessage',
- );
- expect(hiddenKickoffSubQueryBuilder.andWhere).toHaveBeenCalledWith(
- 'hiddenMessage.isHidden = true',
- );
- });
-
- it('should not apply the onboarding fingerprint predicate for the ALL scope', async () => {
- await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- scope: AdminChatThreadScope.ALL,
- });
-
- for (const queryBuilder of threadQueryBuilderMocks) {
- expect(
- getAndWhereConditions(queryBuilder).some((condition) =>
- condition.includes('uuid_generate_v5'),
- ),
- ).toBe(false);
- }
- });
-
- it('should gate both queries on live workspaces allowing impersonation', async () => {
- await service.getGlobalChatThreads(DEFAULT_ARGS);
-
- for (const queryBuilder of threadQueryBuilderMocks) {
- expect(queryBuilder.innerJoin).toHaveBeenCalledWith(
- 'thread.workspace',
- 'workspace',
- '"workspace"."allowImpersonation" = true AND "workspace"."deletedAt" IS NULL',
- );
- }
- });
-
- it('should keep soft-deleted user identity while joining thread owners', async () => {
- await service.getGlobalChatThreads(DEFAULT_ARGS);
-
- for (const queryBuilder of threadQueryBuilderMocks) {
- expect(queryBuilder.leftJoin).toHaveBeenCalledWith(
- 'thread.userWorkspace',
- 'userWorkspace',
- );
- expect(queryBuilder.leftJoin).toHaveBeenCalledWith(
- 'userWorkspace.user',
- 'user',
- );
- expect(queryBuilder.withDeleted).toHaveBeenCalled();
- }
- });
-
- it('should count only visible messages', async () => {
- await service.getGlobalChatThreads(DEFAULT_ARGS);
-
- const [listQueryBuilder] = threadQueryBuilderMocks;
-
- expect(listQueryBuilder.leftJoin).toHaveBeenCalledWith(
- 'thread.messages',
- 'message',
- '"message"."isHidden" = false',
- );
- });
-
- it('should apply error and engagement filters when requested', async () => {
- await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- hasErrorOnly: true,
- userNeverEngagedOnly: true,
- });
-
- const conditions = getAndWhereConditions(threadQueryBuilderMocks[0]);
-
- expect(
- conditions.some((condition) =>
- condition.includes('"lastStreamError" IS NOT NULL'),
- ),
- ).toBe(true);
- expect(
- conditions.some((condition) =>
- condition.includes('NOT EXISTS (SUBQUERY)'),
- ),
- ).toBe(true);
- expect(threadQueryBuilderMocks[0].setParameter).toHaveBeenCalledWith(
- 'userMessageRole',
- AgentMessageRole.USER,
- );
-
- const visibleUserMessageSubQueryBuilder = findSubQueryBuilderByAlias(
- subQueryBuilderMocks,
- 'userMessage',
- );
-
- expect(visibleUserMessageSubQueryBuilder?.from).toHaveBeenCalledWith(
- AgentMessageEntity,
- 'userMessage',
- );
- expect(visibleUserMessageSubQueryBuilder?.andWhere).toHaveBeenCalledWith(
- 'userMessage.role = :userMessageRole',
- );
- });
-
- it('should treat an answered question card as engagement', async () => {
- await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- userNeverEngagedOnly: true,
- });
-
- for (const queryBuilder of threadQueryBuilderMocks) {
- expect(
- getAndWhereConditions(queryBuilder).some(
- (condition) =>
- condition === '(NOT EXISTS (SUBQUERY) AND NOT EXISTS (SUBQUERY))',
- ),
- ).toBe(true);
- }
-
- const answeredQuestionSubQueryBuilder = findSubQueryBuilderByAlias(
- subQueryBuilderMocks,
- 'answeredQuestionPart',
- );
-
- expect(answeredQuestionSubQueryBuilder?.innerJoin).toHaveBeenCalledWith(
- AgentMessageEntity,
- 'questionMessage',
- 'questionMessage.id = answeredQuestionPart.messageId',
- );
- expect(answeredQuestionSubQueryBuilder?.andWhere).toHaveBeenCalledWith(
- 'answeredQuestionPart.toolName = :askQuestionsToolName',
- );
- expect(answeredQuestionSubQueryBuilder?.andWhere).toHaveBeenCalledWith(
- expect.stringContaining(`-> 'result' ->> 'status'`),
- );
- });
-
- it('should count answered question cards as user replies', async () => {
- await service.getGlobalChatThreads(DEFAULT_ARGS);
-
- const [listQueryBuilder] = threadQueryBuilderMocks;
-
- const userReplyCountSelect = listQueryBuilder.addSelect.mock.calls.find(
- ([, alias]) => alias === 'userReplyCount',
- )?.[0];
-
- expect(userReplyCountSelect).toContain(
- 'FILTER (WHERE "message"."role" = :userMessageRole)',
- );
- expect(userReplyCountSelect).toContain('+ (SUBQUERY)');
- expect(listQueryBuilder.setParameter).toHaveBeenCalledWith(
- 'askQuestionsToolName',
- ASK_QUESTIONS_TOOL_NAME,
- );
- expect(listQueryBuilder.setParameter).toHaveBeenCalledWith(
- 'answeredQuestionStatus',
- 'answered',
- );
- });
-
- it('should apply the trimmed search term as an ILIKE pattern', async () => {
- await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- searchTerm: ' [email protected] ',
- });
-
- expect(threadQueryBuilderMocks[0].andWhere).toHaveBeenCalledWith(
- expect.any(Brackets),
- { searchPattern: '%[email protected]%' },
- );
- });
-
- it('should escape LIKE wildcards in the search term', async () => {
- await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- searchTerm: 'my_workspace 100%',
- });
-
- expect(threadQueryBuilderMocks[0].andWhere).toHaveBeenCalledWith(
- expect.any(Brackets),
- { searchPattern: '%my\\_workspace 100\\%%' },
- );
- });
-
- it('should sort by message count with a stable id tiebreaker', async () => {
- await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- sortBy: AdminChatThreadSortField.MESSAGE_COUNT,
- sortDirection: AdminChatThreadSortDirection.ASC,
- });
-
- const [listQueryBuilder] = threadQueryBuilderMocks;
-
- expect(listQueryBuilder.orderBy).toHaveBeenCalledWith(
- '"messageCount"',
- 'ASC',
- );
- expect(listQueryBuilder.addOrderBy).toHaveBeenCalledWith(
- '"thread"."id"',
- 'ASC',
- );
- });
-
- it('should sort by the reply count alias', async () => {
- await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- sortBy: AdminChatThreadSortField.REPLY_COUNT,
- sortDirection: AdminChatThreadSortDirection.DESC,
- });
-
- expect(threadQueryBuilderMocks[0].orderBy).toHaveBeenCalledWith(
- '"userReplyCount"',
- 'DESC',
- );
- });
-
- it('should sort by thread columns for date sort fields', async () => {
- await service.getGlobalChatThreads(DEFAULT_ARGS);
-
- expect(threadQueryBuilderMocks[0].orderBy).toHaveBeenCalledWith(
- '"thread"."createdAt"',
- 'DESC',
- );
- });
-
- it('should clamp the limit and floor the offset', async () => {
- await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- limit: 500,
- offset: -10,
- });
-
- const [listQueryBuilder] = threadQueryBuilderMocks;
-
- expect(listQueryBuilder.limit).toHaveBeenCalledWith(100);
- expect(listQueryBuilder.offset).toHaveBeenCalledWith(0);
- });
-
- it('should compute hasMore from the offset, page size and total count', async () => {
- threadRawManyResult = Array.from({ length: 25 }, (_, index) => ({
- ...RAW_ROW,
- id: `thread-${index}`,
- }));
- threadCountResult = 60;
-
- const result = await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- offset: 25,
- });
-
- expect(result.totalCount).toBe(60);
- expect(result.hasMore).toBe(true);
-
- const lastPageResult = await service.getGlobalChatThreads({
- ...DEFAULT_ARGS,
- offset: 35,
- });
-
- expect(lastPageResult.hasMore).toBe(false);
- });
-
- it('should map raw rows to DTOs tolerating missing user identity', async () => {
- threadRawManyResult = [
- {
- ...RAW_ROW,
- userEmail: null,
- userFirstName: null,
- userLastName: null,
- hasError: true,
- },
- ];
- threadCountResult = 1;
-
- const result = await service.getGlobalChatThreads(DEFAULT_ARGS);
-
- expect(result.threads).toEqual([
- expect.objectContaining({
- id: 'thread-1',
- userEmail: null,
- hasError: true,
- isOnboardingThread: true,
- messageCount: 4,
- userReplyCount: 2,
- }),
- ]);
- expect(result.hasMore).toBe(false);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel-health.service.spec.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel-health.service.spec.ts
deleted file mode 100644
index 8e7922d1986..00000000000
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel-health.service.spec.ts
+++ /dev/null
@@ -1,667 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { Queue } from 'bullmq';
-import { type Redis } from 'ioredis';
-
-import { AdminPanelHealthService } from 'src/engine/core-modules/admin-panel/admin-panel-health.service';
-import { HEALTH_INDICATORS } from 'src/engine/core-modules/admin-panel/constants/health-indicators.constants';
-import { type SystemHealthDTO } from 'src/engine/core-modules/admin-panel/dtos/system-health.dto';
-import { AdminPanelHealthServiceStatus } from 'src/engine/core-modules/admin-panel/enums/admin-panel-health-service-status.enum';
-import { QueueMetricsTimeRange } from 'src/engine/core-modules/admin-panel/enums/queue-metrics-time-range.enum';
-import { HEALTH_ERROR_MESSAGES } from 'src/engine/core-modules/admin-panel/constants/health-error-messages.constants';
-import { HealthIndicatorId } from 'src/engine/core-modules/admin-panel/enums/health-indicator-id.enum';
-import { AppHealthIndicator } from 'src/engine/core-modules/admin-panel/indicators/app.health';
-import { ConnectedAccountHealth } from 'src/engine/core-modules/admin-panel/indicators/connected-account.health';
-import { DatabaseHealthIndicator } from 'src/engine/core-modules/admin-panel/indicators/database.health';
-import { RedisHealthIndicator } from 'src/engine/core-modules/admin-panel/indicators/redis.health';
-import { WorkerHealthIndicator } from 'src/engine/core-modules/admin-panel/indicators/worker.health';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { RedisClientService } from 'src/engine/core-modules/redis-client/redis-client.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-jest.mock('bullmq');
-
-describe('AdminPanelHealthService', () => {
- let service: AdminPanelHealthService;
- let databaseHealth: jest.Mocked<DatabaseHealthIndicator>;
- let redisHealth: jest.Mocked<RedisHealthIndicator>;
- let workerHealth: jest.Mocked<WorkerHealthIndicator>;
- let connectedAccountHealth: jest.Mocked<ConnectedAccountHealth>;
- let appHealth: jest.Mocked<AppHealthIndicator>;
- let redisClient: jest.Mocked<RedisClientService>;
- let twentyConfigService: jest.Mocked<TwentyConfigService>;
- let loggerSpy: jest.SpyInstance;
-
- beforeEach(async () => {
- databaseHealth = { isHealthy: jest.fn() } as any;
- redisHealth = { isHealthy: jest.fn() } as any;
- workerHealth = { isHealthy: jest.fn(), getQueueDetails: jest.fn() } as any;
- connectedAccountHealth = { isHealthy: jest.fn() } as any;
- appHealth = { isHealthy: jest.fn() } as any;
- redisClient = {
- getClient: jest.fn().mockReturnValue({} as Redis),
- getQueueClient: jest.fn().mockReturnValue({} as Redis),
- } as any;
- twentyConfigService = { get: jest.fn() } as any;
-
- (Queue as unknown as jest.Mock) = jest.fn().mockImplementation(() => ({
- getMetrics: jest.fn(),
- getWorkers: jest.fn(),
- close: jest.fn(),
- }));
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AdminPanelHealthService,
- { provide: DatabaseHealthIndicator, useValue: databaseHealth },
- { provide: RedisHealthIndicator, useValue: redisHealth },
- { provide: WorkerHealthIndicator, useValue: workerHealth },
- { provide: ConnectedAccountHealth, useValue: connectedAccountHealth },
- { provide: AppHealthIndicator, useValue: appHealth },
- { provide: RedisClientService, useValue: redisClient },
- { provide: TwentyConfigService, useValue: twentyConfigService },
- ],
- }).compile();
-
- service = module.get<AdminPanelHealthService>(AdminPanelHealthService);
-
- // Override the healthIndicators mapping with our mocked instances
- (service as any)['healthIndicators'] = {
- [HealthIndicatorId.database]: databaseHealth,
- [HealthIndicatorId.redis]: redisHealth,
- [HealthIndicatorId.worker]: workerHealth,
- [HealthIndicatorId.connectedAccount]: connectedAccountHealth,
- [HealthIndicatorId.app]: appHealth,
- };
-
- loggerSpy = jest
- .spyOn(service['logger'], 'error')
- .mockImplementation(() => {});
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- loggerSpy.mockRestore();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('getSystemHealthStatus', () => {
- it('should transform health check response to SystemHealth format', async () => {
- databaseHealth.isHealthy.mockResolvedValue({
- database: { status: 'up', details: 'Database is healthy' },
- });
- redisHealth.isHealthy.mockResolvedValue({
- redis: { status: 'up', details: 'Redis is connected' },
- });
- workerHealth.isHealthy.mockResolvedValue({
- worker: {
- status: 'up',
- queues: [
- {
- queueName: 'test',
- workers: 1,
- metrics: {
- active: 1,
- completed: 0,
- delayed: 4,
- failed: 3,
- waiting: 0,
- failureRate: 0.3,
- },
- status: 'up',
- },
- ],
- },
- });
- connectedAccountHealth.isHealthy.mockResolvedValue({
- connectedAccount: {
- status: 'up',
- details: 'Account sync is operational',
- },
- });
- appHealth.isHealthy.mockResolvedValue({
- app: {
- status: 'up',
- details: {
- system: {
- nodeVersion: '16.0',
- },
- workspaces: {
- totalWorkspaces: 1,
- healthStatus: [
- {
- workspaceId: '1',
- summary: {
- structuralIssues: 0,
- dataIssues: 0,
- relationshipIssues: 0,
- pendingMigrations: 0,
- },
- severity: 'healthy',
- details: {},
- },
- ],
- },
- },
- },
- });
-
- const result = await service.getSystemHealthStatus();
-
- const expected: SystemHealthDTO = {
- services: [
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.database],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.redis],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.worker],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.connectedAccount],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.app],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- },
- ],
- };
-
- expect(result).toStrictEqual(expected);
- });
-
- it('should handle mixed health statuses', async () => {
- databaseHealth.isHealthy.mockResolvedValue({
- database: { status: 'up' },
- });
- redisHealth.isHealthy.mockRejectedValue(
- new Error(HEALTH_ERROR_MESSAGES.REDIS_CONNECTION_FAILED),
- );
- workerHealth.isHealthy.mockResolvedValue({
- worker: { status: 'up', queues: [] },
- });
- connectedAccountHealth.isHealthy.mockResolvedValue({
- connectedAccount: { status: 'up' },
- });
- appHealth.isHealthy.mockResolvedValue({
- app: { status: 'down', details: {} },
- });
-
- const result = await service.getSystemHealthStatus();
-
- expect(result).toStrictEqual({
- services: [
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.database],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.redis],
- status: AdminPanelHealthServiceStatus.OUTAGE,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.worker],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.connectedAccount],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.app],
- status: AdminPanelHealthServiceStatus.OUTAGE,
- },
- ],
- });
- });
-
- it('should handle all services down', async () => {
- databaseHealth.isHealthy.mockRejectedValue(
- new Error(HEALTH_ERROR_MESSAGES.DATABASE_CONNECTION_FAILED),
- );
- redisHealth.isHealthy.mockRejectedValue(
- new Error(HEALTH_ERROR_MESSAGES.REDIS_CONNECTION_FAILED),
- );
- workerHealth.isHealthy.mockRejectedValue(
- new Error(HEALTH_ERROR_MESSAGES.NO_ACTIVE_WORKERS),
- );
- connectedAccountHealth.isHealthy.mockRejectedValue(
- new Error(HEALTH_ERROR_MESSAGES.MESSAGE_SYNC_CHECK_FAILED),
- );
- appHealth.isHealthy.mockRejectedValue(
- new Error(HEALTH_ERROR_MESSAGES.APP_HEALTH_CHECK_FAILED),
- );
-
- const result = await service.getSystemHealthStatus();
-
- expect(result).toStrictEqual({
- services: [
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.database],
- status: AdminPanelHealthServiceStatus.OUTAGE,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.redis],
- status: AdminPanelHealthServiceStatus.OUTAGE,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.worker],
- status: AdminPanelHealthServiceStatus.OUTAGE,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.connectedAccount],
- status: AdminPanelHealthServiceStatus.OUTAGE,
- },
- {
- ...HEALTH_INDICATORS[HealthIndicatorId.app],
- status: AdminPanelHealthServiceStatus.OUTAGE,
- },
- ],
- });
- });
- });
-
- describe('getIndicatorHealthStatus', () => {
- it('should return health status for database indicator', async () => {
- const details = {
- version: '15.0',
- connections: { active: 5, max: 100 },
- };
-
- databaseHealth.isHealthy.mockResolvedValue({
- database: {
- status: 'up',
- details,
- },
- });
-
- const result = await service.getIndicatorHealthStatus(
- HealthIndicatorId.database,
- );
-
- expect(result).toStrictEqual({
- ...HEALTH_INDICATORS[HealthIndicatorId.database],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- details: JSON.stringify({ details }),
- errorMessage: undefined,
- queues: undefined,
- });
- });
-
- it('should return health status with queues for worker indicator', async () => {
- const mockQueues = [
- {
- queueName: 'queue1',
- workers: 2,
- status: 'up',
- },
- {
- queueName: 'queue2',
- workers: 0,
- status: 'up',
- },
- ];
-
- workerHealth.isHealthy.mockResolvedValue({
- worker: {
- status: 'up',
- queues: mockQueues,
- },
- });
-
- const result = await service.getIndicatorHealthStatus(
- HealthIndicatorId.worker,
- );
-
- expect(result).toStrictEqual({
- ...HEALTH_INDICATORS[HealthIndicatorId.worker],
- status: AdminPanelHealthServiceStatus.OPERATIONAL,
- details: JSON.stringify({ queues: mockQueues }),
- errorMessage: undefined,
- queues: mockQueues.map((queue) => ({
- id: `worker-${queue.queueName}`,
- queueName: queue.queueName,
- status:
- queue.workers > 0
- ? AdminPanelHealthServiceStatus.OPERATIONAL
- : AdminPanelHealthServiceStatus.OUTAGE,
- })),
- });
- });
-
- it('should handle failed indicator health check', async () => {
- redisHealth.isHealthy.mockRejectedValue(
- new Error(HEALTH_ERROR_MESSAGES.REDIS_CONNECTION_FAILED),
- );
-
- const result = await service.getIndicatorHealthStatus(
- HealthIndicatorId.redis,
- );
-
- expect(result).toStrictEqual({
- ...HEALTH_INDICATORS[HealthIndicatorId.redis],
- status: AdminPanelHealthServiceStatus.OUTAGE,
- details: undefined,
- errorMessage: HEALTH_ERROR_MESSAGES.REDIS_CONNECTION_FAILED,
- });
- });
-
- it('should throw error for invalid indicator', async () => {
- await expect(
- // @ts-expect-error Testing invalid input
- service.getIndicatorHealthStatus('invalid'),
- ).rejects.toThrow('Health indicator not found: invalid');
- });
- });
-
- describe('getQueueMetrics', () => {
- const mockQueue = {
- getMetrics: jest.fn(),
- getWorkers: jest.fn(),
- close: jest.fn(),
- };
-
- beforeEach(() => {
- jest.clearAllMocks();
- redisClient.getClient.mockReturnValue({} as Redis);
- redisClient.getQueueClient.mockReturnValue({} as Redis);
- (Queue as unknown as jest.Mock).mockImplementation(() => mockQueue);
- });
-
- it('should return metrics data for a queue with correct data transformation', async () => {
- const mockCompletedData = Array(240)
- .fill(0)
- .map((_, i) => i);
- const mockFailedData = Array(240)
- .fill(0)
- .map((_, i) => i * 0.1);
-
- workerHealth.getQueueDetails.mockResolvedValue({
- queueName: 'test-queue',
- workers: 1,
- status: 'up',
- metrics: {
- active: 1,
- completed: 30,
- failed: 3,
- waiting: 0,
- delayed: 0,
- failureRate: 9.1,
- completedData: mockCompletedData,
- failedData: mockFailedData,
- },
- });
-
- const result = await service.getQueueMetrics(
- MessageQueue.messagingQueue,
- QueueMetricsTimeRange.FourHours,
- );
-
- expect(result).toMatchObject({
- queueName: MessageQueue.messagingQueue,
- timeRange: QueueMetricsTimeRange.FourHours,
- workers: 1,
- details: expect.any(Object),
- data: expect.arrayContaining([
- expect.objectContaining({
- id: 'Completed Jobs',
- data: expect.arrayContaining([
- expect.objectContaining({
- x: expect.any(Number),
- y: expect.any(Number),
- }),
- ]),
- }),
- expect.objectContaining({
- id: 'Failed Jobs',
- data: expect.arrayContaining([
- expect.objectContaining({
- x: expect.any(Number),
- y: expect.any(Number),
- }),
- ]),
- }),
- ]),
- });
- });
-
- it('should handle empty metrics data', async () => {
- workerHealth.getQueueDetails.mockResolvedValue(null);
-
- const result = await service.getQueueMetrics(
- MessageQueue.messagingQueue,
- QueueMetricsTimeRange.FourHours,
- );
-
- expect(result.data).toHaveLength(2);
- expect(result.data[0].data).toHaveLength(240);
- expect(result.data[1].data).toHaveLength(240);
- });
-
- it('should handle metrics service errors', async () => {
- workerHealth.getQueueDetails.mockRejectedValue(
- new Error('Metrics error'),
- );
-
- await expect(
- service.getQueueMetrics(
- MessageQueue.messagingQueue,
- QueueMetricsTimeRange.FourHours,
- ),
- ).rejects.toThrow('Metrics error');
-
- expect(loggerSpy).toHaveBeenCalledWith(
- 'Error getting metrics for messaging-queue: Metrics error',
- );
- });
-
- describe('backfilling behavior', () => {
- it('should handle partial data with correct historical backfilling', async () => {
- // Test with 40 recent points for 4-hour range (needs 240 points)
- const partialData = Array(40)
- .fill(0)
- .map((_, i) => i + 1);
-
- workerHealth.getQueueDetails.mockResolvedValue({
- queueName: 'test-queue',
- workers: 1,
- status: 'up',
- metrics: {
- failed: 0,
- completed: 0,
- waiting: 0,
- active: 0,
- delayed: 0,
- failureRate: 0,
- completedData: partialData,
- failedData: partialData,
- },
- });
-
- const result = await service.getQueueMetrics(
- MessageQueue.messagingQueue,
- QueueMetricsTimeRange.FourHours,
- );
-
- // Should have 240 total points
- expect(result.data[0].data).toHaveLength(240);
-
- // First 200 points should be zero (historical backfill)
- const historicalPoints = result.data[0].data.slice(0, 200);
-
- expect(historicalPoints.every((point) => point.y === 0)).toBe(true);
-
- // Last 40 points should be actual data
- const actualDataPoints = result.data[0].data.slice(200);
-
- expect(actualDataPoints.every((point) => point.y > 0)).toBe(true);
-
- // Verify chronological order (increasing values)
- const nonZeroValues = actualDataPoints.map((point) => point.y);
-
- for (let i = 1; i < nonZeroValues.length; i++) {
- expect(nonZeroValues[i]).toBeGreaterThan(nonZeroValues[i - 1]);
- }
- });
-
- it('should handle completely empty data with full backfilling', async () => {
- workerHealth.getQueueDetails.mockResolvedValue({
- queueName: 'test-queue',
- workers: 1,
- status: 'up',
- metrics: {
- failed: 0,
- completed: 0,
- waiting: 0,
- active: 0,
- delayed: 0,
- failureRate: 0,
- completedData: [],
- failedData: [],
- },
- });
-
- const result = await service.getQueueMetrics(
- MessageQueue.messagingQueue,
- QueueMetricsTimeRange.OneHour,
- );
-
- // Should have 60 points for one hour
- expect(result.data[0].data).toHaveLength(60);
- // All points should be zero
- expect(result.data[0].data.every((point) => point.y === 0)).toBe(true);
- });
- });
-
- describe('sampling behavior', () => {
- it('should correctly sample data for different time ranges', async () => {
- const testCases = [
- {
- timeRange: QueueMetricsTimeRange.OneHour,
- expectedPoints: 60,
- samplingFactor: 1,
- },
- {
- timeRange: QueueMetricsTimeRange.FourHours,
- expectedPoints: 240,
- samplingFactor: 1,
- },
- {
- timeRange: QueueMetricsTimeRange.OneDay,
- expectedPoints: 240,
- samplingFactor: 6,
- },
- ];
-
- for (const testCase of testCases) {
- // Create test data with non-zero values
- const testData = Array(testCase.expectedPoints * 2)
- .fill(0)
- .map((_, i) => i + 1); // Start from 1 to avoid zero values
-
- workerHealth.getQueueDetails.mockResolvedValue({
- queueName: 'test-queue',
- workers: 1,
- status: 'up',
- metrics: {
- failed: 0,
- completed: 0,
- waiting: 0,
- active: 0,
- delayed: 0,
- failureRate: 0,
- completedData: testData,
- failedData: testData,
- },
- });
-
- const result = await service.getQueueMetrics(
- MessageQueue.messagingQueue,
- testCase.timeRange,
- );
-
- expect(result.data[0].data).toHaveLength(testCase.expectedPoints);
-
- if (testCase.samplingFactor > 1) {
- const sampledData = result.data[0].data;
-
- for (let i = 0; i < sampledData.length; i++) {
- const start = i * testCase.samplingFactor;
- const end = start + testCase.samplingFactor;
- const originalDataSlice = testData.slice(start, end);
-
- if (originalDataSlice.length > 0) {
- // Add this check
- const maxInSlice = Math.max(...originalDataSlice);
-
- expect(sampledData[i].y).toBeLessThanOrEqual(maxInSlice);
- }
- }
- }
- }
- });
- });
- });
-
- describe('getPointsConfiguration', () => {
- const testCases = [
- {
- timeRange: QueueMetricsTimeRange.OneHour,
- expected: {
- pointsNeeded: 60,
- samplingFactor: 1,
- targetVisualizationPoints: 240,
- },
- },
- {
- timeRange: QueueMetricsTimeRange.FourHours,
- expected: {
- pointsNeeded: 240,
- samplingFactor: 1,
- targetVisualizationPoints: 240,
- },
- },
- {
- timeRange: QueueMetricsTimeRange.TwelveHours,
- expected: {
- pointsNeeded: 720,
- samplingFactor: 3,
- targetVisualizationPoints: 240,
- },
- },
- {
- timeRange: QueueMetricsTimeRange.OneDay,
- expected: {
- pointsNeeded: 1440,
- samplingFactor: 6,
- targetVisualizationPoints: 240,
- },
- },
- {
- timeRange: QueueMetricsTimeRange.SevenDays,
- expected: {
- pointsNeeded: 10080,
- samplingFactor: 42,
- targetVisualizationPoints: 240,
- },
- },
- ];
-
- testCases.forEach(({ timeRange, expected }) => {
- it(`should return correct parameters for ${timeRange}`, () => {
- const result = service['getPointsConfiguration'](timeRange as any);
-
- expect(result).toEqual(expected);
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel.service.spec.ts b/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel.service.spec.ts
deleted file mode 100644
index 62e2edc55c3..00000000000
--- a/packages/twenty-server/src/engine/core-modules/admin-panel/__tests__/admin-panel.service.spec.ts
+++ /dev/null
@@ -1,381 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { AdminPanelConfigService } from 'src/engine/core-modules/admin-panel/services/admin-panel-config.service';
-import { AdminPanelVersionService } from 'src/engine/core-modules/admin-panel/services/admin-panel-version.service';
-import { SecureHttpClientService } from 'src/engine/core-modules/secure-http-client/secure-http-client.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-const TwentyConfigServiceGetAllMock = jest.fn();
-const TwentyConfigServiceGetVariableWithMetadataMock = jest.fn();
-const mockHttpClientGet = jest.fn();
-const mockGetHttpClient = jest.fn().mockReturnValue({ get: mockHttpClientGet });
-
-jest.mock(
- 'src/engine/core-modules/twenty-config/constants/config-variables-group-metadata',
- () => ({
- CONFIG_VARIABLES_GROUP_METADATA: {
- SERVER_CONFIG: {
- position: 100,
- description: 'Server config description',
- isHiddenOnLoad: false,
- },
- RATE_LIMITING: {
- position: 200,
- description: 'Rate limiting description',
- isHiddenOnLoad: false,
- },
- OTHER: {
- position: 300,
- description: 'Other description',
- isHiddenOnLoad: true,
- },
- },
- }),
-);
-
-describe('AdminPanelConfigService', () => {
- let configService: AdminPanelConfigService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AdminPanelConfigService,
- {
- provide: TwentyConfigService,
- useValue: {
- getAll: TwentyConfigServiceGetAllMock,
- getVariableWithMetadata:
- TwentyConfigServiceGetVariableWithMetadataMock,
- },
- },
- ],
- }).compile();
-
- configService = module.get<AdminPanelConfigService>(
- AdminPanelConfigService,
- );
- });
-
- it('should be defined', async () => {
- expect(configService).toBeDefined();
- });
-
- describe('getConfigVariablesGrouped', () => {
- it('should correctly group and sort config variables', () => {
- TwentyConfigServiceGetAllMock.mockReturnValue({
- SERVER_URL: {
- value: 'http://localhost',
- metadata: {
- group: 'SERVER_CONFIG',
- description: 'Server URL',
- type: 'string',
- options: undefined,
- },
- source: 'env',
- },
- RATE_LIMIT_TTL: {
- value: 60,
- metadata: {
- group: 'RATE_LIMITING',
- description: 'Rate limit TTL',
- type: 'number',
- options: undefined,
- },
- source: 'env',
- },
- API_KEY: {
- value: 'secret-key',
- metadata: {
- group: 'SERVER_CONFIG',
- description: 'API Key',
- isSensitive: true,
- type: 'string',
- options: undefined,
- },
- source: 'env',
- },
- OTHER_VAR: {
- value: 'other',
- metadata: {
- group: 'OTHER',
- description: 'Other var',
- type: 'string',
- options: undefined,
- },
- source: 'env',
- },
- });
-
- const result = configService.getConfigVariablesGrouped();
-
- expect(result).toEqual({
- groups: [
- {
- name: 'SERVER_CONFIG',
- description: 'Server config description',
- isHiddenOnLoad: false,
- variables: [
- {
- name: 'API_KEY',
- value: 'secret-key',
- description: 'API Key',
- isSensitive: true,
- isEnvOnly: false,
- type: 'string',
- options: undefined,
- source: 'env',
- },
- {
- name: 'SERVER_URL',
- value: 'http://localhost',
- description: 'Server URL',
- isSensitive: false,
- isEnvOnly: false,
- type: 'string',
- options: undefined,
- source: 'env',
- },
- ],
- },
- {
- name: 'RATE_LIMITING',
- description: 'Rate limiting description',
- isHiddenOnLoad: false,
- variables: [
- {
- name: 'RATE_LIMIT_TTL',
- value: 60,
- description: 'Rate limit TTL',
- isSensitive: false,
- isEnvOnly: false,
- type: 'number',
- options: undefined,
- source: 'env',
- },
- ],
- },
- {
- name: 'OTHER',
- description: 'Other description',
- isHiddenOnLoad: true,
- variables: [
- {
- name: 'OTHER_VAR',
- value: 'other',
- description: 'Other var',
- isSensitive: false,
- isEnvOnly: false,
- type: 'string',
- options: undefined,
- source: 'env',
- },
- ],
- },
- ],
- });
-
- expect(result.groups[0].name).toBe('SERVER_CONFIG');
- expect(result.groups[1].name).toBe('RATE_LIMITING');
- expect(result.groups[2].name).toBe('OTHER');
- });
-
- it('should handle empty config variables', () => {
- TwentyConfigServiceGetAllMock.mockReturnValue({});
-
- const result = configService.getConfigVariablesGrouped();
-
- expect(result).toEqual({
- groups: [],
- });
- });
-
- it('should handle variables with undefined metadata fields', () => {
- TwentyConfigServiceGetAllMock.mockReturnValue({
- TEST_VAR: {
- value: 'test',
- metadata: {
- group: 'SERVER_CONFIG',
- type: 'string',
- options: undefined,
- },
- source: 'env',
- },
- });
-
- const result = configService.getConfigVariablesGrouped();
-
- expect(result.groups[0].variables[0]).toEqual({
- name: 'TEST_VAR',
- value: 'test',
- description: undefined,
- isSensitive: false,
- isEnvOnly: false,
- options: undefined,
- source: 'env',
- type: 'string',
- });
- });
- });
-
- describe('getConfigVariable', () => {
- it('should return config variable with all fields', () => {
- TwentyConfigServiceGetVariableWithMetadataMock.mockReturnValue({
- value: 'test-value',
- metadata: {
- group: 'SERVER_CONFIG',
- description: 'Test description',
- isSensitive: true,
- isEnvOnly: true,
- type: 'string',
- options: ['option1', 'option2'],
- },
- source: 'env',
- });
-
- const result = configService.getConfigVariable('SERVER_URL');
-
- expect(result).toEqual({
- name: 'SERVER_URL',
- value: 'test-value',
- description: 'Test description',
- isSensitive: true,
- isEnvOnly: true,
- type: 'string',
- options: ['option1', 'option2'],
- source: 'env',
- });
- });
-
- it('should throw error when variable not found', () => {
- TwentyConfigServiceGetVariableWithMetadataMock.mockReturnValue(undefined);
-
- expect(() => configService.getConfigVariable('INVALID_VAR')).toThrow(
- 'Config variable INVALID_VAR not found',
- );
- });
- });
-});
-
-describe('AdminPanelVersionService', () => {
- let versionService: AdminPanelVersionService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AdminPanelVersionService,
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: SecureHttpClientService,
- useValue: {
- getHttpClient: mockGetHttpClient,
- },
- },
- ],
- }).compile();
-
- versionService = module.get<AdminPanelVersionService>(
- AdminPanelVersionService,
- );
- });
-
- describe('getVersionInfo', () => {
- const mockEnvironmentGet = jest.fn();
-
- beforeEach(() => {
- mockEnvironmentGet.mockReset();
- mockHttpClientGet.mockReset();
- versionService['twentyConfigService'].get = mockEnvironmentGet;
- });
-
- it('should return current and latest version when everything works', async () => {
- mockEnvironmentGet.mockReturnValue('1.0.0');
- mockHttpClientGet.mockResolvedValue({
- data: {
- results: [
- { name: '2.0.0' },
- { name: '1.5.0' },
- { name: '1.0.0' },
- { name: 'latest' },
- ],
- },
- });
-
- const result = await versionService.getVersionInfo();
-
- expect(result).toEqual({
- currentVersion: '1.0.0',
- latestVersion: '2.0.0',
- });
- });
-
- it('should handle undefined APP_VERSION', async () => {
- mockEnvironmentGet.mockReturnValue(undefined);
- mockHttpClientGet.mockResolvedValue({
- data: {
- results: [{ name: '2.0.0' }, { name: 'latest' }],
- },
- });
-
- const result = await versionService.getVersionInfo();
-
- expect(result).toEqual({
- currentVersion: undefined,
- latestVersion: '2.0.0',
- });
- });
-
- it('should handle Docker Hub API error', async () => {
- mockEnvironmentGet.mockReturnValue('1.0.0');
- mockHttpClientGet.mockRejectedValue(new Error('API Error'));
-
- const result = await versionService.getVersionInfo();
-
- expect(result).toEqual({
- currentVersion: '1.0.0',
- latestVersion: null,
- });
- });
-
- it('should handle empty Docker Hub tags', async () => {
- mockEnvironmentGet.mockReturnValue('1.0.0');
- mockHttpClientGet.mockResolvedValue({
- data: {
- results: [],
- },
- });
-
- const result = await versionService.getVersionInfo();
-
- expect(result).toEqual({
- currentVersion: '1.0.0',
- latestVersion: null,
- });
- });
-
- it('should handle invalid semver tags', async () => {
- mockEnvironmentGet.mockReturnValue('1.0.0');
- mockHttpClientGet.mockResolvedValue({
- data: {
- results: [
- { name: '2.0.0' },
- { name: 'invalid-version' },
- { name: 'latest' },
- { name: '1.0.0' },
- ],
- },
- });
-
- const result = await versionService.getVersionInfo();
-
- expect(result).toEqual({
- currentVersion: '1.0.0',
- latestVersion: '2.0.0',
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/api-key/services/__tests__/api-key.service.spec.ts b/packages/twenty-server/src/engine/core-modules/api-key/services/__tests__/api-key.service.spec.ts
deleted file mode 100644
index 92912fbf2df..00000000000
--- a/packages/twenty-server/src/engine/core-modules/api-key/services/__tests__/api-key.service.spec.ts
+++ /dev/null
@@ -1,500 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getDataSourceToken } from '@nestjs/typeorm';
-
-import { IsNull } from 'typeorm';
-
-import { ApiKeyEntity } from 'src/engine/core-modules/api-key/api-key.entity';
-import {
- ApiKeyException,
- ApiKeyExceptionCode,
-} from 'src/engine/core-modules/api-key/exceptions/api-key.exception';
-import { ApiKeyRoleService } from 'src/engine/core-modules/api-key/services/api-key-role.service';
-import { ApiKeyService } from 'src/engine/core-modules/api-key/services/api-key.service';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { RoleTargetEntity } from 'src/engine/metadata-modules/role-target/role-target.entity';
-import { RoleTargetService } from 'src/engine/metadata-modules/role-target/services/role-target.service';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-describe('ApiKeyService', () => {
- let service: ApiKeyService;
- let mockApiKeyRepository: any;
- let mockroleTargetRepository: any;
- let mockJwtWrapperService: any;
- let mockApiKeyRoleService: any;
- let mockRoleTargetService: any;
- let mockDataSource: any;
-
- const mockWorkspaceId = 'workspace-123';
- const mockApiKeyId = 'api-key-456';
-
- const mockApiKey: ApiKeyEntity = {
- id: mockApiKeyId,
- name: 'Test API Key',
- expiresAt: new Date('2030-12-31'),
- revokedAt: undefined,
- workspaceId: mockWorkspaceId,
- createdAt: new Date('2024-01-01'),
- updatedAt: new Date('2024-01-01'),
- workspace: {} as any,
- };
-
- const mockRevokedApiKey: ApiKeyEntity = {
- ...mockApiKey,
- id: 'revoked-api-key',
- revokedAt: new Date('2024-06-01'),
- };
-
- const mockExpiredApiKey: ApiKeyEntity = {
- ...mockApiKey,
- id: 'expired-api-key',
- expiresAt: new Date('2024-01-01'),
- };
-
- beforeEach(async () => {
- mockApiKeyRepository = {
- create: jest.fn(),
- save: jest.fn(),
- find: jest.fn(),
- findOne: jest.fn(),
- update: jest.fn(),
- };
-
- mockroleTargetRepository = {
- delete: jest.fn(),
- save: jest.fn(),
- findOne: jest.fn(),
- };
-
- mockJwtWrapperService = {
- signAsyncOrThrow: jest.fn(),
- };
-
- mockApiKeyRoleService = {
- recomputeCache: jest.fn(),
- assignRoleToApiKey: jest.fn(),
- assignRoleToApiKeyWithManager: jest.fn(),
- };
-
- mockRoleTargetService = {
- create: jest.fn(),
- };
-
- mockDataSource = {
- transaction: jest.fn(),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApiKeyService,
- {
- provide: getWorkspaceScopedRepositoryToken(ApiKeyEntity),
- useValue: mockApiKeyRepository,
- },
- {
- provide: JwtWrapperService,
- useValue: mockJwtWrapperService,
- },
- {
- provide: RoleTargetService,
- useValue: mockRoleTargetService,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(RoleTargetEntity),
- useValue: mockroleTargetRepository,
- },
- {
- provide: ApiKeyRoleService,
- useValue: mockApiKeyRoleService,
- },
- {
- provide: getDataSourceToken(),
- useValue: mockDataSource,
- },
- {
- provide: WorkspaceCacheService,
- useValue: {
- invalidateAndRecompute: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<ApiKeyService>(ApiKeyService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('create', () => {
- it('should create and save an API key and assign role', async () => {
- const apiKeyData = {
- name: 'New API Key',
- expiresAt: new Date('2025-12-31'),
- workspaceId: mockWorkspaceId,
- roleId: 'mock-role-id',
- };
-
- const expectedApiKeyFields = {
- name: 'New API Key',
- expiresAt: new Date('2025-12-31'),
- };
-
- mockApiKeyRepository.save.mockResolvedValue(mockApiKey);
- mockRoleTargetService.create.mockResolvedValue(undefined);
-
- const result = await service.create(apiKeyData);
-
- expect(mockApiKeyRepository.save).toHaveBeenCalledWith(
- mockWorkspaceId,
- expectedApiKeyFields,
- );
- expect(mockRoleTargetService.create).toHaveBeenCalledWith({
- createRoleTargetInput: {
- roleId: 'mock-role-id',
- targetId: mockApiKey.id,
- targetMetadataForeignKey: 'apiKeyId',
- },
- workspaceId: mockWorkspaceId,
- });
- expect(result).toEqual(mockApiKey);
- });
-
- it('should delete API key if role assignment fails', async () => {
- const apiKeyData = {
- name: 'New API Key',
- expiresAt: new Date('2025-12-31'),
- workspaceId: mockWorkspaceId,
- roleId: 'mock-role-id',
- };
-
- mockApiKeyRepository.save.mockResolvedValue(mockApiKey);
- mockApiKeyRepository.delete = jest.fn().mockResolvedValue(undefined);
- mockRoleTargetService.create.mockRejectedValue(
- new Error('Role assignment failed'),
- );
-
- await expect(service.create(apiKeyData)).rejects.toThrow(
- 'Role assignment failed',
- );
-
- expect(mockApiKeyRepository.save).toHaveBeenCalled();
- expect(mockRoleTargetService.create).toHaveBeenCalled();
- expect(mockApiKeyRepository.delete).toHaveBeenCalledWith(
- mockWorkspaceId,
- { id: mockApiKey.id },
- );
- });
-
- it('should handle save failures gracefully', async () => {
- const apiKeyData = {
- name: 'New API Key',
- expiresAt: new Date('2025-12-31'),
- workspaceId: mockWorkspaceId,
- roleId: 'mock-role-id',
- };
-
- mockApiKeyRepository.save.mockRejectedValue(new Error('Save failed'));
-
- await expect(service.create(apiKeyData)).rejects.toThrow('Save failed');
-
- expect(mockApiKeyRepository.save).toHaveBeenCalled();
- expect(mockRoleTargetService.create).not.toHaveBeenCalled();
- });
- });
-
- describe('findById', () => {
- it('should find an API key by ID and workspace ID', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(mockApiKey);
-
- const result = await service.findById(mockApiKeyId, mockWorkspaceId);
-
- expect(mockApiKeyRepository.findOne).toHaveBeenCalledWith(
- mockWorkspaceId,
- { where: { id: mockApiKeyId } },
- );
- expect(result).toEqual(mockApiKey);
- });
-
- it('should return null if API key not found', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(null);
-
- const result = await service.findById('non-existent', mockWorkspaceId);
-
- expect(result).toBeNull();
- });
- });
-
- describe('findByWorkspaceId', () => {
- it('should find all API keys for a workspace', async () => {
- const mockApiKeys = [mockApiKey, { ...mockApiKey, id: 'another-key' }];
-
- mockApiKeyRepository.find.mockResolvedValue(mockApiKeys);
-
- const result = await service.findByWorkspaceId(mockWorkspaceId);
-
- expect(mockApiKeyRepository.find).toHaveBeenCalledWith(mockWorkspaceId, {
- order: { createdAt: 'ASC', id: 'ASC' },
- });
- expect(result).toEqual(mockApiKeys);
- });
- });
-
- describe('findActiveByWorkspaceId', () => {
- it('should find only active (non-revoked) API keys', async () => {
- const activeApiKeys = [mockApiKey];
-
- mockApiKeyRepository.find.mockResolvedValue(activeApiKeys);
-
- const result = await service.findActiveByWorkspaceId(mockWorkspaceId);
-
- expect(mockApiKeyRepository.find).toHaveBeenCalledWith(mockWorkspaceId, {
- where: { revokedAt: IsNull() },
- order: { createdAt: 'ASC', id: 'ASC' },
- });
- expect(result).toEqual(activeApiKeys);
- });
- });
-
- describe('update', () => {
- it('should update an existing API key', async () => {
- const updateData = { name: 'Updated API Key' };
- const updatedApiKey = { ...mockApiKey, ...updateData };
-
- mockApiKeyRepository.findOne
- .mockResolvedValueOnce(mockApiKey)
- .mockResolvedValueOnce(updatedApiKey);
- mockApiKeyRepository.update.mockResolvedValue({ affected: 1 });
-
- const result = await service.update(
- mockApiKeyId,
- mockWorkspaceId,
- updateData,
- );
-
- expect(mockApiKeyRepository.update).toHaveBeenCalledWith(
- mockWorkspaceId,
- { id: mockApiKeyId },
- updateData,
- );
- expect(result).toEqual(updatedApiKey);
- });
-
- it('should return null if API key to update does not exist', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(null);
-
- const result = await service.update('non-existent', mockWorkspaceId, {
- name: 'Updated',
- });
-
- expect(mockApiKeyRepository.update).not.toHaveBeenCalled();
- expect(result).toBeNull();
- });
- });
-
- describe('revoke', () => {
- it('should revoke an API key by setting revokedAt', async () => {
- const revokedApiKey = { ...mockApiKey, revokedAt: new Date() };
-
- mockApiKeyRepository.findOne
- .mockResolvedValueOnce(mockApiKey)
- .mockResolvedValueOnce(revokedApiKey);
- mockApiKeyRepository.update.mockResolvedValue({ affected: 1 });
-
- const result = await service.revoke(mockApiKeyId, mockWorkspaceId);
-
- expect(mockApiKeyRepository.update).toHaveBeenCalledWith(
- mockWorkspaceId,
- { id: mockApiKeyId },
- expect.objectContaining({ revokedAt: expect.any(Date) }),
- );
- expect(result).toEqual(revokedApiKey);
- });
- });
-
- describe('validateApiKey', () => {
- it('should validate an active API key', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(mockApiKey);
-
- const result = await service.validateApiKey(
- mockApiKeyId,
- mockWorkspaceId,
- );
-
- expect(result).toEqual(mockApiKey);
- });
-
- it('should throw ApiKeyException if API key does not exist', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(null);
-
- await expect(
- service.validateApiKey('non-existent', mockWorkspaceId),
- ).rejects.toThrow(ApiKeyException);
-
- await expect(
- service.validateApiKey('non-existent', mockWorkspaceId),
- ).rejects.toMatchObject({
- code: ApiKeyExceptionCode.API_KEY_NOT_FOUND,
- });
- });
-
- it('should throw ApiKeyException if API key is revoked', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(mockRevokedApiKey);
-
- await expect(
- service.validateApiKey(mockRevokedApiKey.id, mockWorkspaceId),
- ).rejects.toThrow(ApiKeyException);
-
- await expect(
- service.validateApiKey(mockRevokedApiKey.id, mockWorkspaceId),
- ).rejects.toMatchObject({
- code: ApiKeyExceptionCode.API_KEY_REVOKED,
- });
- });
-
- it('should throw ApiKeyException if API key is expired', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(mockExpiredApiKey);
-
- await expect(
- service.validateApiKey(mockExpiredApiKey.id, mockWorkspaceId),
- ).rejects.toThrow(ApiKeyException);
-
- await expect(
- service.validateApiKey(mockExpiredApiKey.id, mockWorkspaceId),
- ).rejects.toMatchObject({
- code: ApiKeyExceptionCode.API_KEY_EXPIRED,
- });
- });
- });
-
- describe('generateApiKeyToken', () => {
- const mockToken = 'mock-jwt-token';
-
- beforeEach(() => {
- mockJwtWrapperService.signAsyncOrThrow.mockResolvedValue(mockToken);
- });
-
- it('should generate a JWT token for a valid API key', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(mockApiKey);
- const expiresAt = new Date('2025-12-31');
-
- const result = await service.generateApiKeyToken(
- mockWorkspaceId,
- mockApiKeyId,
- expiresAt,
- );
-
- expect(mockJwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- {
- sub: mockWorkspaceId,
- type: JwtTokenTypeEnum.API_KEY,
- workspaceId: mockWorkspaceId,
- },
- {
- expiresIn: expect.any(Number),
- jwtid: mockApiKeyId,
- },
- );
- expect(result).toEqual({ token: mockToken });
- });
-
- it('should return undefined if no API key ID provided', async () => {
- const result = await service.generateApiKeyToken(mockWorkspaceId);
-
- expect(result).toBeUndefined();
- expect(mockJwtWrapperService.signAsyncOrThrow).not.toHaveBeenCalled();
- });
-
- it('should use default expiration if no expiresAt provided', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(mockApiKey);
-
- await service.generateApiKeyToken(mockWorkspaceId, mockApiKeyId);
-
- expect(mockJwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- expect.any(Object),
- expect.objectContaining({
- expiresIn: '100y',
- }),
- );
- });
-
- it('should use custom expiration time if provided', async () => {
- mockApiKeyRepository.findOne.mockResolvedValue(mockApiKey);
- const expiresAt = new Date(Date.now() + 3600000); // 1 hour from now
-
- await service.generateApiKeyToken(
- mockWorkspaceId,
- mockApiKeyId,
- expiresAt,
- );
-
- expect(mockJwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- {
- sub: mockWorkspaceId,
- type: JwtTokenTypeEnum.API_KEY,
- workspaceId: mockWorkspaceId,
- },
- expect.objectContaining({
- expiresIn: expect.any(Number),
- jwtid: mockApiKeyId,
- }),
- );
- });
- });
-
- describe('utility methods', () => {
- describe('isExpired', () => {
- it('should return true for expired API key', () => {
- const result = service.isExpired(mockExpiredApiKey);
-
- expect(result).toBe(true);
- });
-
- it('should return false for non-expired API key', () => {
- const result = service.isExpired(mockApiKey);
-
- expect(result).toBe(false);
- });
- });
-
- describe('isRevoked', () => {
- it('should return true for revoked API key', () => {
- const result = service.isRevoked(mockRevokedApiKey);
-
- expect(result).toBe(true);
- });
-
- it('should return false for non-revoked API key', () => {
- const result = service.isRevoked(mockApiKey);
-
- expect(result).toBe(false);
- });
- });
-
- describe('isActive', () => {
- it('should return true for active API key', () => {
- const result = service.isActive(mockApiKey);
-
- expect(result).toBe(true);
- });
-
- it('should return false for revoked API key', () => {
- const result = service.isActive(mockRevokedApiKey);
-
- expect(result).toBe(false);
- });
-
- it('should return false for expired API key', () => {
- const result = service.isActive(mockExpiredApiKey);
-
- expect(result).toBe(false);
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-authorization/__tests__/application-authorization.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-authorization/__tests__/application-authorization.service.spec.ts
deleted file mode 100644
index 669daf16d06..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-authorization/__tests__/application-authorization.service.spec.ts
+++ /dev/null
@@ -1,258 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { IsNull, type Repository, type UpdateResult } from 'typeorm';
-
-import { ApplicationAuthorizationEntity } from 'src/engine/core-modules/application/application-authorization/application-authorization.entity';
-import { ApplicationAuthorizationService } from 'src/engine/core-modules/application/application-authorization/services/application-authorization.service';
-
-describe('ApplicationAuthorizationService', () => {
- let service: ApplicationAuthorizationService;
- let repository: jest.Mocked<Repository<ApplicationAuthorizationEntity>>;
-
- const queryBuilder = {
- innerJoinAndSelect: jest.fn().mockReturnThis(),
- where: jest.fn().mockReturnThis(),
- andWhere: jest.fn().mockReturnThis(),
- orderBy: jest.fn().mockReturnThis(),
- getMany: jest.fn().mockResolvedValue([]),
- insert: jest.fn().mockReturnThis(),
- values: jest.fn().mockReturnThis(),
- orIgnore: jest.fn().mockReturnThis(),
- execute: jest.fn().mockResolvedValue({ identifiers: [] }),
- };
-
- const userId = 'user-1';
- const otherUserId = 'user-2';
- const workspaceId = 'workspace-1';
- const userWorkspaceId = 'user-workspace-1';
- const applicationId = 'application-1';
- const authorizationId = 'authorization-1';
-
- const buildUpdateResult = (affected: number): UpdateResult => ({
- affected,
- raw: [],
- generatedMaps: [],
- });
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- queryBuilder.innerJoinAndSelect.mockReturnThis();
- queryBuilder.where.mockReturnThis();
- queryBuilder.andWhere.mockReturnThis();
- queryBuilder.orderBy.mockReturnThis();
- queryBuilder.getMany.mockResolvedValue([]);
- queryBuilder.insert.mockReturnThis();
- queryBuilder.values.mockReturnThis();
- queryBuilder.orIgnore.mockReturnThis();
- queryBuilder.execute.mockResolvedValue({ identifiers: [] });
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplicationAuthorizationService,
- {
- provide: getRepositoryToken(ApplicationAuthorizationEntity),
- useValue: {
- upsert: jest.fn(),
- findOneBy: jest.fn(),
- update: jest.fn(),
- createQueryBuilder: jest.fn(() => queryBuilder),
- },
- },
- ],
- }).compile();
-
- service = module.get(ApplicationAuthorizationService);
- repository = module.get(
- getRepositoryToken(ApplicationAuthorizationEntity),
- ) as jest.Mocked<Repository<ApplicationAuthorizationEntity>>;
- });
-
- describe('recordAuthorization', () => {
- it('should upsert on the user and application pair so re-authorizing does not duplicate the row', async () => {
- await service.recordAuthorization({
- userId,
- workspaceId,
- userWorkspaceId,
- applicationId,
- scopes: ['api', 'profile'],
- });
-
- expect(repository.upsert).toHaveBeenCalledWith(
- expect.objectContaining({
- userId,
- workspaceId,
- userWorkspaceId,
- applicationId,
- scopes: ['api', 'profile'],
- }),
- expect.objectContaining({
- conflictPaths: ['userId', 'applicationId'],
- }),
- );
- });
-
- it('should clear revokedAt when the user authorizes again', async () => {
- await service.recordAuthorization({
- userId,
- workspaceId,
- userWorkspaceId,
- applicationId,
- scopes: [],
- });
-
- expect(repository.upsert).toHaveBeenCalledWith(
- expect.objectContaining({ revokedAt: null }),
- expect.anything(),
- );
- });
- });
-
- describe('backfillAuthorizationFromRefreshToken', () => {
- const backfill = () =>
- service.backfillAuthorizationFromRefreshToken({
- userId,
- workspaceId,
- userWorkspaceId,
- applicationId,
- });
-
- it('should leave the consent unrecorded rather than guessing it', async () => {
- await backfill();
-
- expect(queryBuilder.values).toHaveBeenCalledWith(
- expect.objectContaining({ scopes: null, lastAuthorizedAt: null }),
- );
- });
-
- it('should never overwrite a row written by a real consent', async () => {
- await backfill();
-
- expect(queryBuilder.orIgnore).toHaveBeenCalled();
- expect(repository.upsert).not.toHaveBeenCalled();
- });
- });
-
- describe('findByUserAndApplication', () => {
- it('should not filter on revokedAt so callers can tell a revoked grant from a missing one', async () => {
- repository.findOneBy.mockResolvedValue(null);
-
- await service.findByUserAndApplication({ userId, applicationId });
-
- expect(repository.findOneBy).toHaveBeenCalledWith({
- userId,
- applicationId,
- });
- });
- });
-
- describe('findActiveAuthorizationsForUserWorkspace', () => {
- it('should only return unrevoked authorizations whose application still exists', async () => {
- await service.findActiveAuthorizationsForUserWorkspace({
- userId,
- workspaceId,
- });
-
- expect(queryBuilder.innerJoinAndSelect).toHaveBeenCalledWith(
- 'applicationAuthorization.application',
- 'application',
- );
- expect(queryBuilder.where).toHaveBeenCalledWith(
- 'applicationAuthorization.userId = :userId',
- { userId },
- );
- expect(queryBuilder.andWhere).toHaveBeenCalledWith(
- 'applicationAuthorization.revokedAt IS NULL',
- );
- });
-
- it('should scope the query to the current workspace', async () => {
- await service.findActiveAuthorizationsForUserWorkspace({
- userId,
- workspaceId,
- });
-
- expect(queryBuilder.andWhere).toHaveBeenCalledWith(
- 'applicationAuthorization.workspaceId = :workspaceId',
- { workspaceId },
- );
- });
-
- it('should put the most recently used authorization first', async () => {
- await service.findActiveAuthorizationsForUserWorkspace({
- userId,
- workspaceId,
- });
-
- expect(queryBuilder.orderBy).toHaveBeenCalledWith(
- 'applicationAuthorization.lastUsedAt',
- 'DESC',
- );
- });
- });
-
- describe('revokeAuthorizationByIdForUserWorkspace', () => {
- it('should scope the update by userId and workspaceId so an id from elsewhere matches nothing', async () => {
- repository.update.mockResolvedValue(buildUpdateResult(0));
-
- const revoked = await service.revokeAuthorizationByIdForUserWorkspace({
- authorizationId,
- userId: otherUserId,
- workspaceId,
- });
-
- expect(repository.update).toHaveBeenCalledWith(
- {
- id: authorizationId,
- userId: otherUserId,
- workspaceId,
- revokedAt: IsNull(),
- },
- expect.objectContaining({ revokedAt: expect.any(Date) }),
- );
- expect(revoked).toBe(false);
- });
-
- it('should report true when the row was still active', async () => {
- repository.update.mockResolvedValue(buildUpdateResult(1));
-
- expect(
- await service.revokeAuthorizationByIdForUserWorkspace({
- authorizationId,
- userId,
- workspaceId,
- }),
- ).toBe(true);
- });
-
- it('should report false when the row was already revoked', async () => {
- repository.update.mockResolvedValue(buildUpdateResult(0));
-
- expect(
- await service.revokeAuthorizationByIdForUserWorkspace({
- authorizationId,
- userId,
- workspaceId,
- }),
- ).toBe(false);
- });
- });
-
- describe('revokeAuthorizationForApplication', () => {
- it('should revoke the live row for that user and application', async () => {
- repository.update.mockResolvedValue(buildUpdateResult(1));
-
- const revoked = await service.revokeAuthorizationForApplication({
- userId,
- applicationId,
- });
-
- expect(repository.update).toHaveBeenCalledWith(
- { userId, applicationId, revokedAt: IsNull() },
- expect.objectContaining({ revokedAt: expect.any(Date) }),
- );
- expect(revoked).toBe(true);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-job/services/__tests__/application-job.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-job/services/__tests__/application-job.service.spec.ts
deleted file mode 100644
index ab28084a809..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-job/services/__tests__/application-job.service.spec.ts
+++ /dev/null
@@ -1,200 +0,0 @@
-import { ENQUEUE_JOB_PRIORITY } from 'src/engine/core-modules/application/application-job/constants/enqueue-job.constant';
-import { type EnqueueJobInputDTO } from 'src/engine/core-modules/application/application-job/dtos/enqueue-job.input';
-import { ApplicationJobService } from 'src/engine/core-modules/application/application-job/services/application-job.service';
-import {
- ApplicationException,
- ApplicationExceptionCode,
-} from 'src/engine/core-modules/application/application.exception';
-import { LogicFunctionTriggerJob } from 'src/engine/core-modules/logic-function/logic-function-trigger/jobs/logic-function-trigger.job';
-import { type MessageQueueService } from 'src/engine/core-modules/message-queue/services/message-queue.service';
-import { type WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-const APPLICATION_ID = 'c2a9e9d0-1f42-4f0e-9a0e-6d2e4b2a1f01';
-const WORKSPACE_ID = '20202020-1c25-4d02-bf25-6aeccf7ea419';
-const TARGET_UNIVERSAL_IDENTIFIER = '5a2f4d2a-1a1e-4c66-8a54-1f0a2b3c4d5e';
-const TARGET_LOGIC_FUNCTION_ID = 'ab6a2e5c-8c1f-4d0a-9bd1-52c1f5a9e100';
-
-const buildFlatLogicFunction = (
- overrides: Partial<{
- applicationId: string;
- deletedAt: Date | null;
- }> = {},
-) => ({
- id: TARGET_LOGIC_FUNCTION_ID,
- universalIdentifier: TARGET_UNIVERSAL_IDENTIFIER,
- applicationId: APPLICATION_ID,
- deletedAt: null,
- ...overrides,
-});
-
-describe('ApplicationJobService', () => {
- let service: ApplicationJobService;
- let workspaceCacheService: jest.Mocked<
- Pick<WorkspaceCacheService, 'getOrRecompute'>
- >;
- let messageQueueService: jest.Mocked<Pick<MessageQueueService, 'add'>>;
-
- const setCachedLogicFunctions = (
- flatLogicFunctions: ReturnType<typeof buildFlatLogicFunction>[],
- ) => {
- workspaceCacheService.getOrRecompute.mockResolvedValue({
- flatLogicFunctionMaps: {
- byUniversalIdentifier: Object.fromEntries(
- flatLogicFunctions.map((flatLogicFunction) => [
- flatLogicFunction.universalIdentifier,
- flatLogicFunction,
- ]),
- ),
- },
- // oxlint-disable-next-line typescript/no-explicit-any
- } as any);
- };
-
- const enqueueJob = (
- input: EnqueueJobInputDTO,
- overrides: { userId?: string | null; userWorkspaceId?: string | null } = {},
- ) =>
- service.enqueueJob({
- applicationId: APPLICATION_ID,
- workspaceId: WORKSPACE_ID,
- userId: overrides.userId ?? null,
- userWorkspaceId: overrides.userWorkspaceId ?? null,
- input,
- });
-
- beforeEach(() => {
- jest.clearAllMocks();
-
- workspaceCacheService = { getOrRecompute: jest.fn() };
- setCachedLogicFunctions([buildFlatLogicFunction()]);
- messageQueueService = { add: jest.fn().mockResolvedValue(undefined) };
-
- service = new ApplicationJobService(
- workspaceCacheService as unknown as WorkspaceCacheService,
- messageQueueService as unknown as MessageQueueService,
- );
- });
-
- it('should enqueue a logic function trigger job with the provided job options', async () => {
- const result = await enqueueJob({
- logicFunctionUniversalIdentifier: TARGET_UNIVERSAL_IDENTIFIER,
- payload: { batchIndex: 2 },
- retryLimit: 3,
- delayMs: 1000,
- });
-
- expect(result).toEqual({
- enqueued: true,
- logicFunctionUniversalIdentifier: TARGET_UNIVERSAL_IDENTIFIER,
- });
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- LogicFunctionTriggerJob.name,
- {
- logicFunctionId: TARGET_LOGIC_FUNCTION_ID,
- workspaceId: WORKSPACE_ID,
- payload: { batchIndex: 2 },
- },
- { retryLimit: 3, priority: ENQUEUE_JOB_PRIORITY, delay: 1000 },
- );
- });
-
- it('should always enqueue at the lowest priority so platform jobs go first', async () => {
- await enqueueJob({
- logicFunctionUniversalIdentifier: TARGET_UNIVERSAL_IDENTIFIER,
- });
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- LogicFunctionTriggerJob.name,
- expect.anything(),
- expect.objectContaining({ priority: ENQUEUE_JOB_PRIORITY }),
- );
- });
-
- it('should default to no retry and omit unset queue options', async () => {
- await enqueueJob({
- logicFunctionUniversalIdentifier: TARGET_UNIVERSAL_IDENTIFIER,
- });
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- LogicFunctionTriggerJob.name,
- {
- logicFunctionId: TARGET_LOGIC_FUNCTION_ID,
- workspaceId: WORKSPACE_ID,
- payload: {},
- },
- { retryLimit: 0, priority: ENQUEUE_JOB_PRIORITY },
- );
- });
-
- it('should forward the acting user so the queued run keeps the caller permissions', async () => {
- await enqueueJob(
- { logicFunctionUniversalIdentifier: TARGET_UNIVERSAL_IDENTIFIER },
- { userId: 'user-1', userWorkspaceId: 'user-workspace-1' },
- );
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- LogicFunctionTriggerJob.name,
- expect.objectContaining({
- userId: 'user-1',
- userWorkspaceId: 'user-workspace-1',
- }),
- expect.anything(),
- );
- });
-
- it('should resolve the target from the workspace cache instead of the database', async () => {
- await enqueueJob({
- logicFunctionUniversalIdentifier: TARGET_UNIVERSAL_IDENTIFIER,
- });
-
- expect(workspaceCacheService.getOrRecompute).toHaveBeenCalledWith(
- WORKSPACE_ID,
- ['flatLogicFunctionMaps'],
- );
- });
-
- it('should throw LOGIC_FUNCTION_NOT_FOUND when the function belongs to another application', async () => {
- setCachedLogicFunctions([
- buildFlatLogicFunction({ applicationId: 'another-application-id' }),
- ]);
-
- await expect(
- enqueueJob({
- logicFunctionUniversalIdentifier: TARGET_UNIVERSAL_IDENTIFIER,
- }),
- ).rejects.toMatchObject({
- code: ApplicationExceptionCode.LOGIC_FUNCTION_NOT_FOUND,
- });
-
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('should throw LOGIC_FUNCTION_NOT_FOUND when the function is soft deleted', async () => {
- setCachedLogicFunctions([
- buildFlatLogicFunction({ deletedAt: new Date('2026-01-01') }),
- ]);
-
- await expect(
- enqueueJob({
- logicFunctionUniversalIdentifier: TARGET_UNIVERSAL_IDENTIFIER,
- }),
- ).rejects.toMatchObject({
- code: ApplicationExceptionCode.LOGIC_FUNCTION_NOT_FOUND,
- });
-
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('should throw LOGIC_FUNCTION_NOT_FOUND when the function is unknown', async () => {
- setCachedLogicFunctions([]);
-
- await expect(
- enqueueJob({
- logicFunctionUniversalIdentifier: TARGET_UNIVERSAL_IDENTIFIER,
- }),
- ).rejects.toThrow(ApplicationException);
-
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-manifest/__tests__/application-manifest-apply.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-manifest/__tests__/application-manifest-apply.service.spec.ts
deleted file mode 100644
index 878db218e42..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-manifest/__tests__/application-manifest-apply.service.spec.ts
+++ /dev/null
@@ -1,227 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type Manifest } from 'twenty-shared/application';
-
-import { ApplicationManifestApplyService } from 'src/engine/core-modules/application/application-manifest/application-manifest-apply.service';
-import { ApplicationSyncService } from 'src/engine/core-modules/application/application-manifest/application-sync.service';
-import { ApplicationRegistrationService } from 'src/engine/core-modules/application/application-registration/application-registration.service';
-import { ApplicationRegistrationSourceType } from 'src/engine/core-modules/application/application-registration/enums/application-registration-source-type.enum';
-import { type ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
-import { SdkClientGenerationService } from 'src/engine/core-modules/sdk-client/sdk-client-generation.service';
-
-const WORKSPACE_ID = '20202020-0000-4000-8000-000000000001';
-const REGISTRATION_ID = '20202020-0000-4000-8000-000000000002';
-const APPLICATION_ID = '20202020-0000-4000-8000-000000000003';
-
-const buildManifest = (overrides: Record<string, unknown> = {}): Manifest =>
- ({
- application: {
- universalIdentifier: 'my-app',
- displayName: 'My App',
- ...overrides,
- },
- }) as Manifest;
-
-const buildApplication = (version: string | null): ApplicationEntity =>
- ({
- id: APPLICATION_ID,
- universalIdentifier: 'my-app',
- version,
- }) as ApplicationEntity;
-
-describe('ApplicationManifestApplyService', () => {
- let service: ApplicationManifestApplyService;
-
- const mockApplicationSyncService = {
- synchronizeFromManifest: jest.fn(),
- };
-
- const mockSdkClientGenerationService = {
- generateSdkClientForApplication: jest.fn(),
- };
-
- const mockApplicationRegistrationService = {
- findOneByIdGlobal: jest.fn(),
- updateFromManifest: jest.fn(),
- };
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- mockApplicationSyncService.synchronizeFromManifest.mockResolvedValue({
- workspaceMigration: { actions: [] },
- hasSchemaMetadataChanged: false,
- });
- mockApplicationRegistrationService.updateFromManifest.mockResolvedValue(
- true,
- );
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplicationManifestApplyService,
- {
- provide: ApplicationSyncService,
- useValue: mockApplicationSyncService,
- },
- {
- provide: SdkClientGenerationService,
- useValue: mockSdkClientGenerationService,
- },
- {
- provide: ApplicationRegistrationService,
- useValue: mockApplicationRegistrationService,
- },
- ],
- }).compile();
-
- service = module.get(ApplicationManifestApplyService);
- });
-
- describe('applyManifestToWorkspace', () => {
- it('should generate the SDK client when the application has no version yet', async () => {
- await service.applyManifestToWorkspace({
- workspaceId: WORKSPACE_ID,
- manifest: buildManifest(),
- applicationRegistrationId: REGISTRATION_ID,
- application: buildApplication(null),
- });
-
- expect(
- mockSdkClientGenerationService.generateSdkClientForApplication,
- ).toHaveBeenCalledWith({
- workspaceId: WORKSPACE_ID,
- applicationId: APPLICATION_ID,
- applicationUniversalIdentifier: 'my-app',
- trigger: 'manifest-sync',
- });
- });
-
- it('should generate the SDK client when the schema changed', async () => {
- mockApplicationSyncService.synchronizeFromManifest.mockResolvedValue({
- workspaceMigration: { actions: [] },
- hasSchemaMetadataChanged: true,
- });
-
- await service.applyManifestToWorkspace({
- workspaceId: WORKSPACE_ID,
- manifest: buildManifest(),
- applicationRegistrationId: REGISTRATION_ID,
- application: buildApplication('1.0.0'),
- });
-
- expect(
- mockSdkClientGenerationService.generateSdkClientForApplication,
- ).toHaveBeenCalled();
- });
-
- it('should not generate the SDK client on an unchanged re-apply', async () => {
- await service.applyManifestToWorkspace({
- workspaceId: WORKSPACE_ID,
- manifest: buildManifest(),
- applicationRegistrationId: REGISTRATION_ID,
- application: buildApplication('1.0.0'),
- });
-
- expect(
- mockSdkClientGenerationService.generateSdkClientForApplication,
- ).not.toHaveBeenCalled();
- });
- });
-
- describe('refreshRegistrationFromManifest', () => {
- it('should update the registration', async () => {
- const manifest = buildManifest();
-
- const result = await service.refreshRegistrationFromManifest({
- applicationRegistrationId: REGISTRATION_ID,
- manifest,
- latestAvailableVersion: '1.2.0',
- preventVersionDowngrade: true,
- });
-
- expect(result).toBe(true);
- expect(
- mockApplicationRegistrationService.updateFromManifest,
- ).toHaveBeenCalledWith({
- applicationRegistrationId: REGISTRATION_ID,
- manifest,
- sourceType: undefined,
- latestAvailableVersion: '1.2.0',
- preventVersionDowngrade: true,
- });
- });
-
- it('should report a registration update skipped as a downgrade', async () => {
- mockApplicationRegistrationService.updateFromManifest.mockResolvedValue(
- false,
- );
-
- const result = await service.refreshRegistrationFromManifest({
- applicationRegistrationId: REGISTRATION_ID,
- manifest: buildManifest(),
- latestAvailableVersion: '0.9.0',
- preventVersionDowngrade: true,
- });
-
- expect(result).toBe(false);
- });
-
- it('should skip npm-sourced registrations when scoped to a workspace', async () => {
- mockApplicationRegistrationService.findOneByIdGlobal.mockResolvedValue({
- id: REGISTRATION_ID,
- sourceType: ApplicationRegistrationSourceType.NPM,
- ownerWorkspaceId: WORKSPACE_ID,
- });
-
- const result = await service.refreshRegistrationFromManifest({
- applicationRegistrationId: REGISTRATION_ID,
- manifest: buildManifest(),
- onlyIfOwnedByWorkspaceId: WORKSPACE_ID,
- });
-
- expect(result).toBe(false);
- expect(
- mockApplicationRegistrationService.updateFromManifest,
- ).not.toHaveBeenCalled();
- });
-
- it('should skip registrations owned by another workspace when scoped to a workspace', async () => {
- mockApplicationRegistrationService.findOneByIdGlobal.mockResolvedValue({
- id: REGISTRATION_ID,
- sourceType: ApplicationRegistrationSourceType.LOCAL,
- ownerWorkspaceId: 'another-workspace-id',
- });
-
- const result = await service.refreshRegistrationFromManifest({
- applicationRegistrationId: REGISTRATION_ID,
- manifest: buildManifest(),
- onlyIfOwnedByWorkspaceId: WORKSPACE_ID,
- });
-
- expect(result).toBe(false);
- expect(
- mockApplicationRegistrationService.updateFromManifest,
- ).not.toHaveBeenCalled();
- });
-
- it('should update a workspace-owned registration when scoped to that workspace', async () => {
- mockApplicationRegistrationService.findOneByIdGlobal.mockResolvedValue({
- id: REGISTRATION_ID,
- sourceType: ApplicationRegistrationSourceType.LOCAL,
- ownerWorkspaceId: WORKSPACE_ID,
- });
-
- const result = await service.refreshRegistrationFromManifest({
- applicationRegistrationId: REGISTRATION_ID,
- manifest: buildManifest(),
- sourceType: ApplicationRegistrationSourceType.LOCAL,
- onlyIfOwnedByWorkspaceId: WORKSPACE_ID,
- });
-
- expect(result).toBe(true);
- expect(
- mockApplicationRegistrationService.updateFromManifest,
- ).toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-oauth/__tests__/oauth.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-oauth/__tests__/oauth.service.spec.ts
deleted file mode 100644
index 896fadd3fc6..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-oauth/__tests__/oauth.service.spec.ts
+++ /dev/null
@@ -1,489 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { AppTokenEntity } from 'src/engine/core-modules/app-token/app-token.entity';
-import { type ApplicationAuthorizationEntity } from 'src/engine/core-modules/application/application-authorization/application-authorization.entity';
-import { ApplicationAuthorizationService } from 'src/engine/core-modules/application/application-authorization/services/application-authorization.service';
-import { ApplicationInstallService } from 'src/engine/core-modules/application/application-install/application-install.service';
-import { OAuthService } from 'src/engine/core-modules/application/application-oauth/oauth.service';
-import { ApplicationRegistrationService } from 'src/engine/core-modules/application/application-registration/application-registration.service';
-import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { ApplicationTokenService } from 'src/engine/core-modules/auth/token/services/application-token.service';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-
-describe('OAuthService', () => {
- let service: OAuthService;
-
- const clientId = 'client-1';
- const clientSecret = 'client-secret';
- const userId = 'user-1';
- const workspaceId = 'workspace-1';
- const userWorkspaceId = 'user-workspace-1';
- const applicationId = 'application-1';
- const applicationRegistrationId = 'application-registration-1';
- const redirectUri = 'https://app.example.com/callback';
- const authorizationId = 'authorization-1';
-
- const applicationRegistration = {
- id: applicationRegistrationId,
- name: 'Example',
- universalIdentifier: 'example',
- latestAvailableVersion: '1.0.0',
- oAuthClientSecretHash: 'hash',
- oAuthScopes: ['api', 'profile'],
- };
-
- const application = {
- id: applicationId,
- workspaceId,
- applicationRegistrationId,
- };
-
- const refreshTokenPayload = {
- sub: applicationId,
- type: JwtTokenTypeEnum.APPLICATION_REFRESH,
- applicationId,
- workspaceId,
- userWorkspaceId,
- userId,
- };
-
- const appTokenRepository = { findOne: jest.fn(), update: jest.fn() };
- const applicationRepository = { find: jest.fn(), findOne: jest.fn() };
- const userWorkspaceRepository = { findOne: jest.fn() };
-
- const applicationTokenService = {
- generateApplicationTokenPair: jest.fn(),
- generateApplicationAccessToken: jest.fn(),
- validateApplicationRefreshToken: jest.fn(),
- validateApplicationAccessToken: jest.fn(),
- renewApplicationTokens: jest.fn(),
- decodeToken: jest.fn(),
- };
-
- const applicationAuthorizationService = {
- recordAuthorization: jest.fn(),
- backfillAuthorizationFromRefreshToken: jest.fn(),
- findByUserAndApplication: jest.fn(),
- touchLastUsedAt: jest.fn(),
- revokeAuthorizationForApplication: jest.fn(),
- };
-
- const applicationRegistrationService = {
- findOneByClientId: jest.fn(),
- verifyClientSecret: jest.fn(),
- };
-
- const buildAuthorization = (
- overrides: Partial<ApplicationAuthorizationEntity> = {},
- ): ApplicationAuthorizationEntity =>
- ({
- id: authorizationId,
- userId,
- workspaceId,
- userWorkspaceId,
- applicationId,
- scopes: ['api'],
- revokedAt: null,
- ...overrides,
- }) as ApplicationAuthorizationEntity;
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- applicationRegistrationService.findOneByClientId.mockResolvedValue(
- applicationRegistration,
- );
- applicationRegistrationService.verifyClientSecret.mockResolvedValue(true);
- applicationRepository.findOne.mockResolvedValue(application);
- userWorkspaceRepository.findOne.mockResolvedValue({ id: userWorkspaceId });
- applicationTokenService.generateApplicationTokenPair.mockResolvedValue({
- applicationAccessToken: { token: 'access-token', expiresAt: new Date() },
- applicationRefreshToken: {
- token: 'refresh-token',
- expiresAt: new Date(),
- },
- });
- applicationTokenService.renewApplicationTokens.mockResolvedValue({
- applicationAccessToken: { token: 'access-token', expiresAt: new Date() },
- applicationRefreshToken: {
- token: 'refresh-token',
- expiresAt: new Date(),
- },
- });
- applicationTokenService.validateApplicationRefreshToken.mockResolvedValue(
- refreshTokenPayload,
- );
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- OAuthService,
- {
- provide: getRepositoryToken(AppTokenEntity),
- useValue: appTokenRepository,
- },
- {
- provide: getRepositoryToken(ApplicationEntity),
- useValue: applicationRepository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: userWorkspaceRepository,
- },
- {
- provide: ApplicationTokenService,
- useValue: applicationTokenService,
- },
- {
- provide: ApplicationAuthorizationService,
- useValue: applicationAuthorizationService,
- },
- {
- provide: ApplicationRegistrationService,
- useValue: applicationRegistrationService,
- },
- { provide: ApplicationService, useValue: { create: jest.fn() } },
- {
- provide: ApplicationInstallService,
- useValue: { installApplication: jest.fn() },
- },
- {
- provide: TwentyConfigService,
- useValue: { get: jest.fn(() => '30m') },
- },
- ],
- }).compile();
-
- service = module.get(OAuthService);
- });
-
- describe('exchangeAuthorizationCode', () => {
- const exchange = () =>
- service.exchangeAuthorizationCode({
- authorizationCode: 'code',
- clientId,
- clientSecret,
- redirectUri,
- });
-
- beforeEach(() => {
- appTokenRepository.findOne.mockResolvedValue({
- id: 'app-token-1',
- userId,
- workspaceId,
- revokedAt: null,
- expiresAt: new Date(Date.now() + 60 * 1000),
- context: { clientId, redirectUri, scope: 'api profile' },
- });
- });
-
- it('should record the authorization with the granted scopes', async () => {
- await exchange();
-
- expect(
- applicationAuthorizationService.recordAuthorization,
- ).toHaveBeenCalledWith({
- userId,
- workspaceId,
- userWorkspaceId,
- applicationId,
- scopes: ['api', 'profile'],
- });
- });
-
- it('should record the authorization before issuing the token pair', async () => {
- await exchange();
-
- expect(
- applicationAuthorizationService.recordAuthorization.mock
- .invocationCallOrder[0],
- ).toBeLessThan(
- applicationTokenService.generateApplicationTokenPair.mock
- .invocationCallOrder[0],
- );
- });
-
- it('should record no scopes when the authorization carried an empty scope', async () => {
- appTokenRepository.findOne.mockResolvedValue({
- id: 'app-token-1',
- userId,
- workspaceId,
- revokedAt: null,
- expiresAt: new Date(Date.now() + 60 * 1000),
- context: { clientId, redirectUri, scope: '' },
- });
-
- await exchange();
-
- expect(
- applicationAuthorizationService.recordAuthorization,
- ).toHaveBeenCalledWith(expect.objectContaining({ scopes: [] }));
- });
- });
-
- describe('refreshTokenGrant', () => {
- const refresh = () =>
- service.refreshTokenGrant({
- refreshToken: 'refresh-token',
- clientId,
- clientSecret,
- });
-
- it('should refuse to renew once the user revoked the application', async () => {
- applicationAuthorizationService.findByUserAndApplication.mockResolvedValue(
- buildAuthorization({ revokedAt: new Date() }),
- );
-
- const result = await refresh();
-
- expect(result).toEqual(
- expect.objectContaining({ error: 'invalid_grant' }),
- );
- expect(
- applicationTokenService.renewApplicationTokens,
- ).not.toHaveBeenCalled();
- });
-
- it('should renew and touch the authorization when it is still live', async () => {
- applicationAuthorizationService.findByUserAndApplication.mockResolvedValue(
- buildAuthorization(),
- );
-
- const result = await refresh();
-
- expect(result).toEqual(
- expect.objectContaining({ access_token: 'access-token' }),
- );
- expect(
- applicationAuthorizationService.touchLastUsedAt,
- ).toHaveBeenCalledWith(authorizationId);
- });
-
- it('should backfill the missing grant for a refresh token issued before authorizations were recorded', async () => {
- applicationAuthorizationService.findByUserAndApplication.mockResolvedValue(
- null,
- );
-
- const result = await refresh();
-
- expect(
- applicationAuthorizationService.backfillAuthorizationFromRefreshToken,
- ).toHaveBeenCalledWith({
- userId,
- workspaceId,
- userWorkspaceId,
- applicationId,
- });
- expect(result).toEqual(
- expect.objectContaining({ access_token: 'access-token' }),
- );
- });
-
- // The token carries no scope claim, so what the registration declares now
- // is not evidence of what this user agreed to.
- it('should not pass the registration scopes off as the backfilled consent', async () => {
- applicationAuthorizationService.findByUserAndApplication.mockResolvedValue(
- null,
- );
-
- await refresh();
-
- expect(
- applicationAuthorizationService.backfillAuthorizationFromRefreshToken,
- ).toHaveBeenCalledWith(expect.not.objectContaining({ scopes: [] }));
- expect(
- applicationAuthorizationService.recordAuthorization,
- ).not.toHaveBeenCalled();
- });
-
- it('should refuse to renew when the user is no longer a member of the workspace', async () => {
- applicationAuthorizationService.findByUserAndApplication.mockResolvedValue(
- null,
- );
- userWorkspaceRepository.findOne.mockResolvedValue(null);
-
- const result = await refresh();
-
- expect(result).toEqual(
- expect.objectContaining({ error: 'invalid_grant' }),
- );
- expect(
- applicationAuthorizationService.backfillAuthorizationFromRefreshToken,
- ).not.toHaveBeenCalled();
- });
-
- // Removing a member soft-deletes the membership, so the grant outlives it.
- it('should refuse to renew an existing grant once the membership is gone', async () => {
- applicationAuthorizationService.findByUserAndApplication.mockResolvedValue(
- buildAuthorization(),
- );
- userWorkspaceRepository.findOne.mockResolvedValue(null);
-
- const result = await refresh();
-
- expect(result).toEqual(
- expect.objectContaining({ error: 'invalid_grant' }),
- );
- expect(
- applicationTokenService.renewApplicationTokens,
- ).not.toHaveBeenCalled();
- expect(
- applicationAuthorizationService.touchLastUsedAt,
- ).not.toHaveBeenCalled();
- });
-
- it('should not look for an authorization when the token carries no user', async () => {
- applicationTokenService.validateApplicationRefreshToken.mockResolvedValue(
- {
- ...refreshTokenPayload,
- userId: undefined,
- userWorkspaceId: undefined,
- },
- );
-
- const result = await refresh();
-
- expect(
- applicationAuthorizationService.findByUserAndApplication,
- ).not.toHaveBeenCalled();
- expect(result).toEqual(
- expect.objectContaining({ access_token: 'access-token' }),
- );
- });
- });
-
- describe('revokeToken', () => {
- it('should revoke the underlying authorization', async () => {
- const result = await service.revokeToken({
- token: 'refresh-token',
- clientId,
- clientSecret,
- });
-
- expect(
- applicationAuthorizationService.revokeAuthorizationForApplication,
- ).toHaveBeenCalledWith({ userId, applicationId });
- expect(result).toEqual({ success: true });
- });
-
- // Without the row, the refresh path would find nothing and backfill a
- // fresh active grant, so revoking a token that predates the record would
- // silently do nothing.
- it('should lay down the row before revoking so a pre-record token stays revoked', async () => {
- await service.revokeToken({
- token: 'refresh-token',
- clientId,
- clientSecret,
- });
-
- expect(
- applicationAuthorizationService.backfillAuthorizationFromRefreshToken
- .mock.invocationCallOrder[0],
- ).toBeLessThan(
- applicationAuthorizationService.revokeAuthorizationForApplication.mock
- .invocationCallOrder[0],
- );
- });
-
- it('should still revoke when the membership is gone', async () => {
- userWorkspaceRepository.findOne.mockResolvedValue(null);
-
- await service.revokeToken({
- token: 'refresh-token',
- clientId,
- clientSecret,
- });
-
- expect(
- applicationAuthorizationService.backfillAuthorizationFromRefreshToken,
- ).not.toHaveBeenCalled();
- expect(
- applicationAuthorizationService.revokeAuthorizationForApplication,
- ).toHaveBeenCalledWith({ userId, applicationId });
- });
-
- it('should stay a no-op for a token that carries no user', async () => {
- applicationTokenService.validateApplicationRefreshToken.mockResolvedValue(
- {
- ...refreshTokenPayload,
- userId: undefined,
- },
- );
-
- const result = await service.revokeToken({
- token: 'refresh-token',
- clientId,
- clientSecret,
- });
-
- expect(
- applicationAuthorizationService.revokeAuthorizationForApplication,
- ).not.toHaveBeenCalled();
- expect(result).toEqual({ success: true });
- });
-
- it('should refuse to revoke an authorization the asking client was not issued', async () => {
- applicationRepository.findOne.mockResolvedValue({
- ...application,
- applicationRegistrationId: 'another-registration',
- });
-
- const result = await service.revokeToken({
- token: 'refresh-token',
- clientId,
- clientSecret,
- });
-
- expect(
- applicationAuthorizationService.revokeAuthorizationForApplication,
- ).not.toHaveBeenCalled();
- expect(result).toEqual({ success: true });
- });
-
- it('should stay a no-op when the caller did not identify itself as a client', async () => {
- const result = await service.revokeToken({ token: 'refresh-token' });
-
- expect(
- applicationAuthorizationService.revokeAuthorizationForApplication,
- ).not.toHaveBeenCalled();
- expect(result).toEqual({ success: true });
- });
- });
-
- describe('introspectToken', () => {
- beforeEach(() => {
- applicationTokenService.decodeToken.mockReturnValue(refreshTokenPayload);
- });
-
- it('should report a refresh token inactive once its authorization is revoked', async () => {
- applicationAuthorizationService.findByUserAndApplication.mockResolvedValue(
- buildAuthorization({ revokedAt: new Date() }),
- );
-
- expect(
- await service.introspectToken({
- token: 'refresh-token',
- clientId,
- clientSecret,
- }),
- ).toEqual({ active: false });
- });
-
- it('should report a refresh token active while its authorization stands', async () => {
- applicationAuthorizationService.findByUserAndApplication.mockResolvedValue(
- buildAuthorization(),
- );
-
- expect(
- await service.introspectToken({
- token: 'refresh-token',
- clientId,
- clientSecret,
- }),
- ).toEqual(expect.objectContaining({ active: true }));
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-package/application-version-validation.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-package/application-version-validation.service.spec.ts
deleted file mode 100644
index 672246d42a1..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-package/application-version-validation.service.spec.ts
+++ /dev/null
@@ -1,238 +0,0 @@
-import { Test } from '@nestjs/testing';
-
-import { ApplicationVersionValidationService } from 'src/engine/core-modules/application/application-package/application-version-validation.service';
-import { UpgradeStatusService } from 'src/engine/core-modules/upgrade/services/upgrade-status.service';
-
-describe('ApplicationVersionValidationService', () => {
- let service: ApplicationVersionValidationService;
- let getInstanceCompletedVersion: jest.Mock;
- let getWorkspaceCompletedVersion: jest.Mock;
-
- beforeEach(async () => {
- getInstanceCompletedVersion = jest.fn();
- getWorkspaceCompletedVersion = jest.fn();
-
- const module = await Test.createTestingModule({
- providers: [
- ApplicationVersionValidationService,
- {
- provide: UpgradeStatusService,
- useValue: {
- getInstanceCompletedVersion,
- getWorkspaceCompletedVersion,
- },
- },
- ],
- }).compile();
-
- service = module.get(ApplicationVersionValidationService);
- });
-
- describe('validateServerCompatibility', () => {
- it('should be compatible when no required version is declared', async () => {
- await expect(
- service.validateServerCompatibility(undefined),
- ).resolves.toEqual({ compatible: true });
- });
-
- it('should reject an invalid semver range', async () => {
- const result = await service.validateServerCompatibility('not-semver');
-
- expect(result).toMatchObject({
- compatible: false,
- reason: 'INVALID_REQUIRED_VERSION',
- });
- });
-
- it('should be compatible when the instance completed version satisfies the range', async () => {
- getInstanceCompletedVersion.mockResolvedValue('2.19.0');
-
- await expect(
- service.validateServerCompatibility('>=2.19.0'),
- ).resolves.toEqual({ compatible: true });
- });
-
- it('should be incompatible when the instance completed version does not satisfy the range', async () => {
- getInstanceCompletedVersion.mockResolvedValue('2.18.0');
-
- const result = await service.validateServerCompatibility('>=2.19.0');
-
- expect(result).toMatchObject({
- compatible: false,
- reason: 'INSTANCE_INCOMPATIBLE',
- });
- });
-
- it('should fail when the instance completed version is not valid semver', async () => {
- getInstanceCompletedVersion.mockResolvedValue(null);
-
- const result = await service.validateServerCompatibility('>=2.19.0');
-
- expect(result).toMatchObject({
- compatible: false,
- reason: 'INVALID_SERVER_VERSION',
- });
- });
- });
-
- describe('validateWorkspaceCompatibility', () => {
- it('should be compatible when no required version is declared', async () => {
- await expect(
- service.validateWorkspaceCompatibility({
- requiredServerVersion: undefined,
- workspaceId: 'ws-1',
- }),
- ).resolves.toEqual({ compatible: true });
-
- expect(getWorkspaceCompletedVersion).not.toHaveBeenCalled();
- });
-
- it('should reject an invalid semver range', async () => {
- const result = await service.validateWorkspaceCompatibility({
- requiredServerVersion: 'not-semver',
- workspaceId: 'ws-1',
- });
-
- expect(result).toMatchObject({
- compatible: false,
- reason: 'INVALID_REQUIRED_VERSION',
- });
- });
-
- it('should be compatible when the workspace completed version satisfies the range', async () => {
- getWorkspaceCompletedVersion.mockResolvedValue('2.19.0');
-
- await expect(
- service.validateWorkspaceCompatibility({
- requiredServerVersion: '>=2.19.0',
- workspaceId: 'ws-1',
- }),
- ).resolves.toEqual({ compatible: true });
-
- expect(getWorkspaceCompletedVersion).toHaveBeenCalledWith('ws-1');
- expect(getInstanceCompletedVersion).not.toHaveBeenCalled();
- });
-
- it('should be incompatible when the workspace has only completed an earlier version', async () => {
- getWorkspaceCompletedVersion.mockResolvedValue('2.18.0');
-
- const result = await service.validateWorkspaceCompatibility({
- requiredServerVersion: '>=2.19.0',
- workspaceId: 'ws-1',
- });
-
- expect(result).toMatchObject({
- compatible: false,
- reason: 'WORKSPACE_INCOMPATIBLE',
- message:
- 'App requires Twenty server >=2.19.0 but this workspace has only completed the upgrade to 2.18.0.',
- });
- });
-
- it('should be incompatible when the workspace has no interpretable upgrade cursor', async () => {
- getWorkspaceCompletedVersion.mockResolvedValue(null);
-
- const result = await service.validateWorkspaceCompatibility({
- requiredServerVersion: '>=2.19.0',
- workspaceId: 'ws-1',
- });
-
- expect(result).toMatchObject({
- compatible: false,
- reason: 'INVALID_WORKSPACE_VERSION',
- message:
- 'Cannot determine the completed upgrade version for workspace ws-1: no interpretable upgrade cursor found.',
- });
- expect(getInstanceCompletedVersion).not.toHaveBeenCalled();
- });
- });
-
- describe('validateVersionProgression', () => {
- it('should reject an invalid incoming version', () => {
- const result = service.validateVersionProgression({
- incomingVersion: 'not-semver',
- currentVersion: '1.0.0',
- universalIdentifier: 'my-app',
- action: 'install',
- });
-
- expect(result).toMatchObject({
- allowed: false,
- reason: 'INVALID_INCOMING_VERSION',
- });
- });
-
- it('should allow any progression when the current version is not valid semver', () => {
- expect(
- service.validateVersionProgression({
- incomingVersion: '1.0.0',
- currentVersion: 'unknown',
- universalIdentifier: 'my-app',
- action: 'install',
- }),
- ).toEqual({ allowed: true });
- });
-
- it('should allow a higher version', () => {
- for (const action of ['install', 'deploy'] as const) {
- expect(
- service.validateVersionProgression({
- incomingVersion: '1.1.0',
- currentVersion: '1.0.0',
- universalIdentifier: 'my-app',
- action,
- }),
- ).toEqual({ allowed: true });
- }
- });
-
- it('should reject the same version on install as already installed', () => {
- const result = service.validateVersionProgression({
- incomingVersion: '1.0.0',
- currentVersion: '1.0.0',
- universalIdentifier: 'my-app',
- action: 'install',
- });
-
- expect(result).toMatchObject({
- allowed: false,
- reason: 'SAME_VERSION',
- message: '[email protected] is already installed in this workspace.',
- });
- });
-
- it('should reject a lower version on install as a downgrade', () => {
- const result = service.validateVersionProgression({
- incomingVersion: '0.9.0',
- currentVersion: '1.0.0',
- universalIdentifier: 'my-app',
- action: 'install',
- });
-
- expect(result).toMatchObject({
- allowed: false,
- reason: 'DOWNGRADE',
- });
- });
-
- it('should reject same and lower versions on deploy with the bump message', () => {
- for (const [incomingVersion, reason] of [
- ['1.0.0', 'SAME_VERSION'],
- ['0.9.0', 'DOWNGRADE'],
- ] as const) {
- const result = service.validateVersionProgression({
- incomingVersion,
- currentVersion: '1.0.0',
- universalIdentifier: 'my-app',
- action: 'deploy',
- });
-
- expect(result).toMatchObject({
- allowed: false,
- reason,
- message: `Cannot deploy my-app@${incomingVersion}: version must be higher than the currently deployed version 1.0.0. Please bump the version in package.json.`,
- });
- }
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-registration-variable/__tests__/application-registration-variable.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-registration-variable/__tests__/application-registration-variable.service.spec.ts
deleted file mode 100644
index ca263ce6640..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-registration-variable/__tests__/application-registration-variable.service.spec.ts
+++ /dev/null
@@ -1,218 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { type ServerVariables } from 'twenty-shared/application';
-import { FieldMetadataType } from 'twenty-shared/types';
-import { type Repository } from 'typeorm';
-
-import { ApplicationRegistrationVariableEntity } from 'src/engine/core-modules/application/application-registration-variable/application-registration-variable.entity';
-import { ApplicationRegistrationVariableService } from 'src/engine/core-modules/application/application-registration-variable/application-registration-variable.service';
-import { ApplicationRegistrationEntity } from 'src/engine/core-modules/application/application-registration/application-registration.entity';
-import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
-import { type EncryptedString } from 'src/engine/core-modules/secret-encryption/branded-strings/encrypted-string.type';
-import { type PlaintextString } from 'src/engine/core-modules/secret-encryption/branded-strings/plaintext-string.type';
-import { SecretEncryptionService } from 'src/engine/core-modules/secret-encryption/secret-encryption.service';
-
-describe('ApplicationRegistrationVariableService', () => {
- let service: ApplicationRegistrationVariableService;
- let variableRepository: jest.Mocked<
- Repository<ApplicationRegistrationVariableEntity>
- >;
- let applicationRegistrationRepository: jest.Mocked<
- Repository<ApplicationRegistrationEntity>
- >;
- let applicationRepository: jest.Mocked<Repository<ApplicationEntity>>;
- let encryptionService: jest.Mocked<SecretEncryptionService>;
-
- const registrationId = 'registration-1';
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplicationRegistrationVariableService,
- {
- provide: getRepositoryToken(ApplicationRegistrationVariableEntity),
- useValue: {
- find: jest.fn().mockResolvedValue([]),
- findOne: jest.fn(),
- findOneOrFail: jest.fn(),
- create: jest.fn((entity) => entity),
- save: jest.fn(),
- update: jest.fn(),
- delete: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(ApplicationRegistrationEntity),
- useValue: {
- find: jest.fn().mockResolvedValue([]),
- findOne: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(ApplicationEntity),
- useValue: { find: jest.fn().mockResolvedValue([]) },
- },
- {
- provide: SecretEncryptionService,
- useValue: {
- encryptVersioned: jest.fn(
- (value: string) => `enc:v2:deadbeef:${value}`,
- ),
- decryptVersionedOrThrow: jest.fn((value: string) =>
- value.replace(/^enc:v2:[0-9a-f]+:/, ''),
- ),
- },
- },
- ],
- }).compile();
-
- service = module.get(ApplicationRegistrationVariableService);
- variableRepository = module.get(
- getRepositoryToken(ApplicationRegistrationVariableEntity),
- );
- applicationRegistrationRepository = module.get(
- getRepositoryToken(ApplicationRegistrationEntity),
- );
- applicationRepository = module.get(getRepositoryToken(ApplicationEntity));
- encryptionService = module.get(SecretEncryptionService);
- });
-
- const makeExistingVariable = (
- overrides: Partial<ApplicationRegistrationVariableEntity>,
- ) =>
- ({
- id: 'variable-1',
- key: 'API_KEY',
- encryptedValue: 'enc:v2:deadbeef:' as EncryptedString,
- description: '',
- isSecret: true,
- isRequired: false,
- isDeprecated: false,
- type: FieldMetadataType.TEXT,
- options: null,
- applicationRegistrationId: registrationId,
- ...overrides,
- }) as ApplicationRegistrationVariableEntity;
-
- describe('syncVariableSchemas', () => {
- it('should persist isDeprecated on creation', async () => {
- const serverVariables: ServerVariables = {
- API_KEY: { isDeprecated: true },
- };
-
- await service.syncVariableSchemas(registrationId, serverVariables);
-
- expect(variableRepository.save).toHaveBeenCalledWith(
- expect.objectContaining({
- key: 'API_KEY',
- isDeprecated: true,
- encryptedValue: 'enc:v2:deadbeef:',
- }),
- );
- });
-
- it('should drop isRequired when the manifest deprecates a variable', async () => {
- variableRepository.find.mockResolvedValue([
- makeExistingVariable({ isRequired: true }),
- ]);
-
- await service.syncVariableSchemas(registrationId, {
- API_KEY: { isRequired: true, isDeprecated: true },
- });
-
- expect(variableRepository.update).toHaveBeenCalledWith(
- 'variable-1',
- expect.objectContaining({ isRequired: false, isDeprecated: true }),
- );
- });
-
- it('should un-deprecate a variable when the manifest drops the flag', async () => {
- variableRepository.find.mockResolvedValue([
- makeExistingVariable({ isDeprecated: true }),
- ]);
-
- await service.syncVariableSchemas(registrationId, { API_KEY: {} });
-
- expect(variableRepository.update).toHaveBeenCalledWith(
- 'variable-1',
- expect.objectContaining({ isDeprecated: false }),
- );
- });
- });
-
- describe('isConfiguredBatch', () => {
- const mockVariables = (
- variables: ApplicationRegistrationVariableEntity[],
- ) => {
- variableRepository.find.mockResolvedValue(variables);
- applicationRegistrationRepository.find.mockResolvedValue([
- { id: registrationId, manifest: {}, ownerWorkspaceId: null } as never,
- ]);
- applicationRepository.find.mockResolvedValue([]);
- };
-
- it('should report configured when the only unfilled variable is deprecated', async () => {
- mockVariables([
- makeExistingVariable({ isRequired: false, isDeprecated: true }),
- ]);
-
- const result = await service.isConfiguredBatch([registrationId]);
-
- expect(result.get(registrationId)).toBe(true);
- });
-
- it('should report unconfigured when a required variable decrypts to an empty string', async () => {
- mockVariables([
- makeExistingVariable({
- isRequired: true,
- encryptedValue: 'enc:v2:deadbeef:' as EncryptedString,
- }),
- ]);
-
- const result = await service.isConfiguredBatch([registrationId]);
-
- expect(result.get(registrationId)).toBe(false);
- });
-
- it('should report configured when a required variable decrypts to a real value', async () => {
- mockVariables([
- makeExistingVariable({
- isRequired: true,
- encryptedValue: 'enc:v2:deadbeef:stored-secret' as EncryptedString,
- }),
- ]);
-
- const result = await service.isConfiguredBatch([registrationId]);
-
- expect(result.get(registrationId)).toBe(true);
- });
- });
-
- describe('updateVariableGlobal', () => {
- it('should encrypt an empty value and report the variable unfilled', async () => {
- const variable = makeExistingVariable({
- encryptedValue: 'enc:v2:deadbeef:stored-secret' as EncryptedString,
- });
-
- variableRepository.findOne.mockResolvedValue(variable);
- variableRepository.findOneOrFail.mockResolvedValue(
- makeExistingVariable({
- encryptedValue: 'enc:v2:deadbeef:' as EncryptedString,
- }),
- );
-
- const result = await service.updateVariableGlobal({
- id: 'variable-1',
- update: { value: '' as PlaintextString },
- });
-
- expect(encryptionService.encryptVersioned).toHaveBeenCalledWith('');
- expect(variableRepository.update).toHaveBeenCalledWith('variable-1', {
- encryptedValue: 'enc:v2:deadbeef:',
- });
- expect(result.isFilled).toBe(false);
- expect(result.value).toBeNull();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-registration/__tests__/application-registration-asset-url.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-registration/__tests__/application-registration-asset-url.service.spec.ts
deleted file mode 100644
index 12f7d199d30..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-registration/__tests__/application-registration-asset-url.service.spec.ts
+++ /dev/null
@@ -1,162 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type Manifest } from 'twenty-shared/application';
-
-import { ApplicationRegistrationAssetUrlService } from 'src/engine/core-modules/application/application-registration/application-registration-asset-url.service';
-import { ApplicationRegistrationSourceType } from 'src/engine/core-modules/application/application-registration/enums/application-registration-source-type.enum';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-const CONFIG_VALUES: Record<string, string> = {
- SERVER_URL: 'https://api.twenty.com',
- APP_REGISTRY_CDN_URL: 'https://cdn.registry.com',
-};
-
-const baseRegistration = {
- id: 'registration-id',
- sourceType: ApplicationRegistrationSourceType.TARBALL,
- sourcePackage: null,
- latestAvailableVersion: '1.0.0',
- logo: null,
- logoFileId: null,
- galleryImages: null,
- screenshots: [],
- manifest: null,
-};
-
-describe('ApplicationRegistrationAssetUrlService', () => {
- let service: ApplicationRegistrationAssetUrlService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplicationRegistrationAssetUrlService,
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn((key: string) => CONFIG_VALUES[key]),
- },
- },
- ],
- }).compile();
-
- service = module.get(ApplicationRegistrationAssetUrlService);
- });
-
- describe('buildLogoUrl', () => {
- it('should build a server file url when a logoFileId is set', () => {
- const logoUrl = service.buildLogoUrl({
- ...baseRegistration,
- logo: 'public/logo.png',
- logoFileId: 'file-id',
- });
-
- expect(logoUrl).toBe(
- 'https://api.twenty.com/files/application-registrations/registration-id/public/logo.png',
- );
- });
-
- it('should url-encode stored asset path segments', () => {
- const logoUrl = service.buildLogoUrl({
- ...baseRegistration,
- logo: 'public/logo #1.png',
- logoFileId: 'file-id',
- });
-
- expect(logoUrl).toBe(
- 'https://api.twenty.com/files/application-registrations/registration-id/public/logo%20%231.png',
- );
- });
-
- it('should pass through absolute logo urls', () => {
- const logoUrl = service.buildLogoUrl({
- ...baseRegistration,
- logo: 'https://example.com/logo.png',
- });
-
- expect(logoUrl).toBe('https://example.com/logo.png');
- });
-
- it('should build a registry cdn url for npm registrations', () => {
- const logoUrl = service.buildLogoUrl({
- ...baseRegistration,
- sourceType: ApplicationRegistrationSourceType.NPM,
- sourcePackage: '@twenty/my-app',
- latestAvailableVersion: '2.3.4',
- logo: 'public/logo.png',
- });
-
- expect(logoUrl).toBe(
- 'https://cdn.registry.com/@twenty/[email protected]/public/logo.png',
- );
- });
-
- it('should return null for a relative path without a stored file on non-npm registrations', () => {
- const logoUrl = service.buildLogoUrl({
- ...baseRegistration,
- logo: 'public/logo.png',
- });
-
- expect(logoUrl).toBeNull();
- });
-
- it('should return null when there is no logo at all', () => {
- const logoUrl = service.buildLogoUrl(baseRegistration);
-
- expect(logoUrl).toBeNull();
- });
- });
-
- describe('buildGalleryImageUrls', () => {
- it('should resolve stored gallery images by fileId and keep absolute urls', () => {
- const urls = service.buildGalleryImageUrls({
- ...baseRegistration,
- galleryImages: [
- { path: 'public/one.png', fileId: 'file-1' },
- { path: 'https://example.com/two.png', fileId: null },
- { path: 'public/missing.png', fileId: null },
- ],
- });
-
- expect(urls).toEqual([
- 'https://api.twenty.com/files/application-registrations/registration-id/public/one.png',
- 'https://example.com/two.png',
- ]);
- });
-
- it('should resolve npm gallery images from the registry cdn', () => {
- const urls = service.buildGalleryImageUrls({
- ...baseRegistration,
- sourceType: ApplicationRegistrationSourceType.NPM,
- sourcePackage: '@twenty/my-app',
- latestAvailableVersion: '2.3.4',
- galleryImages: [{ path: 'public/one.png', fileId: null }],
- });
-
- expect(urls).toEqual([
- 'https://cdn.registry.com/@twenty/[email protected]/public/one.png',
- ]);
- });
-
- it('should fall back to the deprecated screenshots column', () => {
- const urls = service.buildGalleryImageUrls({
- ...baseRegistration,
- screenshots: ['https://example.com/screenshot.png'],
- });
-
- expect(urls).toEqual(['https://example.com/screenshot.png']);
- });
-
- it('should fall back to manifest gallery images when nothing is backfilled', () => {
- const urls = service.buildGalleryImageUrls({
- ...baseRegistration,
- manifest: {
- application: {
- galleryImages: ['https://example.com/from-manifest.png'],
- },
- } as unknown as Manifest,
- });
-
- expect(urls).toEqual(['https://example.com/from-manifest.png']);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-registration/__tests__/application-registration-claim.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-registration/__tests__/application-registration-claim.service.spec.ts
deleted file mode 100644
index f52450afd1b..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-registration/__tests__/application-registration-claim.service.spec.ts
+++ /dev/null
@@ -1,400 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import axios from 'axios';
-
-import { ApplicationRegistrationClaimService } from 'src/engine/core-modules/application/application-registration/application-registration-claim.service';
-import { type ApplicationRegistrationEntity } from 'src/engine/core-modules/application/application-registration/application-registration.entity';
-import {
- ApplicationRegistrationException,
- ApplicationRegistrationExceptionCode,
-} from 'src/engine/core-modules/application/application-registration/application-registration.exception';
-import { ApplicationRegistrationService } from 'src/engine/core-modules/application/application-registration/application-registration.service';
-import { ApplicationRegistrationSourceType } from 'src/engine/core-modules/application/application-registration/enums/application-registration-source-type.enum';
-import { type ApplicationRegistrationGithubClaimStateJwtPayload } from 'src/engine/core-modules/auth/types/application-registration-github-claim-state-jwt-payload.type';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-jest.mock('axios');
-
-const mockedAxios = axios as jest.Mocked<typeof axios>;
-
-const WORKSPACE_ID = 'workspace-1';
-const REGISTRATION_ID = 'registration-1';
-
-const CONFIG_VALUES: Record<string, string> = {
- APP_CLAIM_GITHUB_CLIENT_ID: 'github-client-id',
- APP_CLAIM_GITHUB_CLIENT_SECRET: 'github-client-secret',
- APP_REGISTRY_URL: 'https://registry.npmjs.org',
- SERVER_URL: 'https://server.example.com',
-};
-
-const buildRegistration = (
- overrides: Partial<ApplicationRegistrationEntity> = {},
-): ApplicationRegistrationEntity =>
- ({
- id: REGISTRATION_ID,
- universalIdentifier: 'universal-identifier-1',
- ownerWorkspaceId: null,
- sourceType: ApplicationRegistrationSourceType.NPM,
- sourcePackage: '@acme/my-twenty-app',
- latestAvailableVersion: '1.2.3',
- ...overrides,
- }) as ApplicationRegistrationEntity;
-
-const buildAttestationsResponse = (repository: string) => ({
- attestations: [
- {
- predicateType: 'https://slsa.dev/provenance/v1',
- bundle: {
- dsseEnvelope: {
- payload: Buffer.from(
- JSON.stringify({
- predicate: {
- buildDefinition: {
- externalParameters: { workflow: { repository } },
- },
- },
- }),
- ).toString('base64'),
- },
- },
- },
- ],
-});
-
-const STATE_PAYLOAD: ApplicationRegistrationGithubClaimStateJwtPayload = {
- sub: REGISTRATION_ID,
- type: JwtTokenTypeEnum.APPLICATION_REGISTRATION_GITHUB_CLAIM_STATE,
- applicationRegistrationId: REGISTRATION_ID,
- workspaceId: WORKSPACE_ID,
- userId: 'user-1',
-};
-
-describe('ApplicationRegistrationClaimService', () => {
- let service: ApplicationRegistrationClaimService;
- let applicationRegistrationService: jest.Mocked<ApplicationRegistrationService>;
- let jwtWrapperService: jest.Mocked<JwtWrapperService>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplicationRegistrationClaimService,
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- {
- provide: ApplicationRegistrationService,
- useValue: {
- findOneByIdGlobal: jest.fn(),
- claimOwnership: jest.fn(),
- },
- },
- {
- provide: JwtWrapperService,
- useValue: {
- signAsyncOrThrow: jest.fn().mockResolvedValue('signed-state'),
- verifyJwtToken: jest.fn(),
- decode: jest.fn().mockReturnValue(STATE_PAYLOAD),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn((key: string) => CONFIG_VALUES[key]),
- },
- },
- ],
- }).compile();
-
- service = module.get(ApplicationRegistrationClaimService);
- applicationRegistrationService = module.get(ApplicationRegistrationService);
- jwtWrapperService = module.get(JwtWrapperService);
- mockedAxios.isAxiosError.mockReturnValue(false);
- });
-
- afterEach(() => jest.clearAllMocks());
-
- const expectException = async (
- promise: Promise<unknown>,
- code: ApplicationRegistrationExceptionCode,
- ) => {
- await expect(promise).rejects.toThrow(ApplicationRegistrationException);
- await promise.catch((error) => expect(error.code).toBe(code));
- };
-
- describe('buildGithubAuthorizationUrl', () => {
- it('rejects an already-owned registration', async () => {
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration({ ownerWorkspaceId: 'other-workspace' }),
- );
-
- await expectException(
- service.buildGithubAuthorizationUrl({
- applicationRegistrationId: REGISTRATION_ID,
- workspaceId: WORKSPACE_ID,
- userId: null,
- }),
- ApplicationRegistrationExceptionCode.APPLICATION_REGISTRATION_ALREADY_OWNED,
- );
- });
-
- it('rejects a non-npm registration', async () => {
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration({
- sourceType: ApplicationRegistrationSourceType.LOCAL,
- sourcePackage: null,
- }),
- );
-
- await expectException(
- service.buildGithubAuthorizationUrl({
- applicationRegistrationId: REGISTRATION_ID,
- workspaceId: WORKSPACE_ID,
- userId: null,
- }),
- ApplicationRegistrationExceptionCode.CLAIM_NOT_SUPPORTED,
- );
- });
-
- it('throws when the GitHub OAuth app is not configured', async () => {
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration(),
- );
- const configService = { APP_CLAIM_GITHUB_CLIENT_ID: '' };
-
- (
- service as unknown as {
- twentyConfigService: { get: jest.Mock };
- }
- ).twentyConfigService.get = jest.fn(
- (key: string) =>
- ({ ...CONFIG_VALUES, ...configService })[key] as string,
- );
-
- await expectException(
- service.buildGithubAuthorizationUrl({
- applicationRegistrationId: REGISTRATION_ID,
- workspaceId: WORKSPACE_ID,
- userId: null,
- }),
- ApplicationRegistrationExceptionCode.CLAIM_NOT_CONFIGURED,
- );
- });
-
- it('returns the GitHub authorization url with a signed state', async () => {
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration(),
- );
-
- const url = new URL(
- await service.buildGithubAuthorizationUrl({
- applicationRegistrationId: REGISTRATION_ID,
- workspaceId: WORKSPACE_ID,
- userId: 'user-1',
- }),
- );
-
- expect(url.origin + url.pathname).toBe(
- 'https://github.com/login/oauth/authorize',
- );
- expect(url.searchParams.get('client_id')).toBe('github-client-id');
- expect(url.searchParams.get('scope')).toBe('read:org');
- expect(url.searchParams.get('state')).toBe('signed-state');
- expect(url.searchParams.get('prompt')).toBe('select_account');
- expect(url.searchParams.get('redirect_uri')).toBe(
- 'https://server.example.com/application-registration-claim/github/callback',
- );
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- STATE_PAYLOAD,
- expect.objectContaining({ expiresIn: '15m' }),
- );
- });
- });
-
- describe('completeGithubClaim', () => {
- it('throws when no provenance attestation exists', async () => {
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration(),
- );
- const notFoundError = Object.assign(new Error('Request failed'), {
- response: { status: 404 },
- });
-
- mockedAxios.get.mockRejectedValueOnce(notFoundError);
- mockedAxios.isAxiosError.mockReturnValue(true);
-
- await expectException(
- service.completeGithubClaim({
- statePayload: STATE_PAYLOAD,
- code: 'oauth-code',
- }),
- ApplicationRegistrationExceptionCode.PROVENANCE_NOT_FOUND,
- );
- });
-
- it('reports a registry outage without blaming the provenance', async () => {
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration(),
- );
- mockedAxios.get.mockRejectedValueOnce(new Error('ETIMEDOUT'));
-
- await expectException(
- service.completeGithubClaim({
- statePayload: STATE_PAYLOAD,
- code: 'oauth-code',
- }),
- ApplicationRegistrationExceptionCode.PROVENANCE_CHECK_UNAVAILABLE,
- );
- });
-
- it('claims when the connected user is the publishing account', async () => {
- const claimed = buildRegistration({ ownerWorkspaceId: WORKSPACE_ID });
-
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration(),
- );
- applicationRegistrationService.claimOwnership.mockResolvedValue(claimed);
- mockedAxios.get.mockImplementation(async (url: string) => {
- if (url.includes('/attestations/')) {
- return {
- data: buildAttestationsResponse('https://github.com/acme/my-app'),
- };
- }
- if (url.endsWith('/user')) {
- return { data: { login: 'Acme' } };
- }
- throw new Error(`Unexpected GET ${url}`);
- });
- mockedAxios.post.mockResolvedValue({
- data: { access_token: 'github-token' },
- });
-
- const result = await service.completeGithubClaim({
- statePayload: STATE_PAYLOAD,
- code: 'oauth-code',
- });
-
- expect(
- applicationRegistrationService.claimOwnership,
- ).toHaveBeenCalledWith({
- applicationRegistrationId: REGISTRATION_ID,
- claimingWorkspaceId: WORKSPACE_ID,
- });
- expect(result).toBe(claimed);
- });
-
- it('claims when the connected user owns the publishing organization', async () => {
- const claimed = buildRegistration({ ownerWorkspaceId: WORKSPACE_ID });
-
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration(),
- );
- applicationRegistrationService.claimOwnership.mockResolvedValue(claimed);
- mockedAxios.get.mockImplementation(async (url: string) => {
- if (url.includes('/attestations/')) {
- return {
- data: buildAttestationsResponse('https://github.com/acme/my-app'),
- };
- }
- if (url.endsWith('/user')) {
- return { data: { login: 'someone-else' } };
- }
- if (url.includes('/user/memberships/orgs/acme')) {
- return { data: { state: 'active', role: 'admin' } };
- }
- throw new Error(`Unexpected GET ${url}`);
- });
- mockedAxios.post.mockResolvedValue({
- data: { access_token: 'github-token' },
- });
-
- const result = await service.completeGithubClaim({
- statePayload: STATE_PAYLOAD,
- code: 'oauth-code',
- });
-
- expect(result).toBe(claimed);
- });
-
- it('rejects a member who is not an owner of the publishing organization', async () => {
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration(),
- );
- mockedAxios.get.mockImplementation(async (url: string) => {
- if (url.includes('/attestations/')) {
- return {
- data: buildAttestationsResponse('https://github.com/acme/my-app'),
- };
- }
- if (url.endsWith('/user')) {
- return { data: { login: 'someone-else' } };
- }
- if (url.includes('/user/memberships/orgs/acme')) {
- return { data: { state: 'active', role: 'member' } };
- }
- throw new Error(`Unexpected GET ${url}`);
- });
- mockedAxios.post.mockResolvedValue({
- data: { access_token: 'github-token' },
- });
-
- await expectException(
- service.completeGithubClaim({
- statePayload: STATE_PAYLOAD,
- code: 'oauth-code',
- }),
- ApplicationRegistrationExceptionCode.GITHUB_ORG_OWNERSHIP_REQUIRED,
- );
- expect(
- applicationRegistrationService.claimOwnership,
- ).not.toHaveBeenCalled();
- });
-
- it('fails when the GitHub code exchange fails', async () => {
- applicationRegistrationService.findOneByIdGlobal.mockResolvedValue(
- buildRegistration(),
- );
- mockedAxios.get.mockResolvedValue({
- data: buildAttestationsResponse('https://github.com/acme/my-app'),
- });
- mockedAxios.post.mockRejectedValue(new Error('bad code'));
-
- await expectException(
- service.completeGithubClaim({
- statePayload: STATE_PAYLOAD,
- code: 'oauth-code',
- }),
- ApplicationRegistrationExceptionCode.GITHUB_AUTH_FAILED,
- );
- });
- });
-
- describe('verifyClaimState', () => {
- it('rejects a state token of the wrong type', async () => {
- jwtWrapperService.decode.mockReturnValue({
- ...STATE_PAYLOAD,
- type: 'SOMETHING_ELSE',
- } as never);
-
- await expectException(
- service.verifyClaimState('state-token'),
- ApplicationRegistrationExceptionCode.GITHUB_AUTH_FAILED,
- );
- });
-
- it('returns the payload of a valid state token', async () => {
- const payload = await service.verifyClaimState('state-token');
-
- expect(payload).toEqual(STATE_PAYLOAD);
- expect(jwtWrapperService.verifyJwtToken).toHaveBeenCalledWith(
- 'state-token',
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-stop/__tests__/application-stop.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-stop/__tests__/application-stop.service.spec.ts
deleted file mode 100644
index cece36daa24..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-stop/__tests__/application-stop.service.spec.ts
+++ /dev/null
@@ -1,140 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import {
- APPLICATION_KILL_SWITCH_LOCAL_CACHE_TTL_MS,
- ApplicationStopService,
-} from 'src/engine/core-modules/application/application-stop/application-stop.service';
-import { CacheStorageNamespace } from 'src/engine/core-modules/cache-storage/types/cache-storage-namespace.enum';
-
-const APPLICATION_UNIVERSAL_IDENTIFIER = 'application-universal-identifier-1';
-const KILL_SWITCH_KEY = `kill-switch:${APPLICATION_UNIVERSAL_IDENTIFIER}`;
-
-describe('ApplicationStopService', () => {
- let applicationStopService: ApplicationStopService;
-
- const cacheStorageService = {
- get: jest.fn(),
- set: jest.fn(),
- del: jest.fn(),
- };
-
- beforeEach(async () => {
- jest.resetAllMocks();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplicationStopService,
- {
- provide: CacheStorageNamespace.ModuleApplications,
- useValue: cacheStorageService,
- },
- ],
- }).compile();
-
- applicationStopService = module.get(ApplicationStopService);
- });
-
- afterEach(() => {
- jest.restoreAllMocks();
- });
-
- it('sets the kill switch when stopping an application', async () => {
- await applicationStopService.stop(APPLICATION_UNIVERSAL_IDENTIFIER);
-
- expect(cacheStorageService.set).toHaveBeenCalledWith(
- KILL_SWITCH_KEY,
- 'stopped',
- );
- });
-
- it('deletes the kill switch when removing it', async () => {
- await applicationStopService.remove(APPLICATION_UNIVERSAL_IDENTIFIER);
-
- expect(cacheStorageService.del).toHaveBeenCalledWith(KILL_SWITCH_KEY);
- });
-
- it('returns true when the kill switch exists', async () => {
- cacheStorageService.get.mockResolvedValue('stopped');
-
- await expect(
- applicationStopService.isApplicationStopped(
- APPLICATION_UNIVERSAL_IDENTIFIER,
- ),
- ).resolves.toBe(true);
- expect(cacheStorageService.get).toHaveBeenCalledWith(KILL_SWITCH_KEY);
- });
-
- it('returns false when the kill switch is absent', async () => {
- cacheStorageService.get.mockResolvedValue(undefined);
-
- await expect(
- applicationStopService.isApplicationStopped(
- APPLICATION_UNIVERSAL_IDENTIFIER,
- ),
- ).resolves.toBe(false);
- });
-
- it('caches the Redis value for one minute', async () => {
- const dateNow = jest.spyOn(Date, 'now').mockReturnValue(1_000);
-
- cacheStorageService.get
- .mockResolvedValueOnce(undefined)
- .mockResolvedValueOnce('stopped');
-
- await expect(
- applicationStopService.isApplicationStopped(
- APPLICATION_UNIVERSAL_IDENTIFIER,
- ),
- ).resolves.toBe(false);
-
- dateNow.mockReturnValue(
- 1_000 + APPLICATION_KILL_SWITCH_LOCAL_CACHE_TTL_MS - 1,
- );
-
- await expect(
- applicationStopService.isApplicationStopped(
- APPLICATION_UNIVERSAL_IDENTIFIER,
- ),
- ).resolves.toBe(false);
- expect(cacheStorageService.get).toHaveBeenCalledTimes(1);
-
- dateNow.mockReturnValue(1_000 + APPLICATION_KILL_SWITCH_LOCAL_CACHE_TTL_MS);
-
- await expect(
- applicationStopService.isApplicationStopped(
- APPLICATION_UNIVERSAL_IDENTIFIER,
- ),
- ).resolves.toBe(true);
- expect(cacheStorageService.get).toHaveBeenCalledTimes(2);
- });
-
- it('deduplicates concurrent Redis reads', async () => {
- cacheStorageService.get.mockResolvedValue(undefined);
-
- await Promise.all(
- Array.from({ length: 10 }, () =>
- applicationStopService.isApplicationStopped(
- APPLICATION_UNIVERSAL_IDENTIFIER,
- ),
- ),
- );
-
- expect(cacheStorageService.get).toHaveBeenCalledTimes(1);
- });
-
- it('fails open when the cache cannot be read', async () => {
- cacheStorageService.get.mockRejectedValue(new Error('Redis unavailable'));
-
- await expect(
- Promise.all([
- applicationStopService.isApplicationStopped(
- APPLICATION_UNIVERSAL_IDENTIFIER,
- ),
- applicationStopService.isApplicationStopped(
- APPLICATION_UNIVERSAL_IDENTIFIER,
- ),
- ]),
- ).resolves.toEqual([false, false]);
- expect(cacheStorageService.get).toHaveBeenCalledTimes(1);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/application-variable/__tests__/application-variable.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-variable/__tests__/application-variable.service.spec.ts
deleted file mode 100644
index ff136f45e53..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/application-variable/__tests__/application-variable.service.spec.ts
+++ /dev/null
@@ -1,481 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { type Repository } from 'typeorm';
-
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { ApplicationVariableEntity } from 'src/engine/core-modules/application/application-variable/application-variable.entity';
-import {
- ApplicationVariableEntityException,
- ApplicationVariableEntityExceptionCode,
-} from 'src/engine/core-modules/application/application-variable/application-variable.exception';
-import { ApplicationVariableEntityService } from 'src/engine/core-modules/application/application-variable/application-variable.service';
-import { SECRET_APPLICATION_VARIABLE_MASK } from 'src/engine/core-modules/application/application-variable/constants/secret-application-variable-mask.constant';
-import { type ApplicationVariableCacheMaps } from 'src/engine/core-modules/application/application-variable/types/application-variable-cache-maps.type';
-import { type EncryptedString } from 'src/engine/core-modules/secret-encryption/branded-strings/encrypted-string.type';
-import { type PlaintextString } from 'src/engine/core-modules/secret-encryption/branded-strings/plaintext-string.type';
-import { SecretEncryptionService } from 'src/engine/core-modules/secret-encryption/secret-encryption.service';
-import { type FlatApplicationVariable } from 'src/engine/metadata-modules/flat-application-variable/types/flat-application-variable.type';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-describe('ApplicationVariableEntityService', () => {
- let service: ApplicationVariableEntityService;
- let repository: jest.Mocked<Repository<ApplicationVariableEntity>>;
- let secretEncryptionService: jest.Mocked<SecretEncryptionService>;
- let workspaceCacheService: jest.Mocked<WorkspaceCacheService>;
-
- const mockWorkspaceId = 'workspace-123';
- const mockApplicationId = 'app-456';
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplicationVariableEntityService,
- {
- provide: getRepositoryToken(ApplicationVariableEntity),
- useValue: {
- find: jest.fn(),
- findOne: jest.fn(),
- update: jest.fn(),
- save: jest.fn(),
- delete: jest.fn(),
- },
- },
- {
- provide: SecretEncryptionService,
- useValue: {
- encryptVersioned: jest.fn(
- (value: string, opts?: { workspaceId?: string }) =>
- `enc:v2:deadbeef:${value}|${opts?.workspaceId ?? 'instance'}`,
- ),
- decryptVersionedOrThrow: jest.fn(
- (value: string, _opts?: { workspaceId?: string }) =>
- value.replace(/^enc:v2:[0-9a-f]+:/, '').replace(/\|.*$/, ''),
- ),
- maskDecryptedValue: jest.fn(
- (_decryptedValue: string, _mask: string) => '********',
- ),
- },
- },
- {
- provide: WorkspaceCacheService,
- useValue: {
- invalidateAndRecompute: jest.fn(),
- getOrRecompute: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<ApplicationVariableEntityService>(
- ApplicationVariableEntityService,
- );
- repository = module.get(getRepositoryToken(ApplicationVariableEntity));
- secretEncryptionService = module.get(SecretEncryptionService);
- workspaceCacheService = module.get(WorkspaceCacheService);
- });
-
- const workspaceA = 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa';
- const workspaceB = 'bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb';
-
- const makeFlatVariable = (
- overrides: Partial<FlatApplicationVariable>,
- ): FlatApplicationVariable =>
- ({
- id: '1',
- key: 'KEY',
- value: 'enc:v2:deadbeef:|instance' as EncryptedString,
- description: '',
- isSecret: false,
- type: FieldMetadataType.TEXT,
- options: null,
- applicationId: mockApplicationId,
- workspaceId: workspaceA,
- universalIdentifier: '00000000-0000-0000-0000-000000000000',
- applicationUniversalIdentifier: '00000000-0000-0000-0000-000000000000',
- createdAt: '2024-01-01T00:00:00.000Z',
- updatedAt: '2024-01-01T00:00:00.000Z',
- ...overrides,
- }) as FlatApplicationVariable;
-
- const makeApplicationVariableMaps = (
- flatApplicationVariables: FlatApplicationVariable[],
- ) =>
- ({
- byUniversalIdentifier: Object.fromEntries(
- flatApplicationVariables.map((flatApplicationVariable) => [
- flatApplicationVariable.universalIdentifier,
- flatApplicationVariable,
- ]),
- ),
- universalIdentifiersByApplicationId: {
- [mockApplicationId]: flatApplicationVariables.map(
- ({ universalIdentifier }) => universalIdentifier,
- ),
- },
- }) as unknown as ApplicationVariableCacheMaps;
-
- const mockCachedApplicationVariables = (
- flatApplicationVariables: FlatApplicationVariable[],
- ) => {
- workspaceCacheService.getOrRecompute.mockResolvedValue({
- applicationVariableMaps: makeApplicationVariableMaps(
- flatApplicationVariables,
- ),
- } as never);
- };
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('getServerEnvVariables', () => {
- it('should return an empty object when the application has no variable', async () => {
- mockCachedApplicationVariables([]);
-
- await expect(
- service.getServerEnvVariables({
- workspaceId: workspaceA,
- applicationId: mockApplicationId,
- }),
- ).resolves.toEqual({});
- });
-
- it('should decrypt all encrypted variables regardless of isSecret', async () => {
- mockCachedApplicationVariables([
- makeFlatVariable({
- universalIdentifier: 'variable-1',
- key: 'PUBLIC_URL',
- value:
- `enc:v2:deadbeef:https://example.com|${workspaceA}` as EncryptedString,
- }),
- makeFlatVariable({
- universalIdentifier: 'variable-2',
- key: 'API_SECRET',
- value: `enc:v2:deadbeef:secret-123|${workspaceA}` as EncryptedString,
- isSecret: true,
- }),
- ]);
-
- const result = await service.getServerEnvVariables({
- workspaceId: workspaceA,
- applicationId: mockApplicationId,
- });
-
- expect(result).toEqual({
- PUBLIC_URL: 'https://example.com',
- API_SECRET: 'secret-123',
- });
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledTimes(2);
- });
-
- it('should still inject a deprecated variable so apps can fall back to it', async () => {
- mockCachedApplicationVariables([
- makeFlatVariable({
- universalIdentifier: 'variable-1',
- key: 'API_KEY',
- value: `enc:v2:deadbeef:legacy-key|${workspaceA}` as EncryptedString,
- isSecret: true,
- isDeprecated: true,
- }),
- makeFlatVariable({
- universalIdentifier: 'variable-2',
- key: 'NEW_API_KEY',
- value: `enc:v2:deadbeef:new-key|${workspaceA}` as EncryptedString,
- isSecret: true,
- }),
- ]);
-
- const result = await service.getServerEnvVariables({
- workspaceId: workspaceA,
- applicationId: mockApplicationId,
- });
-
- expect(result).toEqual({
- API_KEY: 'legacy-key',
- NEW_API_KEY: 'new-key',
- });
- });
-
- it('should route each variable to its own workspace HKDF context', async () => {
- mockCachedApplicationVariables([
- makeFlatVariable({
- universalIdentifier: 'variable-1',
- key: 'A_SECRET',
- value: `enc:v2:deadbeef:value-a|${workspaceA}` as EncryptedString,
- isSecret: true,
- }),
- makeFlatVariable({
- universalIdentifier: 'variable-2',
- key: 'B_SECRET',
- value: `enc:v2:deadbeef:value-b|${workspaceB}` as EncryptedString,
- isSecret: true,
- workspaceId: workspaceB,
- }),
- ]);
-
- await service.getServerEnvVariables({
- workspaceId: workspaceA,
- applicationId: mockApplicationId,
- });
-
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledWith(`enc:v2:deadbeef:value-a|${workspaceA}`, {
- workspaceId: workspaceA,
- });
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledWith(`enc:v2:deadbeef:value-b|${workspaceB}`, {
- workspaceId: workspaceB,
- });
- });
-
- it('should decrypt uninitialised variables to an empty string', async () => {
- mockCachedApplicationVariables([
- makeFlatVariable({
- universalIdentifier: 'variable-1',
- key: 'EMPTY_VALUE',
- value: `enc:v2:deadbeef:|${workspaceA}` as EncryptedString,
- }),
- ]);
-
- const result = await service.getServerEnvVariables({
- workspaceId: workspaceA,
- applicationId: mockApplicationId,
- });
-
- expect(result).toEqual({ EMPTY_VALUE: '' });
- });
-
- it('should reuse provided application variable maps instead of reading the cache', async () => {
- const applicationVariableMaps = makeApplicationVariableMaps([
- makeFlatVariable({
- universalIdentifier: 'variable-1',
- key: 'PUBLIC_URL',
- value:
- `enc:v2:deadbeef:https://example.com|${workspaceA}` as EncryptedString,
- }),
- ]);
-
- const result = await service.getServerEnvVariables({
- workspaceId: workspaceA,
- applicationId: mockApplicationId,
- applicationVariableMaps,
- });
-
- expect(result).toEqual({ PUBLIC_URL: 'https://example.com' });
- expect(workspaceCacheService.getOrRecompute).not.toHaveBeenCalled();
- });
- });
-
- describe('getPublicEnvVariables', () => {
- it('should exclude secret variables without decrypting them', async () => {
- mockCachedApplicationVariables([
- makeFlatVariable({
- universalIdentifier: 'variable-1',
- key: 'PUBLIC_URL',
- value:
- `enc:v2:deadbeef:https://example.com|${workspaceA}` as EncryptedString,
- }),
- makeFlatVariable({
- universalIdentifier: 'variable-2',
- key: 'API_SECRET',
- value: `enc:v2:deadbeef:secret-123|${workspaceA}` as EncryptedString,
- isSecret: true,
- }),
- ]);
-
- const result = await service.getPublicEnvVariables({
- workspaceId: workspaceA,
- applicationId: mockApplicationId,
- });
-
- expect(result).toEqual({ PUBLIC_URL: 'https://example.com' });
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledTimes(1);
- });
- });
-
- describe('update', () => {
- it('should encrypt value with workspaceId-scoped envelope when variable is secret', async () => {
- const existingVariable = {
- id: '1',
- key: 'API_KEY',
- value: 'old-encrypted-value',
- isSecret: true,
- applicationId: mockApplicationId,
- } as ApplicationVariableEntity;
-
- repository.findOne.mockResolvedValue(existingVariable);
- repository.update.mockResolvedValue({ affected: 1 } as any);
-
- await service.update({
- key: 'API_KEY',
- plainTextValue: 'new-secret-value' as PlaintextString,
- applicationId: mockApplicationId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(secretEncryptionService.encryptVersioned).toHaveBeenCalledWith(
- 'new-secret-value',
- { workspaceId: mockWorkspaceId },
- );
- expect(repository.update).toHaveBeenCalledWith(
- { key: 'API_KEY', applicationId: mockApplicationId },
- { value: `enc:v2:deadbeef:new-secret-value|${mockWorkspaceId}` },
- );
- expect(workspaceCacheService.invalidateAndRecompute).toHaveBeenCalledWith(
- mockWorkspaceId,
- ['applicationVariableMaps'],
- );
- });
-
- it('should encrypt value even when variable is not secret', async () => {
- const existingVariable = {
- id: '1',
- key: 'PUBLIC_URL',
- value: 'https://old-url.com',
- isSecret: false,
- applicationId: mockApplicationId,
- } as ApplicationVariableEntity;
-
- repository.findOne.mockResolvedValue(existingVariable);
- repository.update.mockResolvedValue({ affected: 1 } as any);
-
- await service.update({
- key: 'PUBLIC_URL',
- plainTextValue: 'https://new-url.com' as PlaintextString,
- applicationId: mockApplicationId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(secretEncryptionService.encryptVersioned).toHaveBeenCalledWith(
- 'https://new-url.com',
- { workspaceId: mockWorkspaceId },
- );
- expect(repository.update).toHaveBeenCalledWith(
- { key: 'PUBLIC_URL', applicationId: mockApplicationId },
- { value: `enc:v2:deadbeef:https://new-url.com|${mockWorkspaceId}` },
- );
- });
-
- it('should encrypt an empty value like any other value', async () => {
- const existingVariable = {
- id: '1',
- key: 'API_KEY',
- value: 'old-encrypted-value',
- isSecret: true,
- applicationId: mockApplicationId,
- } as ApplicationVariableEntity;
-
- repository.findOne.mockResolvedValue(existingVariable);
- repository.update.mockResolvedValue({ affected: 1 } as any);
-
- await service.update({
- key: 'API_KEY',
- plainTextValue: '' as PlaintextString,
- applicationId: mockApplicationId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(secretEncryptionService.encryptVersioned).toHaveBeenCalledWith(
- '',
- { workspaceId: mockWorkspaceId },
- );
- expect(repository.update).toHaveBeenCalledWith(
- { key: 'API_KEY', applicationId: mockApplicationId },
- { value: `enc:v2:deadbeef:|${mockWorkspaceId}` },
- );
- });
-
- it('should throw exception when variable not found', async () => {
- repository.findOne.mockResolvedValue(null);
-
- await expect(
- service.update({
- key: 'NON_EXISTENT',
- plainTextValue: 'some-value' as PlaintextString,
- applicationId: mockApplicationId,
- workspaceId: mockWorkspaceId,
- }),
- ).rejects.toThrow(ApplicationVariableEntityException);
-
- await expect(
- service.update({
- key: 'NON_EXISTENT',
- plainTextValue: 'some-value' as PlaintextString,
- applicationId: mockApplicationId,
- workspaceId: mockWorkspaceId,
- }),
- ).rejects.toMatchObject({
- code: ApplicationVariableEntityExceptionCode.APPLICATION_VARIABLE_NOT_FOUND,
- });
- });
- });
-
- describe('getDisplayValue', () => {
- it('should return plain value for non-secret variables', () => {
- const variable = {
- id: '1',
- key: 'PUBLIC_URL',
- value: 'https://example.com',
- isSecret: false,
- applicationId: mockApplicationId,
- workspaceId: mockWorkspaceId,
- } as ApplicationVariableEntity;
-
- const result = service.getDisplayValue(variable);
-
- expect(result).toBe('https://example.com');
- expect(secretEncryptionService.maskDecryptedValue).not.toHaveBeenCalled();
- });
-
- it('should decrypt once with the row workspaceId and mask the plaintext for secret variables', () => {
- const variable = {
- id: '1',
- key: 'SECRET_KEY',
- value: 'enc:v2:deadbeef:secret|workspace-123',
- isSecret: true,
- applicationId: mockApplicationId,
- workspaceId: mockWorkspaceId,
- } as ApplicationVariableEntity;
-
- const result = service.getDisplayValue(variable);
-
- expect(result).toBe('********');
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledTimes(1);
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledWith('enc:v2:deadbeef:secret|workspace-123', {
- workspaceId: mockWorkspaceId,
- });
- expect(secretEncryptionService.maskDecryptedValue).toHaveBeenCalledWith(
- 'secret',
- SECRET_APPLICATION_VARIABLE_MASK,
- );
- });
-
- it('should return an empty string when a secret variable decrypts to an empty string', () => {
- const variable = {
- id: '1',
- key: 'SECRET_KEY',
- value: `enc:v2:deadbeef:|${mockWorkspaceId}`,
- isSecret: true,
- applicationId: mockApplicationId,
- workspaceId: mockWorkspaceId,
- } as ApplicationVariableEntity;
-
- const result = service.getDisplayValue(variable);
-
- expect(result).toBe('');
- expect(secretEncryptionService.maskDecryptedValue).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/connection-provider/__tests__/connection-provider-lifecycle-hook.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/connection-provider/__tests__/connection-provider-lifecycle-hook.service.spec.ts
deleted file mode 100644
index c54a43e74fc..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/connection-provider/__tests__/connection-provider-lifecycle-hook.service.spec.ts
+++ /dev/null
@@ -1,219 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ConnectionProviderLifecycleHookService } from 'src/engine/core-modules/application/connection-provider/connection-provider-lifecycle-hook.service';
-import { type ConnectionProviderEntity } from 'src/engine/core-modules/application/connection-provider/connection-provider.entity';
-import { ConnectionProviderService } from 'src/engine/core-modules/application/connection-provider/connection-provider.service';
-import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-const ON_CONNECT_UID = 'c1c1c1c1-c1c1-4c1c-c1c1-c1c1c1c1c1c1';
-const ON_DISCONNECT_UID = 'd2d2d2d2-d2d2-4d2d-d2d2-d2d2d2d2d2d2';
-
-describe('ConnectionProviderLifecycleHookService', () => {
- let service: ConnectionProviderLifecycleHookService;
- let connectionProviderService: { findOneByIdOrThrow: jest.Mock };
- let workspaceCacheService: { getOrRecompute: jest.Mock };
- let messageQueueService: { add: jest.Mock };
- let exceptionHandlerService: { captureExceptions: jest.Mock };
-
- const baseProvider: Pick<
- ConnectionProviderEntity,
- | 'id'
- | 'name'
- | 'onConnectLogicFunctionUniversalIdentifier'
- | 'onDisconnectLogicFunctionUniversalIdentifier'
- > = {
- id: 'provider-1',
- name: 'linear',
- onConnectLogicFunctionUniversalIdentifier: null,
- onDisconnectLogicFunctionUniversalIdentifier: null,
- };
-
- beforeEach(async () => {
- connectionProviderService = {
- findOneByIdOrThrow: jest.fn(async () => baseProvider),
- };
- workspaceCacheService = {
- getOrRecompute: jest.fn(async () => ({
- flatLogicFunctionMaps: { byUniversalIdentifier: {} },
- })),
- };
- messageQueueService = { add: jest.fn() };
- exceptionHandlerService = { captureExceptions: jest.fn() };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ConnectionProviderLifecycleHookService,
- {
- provide: ConnectionProviderService,
- useValue: connectionProviderService,
- },
- { provide: WorkspaceCacheService, useValue: workspaceCacheService },
- {
- provide: getQueueToken(MessageQueue.logicFunctionQueue),
- useValue: messageQueueService,
- },
- { provide: ExceptionHandlerService, useValue: exceptionHandlerService },
- ],
- }).compile();
-
- service = module.get(ConnectionProviderLifecycleHookService);
- });
-
- afterEach(() => jest.clearAllMocks());
-
- describe('dispatchOnConnect', () => {
- it('does not dispatch a hook when the provider declares none', async () => {
- await service.dispatchOnConnect({
- provider: baseProvider,
- workspaceId: 'workspace-1',
- connectedAccountId: 'account-1',
- });
-
- expect(workspaceCacheService.getOrRecompute).not.toHaveBeenCalled();
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('enqueues the declared on-connect logic function in the connecting workspace', async () => {
- workspaceCacheService.getOrRecompute.mockResolvedValue({
- flatLogicFunctionMaps: {
- byUniversalIdentifier: { [ON_CONNECT_UID]: { id: 'function-1' } },
- },
- });
-
- await service.dispatchOnConnect({
- provider: {
- ...baseProvider,
- onConnectLogicFunctionUniversalIdentifier: ON_CONNECT_UID,
- },
- workspaceId: 'workspace-1',
- connectedAccountId: 'account-1',
- });
-
- expect(workspaceCacheService.getOrRecompute).toHaveBeenCalledWith(
- 'workspace-1',
- ['flatLogicFunctionMaps'],
- );
- expect(messageQueueService.add).toHaveBeenCalledWith(
- 'LogicFunctionTriggerJob',
- {
- logicFunctionId: 'function-1',
- workspaceId: 'workspace-1',
- payload: {
- connectionProviderId: 'provider-1',
- connectionProviderName: 'linear',
- connectedAccountId: 'account-1',
- },
- },
- { retryLimit: 3 },
- );
- });
-
- it('reports to Sentry without throwing when the hook function is missing', async () => {
- await service.dispatchOnConnect({
- provider: {
- ...baseProvider,
- onConnectLogicFunctionUniversalIdentifier: ON_CONNECT_UID,
- },
- workspaceId: 'workspace-1',
- connectedAccountId: 'account-1',
- });
-
- expect(messageQueueService.add).not.toHaveBeenCalled();
- expect(exceptionHandlerService.captureExceptions).toHaveBeenCalledTimes(
- 1,
- );
- });
-
- it('treats a soft-deleted hook function as missing instead of enqueuing it', async () => {
- workspaceCacheService.getOrRecompute.mockResolvedValue({
- flatLogicFunctionMaps: {
- byUniversalIdentifier: {
- [ON_CONNECT_UID]: {
- id: 'function-1',
- deletedAt: new Date().toISOString(),
- },
- },
- },
- });
-
- await service.dispatchOnConnect({
- provider: {
- ...baseProvider,
- onConnectLogicFunctionUniversalIdentifier: ON_CONNECT_UID,
- },
- workspaceId: 'workspace-1',
- connectedAccountId: 'account-1',
- });
-
- expect(messageQueueService.add).not.toHaveBeenCalled();
- expect(exceptionHandlerService.captureExceptions).toHaveBeenCalledTimes(
- 1,
- );
- });
- });
-
- describe('dispatchOnDisconnect', () => {
- it('does not dispatch a hook when the provider declares none', async () => {
- await service.dispatchOnDisconnect({
- connectionProviderId: 'provider-1',
- workspaceId: 'workspace-1',
- connectedAccountId: 'account-1',
- });
-
- expect(messageQueueService.add).not.toHaveBeenCalled();
- expect(exceptionHandlerService.captureExceptions).not.toHaveBeenCalled();
- });
-
- it('enqueues the declared on-disconnect logic function in the disconnecting workspace', async () => {
- connectionProviderService.findOneByIdOrThrow.mockResolvedValue({
- ...baseProvider,
- onDisconnectLogicFunctionUniversalIdentifier: ON_DISCONNECT_UID,
- });
- workspaceCacheService.getOrRecompute.mockResolvedValue({
- flatLogicFunctionMaps: {
- byUniversalIdentifier: { [ON_DISCONNECT_UID]: { id: 'function-2' } },
- },
- });
-
- await service.dispatchOnDisconnect({
- connectionProviderId: 'provider-1',
- workspaceId: 'workspace-1',
- connectedAccountId: 'account-1',
- });
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- 'LogicFunctionTriggerJob',
- {
- logicFunctionId: 'function-2',
- workspaceId: 'workspace-1',
- payload: {
- connectionProviderId: 'provider-1',
- connectionProviderName: 'linear',
- connectedAccountId: 'account-1',
- },
- },
- { retryLimit: 3 },
- );
- });
-
- it('reports to Sentry without throwing when the provider no longer exists', async () => {
- connectionProviderService.findOneByIdOrThrow.mockRejectedValue(
- new Error('Provider not found'),
- );
-
- await service.dispatchOnDisconnect({
- connectionProviderId: 'provider-1',
- workspaceId: 'workspace-1',
- connectedAccountId: 'account-1',
- });
-
- expect(messageQueueService.add).not.toHaveBeenCalled();
- expect(exceptionHandlerService.captureExceptions).toHaveBeenCalledTimes(
- 1,
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/connection-provider/__tests__/connection-provider-oauth-flow.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/connection-provider/__tests__/connection-provider-oauth-flow.service.spec.ts
deleted file mode 100644
index 307cd510585..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/connection-provider/__tests__/connection-provider-oauth-flow.service.spec.ts
+++ /dev/null
@@ -1,465 +0,0 @@
-// SecureHttpClientService transitively depends on `@lifeomic/axios-fetch`,
-// which is an optional native-binding dep that's flaky in some test envs.
-// We never use the real implementation here (the test always injects a
-// mock via `useValue`), so stub the module to avoid loading the dep at all.
-jest.mock(
- 'src/engine/core-modules/secure-http-client/secure-http-client.service',
- () => ({
- SecureHttpClientService: class {},
- }),
-);
-
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-import { isDefined } from 'twenty-shared/utils';
-
-import { type ConnectionProviderEntity } from 'src/engine/core-modules/application/connection-provider/connection-provider.entity';
-import { ConnectionProviderLifecycleHookService } from 'src/engine/core-modules/application/connection-provider/connection-provider-lifecycle-hook.service';
-import { ConnectionProviderOAuthFlowService } from 'src/engine/core-modules/application/connection-provider/connection-provider-oauth-flow.service';
-import { ConnectionProviderService } from 'src/engine/core-modules/application/connection-provider/connection-provider.service';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { SecureHttpClientService } from 'src/engine/core-modules/secure-http-client/secure-http-client.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { SECRET_ENCRYPTION_ENVELOPE_V2_PREFIX } from 'src/engine/core-modules/secret-encryption/constants/secret-encryption.constant';
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { ConnectedAccountTokenEncryptionService } from 'src/engine/metadata-modules/connected-account/services/connected-account-token-encryption.service';
-
-const FAKE_CIPHER_PREFIX = `${SECRET_ENCRYPTION_ENVELOPE_V2_PREFIX}keyid:`;
-
-describe('ConnectionProviderOAuthFlowService', () => {
- let service: ConnectionProviderOAuthFlowService;
- let connectionProviderService: {
- findOneByIdOrThrow: jest.Mock;
- getClientCredentials: jest.Mock;
- };
- let jwtWrapperService: {
- signAsyncOrThrow: jest.Mock;
- verifyJwtToken: jest.Mock;
- };
- let secureHttpClientService: { createSsrfSafeFetch: jest.Mock };
- let connectedAccountRepository: {
- count: jest.Mock;
- update: jest.Mock;
- create: jest.Mock;
- save: jest.Mock;
- findOne: jest.Mock;
- findOneByOrFail: jest.Mock;
- };
- let connectionProviderLifecycleHookService: { dispatchOnConnect: jest.Mock };
-
- const baseProvider: ConnectionProviderEntity = {
- id: 'provider-1',
- universalIdentifier: 'provider-uid',
- applicationId: 'app-1',
- workspaceId: 'workspace-1',
- name: 'linear',
- displayName: 'Linear',
- type: 'oauth',
- oauthConfig: {
- authorizationEndpoint: 'https://linear.app/oauth/authorize',
- tokenEndpoint: 'https://api.linear.app/oauth/token',
- revokeEndpoint: null,
- scopes: ['read', 'write'],
- clientIdVariable: 'LINEAR_CLIENT_ID',
- clientSecretVariable: 'LINEAR_CLIENT_SECRET',
- authorizationParams: null,
- tokenRequestContentType: 'form-urlencoded',
- usePkce: false,
- },
- createdAt: new Date(),
- updatedAt: new Date(),
- } as unknown as ConnectionProviderEntity;
-
- beforeEach(async () => {
- connectionProviderService = {
- findOneByIdOrThrow: jest.fn(),
- getClientCredentials: jest.fn(async () => ({
- clientId: 'lin_client_id',
- clientSecret: 'lin_client_secret',
- })),
- };
- jwtWrapperService = {
- signAsyncOrThrow: jest.fn(),
- verifyJwtToken: jest.fn(),
- };
- secureHttpClientService = { createSsrfSafeFetch: jest.fn() };
- connectedAccountRepository = {
- count: jest.fn(async () => 0),
- update: jest.fn(),
- create: jest.fn((entity) => entity),
- save: jest.fn(async (entity) => ({ ...entity, id: 'new-account-id' })),
- findOne: jest.fn(async () => null),
- findOneByOrFail: jest.fn(async ({ id }) => ({
- id,
- provider: ConnectedAccountProvider.APP,
- })),
- };
- connectionProviderLifecycleHookService = {
- dispatchOnConnect: jest.fn(),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ConnectionProviderOAuthFlowService,
- {
- provide: ConnectionProviderService,
- useValue: connectionProviderService,
- },
- { provide: JwtWrapperService, useValue: jwtWrapperService },
- { provide: SecureHttpClientService, useValue: secureHttpClientService },
- {
- provide: TwentyConfigService,
- useValue: { get: jest.fn(() => 'https://api.example.com') },
- },
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: connectedAccountRepository,
- },
- {
- provide: ConnectionProviderLifecycleHookService,
- useValue: connectionProviderLifecycleHookService,
- },
- {
- // Real prefix/round-trip behavior is asserted in
- // connected-account-token-encryption.service.spec.ts; here we use a
- // CIPHER(...) wrapper so assertions can match exact ciphertext.
- provide: ConnectedAccountTokenEncryptionService,
- useValue: {
- encryptTokenPair: jest.fn(
- ({
- accessToken,
- refreshToken,
- }: {
- accessToken: string;
- refreshToken: string | null;
- workspaceId: string;
- }) => ({
- encryptedAccessToken: `${FAKE_CIPHER_PREFIX}CIPHER(${accessToken})`,
- encryptedRefreshToken: isDefined(refreshToken)
- ? `${FAKE_CIPHER_PREFIX}CIPHER(${refreshToken})`
- : null,
- }),
- ),
- },
- },
- ],
- }).compile();
-
- service = module.get(ConnectionProviderOAuthFlowService);
- });
-
- afterEach(() => jest.clearAllMocks());
-
- describe('startAuthorizationFlow', () => {
- it('builds the provider authorization URL with the workspace + visibility context signed into state', async () => {
- jwtWrapperService.signAsyncOrThrow.mockResolvedValue(
- 'signed-state-token',
- );
-
- const { authorizationUrl } = await service.startAuthorizationFlow({
- connectionProvider: baseProvider,
- workspaceId: 'workspace-1',
- userId: 'user-1',
- userWorkspaceId: 'uws-1',
- visibility: 'user',
- reconnectingConnectedAccountId: null,
- redirectLocation: null,
- });
-
- const url = new URL(authorizationUrl);
-
- expect(url.origin + url.pathname).toBe(
- 'https://linear.app/oauth/authorize',
- );
- expect(url.searchParams.get('client_id')).toBe('lin_client_id');
- expect(url.searchParams.get('response_type')).toBe('code');
- // OAuth-standard `scope` (plural meaning) - these are the upstream
- // permissions we're requesting, unrelated to the row-visibility field.
- expect(url.searchParams.get('scope')).toBe('read write');
- expect(url.searchParams.get('state')).toBe('signed-state-token');
- expect(url.searchParams.get('redirect_uri')).toBe(
- 'https://api.example.com/auth/apps/callback',
- );
- expect(url.searchParams.has('code_challenge')).toBe(false);
-
- // signed payload carries workspace identity for the callback to use
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- expect.objectContaining({
- type: JwtTokenTypeEnum.APP_OAUTH_STATE,
- workspaceId: 'workspace-1',
- connectionProviderId: 'provider-1',
- visibility: 'user',
- reconnectingConnectedAccountId: null,
- }),
- expect.objectContaining({ expiresIn: expect.any(String) }),
- );
- });
-
- it('emits PKCE challenge params when usePkce is enabled', async () => {
- jwtWrapperService.signAsyncOrThrow.mockResolvedValue('signed-state');
-
- const { authorizationUrl } = await service.startAuthorizationFlow({
- connectionProvider: {
- ...baseProvider,
- oauthConfig: { ...baseProvider.oauthConfig!, usePkce: true },
- },
- workspaceId: 'workspace-1',
- userId: 'user-1',
- userWorkspaceId: 'uws-1',
- visibility: 'user',
- reconnectingConnectedAccountId: null,
- redirectLocation: null,
- });
-
- const url = new URL(authorizationUrl);
-
- expect(url.searchParams.get('code_challenge_method')).toBe('S256');
- expect(url.searchParams.get('code_challenge')).toMatch(/^[\w-]+$/);
- });
-
- describe('reconnect target validation', () => {
- // Cross-workspace reconnect was a real bug: the persist UPDATE filtered
- // by (id, workspaceId) so it wrote nothing, but the subsequent
- // findOneByOrFail({ id }) returned the foreign-workspace row with stale
- // tokens, making the reconnect look successful. Catch it at authorize
- // time before the upstream OAuth round-trip.
- const validateArgs = {
- connectionProvider: baseProvider,
- workspaceId: 'workspace-1',
- userId: 'user-1',
- userWorkspaceId: 'uws-1',
- visibility: 'user' as const,
- redirectLocation: null,
- };
-
- it('throws FORBIDDEN when reconnecting an id that lives in another workspace', async () => {
- connectedAccountRepository.findOne.mockResolvedValue(null);
-
- const error = await service
- .startAuthorizationFlow({
- ...validateArgs,
- reconnectingConnectedAccountId: 'foreign-account-id',
- })
- .catch((caught) => caught);
-
- expect(error).toMatchObject({
- code: 'FORBIDDEN',
- });
- expect(error.message).toContain('foreign-account-id');
- expect(connectedAccountRepository.findOne).toHaveBeenCalledWith({
- where: {
- id: 'foreign-account-id',
- workspaceId: 'workspace-1',
- connectionProviderId: 'provider-1',
- },
- });
- // No state JWT signed, no upstream URL built.
- expect(jwtWrapperService.signAsyncOrThrow).not.toHaveBeenCalled();
- });
-
- it('throws FORBIDDEN when reconnecting an id that belongs to a different provider in the same workspace', async () => {
- // findOne with the provider filter returns null even though the row
- // exists in this workspace under a different provider.
- connectedAccountRepository.findOne.mockResolvedValue(null);
-
- await expect(
- service.startAuthorizationFlow({
- ...validateArgs,
- reconnectingConnectedAccountId: 'wrong-provider-account-id',
- }),
- ).rejects.toMatchObject({ code: 'FORBIDDEN' });
- });
-
- it('proceeds when the reconnect target matches workspace and provider', async () => {
- connectedAccountRepository.findOne.mockResolvedValue({
- id: 'existing-account-id',
- workspaceId: 'workspace-1',
- connectionProviderId: 'provider-1',
- });
- jwtWrapperService.signAsyncOrThrow.mockResolvedValue('state');
-
- const { authorizationUrl } = await service.startAuthorizationFlow({
- ...validateArgs,
- reconnectingConnectedAccountId: 'existing-account-id',
- });
-
- expect(new URL(authorizationUrl).searchParams.get('state')).toBe(
- 'state',
- );
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalled();
- });
-
- it('skips the lookup entirely when reconnectingConnectedAccountId is null', async () => {
- jwtWrapperService.signAsyncOrThrow.mockResolvedValue('state');
-
- await service.startAuthorizationFlow({
- ...validateArgs,
- reconnectingConnectedAccountId: null,
- });
-
- expect(connectedAccountRepository.findOne).not.toHaveBeenCalled();
- });
- });
- });
-
- describe('completeAuthorizationFlow', () => {
- const stateClaims = {
- sub: 'provider-1',
- type: JwtTokenTypeEnum.APP_OAUTH_STATE,
- connectionProviderId: 'provider-1',
- workspaceId: 'workspace-1',
- userId: 'user-1',
- userWorkspaceId: 'uws-1',
- visibility: 'user' as const,
- reconnectingConnectedAccountId: null,
- redirectLocation: null,
- codeVerifier: null,
- };
-
- const successfulTokenResponse = {
- ok: true,
- status: 200,
- json: async () => ({
- access_token: 'new_access',
- refresh_token: 'new_refresh',
- scope: 'read write',
- }),
- text: async () => '',
- };
-
- beforeEach(() => {
- jwtWrapperService.verifyJwtToken.mockResolvedValue(stateClaims);
- connectionProviderService.findOneByIdOrThrow.mockResolvedValue(
- baseProvider,
- );
- secureHttpClientService.createSsrfSafeFetch.mockReturnValue(
- jest.fn(async () => successfulTokenResponse),
- );
- });
-
- it('always creates a new ConnectedAccount when no reconnect id is supplied', async () => {
- const result = await service.completeAuthorizationFlow({
- code: 'auth_code',
- state: 'signed-state',
- });
-
- expect(result.connectedAccountId).toBe('new-account-id');
- expect(result.workspaceId).toBe('workspace-1');
- expect(result.applicationId).toBe('app-1');
-
- // Encrypt-at-receipt: the entity must never hold the IDP plaintext.
- expect(connectedAccountRepository.create).toHaveBeenCalledWith(
- expect.objectContaining({
- provider: ConnectedAccountProvider.APP,
- accessToken: `${FAKE_CIPHER_PREFIX}CIPHER(new_access)`,
- refreshToken: `${FAKE_CIPHER_PREFIX}CIPHER(new_refresh)`,
- connectionProviderId: 'provider-1',
- applicationId: 'app-1',
- workspaceId: 'workspace-1',
- userWorkspaceId: 'uws-1',
- visibility: 'user',
- }),
- );
- expect(connectedAccountRepository.save).toHaveBeenCalled();
- expect(connectedAccountRepository.update).not.toHaveBeenCalled();
- });
-
- it('updates the existing ConnectedAccount when reconnectingConnectedAccountId is supplied', async () => {
- jwtWrapperService.verifyJwtToken.mockResolvedValue({
- ...stateClaims,
- reconnectingConnectedAccountId: 'existing-account-id',
- });
-
- const result = await service.completeAuthorizationFlow({
- code: 'auth_code',
- state: 'signed-state',
- });
-
- expect(result.connectedAccountId).toBe('existing-account-id');
- expect(connectedAccountRepository.update).toHaveBeenCalledWith(
- { id: 'existing-account-id', workspaceId: 'workspace-1' },
- expect.objectContaining({
- accessToken: `${FAKE_CIPHER_PREFIX}CIPHER(new_access)`,
- refreshToken: `${FAKE_CIPHER_PREFIX}CIPHER(new_refresh)`,
- authFailedAt: null,
- visibility: 'user',
- }),
- );
- // Defense-in-depth: the post-update read MUST also be workspace-scoped,
- // otherwise a foreign-id that slipped past the authorize-time guard
- // would still surface stale fields from another workspace.
- expect(connectedAccountRepository.findOneByOrFail).toHaveBeenCalledWith({
- id: 'existing-account-id',
- workspaceId: 'workspace-1',
- });
- expect(connectedAccountRepository.create).not.toHaveBeenCalled();
- });
-
- it('updates visibility on an existing ConnectedAccount when reconnecting', async () => {
- jwtWrapperService.verifyJwtToken.mockResolvedValue({
- ...stateClaims,
- visibility: 'workspace',
- reconnectingConnectedAccountId: 'existing-account-id',
- });
-
- await service.completeAuthorizationFlow({
- code: 'auth_code',
- state: 'signed-state',
- });
-
- expect(connectedAccountRepository.update).toHaveBeenCalledWith(
- { id: 'existing-account-id', workspaceId: 'workspace-1' },
- expect.objectContaining({
- visibility: 'workspace',
- }),
- );
- });
-
- it('persists the workspace visibility when state asks for it', async () => {
- jwtWrapperService.verifyJwtToken.mockResolvedValue({
- ...stateClaims,
- visibility: 'workspace',
- });
-
- await service.completeAuthorizationFlow({
- code: 'auth_code',
- state: 'signed-state',
- });
-
- expect(connectedAccountRepository.create).toHaveBeenCalledWith(
- expect.objectContaining({ visibility: 'workspace' }),
- );
- });
-
- it('rejects an invalid state', async () => {
- jwtWrapperService.verifyJwtToken.mockRejectedValue(
- new Error('JWT expired'),
- );
-
- await expect(
- service.completeAuthorizationFlow({
- code: 'auth_code',
- state: 'bad-state',
- }),
- ).rejects.toThrow(/state/);
- });
-
- it('hands the created connection to the on-connect lifecycle hook', async () => {
- const result = await service.completeAuthorizationFlow({
- code: 'auth_code',
- state: 'signed-state',
- });
-
- expect(
- connectionProviderLifecycleHookService.dispatchOnConnect,
- ).toHaveBeenCalledWith({
- provider: baseProvider,
- workspaceId: 'workspace-1',
- connectedAccountId: result.connectedAccountId,
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/application/pre-installed-apps/__tests__/pre-installed-apps.service.spec.ts b/packages/twenty-server/src/engine/core-modules/application/pre-installed-apps/__tests__/pre-installed-apps.service.spec.ts
deleted file mode 100644
index 19cf443531c..00000000000
--- a/packages/twenty-server/src/engine/core-modules/application/pre-installed-apps/__tests__/pre-installed-apps.service.spec.ts
+++ /dev/null
@@ -1,163 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';
-import { ApplicationInstallService } from 'src/engine/core-modules/application/application-install/application-install.service';
-import { ApplicationRegistrationEntity } from 'src/engine/core-modules/application/application-registration/application-registration.entity';
-import { PreInstalledAppsService } from 'src/engine/core-modules/application/pre-installed-apps/pre-installed-apps.service';
-import {
- ApplicationException,
- ApplicationExceptionCode,
-} from 'src/engine/core-modules/application/application.exception';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-
-describe('PreInstalledAppsService', () => {
- let service: PreInstalledAppsService;
- let applicationInstallService: { installApplication: jest.Mock };
- let applicationRegistrationRepository: {
- find: jest.Mock;
- findOne: jest.Mock;
- };
- let workspaceIteratorService: { iterate: jest.Mock };
- let messageQueueService: { add: jest.Mock };
-
- beforeEach(async () => {
- applicationInstallService = { installApplication: jest.fn() };
- applicationRegistrationRepository = { find: jest.fn(), findOne: jest.fn() };
- workspaceIteratorService = { iterate: jest.fn() };
- messageQueueService = { add: jest.fn() };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- PreInstalledAppsService,
- {
- provide: ApplicationInstallService,
- useValue: applicationInstallService,
- },
- {
- provide: getRepositoryToken(ApplicationRegistrationEntity),
- useValue: applicationRegistrationRepository,
- },
- {
- provide: WorkspaceIteratorService,
- useValue: workspaceIteratorService,
- },
- {
- provide: getQueueToken(MessageQueue.workspaceQueue),
- useValue: messageQueueService,
- },
- ],
- }).compile();
-
- service = module.get<PreInstalledAppsService>(PreInstalledAppsService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('backfillApplicationOnAllWorkspaces', () => {
- it('should throw when the registration does not exist', async () => {
- applicationRegistrationRepository.findOne.mockResolvedValue(null);
-
- await expect(
- service.backfillApplicationOnAllWorkspaces('missing-id'),
- ).rejects.toThrow(ApplicationException);
-
- expect(workspaceIteratorService.iterate).not.toHaveBeenCalled();
- });
-
- it('should install the app on every iterated workspace', async () => {
- applicationRegistrationRepository.findOne.mockResolvedValue({
- id: 'app-1',
- name: 'My App',
- } as ApplicationRegistrationEntity);
-
- workspaceIteratorService.iterate.mockImplementation(
- async ({ callback }) => {
- await callback({ workspaceId: 'workspace-1', index: 0, total: 2 });
- await callback({ workspaceId: 'workspace-2', index: 1, total: 2 });
-
- return { success: [{ workspaceId: 'workspace-1' }], fail: [] };
- },
- );
-
- await service.backfillApplicationOnAllWorkspaces('app-1');
-
- expect(
- applicationInstallService.installApplication,
- ).toHaveBeenCalledTimes(2);
- expect(applicationInstallService.installApplication).toHaveBeenCalledWith(
- {
- appRegistrationId: 'app-1',
- workspaceId: 'workspace-1',
- },
- );
- expect(applicationInstallService.installApplication).toHaveBeenCalledWith(
- {
- appRegistrationId: 'app-1',
- workspaceId: 'workspace-2',
- },
- );
- });
-
- it('should swallow already-installed errors so the backfill stays idempotent', async () => {
- applicationRegistrationRepository.findOne.mockResolvedValue({
- id: 'app-1',
- name: 'My App',
- } as ApplicationRegistrationEntity);
-
- applicationInstallService.installApplication.mockRejectedValue(
- new ApplicationException(
- 'already installed',
- ApplicationExceptionCode.APP_ALREADY_INSTALLED,
- ),
- );
-
- workspaceIteratorService.iterate.mockImplementation(
- async ({ callback }) => {
- await expect(
- callback({ workspaceId: 'workspace-1', index: 0, total: 1 }),
- ).resolves.toBeUndefined();
-
- return { success: [{ workspaceId: 'workspace-1' }], fail: [] };
- },
- );
-
- await expect(
- service.backfillApplicationOnAllWorkspaces('app-1'),
- ).resolves.toBeUndefined();
- });
-
- it('should rethrow unexpected install errors to the iterator', async () => {
- applicationRegistrationRepository.findOne.mockResolvedValue({
- id: 'app-1',
- name: 'My App',
- } as ApplicationRegistrationEntity);
-
- const unexpectedError = new Error('boom');
-
- applicationInstallService.installApplication.mockRejectedValue(
- unexpectedError,
- );
-
- workspaceIteratorService.iterate.mockImplementation(
- async ({ callback }) => {
- await expect(
- callback({ workspaceId: 'workspace-1', index: 0, total: 1 }),
- ).rejects.toThrow(unexpectedError);
-
- return {
- success: [],
- fail: [{ workspaceId: 'workspace-1', error: unexpectedError }],
- };
- },
- );
-
- await expect(
- service.backfillApplicationOnAllWorkspaces('app-1'),
- ).resolves.toBeUndefined();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/auth.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/services/auth.service.spec.ts
deleted file mode 100644
index 56bac3d507d..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/services/auth.service.spec.ts
+++ /dev/null
@@ -1,813 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import bcrypt from 'bcrypt';
-import { type Repository } from 'typeorm';
-import { AppPath } from 'twenty-shared/types';
-
-import { AppTokenEntity } from 'src/engine/core-modules/app-token/app-token.entity';
-import { EventLogEmitterService } from 'src/engine/core-modules/event-logs/emit/event-log-emitter.service';
-import {
- AuthException,
- AuthExceptionCode,
-} from 'src/engine/core-modules/auth/auth.exception';
-import { AuthSsoService } from 'src/engine/core-modules/auth/services/auth-sso.service';
-import { SignInUpService } from 'src/engine/core-modules/auth/services/sign-in-up.service';
-import { type GoogleRequest } from 'src/engine/core-modules/auth/strategies/google.auth.strategy';
-import { AccessTokenService } from 'src/engine/core-modules/auth/token/services/access-token.service';
-import { LoginTokenService } from 'src/engine/core-modules/auth/token/services/login-token.service';
-import { RefreshTokenService } from 'src/engine/core-modules/auth/token/services/refresh-token.service';
-import { SSOExchangeTokenService } from 'src/engine/core-modules/auth/token/services/sso-exchange-token.service';
-import { type ExistingUserOrNewUser } from 'src/engine/core-modules/auth/types/signInUp.type';
-import { DomainServerConfigService } from 'src/engine/core-modules/domain/domain-server-config/services/domain-server-config.service';
-import { buildUrlWithPathnameAndSearchParams } from 'src/engine/core-modules/domain/domain-server-config/utils/build-url-with-pathname-and-search-params.util';
-import { WorkspaceDomainsService } from 'src/engine/core-modules/domain/workspace-domains/services/workspace-domains.service';
-import { EmailService } from 'src/engine/core-modules/email/email.service';
-import { GuardRedirectService } from 'src/engine/core-modules/guard-redirect/services/guard-redirect.service';
-import { I18nService } from 'src/engine/core-modules/i18n/i18n.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';
-import { UserService } from 'src/engine/core-modules/user/services/user.service';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { WorkspaceInvitationService } from 'src/engine/core-modules/workspace-invitation/services/workspace-invitation.service';
-import { AuthProviderEnum } from 'src/engine/core-modules/workspace/types/workspace.type';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { ApplicationRegistrationService } from 'src/engine/core-modules/application/application-registration/application-registration.service';
-import { CreateSSOConnectedAccountService } from 'src/engine/core-modules/auth/services/create-sso-connected-account.service';
-import { UserSessionService } from 'src/engine/core-modules/user-session/services/user-session.service';
-import { UserSessionRevokedReason } from 'src/engine/core-modules/user-session/types/user-session-revoked-reason.type';
-import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
-import { PermissionsService } from 'src/engine/metadata-modules/permissions/permissions.service';
-
-import { AuthService } from './auth.service';
-
-jest.mock('bcrypt');
-
-jest.mock('twenty-emails', () => ({
- ...jest.requireActual('twenty-emails'),
- renderEmail: jest.fn().mockResolvedValue('rendered-email'),
-}));
-
-const twentyConfigServiceGetMock = jest.fn();
-
-describe('AuthService', () => {
- let service: AuthService;
- let userService: UserService;
- let workspaceRepository: Repository<WorkspaceEntity>;
- let userRepository: Repository<UserEntity>;
- let authSsoService: AuthSsoService;
- let userWorkspaceService: UserWorkspaceService;
- let workspaceInvitationService: WorkspaceInvitationService;
- let permissionsService: PermissionsService;
- let refreshTokenService: RefreshTokenService;
- let userSessionService: UserSessionService;
- let signInUpServiceMock: jest.Mocked<
- Pick<SignInUpService, 'validatePassword' | 'signUpWithoutWorkspace'>
- >;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AuthService,
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(UserEntity),
- useValue: {
- findOne: jest.fn(),
- update: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(AppTokenEntity),
- useValue: {
- createQueryBuilder: jest.fn().mockReturnValue({
- leftJoin: jest.fn().mockReturnThis(),
- andWhere: jest.fn().mockReturnThis(),
- where: jest.fn().mockReturnThis(),
- getOne: jest.fn().mockImplementation(() => null),
- }),
- update: jest.fn(),
- },
- },
- {
- provide: LoginTokenService,
- useValue: {},
- },
- {
- provide: WorkspaceDomainsService,
- useValue: {},
- },
- {
- provide: DomainServerConfigService,
- useValue: {
- getBaseUrl: jest.fn(() => new URL('https://app.twenty.com')),
- buildBaseUrl: jest.fn(({ pathname, searchParams, hash }) =>
- buildUrlWithPathnameAndSearchParams({
- baseUrl: new URL('https://app.twenty.com'),
- pathname,
- searchParams,
- hash,
- }),
- ),
- },
- },
- {
- provide: SSOExchangeTokenService,
- useValue: {
- generateSSOExchangeToken: jest.fn().mockResolvedValue({
- token: 'sso-exchange-token',
- expiresAt: new Date(),
- }),
- },
- },
- {
- provide: GuardRedirectService,
- useValue: {},
- },
- {
- provide: SignInUpService,
- useValue: {
- validatePassword: jest.fn().mockResolvedValue(undefined),
- generateHash: jest.fn(),
- signUpWithoutWorkspace: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: twentyConfigServiceGetMock,
- },
- },
- {
- provide: EmailService,
- useValue: {
- send: jest.fn(),
- },
- },
- {
- provide: AccessTokenService,
- useValue: {},
- },
- {
- provide: RefreshTokenService,
- useValue: {
- generateRefreshToken: jest.fn(),
- },
- },
- {
- provide: UserWorkspaceService,
- useValue: {
- checkUserWorkspaceExists: jest.fn(),
- addUserToWorkspaceIfUserNotInWorkspace: jest.fn(),
- findAvailableWorkspacesByEmail: jest.fn(),
- },
- },
- {
- provide: UserService,
- useValue: {
- hasUserAccessToWorkspaceOrThrow: jest.fn(),
- findUserByEmailWithWorkspaces: jest.fn(),
- },
- },
- {
- provide: WorkspaceInvitationService,
- useValue: {
- getOneWorkspaceInvitation: jest.fn(),
- validatePersonalInvitation: jest.fn(),
- },
- },
- {
- provide: AuthSsoService,
- useValue: {
- findWorkspaceFromWorkspaceIdOrAuthProvider: jest.fn(),
- },
- },
- {
- provide: I18nService,
- useValue: {
- getI18nInstance: jest.fn().mockReturnValue({
- _: jest.fn().mockReturnValue('mocked-translation'),
- }),
- },
- },
- {
- provide: EventLogEmitterService,
- useValue: {},
- },
- {
- provide: PermissionsService,
- useValue: {
- userHasWorkspaceSettingPermission: jest
- .fn()
- .mockResolvedValue(false),
- },
- },
- {
- provide: ApplicationRegistrationService,
- useValue: {},
- },
- {
- provide: FeatureFlagService,
- useValue: {
- isFeatureEnabled: jest.fn().mockResolvedValue(false),
- },
- },
- {
- provide: CreateSSOConnectedAccountService,
- useValue: {
- createOrUpdateSSOConnectedAccount: jest
- .fn()
- .mockResolvedValue(undefined),
- },
- },
- {
- provide: UserSessionService,
- useValue: {
- revokeAllSessionsForUser: jest.fn().mockResolvedValue(0),
- },
- },
- ],
- }).compile();
-
- service = module.get<AuthService>(AuthService);
- userService = module.get<UserService>(UserService);
- workspaceInvitationService = module.get<WorkspaceInvitationService>(
- WorkspaceInvitationService,
- );
- authSsoService = module.get<AuthSsoService>(AuthSsoService);
- userWorkspaceService =
- module.get<UserWorkspaceService>(UserWorkspaceService);
- workspaceRepository = module.get<Repository<WorkspaceEntity>>(
- getRepositoryToken(WorkspaceEntity),
- );
- userRepository = module.get<Repository<UserEntity>>(
- getRepositoryToken(UserEntity),
- );
- permissionsService = module.get<PermissionsService>(PermissionsService);
- refreshTokenService = module.get<RefreshTokenService>(RefreshTokenService);
- signInUpServiceMock = module.get(SignInUpService) as jest.Mocked<
- Pick<SignInUpService, 'validatePassword' | 'signUpWithoutWorkspace'>
- >;
- userSessionService = module.get<UserSessionService>(UserSessionService);
- });
-
- beforeEach(() => {
- twentyConfigServiceGetMock.mockReturnValue(false);
- signInUpServiceMock.validatePassword.mockClear();
- });
-
- it('should be defined', async () => {
- expect(service).toBeDefined();
- });
-
- it('challenge - user already member of workspace', async () => {
- const workspace = { isPasswordAuthEnabled: true } as WorkspaceEntity;
- const user = {
- email: 'email',
- password: 'password',
- captchaToken: 'captchaToken',
- };
-
- (bcrypt.compare as jest.Mock).mockReturnValueOnce(true);
-
- jest.spyOn(userRepository, 'findOne').mockReturnValueOnce({
- email: user.email,
- passwordHash: 'passwordHash',
- captchaToken: user.captchaToken,
- } as unknown as Promise<UserEntity>);
-
- jest
- .spyOn(userWorkspaceService, 'checkUserWorkspaceExists')
- .mockReturnValueOnce({} as any);
-
- const response = await service.validateLoginWithPassword(
- {
- email: 'email',
- password: 'password',
- captchaToken: 'captchaToken',
- },
- workspace,
- );
-
- expect(response).toStrictEqual({
- email: user.email,
- passwordHash: 'passwordHash',
- captchaToken: user.captchaToken,
- });
- });
-
- it('allows password login through SSO bypass when user has permission', async () => {
- const workspace = {
- id: 'workspace-id',
- isPasswordAuthEnabled: false,
- isPasswordAuthBypassEnabled: true,
- } as WorkspaceEntity;
-
- const userEntity = {
- id: 'user-id',
- email: 'email',
- passwordHash: 'password-hash',
- userWorkspaces: [
- {
- id: 'user-workspace-id',
- workspaceId: workspace.id,
- } as any,
- ],
- } as unknown as UserEntity;
-
- (bcrypt.compare as jest.Mock).mockResolvedValue(true);
-
- jest.spyOn(userRepository, 'findOne').mockResolvedValueOnce(userEntity);
- jest
- .spyOn(userWorkspaceService, 'checkUserWorkspaceExists')
- .mockResolvedValueOnce({ id: 'user-workspace-id' } as any);
- jest
- .spyOn(permissionsService, 'userHasWorkspaceSettingPermission')
- .mockResolvedValueOnce(true);
-
- const response = await service.validateLoginWithPassword(
- {
- email: 'email',
- password: 'password',
- captchaToken: 'captcha-token',
- },
- workspace,
- );
-
- expect(response).toBe(userEntity);
- });
-
- it('throws when bypass permission is missing for disabled password auth', async () => {
- const workspace = {
- id: 'workspace-id',
- isPasswordAuthEnabled: false,
- isPasswordAuthBypassEnabled: true,
- } as WorkspaceEntity;
-
- const userEntity = {
- id: 'user-id',
- email: 'email',
- passwordHash: 'password-hash',
- userWorkspaces: [
- {
- id: 'user-workspace-id',
- workspaceId: workspace.id,
- } as any,
- ],
- } as unknown as UserEntity;
-
- jest.spyOn(userRepository, 'findOne').mockResolvedValueOnce(userEntity);
- jest
- .spyOn(userWorkspaceService, 'checkUserWorkspaceExists')
- .mockResolvedValueOnce(null);
- jest
- .spyOn(permissionsService, 'userHasWorkspaceSettingPermission')
- .mockResolvedValueOnce(false);
-
- await expect(
- service.validateLoginWithPassword(
- {
- email: 'email',
- password: 'password',
- captchaToken: 'captcha-token',
- },
- workspace,
- ),
- ).rejects.toThrow(
- new AuthException(
- 'Email/Password auth is not enabled for this workspace',
- AuthExceptionCode.FORBIDDEN_EXCEPTION,
- ),
- );
- expect(signInUpServiceMock.validatePassword).not.toHaveBeenCalled();
- });
-
- it('challenge - user who have an invitation', async () => {
- const user = {
- email: 'email',
- password: 'password',
- captchaToken: 'captchaToken',
- };
-
- const UserFindOneSpy = jest
- .spyOn(userRepository, 'findOne')
- .mockReturnValueOnce({
- email: user.email,
- passwordHash: 'passwordHash',
- captchaToken: user.captchaToken,
- } as unknown as Promise<UserEntity>);
-
- (bcrypt.compare as jest.Mock).mockReturnValueOnce(true);
- jest
- .spyOn(userWorkspaceService, 'checkUserWorkspaceExists')
- .mockReturnValueOnce(null as any);
-
- const getOneWorkspaceInvitationSpy = jest
- .spyOn(workspaceInvitationService, 'getOneWorkspaceInvitation')
- .mockReturnValueOnce({} as any);
-
- const workspaceInvitationValidatePersonalInvitationSpy = jest
- .spyOn(workspaceInvitationService, 'validatePersonalInvitation')
- .mockReturnValueOnce({} as any);
-
- const addUserToWorkspaceIfUserNotInWorkspaceSpy = jest
- .spyOn(userWorkspaceService, 'addUserToWorkspaceIfUserNotInWorkspace')
- .mockReturnValueOnce({} as any);
-
- const response = await service.validateLoginWithPassword(
- {
- email: 'email',
- password: 'password',
- captchaToken: 'captchaToken',
- },
- {
- isPasswordAuthEnabled: true,
- } as WorkspaceEntity,
- );
-
- expect(response).toStrictEqual({
- email: user.email,
- passwordHash: 'passwordHash',
- captchaToken: user.captchaToken,
- });
-
- expect(getOneWorkspaceInvitationSpy).toHaveBeenCalledTimes(1);
- expect(
- workspaceInvitationValidatePersonalInvitationSpy,
- ).toHaveBeenCalledTimes(1);
- expect(addUserToWorkspaceIfUserNotInWorkspaceSpy).toHaveBeenCalledTimes(1);
- expect(UserFindOneSpy).toHaveBeenCalledTimes(1);
- });
-
- describe('checkAccessForSignIn', () => {
- it('checkAccessForSignIn - allow signin for existing user who target a workspace with right access', async () => {
- const spy = jest
- .spyOn(userService, 'hasUserAccessToWorkspaceOrThrow')
- .mockResolvedValue();
-
- await service.checkAccessForSignIn({
- userData: {
- type: 'existingUser',
- existingUser: {
- id: 'user-id',
- },
- } as ExistingUserOrNewUser['userData'],
- invitation: undefined,
- workspaceInviteHash: undefined,
- workspace: {
- id: 'workspace-id',
- isPublicInviteLinkEnabled: true,
- approvedAccessDomains: [],
- } as unknown as WorkspaceEntity,
- });
-
- expect(spy).toHaveBeenCalledTimes(1);
- });
-
- it('checkAccessForSignIn - trigger error on existing user signin in unauthorized workspace', async () => {
- const spy = jest
- .spyOn(userService, 'hasUserAccessToWorkspaceOrThrow')
- .mockRejectedValue(new Error('Access denied'));
-
- await expect(
- service.checkAccessForSignIn({
- userData: {
- type: 'existingUser',
- existingUser: {
- id: 'user-id',
- },
- } as ExistingUserOrNewUser['userData'],
- invitation: undefined,
- workspaceInviteHash: undefined,
- workspace: {
- id: 'workspace-id',
- isPublicInviteLinkEnabled: true,
- approvedAccessDomains: [],
- } as unknown as WorkspaceEntity,
- }),
- ).rejects.toThrow(new Error('Access denied'));
-
- expect(spy).toHaveBeenCalledTimes(1);
- });
-
- it('checkAccessForSignIn - trigger an error when a user attempts to sign up using a public link in a workspace where public links are disabled', async () => {
- const spy = jest.spyOn(userService, 'hasUserAccessToWorkspaceOrThrow');
-
- await expect(
- service.checkAccessForSignIn({
- userData: {
- type: 'existingUser',
- existingUser: {
- id: 'user-id',
- },
- } as ExistingUserOrNewUser['userData'],
- invitation: undefined,
- workspaceInviteHash: 'workspaceInviteHash',
- workspace: {
- id: 'workspace-id',
- isPublicInviteLinkEnabled: false,
- approvedAccessDomains: [],
- } as unknown as WorkspaceEntity,
- }),
- ).rejects.toThrow(
- new AuthException(
- 'Public invite link is disabled for this workspace',
- AuthExceptionCode.FORBIDDEN_EXCEPTION,
- ),
- );
-
- expect(spy).toHaveBeenCalledTimes(0);
- });
-
- it("checkAccessForSignIn - allow signup for new user who don't target a workspace", async () => {
- const spy = jest
- .spyOn(userService, 'hasUserAccessToWorkspaceOrThrow')
- .mockResolvedValue();
-
- await service.checkAccessForSignIn({
- userData: {
- type: 'newUser',
- newUserPayload: {},
- } as ExistingUserOrNewUser['userData'],
- invitation: undefined,
- workspaceInviteHash: undefined,
- workspace: undefined,
- });
-
- expect(spy).toHaveBeenCalledTimes(0);
- });
-
- it("checkAccessForSignIn - allow signup for existing user who don't target a workspace", async () => {
- const spy = jest
- .spyOn(userService, 'hasUserAccessToWorkspaceOrThrow')
- .mockResolvedValue();
-
- await service.checkAccessForSignIn({
- userData: {
- type: 'existingUser',
- existingUser: {
- id: 'user-id',
- },
- } as ExistingUserOrNewUser['userData'],
- invitation: undefined,
- workspaceInviteHash: undefined,
- workspace: undefined,
- });
-
- expect(spy).toHaveBeenCalledTimes(0);
- });
-
- it('checkAccessForSignIn - allow signup for new user who target a workspace with invitation', async () => {
- const spy = jest
- .spyOn(userService, 'hasUserAccessToWorkspaceOrThrow')
- .mockResolvedValue();
-
- await service.checkAccessForSignIn({
- userData: {
- type: 'existingUser',
- existingUser: {
- id: 'user-id',
- },
- } as ExistingUserOrNewUser['userData'],
- invitation: {} as AppTokenEntity,
- workspaceInviteHash: undefined,
- workspace: { approvedAccessDomains: [] } as unknown as WorkspaceEntity,
- });
-
- expect(spy).toHaveBeenCalledTimes(0);
- });
-
- it('checkAccessForSignIn - allow signup for new user who target a workspace with public invitation', async () => {
- const spy = jest
- .spyOn(userService, 'hasUserAccessToWorkspaceOrThrow')
- .mockResolvedValue();
-
- await service.checkAccessForSignIn({
- userData: {
- type: 'newUser',
- newUserPayload: {},
- } as ExistingUserOrNewUser['userData'],
- invitation: undefined,
- workspaceInviteHash: 'workspaceInviteHash',
- workspace: {
- isPublicInviteLinkEnabled: true,
- approvedAccessDomains: [],
- } as unknown as WorkspaceEntity,
- });
-
- expect(spy).toHaveBeenCalledTimes(0);
- });
-
- it('checkAccessForSignIn - allow signup for new user who target a workspace with valid trusted domain', async () => {
- expect(async () => {
- await service.checkAccessForSignIn({
- userData: {
- type: 'newUser',
- newUserPayload: {
- email: '[email protected]',
- },
- } as ExistingUserOrNewUser['userData'],
- invitation: undefined,
- workspaceInviteHash: 'workspaceInviteHash',
- workspace: {
- isPublicInviteLinkEnabled: true,
- approvedAccessDomains: [
- { domain: 'domain.com', isValidated: true },
- ],
- } as unknown as WorkspaceEntity,
- });
- }).not.toThrow();
- });
- });
-
- describe('findWorkspaceForSignInUp', () => {
- it('findWorkspaceForSignInUp - signup password auth', async () => {
- const spyWorkspaceRepository = jest.spyOn(workspaceRepository, 'findOne');
- const spyAuthSsoService = jest.spyOn(
- authSsoService,
- 'findWorkspaceFromWorkspaceIdOrAuthProvider',
- );
-
- const result = await service.findWorkspaceForSignInUp({
- authProvider: AuthProviderEnum.Password,
- workspaceId: 'workspaceId',
- });
-
- expect(result).toBeUndefined();
- expect(spyWorkspaceRepository).toHaveBeenCalledTimes(1);
- expect(spyAuthSsoService).toHaveBeenCalledTimes(0);
- });
- it('findWorkspaceForSignInUp - signup password auth with workspaceInviteHash', async () => {
- const spyWorkspaceRepository = jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue({
- approvedAccessDomains: [],
- } as unknown as WorkspaceEntity);
- const spyAuthSsoService = jest.spyOn(
- authSsoService,
- 'findWorkspaceFromWorkspaceIdOrAuthProvider',
- );
-
- const result = await service.findWorkspaceForSignInUp({
- authProvider: AuthProviderEnum.Password,
- workspaceId: 'workspaceId',
- workspaceInviteHash: 'workspaceInviteHash',
- });
-
- expect(result).toBeDefined();
- expect(spyWorkspaceRepository).toHaveBeenCalledTimes(1);
- expect(spyAuthSsoService).toHaveBeenCalledTimes(0);
- });
- it('findWorkspaceForSignInUp - signup social sso auth with workspaceInviteHash', async () => {
- const spyWorkspaceRepository = jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue({
- approvedAccessDomains: [],
- } as unknown as WorkspaceEntity);
- const spyAuthSsoService = jest.spyOn(
- authSsoService,
- 'findWorkspaceFromWorkspaceIdOrAuthProvider',
- );
-
- const result = await service.findWorkspaceForSignInUp({
- authProvider: AuthProviderEnum.Password,
- workspaceId: 'workspaceId',
- workspaceInviteHash: 'workspaceInviteHash',
- });
-
- expect(result).toBeDefined();
- expect(spyWorkspaceRepository).toHaveBeenCalledTimes(1);
- expect(spyAuthSsoService).toHaveBeenCalledTimes(0);
- });
- it('findWorkspaceForSignInUp - signup social sso auth', async () => {
- const spyWorkspaceRepository = jest.spyOn(workspaceRepository, 'findOne');
-
- const spyAuthSsoService = jest
- .spyOn(authSsoService, 'findWorkspaceFromWorkspaceIdOrAuthProvider')
- .mockResolvedValue({} as WorkspaceEntity);
-
- const result = await service.findWorkspaceForSignInUp({
- authProvider: AuthProviderEnum.Google,
- workspaceId: 'workspaceId',
- email: 'email',
- });
-
- expect(result).toBeDefined();
- expect(spyWorkspaceRepository).toHaveBeenCalledTimes(0);
- expect(spyAuthSsoService).toHaveBeenCalledTimes(1);
- });
- it('findWorkspaceForSignInUp - sso auth', async () => {
- const spyWorkspaceRepository = jest.spyOn(workspaceRepository, 'findOne');
-
- const spyAuthSsoService = jest
- .spyOn(authSsoService, 'findWorkspaceFromWorkspaceIdOrAuthProvider')
- .mockResolvedValue({} as WorkspaceEntity);
-
- const result = await service.findWorkspaceForSignInUp({
- authProvider: AuthProviderEnum.SSO,
- workspaceId: 'workspaceId',
- email: 'email',
- });
-
- expect(result).toBeDefined();
- expect(spyWorkspaceRepository).toHaveBeenCalledTimes(0);
- expect(spyAuthSsoService).toHaveBeenCalledTimes(1);
- });
- });
-
- describe('signInUpWithSocialSSO - redirect without a target workspace', () => {
- const socialSSOUser: GoogleRequest['user'] = {
- firstName: 'John',
- lastName: 'Doe',
- email: '[email protected]',
- picture: 'picture',
- action: 'list-available-workspaces',
- returnToPath: '/settings/profile',
- };
-
- beforeEach(() => {
- jest
- .spyOn(userService, 'findUserByEmailWithWorkspaces')
- .mockResolvedValue({ id: 'user-id' } as UserEntity);
- });
-
- it('should not mint a refresh token nor put credentials in the query string', async () => {
- const url = await service.signInUpWithSocialSSO(
- socialSSOUser,
- AuthProviderEnum.Google,
- );
-
- expect(refreshTokenService.generateRefreshToken).not.toHaveBeenCalled();
- expect([...new URL(url).searchParams.keys()]).toEqual(['returnToPath']);
- });
-
- it('should redirect with the sso exchange token in the url fragment', async () => {
- const url = new URL(
- await service.signInUpWithSocialSSO(
- socialSSOUser,
- AuthProviderEnum.Google,
- ),
- );
-
- expect(
- new URLSearchParams(url.hash.substring(1)).get('ssoExchangeToken'),
- ).toBe('sso-exchange-token');
- expect(url.pathname).toBe(AppPath.SignInUp);
- });
-
- it('should not sign the user up again when they already exist', async () => {
- await service.signInUpWithSocialSSO(
- socialSSOUser,
- AuthProviderEnum.Google,
- );
-
- expect(signInUpServiceMock.signUpWithoutWorkspace).not.toHaveBeenCalled();
- });
- });
- describe('updatePassword', () => {
- const buildUserWithWorkspace = (userId: string) =>
- ({
- id: userId,
- email: '[email protected]',
- firstName: 'Tim',
- lastName: 'Apple',
- userWorkspaces: [{ locale: 'en' }],
- }) as unknown as UserEntity;
-
- it('should revoke every session for the user after a password change', async () => {
- const userId = 'e2c1a1a2-0000-4000-8000-000000000001';
-
- jest
- .spyOn(userRepository, 'findOne')
- .mockResolvedValue(buildUserWithWorkspace(userId));
-
- await service.updatePassword(userId, 'Str0ngPassw0rd!');
-
- expect(userSessionService.revokeAllSessionsForUser).toHaveBeenCalledWith({
- userId,
- reason: UserSessionRevokedReason.PasswordChanged,
- });
- });
-
- it('should not revoke sessions when the new password is rejected', async () => {
- const userId = 'e2c1a1a2-0000-4000-8000-000000000002';
-
- jest
- .spyOn(userRepository, 'findOne')
- .mockResolvedValue(buildUserWithWorkspace(userId));
-
- await expect(service.updatePassword(userId, 'weak')).rejects.toThrow(
- AuthException,
- );
-
- expect(
- userSessionService.revokeAllSessionsForUser,
- ).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.service.spec.ts
deleted file mode 100644
index 5aaa83a1394..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/services/google-apis-scopes.service.spec.ts
+++ /dev/null
@@ -1,114 +0,0 @@
-import { getGoogleApisOauthScopes } from 'src/engine/core-modules/auth/utils/get-google-apis-oauth-scopes';
-
-import { includesExpectedScopes } from './google-apis-scopes.service.util';
-
-describe('GoogleAPIScopesService', () => {
- describe('includesExpectedScopes', () => {
- it('should return true when all expected scopes are present', () => {
- const scopes = [
- 'email',
- 'profile',
- 'https://www.googleapis.com/auth/gmail.readonly',
- 'https://www.googleapis.com/auth/calendar.events',
- ];
- const expectedScopes = ['email', 'profile'];
-
- const result = includesExpectedScopes(scopes, expectedScopes);
-
- expect(result).toBe(true);
- });
-
- it('should return false when some expected scopes are missing', () => {
- const scopes = ['email', 'profile'];
- const expectedScopes = [
- 'email',
- 'profile',
- 'https://www.googleapis.com/auth/gmail.readonly',
- ];
-
- const result = includesExpectedScopes(scopes, expectedScopes);
-
- expect(result).toBe(false);
- });
-
- it('should return true when expected scopes match with userinfo prefix fallback', () => {
- const scopes = [
- 'https://www.googleapis.com/auth/userinfo.email',
- 'https://www.googleapis.com/auth/userinfo.profile',
- ];
- const expectedScopes = ['email', 'profile'];
-
- const result = includesExpectedScopes(scopes, expectedScopes);
-
- expect(result).toBe(true);
- });
-
- it('should return true when some scopes are direct matches and others use userinfo prefix', () => {
- const scopes = [
- 'email',
- 'https://www.googleapis.com/auth/userinfo.profile',
- 'https://www.googleapis.com/auth/gmail.readonly',
- ];
- const expectedScopes = ['email', 'profile'];
-
- const result = includesExpectedScopes(scopes, expectedScopes);
-
- expect(result).toBe(true);
- });
-
- it('should return true when 0 expected scopes', () => {
- const scopes = ['email', 'profile'];
- const expectedScopes: string[] = [];
-
- const result = includesExpectedScopes(scopes, expectedScopes);
-
- expect(result).toBe(true);
- });
-
- it('should return false when 0 scopes but expected scopes', () => {
- const scopes: string[] = [];
- const expectedScopes = ['email', 'profile'];
-
- const result = includesExpectedScopes(scopes, expectedScopes);
-
- expect(result).toBe(false);
- });
-
- it('should return true when both empty', () => {
- const scopes: string[] = [];
- const expectedScopes: string[] = [];
-
- const result = includesExpectedScopes(scopes, expectedScopes);
-
- expect(result).toBe(true);
- });
-
- it('should handle case-sensitive scope matching', () => {
- const scopes = ['EMAIL', 'PROFILE'];
- const expectedScopes = ['email', 'profile'];
-
- const result = includesExpectedScopes(scopes, expectedScopes);
-
- expect(result).toBe(false);
- });
-
- it('should work with the current Google API scopes', () => {
- // What is currently returned by Google
- const actualGoogleScopes = [
- 'https://www.googleapis.com/auth/calendar.events',
- 'https://www.googleapis.com/auth/gmail.readonly',
- 'https://www.googleapis.com/auth/gmail.send',
- 'https://www.googleapis.com/auth/gmail.compose',
- 'https://www.googleapis.com/auth/profile.emails.read',
- 'https://www.googleapis.com/auth/userinfo.email',
- 'https://www.googleapis.com/auth/userinfo.profile',
- 'openid',
- ];
- const expectedScopes = getGoogleApisOauthScopes();
-
- const result = includesExpectedScopes(actualGoogleScopes, expectedScopes);
-
- expect(result).toBe(true);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/google-apis-service-availability.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/services/google-apis-service-availability.service.spec.ts
deleted file mode 100644
index af629b3a2ba..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/services/google-apis-service-availability.service.spec.ts
+++ /dev/null
@@ -1,370 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { google } from 'googleapis';
-
-import { GoogleApisServiceAvailabilityService } from 'src/engine/core-modules/auth/services/google-apis-service-availability.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-jest.mock('googleapis', () => ({
- google: {
- auth: {
- OAuth2: jest.fn().mockImplementation(() => ({
- setCredentials: jest.fn(),
- })),
- },
- gmail: jest.fn(),
- calendar: jest.fn(),
- },
-}));
-
-describe('GoogleApisServiceAvailabilityService', () => {
- let service: GoogleApisServiceAvailabilityService;
- let mockTwentyConfigService: { get: jest.Mock };
-
- beforeEach(async () => {
- mockTwentyConfigService = {
- get: jest.fn(),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- GoogleApisServiceAvailabilityService,
- {
- provide: TwentyConfigService,
- useValue: mockTwentyConfigService,
- },
- ],
- }).compile();
-
- service = module.get<GoogleApisServiceAvailabilityService>(
- GoogleApisServiceAvailabilityService,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('checkServicesAvailability', () => {
- it('should return both services available when Gmail and Calendar are enabled and accessible', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'AUTH_GOOGLE_CLIENT_ID') return 'client-id';
- if (key === 'AUTH_GOOGLE_CLIENT_SECRET') return 'client-secret';
- if (key === 'MESSAGING_PROVIDER_GMAIL_ENABLED') return true;
- if (key === 'CALENDAR_PROVIDER_GOOGLE_ENABLED') return true;
-
- return undefined;
- });
-
- const mockGmailClient = {
- users: {
- getProfile: jest.fn().mockResolvedValue({ data: {} }),
- },
- };
-
- const mockCalendarClient = {
- events: {
- list: jest.fn().mockResolvedValue({ data: {} }),
- },
- };
-
- (google.gmail as jest.Mock).mockReturnValue(mockGmailClient);
- (google.calendar as jest.Mock).mockReturnValue(mockCalendarClient);
-
- const result = await service.checkServicesAvailability('access-token');
-
- expect(result).toEqual({
- isMessagingAvailable: true,
- isCalendarAvailable: true,
- });
- });
-
- it('should return messaging unavailable when messaging provider is disabled', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'AUTH_GOOGLE_CLIENT_ID') return 'client-id';
- if (key === 'AUTH_GOOGLE_CLIENT_SECRET') return 'client-secret';
- if (key === 'MESSAGING_PROVIDER_GMAIL_ENABLED') return false;
- if (key === 'CALENDAR_PROVIDER_GOOGLE_ENABLED') return true;
-
- return undefined;
- });
-
- const mockCalendarClient = {
- events: {
- list: jest.fn().mockResolvedValue({ data: {} }),
- },
- };
-
- (google.calendar as jest.Mock).mockReturnValue(mockCalendarClient);
-
- const result = await service.checkServicesAvailability('access-token');
-
- expect(result).toEqual({
- isMessagingAvailable: false,
- isCalendarAvailable: true,
- });
- });
-
- it('should return messaging unavailable when messaging service is not enabled in Google Workspace', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'AUTH_GOOGLE_CLIENT_ID') return 'client-id';
- if (key === 'AUTH_GOOGLE_CLIENT_SECRET') return 'client-secret';
- if (key === 'MESSAGING_PROVIDER_GMAIL_ENABLED') return true;
- if (key === 'CALENDAR_PROVIDER_GOOGLE_ENABLED') return true;
-
- return undefined;
- });
-
- const gmailServiceNotEnabledError = {
- response: {
- status: 400,
- data: {
- error: {
- code: 400,
- message: 'Mail service not enabled',
- errors: [
- {
- message: 'Mail service not enabled',
- domain: 'global',
- reason: 'failedPrecondition',
- },
- ],
- status: 'FAILED_PRECONDITION',
- },
- },
- },
- };
-
- const mockGmailClient = {
- users: {
- getProfile: jest.fn().mockRejectedValue(gmailServiceNotEnabledError),
- },
- };
-
- const mockCalendarClient = {
- events: {
- list: jest.fn().mockResolvedValue({ data: {} }),
- },
- };
-
- (google.gmail as jest.Mock).mockReturnValue(mockGmailClient);
- (google.calendar as jest.Mock).mockReturnValue(mockCalendarClient);
-
- const result = await service.checkServicesAvailability('access-token');
-
- expect(result).toEqual({
- isMessagingAvailable: false,
- isCalendarAvailable: true,
- });
- });
-
- it('should return Calendar unavailable when Calendar service is not enabled in Google Workspace', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'AUTH_GOOGLE_CLIENT_ID') return 'client-id';
- if (key === 'AUTH_GOOGLE_CLIENT_SECRET') return 'client-secret';
- if (key === 'MESSAGING_PROVIDER_GMAIL_ENABLED') return true;
- if (key === 'CALENDAR_PROVIDER_GOOGLE_ENABLED') return true;
-
- return undefined;
- });
-
- const calendarServiceNotEnabledError = {
- response: {
- status: 400,
- data: {
- error: {
- code: 400,
- message: 'Calendar service not enabled',
- errors: [
- {
- message: 'Calendar service not enabled',
- domain: 'global',
- reason: 'failedPrecondition',
- },
- ],
- status: 'FAILED_PRECONDITION',
- },
- },
- },
- };
-
- const mockGmailClient = {
- users: {
- getProfile: jest.fn().mockResolvedValue({ data: {} }),
- },
- };
-
- const mockCalendarClient = {
- events: {
- list: jest.fn().mockRejectedValue(calendarServiceNotEnabledError),
- },
- };
-
- (google.gmail as jest.Mock).mockReturnValue(mockGmailClient);
- (google.calendar as jest.Mock).mockReturnValue(mockCalendarClient);
-
- const result = await service.checkServicesAvailability('access-token');
-
- expect(result).toEqual({
- isMessagingAvailable: true,
- isCalendarAvailable: false,
- });
- });
-
- it('should return messaging unavailable when Google returns generic precondition check failed error', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'AUTH_GOOGLE_CLIENT_ID') return 'client-id';
- if (key === 'AUTH_GOOGLE_CLIENT_SECRET') return 'client-secret';
- if (key === 'MESSAGING_PROVIDER_GMAIL_ENABLED') return true;
- if (key === 'CALENDAR_PROVIDER_GOOGLE_ENABLED') return true;
-
- return undefined;
- });
-
- const preconditionCheckFailedError = {
- response: {
- status: 400,
- data: {
- error: {
- code: 400,
- message: 'Precondition check failed.',
- errors: [
- {
- message: 'Precondition check failed.',
- domain: 'global',
- reason: 'failedPrecondition',
- },
- ],
- status: 'FAILED_PRECONDITION',
- },
- },
- },
- };
-
- const mockGmailClient = {
- users: {
- getProfile: jest.fn().mockRejectedValue(preconditionCheckFailedError),
- },
- };
-
- const mockCalendarClient = {
- events: {
- list: jest.fn().mockResolvedValue({ data: {} }),
- },
- };
-
- (google.gmail as jest.Mock).mockReturnValue(mockGmailClient);
- (google.calendar as jest.Mock).mockReturnValue(mockCalendarClient);
-
- const result = await service.checkServicesAvailability('access-token');
-
- expect(result).toEqual({
- isMessagingAvailable: false,
- isCalendarAvailable: true,
- });
- });
-
- it('should return Calendar unavailable when Google returns generic precondition check failed error', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'AUTH_GOOGLE_CLIENT_ID') return 'client-id';
- if (key === 'AUTH_GOOGLE_CLIENT_SECRET') return 'client-secret';
- if (key === 'MESSAGING_PROVIDER_GMAIL_ENABLED') return true;
- if (key === 'CALENDAR_PROVIDER_GOOGLE_ENABLED') return true;
-
- return undefined;
- });
-
- const preconditionCheckFailedError = {
- response: {
- status: 400,
- data: {
- error: {
- code: 400,
- message: 'Precondition check failed.',
- errors: [
- {
- message: 'Precondition check failed.',
- domain: 'global',
- reason: 'failedPrecondition',
- },
- ],
- status: 'FAILED_PRECONDITION',
- },
- },
- },
- };
-
- const mockGmailClient = {
- users: {
- getProfile: jest.fn().mockResolvedValue({ data: {} }),
- },
- };
-
- const mockCalendarClient = {
- events: {
- list: jest.fn().mockRejectedValue(preconditionCheckFailedError),
- },
- };
-
- (google.gmail as jest.Mock).mockReturnValue(mockGmailClient);
- (google.calendar as jest.Mock).mockReturnValue(mockCalendarClient);
-
- const result = await service.checkServicesAvailability('access-token');
-
- expect(result).toEqual({
- isMessagingAvailable: true,
- isCalendarAvailable: false,
- });
- });
-
- it('should throw error for non-service-availability related errors', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'AUTH_GOOGLE_CLIENT_ID') return 'client-id';
- if (key === 'AUTH_GOOGLE_CLIENT_SECRET') return 'client-secret';
- if (key === 'MESSAGING_PROVIDER_GMAIL_ENABLED') return true;
- if (key === 'CALENDAR_PROVIDER_GOOGLE_ENABLED') return true;
-
- return undefined;
- });
-
- const rateLimitError = {
- response: {
- status: 429,
- data: {
- error: {
- code: 429,
- message: 'Rate Limit Exceeded',
- errors: [
- {
- message: 'Rate Limit Exceeded',
- domain: 'usageLimits',
- reason: 'rateLimitExceeded',
- },
- ],
- status: 'RESOURCE_EXHAUSTED',
- },
- },
- },
- };
-
- const mockGmailClient = {
- users: {
- getProfile: jest.fn().mockRejectedValue(rateLimitError),
- },
- };
-
- const mockCalendarClient = {
- events: {
- list: jest.fn().mockResolvedValue({ data: {} }),
- },
- };
-
- (google.gmail as jest.Mock).mockReturnValue(mockGmailClient);
- (google.calendar as jest.Mock).mockReturnValue(mockCalendarClient);
-
- await expect(
- service.checkServicesAvailability('access-token'),
- ).rejects.toMatchObject(rateLimitError);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/google-apis.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/services/google-apis.service.spec.ts
deleted file mode 100644
index dea1323fde9..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/services/google-apis.service.spec.ts
+++ /dev/null
@@ -1,374 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import {
- CalendarChannelSyncStage,
- CalendarChannelVisibility,
- ConnectedAccountProvider,
- MessageChannelVisibility,
-} from 'twenty-shared/types';
-
-import { type PlaintextString } from 'src/engine/core-modules/secret-encryption/branded-strings/plaintext-string.type';
-import { CreateCalendarChannelService } from 'src/engine/core-modules/auth/services/create-calendar-channel.service';
-import { CreateConnectedAccountService } from 'src/engine/core-modules/auth/services/create-connected-account.service';
-import { CreateMessageChannelService } from 'src/engine/core-modules/auth/services/create-message-channel.service';
-import { GoogleAPIScopesService } from 'src/engine/core-modules/auth/services/google-apis-scopes';
-import { GoogleApisServiceAvailabilityService } from 'src/engine/core-modules/auth/services/google-apis-service-availability.service';
-import { GoogleAPIsService } from 'src/engine/core-modules/auth/services/google-apis.service';
-import { UpdateConnectedAccountOnReconnectService } from 'src/engine/core-modules/auth/services/update-connected-account-on-reconnect.service';
-import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { CalendarChannelEntity } from 'src/engine/metadata-modules/calendar-channel/entities/calendar-channel.entity';
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { MessageChannelEntity } from 'src/engine/metadata-modules/message-channel/entities/message-channel.entity';
-import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { CalendarChannelSyncStatusService } from 'src/modules/calendar/common/services/calendar-channel-sync-status.service';
-import { EmailAliasManagerService } from 'src/modules/connected-account/email-alias-manager/services/email-alias-manager.service';
-import { AccountsToReconnectService } from 'src/modules/connected-account/services/accounts-to-reconnect.service';
-import { MessageChannelSyncStatusService } from 'src/modules/messaging/common/services/message-channel-sync-status.service';
-import { SyncMessageFoldersService } from 'src/modules/messaging/message-folder-manager/services/sync-message-folders.service';
-import { OnboardingRecentMessagesImportService } from 'src/modules/onboarding-recent-messages-import/services/onboarding-recent-messages-import.service';
-
-jest.mock('uuid', () => ({
- ...jest.requireActual('uuid'),
- v4: jest.fn(() => 'mocked-uuid'),
-}));
-
-describe('GoogleAPIsService', () => {
- let service: GoogleAPIsService;
- let calendarChannelSyncStatusService: CalendarChannelSyncStatusService;
- let messagingChannelSyncStatusService: MessageChannelSyncStatusService;
- let createMessageChannelService: CreateMessageChannelService;
-
- const mockConnectedAccountRepository = {
- findOne: jest.fn(),
- };
-
- const mockTransactionEntityRepository = {
- save: jest.fn(),
- update: jest.fn(),
- };
-
- const mockTransactionManager = {
- getRepository: jest.fn().mockReturnValue(mockTransactionEntityRepository),
- };
-
- const mockMessageChannelRepository = {
- find: jest.fn(),
- findOne: jest.fn().mockResolvedValue(null),
- manager: {
- transaction: jest.fn((callback) => callback(mockTransactionManager)),
- },
- };
-
- const mockCalendarChannelRepository = {
- find: jest.fn(),
- };
-
- const mockUserWorkspaceRepository = {
- findOne: jest.fn().mockResolvedValue({ id: 'user-workspace-id' }),
- };
-
- const mockWorkspaceMemberRepository = {
- findOneOrFail: jest.fn(),
- findOne: jest.fn().mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- }),
- };
-
- const mockTwentyConfigService = {
- get: jest.fn(),
- };
-
- const mockMessageQueueService = {
- add: jest.fn(),
- };
-
- const mockCalendarQueueService = {
- add: jest.fn(),
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- GoogleAPIsService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getRepository: jest
- .fn()
- .mockImplementation((_workspaceId, entity) => {
- if (entity === 'workspaceMember')
- return mockWorkspaceMemberRepository;
-
- return {};
- }),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- },
- },
- {
- provide: getRepositoryToken(ObjectMetadataEntity),
- useValue: {
- findOneOrFail: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: mockTwentyConfigService,
- },
- {
- provide: CalendarChannelSyncStatusService,
- useValue: {
- resetAndMarkAsCalendarEventListFetchPending: jest.fn(),
- },
- },
- {
- provide: GoogleAPIScopesService,
- useValue: {
- getScopesFromGoogleAccessTokenAndCheckIfExpectedScopesArePresent:
- jest.fn().mockResolvedValue({
- scopes: [],
- isValid: true,
- }),
- },
- },
- {
- provide: GoogleApisServiceAvailabilityService,
- useValue: {
- checkServicesAvailability: jest.fn().mockResolvedValue({
- isMessagingAvailable: true,
- isCalendarAvailable: true,
- }),
- },
- },
- {
- provide: MessageChannelSyncStatusService,
- useValue: {
- resetAndMarkAsMessagesListFetchPending: jest.fn(),
- },
- },
- {
- provide: CreateConnectedAccountService,
- useValue: {
- createConnectedAccount: jest.fn(),
- },
- },
- {
- provide: CreateMessageChannelService,
- useValue: {
- createMessageChannel: jest.fn(),
- },
- },
- {
- provide: CreateCalendarChannelService,
- useValue: {
- createCalendarChannel: jest.fn(),
- },
- },
- {
- provide: UpdateConnectedAccountOnReconnectService,
- useValue: {
- updateConnectedAccountOnReconnect: jest.fn(),
- },
- },
- {
- provide: AccountsToReconnectService,
- useValue: {
- removeAccountToReconnect: jest.fn(),
- },
- },
- {
- provide: getQueueToken(MessageQueue.messagingQueue),
- useValue: mockMessageQueueService,
- },
- {
- provide: getQueueToken(MessageQueue.calendarQueue),
- useValue: mockCalendarQueueService,
- },
- {
- provide: FeatureFlagService,
- useValue: {
- isFeatureEnabled: jest.fn().mockResolvedValue(false),
- },
- },
- {
- provide: SyncMessageFoldersService,
- useValue: {
- syncMessageFolders: jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: EmailAliasManagerService,
- useValue: {
- refreshHandleAliases: jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: OnboardingRecentMessagesImportService,
- useValue: {
- importRecentMessages: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: mockConnectedAccountRepository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: mockUserWorkspaceRepository,
- },
- {
- provide: getRepositoryToken(MessageChannelEntity),
- useValue: mockMessageChannelRepository,
- },
- {
- provide: getRepositoryToken(CalendarChannelEntity),
- useValue: mockCalendarChannelRepository,
- },
- ],
- }).compile();
-
- service = module.get<GoogleAPIsService>(GoogleAPIsService);
- calendarChannelSyncStatusService =
- module.get<CalendarChannelSyncStatusService>(
- CalendarChannelSyncStatusService,
- );
- messagingChannelSyncStatusService =
- module.get<MessageChannelSyncStatusService>(
- MessageChannelSyncStatusService,
- );
- createMessageChannelService = module.get<CreateMessageChannelService>(
- CreateMessageChannelService,
- );
- });
-
- describe('refreshGoogleRefreshToken', () => {
- it('should reset calendar channels with FAILED_UNKNOWN syncStatus and FAILED syncStage', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'CALENDAR_PROVIDER_GOOGLE_ENABLED') return true;
- if (key === 'MESSAGING_PROVIDER_GMAIL_ENABLED') return true;
-
- return false;
- });
-
- const existingConnectedAccount = {
- id: 'existing-account-id',
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- provider: ConnectedAccountProvider.GOOGLE,
- } as ConnectedAccountEntity;
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(
- existingConnectedAccount,
- );
-
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
-
- const failedCalendarChannel = {
- id: 'calendar-channel-id',
- connectedAccountId: 'existing-account-id',
- syncStatus: 'FAILED_UNKNOWN',
- syncStage: CalendarChannelSyncStage.FAILED,
- };
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- failedCalendarChannel,
- ]);
-
- mockMessageChannelRepository.find.mockResolvedValue([]);
-
- await service.refreshGoogleRefreshToken({
- handle: '[email protected]',
- userId: 'user-id',
- workspaceMemberId: 'workspace-member-id',
- workspaceId: 'workspace-id',
- accessToken: 'new-access-token' as PlaintextString,
- refreshToken: 'new-refresh-token' as PlaintextString,
- calendarVisibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- messageVisibility: MessageChannelVisibility.SHARE_EVERYTHING,
- });
-
- expect(
- calendarChannelSyncStatusService.resetAndMarkAsCalendarEventListFetchPending,
- ).toHaveBeenCalledWith([failedCalendarChannel.id], 'workspace-id');
-
- expect(
- messagingChannelSyncStatusService.resetAndMarkAsMessagesListFetchPending,
- ).not.toHaveBeenCalled();
-
- expect(
- createMessageChannelService.createMessageChannel,
- ).toHaveBeenCalled();
- });
-
- it('should re-enable sync on existing channels when reconnecting an archived account', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'CALENDAR_PROVIDER_GOOGLE_ENABLED') return true;
- if (key === 'MESSAGING_PROVIDER_GMAIL_ENABLED') return true;
-
- return false;
- });
-
- const archivedConnectedAccount = {
- id: 'archived-account-id',
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- provider: ConnectedAccountProvider.GOOGLE,
- archivedAt: new Date('2026-01-01'),
- } as ConnectedAccountEntity;
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(
- archivedConnectedAccount,
- );
-
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
-
- mockMessageChannelRepository.find.mockResolvedValue([
- {
- id: 'message-channel-id',
- connectedAccountId: 'archived-account-id',
- },
- ]);
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- {
- id: 'calendar-channel-id',
- connectedAccountId: 'archived-account-id',
- },
- ]);
-
- await service.refreshGoogleRefreshToken({
- handle: '[email protected]',
- userId: 'user-id',
- workspaceMemberId: 'workspace-member-id',
- workspaceId: 'workspace-id',
- accessToken: 'new-access-token' as PlaintextString,
- refreshToken: 'new-refresh-token' as PlaintextString,
- calendarVisibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- messageVisibility: MessageChannelVisibility.SHARE_EVERYTHING,
- });
-
- expect(mockTransactionEntityRepository.update).toHaveBeenCalledWith(
- {
- connectedAccountId: 'archived-account-id',
- workspaceId: 'workspace-id',
- },
- { isSyncEnabled: true },
- );
- expect(mockTransactionEntityRepository.update).toHaveBeenCalledTimes(2);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/microsoft-apis.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/services/microsoft-apis.service.spec.ts
deleted file mode 100644
index 12fd0dfbcb9..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/services/microsoft-apis.service.spec.ts
+++ /dev/null
@@ -1,353 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import {
- CalendarChannelSyncStage,
- CalendarChannelVisibility,
- ConnectedAccountProvider,
- MessageChannelVisibility,
-} from 'twenty-shared/types';
-
-import { type PlaintextString } from 'src/engine/core-modules/secret-encryption/branded-strings/plaintext-string.type';
-import { CreateCalendarChannelService } from 'src/engine/core-modules/auth/services/create-calendar-channel.service';
-import { CreateConnectedAccountService } from 'src/engine/core-modules/auth/services/create-connected-account.service';
-import { CreateMessageChannelService } from 'src/engine/core-modules/auth/services/create-message-channel.service';
-import { MicrosoftAPIsService } from 'src/engine/core-modules/auth/services/microsoft-apis.service';
-import { UpdateConnectedAccountOnReconnectService } from 'src/engine/core-modules/auth/services/update-connected-account-on-reconnect.service';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { CalendarChannelEntity } from 'src/engine/metadata-modules/calendar-channel/entities/calendar-channel.entity';
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { MessageChannelEntity } from 'src/engine/metadata-modules/message-channel/entities/message-channel.entity';
-import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { CalendarChannelSyncStatusService } from 'src/modules/calendar/common/services/calendar-channel-sync-status.service';
-import { EmailAliasManagerService } from 'src/modules/connected-account/email-alias-manager/services/email-alias-manager.service';
-import { AccountsToReconnectService } from 'src/modules/connected-account/services/accounts-to-reconnect.service';
-import { MessageChannelSyncStatusService } from 'src/modules/messaging/common/services/message-channel-sync-status.service';
-import { SyncMessageFoldersService } from 'src/modules/messaging/message-folder-manager/services/sync-message-folders.service';
-import { OnboardingRecentMessagesImportService } from 'src/modules/onboarding-recent-messages-import/services/onboarding-recent-messages-import.service';
-
-jest.mock('uuid', () => ({
- ...jest.requireActual('uuid'),
- v4: jest.fn(() => 'mocked-uuid'),
-}));
-
-describe('MicrosoftAPIsService', () => {
- let service: MicrosoftAPIsService;
- let messagingChannelSyncStatusService: MessageChannelSyncStatusService;
- let calendarChannelSyncStatusService: CalendarChannelSyncStatusService;
- let createMessageChannelService: CreateMessageChannelService;
-
- const mockConnectedAccountRepository = {
- findOne: jest.fn(),
- };
-
- const mockTransactionEntityRepository = {
- save: jest.fn(),
- update: jest.fn(),
- };
-
- const mockTransactionManager = {
- getRepository: jest.fn().mockReturnValue(mockTransactionEntityRepository),
- };
-
- const mockMessageChannelRepository = {
- find: jest.fn(),
- findOne: jest.fn().mockResolvedValue(null),
- manager: {
- transaction: jest.fn((callback) => callback(mockTransactionManager)),
- },
- };
-
- const mockCalendarChannelRepository = {
- find: jest.fn(),
- };
-
- const mockUserWorkspaceRepository = {
- findOne: jest.fn().mockResolvedValue({ id: 'user-workspace-id' }),
- };
-
- const mockWorkspaceMemberRepository = {
- findOneOrFail: jest.fn(),
- findOne: jest.fn().mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- }),
- };
-
- const mockTwentyConfigService = {
- get: jest.fn(),
- };
-
- const mockMessageQueueService = {
- add: jest.fn(),
- };
-
- const mockCalendarQueueService = {
- add: jest.fn(),
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- MicrosoftAPIsService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getRepository: jest
- .fn()
- .mockImplementation((_workspaceId, entity) => {
- if (entity === 'workspaceMember')
- return mockWorkspaceMemberRepository;
-
- return {};
- }),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- },
- },
- {
- provide: getRepositoryToken(ObjectMetadataEntity),
- useValue: {
- findOneOrFail: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: mockTwentyConfigService,
- },
- {
- provide: CalendarChannelSyncStatusService,
- useValue: {
- resetAndMarkAsCalendarEventListFetchPending: jest.fn(),
- },
- },
- {
- provide: MessageChannelSyncStatusService,
- useValue: {
- resetAndMarkAsMessagesListFetchPending: jest.fn(),
- },
- },
- {
- provide: CreateConnectedAccountService,
- useValue: {
- createConnectedAccount: jest.fn(),
- },
- },
- {
- provide: CreateMessageChannelService,
- useValue: {
- createMessageChannel: jest
- .fn()
- .mockResolvedValue('message-channel-id'),
- },
- },
- {
- provide: CreateCalendarChannelService,
- useValue: {
- createCalendarChannel: jest.fn(),
- },
- },
- {
- provide: UpdateConnectedAccountOnReconnectService,
- useValue: {
- updateConnectedAccountOnReconnect: jest.fn(),
- },
- },
- {
- provide: AccountsToReconnectService,
- useValue: {
- removeAccountToReconnect: jest.fn(),
- },
- },
- {
- provide: getQueueToken(MessageQueue.messagingQueue),
- useValue: mockMessageQueueService,
- },
- {
- provide: getQueueToken(MessageQueue.calendarQueue),
- useValue: mockCalendarQueueService,
- },
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: mockConnectedAccountRepository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: mockUserWorkspaceRepository,
- },
- {
- provide: getRepositoryToken(MessageChannelEntity),
- useValue: mockMessageChannelRepository,
- },
- {
- provide: getRepositoryToken(CalendarChannelEntity),
- useValue: mockCalendarChannelRepository,
- },
- {
- provide: SyncMessageFoldersService,
- useValue: {
- syncMessageFolders: jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: EmailAliasManagerService,
- useValue: {
- refreshHandleAliases: jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: OnboardingRecentMessagesImportService,
- useValue: {
- importRecentMessages: jest.fn().mockResolvedValue(undefined),
- },
- },
- ],
- }).compile();
-
- service = module.get<MicrosoftAPIsService>(MicrosoftAPIsService);
- calendarChannelSyncStatusService =
- module.get<CalendarChannelSyncStatusService>(
- CalendarChannelSyncStatusService,
- );
- messagingChannelSyncStatusService =
- module.get<MessageChannelSyncStatusService>(
- MessageChannelSyncStatusService,
- );
- createMessageChannelService = module.get<CreateMessageChannelService>(
- CreateMessageChannelService,
- );
- });
-
- describe('refreshMicrosoftRefreshToken', () => {
- it('should reset calendar channels and message channels', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'CALENDAR_PROVIDER_MICROSOFT_ENABLED') return true;
- if (key === 'MESSAGING_PROVIDER_MICROSOFT_ENABLED') return true;
-
- return false;
- });
-
- const existingConnectedAccount = {
- id: 'existing-account-id',
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- provider: ConnectedAccountProvider.MICROSOFT,
- } as ConnectedAccountEntity;
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(
- existingConnectedAccount,
- );
-
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
-
- const failedCalendarChannel = {
- id: 'calendar-channel-id',
- connectedAccountId: 'existing-account-id',
- syncStatus: 'FAILED_UNKNOWN',
- syncStage: CalendarChannelSyncStage.FAILED,
- };
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- failedCalendarChannel,
- ]);
-
- mockMessageChannelRepository.find.mockResolvedValue([
- {
- id: 'message-channel-id',
- connectedAccountId: 'existing-account-id',
- },
- ]);
-
- await service.refreshMicrosoftRefreshToken({
- handle: '[email protected]',
- userId: 'user-id',
- workspaceMemberId: 'workspace-member-id',
- workspaceId: 'workspace-id',
- accessToken: 'new-access-token' as PlaintextString,
- refreshToken: 'new-refresh-token' as PlaintextString,
- calendarVisibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- messageVisibility: MessageChannelVisibility.SHARE_EVERYTHING,
- });
-
- expect(
- calendarChannelSyncStatusService.resetAndMarkAsCalendarEventListFetchPending,
- ).toHaveBeenCalledWith([existingConnectedAccount.id], 'workspace-id');
-
- expect(
- messagingChannelSyncStatusService.resetAndMarkAsMessagesListFetchPending,
- ).toHaveBeenCalledWith([existingConnectedAccount.id], 'workspace-id');
-
- expect(
- createMessageChannelService.createMessageChannel,
- ).not.toHaveBeenCalled();
- });
-
- it('should re-enable sync on existing channels when reconnecting an archived account', async () => {
- mockTwentyConfigService.get.mockImplementation((key) => {
- if (key === 'CALENDAR_PROVIDER_MICROSOFT_ENABLED') return true;
- if (key === 'MESSAGING_PROVIDER_MICROSOFT_ENABLED') return true;
-
- return false;
- });
-
- const archivedConnectedAccount = {
- id: 'archived-account-id',
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- provider: ConnectedAccountProvider.MICROSOFT,
- archivedAt: new Date('2026-01-01'),
- } as ConnectedAccountEntity;
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(
- archivedConnectedAccount,
- );
-
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
-
- mockMessageChannelRepository.find.mockResolvedValue([
- {
- id: 'message-channel-id',
- connectedAccountId: 'archived-account-id',
- },
- ]);
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- {
- id: 'calendar-channel-id',
- connectedAccountId: 'archived-account-id',
- },
- ]);
-
- await service.refreshMicrosoftRefreshToken({
- handle: '[email protected]',
- userId: 'user-id',
- workspaceMemberId: 'workspace-member-id',
- workspaceId: 'workspace-id',
- accessToken: 'new-access-token' as PlaintextString,
- refreshToken: 'new-refresh-token' as PlaintextString,
- calendarVisibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- messageVisibility: MessageChannelVisibility.SHARE_EVERYTHING,
- });
-
- expect(mockTransactionEntityRepository.update).toHaveBeenCalledWith(
- {
- connectedAccountId: 'archived-account-id',
- workspaceId: 'workspace-id',
- },
- { isSyncEnabled: true },
- );
- expect(mockTransactionEntityRepository.update).toHaveBeenCalledTimes(2);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/reset-password.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/services/reset-password.service.spec.ts
deleted file mode 100644
index aaf559eb640..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/services/reset-password.service.spec.ts
+++ /dev/null
@@ -1,456 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { addMilliseconds } from 'date-fns';
-import { type EntityManager, Repository } from 'typeorm';
-
-import {
- AppTokenEntity,
- AppTokenType,
-} from 'src/engine/core-modules/app-token/app-token.entity';
-import {
- AuthException,
- AuthExceptionCode,
-} from 'src/engine/core-modules/auth/auth.exception';
-import { WorkspaceDomainsService } from 'src/engine/core-modules/domain/workspace-domains/services/workspace-domains.service';
-import { EmailService } from 'src/engine/core-modules/email/email.service';
-import { I18nService } from 'src/engine/core-modules/i18n/i18n.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserService } from 'src/engine/core-modules/user/services/user.service';
-import { type UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-import { ResetPasswordService } from './reset-password.service';
-
-// render() resolves through a streaming scheduler that never advances under the
-// globally enabled fake timers; the real render path is covered by
-// email-templates-rendering.spec.ts.
-jest.mock('twenty-emails', () => ({
- ...jest.requireActual('twenty-emails'),
- renderEmail: jest.fn().mockImplementation(async (_template, options) => {
- if (options?.plainText) {
- return 'Plain Text Email';
- }
-
- return '<html><body>HTML email content</body></html>';
- }),
-}));
-
-describe('ResetPasswordService', () => {
- let service: ResetPasswordService;
- let userService: UserService;
- let workspaceRepository: Repository<WorkspaceEntity>;
- let appTokenRepository: Repository<AppTokenEntity>;
- let emailService: EmailService;
- let twentyConfigService: TwentyConfigService;
- let workspaceDomainsService: WorkspaceDomainsService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ResetPasswordService,
- {
- provide: UserService,
- useValue: {
- findUserByEmail: jest.fn(),
- findUserByIdOrThrow: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(AppTokenEntity),
- useClass: Repository,
- },
- {
- provide: EmailService,
- useValue: {
- send: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: WorkspaceDomainsService,
- useValue: {
- buildWorkspaceURL: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: I18nService,
- useValue: {
- getI18nInstance: jest.fn().mockReturnValue({
- _: jest.fn().mockReturnValue('mocked-translation'),
- }),
- },
- },
- ],
- }).compile();
-
- service = module.get<ResetPasswordService>(ResetPasswordService);
- userService = module.get<UserService>(UserService);
- workspaceRepository = module.get<Repository<WorkspaceEntity>>(
- getRepositoryToken(WorkspaceEntity),
- );
- appTokenRepository = module.get<Repository<AppTokenEntity>>(
- getRepositoryToken(AppTokenEntity),
- );
- emailService = module.get<EmailService>(EmailService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- workspaceDomainsService = module.get<WorkspaceDomainsService>(
- WorkspaceDomainsService,
- );
- });
-
- const mockAppTokenTransaction = () => {
- const updateSpy = jest.fn().mockResolvedValue({ affected: 1 });
- const saveSpy = jest.fn().mockResolvedValue({} as AppTokenEntity);
-
- Object.defineProperty(appTokenRepository, 'manager', {
- configurable: true,
- value: {
- transaction: (
- runInTransaction: (entityManager: EntityManager) => Promise<unknown>,
- ) =>
- runInTransaction({
- getRepository: () => ({ update: updateSpy, save: saveSpy }),
- } as unknown as EntityManager),
- },
- });
-
- return { updateSpy, saveSpy };
- };
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('generatePasswordResetToken', () => {
- it('should generate a password reset token for a valid user', async () => {
- const mockUser = { id: '1', email: '[email protected]' };
-
- jest
- .spyOn(userService, 'findUserByEmail')
- .mockResolvedValue(mockUser as UserEntity);
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue({ id: 'workspace-id' } as WorkspaceEntity);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('1h');
-
- const result = await service.generatePasswordResetToken(
- 'workspace-id',
- );
-
- expect(result).toEqual(
- expect.objectContaining({
- status: 'TOKEN_GENERATED',
- resetToken: expect.objectContaining({
- passwordResetToken: expect.any(String),
- passwordResetTokenExpiresAt: expect.any(Date),
- workspaceId: 'workspace-id',
- }),
- }),
- );
- expect(workspaceRepository.findOne).toHaveBeenCalledWith(
- expect.objectContaining({
- where: expect.objectContaining({
- id: 'workspace-id',
- isPasswordAuthEnabled: true,
- }),
- }),
- );
- });
-
- it('falls back to the user own workspace when the provided workspaceId is not one they belong to', async () => {
- const mockUser = { id: '1', email: '[email protected]' };
-
- jest
- .spyOn(userService, 'findUserByEmail')
- .mockResolvedValue(mockUser as UserEntity);
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValueOnce(null)
- .mockResolvedValueOnce({
- id: 'fallback-workspace-id',
- } as WorkspaceEntity);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('1h');
-
- const result = await service.generatePasswordResetToken(
- 'foreign-workspace-id',
- );
-
- expect(result).toEqual(
- expect.objectContaining({
- status: 'TOKEN_GENERATED',
- resetToken: expect.objectContaining({
- workspaceId: 'fallback-workspace-id',
- }),
- workspace: expect.objectContaining({ id: 'fallback-workspace-id' }),
- }),
- );
- });
-
- it('should resolve workspace when workspaceId is missing', async () => {
- const mockUser = { id: '1', email: '[email protected]' };
- const mockWorkspace = { id: 'resolved-workspace-id' };
-
- jest
- .spyOn(userService, 'findUserByEmail')
- .mockResolvedValue(mockUser as UserEntity);
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace as WorkspaceEntity);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('1h');
-
- const result =
- await service.generatePasswordResetToken('[email protected]');
-
- expect(result).toEqual(
- expect.objectContaining({
- status: 'TOKEN_GENERATED',
- resetToken: expect.objectContaining({
- workspaceId: 'resolved-workspace-id',
- }),
- workspace: expect.objectContaining({ id: 'resolved-workspace-id' }),
- }),
- );
- });
-
- it('should return a status instead of sending when no password auth enabled workspace is found', async () => {
- const mockUser = { id: '1', email: '[email protected]' };
-
- jest
- .spyOn(userService, 'findUserByEmail')
- .mockResolvedValue(mockUser as UserEntity);
- jest.spyOn(workspaceRepository, 'findOne').mockResolvedValue(null);
-
- const result =
- await service.generatePasswordResetToken('[email protected]');
-
- expect(result).toEqual({
- status: 'NO_PASSWORD_AUTH_ENABLED_WORKSPACE_FOUND',
- });
- });
-
- it('should return a status instead of sending when the user is unknown', async () => {
- jest.spyOn(userService, 'findUserByEmail').mockResolvedValue(null);
-
- const result = await service.generatePasswordResetToken(
- 'workspace-id',
- );
-
- expect(result).toEqual({ status: 'USER_NOT_FOUND' });
- });
-
- it('should throw when the reset token expiration config is missing', async () => {
- const mockUser = { id: '1', email: '[email protected]' };
-
- jest
- .spyOn(userService, 'findUserByEmail')
- .mockResolvedValue(mockUser as UserEntity);
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue({ id: 'workspace-id' } as WorkspaceEntity);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(undefined);
-
- await expect(
- service.generatePasswordResetToken('[email protected]', 'workspace-id'),
- ).rejects.toMatchObject({
- code: AuthExceptionCode.INTERNAL_SERVER_ERROR,
- });
- });
- });
-
- describe('generateAndSendPasswordResetLink', () => {
- it('should rotate the token and send the email when a token is generated', async () => {
- const { updateSpy, saveSpy } = mockAppTokenTransaction();
-
- jest.spyOn(userService, 'findUserByEmail').mockResolvedValue({
- id: '1',
- email: '[email protected]',
- } as UserEntity);
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue({ id: 'workspace-id' } as WorkspaceEntity);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('1h');
- jest
- .spyOn(workspaceDomainsService, 'buildWorkspaceURL')
- .mockReturnValue(new URL('https://subdomain.localhost.com:3000/reset'));
-
- await service.generateAndSendPasswordResetLink({
- email: '[email protected]',
- workspaceId: 'workspace-id',
- locale: 'en',
- });
-
- expect(updateSpy).toHaveBeenCalled();
- expect(saveSpy).toHaveBeenCalled();
- expect(emailService.send).toHaveBeenCalled();
- });
-
- it.each(['USER_NOT_FOUND', 'NO_PASSWORD_AUTH_ENABLED_WORKSPACE_FOUND'])(
- 'should skip sending the email when generation status is %s',
- async (status) => {
- jest
- .spyOn(service, 'generatePasswordResetToken')
- .mockResolvedValue({ status } as never);
-
- await service.generateAndSendPasswordResetLink({
- email: '[email protected]',
- locale: 'en',
- });
-
- expect(emailService.send).not.toHaveBeenCalled();
- },
- );
- });
-
- describe('rotatePasswordResetToken', () => {
- const mockResetToken = {
- workspaceId: 'workspace-id',
- passwordResetToken: 'plain-token',
- passwordResetTokenExpiresAt: addMilliseconds(new Date(), 3600000),
- };
-
- it('should revoke the previous tokens and save the hashed one in a single transaction', async () => {
- const { updateSpy, saveSpy } = mockAppTokenTransaction();
-
- await service.rotatePasswordResetToken({
- userId: '1',
- resetToken: mockResetToken,
- });
-
- expect(updateSpy).toHaveBeenCalledWith(
- { userId: '1', type: AppTokenType.PasswordResetToken },
- { revokedAt: expect.any(Date) },
- );
- expect(saveSpy).toHaveBeenCalledWith({
- userId: '1',
- workspaceId: 'workspace-id',
- value: expect.any(String),
- expiresAt: mockResetToken.passwordResetTokenExpiresAt,
- type: AppTokenType.PasswordResetToken,
- });
- expect(saveSpy.mock.calls[0][0].value).not.toBe('plain-token');
- });
-
- it('should rethrow repository errors', async () => {
- const { saveSpy } = mockAppTokenTransaction();
-
- saveSpy.mockRejectedValue(new Error('db down'));
-
- await expect(
- service.rotatePasswordResetToken({
- userId: '1',
- resetToken: mockResetToken,
- }),
- ).rejects.toThrow('db down');
- });
- });
-
- describe('sendEmailPasswordResetLink', () => {
- it('should send a password reset email', async () => {
- const mockUser = { id: '1', email: '[email protected]' };
- const mockToken = {
- workspaceId: 'workspace-id',
- passwordResetToken: 'token123',
- passwordResetTokenExpiresAt: new Date(),
- };
-
- jest
- .spyOn(twentyConfigService, 'get')
- .mockReturnValue('http://localhost:3000');
- jest
- .spyOn(workspaceDomainsService, 'buildWorkspaceURL')
- .mockReturnValue(
- new URL(
- 'https://subdomain.localhost.com:3000/reset-password/passwordResetToken',
- ),
- );
-
- const result = await service.sendEmailPasswordResetLink({
- resetToken: mockToken,
- user: mockUser as UserEntity,
- workspace: { id: 'workspace-id' } as WorkspaceEntity,
- locale: 'en',
- });
-
- expect(result.success).toBe(true);
- expect(emailService.send).toHaveBeenCalled();
- });
- });
-
- describe('validatePasswordResetToken', () => {
- it('should validate a correct password reset token', async () => {
- const mockToken = {
- userId: '1',
- type: AppTokenType.PasswordResetToken,
- expiresAt: addMilliseconds(new Date(), 3600000),
- };
- const mockUser = { id: '1', email: '[email protected]' };
-
- jest
- .spyOn(appTokenRepository, 'findOne')
- .mockResolvedValue(mockToken as AppTokenEntity);
- jest
- .spyOn(userService, 'findUserByIdOrThrow')
- .mockResolvedValue(mockUser as UserEntity);
-
- const result = await service.validatePasswordResetToken('validToken');
-
- expect(result).toEqual({
- id: '1',
- email: '[email protected]',
- hasPassword: false,
- });
- });
-
- it('should throw an error for an invalid token', async () => {
- jest.spyOn(appTokenRepository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.validatePasswordResetToken('invalidToken'),
- ).rejects.toThrow(AuthException);
- });
- });
-
- describe('invalidatePasswordResetToken', () => {
- it('should invalidate an existing password reset token', async () => {
- const mockUser = { id: '1', email: '[email protected]' };
-
- jest
- .spyOn(userService, 'findUserByIdOrThrow')
- .mockResolvedValue(mockUser as UserEntity);
- jest.spyOn(appTokenRepository, 'update').mockResolvedValue({} as any);
-
- const result = await service.invalidatePasswordResetToken('1');
-
- expect(result.success).toBe(true);
- expect(appTokenRepository.update).toHaveBeenCalledWith(
- { userId: '1', type: AppTokenType.PasswordResetToken },
- { revokedAt: expect.any(Date) },
- );
- });
-
- it('should throw an error if user is not found', async () => {
- jest
- .spyOn(userService, 'findUserByIdOrThrow')
- .mockRejectedValue(
- new AuthException('User not found', AuthExceptionCode.INVALID_INPUT),
- );
-
- await expect(
- service.invalidatePasswordResetToken('nonexistent'),
- ).rejects.toThrow(AuthException);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.spec.ts
deleted file mode 100644
index ea62d3b1462..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.spec.ts
+++ /dev/null
@@ -1,389 +0,0 @@
-import { WorkspaceActivationStatus } from 'twenty-shared/workspace';
-
-import {
- AuthException,
- AuthExceptionCode,
-} from 'src/engine/core-modules/auth/auth.exception';
-import { type SignInUpNewUserPayload } from 'src/engine/core-modules/auth/types/signInUp.type';
-import { AuthProviderEnum } from 'src/engine/core-modules/workspace/types/workspace.type';
-
-import { SignInUpService } from './sign-in-up.service';
-
-const mockPartialUserPayload: SignInUpNewUserPayload = {
- email: '[email protected]',
- firstName: 'First',
- lastName: 'User',
- locale: 'en',
- isEmailAlreadyVerified: true,
-};
-
-type MockConfigurationValues = {
- IS_MULTIWORKSPACE_ENABLED: boolean;
- IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS: boolean;
- SERVER_URL: string;
-};
-
-const createSignInUpServiceForTests = () => {
- const mockUserRepository = {
- create: jest.fn((user) => user),
- save: jest.fn(async (user) => ({ id: 'saved-user-id', ...user })),
- count: jest.fn(),
- };
-
- const mockWorkspaceRepository = {
- count: jest.fn(),
- create: jest.fn((workspace) => workspace),
- };
-
- const mockConfigurationValues: MockConfigurationValues = {
- IS_MULTIWORKSPACE_ENABLED: true,
- IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS: false,
- SERVER_URL: 'http://localhost:3000',
- };
-
- const mockTwentyConfigService = {
- get: jest.fn(
- (configKey: keyof MockConfigurationValues) =>
- mockConfigurationValues[configKey],
- ),
- };
-
- const queryRunnerMock = {
- manager: {
- save: jest.fn((_entity, entity) => entity),
- update: jest.fn(),
- },
- connect: jest.fn(),
- startTransaction: jest.fn(),
- commitTransaction: jest.fn(),
- rollbackTransaction: jest.fn(),
- release: jest.fn(),
- };
-
- const mockUserWorkspaceService = {
- create: jest.fn(),
- checkUserWorkspaceExists: jest.fn(),
- addUserToWorkspaceIfUserNotInWorkspace: jest.fn(),
- };
-
- const mockOnboardingService = {
- setOnboardingConnectAccountPending: jest.fn(),
- setOnboardingCreateProfilePending: jest.fn(),
- setOnboardingInstallAppsPending: jest.fn(),
- setOnboardingInviteTeamPending: jest.fn(),
- createOnboardingStatusForWorkspaceMember: jest.fn(),
- };
-
- const service = new SignInUpService(
- mockUserRepository as any,
- mockWorkspaceRepository as any,
- {
- validatePersonalInvitation: jest.fn(),
- invalidateWorkspaceInvitation: jest.fn(),
- } as any,
- mockUserWorkspaceService as any,
- mockOnboardingService as any,
- {
- emitCustomBatchEvent: jest.fn(),
- } as any,
- mockTwentyConfigService as any,
- {
- generateSubdomain: jest.fn(),
- } as any,
- {
- findUserByEmail: jest.fn(),
- findByEmail: jest.fn(),
- markEmailAsVerified: jest.fn(),
- } as any,
- {
- incrementCounterForEvent: jest.fn(),
- } as any,
- {
- invalidateAndRecompute: jest.fn(),
- } as any,
- {
- createWorkspaceCustomApplication: jest.fn().mockResolvedValue({
- universalIdentifier: 'custom-application-universal-identifier',
- }),
- } as any,
- {
- uploadWorkspaceLogoFromUrl: jest.fn(),
- } as any,
- {
- isValid: jest.fn().mockReturnValue(false),
- } as any,
- {
- createContext: jest.fn().mockReturnValue({
- insertWorkspaceEvent: jest.fn(),
- }),
- } as any,
- {
- grantCredits: jest.fn(),
- } as any,
- {
- isBillingEnabled: jest.fn(),
- } as any,
- {
- createQueryRunner: jest.fn(() => queryRunnerMock),
- transaction: jest.fn(async (runInTransaction) =>
- runInTransaction({ queryRunner: queryRunnerMock }),
- ),
- } as any,
- );
-
- return {
- service,
- mockUserRepository,
- mockWorkspaceRepository,
- mockConfigurationValues,
- mockOnboardingService,
- };
-};
-
-describe('SignInUpService workspace-creation policy', () => {
- it('grants bootstrap owner server permissions when multi-workspace is enabled and unrestricted', async () => {
- const {
- service,
- mockUserRepository,
- mockWorkspaceRepository,
- mockConfigurationValues,
- } = createSignInUpServiceForTests();
-
- mockConfigurationValues.IS_MULTIWORKSPACE_ENABLED = true;
- mockConfigurationValues.IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS = false;
- mockWorkspaceRepository.count.mockResolvedValue(0);
- mockUserRepository.count.mockResolvedValue(0);
- jest
- .spyOn((service as any).userService, 'findUserByEmail')
- .mockResolvedValue(null);
-
- await service.signUpWithoutWorkspace(mockPartialUserPayload, {
- provider: AuthProviderEnum.Google,
- } as any);
-
- expect(mockUserRepository.create).toHaveBeenCalledWith(
- expect.objectContaining({
- canImpersonate: true,
- canAccessFullAdminPanel: true,
- }),
- );
- });
-
- it('grants bootstrap owner server permissions when multi-workspace is enabled and restricted', async () => {
- const {
- service,
- mockUserRepository,
- mockWorkspaceRepository,
- mockConfigurationValues,
- } = createSignInUpServiceForTests();
-
- mockConfigurationValues.IS_MULTIWORKSPACE_ENABLED = true;
- mockConfigurationValues.IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS = true;
- mockWorkspaceRepository.count.mockResolvedValue(0);
- mockUserRepository.count.mockResolvedValue(0);
- jest
- .spyOn((service as any).userService, 'findUserByEmail')
- .mockResolvedValue(null);
-
- await service.signUpWithoutWorkspace(mockPartialUserPayload, {
- provider: AuthProviderEnum.Google,
- } as any);
-
- expect(mockUserRepository.create).toHaveBeenCalledWith(
- expect.objectContaining({
- canImpersonate: true,
- canAccessFullAdminPanel: true,
- }),
- );
- });
-
- it('assigns default non-admin permissions after bootstrap in multi-workspace mode', async () => {
- const {
- service,
- mockUserRepository,
- mockWorkspaceRepository,
- mockConfigurationValues,
- } = createSignInUpServiceForTests();
-
- mockConfigurationValues.IS_MULTIWORKSPACE_ENABLED = true;
- mockConfigurationValues.IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS = false;
- mockWorkspaceRepository.count.mockResolvedValue(1);
- mockUserRepository.count.mockResolvedValue(1);
- jest
- .spyOn((service as any).userService, 'findUserByEmail')
- .mockResolvedValue(null);
-
- await service.signUpWithoutWorkspace(mockPartialUserPayload, {
- provider: AuthProviderEnum.Google,
- } as any);
-
- expect(mockUserRepository.create).toHaveBeenCalledWith(
- expect.objectContaining({
- canImpersonate: false,
- canAccessFullAdminPanel: false,
- }),
- );
- });
-
- it('does not grant admin to second user signing up before any workspace exists', async () => {
- const {
- service,
- mockUserRepository,
- mockWorkspaceRepository,
- mockConfigurationValues,
- } = createSignInUpServiceForTests();
-
- mockConfigurationValues.IS_MULTIWORKSPACE_ENABLED = true;
- mockConfigurationValues.IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS = false;
- mockWorkspaceRepository.count.mockResolvedValue(0);
- mockUserRepository.count.mockResolvedValue(1);
- jest
- .spyOn((service as any).userService, 'findUserByEmail')
- .mockResolvedValue(null);
-
- await service.signUpWithoutWorkspace(mockPartialUserPayload, {
- provider: AuthProviderEnum.Google,
- } as any);
-
- expect(mockUserRepository.create).toHaveBeenCalledWith(
- expect.objectContaining({
- canImpersonate: false,
- canAccessFullAdminPanel: false,
- }),
- );
- });
-
- it('throws forbidden when a non-admin existing user creates workspace in restricted mode after bootstrap', async () => {
- const { service, mockWorkspaceRepository, mockConfigurationValues } =
- createSignInUpServiceForTests();
-
- mockConfigurationValues.IS_MULTIWORKSPACE_ENABLED = true;
- mockConfigurationValues.IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS = true;
- mockWorkspaceRepository.count.mockResolvedValue(1);
-
- const nonAdminExistingUser = {
- id: 'existing-user-id',
- email: '[email protected]',
- canAccessFullAdminPanel: false,
- };
-
- await expect(
- service.signUpOnNewWorkspace({
- type: 'existingUser',
- existingUser: nonAdminExistingUser as any,
- }),
- ).rejects.toMatchObject({
- code: AuthExceptionCode.FORBIDDEN_EXCEPTION,
- });
- });
-
- it('throws SIGNUP_DISABLED when creating workspace in single-workspace mode after bootstrap', async () => {
- const { service, mockWorkspaceRepository, mockConfigurationValues } =
- createSignInUpServiceForTests();
-
- mockConfigurationValues.IS_MULTIWORKSPACE_ENABLED = false;
- mockConfigurationValues.IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS = false;
- mockWorkspaceRepository.count.mockResolvedValue(1);
-
- await expect(
- service.signUpOnNewWorkspace({
- type: 'existingUser',
- existingUser: {
- id: 'existing-user-id',
- email: '[email protected]',
- canAccessFullAdminPanel: true,
- } as any,
- }),
- ).rejects.toMatchObject({
- code: AuthExceptionCode.SIGNUP_DISABLED,
- });
- });
-
- it('keeps single-workspace SIGNUP_DISABLED behavior after first workspace exists', async () => {
- const { service, mockWorkspaceRepository, mockConfigurationValues } =
- createSignInUpServiceForTests();
-
- mockConfigurationValues.IS_MULTIWORKSPACE_ENABLED = false;
- mockConfigurationValues.IS_WORKSPACE_CREATION_LIMITED_TO_SERVER_ADMINS = false;
- mockWorkspaceRepository.count.mockResolvedValue(1);
- jest
- .spyOn((service as any).userService, 'findUserByEmail')
- .mockResolvedValue(null);
-
- await expect(
- service.signUpWithoutWorkspace(mockPartialUserPayload, {
- provider: AuthProviderEnum.Google,
- } as any),
- ).rejects.toBeInstanceOf(AuthException);
-
- await expect(
- service.signUpWithoutWorkspace(mockPartialUserPayload, {
- provider: AuthProviderEnum.Google,
- } as any),
- ).rejects.toMatchObject({
- code: AuthExceptionCode.SIGNUP_DISABLED,
- });
- });
-});
-
-describe('SignInUpService onboarding steps', () => {
- it('flags the connect-account step but not the install-apps step for a new user joining an existing workspace', async () => {
- const { service, mockOnboardingService } = createSignInUpServiceForTests();
-
- await service.signInUpOnExistingWorkspace({
- workspace: {
- id: 'existing-workspace-id',
- activationStatus: WorkspaceActivationStatus.ACTIVE,
- } as any,
- userData: {
- type: 'newUserWithPicture',
- newUserWithPicture: {
- email: '[email protected]',
- firstName: 'Invited',
- lastName: 'User',
- },
- },
- });
-
- expect(
- mockOnboardingService.setOnboardingCreateProfilePending,
- ).toHaveBeenCalledWith(expect.objectContaining({ value: true }), undefined);
- expect(
- mockOnboardingService.setOnboardingInstallAppsPending,
- ).not.toHaveBeenCalled();
- expect(
- mockOnboardingService.setOnboardingConnectAccountPending,
- ).toHaveBeenCalledWith(expect.objectContaining({ value: true }), undefined);
- });
-
- it('flags the install-apps step for a user creating a new workspace', async () => {
- const {
- service,
- mockOnboardingService,
- mockWorkspaceRepository,
- mockUserRepository,
- } = createSignInUpServiceForTests();
-
- mockWorkspaceRepository.count.mockResolvedValue(0);
- mockUserRepository.count.mockResolvedValue(0);
-
- await service.signUpOnNewWorkspace(
- {
- type: 'newUserWithPicture',
- newUserWithPicture: {
- email: '[email protected]',
- firstName: 'Creator',
- lastName: 'User',
- },
- },
- { displayName: 'Acme Inc' },
- );
-
- expect(
- mockOnboardingService.setOnboardingInstallAppsPending,
- ).toHaveBeenCalledWith(
- expect.objectContaining({ value: true }),
- expect.anything(),
- );
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/token/services/access-token.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/token/services/access-token.service.spec.ts
deleted file mode 100644
index 865d193c53d..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/token/services/access-token.service.spec.ts
+++ /dev/null
@@ -1,390 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { randomUUID } from 'crypto';
-
-import { type Request } from 'express';
-import { WorkspaceActivationStatus } from 'twenty-shared/workspace';
-import { Repository } from 'typeorm';
-
-import { AppTokenEntity } from 'src/engine/core-modules/app-token/app-token.entity';
-import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
-import { JwtAuthStrategy } from 'src/engine/core-modules/auth/strategies/jwt.auth.strategy';
-import { EmailService } from 'src/engine/core-modules/email/email.service';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserSessionService } from 'src/engine/core-modules/user-session/services/user-session.service';
-import { UserSessionCookieService } from 'src/engine/core-modules/user-session/services/user-session-cookie.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { AuthProviderEnum } from 'src/engine/core-modules/workspace/types/workspace.type';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-
-import { AccessTokenService } from './access-token.service';
-
-describe('AccessTokenService', () => {
- let service: AccessTokenService;
- let jwtWrapperService: JwtWrapperService;
- let twentyConfigService: TwentyConfigService;
- let userRepository: Repository<UserEntity>;
- let workspaceRepository: Repository<WorkspaceEntity>;
- let globalWorkspaceOrmManager: GlobalWorkspaceOrmManager;
- let userWorkspaceRepository: Repository<UserWorkspaceEntity>;
- let userSessionService: UserSessionService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AccessTokenService,
- {
- provide: JwtWrapperService,
- useValue: {
- signAsyncOrThrow: jest.fn(),
- verifyJwtToken: jest.fn(),
- decode: jest.fn(),
- generateAppSecret: jest.fn(),
- extractJwtFromRequest: jest.fn(),
- },
- },
- {
- provide: JwtAuthStrategy,
- useValue: {
- validate: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(UserEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(AppTokenEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useClass: Repository,
- },
- {
- provide: EmailService,
- useValue: {},
- },
- {
- provide: UserSessionService,
- useValue: {
- resolveSession: jest.fn(),
- },
- },
- UserSessionCookieService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getRepository: jest.fn(),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- },
- },
- ],
- }).compile();
-
- service = module.get<AccessTokenService>(AccessTokenService);
- jwtWrapperService = module.get<JwtWrapperService>(JwtWrapperService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- userRepository = module.get<Repository<UserEntity>>(
- getRepositoryToken(UserEntity),
- );
- workspaceRepository = module.get<Repository<WorkspaceEntity>>(
- getRepositoryToken(WorkspaceEntity),
- );
- globalWorkspaceOrmManager = module.get<GlobalWorkspaceOrmManager>(
- GlobalWorkspaceOrmManager,
- );
- userWorkspaceRepository = module.get<Repository<UserWorkspaceEntity>>(
- getRepositoryToken(UserWorkspaceEntity),
- );
- userSessionService = module.get<UserSessionService>(UserSessionService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('generateAccessToken', () => {
- it('should generate an access token successfully', async () => {
- const userId = randomUUID();
- const workspaceId = randomUUID();
- const mockUser = {
- id: userId,
- };
- const mockWorkspace = {
- activationStatus: WorkspaceActivationStatus.ACTIVE,
- id: workspaceId,
- };
- const mockUserWorkspace = { id: randomUUID() };
- const mockWorkspaceMember = { id: randomUUID() };
- const mockToken = 'mock-token';
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('1h');
- jest
- .spyOn(userRepository, 'findOne')
- .mockResolvedValue(mockUser as UserEntity);
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace as WorkspaceEntity);
- jest
- .spyOn(userWorkspaceRepository, 'findOne')
- .mockResolvedValue(mockUserWorkspace as UserWorkspaceEntity);
- jest.spyOn(globalWorkspaceOrmManager, 'getRepository').mockResolvedValue({
- findOne: jest.fn().mockResolvedValue(mockWorkspaceMember),
- } as any);
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
-
- const result = await service.generateAccessToken({
- userId,
- workspaceId,
- authProvider: AuthProviderEnum.Password,
- });
-
- expect(result).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- expect.objectContaining({
- sub: userId,
- workspaceId: workspaceId,
- workspaceMemberId: mockWorkspaceMember.id,
- }),
- expect.any(Object),
- );
- });
-
- it('embeds impersonation claims when provided', async () => {
- const userId = randomUUID();
- const workspaceId = randomUUID();
- const impersonatorUserWorkspaceId = randomUUID();
- const impersonatedUserWorkspaceId = randomUUID();
- const mockUser = { id: userId } as UserEntity;
- const mockWorkspace = {
- activationStatus: WorkspaceActivationStatus.ACTIVE,
- id: workspaceId,
- } as WorkspaceEntity;
- const mockUserWorkspace = {
- id: impersonatedUserWorkspaceId,
- } as UserWorkspaceEntity;
- const mockWorkspaceMember = { id: randomUUID() };
- const mockToken = 'mock-token';
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('1h');
- jest
- .spyOn(userRepository, 'findOne')
- .mockResolvedValue(mockUser as UserEntity);
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace as WorkspaceEntity);
- jest
- .spyOn(userWorkspaceRepository, 'findOne')
- .mockResolvedValueOnce(mockUserWorkspace as UserWorkspaceEntity)
- .mockResolvedValueOnce({
- id: impersonatorUserWorkspaceId,
- workspaceId,
- } as UserWorkspaceEntity)
- .mockResolvedValueOnce({
- id: impersonatedUserWorkspaceId,
- workspaceId,
- } as UserWorkspaceEntity);
- jest.spyOn(globalWorkspaceOrmManager, 'getRepository').mockResolvedValue({
- findOne: jest.fn().mockResolvedValue(mockWorkspaceMember),
- } as any);
- const signSpy = jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
-
- await service.generateAccessToken({
- userId,
- workspaceId,
- authProvider: AuthProviderEnum.Impersonation,
- isImpersonating: true,
- impersonatorUserWorkspaceId: impersonatorUserWorkspaceId,
- impersonatedUserWorkspaceId: impersonatedUserWorkspaceId,
- });
-
- expect(signSpy).toHaveBeenCalledWith(
- expect.objectContaining({
- isImpersonating: true,
- impersonatorUserWorkspaceId: impersonatorUserWorkspaceId,
- impersonatedUserWorkspaceId: impersonatedUserWorkspaceId,
- }),
- expect.any(Object),
- );
- });
-
- it('should throw an error if user is not found', async () => {
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('1h');
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue({} as WorkspaceEntity);
- jest
- .spyOn(userWorkspaceRepository, 'findOne')
- .mockResolvedValue({} as UserWorkspaceEntity);
-
- await expect(
- service.generateAccessToken({
- userId: 'non-existent-user',
- workspaceId: 'workspace-id',
- authProvider: AuthProviderEnum.Password,
- }),
- ).rejects.toThrow(AuthException);
- });
- });
-
- describe('validateToken', () => {
- it('should validate a token successfully', async () => {
- const mockToken = 'valid-token';
- const mockRequest = {
- headers: {
- authorization: `Bearer ${mockToken}`,
- },
- } as Request;
- const mockDecodedToken = { sub: 'user-id', workspaceId: 'workspace-id' };
- const mockAuthContext = {
- user: { id: 'user-id' },
- apiKey: null,
- workspace: { id: 'workspace-id' },
- workspaceMemberId: 'workspace-member-id',
- };
-
- jest
- .spyOn(jwtWrapperService, 'extractJwtFromRequest')
- .mockReturnValue(() => mockToken);
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(undefined);
- jest
- .spyOn(jwtWrapperService, 'decode')
- .mockReturnValue(mockDecodedToken as any);
- jest
- .spyOn(service['jwtStrategy'], 'validate')
- .mockReturnValue(mockAuthContext as any);
-
- const result = await service.validateTokenByRequest(mockRequest);
-
- expect(result).toEqual(mockAuthContext);
- expect(jwtWrapperService.verifyJwtToken).toHaveBeenCalledWith(mockToken);
- expect(jwtWrapperService.decode).toHaveBeenCalledWith(mockToken);
- expect(service['jwtStrategy'].validate).toHaveBeenCalledWith(
- mockDecodedToken,
- );
- });
-
- it('should throw an error if token is missing', async () => {
- const mockRequest = {
- headers: {},
- } as Request;
-
- jest
- .spyOn(jwtWrapperService, 'extractJwtFromRequest')
- .mockReturnValue(() => null);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(false);
-
- await expect(service.validateTokenByRequest(mockRequest)).rejects.toThrow(
- AuthException,
- );
- });
-
- it('should reject session tokens presented as bearer tokens', async () => {
- const mockSessionToken = 'sess_opaque-session-token';
- const mockRequest = {
- headers: {
- authorization: `Bearer ${mockSessionToken}`,
- },
- } as Request;
-
- jest
- .spyOn(jwtWrapperService, 'extractJwtFromRequest')
- .mockReturnValue(() => mockSessionToken);
-
- await expect(service.validateTokenByRequest(mockRequest)).rejects.toThrow(
- 'Session tokens are only accepted from the session cookie',
- );
- });
-
- it('should resolve the session cookie when cookie sessions are enabled', async () => {
- const mockSessionToken = 'sess_opaque-session-token';
- const mockRequest = {
- headers: {
- cookie: `twenty-session=${mockSessionToken}`,
- },
- } as Request;
- const mockPayload = {
- sub: 'user-id',
- userId: 'user-id',
- workspaceId: 'workspace-id',
- userWorkspaceId: 'user-workspace-id',
- };
- const mockAuthContext = {
- user: { id: 'user-id' },
- workspace: { id: 'workspace-id' },
- workspaceMember: { id: 'workspace-member-id' },
- };
-
- jest
- .spyOn(jwtWrapperService, 'extractJwtFromRequest')
- .mockReturnValue(() => null);
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) =>
- key === 'SERVER_URL' ? 'http://localhost:3000' : true,
- );
- jest.spyOn(userSessionService, 'resolveSession').mockResolvedValue({
- payload: mockPayload as any,
- authenticatedAt: new Date(),
- expiresAt: new Date(),
- });
- jest
- .spyOn(service['jwtStrategy'], 'validate')
- .mockResolvedValue(mockAuthContext as any);
-
- const result = await service.validateTokenByRequest(mockRequest);
-
- expect(userSessionService.resolveSession).toHaveBeenCalledWith(
- mockSessionToken,
- );
- expect(service['jwtStrategy'].validate).toHaveBeenCalledWith(mockPayload);
- expect(result.workspaceMemberId).toEqual('workspace-member-id');
- });
-
- it('should ignore the session cookie when cookie sessions are disabled', async () => {
- const mockRequest = {
- headers: {
- cookie: 'twenty-session=sess_opaque-session-token',
- },
- } as Request;
-
- jest
- .spyOn(jwtWrapperService, 'extractJwtFromRequest')
- .mockReturnValue(() => null);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(false);
- jest.spyOn(userSessionService, 'resolveSession');
-
- await expect(service.validateTokenByRequest(mockRequest)).rejects.toThrow(
- 'Missing authentication token',
- );
- expect(userSessionService.resolveSession).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/token/services/application-token.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/token/services/application-token.service.spec.ts
deleted file mode 100644
index e64c72608ec..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/token/services/application-token.service.spec.ts
+++ /dev/null
@@ -1,331 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { Repository } from 'typeorm';
-
-import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
-import { ApplicationException } from 'src/engine/core-modules/application/application.exception';
-import {
- AuthException,
- AuthExceptionCode,
-} from 'src/engine/core-modules/auth/auth.exception';
-import { ApplicationTokenService } from 'src/engine/core-modules/auth/token/services/application-token.service';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { WorkspaceException } from 'src/engine/core-modules/workspace/workspace.exception';
-
-describe('ApplicationTokenService', () => {
- let service: ApplicationTokenService;
- let jwtWrapperService: JwtWrapperService;
- let workspaceRepository: Repository<WorkspaceEntity>;
- let applicationRepository: Repository<ApplicationEntity>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplicationTokenService,
- {
- provide: JwtWrapperService,
- useValue: {
- signAsyncOrThrow: jest.fn(),
- verifyJwtToken: jest.fn(),
- decode: jest.fn(),
- extractJwtFromRequest: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(ApplicationEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useClass: Repository,
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn().mockReturnValue('1h'),
- },
- },
- ],
- }).compile();
-
- service = module.get<ApplicationTokenService>(ApplicationTokenService);
- jwtWrapperService = module.get<JwtWrapperService>(JwtWrapperService);
- applicationRepository = module.get<Repository<ApplicationEntity>>(
- getRepositoryToken(ApplicationEntity),
- );
- workspaceRepository = module.get<Repository<WorkspaceEntity>>(
- getRepositoryToken(WorkspaceEntity),
- );
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('generateApplicationAccessToken', () => {
- it('should generate an application access token successfully', async () => {
- const workspaceId = 'workspace-id';
- const applicationId = 'application-id';
- const mockWorkspace = { id: workspaceId };
- const mockApplication = { id: applicationId };
- const mockToken = 'mock-token';
-
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace as WorkspaceEntity);
- jest
- .spyOn(applicationRepository, 'findOne')
- .mockResolvedValue(mockApplication as ApplicationEntity);
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
-
- const result = await service.generateApplicationAccessToken({
- workspaceId,
- applicationId,
- });
-
- expect(result).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- expect.objectContaining({
- sub: applicationId,
- applicationId,
- }),
- expect.any(Object),
- );
- });
-
- it('should include optional userWorkspaceId and userId in payload', async () => {
- const workspaceId = 'workspace-id';
- const applicationId = 'application-id';
- const userWorkspaceId = 'user-workspace-id';
- const userId = 'user-id';
- const mockWorkspace = { id: workspaceId };
- const mockApplication = { id: applicationId };
- const mockToken = 'mock-token';
-
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace as WorkspaceEntity);
- jest
- .spyOn(applicationRepository, 'findOne')
- .mockResolvedValue(mockApplication as ApplicationEntity);
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
-
- const result = await service.generateApplicationAccessToken({
- workspaceId,
- applicationId,
- userWorkspaceId,
- userId,
- });
-
- expect(result).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- expect.objectContaining({
- sub: applicationId,
- applicationId,
- workspaceId,
- userWorkspaceId,
- userId,
- }),
- expect.any(Object),
- );
- });
- });
-
- it('should throw an error if application is not found', async () => {
- const workspaceId = 'workspace-id';
-
- const mockWorkspace = { id: workspaceId };
-
- jest.spyOn(applicationRepository, 'findOne').mockResolvedValue(null);
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace as WorkspaceEntity);
-
- await expect(
- service.generateApplicationAccessToken({
- applicationId: 'non-existent-application',
- workspaceId: 'workspace-id',
- }),
- ).rejects.toThrow(ApplicationException);
- });
-
- it('should throw an error if workspace is not found', async () => {
- jest.spyOn(workspaceRepository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.generateApplicationAccessToken({
- applicationId: 'application-id',
- workspaceId: 'non-existent-workspace',
- }),
- ).rejects.toThrow(WorkspaceException);
- });
-
- describe('validateApplicationRefreshToken', () => {
- it('should validate and return payload for a valid refresh token', async () => {
- const mockToken = 'valid-refresh-token';
- const mockPayload = {
- sub: 'application-id',
- applicationId: 'application-id',
- workspaceId: 'workspace-id',
- type: JwtTokenTypeEnum.APPLICATION_REFRESH,
- };
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(undefined);
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue(mockPayload);
-
- const result = await service.validateApplicationRefreshToken(mockToken);
-
- expect(result).toEqual(mockPayload);
- expect(jwtWrapperService.verifyJwtToken).toHaveBeenCalledWith(mockToken);
- expect(jwtWrapperService.decode).toHaveBeenCalledWith(mockToken, {
- json: true,
- });
- });
-
- it('should throw when token type is not APPLICATION_REFRESH', async () => {
- const mockToken = 'access-token';
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(undefined);
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue({
- sub: 'application-id',
- applicationId: 'application-id',
- workspaceId: 'workspace-id',
- type: JwtTokenTypeEnum.APPLICATION_ACCESS,
- });
-
- await expect(
- service.validateApplicationRefreshToken(mockToken),
- ).rejects.toThrow(AuthException);
-
- try {
- await service.validateApplicationRefreshToken(mockToken);
- } catch (error) {
- expect((error as AuthException).code).toBe(
- AuthExceptionCode.APPLICATION_REFRESH_TOKEN_INVALID_OR_EXPIRED,
- );
- }
- });
-
- it('should throw dedicated code when token verification fails', async () => {
- const mockToken = 'invalid-token';
-
- jest.spyOn(jwtWrapperService, 'verifyJwtToken').mockImplementation(() => {
- throw new AuthException(
- 'Token has expired.',
- AuthExceptionCode.UNAUTHENTICATED,
- );
- });
-
- await expect(
- service.validateApplicationRefreshToken(mockToken),
- ).rejects.toThrow(AuthException);
-
- try {
- await service.validateApplicationRefreshToken(mockToken);
- } catch (error) {
- expect((error as AuthException).code).toBe(
- AuthExceptionCode.APPLICATION_REFRESH_TOKEN_INVALID_OR_EXPIRED,
- );
- }
- });
-
- it('should rethrow unexpected token verification errors', async () => {
- const mockToken = 'invalid-token';
-
- jest.spyOn(jwtWrapperService, 'verifyJwtToken').mockImplementation(() => {
- throw new Error('Unexpected verification error');
- });
-
- await expect(
- service.validateApplicationRefreshToken(mockToken),
- ).rejects.toThrow('Unexpected verification error');
- });
- });
-
- describe('generateApplicationTokenPair', () => {
- it('should generate both access and refresh tokens', async () => {
- const workspaceId = 'workspace-id';
- const applicationId = 'application-id';
- const mockWorkspace = { id: workspaceId };
- const mockApplication = { id: applicationId };
- const mockToken = 'mock-token';
-
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace as WorkspaceEntity);
- jest
- .spyOn(applicationRepository, 'findOne')
- .mockResolvedValue(mockApplication as ApplicationEntity);
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
-
- const result = await service.generateApplicationTokenPair({
- workspaceId,
- applicationId,
- });
-
- expect(result.applicationAccessToken).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(result.applicationRefreshToken).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledTimes(2);
- });
- });
-
- describe('renewApplicationTokens', () => {
- it('should generate a new token pair from validated payload', async () => {
- const workspaceId = 'workspace-id';
- const applicationId = 'application-id';
- const mockWorkspace = { id: workspaceId };
- const mockApplication = { id: applicationId };
- const mockToken = 'mock-token';
-
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace as WorkspaceEntity);
- jest
- .spyOn(applicationRepository, 'findOne')
- .mockResolvedValue(mockApplication as ApplicationEntity);
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
-
- const result = await service.renewApplicationTokens({
- workspaceId,
- applicationId,
- });
-
- expect(result.applicationAccessToken).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(result.applicationRefreshToken).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/token/services/email-verification-token.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/token/services/email-verification-token.service.spec.ts
deleted file mode 100644
index 2c5a361c10f..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/token/services/email-verification-token.service.spec.ts
+++ /dev/null
@@ -1,276 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import crypto from 'crypto';
-
-import { Repository } from 'typeorm';
-
-import {
- AppTokenEntity,
- AppTokenType,
-} from 'src/engine/core-modules/app-token/app-token.entity';
-import {
- EmailVerificationException,
- EmailVerificationExceptionCode,
-} from 'src/engine/core-modules/email-verification/email-verification.exception';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-
-import { EmailVerificationTokenService } from './email-verification-token.service';
-
-describe('EmailVerificationTokenService', () => {
- let service: EmailVerificationTokenService;
- let appTokenRepository: Repository<AppTokenEntity>;
- let userRepository: Repository<UserEntity>;
- let twentyConfigService: TwentyConfigService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- EmailVerificationTokenService,
- {
- provide: getRepositoryToken(AppTokenEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(UserEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<EmailVerificationTokenService>(
- EmailVerificationTokenService,
- );
- appTokenRepository = module.get<Repository<AppTokenEntity>>(
- getRepositoryToken(AppTokenEntity),
- );
- userRepository = module.get<Repository<UserEntity>>(
- getRepositoryToken(UserEntity),
- );
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- });
-
- describe('generateToken', () => {
- it('should generate a verification token successfully', async () => {
- const userId = 'test-user-id';
- const email = '[email protected]';
- const mockExpiresIn = '24h';
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(mockExpiresIn);
- jest
- .spyOn(appTokenRepository, 'create')
- .mockReturnValue({} as AppTokenEntity);
- jest
- .spyOn(appTokenRepository, 'save')
- .mockResolvedValue({} as AppTokenEntity);
-
- const result = await service.generateToken(userId, email);
-
- expect(result).toHaveProperty('token');
- expect(result).toHaveProperty('expiresAt');
- expect(result.token).toHaveLength(64); // 32 bytes in hex = 64 characters
- expect(appTokenRepository.create).toHaveBeenCalledWith(
- expect.objectContaining({
- userId,
- type: AppTokenType.EmailVerificationToken,
- context: { email },
- }),
- );
- expect(appTokenRepository.save).toHaveBeenCalled();
- });
- });
-
- describe('validateEmailVerificationTokenOrThrow', () => {
- it('should validate token successfully and return user', async () => {
- const plainToken = 'plain-token';
- const hashedToken = crypto
- .createHash('sha256')
- .update(plainToken)
- .digest('hex');
- const mockUser = { id: 'user-id', email: '[email protected]' };
- const mockAppToken = {
- type: AppTokenType.EmailVerificationToken,
- expiresAt: new Date(Date.now() + 86400000), // 24h from now
- context: { email: '[email protected]' },
- user: mockUser,
- };
-
- jest
- .spyOn(appTokenRepository, 'findOne')
- .mockResolvedValue(mockAppToken as AppTokenEntity);
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
-
- const result = await service.validateEmailVerificationTokenOrThrow({
- emailVerificationToken: plainToken,
- email: '[email protected]',
- });
-
- expect(result).toEqual(mockAppToken);
- expect(appTokenRepository.findOne).toHaveBeenCalledWith({
- where: {
- value: hashedToken,
- type: AppTokenType.EmailVerificationToken,
- },
- relations: ['user'],
- });
- });
-
- it('should throw exception for invalid token', async () => {
- jest.spyOn(appTokenRepository, 'findOne').mockResolvedValue(null);
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.validateEmailVerificationTokenOrThrow({
- emailVerificationToken: 'invalid-token',
- email: '[email protected]',
- }),
- ).rejects.toThrow(
- new EmailVerificationException(
- 'Invalid email verification token',
- EmailVerificationExceptionCode.INVALID_TOKEN,
- ),
- );
- });
-
- it('should throw exception for already validated token', async () => {
- const mockUser = {
- id: 'user-id',
- email: '[email protected]',
- isEmailVerified: true,
- };
-
- jest.spyOn(appTokenRepository, 'findOne').mockResolvedValue(null);
- jest
- .spyOn(userRepository, 'findOne')
- .mockResolvedValue(mockUser as UserEntity);
-
- await expect(
- service.validateEmailVerificationTokenOrThrow({
- emailVerificationToken: 'invalid-token',
- email: '[email protected]',
- }),
- ).rejects.toThrow(
- new EmailVerificationException(
- 'Email already verified',
- EmailVerificationExceptionCode.EMAIL_ALREADY_VERIFIED,
- ),
- );
- });
-
- it('should throw exception when email does not match appToken email', async () => {
- const mockUser = {
- id: 'user-id',
- email: '[email protected]',
- isEmailVerified: false,
- };
-
- const mockAppToken = {
- type: AppTokenType.EmailVerificationToken,
- expiresAt: new Date(Date.now() + 86400000), // 24h from now
- context: { email: '[email protected]' },
- user: {
- email: '[email protected]',
- },
- };
-
- jest
- .spyOn(appTokenRepository, 'findOne')
- .mockResolvedValue(mockAppToken as AppTokenEntity);
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.validateEmailVerificationTokenOrThrow({
- emailVerificationToken: 'valid-token',
- email: mockUser.email,
- }),
- ).rejects.toThrow(
- new EmailVerificationException(
- 'Email does not match token',
- EmailVerificationExceptionCode.INVALID_EMAIL,
- ),
- );
- });
-
- it('should throw exception for wrong token type', async () => {
- const mockAppToken = {
- type: AppTokenType.PasswordResetToken,
- expiresAt: new Date(Date.now() + 86400000),
- };
-
- jest
- .spyOn(appTokenRepository, 'findOne')
- .mockResolvedValue(mockAppToken as AppTokenEntity);
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.validateEmailVerificationTokenOrThrow({
- emailVerificationToken: 'wrong-type-token',
- email: '[email protected]',
- }),
- ).rejects.toThrow(
- new EmailVerificationException(
- 'Invalid email verification token type',
- EmailVerificationExceptionCode.INVALID_APP_TOKEN_TYPE,
- ),
- );
- });
-
- it('should throw exception for expired token', async () => {
- const mockAppToken = {
- type: AppTokenType.EmailVerificationToken,
- expiresAt: new Date(Date.now() - 86400000), // 24h ago
- };
-
- jest
- .spyOn(appTokenRepository, 'findOne')
- .mockResolvedValue(mockAppToken as AppTokenEntity);
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.validateEmailVerificationTokenOrThrow({
- emailVerificationToken: 'expired-token',
- email: '[email protected]',
- }),
- ).rejects.toThrow(
- new EmailVerificationException(
- 'Email verification token expired',
- EmailVerificationExceptionCode.TOKEN_EXPIRED,
- ),
- );
- });
-
- it('should throw exception when email is missing in context', async () => {
- const mockAppToken = {
- type: AppTokenType.EmailVerificationToken,
- expiresAt: new Date(Date.now() + 86400000),
- context: {},
- };
-
- jest
- .spyOn(appTokenRepository, 'findOne')
- .mockResolvedValue(mockAppToken as AppTokenEntity);
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.validateEmailVerificationTokenOrThrow({
- emailVerificationToken: 'valid-token',
- email: '[email protected]',
- }),
- ).rejects.toThrow(
- new EmailVerificationException(
- 'Email missing in email verification token context',
- EmailVerificationExceptionCode.EMAIL_MISSING,
- ),
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/token/services/login-token.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/token/services/login-token.service.spec.ts
deleted file mode 100644
index 3c8f3e0522e..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/token/services/login-token.service.spec.ts
+++ /dev/null
@@ -1,154 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { AuthProviderEnum } from 'src/engine/core-modules/workspace/types/workspace.type';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-
-import { LoginTokenService } from './login-token.service';
-
-describe('LoginTokenService', () => {
- let service: LoginTokenService;
- let jwtWrapperService: JwtWrapperService;
- let twentyConfigService: TwentyConfigService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- LoginTokenService,
- {
- provide: JwtWrapperService,
- useValue: {
- signAsyncOrThrow: jest.fn(),
- verifyJwtToken: jest.fn(),
- decode: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<LoginTokenService>(LoginTokenService);
- jwtWrapperService = module.get<JwtWrapperService>(JwtWrapperService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('generateLoginToken', () => {
- it('should generate a login token successfully', async () => {
- const email = '[email protected]';
- const mockExpiresIn = '1h';
- const mockToken = 'mock-token';
- const workspaceId = 'workspace-id';
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(mockExpiresIn);
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
-
- const result = await service.generateLoginToken(
- email,
- workspaceId,
- AuthProviderEnum.Password,
- );
-
- expect(result).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(twentyConfigService.get).toHaveBeenCalledWith(
- 'LOGIN_TOKEN_EXPIRES_IN',
- );
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- {
- sub: email,
- workspaceId,
- type: JwtTokenTypeEnum.LOGIN,
- authProvider: AuthProviderEnum.Password,
- impersonatorUserWorkspaceId: undefined,
- },
- { expiresIn: mockExpiresIn },
- );
- });
- });
-
- describe('generateLoginToken with impersonation', () => {
- it('should include impersonatorUserWorkspaceId in JWT payload when using Impersonation auth provider', async () => {
- const email = '[email protected]';
- const mockToken = 'mock-token';
- const workspaceId = 'workspace-id';
- const impersonatorUserWorkspaceId = 'impersonator-id';
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('1h');
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
-
- const result = await service.generateLoginToken(
- email,
- workspaceId,
- AuthProviderEnum.Impersonation,
- { impersonatorUserWorkspaceId },
- );
-
- expect(result).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- {
- sub: email,
- workspaceId,
- type: JwtTokenTypeEnum.LOGIN,
- authProvider: AuthProviderEnum.Impersonation,
- impersonatorUserWorkspaceId,
- },
- { expiresIn: expect.any(String) },
- );
- });
- });
-
- describe('verifyLoginToken', () => {
- it('should verify a login token successfully', async () => {
- const mockToken = 'valid-token';
- const mockEmail = '[email protected]';
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(undefined);
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue({
- sub: mockEmail,
- type: JwtTokenTypeEnum.LOGIN,
- });
-
- const result = await service.verifyLoginToken(mockToken);
-
- expect(result).toEqual({
- sub: mockEmail,
- type: JwtTokenTypeEnum.LOGIN,
- });
- expect(jwtWrapperService.verifyJwtToken).toHaveBeenCalledWith(mockToken);
- expect(jwtWrapperService.decode).toHaveBeenCalledWith(mockToken, {
- json: true,
- });
- });
-
- it('should throw an error if token verification fails', async () => {
- const mockToken = 'invalid-token';
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockRejectedValue(new Error('Invalid token'));
-
- await expect(service.verifyLoginToken(mockToken)).rejects.toThrow();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/token/services/refresh-token.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/token/services/refresh-token.service.spec.ts
deleted file mode 100644
index f43c27dd840..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/token/services/refresh-token.service.spec.ts
+++ /dev/null
@@ -1,223 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { Repository } from 'typeorm';
-
-import {
- AppTokenEntity,
- AppTokenType,
-} from 'src/engine/core-modules/app-token/app-token.entity';
-import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-
-import { RefreshTokenService } from './refresh-token.service';
-
-describe('RefreshTokenService', () => {
- let service: RefreshTokenService;
- let jwtWrapperService: JwtWrapperService;
- let twentyConfigService: TwentyConfigService;
- let appTokenRepository: Repository<AppTokenEntity>;
- let userRepository: Repository<UserEntity>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- RefreshTokenService,
- {
- provide: JwtWrapperService,
- useValue: {
- verifyJwtToken: jest.fn(),
- decode: jest.fn(),
- signAsyncOrThrow: jest.fn(),
- generateAppSecret: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(AppTokenEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(UserEntity),
- useClass: Repository,
- },
- ],
- }).compile();
-
- service = module.get<RefreshTokenService>(RefreshTokenService);
- jwtWrapperService = module.get<JwtWrapperService>(JwtWrapperService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- appTokenRepository = module.get<Repository<AppTokenEntity>>(
- getRepositoryToken(AppTokenEntity),
- );
- userRepository = module.get<Repository<UserEntity>>(
- getRepositoryToken(UserEntity),
- );
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('verifyRefreshToken', () => {
- it('should verify a refresh token successfully', async () => {
- const mockToken = 'valid-refresh-token';
- const mockJwtPayload = {
- jti: 'token-id',
- sub: 'user-id',
- type: JwtTokenTypeEnum.REFRESH,
- };
- const mockAppToken = {
- id: 'token-id',
- workspaceId: 'workspace-id',
- revokedAt: null,
- } as AppTokenEntity;
- const mockUser = {
- id: 'some-id',
- firstName: 'John',
- lastName: 'Doe',
- email: '[email protected]',
- } as UserEntity;
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(undefined);
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue(mockJwtPayload);
- jest
- .spyOn(appTokenRepository, 'findOneBy')
- .mockResolvedValue(mockAppToken);
- jest.spyOn(userRepository, 'findOneBy').mockResolvedValue(mockUser);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('1h');
-
- const result = await service.verifyRefreshToken(mockToken);
-
- expect(result).toEqual({ user: mockUser, token: mockAppToken });
- expect(jwtWrapperService.verifyJwtToken).toHaveBeenCalledWith(mockToken);
- });
-
- it('should throw an error if the token is malformed', async () => {
- const mockToken = 'invalid-token';
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(undefined);
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue({});
-
- await expect(service.verifyRefreshToken(mockToken)).rejects.toThrow(
- AuthException,
- );
- });
- });
-
- describe('generateRefreshToken', () => {
- it('should generate a refresh token successfully', async () => {
- const userId = 'user-id';
- const workspaceId = 'workspace-id';
- const mockToken = 'mock-refresh-token';
- const mockExpiresIn = '7d';
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(mockExpiresIn);
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
- jest
- .spyOn(appTokenRepository, 'create')
- .mockReturnValue({ id: 'new-token-id' } as AppTokenEntity);
- jest
- .spyOn(appTokenRepository, 'save')
- .mockResolvedValue({ id: 'new-token-id' } as AppTokenEntity);
-
- const result = await service.generateRefreshToken({
- userId,
- workspaceId,
- targetedTokenType: JwtTokenTypeEnum.ACCESS,
- });
-
- expect(result).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(appTokenRepository.save).toHaveBeenCalled();
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- {
- sub: userId,
- workspaceId,
- type: JwtTokenTypeEnum.REFRESH,
- userId: 'user-id',
- targetedTokenType: JwtTokenTypeEnum.ACCESS,
- },
- expect.objectContaining({
- expiresIn: mockExpiresIn,
- jwtid: 'new-token-id',
- }),
- );
- });
-
- it('should throw an error if expiration time is not set', async () => {
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(undefined);
-
- await expect(
- service.generateRefreshToken({
- userId: 'user-id',
- workspaceId: 'workspace-id',
- targetedTokenType: JwtTokenTypeEnum.ACCESS,
- }),
- ).rejects.toThrow(AuthException);
- });
- });
-
- it('returns impersonation claims from verified refresh token', async () => {
- const refreshToken = 'rtok';
- const userId = 'user-id';
- const tokenId = 'token-id';
-
- (jwtWrapperService.verifyJwtToken as jest.Mock).mockResolvedValue(
- undefined,
- );
- (jwtWrapperService.decode as jest.Mock).mockReturnValue({
- sub: userId,
- jti: tokenId,
- type: JwtTokenTypeEnum.REFRESH,
- targetedTokenType: JwtTokenTypeEnum.ACCESS,
- isImpersonating: true,
- impersonatorUserWorkspaceId: 'uw-imp',
- impersonatedUserWorkspaceId: 'uw-orig',
- });
-
- const token = {
- id: tokenId,
- type: AppTokenType.RefreshToken,
- } as AppTokenEntity;
-
- jest.spyOn(appTokenRepository, 'findOneBy').mockResolvedValue(token);
-
- const user = { id: userId } as UserEntity;
-
- jest.spyOn(userRepository, 'findOneBy').mockResolvedValue(user);
-
- const out = await service.verifyRefreshToken(refreshToken);
-
- expect(out.isImpersonating).toBe(true);
- expect(out.impersonatorUserWorkspaceId).toBe('uw-imp');
- expect(out.impersonatedUserWorkspaceId).toBe('uw-orig');
- });
-
- it('throws on malformed refresh token', async () => {
- (jwtWrapperService.verifyJwtToken as jest.Mock).mockResolvedValue(
- undefined,
- );
- (jwtWrapperService.decode as jest.Mock).mockReturnValue({});
-
- await expect(service.verifyRefreshToken('rtok')).rejects.toThrow(
- AuthException,
- );
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/token/services/renew-token.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/token/services/renew-token.service.spec.ts
deleted file mode 100644
index 2ff1f2ad3de..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/token/services/renew-token.service.spec.ts
+++ /dev/null
@@ -1,193 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { IsNull, Repository } from 'typeorm';
-
-import { AppTokenEntity } from 'src/engine/core-modules/app-token/app-token.entity';
-import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
-import { AccessTokenService } from 'src/engine/core-modules/auth/token/services/access-token.service';
-import { RefreshTokenService } from 'src/engine/core-modules/auth/token/services/refresh-token.service';
-import { WorkspaceAgnosticTokenService } from 'src/engine/core-modules/auth/token/services/workspace-agnostic-token.service';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-import { type UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { AuthProviderEnum } from 'src/engine/core-modules/workspace/types/workspace.type';
-
-import { RenewTokenService } from './renew-token.service';
-
-describe('RenewTokenService', () => {
- let service: RenewTokenService;
- let appTokenRepository: Repository<AppTokenEntity>;
- let accessTokenService: AccessTokenService;
- let refreshTokenService: RefreshTokenService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- RenewTokenService,
- {
- provide: getRepositoryToken(AppTokenEntity),
- useClass: Repository,
- },
- {
- provide: AccessTokenService,
- useValue: {
- generateAccessToken: jest.fn(),
- },
- },
- {
- provide: WorkspaceAgnosticTokenService,
- useValue: {
- generateWorkspaceAgnosticToken: jest.fn(),
- },
- },
- {
- provide: RefreshTokenService,
- useValue: {
- verifyRefreshToken: jest.fn(),
- generateRefreshToken: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<RenewTokenService>(RenewTokenService);
- appTokenRepository = module.get<Repository<AppTokenEntity>>(
- getRepositoryToken(AppTokenEntity),
- );
- accessTokenService = module.get<AccessTokenService>(AccessTokenService);
- refreshTokenService = module.get<RefreshTokenService>(RefreshTokenService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('generateTokensFromRefreshToken', () => {
- it('should generate new access and refresh tokens', async () => {
- const mockRefreshToken = 'valid-refresh-token';
- const mockUser = { id: 'user-id' } as UserEntity;
- const mockWorkspaceId = 'workspace-id';
- const mockTokenId = 'token-id';
- const mockAccessToken = {
- token: 'new-access-token',
- expiresAt: new Date(),
- };
- const mockNewRefreshToken = {
- token: 'new-refresh-token',
- expiresAt: new Date(),
- targetedTokenType: JwtTokenTypeEnum.ACCESS,
- };
- const mockAppToken: Partial<AppTokenEntity> = {
- id: mockTokenId,
- workspaceId: mockWorkspaceId,
- } as AppTokenEntity;
-
- jest.spyOn(refreshTokenService, 'verifyRefreshToken').mockResolvedValue({
- user: mockUser,
- token: mockAppToken as AppTokenEntity,
- authProvider: AuthProviderEnum.Password,
- targetedTokenType: JwtTokenTypeEnum.ACCESS,
- isImpersonating: false,
- impersonatorUserWorkspaceId: undefined,
- impersonatedUserWorkspaceId: undefined,
- });
- jest.spyOn(appTokenRepository, 'update').mockResolvedValue({} as any);
- jest
- .spyOn(accessTokenService, 'generateAccessToken')
- .mockResolvedValue(mockAccessToken);
- jest
- .spyOn(refreshTokenService, 'generateRefreshToken')
- .mockResolvedValue(mockNewRefreshToken);
-
- const result =
- await service.generateTokensFromRefreshToken(mockRefreshToken);
-
- expect(result).toEqual({
- accessOrWorkspaceAgnosticToken: mockAccessToken,
- refreshToken: mockNewRefreshToken,
- });
- expect(refreshTokenService.verifyRefreshToken).toHaveBeenCalledWith(
- mockRefreshToken,
- );
- expect(appTokenRepository.update).toHaveBeenCalledWith(
- { id: mockTokenId, revokedAt: IsNull() },
- { revokedAt: expect.any(Date) },
- );
- expect(accessTokenService.generateAccessToken).toHaveBeenCalledWith(
- expect.objectContaining({
- userId: mockUser.id,
- workspaceId: mockWorkspaceId,
- authProvider: AuthProviderEnum.Password,
- }),
- );
- expect(refreshTokenService.generateRefreshToken).toHaveBeenCalledWith(
- expect.objectContaining({
- authProvider: AuthProviderEnum.Password,
- targetedTokenType: JwtTokenTypeEnum.ACCESS,
- userId: mockUser.id,
- workspaceId: mockWorkspaceId,
- }),
- );
- });
-
- it('should propagate impersonation claims when present', async () => {
- const mockRefreshToken = 'valid-refresh-token';
- const mockUser = { id: 'user-id' } as UserEntity;
- const mockWorkspaceId = 'workspace-id';
- const mockTokenId = 'token-id';
- const mockAccessToken = {
- token: 'new-access-token',
- expiresAt: new Date(),
- };
- const mockNewRefreshToken = {
- token: 'new-refresh-token',
- expiresAt: new Date(),
- targetedTokenType: JwtTokenTypeEnum.ACCESS,
- };
- const mockAppToken = {
- id: mockTokenId,
- workspaceId: mockWorkspaceId,
- } as AppTokenEntity;
-
- jest.spyOn(refreshTokenService, 'verifyRefreshToken').mockResolvedValue({
- user: mockUser,
- token: mockAppToken as AppTokenEntity,
- authProvider: AuthProviderEnum.Password,
- targetedTokenType: JwtTokenTypeEnum.ACCESS,
- isImpersonating: true,
- impersonatorUserWorkspaceId: 'uw-imp',
- impersonatedUserWorkspaceId: 'uw-orig',
- });
- jest.spyOn(appTokenRepository, 'update').mockResolvedValue({} as any);
- const accessSpy = jest
- .spyOn(accessTokenService, 'generateAccessToken')
- .mockResolvedValue(mockAccessToken);
- const refreshSpy = jest
- .spyOn(refreshTokenService, 'generateRefreshToken')
- .mockResolvedValue(mockNewRefreshToken);
-
- await service.generateTokensFromRefreshToken(mockRefreshToken);
-
- expect(accessSpy).toHaveBeenCalledWith(
- expect.objectContaining({
- isImpersonating: true,
- impersonatorUserWorkspaceId: 'uw-imp',
- impersonatedUserWorkspaceId: 'uw-orig',
- }),
- );
- expect(refreshSpy).toHaveBeenCalledWith(
- expect.objectContaining({
- isImpersonating: true,
- impersonatorUserWorkspaceId: 'uw-imp',
- impersonatedUserWorkspaceId: 'uw-orig',
- }),
- );
- });
-
- it('should throw an error if refresh token is not provided', async () => {
- await expect(service.generateTokensFromRefreshToken('')).rejects.toThrow(
- AuthException,
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/token/services/sso-exchange-token.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/token/services/sso-exchange-token.service.spec.ts
deleted file mode 100644
index 3a6f40a25c2..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/token/services/sso-exchange-token.service.spec.ts
+++ /dev/null
@@ -1,185 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import crypto from 'crypto';
-
-import { IsNull, Repository } from 'typeorm';
-
-import {
- AppTokenEntity,
- AppTokenType,
-} from 'src/engine/core-modules/app-token/app-token.entity';
-import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { AuthProviderEnum } from 'src/engine/core-modules/workspace/types/workspace.type';
-
-import { SSOExchangeTokenService } from './sso-exchange-token.service';
-
-const USER_ID = '20202020-9e3b-46d4-a556-88b9ddc2b034';
-
-const sha256 = (value: string) =>
- crypto.createHash('sha256').update(value).digest('hex');
-
-describe('SSOExchangeTokenService', () => {
- let service: SSOExchangeTokenService;
- let twentyConfigService: TwentyConfigService;
- let appTokenRepository: Repository<AppTokenEntity>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- SSOExchangeTokenService,
- {
- provide: TwentyConfigService,
- useValue: { get: jest.fn().mockReturnValue('5m') },
- },
- {
- provide: getRepositoryToken(AppTokenEntity),
- useClass: Repository,
- },
- ],
- }).compile();
-
- service = module.get<SSOExchangeTokenService>(SSOExchangeTokenService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- appTokenRepository = module.get<Repository<AppTokenEntity>>(
- getRepositoryToken(AppTokenEntity),
- );
-
- jest
- .spyOn(appTokenRepository, 'create')
- .mockImplementation((entity) => entity as AppTokenEntity);
- jest
- .spyOn(appTokenRepository, 'save')
- .mockImplementation(async (entity) => entity as AppTokenEntity);
- });
-
- describe('generateSSOExchangeToken', () => {
- it('should persist only the hash of the token, never the plaintext', async () => {
- const { token } = await service.generateSSOExchangeToken({
- userId: USER_ID,
- authProvider: AuthProviderEnum.Google,
- });
-
- const savedToken = jest.mocked(appTokenRepository.save).mock
- .calls[0][0] as AppTokenEntity;
-
- expect(savedToken.value).toBe(sha256(token));
- expect(savedToken.value).not.toBe(token);
- expect(savedToken.type).toBe(AppTokenType.SSOExchangeToken);
- expect(savedToken.userId).toBe(USER_ID);
- expect(savedToken.context).toEqual({
- authProvider: AuthProviderEnum.Google,
- });
- });
-
- it('should use the short term token expiration', async () => {
- await service.generateSSOExchangeToken({
- userId: USER_ID,
- authProvider: AuthProviderEnum.Microsoft,
- });
-
- expect(twentyConfigService.get).toHaveBeenCalledWith(
- 'SHORT_TERM_TOKEN_EXPIRES_IN',
- );
- });
-
- it('should generate a different token on every call', async () => {
- const first = await service.generateSSOExchangeToken({
- userId: USER_ID,
- authProvider: AuthProviderEnum.Google,
- });
- const second = await service.generateSSOExchangeToken({
- userId: USER_ID,
- authProvider: AuthProviderEnum.Google,
- });
-
- expect(first.token).not.toBe(second.token);
- });
- });
-
- describe('validateAndConsumeSSOExchangeTokenOrThrow', () => {
- const buildAppToken = (): AppTokenEntity =>
- ({
- id: 'app-token-id',
- userId: USER_ID,
- type: AppTokenType.SSOExchangeToken,
- value: sha256('plain-token'),
- expiresAt: new Date(Date.now() + 60_000),
- context: { authProvider: AuthProviderEnum.Google },
- }) as AppTokenEntity;
-
- const mockLookup = (appToken: AppTokenEntity | null) => {
- jest
- .spyOn(appTokenRepository, 'findOneBy')
- .mockResolvedValue(appToken as never);
- };
-
- const mockClaim = (affected: number) => {
- jest
- .spyOn(appTokenRepository, 'delete')
- .mockResolvedValue({ affected, raw: [] } as never);
- };
-
- it('should return the user and auth provider of the claimed token', async () => {
- mockLookup(buildAppToken());
- mockClaim(1);
-
- const result =
- await service.validateAndConsumeSSOExchangeTokenOrThrow('plain-token');
-
- expect(result).toEqual({
- userId: USER_ID,
- authProvider: AuthProviderEnum.Google,
- });
- expect(appTokenRepository.delete).toHaveBeenCalledWith({
- id: 'app-token-id',
- revokedAt: IsNull(),
- deletedAt: IsNull(),
- });
- });
-
- it('should throw when the token cannot be found', async () => {
- mockLookup(null);
-
- await expect(
- service.validateAndConsumeSSOExchangeTokenOrThrow('plain-token'),
- ).rejects.toThrow(AuthException);
- });
-
- it('should throw when the delete does not claim the row', async () => {
- mockLookup(buildAppToken());
- mockClaim(0);
-
- await expect(
- service.validateAndConsumeSSOExchangeTokenOrThrow('plain-token'),
- ).rejects.toThrow(AuthException);
- });
-
- it('should throw when the claimed token has expired', async () => {
- const expiredToken = buildAppToken();
-
- expiredToken.expiresAt = new Date(Date.now() - 1);
-
- mockLookup(expiredToken);
- mockClaim(1);
-
- await expect(
- service.validateAndConsumeSSOExchangeTokenOrThrow('plain-token'),
- ).rejects.toThrow(AuthException);
- });
-
- it('should throw when the auth provider is missing from the token context', async () => {
- const tokenWithoutProvider = buildAppToken();
-
- tokenWithoutProvider.context = null;
-
- mockLookup(tokenWithoutProvider);
- mockClaim(1);
-
- await expect(
- service.validateAndConsumeSSOExchangeTokenOrThrow('plain-token'),
- ).rejects.toThrow(AuthException);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/token/services/transient-token.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/token/services/transient-token.service.spec.ts
deleted file mode 100644
index a66aa6ef205..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/token/services/transient-token.service.spec.ts
+++ /dev/null
@@ -1,125 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-
-import { TransientTokenService } from './transient-token.service';
-
-describe('TransientTokenService', () => {
- let service: TransientTokenService;
- let jwtWrapperService: JwtWrapperService;
- let twentyConfigService: TwentyConfigService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- TransientTokenService,
- {
- provide: JwtWrapperService,
- useValue: {
- signAsyncOrThrow: jest.fn(),
- verifyJwtToken: jest.fn(),
- decode: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<TransientTokenService>(TransientTokenService);
- jwtWrapperService = module.get<JwtWrapperService>(JwtWrapperService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('generateTransientToken', () => {
- it('should generate a transient token successfully', async () => {
- const workspaceMemberId = 'workspace-member-id';
- const userId = 'user-id';
- const workspaceId = 'workspace-id';
- const mockExpiresIn = '15m';
- const mockToken = 'mock-token';
-
- jest.spyOn(twentyConfigService, 'get').mockImplementation((key) => {
- if (key === 'SHORT_TERM_TOKEN_EXPIRES_IN') return mockExpiresIn;
-
- return undefined;
- });
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
-
- const result = await service.generateTransientToken({
- workspaceMemberId,
- userId,
- workspaceId,
- });
-
- expect(result).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(twentyConfigService.get).toHaveBeenCalledWith(
- 'SHORT_TERM_TOKEN_EXPIRES_IN',
- );
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- {
- sub: workspaceMemberId,
- type: JwtTokenTypeEnum.LOGIN,
- userId,
- workspaceId,
- workspaceMemberId,
- },
- { expiresIn: mockExpiresIn },
- );
- });
- });
-
- describe('verifyTransientToken', () => {
- it('should verify a transient token successfully', async () => {
- const mockToken = 'valid-token';
- const mockPayload = {
- sub: 'workspace-member-id',
- type: JwtTokenTypeEnum.LOGIN,
- userId: 'user-id',
- workspaceId: 'workspace-id',
- workspaceMemberId: 'workspace-member-id',
- };
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(undefined);
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue(mockPayload);
-
- const result = await service.verifyTransientToken(mockToken);
-
- expect(result).toEqual({
- workspaceMemberId: mockPayload.workspaceMemberId,
- sub: mockPayload.sub,
- userId: mockPayload.userId,
- workspaceId: mockPayload.workspaceId,
- });
- expect(jwtWrapperService.verifyJwtToken).toHaveBeenCalledWith(mockToken);
- expect(jwtWrapperService.decode).toHaveBeenCalledWith(mockToken);
- });
-
- it('should throw an error if token verification fails', async () => {
- const mockToken = 'invalid-token';
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockRejectedValue(new Error('Invalid token'));
-
- await expect(service.verifyTransientToken(mockToken)).rejects.toThrow();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/auth/token/services/workspace-agnostic-token.service.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/token/services/workspace-agnostic-token.service.spec.ts
deleted file mode 100644
index e364e99ca07..00000000000
--- a/packages/twenty-server/src/engine/core-modules/auth/token/services/workspace-agnostic-token.service.spec.ts
+++ /dev/null
@@ -1,214 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { type Repository } from 'typeorm';
-
-import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { WorkspaceAgnosticTokenService } from 'src/engine/core-modules/auth/token/services/workspace-agnostic-token.service';
-import { AuthProviderEnum } from 'src/engine/core-modules/workspace/types/workspace.type';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-
-describe('WorkspaceAgnosticToken', () => {
- let service: WorkspaceAgnosticTokenService;
- let jwtWrapperService: JwtWrapperService;
- let twentyConfigService: TwentyConfigService;
- let userRepository: Repository<UserEntity>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkspaceAgnosticTokenService,
- {
- provide: JwtWrapperService,
- useValue: {
- signAsyncOrThrow: jest.fn(),
- verifyJwtToken: jest.fn(),
- decode: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(UserEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<WorkspaceAgnosticTokenService>(
- WorkspaceAgnosticTokenService,
- );
- jwtWrapperService = module.get<JwtWrapperService>(JwtWrapperService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- userRepository = module.get<Repository<UserEntity>>(
- getRepositoryToken(UserEntity),
- );
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('generateWorkspaceAgnosticToken', () => {
- it('should generate a workspace agnostic token successfully', async () => {
- const userId = 'user-id';
- const mockExpiresIn = '15m';
- const mockToken = 'mock-token';
- const mockUser = { id: userId };
-
- jest.spyOn(twentyConfigService, 'get').mockImplementation((key) => {
- if (key === 'WORKSPACE_AGNOSTIC_TOKEN_EXPIRES_IN') return mockExpiresIn;
-
- return undefined;
- });
- jest
- .spyOn(jwtWrapperService, 'signAsyncOrThrow')
- .mockResolvedValue(mockToken);
- jest
- .spyOn(userRepository, 'findOne')
- .mockResolvedValue(mockUser as UserEntity);
-
- const result = await service.generateWorkspaceAgnosticToken({
- userId,
- authProvider: AuthProviderEnum.Password,
- });
-
- expect(result).toEqual({
- token: mockToken,
- expiresAt: expect.any(Date),
- });
- expect(twentyConfigService.get).toHaveBeenCalledWith(
- 'WORKSPACE_AGNOSTIC_TOKEN_EXPIRES_IN',
- );
- expect(userRepository.findOne).toHaveBeenCalledWith({
- where: { id: userId },
- });
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- {
- authProvider: AuthProviderEnum.Password,
- sub: userId,
- userId: userId,
- type: JwtTokenTypeEnum.WORKSPACE_AGNOSTIC,
- },
- { expiresIn: mockExpiresIn },
- );
- });
-
- it('should throw an error if user is not found', async () => {
- const userId = 'non-existent-user-id';
- const mockExpiresIn = '15m';
-
- jest.spyOn(twentyConfigService, 'get').mockImplementation((key) => {
- if (key === 'WORKSPACE_AGNOSTIC_TOKEN_EXPIRES_IN') return mockExpiresIn;
-
- return undefined;
- });
-
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.generateWorkspaceAgnosticToken({
- userId,
- authProvider: AuthProviderEnum.Password,
- }),
- ).rejects.toThrow(AuthException);
- });
- });
-
- describe('validateToken', () => {
- it('should validate a token successfully', async () => {
- const mockToken = 'valid-token';
- const userId = 'user-id';
- const mockPayload = {
- sub: userId,
- userId: userId,
- type: JwtTokenTypeEnum.WORKSPACE_AGNOSTIC,
- };
- const mockUser = {
- id: userId,
- createdAt: new Date('2024-01-01'),
- updatedAt: new Date('2024-01-01'),
- deletedAt: null,
- } as unknown as UserEntity;
-
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue(mockPayload);
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(mockPayload);
- jest
- .spyOn(userRepository, 'findOne')
- .mockResolvedValue(mockUser as UserEntity);
-
- const result = await service.validateToken(mockToken);
-
- expect(result.user).toMatchObject({
- id: userId,
- });
- expect(jwtWrapperService.verifyJwtToken).toHaveBeenCalledWith(mockToken);
- expect(jwtWrapperService.decode).toHaveBeenCalledWith(mockToken);
- expect(userRepository.findOne).toHaveBeenCalledWith({
- where: { id: userId },
- });
- });
-
- it('should throw an error if token verification fails', async () => {
- const mockToken = 'invalid-token';
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockRejectedValue(new Error('Invalid token'));
-
- await expect(service.validateToken(mockToken)).rejects.toThrow(
- AuthException,
- );
- });
-
- it('should throw an error if user is not found', async () => {
- const mockToken = 'valid-token';
- const userId = 'user-id';
- const mockPayload = {
- sub: userId,
- userId: userId,
- type: JwtTokenTypeEnum.WORKSPACE_AGNOSTIC,
- };
-
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue(mockPayload);
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(mockPayload);
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
-
- await expect(service.validateToken(mockToken)).rejects.toThrow(
- AuthException,
- );
- });
-
- it('should reject a valid token that is not of WORKSPACE_AGNOSTIC type', async () => {
- const mockToken = 'valid-but-wrong-type-token';
- const userId = 'user-id';
- const mockPayload = {
- sub: userId,
- userId: userId,
- type: JwtTokenTypeEnum.ACCESS,
- };
-
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue(mockPayload);
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(mockPayload);
-
- await expect(service.validateToken(mockToken)).rejects.toThrow(
- AuthException,
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing-webhook/services/__tests__/billing-webhook-subscription.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing-webhook/services/__tests__/billing-webhook-subscription.service.spec.ts
deleted file mode 100644
index 2546e0486fa..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing-webhook/services/__tests__/billing-webhook-subscription.service.spec.ts
+++ /dev/null
@@ -1,429 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { WorkspaceActivationStatus } from 'twenty-shared/workspace';
-
-import type Stripe from 'stripe';
-
-import { mockStripeSubscriptionUpdatedEventWithoutUpdatedItem } from 'src/engine/core-modules/billing-webhook/__mocks__/stripe-subscription-updated-events';
-import { BillingWebhookSubscriptionService } from 'src/engine/core-modules/billing-webhook/services/billing-webhook-subscription.service';
-import { BillingCustomerEntity } from 'src/engine/core-modules/billing/entities/billing-customer.entity';
-import { BillingSubscriptionItemEntity } from 'src/engine/core-modules/billing/entities/billing-subscription-item.entity';
-import { BillingSubscriptionEntity } from 'src/engine/core-modules/billing/entities/billing-subscription.entity';
-import { BillingCreditService } from 'src/engine/core-modules/billing/services/billing-credit.service';
-import { BillingUsageCacheService } from 'src/engine/core-modules/billing/services/billing-usage-cache.service';
-import { StripeCustomerService } from 'src/engine/core-modules/billing/stripe/services/stripe-customer.service';
-import { StripeSubscriptionScheduleService } from 'src/engine/core-modules/billing/stripe/services/stripe-subscription-schedule.service';
-import { type SubscriptionWithSchedule } from 'src/engine/core-modules/billing/types/billing-subscription-with-schedule.type';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { WorkspaceService } from 'src/engine/core-modules/workspace/services/workspace.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-const WORKSPACE_ID = 'workspace-id';
-
-const buildWorkspace = (
- activationStatus: WorkspaceActivationStatus,
- deletedAt: Date | null = null,
-) =>
- ({
- id: WORKSPACE_ID,
- activationStatus,
- deletedAt,
- }) as unknown as WorkspaceEntity;
-
-const buildSubscriptionUpdatedEvent = (
- overrides: Partial<Stripe.Subscription>,
-): Stripe.CustomerSubscriptionUpdatedEvent => {
- const baseEvent = mockStripeSubscriptionUpdatedEventWithoutUpdatedItem;
-
- return {
- ...baseEvent,
- data: {
- ...baseEvent.data,
- object: {
- ...baseEvent.data.object,
- ...overrides,
- },
- },
- };
-};
-
-const buildLiveSubscription = (
- overrides: Partial<Stripe.Subscription>,
-): SubscriptionWithSchedule =>
- ({
- ...mockStripeSubscriptionUpdatedEventWithoutUpdatedItem.data.object,
- ...overrides,
- }) as unknown as SubscriptionWithSchedule;
-
-describe('BillingWebhookSubscriptionService', () => {
- let service: BillingWebhookSubscriptionService;
- let workspaceRepository: { findOne: jest.Mock };
- let workspaceService: {
- suspendWorkspace: jest.Mock;
- reactivateWorkspace: jest.Mock;
- deleteWorkspace: jest.Mock;
- };
- let stripeSubscriptionScheduleService: {
- listCustomerNotEndedSubscriptionsWithSchedule: jest.Mock;
- getSubscriptionWithSchedule: jest.Mock;
- };
- let messageQueueService: { add: jest.Mock };
- let billingSubscriptionRepository: { upsert: jest.Mock; findOne: jest.Mock };
-
- beforeEach(async () => {
- workspaceRepository = { findOne: jest.fn() };
- workspaceService = {
- suspendWorkspace: jest.fn().mockResolvedValue(true),
- reactivateWorkspace: jest.fn().mockResolvedValue(true),
- deleteWorkspace: jest.fn(),
- };
- stripeSubscriptionScheduleService = {
- listCustomerNotEndedSubscriptionsWithSchedule: jest.fn(),
- getSubscriptionWithSchedule: jest.fn(),
- };
- messageQueueService = { add: jest.fn() };
- billingSubscriptionRepository = {
- upsert: jest.fn(),
- findOne: jest.fn().mockResolvedValue({
- id: 'billing-subscription-id',
- stripeSubscriptionId:
- mockStripeSubscriptionUpdatedEventWithoutUpdatedItem.data.object.id,
- currentPeriodStart: new Date('2026-01-01T00:00:00.000Z'),
- previousPeriodStart: null,
- }),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- BillingWebhookSubscriptionService,
- {
- provide: StripeCustomerService,
- useValue: { updateCustomerMetadataWorkspaceId: jest.fn() },
- },
- {
- provide: getQueueToken(MessageQueue.workspaceQueue),
- useValue: messageQueueService,
- },
- {
- provide: getRepositoryToken(BillingSubscriptionEntity),
- useValue: billingSubscriptionRepository,
- },
- {
- provide: getRepositoryToken(BillingSubscriptionItemEntity),
- useValue: { upsert: jest.fn(), delete: jest.fn() },
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: workspaceRepository,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(BillingCustomerEntity),
- useValue: { upsert: jest.fn() },
- },
- { provide: WorkspaceService, useValue: workspaceService },
- {
- provide: StripeSubscriptionScheduleService,
- useValue: stripeSubscriptionScheduleService,
- },
- {
- provide: BillingCreditService,
- useValue: {
- reconcileMirroredBalance: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: BillingUsageCacheService,
- useValue: { flushAvailableCredits: jest.fn() },
- },
- {
- provide: WorkspaceCacheService,
- useValue: { invalidateAndRecompute: jest.fn() },
- },
- ],
- }).compile();
-
- service = module.get<BillingWebhookSubscriptionService>(
- BillingWebhookSubscriptionService,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('processStripeEvent', () => {
- it('should not suspend and should reactivate when a stale past_due event is processed after the subscription became active', async () => {
- // Trial ended one hour ago: a past_due payload within the 24h window
- // previously triggered a suspension even if the customer had already paid
- const trialEndOneHourAgo = Math.floor(Date.now() / 1000) - 3600;
-
- const staleEvent = buildSubscriptionUpdatedEvent({
- status: 'past_due',
- trial_end: trialEndOneHourAgo,
- });
-
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [
- buildLiveSubscription({
- status: 'active',
- trial_end: trialEndOneHourAgo,
- }),
- ],
- );
-
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.SUSPENDED),
- );
-
- await service.processStripeEvent(WORKSPACE_ID, staleEvent);
-
- expect(workspaceService.suspendWorkspace).not.toHaveBeenCalled();
- expect(workspaceService.reactivateWorkspace).toHaveBeenCalledWith(
- WORKSPACE_ID,
- );
- expect(messageQueueService.add).toHaveBeenCalled();
- });
-
- it('should suspend an active workspace when the live subscription is unpaid even if the event payload says active', async () => {
- const staleEvent = buildSubscriptionUpdatedEvent({ status: 'active' });
-
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [buildLiveSubscription({ status: 'unpaid' })],
- );
-
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.ACTIVE),
- );
-
- await service.processStripeEvent(WORKSPACE_ID, staleEvent);
-
- expect(workspaceService.suspendWorkspace).toHaveBeenCalledWith(
- WORKSPACE_ID,
- );
- expect(workspaceService.reactivateWorkspace).not.toHaveBeenCalled();
- });
-
- it('should attempt the guarded reactivation even when the workspace snapshot is stale', async () => {
- const activeEvent = buildSubscriptionUpdatedEvent({ status: 'active' });
-
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [buildLiveSubscription({ status: 'active' })],
- );
-
- // The handler's snapshot says ACTIVE (e.g. a concurrent event suspends
- // the workspace mid-processing): reactivation is still attempted and the
- // compare-and-swap in WorkspaceService decides whether it applies
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.ACTIVE),
- );
-
- await service.processStripeEvent(WORKSPACE_ID, activeEvent);
-
- expect(workspaceService.reactivateWorkspace).toHaveBeenCalledWith(
- WORKSPACE_ID,
- );
- expect(workspaceService.suspendWorkspace).not.toHaveBeenCalled();
- });
-
- it('should not suspend when the event subscription is canceled but the customer has another live activating subscription', async () => {
- const staleDeletionEvent = buildSubscriptionUpdatedEvent({
- status: 'canceled',
- });
-
- // The canceled event subscription is not in the not-canceled list and
- // is fetched through the direct retrieve fallback instead
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [
- buildLiveSubscription({
- id: 'sub_new_active_subscription',
- status: 'active',
- }),
- ],
- );
- stripeSubscriptionScheduleService.getSubscriptionWithSchedule.mockResolvedValue(
- buildLiveSubscription({ status: 'canceled' }),
- );
-
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.ACTIVE),
- );
-
- await service.processStripeEvent(WORKSPACE_ID, staleDeletionEvent);
-
- expect(workspaceService.suspendWorkspace).not.toHaveBeenCalled();
- expect(workspaceService.deleteWorkspace).not.toHaveBeenCalled();
- });
-
- it('should neither suspend nor reactivate when a sibling subscription is in a past_due grace period', async () => {
- const deletionEvent = buildSubscriptionUpdatedEvent({
- status: 'canceled',
- });
-
- // The sibling is past_due outside the trial window: not suspend-worthy
- // (payment retries are in progress) but not activating either, so the
- // workspace must be left untouched
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [
- buildLiveSubscription({
- id: 'sub_sibling_in_grace_period',
- status: 'past_due',
- trial_end: null,
- }),
- ],
- );
- stripeSubscriptionScheduleService.getSubscriptionWithSchedule.mockResolvedValue(
- buildLiveSubscription({ status: 'canceled' }),
- );
-
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.ACTIVE),
- );
-
- await service.processStripeEvent(WORKSPACE_ID, deletionEvent);
-
- expect(workspaceService.suspendWorkspace).not.toHaveBeenCalled();
- expect(workspaceService.deleteWorkspace).not.toHaveBeenCalled();
- expect(workspaceService.reactivateWorkspace).not.toHaveBeenCalled();
- });
-
- it('should reactivate a suspended workspace on a canceled subscription event when another live activating subscription exists', async () => {
- const staleDeletionEvent = buildSubscriptionUpdatedEvent({
- status: 'canceled',
- });
-
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [
- buildLiveSubscription({
- id: 'sub_new_trialing_subscription',
- status: 'trialing',
- }),
- ],
- );
- stripeSubscriptionScheduleService.getSubscriptionWithSchedule.mockResolvedValue(
- buildLiveSubscription({ status: 'canceled' }),
- );
-
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.SUSPENDED),
- );
-
- await service.processStripeEvent(WORKSPACE_ID, staleDeletionEvent);
-
- expect(workspaceService.suspendWorkspace).not.toHaveBeenCalled();
- expect(workspaceService.reactivateWorkspace).toHaveBeenCalledWith(
- WORKSPACE_ID,
- );
- });
-
- it('should not enqueue the deletion warning cleanup job when the guarded reactivation did not apply', async () => {
- const activeEvent = buildSubscriptionUpdatedEvent({ status: 'active' });
-
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [buildLiveSubscription({ status: 'active' })],
- );
-
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.SUSPENDED),
- );
-
- // Compare-and-swap in WorkspaceService reports no transition, e.g. a
- // concurrent handler already reactivated the workspace
- workspaceService.reactivateWorkspace.mockResolvedValue(false);
-
- await service.processStripeEvent(WORKSPACE_ID, activeEvent);
-
- expect(workspaceService.reactivateWorkspace).toHaveBeenCalledWith(
- WORKSPACE_ID,
- );
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('should not reactivate a suspended workspace when the live subscription is past_due outside the trial window', async () => {
- const staleEvent = buildSubscriptionUpdatedEvent({ status: 'active' });
-
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [buildLiveSubscription({ status: 'past_due', trial_end: null })],
- );
-
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.SUSPENDED),
- );
-
- await service.processStripeEvent(WORKSPACE_ID, staleEvent);
-
- expect(workspaceService.suspendWorkspace).not.toHaveBeenCalled();
- expect(workspaceService.reactivateWorkspace).not.toHaveBeenCalled();
- });
-
- it('should fall back to a direct subscription retrieve when the customer subscription list does not contain the event subscription', async () => {
- const deletionEvent = {
- ...buildSubscriptionUpdatedEvent({ status: 'canceled' }),
- type: 'customer.subscription.deleted',
- } as unknown as Stripe.CustomerSubscriptionDeletedEvent;
-
- // Deleted Stripe customer: listing its subscriptions returns nothing,
- // but retrieving the canceled subscription by id still works
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [],
- );
- stripeSubscriptionScheduleService.getSubscriptionWithSchedule.mockResolvedValue(
- buildLiveSubscription({ status: 'canceled' }),
- );
-
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.ACTIVE),
- );
-
- await service.processStripeEvent(WORKSPACE_ID, deletionEvent);
-
- expect(
- stripeSubscriptionScheduleService.getSubscriptionWithSchedule,
- ).toHaveBeenCalledWith(
- mockStripeSubscriptionUpdatedEventWithoutUpdatedItem.data.object.id,
- );
- expect(workspaceService.suspendWorkspace).toHaveBeenCalledWith(
- WORKSPACE_ID,
- );
- expect(workspaceService.reactivateWorkspace).not.toHaveBeenCalled();
- });
-
- it('should not transition a workspace that was soft-deleted mid-processing', async () => {
- const deletionEvent = {
- ...buildSubscriptionUpdatedEvent({ status: 'canceled' }),
- type: 'customer.subscription.deleted',
- } as unknown as Stripe.CustomerSubscriptionDeletedEvent;
-
- stripeSubscriptionScheduleService.listCustomerNotEndedSubscriptionsWithSchedule.mockResolvedValue(
- [
- buildLiveSubscription({
- id: 'sub_new_active_subscription',
- status: 'active',
- }),
- ],
- );
- stripeSubscriptionScheduleService.getSubscriptionWithSchedule.mockResolvedValue(
- buildLiveSubscription({ status: 'canceled' }),
- );
-
- // The workspace was soft-deleted mid-processing: billing must not
- // suspend or delete it, and the reactivation compare-and-swap refuses
- // soft-deleted workspaces (deletedAt IS NULL in its WHERE clause)
- workspaceRepository.findOne.mockResolvedValue(
- buildWorkspace(WorkspaceActivationStatus.SUSPENDED, new Date()),
- );
- workspaceService.reactivateWorkspace.mockResolvedValue(false);
-
- await service.processStripeEvent(WORKSPACE_ID, deletionEvent);
-
- expect(workspaceService.suspendWorkspace).not.toHaveBeenCalled();
- expect(workspaceService.deleteWorkspace).not.toHaveBeenCalled();
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/reminders/services/__tests__/billing-reminder.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/reminders/services/__tests__/billing-reminder.service.spec.ts
deleted file mode 100644
index d9b96ac9acd..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/reminders/services/__tests__/billing-reminder.service.spec.ts
+++ /dev/null
@@ -1,263 +0,0 @@
-import { addDays } from 'date-fns';
-import {
- BillingSubscriptionRenewingEmail,
- BillingTrialConvertingEmail,
- BillingTrialEndingEmail,
-} from 'twenty-emails';
-
-import { SubscriptionInterval } from 'src/engine/core-modules/billing/enums/billing-subscription-interval.enum';
-import { SubscriptionStatus } from 'src/engine/core-modules/billing/enums/billing-subscription-status.enum';
-import {
- BILLING_RENEWAL_REMINDER_SENT_KEY,
- BILLING_TRIAL_REMINDER_SENT_KEY,
-} from 'src/engine/core-modules/billing/reminders/constants/billing-reminder-sent-keys.constant';
-import { BillingReminderService } from 'src/engine/core-modules/billing/reminders/services/billing-reminder.service';
-
-// render() resolves through a streaming scheduler that never advances under the
-// globally enabled fake timers; the real render path is covered by
-// email-templates-rendering.spec.ts.
-jest.mock('twenty-emails', () => ({
- BillingTrialEndingEmail: jest.fn(),
- BillingTrialConvertingEmail: jest.fn(),
- BillingSubscriptionRenewingEmail: jest.fn(),
- renderEmail: jest.fn().mockResolvedValue('<html></html>'),
-}));
-
-const CONFIG: Record<string, unknown> = {
- IS_BILLING_ENABLED: true,
- BILLING_TRIAL_WITHOUT_CREDIT_CARD_REMINDER_DAYS_BEFORE: 1,
- BILLING_TRIAL_WITH_CREDIT_CARD_REMINDER_DAYS_BEFORE: 7,
- BILLING_SUBSCRIPTION_RENEWAL_REMINDER_DAYS_BEFORE: 7,
- BILLING_FREE_TRIAL_WITH_CREDIT_CARD_DURATION_IN_DAYS: 30,
- BILLING_FREE_TRIAL_WITHOUT_CREDIT_CARD_DURATION_IN_DAYS: 7,
- WORKSPACE_INACTIVE_DAYS_BEFORE_SOFT_DELETION: 14,
- EMAIL_FROM_NAME: 'Twenty',
- EMAIL_FROM_ADDRESS: '[email protected]',
-};
-
-const buildService = ({
- trialingSubscriptions = [],
- renewingSubscriptions = [],
- alreadySentBoundary,
-}: {
- // oxlint-disable-next-line typescript/no-explicit-any
- trialingSubscriptions?: any[];
- // oxlint-disable-next-line typescript/no-explicit-any
- renewingSubscriptions?: any[];
- alreadySentBoundary?: string;
-}) => {
- const emailSend = jest.fn().mockResolvedValue(undefined);
- const userVarsSet = jest.fn().mockResolvedValue(undefined);
-
- const billingSubscriptionRepository = {
- find: jest
- .fn()
- .mockImplementation(({ where }) =>
- where.status === SubscriptionStatus.Trialing
- ? trialingSubscriptions
- : renewingSubscriptions,
- ),
- };
- const workspaceRepository = {
- findOne: jest
- .fn()
- .mockResolvedValue({ id: 'workspace-1', displayName: 'Acme Inc.' }),
- };
- const userService = {
- loadWorkspaceMembers: jest.fn().mockResolvedValue([
- {
- name: { firstName: 'John', lastName: 'Doe' },
- locale: 'en',
- userEmail: '[email protected]',
- },
- ]),
- };
- const userVarsService = {
- get: jest.fn().mockResolvedValue(alreadySentBoundary),
- set: userVarsSet,
- };
- const emailService = { send: emailSend };
- const i18nService = { getI18nInstance: () => ({ _: () => 'subject' }) };
- const twentyConfigService = { get: (key: string) => CONFIG[key] };
- const workspaceDomainsService = {
- buildWorkspaceURL: jest.fn(
- () => new URL('https://acme.twenty.com/settings/billing'),
- ),
- };
-
- const service = new BillingReminderService(
- // oxlint-disable-next-line typescript/no-explicit-any
- twentyConfigService as any,
- // oxlint-disable-next-line typescript/no-explicit-any
- billingSubscriptionRepository as any,
- // oxlint-disable-next-line typescript/no-explicit-any
- workspaceRepository as any,
- // oxlint-disable-next-line typescript/no-explicit-any
- userService as any,
- // oxlint-disable-next-line typescript/no-explicit-any
- userVarsService as any,
- // oxlint-disable-next-line typescript/no-explicit-any
- emailService as any,
- // oxlint-disable-next-line typescript/no-explicit-any
- i18nService as any,
- // oxlint-disable-next-line typescript/no-explicit-any
- workspaceDomainsService as any,
- );
-
- return { service, emailSend, userVarsSet };
-};
-
-describe('BillingReminderService', () => {
- beforeEach(() => jest.clearAllMocks());
-
- it('sends the add-a-card email the day before a no-credit-card trial ends', async () => {
- const trialEnd = addDays(new Date(), 1);
- const { service, emailSend } = buildService({
- trialingSubscriptions: [
- {
- workspaceId: 'workspace-1',
- status: SubscriptionStatus.Trialing,
- interval: SubscriptionInterval.Month,
- trialStart: addDays(new Date(), -6),
- trialEnd,
- billingCustomer: { hasPaymentMethod: false },
- },
- ],
- });
-
- await service.processReminders();
-
- expect(BillingTrialEndingEmail).toHaveBeenCalledTimes(1);
- expect(BillingTrialEndingEmail).toHaveBeenCalledWith(
- expect.objectContaining({
- trialEndsAt: trialEnd,
- dataRetentionDays: 14,
- link: 'https://acme.twenty.com/settings/billing',
- }),
- );
- expect(BillingTrialConvertingEmail).not.toHaveBeenCalled();
- expect(emailSend).toHaveBeenCalledTimes(1);
- });
-
- it('sends the upcoming-charge email 7 days before a credit-card trial converts', async () => {
- const trialEnd = addDays(new Date(), 7);
- const { service, userVarsSet } = buildService({
- trialingSubscriptions: [
- {
- workspaceId: 'workspace-1',
- status: SubscriptionStatus.Trialing,
- interval: SubscriptionInterval.Month,
- trialStart: addDays(new Date(), -23),
- trialEnd,
- billingCustomer: { hasPaymentMethod: true },
- },
- ],
- });
-
- await service.processReminders();
-
- expect(BillingTrialConvertingEmail).toHaveBeenCalledWith(
- expect.objectContaining({ trialEndsAt: trialEnd, interval: 'month' }),
- );
- expect(BillingTrialEndingEmail).not.toHaveBeenCalled();
- expect(userVarsSet).toHaveBeenCalledWith(
- expect.objectContaining({
- key: BILLING_TRIAL_REMINDER_SENT_KEY,
- value: trialEnd.toISOString(),
- }),
- );
- });
-
- it('classifies a card-on-file trial as converting even when hasPaymentMethod and trialStart are not yet synced', async () => {
- const trialEnd = addDays(new Date(), 5);
- const { service } = buildService({
- trialingSubscriptions: [
- {
- workspaceId: 'workspace-1',
- status: SubscriptionStatus.Trialing,
- interval: SubscriptionInterval.Month,
- trialStart: null,
- trialEnd,
- createdAt: addDays(new Date(), -25),
- billingCustomer: { hasPaymentMethod: null },
- },
- ],
- });
-
- await service.processReminders();
-
- expect(BillingTrialConvertingEmail).toHaveBeenCalled();
- expect(BillingTrialEndingEmail).not.toHaveBeenCalled();
- });
-
- it('does not send twice for the same boundary (idempotent)', async () => {
- const trialEnd = addDays(new Date(), 7);
- const { service, emailSend, userVarsSet } = buildService({
- trialingSubscriptions: [
- {
- workspaceId: 'workspace-1',
- status: SubscriptionStatus.Trialing,
- interval: SubscriptionInterval.Month,
- trialStart: addDays(new Date(), -23),
- trialEnd,
- billingCustomer: { hasPaymentMethod: true },
- },
- ],
- alreadySentBoundary: trialEnd.toISOString(),
- });
-
- await service.processReminders();
-
- expect(BillingTrialConvertingEmail).not.toHaveBeenCalled();
- expect(emailSend).not.toHaveBeenCalled();
- expect(userVarsSet).not.toHaveBeenCalled();
- });
-
- it('sends a renewal reminder 7 days before a yearly subscription renews', async () => {
- const renewsAt = addDays(new Date(), 7);
- const { service, userVarsSet } = buildService({
- renewingSubscriptions: [
- {
- workspaceId: 'workspace-1',
- status: SubscriptionStatus.Active,
- interval: SubscriptionInterval.Year,
- cancelAtPeriodEnd: false,
- currentPeriodEnd: renewsAt,
- },
- ],
- });
-
- await service.processReminders();
-
- expect(BillingSubscriptionRenewingEmail).toHaveBeenCalledWith(
- expect.objectContaining({ renewsAt }),
- );
- expect(userVarsSet).toHaveBeenCalledWith(
- expect.objectContaining({
- key: BILLING_RENEWAL_REMINDER_SENT_KEY,
- value: renewsAt.toISOString(),
- }),
- );
- });
-
- it('does nothing when billing is disabled', async () => {
- const { service, emailSend } = buildService({
- trialingSubscriptions: [
- {
- workspaceId: 'workspace-1',
- status: SubscriptionStatus.Trialing,
- interval: SubscriptionInterval.Month,
- trialStart: addDays(new Date(), -6),
- trialEnd: addDays(new Date(), 1),
- billingCustomer: { hasPaymentMethod: false },
- },
- ],
- });
- CONFIG.IS_BILLING_ENABLED = false;
-
- await service.processReminders();
-
- expect(emailSend).not.toHaveBeenCalled();
- CONFIG.IS_BILLING_ENABLED = true;
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-credit-grant.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-credit-grant.service.spec.ts
deleted file mode 100644
index 51958250c24..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-credit-grant.service.spec.ts
+++ /dev/null
@@ -1,325 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { BillingException } from 'src/engine/core-modules/billing/billing.exception';
-import { BillingCreditGrantEntity } from 'src/engine/core-modules/billing/entities/billing-credit-grant.entity';
-import { BillingCustomerEntity } from 'src/engine/core-modules/billing/entities/billing-customer.entity';
-import { BillingCreditGrantType } from 'src/engine/core-modules/billing/enums/billing-credit-grant-type.enum';
-import { BillingCreditGrantService } from 'src/engine/core-modules/billing/services/billing-credit-grant.service';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-
-const workspaceId = 'ws_123';
-const EFFECTIVE_AT = new Date('2026-01-01T00:00:00.000Z');
-const EXPIRES_AT = new Date('2026-02-01T00:00:00.000Z');
-
-const validParams = {
- workspaceId,
- amountMicro: 2_000_000,
- type: BillingCreditGrantType.COMPENSATION,
- effectiveAt: EFFECTIVE_AT,
- expiresAt: EXPIRES_AT,
-};
-
-describe('BillingCreditGrantService', () => {
- let service: BillingCreditGrantService;
- let repository: jest.Mocked<{
- insert: jest.Mock;
- findOne: jest.Mock;
- findOneOrFail: jest.Mock;
- find: jest.Mock;
- update: jest.Mock;
- createQueryBuilder: jest.Mock;
- exists: jest.Mock;
- }>;
- let billingCustomerRepository: jest.Mocked<{ findOne: jest.Mock }>;
- let queryBuilder: { getRawOne: jest.Mock } & Record<string, jest.Mock>;
-
- beforeEach(async () => {
- queryBuilder = {
- select: jest.fn(),
- where: jest.fn(),
- andWhere: jest.fn(),
- getRawOne: jest.fn().mockResolvedValue({ total: '3000000' }),
- };
- queryBuilder.select.mockReturnValue(queryBuilder);
- queryBuilder.where.mockReturnValue(queryBuilder);
- queryBuilder.andWhere.mockReturnValue(queryBuilder);
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- BillingCreditGrantService,
- {
- provide: getWorkspaceScopedRepositoryToken(BillingCreditGrantEntity),
- useValue: {
- insert: jest.fn().mockResolvedValue({
- identifiers: [{ id: 'grant_1' }],
- generatedMaps: [{ id: 'grant_1' }],
- }),
- findOne: jest.fn().mockResolvedValue({ id: 'grant_1' }),
- findOneOrFail: jest
- .fn()
- .mockResolvedValue({ id: 'grant_1', revokedAt: new Date() }),
- find: jest.fn().mockResolvedValue([]),
- update: jest.fn().mockResolvedValue({ affected: 1 }),
- createQueryBuilder: jest.fn().mockReturnValue(queryBuilder),
- exists: jest.fn().mockResolvedValue(true),
- },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(BillingCustomerEntity),
- useValue: {
- findOne: jest.fn().mockResolvedValue({ creditBalanceMicro: 0 }),
- },
- },
- ],
- }).compile();
-
- service = module.get<BillingCreditGrantService>(BillingCreditGrantService);
- repository = module.get(
- getWorkspaceScopedRepositoryToken(BillingCreditGrantEntity),
- );
- billingCustomerRepository = module.get(
- getWorkspaceScopedRepositoryToken(BillingCustomerEntity),
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('createGrant', () => {
- it('inserts the grant and returns it', async () => {
- const grant = await service.createGrant(validParams);
-
- expect(repository.insert).toHaveBeenCalledWith(
- workspaceId,
- expect.objectContaining({
- amountMicro: 2_000_000,
- type: BillingCreditGrantType.COMPENSATION,
- effectiveAt: EFFECTIVE_AT,
- expiresAt: EXPIRES_AT,
- }),
- );
- expect(grant).toEqual({ id: 'grant_1' });
- });
-
- it.each([
- 0,
- -1,
- 1.5,
- Number.NaN,
- Number.POSITIVE_INFINITY,
- Number.MAX_SAFE_INTEGER + 1,
- ])(
- 'throws on a non-positive, non-integer or unsafe-integer amount (%p)',
- async (amountMicro) => {
- await expect(
- service.createGrant({ ...validParams, amountMicro }),
- ).rejects.toThrow(BillingException);
-
- expect(repository.insert).not.toHaveBeenCalled();
- },
- );
-
- it('throws when the grant would expire before it becomes effective', async () => {
- await expect(
- service.createGrant({
- ...validParams,
- effectiveAt: EXPIRES_AT,
- expiresAt: EFFECTIVE_AT,
- }),
- ).rejects.toThrow(BillingException);
-
- expect(repository.insert).not.toHaveBeenCalled();
- });
-
- it('returns null instead of duplicating a grant with a used idempotency key', async () => {
- repository.insert.mockRejectedValue(
- Object.assign(new Error('duplicate key'), { code: '23505' }),
- );
-
- const grant = await service.createGrant({
- ...validParams,
- idempotencyKey: 'onboarding-import-contacts:ws_123',
- });
-
- expect(grant).toBeNull();
- });
-
- it('returns null when the unique violation is wrapped in a driver error', async () => {
- repository.insert.mockRejectedValue(
- Object.assign(new Error('duplicate key'), {
- driverError: { code: '23505' },
- }),
- );
-
- const grant = await service.createGrant({
- ...validParams,
- idempotencyKey: 'onboarding-import-contacts:ws_123',
- });
-
- expect(grant).toBeNull();
- });
-
- it('rethrows a unique violation when no idempotency key was given', async () => {
- repository.insert.mockRejectedValue(
- Object.assign(new Error('duplicate key'), { code: '23505' }),
- );
-
- await expect(service.createGrant(validParams)).rejects.toThrow(
- 'duplicate key',
- );
- });
-
- it('rethrows errors that are not unique violations', async () => {
- repository.insert.mockRejectedValue(new Error('connection lost'));
-
- await expect(
- service.createGrant({
- ...validParams,
- idempotencyKey: 'some-key',
- }),
- ).rejects.toThrow('connection lost');
- });
- });
-
- describe('getActiveCreditsMicro', () => {
- it('sums the grants that are live right now', async () => {
- const total = await service.getActiveCreditsMicro(workspaceId);
-
- expect(total).toBe(3_000_000);
- expect(queryBuilder.andWhere).toHaveBeenCalledWith(
- '"billingCreditGrant"."revokedAt" IS NULL',
- );
- });
-
- it('returns zero when the workspace has no live grant', async () => {
- queryBuilder.getRawOne.mockResolvedValue({ total: null });
-
- expect(await service.getActiveCreditsMicro(workspaceId)).toBe(0);
- });
-
- it('throws rather than serving a balance it cannot represent exactly', async () => {
- queryBuilder.getRawOne.mockResolvedValue({
- total: String(Number.MAX_SAFE_INTEGER) + '0',
- });
-
- await expect(service.getActiveCreditsMicro(workspaceId)).rejects.toThrow(
- BillingException,
- );
- });
- });
-
- describe('getSpendableCreditsMicro', () => {
- it('reads the ledger once the workspace has a grant', async () => {
- repository.exists.mockResolvedValue(true);
-
- expect(await service.getSpendableCreditsMicro(workspaceId)).toBe(
- 3_000_000,
- );
- expect(billingCustomerRepository.findOne).not.toHaveBeenCalled();
- });
-
- it('falls back to the mirror column before the backfill has run', async () => {
- repository.exists.mockResolvedValue(false);
- billingCustomerRepository.findOne.mockResolvedValue({
- creditBalanceMicro: 200_000_000,
- });
-
- expect(await service.getSpendableCreditsMicro(workspaceId)).toBe(
- 200_000_000,
- );
- });
-
- it('returns zero when the workspace has neither a grant nor a customer', async () => {
- repository.exists.mockResolvedValue(false);
- billingCustomerRepository.findOne.mockResolvedValue(null);
-
- expect(await service.getSpendableCreditsMicro(workspaceId)).toBe(0);
- });
- });
-
- describe('closeGrantsAtPeriodEnd', () => {
- it('pulls expiries back to the period end', async () => {
- await service.closeGrantsAtPeriodEnd({
- workspaceId,
- periodEnd: EXPIRES_AT,
- });
-
- expect(repository.update).toHaveBeenCalledWith(
- workspaceId,
- expect.objectContaining({ expiresAt: expect.anything() }),
- { expiresAt: EXPIRES_AT },
- );
- });
-
- it('matches by predicate so a grant written mid-transition is closed too', async () => {
- await service.closeGrantsAtPeriodEnd({
- workspaceId,
- periodEnd: EXPIRES_AT,
- });
-
- const [, criteria] = repository.update.mock.calls[0];
-
- expect(Object.keys(criteria)).toEqual(
- expect.arrayContaining(['revokedAt', 'effectiveAt', 'expiresAt']),
- );
- expect(criteria).not.toHaveProperty('id');
- });
- });
-
- describe('revokeGrant', () => {
- it('stamps revokedAt', async () => {
- repository.findOne.mockResolvedValue({ id: 'grant_1', revokedAt: null });
-
- const { wasRevokedNow } = await service.revokeGrant({
- workspaceId,
- grantId: 'grant_1',
- revokedByUserId: 'user_1',
- });
-
- expect(wasRevokedNow).toBe(true);
- expect(repository.update).toHaveBeenCalledWith(
- workspaceId,
- expect.objectContaining({ id: 'grant_1' }),
- expect.objectContaining({ revokedByUserId: 'user_1' }),
- );
- });
-
- it('reports that it did not revoke when a concurrent call won the race', async () => {
- repository.findOne.mockResolvedValue({ id: 'grant_1', revokedAt: null });
- repository.update.mockResolvedValue({ affected: 0 });
-
- const { wasRevokedNow } = await service.revokeGrant({
- workspaceId,
- grantId: 'grant_1',
- });
-
- expect(wasRevokedNow).toBe(false);
- });
-
- it('leaves an already revoked grant alone', async () => {
- const revokedAt = new Date('2026-01-15T00:00:00.000Z');
-
- repository.findOne.mockResolvedValue({ id: 'grant_1', revokedAt });
-
- const { grant, wasRevokedNow } = await service.revokeGrant({
- workspaceId,
- grantId: 'grant_1',
- });
-
- expect(grant.revokedAt).toEqual(revokedAt);
- expect(wasRevokedNow).toBe(false);
- expect(repository.update).not.toHaveBeenCalled();
- });
-
- it('throws when the grant belongs to another workspace or does not exist', async () => {
- repository.findOne.mockResolvedValue(null);
-
- await expect(
- service.revokeGrant({ workspaceId, grantId: 'grant_unknown' }),
- ).rejects.toThrow(BillingException);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-credit-rollover.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-credit-rollover.service.spec.ts
deleted file mode 100644
index e4d402dee65..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-credit-rollover.service.spec.ts
+++ /dev/null
@@ -1,324 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { BillingExceptionCode } from 'src/engine/core-modules/billing/billing.exception';
-import { BillingCreditGrantType } from 'src/engine/core-modules/billing/enums/billing-credit-grant-type.enum';
-import { BillingCreditGrantService } from 'src/engine/core-modules/billing/services/billing-credit-grant.service';
-import { BillingCreditRolloverService } from 'src/engine/core-modules/billing/services/billing-credit-rollover.service';
-import { BillingCreditService } from 'src/engine/core-modules/billing/services/billing-credit.service';
-import { BillingUsageService } from 'src/engine/core-modules/billing/services/billing-usage.service';
-import { CacheLockService } from 'src/engine/core-modules/cache-lock/cache-lock.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-const workspaceId = 'ws_123';
-const CLOSING_PERIOD_START = new Date('2026-01-01T00:00:00.000Z');
-const CLOSING_PERIOD_END = new Date('2026-02-01T00:00:00.000Z');
-const NEXT_PERIOD_END = new Date('2026-03-01T00:00:00.000Z');
-const ALLOWANCE = 1_000_000;
-const ROLLOVER_ADJUSTMENT_KEY = `rollover:${CLOSING_PERIOD_END.toISOString()}`;
-
-const baseParams = {
- workspaceId,
- closingPeriodStart: CLOSING_PERIOD_START,
- closingPeriodEnd: CLOSING_PERIOD_END,
- closingAllowanceMicro: ALLOWANCE,
- nextPeriodStart: CLOSING_PERIOD_END,
- nextPeriodEnd: NEXT_PERIOD_END,
- nextAllowanceMicro: ALLOWANCE,
-};
-
-describe('BillingCreditRolloverService', () => {
- let service: BillingCreditRolloverService;
- let billingUsageService: jest.Mocked<{
- getCreditsUsedBetweenOrNull: jest.Mock;
- }>;
- let billingCreditGrantService: jest.Mocked<{
- findGrantsLiveDuringPeriod: jest.Mock;
- closeGrantsAtPeriodEnd: jest.Mock;
- createGrant: jest.Mock;
- materializeLegacyBalance: jest.Mock;
- }>;
- let billingCreditService: jest.Mocked<{
- refreshWorkspaceCreditState: jest.Mock;
- }>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- BillingCreditRolloverService,
- {
- provide: BillingUsageService,
- useValue: {
- getCreditsUsedBetweenOrNull: jest.fn().mockResolvedValue(0),
- },
- },
- {
- provide: BillingCreditGrantService,
- useValue: {
- findGrantsLiveDuringPeriod: jest.fn().mockResolvedValue([]),
- closeGrantsAtPeriodEnd: jest.fn().mockResolvedValue(undefined),
- createGrant: jest
- .fn()
- .mockImplementation((params) =>
- Promise.resolve({ id: 'grant_new', ...params }),
- ),
- materializeLegacyBalance: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: BillingCreditService,
- useValue: {
- refreshWorkspaceCreditState: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: CacheLockService,
- useValue: { withLock: jest.fn((fn: () => unknown) => fn()) },
- },
- {
- provide: TwentyConfigService,
- useValue: { get: jest.fn().mockReturnValue(2) },
- },
- ],
- }).compile();
-
- service = module.get<BillingCreditRolloverService>(
- BillingCreditRolloverService,
- );
- billingUsageService = module.get(BillingUsageService);
- billingCreditGrantService = module.get(BillingCreditGrantService);
- billingCreditService = module.get(BillingCreditService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('processRolloverOnPeriodTransition', () => {
- it('grants the unspent allowance for the new period', async () => {
- billingUsageService.getCreditsUsedBetweenOrNull.mockResolvedValue(
- 300_000,
- );
-
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledWith(
- expect.objectContaining({
- workspaceId,
- amountMicro: 700_000,
- type: BillingCreditGrantType.ROLLOVER,
- effectiveAt: CLOSING_PERIOD_END,
- expiresAt: NEXT_PERIOD_END,
- }),
- );
- });
-
- it('reads usage over the closing period, not the one that just started', async () => {
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(
- billingUsageService.getCreditsUsedBetweenOrNull,
- ).toHaveBeenCalledWith({
- workspaceId,
- from: CLOSING_PERIOD_START,
- to: CLOSING_PERIOD_END,
- });
- });
-
- it('grants nothing when the whole allowance was spent', async () => {
- billingUsageService.getCreditsUsedBetweenOrNull.mockResolvedValue(
- ALLOWANCE,
- );
-
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(billingCreditGrantService.createGrant).not.toHaveBeenCalled();
- });
-
- it('refreshes the credit state once even when nothing carried forward', async () => {
- billingUsageService.getCreditsUsedBetweenOrNull.mockResolvedValue(
- ALLOWANCE,
- );
-
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(
- billingCreditService.refreshWorkspaceCreditState,
- ).toHaveBeenCalledTimes(1);
- expect(
- billingCreditService.refreshWorkspaceCreditState,
- ).toHaveBeenCalledWith({
- workspaceId,
- availableDeltaMicro: 0,
- addsCredits: true,
- isReplay: false,
- adjustmentKey: ROLLOVER_ADJUSTMENT_KEY,
- });
- });
-
- // A redelivery after the rows were inserted carries nothing forward, so a
- // delta of zero would leave the carried credits out of the counter for the
- // whole period. Whether the counter actually needs rebuilding is decided by
- // the refresh, which owns the adjustment marker; the transition only
- // reports that it saw a replay.
- it('reports a replay when the carry-forward grants already existed', async () => {
- billingCreditGrantService.createGrant.mockResolvedValue(null);
-
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(
- billingCreditService.refreshWorkspaceCreditState,
- ).toHaveBeenCalledWith({
- workspaceId,
- availableDeltaMicro: 0,
- addsCredits: true,
- isReplay: true,
- adjustmentKey: ROLLOVER_ADJUSTMENT_KEY,
- });
- });
-
- it('refreshes the credit state once for the whole transition', async () => {
- billingCreditGrantService.findGrantsLiveDuringPeriod.mockResolvedValue([
- {
- id: 'compensation_1',
- type: BillingCreditGrantType.COMPENSATION,
- amountMicro: 500_000,
- createdAt: CLOSING_PERIOD_START,
- },
- ]);
-
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledTimes(2);
- expect(
- billingCreditService.refreshWorkspaceCreditState,
- ).toHaveBeenCalledTimes(1);
- });
-
- it('caps the rollover so the new period totals at most twice the allowance', async () => {
- billingCreditGrantService.findGrantsLiveDuringPeriod.mockResolvedValue([
- {
- id: 'previous_rollover',
- type: BillingCreditGrantType.ROLLOVER,
- amountMicro: ALLOWANCE,
- createdAt: CLOSING_PERIOD_START,
- },
- ]);
-
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledTimes(1);
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledWith(
- expect.objectContaining({ amountMicro: ALLOWANCE }),
- );
- });
-
- it('carries a compensation grant over untouched by the cap', async () => {
- billingCreditGrantService.findGrantsLiveDuringPeriod.mockResolvedValue([
- {
- id: 'compensation_1',
- type: BillingCreditGrantType.COMPENSATION,
- amountMicro: 200_000_000,
- createdAt: CLOSING_PERIOD_START,
- },
- ]);
-
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledWith(
- expect.objectContaining({
- amountMicro: 200_000_000,
- type: BillingCreditGrantType.COMPENSATION,
- sourceGrantId: 'compensation_1',
- }),
- );
- });
-
- it('closes the grants it carried forward so they cannot be counted twice', async () => {
- billingCreditGrantService.findGrantsLiveDuringPeriod.mockResolvedValue([
- {
- id: 'compensation_1',
- type: BillingCreditGrantType.COMPENSATION,
- amountMicro: 500_000,
- createdAt: CLOSING_PERIOD_START,
- },
- ]);
-
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(
- billingCreditGrantService.closeGrantsAtPeriodEnd,
- ).toHaveBeenCalledWith({
- workspaceId,
- periodEnd: CLOSING_PERIOD_END,
- });
- });
-
- it('gives every carried grant a replay-safe idempotency key', async () => {
- await service.processRolloverOnPeriodTransition(baseParams);
-
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledWith(
- expect.objectContaining({
- idempotencyKey: `carry-forward:${workspaceId}:${CLOSING_PERIOD_END.toISOString()}:ROLLOVER:allowance`,
- }),
- );
- });
-
- // Returning normally would answer the webhook 200 and Stripe would never
- // redeliver, so the transition would never run: no grant closed, nothing
- // carried forward, and the balance lost at expiry.
- it('fails the transition when usage could not be read so Stripe redelivers', async () => {
- billingUsageService.getCreditsUsedBetweenOrNull.mockResolvedValue(null);
-
- await expect(
- service.processRolloverOnPeriodTransition(baseParams),
- ).rejects.toMatchObject({
- code: BillingExceptionCode.BILLING_USAGE_UNAVAILABLE,
- });
-
- expect(billingCreditGrantService.createGrant).not.toHaveBeenCalled();
- expect(
- billingCreditGrantService.closeGrantsAtPeriodEnd,
- ).not.toHaveBeenCalled();
- expect(
- billingCreditService.refreshWorkspaceCreditState,
- ).not.toHaveBeenCalled();
- });
-
- it('carries trial credits into the first paid period', async () => {
- const trialAllowance = 500_000;
-
- billingCreditGrantService.findGrantsLiveDuringPeriod.mockResolvedValue([
- {
- id: 'reward_1',
- type: BillingCreditGrantType.ONBOARDING_REWARD,
- amountMicro: 1_000_000,
- createdAt: CLOSING_PERIOD_START,
- },
- ]);
- billingUsageService.getCreditsUsedBetweenOrNull.mockResolvedValue(
- 200_000,
- );
-
- await service.processRolloverOnPeriodTransition({
- ...baseParams,
- closingAllowanceMicro: trialAllowance,
- });
-
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledWith(
- expect.objectContaining({
- amountMicro: 300_000,
- type: BillingCreditGrantType.ROLLOVER,
- }),
- );
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledWith(
- expect.objectContaining({
- amountMicro: 1_000_000,
- type: BillingCreditGrantType.ONBOARDING_REWARD,
- sourceGrantId: 'reward_1',
- }),
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-credit.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-credit.service.spec.ts
deleted file mode 100644
index 60949dd1acb..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-credit.service.spec.ts
+++ /dev/null
@@ -1,565 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { BillingCustomerEntity } from 'src/engine/core-modules/billing/entities/billing-customer.entity';
-import { BillingCreditGrantType } from 'src/engine/core-modules/billing/enums/billing-credit-grant-type.enum';
-import { SubscriptionStatus } from 'src/engine/core-modules/billing/enums/billing-subscription-status.enum';
-import { BillingCreditGrantService } from 'src/engine/core-modules/billing/services/billing-credit-grant.service';
-import { BillingCreditService } from 'src/engine/core-modules/billing/services/billing-credit.service';
-import { BillingSubscriptionService } from 'src/engine/core-modules/billing/services/billing-subscription.service';
-import { BillingUsageCacheService } from 'src/engine/core-modules/billing/services/billing-usage-cache.service';
-import { BillingUsageCapService } from 'src/engine/core-modules/billing/services/billing-usage-cap.service';
-import { BillingService } from 'src/engine/core-modules/billing/services/billing.service';
-import { CacheLockService } from 'src/engine/core-modules/cache-lock/cache-lock.service';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-const workspaceId = 'ws_123';
-const DAY_IN_MS = 24 * 60 * 60 * 1000;
-// Relative to now so the period stays current: a lapsed period end takes a
-// different branch, which is covered by its own test below.
-const PERIOD_START = new Date(Date.now() - 10 * DAY_IN_MS);
-const PERIOD_END = new Date(Date.now() + 20 * DAY_IN_MS);
-
-const subscription = {
- status: SubscriptionStatus.Active,
- currentPeriodStart: PERIOD_START,
- currentPeriodEnd: PERIOD_END,
- trialStart: null,
- trialEnd: null,
-};
-
-describe('BillingCreditService', () => {
- let service: BillingCreditService;
- let billingService: jest.Mocked<{ isBillingEnabled: jest.Mock }>;
- let billingCreditGrantService: jest.Mocked<{
- createGrant: jest.Mock;
- getActiveCreditsMicro: jest.Mock;
- revokeGrant: jest.Mock;
- materializeLegacyBalance: jest.Mock;
- hasAnyGrant: jest.Mock;
- }>;
- let billingSubscriptionService: jest.Mocked<{
- getCurrentBillingSubscription: jest.Mock;
- }>;
- let billingUsageCacheService: jest.Mocked<{
- getAvailableCredits: jest.Mock;
- adjustAvailableCredits: jest.Mock;
- invalidateAvailableCredits: jest.Mock;
- hasCounterAdjustmentBeenApplied: jest.Mock;
- markCounterAdjustmentApplied: jest.Mock;
- }>;
- let billingUsageCapService: jest.Mocked<{
- clearHasReachedCapForWorkspace: jest.Mock;
- }>;
- let cacheLockService: jest.Mocked<{ withLock: jest.Mock }>;
- let workspaceCacheService: jest.Mocked<{ invalidateAndRecompute: jest.Mock }>;
- let billingCustomerRepository: jest.Mocked<{ update: jest.Mock }>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- BillingCreditService,
- {
- provide: BillingService,
- useValue: { isBillingEnabled: jest.fn().mockReturnValue(true) },
- },
- {
- provide: BillingCreditGrantService,
- useValue: {
- createGrant: jest
- .fn()
- .mockResolvedValue({ id: 'grant_1', amountMicro: 2_000_000 }),
- getActiveCreditsMicro: jest.fn().mockResolvedValue(2_000_000),
- hasAnyGrant: jest.fn().mockResolvedValue(true),
- materializeLegacyBalance: jest.fn().mockResolvedValue(undefined),
- revokeGrant: jest.fn().mockResolvedValue({
- grant: {
- id: 'grant_1',
- amountMicro: 2_000_000,
- effectiveAt: PERIOD_START,
- expiresAt: PERIOD_END,
- revokedAt: new Date(),
- },
- wasRevokedNow: true,
- }),
- },
- },
- {
- provide: BillingSubscriptionService,
- useValue: {
- getCurrentBillingSubscription: jest
- .fn()
- .mockResolvedValue(subscription),
- },
- },
- {
- provide: BillingUsageCacheService,
- useValue: {
- getAvailableCredits: jest.fn().mockResolvedValue(undefined),
- adjustAvailableCredits: jest.fn().mockResolvedValue(0),
- invalidateAvailableCredits: jest.fn().mockResolvedValue(undefined),
- hasCounterAdjustmentBeenApplied: jest.fn().mockResolvedValue(false),
- markCounterAdjustmentApplied: jest
- .fn()
- .mockResolvedValue(undefined),
- },
- },
- {
- provide: BillingUsageCapService,
- useValue: {
- clearHasReachedCapForWorkspace: jest
- .fn()
- .mockResolvedValue(undefined),
- },
- },
- {
- provide: CacheLockService,
- useValue: { withLock: jest.fn((fn: () => unknown) => fn()) },
- },
- {
- provide: WorkspaceCacheService,
- useValue: {
- invalidateAndRecompute: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(BillingCustomerEntity),
- useValue: { update: jest.fn().mockResolvedValue({ affected: 1 }) },
- },
- ],
- }).compile();
-
- service = module.get<BillingCreditService>(BillingCreditService);
- billingService = module.get(BillingService);
- billingCreditGrantService = module.get(BillingCreditGrantService);
- billingSubscriptionService = module.get(BillingSubscriptionService);
- billingUsageCacheService = module.get(BillingUsageCacheService);
- billingUsageCapService = module.get(BillingUsageCapService);
- cacheLockService = module.get(CacheLockService);
- workspaceCacheService = module.get(WorkspaceCacheService);
- billingCustomerRepository = module.get(
- getWorkspaceScopedRepositoryToken(BillingCustomerEntity),
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('grantCredits', () => {
- const params = {
- workspaceId,
- amountMicro: 2_000_000,
- type: BillingCreditGrantType.COMPENSATION,
- };
-
- it('records the grant with the current period end as its expiry', async () => {
- await service.grantCredits(params);
-
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledWith(
- expect.objectContaining({
- workspaceId,
- amountMicro: 2_000_000,
- type: BillingCreditGrantType.COMPENSATION,
- expiresAt: PERIOD_END,
- }),
- );
- });
-
- it('writes the ledger row and the counter under the workspace credit state lock', async () => {
- await service.grantCredits(params);
-
- expect(cacheLockService.withLock).toHaveBeenCalledWith(
- expect.any(Function),
- `billing-credit-state:${workspaceId}`,
- );
- expect(billingCreditGrantService.createGrant).toHaveBeenCalled();
- });
-
- // Reading the period before waiting for the lock would date the grant to
- // the period the wait started in, so it would land already expired while
- // its amount still went onto the counter for the period now running.
- it('takes its validity window from the period that is current once the lock is held', async () => {
- const NEXT_PERIOD_END = new Date(PERIOD_END.getTime() + 30 * DAY_IN_MS);
-
- cacheLockService.withLock.mockImplementation(
- async (fn: () => Promise<unknown>) => {
- billingSubscriptionService.getCurrentBillingSubscription.mockResolvedValue(
- {
- ...subscription,
- currentPeriodStart: PERIOD_END,
- currentPeriodEnd: NEXT_PERIOD_END,
- },
- );
-
- return fn();
- },
- );
-
- await service.grantCredits(params);
-
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledWith(
- expect.objectContaining({ expiresAt: NEXT_PERIOD_END }),
- );
- });
-
- it('expires on trial end while the workspace is trialing', async () => {
- const trialEnd = new Date(Date.now() + 5 * DAY_IN_MS);
-
- billingSubscriptionService.getCurrentBillingSubscription.mockResolvedValue(
- {
- ...subscription,
- status: SubscriptionStatus.Trialing,
- trialStart: PERIOD_START,
- trialEnd,
- },
- );
-
- await service.grantCredits(params);
-
- expect(billingCreditGrantService.createGrant).toHaveBeenCalledWith(
- expect.objectContaining({ expiresAt: trialEnd }),
- );
- });
-
- it('does not expire on creation when the subscription period has lapsed', async () => {
- const lapsedPeriodEnd = new Date(Date.now() - 60_000);
-
- billingSubscriptionService.getCurrentBillingSubscription.mockResolvedValue(
- { ...subscription, currentPeriodEnd: lapsedPeriodEnd },
- );
-
- await service.grantCredits(params);
-
- const { expiresAt } =
- billingCreditGrantService.createGrant.mock.calls[0][0];
-
- expect(expiresAt.getTime()).toBeGreaterThan(Date.now());
- });
-
- it('still records the grant when the workspace has no subscription yet', async () => {
- billingSubscriptionService.getCurrentBillingSubscription.mockResolvedValue(
- undefined,
- );
-
- const grant = await service.grantCredits(params);
-
- expect(grant).not.toBeNull();
- expect(billingCreditGrantService.createGrant).toHaveBeenCalled();
- });
-
- it('mirrors the ledger balance onto the billing customer', async () => {
- await service.grantCredits(params);
-
- expect(billingCustomerRepository.update).toHaveBeenCalledWith(
- workspaceId,
- {},
- { creditBalanceMicro: 2_000_000 },
- );
- });
-
- it('lifts the cap so the no-more-credits banner disappears', async () => {
- await service.grantCredits(params);
-
- expect(
- billingUsageCapService.clearHasReachedCapForWorkspace,
- ).toHaveBeenCalledWith(workspaceId);
- expect(workspaceCacheService.invalidateAndRecompute).toHaveBeenCalledWith(
- workspaceId,
- ['currentBillingSubscription'],
- );
- });
-
- // An execution can overrun the balance it checked, leaving the counter
- // below zero, and a grant smaller than the overrun does not make the
- // workspace spendable again.
- it('leaves the cap in place when the grant does not bring the counter above zero', async () => {
- billingUsageCacheService.getAvailableCredits.mockResolvedValue(
- -3_000_000,
- );
-
- await service.grantCredits(params);
-
- expect(
- billingUsageCapService.clearHasReachedCapForWorkspace,
- ).not.toHaveBeenCalled();
- });
-
- it('adjusts the warm usage counter instead of flushing it', async () => {
- billingUsageCacheService.getAvailableCredits.mockResolvedValue(500_000);
-
- await service.grantCredits(params);
-
- expect(
- billingUsageCacheService.adjustAvailableCredits,
- ).toHaveBeenCalledWith(workspaceId, PERIOD_START, 2_000_000);
- });
-
- it('leaves a cold usage counter cold', async () => {
- billingUsageCacheService.getAvailableCredits.mockResolvedValue(undefined);
-
- await service.grantCredits(params);
-
- expect(
- billingUsageCacheService.adjustAvailableCredits,
- ).not.toHaveBeenCalled();
- });
-
- // The first attempt can insert the row and then fail on the refresh, so a
- // replay has to repair the projections rather than assume they are built.
- it('repairs derived state on a replayed grant without moving the counter', async () => {
- billingCreditGrantService.createGrant.mockResolvedValue(null);
-
- const grant = await service.grantCredits({
- ...params,
- idempotencyKey: 'onboarding-import-contacts:ws_123',
- });
-
- expect(grant).toBeNull();
- expect(billingCustomerRepository.update).toHaveBeenCalledWith(
- workspaceId,
- {},
- { creditBalanceMicro: 2_000_000 },
- );
- expect(
- billingUsageCacheService.invalidateAvailableCredits,
- ).toHaveBeenCalledWith(workspaceId, PERIOD_START);
- expect(
- billingUsageCacheService.adjustAvailableCredits,
- ).not.toHaveBeenCalled();
- expect(
- billingUsageCapService.clearHasReachedCapForWorkspace,
- ).toHaveBeenCalledWith(workspaceId);
- });
-
- // A reader that missed the counter before the grant landed would otherwise
- // warm it from a balance predating the grant, and that value would stand
- // until the period ended.
- // A reader can only warm the counter while holding the same lock this
- // write holds, so it cannot be mid-computation, and the next reader to take
- // the lock sees a ledger that already contains this grant.
- it('leaves a cold counter alone rather than seeding it', async () => {
- billingUsageCacheService.getAvailableCredits.mockResolvedValue(undefined);
-
- await service.grantCredits(params);
-
- expect(
- billingUsageCacheService.adjustAvailableCredits,
- ).not.toHaveBeenCalled();
- expect(
- billingUsageCacheService.invalidateAvailableCredits,
- ).not.toHaveBeenCalled();
- });
-
- it('no-ops when billing is disabled', async () => {
- billingService.isBillingEnabled.mockReturnValue(false);
-
- const grant = await service.grantCredits(params);
-
- expect(grant).toBeNull();
- expect(billingCreditGrantService.createGrant).not.toHaveBeenCalled();
- });
- });
-
- describe('revokeGrant', () => {
- it('marks the grant revoked and moves the counter under the workspace credit state lock', async () => {
- await service.revokeGrant({ workspaceId, grantId: 'grant_1' });
-
- expect(cacheLockService.withLock).toHaveBeenCalledWith(
- expect.any(Function),
- `billing-credit-state:${workspaceId}`,
- );
- expect(billingCreditGrantService.revokeGrant).toHaveBeenCalled();
- });
-
- it('takes the revoked amount back off the warm usage counter', async () => {
- billingUsageCacheService.getAvailableCredits.mockResolvedValue(3_000_000);
- billingCreditGrantService.getActiveCreditsMicro.mockResolvedValue(0);
-
- await service.revokeGrant({ workspaceId, grantId: 'grant_1' });
-
- expect(
- billingUsageCacheService.adjustAvailableCredits,
- ).toHaveBeenCalledWith(workspaceId, PERIOD_START, -2_000_000);
- expect(billingCustomerRepository.update).toHaveBeenCalledWith(
- workspaceId,
- {},
- { creditBalanceMicro: 0 },
- );
- });
-
- // The mutation takes any grant id and a grant can expire between the admin
- // panel rendering and the revoke landing. Those credits were never in the
- // counter, so taking them off would block usage until the period ends.
- it.each([
- [
- 'expired',
- {
- effectiveAt: new Date(Date.now() - 40 * DAY_IN_MS),
- expiresAt: new Date(Date.now() - 1 * DAY_IN_MS),
- },
- ],
- [
- 'not yet effective',
- {
- effectiveAt: new Date(Date.now() + 1 * DAY_IN_MS),
- expiresAt: new Date(Date.now() + 40 * DAY_IN_MS),
- },
- ],
- ])(
- 'leaves the usage counter alone when revoking a grant that was %s',
- async (_label, window) => {
- billingUsageCacheService.getAvailableCredits.mockResolvedValue(
- 3_000_000,
- );
- billingCreditGrantService.revokeGrant.mockResolvedValue({
- grant: {
- id: 'grant_1',
- amountMicro: 2_000_000,
- revokedAt: new Date(),
- ...window,
- },
- wasRevokedNow: true,
- });
-
- await service.revokeGrant({ workspaceId, grantId: 'grant_1' });
-
- expect(
- billingUsageCacheService.adjustAvailableCredits,
- ).not.toHaveBeenCalled();
- },
- );
-
- // The attempt that did revoke failed before reaching the counter, so the
- // revoked credits are still spendable and only a rebuild from the ledger
- // can repair that without decrementing a second time.
- it('rebuilds the counter when the first revoke never reached it', async () => {
- billingUsageCacheService.hasCounterAdjustmentBeenApplied.mockResolvedValue(
- false,
- );
- billingCreditGrantService.getActiveCreditsMicro.mockResolvedValue(0);
- billingCreditGrantService.revokeGrant.mockResolvedValue({
- grant: { id: 'grant_1', amountMicro: 2_000_000 },
- wasRevokedNow: false,
- });
-
- await service.revokeGrant({ workspaceId, grantId: 'grant_1' });
-
- expect(
- billingUsageCacheService.invalidateAvailableCredits,
- ).toHaveBeenCalledWith(workspaceId, PERIOD_START);
- expect(
- billingUsageCacheService.adjustAvailableCredits,
- ).not.toHaveBeenCalled();
- });
-
- it('records that a revocation moved the counter so a retry can tell', async () => {
- await service.revokeGrant({ workspaceId, grantId: 'grant_1' });
-
- expect(
- billingUsageCacheService.markCounterAdjustmentApplied,
- ).toHaveBeenCalledWith(workspaceId, 'revoke:grant_1', PERIOD_END);
- });
-
- // The first attempt recorded that it moved the counter, so the retry must
- // not move it again and must not rebuild either.
- it('leaves the counter alone when the first revoke already adjusted it', async () => {
- billingUsageCacheService.hasCounterAdjustmentBeenApplied.mockResolvedValue(
- true,
- );
- billingUsageCacheService.getAvailableCredits.mockResolvedValue(3_000_000);
- billingCreditGrantService.getActiveCreditsMicro.mockResolvedValue(0);
- billingCreditGrantService.revokeGrant.mockResolvedValue({
- grant: { id: 'grant_1', amountMicro: 2_000_000 },
- wasRevokedNow: false,
- });
-
- await service.revokeGrant({ workspaceId, grantId: 'grant_1' });
-
- expect(
- billingUsageCacheService.adjustAvailableCredits,
- ).not.toHaveBeenCalled();
- expect(
- billingUsageCacheService.invalidateAvailableCredits,
- ).not.toHaveBeenCalled();
- expect(billingCustomerRepository.update).toHaveBeenCalledWith(
- workspaceId,
- {},
- { creditBalanceMicro: 0 },
- );
- expect(
- billingUsageCapService.clearHasReachedCapForWorkspace,
- ).not.toHaveBeenCalled();
- });
-
- it('leaves the cap in place when the revoke empties the balance', async () => {
- billingCreditGrantService.getActiveCreditsMicro.mockResolvedValue(0);
-
- await service.revokeGrant({ workspaceId, grantId: 'grant_1' });
-
- expect(
- billingUsageCapService.clearHasReachedCapForWorkspace,
- ).not.toHaveBeenCalled();
- });
-
- // Taking credits away can never make the workspace spendable again: the
- // grants it leaves behind may already be spent, and the ledger total says
- // nothing about that.
- it('leaves the cap in place even when the revoke leaves other credits behind', async () => {
- billingCreditGrantService.getActiveCreditsMicro.mockResolvedValue(
- 500_000,
- );
-
- await service.revokeGrant({ workspaceId, grantId: 'grant_1' });
-
- expect(
- billingUsageCapService.clearHasReachedCapForWorkspace,
- ).not.toHaveBeenCalled();
- });
- });
-
- describe('refreshWorkspaceCreditState', () => {
- // Stripe redelivers events it already handled. The grants are still live in
- // the ledger, but the workspace may have spent them since, and this replay
- // adds nothing on top.
- it('leaves the cap in place when a replay finds the counter already moved', async () => {
- billingUsageCacheService.hasCounterAdjustmentBeenApplied.mockResolvedValue(
- true,
- );
-
- await service.refreshWorkspaceCreditState({
- workspaceId,
- availableDeltaMicro: 0,
- addsCredits: true,
- isReplay: true,
- adjustmentKey: 'rollover:2026-02-01T00:00:00.000Z',
- });
-
- expect(
- billingUsageCapService.clearHasReachedCapForWorkspace,
- ).not.toHaveBeenCalled();
- });
-
- // The delivery that wrote the grants never reached the counter, so this one
- // rebuilds it and the credits become spendable here.
- it('lifts the cap when a replay rebuilds the counter', async () => {
- billingUsageCacheService.hasCounterAdjustmentBeenApplied.mockResolvedValue(
- false,
- );
-
- await service.refreshWorkspaceCreditState({
- workspaceId,
- availableDeltaMicro: 0,
- addsCredits: true,
- isReplay: true,
- adjustmentKey: 'rollover:2026-02-01T00:00:00.000Z',
- });
-
- expect(
- billingUsageCapService.clearHasReachedCapForWorkspace,
- ).toHaveBeenCalledWith(workspaceId);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-subscription-update.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-subscription-update.service.spec.ts
deleted file mode 100644
index 0812ecc1e4e..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-subscription-update.service.spec.ts
+++ /dev/null
@@ -1,1569 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { type Repository } from 'typeorm';
-
-import type Stripe from 'stripe';
-
-import { BillingPriceEntity } from 'src/engine/core-modules/billing/entities/billing-price.entity';
-import { BillingSubscriptionItemEntity } from 'src/engine/core-modules/billing/entities/billing-subscription-item.entity';
-import { BillingSubscriptionEntity } from 'src/engine/core-modules/billing/entities/billing-subscription.entity';
-import { BillingPlanKey } from 'src/engine/core-modules/billing/enums/billing-plan-key.enum';
-import { SubscriptionInterval } from 'src/engine/core-modules/billing/enums/billing-subscription-interval.enum';
-import { SubscriptionStatus } from 'src/engine/core-modules/billing/enums/billing-subscription-status.enum';
-import { BillingPriceService } from 'src/engine/core-modules/billing/services/billing-price.service';
-import { BillingProductService } from 'src/engine/core-modules/billing/services/billing-product.service';
-import { BillingSubscriptionPhaseService } from 'src/engine/core-modules/billing/services/billing-subscription-phase.service';
-import { BillingSubscriptionUpdateService } from 'src/engine/core-modules/billing/services/billing-subscription-update.service';
-import { BillingSubscriptionService } from 'src/engine/core-modules/billing/services/billing-subscription.service';
-import { ResourceCreditService } from 'src/engine/core-modules/billing/services/resource-credit.service';
-import { StripeInvoiceService } from 'src/engine/core-modules/billing/stripe/services/stripe-invoice.service';
-import { StripeSubscriptionScheduleService } from 'src/engine/core-modules/billing/stripe/services/stripe-subscription-schedule.service';
-import { StripeSubscriptionService } from 'src/engine/core-modules/billing/stripe/services/stripe-subscription.service';
-import { SubscriptionUpdateType } from 'src/engine/core-modules/billing/types/billing-subscription-update.type';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { type WorkspaceScopedRepository } from 'src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository';
-import {
- arrangeBillingPriceRepositoryFindOneOrFail,
- arrangeBillingProductServiceGetProductPrices,
- arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams,
- arrangeBillingSubscriptionRepositoryFindOneOrFail,
- arrangeStripeSubscriptionScheduleServiceCreateSubscriptionSchedule,
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule,
- buildBillingPriceEntity,
- buildDefaultMeteredTiers,
- buildSchedulePhase,
- repoMock,
-} from './utils/mock-builders.util';
-import {
- LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- LICENSE_PRICE_PRO_MONTH_ID,
- LICENSE_PRICE_PRO_YEAR_ID,
- METER_PRICE_ENTERPRISE_MONTH_ID,
- METER_PRICE_ENTERPRISE_YEAR_ID,
- METER_PRICE_PRO_MONTH_ID,
- METER_PRICE_PRO_YEAR_ID,
-} from './utils/price.constants';
-
-describe('BillingSubscriptionUpdateService', () => {
- let module: TestingModule;
- let service: BillingSubscriptionUpdateService;
- let billingSubscriptionRepository: jest.Mocked<
- WorkspaceScopedRepository<BillingSubscriptionEntity>
- >;
- let billingPriceRepository: jest.Mocked<Repository<BillingPriceEntity>>;
- let billingProductService: jest.Mocked<BillingProductService>;
- let stripeSubscriptionScheduleService: jest.Mocked<StripeSubscriptionScheduleService>;
- let stripeSubscriptionService: jest.Mocked<StripeSubscriptionService>;
- let billingSubscriptionPhaseService: jest.Mocked<BillingSubscriptionPhaseService>;
- let billingSubscriptionService: jest.Mocked<BillingSubscriptionService>;
-
- beforeEach(async () => {
- module = await Test.createTestingModule({
- providers: [
- BillingSubscriptionUpdateService,
- {
- provide: StripeInvoiceService,
- useValue: {
- createImmediateUpgradeInvoice: jest
- .fn()
- .mockResolvedValue(undefined),
- },
- },
- {
- provide: BillingSubscriptionService,
- useValue: {
- syncSubscriptionToDatabase: jest
- .fn()
- .mockResolvedValue({} as BillingSubscriptionEntity),
- },
- },
- {
- provide: BillingProductService,
- useValue: {
- getProductPrices: jest.fn(),
- },
- },
- {
- provide: StripeSubscriptionScheduleService,
- useValue: {
- loadSubscriptionSchedule: jest.fn(),
- createSubscriptionSchedule: jest.fn(),
- updateSchedule: jest.fn().mockResolvedValue({}),
- releaseSubscriptionSchedule: jest.fn(),
- getSubscriptionWithSchedule: jest.fn(),
- },
- },
- {
- provide: StripeSubscriptionService,
- useValue: {
- updateSubscription: jest.fn().mockResolvedValue({}),
- },
- },
- {
- provide: BillingSubscriptionPhaseService,
- useValue: {
- toPhaseUpdateParams: jest.fn(),
- buildPhaseUpdateParams: jest.fn().mockImplementation(
- ({
- toUpdatePrices,
- startDate,
- endDate,
- }: {
- toUpdatePrices: {
- licensedPriceId: string;
- seats: number;
- resourceCreditPriceId: string;
- };
- startDate: Stripe.SubscriptionScheduleUpdateParams.Phase['start_date'];
- endDate: number | undefined;
- }) => ({
- start_date: startDate,
- ...(endDate ? { end_date: endDate } : {}),
- proration_behavior: 'none',
- items: [
- {
- price: toUpdatePrices.licensedPriceId,
- quantity: toUpdatePrices.seats,
- },
- {
- price: toUpdatePrices.resourceCreditPriceId,
- quantity: 1,
- },
- ],
- }),
- ),
- isSamePhaseSignature: jest.fn().mockResolvedValue(false),
- },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(BillingSubscriptionEntity),
- useValue: repoMock<BillingSubscriptionEntity>(),
- },
- {
- provide: getRepositoryToken(BillingPriceEntity),
- useValue: repoMock<BillingPriceEntity>(),
- },
- {
- provide: getRepositoryToken(BillingSubscriptionItemEntity),
- useValue: repoMock<BillingSubscriptionItemEntity>(),
- },
- {
- provide: ResourceCreditService,
- useValue: {
- extractResourceCreditPricingInfo: jest
- .fn()
- .mockReturnValue({ tierCap: 1000, unitPriceCents: 10 }),
- },
- },
- BillingPriceService,
- ],
- }).compile();
-
- service = module.get(BillingSubscriptionUpdateService);
- billingSubscriptionRepository = module.get(
- getWorkspaceScopedRepositoryToken(BillingSubscriptionEntity),
- );
- billingPriceRepository = module.get(getRepositoryToken(BillingPriceEntity));
- billingProductService = module.get(BillingProductService);
- stripeSubscriptionScheduleService = module.get(
- StripeSubscriptionScheduleService,
- );
- stripeSubscriptionService = module.get(StripeSubscriptionService);
- billingSubscriptionPhaseService = module.get(
- BillingSubscriptionPhaseService,
- );
- billingSubscriptionService = module.get(BillingSubscriptionService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('updateSubscription - Plan update', () => {
- it('should update from PRO to ENTERPRISE - without schedule', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {},
- );
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.PLAN,
- newPlan: BillingPlanKey.ENTERPRISE,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- quantity: 1,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_ENTERPRISE_MONTH_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'always_invoice',
- metadata: { plan: BillingPlanKey.ENTERPRISE },
- },
- );
- expect(
- stripeSubscriptionScheduleService.updateSchedule,
- ).not.toHaveBeenCalled();
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should update from PRO to ENTERPRISE during trial without immediate invoicing', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 1,
- status: SubscriptionStatus.Trialing,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {},
- );
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.PLAN,
- newPlan: BillingPlanKey.ENTERPRISE,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- quantity: 1,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_ENTERPRISE_MONTH_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'none',
- metadata: { plan: BillingPlanKey.ENTERPRISE },
- },
- );
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should update from PRO to ENTERPRISE - with schedule', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- [LICENSE_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }),
- [METER_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- const currentPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_PRO_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_PRO_YEAR_ID,
- seats: 1,
- });
- const nextPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 1,
- });
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- const refreshedCurrentPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_YEAR_ID,
- seats: 1,
- });
-
- jest
- .spyOn(stripeSubscriptionScheduleService, 'loadSubscriptionSchedule')
- .mockResolvedValueOnce({
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase,
- nextPhase,
- })
- .mockResolvedValueOnce({
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase: refreshedCurrentPhase,
- nextPhase,
- });
-
- arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams(
- billingSubscriptionPhaseService,
- {
- items: currentPhase.items,
- } as Stripe.SubscriptionScheduleUpdateParams.Phase,
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.PLAN,
- newPlan: BillingPlanKey.ENTERPRISE,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- quantity: 1,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_ENTERPRISE_MONTH_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'always_invoice',
- metadata: { plan: BillingPlanKey.ENTERPRISE },
- },
- );
- expect(
- stripeSubscriptionScheduleService.updateSchedule,
- ).toHaveBeenCalledWith('schedule_1', {
- phases: [
- expect.objectContaining({ items: currentPhase.items }),
- expect.objectContaining({
- items: [
- { price: LICENSE_PRICE_ENTERPRISE_MONTH_ID, quantity: 1 },
- { price: METER_PRICE_ENTERPRISE_MONTH_ID, quantity: 1 },
- ],
- }),
- ],
- });
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should update from ENTERPRISE to PRO - without schedule', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_ENTERPRISE_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_ENTERPRISE_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {},
- );
-
- const currentPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- seats: 1,
- });
-
- arrangeStripeSubscriptionScheduleServiceCreateSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- currentPhase,
- );
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams(
- billingSubscriptionPhaseService,
- {
- items: currentPhase.items,
- } as Stripe.SubscriptionScheduleUpdateParams.Phase,
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.PLAN,
- newPlan: BillingPlanKey.PRO,
- });
-
- expect(
- stripeSubscriptionScheduleService.createSubscriptionSchedule,
- ).toHaveBeenCalled();
- expect(
- stripeSubscriptionScheduleService.updateSchedule,
- ).toHaveBeenCalledWith('schedule_1', {
- phases: [
- expect.objectContaining({ items: currentPhase.items }),
- expect.objectContaining({
- items: [
- { price: LICENSE_PRICE_PRO_MONTH_ID, quantity: 1 },
- { price: METER_PRICE_PRO_MONTH_ID, quantity: 1 },
- ],
- }),
- ],
- });
- expect(
- stripeSubscriptionService.updateSubscription,
- ).not.toHaveBeenCalled();
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should update from ENTERPRISE to PRO - with schedule', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_ENTERPRISE_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_ENTERPRISE_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- [LICENSE_PRICE_ENTERPRISE_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }),
- [METER_PRICE_ENTERPRISE_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_YEAR_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- const currentPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_YEAR_ID,
- seats: 1,
- });
- const nextPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- seats: 1,
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase,
- nextPhase,
- },
- );
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams(
- billingSubscriptionPhaseService,
- {
- items: currentPhase.items,
- } as Stripe.SubscriptionScheduleUpdateParams.Phase,
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.PLAN,
- newPlan: BillingPlanKey.PRO,
- });
-
- expect(
- stripeSubscriptionScheduleService.updateSchedule,
- ).toHaveBeenCalledWith('schedule_1', {
- phases: [
- expect.objectContaining({ items: currentPhase.items }),
- expect.objectContaining({
- items: [
- { price: LICENSE_PRICE_PRO_MONTH_ID, quantity: 1 },
- { price: METER_PRICE_PRO_MONTH_ID, quantity: 1 },
- ],
- }),
- ],
- });
- expect(
- stripeSubscriptionService.updateSubscription,
- ).not.toHaveBeenCalled();
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
- });
-
- describe('updateSubscription - Interval update', () => {
- it('should change interval from monthly to yearly - without schedule', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {},
- );
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.INTERVAL,
- newInterval: SubscriptionInterval.Year,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_PRO_YEAR_ID,
- quantity: 1,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_PRO_YEAR_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'create_prorations',
- billing_cycle_anchor: 'now',
- },
- );
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should change interval from monthly to yearly during trial without resetting billing anchor', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 1,
- status: SubscriptionStatus.Trialing,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {},
- );
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.INTERVAL,
- newInterval: SubscriptionInterval.Year,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_PRO_YEAR_ID,
- quantity: 1,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_PRO_YEAR_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'none',
- },
- );
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should change interval from monthly to yearly - with schedule (ENTERPRISE monthly to PRO yearly downgrade)', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_ENTERPRISE_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_ENTERPRISE_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- [LICENSE_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }),
- [METER_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- const currentPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- seats: 1,
- });
- const nextPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_PRO_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_PRO_YEAR_ID,
- seats: 1,
- });
-
- jest
- .spyOn(stripeSubscriptionScheduleService, 'loadSubscriptionSchedule')
- .mockResolvedValueOnce({
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase,
- nextPhase,
- })
- .mockResolvedValueOnce({
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase: buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_YEAR_ID,
- seats: 1,
- }),
- nextPhase,
- });
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_YEAR_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams(
- billingSubscriptionPhaseService,
- {
- items: currentPhase.items,
- } as Stripe.SubscriptionScheduleUpdateParams.Phase,
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.INTERVAL,
- newInterval: SubscriptionInterval.Year,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- quantity: 1,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_ENTERPRISE_YEAR_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'create_prorations',
- billing_cycle_anchor: 'now',
- },
- );
- expect(
- stripeSubscriptionScheduleService.updateSchedule,
- ).toHaveBeenCalledWith('schedule_1', {
- phases: [
- expect.objectContaining({ items: currentPhase.items }),
- expect.objectContaining({
- items: [
- { price: LICENSE_PRICE_PRO_YEAR_ID, quantity: 1 },
- { price: METER_PRICE_PRO_YEAR_ID, quantity: 1 },
- ],
- }),
- ],
- });
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should change interval from yearly to monthly - without schedule', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- licensedPriceId: LICENSE_PRICE_PRO_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_PRO_YEAR_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }),
- [METER_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {},
- );
-
- const currentPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_PRO_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_PRO_YEAR_ID,
- seats: 1,
- });
-
- arrangeStripeSubscriptionScheduleServiceCreateSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- currentPhase,
- );
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams(
- billingSubscriptionPhaseService,
- {
- items: currentPhase.items,
- } as Stripe.SubscriptionScheduleUpdateParams.Phase,
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.INTERVAL,
- newInterval: SubscriptionInterval.Month,
- });
-
- expect(
- stripeSubscriptionScheduleService.createSubscriptionSchedule,
- ).toHaveBeenCalled();
- expect(
- stripeSubscriptionScheduleService.updateSchedule,
- ).toHaveBeenCalledWith('schedule_1', {
- phases: [
- expect.objectContaining({ items: currentPhase.items }),
- expect.objectContaining({
- items: [
- { price: LICENSE_PRICE_PRO_MONTH_ID, quantity: 1 },
- { price: METER_PRICE_PRO_MONTH_ID, quantity: 1 },
- ],
- }),
- ],
- });
- expect(
- stripeSubscriptionService.updateSubscription,
- ).not.toHaveBeenCalled();
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should change interval from yearly to monthly - with schedule (ENTERPRISE yearly to PRO monthly downgrade)', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Year,
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_YEAR_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_ENTERPRISE_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }),
- [METER_PRICE_ENTERPRISE_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_YEAR_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- [LICENSE_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- const currentPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_YEAR_ID,
- seats: 1,
- });
- const nextPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 1,
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase,
- nextPhase,
- },
- );
-
- arrangeBillingProductServiceGetProductPrices(billingProductService, [
- buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }) as BillingPriceEntity,
- buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }) as BillingPriceEntity,
- ]);
-
- arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams(
- billingSubscriptionPhaseService,
- {
- items: currentPhase.items,
- } as Stripe.SubscriptionScheduleUpdateParams.Phase,
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.INTERVAL,
- newInterval: SubscriptionInterval.Month,
- });
-
- expect(
- stripeSubscriptionScheduleService.updateSchedule,
- ).toHaveBeenCalledWith('schedule_1', {
- phases: [
- expect.objectContaining({ items: currentPhase.items }),
- expect.objectContaining({
- items: [
- { price: LICENSE_PRICE_PRO_MONTH_ID, quantity: 1 },
- { price: METER_PRICE_PRO_MONTH_ID, quantity: 1 },
- ],
- }),
- ],
- });
- expect(
- stripeSubscriptionService.updateSubscription,
- ).not.toHaveBeenCalled();
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
- });
-
- describe('updateSubscription - Seats update', () => {
- it('should change seats from 1 to 2 - without schedule', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {},
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.SEATS,
- newSeats: 2,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_PRO_MONTH_ID,
- quantity: 2,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_PRO_MONTH_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'always_invoice',
- },
- );
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should change seats from 1 to 2 - with schedule (ENTERPRISE monthly to PRO yearly downgrade)', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- seats: 1,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_ENTERPRISE_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_ENTERPRISE_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- planKey: BillingPlanKey.ENTERPRISE,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- [LICENSE_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }),
- [METER_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- const currentPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- seats: 1,
- });
- const nextPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_PRO_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_PRO_YEAR_ID,
- seats: 1,
- });
-
- jest
- .spyOn(stripeSubscriptionScheduleService, 'loadSubscriptionSchedule')
- .mockResolvedValueOnce({
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase,
- nextPhase,
- })
- .mockResolvedValueOnce({
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase: buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_ENTERPRISE_MONTH_ID,
- seats: 2,
- }),
- nextPhase,
- });
-
- arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams(
- billingSubscriptionPhaseService,
- {
- items: currentPhase.items,
- } as Stripe.SubscriptionScheduleUpdateParams.Phase,
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.SEATS,
- newSeats: 2,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_ENTERPRISE_MONTH_ID,
- quantity: 2,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_ENTERPRISE_MONTH_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'always_invoice',
- },
- );
- expect(
- stripeSubscriptionScheduleService.updateSchedule,
- ).toHaveBeenCalledWith('schedule_1', {
- phases: [
- expect.objectContaining({ items: currentPhase.items }),
- expect.objectContaining({
- items: [
- { price: LICENSE_PRICE_PRO_YEAR_ID, quantity: 2 },
- { price: METER_PRICE_PRO_YEAR_ID, quantity: 1 },
- ],
- }),
- ],
- });
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should change seats from 2 to 1 - without schedule', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 2,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule(
- stripeSubscriptionScheduleService,
- {},
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.SEATS,
- newSeats: 1,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_PRO_MONTH_ID,
- quantity: 1,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_PRO_MONTH_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'create_prorations',
- },
- );
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
-
- it('should change seats from 2 to 1 - with schedule', async () => {
- arrangeBillingSubscriptionRepositoryFindOneOrFail(
- billingSubscriptionRepository,
- {
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 2,
- },
- );
-
- arrangeBillingPriceRepositoryFindOneOrFail(billingPriceRepository, {
- [LICENSE_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: false,
- }),
- [METER_PRICE_PRO_MONTH_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_MONTH_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Month,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- [LICENSE_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: LICENSE_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: false,
- }),
- [METER_PRICE_PRO_YEAR_ID]: buildBillingPriceEntity({
- stripePriceId: METER_PRICE_PRO_YEAR_ID,
- planKey: BillingPlanKey.PRO,
- interval: SubscriptionInterval.Year,
- isMetered: true,
- tiers: buildDefaultMeteredTiers(),
- }),
- });
-
- const currentPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 2,
- });
- const nextPhase = buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_PRO_YEAR_ID,
- resourceCreditPriceId: METER_PRICE_PRO_YEAR_ID,
- seats: 2,
- });
-
- jest
- .spyOn(stripeSubscriptionScheduleService, 'loadSubscriptionSchedule')
- .mockResolvedValueOnce({
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase,
- nextPhase,
- })
- .mockResolvedValueOnce({
- schedule: { id: 'schedule_1' } as Stripe.SubscriptionSchedule,
- currentPhase: buildSchedulePhase({
- licensedPriceId: LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId: METER_PRICE_PRO_MONTH_ID,
- seats: 1,
- }),
- nextPhase,
- });
-
- arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams(
- billingSubscriptionPhaseService,
- {
- items: currentPhase.items,
- } as Stripe.SubscriptionScheduleUpdateParams.Phase,
- );
-
- await service.updateSubscription('ws_1', 'sub_db_1', {
- type: SubscriptionUpdateType.SEATS,
- newSeats: 1,
- });
-
- expect(stripeSubscriptionService.updateSubscription).toHaveBeenCalledWith(
- 'sub_1',
- {
- items: [
- {
- id: 'si_licensed',
- price: LICENSE_PRICE_PRO_MONTH_ID,
- quantity: 1,
- },
- {
- id: 'si_resource_credit',
- price: METER_PRICE_PRO_MONTH_ID,
- quantity: 1,
- },
- ],
- proration_behavior: 'create_prorations',
- },
- );
- expect(
- stripeSubscriptionScheduleService.updateSchedule,
- ).toHaveBeenCalledWith('schedule_1', {
- phases: [
- expect.objectContaining({ items: currentPhase.items }),
- expect.objectContaining({
- items: [
- { price: LICENSE_PRICE_PRO_YEAR_ID, quantity: 1 },
- { price: METER_PRICE_PRO_YEAR_ID, quantity: 1 },
- ],
- }),
- ],
- });
- expect(
- billingSubscriptionService.syncSubscriptionToDatabase,
- ).toHaveBeenCalled();
- });
- });
-
- describe('shouldUpdateAtSubscriptionPeriodEnd', () => {
- it('should update plan changes immediately during trial', async () => {
- await expect(
- service.shouldUpdateAtSubscriptionPeriodEnd(
- { status: SubscriptionStatus.Trialing } as BillingSubscriptionEntity,
- {
- type: SubscriptionUpdateType.PLAN,
- newPlan: BillingPlanKey.PRO,
- },
- ),
- ).resolves.toBe(false);
- });
-
- it('should update interval changes immediately during trial', async () => {
- await expect(
- service.shouldUpdateAtSubscriptionPeriodEnd(
- { status: SubscriptionStatus.Trialing } as BillingSubscriptionEntity,
- {
- type: SubscriptionUpdateType.INTERVAL,
- newInterval: SubscriptionInterval.Month,
- },
- ),
- ).resolves.toBe(false);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-usage-cap.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-usage-cap.service.spec.ts
deleted file mode 100644
index afd41098831..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-usage-cap.service.spec.ts
+++ /dev/null
@@ -1,116 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { Not } from 'typeorm';
-
-import { BillingException } from 'src/engine/core-modules/billing/billing.exception';
-import { BillingSubscriptionItemEntity } from 'src/engine/core-modules/billing/entities/billing-subscription-item.entity';
-import { SubscriptionStatus } from 'src/engine/core-modules/billing/enums/billing-subscription-status.enum';
-import { BillingUsageCapService } from 'src/engine/core-modules/billing/services/billing-usage-cap.service';
-
-const workspaceId = 'ws_123';
-
-describe('BillingUsageCapService', () => {
- let service: BillingUsageCapService;
- let billingSubscriptionItemRepository: jest.Mocked<{
- find: jest.Mock;
- update: jest.Mock;
- }>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- BillingUsageCapService,
- {
- provide: getRepositoryToken(BillingSubscriptionItemEntity),
- useValue: {
- find: jest.fn().mockResolvedValue([{ id: 'item_1' }]),
- update: jest.fn().mockResolvedValue({ affected: 1 }),
- },
- },
- ],
- }).compile();
-
- service = module.get<BillingUsageCapService>(BillingUsageCapService);
- billingSubscriptionItemRepository = module.get(
- getRepositoryToken(BillingSubscriptionItemEntity),
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('setSubscriptionItemHasReachedCap', () => {
- it('flags the resource credit item', async () => {
- await service.setSubscriptionItemHasReachedCap(workspaceId, true);
-
- expect(billingSubscriptionItemRepository.update).toHaveBeenCalledWith(
- { id: 'item_1' },
- { hasReachedCurrentPeriodCap: true },
- );
- });
-
- it("looks only at the workspace's non-canceled resource credit items", async () => {
- await service.setSubscriptionItemHasReachedCap(workspaceId, true);
-
- expect(billingSubscriptionItemRepository.find).toHaveBeenCalledWith({
- where: {
- billingSubscription: {
- workspaceId,
- status: Not(SubscriptionStatus.Canceled),
- },
- billingProduct: { metadata: expect.anything() },
- },
- });
- });
-
- it('throws when the workspace has no resource credit item', async () => {
- billingSubscriptionItemRepository.find.mockResolvedValue([]);
-
- await expect(
- service.setSubscriptionItemHasReachedCap(workspaceId, true),
- ).rejects.toThrow(BillingException);
- });
-
- it('throws when the workspace has more than one resource credit item', async () => {
- billingSubscriptionItemRepository.find.mockResolvedValue([
- { id: 'item_1' },
- { id: 'item_2' },
- ]);
-
- await expect(
- service.setSubscriptionItemHasReachedCap(workspaceId, true),
- ).rejects.toThrow(BillingException);
- });
- });
-
- describe('clearHasReachedCapForWorkspace', () => {
- it('clears the flag on every resource credit item', async () => {
- billingSubscriptionItemRepository.find.mockResolvedValue([
- { id: 'item_1' },
- { id: 'item_2' },
- ]);
-
- await service.clearHasReachedCapForWorkspace(workspaceId);
-
- expect(billingSubscriptionItemRepository.update).toHaveBeenCalledWith(
- { id: expect.objectContaining({ _value: ['item_1', 'item_2'] }) },
- { hasReachedCurrentPeriodCap: false },
- );
- });
-
- it('does nothing rather than throwing when there is no item to clear', async () => {
- billingSubscriptionItemRepository.find.mockResolvedValue([]);
-
- await expect(
- service.clearHasReachedCapForWorkspace(workspaceId),
- ).resolves.not.toThrow();
-
- expect(billingSubscriptionItemRepository.update).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-usage.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-usage.service.spec.ts
deleted file mode 100644
index a77551e86c3..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing-usage.service.spec.ts
+++ /dev/null
@@ -1,250 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ClickHouseService } from 'src/database/clickHouse/clickHouse.service';
-import { CoreEntityCacheService } from 'src/engine/core-entity-cache/services/core-entity-cache.service';
-import { BillingSubscriptionEntity } from 'src/engine/core-modules/billing/entities/billing-subscription.entity';
-import { BillingProductKey } from 'src/engine/core-modules/billing/enums/billing-product-key.enum';
-import { SubscriptionStatus } from 'src/engine/core-modules/billing/enums/billing-subscription-status.enum';
-import { BillingCreditGrantService } from 'src/engine/core-modules/billing/services/billing-credit-grant.service';
-import { BillingSubscriptionItemService } from 'src/engine/core-modules/billing/services/billing-subscription-item.service';
-import { BillingSubscriptionService } from 'src/engine/core-modules/billing/services/billing-subscription.service';
-import { BillingUsageCacheService } from 'src/engine/core-modules/billing/services/billing-usage-cache.service';
-import { BillingUsageCapService } from 'src/engine/core-modules/billing/services/billing-usage-cap.service';
-import { BillingUsageService } from 'src/engine/core-modules/billing/services/billing-usage.service';
-import { CacheLockService } from 'src/engine/core-modules/cache-lock/cache-lock.service';
-import {
- CacheLockException,
- CacheLockExceptionCode,
-} from 'src/engine/core-modules/cache-lock/exceptions/cache-lock.exception';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-const workspaceId = 'ws_123';
-const PERIOD_START = new Date('2026-01-01T00:00:00.000Z');
-const PERIOD_END = new Date('2026-02-01T00:00:00.000Z');
-const ALLOWANCE = 1_000_000;
-
-const currentBillingSubscription = {
- workspaceId,
- status: SubscriptionStatus.Active,
- currentPeriodStart: PERIOD_START,
- currentPeriodEnd: PERIOD_END,
-};
-
-const subscriptionWithAllowance = {
- workspaceId,
- status: SubscriptionStatus.Active,
- currentPeriodStart: PERIOD_START,
- currentPeriodEnd: PERIOD_END,
- billingSubscriptionItems: [
- {
- stripePriceId: 'price_1',
- billingProduct: {
- metadata: { productKey: BillingProductKey.RESOURCE_CREDIT },
- billingPrices: [
- {
- stripePriceId: 'price_1',
- metadata: { credit_amount: String(ALLOWANCE) },
- },
- ],
- },
- },
- ],
-};
-
-describe('BillingUsageService', () => {
- let service: BillingUsageService;
- let billingUsageCacheService: jest.Mocked<{
- getAvailableCredits: jest.Mock;
- warmAvailableCredits: jest.Mock;
- adjustAvailableCredits: jest.Mock;
- }>;
- let billingCreditGrantService: jest.Mocked<{
- getSpendableCreditsMicro: jest.Mock;
- }>;
- let cacheLockService: jest.Mocked<{ withLock: jest.Mock }>;
- let clickHouseService: jest.Mocked<{ select: jest.Mock }>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- BillingUsageService,
- {
- provide: BillingCreditGrantService,
- useValue: {
- getSpendableCreditsMicro: jest.fn().mockResolvedValue(0),
- },
- },
- {
- provide: BillingSubscriptionService,
- useValue: {
- getTrialPeriodFreeWorkflowCredits: jest.fn().mockReturnValue(0),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: { get: jest.fn().mockReturnValue(true) },
- },
- {
- provide: BillingSubscriptionItemService,
- useValue: {
- getResourceCreditSubscriptionItemDetails: jest.fn(),
- },
- },
- {
- provide: BillingUsageCacheService,
- useValue: {
- getAvailableCredits: jest.fn().mockResolvedValue(undefined),
- warmAvailableCredits: jest.fn().mockResolvedValue(undefined),
- adjustAvailableCredits: jest.fn().mockResolvedValue(0),
- },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(BillingSubscriptionEntity),
- useValue: {
- findOne: jest.fn().mockResolvedValue(subscriptionWithAllowance),
- },
- },
- {
- provide: WorkspaceCacheService,
- useValue: {
- getOrRecompute: jest
- .fn()
- .mockResolvedValue({ currentBillingSubscription }),
- },
- },
- {
- provide: ClickHouseService,
- useValue: { select: jest.fn().mockResolvedValue([{ total: 0 }]) },
- },
- {
- provide: BillingUsageCapService,
- useValue: {
- setSubscriptionItemHasReachedCap: jest
- .fn()
- .mockResolvedValue(undefined),
- },
- },
- {
- provide: CacheLockService,
- useValue: { withLock: jest.fn((fn: () => unknown) => fn()) },
- },
- {
- provide: CoreEntityCacheService,
- useValue: { get: jest.fn().mockResolvedValue(undefined) },
- },
- ],
- }).compile();
-
- service = module.get<BillingUsageService>(BillingUsageService);
- billingUsageCacheService = module.get(BillingUsageCacheService);
- billingCreditGrantService = module.get(BillingCreditGrantService);
- cacheLockService = module.get(CacheLockService);
- clickHouseService = module.get(ClickHouseService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('hasAvailableCredits', () => {
- it('answers from the warm counter without taking the lock', async () => {
- billingUsageCacheService.getAvailableCredits.mockResolvedValue(500);
-
- expect(await service.hasAvailableCredits(workspaceId)).toBe(true);
- expect(cacheLockService.withLock).not.toHaveBeenCalled();
- expect(clickHouseService.select).not.toHaveBeenCalled();
- });
-
- // Computing from the ledger and warming the counter are a read and a write
- // that a concurrent grant must not slip between, or the grant is counted
- // here and then added to the counter a second time.
- it('takes the credit state lock before computing a cold counter', async () => {
- expect(await service.hasAvailableCredits(workspaceId)).toBe(true);
-
- expect(cacheLockService.withLock).toHaveBeenCalledWith(
- expect.any(Function),
- `billing-credit-state:${workspaceId}`,
- expect.any(Object),
- );
- expect(billingUsageCacheService.warmAvailableCredits).toHaveBeenCalled();
- });
-
- it('skips the recompute when another reader warmed the counter first', async () => {
- billingUsageCacheService.getAvailableCredits
- .mockResolvedValueOnce(undefined)
- .mockResolvedValue(400);
-
- expect(await service.hasAvailableCredits(workspaceId)).toBe(true);
- expect(clickHouseService.select).not.toHaveBeenCalled();
- expect(
- billingUsageCacheService.warmAvailableCredits,
- ).not.toHaveBeenCalled();
- });
-
- // Failing the execution because someone is writing a grant would be worse
- // than answering from a value this call computed itself. It must not warm
- // though: holding the lock is what makes installing a value safe.
- it('computes without warming rather than failing when the lock times out', async () => {
- cacheLockService.withLock.mockRejectedValue(
- new CacheLockException(
- 'Failed to acquire lock',
- CacheLockExceptionCode.LOCK_ACQUISITION_TIMEOUT,
- ),
- );
-
- expect(await service.hasAvailableCredits(workspaceId)).toBe(true);
- expect(
- billingUsageCacheService.warmAvailableCredits,
- ).not.toHaveBeenCalled();
- });
-
- it('propagates failures that are not a lock timeout', async () => {
- cacheLockService.withLock.mockRejectedValue(new Error('redis is down'));
-
- await expect(service.hasAvailableCredits(workspaceId)).rejects.toThrow(
- 'redis is down',
- );
- });
- });
-
- describe('decrementAvailableCreditsInCache', () => {
- it('decrements the warm counter without taking the lock', async () => {
- billingUsageCacheService.getAvailableCredits.mockResolvedValue(500);
- billingUsageCacheService.adjustAvailableCredits.mockResolvedValue(300);
-
- expect(
- await service.decrementAvailableCreditsInCache({
- workspaceId,
- usedCredits: 200,
- }),
- ).toBe(300);
- expect(cacheLockService.withLock).not.toHaveBeenCalled();
- });
-
- // Incrementing an absent key would install -usedCredits as the whole
- // balance, so a call that could not warm the counter only computes.
- it('subtracts locally when the lock timed out and nothing was warmed', async () => {
- billingCreditGrantService.getSpendableCreditsMicro.mockResolvedValue(0);
- cacheLockService.withLock.mockRejectedValue(
- new CacheLockException(
- 'Failed to acquire lock',
- CacheLockExceptionCode.LOCK_ACQUISITION_TIMEOUT,
- ),
- );
-
- expect(
- await service.decrementAvailableCreditsInCache({
- workspaceId,
- usedCredits: 200,
- }),
- ).toBe(ALLOWANCE - 200);
- expect(
- billingUsageCacheService.adjustAvailableCredits,
- ).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing.service.spec.ts
deleted file mode 100644
index 7265bc8894e..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/billing.service.spec.ts
+++ /dev/null
@@ -1,94 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { BillingCustomerEntity } from 'src/engine/core-modules/billing/entities/billing-customer.entity';
-import { BillingSubscriptionEntity } from 'src/engine/core-modules/billing/entities/billing-subscription.entity';
-import { BillingProductService } from 'src/engine/core-modules/billing/services/billing-product.service';
-import { BillingSubscriptionService } from 'src/engine/core-modules/billing/services/billing-subscription.service';
-import { BillingService } from 'src/engine/core-modules/billing/services/billing.service';
-import { StripeCustomerService } from 'src/engine/core-modules/billing/stripe/services/stripe-customer.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-
-describe('BillingService', () => {
- let service: BillingService;
- let stripeCustomerService: jest.Mocked<
- Pick<StripeCustomerService, 'createStripeCustomer'>
- >;
- let billingCustomerRepository: jest.Mocked<{ findOne: jest.Mock }>;
-
- const ensureParams = {
- userEmail: '[email protected]',
- workspaceId: 'ws_123',
- workspaceDisplayName: 'Acme',
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- BillingService,
- {
- provide: TwentyConfigService,
- useValue: { get: jest.fn() },
- },
- {
- provide: BillingSubscriptionService,
- useValue: {},
- },
- {
- provide: BillingProductService,
- useValue: {},
- },
- {
- provide: StripeCustomerService,
- useValue: {
- createStripeCustomer: jest
- .fn()
- .mockResolvedValue({ id: 'cus_123' }),
- },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(BillingSubscriptionEntity),
- useValue: { findOne: jest.fn() },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(BillingCustomerEntity),
- useValue: { findOne: jest.fn().mockResolvedValue(null) },
- },
- ],
- }).compile();
-
- service = module.get<BillingService>(BillingService);
- stripeCustomerService = module.get(StripeCustomerService);
- billingCustomerRepository = module.get(
- getWorkspaceScopedRepositoryToken(BillingCustomerEntity),
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('ensureBillingCustomer', () => {
- it('creates a stripe customer when none exists', async () => {
- billingCustomerRepository.findOne.mockResolvedValue(null);
-
- await service.ensureBillingCustomer(ensureParams);
-
- expect(stripeCustomerService.createStripeCustomer).toHaveBeenCalledWith(
- 'ws_123',
- 'Acme',
- );
- });
-
- it('is idempotent when a billing customer already exists', async () => {
- billingCustomerRepository.findOne.mockResolvedValue({ id: 'bc_1' });
-
- await service.ensureBillingCustomer(ensureParams);
-
- expect(stripeCustomerService.createStripeCustomer).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/resource-credit.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/resource-credit.service.spec.ts
deleted file mode 100644
index c46eba2d0b6..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/resource-credit.service.spec.ts
+++ /dev/null
@@ -1,161 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { BillingPriceEntity } from 'src/engine/core-modules/billing/entities/billing-price.entity';
-import { BillingSubscriptionEntity } from 'src/engine/core-modules/billing/entities/billing-subscription.entity';
-import { BillingProductKey } from 'src/engine/core-modules/billing/enums/billing-product-key.enum';
-import { ResourceCreditService } from 'src/engine/core-modules/billing/services/resource-credit.service';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-describe('ResourceCreditService', () => {
- let service: ResourceCreditService;
- let billingSubscriptionRepository: jest.Mocked<any>;
-
- const buildSubscriptionWithResourceCredit = (
- creditAmount: number,
- unitAmount = 0,
- ) => ({
- id: 'sub_123',
- billingSubscriptionItems: [
- {
- stripePriceId: 'price_rc_123',
- billingProduct: {
- metadata: { productKey: BillingProductKey.RESOURCE_CREDIT },
- billingPrices: [
- {
- stripePriceId: 'price_rc_123',
- metadata: { credit_amount: String(creditAmount) },
- unitAmount,
- },
- ],
- },
- },
- ],
- });
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ResourceCreditService,
- {
- provide: getWorkspaceScopedRepositoryToken(BillingSubscriptionEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(BillingPriceEntity),
- useValue: {
- findOneOrFail: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<ResourceCreditService>(ResourceCreditService);
- billingSubscriptionRepository = module.get(
- getWorkspaceScopedRepositoryToken(BillingSubscriptionEntity),
- );
- });
-
- describe('extractResourceCreditPricingInfo', () => {
- it('returns pricing info for a valid resource credit subscription', () => {
- const subscription = buildSubscriptionWithResourceCredit(1000, 10);
-
- const result = service.extractResourceCreditPricingInfo(
- subscription as any,
- );
-
- expect(result).toEqual({ tierCap: 1000, unitPriceCents: 10 });
- });
-
- it('returns null when no RESOURCE_CREDIT item found', () => {
- const subscription = {
- billingSubscriptionItems: [
- {
- stripePriceId: 'price_base',
- billingProduct: {
- metadata: { productKey: BillingProductKey.BASE_PRODUCT },
- billingPrices: [],
- },
- },
- ],
- };
-
- expect(
- service.extractResourceCreditPricingInfo(subscription as any),
- ).toBeNull();
- });
-
- it('returns null when credit_amount is 0', () => {
- const subscription = buildSubscriptionWithResourceCredit(0);
-
- expect(
- service.extractResourceCreditPricingInfo(subscription as any),
- ).toBeNull();
- });
-
- it('returns null when matching price not found', () => {
- const subscription = {
- billingSubscriptionItems: [
- {
- stripePriceId: 'price_rc_different',
- billingProduct: {
- metadata: { productKey: BillingProductKey.RESOURCE_CREDIT },
- billingPrices: [
- {
- stripePriceId: 'price_rc_other',
- metadata: { credit_amount: '500' },
- },
- ],
- },
- },
- ],
- };
-
- expect(
- service.extractResourceCreditPricingInfo(subscription as any),
- ).toBeNull();
- });
- });
-
- describe('getResourceCreditRolloverParameters', () => {
- it('returns parameters when resource credit item found', async () => {
- const subscription = buildSubscriptionWithResourceCredit(5000, 5);
-
- billingSubscriptionRepository.findOne.mockResolvedValue(subscription);
-
- const result = await service.getResourceCreditRolloverParameters(
- 'ws_1',
- 'sub_123',
- );
-
- expect(result).toEqual({ tierQuantity: 5000 });
- });
-
- it('returns null when subscription not found', async () => {
- billingSubscriptionRepository.findOne.mockResolvedValue(null);
-
- const result = await service.getResourceCreditRolloverParameters(
- 'ws_1',
- 'sub_123',
- );
-
- expect(result).toBeNull();
- });
-
- it('returns null when resource credit pricing info not extractable', async () => {
- billingSubscriptionRepository.findOne.mockResolvedValue({
- billingSubscriptionItems: [],
- });
-
- const result = await service.getResourceCreditRolloverParameters(
- 'ws_1',
- 'sub_123',
- );
-
- expect(result).toBeNull();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/utils/build-subscription.util.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/utils/build-subscription.util.ts
deleted file mode 100644
index 185e35770ea..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/utils/build-subscription.util.ts
+++ /dev/null
@@ -1,68 +0,0 @@
-import { type BillingSubscriptionEntity } from 'src/engine/core-modules/billing/entities/billing-subscription.entity';
-import { BillingPlanKey } from 'src/engine/core-modules/billing/enums/billing-plan-key.enum';
-import { BillingProductKey } from 'src/engine/core-modules/billing/enums/billing-product-key.enum';
-import { SubscriptionInterval } from 'src/engine/core-modules/billing/enums/billing-subscription-interval.enum';
-import { SubscriptionStatus } from 'src/engine/core-modules/billing/enums/billing-subscription-status.enum';
-import { BillingUsageType } from 'src/engine/core-modules/billing/enums/billing-usage-type.enum';
-
-import {
- LICENSE_PRICE_PRO_MONTH_ID,
- METER_PRICE_PRO_MONTH_ID,
-} from './price.constants';
-
-export const buildSubscription = ({
- planKey = BillingPlanKey.PRO,
- interval = SubscriptionInterval.Month,
- licensedPriceId = LICENSE_PRICE_PRO_MONTH_ID,
- resourceCreditPriceId = METER_PRICE_PRO_MONTH_ID,
- seats = 1,
- status = SubscriptionStatus.Active,
- workspaceId = 'ws_1',
- stripeSubscriptionId = 'sub_1',
- currentPeriodEnd = new Date(Date.now() + 30 * 24 * 60 * 60 * 1000),
-}: {
- planKey?: BillingPlanKey;
- interval?: SubscriptionInterval;
- licensedPriceId?: string;
- resourceCreditPriceId?: string;
- seats?: number;
- status?: SubscriptionStatus;
- workspaceId?: string;
- stripeSubscriptionId?: string;
- currentPeriodEnd?: Date;
-} = {}): BillingSubscriptionEntity =>
- ({
- id: 'sub_db_1',
- workspaceId,
- stripeSubscriptionId,
- status,
- interval,
- currentPeriodEnd,
- billingSubscriptionItems: [
- {
- stripeSubscriptionItemId: 'si_licensed',
- stripeProductId: 'prod_base',
- stripePriceId: licensedPriceId,
- quantity: seats,
- billingProduct: {
- metadata: {
- planKey,
- productKey: BillingProductKey.BASE_PRODUCT,
- priceUsageBased: BillingUsageType.LICENSED,
- },
- },
- },
- {
- stripeSubscriptionItemId: 'si_resource_credit',
- stripeProductId: 'prod_resource_credit',
- stripePriceId: resourceCreditPriceId,
- billingProduct: {
- metadata: {
- planKey,
- productKey: BillingProductKey.RESOURCE_CREDIT,
- priceUsageBased: BillingUsageType.METERED,
- },
- },
- },
- ],
- }) as BillingSubscriptionEntity;
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/utils/mock-builders.util.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/utils/mock-builders.util.ts
deleted file mode 100644
index 4ad30887823..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/utils/mock-builders.util.ts
+++ /dev/null
@@ -1,219 +0,0 @@
-import { type ObjectLiteral, type Repository } from 'typeorm';
-
-import type Stripe from 'stripe';
-
-import { type BillingPriceEntity } from 'src/engine/core-modules/billing/entities/billing-price.entity';
-import { type BillingSubscriptionEntity } from 'src/engine/core-modules/billing/entities/billing-subscription.entity';
-import { type BillingPlanKey } from 'src/engine/core-modules/billing/enums/billing-plan-key.enum';
-import { BillingProductKey } from 'src/engine/core-modules/billing/enums/billing-product-key.enum';
-import { type SubscriptionInterval } from 'src/engine/core-modules/billing/enums/billing-subscription-interval.enum';
-import { type SubscriptionStatus } from 'src/engine/core-modules/billing/enums/billing-subscription-status.enum';
-import { BillingUsageType } from 'src/engine/core-modules/billing/enums/billing-usage-type.enum';
-import { type BillingProductService } from 'src/engine/core-modules/billing/services/billing-product.service';
-import { type BillingSubscriptionPhaseService } from 'src/engine/core-modules/billing/services/billing-subscription-phase.service';
-import { type StripeSubscriptionScheduleService } from 'src/engine/core-modules/billing/stripe/services/stripe-subscription-schedule.service';
-import { type BillingMeterPrice } from 'src/engine/core-modules/billing/types/billing-meter-price.type';
-import { type WorkspaceScopedRepository } from 'src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository';
-import { buildSubscription } from './build-subscription.util';
-
-export const repoMock = <T extends ObjectLiteral>() =>
- ({
- find: jest.fn(),
- findOne: jest.fn(),
- findOneOrFail: jest.fn(),
- upsert: jest.fn(),
- update: jest.fn(),
- delete: jest.fn(),
- }) as unknown as jest.Mocked<Repository<T>>;
-
-export const buildBillingPriceEntity = ({
- stripePriceId,
- planKey,
- interval,
- isMetered,
- tiers,
-}: {
- stripePriceId: string;
- planKey: BillingPlanKey;
- interval: SubscriptionInterval;
- isMetered: boolean;
- tiers?: Stripe.Price.Tier[];
-}): BillingPriceEntity | BillingMeterPrice =>
- ({
- stripePriceId,
- interval,
- billingProduct: {
- metadata: {
- planKey,
- productKey: isMetered
- ? BillingProductKey.RESOURCE_CREDIT
- : BillingProductKey.BASE_PRODUCT,
- priceUsageBased: isMetered
- ? BillingUsageType.METERED
- : BillingUsageType.LICENSED,
- },
- },
- ...(isMetered
- ? {
- metadata: { credit_amount: '1000' },
- ...(tiers ? { tiers } : {}),
- }
- : {}),
- }) as BillingPriceEntity | BillingMeterPrice;
-
-export const buildDefaultMeteredTiers = (
- upTo: number = 1000,
-): Stripe.Price.Tier[] => [
- {
- up_to: upTo,
- flat_amount: upTo,
- unit_amount: null,
- flat_amount_decimal: String(upTo * 100),
- unit_amount_decimal: null,
- },
- {
- up_to: null,
- flat_amount: null,
- unit_amount: null,
- flat_amount_decimal: null,
- unit_amount_decimal: '100',
- },
-];
-
-export const arrangeBillingSubscriptionRepositoryFindOneOrFail = (
- billingSubscriptionRepository: jest.Mocked<
- WorkspaceScopedRepository<BillingSubscriptionEntity>
- >,
- params: {
- planKey?: BillingPlanKey;
- interval?: SubscriptionInterval;
- licensedPriceId?: string;
- resourceCreditPriceId?: string;
- seats?: number;
- status?: SubscriptionStatus;
- workspaceId?: string;
- stripeSubscriptionId?: string;
- currentPeriodEnd?: Date;
- } = {},
-) =>
- jest
- .spyOn(billingSubscriptionRepository, 'findOneOrFail')
- .mockResolvedValue(buildSubscription(params));
-
-export const arrangeBillingPriceRepositoryFindOneOrFail = (
- billingPriceRepository: jest.Mocked<Repository<BillingPriceEntity>>,
- priceIdToPriceMap: Record<string, BillingPriceEntity | BillingMeterPrice>,
-) => {
- jest
- .spyOn(billingPriceRepository, 'findOneOrFail')
- .mockImplementation(async (criteria: unknown) => {
- const where = (criteria as { where?: { stripePriceId?: string } })?.where;
- const priceId = where?.stripePriceId;
-
- if (priceId && priceIdToPriceMap[priceId]) {
- return priceIdToPriceMap[priceId] as BillingPriceEntity;
- }
-
- return {} as BillingPriceEntity;
- });
-
- jest
- .spyOn(billingPriceRepository, 'find')
- .mockImplementation(async (criteria?: unknown) => {
- const where = (criteria as { where?: { stripePriceId?: unknown } })
- ?.where;
- const stripePriceIdCondition = where?.stripePriceId;
-
- const resolveStripePriceIds = (cond: unknown): string[] => {
- if (typeof cond === 'string') {
- return [cond];
- }
- if (
- cond &&
- typeof cond === 'object' &&
- 'value' in cond &&
- (cond as { value: unknown }).value !== undefined
- ) {
- const value = (cond as { value: string | string[] }).value;
-
- return Array.isArray(value) ? value : [value];
- }
-
- return [];
- };
-
- const stripePriceIds = resolveStripePriceIds(stripePriceIdCondition);
-
- return stripePriceIds
- .map((stripePriceId) => priceIdToPriceMap[stripePriceId])
- .filter(
- (entity): entity is BillingPriceEntity =>
- entity !== null && entity !== undefined,
- );
- });
-};
-
-export const arrangeStripeSubscriptionScheduleServiceLoadSubscriptionSchedule =
- (
- stripeSubscriptionScheduleService: jest.Mocked<StripeSubscriptionScheduleService>,
- result: {
- schedule?: Stripe.SubscriptionSchedule;
- currentPhase?: Stripe.SubscriptionSchedule.Phase;
- nextPhase?: Stripe.SubscriptionSchedule.Phase;
- } = {},
- ) =>
- jest
- .spyOn(stripeSubscriptionScheduleService, 'loadSubscriptionSchedule')
- .mockResolvedValue(result as never);
-
-export const arrangeStripeSubscriptionScheduleServiceCreateSubscriptionSchedule =
- (
- stripeSubscriptionScheduleService: jest.Mocked<StripeSubscriptionScheduleService>,
- currentPhase: Stripe.SubscriptionSchedule.Phase = {} as Stripe.SubscriptionSchedule.Phase,
- ) =>
- jest
- .spyOn(stripeSubscriptionScheduleService, 'createSubscriptionSchedule')
- .mockResolvedValue({
- schedule: {
- id: 'schedule_1',
- } as unknown as Stripe.Response<Stripe.SubscriptionSchedule>,
- currentPhase,
- });
-
-export const arrangeBillingProductServiceGetProductPrices = (
- billingProductService: jest.Mocked<BillingProductService>,
- prices: BillingPriceEntity[],
-) =>
- jest
- .spyOn(billingProductService, 'getProductPrices')
- .mockResolvedValue(prices);
-
-export const arrangeBillingSubscriptionPhaseServiceToPhaseUpdateParams = (
- billingSubscriptionPhaseService: jest.Mocked<BillingSubscriptionPhaseService>,
- result: Stripe.SubscriptionScheduleUpdateParams.Phase = {} as Stripe.SubscriptionScheduleUpdateParams.Phase,
-) =>
- jest
- .spyOn(billingSubscriptionPhaseService, 'toPhaseUpdateParams')
- .mockReturnValue(result);
-
-export const buildSchedulePhase = ({
- licensedPriceId,
- resourceCreditPriceId,
- seats = 1,
- startDate = Math.floor(Date.now() / 1000),
- endDate = Math.floor(Date.now() / 1000) + 30 * 24 * 60 * 60,
-}: {
- licensedPriceId: string;
- resourceCreditPriceId: string;
- seats?: number;
- startDate?: number;
- endDate?: number;
-}): Stripe.SubscriptionSchedule.Phase =>
- ({
- start_date: startDate,
- end_date: endDate,
- items: [
- { price: licensedPriceId, quantity: seats },
- { price: resourceCreditPriceId, quantity: 1 },
- ],
- }) as Stripe.SubscriptionSchedule.Phase;
diff --git a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/utils/price.constants.ts b/packages/twenty-server/src/engine/core-modules/billing/services/__test__/utils/price.constants.ts
deleted file mode 100644
index e30cad74d9b..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/services/__test__/utils/price.constants.ts
+++ /dev/null
@@ -1,21 +0,0 @@
-export const LICENSE_PRICE_ENTERPRISE_MONTH_ID =
- 'LICENSE_PRICE_ENTERPRISE_MONTH_ID';
-export const LICENSE_PRICE_PRO_MONTH_ID = 'LICENSE_PRICE_PRO_MONTH_ID';
-export const LICENSE_PRICE_ENTERPRISE_YEAR_ID =
- 'LICENSE_PRICE_ENTERPRISE_YEAR_ID';
-export const LICENSE_PRICE_PRO_YEAR_ID = 'LICENSE_PRICE_PRO_YEAR_ID';
-
-export const METER_PRICE_ENTERPRISE_MONTH_ID =
- 'METER_PRICE_ENTERPRISE_MONTH_ID';
-export const METER_PRICE_PRO_MONTH_ID = 'METER_PRICE_PRO_MONTH_ID';
-export const METER_PRICE_ENTERPRISE_YEAR_ID = 'METER_PRICE_ENTERPRISE_YEAR_ID';
-export const METER_PRICE_PRO_YEAR_ID = 'METER_PRICE_PRO_YEAR_ID';
-
-export const METER_PRICE_ENTERPRISE_MONTH_TIER_LOW_ID =
- 'METER_PRICE_ENTERPRISE_MONTH_TIER_LOW_ID';
-export const METER_PRICE_ENTERPRISE_MONTH_TIER_HIGH_ID =
- 'METER_PRICE_ENTERPRISE_MONTH_TIER_HIGH_ID';
-export const METER_PRICE_PRO_MONTH_TIER_LOW_ID =
- 'METER_PRICE_PRO_MONTH_TIER_LOW_ID';
-export const METER_PRICE_PRO_MONTH_TIER_HIGH_ID =
- 'METER_PRICE_PRO_MONTH_TIER_HIGH_ID';
diff --git a/packages/twenty-server/src/engine/core-modules/billing/stripe/services/__tests__/stripe-invoice.service.spec.ts b/packages/twenty-server/src/engine/core-modules/billing/stripe/services/__tests__/stripe-invoice.service.spec.ts
deleted file mode 100644
index 73370be6ac0..00000000000
--- a/packages/twenty-server/src/engine/core-modules/billing/stripe/services/__tests__/stripe-invoice.service.spec.ts
+++ /dev/null
@@ -1,141 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { StripeInvoiceService } from 'src/engine/core-modules/billing/stripe/services/stripe-invoice.service';
-import { StripeSDKService } from 'src/engine/core-modules/billing/stripe/stripe-sdk/services/stripe-sdk.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-describe('StripeInvoiceService', () => {
- let service: StripeInvoiceService;
-
- const stripeMock = {
- invoiceItems: {
- create: jest.fn(),
- },
- invoices: {
- create: jest.fn(),
- finalizeInvoice: jest.fn(),
- pay: jest.fn(),
- retrieve: jest.fn(),
- },
- };
-
- const upgradeInvoiceInput = {
- stripeCustomerId: 'cus_1',
- stripeSubscriptionId: 'sub_1',
- diffAmountInCents: 2000,
- currency: 'usd',
- description:
- 'Resource usage - Upgrade resource credit price from $0 to $20',
- };
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- StripeInvoiceService,
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn().mockImplementation((key: string) => {
- if (key === 'IS_BILLING_ENABLED') {
- return true;
- }
-
- return 'stripe-api-key';
- }),
- },
- },
- {
- provide: StripeSDKService,
- useValue: {
- getStripe: jest.fn().mockReturnValue(stripeMock),
- },
- },
- ],
- }).compile();
-
- service = module.get(StripeInvoiceService);
-
- stripeMock.invoiceItems.create.mockResolvedValue({ id: 'ii_1' });
- stripeMock.invoices.create.mockResolvedValue({
- id: 'in_1',
- status: 'draft',
- });
- });
-
- describe('createImmediateUpgradeInvoice', () => {
- it('should pay the invoice when it is still open after finalization', async () => {
- stripeMock.invoices.finalizeInvoice.mockResolvedValue({
- id: 'in_1',
- status: 'open',
- });
- stripeMock.invoices.pay.mockResolvedValue({ id: 'in_1', status: 'paid' });
-
- await service.createImmediateUpgradeInvoice(upgradeInvoiceInput);
-
- expect(stripeMock.invoiceItems.create).toHaveBeenCalledWith({
- customer: 'cus_1',
- subscription: 'sub_1',
- amount: 2000,
- currency: 'usd',
- description: upgradeInvoiceInput.description,
- });
- expect(stripeMock.invoices.finalizeInvoice).toHaveBeenCalledWith('in_1', {
- auto_advance: true,
- });
- expect(stripeMock.invoices.pay).toHaveBeenCalledWith('in_1');
- });
-
- it('should not attempt payment when the invoice is settled at finalization', async () => {
- stripeMock.invoices.finalizeInvoice.mockResolvedValue({
- id: 'in_1',
- status: 'paid',
- });
-
- await expect(
- service.createImmediateUpgradeInvoice(upgradeInvoiceInput),
- ).resolves.toBeUndefined();
-
- expect(stripeMock.invoices.pay).not.toHaveBeenCalled();
- });
-
- it('should swallow the payment error when the invoice was paid in the meantime', async () => {
- stripeMock.invoices.finalizeInvoice.mockResolvedValue({
- id: 'in_1',
- status: 'open',
- });
- stripeMock.invoices.pay.mockRejectedValue(
- new Error('Invoice is already paid'),
- );
- stripeMock.invoices.retrieve.mockResolvedValue({
- id: 'in_1',
- status: 'paid',
- });
-
- await expect(
- service.createImmediateUpgradeInvoice(upgradeInvoiceInput),
- ).resolves.toBeUndefined();
- });
-
- it('should rethrow the payment error when the invoice is not paid', async () => {
- const paymentError = new Error('Your card was declined.');
-
- stripeMock.invoices.finalizeInvoice.mockResolvedValue({
- id: 'in_1',
- status: 'open',
- });
- stripeMock.invoices.pay.mockRejectedValue(paymentError);
- stripeMock.invoices.retrieve.mockResolvedValue({
- id: 'in_1',
- status: 'open',
- });
-
- await expect(
- service.createImmediateUpgradeInvoice(upgradeInvoiceInput),
- ).rejects.toBe(paymentError);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/cache-lock/__tests__/cache-lock.service.spec.ts b/packages/twenty-server/src/engine/core-modules/cache-lock/__tests__/cache-lock.service.spec.ts
deleted file mode 100644
index 2d604cbbca1..00000000000
--- a/packages/twenty-server/src/engine/core-modules/cache-lock/__tests__/cache-lock.service.spec.ts
+++ /dev/null
@@ -1,108 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { CacheLockService } from 'src/engine/core-modules/cache-lock/cache-lock.service';
-import { CacheStorageService } from 'src/engine/core-modules/cache-storage/services/cache-storage.service';
-import { CacheStorageNamespace } from 'src/engine/core-modules/cache-storage/types/cache-storage-namespace.enum';
-
-describe('CacheLockService', () => {
- let service: CacheLockService;
- let cacheStorageService: jest.Mocked<CacheStorageService>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- CacheLockService,
- {
- provide: CacheStorageNamespace.EngineLock,
- useValue: {
- acquireLock: jest.fn(),
- releaseLock: jest.fn(),
- },
- },
- {
- provide: CacheStorageService,
- useValue: {
- acquireLock: jest.fn(),
- releaseLock: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<CacheLockService>(CacheLockService);
- cacheStorageService = module.get(CacheStorageNamespace.EngineLock);
- jest.spyOn(service, 'delay').mockResolvedValue(undefined);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- it('should acquire the lock and execute the function', async () => {
- cacheStorageService.acquireLock.mockResolvedValue(true);
- cacheStorageService.releaseLock.mockResolvedValue(undefined);
-
- const fn = jest.fn().mockResolvedValue('success');
-
- const ttl = 100;
-
- const result = await service.withLock(fn, 'key', {
- ttl,
- });
-
- expect(result).toBe('success');
- expect(fn).toHaveBeenCalled();
- expect(cacheStorageService.acquireLock).toHaveBeenCalledTimes(1);
- expect(cacheStorageService.acquireLock).toHaveBeenCalledWith('key', ttl);
- expect(cacheStorageService.releaseLock).toHaveBeenCalledTimes(1);
- expect(cacheStorageService.releaseLock).toHaveBeenCalledWith('key');
- });
-
- it('should throw an error if lock cannot be acquired after max retries', async () => {
- cacheStorageService.acquireLock.mockResolvedValue(false);
-
- const fn = jest.fn();
- const ms = 1;
- const maxRetries = 3;
-
- await expect(
- service.withLock(fn, 'key', { ms, maxRetries }),
- ).rejects.toThrow('Failed to acquire lock for key: key');
-
- expect(cacheStorageService.acquireLock).toHaveBeenCalledTimes(maxRetries);
- expect(fn).not.toHaveBeenCalled();
- });
-
- it('should retry before acquiring the lock', async () => {
- const mockAcquireLock = cacheStorageService.acquireLock;
-
- mockAcquireLock
- .mockResolvedValueOnce(false)
- .mockResolvedValueOnce(false)
- .mockResolvedValueOnce(true);
-
- const fn = jest.fn().mockResolvedValue('retried success');
-
- const result = await service.withLock(fn, 'key', {
- maxRetries: 5,
- ms: 1,
- });
-
- expect(result).toBe('retried success');
- expect(fn).toHaveBeenCalledTimes(1);
- expect(mockAcquireLock).toHaveBeenCalledTimes(3);
- expect(cacheStorageService.releaseLock).toHaveBeenCalledWith('key');
- });
-
- it('should release the lock even if the function throws', async () => {
- cacheStorageService.acquireLock.mockResolvedValue(true);
- cacheStorageService.releaseLock.mockResolvedValue(undefined);
-
- const fn = jest.fn().mockRejectedValue(new Error('fail'));
-
- await expect(service.withLock(fn, 'key')).rejects.toThrow('fail');
-
- expect(fn).toHaveBeenCalled();
- expect(cacheStorageService.releaseLock).toHaveBeenCalledWith('key');
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/cache-storage/services/__tests__/cache-storage.service.spec.ts b/packages/twenty-server/src/engine/core-modules/cache-storage/services/__tests__/cache-storage.service.spec.ts
deleted file mode 100644
index 27ef73bfa2b..00000000000
--- a/packages/twenty-server/src/engine/core-modules/cache-storage/services/__tests__/cache-storage.service.spec.ts
+++ /dev/null
@@ -1,198 +0,0 @@
-import { type Cache } from '@nestjs/cache-manager';
-
-import { CacheStorageService } from 'src/engine/core-modules/cache-storage/services/cache-storage.service';
-import { CacheStorageNamespace } from 'src/engine/core-modules/cache-storage/types/cache-storage-namespace.enum';
-
-const prefixKey = (key: string) =>
- `${CacheStorageNamespace.IntegrationTests}:${CacheStorageNamespace.EngineWorkspace}:${key}`;
-
-describe('CacheStorageService', () => {
- describe('mset', () => {
- const createRedisCacheMock = () => {
- const storeMset = jest.fn().mockResolvedValue(undefined);
- const cache = {
- store: { name: 'redis', mset: storeMset },
- set: jest.fn(),
- } as unknown as Cache;
-
- return { cache, storeMset };
- };
-
- it('commits all same-ttl entries in a single atomic store call', async () => {
- const { cache, storeMset } = createRedisCacheMock();
- const cacheStorageService = new CacheStorageService(
- cache,
- CacheStorageNamespace.EngineWorkspace,
- );
-
- await cacheStorageService.mset<unknown>([
- { key: 'flat-maps:field-metadata:workspace-id:hash', value: 'hash-1' },
- {
- key: 'flat-maps:field-metadata:workspace-id:data',
- value: { byId: {} },
- },
- ]);
-
- expect(storeMset).toHaveBeenCalledTimes(1);
- expect(storeMset).toHaveBeenCalledWith(
- [
- [prefixKey('flat-maps:field-metadata:workspace-id:hash'), 'hash-1'],
- [
- prefixKey('flat-maps:field-metadata:workspace-id:data'),
- { byId: {} },
- ],
- ],
- undefined,
- );
- });
-
- it('groups entries by ttl into one atomic store call per ttl', async () => {
- const { cache, storeMset } = createRedisCacheMock();
- const cacheStorageService = new CacheStorageService(
- cache,
- CacheStorageNamespace.EngineWorkspace,
- );
-
- await cacheStorageService.mset([
- { key: 'first', value: 1, ttl: 1000 },
- { key: 'second', value: 2 },
- { key: 'third', value: 3, ttl: 1000 },
- ]);
-
- expect(storeMset).toHaveBeenCalledTimes(2);
- expect(storeMset).toHaveBeenCalledWith(
- [
- [prefixKey('first'), 1],
- [prefixKey('third'), 3],
- ],
- 1000,
- );
- expect(storeMset).toHaveBeenCalledWith(
- [[prefixKey('second'), 2]],
- undefined,
- );
- });
-
- it('does not call the store for empty entries', async () => {
- const { cache, storeMset } = createRedisCacheMock();
- const cacheStorageService = new CacheStorageService(
- cache,
- CacheStorageNamespace.EngineWorkspace,
- );
-
- await cacheStorageService.mset([]);
-
- expect(storeMset).not.toHaveBeenCalled();
- });
-
- it('falls back to sequential sets on non-redis stores', async () => {
- const cache = {
- store: { name: 'memory' },
- set: jest.fn().mockResolvedValue(undefined),
- } as unknown as Cache;
- const cacheStorageService = new CacheStorageService(
- cache,
- CacheStorageNamespace.EngineWorkspace,
- );
-
- await cacheStorageService.mset([
- { key: 'first', value: 1, ttl: 500 },
- { key: 'second', value: 2 },
- ]);
-
- expect(cache.set).toHaveBeenNthCalledWith(1, prefixKey('first'), 1, 500);
- expect(cache.set).toHaveBeenNthCalledWith(
- 2,
- prefixKey('second'),
- 2,
- undefined,
- );
- });
- });
-
- describe('sorted sets', () => {
- const createRedisCacheMock = () => {
- const zAdd = jest.fn().mockResolvedValue(1);
- const zRem = jest.fn().mockResolvedValue(1);
- const exec = jest.fn().mockResolvedValue([2, 3]);
- const multi = {
- zRemRangeByScore: jest.fn(),
- zCard: jest.fn(),
- exec,
- };
-
- multi.zRemRangeByScore.mockReturnValue(multi);
- multi.zCard.mockReturnValue(multi);
-
- const cache = {
- store: {
- name: 'redis',
- client: {
- zAdd,
- zRem,
- multi: jest.fn().mockReturnValue(multi),
- },
- },
- } as unknown as Cache;
-
- return { cache, exec, multi, zAdd, zRem };
- };
-
- it('adds members with scores', async () => {
- const { cache, zAdd } = createRedisCacheMock();
- const cacheStorageService = new CacheStorageService(
- cache,
- CacheStorageNamespace.EngineWorkspace,
- );
- const entries = [
- { score: 1000, value: 'stream-1' },
- { score: 2000, value: 'stream-2' },
- ];
-
- await cacheStorageService.sortedSetAdd('active-streams', entries);
-
- expect(zAdd).toHaveBeenCalledWith(prefixKey('active-streams'), entries);
- });
-
- it('removes members', async () => {
- const { cache, zRem } = createRedisCacheMock();
- const cacheStorageService = new CacheStorageService(
- cache,
- CacheStorageNamespace.EngineWorkspace,
- );
-
- await cacheStorageService.sortedSetRemove('active-streams', [
- 'stream-1',
- 'stream-2',
- ]);
-
- expect(zRem).toHaveBeenCalledWith(prefixKey('active-streams'), [
- 'stream-1',
- 'stream-2',
- ]);
- });
-
- it('removes expired members and returns the remaining count atomically', async () => {
- const { cache, exec, multi } = createRedisCacheMock();
- const cacheStorageService = new CacheStorageService(
- cache,
- CacheStorageNamespace.EngineWorkspace,
- );
-
- const count = await cacheStorageService.sortedSetRemoveByScoreAndCount(
- 'active-streams',
- 0,
- 1000,
- );
-
- expect(multi.zRemRangeByScore).toHaveBeenCalledWith(
- prefixKey('active-streams'),
- 0,
- 1000,
- );
- expect(multi.zCard).toHaveBeenCalledWith(prefixKey('active-streams'));
- expect(exec).toHaveBeenCalledTimes(1);
- expect(count).toBe(3);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.spec.ts b/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.spec.ts
deleted file mode 100644
index 7358ba1f748..00000000000
--- a/packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.spec.ts
+++ /dev/null
@@ -1,381 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED } from 'twenty-shared/constants';
-
-import { CalendarChannelVisibility } from 'twenty-shared/types';
-import { FileUrlService } from 'src/engine/core-modules/file/file-url/file-url.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { RelatedPersonIdsService } from 'src/engine/core-modules/related-person-ids/services/related-person-ids.service';
-import { CalendarChannelEntity } from 'src/engine/metadata-modules/calendar-channel/entities/calendar-channel.entity';
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type WorkspaceRepository } from 'src/engine/twenty-orm/repository/workspace.repository';
-import { type CalendarEventWorkspaceEntity } from 'src/modules/calendar/common/standard-objects/calendar-event.workspace-entity';
-
-import { TimelineCalendarEventService } from './timeline-calendar-event.service';
-
-type MockWorkspaceRepository = Partial<
- WorkspaceRepository<CalendarEventWorkspaceEntity>
-> & {
- count: jest.Mock;
- find: jest.Mock;
- findAndCount: jest.Mock;
-};
-
-describe('TimelineCalendarEventService', () => {
- let service: TimelineCalendarEventService;
- let mockCalendarEventRepository: MockWorkspaceRepository;
- let mockCalendarChannelCoreRepository: { find: jest.Mock };
- let mockConnectedAccountRepository: { find: jest.Mock };
- let mockUserWorkspaceRepository: { findOne: jest.Mock };
- let mockWorkspaceMemberRepository: { findOne: jest.Mock };
- let mockFileUrlService: { signFirstFilesFieldFileUrl: jest.Mock };
- let mockCallRecordingRepository: { find: jest.Mock };
-
- const mockCalendarEvent: Partial<CalendarEventWorkspaceEntity> = {
- id: '1',
- title: 'Test Event',
- description: 'Test Description',
- startsAt: '2024-01-01T00:00:00.000Z',
- endsAt: '2024-01-01T01:00:00.000Z',
- calendarEventParticipants: [],
- calendarChannelEventAssociations: [],
- };
-
- beforeEach(async () => {
- mockCalendarEventRepository = {
- count: jest.fn().mockResolvedValue(1),
- find: jest.fn(),
- findAndCount: jest.fn(),
- };
-
- mockConnectedAccountRepository = {
- find: jest.fn().mockResolvedValue([]),
- };
-
- mockCalendarChannelCoreRepository = {
- find: jest.fn().mockResolvedValue([]),
- };
-
- mockUserWorkspaceRepository = {
- findOne: jest.fn().mockResolvedValue(null),
- };
-
- mockWorkspaceMemberRepository = {
- findOne: jest.fn().mockResolvedValue(null),
- };
-
- mockFileUrlService = {
- signFirstFilesFieldFileUrl: jest.fn().mockResolvedValue(null),
- };
-
- mockCallRecordingRepository = {
- find: jest.fn().mockResolvedValue([]),
- };
-
- const mockGlobalWorkspaceOrmManager = {
- getRepository: jest
- .fn()
- .mockImplementation((_workspaceId, entityName) => {
- if (entityName === 'workspaceMember') {
- return Promise.resolve(mockWorkspaceMemberRepository);
- }
-
- if (entityName === 'callRecording') {
- return Promise.resolve(mockCallRecordingRepository);
- }
-
- return Promise.resolve(mockCalendarEventRepository);
- }),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- TimelineCalendarEventService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: mockGlobalWorkspaceOrmManager,
- },
- {
- provide: getRepositoryToken(CalendarChannelEntity),
- useValue: mockCalendarChannelCoreRepository,
- },
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: mockConnectedAccountRepository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: mockUserWorkspaceRepository,
- },
- {
- provide: RelatedPersonIdsService,
- useValue: { getRelatedPersonIds: jest.fn().mockResolvedValue([]) },
- },
- {
- provide: FileUrlService,
- useValue: mockFileUrlService,
- },
- ],
- }).compile();
-
- service = module.get<TimelineCalendarEventService>(
- TimelineCalendarEventService,
- );
- });
-
- it('should return non-obfuscated calendar events if visibility is SHARE_EVERYTHING', async () => {
- const currentWorkspaceMemberId = 'current-workspace-member-id';
- const personIds = ['person-1'];
-
- mockCalendarEventRepository.find.mockResolvedValue([
- { id: '1', startsAt: new Date() },
- ]);
- mockCalendarEventRepository.findAndCount.mockResolvedValue([
- [
- {
- ...mockCalendarEvent,
- calendarChannelEventAssociations: [
- { calendarChannelId: 'channel-1' },
- ],
- },
- ],
- 1,
- ]);
- mockCalendarChannelCoreRepository.find.mockResolvedValue([
- {
- id: 'channel-1',
- visibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- connectedAccountId: 'connected-account-1',
- },
- ]);
- // Ownership doesn't matter for SHARE_EVERYTHING
- mockWorkspaceMemberRepository.findOne.mockResolvedValue(null);
-
- const result = await service.getCalendarEventsFromPersonIds({
- currentWorkspaceMemberId,
- personIds,
- workspaceId: 'test-workspace-id',
- page: 1,
- pageSize: 10,
- });
-
- expect(result.timelineCalendarEvents[0].title).toBe('Test Event');
- expect(result.timelineCalendarEvents[0].description).toBe(
- 'Test Description',
- );
- });
-
- it('should return obfuscated calendar events if visibility is METADATA', async () => {
- const currentWorkspaceMemberId = 'current-workspace-member-id';
- const personIds = ['person-1'];
-
- mockCalendarEventRepository.find.mockResolvedValue([
- { id: '1', startsAt: new Date() },
- ]);
- mockCalendarEventRepository.findAndCount.mockResolvedValue([
- [
- {
- ...mockCalendarEvent,
- calendarChannelEventAssociations: [
- { calendarChannelId: 'channel-1' },
- ],
- },
- ],
- 1,
- ]);
- mockCalendarChannelCoreRepository.find.mockResolvedValue([
- {
- id: 'channel-1',
- visibility: CalendarChannelVisibility.METADATA,
- connectedAccountId: 'connected-account-1',
- },
- ]);
- // Current user resolves but doesn't own the account
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- userId: 'current-user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'current-uw-id',
- });
- mockConnectedAccountRepository.find.mockResolvedValue([]);
-
- const result = await service.getCalendarEventsFromPersonIds({
- currentWorkspaceMemberId,
- personIds,
- workspaceId: 'test-workspace-id',
- page: 1,
- pageSize: 10,
- });
-
- expect(result.timelineCalendarEvents[0].title).toBe(
- FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- );
- expect(result.timelineCalendarEvents[0].description).toBe(
- FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- );
- });
-
- it('should return non-obfuscated calendar events if visibility is METADATA and user is calendar events owner', async () => {
- const currentWorkspaceMemberId = 'current-workspace-member-id';
- const personIds = ['person-1'];
-
- mockCalendarEventRepository.find.mockResolvedValue([
- { id: '1', startsAt: new Date() },
- ]);
- mockCalendarEventRepository.findAndCount.mockResolvedValue([
- [
- {
- ...mockCalendarEvent,
- calendarChannelEventAssociations: [
- { calendarChannelId: 'channel-1' },
- ],
- },
- ],
- 1,
- ]);
- mockCalendarChannelCoreRepository.find.mockResolvedValue([
- {
- id: 'channel-1',
- visibility: CalendarChannelVisibility.METADATA,
- connectedAccountId: 'connected-account-1',
- },
- ]);
- // Current user resolves and owns the account
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- userId: 'current-user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'current-uw-id',
- });
- mockConnectedAccountRepository.find.mockResolvedValue([
- { id: 'connected-account-1' },
- ]);
-
- const result = await service.getCalendarEventsFromPersonIds({
- currentWorkspaceMemberId,
- personIds,
- workspaceId: 'test-workspace-id',
- page: 1,
- pageSize: 10,
- });
-
- expect(result.timelineCalendarEvents[0].title).toBe('Test Event');
- expect(result.timelineCalendarEvents[0].description).toBe(
- 'Test Description',
- );
- });
-
- it('should resolve the participant avatar from the signed avatarFile URL over the legacy avatarUrl', async () => {
- const signedAvatarFileUrl = 'https://files.example.com/signed-avatar.png';
-
- mockFileUrlService.signFirstFilesFieldFileUrl.mockResolvedValue(
- signedAvatarFileUrl,
- );
-
- mockCalendarEventRepository.find.mockResolvedValue([
- { id: '1', startsAt: new Date() },
- ]);
- mockCalendarEventRepository.findAndCount.mockResolvedValue([
- [
- {
- ...mockCalendarEvent,
- calendarEventParticipants: [
- {
- personId: 'person-1',
- handle: '[email protected]',
- person: {
- id: 'person-1',
- name: { firstName: 'John', lastName: 'Doe' },
- avatarFile: [{ fileId: 'file-1' }],
- avatarUrl: 'https://legacy.example.com/avatar.png',
- },
- },
- ],
- calendarChannelEventAssociations: [
- { calendarChannelId: 'channel-1' },
- ],
- },
- ],
- 1,
- ]);
- mockCalendarChannelCoreRepository.find.mockResolvedValue([
- {
- id: 'channel-1',
- visibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- connectedAccountId: 'connected-account-1',
- },
- ]);
-
- const result = await service.getCalendarEventsFromPersonIds({
- currentWorkspaceMemberId: 'current-workspace-member-id',
- personIds: ['person-1'],
- workspaceId: 'test-workspace-id',
- page: 1,
- pageSize: 10,
- });
-
- expect(mockFileUrlService.signFirstFilesFieldFileUrl).toHaveBeenCalledWith({
- filesFieldValue: [{ fileId: 'file-1' }],
- workspaceId: 'test-workspace-id',
- });
- expect(result.timelineCalendarEvents[0].participants[0].avatarUrl).toBe(
- signedAvatarFileUrl,
- );
- });
-
- it('should fall back to the legacy avatarUrl when no avatarFile is signed', async () => {
- mockFileUrlService.signFirstFilesFieldFileUrl.mockResolvedValue(null);
-
- const legacyAvatarUrl = 'https://legacy.example.com/avatar.png';
-
- mockCalendarEventRepository.find.mockResolvedValue([
- { id: '1', startsAt: new Date() },
- ]);
- mockCalendarEventRepository.findAndCount.mockResolvedValue([
- [
- {
- ...mockCalendarEvent,
- calendarEventParticipants: [
- {
- personId: 'person-1',
- handle: '[email protected]',
- person: {
- id: 'person-1',
- name: { firstName: 'John', lastName: 'Doe' },
- avatarUrl: legacyAvatarUrl,
- },
- },
- ],
- calendarChannelEventAssociations: [
- { calendarChannelId: 'channel-1' },
- ],
- },
- ],
- 1,
- ]);
- mockCalendarChannelCoreRepository.find.mockResolvedValue([
- {
- id: 'channel-1',
- visibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- connectedAccountId: 'connected-account-1',
- },
- ]);
-
- const result = await service.getCalendarEventsFromPersonIds({
- currentWorkspaceMemberId: 'current-workspace-member-id',
- personIds: ['person-1'],
- workspaceId: 'test-workspace-id',
- page: 1,
- pageSize: 10,
- });
-
- expect(result.timelineCalendarEvents[0].participants[0].avatarUrl).toBe(
- legacyAvatarUrl,
- );
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts b/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts
deleted file mode 100644
index 4cd4da967f8..00000000000
--- a/packages/twenty-server/src/engine/core-modules/client-config/services/client-config.service.spec.ts
+++ /dev/null
@@ -1,319 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { NodeEnvironment } from 'src/engine/core-modules/twenty-config/interfaces/node-environment.interface';
-import { SupportDriver } from 'src/engine/core-modules/twenty-config/interfaces/support.interface';
-
-import { MaintenanceModeService } from 'src/engine/core-modules/admin-panel/maintenance-mode.service';
-import { CaptchaDriverType } from 'src/engine/core-modules/captcha/interfaces';
-import { ClientConfigService } from 'src/engine/core-modules/client-config/services/client-config.service';
-import { DomainServerConfigService } from 'src/engine/core-modules/domain/domain-server-config/services/domain-server-config.service';
-import { PUBLIC_FEATURE_FLAGS } from 'src/engine/core-modules/feature-flag/constants/public-feature-flag.const';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { AiModelRegistryService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
-import { ENTERPRISE_INSTANCE_TYPE } from 'twenty-shared/constants';
-
-describe('ClientConfigService', () => {
- let service: ClientConfigService;
- let twentyConfigService: TwentyConfigService;
- let domainServerConfigService: DomainServerConfigService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ClientConfigService,
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: DomainServerConfigService,
- useValue: {
- getFrontUrl: jest.fn(),
- getPublicBaseHostnameOrUndefined: jest.fn(),
- },
- },
- {
- provide: AiModelRegistryService,
- useValue: {
- getAdminFilteredModels: jest.fn().mockReturnValue([]),
- getRecommendedModelIds: jest.fn().mockReturnValue(new Set()),
- getModelConfig: jest.fn().mockReturnValue(undefined),
- getResolvedProvidersForAdmin: jest.fn().mockReturnValue({}),
- getDefaultSpeedModel: jest.fn().mockReturnValue(undefined),
- getDefaultPerformanceModel: jest.fn().mockReturnValue(undefined),
- },
- },
- {
- provide: MaintenanceModeService,
- useValue: {
- getMaintenanceMode: jest.fn().mockResolvedValue(null),
- },
- },
- ],
- }).compile();
-
- service = module.get<ClientConfigService>(ClientConfigService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- domainServerConfigService = module.get<DomainServerConfigService>(
- DomainServerConfigService,
- );
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('getClientConfig', () => {
- beforeEach(() => {
- // Setup default mock values
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const mockValues: Record<string, any> = {
- IS_BILLING_ENABLED: true,
- BILLING_PLAN_REQUIRED_LINK: 'https://billing.example.com',
- BILLING_FREE_TRIAL_WITH_CREDIT_CARD_DURATION_IN_DAYS: 30,
- BILLING_FREE_TRIAL_WITHOUT_CREDIT_CARD_DURATION_IN_DAYS: 7,
- BILLING_STRIPE_PUBLISHABLE_KEY: 'pk_test_123',
- AUTH_GOOGLE_ENABLED: true,
- AUTH_PASSWORD_ENABLED: true,
- AUTH_MICROSOFT_ENABLED: false,
- SIGN_IN_PREFILLED: false,
- IS_MULTIWORKSPACE_ENABLED: true,
- IS_EMAIL_VERIFICATION_REQUIRED: true,
- DEFAULT_SUBDOMAIN: 'app',
- NODE_ENV: NodeEnvironment.DEVELOPMENT,
- SUPPORT_DRIVER: SupportDriver.FRONT,
- SUPPORT_FRONT_CHAT_ID: 'chat-123',
- SENTRY_ENVIRONMENT: 'development',
- APP_VERSION: '1.0.0',
- SENTRY_FRONT_DSN: 'https://sentry.example.com',
- CAPTCHA_DRIVER: CaptchaDriverType.GOOGLE_RECAPTCHA,
- CAPTCHA_SITE_KEY: 'site-key-123',
- MUTATION_MAXIMUM_AFFECTED_RECORDS: 1000,
- ONBOARDING_IMPORT_CONTACTS_CREDITS_REWARD: 2_000_000,
- ONBOARDING_INVITE_TEAM_CREDITS_REWARD_PER_USER: 3_000_000,
- BILLING_FREE_WORKFLOW_CREDITS_FOR_TRIAL_PERIOD_WITH_CREDIT_CARD: 5_000_000,
- ONBOARDING_INSTALL_APPS_CREDITS_REWARD_PER_APP: 1_000_000,
- IS_ATTACHMENT_PREVIEW_ENABLED: true,
- ANALYTICS_ENABLED: true,
- MESSAGING_PROVIDER_MICROSOFT_ENABLED: false,
- CALENDAR_PROVIDER_MICROSOFT_ENABLED: false,
- MESSAGING_PROVIDER_GMAIL_ENABLED: true,
- CALENDAR_PROVIDER_GOOGLE_ENABLED: true,
- IS_CONFIG_VARIABLES_IN_DB_ENABLED: false,
- IS_IMAP_SMTP_CALDAV_ENABLED: false,
- CALENDAR_BOOKING_PAGE_ID: 'team/twenty/talk-to-us',
- ONBOARDING_BOOK_CALL_MIN_EMPLOYEE_COUNT: 50,
- CLOUDFLARE_API_KEY: undefined,
- CLOUDFLARE_ZONE_ID: undefined,
- ALLOW_REQUESTS_TO_TWENTY_ICONS: false,
- CLICKHOUSE_URL: undefined,
- IS_ONBOARDING_AI_CHAT_ENABLED: false,
- };
-
- return mockValues[key];
- });
-
- jest.spyOn(domainServerConfigService, 'getFrontUrl').mockReturnValue({
- hostname: 'app.twenty.com',
- } as URL);
- });
-
- it('should return complete client config with all properties', async () => {
- const result = await service.getClientConfig();
-
- expect(result).toEqual({
- appVersion: '1.0.0',
- billing: {
- isBillingEnabled: true,
- billingUrl: 'https://billing.example.com',
- stripePublishableKey: 'pk_test_123',
- trialPeriods: [
- {
- duration: 30,
- isCreditCardRequired: true,
- },
- {
- duration: 7,
- isCreditCardRequired: false,
- },
- ],
- },
- aiModels: [],
- authProviders: {
- google: true,
- magicLink: false,
- password: true,
- microsoft: false,
- sso: [],
- },
- signInPrefilled: false,
- isMultiWorkspaceEnabled: true,
- isEmailVerificationRequired: true,
- defaultSubdomain: 'app',
- frontDomain: 'app.twenty.com',
- publicFunctionDomain: null,
- support: {
- supportDriver: 'FRONT',
- supportFrontChatId: 'chat-123',
- },
- sentry: {
- environment: 'development',
- release: '1.0.0',
- dsn: 'https://sentry.example.com',
- },
- captcha: {
- provider: 'GOOGLE_RECAPTCHA',
- siteKey: 'site-key-123',
- },
- api: {
- mutationMaximumAffectedRecords: 1000,
- },
- onboarding: {
- importContactsCreditsReward: 2,
- inviteTeamCreditsRewardPerUser: 3,
- upgradeCreditsReward: 5,
- installAppsCreditsRewardPerApp: 1,
- },
- isAttachmentPreviewEnabled: true,
- analyticsEnabled: true,
- canManageFeatureFlags: true,
- publicFeatureFlags: PUBLIC_FEATURE_FLAGS,
- isMicrosoftMessagingEnabled: false,
- isMicrosoftCalendarEnabled: false,
- isGoogleMessagingEnabled: true,
- isGoogleCalendarEnabled: true,
- isConfigVariablesInDbEnabled: false,
- isImapSmtpCaldavEnabled: false,
- isEmailingDomainInDemoMode: false,
- allowRequestsToTwentyIcons: false,
- calendarBookingPageId: 'team/twenty/talk-to-us',
- isBookCallOnboardingStepEnabled: true,
- isCompanyEnrichmentEnabled: false,
- isCloudflareIntegrationEnabled: false,
- isClickHouseConfigured: false,
- isOnboardingAiChatEnabled: false,
- enterpriseInstanceType: ENTERPRISE_INSTANCE_TYPE.PRODUCTION,
- });
- });
-
- it('should not return onboarding credits rewards when billing is disabled', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) =>
- key === 'IS_BILLING_ENABLED' ? false : undefined,
- );
-
- const result = await service.getClientConfig();
-
- expect(result.onboarding).toBeNull();
- });
-
- it('should advertise cookie sessions when the flag is on', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) =>
- key === 'AUTH_COOKIE_SESSIONS_ENABLED' ? true : undefined,
- );
-
- const result = await service.getClientConfig();
-
- expect(result.isCookieSessionEnabled).toBe(true);
- });
-
- it('should not advertise cookie sessions when the flag is off', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) =>
- key === 'AUTH_COOKIE_SESSIONS_ENABLED' ? false : undefined,
- );
-
- const result = await service.getClientConfig();
-
- expect(result.isCookieSessionEnabled).toBe(false);
- });
-
- it('should handle production environment correctly', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- if (key === 'NODE_ENV') return NodeEnvironment.PRODUCTION;
- if (key === 'IS_BILLING_ENABLED') return false;
- if (key === 'IS_FEATURE_FLAG_MANAGEMENT_ENABLED') return false;
-
- return undefined;
- });
-
- const result = await service.getClientConfig();
-
- expect(result.canManageFeatureFlags).toBe(false);
- expect(result.aiModels).toEqual([]);
- });
-
- it('should handle missing captcha driver', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- if (key === 'CAPTCHA_DRIVER') return undefined;
- if (key === 'CAPTCHA_SITE_KEY') return 'site-key';
-
- return undefined;
- });
-
- const result = await service.getClientConfig();
-
- expect(result.captcha.provider).toBeUndefined();
- expect(result.captcha.siteKey).toBe('site-key');
- expect(result.aiModels).toEqual([]);
- });
-
- it('should handle missing support driver', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- if (key === 'SUPPORT_DRIVER') return undefined;
-
- return undefined;
- });
-
- const result = await service.getClientConfig();
-
- expect(result.support.supportDriver).toBe(SupportDriver.NONE);
- expect(result.aiModels).toEqual([]);
- });
-
- it('should handle billing enabled with feature flags', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- if (key === 'NODE_ENV') return NodeEnvironment.PRODUCTION;
- if (key === 'IS_BILLING_ENABLED') return true;
-
- return undefined;
- });
-
- const result = await service.getClientConfig();
-
- expect(result.canManageFeatureFlags).toBe(true);
- });
-
- it('should allow managing feature flags when IS_FEATURE_FLAG_MANAGEMENT_ENABLED is on', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- if (key === 'NODE_ENV') return NodeEnvironment.PRODUCTION;
- if (key === 'IS_BILLING_ENABLED') return false;
- if (key === 'IS_FEATURE_FLAG_MANAGEMENT_ENABLED') return true;
-
- return undefined;
- });
-
- const result = await service.getClientConfig();
-
- expect(result.canManageFeatureFlags).toBe(true);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/company-enrichment/services/__tests__/company-enrichment.service.spec.ts b/packages/twenty-server/src/engine/core-modules/company-enrichment/services/__tests__/company-enrichment.service.spec.ts
deleted file mode 100644
index ff2b7f7e43b..00000000000
--- a/packages/twenty-server/src/engine/core-modules/company-enrichment/services/__tests__/company-enrichment.service.spec.ts
+++ /dev/null
@@ -1,416 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { CompanyEnrichmentService } from 'src/engine/core-modules/company-enrichment/services/company-enrichment.service';
-import { PeopleDataLabsCompanyClientService } from 'src/engine/core-modules/company-enrichment/services/people-data-labs-company-client.service';
-import { COMPANY_ENRICHMENT_ATTEMPT_KEY } from 'src/engine/core-modules/company-enrichment/types/company-enrichment-attempt-key-value.type';
-import { KeyValuePairType } from 'src/engine/core-modules/key-value-pair/key-value-pair.entity';
-import { KeyValuePairService } from 'src/engine/core-modules/key-value-pair/key-value-pair.service';
-import {
- ThrottlerException,
- ThrottlerExceptionCode,
-} from 'src/engine/core-modules/throttler/throttler.exception';
-import { ThrottlerService } from 'src/engine/core-modules/throttler/throttler.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';
-
-describe('CompanyEnrichmentService', () => {
- let service: CompanyEnrichmentService;
- let userWorkspaceService: { isWorkspaceCreator: jest.Mock };
- let peopleDataLabsCompanyClientService: {
- enrichCompanyByDomain: jest.Mock;
- isEnabled: jest.Mock;
- };
- let throttlerService: { tokenBucketThrottleOrThrow: jest.Mock };
- let keyValuePairService: { set: jest.Mock };
- let configValues: Record<string, unknown>;
-
- const workspaceId = 'workspace-id';
- const creatorUserId = 'creator-user-id';
-
- beforeEach(async () => {
- userWorkspaceService = {
- isWorkspaceCreator: jest
- .fn()
- .mockImplementation(({ userId }) =>
- Promise.resolve(userId === creatorUserId),
- ),
- };
- peopleDataLabsCompanyClientService = {
- enrichCompanyByDomain: jest.fn(),
- isEnabled: jest.fn().mockReturnValue(true),
- };
- throttlerService = { tokenBucketThrottleOrThrow: jest.fn() };
- keyValuePairService = { set: jest.fn() };
- configValues = {
- IS_ONBOARDING_AI_CHAT_ENABLED: true,
- PEOPLE_DATA_LABS_API_KEY: 'pdl-key',
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- CompanyEnrichmentService,
- {
- provide: UserWorkspaceService,
- useValue: userWorkspaceService,
- },
- {
- provide: PeopleDataLabsCompanyClientService,
- useValue: peopleDataLabsCompanyClientService,
- },
- {
- provide: ThrottlerService,
- useValue: throttlerService,
- },
- {
- provide: TwentyConfigService,
- useValue: { get: (key: string) => configValues[key] },
- },
- {
- provide: KeyValuePairService,
- useValue: keyValuePairService,
- },
- ],
- }).compile();
-
- service = module.get<CompanyEnrichmentService>(CompanyEnrichmentService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should return unavailable for a non creator without calling the client', async () => {
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: 'someone-else',
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result).toEqual({ outcome: 'unavailable', enrichment: null });
- expect(
- peopleDataLabsCompanyClientService.enrichCompanyByDomain,
- ).not.toHaveBeenCalled();
- });
-
- it.each(['[email protected]', '[email protected]', 'not-an-email'])(
- 'should return unavailable for %s without calling the client',
- async (email) => {
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email,
- workspaceId,
- });
-
- expect(result).toEqual({ outcome: 'unavailable', enrichment: null });
- expect(
- peopleDataLabsCompanyClientService.enrichCompanyByDomain,
- ).not.toHaveBeenCalled();
- },
- );
-
- it('should enrich and return the mapped enrichment on a match', async () => {
- peopleDataLabsCompanyClientService.enrichCompanyByDomain.mockResolvedValue({
- outcome: 'matched',
- data: { name: 'Acme Inc', industry: 'computer software' },
- });
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result.outcome).toBe('matched');
- expect(result.enrichment).toMatchObject({
- domain: 'acme.com',
- name: 'Acme Inc',
- industry: 'computer software',
- });
- expect(
- peopleDataLabsCompanyClientService.enrichCompanyByDomain,
- ).toHaveBeenCalledWith('acme.com');
- expect(keyValuePairService.set).toHaveBeenCalledWith(
- expect.objectContaining({
- userId: null,
- workspaceId,
- key: COMPANY_ENRICHMENT_ATTEMPT_KEY,
- type: KeyValuePairType.CONFIG_VARIABLE,
- value: expect.objectContaining({
- domain: 'acme.com',
- outcome: 'matched',
- }),
- }),
- );
- });
-
- it('should pass through a transient error', async () => {
- peopleDataLabsCompanyClientService.enrichCompanyByDomain.mockResolvedValue({
- outcome: 'transientError',
- httpStatus: 429,
- message: 'rate limited',
- });
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result).toEqual({ outcome: 'transientError', enrichment: null });
- });
-
- it.each([
- { outcome: 'skipped' },
- { outcome: 'notFound' },
- { outcome: 'permanentError', httpStatus: 401, message: 'unauthorized' },
- ])(
- 'should return unavailable on client outcome $outcome',
- async (clientResult) => {
- peopleDataLabsCompanyClientService.enrichCompanyByDomain.mockResolvedValue(
- clientResult,
- );
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result).toEqual({ outcome: 'unavailable', enrichment: null });
- },
- );
-
- it('should record the pre-collapse outcome with its HTTP status', async () => {
- peopleDataLabsCompanyClientService.enrichCompanyByDomain.mockResolvedValue({
- outcome: 'permanentError',
- httpStatus: 401,
- message: 'unauthorized',
- });
-
- await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(keyValuePairService.set).toHaveBeenCalledWith(
- expect.objectContaining({
- value: expect.objectContaining({
- domain: 'acme.com',
- outcome: 'permanentError',
- httpStatus: 401,
- message: 'unauthorized',
- }),
- }),
- );
- });
-
- it('should not consume throttle tokens when the feature is disabled', async () => {
- peopleDataLabsCompanyClientService.isEnabled.mockReturnValue(false);
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result).toEqual({ outcome: 'unavailable', enrichment: null });
- expect(throttlerService.tokenBucketThrottleOrThrow).not.toHaveBeenCalled();
- expect(
- peopleDataLabsCompanyClientService.enrichCompanyByDomain,
- ).not.toHaveBeenCalled();
- expect(keyValuePairService.set).not.toHaveBeenCalled();
- });
-
- it('should not consume throttle tokens for a non creator', async () => {
- await service.enrichCompanyForWorkspaceCreator({
- userId: 'someone-else',
- email: '[email protected]',
- workspaceId,
- });
-
- expect(throttlerService.tokenBucketThrottleOrThrow).not.toHaveBeenCalled();
- });
-
- it('should return transientError without calling the client when throttled', async () => {
- throttlerService.tokenBucketThrottleOrThrow.mockRejectedValue(
- new ThrottlerException(
- 'Limit reached',
- ThrottlerExceptionCode.LIMIT_REACHED,
- ),
- );
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result).toEqual({ outcome: 'transientError', enrichment: null });
- expect(
- peopleDataLabsCompanyClientService.enrichCompanyByDomain,
- ).not.toHaveBeenCalled();
- });
-
- it('should not record an enrichment attempt when the client is never called', async () => {
- await service.enrichCompanyForWorkspaceCreator({
- userId: 'someone-else',
- email: '[email protected]',
- workspaceId,
- });
-
- expect(keyValuePairService.set).not.toHaveBeenCalled();
- });
-
- it('should not record an enrichment attempt when throttled', async () => {
- throttlerService.tokenBucketThrottleOrThrow.mockRejectedValue(
- new ThrottlerException(
- 'Limit reached',
- ThrottlerExceptionCode.LIMIT_REACHED,
- ),
- );
-
- await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(keyValuePairService.set).not.toHaveBeenCalled();
- });
-
- it('should not record an enrichment attempt when the client skips (feature disabled)', async () => {
- peopleDataLabsCompanyClientService.enrichCompanyByDomain.mockResolvedValue({
- outcome: 'skipped',
- });
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result).toEqual({ outcome: 'unavailable', enrichment: null });
- expect(keyValuePairService.set).not.toHaveBeenCalled();
- });
-
- it('should still return the enrichment when recording the attempt fails', async () => {
- peopleDataLabsCompanyClientService.enrichCompanyByDomain.mockResolvedValue({
- outcome: 'matched',
- data: { name: 'Acme Inc' },
- });
- keyValuePairService.set.mockRejectedValue(
- new Error('key-value store down'),
- );
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result.outcome).toBe('matched');
- expect(result.enrichment).toMatchObject({
- domain: 'acme.com',
- name: 'Acme Inc',
- });
- });
-
- it('should not call the client when no api key is configured', async () => {
- configValues = { IS_ONBOARDING_AI_CHAT_ENABLED: true };
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result.outcome).toBe('unavailable');
- expect(
- peopleDataLabsCompanyClientService.enrichCompanyByDomain,
- ).not.toHaveBeenCalled();
- });
-
- it('should not call the client when no consumer of the enrichment is configured', async () => {
- configValues = {
- IS_ONBOARDING_AI_CHAT_ENABLED: false,
- PEOPLE_DATA_LABS_API_KEY: 'pdl-key',
- };
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result).toEqual({ outcome: 'unavailable', enrichment: null });
- expect(throttlerService.tokenBucketThrottleOrThrow).not.toHaveBeenCalled();
- expect(
- peopleDataLabsCompanyClientService.enrichCompanyByDomain,
- ).not.toHaveBeenCalled();
- });
-
- it.each([
- { CALENDAR_BOOKING_PAGE_ID: 'team/twenty/talk-to-us' },
- { ONBOARDING_BOOK_CALL_MIN_EMPLOYEE_COUNT: 50 },
- {
- CALENDAR_BOOKING_PAGE_ID: 'team/twenty/talk-to-us',
- ONBOARDING_BOOK_CALL_MIN_EMPLOYEE_COUNT: 0,
- },
- ])(
- 'should not call the client for a half-configured book-call step (%j)',
- async (bookCallConfig) => {
- configValues = {
- IS_ONBOARDING_AI_CHAT_ENABLED: false,
- PEOPLE_DATA_LABS_API_KEY: 'pdl-key',
- ...bookCallConfig,
- };
-
- await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(
- peopleDataLabsCompanyClientService.enrichCompanyByDomain,
- ).not.toHaveBeenCalled();
- },
- );
-
- it('should enrich for the book-call step alone when the ai chat is disabled', async () => {
- configValues = {
- IS_ONBOARDING_AI_CHAT_ENABLED: false,
- CALENDAR_BOOKING_PAGE_ID: 'team/twenty/talk-to-us',
- ONBOARDING_BOOK_CALL_MIN_EMPLOYEE_COUNT: 50,
- PEOPLE_DATA_LABS_API_KEY: 'pdl-key',
- };
- peopleDataLabsCompanyClientService.enrichCompanyByDomain.mockResolvedValue({
- outcome: 'matched',
- data: { name: 'Acme Inc', employee_count: 320 },
- });
-
- const result = await service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- });
-
- expect(result.outcome).toBe('matched');
- expect(result.enrichment).toMatchObject({ employeeCount: 320 });
- });
-
- it('should rethrow non throttler errors from the throttler', async () => {
- throttlerService.tokenBucketThrottleOrThrow.mockRejectedValue(
- new Error('redis down'),
- );
-
- await expect(
- service.enrichCompanyForWorkspaceCreator({
- userId: creatorUserId,
- email: '[email protected]',
- workspaceId,
- }),
- ).rejects.toThrow('redis down');
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/company-enrichment/services/__tests__/people-data-labs-company-client.service.spec.ts b/packages/twenty-server/src/engine/core-modules/company-enrichment/services/__tests__/people-data-labs-company-client.service.spec.ts
deleted file mode 100644
index 1e428bac706..00000000000
--- a/packages/twenty-server/src/engine/core-modules/company-enrichment/services/__tests__/people-data-labs-company-client.service.spec.ts
+++ /dev/null
@@ -1,191 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { PEOPLE_DATA_LABS_COMPANY_MIN_LIKELIHOOD } from 'src/engine/core-modules/company-enrichment/constants/people-data-labs-company-min-likelihood.constant';
-import { PeopleDataLabsCompanyClientService } from 'src/engine/core-modules/company-enrichment/services/people-data-labs-company-client.service';
-import { SecureHttpClientService } from 'src/engine/core-modules/secure-http-client/secure-http-client.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-describe('PeopleDataLabsCompanyClientService', () => {
- let service: PeopleDataLabsCompanyClientService;
- let httpClient: { get: jest.Mock };
- let twentyConfigService: { get: jest.Mock };
-
- const domain = 'acme.com';
-
- beforeEach(async () => {
- httpClient = { get: jest.fn() };
- twentyConfigService = { get: jest.fn().mockReturnValue('pdl-key') };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- PeopleDataLabsCompanyClientService,
- {
- provide: TwentyConfigService,
- useValue: twentyConfigService,
- },
- {
- provide: SecureHttpClientService,
- useValue: { getHttpClient: jest.fn().mockReturnValue(httpClient) },
- },
- ],
- }).compile();
-
- service = module.get<PeopleDataLabsCompanyClientService>(
- PeopleDataLabsCompanyClientService,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it.each([undefined, '', ' '])(
- 'should skip without calling the API when the key is %p',
- async (apiKey) => {
- twentyConfigService.get.mockReturnValue(apiKey);
-
- const result = await service.enrichCompanyByDomain(domain);
-
- expect(result).toEqual({ outcome: 'skipped' });
- expect(httpClient.get).not.toHaveBeenCalled();
- },
- );
-
- it('should send the domain and minimum likelihood as query parameters', async () => {
- httpClient.get.mockResolvedValue({
- status: 200,
- data: { name: 'Acme Inc' },
- });
-
- await service.enrichCompanyByDomain(domain);
-
- expect(httpClient.get).toHaveBeenCalledWith('/company/enrich', {
- params: {
- website: domain,
- min_likelihood: PEOPLE_DATA_LABS_COMPANY_MIN_LIKELIHOOD,
- },
- headers: { 'X-Api-Key': 'pdl-key' },
- });
- });
-
- it('should treat a body level 404 under an HTTP 200 as not found', async () => {
- httpClient.get.mockResolvedValue({
- status: 200,
- data: { status: 404 },
- });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'notFound',
- });
- });
-
- it('should treat an HTTP 404 as not found', async () => {
- httpClient.get.mockResolvedValue({ status: 404, data: {} });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'notFound',
- });
- });
-
- it.each([429, 500, 503])(
- 'should classify HTTP %i as a transient error',
- async (status) => {
- httpClient.get.mockResolvedValue({ status, data: {} });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'transientError',
- httpStatus: status,
- message: `PDL request failed (HTTP ${status}).`,
- });
- },
- );
-
- it('should classify HTTP 401 as a permanent error', async () => {
- httpClient.get.mockResolvedValue({ status: 401, data: {} });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'permanentError',
- httpStatus: 401,
- message: 'PDL request failed (HTTP 401).',
- });
- });
-
- it('should match on data nested under the data key', async () => {
- httpClient.get.mockResolvedValue({
- status: 200,
- data: { status: 200, likelihood: 9, data: { name: 'Acme Inc' } },
- });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'matched',
- data: { name: 'Acme Inc' },
- });
- });
-
- it('should match on top level data and strip the envelope fields', async () => {
- httpClient.get.mockResolvedValue({
- status: 200,
- data: { status: 200, likelihood: 9, name: 'Acme Inc' },
- });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'matched',
- data: { name: 'Acme Inc' },
- });
- });
-
- it('should treat an envelope only body as not found', async () => {
- httpClient.get.mockResolvedValue({
- status: 200,
- data: { status: 200, likelihood: 2 },
- });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'notFound',
- });
- });
-
- it('should treat a non object 2xx body as a transient error', async () => {
- httpClient.get.mockResolvedValue({ status: 200, data: '<html></html>' });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'transientError',
- httpStatus: 200,
- message: 'People Data Labs returned a non-JSON response',
- });
- });
-
- it('should surface the People Data Labs error message when present', async () => {
- httpClient.get.mockResolvedValue({
- status: 402,
- data: { error: { message: 'payment required' } },
- });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'permanentError',
- httpStatus: 402,
- message: 'payment required',
- });
- });
-
- it('should treat a match below the minimum likelihood as not found', async () => {
- httpClient.get.mockResolvedValue({
- status: 200,
- data: { status: 200, likelihood: 1, data: { name: 'Acme Inc' } },
- });
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'notFound',
- });
- });
-
- it('should treat a rejected request as a transient error', async () => {
- httpClient.get.mockRejectedValue(new Error('socket hang up'));
-
- await expect(service.enrichCompanyByDomain(domain)).resolves.toEqual({
- outcome: 'transientError',
- httpStatus: 0,
- message: 'socket hang up',
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/dns-manager/services/dns-manager.service.spec.ts b/packages/twenty-server/src/engine/core-modules/dns-manager/services/dns-manager.service.spec.ts
deleted file mode 100644
index 08c2a97e7ff..00000000000
--- a/packages/twenty-server/src/engine/core-modules/dns-manager/services/dns-manager.service.spec.ts
+++ /dev/null
@@ -1,359 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import Cloudflare from 'cloudflare';
-import { type CustomHostnameCreateResponse } from 'cloudflare/resources/custom-hostnames/custom-hostnames';
-import { AuditContextMock } from 'test/utils/audit-context.mock';
-
-import { EventLogEmitterService } from 'src/engine/core-modules/event-logs/emit/event-log-emitter.service';
-import { DnsManagerException } from 'src/engine/core-modules/dns-manager/exceptions/dns-manager.exception';
-import { DnsManagerService } from 'src/engine/core-modules/dns-manager/services/dns-manager.service';
-import { DomainServerConfigService } from 'src/engine/core-modules/domain/domain-server-config/services/domain-server-config.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-jest.mock('cloudflare');
-
-describe('DnsManagerService', () => {
- let dnsManagerService: DnsManagerService;
- let twentyConfigService: TwentyConfigService;
- let domainServerConfigService: DomainServerConfigService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- DnsManagerService,
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: EventLogEmitterService,
- useValue: {
- createContext: AuditContextMock,
- },
- },
- {
- provide: DomainServerConfigService,
- useValue: {
- getBaseUrl: jest.fn(),
- getPublicDomainUrl: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {
- save: jest.fn(),
- },
- },
- ],
- }).compile();
-
- dnsManagerService = module.get<DnsManagerService>(DnsManagerService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- domainServerConfigService = module.get<DomainServerConfigService>(
- DomainServerConfigService,
- );
-
- (dnsManagerService as any).cloudflareClient = {
- customHostnames: {
- list: jest.fn(),
- create: jest.fn(),
- },
- };
-
- jest.clearAllMocks();
- });
-
- it('should initialize cloudflareClient when CLOUDFLARE_API_KEY is defined', () => {
- const mockApiKey = 'test-api-key';
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(mockApiKey);
-
- const instance = new DnsManagerService(twentyConfigService, {} as any);
-
- expect(twentyConfigService.get).toHaveBeenCalledWith('CLOUDFLARE_API_KEY');
- expect(Cloudflare).toHaveBeenCalledWith({ apiToken: mockApiKey });
- expect(instance.cloudflareClient).toBeDefined();
- });
-
- describe('registerHostname', () => {
- it('should throw an error when the hostname is already registered', async () => {
- const customDomain = 'example.com';
-
- jest
- .spyOn(dnsManagerService, 'getHostnameId')
- .mockResolvedValueOnce('hostname-id');
-
- await expect(
- dnsManagerService.registerHostname(customDomain),
- ).rejects.toThrow(DnsManagerException);
-
- expect(dnsManagerService.getHostnameId).toHaveBeenCalledWith(
- customDomain,
- undefined,
- );
- });
-
- it('should register a custom domain successfully', async () => {
- const customDomain = 'example.com';
- const createMock = jest.fn().mockResolvedValueOnce({});
- const cloudflareMock = {
- customHostnames: {
- create: createMock,
- },
- };
-
- jest
- .spyOn(dnsManagerService, 'getHostnameId')
- .mockResolvedValueOnce(undefined);
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('test-zone-id');
- (dnsManagerService as any).cloudflareClient = cloudflareMock;
-
- await dnsManagerService.registerHostname(customDomain);
-
- expect(createMock).toHaveBeenCalledWith({
- zone_id: 'test-zone-id',
- hostname: customDomain,
- ssl: expect.any(Object),
- });
- });
- });
-
- describe('getHostnameWithRecords', () => {
- it('should return undefined if no custom domain details are found', async () => {
- const customDomain = 'example.com';
- const cloudflareMock = {
- customHostnames: {
- list: jest.fn().mockResolvedValueOnce({ result: [] }),
- },
- };
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('test-zone-id');
- (dnsManagerService as any).cloudflareClient = cloudflareMock;
-
- const result = await dnsManagerService.getHostnameWithRecords(
- customDomain,
- { isPublicDomain: false },
- );
-
- expect(result).toBeUndefined();
- expect(cloudflareMock.customHostnames.list).toHaveBeenCalledWith({
- zone_id: 'test-zone-id',
- hostname: customDomain,
- });
- });
- it('should return even if no record found', async () => {
- const customDomain = 'example.com';
- const mockResult = {
- id: 'custom-id',
- hostname: customDomain,
- ownership_verification: undefined,
- verification_errors: [],
- ssl: {
- dcv_delegation_records: [],
- },
- };
- const cloudflareMock = {
- customHostnames: {
- list: jest.fn().mockResolvedValueOnce({ result: [mockResult] }),
- },
- };
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('test-zone-id');
-
- jest
- .spyOn(domainServerConfigService, 'getBaseUrl')
- .mockReturnValue(new URL('https://front.domain'));
- (dnsManagerService as any).cloudflareClient = cloudflareMock;
-
- const result = await dnsManagerService.getHostnameWithRecords(
- customDomain,
- { isPublicDomain: false },
- );
-
- expect(result).toEqual({
- id: 'custom-id',
- domain: customDomain,
- records: expect.any(Array),
- });
- });
-
- it('should return domain details if a single result is found', async () => {
- const customDomain = 'example.com';
- const mockResult = {
- id: 'custom-id',
- hostname: customDomain,
- ownership_verification: {
- type: 'txt',
- name: 'ownership',
- value: 'value',
- },
- ssl: {
- validation_records: [{ txt_name: 'ssl', txt_value: 'validation' }],
- },
- verification_errors: [],
- };
- const cloudflareMock = {
- customHostnames: {
- list: jest.fn().mockResolvedValueOnce({ result: [mockResult] }),
- },
- };
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('test-zone-id');
- jest
- .spyOn(domainServerConfigService, 'getBaseUrl')
- .mockReturnValue(new URL('https://front.domain'));
- (dnsManagerService as any).cloudflareClient = cloudflareMock;
-
- const result = await dnsManagerService.getHostnameWithRecords(
- customDomain,
- { isPublicDomain: false },
- );
-
- expect(result).toEqual({
- id: 'custom-id',
- domain: customDomain,
- records: expect.any(Array),
- });
-
- expect(result?.records[0].value === 'https://front.domain');
- });
-
- it('should return public domain details', async () => {
- const customDomain = 'example.com';
- const mockResult = {
- id: 'custom-id',
- hostname: customDomain,
- ownership_verification: {
- type: 'txt',
- name: 'ownership',
- value: 'value',
- },
- ssl: {
- validation_records: [{ txt_name: 'ssl', txt_value: 'validation' }],
- },
- verification_errors: [],
- };
- const cloudflareMock = {
- customHostnames: {
- list: jest.fn().mockResolvedValueOnce({ result: [mockResult] }),
- },
- };
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('test-zone-id');
- jest
- .spyOn(domainServerConfigService, 'getBaseUrl')
- .mockReturnValue(new URL('https://front.domain'));
-
- jest
- .spyOn(domainServerConfigService, 'getPublicDomainUrl')
- .mockReturnValue(new URL('https://front.public-domain'));
-
- (dnsManagerService as any).cloudflareClient = cloudflareMock;
-
- const result = await dnsManagerService.getHostnameWithRecords(
- customDomain,
- { isPublicDomain: true },
- );
-
- expect(result).toEqual({
- id: 'custom-id',
- domain: customDomain,
- records: expect.any(Array),
- });
-
- expect(result?.records[0].value === 'https://front.public-domain');
- });
-
- it('should throw an error if multiple results are found', async () => {
- const customDomain = 'example.com';
- const cloudflareMock = {
- customHostnames: {
- list: jest.fn().mockResolvedValueOnce({ result: [{}, {}] }),
- },
- };
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('test-zone-id');
- (dnsManagerService as any).cloudflareClient = cloudflareMock;
-
- await expect(
- dnsManagerService.getHostnameWithRecords(customDomain, {
- isPublicDomain: false,
- }),
- ).rejects.toThrow(Error);
- });
- });
-
- describe('updateHostname', () => {
- it('should update a custom domain and register a new one', async () => {
- const fromHostname = 'old.com';
- const toHostname = 'new.com';
-
- jest
- .spyOn(dnsManagerService, 'getHostnameId')
- .mockResolvedValueOnce('old-id');
- jest
- .spyOn(dnsManagerService, 'deleteHostname')
- .mockResolvedValueOnce(undefined);
-
- const registerSpy = jest
- .spyOn(dnsManagerService, 'registerHostname')
- .mockResolvedValueOnce({} as unknown as CustomHostnameCreateResponse);
-
- await dnsManagerService.updateHostname(fromHostname, toHostname);
-
- expect(dnsManagerService.getHostnameId).toHaveBeenCalledWith(
- fromHostname,
- undefined,
- );
- expect(dnsManagerService.deleteHostname).toHaveBeenCalledWith(
- 'old-id',
- undefined,
- );
- expect(registerSpy).toHaveBeenCalledWith(toHostname, undefined);
- });
- });
-
- describe('deleteHostnameSilently', () => {
- it('should delete the custom hostname silently', async () => {
- const customDomain = 'example.com';
-
- jest
- .spyOn(dnsManagerService, 'getHostnameId')
- .mockResolvedValueOnce('custom-id');
- const deleteMock = jest.fn();
- const cloudflareMock = {
- customHostnames: {
- delete: deleteMock,
- },
- };
-
- jest.spyOn(twentyConfigService, 'get').mockReturnValue('test-zone-id');
- (dnsManagerService as any).cloudflareClient = cloudflareMock;
-
- await expect(
- dnsManagerService.deleteHostnameSilently(customDomain),
- ).resolves.toBeUndefined();
-
- expect(deleteMock).toHaveBeenCalledWith('custom-id', {
- zone_id: 'test-zone-id',
- });
- });
-
- it('should silently handle errors', async () => {
- const customDomain = 'example.com';
-
- jest
- .spyOn(dnsManagerService, 'getHostnameId')
- .mockRejectedValueOnce(new Error('Failure'));
-
- await expect(
- dnsManagerService.deleteHostnameSilently(customDomain),
- ).resolves.toBeUndefined();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/domain/domain-server-config/services/__test__/domain-server-config.service.spec.ts b/packages/twenty-server/src/engine/core-modules/domain/domain-server-config/services/__test__/domain-server-config.service.spec.ts
deleted file mode 100644
index 0dbb8955c89..00000000000
--- a/packages/twenty-server/src/engine/core-modules/domain/domain-server-config/services/__test__/domain-server-config.service.spec.ts
+++ /dev/null
@@ -1,82 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { ApprovedAccessDomainEntity } from 'src/engine/core-modules/approved-access-domain/approved-access-domain.entity';
-import { DomainServerConfigService } from 'src/engine/core-modules/domain/domain-server-config/services/domain-server-config.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-describe('SubdomainManagerService', () => {
- let domainServerConfigService: DomainServerConfigService;
- let twentyConfigService: TwentyConfigService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- DomainServerConfigService,
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {
- find: jest.fn(),
- findOne: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(ApprovedAccessDomainEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- ],
- }).compile();
-
- domainServerConfigService = module.get<DomainServerConfigService>(
- DomainServerConfigService,
- );
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- });
-
- describe('buildBaseUrl', () => {
- it('should build the base URL from environment variables', () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- const result = domainServerConfigService.getBaseUrl();
-
- expect(result.toString()).toBe('https://example.com/');
- });
-
- it('should append default subdomain if multiworkspace is enabled', () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- IS_MULTIWORKSPACE_ENABLED: true,
- DEFAULT_SUBDOMAIN: 'test',
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- const result = domainServerConfigService.getBaseUrl();
-
- expect(result.toString()).toBe('https://test.example.com/');
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/services/__test__/subdomain-manager.service.spec.ts b/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/services/__test__/subdomain-manager.service.spec.ts
deleted file mode 100644
index c1fedd8536b..00000000000
--- a/packages/twenty-server/src/engine/core-modules/domain/subdomain-manager/services/__test__/subdomain-manager.service.spec.ts
+++ /dev/null
@@ -1,116 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { SubdomainManagerService } from 'src/engine/core-modules/domain/subdomain-manager/services/subdomain-manager.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-describe('SubdomainManagerService', () => {
- let service: SubdomainManagerService;
- const takenSubdomains = new Set<string>();
- let areAllSubdomainsTaken = false;
-
- beforeEach(async () => {
- takenSubdomains.clear();
- areAllSubdomainsTaken = false;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- SubdomainManagerService,
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {
- findOne: jest.fn((options: { where: { subdomain: string } }) =>
- Promise.resolve(
- areAllSubdomainsTaken ||
- takenSubdomains.has(options.where.subdomain)
- ? ({} as WorkspaceEntity)
- : null,
- ),
- ),
- find: jest.fn(
- (options: { where: { subdomain: { value: string[] } } }) =>
- Promise.resolve(
- options.where.subdomain.value
- .filter(
- (candidate) =>
- areAllSubdomainsTaken || takenSubdomains.has(candidate),
- )
- .map((subdomain) => ({ subdomain }) as WorkspaceEntity),
- ),
- ),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn().mockReturnValue('app'),
- },
- },
- ],
- }).compile();
-
- service = module.get(SubdomainManagerService);
- });
-
- describe('getSubdomainAvailability', () => {
- it('returns the input as the only suggestion when it is free', async () => {
- const result = await service.getSubdomainAvailability('stripe');
-
- expect(result.isValid).toBe(true);
- expect(result.available).toBe(true);
- expect(result.suggestedSubdomain).toBe('stripe');
- expect(result.suggestedSubdomains).toEqual(['stripe']);
- });
-
- it('returns three distinct available alternatives when taken', async () => {
- takenSubdomains.add('stripe');
-
- const result = await service.getSubdomainAvailability('stripe');
-
- expect(result.available).toBe(false);
- expect(result.suggestedSubdomains).toHaveLength(3);
- expect(new Set(result.suggestedSubdomains).size).toBe(3);
- expect(result.suggestedSubdomains).not.toContain('stripe');
- expect(result.suggestedSubdomain).toBe(result.suggestedSubdomains[0]);
- result.suggestedSubdomains.forEach((candidate) =>
- expect(takenSubdomains.has(candidate)).toBe(false),
- );
- });
-
- it('skips taken numbered suffixes when collecting alternatives', async () => {
- takenSubdomains.add('stripe');
- takenSubdomains.add('stripe-2');
-
- const result = await service.getSubdomainAvailability('stripe');
-
- expect(result.suggestedSubdomains).toEqual([
- 'stripe-3',
- 'stripe-4',
- 'stripe-5',
- ]);
- });
- });
-
- describe('findAvailableSubdomains', () => {
- it('returns the requested number of distinct available subdomains', async () => {
- takenSubdomains.add('acme');
-
- const subdomains = await service.findAvailableSubdomains('acme', 3);
-
- expect(subdomains).toHaveLength(3);
- expect(new Set(subdomains).size).toBe(3);
- subdomains.forEach((candidate) =>
- expect(takenSubdomains.has(candidate)).toBe(false),
- );
- });
-
- it('does not pad with unverified subdomains when availability is scarce', async () => {
- areAllSubdomainsTaken = true;
-
- const subdomains = await service.findAvailableSubdomains('acme', 3);
-
- expect(subdomains).toHaveLength(1);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/domain/workspace-domains/services/__test__/workspace-domains.service.spec.ts b/packages/twenty-server/src/engine/core-modules/domain/workspace-domains/services/__test__/workspace-domains.service.spec.ts
deleted file mode 100644
index 49cc3e6523a..00000000000
--- a/packages/twenty-server/src/engine/core-modules/domain/workspace-domains/services/__test__/workspace-domains.service.spec.ts
+++ /dev/null
@@ -1,385 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { type Repository } from 'typeorm';
-
-import { DomainServerConfigService } from 'src/engine/core-modules/domain/domain-server-config/services/domain-server-config.service';
-import { WorkspaceDomainsService } from 'src/engine/core-modules/domain/workspace-domains/services/workspace-domains.service';
-import { PublicDomainEntity } from 'src/engine/core-modules/public-domain/public-domain.entity';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-describe('WorkspaceDomainsService', () => {
- let workspaceDomainsService: WorkspaceDomainsService;
- let twentyConfigService: TwentyConfigService;
- let workspaceRepository: Repository<WorkspaceEntity>;
- let publicDomainRepository: Repository<PublicDomainEntity>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- DomainServerConfigService,
- WorkspaceDomainsService,
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {
- find: jest.fn(),
- findOne: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(PublicDomainEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- ],
- }).compile();
-
- workspaceRepository = module.get<Repository<WorkspaceEntity>>(
- getRepositoryToken(WorkspaceEntity),
- );
- publicDomainRepository = module.get<Repository<PublicDomainEntity>>(
- getRepositoryToken(PublicDomainEntity),
- );
- workspaceDomainsService = module.get<WorkspaceDomainsService>(
- WorkspaceDomainsService,
- );
-
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- });
-
- describe('getWorkspaceUrls', () => {
- it('should return a URL containing the correct customDomain if customDomain is provided', () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- const result = workspaceDomainsService.getWorkspaceUrls({
- subdomain: 'subdomain',
- customDomain: 'custom-host.com',
- isCustomDomainEnabled: true,
- });
-
- expect(result).toEqual({
- customUrl: 'https://custom-host.com/',
- subdomainUrl: 'https://example.com/',
- });
- });
-
- it('should return a URL containing the correct subdomain if customDomain is not provided but subdomain is', () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- IS_MULTIWORKSPACE_ENABLED: true,
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- const result = workspaceDomainsService.getWorkspaceUrls({
- subdomain: 'subdomain',
- customDomain: null,
- isCustomDomainEnabled: false,
- });
-
- expect(result).toEqual({
- customUrl: undefined,
- subdomainUrl: 'https://subdomain.example.com/',
- });
- });
- });
-
- describe('buildWorkspaceURL', () => {
- it('should build workspace URL with given subdomain', () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- IS_MULTIWORKSPACE_ENABLED: true,
- DEFAULT_SUBDOMAIN: 'default',
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- const result = workspaceDomainsService.buildWorkspaceURL({
- workspace: {
- subdomain: 'test',
- customDomain: null,
- isCustomDomainEnabled: false,
- },
- });
-
- expect(result.toString()).toBe('https://test.example.com/');
- });
-
- it('should set the pathname if provided', () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- const result = workspaceDomainsService.buildWorkspaceURL({
- workspace: {
- subdomain: 'test',
- customDomain: null,
- isCustomDomainEnabled: false,
- },
- pathname: '/path/to/resource',
- });
-
- expect(result.pathname).toBe('/path/to/resource');
- });
-
- it('should set the search parameters if provided', () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- const result = workspaceDomainsService.buildWorkspaceURL({
- workspace: {
- subdomain: 'test',
- customDomain: null,
- isCustomDomainEnabled: false,
- },
- searchParams: {
- foo: 'bar',
- baz: 123,
- },
- });
-
- expect(result.searchParams.get('foo')).toBe('bar');
- expect(result.searchParams.get('baz')).toBe('123');
- });
-
- it('should set the hash if provided', () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- const result = workspaceDomainsService.buildWorkspaceURL({
- workspace: {
- subdomain: 'test',
- customDomain: null,
- isCustomDomainEnabled: false,
- },
- pathname: '/settings/members',
- searchParams: {
- wtdId: 'domain-id',
- },
- hash: 'invite',
- });
-
- expect(result.hash).toBe('#invite');
- expect(result.searchParams.get('wtdId')).toBe('domain-id');
- expect(result.toString()).toBe(
- 'https://example.com/settings/members?wtdId=domain-id#invite',
- );
- });
- });
-
- describe('getWorkspaceByOriginOrDefaultWorkspace', () => {
- it('should return default workspace if IS_MULTIWORKSPACE_ENABLED=false', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- IS_MULTIWORKSPACE_ENABLED: false,
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- jest.spyOn(workspaceRepository, 'find').mockResolvedValueOnce([
- {
- id: 'workspace-id',
- },
- ] as unknown as WorkspaceEntity[]);
-
- const result =
- await workspaceDomainsService.getWorkspaceByOriginOrDefaultWorkspace(
- 'https://example.com',
- );
-
- expect(result?.id).toEqual('workspace-id');
- });
-
- it('should return 1st workspace if multiple workspaces when IS_MULTIWORKSPACE_ENABLED=false', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- IS_MULTIWORKSPACE_ENABLED: false,
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- jest.spyOn(workspaceRepository, 'find').mockResolvedValueOnce([
- {
- id: 'workspace-id1',
- },
- {
- id: 'workspace-id2',
- },
- ] as unknown as WorkspaceEntity[]);
-
- const result =
- await workspaceDomainsService.getWorkspaceByOriginOrDefaultWorkspace(
- 'https://example.com',
- );
-
- expect(result?.id).toEqual('workspace-id1');
- });
-
- it('should return workspace by subdomain', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- IS_MULTIWORKSPACE_ENABLED: true,
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- jest.spyOn(workspaceRepository, 'findOne').mockResolvedValueOnce({
- id: 'workspace-id1',
- subdomain: '123',
- } as unknown as Promise<WorkspaceEntity>);
-
- const result =
- await workspaceDomainsService.getWorkspaceByOriginOrDefaultWorkspace(
- 'https://123.example.com',
- );
-
- expect(result?.id).toEqual('workspace-id1');
- });
-
- it('should return workspace by customDomain', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- IS_MULTIWORKSPACE_ENABLED: true,
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- jest.spyOn(workspaceRepository, 'findOne').mockResolvedValueOnce({
- id: 'workspace-id1',
- customDomain: '123.custom.com',
- } as unknown as Promise<WorkspaceEntity>);
-
- const result =
- await workspaceDomainsService.getWorkspaceByOriginOrDefaultWorkspace(
- 'https://123.custom.com',
- );
-
- expect(result?.id).toEqual('workspace-id1');
- });
-
- it('should return workspace by publicDomain', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- IS_MULTIWORKSPACE_ENABLED: true,
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- jest.spyOn(workspaceRepository, 'findOne').mockResolvedValueOnce({
- id: 'workspace-id1',
- } as unknown as Promise<WorkspaceEntity>);
-
- jest.spyOn(publicDomainRepository, 'findOne').mockResolvedValueOnce({
- domain: '123.custom.com',
- workspaceId: 'workspace-id1',
- } as unknown as Promise<PublicDomainEntity>);
-
- const result =
- await workspaceDomainsService.getWorkspaceByOriginOrDefaultWorkspace(
- 'https://123.custom.com',
- );
-
- expect(result?.id).toEqual('workspace-id1');
- });
-
- it('should return undefined if nothing found', async () => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- const env = {
- FRONTEND_URL: 'https://example.com',
- IS_MULTIWORKSPACE_ENABLED: true,
- };
-
- // @ts-expect-error legacy noImplicitAny
- return env[key];
- });
-
- jest.spyOn(workspaceRepository, 'findOne').mockResolvedValueOnce(null);
-
- jest.spyOn(publicDomainRepository, 'findOne').mockResolvedValueOnce(null);
-
- const result =
- await workspaceDomainsService.getWorkspaceByOriginOrDefaultWorkspace(
- 'https://123.custom.com',
- );
-
- expect(result).toEqual(undefined);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/dpa/services/__tests__/dpa.service.spec.ts b/packages/twenty-server/src/engine/core-modules/dpa/services/__tests__/dpa.service.spec.ts
deleted file mode 100644
index c61d038a16a..00000000000
--- a/packages/twenty-server/src/engine/core-modules/dpa/services/__tests__/dpa.service.spec.ts
+++ /dev/null
@@ -1,67 +0,0 @@
-import { BadRequestException } from '@nestjs/common';
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { DpaAgreementEntity } from 'src/engine/core-modules/dpa/entities/dpa-agreement.entity';
-import { DpaRegionService } from 'src/engine/core-modules/dpa/services/dpa-region.service';
-import { DpaService } from 'src/engine/core-modules/dpa/services/dpa.service';
-import { FileStorageService } from 'src/engine/core-modules/file-storage/services/file-storage.service';
-import { FileUrlService } from 'src/engine/core-modules/file/file-url/file-url.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-// @react-pdf/renderer (via the PDF util) is ESM-only and jest can't parse it;
-// mock the util so importing DpaService doesn't load it.
-jest.mock('src/engine/core-modules/dpa/pdf/render-dpa-to-pdf.util', () => ({
- renderDpaToPdfBuffer: jest.fn(),
-}));
-
-describe('DpaService', () => {
- let service: DpaService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- DpaService,
- {
- provide: getRepositoryToken(DpaAgreementEntity),
- useValue: { find: jest.fn(), save: jest.fn() },
- },
- {
- provide: DpaRegionService,
- useValue: { getRegionForWorkspace: jest.fn() },
- },
- { provide: FileStorageService, useValue: { writeFile: jest.fn() } },
- { provide: FileUrlService, useValue: { signFileByIdUrl: jest.fn() } },
- {
- provide: ApplicationService,
- useValue: {
- findWorkspaceTwentyStandardAndCustomApplicationOrThrow: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: { get: jest.fn().mockReturnValue(false) },
- },
- ],
- }).compile();
-
- service = module.get<DpaService>(DpaService);
- });
-
- it('refuses to generate a signed DPA on self-hosted deployments', async () => {
- const generate = service.generateSignedDpa({
- workspace: { id: 'ws-1' },
- userId: 'user-1',
- userEmail: '[email protected]',
- input: {
- customerLegalEntityName: 'Acme GmbH',
- signatoryName: 'Jane Doe',
- signatoryTitle: 'Head of Legal',
- },
- });
-
- await expect(generate).rejects.toBeInstanceOf(BadRequestException);
- await expect(generate).rejects.toThrow(/self-hosted deployments/i);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/email/__tests__/email-sender.service.spec.ts b/packages/twenty-server/src/engine/core-modules/email/__tests__/email-sender.service.spec.ts
deleted file mode 100644
index 1bf1e83ecfb..00000000000
--- a/packages/twenty-server/src/engine/core-modules/email/__tests__/email-sender.service.spec.ts
+++ /dev/null
@@ -1,73 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type SendMailOptions } from 'nodemailer';
-
-import { EmailDriverFactory } from 'src/engine/core-modules/email/email-driver.factory';
-import { EmailSenderService } from 'src/engine/core-modules/email/email-sender.service';
-
-describe('EmailSenderService', () => {
- let service: EmailSenderService;
- let emailDriverFactory: EmailDriverFactory;
-
- const mockEmailDriverFactory = {
- getCurrentDriver: jest.fn(),
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- EmailSenderService,
- {
- provide: EmailDriverFactory,
- useValue: mockEmailDriverFactory,
- },
- ],
- }).compile();
-
- service = module.get<EmailSenderService>(EmailSenderService);
- emailDriverFactory = module.get<EmailDriverFactory>(EmailDriverFactory);
-
- jest.clearAllMocks();
- });
-
- describe('send', () => {
- it('should delegate to the current driver', async () => {
- const mockDriver = {
- send: jest.fn().mockResolvedValue(undefined),
- };
-
- mockEmailDriverFactory.getCurrentDriver.mockReturnValue(mockDriver);
-
- const sendMailOptions: SendMailOptions = {
- subject: 'Test',
- text: 'Test message',
- };
-
- await service.send(sendMailOptions);
-
- expect(emailDriverFactory.getCurrentDriver).toHaveBeenCalled();
- expect(mockDriver.send).toHaveBeenCalledWith(sendMailOptions);
- });
-
- it('should handle driver errors', async () => {
- const mockDriver = {
- send: jest.fn().mockRejectedValue(new Error('Driver error')),
- };
-
- mockEmailDriverFactory.getCurrentDriver.mockReturnValue(mockDriver);
-
- const sendMailOptions: SendMailOptions = {
- subject: 'Test',
- text: 'Test message',
- };
-
- await expect(service.send(sendMailOptions)).rejects.toThrow(
- 'Driver error',
- );
- expect(emailDriverFactory.getCurrentDriver).toHaveBeenCalled();
- expect(mockDriver.send).toHaveBeenCalledWith(sendMailOptions);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/emailing-domain/drivers/aws-ses/services/__tests__/aws-ses-driver-domain-status.service.spec.ts b/packages/twenty-server/src/engine/core-modules/emailing-domain/drivers/aws-ses/services/__tests__/aws-ses-driver-domain-status.service.spec.ts
deleted file mode 100644
index 98ee10637fb..00000000000
--- a/packages/twenty-server/src/engine/core-modules/emailing-domain/drivers/aws-ses/services/__tests__/aws-ses-driver-domain-status.service.spec.ts
+++ /dev/null
@@ -1,94 +0,0 @@
-import { type AwsSesClientProvider } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/providers/aws-ses-client.provider';
-import { AwsSesDriver } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/services/aws-ses-driver.service';
-import { type AwsSesHandleErrorService } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/services/aws-ses-handle-error.service';
-import { type AwsSesRegisterDomainService } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/services/aws-ses-register-domain.service';
-import { type AwsSesSendEmailService } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/services/aws-ses-send-email.service';
-import { type AwsSesDriverConfig } from 'src/engine/core-modules/emailing-domain/drivers/interfaces/driver-config.interface';
-import { EmailingDomainDriver } from 'src/engine/core-modules/emailing-domain/drivers/types/emailing-domain-driver.type';
-import { EmailingDomainStatus } from 'src/engine/core-modules/emailing-domain/drivers/types/emailing-domain-status.type';
-import { type UnsubscribeContentService } from 'src/engine/core-modules/emailing-domain/services/unsubscribe-content.service';
-
-describe('AwsSesDriver getDomainStatus', () => {
- const config: AwsSesDriverConfig = {
- driver: EmailingDomainDriver.AWS_SES,
- region: 'us-east-1',
- accountId: '123456789012',
- };
-
- const setUp = (identityResponse: Record<string, unknown>) => {
- const send = jest.fn().mockResolvedValue(identityResponse);
- const clientProvider = {
- getSESClient: () => ({ send }),
- } as unknown as AwsSesClientProvider;
-
- const driver = new AwsSesDriver(
- config,
- clientProvider,
- {} as unknown as AwsSesHandleErrorService,
- {} as unknown as AwsSesRegisterDomainService,
- {} as unknown as AwsSesSendEmailService,
- {} as unknown as UnsubscribeContentService,
- );
-
- return driver.getDomainStatus({
- domain: 'twenty.dev',
- workspaceId: 'workspace-id',
- });
- };
-
- it('should report pending while SES is still waiting for the DKIM records', async () => {
- const result = await setUp({
- VerifiedForSendingStatus: false,
- DkimAttributes: { SigningEnabled: true, Status: 'PENDING', Tokens: [] },
- });
-
- expect(result.status).toBe(EmailingDomainStatus.PENDING);
- });
-
- it('should report pending when a DKIM check fails temporarily', async () => {
- const result = await setUp({
- VerifiedForSendingStatus: false,
- DkimAttributes: {
- SigningEnabled: true,
- Status: 'TEMPORARY_FAILURE',
- Tokens: [],
- },
- });
-
- expect(result.status).toBe(EmailingDomainStatus.PENDING);
- });
-
- it('should report failed when SES gave up on the DKIM records', async () => {
- const result = await setUp({
- VerifiedForSendingStatus: false,
- DkimAttributes: { SigningEnabled: true, Status: 'FAILED', Tokens: [] },
- });
-
- expect(result.status).toBe(EmailingDomainStatus.FAILED);
- });
-
- it('should report verified once SES signs with DKIM', async () => {
- const result = await setUp({
- VerifiedForSendingStatus: true,
- DkimAttributes: { SigningEnabled: true, Status: 'SUCCESS', Tokens: [] },
- });
-
- expect(result.status).toBe(EmailingDomainStatus.VERIFIED);
- });
-
- it('should mark every DKIM record pending while the domain is pending', async () => {
- const result = await setUp({
- VerifiedForSendingStatus: false,
- DkimAttributes: {
- SigningEnabled: true,
- Status: 'PENDING',
- Tokens: ['token1', 'token2', 'token3'],
- },
- });
-
- expect(result.verificationRecords).toHaveLength(3);
- expect(
- result.verificationRecords.every((record) => record.status === 'pending'),
- ).toBe(true);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/emailing-domain/drivers/aws-ses/services/__tests__/aws-ses-register-domain.service.spec.ts b/packages/twenty-server/src/engine/core-modules/emailing-domain/drivers/aws-ses/services/__tests__/aws-ses-register-domain.service.spec.ts
deleted file mode 100644
index 86e6095ecb3..00000000000
--- a/packages/twenty-server/src/engine/core-modules/emailing-domain/drivers/aws-ses/services/__tests__/aws-ses-register-domain.service.spec.ts
+++ /dev/null
@@ -1,126 +0,0 @@
-import {
- AlreadyExistsException,
- CreateConfigurationSetCommand,
- CreateConfigurationSetEventDestinationCommand,
- CreateTenantResourceAssociationCommand,
- PutEmailIdentityMailFromAttributesCommand,
-} from '@aws-sdk/client-sesv2';
-
-import { type AwsSesClientProvider } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/providers/aws-ses-client.provider';
-import { type AwsSesObservabilityService } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/services/aws-ses-observability.service';
-import { AwsSesRegisterDomainService } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/services/aws-ses-register-domain.service';
-import { type AwsSesDriverConfig } from 'src/engine/core-modules/emailing-domain/drivers/interfaces/driver-config.interface';
-import { EmailingDomainDriver } from 'src/engine/core-modules/emailing-domain/drivers/types/emailing-domain-driver.type';
-
-describe('AwsSesRegisterDomainService', () => {
- const config: AwsSesDriverConfig = {
- driver: EmailingDomainDriver.AWS_SES,
- region: 'us-east-1',
- accountId: '123456789012',
- };
-
- const provisionInput = {
- tenantName: 'twenty-workspace-ws1',
- configurationSetName: 'twenty-workspace-ws1',
- };
-
- const buildAlreadyExists = () =>
- new AlreadyExistsException({
- $metadata: { httpStatusCode: 409 },
- message: 'Resource already exists.',
- });
-
- const setUp = () => {
- const send = jest.fn();
- const clientProvider = {
- getSESClient: () => ({ send }),
- } as unknown as AwsSesClientProvider;
- const awsSesObservabilityService = {
- addEventDestination: jest.fn().mockResolvedValue(undefined),
- } as unknown as AwsSesObservabilityService;
- const service = new AwsSesRegisterDomainService(
- clientProvider,
- awsSesObservabilityService,
- );
-
- return { service, send };
- };
-
- describe('provisionWorkspaceResources', () => {
- it('creates every workspace-scoped resource', async () => {
- const { service, send } = setUp();
-
- send.mockResolvedValue({});
-
- await service.provisionWorkspaceResources(provisionInput, config);
-
- const commandTypes = send.mock.calls.map(
- ([command]) => command.constructor.name,
- );
-
- expect(commandTypes).toEqual([
- CreateConfigurationSetCommand.name,
- CreateConfigurationSetEventDestinationCommand.name,
- CreateTenantResourceAssociationCommand.name,
- ]);
- });
-
- it('ignores AlreadyExistsException per resource so a retry re-runs every step', async () => {
- const { service, send } = setUp();
-
- send.mockRejectedValue(buildAlreadyExists());
-
- await service.provisionWorkspaceResources(provisionInput, config);
-
- const commandTypes = send.mock.calls.map(
- ([command]) => command.constructor.name,
- );
-
- expect(commandTypes).toEqual([
- CreateConfigurationSetCommand.name,
- CreateConfigurationSetEventDestinationCommand.name,
- CreateTenantResourceAssociationCommand.name,
- ]);
- });
-
- it('propagates AWS errors that are not AlreadyExistsException', async () => {
- const { service, send } = setUp();
- const fatalError = new Error('Boom');
-
- send.mockRejectedValue(fatalError);
-
- await expect(
- service.provisionWorkspaceResources(provisionInput, config),
- ).rejects.toBe(fatalError);
- });
- });
-
- describe('registerDomain', () => {
- it('configures custom MAIL FROM using the bounce subdomain', async () => {
- const { service, send } = setUp();
-
- send.mockResolvedValue({});
-
- await service.registerDomain('mail.example.com');
-
- const commandTypes = send.mock.calls.map(
- ([command]) => command.constructor.name,
- );
-
- expect(commandTypes).toEqual([
- PutEmailIdentityMailFromAttributesCommand.name,
- ]);
-
- const mailFromCall = send.mock.calls.find(
- ([command]) =>
- command instanceof PutEmailIdentityMailFromAttributesCommand,
- );
-
- expect(mailFromCall?.[0].input).toMatchObject({
- EmailIdentity: 'mail.example.com',
- MailFromDomain: 'bounce.mail.example.com',
- BehaviorOnMxFailure: 'USE_DEFAULT_VALUE',
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/emailing-domain/drivers/aws-ses/services/__tests__/aws-ses-send-email.service.spec.ts b/packages/twenty-server/src/engine/core-modules/emailing-domain/drivers/aws-ses/services/__tests__/aws-ses-send-email.service.spec.ts
deleted file mode 100644
index c709ef74509..00000000000
--- a/packages/twenty-server/src/engine/core-modules/emailing-domain/drivers/aws-ses/services/__tests__/aws-ses-send-email.service.spec.ts
+++ /dev/null
@@ -1,109 +0,0 @@
-import { SendEmailCommand } from '@aws-sdk/client-sesv2';
-
-import { type AwsSesClientProvider } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/providers/aws-ses-client.provider';
-import { type AwsSesHandleErrorService } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/services/aws-ses-handle-error.service';
-import { AwsSesSendEmailService } from 'src/engine/core-modules/emailing-domain/drivers/aws-ses/services/aws-ses-send-email.service';
-import {
- EmailingDomainDriverException,
- EmailingDomainDriverExceptionCode,
-} from 'src/engine/core-modules/emailing-domain/drivers/exceptions/emailing-domain-driver.exception';
-
-describe('AwsSesSendEmailService', () => {
- const baseInput = {
- workspaceId: 'ws1',
- domain: 'mail.example.com',
- subject: 'Hello',
- text: 'World',
- };
-
- const baseContext = {
- tenantName: 'twenty-workspace-ws1',
- configurationSetName: 'twenty-workspace-ws1',
- };
-
- const setUp = () => {
- const send = jest.fn();
- const clientProvider = {
- getSESClient: () => ({ send }),
- } as unknown as AwsSesClientProvider;
- const handleErrorService = {
- handleAwsSesError: jest.fn((error) => {
- throw error;
- }),
- } as unknown as AwsSesHandleErrorService;
- const service = new AwsSesSendEmailService(
- clientProvider,
- handleErrorService,
- );
-
- return { service, send, handleErrorService };
- };
-
- it('should call SendEmail with tenant and config set', async () => {
- const { service, send } = setUp();
-
- send.mockResolvedValue({ MessageId: 'msg-1' });
-
- const result = await service.sendEmail(baseInput, baseContext);
-
- expect(result.messageId).toBe('msg-1');
-
- const [command] = send.mock.calls[0];
-
- expect(command).toBeInstanceOf(SendEmailCommand);
- expect(command.input).toMatchObject({
- FromEmailAddress: '[email protected]',
- Destination: { ToAddresses: ['[email protected]'] },
- ConfigurationSetName: 'twenty-workspace-ws1',
- TenantName: 'twenty-workspace-ws1',
- });
- expect(command.input.ListManagementOptions).toBeUndefined();
- expect(command.input.EmailTags).toEqual(
- expect.arrayContaining([
- { Name: 'workspace', Value: 'ws1' },
- { Name: 'domain', Value: 'mail.example.com' },
- ]),
- );
- });
-
- it('should throw when SES returns no MessageId', async () => {
- const { service, send } = setUp();
-
- send.mockResolvedValue({});
-
- await expect(service.sendEmail(baseInput, baseContext)).rejects.toThrow(
- EmailingDomainDriverException,
- );
- });
-
- it('should reject empty recipient list before calling SES', async () => {
- const { service, send } = setUp();
-
- await expect(
- service.sendEmail({ ...baseInput, to: [] }, baseContext),
- ).rejects.toMatchObject({
- code: EmailingDomainDriverExceptionCode.CONFIGURATION_ERROR,
- });
- expect(send).not.toHaveBeenCalled();
- });
-
- it('should route AWS errors through the error handler', async () => {
- const { service, send, handleErrorService } = setUp();
- const awsError = Object.assign(new Error('Rejected'), {
- name: 'MessageRejected',
- $metadata: { httpStatusCode: 400 },
- });
-
- send.mockRejectedValue(awsError);
-
- await expect(service.sendEmail(baseInput, baseContext)).rejects.toBe(
- awsError,
- );
- expect(handleErrorService.handleAwsSesError).toHaveBeenCalledWith(
- awsError,
- 'sendEmail',
- );
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/enterprise/services/__tests__/enterprise-plan.service.spec.ts b/packages/twenty-server/src/engine/core-modules/enterprise/services/__tests__/enterprise-plan.service.spec.ts
deleted file mode 100644
index 39dcede81fc..00000000000
--- a/packages/twenty-server/src/engine/core-modules/enterprise/services/__tests__/enterprise-plan.service.spec.ts
+++ /dev/null
@@ -1,929 +0,0 @@
-/* @license Enterprise */
-
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { AppTokenEntity } from 'src/engine/core-modules/app-token/app-token.entity';
-import { EnterprisePlanService } from 'src/engine/core-modules/enterprise/services/enterprise-plan.service';
-import { NodeEnvironment } from 'src/engine/core-modules/twenty-config/interfaces/node-environment.interface';
-import {
- ConfigVariableException,
- ConfigVariableExceptionCode,
-} from 'src/engine/core-modules/twenty-config/twenty-config.exception';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-const mockCryptoVerify = jest.fn();
-
-jest.mock('crypto', () => ({
- ...jest.requireActual('crypto'),
- verify: (...args: unknown[]) => mockCryptoVerify(...args),
-}));
-
-const createFakeJwt = (payload: Record<string, unknown>): string => {
- const header = Buffer.from(
- JSON.stringify({ alg: 'RS256', typ: 'JWT' }),
- ).toString('base64url');
- const body = Buffer.from(JSON.stringify(payload)).toString('base64url');
- const signature = Buffer.from('fake-signature').toString('base64url');
-
- return `${header}.${body}.${signature}`;
-};
-
-const MOCK_API_URL = 'https://enterprise.example.com';
-const FUTURE_TIMESTAMP = Math.floor(Date.now() / 1000) + 3600;
-const PAST_TIMESTAMP = Math.floor(Date.now() / 1000) - 3600;
-
-const MOCK_KEY_PAYLOAD = {
- sub: 'sub-123',
- licensee: 'ACME Corp',
- iat: 1000,
-};
-
-const MOCK_VALIDITY_PAYLOAD = {
- sub: 'sub-123',
- status: 'valid',
- iat: 1000,
- exp: FUTURE_TIMESTAMP,
-};
-
-const MOCK_EXPIRED_VALIDITY_PAYLOAD = {
- sub: 'sub-123',
- status: 'valid',
- iat: 1000,
- exp: PAST_TIMESTAMP,
-};
-
-describe('EnterprisePlanService', () => {
- let service: EnterprisePlanService;
-
- const configGetMock = jest.fn();
- const configSetMock = jest.fn();
- const appTokenFindOneMock = jest.fn();
- const transactionMock = jest.fn();
- const fetchMock = jest.fn();
- const workspaceCountMock = jest.fn();
- const userCountMock = jest.fn();
- const userWorkspaceCountMock = jest.fn();
- const userWorkspaceGetRawOneMock = jest.fn();
- const userWorkspaceQueryBuilderMock = {
- select: jest.fn().mockReturnThis(),
- where: jest.fn().mockReturnThis(),
- getRawOne: userWorkspaceGetRawOneMock,
- };
- const userFindOneMock = jest.fn();
-
- let originalFetch: typeof global.fetch;
-
- const setupEnterpriseKey = (key?: string) => {
- configGetMock.mockImplementation((configKey: string) => {
- if (configKey === 'ENTERPRISE_KEY') return key;
- if (configKey === 'ENTERPRISE_API_URL') return MOCK_API_URL;
-
- return undefined;
- });
- };
-
- const setupValidState = async (
- overrides: {
- keyPayload?: Record<string, unknown>;
- validityPayload?: Record<string, unknown>;
- cryptoVerifyResult?: boolean;
- } = {},
- ) => {
- const {
- keyPayload = MOCK_KEY_PAYLOAD,
- validityPayload = MOCK_VALIDITY_PAYLOAD,
- cryptoVerifyResult = true,
- } = overrides;
-
- const fakeKey = createFakeJwt(keyPayload);
- const fakeValidityToken = createFakeJwt(validityPayload);
-
- setupEnterpriseKey(fakeKey);
- mockCryptoVerify.mockReturnValue(cryptoVerifyResult);
- appTokenFindOneMock.mockResolvedValue({ value: fakeValidityToken });
-
- await service.onModuleInit();
- };
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- originalFetch = global.fetch;
- global.fetch = fetchMock as unknown as typeof fetch;
-
- configGetMock.mockImplementation((key: string) => {
- if (key === 'ENTERPRISE_API_URL') return MOCK_API_URL;
-
- return undefined;
- });
-
- appTokenFindOneMock.mockResolvedValue(null);
- workspaceCountMock.mockResolvedValue(0);
- userCountMock.mockResolvedValue(0);
- userWorkspaceCountMock.mockResolvedValue(0);
- userWorkspaceQueryBuilderMock.select.mockReturnThis();
- userWorkspaceQueryBuilderMock.where.mockReturnThis();
- userWorkspaceGetRawOneMock.mockResolvedValue({ distinctUserCount: '0' });
- userFindOneMock.mockResolvedValue(null);
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- EnterprisePlanService,
- {
- provide: TwentyConfigService,
- useValue: {
- get: configGetMock,
- set: configSetMock,
- },
- },
- {
- provide: getRepositoryToken(AppTokenEntity),
- useValue: {
- findOne: appTokenFindOneMock,
- target: AppTokenEntity,
- manager: {
- transaction: transactionMock,
- },
- },
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: {
- count: userWorkspaceCountMock,
- createQueryBuilder: jest
- .fn()
- .mockReturnValue(userWorkspaceQueryBuilderMock),
- },
- },
- {
- provide: getRepositoryToken(UserEntity),
- useValue: { count: userCountMock, findOne: userFindOneMock },
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: { count: workspaceCountMock },
- },
- ],
- }).compile();
-
- service = module.get<EnterprisePlanService>(EnterprisePlanService);
- });
-
- afterEach(() => {
- global.fetch = originalFetch;
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('onModuleInit', () => {
- it('should populate caches when enterprise key and validity token exist', async () => {
- await setupValidState();
-
- expect(service.hasValidSignedEnterpriseKey()).toBe(true);
- expect(service.hasValidEnterpriseValidityToken()).toBe(true);
- });
-
- it('should handle missing enterprise key', async () => {
- setupEnterpriseKey(undefined);
- appTokenFindOneMock.mockResolvedValue(null);
-
- await service.onModuleInit();
-
- expect(service.hasValidSignedEnterpriseKey()).toBe(false);
- expect(service.hasValidEnterpriseValidityToken()).toBe(false);
- });
-
- it('should handle DB error when loading validity token', async () => {
- setupEnterpriseKey(createFakeJwt(MOCK_KEY_PAYLOAD));
- mockCryptoVerify.mockReturnValue(true);
- appTokenFindOneMock.mockRejectedValue(new Error('DB connection failed'));
-
- await service.onModuleInit();
-
- expect(service.hasValidSignedEnterpriseKey()).toBe(true);
- expect(service.hasValidEnterpriseValidityToken()).toBe(false);
- });
-
- it('should fall back to ENTERPRISE_VALIDITY_TOKEN config when DB has no token', async () => {
- const fakeKey = createFakeJwt(MOCK_KEY_PAYLOAD);
- const fakeValidityToken = createFakeJwt(MOCK_VALIDITY_PAYLOAD);
-
- configGetMock.mockImplementation((key: string) => {
- if (key === 'ENTERPRISE_KEY') return fakeKey;
- if (key === 'ENTERPRISE_API_URL') return MOCK_API_URL;
- if (key === 'ENTERPRISE_VALIDITY_TOKEN') return fakeValidityToken;
-
- return undefined;
- });
- mockCryptoVerify.mockReturnValue(true);
- appTokenFindOneMock.mockResolvedValue(null);
-
- await service.onModuleInit();
-
- expect(service.hasValidEnterpriseValidityToken()).toBe(true);
- });
-
- it('should prefer DB token over ENTERPRISE_VALIDITY_TOKEN config', async () => {
- const fakeKey = createFakeJwt(MOCK_KEY_PAYLOAD);
- const dbToken = createFakeJwt(MOCK_VALIDITY_PAYLOAD);
- const envToken = createFakeJwt(MOCK_EXPIRED_VALIDITY_PAYLOAD);
-
- configGetMock.mockImplementation((key: string) => {
- if (key === 'ENTERPRISE_KEY') return fakeKey;
- if (key === 'ENTERPRISE_API_URL') return MOCK_API_URL;
- if (key === 'ENTERPRISE_VALIDITY_TOKEN') return envToken;
-
- return undefined;
- });
- mockCryptoVerify.mockReturnValue(true);
- appTokenFindOneMock.mockResolvedValue({ value: dbToken });
-
- await service.onModuleInit();
-
- expect(service.hasValidEnterpriseValidityToken()).toBe(true);
- });
-
- it('should reject validity token with non-valid status', async () => {
- const invalidStatusPayload = {
- ...MOCK_VALIDITY_PAYLOAD,
- status: 'revoked',
- };
-
- setupEnterpriseKey(createFakeJwt(MOCK_KEY_PAYLOAD));
- mockCryptoVerify.mockReturnValue(true);
- appTokenFindOneMock.mockResolvedValue({
- value: createFakeJwt(invalidStatusPayload),
- });
-
- await service.onModuleInit();
-
- expect(service.hasValidEnterpriseValidityToken()).toBe(false);
- });
- });
-
- describe('hasValidSignedEnterpriseKey', () => {
- it('should return false when no enterprise key is configured', async () => {
- setupEnterpriseKey(undefined);
- await service.onModuleInit();
-
- expect(service.hasValidSignedEnterpriseKey()).toBe(false);
- });
-
- it('should return true when key has valid signature', async () => {
- setupEnterpriseKey(createFakeJwt(MOCK_KEY_PAYLOAD));
- mockCryptoVerify.mockReturnValue(true);
- await service.onModuleInit();
-
- expect(service.hasValidSignedEnterpriseKey()).toBe(true);
- });
-
- it('should return false when key has invalid signature', async () => {
- setupEnterpriseKey(createFakeJwt(MOCK_KEY_PAYLOAD));
- mockCryptoVerify.mockReturnValue(false);
- await service.onModuleInit();
-
- expect(service.hasValidSignedEnterpriseKey()).toBe(false);
- });
-
- it('should return false when key is not a valid JWT format', async () => {
- setupEnterpriseKey('not-a-jwt');
- await service.onModuleInit();
-
- expect(service.hasValidSignedEnterpriseKey()).toBe(false);
- });
- });
-
- describe('hasValidEnterpriseValidityToken', () => {
- it('should return false when no validity token exists', async () => {
- setupEnterpriseKey(undefined);
- appTokenFindOneMock.mockResolvedValue(null);
- await service.onModuleInit();
-
- expect(service.hasValidEnterpriseValidityToken()).toBe(false);
- });
-
- it('should return true when validity token is valid and not expired', async () => {
- await setupValidState();
-
- expect(service.hasValidEnterpriseValidityToken()).toBe(true);
- });
-
- it('should return false when validity token is expired', async () => {
- await setupValidState({
- validityPayload: MOCK_EXPIRED_VALIDITY_PAYLOAD,
- });
-
- expect(service.hasValidEnterpriseValidityToken()).toBe(false);
- });
- });
-
- describe('isValid', () => {
- it('should return true when validity token is valid', async () => {
- await setupValidState();
-
- expect(service.isValid()).toBe(true);
- });
-
- it('should return false with unsigned legacy key', async () => {
- setupEnterpriseKey('some-legacy-key');
- mockCryptoVerify.mockReturnValue(false);
- appTokenFindOneMock.mockResolvedValue(null);
- await service.onModuleInit();
-
- expect(service.isValid()).toBe(false);
- });
-
- it('should return false when no key or token exists', async () => {
- setupEnterpriseKey(undefined);
- appTokenFindOneMock.mockResolvedValue(null);
- await service.onModuleInit();
-
- expect(service.isValid()).toBe(false);
- });
- });
-
- describe('isValidEnterpriseKeyFormat', () => {
- it('should return true for valid JWT format', () => {
- mockCryptoVerify.mockReturnValue(true);
- const validKey = createFakeJwt(MOCK_KEY_PAYLOAD);
-
- expect(service.isValidEnterpriseKeyFormat(validKey)).toBe(true);
- });
-
- it('should return false for invalid JWT format', () => {
- expect(service.isValidEnterpriseKeyFormat('not-a-jwt')).toBe(false);
- });
-
- it('should return false when signature verification fails', () => {
- mockCryptoVerify.mockReturnValue(false);
- const invalidKey = createFakeJwt(MOCK_KEY_PAYLOAD);
-
- expect(service.isValidEnterpriseKeyFormat(invalidKey)).toBe(false);
- });
-
- it('should accept production key when NODE_ENV is development', () => {
- configGetMock.mockImplementation((key: string) => {
- if (key === 'NODE_ENV') return NodeEnvironment.DEVELOPMENT;
- if (key === 'ENTERPRISE_API_URL') return MOCK_API_URL;
-
- return undefined;
- });
- mockCryptoVerify.mockReturnValueOnce(false).mockReturnValueOnce(true);
- const productionKey = createFakeJwt(MOCK_KEY_PAYLOAD);
-
- expect(service.isValidEnterpriseKeyFormat(productionKey)).toBe(true);
- expect(mockCryptoVerify).toHaveBeenCalledTimes(2);
- });
- });
-
- describe('getLicenseInfo', () => {
- it('should return valid license info when validity token exists', async () => {
- await setupValidState();
-
- const licenseInfo = await service.getLicenseInfo();
-
- expect(licenseInfo).toEqual({
- isValid: true,
- licensee: 'ACME Corp',
- expiresAt: new Date(FUTURE_TIMESTAMP * 1000),
- subscriptionId: 'sub-123',
- });
- });
-
- it('should return expired license info when validity token is expired', async () => {
- await setupValidState({
- validityPayload: MOCK_EXPIRED_VALIDITY_PAYLOAD,
- });
-
- const licenseInfo = await service.getLicenseInfo();
-
- expect(licenseInfo).toEqual({
- isValid: false,
- licensee: 'ACME Corp',
- expiresAt: new Date(PAST_TIMESTAMP * 1000),
- subscriptionId: 'sub-123',
- });
- });
-
- it('should return invalid license info when only unsigned legacy key exists', async () => {
- setupEnterpriseKey('some-legacy-key');
- mockCryptoVerify.mockReturnValue(false);
- appTokenFindOneMock.mockResolvedValue(null);
-
- const licenseInfo = await service.getLicenseInfo();
-
- expect(licenseInfo).toEqual({
- isValid: false,
- licensee: null,
- expiresAt: null,
- subscriptionId: null,
- });
- });
-
- it('should return invalid license info when no key exists', async () => {
- setupEnterpriseKey(undefined);
- appTokenFindOneMock.mockResolvedValue(null);
-
- const licenseInfo = await service.getLicenseInfo();
-
- expect(licenseInfo).toEqual({
- isValid: false,
- licensee: null,
- expiresAt: null,
- subscriptionId: null,
- });
- });
- });
-
- describe('setEnterpriseKey', () => {
- it('should set the enterprise key via config service', async () => {
- configSetMock.mockResolvedValue(undefined);
-
- await service.setEnterpriseKey('new-enterprise-key');
-
- expect(configSetMock).toHaveBeenCalledWith(
- 'ENTERPRISE_KEY',
- 'new-enterprise-key',
- );
- });
-
- it('should throw specific error when DB config is disabled', async () => {
- configSetMock.mockRejectedValue(
- new ConfigVariableException(
- 'Database config disabled',
- ConfigVariableExceptionCode.DATABASE_CONFIG_DISABLED,
- ),
- );
-
- await expect(service.setEnterpriseKey('key')).rejects.toThrow(
- 'IS_CONFIG_VARIABLES_IN_DB_ENABLED is false on your server',
- );
- });
-
- it('should re-throw other errors', async () => {
- configSetMock.mockRejectedValue(new Error('Unexpected error'));
-
- await expect(service.setEnterpriseKey('key')).rejects.toThrow(
- 'Unexpected error',
- );
- });
- });
-
- describe('refreshValidityToken', () => {
- it('should return false when no enterprise key is configured', async () => {
- setupEnterpriseKey(undefined);
-
- const result = await service.refreshValidityToken();
-
- expect(result).toBe(false);
- expect(fetchMock).not.toHaveBeenCalled();
- });
-
- it('should return false when key is not a valid signed JWT', async () => {
- setupEnterpriseKey('not-a-valid-jwt');
-
- const result = await service.refreshValidityToken();
-
- expect(result).toBe(false);
- expect(fetchMock).not.toHaveBeenCalled();
- });
-
- it('should refresh and return true when API call succeeds', async () => {
- const fakeKey = createFakeJwt(MOCK_KEY_PAYLOAD);
- const fakeValidityToken = createFakeJwt(MOCK_VALIDITY_PAYLOAD);
-
- setupEnterpriseKey(fakeKey);
- mockCryptoVerify.mockReturnValue(true);
-
- fetchMock.mockResolvedValue({
- ok: true,
- json: () => Promise.resolve({ validityToken: fakeValidityToken }),
- });
-
- transactionMock.mockImplementation(
- async (callback: (manager: Record<string, jest.Mock>) => void) => {
- await callback({
- update: jest.fn(),
- save: jest.fn(),
- });
- },
- );
-
- appTokenFindOneMock.mockResolvedValue({ value: fakeValidityToken });
-
- const result = await service.refreshValidityToken();
-
- expect(result).toBe(true);
-
- const [validateUrl, validateOptions] = fetchMock.mock.calls[0] as [
- string,
- { method: string; headers: Record<string, string>; body: string },
- ];
-
- expect(validateUrl).toBe(`${MOCK_API_URL}/validate`);
- expect(validateOptions.method).toBe('POST');
-
- const validateBody = JSON.parse(validateOptions.body);
-
- expect(validateBody.enterpriseKey).toBe(fakeKey);
- expect(validateBody.instanceMetadata).toBeDefined();
- });
-
- it('should include instance metadata in the validate payload', async () => {
- const fakeKey = createFakeJwt(MOCK_KEY_PAYLOAD);
-
- configGetMock.mockImplementation((key: string) => {
- if (key === 'ENTERPRISE_KEY') return fakeKey;
- if (key === 'ENTERPRISE_API_URL') return MOCK_API_URL;
- if (key === 'SERVER_ID') return 'server-abc';
- if (key === 'SERVER_URL') return 'https://crm.example.com';
- if (key === 'APP_VERSION') return '1.2.3';
- if (key === 'NODE_ENV') return NodeEnvironment.PRODUCTION;
- if (key === 'TELEMETRY_ENABLED') return true;
-
- return undefined;
- });
- mockCryptoVerify.mockReturnValue(true);
- workspaceCountMock.mockResolvedValue(2);
- userWorkspaceCountMock.mockResolvedValue(7);
- userCountMock.mockResolvedValue(5);
- userFindOneMock.mockResolvedValue({ email: '[email protected]' });
-
- fetchMock.mockResolvedValue({
- ok: true,
- json: () =>
- Promise.resolve({
- validityToken: createFakeJwt(MOCK_VALIDITY_PAYLOAD),
- }),
- });
- transactionMock.mockImplementation(
- async (callback: (manager: Record<string, jest.Mock>) => void) => {
- await callback({ update: jest.fn(), save: jest.fn() });
- },
- );
- appTokenFindOneMock.mockResolvedValue({
- value: createFakeJwt(MOCK_VALIDITY_PAYLOAD),
- });
-
- await service.refreshValidityToken();
-
- const [, options] = fetchMock.mock.calls[0] as [string, { body: string }];
- const body = JSON.parse(options.body);
-
- expect(body.instanceMetadata).toMatchObject({
- serverId: 'server-abc',
- serverUrl: 'https://crm.example.com',
- appVersion: '1.2.3',
- nodeEnv: NodeEnvironment.PRODUCTION,
- telemetryEnabled: true,
- workspaceCount: 2,
- activeUserWorkspaceCount: 7,
- distinctUserCount: 5,
- adminContactEmail: '[email protected]',
- });
- expect(typeof body.instanceMetadata.sentAt).toBe('string');
- });
-
- it('should return false when API returns non-OK response', async () => {
- const fakeKey = createFakeJwt(MOCK_KEY_PAYLOAD);
-
- setupEnterpriseKey(fakeKey);
- mockCryptoVerify.mockReturnValue(true);
-
- fetchMock.mockResolvedValue({
- ok: false,
- status: 401,
- json: () => Promise.resolve({ error: 'Unauthorized' }),
- });
-
- const result = await service.refreshValidityToken();
-
- expect(result).toBe(false);
- });
-
- it('should return false when API response is missing validityToken', async () => {
- const fakeKey = createFakeJwt(MOCK_KEY_PAYLOAD);
-
- setupEnterpriseKey(fakeKey);
- mockCryptoVerify.mockReturnValue(true);
-
- fetchMock.mockResolvedValue({
- ok: true,
- json: () => Promise.resolve({}),
- });
-
- const result = await service.refreshValidityToken();
-
- expect(result).toBe(false);
- });
-
- it('should return false on network error', async () => {
- const fakeKey = createFakeJwt(MOCK_KEY_PAYLOAD);
-
- setupEnterpriseKey(fakeKey);
- mockCryptoVerify.mockReturnValue(true);
-
- fetchMock.mockRejectedValue(new Error('Network error'));
-
- const result = await service.refreshValidityToken();
-
- expect(result).toBe(false);
- });
- });
-
- describe('getBillableSeatCount', () => {
- it('should count distinct users so a user in several workspaces is one seat', async () => {
- userWorkspaceGetRawOneMock.mockResolvedValue({ distinctUserCount: '5' });
-
- const result = await service.getBillableSeatCount();
-
- expect(result).toBe(5);
- expect(userWorkspaceQueryBuilderMock.select).toHaveBeenCalledWith(
- 'COUNT(DISTINCT "userWorkspace"."userId")',
- 'distinctUserCount',
- );
- expect(userWorkspaceQueryBuilderMock.where).toHaveBeenCalledWith(
- '"userWorkspace"."deletedAt" IS NULL',
- );
- });
-
- it('should return at least 1 when there are no active user workspaces', async () => {
- userWorkspaceGetRawOneMock.mockResolvedValue({ distinctUserCount: '0' });
-
- const result = await service.getBillableSeatCount();
-
- expect(result).toBe(1);
- });
-
- it('should return at least 1 when the query returns no row', async () => {
- userWorkspaceGetRawOneMock.mockResolvedValue(undefined);
-
- const result = await service.getBillableSeatCount();
-
- expect(result).toBe(1);
- });
- });
-
- describe('reportSeats', () => {
- it('should return false when no enterprise key is configured', async () => {
- setupEnterpriseKey(undefined);
-
- const result = await service.reportSeats(10);
-
- expect(result).toBe(false);
- expect(fetchMock).not.toHaveBeenCalled();
- });
-
- it('should return false when key is not a valid signed JWT', async () => {
- setupEnterpriseKey('not-a-valid-jwt');
- appTokenFindOneMock.mockResolvedValue(null);
- await service.onModuleInit();
-
- const result = await service.reportSeats(10);
-
- expect(result).toBe(false);
- });
-
- it('should report seats and return true on success', async () => {
- await setupValidState();
-
- fetchMock.mockResolvedValue({
- ok: true,
- json: () => Promise.resolve({ success: true }),
- });
-
- const result = await service.reportSeats(25);
-
- expect(result).toBe(true);
- expect(fetchMock).toHaveBeenCalledWith(
- `${MOCK_API_URL}/seats`,
- expect.objectContaining({
- method: 'POST',
- headers: { 'Content-Type': 'application/json' },
- }),
- );
-
- const callBody = JSON.parse(
- (fetchMock.mock.calls[0] as [string, { body: string }])[1].body,
- );
-
- expect(callBody.seatCount).toBe(25);
- });
-
- it('should return false when API returns non-OK response', async () => {
- await setupValidState();
-
- fetchMock.mockResolvedValue({ ok: false, status: 500 });
-
- const result = await service.reportSeats(10);
-
- expect(result).toBe(false);
- });
-
- it('should return false on network error', async () => {
- await setupValidState();
-
- fetchMock.mockRejectedValue(new Error('Connection refused'));
-
- const result = await service.reportSeats(10);
-
- expect(result).toBe(false);
- });
- });
-
- describe('getSubscriptionStatus', () => {
- it('should return null when no enterprise key is configured', async () => {
- setupEnterpriseKey(undefined);
-
- const result = await service.getSubscriptionStatus();
-
- expect(result).toBeNull();
- });
-
- it('should return subscription status on success', async () => {
- await setupValidState();
-
- const cancelAtTimestamp = Math.floor(Date.now() / 1000) + 86400;
- const periodEndTimestamp = Math.floor(Date.now() / 1000) + 2592000;
-
- fetchMock.mockResolvedValue({
- ok: true,
- json: () =>
- Promise.resolve({
- status: 'active',
- cancelAt: cancelAtTimestamp,
- currentPeriodEnd: periodEndTimestamp,
- isCancellationScheduled: false,
- }),
- });
-
- const result = await service.getSubscriptionStatus();
-
- expect(result).toEqual({
- status: 'active',
- licensee: 'ACME Corp',
- expiresAt: new Date(FUTURE_TIMESTAMP * 1000),
- cancelAt: new Date(cancelAtTimestamp * 1000),
- currentPeriodEnd: new Date(periodEndTimestamp * 1000),
- isCancellationScheduled: false,
- });
- });
-
- it('should return null when API returns non-OK response', async () => {
- await setupValidState();
-
- fetchMock.mockResolvedValue({ ok: false, status: 500 });
-
- const result = await service.getSubscriptionStatus();
-
- expect(result).toBeNull();
- });
-
- it('should return null on network error', async () => {
- await setupValidState();
-
- fetchMock.mockRejectedValue(new Error('Network error'));
-
- const result = await service.getSubscriptionStatus();
-
- expect(result).toBeNull();
- });
-
- it('should handle null cancelAt and currentPeriodEnd', async () => {
- await setupValidState();
-
- fetchMock.mockResolvedValue({
- ok: true,
- json: () =>
- Promise.resolve({
- status: 'active',
- cancelAt: null,
- currentPeriodEnd: null,
- }),
- });
-
- const result = await service.getSubscriptionStatus();
-
- expect(result?.cancelAt).toBeNull();
- expect(result?.currentPeriodEnd).toBeNull();
- expect(result?.isCancellationScheduled).toBe(false);
- });
- });
-
- describe('getPortalUrl', () => {
- it('should return null when no API URL is configured', async () => {
- configGetMock.mockReturnValue(undefined);
-
- const result = await service.getPortalUrl();
-
- expect(result).toBeNull();
- });
-
- it('should return null when no valid enterprise key exists', async () => {
- setupEnterpriseKey(undefined);
-
- const result = await service.getPortalUrl();
-
- expect(result).toBeNull();
- });
-
- it('should return portal URL on success', async () => {
- await setupValidState();
-
- fetchMock.mockResolvedValue({
- ok: true,
- json: () => Promise.resolve({ url: 'https://portal.example.com' }),
- });
-
- const result = await service.getPortalUrl('https://return.example.com');
-
- expect(result).toBe('https://portal.example.com');
- expect(fetchMock).toHaveBeenCalledWith(
- `${MOCK_API_URL}/portal`,
- expect.objectContaining({
- method: 'POST',
- headers: { 'Content-Type': 'application/json' },
- }),
- );
- });
-
- it('should return null when API fails', async () => {
- await setupValidState();
-
- fetchMock.mockResolvedValue({ ok: false, status: 500 });
-
- const result = await service.getPortalUrl();
-
- expect(result).toBeNull();
- });
-
- it('should return null on network error', async () => {
- await setupValidState();
-
- fetchMock.mockRejectedValue(new Error('Network error'));
-
- const result = await service.getPortalUrl();
-
- expect(result).toBeNull();
- });
- });
-
- describe('getCheckoutUrl', () => {
- it('should return null when no API URL is configured', async () => {
- configGetMock.mockReturnValue(undefined);
-
- const result = await service.getCheckoutUrl('monthly', 5);
-
- expect(result).toBeNull();
- });
-
- it('should return checkout URL on success', async () => {
- fetchMock.mockResolvedValue({
- ok: true,
- json: () => Promise.resolve({ url: 'https://checkout.example.com' }),
- });
-
- const result = await service.getCheckoutUrl('yearly', 10);
-
- expect(result).toBe('https://checkout.example.com');
- expect(fetchMock).toHaveBeenCalledWith(`${MOCK_API_URL}/checkout`, {
- method: 'POST',
- headers: { 'Content-Type': 'application/json' },
- body: JSON.stringify({ billingInterval: 'yearly', seatCount: 10 }),
- });
- });
-
- it('should return null when API fails', async () => {
- fetchMock.mockResolvedValue({ ok: false, status: 500 });
-
- const result = await service.getCheckoutUrl('monthly', 5);
-
- expect(result).toBeNull();
- });
-
- it('should return null on network error', async () => {
- fetchMock.mockRejectedValue(new Error('Network error'));
-
- const result = await service.getCheckoutUrl('monthly', 5);
-
- expect(result).toBeNull();
- });
-
- it('should return null when API response has no url', async () => {
- fetchMock.mockResolvedValue({
- ok: true,
- json: () => Promise.resolve({}),
- });
-
- const result = await service.getCheckoutUrl('monthly', 5);
-
- expect(result).toBeNull();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/event-logs/emit/event-log-emitter.service.spec.ts b/packages/twenty-server/src/engine/core-modules/event-logs/emit/event-log-emitter.service.spec.ts
deleted file mode 100644
index 4e852d00172..00000000000
--- a/packages/twenty-server/src/engine/core-modules/event-logs/emit/event-log-emitter.service.spec.ts
+++ /dev/null
@@ -1,149 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { AuditContextMock } from 'test/utils/audit-context.mock';
-
-import { ClickHouseService } from 'src/database/clickHouse/clickHouse.service';
-import { OBJECT_RECORD_CREATED_EVENT } from 'src/engine/core-modules/event-logs/emit/events/object-event/object-record-created';
-import { CUSTOM_DOMAIN_ACTIVATED_EVENT } from 'src/engine/core-modules/event-logs/emit/events/workspace-event/custom-domain/custom-domain-activated';
-import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-import { EventLogEmitterService } from './event-log-emitter.service';
-
-describe('EventLogEmitterService', () => {
- let service: EventLogEmitterService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- {
- provide: EventLogEmitterService,
- useValue: {
- createContext: AuditContextMock,
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn().mockReturnValue(true),
- },
- },
- {
- provide: ClickHouseService,
- useValue: {
- pushEvent: jest.fn(),
- },
- },
- {
- provide: ExceptionHandlerService,
- useValue: {
- captureExceptions: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<EventLogEmitterService>(EventLogEmitterService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('createContext', () => {
- const mockUserIdAndWorkspaceId = {
- userId: 'test-user-id',
- workspaceId: 'test-workspace-id',
- };
-
- it('should create a valid context object', () => {
- const context = service.createContext(mockUserIdAndWorkspaceId);
-
- expect(context).toHaveProperty('insertWorkspaceEvent');
- expect(context).toHaveProperty('createObjectEvent');
- expect(context).toHaveProperty('createPageviewEvent');
- });
-
- it('should call insertWorkspaceEvent with correct parameters', async () => {
- const insertWorkspaceEventSpy = jest
- .fn()
- .mockResolvedValue({ success: true });
- const mockContext = AuditContextMock({
- insertWorkspaceEvent: insertWorkspaceEventSpy,
- });
-
- jest.spyOn(service, 'createContext').mockReturnValue(mockContext);
-
- const context = service.createContext(mockUserIdAndWorkspaceId);
-
- await context.insertWorkspaceEvent(CUSTOM_DOMAIN_ACTIVATED_EVENT, {});
-
- expect(insertWorkspaceEventSpy).toHaveBeenCalledWith(
- CUSTOM_DOMAIN_ACTIVATED_EVENT,
- {},
- );
- });
-
- it('should call createPageviewEvent with correct parameters', async () => {
- const createPageviewEventSpy = jest
- .fn()
- .mockResolvedValue({ success: true });
- const mockContext = AuditContextMock({
- createPageviewEvent: createPageviewEventSpy,
- });
-
- jest.spyOn(service, 'createContext').mockReturnValue(mockContext);
-
- const context = service.createContext(mockUserIdAndWorkspaceId);
- const testPageviewProperties = {
- href: '/test-url',
- locale: '',
- pathname: '',
- referrer: '',
- sessionId: '',
- timeZone: '',
- userAgent: '',
- };
-
- await context.createPageviewEvent('page-view', testPageviewProperties);
-
- expect(createPageviewEventSpy).toHaveBeenCalledWith(
- 'page-view',
- testPageviewProperties,
- );
- });
-
- it('should return success when insertWorkspaceEvent is called', async () => {
- const context = service.createContext(mockUserIdAndWorkspaceId);
-
- const result = await context.insertWorkspaceEvent(
- CUSTOM_DOMAIN_ACTIVATED_EVENT,
- {},
- );
-
- expect(result).toEqual({ success: true });
- });
-
- it('should return success when createPageviewEvent is called', async () => {
- const context = service.createContext(mockUserIdAndWorkspaceId);
-
- const result = await context.createPageviewEvent('page-view', {});
-
- expect(result).toEqual({ success: true });
- });
-
- it('should return success when createObjectEvent is called', async () => {
- const context = service.createContext(mockUserIdAndWorkspaceId);
-
- const result = await context.createObjectEvent(
- OBJECT_RECORD_CREATED_EVENT,
- {
- recordId: 'test-record-id',
- objectMetadataId: 'test-object-metadata-id',
- },
- );
-
- expect(result).toEqual({ success: true });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/event-logs/event-logs.service.spec.ts b/packages/twenty-server/src/engine/core-modules/event-logs/event-logs.service.spec.ts
deleted file mode 100644
index 2dacb52ef52..00000000000
--- a/packages/twenty-server/src/engine/core-modules/event-logs/event-logs.service.spec.ts
+++ /dev/null
@@ -1,79 +0,0 @@
-import { EventLogTable } from 'twenty-shared/types';
-
-import { ClickHouseService } from 'src/database/clickHouse/clickHouse.service';
-import { BillingEntitlementKey } from 'src/engine/core-modules/billing/enums/billing-entitlement-key.enum';
-import { BillingService } from 'src/engine/core-modules/billing/services/billing.service';
-import { EnterprisePlanService } from 'src/engine/core-modules/enterprise/services/enterprise-plan.service';
-import { EventLogsExceptionCode } from 'src/engine/core-modules/event-logs/event-logs.exception';
-import { EventLogsService } from 'src/engine/core-modules/event-logs/event-logs.service';
-
-describe('EventLogsService.validateAccess', () => {
- let service: EventLogsService;
- let getMainClient: jest.Mock;
- let hasEntitlement: jest.Mock;
- let isValid: jest.Mock;
-
- beforeEach(() => {
- getMainClient = jest.fn().mockReturnValue({});
- hasEntitlement = jest.fn().mockResolvedValue(true);
- isValid = jest.fn().mockReturnValue(true);
-
- service = new EventLogsService(
- { getMainClient } as unknown as ClickHouseService,
- { hasEntitlement } as unknown as BillingService,
- { isValid } as unknown as EnterprisePlanService,
- {} as never,
- );
- });
-
- const validateAccessError = async (table: EventLogTable) =>
- service.validateAccess('ws-1', table).then(
- () => undefined,
- (error) => error,
- );
-
- it('throws CLICKHOUSE_NOT_CONFIGURED when ClickHouse is unavailable', async () => {
- getMainClient.mockReturnValue(undefined);
-
- const error = await validateAccessError(EventLogTable.WORKSPACE_EVENT);
-
- expect(error?.code).toBe(EventLogsExceptionCode.CLICKHOUSE_NOT_CONFIGURED);
- });
-
- it('allows application logs with no entitlement (free on every plan)', async () => {
- isValid.mockReturnValue(false);
- hasEntitlement.mockResolvedValue(false);
-
- await expect(
- service.validateAccess('ws-1', EventLogTable.APPLICATION_LOG),
- ).resolves.toBeUndefined();
- expect(hasEntitlement).not.toHaveBeenCalled();
- });
-
- it('throws NO_ENTITLEMENT for a gated table when the Enterprise plan is invalid (skips the billing call)', async () => {
- isValid.mockReturnValue(false);
-
- const error = await validateAccessError(EventLogTable.WORKSPACE_EVENT);
-
- expect(error?.code).toBe(EventLogsExceptionCode.NO_ENTITLEMENT);
- expect(hasEntitlement).not.toHaveBeenCalled();
- });
-
- it('throws NO_ENTITLEMENT for a gated table when the AUDIT_LOGS entitlement is missing', async () => {
- hasEntitlement.mockResolvedValue(false);
-
- const error = await validateAccessError(EventLogTable.USAGE_EVENT);
-
- expect(error?.code).toBe(EventLogsExceptionCode.NO_ENTITLEMENT);
- expect(hasEntitlement).toHaveBeenCalledWith(
- 'ws-1',
- BillingEntitlementKey.AUDIT_LOGS,
- );
- });
-
- it('allows a gated table when the plan is valid and the entitlement is held', async () => {
- await expect(
- service.validateAccess('ws-1', EventLogTable.OBJECT_EVENT),
- ).resolves.toBeUndefined();
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/exception-handler/__tests__/exception-handler.service.spec.ts b/packages/twenty-server/src/engine/core-modules/exception-handler/__tests__/exception-handler.service.spec.ts
deleted file mode 100644
index 498f81fd67d..00000000000
--- a/packages/twenty-server/src/engine/core-modules/exception-handler/__tests__/exception-handler.service.spec.ts
+++ /dev/null
@@ -1,26 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { EXCEPTION_HANDLER_DRIVER } from 'src/engine/core-modules/exception-handler/exception-handler.constants';
-import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
-
-describe('ExceptionHandlerService', () => {
- let service: ExceptionHandlerService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ExceptionHandlerService,
- {
- provide: EXCEPTION_HANDLER_DRIVER,
- useValue: {},
- },
- ],
- }).compile();
-
- service = module.get<ExceptionHandlerService>(ExceptionHandlerService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/feature-flag/services/__tests__/feature-flag.service.spec.ts b/packages/twenty-server/src/engine/core-modules/feature-flag/services/__tests__/feature-flag.service.spec.ts
deleted file mode 100644
index ccecac554d4..00000000000
--- a/packages/twenty-server/src/engine/core-modules/feature-flag/services/__tests__/feature-flag.service.spec.ts
+++ /dev/null
@@ -1,287 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { FeatureFlagKey } from 'twenty-shared/types';
-
-import { FeatureFlagEntity } from 'src/engine/core-modules/feature-flag/feature-flag.entity';
-import {
- FeatureFlagException,
- FeatureFlagExceptionCode,
-} from 'src/engine/core-modules/feature-flag/feature-flag.exception';
-import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
-import { featureFlagValidator } from 'src/engine/core-modules/feature-flag/validates/feature-flag.validate';
-import { publicFeatureFlagValidator } from 'src/engine/core-modules/feature-flag/validates/is-public-feature-flag.validate';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-jest.mock(
- 'src/engine/core-modules/feature-flag/validates/is-public-feature-flag.validate',
-);
-jest.mock(
- 'src/engine/core-modules/feature-flag/validates/feature-flag.validate',
-);
-
-describe('FeatureFlagService', () => {
- let service: FeatureFlagService;
-
- const mockFeatureFlagRepository = {
- findOneBy: jest.fn(),
- find: jest.fn(),
- upsert: jest.fn(),
- findOne: jest.fn(),
- save: jest.fn(),
- };
-
- const mockWorkspaceCacheService = {
- getOrRecompute: jest.fn(),
- invalidateAndRecompute: jest.fn(),
- };
-
- const workspaceId = 'workspace-id';
- const featureFlag = FeatureFlagKey.IS_JUNCTION_RELATIONS_ENABLED;
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- (
- publicFeatureFlagValidator.assertIsPublicFeatureFlag as jest.Mock
- ).mockReset();
- (featureFlagValidator.assertIsFeatureFlagKey as jest.Mock).mockReset();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- FeatureFlagService,
- {
- provide: getWorkspaceScopedRepositoryToken(FeatureFlagEntity),
- useValue: mockFeatureFlagRepository,
- },
- {
- provide: WorkspaceCacheService,
- useValue: mockWorkspaceCacheService,
- },
- ],
- }).compile();
-
- service = module.get<FeatureFlagService>(FeatureFlagService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('isFeatureEnabled', () => {
- it('should return true when feature flag is enabled', async () => {
- // Prepare
- mockWorkspaceCacheService.getOrRecompute.mockResolvedValue({
- featureFlagsMap: {
- [featureFlag]: true,
- },
- });
-
- // Act
- const result = await service.isFeatureEnabled(featureFlag, workspaceId);
-
- // Assert
- expect(result).toBe(true);
- expect(mockWorkspaceCacheService.getOrRecompute).toHaveBeenCalledWith(
- workspaceId,
- ['featureFlagsMap'],
- );
- });
-
- it('should return false when feature flag is not found', async () => {
- // Prepare
- mockWorkspaceCacheService.getOrRecompute.mockResolvedValue({
- featureFlagsMap: {},
- });
-
- // Act
- const result = await service.isFeatureEnabled(featureFlag, workspaceId);
-
- // Assert
- expect(result).toBe(false);
- });
-
- it('should return false when feature flag value is false', async () => {
- // Prepare
- mockFeatureFlagRepository.findOneBy.mockResolvedValue({
- key: featureFlag,
- value: false,
- });
-
- // Act
- const result = await service.isFeatureEnabled(featureFlag, workspaceId);
-
- // Assert
- expect(result).toBe(false);
- });
- });
-
- describe('getWorkspaceFeatureFlags', () => {
- it('should return all feature flags for a workspace', async () => {
- // Prepare
- mockWorkspaceCacheService.getOrRecompute.mockResolvedValue({
- featureFlagsMap: {
- [FeatureFlagKey.IS_JUNCTION_RELATIONS_ENABLED]: false,
- },
- });
- const mockFeatureFlags = [
- { key: FeatureFlagKey.IS_JUNCTION_RELATIONS_ENABLED, value: false },
- ];
-
- // Act
- const result = await service.getWorkspaceFeatureFlags(workspaceId);
-
- // Assert
- expect(result).toEqual(mockFeatureFlags);
- expect(mockWorkspaceCacheService.getOrRecompute).toHaveBeenCalledWith(
- workspaceId,
- ['featureFlagsMap'],
- );
- });
- });
-
- describe('getWorkspaceFeatureFlagsMap', () => {
- it('should return a map of feature flags for a workspace', async () => {
- // Prepare
- const mockFeatureFlags = [
- {
- key: FeatureFlagKey.IS_JUNCTION_RELATIONS_ENABLED,
- value: false,
- workspaceId,
- },
- ];
-
- mockFeatureFlagRepository.find.mockResolvedValue(mockFeatureFlags);
-
- // Act
- const result = await service.getWorkspaceFeatureFlagsMap(workspaceId);
-
- // Assert
- expect(result).toEqual({
- [FeatureFlagKey.IS_JUNCTION_RELATIONS_ENABLED]: false,
- });
- });
- });
-
- describe('enableFeatureFlags', () => {
- it('should enable multiple feature flags for a workspace', async () => {
- // Prepare
- const keys = [FeatureFlagKey.IS_JUNCTION_RELATIONS_ENABLED];
-
- mockFeatureFlagRepository.upsert.mockResolvedValue({});
- mockWorkspaceCacheService.invalidateAndRecompute.mockResolvedValue(
- undefined,
- );
-
- // Act
- await service.enableFeatureFlags(keys, workspaceId);
-
- // Assert
- expect(mockFeatureFlagRepository.upsert).toHaveBeenCalledWith(
- workspaceId,
- keys.map((key) => ({ key, value: true })),
- {
- conflictPaths: ['workspaceId', 'key'],
- skipUpdateIfNoValuesChanged: true,
- },
- );
- expect(
- mockWorkspaceCacheService.invalidateAndRecompute,
- ).toHaveBeenCalledWith(workspaceId, ['featureFlagsMap']);
- });
- });
-
- describe('upsertWorkspaceFeatureFlag', () => {
- it('should upsert a feature flag for a workspace', async () => {
- // Prepare
- const value = true;
- const mockFeatureFlag = {
- key: featureFlag,
- value,
- workspaceId,
- };
-
- mockFeatureFlagRepository.save.mockResolvedValue(mockFeatureFlag);
- mockWorkspaceCacheService.invalidateAndRecompute.mockResolvedValue(
- undefined,
- );
-
- (
- featureFlagValidator.assertIsFeatureFlagKey as jest.Mock
- ).mockImplementation(() => true);
-
- // Act
- const result = await service.upsertWorkspaceFeatureFlag({
- workspaceId,
- featureFlag,
- value,
- });
-
- // Assert
- expect(result).toEqual(mockFeatureFlag);
- expect(mockFeatureFlagRepository.save).toHaveBeenCalledWith(workspaceId, {
- key: FeatureFlagKey[featureFlag],
- value,
- });
- expect(
- mockWorkspaceCacheService.invalidateAndRecompute,
- ).toHaveBeenCalledWith(workspaceId, ['featureFlagsMap']);
- });
-
- it('should throw an exception when feature flag key is invalid', async () => {
- // Prepare
- const invalidFeatureFlag = 'INVALID_KEY' as FeatureFlagKey;
- const value = true;
-
- (
- featureFlagValidator.assertIsFeatureFlagKey as jest.Mock
- ).mockImplementation(() => {
- throw new FeatureFlagException(
- 'Invalid feature flag key',
- FeatureFlagExceptionCode.INVALID_FEATURE_FLAG_KEY,
- );
- });
-
- // Act & Assert
- await expect(
- service.upsertWorkspaceFeatureFlag({
- workspaceId,
- featureFlag: invalidFeatureFlag,
- value,
- }),
- ).rejects.toThrow(
- new FeatureFlagException(
- 'Invalid feature flag key',
- FeatureFlagExceptionCode.INVALID_FEATURE_FLAG_KEY,
- ),
- );
- });
-
- it('should throw an exception when non-public feature flag is used with shouldBePublic=true', async () => {
- // Prepare
- (
- publicFeatureFlagValidator.assertIsPublicFeatureFlag as jest.Mock
- ).mockImplementation(() => {
- throw new FeatureFlagException(
- 'Invalid feature flag key, flag is not public',
- FeatureFlagExceptionCode.INVALID_FEATURE_FLAG_KEY,
- );
- });
-
- // Act & Assert
- await expect(
- service.upsertWorkspaceFeatureFlag({
- workspaceId,
- featureFlag,
- value: true,
- shouldBePublic: true,
- }),
- ).rejects.toThrow(
- new FeatureFlagException(
- 'Invalid feature flag key, flag is not public',
- FeatureFlagExceptionCode.INVALID_FEATURE_FLAG_KEY,
- ),
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/file-storage/services/__tests__/file-storage.service.spec.ts b/packages/twenty-server/src/engine/core-modules/file-storage/services/__tests__/file-storage.service.spec.ts
deleted file mode 100644
index 6a477d9467f..00000000000
--- a/packages/twenty-server/src/engine/core-modules/file-storage/services/__tests__/file-storage.service.spec.ts
+++ /dev/null
@@ -1,919 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { FileFolder } from 'twenty-shared/types';
-import {
- type EachTestingContext,
- eachTestingContextFilter,
-} from 'twenty-shared/testing';
-
-import { FileStorageDriverFactory } from 'src/engine/core-modules/file-storage/file-storage-driver.factory';
-import { FileStorageService } from 'src/engine/core-modules/file-storage/services/file-storage.service';
-import { FileStorageExceptionCode } from 'src/engine/core-modules/file-storage/interfaces/file-storage-exception';
-import { FileEntity } from 'src/engine/core-modules/file/entities/file.entity';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-describe('FileStorageService', () => {
- let service: FileStorageService;
- let fileStorageDriverFactory: FileStorageDriverFactory;
-
- const mockFileStorageDriverFactory = {
- getCurrentDriver: jest.fn(),
- };
-
- const mockFileRepository = {
- save: jest.fn(),
- upsertAndReturnOne: jest.fn(),
- findOneOrFail: jest.fn(),
- delete: jest.fn(),
- withManager: jest.fn(),
- };
-
- const mockWorkspaceCacheService = {
- getOrRecompute: jest.fn(),
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- FileStorageService,
- {
- provide: FileStorageDriverFactory,
- useValue: mockFileStorageDriverFactory,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(FileEntity),
- useValue: mockFileRepository,
- },
- {
- provide: WorkspaceCacheService,
- useValue: mockWorkspaceCacheService,
- },
- ],
- }).compile();
-
- service = module.get<FileStorageService>(FileStorageService);
- fileStorageDriverFactory = module.get<FileStorageDriverFactory>(
- FileStorageDriverFactory,
- );
-
- jest.clearAllMocks();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('storage operations', () => {
- let mockDriver: any;
-
- beforeEach(() => {
- mockDriver = {
- writeFile: jest.fn(),
- readFile: jest.fn(),
- delete: jest.fn(),
- move: jest.fn(),
- copy: jest.fn(),
- downloadFile: jest.fn(),
- downloadFolder: jest.fn(),
- uploadFolder: jest.fn(),
- checkFileExists: jest.fn(),
- checkFolderExists: jest.fn(),
- getPresignedUrl: jest.fn(),
- };
-
- mockFileStorageDriverFactory.getCurrentDriver.mockReturnValue(mockDriver);
- });
-
- describe('copyLegacy', () => {
- it('should delegate to the current driver', async () => {
- const copyParams = {
- from: { folderPath: 'documents', filename: 'test.txt' },
- to: { folderPath: 'backup', filename: 'test-backup.txt' },
- };
-
- mockDriver.copy.mockResolvedValue(undefined);
-
- await service.copyLegacy(copyParams);
-
- expect(fileStorageDriverFactory.getCurrentDriver).toHaveBeenCalled();
- expect(mockDriver.copy).toHaveBeenCalledWith(copyParams);
- });
-
- it('should handle copy errors', async () => {
- const copyParams = {
- from: { folderPath: 'documents', filename: 'test.txt' },
- to: { folderPath: 'backup', filename: 'test-backup.txt' },
- };
-
- const error = new Error('Copy failed');
-
- mockDriver.copy.mockRejectedValue(error);
-
- await expect(service.copyLegacy(copyParams)).rejects.toThrow(
- 'Copy failed',
- );
- expect(fileStorageDriverFactory.getCurrentDriver).toHaveBeenCalled();
- expect(mockDriver.copy).toHaveBeenCalledWith(copyParams);
- });
- });
-
- describe('getPresignedUrl', () => {
- it('should delegate to the driver and return the URL', async () => {
- mockDriver.getPresignedUrl.mockResolvedValue(
- 'https://s3.example.com/signed',
- );
-
- const result = await service.getPresignedUrl({
- resourcePath: 'file.txt',
- fileFolder: 'workflow' as any,
- applicationUniversalIdentifier: 'app-uid',
- workspaceId: 'ws-id',
- responseContentType: 'image/png',
- responseContentDisposition: 'inline',
- });
-
- expect(result).toBe('https://s3.example.com/signed');
- expect(mockDriver.getPresignedUrl).toHaveBeenCalled();
- });
-
- it('should return null when driver returns null', async () => {
- mockDriver.getPresignedUrl.mockResolvedValue(null);
-
- const result = await service.getPresignedUrl({
- resourcePath: 'file.txt',
- fileFolder: 'workflow' as any,
- applicationUniversalIdentifier: 'app-uid',
- workspaceId: 'ws-id',
- });
-
- expect(result).toBeNull();
- });
- });
- });
-
- describe('path traversal protection', () => {
- let mockDriver: any;
-
- beforeEach(() => {
- mockDriver = {
- writeFile: jest.fn().mockResolvedValue(undefined),
- readFile: jest.fn().mockResolvedValue('stream'),
- delete: jest.fn().mockResolvedValue(undefined),
- copy: jest.fn().mockResolvedValue(undefined),
- downloadFile: jest.fn().mockResolvedValue(undefined),
- checkFileExists: jest.fn().mockResolvedValue(true),
- checkFolderExists: jest.fn().mockResolvedValue(true),
- getPresignedUrl: jest.fn().mockResolvedValue('https://signed.url'),
- };
-
- mockFileStorageDriverFactory.getCurrentDriver.mockReturnValue(mockDriver);
- mockWorkspaceCacheService.getOrRecompute.mockResolvedValue({
- flatApplicationMaps: {
- byId: {
- 'app-id': { id: 'app-id', universalIdentifier: 'app-456' },
- },
- idByUniversalIdentifier: { 'app-456': 'app-id' },
- },
- });
- mockFileRepository.upsertAndReturnOne.mockResolvedValue({
- id: 'file-id',
- path: 'BuiltFrontComponent/file.mjs',
- mimeType: 'application/javascript',
- });
- mockFileRepository.findOneOrFail.mockResolvedValue({
- id: 'file-id',
- path: 'BuiltFrontComponent/file.mjs',
- mimeType: 'application/javascript',
- });
- });
-
- const validResourceIdentifier = {
- workspaceId: 'workspace-123',
- applicationUniversalIdentifier: 'app-456',
- fileFolder: FileFolder.BuiltFrontComponent,
- resourcePath: 'src/components/my-component.mjs',
- };
-
- const validFolderIdentifier = {
- workspaceId: 'workspace-123',
- applicationUniversalIdentifier: 'app-456',
- fileFolder: FileFolder.BuiltFrontComponent,
- };
-
- const expectedValidPath =
- 'workspace-123/app-456/built-front-component/src/components/my-component.mjs';
-
- type RejectedFilePathContext = {
- resourcePath: string;
- };
-
- const REJECTED_FILE_PATHS: EachTestingContext<RejectedFilePathContext>[] = [
- {
- title: 'path traversal with ../',
- context: {
- resourcePath:
- '../../../victim-ws/victim-app/built-front-component/secret.mjs',
- },
- },
- {
- title: 'absolute path',
- context: { resourcePath: '/etc/passwd' },
- },
- {
- title: 'single-level traversal escaping fileFolder',
- context: { resourcePath: '../source/handler.ts' },
- },
- {
- title: 'excess .. segments',
- context: { resourcePath: 'foo/../../../../../../etc/passwd' },
- },
- {
- title: 'exact 3-level traversal to another tenant',
- context: {
- resourcePath:
- '../../../target-ws/target-app/built-front-component/file.js',
- },
- },
- {
- title: 'empty resource path',
- context: { resourcePath: '' },
- },
- ];
-
- type AcceptedFilePathContext = {
- resourcePath: string;
- expectedStoragePath: string;
- };
-
- const ACCEPTED_FILE_PATHS: EachTestingContext<AcceptedFilePathContext>[] = [
- {
- title: 'valid relative path',
- context: {
- resourcePath: 'src/components/my-component.mjs',
- expectedStoragePath: expectedValidPath,
- },
- },
- {
- title: 'deeply nested valid path',
- context: {
- resourcePath: 'a/b/c/d/e/f/deep-file.mjs',
- expectedStoragePath:
- 'workspace-123/app-456/built-front-component/a/b/c/d/e/f/deep-file.mjs',
- },
- },
- {
- title: 'path with dots that are not traversal',
- context: {
- resourcePath: 'v1.0.0/file.name.mjs',
- expectedStoragePath:
- 'workspace-123/app-456/built-front-component/v1.0.0/file.name.mjs',
- },
- },
- {
- title: 'path with hidden directory (dot-prefixed segment)',
- context: {
- resourcePath: '.hidden/file.name.mjs',
- expectedStoragePath:
- 'workspace-123/app-456/built-front-component/.hidden/file.name.mjs',
- },
- },
- ];
-
- describe('readFile', () => {
- it.each(eachTestingContextFilter(REJECTED_FILE_PATHS))(
- 'should reject $title',
- ({ context }) => {
- expect(() =>
- service.readFile({
- ...validResourceIdentifier,
- resourcePath: context.resourcePath,
- }),
- ).toThrow(
- expect.objectContaining({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- }),
- );
-
- expect(mockDriver.readFile).not.toHaveBeenCalled();
- },
- );
-
- it.each(eachTestingContextFilter(ACCEPTED_FILE_PATHS))(
- 'should accept $title',
- async ({ context }) => {
- await service.readFile({
- ...validResourceIdentifier,
- resourcePath: context.resourcePath,
- });
-
- expect(mockDriver.readFile).toHaveBeenCalledWith({
- filePath: context.expectedStoragePath,
- });
- },
- );
- });
-
- describe('checkFileExists', () => {
- it.each(eachTestingContextFilter(REJECTED_FILE_PATHS))(
- 'should reject $title',
- ({ context }) => {
- expect(() =>
- service.checkFileExists({
- ...validResourceIdentifier,
- resourcePath: context.resourcePath,
- }),
- ).toThrow(
- expect.objectContaining({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- }),
- );
-
- expect(mockDriver.checkFileExists).not.toHaveBeenCalled();
- },
- );
- });
-
- describe('getPresignedUrl', () => {
- it.each(eachTestingContextFilter(REJECTED_FILE_PATHS))(
- 'should reject $title',
- async ({ context }) => {
- await expect(
- service.getPresignedUrl({
- ...validResourceIdentifier,
- resourcePath: context.resourcePath,
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- });
-
- expect(mockDriver.getPresignedUrl).not.toHaveBeenCalled();
- },
- );
- });
-
- describe('downloadFile', () => {
- it.each(eachTestingContextFilter(REJECTED_FILE_PATHS))(
- 'should reject $title',
- ({ context }) => {
- expect(() =>
- service.downloadFile({
- ...validResourceIdentifier,
- resourcePath: context.resourcePath,
- localPath: '/tmp/download.js',
- }),
- ).toThrow(
- expect.objectContaining({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- }),
- );
-
- expect(mockDriver.downloadFile).not.toHaveBeenCalled();
- },
- );
- });
-
- describe('writeFile', () => {
- it.each(eachTestingContextFilter(REJECTED_FILE_PATHS))(
- 'should reject $title',
- async ({ context }) => {
- await expect(
- service.writeFile({
- ...validResourceIdentifier,
- resourcePath: context.resourcePath,
- sourceFile: Buffer.from('malicious'),
- settings: { isTemporaryFile: false, toDelete: false },
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- });
-
- expect(mockDriver.writeFile).not.toHaveBeenCalled();
- },
- );
-
- it('should allow valid writes', async () => {
- await service.writeFile({
- ...validResourceIdentifier,
- sourceFile: Buffer.from('valid content'),
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- expect(mockDriver.writeFile).toHaveBeenCalledWith(
- expect.objectContaining({
- filePath: expectedValidPath,
- }),
- );
- });
-
- describe('applicationId resolution', () => {
- it('should resolve applicationId from the workspace cache by universalIdentifier', async () => {
- await service.writeFile({
- ...validResourceIdentifier,
- sourceFile: Buffer.from('valid content'),
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- expect(mockWorkspaceCacheService.getOrRecompute).toHaveBeenCalledWith(
- 'workspace-123',
- ['flatApplicationMaps'],
- );
- expect(mockFileRepository.upsertAndReturnOne).toHaveBeenCalledWith(
- 'workspace-123',
- expect.objectContaining({ applicationId: 'app-id' }),
- ['path', 'workspaceId', 'applicationId'],
- );
- });
-
- it('should throw FILE_NOT_FOUND when the application is not in the cache', async () => {
- mockWorkspaceCacheService.getOrRecompute.mockResolvedValueOnce({
- flatApplicationMaps: { byId: {}, idByUniversalIdentifier: {} },
- });
-
- await expect(
- service.writeFile({
- ...validResourceIdentifier,
- sourceFile: Buffer.from('valid content'),
- settings: { isTemporaryFile: false, toDelete: false },
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.FILE_NOT_FOUND,
- });
-
- expect(mockDriver.writeFile).not.toHaveBeenCalled();
- });
-
- it('should throw FILE_NOT_FOUND when the cached application is soft-deleted', async () => {
- mockWorkspaceCacheService.getOrRecompute.mockResolvedValueOnce({
- flatApplicationMaps: {
- byId: {
- 'app-id': {
- id: 'app-id',
- universalIdentifier: 'app-456',
- deletedAt: new Date(),
- },
- },
- idByUniversalIdentifier: { 'app-456': 'app-id' },
- },
- });
-
- await expect(
- service.writeFile({
- ...validResourceIdentifier,
- sourceFile: Buffer.from('valid content'),
- settings: { isTemporaryFile: false, toDelete: false },
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.FILE_NOT_FOUND,
- });
-
- expect(mockDriver.writeFile).not.toHaveBeenCalled();
- });
-
- it('should use the passed applicationId without consulting the cache', async () => {
- await service.writeFile({
- ...validResourceIdentifier,
- applicationId: 'passed-app-id',
- sourceFile: Buffer.from('valid content'),
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- expect(
- mockWorkspaceCacheService.getOrRecompute,
- ).not.toHaveBeenCalled();
- expect(mockFileRepository.upsertAndReturnOne).toHaveBeenCalledWith(
- 'workspace-123',
- expect.objectContaining({ applicationId: 'passed-app-id' }),
- ['path', 'workspaceId', 'applicationId'],
- );
- });
-
- it('should use the passed applicationId and write through the queryRunner without consulting the cache', async () => {
- const queryRunner = { manager: {} };
-
- mockFileRepository.withManager.mockReturnValue(mockFileRepository);
-
- await service.writeFile({
- ...validResourceIdentifier,
- applicationId: 'passed-app-id',
- sourceFile: Buffer.from('valid content'),
- settings: { isTemporaryFile: false, toDelete: false },
- queryRunner: queryRunner as any,
- });
-
- expect(mockFileRepository.withManager).toHaveBeenCalledWith(
- queryRunner.manager,
- );
- expect(
- mockWorkspaceCacheService.getOrRecompute,
- ).not.toHaveBeenCalled();
- expect(mockFileRepository.upsertAndReturnOne).toHaveBeenCalledWith(
- 'workspace-123',
- expect.objectContaining({ applicationId: 'passed-app-id' }),
- ['path', 'workspaceId', 'applicationId'],
- );
- });
-
- it('should fall back to a queryRunner DB read when the application is not yet in the cache', async () => {
- mockWorkspaceCacheService.getOrRecompute.mockResolvedValueOnce({
- flatApplicationMaps: { byId: {}, idByUniversalIdentifier: {} },
- });
-
- const findOne = jest.fn().mockResolvedValue({ id: 'uncommitted-id' });
- const queryRunner = {
- manager: { getRepository: jest.fn().mockReturnValue({ findOne }) },
- };
-
- mockFileRepository.withManager.mockReturnValue(mockFileRepository);
-
- await service.writeFile({
- ...validResourceIdentifier,
- sourceFile: Buffer.from('valid content'),
- settings: { isTemporaryFile: false, toDelete: false },
- queryRunner: queryRunner as any,
- });
-
- expect(mockWorkspaceCacheService.getOrRecompute).toHaveBeenCalled();
- expect(findOne).toHaveBeenCalledWith({
- where: {
- universalIdentifier: 'app-456',
- workspaceId: 'workspace-123',
- },
- });
- expect(mockFileRepository.upsertAndReturnOne).toHaveBeenCalledWith(
- 'workspace-123',
- expect.objectContaining({ applicationId: 'uncommitted-id' }),
- ['path', 'workspaceId', 'applicationId'],
- );
- });
-
- it('should throw FILE_NOT_FOUND when the application is missing from both the cache and the queryRunner DB read', async () => {
- mockWorkspaceCacheService.getOrRecompute.mockResolvedValueOnce({
- flatApplicationMaps: { byId: {}, idByUniversalIdentifier: {} },
- });
-
- const findOne = jest.fn().mockResolvedValue(null);
- const queryRunner = {
- manager: { getRepository: jest.fn().mockReturnValue({ findOne }) },
- };
-
- mockFileRepository.withManager.mockReturnValue(mockFileRepository);
-
- await expect(
- service.writeFile({
- ...validResourceIdentifier,
- sourceFile: Buffer.from('valid content'),
- settings: { isTemporaryFile: false, toDelete: false },
- queryRunner: queryRunner as any,
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.FILE_NOT_FOUND,
- });
-
- expect(mockDriver.writeFile).not.toHaveBeenCalled();
- });
- });
-
- describe('magic-byte backstop', () => {
- const pngBuffer = Buffer.from([
- 0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 0x00, 0x00, 0x00,
- 0x0d, 0x49, 0x48, 0x44, 0x52,
- ]);
- const textBuffer = Buffer.from('Hello, world!', 'utf-8');
-
- it('should reject buffer whose magic bytes do not match the path extension', async () => {
- await expect(
- service.writeFile({
- workspaceId: 'workspace-123',
- applicationUniversalIdentifier: 'app-456',
- fileFolder: FileFolder.PublicAsset,
- resourcePath: 'assets/fake-image.png',
- sourceFile: textBuffer,
- settings: { isTemporaryFile: false, toDelete: false },
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.INVALID_EXTENSION,
- });
-
- expect(mockDriver.writeFile).not.toHaveBeenCalled();
- });
-
- it('should accept buffer whose magic bytes match the path extension and persist the bytes-derived mime', async () => {
- await service.writeFile({
- workspaceId: 'workspace-123',
- applicationUniversalIdentifier: 'app-456',
- fileFolder: FileFolder.PublicAsset,
- resourcePath: 'assets/photo.png',
- sourceFile: pngBuffer,
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- expect(mockDriver.writeFile).toHaveBeenCalledWith(
- expect.objectContaining({ mimeType: 'image/png' }),
- );
- expect(mockFileRepository.upsertAndReturnOne).toHaveBeenCalledWith(
- 'workspace-123',
- expect.objectContaining({ mimeType: 'image/png' }),
- ['path', 'workspaceId', 'applicationId'],
- );
- });
-
- it('should persist application/typescript for a TypeScript source string (TWENTY_MIME_POLICY)', async () => {
- await service.writeFile({
- workspaceId: 'workspace-123',
- applicationUniversalIdentifier: 'app-456',
- fileFolder: FileFolder.Source,
- resourcePath: 'src/index.tsx',
- sourceFile: 'export const App = () => null;',
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- expect(mockDriver.writeFile).toHaveBeenCalledWith(
- expect.objectContaining({ mimeType: 'application/typescript' }),
- );
- });
-
- it('should persist application/typescript for a TypeScript source buffer (policy beats mrmime collision)', async () => {
- await service.writeFile({
- workspaceId: 'workspace-123',
- applicationUniversalIdentifier: 'app-456',
- fileFolder: FileFolder.Source,
- resourcePath: 'src/handler.ts',
- sourceFile: Buffer.from(
- 'export const handler = () => null;',
- 'utf-8',
- ),
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- expect(mockDriver.writeFile).toHaveBeenCalledWith(
- expect.objectContaining({ mimeType: 'application/typescript' }),
- );
- });
- });
-
- describe('SVG sanitization (centralized invariant)', () => {
- const maliciousSvg =
- '<svg xmlns="http://www.w3.org/2000/svg" onload="alert(1)"><script>alert(2)</script><circle r="10" /></svg>';
-
- it('should strip scripts and event handlers from an SVG string upload', async () => {
- await service.writeFile({
- workspaceId: 'workspace-123',
- applicationUniversalIdentifier: 'app-456',
- fileFolder: FileFolder.PublicAsset,
- resourcePath: 'assets/icon.svg',
- sourceFile: maliciousSvg,
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- const driverCall = mockDriver.writeFile.mock.calls[0][0];
-
- expect(driverCall.mimeType).toBe('image/svg+xml');
- expect(typeof driverCall.sourceFile).toBe('string');
- expect(driverCall.sourceFile).not.toContain('<script>');
- expect(driverCall.sourceFile).not.toContain('onload');
- expect(driverCall.sourceFile).toContain('<circle');
- });
-
- it('should strip scripts and event handlers from an SVG buffer upload', async () => {
- await service.writeFile({
- workspaceId: 'workspace-123',
- applicationUniversalIdentifier: 'app-456',
- fileFolder: FileFolder.PublicAsset,
- resourcePath: 'assets/icon.svg',
- sourceFile: Buffer.from(maliciousSvg, 'utf-8'),
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- const driverCall = mockDriver.writeFile.mock.calls[0][0];
-
- expect(driverCall.mimeType).toBe('image/svg+xml');
- expect(driverCall.sourceFile).not.toContain('<script>');
- expect(driverCall.sourceFile).not.toContain('onload');
- });
-
- it('should leave non-SVG content untouched (sanitize is no-op)', async () => {
- const original = '{"foo": "bar"}';
-
- await service.writeFile({
- workspaceId: 'workspace-123',
- applicationUniversalIdentifier: 'app-456',
- fileFolder: FileFolder.Source,
- resourcePath: 'package.json',
- sourceFile: original,
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- const driverCall = mockDriver.writeFile.mock.calls[0][0];
-
- expect(driverCall.sourceFile).toBe(original);
- });
- });
- });
-
- describe('deleteFile', () => {
- it.each(eachTestingContextFilter(REJECTED_FILE_PATHS))(
- 'should reject $title',
- async ({ context }) => {
- await expect(
- service.deleteFile({
- ...validResourceIdentifier,
- resourcePath: context.resourcePath,
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- });
-
- expect(mockDriver.delete).not.toHaveBeenCalled();
- },
- );
-
- it('should call driver.delete with dirname and basename', async () => {
- await service.deleteFile(validResourceIdentifier);
-
- expect(mockDriver.delete).toHaveBeenCalledWith({
- folderPath:
- 'workspace-123/app-456/built-front-component/src/components',
- filename: 'my-component.mjs',
- });
- });
- });
-
- describe('deleteFolder', () => {
- type RejectedFolderPathContext = {
- folderPath: string;
- };
-
- const REJECTED_FOLDER_PATHS: EachTestingContext<RejectedFolderPathContext>[] =
- [
- {
- title: 'path traversal with ../',
- context: { folderPath: '../../../other-ws/other-app/folder' },
- },
- {
- title: 'absolute path',
- context: { folderPath: '/etc/secret-folder' },
- },
- {
- title: 'empty folder path',
- context: { folderPath: '' },
- },
- {
- title: 'folder path with special characters (spaces)',
- context: { folderPath: 'my folder/data' },
- },
- {
- title: 'folder path with shell metacharacters',
- context: { folderPath: 'folder;rm -rf/' },
- },
- {
- title: 'file path with .mjs extension',
- context: { folderPath: 'src/logic-functions/handler.mjs' },
- },
- {
- title: 'file path with .ts extension',
- context: { folderPath: 'src/components/index.ts' },
- },
- {
- title: 'file path with .json extension',
- context: { folderPath: 'config/settings.json' },
- },
- {
- title: 'dotted version string (extname detects .0)',
- context: { folderPath: 'v1.0.0' },
- },
- {
- title: 'numeric-only extension (.7z)',
- context: { folderPath: 'archive.7z' },
- },
- ];
-
- type AcceptedFolderPathContext = {
- folderPath: string;
- expectedStoragePath: string;
- };
-
- const ACCEPTED_FOLDER_PATHS: EachTestingContext<AcceptedFolderPathContext>[] =
- [
- {
- title: 'UUID folder path',
- context: {
- folderPath: '8b2df3cc-23ad-4e1b-87fd-f880d4cefd58',
- expectedStoragePath:
- 'workspace-123/app-456/built-front-component/8b2df3cc-23ad-4e1b-87fd-f880d4cefd58/',
- },
- },
- {
- title: 'simple folder name',
- context: {
- folderPath: 'my-folder',
- expectedStoragePath:
- 'workspace-123/app-456/built-front-component/my-folder/',
- },
- },
- {
- title: 'nested folder path with numeric ranges',
- context: {
- folderPath: '0000-0999/tmp200/toto',
- expectedStoragePath:
- 'workspace-123/app-456/built-front-component/0000-0999/tmp200/toto/',
- },
- },
- ];
-
- it.each(eachTestingContextFilter(REJECTED_FOLDER_PATHS))(
- 'should reject $title',
- async ({ context }) => {
- await expect(
- service.deleteFolder({
- ...validFolderIdentifier,
- folderPath: context.folderPath,
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- });
-
- expect(mockDriver.delete).not.toHaveBeenCalled();
- },
- );
-
- it.each(eachTestingContextFilter(ACCEPTED_FOLDER_PATHS))(
- 'should accept $title',
- async ({ context }) => {
- await service.deleteFolder({
- ...validFolderIdentifier,
- folderPath: context.folderPath,
- });
-
- expect(mockDriver.delete).toHaveBeenCalledWith({
- folderPath: context.expectedStoragePath,
- });
- },
- );
- });
-
- describe('deleteByFileId', () => {
- it('should delegate to deleteFile with the correct resource path', async () => {
- mockFileRepository.findOneOrFail.mockResolvedValue({
- id: 'file-id',
- path: 'built-front-component/src/components/my-component.mjs',
- applicationId: 'app-id',
- workspaceId: 'workspace-123',
- });
-
- await service.deleteByFileId({
- fileId: 'file-id',
- workspaceId: 'workspace-123',
- fileFolder: FileFolder.BuiltFrontComponent,
- });
-
- expect(mockDriver.delete).toHaveBeenCalledWith({
- folderPath:
- 'workspace-123/app-456/built-front-component/src/components',
- filename: 'my-component.mjs',
- });
-
- expect(mockFileRepository.delete).toHaveBeenCalledWith(
- 'workspace-123',
- {
- path: 'built-front-component/src/components/my-component.mjs',
- applicationId: 'app-id',
- },
- );
- });
- });
-
- describe('copy', () => {
- it('should reject path traversal in source', async () => {
- await expect(
- service.copy({
- from: {
- ...validResourceIdentifier,
- resourcePath: '../../../other-ws/secret.mjs',
- },
- to: validResourceIdentifier,
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- });
-
- expect(mockDriver.copy).not.toHaveBeenCalled();
- });
-
- it('should reject path traversal in destination', async () => {
- mockDriver.checkFileExists.mockResolvedValue(true);
-
- await expect(
- service.copy({
- from: validResourceIdentifier,
- to: {
- ...validResourceIdentifier,
- resourcePath: '../../../other-ws/overwrite.mjs',
- },
- }),
- ).rejects.toMatchObject({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- });
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/file-storage/services/__tests__/server-file-storage.service.spec.ts b/packages/twenty-server/src/engine/core-modules/file-storage/services/__tests__/server-file-storage.service.spec.ts
deleted file mode 100644
index ac36f751135..00000000000
--- a/packages/twenty-server/src/engine/core-modules/file-storage/services/__tests__/server-file-storage.service.spec.ts
+++ /dev/null
@@ -1,414 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { Readable } from 'stream';
-
-import { ServerFileFolder } from 'twenty-shared/types';
-import { IsNull } from 'typeorm';
-
-import { FileStorageDriverFactory } from 'src/engine/core-modules/file-storage/file-storage-driver.factory';
-import { ServerFileStorageService } from 'src/engine/core-modules/file-storage/services/server-file-storage.service';
-import {
- FileStorageException,
- FileStorageExceptionCode,
-} from 'src/engine/core-modules/file-storage/interfaces/file-storage-exception';
-import { FileEntity } from 'src/engine/core-modules/file/entities/file.entity';
-
-describe('ServerFileStorageService', () => {
- let service: ServerFileStorageService;
-
- const mockFileStorageDriverFactory = {
- getCurrentDriver: jest.fn(),
- };
-
- const mockServerFileRepository = {
- upsert: jest.fn(),
- findOneBy: jest.fn(),
- findOneByOrFail: jest.fn(),
- findBy: jest.fn(),
- delete: jest.fn(),
- };
-
- const mockDriver = {
- writeFile: jest.fn(),
- readFile: jest.fn(),
- delete: jest.fn(),
- checkFileExists: jest.fn(),
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ServerFileStorageService,
- {
- provide: FileStorageDriverFactory,
- useValue: mockFileStorageDriverFactory,
- },
- {
- provide: getRepositoryToken(FileEntity),
- useValue: mockServerFileRepository,
- },
- ],
- }).compile();
-
- service = module.get<ServerFileStorageService>(ServerFileStorageService);
-
- jest.clearAllMocks();
-
- mockFileStorageDriverFactory.getCurrentDriver.mockReturnValue(mockDriver);
- });
-
- describe.each([
- [
- 'readServerFile',
- (resourcePath: string) =>
- service.readServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath,
- }),
- ],
- [
- 'checkServerFileExists',
- (resourcePath: string) =>
- service.checkServerFileExists({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath,
- }),
- ],
- [
- 'deleteServerFile',
- (resourcePath: string) =>
- service.deleteServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath,
- }),
- ],
- ] as const)('%s traversal protection', (_methodName, invoke) => {
- it.each(['../workspace-id/stolen.json', 'a/../../escape.json'])(
- 'should reject traversal resource path %s without touching storage',
- async (resourcePath) => {
- await expect(
- (async () => {
- await invoke(resourcePath);
- })(),
- ).rejects.toThrow(
- expect.objectContaining({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- }),
- );
-
- expect(mockDriver.readFile).not.toHaveBeenCalled();
- expect(mockDriver.checkFileExists).not.toHaveBeenCalled();
- expect(mockDriver.delete).not.toHaveBeenCalled();
- },
- );
- });
-
- describe('writeServerFile', () => {
- it('should write bytes with the server prefix and upsert the row on path conflict', async () => {
- const serverFile = {
- id: 'server-file-id',
- path: 'application-registration/registration-id/manifests/manifest.json',
- } as FileEntity;
-
- mockServerFileRepository.findOneByOrFail.mockResolvedValue(serverFile);
-
- const result = await service.writeServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'manifests/manifest.json',
- contents: '{"name":"my-app"}',
- mimeType: 'application/json',
- });
-
- expect(mockDriver.writeFile).toHaveBeenCalledWith({
- filePath:
- 'server/application-registration/registration-id/manifests/manifest.json',
- mimeType: 'application/json',
- sourceFile: '{"name":"my-app"}',
- });
- expect(mockServerFileRepository.upsert).toHaveBeenCalledWith(
- {
- path: 'application-registration/registration-id/manifests/manifest.json',
- workspaceId: null,
- size: Buffer.byteLength('{"name":"my-app"}'),
- mimeType: 'application/json',
- applicationRegistrationId: 'registration-id',
- },
- {
- conflictPaths: ['applicationRegistrationId', 'path'],
- },
- );
- expect(mockServerFileRepository.findOneByOrFail).toHaveBeenCalledWith({
- applicationRegistrationId: 'registration-id',
- path: 'application-registration/registration-id/manifests/manifest.json',
- workspaceId: IsNull(),
- });
- expect(result).toEqual(serverFile);
- });
-
- it('should reject a traversal resource path without touching storage', async () => {
- await expect(
- service.writeServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: '../workspace-id/stolen.json',
- contents: '{}',
- mimeType: 'application/json',
- }),
- ).rejects.toThrow(
- expect.objectContaining({
- code: FileStorageExceptionCode.ACCESS_DENIED,
- }),
- );
-
- expect(mockDriver.writeFile).not.toHaveBeenCalled();
- expect(mockServerFileRepository.upsert).not.toHaveBeenCalled();
- });
-
- it('should propagate driver write failures without upserting the row', async () => {
- mockDriver.writeFile.mockRejectedValueOnce(new Error('Write failed'));
-
- await expect(
- service.writeServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'manifest.json',
- contents: '{}',
- mimeType: 'application/json',
- }),
- ).rejects.toThrow('Write failed');
-
- expect(mockServerFileRepository.upsert).not.toHaveBeenCalled();
- });
- });
-
- describe('readServerFile', () => {
- it('should read from the server-prefixed storage path', async () => {
- const stream = Readable.from(['{}']);
-
- mockServerFileRepository.findOneBy.mockResolvedValue({
- id: 'server-file-id',
- path: 'application-registration/registration-id/manifests/manifest.json',
- mimeType: 'application/json',
- } as FileEntity);
- mockDriver.readFile.mockResolvedValue(stream);
-
- const result = await service.readServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'manifests/manifest.json',
- });
-
- expect(mockServerFileRepository.findOneBy).toHaveBeenCalledWith({
- applicationRegistrationId: 'registration-id',
- path: 'application-registration/registration-id/manifests/manifest.json',
- workspaceId: IsNull(),
- });
- expect(mockDriver.readFile).toHaveBeenCalledWith({
- filePath:
- 'server/application-registration/registration-id/manifests/manifest.json',
- });
- expect(result).toEqual({ stream, mimeType: 'application/json' });
- });
-
- it('should propagate the missing-file exception from the driver', async () => {
- mockServerFileRepository.findOneBy.mockResolvedValue({
- id: 'server-file-id',
- path: 'application-registration/registration-id/missing.json',
- } as FileEntity);
- mockDriver.readFile.mockRejectedValueOnce(
- new FileStorageException(
- 'File not found',
- FileStorageExceptionCode.FILE_NOT_FOUND,
- ),
- );
-
- await expect(
- service.readServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'missing.json',
- }),
- ).rejects.toThrow(
- expect.objectContaining({
- code: FileStorageExceptionCode.FILE_NOT_FOUND,
- }),
- );
- });
-
- it('should throw FILE_NOT_FOUND without reading bytes when the row is missing', async () => {
- mockServerFileRepository.findOneBy.mockResolvedValue(null);
-
- await expect(
- service.readServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'deleted.json',
- }),
- ).rejects.toThrow(
- expect.objectContaining({
- code: FileStorageExceptionCode.FILE_NOT_FOUND,
- }),
- );
-
- expect(mockDriver.readFile).not.toHaveBeenCalled();
- });
- });
-
- describe('findServerFile', () => {
- it('should return the row matching the registration and path', async () => {
- const serverFile = {
- id: 'server-file-id',
- path: 'application-registration/registration-id/manifest.json',
- } as FileEntity;
-
- mockServerFileRepository.findOneBy.mockResolvedValue(serverFile);
-
- const result = await service.findServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'manifest.json',
- });
-
- expect(mockServerFileRepository.findOneBy).toHaveBeenCalledWith({
- applicationRegistrationId: 'registration-id',
- path: 'application-registration/registration-id/manifest.json',
- workspaceId: IsNull(),
- });
- expect(result).toBe(serverFile);
- });
-
- it('should return null when no row matches', async () => {
- mockServerFileRepository.findOneBy.mockResolvedValue(null);
-
- const result = await service.findServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'missing.json',
- });
-
- expect(result).toBeNull();
- });
- });
-
- describe('checkServerFileExists', () => {
- it('should check existence on the server-prefixed storage path', async () => {
- mockDriver.checkFileExists.mockResolvedValue(true);
-
- const result = await service.checkServerFileExists({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'manifest.json',
- });
-
- expect(mockDriver.checkFileExists).toHaveBeenCalledWith({
- filePath:
- 'server/application-registration/registration-id/manifest.json',
- });
- expect(result).toBe(true);
- });
- });
-
- describe('deleteServerFile', () => {
- it('should delete the bytes and the row', async () => {
- await service.deleteServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'manifests/manifest.json',
- });
-
- expect(mockDriver.delete).toHaveBeenCalledWith({
- folderPath: 'server/application-registration/registration-id/manifests',
- filename: 'manifest.json',
- });
- expect(mockServerFileRepository.delete).toHaveBeenCalledWith({
- path: 'application-registration/registration-id/manifests/manifest.json',
- workspaceId: IsNull(),
- });
- });
-
- it('should still delete the row when the bytes deletion fails', async () => {
- mockDriver.delete.mockRejectedValueOnce(new Error('Delete failed'));
-
- await service.deleteServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'manifest.json',
- });
-
- expect(mockServerFileRepository.delete).toHaveBeenCalledWith({
- path: 'application-registration/registration-id/manifest.json',
- workspaceId: IsNull(),
- });
- });
-
- it('should propagate row deletion failures', async () => {
- mockServerFileRepository.delete.mockRejectedValueOnce(
- new Error('Row deletion failed'),
- );
-
- await expect(
- service.deleteServerFile({
- fileFolder: ServerFileFolder.ApplicationRegistration,
- applicationRegistrationId: 'registration-id',
- resourcePath: 'manifest.json',
- }),
- ).rejects.toThrow('Row deletion failed');
- });
- });
-
- describe('deleteByApplicationRegistrationId', () => {
- it('should delete the bytes of every file then the rows', async () => {
- mockServerFileRepository.findBy.mockResolvedValue([
- {
- id: 'file-1',
- path: 'application-registration/registration-id/manifest.json',
- },
- {
- id: 'file-2',
- path: 'application-registration/registration-id/nested/settings.json',
- },
- ] as FileEntity[]);
-
- await service.deleteByApplicationRegistrationId('registration-id');
-
- expect(mockServerFileRepository.findBy).toHaveBeenCalledWith({
- applicationRegistrationId: 'registration-id',
- workspaceId: IsNull(),
- });
- expect(mockDriver.delete).toHaveBeenCalledWith({
- folderPath: 'server/application-registration/registration-id',
- filename: 'manifest.json',
- });
- expect(mockDriver.delete).toHaveBeenCalledWith({
- folderPath: 'server/application-registration/registration-id/nested',
- filename: 'settings.json',
- });
- expect(mockServerFileRepository.delete).toHaveBeenCalledWith({
- applicationRegistrationId: 'registration-id',
- workspaceId: IsNull(),
- });
- });
-
- it('should still delete the rows when a bytes deletion fails', async () => {
- mockServerFileRepository.findBy.mockResolvedValue([
- {
- id: 'file-1',
- path: 'application-registration/registration-id/manifest.json',
- },
- ] as FileEntity[]);
- mockDriver.delete.mockRejectedValueOnce(new Error('Delete failed'));
-
- await service.deleteByApplicationRegistrationId('registration-id');
-
- expect(mockServerFileRepository.delete).toHaveBeenCalledWith({
- applicationRegistrationId: 'registration-id',
- workspaceId: IsNull(),
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/file/file-upload/services/__tests__/pending-file-cleanup.service.spec.ts b/packages/twenty-server/src/engine/core-modules/file/file-upload/services/__tests__/pending-file-cleanup.service.spec.ts
deleted file mode 100644
index aad38f4e7ad..00000000000
--- a/packages/twenty-server/src/engine/core-modules/file/file-upload/services/__tests__/pending-file-cleanup.service.spec.ts
+++ /dev/null
@@ -1,179 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { FileFolder } from 'twenty-shared/types';
-
-import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
-import { FileStorageService } from 'src/engine/core-modules/file-storage/services/file-storage.service';
-import { FileEntity } from 'src/engine/core-modules/file/entities/file.entity';
-import {
- PENDING_FILE_CLEANUP_BATCH_SIZE,
- PENDING_FILE_MAX_AGE_MS,
-} from 'src/engine/core-modules/file/file-upload/crons/constants/pending-file-cleanup.constants';
-import { PendingFileCleanupService } from 'src/engine/core-modules/file/file-upload/services/pending-file-cleanup.service';
-import { FILE_STATUS } from 'src/engine/core-modules/file/types/file-status.types';
-
-describe('PendingFileCleanupService', () => {
- let service: PendingFileCleanupService;
-
- const fileRepository = {
- find: jest.fn(),
- delete: jest.fn(),
- };
-
- const applicationRepository = {
- findOne: jest.fn(),
- };
-
- const fileStorageService = {
- deleteFile: jest.fn(),
- };
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- applicationRepository.findOne.mockResolvedValue({
- id: 'application-id',
- universalIdentifier: 'application-uid',
- });
- fileRepository.delete.mockResolvedValue({ affected: 1 });
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- PendingFileCleanupService,
- {
- provide: getRepositoryToken(FileEntity),
- useValue: fileRepository,
- },
- {
- provide: getRepositoryToken(ApplicationEntity),
- useValue: applicationRepository,
- },
- {
- provide: FileStorageService,
- useValue: fileStorageService,
- },
- ],
- }).compile();
-
- service = module.get<PendingFileCleanupService>(PendingFileCleanupService);
- });
-
- it('should query for stale pending files with the batch size cap', async () => {
- fileRepository.find.mockResolvedValue([]);
-
- const before = Date.now() - PENDING_FILE_MAX_AGE_MS;
-
- await service.cleanupStalePendingFiles();
-
- const after = Date.now() - PENDING_FILE_MAX_AGE_MS;
-
- expect(fileRepository.find).toHaveBeenCalledTimes(1);
-
- const where = fileRepository.find.mock.calls[0][0].where;
-
- expect(where.status).toBe(FILE_STATUS.PENDING);
- // LessThan wraps the threshold in _value
- const threshold = where.createdAt._value.getTime();
-
- expect(threshold).toBeGreaterThanOrEqual(before);
- expect(threshold).toBeLessThanOrEqual(after);
- expect(fileRepository.find.mock.calls[0][0].take).toBe(
- PENDING_FILE_CLEANUP_BATCH_SIZE,
- );
- });
-
- it('should delete each stale file guarded by status and return the deleted count', async () => {
- fileRepository.find.mockResolvedValue([
- {
- id: 'file-1',
- workspaceId: 'workspace-1',
- applicationId: 'application-id',
- path: `${FileFolder.FilesField}/some/file-1.png`,
- },
- {
- id: 'file-2',
- workspaceId: 'workspace-2',
- applicationId: 'application-id',
- path: `${FileFolder.Workflow}/file-2.pdf`,
- },
- ]);
-
- const deletedCount = await service.cleanupStalePendingFiles();
-
- expect(deletedCount).toBe(2);
- expect(fileRepository.delete).toHaveBeenNthCalledWith(1, {
- id: 'file-1',
- status: FILE_STATUS.PENDING,
- });
- expect(fileRepository.delete).toHaveBeenNthCalledWith(2, {
- id: 'file-2',
- status: FILE_STATUS.PENDING,
- });
- expect(fileStorageService.deleteFile).toHaveBeenNthCalledWith(1, {
- workspaceId: 'workspace-1',
- applicationUniversalIdentifier: 'application-uid',
- fileFolder: FileFolder.FilesField,
- resourcePath: 'some/file-1.png',
- });
- expect(fileStorageService.deleteFile).toHaveBeenNthCalledWith(2, {
- workspaceId: 'workspace-2',
- applicationUniversalIdentifier: 'application-uid',
- fileFolder: FileFolder.Workflow,
- resourcePath: 'file-2.pdf',
- });
- });
-
- it('should skip storage deletion when the file was confirmed concurrently', async () => {
- fileRepository.find.mockResolvedValue([
- {
- id: 'file-1',
- workspaceId: 'workspace-1',
- applicationId: 'application-id',
- path: `${FileFolder.FilesField}/file-1.png`,
- },
- ]);
- // A racing completeFileUpload promoted the row, so the guarded delete is a no-op.
- fileRepository.delete.mockResolvedValueOnce({ affected: 0 });
-
- const deletedCount = await service.cleanupStalePendingFiles();
-
- expect(deletedCount).toBe(0);
- expect(fileStorageService.deleteFile).not.toHaveBeenCalled();
- });
-
- it('should keep cleaning remaining files when one deletion fails', async () => {
- fileRepository.find.mockResolvedValue([
- {
- id: 'file-1',
- workspaceId: 'workspace-1',
- applicationId: 'application-id',
- path: `${FileFolder.FilesField}/file-1.png`,
- },
- {
- id: 'file-2',
- workspaceId: 'workspace-2',
- applicationId: 'application-id',
- path: `${FileFolder.FilesField}/file-2.png`,
- },
- ]);
- fileStorageService.deleteFile
- .mockRejectedValueOnce(new Error('storage exploded'))
- .mockResolvedValueOnce(undefined);
-
- const deletedCount = await service.cleanupStalePendingFiles();
-
- expect(deletedCount).toBe(1);
- expect(fileStorageService.deleteFile).toHaveBeenCalledTimes(2);
- });
-
- it('should not delete anything when there are no stale files', async () => {
- fileRepository.find.mockResolvedValue([]);
-
- const deletedCount = await service.cleanupStalePendingFiles();
-
- expect(deletedCount).toBe(0);
- expect(fileRepository.delete).not.toHaveBeenCalled();
- expect(fileStorageService.deleteFile).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/file/file-upload/services/file-upload.service.spec.ts b/packages/twenty-server/src/engine/core-modules/file/file-upload/services/file-upload.service.spec.ts
deleted file mode 100644
index 5741ffb88ba..00000000000
--- a/packages/twenty-server/src/engine/core-modules/file/file-upload/services/file-upload.service.spec.ts
+++ /dev/null
@@ -1,438 +0,0 @@
-import { Readable } from 'stream';
-
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { FileFolder } from 'twenty-shared/types';
-
-import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { FileStorageService } from 'src/engine/core-modules/file-storage/services/file-storage.service';
-import { FileEntity } from 'src/engine/core-modules/file/entities/file.entity';
-import {
- FileUploadException,
- FileUploadExceptionCode,
-} from 'src/engine/core-modules/file/file-upload/file-upload.exception';
-import { FileUploadService } from 'src/engine/core-modules/file/file-upload/services/file-upload.service';
-import { FileUrlService } from 'src/engine/core-modules/file/file-url/file-url.service';
-import { FILE_STATUS } from 'src/engine/core-modules/file/types/file-status.types';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-
-jest.mock('uuid', () => ({
- ...jest.requireActual('uuid'),
- v4: jest.fn(() => 'mocked-file-id'),
-}));
-
-describe('FileUploadService', () => {
- let service: FileUploadService;
-
- const fileStorageService = {
- createPendingFile: jest.fn(),
- getPresignedUploadUrl: jest.fn(),
- getFileMetadata: jest.fn(),
- writeFileStream: jest.fn(),
- readFile: jest.fn(),
- };
-
- const fileUrlService = {
- signFileByIdUrl: jest.fn().mockResolvedValue('https://signed-url'),
- };
-
- const jwtWrapperService = {
- signAsyncOrThrow: jest.fn().mockResolvedValue('upload-token'),
- };
-
- const twentyConfigService = {
- get: jest.fn((key: string) => {
- if (key === 'STORAGE_S3_PRESIGNED_URL_EXPIRES_IN') {
- return 900;
- }
- if (key === 'SERVER_URL') {
- return 'https://server.tld';
- }
-
- return undefined;
- }),
- };
-
- const applicationService = {
- findWorkspaceTwentyStandardAndCustomApplicationOrThrow: jest
- .fn()
- .mockResolvedValue({
- workspaceCustomFlatApplication: {
- universalIdentifier: 'custom-app-uid',
- },
- }),
- };
-
- const applicationRepository = {
- findOneOrFail: jest.fn().mockResolvedValue({
- id: 'application-id',
- universalIdentifier: 'application-uid',
- }),
- };
-
- const fieldMetadataRepository = {
- findOneOrFail: jest.fn().mockResolvedValue({
- applicationId: 'application-id',
- universalIdentifier: 'field-metadata-uid',
- }),
- };
-
- const fileRepository = {
- findOne: jest.fn(),
- update: jest.fn(),
- };
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- FileUploadService,
- { provide: FileStorageService, useValue: fileStorageService },
- { provide: FileUrlService, useValue: fileUrlService },
- { provide: JwtWrapperService, useValue: jwtWrapperService },
- { provide: TwentyConfigService, useValue: twentyConfigService },
- { provide: ApplicationService, useValue: applicationService },
- {
- provide: getRepositoryToken(ApplicationEntity),
- useValue: applicationRepository,
- },
- {
- provide: getRepositoryToken(FieldMetadataEntity),
- useValue: fieldMetadataRepository,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(FileEntity),
- useValue: fileRepository,
- },
- ],
- }).compile();
-
- service = module.get<FileUploadService>(FileUploadService);
- });
-
- describe('createFileUpload', () => {
- it('should reject file folders without direct upload support', async () => {
- await expect(
- service.createFileUpload({
- workspaceId: 'workspace-id',
- filename: 'document.pdf',
- size: 1024,
- fileFolder: FileFolder.CorePicture,
- }),
- ).rejects.toThrow(FileUploadException);
- });
-
- it('should reject an invalid declared size', async () => {
- await expect(
- service.createFileUpload({
- workspaceId: 'workspace-id',
- filename: 'document.pdf',
- size: 0,
- fileFolder: FileFolder.FilesField,
- fieldMetadataId: 'field-metadata-id',
- }),
- ).rejects.toThrow(FileUploadException);
- });
-
- it('should create a PENDING file and return the presigned url when storage supports it', async () => {
- fileStorageService.getPresignedUploadUrl.mockResolvedValueOnce(
- 'https://bucket/presigned-put',
- );
-
- const result = await service.createFileUpload({
- workspaceId: 'workspace-id',
- filename: 'document.pdf',
- size: 1024,
- fileFolder: FileFolder.FilesField,
- fieldMetadataId: 'field-metadata-id',
- });
-
- expect(fileStorageService.createPendingFile).toHaveBeenCalledWith(
- expect.objectContaining({
- fileId: 'mocked-file-id',
- size: 1024,
- mimeType: 'application/octet-stream',
- resourcePath: 'field-metadata-uid/mocked-file-id.pdf',
- settings: { isTemporaryFile: true, toDelete: false },
- }),
- );
- expect(result.uploadUrl).toBe('https://bucket/presigned-put');
- expect(result.contentType).toBe('application/octet-stream');
- expect(result.fileId).toBe('mocked-file-id');
- });
-
- it('should fall back to the server streaming endpoint when presign is unavailable', async () => {
- fileStorageService.getPresignedUploadUrl.mockResolvedValueOnce(null);
-
- const result = await service.createFileUpload({
- workspaceId: 'workspace-id',
- filename: 'archive.zip',
- size: 2048,
- fileFolder: FileFolder.Workflow,
- });
-
- expect(jwtWrapperService.signAsyncOrThrow).toHaveBeenCalledWith(
- expect.objectContaining({
- workspaceId: 'workspace-id',
- fileId: 'mocked-file-id',
- }),
- { expiresIn: 900 },
- );
- expect(result.uploadUrl).toBe(
- 'https://server.tld/file-upload/mocked-file-id?token=upload-token',
- );
- expect(result.contentType).toBe('application/octet-stream');
- });
-
- it.each([
- FileFolder.EmailAttachment,
- FileFolder.EmailImage,
- FileFolder.AgentChat,
- ])('should support direct upload for the %s folder', async (fileFolder) => {
- fileStorageService.getPresignedUploadUrl.mockResolvedValueOnce(
- 'https://bucket/presigned-put',
- );
-
- const result = await service.createFileUpload({
- workspaceId: 'workspace-id',
- filename: 'document.pdf',
- size: 1024,
- fileFolder,
- });
-
- expect(fileStorageService.createPendingFile).toHaveBeenCalledWith(
- expect.objectContaining({
- fileFolder,
- resourcePath: 'mocked-file-id.pdf',
- }),
- );
- expect(result.uploadUrl).toBe('https://bucket/presigned-put');
- });
- });
-
- describe('completeFileUpload', () => {
- const pendingFile = {
- id: 'file-id',
- path: 'files-field/field-metadata-uid/file-id.pdf',
- size: 1024,
- applicationId: 'application-id',
- mimeType: 'application/octet-stream',
- status: FILE_STATUS.PENDING,
- settings: { isTemporaryFile: true, toDelete: false },
- createdAt: new Date(),
- };
-
- const PDF_BYTES = Buffer.from('%PDF-1.4\n%\xE2\xE3\xCF\xD3\n', 'latin1');
- const PNG_BYTES = Buffer.from(
- 'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg==',
- 'base64',
- );
-
- it('should throw when the file record does not exist', async () => {
- fileRepository.findOne.mockResolvedValueOnce(null);
-
- await expect(
- service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- }),
- ).rejects.toThrow(FileUploadException);
- });
-
- it('should throw when the bytes are not in storage yet', async () => {
- fileRepository.findOne.mockResolvedValueOnce(pendingFile);
- fileStorageService.getFileMetadata.mockResolvedValueOnce(null);
-
- await expect(
- service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- }),
- ).rejects.toMatchObject({
- code: FileUploadExceptionCode.FILE_NOT_UPLOADED,
- });
- expect(fileRepository.update).not.toHaveBeenCalled();
- });
-
- it('should throw when the stored size does not match the declared size', async () => {
- fileRepository.findOne.mockResolvedValueOnce(pendingFile);
- fileStorageService.getFileMetadata.mockResolvedValueOnce({ size: 999 });
-
- await expect(
- service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- }),
- ).rejects.toMatchObject({
- code: FileUploadExceptionCode.FILE_SIZE_MISMATCH,
- });
- expect(fileRepository.update).not.toHaveBeenCalled();
- });
-
- it('should sniff the content, set the detected mime and flip to UPLOADED', async () => {
- fileRepository.findOne.mockResolvedValueOnce(pendingFile);
- fileStorageService.getFileMetadata.mockResolvedValueOnce({ size: 1024 });
- fileStorageService.readFile.mockResolvedValueOnce(
- Readable.from(PDF_BYTES),
- );
-
- const result = await service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- });
-
- expect(fileStorageService.readFile).toHaveBeenCalledWith(
- expect.objectContaining({
- fileFolder: FileFolder.FilesField,
- resourcePath: 'field-metadata-uid/file-id.pdf',
- workspaceId: 'workspace-id',
- }),
- );
- expect(fileRepository.update).toHaveBeenCalledWith(
- 'workspace-id',
- { id: 'file-id' },
- { status: FILE_STATUS.UPLOADED, mimeType: 'application/pdf' },
- );
- expect(result.url).toBe('https://signed-url');
- });
-
- it('should override a spoofed extension with the detected content type', async () => {
- fileRepository.findOne.mockResolvedValueOnce({
- ...pendingFile,
- path: 'files-field/field-metadata-uid/file-id.pdf',
- });
- fileStorageService.getFileMetadata.mockResolvedValueOnce({ size: 1024 });
- fileStorageService.readFile.mockResolvedValueOnce(
- Readable.from(PNG_BYTES),
- );
-
- await service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- });
-
- expect(fileRepository.update).toHaveBeenCalledWith(
- 'workspace-id',
- { id: 'file-id' },
- { status: FILE_STATUS.UPLOADED, mimeType: 'image/png' },
- );
- });
-
- it('should reject when the content cannot be matched to the declared extension', async () => {
- fileRepository.findOne.mockResolvedValueOnce({
- ...pendingFile,
- path: 'files-field/field-metadata-uid/file-id.png',
- });
- fileStorageService.getFileMetadata.mockResolvedValueOnce({ size: 1024 });
- fileStorageService.readFile.mockResolvedValueOnce(
- Readable.from(Buffer.from('not-an-image-just-text')),
- );
-
- await expect(
- service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- }),
- ).rejects.toThrow();
- expect(fileRepository.update).not.toHaveBeenCalled();
- });
-
- it('should reject non-image content from the email image folder', async () => {
- fileRepository.findOne.mockResolvedValueOnce({
- ...pendingFile,
- path: `${FileFolder.EmailImage}/file-id.pdf`,
- });
- fileStorageService.getFileMetadata.mockResolvedValueOnce({ size: 1024 });
- fileStorageService.readFile.mockResolvedValueOnce(
- Readable.from(PDF_BYTES),
- );
-
- await expect(
- service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- }),
- ).rejects.toMatchObject({
- code: FileUploadExceptionCode.BAD_REQUEST,
- });
- expect(fileRepository.update).not.toHaveBeenCalled();
- });
-
- it('should accept image content in the email image folder', async () => {
- fileRepository.findOne.mockResolvedValueOnce({
- ...pendingFile,
- path: `${FileFolder.EmailImage}/file-id.png`,
- });
- fileStorageService.getFileMetadata.mockResolvedValueOnce({ size: 1024 });
- fileStorageService.readFile.mockResolvedValueOnce(
- Readable.from(PNG_BYTES),
- );
-
- await service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- });
-
- expect(fileRepository.update).toHaveBeenCalledWith(
- 'workspace-id',
- { id: 'file-id' },
- { status: FILE_STATUS.UPLOADED, mimeType: 'image/png' },
- );
- });
-
- it('should be idempotent when the file is already UPLOADED', async () => {
- fileRepository.findOne.mockResolvedValueOnce({
- ...pendingFile,
- status: FILE_STATUS.UPLOADED,
- });
-
- const result = await service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- });
-
- expect(fileStorageService.getFileMetadata).not.toHaveBeenCalled();
- expect(fileRepository.update).not.toHaveBeenCalled();
- expect(result.url).toBe('https://signed-url');
- });
-
- it('should refuse confirming files that already left the upload flow', async () => {
- fileRepository.findOne.mockResolvedValueOnce({
- ...pendingFile,
- status: FILE_STATUS.UPLOADED,
- settings: { isTemporaryFile: false, toDelete: false },
- });
-
- await expect(
- service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- }),
- ).rejects.toMatchObject({
- code: FileUploadExceptionCode.BAD_REQUEST,
- });
- });
-
- it('should refuse files outside direct-upload folders', async () => {
- fileRepository.findOne.mockResolvedValueOnce({
- ...pendingFile,
- path: 'core-picture/file-id.png',
- });
-
- await expect(
- service.completeFileUpload({
- workspaceId: 'workspace-id',
- fileId: 'file-id',
- }),
- ).rejects.toMatchObject({
- code: FileUploadExceptionCode.FILE_NOT_FOUND,
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/file/services/file.service.spec.ts b/packages/twenty-server/src/engine/core-modules/file/services/file.service.spec.ts
deleted file mode 100644
index 08d66c1252e..00000000000
--- a/packages/twenty-server/src/engine/core-modules/file/services/file.service.spec.ts
+++ /dev/null
@@ -1,52 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
-import { FileStorageService } from 'src/engine/core-modules/file-storage/services/file-storage.service';
-import { FileEntity } from 'src/engine/core-modules/file/entities/file.entity';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { FileService } from './file.service';
-
-jest.mock('uuid', () => ({
- v4: jest.fn(() => 'mocked-uuid'),
-}));
-
-describe('FileService', () => {
- let service: FileService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- FileService,
- {
- provide: TwentyConfigService,
- useValue: {},
- },
- {
- provide: JwtWrapperService,
- useValue: {},
- },
- {
- provide: FileStorageService,
- useValue: {},
- },
- {
- provide: getWorkspaceScopedRepositoryToken(FileEntity),
- useValue: {},
- },
- {
- provide: getRepositoryToken(ApplicationEntity),
- useValue: {},
- },
- ],
- }).compile();
-
- service = module.get<FileService>(FileService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/imap-smtp-caldav-connection/services/__tests__/imap-smtp-caldav-connection.service.spec.ts b/packages/twenty-server/src/engine/core-modules/imap-smtp-caldav-connection/services/__tests__/imap-smtp-caldav-connection.service.spec.ts
deleted file mode 100644
index 25cf60ccad8..00000000000
--- a/packages/twenty-server/src/engine/core-modules/imap-smtp-caldav-connection/services/__tests__/imap-smtp-caldav-connection.service.spec.ts
+++ /dev/null
@@ -1,157 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { createTransport } from 'nodemailer';
-import { type DAVClient } from 'tsdav';
-
-import { EmailConnectionSecurity } from 'src/engine/core-modules/imap-smtp-caldav-connection/enums/email-connection-security.enum';
-import { ImapSmtpCaldavValidatorService } from 'src/engine/core-modules/imap-smtp-caldav-connection/services/imap-smtp-caldav-connection-validator.service';
-import { ImapSmtpCaldavService } from 'src/engine/core-modules/imap-smtp-caldav-connection/services/imap-smtp-caldav-connection.service';
-import { type ConnectionParameters } from 'src/engine/core-modules/imap-smtp-caldav-connection/types/imap-smtp-caldav-connection.type';
-import { SecureHttpClientService } from 'src/engine/core-modules/secure-http-client/secure-http-client.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { CalDavClientService } from 'src/modules/calendar/calendar-event-import-manager/drivers/caldav/services/caldav-client.service';
-import { CalDavFetchEventsService } from 'src/modules/calendar/calendar-event-import-manager/drivers/caldav/services/caldav-fetch-events.service';
-
-jest.mock('nodemailer', () => ({
- createTransport: jest.fn(),
-}));
-
-describe('ImapSmtpCaldavService', () => {
- let service: ImapSmtpCaldavService;
-
- const mockClient = {} as DAVClient;
-
- const mockVerify = jest.fn().mockResolvedValue(true);
- const mockGetValidatedHost = jest
- .fn()
- .mockImplementation((host: string) => Promise.resolve(host));
-
- const mockCalDavClientService = {
- getClient: jest.fn(),
- };
-
- const mockCalDavFetchEventsService = {
- listEventCalendars: jest.fn(),
- };
-
- beforeEach(async () => {
- jest.clearAllMocks();
- (createTransport as jest.Mock).mockReturnValue({ verify: mockVerify });
- mockVerify.mockResolvedValue(true);
- mockCalDavClientService.getClient.mockResolvedValue(mockClient);
- mockCalDavFetchEventsService.listEventCalendars.mockResolvedValue([
- { url: 'https://caldav.example.com/calendars/user/default/' },
- ]);
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ImapSmtpCaldavService,
- {
- provide: SecureHttpClientService,
- useValue: { getValidatedHost: mockGetValidatedHost },
- },
- { provide: ImapSmtpCaldavValidatorService, useValue: {} },
- {
- provide: TwentyConfigService,
- useValue: { get: jest.fn().mockReturnValue(true) },
- },
- {
- provide: CalDavClientService,
- useValue: mockCalDavClientService,
- },
- {
- provide: CalDavFetchEventsService,
- useValue: mockCalDavFetchEventsService,
- },
- ],
- }).compile();
-
- service = module.get<ImapSmtpCaldavService>(ImapSmtpCaldavService);
- });
-
- describe('testCaldavConnection', () => {
- const params: ConnectionParameters = {
- host: 'https://caldav.example.com',
- port: 443,
- username: '[email protected]',
- password: 'password123',
- connectionSecurity: EmailConnectionSecurity.SSL_TLS,
- };
-
- it('builds a CalDAV client and lists its event calendars', async () => {
- await service.testCaldavConnection('[email protected]', params);
-
- expect(mockCalDavClientService.getClient).toHaveBeenCalledWith({
- serverUrl: 'https://caldav.example.com',
- username: '[email protected]',
- password: 'password123',
- });
- expect(
- mockCalDavFetchEventsService.listEventCalendars,
- ).toHaveBeenCalledWith(mockClient);
- });
-
- it('falls back to the handle when CALDAV.username is missing', async () => {
- await service.testCaldavConnection('[email protected]', {
- ...params,
- username: undefined,
- });
-
- expect(mockCalDavClientService.getClient).toHaveBeenCalledWith(
- expect.objectContaining({ username: '[email protected]' }),
- );
- });
-
- it('throws when no event calendars are found', async () => {
- mockCalDavFetchEventsService.listEventCalendars.mockResolvedValue([]);
-
- await expect(
- service.testCaldavConnection('[email protected]', params),
- ).rejects.toThrow('No calendar with event support found');
- });
- });
-
- describe('testSmtpConnection', () => {
- const params: ConnectionParameters = {
- host: 'smtp.example.com',
- port: 587,
- username: '[email protected]',
- password: 'password123',
- connectionSecurity: EmailConnectionSecurity.STARTTLS,
- };
-
- it('uses implicit TLS when connectionSecurity is SSL_TLS', async () => {
- await service.testSmtpConnection('[email protected]', {
- ...params,
- port: 465,
- connectionSecurity: EmailConnectionSecurity.SSL_TLS,
- });
-
- expect(createTransport).toHaveBeenCalledWith(
- expect.objectContaining({ secure: true }),
- );
- });
-
- it('upgrades opportunistically via STARTTLS', async () => {
- await service.testSmtpConnection('[email protected]', {
- ...params,
- connectionSecurity: EmailConnectionSecurity.STARTTLS,
- });
-
- expect(createTransport).toHaveBeenCalledWith(
- expect.objectContaining({ secure: false }),
- );
- });
-
- it('disables TLS when connectionSecurity is NONE', async () => {
- await service.testSmtpConnection('[email protected]', {
- ...params,
- connectionSecurity: EmailConnectionSecurity.NONE,
- });
-
- expect(createTransport).toHaveBeenCalledWith(
- expect.objectContaining({ secure: false, ignoreTLS: true }),
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/impersonation/__tests__/impersonation-authorization.service.spec.ts b/packages/twenty-server/src/engine/core-modules/impersonation/__tests__/impersonation-authorization.service.spec.ts
deleted file mode 100644
index 58c61599972..00000000000
--- a/packages/twenty-server/src/engine/core-modules/impersonation/__tests__/impersonation-authorization.service.spec.ts
+++ /dev/null
@@ -1,411 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { PermissionFlagType } from 'twenty-shared/constants';
-
-import { ImpersonationAuthorizationService } from 'src/engine/core-modules/impersonation/services/impersonation-authorization.service';
-import { NodeEnvironment } from 'src/engine/core-modules/twenty-config/interfaces/node-environment.interface';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { OTPStatus } from 'src/engine/core-modules/two-factor-authentication/strategies/otp/otp.constants';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { PermissionsService } from 'src/engine/metadata-modules/permissions/permissions.service';
-
-const userHasWorkspaceSettingPermissionMock = jest.fn();
-const twentyConfigServiceGetMock = jest.fn();
-
-const VERIFIED_TWO_FACTOR_METHODS = [
- { status: OTPStatus.VERIFIED },
-] as unknown as UserWorkspaceEntity['twoFactorAuthenticationMethods'];
-
-type BuildUserWorkspaceParams = {
- userWorkspaceId?: string;
- userId?: string;
- workspaceId?: string;
- canImpersonate?: boolean;
- canAccessFullAdminPanel?: boolean;
- allowImpersonation?: boolean;
- twoFactorAuthenticationMethods?: UserWorkspaceEntity['twoFactorAuthenticationMethods'];
-};
-
-const buildUserWorkspace = ({
- userWorkspaceId = 'user-workspace-id',
- userId = 'user-id',
- workspaceId = 'workspace-id',
- canImpersonate = false,
- canAccessFullAdminPanel = false,
- allowImpersonation = false,
- twoFactorAuthenticationMethods = [],
-}: BuildUserWorkspaceParams): UserWorkspaceEntity =>
- ({
- id: userWorkspaceId,
- userId,
- user: {
- id: userId,
- canImpersonate,
- canAccessFullAdminPanel,
- },
- workspace: {
- id: workspaceId,
- allowImpersonation,
- },
- twoFactorAuthenticationMethods,
- }) as unknown as UserWorkspaceEntity;
-
-describe('ImpersonationAuthorizationService', () => {
- let service: ImpersonationAuthorizationService;
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- twentyConfigServiceGetMock.mockImplementation((key: string) =>
- key === 'NODE_ENV' ? NodeEnvironment.PRODUCTION : undefined,
- );
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ImpersonationAuthorizationService,
- {
- provide: PermissionsService,
- useValue: {
- userHasWorkspaceSettingPermission:
- userHasWorkspaceSettingPermissionMock,
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: twentyConfigServiceGetMock,
- },
- },
- ],
- }).compile();
-
- service = module.get<ImpersonationAuthorizationService>(
- ImpersonationAuthorizationService,
- );
- });
-
- describe('getImpersonationLevel', () => {
- it('should return workspace when impersonator and target share a workspace', () => {
- const impersonator = buildUserWorkspace({ workspaceId: 'workspace-1' });
- const target = buildUserWorkspace({
- userId: 'other',
- workspaceId: 'workspace-1',
- });
-
- expect(service.getImpersonationLevel(impersonator, target)).toBe(
- 'workspace',
- );
- });
-
- it('should return server when impersonator and target are in different workspaces', () => {
- const impersonator = buildUserWorkspace({ workspaceId: 'workspace-1' });
- const target = buildUserWorkspace({
- userId: 'other',
- workspaceId: 'workspace-2',
- });
-
- expect(service.getImpersonationLevel(impersonator, target)).toBe(
- 'server',
- );
- });
- });
-
- describe('server-level impersonation', () => {
- it('should allow when impersonator can impersonate, has verified 2FA and target workspace allows it', async () => {
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- canImpersonate: true,
- twoFactorAuthenticationMethods: VERIFIED_TWO_FACTOR_METHODS,
- });
- const target = buildUserWorkspace({
- userId: 'target',
- workspaceId: 'workspace-2',
- allowImpersonation: true,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({ allowed: true, level: 'server' });
- expect(userHasWorkspaceSettingPermissionMock).not.toHaveBeenCalled();
- });
-
- it('should deny with provisioning reason when impersonator has no 2FA method (production)', async () => {
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- canImpersonate: true,
- twoFactorAuthenticationMethods: [],
- });
- const target = buildUserWorkspace({
- userId: 'target',
- workspaceId: 'workspace-2',
- allowImpersonation: true,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({
- allowed: false,
- level: 'server',
- reason: 'SERVER_LEVEL_2FA_PROVISION_REQUIRED',
- });
- });
-
- it('should deny with verification reason when impersonator has an unverified 2FA method (production)', async () => {
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- canImpersonate: true,
- twoFactorAuthenticationMethods: [
- { status: OTPStatus.PENDING },
- ] as unknown as UserWorkspaceEntity['twoFactorAuthenticationMethods'],
- });
- const target = buildUserWorkspace({
- userId: 'target',
- workspaceId: 'workspace-2',
- allowImpersonation: true,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({
- allowed: false,
- level: 'server',
- reason: 'SERVER_LEVEL_2FA_VERIFICATION_REQUIRED',
- });
- });
-
- it('should allow server-level impersonation without 2FA in development', async () => {
- twentyConfigServiceGetMock.mockImplementation((key: string) =>
- key === 'NODE_ENV' ? NodeEnvironment.DEVELOPMENT : undefined,
- );
-
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- canImpersonate: true,
- twoFactorAuthenticationMethods: [],
- });
- const target = buildUserWorkspace({
- userId: 'target',
- workspaceId: 'workspace-2',
- allowImpersonation: true,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({ allowed: true, level: 'server' });
- });
-
- it('should deny when impersonator cannot impersonate', async () => {
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- canImpersonate: false,
- });
- const target = buildUserWorkspace({
- userId: 'target',
- workspaceId: 'workspace-2',
- allowImpersonation: true,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({
- allowed: false,
- level: 'server',
- reason: 'SERVER_LEVEL_NOT_ALLOWED',
- });
- });
-
- it('should deny when target workspace does not allow impersonation', async () => {
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- canImpersonate: true,
- });
- const target = buildUserWorkspace({
- userId: 'target',
- workspaceId: 'workspace-2',
- allowImpersonation: false,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({
- allowed: false,
- level: 'server',
- reason: 'SERVER_LEVEL_NOT_ALLOWED',
- });
- });
-
- it('should NOT apply the admin-privilege check at server level (a server-level impersonator may impersonate an admin)', async () => {
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- canImpersonate: true,
- canAccessFullAdminPanel: false,
- twoFactorAuthenticationMethods: VERIFIED_TWO_FACTOR_METHODS,
- });
- const target = buildUserWorkspace({
- userId: 'admin-target',
- workspaceId: 'workspace-2',
- allowImpersonation: true,
- canAccessFullAdminPanel: true,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({ allowed: true, level: 'server' });
- });
- });
-
- describe('workspace-level impersonation', () => {
- it('should allow when impersonator has the IMPERSONATE permission and target is not an admin', async () => {
- userHasWorkspaceSettingPermissionMock.mockResolvedValue(true);
-
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- });
- const target = buildUserWorkspace({
- userId: 'target',
- workspaceId: 'workspace-1',
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({ allowed: true, level: 'workspace' });
- expect(userHasWorkspaceSettingPermissionMock).toHaveBeenCalledWith({
- userWorkspaceId: impersonator.id,
- setting: PermissionFlagType.IMPERSONATE,
- workspaceId: target.workspace.id,
- });
- });
-
- it('should deny when impersonator lacks the IMPERSONATE permission', async () => {
- userHasWorkspaceSettingPermissionMock.mockResolvedValue(false);
-
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- });
- const target = buildUserWorkspace({
- userId: 'target',
- workspaceId: 'workspace-1',
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({
- allowed: false,
- level: 'workspace',
- reason: 'WORKSPACE_LEVEL_NOT_ALLOWED',
- });
- });
-
- it('should deny when a non-admin tries to impersonate an admin (canAccessFullAdminPanel)', async () => {
- userHasWorkspaceSettingPermissionMock.mockResolvedValue(true);
-
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- canImpersonate: false,
- canAccessFullAdminPanel: false,
- });
- const target = buildUserWorkspace({
- userId: 'admin-target',
- workspaceId: 'workspace-1',
- canAccessFullAdminPanel: true,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({
- allowed: false,
- level: 'workspace',
- reason: 'TARGET_HAS_ADMIN_PRIVILEGES',
- });
- });
-
- it('should deny when a non-admin tries to impersonate an admin (canImpersonate)', async () => {
- userHasWorkspaceSettingPermissionMock.mockResolvedValue(true);
-
- const impersonator = buildUserWorkspace({
- userId: 'impersonator',
- workspaceId: 'workspace-1',
- canImpersonate: false,
- canAccessFullAdminPanel: false,
- });
- const target = buildUserWorkspace({
- userId: 'admin-target',
- workspaceId: 'workspace-1',
- canImpersonate: true,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({
- allowed: false,
- level: 'workspace',
- reason: 'TARGET_HAS_ADMIN_PRIVILEGES',
- });
- });
-
- it('should allow an admin to impersonate another admin', async () => {
- userHasWorkspaceSettingPermissionMock.mockResolvedValue(true);
-
- const impersonator = buildUserWorkspace({
- userId: 'admin-impersonator',
- workspaceId: 'workspace-1',
- canAccessFullAdminPanel: true,
- });
- const target = buildUserWorkspace({
- userId: 'admin-target',
- workspaceId: 'workspace-1',
- canAccessFullAdminPanel: true,
- });
-
- const result = await service.checkImpersonationAuthorization(
- impersonator,
- target,
- );
-
- expect(result).toEqual({ allowed: true, level: 'workspace' });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/impersonation/__tests__/impersonation.service.spec.ts b/packages/twenty-server/src/engine/core-modules/impersonation/__tests__/impersonation.service.spec.ts
deleted file mode 100644
index d10aa2c4a4a..00000000000
--- a/packages/twenty-server/src/engine/core-modules/impersonation/__tests__/impersonation.service.spec.ts
+++ /dev/null
@@ -1,1000 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { NodeEnvironment } from 'src/engine/core-modules/twenty-config/interfaces/node-environment.interface';
-
-import {
- AuthException,
- AuthExceptionCode,
-} from 'src/engine/core-modules/auth/auth.exception';
-import { LoginTokenService } from 'src/engine/core-modules/auth/token/services/login-token.service';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-import { WorkspaceDomainsService } from 'src/engine/core-modules/domain/workspace-domains/services/workspace-domains.service';
-import { EventLogEmitterService } from 'src/engine/core-modules/event-logs/emit/event-log-emitter.service';
-import { ImpersonationAuthorizationService } from 'src/engine/core-modules/impersonation/services/impersonation-authorization.service';
-import { ImpersonationService } from 'src/engine/core-modules/impersonation/services/impersonation.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { OTPStatus } from 'src/engine/core-modules/two-factor-authentication/strategies/otp/otp.constants';
-import { UserSessionCookieService } from 'src/engine/core-modules/user-session/services/user-session-cookie.service';
-import { UserSessionService } from 'src/engine/core-modules/user-session/services/user-session.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { PermissionsService } from 'src/engine/metadata-modules/permissions/permissions.service';
-
-const UserWorkspaceFindOneMock = jest.fn();
-const LoginTokenServiceGenerateLoginTokenMock = jest.fn();
-const PermissionsServiceUserHasWorkspaceSettingPermissionMock = jest.fn();
-const TwentyConfigServiceGetMock = jest.fn();
-const UserSessionCreateSessionMock = jest.fn();
-const UserSessionRevokeByTokenMock = jest.fn();
-const UserSessionResolveSessionMock = jest.fn();
-const CookieAttachMock = jest.fn();
-const CookieClearMock = jest.fn();
-const CookieExtractMock = jest.fn();
-const CookieExtractImpersonatorMock = jest.fn();
-const CookieClearImpersonatorMock = jest.fn();
-
-describe('ImpersonationService', () => {
- let service: ImpersonationService;
-
- beforeEach(async () => {
- TwentyConfigServiceGetMock.mockImplementation((key: string) => {
- if (key === 'NODE_ENV') {
- return NodeEnvironment.PRODUCTION;
- }
-
- return undefined;
- });
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ImpersonationService,
- ImpersonationAuthorizationService,
- {
- provide: getRepositoryToken(UserEntity),
- useValue: {
- findOne: jest.fn(), // Not used but required by constructor
- },
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: {
- findOne: UserWorkspaceFindOneMock,
- },
- },
- {
- provide: LoginTokenService,
- useValue: {
- generateLoginToken: LoginTokenServiceGenerateLoginTokenMock,
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: TwentyConfigServiceGetMock,
- },
- },
- {
- provide: UserSessionService,
- useValue: {
- createSession: UserSessionCreateSessionMock,
- revokeSessionByToken: UserSessionRevokeByTokenMock,
- resolveSession: UserSessionResolveSessionMock,
- },
- },
- {
- provide: UserSessionCookieService,
- useValue: {
- attachSessionTokenToResponse: CookieAttachMock,
- clearSessionCookie: CookieClearMock,
- extractSessionTokenFromRequest: CookieExtractMock,
- extractImpersonatorSessionTokenFromRequest:
- CookieExtractImpersonatorMock,
- clearImpersonatorSessionCookie: CookieClearImpersonatorMock,
- },
- },
- {
- provide: WorkspaceDomainsService,
- useValue: {
- getWorkspaceUrls: jest.fn().mockReturnValue({
- customUrl: undefined,
- subdomainUrl: 'https://twenty.twenty.com',
- }),
- },
- },
- {
- provide: EventLogEmitterService,
- useValue: {
- createContext: jest.fn().mockReturnValue({
- insertWorkspaceEvent: jest.fn(),
- }),
- },
- },
- {
- provide: PermissionsService,
- useValue: {
- userHasWorkspaceSettingPermission:
- PermissionsServiceUserHasWorkspaceSettingPermissionMock,
- },
- },
- ],
- }).compile();
-
- service = module.get<ImpersonationService>(ImpersonationService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should be defined', async () => {
- expect(service).toBeDefined();
- });
-
- it('should impersonate a user and return workspace and loginToken on success', async () => {
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'workspace-id',
- user: {
- id: 'target-user-id',
- email: '[email protected]',
- },
- workspace: {
- id: 'workspace-id',
- allowImpersonation: true,
- subdomain: 'example-subdomain',
- },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'workspace-id',
- user: {
- id: 'impersonator-user-id',
- email: '[email protected]',
- },
- workspace: {
- id: 'workspace-id',
- allowImpersonation: true,
- subdomain: 'example-subdomain',
- },
- twoFactorAuthenticationMethods: [],
- };
-
- // Mock first call for target user workspace
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- // Mock second call for impersonator user workspace
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- // Mock workspace-level permission check to return true
- PermissionsServiceUserHasWorkspaceSettingPermissionMock.mockResolvedValueOnce(
- true,
- );
-
- LoginTokenServiceGenerateLoginTokenMock.mockResolvedValueOnce({
- token: 'mock-login-token',
- expiresAt: new Date(),
- });
-
- const result = await service.impersonate(
- 'target-user-id',
- 'workspace-id',
- 'impersonator-user-workspace-id',
- );
-
- expect(UserWorkspaceFindOneMock).toHaveBeenCalledTimes(2);
-
- expect(UserWorkspaceFindOneMock).toHaveBeenNthCalledWith(1, {
- where: {
- userId: 'target-user-id',
- workspaceId: 'workspace-id',
- },
- relations: ['user', 'workspace'],
- });
-
- expect(UserWorkspaceFindOneMock).toHaveBeenNthCalledWith(2, {
- where: {
- id: 'impersonator-user-workspace-id',
- },
- relations: ['user', 'workspace', 'twoFactorAuthenticationMethods'],
- });
-
- expect(LoginTokenServiceGenerateLoginTokenMock).toHaveBeenCalledWith(
- 'workspace-id',
- 'impersonation',
- { impersonatorUserWorkspaceId: 'impersonator-user-workspace-id' },
- );
-
- expect(result).toEqual({
- workspace: {
- id: 'workspace-id',
- workspaceUrls: {
- customUrl: undefined,
- subdomainUrl: 'https://twenty.twenty.com',
- },
- },
- loginToken: {
- token: 'mock-login-token',
- expiresAt: expect.any(Date),
- },
- });
- });
-
- it('should allow impersonation within the same workspace even when allowImpersonation is false', async () => {
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'workspace-id',
- user: { id: 'target-user-id', email: '[email protected]' },
- workspace: { id: 'workspace-id', allowImpersonation: false },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'workspace-id', // Same workspace ID
- user: { id: 'impersonator-user-id', canImpersonate: false }, // Explicitly set to false
- workspace: { id: 'workspace-id', allowImpersonation: false }, // Same workspace ID
- twoFactorAuthenticationMethods: [],
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- // Mock workspace-level permission check to return true
- PermissionsServiceUserHasWorkspaceSettingPermissionMock.mockResolvedValueOnce(
- true,
- );
-
- LoginTokenServiceGenerateLoginTokenMock.mockResolvedValueOnce({
- token: 'mock-login-token',
- expiresAt: new Date(),
- });
-
- // This should succeed because same-workspace impersonation doesn't check allowImpersonation
- const result = await service.impersonate(
- 'target-user-id',
- 'workspace-id',
- 'impersonator-user-workspace-id',
- );
-
- expect(result).toEqual({
- workspace: {
- id: 'workspace-id',
- workspaceUrls: {
- customUrl: undefined,
- subdomainUrl: 'https://twenty.twenty.com',
- },
- },
- loginToken: {
- token: 'mock-login-token',
- expiresAt: expect.any(Date),
- },
- });
- });
-
- it('should throw an error when target user is not found', async () => {
- UserWorkspaceFindOneMock.mockResolvedValueOnce(null); // Target user not found
- UserWorkspaceFindOneMock.mockResolvedValueOnce({
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'workspace-id',
- user: { id: 'impersonator-user-id' },
- workspace: { id: 'workspace-id' },
- twoFactorAuthenticationMethods: [],
- });
-
- await expect(
- service.impersonate(
- 'invalid-user-id',
- 'workspace-id',
- 'impersonator-user-workspace-id',
- ),
- ).rejects.toThrow(
- new AuthException(
- 'User not found in workspace or impersonation not enabled',
- AuthExceptionCode.USER_WORKSPACE_NOT_FOUND,
- ),
- );
- });
-
- it('should throw an error when impersonator user workspace is not found', async () => {
- UserWorkspaceFindOneMock.mockResolvedValueOnce({
- userId: 'target-user-id',
- workspaceId: 'workspace-id',
- user: { id: 'target-user-id' },
- workspace: { id: 'workspace-id' },
- });
- UserWorkspaceFindOneMock.mockResolvedValueOnce(null); // Impersonator workspace not found
-
- await expect(
- service.impersonate(
- 'target-user-id',
- 'workspace-id',
- 'invalid-impersonator-workspace-id',
- ),
- ).rejects.toThrow(
- new AuthException(
- 'User not found in workspace or impersonation not enabled',
- AuthExceptionCode.USER_WORKSPACE_NOT_FOUND,
- ),
- );
- });
-
- it('should throw an error when impersonating the same user', async () => {
- const sameUserWorkspace = {
- id: 'same-user-workspace-id',
- userId: 'same-user-id',
- workspaceId: 'workspace-id',
- user: {
- id: 'same-user-id',
- email: '[email protected]',
- canImpersonate: true,
- canAccessFullAdminPanel: false,
- },
- workspace: {
- id: 'workspace-id',
- allowImpersonation: true,
- },
- twoFactorAuthenticationMethods: [],
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(sameUserWorkspace);
- UserWorkspaceFindOneMock.mockResolvedValueOnce(sameUserWorkspace);
-
- await expect(
- service.impersonate(
- 'same-user-id',
- 'workspace-id',
- 'same-user-workspace-id',
- ),
- ).rejects.toThrow(
- new AuthException(
- 'User cannot impersonate themselves',
- AuthExceptionCode.FORBIDDEN_EXCEPTION,
- ),
- );
-
- expect(LoginTokenServiceGenerateLoginTokenMock).not.toHaveBeenCalled();
- });
-
- it('should throw an error when impersonation is not enabled for the workspace', async () => {
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'workspace-id',
- user: { id: 'target-user-id', email: '[email protected]' },
- workspace: { id: 'workspace-id', allowImpersonation: false },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'other-workspace-id',
- user: { id: 'impersonator-user-id' },
- workspace: { id: 'other-workspace-id' },
- twoFactorAuthenticationMethods: [],
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- await expect(
- service.impersonate(
- 'target-user-id',
- 'workspace-id',
- 'impersonator-user-workspace-id',
- ),
- ).rejects.toThrow(
- new AuthException(
- 'Server level impersonation not allowed',
- AuthExceptionCode.FORBIDDEN_EXCEPTION,
- ),
- );
- });
-
- it('should throw an error when impersonation is not enabled at server level for the user', async () => {
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'target-workspace-id',
- user: { id: 'target-user-id', email: '[email protected]' },
- workspace: { id: 'target-workspace-id', allowImpersonation: true },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'impersonator-workspace-id',
- user: { id: 'impersonator-user-id', canImpersonate: false },
- workspace: { id: 'impersonator-workspace-id', allowImpersonation: true },
- twoFactorAuthenticationMethods: [],
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- // Mock workspace-level permission check to return false
- PermissionsServiceUserHasWorkspaceSettingPermissionMock.mockResolvedValueOnce(
- false,
- );
-
- await expect(
- service.impersonate(
- 'target-user-id',
- 'target-workspace-id',
- 'impersonator-user-workspace-id',
- ),
- ).rejects.toThrow(
- new AuthException(
- 'Server level impersonation not allowed',
- AuthExceptionCode.FORBIDDEN_EXCEPTION,
- ),
- );
- });
-
- describe('admin privilege escalation prevention', () => {
- beforeEach(() => {
- PermissionsServiceUserHasWorkspaceSettingPermissionMock.mockReset();
- });
-
- it('should throw when non-admin tries to impersonate a user with canAccessFullAdminPanel', async () => {
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'workspace-id',
- user: {
- id: 'target-user-id',
- email: '[email protected]',
- canAccessFullAdminPanel: true,
- canImpersonate: false,
- },
- workspace: { id: 'workspace-id', allowImpersonation: true },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'workspace-id',
- user: {
- id: 'impersonator-user-id',
- canImpersonate: false,
- canAccessFullAdminPanel: false,
- },
- workspace: { id: 'workspace-id', allowImpersonation: true },
- twoFactorAuthenticationMethods: [],
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- PermissionsServiceUserHasWorkspaceSettingPermissionMock.mockResolvedValueOnce(
- true,
- );
-
- await expect(
- service.impersonate(
- 'target-user-id',
- 'workspace-id',
- 'impersonator-user-workspace-id',
- ),
- ).rejects.toThrow(
- new AuthException(
- 'Cannot impersonate a user with admin privileges. Only administrators can impersonate other administrators.',
- AuthExceptionCode.FORBIDDEN_EXCEPTION,
- ),
- );
- });
-
- it('should throw when non-admin tries to impersonate a user with canImpersonate', async () => {
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'workspace-id',
- user: {
- id: 'target-user-id',
- email: '[email protected]',
- canImpersonate: true,
- canAccessFullAdminPanel: false,
- },
- workspace: { id: 'workspace-id', allowImpersonation: true },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'workspace-id',
- user: {
- id: 'impersonator-user-id',
- canImpersonate: false,
- canAccessFullAdminPanel: false,
- },
- workspace: { id: 'workspace-id', allowImpersonation: true },
- twoFactorAuthenticationMethods: [],
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- PermissionsServiceUserHasWorkspaceSettingPermissionMock.mockResolvedValueOnce(
- true,
- );
-
- await expect(
- service.impersonate(
- 'target-user-id',
- 'workspace-id',
- 'impersonator-user-workspace-id',
- ),
- ).rejects.toThrow(
- new AuthException(
- 'Cannot impersonate a user with admin privileges. Only administrators can impersonate other administrators.',
- AuthExceptionCode.FORBIDDEN_EXCEPTION,
- ),
- );
- });
-
- it('should allow admin to impersonate another admin in the same workspace', async () => {
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'workspace-id',
- user: {
- id: 'target-user-id',
- email: '[email protected]',
- canAccessFullAdminPanel: true,
- canImpersonate: false,
- },
- workspace: { id: 'workspace-id', allowImpersonation: true },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'workspace-id',
- user: {
- id: 'impersonator-user-id',
- canImpersonate: false,
- canAccessFullAdminPanel: true,
- },
- workspace: { id: 'workspace-id', allowImpersonation: true },
- twoFactorAuthenticationMethods: [],
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- PermissionsServiceUserHasWorkspaceSettingPermissionMock.mockResolvedValueOnce(
- true,
- );
-
- LoginTokenServiceGenerateLoginTokenMock.mockResolvedValueOnce({
- token: 'mock-login-token',
- expiresAt: new Date(),
- });
-
- const result = await service.impersonate(
- 'target-user-id',
- 'workspace-id',
- 'impersonator-user-workspace-id',
- );
-
- expect(result).toEqual({
- workspace: {
- id: 'workspace-id',
- workspaceUrls: {
- customUrl: undefined,
- subdomainUrl: 'https://twenty.twenty.com',
- },
- },
- loginToken: {
- token: 'mock-login-token',
- expiresAt: expect.any(Date),
- },
- });
- });
- });
-
- describe('2FA requirements for server-level impersonation', () => {
- it('should allow server-level impersonation when 2FA is enabled and verified', async () => {
- TwentyConfigServiceGetMock.mockImplementation((key: string) => {
- if (key === 'NODE_ENV') {
- return NodeEnvironment.PRODUCTION;
- }
-
- return undefined;
- });
-
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'target-workspace-id',
- user: { id: 'target-user-id', email: '[email protected]' },
- workspace: { id: 'target-workspace-id', allowImpersonation: true },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'impersonator-workspace-id',
- user: { id: 'impersonator-user-id', canImpersonate: true },
- workspace: {
- id: 'impersonator-workspace-id',
- allowImpersonation: true,
- },
- twoFactorAuthenticationMethods: [
- {
- id: '2fa-method-id',
- status: OTPStatus.VERIFIED,
- strategy: 'TOTP',
- },
- ],
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- LoginTokenServiceGenerateLoginTokenMock.mockResolvedValueOnce({
- token: 'mock-login-token',
- expiresAt: new Date(),
- });
-
- const result = await service.impersonate(
- 'target-user-id',
- 'target-workspace-id',
- 'impersonator-user-workspace-id',
- );
-
- expect(result).toEqual({
- workspace: {
- id: 'target-workspace-id',
- workspaceUrls: {
- customUrl: undefined,
- subdomainUrl: 'https://twenty.twenty.com',
- },
- },
- loginToken: {
- token: 'mock-login-token',
- expiresAt: expect.any(Date),
- },
- });
- });
-
- it('should throw an error when 2FA is not enabled for server-level impersonation in production', async () => {
- TwentyConfigServiceGetMock.mockImplementation((key: string) => {
- if (key === 'NODE_ENV') {
- return NodeEnvironment.PRODUCTION;
- }
-
- return undefined;
- });
-
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'target-workspace-id',
- user: { id: 'target-user-id', email: '[email protected]' },
- workspace: { id: 'target-workspace-id', allowImpersonation: true },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'impersonator-workspace-id',
- user: { id: 'impersonator-user-id', canImpersonate: true },
- workspace: {
- id: 'impersonator-workspace-id',
- allowImpersonation: true,
- },
- twoFactorAuthenticationMethods: [], // No 2FA methods
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- await expect(
- service.impersonate(
- 'target-user-id',
- 'target-workspace-id',
- 'impersonator-user-workspace-id',
- ),
- ).rejects.toThrow(
- new AuthException(
- 'Two-factor authentication is required for server-level impersonation. Please enable 2FA in your workspace settings before attempting to impersonate users.',
- AuthExceptionCode.TWO_FACTOR_AUTHENTICATION_PROVISION_REQUIRED,
- ),
- );
- });
-
- it('should throw an error when 2FA is not verified for server-level impersonation in production', async () => {
- TwentyConfigServiceGetMock.mockImplementation((key: string) => {
- if (key === 'NODE_ENV') {
- return NodeEnvironment.PRODUCTION;
- }
-
- return undefined;
- });
-
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'target-workspace-id',
- user: { id: 'target-user-id', email: '[email protected]' },
- workspace: { id: 'target-workspace-id', allowImpersonation: true },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'impersonator-workspace-id',
- user: { id: 'impersonator-user-id', canImpersonate: true },
- workspace: {
- id: 'impersonator-workspace-id',
- allowImpersonation: true,
- },
- twoFactorAuthenticationMethods: [
- {
- id: '2fa-method-id',
- status: OTPStatus.PENDING, // Not verified
- strategy: 'TOTP',
- },
- ],
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- await expect(
- service.impersonate(
- 'target-user-id',
- 'target-workspace-id',
- 'impersonator-user-workspace-id',
- ),
- ).rejects.toThrow(
- new AuthException(
- 'Two-factor authentication is required for server-level impersonation. Please verify your 2FA method before attempting to impersonate users.',
- AuthExceptionCode.TWO_FACTOR_AUTHENTICATION_VERIFICATION_REQUIRED,
- ),
- );
- });
-
- it('should allow server-level impersonation without 2FA in development environment', async () => {
- TwentyConfigServiceGetMock.mockImplementation((key: string) => {
- if (key === 'NODE_ENV') {
- return NodeEnvironment.DEVELOPMENT;
- }
-
- return undefined;
- });
-
- const mockToImpersonateUserWorkspace = {
- userId: 'target-user-id',
- workspaceId: 'target-workspace-id',
- user: { id: 'target-user-id', email: '[email protected]' },
- workspace: { id: 'target-workspace-id', allowImpersonation: true },
- };
-
- const mockImpersonatorUserWorkspace = {
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'impersonator-workspace-id',
- user: { id: 'impersonator-user-id', canImpersonate: true },
- workspace: {
- id: 'impersonator-workspace-id',
- allowImpersonation: true,
- },
- twoFactorAuthenticationMethods: [], // No 2FA methods, but should be allowed in dev
- };
-
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockToImpersonateUserWorkspace,
- );
- UserWorkspaceFindOneMock.mockResolvedValueOnce(
- mockImpersonatorUserWorkspace,
- );
-
- LoginTokenServiceGenerateLoginTokenMock.mockResolvedValueOnce({
- token: 'mock-login-token',
- expiresAt: new Date(),
- });
-
- const result = await service.impersonate(
- 'target-user-id',
- 'target-workspace-id',
- 'impersonator-user-workspace-id',
- );
-
- expect(result).toEqual({
- workspace: {
- id: 'target-workspace-id',
- workspaceUrls: {
- customUrl: undefined,
- subdomainUrl: 'https://twenty.twenty.com',
- },
- },
- loginToken: {
- token: 'mock-login-token',
- expiresAt: expect.any(Date),
- },
- });
- });
- });
- describe('stopImpersonation', () => {
- const buildRequest = () =>
- ({
- headers: {},
- res: {},
- }) as unknown as Parameters<
- ImpersonationService['stopImpersonation']
- >[0]['request'];
-
- const IMPERSONATOR_USER_WORKSPACE_ID = 'impersonator-user-workspace-id';
-
- const stopImpersonating = () => {
- UserWorkspaceFindOneMock.mockResolvedValue({
- id: IMPERSONATOR_USER_WORKSPACE_ID,
- userId: 'impersonator-user-id',
- workspaceId: 'workspace-id',
- });
-
- return service.stopImpersonation({
- impersonationContext: {
- impersonatorUserWorkspaceId: IMPERSONATOR_USER_WORKSPACE_ID,
- impersonatedUserWorkspaceId: 'impersonated-user-workspace-id',
- },
- workspaceId: 'workspace-id',
- request: buildRequest(),
- });
- };
-
- const parkedSession = (
- overrides: Record<string, unknown> = {},
- ): Record<string, unknown> => ({
- payload: {
- type: JwtTokenTypeEnum.ACCESS,
- userWorkspaceId: IMPERSONATOR_USER_WORKSPACE_ID,
- isImpersonating: false,
- ...overrides,
- },
- authenticatedAt: new Date('2026-01-01T00:00:00.000Z'),
- expiresAt: new Date('2026-07-01T00:00:00.000Z'),
- });
-
- it('should hand back the parked impersonator session without minting one', async () => {
- CookieExtractMock.mockReturnValue('sess_impersonation');
- CookieExtractImpersonatorMock.mockReturnValue('sess_impersonator');
- UserSessionResolveSessionMock.mockResolvedValue(parkedSession());
-
- const result = await stopImpersonating();
-
- expect(result).toEqual({ canRestoreImpersonatorSession: true });
- expect(UserSessionCreateSessionMock).not.toHaveBeenCalled();
- expect(CookieAttachMock).toHaveBeenCalledWith(
- expect.anything(),
- 'sess_impersonator',
- new Date('2026-07-01T00:00:00.000Z'),
- );
- expect(CookieClearMock).not.toHaveBeenCalled();
- expect(CookieClearImpersonatorMock).toHaveBeenCalled();
- });
-
- it('should refuse to restore a session belonging to someone else', async () => {
- CookieExtractMock.mockReturnValue('sess_impersonation');
- CookieExtractImpersonatorMock.mockReturnValue('sess_someone_else');
- UserSessionResolveSessionMock.mockResolvedValue(
- parkedSession({ userWorkspaceId: 'another-user-workspace-id' }),
- );
-
- const result = await stopImpersonating();
-
- expect(result).toEqual({ canRestoreImpersonatorSession: false });
- expect(CookieAttachMock).not.toHaveBeenCalled();
- expect(CookieClearMock).toHaveBeenCalled();
- });
-
- it('should refuse to restore a session that is itself impersonating', async () => {
- CookieExtractMock.mockReturnValue('sess_impersonation');
- CookieExtractImpersonatorMock.mockReturnValue('sess_nested');
- UserSessionResolveSessionMock.mockResolvedValue(
- parkedSession({ isImpersonating: true }),
- );
-
- const result = await stopImpersonating();
-
- expect(result).toEqual({ canRestoreImpersonatorSession: false });
- expect(CookieAttachMock).not.toHaveBeenCalled();
- });
-
- it('should refuse to restore a session revoked while impersonating', async () => {
- CookieExtractMock.mockReturnValue('sess_impersonation');
- CookieExtractImpersonatorMock.mockReturnValue('sess_revoked');
- UserSessionResolveSessionMock.mockRejectedValue(
- new AuthException('nope', AuthExceptionCode.UNAUTHENTICATED),
- );
-
- const result = await stopImpersonating();
-
- expect(result).toEqual({ canRestoreImpersonatorSession: false });
- expect(CookieAttachMock).not.toHaveBeenCalled();
- expect(CookieClearMock).toHaveBeenCalled();
- });
-
- it('should sign out when nothing was parked, as on a cross-workspace host', async () => {
- CookieExtractMock.mockReturnValue('sess_impersonation');
- CookieExtractImpersonatorMock.mockReturnValue(undefined);
-
- const result = await stopImpersonating();
-
- expect(result).toEqual({ canRestoreImpersonatorSession: false });
- expect(UserSessionResolveSessionMock).not.toHaveBeenCalled();
- expect(UserSessionCreateSessionMock).not.toHaveBeenCalled();
- expect(CookieAttachMock).not.toHaveBeenCalled();
- expect(CookieClearMock).toHaveBeenCalled();
- });
-
- it('should revoke the presented impersonation session', async () => {
- UserWorkspaceFindOneMock.mockResolvedValue({
- id: 'impersonator-user-workspace-id',
- userId: 'impersonator-user-id',
- workspaceId: 'workspace-id',
- });
- CookieExtractMock.mockReturnValue('sess_presented');
-
- await service.stopImpersonation({
- impersonationContext: {
- impersonatorUserWorkspaceId: 'impersonator-user-workspace-id',
- impersonatedUserWorkspaceId: 'impersonated-user-workspace-id',
- },
- workspaceId: 'workspace-id',
- request: buildRequest(),
- });
-
- expect(UserSessionRevokeByTokenMock).toHaveBeenCalledWith(
- 'sess_presented',
- expect.anything(),
- );
- });
-
- it('should refuse when the request is not impersonating', async () => {
- await expect(
- service.stopImpersonation({
- impersonationContext: undefined,
- workspaceId: 'workspace-id',
- request: buildRequest(),
- }),
- ).rejects.toThrow(AuthException);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/key-value-pair/key-value-pair.service.spec.ts b/packages/twenty-server/src/engine/core-modules/key-value-pair/key-value-pair.service.spec.ts
deleted file mode 100644
index fad43c30673..00000000000
--- a/packages/twenty-server/src/engine/core-modules/key-value-pair/key-value-pair.service.spec.ts
+++ /dev/null
@@ -1,175 +0,0 @@
-import { type Repository } from 'typeorm';
-
-import {
- KeyValuePairEntity,
- KeyValuePairType,
-} from 'src/engine/core-modules/key-value-pair/key-value-pair.entity';
-
-import { KeyValuePairService } from './key-value-pair.service';
-
-describe('KeyValuePairService', () => {
- let service: KeyValuePairService;
- let keyValuePairRepository: jest.Mocked<Repository<KeyValuePairEntity>>;
-
- beforeEach(() => {
- keyValuePairRepository = {
- findOne: jest.fn().mockResolvedValue(null),
- insert: jest.fn().mockResolvedValue(undefined),
- update: jest.fn().mockResolvedValue(undefined),
- upsert: jest.fn().mockResolvedValue(undefined),
- } as unknown as jest.Mocked<Repository<KeyValuePairEntity>>;
-
- service = new KeyValuePairService(keyValuePairRepository);
- });
-
- it('should upsert a global null/null key', async () => {
- await service.set({
- userId: null,
- workspaceId: null,
- key: 'MAINTENANCE_MODE',
- value: { startAt: '2026-04-02T10:00:00.000Z' },
- type: KeyValuePairType.CONFIG_VARIABLE,
- });
-
- expect(keyValuePairRepository.upsert).toHaveBeenCalledWith(
- {
- userId: null,
- workspaceId: null,
- applicationId: null,
- key: 'MAINTENANCE_MODE',
- value: { startAt: '2026-04-02T10:00:00.000Z' },
- type: KeyValuePairType.CONFIG_VARIABLE,
- },
- {
- conflictPaths: ['key'],
- indexPredicate:
- '"userId" IS NULL AND "workspaceId" IS NULL AND "applicationId" IS NULL',
- },
- );
- expect(keyValuePairRepository.findOne).not.toHaveBeenCalled();
- expect(keyValuePairRepository.insert).not.toHaveBeenCalled();
- });
-
- it('should upsert with userId-null index when workspaceId is null', async () => {
- await service.set({
- userId: 'user-id',
- workspaceId: null,
- key: 'USER_SETTING',
- value: true,
- type: KeyValuePairType.USER_VARIABLE,
- });
-
- expect(keyValuePairRepository.upsert).toHaveBeenCalledWith(
- {
- userId: 'user-id',
- workspaceId: null,
- applicationId: null,
- key: 'USER_SETTING',
- value: true,
- type: KeyValuePairType.USER_VARIABLE,
- },
- {
- conflictPaths: ['key', 'userId'],
- indexPredicate: '"workspaceId" IS NULL',
- },
- );
- });
-
- it('should upsert with workspaceId-null index when userId is null', async () => {
- await service.set({
- userId: null,
- workspaceId: 'workspace-id',
- key: 'WORKSPACE_SETTING',
- value: 'test',
- type: KeyValuePairType.CONFIG_VARIABLE,
- });
-
- expect(keyValuePairRepository.upsert).toHaveBeenCalledWith(
- {
- userId: null,
- workspaceId: 'workspace-id',
- applicationId: null,
- key: 'WORKSPACE_SETTING',
- value: 'test',
- type: KeyValuePairType.CONFIG_VARIABLE,
- },
- {
- conflictPaths: ['key', 'workspaceId'],
- indexPredicate: '"userId" IS NULL AND "applicationId" IS NULL',
- },
- );
- });
-
- it('should upsert a workspace-scoped application key on the (key, applicationId) index', async () => {
- await service.set({
- userId: null,
- workspaceId: 'workspace-id',
- applicationId: 'application-id',
- key: 'APP_SETTING',
- value: 'test',
- type: KeyValuePairType.CONFIG_VARIABLE,
- });
-
- expect(keyValuePairRepository.upsert).toHaveBeenCalledWith(
- expect.objectContaining({
- userId: null,
- workspaceId: 'workspace-id',
- applicationId: 'application-id',
- key: 'APP_SETTING',
- }),
- {
- conflictPaths: ['key', 'applicationId'],
- indexPredicate:
- '"applicationId" IS NOT NULL AND "workspaceId" IS NOT NULL',
- },
- );
- });
-
- it('should upsert a server-scoped application key on the global (key, applicationId) index', async () => {
- await service.set({
- userId: null,
- workspaceId: null,
- applicationId: 'application-id',
- key: 'APP_CLAIM',
- value: 'workspace-id',
- type: KeyValuePairType.CONFIG_VARIABLE,
- });
-
- expect(keyValuePairRepository.upsert).toHaveBeenCalledWith(
- expect.objectContaining({
- workspaceId: null,
- applicationId: 'application-id',
- key: 'APP_CLAIM',
- }),
- {
- conflictPaths: ['key', 'applicationId'],
- indexPredicate: '"applicationId" IS NOT NULL AND "workspaceId" IS NULL',
- },
- );
- });
-
- it('should upsert with full conflict paths when both ids are present', async () => {
- await service.set({
- userId: 'user-id',
- workspaceId: 'workspace-id',
- key: 'USER_WORKSPACE_SETTING',
- value: 42,
- type: KeyValuePairType.USER_VARIABLE,
- });
-
- expect(keyValuePairRepository.upsert).toHaveBeenCalledWith(
- {
- userId: 'user-id',
- workspaceId: 'workspace-id',
- applicationId: null,
- key: 'USER_WORKSPACE_SETTING',
- value: 42,
- type: KeyValuePairType.USER_VARIABLE,
- },
- {
- conflictPaths: ['key', 'userId', 'workspaceId'],
- indexPredicate: undefined,
- },
- );
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/logger/__tests__/logger.service.spec.ts b/packages/twenty-server/src/engine/core-modules/logger/__tests__/logger.service.spec.ts
deleted file mode 100644
index e076165926a..00000000000
--- a/packages/twenty-server/src/engine/core-modules/logger/__tests__/logger.service.spec.ts
+++ /dev/null
@@ -1,72 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { LOGGER_DRIVER } from 'src/engine/core-modules/logger/logger.constants';
-import { LoggerService } from 'src/engine/core-modules/logger/logger.service';
-
-describe('LoggerService', () => {
- let service: LoggerService;
- const driver = { log: jest.fn(), options: { logLevels: [] as string[] } };
-
- beforeEach(async () => {
- jest.clearAllMocks();
- driver.options.logLevels = ['log', 'error', 'warn'];
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- LoggerService,
- {
- provide: LOGGER_DRIVER,
- useValue: driver,
- },
- ],
- }).compile();
-
- service = module.get<LoggerService>(LoggerService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('perf', () => {
- it('should log through the driver when the performance level is enabled', () => {
- driver.options.logLevels = ['log', 'performance'];
-
- service.perf('message', 'Category');
-
- expect(driver.log).toHaveBeenCalledWith('message', 'Category');
- });
-
- it('should not log when the performance level is disabled', () => {
- driver.options.logLevels = ['log', 'error', 'warn'];
-
- service.perf('message', 'Category');
-
- expect(driver.log).not.toHaveBeenCalled();
- });
- });
-
- describe('perfTime / perfTimeEnd', () => {
- it('should log the elapsed duration when the performance level is enabled', () => {
- driver.options.logLevels = ['performance'];
-
- service.perfTime('Category', 'label');
- service.perfTimeEnd('Category', 'label');
-
- expect(driver.log).toHaveBeenCalledTimes(1);
- expect(driver.log).toHaveBeenCalledWith(
- expect.stringMatching(/^label: [\d.]+ms$/),
- 'Category',
- );
- });
-
- it('should not log when the performance level is disabled', () => {
- driver.options.logLevels = ['log'];
-
- service.perfTime('Category', 'label');
- service.perfTimeEnd('Category', 'label');
-
- expect(driver.log).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/route/__tests__/route-trigger.service.spec.ts b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/route/__tests__/route-trigger.service.spec.ts
deleted file mode 100644
index 7a89c39c5e3..00000000000
--- a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/route/__tests__/route-trigger.service.spec.ts
+++ /dev/null
@@ -1,129 +0,0 @@
-import { type Request } from 'express';
-import {
- HTTPMethod,
- LOGIC_FUNCTION_HTTP_RESPONSE_MARKER,
-} from 'twenty-shared/types';
-import { WorkspaceActivationStatus } from 'twenty-shared/workspace';
-import { type Repository } from 'typeorm';
-
-import { type AccessTokenService } from 'src/engine/core-modules/auth/token/services/access-token.service';
-import { type WorkspaceDomainsService } from 'src/engine/core-modules/domain/workspace-domains/services/workspace-domains.service';
-import { type LogicFunctionTriggerService } from 'src/engine/core-modules/logic-function/logic-function-trigger/logic-function-trigger.service';
-import { RouteTriggerExceptionCode } from 'src/engine/core-modules/logic-function/logic-function-trigger/triggers/route/exceptions/route-trigger.exception';
-import { RouteTriggerService } from 'src/engine/core-modules/logic-function/logic-function-trigger/triggers/route/route-trigger.service';
-import { buildRouteTriggerResponse } from 'src/engine/core-modules/logic-function/logic-function-trigger/triggers/route/utils/route-trigger-response.util';
-import { type TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { type LogicFunctionEntity } from 'src/engine/metadata-modules/logic-function/logic-function.entity';
-
-describe('buildRouteTriggerResponse', () => {
- it('wraps a plain body with status 200 and no headers', () => {
- expect(buildRouteTriggerResponse({ message: 'hi' })).toEqual({
- statusCode: 200,
- headers: {},
- body: { message: 'hi' },
- });
- });
-
- it('passes through null/undefined as a 200 with that body', () => {
- expect(buildRouteTriggerResponse(null)).toEqual({
- statusCode: 200,
- headers: {},
- body: null,
- });
- });
-
- it('reads status, headers and body from a wrapped response', () => {
- const data = {
- [LOGIC_FUNCTION_HTTP_RESPONSE_MARKER]: true,
- body: '<h1>Hi</h1>',
- status: 201,
- headers: { 'Content-Type': 'text/html' },
- };
-
- expect(buildRouteTriggerResponse(data)).toEqual({
- statusCode: 201,
- headers: { 'Content-Type': 'text/html' },
- body: '<h1>Hi</h1>',
- });
- });
-
- it('defaults a wrapped response without status/headers to 200 and {}', () => {
- const data = {
- [LOGIC_FUNCTION_HTTP_RESPONSE_MARKER]: true,
- body: { ok: true },
- };
-
- expect(buildRouteTriggerResponse(data)).toEqual({
- statusCode: 200,
- headers: {},
- body: { ok: true },
- });
- });
-});
-
-describe('RouteTriggerService', () => {
- const resolveWorkspaceAndPublicDomain = jest.fn();
- const find = jest.fn();
-
- const service = new RouteTriggerService(
- {} as unknown as AccessTokenService,
- {} as unknown as LogicFunctionTriggerService,
- { resolveWorkspaceAndPublicDomain } as unknown as WorkspaceDomainsService,
- { get: jest.fn() } as unknown as TwentyConfigService,
- { find } as unknown as Repository<LogicFunctionEntity>,
- );
-
- const request = {
- protocol: 'https',
- get: () => 'acme.twenty.com',
- path: '/s/webhook',
- } as unknown as Request;
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should reject requests when the workspace is suspended', async () => {
- resolveWorkspaceAndPublicDomain.mockResolvedValue({
- workspace: {
- id: 'workspace-id',
- activationStatus: WorkspaceActivationStatus.SUSPENDED,
- },
- publicDomain: null,
- isIsolatedOrigin: false,
- });
-
- await expect(
- service.handle({ request, httpMethod: HTTPMethod.GET }),
- ).rejects.toMatchObject({
- code: RouteTriggerExceptionCode.WORKSPACE_SUSPENDED,
- });
-
- expect(find).not.toHaveBeenCalled();
- });
-
- it('should resolve route triggers when the workspace is active', async () => {
- resolveWorkspaceAndPublicDomain.mockResolvedValue({
- workspace: {
- id: 'workspace-id',
- activationStatus: WorkspaceActivationStatus.ACTIVE,
- },
- publicDomain: null,
- isIsolatedOrigin: false,
- });
- find.mockResolvedValue([]);
-
- await expect(
- service.handle({ request, httpMethod: HTTPMethod.GET }),
- ).rejects.toMatchObject({
- code: RouteTriggerExceptionCode.TRIGGER_NOT_FOUND,
- });
-
- expect(find).toHaveBeenCalledWith({
- where: {
- workspaceId: 'workspace-id',
- httpRouteTriggerSettings: expect.anything(),
- },
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/message-queue/services/__tests__/application-job-enqueue-throttler.service.spec.ts b/packages/twenty-server/src/engine/core-modules/message-queue/services/__tests__/application-job-enqueue-throttler.service.spec.ts
deleted file mode 100644
index 7ff94bfaaff..00000000000
--- a/packages/twenty-server/src/engine/core-modules/message-queue/services/__tests__/application-job-enqueue-throttler.service.spec.ts
+++ /dev/null
@@ -1,123 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ApplicationJobEnqueueThrottlerService } from 'src/engine/core-modules/message-queue/services/application-job-enqueue-throttler.service';
-import { MetricsService } from 'src/engine/core-modules/metrics/metrics.service';
-import { MetricsKeys } from 'src/engine/core-modules/metrics/types/metrics-keys.type';
-import { ThrottlerException } from 'src/engine/core-modules/throttler/throttler.exception';
-import { ThrottlerService } from 'src/engine/core-modules/throttler/throttler.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-const CONFIG = {
- APPLICATION_JOB_ENQUEUE_RATE_LIMITING_TTL_IN_MS: 60_000,
- APPLICATION_JOB_ENQUEUE_RATE_LIMITING_LIMIT: 500,
- APPLICATION_REGISTRATION_JOB_ENQUEUE_RATE_LIMITING_LIMIT: 2000,
-} as const;
-
-const context = {
- applicationId: 'application-id',
- applicationRegistrationId: 'registration-id',
-};
-
-const APPLICATION_KEY = 'enqueue:throttler:application:application-id';
-const REGISTRATION_KEY =
- 'enqueue:throttler:application-registration:registration-id';
-
-describe('ApplicationJobEnqueueThrottlerService', () => {
- let service: ApplicationJobEnqueueThrottlerService;
- let throttlerService: {
- getAvailableTokensCount: jest.Mock;
- consumeTokens: jest.Mock;
- };
- let metricsService: { incrementCounterForEvent: jest.Mock };
-
- const mockAvailableTokens = (byKey: Record<string, number>) => {
- throttlerService.getAvailableTokensCount.mockImplementation(
- async (key: string) => byKey[key] ?? 0,
- );
- };
-
- beforeEach(async () => {
- throttlerService = {
- getAvailableTokensCount: jest.fn().mockResolvedValue(1000),
- consumeTokens: jest.fn().mockResolvedValue(undefined),
- };
- metricsService = {
- incrementCounterForEvent: jest.fn().mockResolvedValue(undefined),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplicationJobEnqueueThrottlerService,
- { provide: ThrottlerService, useValue: throttlerService },
- { provide: MetricsService, useValue: metricsService },
- {
- provide: TwentyConfigService,
- useValue: {
- get: (key: keyof typeof CONFIG) => CONFIG[key],
- },
- },
- ],
- }).compile();
-
- service = module.get(ApplicationJobEnqueueThrottlerService);
- });
-
- it('debits both application and registration buckets with distinct limits', async () => {
- await service.throttleOrThrow(context);
-
- expect(throttlerService.consumeTokens).toHaveBeenCalledWith(
- APPLICATION_KEY,
- 1,
- CONFIG.APPLICATION_JOB_ENQUEUE_RATE_LIMITING_LIMIT,
- CONFIG.APPLICATION_JOB_ENQUEUE_RATE_LIMITING_TTL_IN_MS,
- );
- expect(throttlerService.consumeTokens).toHaveBeenCalledWith(
- REGISTRATION_KEY,
- 1,
- CONFIG.APPLICATION_REGISTRATION_JOB_ENQUEUE_RATE_LIMITING_LIMIT,
- CONFIG.APPLICATION_JOB_ENQUEUE_RATE_LIMITING_TTL_IN_MS,
- );
- });
-
- it('consumes one token per job for bulk enqueue', async () => {
- await service.throttleOrThrow({ ...context, jobCount: 5 });
-
- expect(throttlerService.consumeTokens).toHaveBeenCalledWith(
- APPLICATION_KEY,
- 5,
- expect.any(Number),
- expect.any(Number),
- );
- });
-
- it('does not debit any bucket when the registration bucket is exhausted', async () => {
- mockAvailableTokens({
- [APPLICATION_KEY]: 1000,
- [REGISTRATION_KEY]: 0,
- });
-
- await expect(service.throttleOrThrow(context)).rejects.toThrow(
- ThrottlerException,
- );
-
- expect(throttlerService.consumeTokens).not.toHaveBeenCalled();
- expect(metricsService.incrementCounterForEvent).toHaveBeenCalledWith(
- expect.objectContaining({
- key: MetricsKeys.JobEnqueueApplicationRateLimited,
- }),
- );
- });
-
- it('does not debit any bucket when the application bucket is exhausted', async () => {
- mockAvailableTokens({
- [APPLICATION_KEY]: 0,
- [REGISTRATION_KEY]: 1000,
- });
-
- await expect(service.throttleOrThrow(context)).rejects.toThrow(
- ThrottlerException,
- );
-
- expect(throttlerService.consumeTokens).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/message-queue/services/__tests__/message-queue-task-assigned.service.spec.ts b/packages/twenty-server/src/engine/core-modules/message-queue/services/__tests__/message-queue-task-assigned.service.spec.ts
deleted file mode 100644
index 5bb2ac4a218..00000000000
--- a/packages/twenty-server/src/engine/core-modules/message-queue/services/__tests__/message-queue-task-assigned.service.spec.ts
+++ /dev/null
@@ -1,46 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type MessageQueueDriver } from 'src/engine/core-modules/message-queue/drivers/interfaces/message-queue-driver.interface';
-
-import {
- QUEUE_DRIVER,
- MessageQueue,
-} from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { MessageQueueService } from 'src/engine/core-modules/message-queue/services/message-queue.service';
-
-describe('MessageQueueTaskAssigned queue', () => {
- let service: MessageQueueService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- {
- provide: MessageQueue.taskAssignedQueue,
- useFactory: (driver: MessageQueueDriver) => {
- return new MessageQueueService(
- driver,
- MessageQueue.taskAssignedQueue,
- );
- },
- inject: [QUEUE_DRIVER],
- },
- {
- provide: QUEUE_DRIVER,
- useValue: {},
- },
- ],
- }).compile();
-
- service = module.get<MessageQueueService>(MessageQueue.taskAssignedQueue);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
- it('should contain the topic and driver', () => {
- expect(service).toEqual({
- driver: {},
- queueName: MessageQueue.taskAssignedQueue,
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/onboarding/onboarding.service.spec.ts b/packages/twenty-server/src/engine/core-modules/onboarding/onboarding.service.spec.ts
deleted file mode 100644
index 5b29f3666c5..00000000000
--- a/packages/twenty-server/src/engine/core-modules/onboarding/onboarding.service.spec.ts
+++ /dev/null
@@ -1,1421 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getDataSourceToken, getRepositoryToken } from '@nestjs/typeorm';
-
-import { WorkspaceActivationStatus } from 'twenty-shared/workspace';
-import {
- type DataSource,
- type EntityManager,
- type QueryRunner,
- Repository,
-} from 'typeorm';
-
-import { BillingCreditGrantType } from 'src/engine/core-modules/billing/enums/billing-credit-grant-type.enum';
-import { BillingCreditService } from 'src/engine/core-modules/billing/services/billing-credit.service';
-import { BillingService } from 'src/engine/core-modules/billing/services/billing.service';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { MessageQueueService } from 'src/engine/core-modules/message-queue/services/message-queue.service';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-import { ONBOARDING_INSTALLABLE_APP_UNIVERSAL_IDENTIFIERS } from 'src/engine/core-modules/onboarding/constants/onboarding-installable-app-universal-identifiers';
-import { OnboardingStatus } from 'src/engine/core-modules/onboarding/enums/onboarding-status.enum';
-import { INSTALL_ONBOARDING_APPS_JOB_NAME } from 'src/engine/core-modules/onboarding/jobs/install-onboarding-apps.job-constants';
-import { OnboardingException } from 'src/engine/core-modules/onboarding/onboarding.exception';
-import {
- OnboardingService,
- OnboardingStepKeys,
-} from 'src/engine/core-modules/onboarding/onboarding.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserVarsService } from 'src/engine/core-modules/user/user-vars/services/user-vars.service';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-describe('OnboardingService', () => {
- let service: OnboardingService;
- let userVarsService: UserVarsService;
- let billingService: BillingService;
- let billingCreditService: BillingCreditService;
- let twentyConfigService: TwentyConfigService;
- let messageQueueService: MessageQueueService;
- let userWorkspaceRepository: Repository<UserWorkspaceEntity>;
- let workspaceRepository: Repository<WorkspaceEntity>;
- let dataSource: DataSource;
-
- const userId = 'user-id';
- const workspaceId = 'workspace-id';
- let mockQueryRunner: QueryRunner;
- let transactionQueryRunner: QueryRunner | undefined;
-
- beforeEach(async () => {
- mockQueryRunner = { query: jest.fn() } as unknown as QueryRunner;
- transactionQueryRunner = mockQueryRunner;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- OnboardingService,
- {
- provide: BillingService,
- useValue: {
- isSubscriptionIncompleteOnboardingStatus: jest.fn(),
- },
- },
- {
- provide: BillingCreditService,
- useValue: {
- grantCredits: jest.fn(),
- },
- },
- {
- provide: UserVarsService,
- useValue: {
- get: jest.fn(),
- getAll: jest.fn().mockResolvedValue(new Map()),
- set: jest.fn(),
- setIfNotExists: jest.fn().mockResolvedValue(true),
- delete: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: {
- countBy: jest.fn(),
- },
- },
- {
- provide: getQueueToken(MessageQueue.workspaceQueue),
- useValue: {
- add: jest.fn(),
- },
- },
- {
- provide: getDataSourceToken(),
- useValue: {
- transaction: jest.fn(
- async (
- runInTransaction: (
- entityManager: EntityManager,
- ) => Promise<unknown>,
- ) =>
- runInTransaction({
- queryRunner: transactionQueryRunner,
- } as EntityManager),
- ),
- },
- },
- ],
- }).compile();
-
- service = module.get<OnboardingService>(OnboardingService);
- userVarsService = module.get<UserVarsService>(UserVarsService);
- billingService = module.get<BillingService>(BillingService);
- workspaceRepository = module.get<Repository<WorkspaceEntity>>(
- getRepositoryToken(WorkspaceEntity),
- );
- billingCreditService =
- module.get<BillingCreditService>(BillingCreditService);
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- messageQueueService = module.get<MessageQueueService>(
- getQueueToken(MessageQueue.workspaceQueue),
- );
- userWorkspaceRepository = module.get<Repository<UserWorkspaceEntity>>(
- getRepositoryToken(UserWorkspaceEntity),
- );
- dataSource = module.get<DataSource>(getDataSourceToken());
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('getOnboardingStatus', () => {
- const user = { id: userId } as UserEntity;
-
- const mockOnboardingState = ({
- pendingSteps,
- isPlanRequired,
- isBookCallStepConfigured = true,
- }: {
- pendingSteps: OnboardingStepKeys[];
- isPlanRequired: boolean;
- isBookCallStepConfigured?: boolean;
- }) => {
- jest.spyOn(workspaceRepository, 'findOne').mockResolvedValue({
- id: workspaceId,
- activationStatus: WorkspaceActivationStatus.ACTIVE,
- } as WorkspaceEntity);
- jest
- .spyOn(userVarsService, 'getAll')
- .mockResolvedValue(
- new Map(pendingSteps.map((key) => [key, true])) as never,
- );
- jest
- .spyOn(billingService, 'isSubscriptionIncompleteOnboardingStatus')
- .mockResolvedValue(isPlanRequired);
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) => {
- if (!isBookCallStepConfigured) {
- return undefined as never;
- }
-
- return (
- key === 'CALENDAR_BOOKING_PAGE_ID' ? 'team/twenty/talk-to-us' : 50
- ) as never;
- });
- };
-
- it('should return BOOK_CALL when the step is pending and a plan is still required', async () => {
- mockOnboardingState({
- pendingSteps: [OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING],
- isPlanRequired: true,
- });
-
- expect(
- await service.getOnboardingStatus({ userId: user.id, workspaceId }),
- ).toBe(OnboardingStatus.BOOK_CALL);
- });
-
- it('should ignore a pending BOOK_CALL once the workspace has a subscription', async () => {
- mockOnboardingState({
- pendingSteps: [OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING],
- isPlanRequired: false,
- });
-
- expect(
- await service.getOnboardingStatus({ userId: user.id, workspaceId }),
- ).toBe(OnboardingStatus.COMPLETED);
- });
-
- it('should ignore a pending BOOK_CALL once the booking page is unconfigured', async () => {
- mockOnboardingState({
- pendingSteps: [OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING],
- isPlanRequired: true,
- isBookCallStepConfigured: false,
- });
-
- expect(
- await service.getOnboardingStatus({ userId: user.id, workspaceId }),
- ).toBe(OnboardingStatus.PLAN_REQUIRED);
- });
-
- it('should keep INVITE_TEAM ahead of a pending BOOK_CALL', async () => {
- mockOnboardingState({
- pendingSteps: [
- OnboardingStepKeys.ONBOARDING_INVITE_TEAM_PENDING,
- OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING,
- ],
- isPlanRequired: true,
- });
-
- expect(
- await service.getOnboardingStatus({ userId: user.id, workspaceId }),
- ).toBe(OnboardingStatus.INVITE_TEAM);
- });
-
- it('should return PLAN_REQUIRED when no step is pending and a plan is required', async () => {
- mockOnboardingState({ pendingSteps: [], isPlanRequired: true });
-
- expect(
- await service.getOnboardingStatus({ userId: user.id, workspaceId }),
- ).toBe(OnboardingStatus.PLAN_REQUIRED);
- });
- });
-
- describe('completeOnboardingConnectAccountStep', () => {
- it('should credit the import-contacts reward when the step was claimed by the first workspace user', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
- jest.spyOn(userWorkspaceRepository, 'countBy').mockResolvedValue(1);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(2_000_000);
-
- await service.completeOnboardingConnectAccountStep({
- userId,
- workspaceId,
- });
-
- expect(userVarsService.delete).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_CONNECT_ACCOUNT_PENDING,
- },
- mockQueryRunner,
- );
- expect(billingCreditService.grantCredits).toHaveBeenCalledWith(
- expect.objectContaining({
- workspaceId,
- amountMicro: 2_000_000,
- type: BillingCreditGrantType.ONBOARDING_REWARD,
- idempotencyKey: `onboarding-import-contacts:${workspaceId}`,
- }),
- );
- });
-
- it('should claim the step but not credit when the workspace has more than one member', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
- jest.spyOn(userWorkspaceRepository, 'countBy').mockResolvedValue(2);
-
- await service.completeOnboardingConnectAccountStep({
- userId,
- workspaceId,
- });
-
- expect(userVarsService.delete).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_CONNECT_ACCOUNT_PENDING,
- },
- mockQueryRunner,
- );
- expect(billingCreditService.grantCredits).not.toHaveBeenCalled();
- });
-
- it('should not credit anything when the step was already consumed', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(0);
-
- await service.completeOnboardingConnectAccountStep({
- userId,
- workspaceId,
- });
-
- expect(billingCreditService.grantCredits).not.toHaveBeenCalled();
- });
-
- it('should credit only once when two completions race for the same step', async () => {
- jest
- .spyOn(userVarsService, 'delete')
- .mockResolvedValueOnce(1)
- .mockResolvedValueOnce(0);
- jest.spyOn(userWorkspaceRepository, 'countBy').mockResolvedValue(1);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(2_000_000);
-
- await Promise.all([
- service.completeOnboardingConnectAccountStep({ userId, workspaceId }),
- service.completeOnboardingConnectAccountStep({ userId, workspaceId }),
- ]);
-
- expect(billingCreditService.grantCredits).toHaveBeenCalledTimes(1);
- });
-
- it('should not throw when crediting fails', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
- jest.spyOn(userWorkspaceRepository, 'countBy').mockResolvedValue(1);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(2_000_000);
- jest
- .spyOn(billingCreditService, 'grantCredits')
- .mockRejectedValue(new Error('billing failure'));
-
- await expect(
- service.completeOnboardingConnectAccountStep({
- userId,
- workspaceId,
- }),
- ).resolves.not.toThrow();
- });
-
- it('should not throw when the workspace member count is unavailable', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
- jest
- .spyOn(userWorkspaceRepository, 'countBy')
- .mockRejectedValue(new Error('database failure'));
-
- await expect(
- service.completeOnboardingConnectAccountStep({
- userId,
- workspaceId,
- }),
- ).resolves.not.toThrow();
-
- expect(billingCreditService.grantCredits).not.toHaveBeenCalled();
- });
- });
-
- describe('triggerInstallAppsOnboardingStep', () => {
- const [callRecorderId, peopleDataLabsId] =
- ONBOARDING_INSTALLABLE_APP_UNIVERSAL_IDENTIFIERS;
-
- it('should claim the step and enqueue the install job for the installable apps without crediting', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [callRecorderId, peopleDataLabsId],
- isAutoSkipped: false,
- });
-
- expect(userVarsService.delete).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_INSTALL_APPS_PENDING,
- },
- mockQueryRunner,
- );
- expect(messageQueueService.add).toHaveBeenCalledWith(
- INSTALL_ONBOARDING_APPS_JOB_NAME,
- {
- workspaceId,
- universalIdentifiers: [callRecorderId, peopleDataLabsId],
- userId,
- },
- { id: `${INSTALL_ONBOARDING_APPS_JOB_NAME}-${workspaceId}` },
- );
- expect(billingCreditService.grantCredits).not.toHaveBeenCalled();
- });
-
- it('should not enqueue anything when the step was already consumed', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(0);
-
- await service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [callRecorderId],
- isAutoSkipped: false,
- });
-
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('should claim the step but not enqueue when no installable app was selected', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: ['00000000-0000-0000-0000-000000000000'],
- isAutoSkipped: false,
- });
-
- expect(userVarsService.delete).toHaveBeenCalled();
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('should record the step as reversible when the user skipped it', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [],
- isAutoSkipped: false,
- });
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [OnboardingStatus.APPS_INSTALLATION],
- },
- mockQueryRunner,
- );
- });
-
- it('should not record the step as reversible when it was auto-skipped', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [],
- isAutoSkipped: true,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should leave clearing the steps to go back to to the install job', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [callRecorderId],
- isAutoSkipped: false,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should clear every step to go back to once the install job runs', async () => {
- await service.clearReversibleOnboardingStepHistoryAfterAppsInstalled({
- userId,
- workspaceId,
- });
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [],
- },
- mockQueryRunner,
- );
- });
-
- it('should keep the steps to go back to when the install job could not be enqueued', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
- jest
- .spyOn(messageQueueService, 'add')
- .mockRejectedValue(new Error('queue unavailable'));
-
- await expect(
- service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [callRecorderId],
- isAutoSkipped: false,
- }),
- ).rejects.toThrow(OnboardingException);
-
- expect(userVarsService.set).not.toHaveBeenCalledWith(
- expect.objectContaining({
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- }),
- expect.anything(),
- );
- });
-
- it('should restore the pending step and throw when enqueuing fails', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
- jest
- .spyOn(messageQueueService, 'add')
- .mockRejectedValue(new Error('queue failure'));
-
- await expect(
- service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [callRecorderId],
- isAutoSkipped: false,
- }),
- ).rejects.toThrow(OnboardingException);
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_INSTALL_APPS_PENDING,
- value: true,
- },
- mockQueryRunner,
- );
- });
-
- it('should let the user retry the step after a failed enqueue', async () => {
- let isInstallAppsStepPending = true;
-
- jest.spyOn(userVarsService, 'delete').mockImplementation(async () => {
- const affectedRows = isInstallAppsStepPending ? 1 : 0;
-
- isInstallAppsStepPending = false;
-
- return affectedRows;
- });
- jest.spyOn(userVarsService, 'set').mockImplementation(async () => {
- isInstallAppsStepPending = true;
- });
- jest
- .spyOn(messageQueueService, 'add')
- .mockRejectedValueOnce(new Error('queue failure'))
- .mockResolvedValueOnce(undefined);
-
- await expect(
- service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [callRecorderId],
- isAutoSkipped: false,
- }),
- ).rejects.toThrow(OnboardingException);
-
- await service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [callRecorderId],
- isAutoSkipped: false,
- });
-
- expect(messageQueueService.add).toHaveBeenCalledTimes(2);
- expect(messageQueueService.add).toHaveBeenLastCalledWith(
- INSTALL_ONBOARDING_APPS_JOB_NAME,
- { workspaceId, universalIdentifiers: [callRecorderId], userId },
- { id: `${INSTALL_ONBOARDING_APPS_JOB_NAME}-${workspaceId}` },
- );
- });
-
- it('should still throw when restoring the pending step fails', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
- jest
- .spyOn(messageQueueService, 'add')
- .mockRejectedValue(new Error('queue failure'));
- jest
- .spyOn(userVarsService, 'set')
- .mockRejectedValue(new Error('database failure'));
-
- await expect(
- service.triggerInstallAppsOnboardingStep({
- userId,
- workspaceId,
- universalIdentifiers: [callRecorderId],
- isAutoSkipped: false,
- }),
- ).rejects.toThrow(OnboardingException);
- });
- });
-
- describe('skipOnboardingConnectAccountStep', () => {
- it('should record the step as reversible when the user skipped it', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.skipOnboardingConnectAccountStep({
- userId,
- workspaceId,
- isAutoSkipped: false,
- });
-
- expect(userVarsService.delete).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_CONNECT_ACCOUNT_PENDING,
- },
- mockQueryRunner,
- );
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [OnboardingStatus.SYNC_EMAIL],
- },
- mockQueryRunner,
- );
- });
-
- it('should not record the step as reversible when it was auto-skipped', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.skipOnboardingConnectAccountStep({
- userId,
- workspaceId,
- isAutoSkipped: true,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should not record the step as reversible when it was already consumed', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(0);
-
- await service.skipOnboardingConnectAccountStep({
- userId,
- workspaceId,
- isAutoSkipped: false,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should clear every step to go back to when it granted the import-contacts reward', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
- jest.spyOn(userWorkspaceRepository, 'countBy').mockResolvedValue(1);
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(2_000_000);
-
- await service.completeOnboardingConnectAccountStep({
- userId,
- workspaceId,
- });
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [],
- },
- mockQueryRunner,
- );
- });
- });
-
- describe('completeOnboardingProfileStepIfNameProvided', () => {
- it('should record the step as reversible when a name was provided', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.completeOnboardingProfileStepIfNameProvided({
- userId,
- workspaceId,
- firstName: 'Ada',
- });
-
- expect(userVarsService.delete).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_CREATE_PROFILE_PENDING,
- },
- mockQueryRunner,
- );
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [OnboardingStatus.PROFILE_CREATION],
- },
- mockQueryRunner,
- );
- });
-
- it('should not record anything when the step was not pending', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(0);
-
- await service.completeOnboardingProfileStepIfNameProvided({
- userId,
- workspaceId,
- firstName: 'Ada',
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should not touch the step when no name part was provided', async () => {
- await service.completeOnboardingProfileStepIfNameProvided({
- userId,
- workspaceId,
- firstName: '',
- lastName: '',
- });
-
- expect(userVarsService.delete).not.toHaveBeenCalled();
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
- });
-
- describe('completeOnboardingBookCallStep', () => {
- it('should record the step as reversible when the user skipped the call', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.completeOnboardingBookCallStep({
- userId,
- workspaceId,
- hasBookedCall: false,
- isAutoSkipped: false,
- });
-
- expect(userVarsService.delete).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING,
- },
- mockQueryRunner,
- );
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [OnboardingStatus.BOOK_CALL],
- },
- mockQueryRunner,
- );
- });
-
- it('should clear every step to go back to when a call was booked', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.completeOnboardingBookCallStep({
- userId,
- workspaceId,
- hasBookedCall: true,
- isAutoSkipped: false,
- });
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [],
- },
- mockQueryRunner,
- );
- });
-
- it('should not record the step as reversible when it was dropped automatically', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.completeOnboardingBookCallStep({
- userId,
- workspaceId,
- hasBookedCall: false,
- isAutoSkipped: true,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should not record the step as reversible when it was already consumed', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(0);
-
- await service.completeOnboardingBookCallStep({
- userId,
- workspaceId,
- hasBookedCall: false,
- isAutoSkipped: false,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
- });
-
- describe('completeOnboardingInviteTeamStep', () => {
- it('should record the step as reversible when no invitation was sent', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.completeOnboardingInviteTeamStep({
- userId,
- workspaceId,
- hasSentInvitations: false,
- });
-
- expect(userVarsService.delete).toHaveBeenCalledWith(
- {
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_INVITE_TEAM_PENDING,
- },
- mockQueryRunner,
- );
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [OnboardingStatus.INVITE_TEAM],
- },
- mockQueryRunner,
- );
- });
-
- it('should clear every step to go back to when invitations were sent', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(1);
-
- await service.completeOnboardingInviteTeamStep({
- userId,
- workspaceId,
- hasSentInvitations: true,
- });
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [],
- },
- mockQueryRunner,
- );
- });
-
- it('should not record the step as reversible when the step was not pending', async () => {
- jest.spyOn(userVarsService, 'delete').mockResolvedValue(0);
-
- await service.completeOnboardingInviteTeamStep({
- userId,
- workspaceId,
- hasSentInvitations: false,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
- });
-
- describe('getPreviousReversibleOnboardingStatus', () => {
- it('should return the last recorded step', async () => {
- jest
- .spyOn(userVarsService, 'get')
- .mockResolvedValue([
- OnboardingStatus.SYNC_EMAIL,
- OnboardingStatus.APPS_INSTALLATION,
- ]);
-
- await expect(
- service.getPreviousReversibleOnboardingStatus({ userId, workspaceId }),
- ).resolves.toBe(OnboardingStatus.APPS_INSTALLATION);
- });
-
- it('should return null when no step was recorded', async () => {
- jest.spyOn(userVarsService, 'get').mockResolvedValue(undefined);
-
- await expect(
- service.getPreviousReversibleOnboardingStatus({ userId, workspaceId }),
- ).resolves.toBeNull();
- });
- });
-
- describe('goBackToPreviousOnboardingStep', () => {
- beforeEach(() => {
- jest.spyOn(workspaceRepository, 'findOne').mockResolvedValue({
- id: workspaceId,
- activationStatus: WorkspaceActivationStatus.ACTIVE,
- } as WorkspaceEntity);
- });
-
- it('should pop the last step, re-arm its pending flag and return the resulting statuses', async () => {
- jest
- .spyOn(userVarsService, 'get')
- .mockResolvedValueOnce([
- OnboardingStatus.SYNC_EMAIL,
- OnboardingStatus.APPS_INSTALLATION,
- ])
- .mockResolvedValue([OnboardingStatus.SYNC_EMAIL]);
- jest
- .spyOn(userVarsService, 'getAll')
- .mockResolvedValue(
- new Map<string, boolean>([
- [OnboardingStepKeys.ONBOARDING_INSTALL_APPS_PENDING, true],
- ]),
- );
-
- const result = await service.goBackToPreviousOnboardingStep({
- userId,
- workspaceId,
- });
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_REVERSIBLE_STEP_HISTORY,
- value: [OnboardingStatus.SYNC_EMAIL],
- },
- mockQueryRunner,
- );
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_INSTALL_APPS_PENDING,
- value: true,
- },
- mockQueryRunner,
- );
- expect(result.onboardingStatus).toBe(OnboardingStatus.APPS_INSTALLATION);
- expect(result.previousOnboardingStatus).toBe(OnboardingStatus.SYNC_EMAIL);
- });
-
- it('should take the step transition lock before reading the history', async () => {
- const lockThenReadCallOrder: string[] = [];
-
- jest
- .spyOn(mockQueryRunner, 'query')
- .mockImplementation(async (statement: string) => {
- lockThenReadCallOrder.push(`query:${statement}`);
-
- return [];
- });
- jest.spyOn(userVarsService, 'get').mockImplementation(async () => {
- lockThenReadCallOrder.push('readHistory');
-
- return [OnboardingStatus.SYNC_EMAIL];
- });
- jest
- .spyOn(userVarsService, 'getAll')
- .mockResolvedValue(
- new Map<string, boolean>([
- [OnboardingStepKeys.ONBOARDING_CONNECT_ACCOUNT_PENDING, true],
- ]),
- );
-
- await service.goBackToPreviousOnboardingStep({ userId, workspaceId });
-
- expect(mockQueryRunner.query).toHaveBeenCalledWith(
- 'SELECT pg_advisory_xact_lock(hashtextextended($1, 0))',
- [`onboarding-step-transition:${userId}:${workspaceId}`],
- );
- expect(lockThenReadCallOrder[0]).toBe(
- 'query:SELECT pg_advisory_xact_lock(hashtextextended($1, 0))',
- );
- expect(lockThenReadCallOrder[1]).toBe('readHistory');
- });
-
- it('should re-arm the invite-team flag for the navigating user only when going back to invite team', async () => {
- jest
- .spyOn(userVarsService, 'get')
- .mockResolvedValueOnce([OnboardingStatus.INVITE_TEAM])
- .mockResolvedValue([]);
- jest
- .spyOn(userVarsService, 'getAll')
- .mockResolvedValue(
- new Map<string, boolean>([
- [OnboardingStepKeys.ONBOARDING_INVITE_TEAM_PENDING, true],
- ]),
- );
-
- const result = await service.goBackToPreviousOnboardingStep({
- userId,
- workspaceId,
- });
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_INVITE_TEAM_PENDING,
- value: true,
- },
- mockQueryRunner,
- );
- expect(result.onboardingStatus).toBe(OnboardingStatus.INVITE_TEAM);
- expect(result.previousOnboardingStatus).toBeNull();
- });
-
- it('should re-arm the book-call step when going back to it', async () => {
- jest
- .spyOn(userVarsService, 'get')
- .mockResolvedValueOnce([OnboardingStatus.BOOK_CALL])
- .mockResolvedValue([]);
- jest
- .spyOn(userVarsService, 'getAll')
- .mockResolvedValue(
- new Map<string, boolean>([
- [OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING, true],
- ]),
- );
- jest
- .spyOn(billingService, 'isSubscriptionIncompleteOnboardingStatus')
- .mockResolvedValue(true);
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation(
- (key: string) =>
- (key === 'CALENDAR_BOOKING_PAGE_ID'
- ? 'team/twenty/talk-to-us'
- : 50) as never,
- );
-
- const result = await service.goBackToPreviousOnboardingStep({
- userId,
- workspaceId,
- });
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING,
- value: true,
- },
- mockQueryRunner,
- );
- expect(result.onboardingStatus).toBe(OnboardingStatus.BOOK_CALL);
- });
-
- it('should throw when there is no recorded step to go back to', async () => {
- jest.spyOn(userVarsService, 'get').mockResolvedValue([]);
-
- await expect(
- service.goBackToPreviousOnboardingStep({ userId, workspaceId }),
- ).rejects.toThrow(OnboardingException);
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
- });
-
- describe('creditInstallAppsReward', () => {
- it('should credit the reward per installed app', async () => {
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(1_000_000);
-
- await service.creditInstallAppsReward({
- workspaceId,
- rewardAppsCount: 2,
- });
-
- expect(billingCreditService.grantCredits).toHaveBeenCalledWith(
- expect.objectContaining({
- workspaceId,
- amountMicro: 2_000_000,
- type: BillingCreditGrantType.ONBOARDING_REWARD,
- idempotencyKey: `onboarding-install-apps:${workspaceId}`,
- }),
- );
- });
-
- it('should not throw when crediting fails', async () => {
- jest.spyOn(twentyConfigService, 'get').mockReturnValue(1_000_000);
- jest
- .spyOn(billingCreditService, 'grantCredits')
- .mockRejectedValue(new Error('billing failure'));
-
- await expect(
- service.creditInstallAppsReward({
- workspaceId,
- rewardAppsCount: 1,
- }),
- ).resolves.not.toThrow();
- });
- });
-
- describe('setOnboardingBookCallPendingIfQualified', () => {
- const mockConfig = ({
- calendarBookingPageId,
- minEmployeeCount,
- }: {
- calendarBookingPageId?: string;
- minEmployeeCount?: number;
- }) => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) =>
- key === 'CALENDAR_BOOKING_PAGE_ID'
- ? calendarBookingPageId
- : minEmployeeCount,
- );
- };
-
- it('should not offer the step twice', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
- jest.spyOn(userVarsService, 'setIfNotExists').mockResolvedValue(false);
-
- const isPending = await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- });
-
- expect(isPending).toBe(false);
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should record the offer so a later enrichment cannot reopen the step', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
-
- const isPending = await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- });
-
- expect(isPending).toBe(true);
- expect(userVarsService.setIfNotExists).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_BOOK_CALL_OFFERED,
- value: true,
- },
- mockQueryRunner,
- );
- });
-
- it('should let only one of two concurrent qualifications flag the step', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
- jest
- .spyOn(userVarsService, 'setIfNotExists')
- .mockResolvedValueOnce(true)
- .mockResolvedValueOnce(false);
-
- await Promise.all([
- service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- }),
- service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- }),
- ]);
-
- expect(userVarsService.set).toHaveBeenCalledTimes(1);
- });
-
- it('should write the offer and the pending step in a single transaction', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
-
- await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- });
-
- const [[, offeredQueryRunner]] = jest.mocked(
- userVarsService.setIfNotExists,
- ).mock.calls;
- const [[, pendingQueryRunner]] = jest.mocked(userVarsService.set).mock
- .calls;
-
- expect(offeredQueryRunner).toBe(mockQueryRunner);
- expect(pendingQueryRunner).toBe(mockQueryRunner);
- });
-
- it('should not record the offer when flagging the step fails', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
- jest
- .spyOn(dataSource, 'transaction')
- .mockRejectedValue(new Error('user vars down'));
-
- await expect(
- service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- }),
- ).resolves.not.toThrow();
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should offer the step again after a failed attempt left nothing behind', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
- jest
- .spyOn(dataSource, 'transaction')
- .mockRejectedValueOnce(new Error('user vars down'));
-
- await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- });
- await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- });
-
- expect(userVarsService.setIfNotExists).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_BOOK_CALL_OFFERED,
- value: true,
- },
- mockQueryRunner,
- );
- });
-
- it('should not throw when the user vars are unavailable', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
- jest
- .spyOn(userVarsService, 'setIfNotExists')
- .mockRejectedValue(new Error('user vars down'));
-
- await expect(
- service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- }),
- ).resolves.toBe(false);
- });
-
- it('should not flag the step when the transaction exposes no query runner', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
- transactionQueryRunner = undefined;
-
- await expect(
- service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 320,
- }),
- ).resolves.toBe(false);
-
- expect(userVarsService.setIfNotExists).not.toHaveBeenCalled();
- });
-
- it('should clear the pending var when the step is completed', async () => {
- await service.setOnboardingBookCallPending({
- userId,
- workspaceId,
- value: false,
- });
-
- expect(userVarsService.delete).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING,
- },
- undefined,
- );
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it.each([50, 51])(
- 'should flag the step when the employee count is %s',
- async (employeeCount) => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
-
- await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount,
- });
-
- expect(userVarsService.set).toHaveBeenCalledWith(
- {
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING,
- value: true,
- },
- mockQueryRunner,
- );
- },
- );
-
- it('should not flag the step below the threshold', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
-
- await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 49,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should not flag the step without an employee count', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
-
- await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: null,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should not flag the step when no threshold is configured', async () => {
- mockConfig({ calendarBookingPageId: 'team/twenty/talk-to-us' });
-
- await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 5000,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should treat a zero threshold as unconfigured', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 0,
- });
-
- await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 5000,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
-
- it('should not flag the step when no booking page is configured', async () => {
- mockConfig({ minEmployeeCount: 50 });
-
- await service.setOnboardingBookCallPendingIfQualified({
- userId,
- workspaceId,
- employeeCount: 5000,
- });
-
- expect(userVarsService.set).not.toHaveBeenCalled();
- });
- });
-
- describe('isOnboardingBookCallPending', () => {
- const mockConfig = ({
- calendarBookingPageId,
- minEmployeeCount,
- }: {
- calendarBookingPageId?: string;
- minEmployeeCount?: number;
- }) => {
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: string) =>
- key === 'CALENDAR_BOOKING_PAGE_ID'
- ? calendarBookingPageId
- : minEmployeeCount,
- );
- };
-
- it('should report the stored pending var', async () => {
- mockConfig({
- calendarBookingPageId: 'team/twenty/talk-to-us',
- minEmployeeCount: 50,
- });
- jest.spyOn(userVarsService, 'get').mockResolvedValue(true);
-
- expect(
- await service.isOnboardingBookCallPending({ userId, workspaceId }),
- ).toBe(true);
- expect(userVarsService.get).toHaveBeenCalledWith({
- userId,
- workspaceId,
- key: OnboardingStepKeys.ONBOARDING_BOOK_CALL_PENDING,
- });
- });
-
- it('should report false without reading the var when the step is unconfigured', async () => {
- mockConfig({ minEmployeeCount: 50 });
-
- expect(
- await service.isOnboardingBookCallPending({ userId, workspaceId }),
- ).toBe(false);
- expect(userVarsService.get).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/open-api/open-api.service.spec.ts b/packages/twenty-server/src/engine/core-modules/open-api/open-api.service.spec.ts
deleted file mode 100644
index ecf8d97703d..00000000000
--- a/packages/twenty-server/src/engine/core-modules/open-api/open-api.service.spec.ts
+++ /dev/null
@@ -1,48 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { AccessTokenService } from 'src/engine/core-modules/auth/token/services/access-token.service';
-import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
-import { OpenApiService } from 'src/engine/core-modules/open-api/open-api.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { ObjectMetadataService } from 'src/engine/metadata-modules/object-metadata/object-metadata.service';
-
-describe('OpenApiService', () => {
- let service: OpenApiService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- OpenApiService,
- {
- provide: AccessTokenService,
- useValue: {},
- },
- {
- provide: ObjectMetadataService,
- useValue: {},
- },
- {
- provide: TwentyConfigService,
- useValue: {},
- },
- {
- provide: FeatureFlagService,
- useValue: {},
- },
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<OpenApiService>(OpenApiService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/record-position/services/__tests__/record-position.service.spec.ts b/packages/twenty-server/src/engine/core-modules/record-position/services/__tests__/record-position.service.spec.ts
deleted file mode 100644
index c883e7763ba..00000000000
--- a/packages/twenty-server/src/engine/core-modules/record-position/services/__tests__/record-position.service.spec.ts
+++ /dev/null
@@ -1,81 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { RecordPositionService } from 'src/engine/core-modules/record-position/services/record-position.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-
-describe('RecordPositionService', () => {
- let globalWorkspaceOrmManager: jest.Mocked<GlobalWorkspaceOrmManager>;
- let mockRepository: any;
- let service: RecordPositionService;
-
- beforeEach(async () => {
- mockRepository = {
- findOneBy: jest.fn(),
- update: jest.fn(),
- minimum: jest.fn().mockResolvedValue(1),
- maximum: jest.fn().mockResolvedValue(1),
- };
-
- globalWorkspaceOrmManager = {
- getRepository: jest.fn().mockResolvedValue(mockRepository),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- } as unknown as jest.Mocked<GlobalWorkspaceOrmManager>;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- RecordPositionService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: globalWorkspaceOrmManager,
- },
- ],
- }).compile();
-
- service = module.get<RecordPositionService>(RecordPositionService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('buildRecordPosition', () => {
- const objectMetadata = { isCustom: false, nameSingular: 'company' };
- const workspaceId = 'workspaceId';
-
- it('should return the value when value is a number', async () => {
- const value = 1;
-
- const result = await service.buildRecordPosition({
- value,
- objectMetadata,
- workspaceId,
- });
-
- expect(result).toEqual(value);
- });
-
- it('should return the existing position -1 when value is first', async () => {
- const value = 'first';
- const result = await service.buildRecordPosition({
- value,
- objectMetadata,
- workspaceId,
- });
-
- expect(result).toEqual(0);
- });
-
- it('should return the existing position + 1 when value is last', async () => {
- const value = 'last';
- const result = await service.buildRecordPosition({
- value,
- objectMetadata,
- workspaceId,
- });
-
- expect(result).toEqual(2);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/sdk-client/__tests__/sdk-client-generation.service.spec.ts b/packages/twenty-server/src/engine/core-modules/sdk-client/__tests__/sdk-client-generation.service.spec.ts
deleted file mode 100644
index 02822f243cd..00000000000
--- a/packages/twenty-server/src/engine/core-modules/sdk-client/__tests__/sdk-client-generation.service.spec.ts
+++ /dev/null
@@ -1,146 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { Repository } from 'typeorm';
-
-import { WorkspaceSchemaFactory } from 'src/engine/api/graphql/workspace-schema.factory';
-import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { FileStorageService } from 'src/engine/core-modules/file-storage/services/file-storage.service';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { MessageQueueService } from 'src/engine/core-modules/message-queue/services/message-queue.service';
-import { MetricsService } from 'src/engine/core-modules/metrics/metrics.service';
-import { GENERATE_SDK_CLIENT_JOB_NAME } from 'src/engine/core-modules/sdk-client/jobs/generate-sdk-client.job-constants';
-import { SdkClientGenerationService } from 'src/engine/core-modules/sdk-client/sdk-client-generation.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { WorkspaceEventBroadcaster } from 'src/engine/subscriptions/workspace-event-broadcaster/workspace-event-broadcaster.service';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-describe('SdkClientGenerationService', () => {
- let service: SdkClientGenerationService;
- let applicationService: jest.Mocked<
- Pick<
- ApplicationService,
- 'findWorkspaceTwentyStandardAndCustomApplicationOrThrow'
- >
- >;
- let messageQueueService: jest.Mocked<Pick<MessageQueueService, 'add'>>;
- let workspaceCacheService: jest.Mocked<
- Pick<WorkspaceCacheService, 'getOrRecompute'>
- >;
-
- beforeEach(async () => {
- applicationService = {
- findWorkspaceTwentyStandardAndCustomApplicationOrThrow: jest.fn(),
- };
- messageQueueService = {
- add: jest.fn().mockResolvedValue(undefined),
- };
- workspaceCacheService = {
- getOrRecompute: jest.fn(),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- SdkClientGenerationService,
- { provide: FileStorageService, useValue: {} },
- {
- provide: getRepositoryToken(ApplicationEntity),
- useValue: {} as Repository<ApplicationEntity>,
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {} as Repository<WorkspaceEntity>,
- },
- { provide: WorkspaceCacheService, useValue: workspaceCacheService },
- { provide: WorkspaceSchemaFactory, useValue: {} },
- { provide: ApplicationService, useValue: applicationService },
- {
- provide: getQueueToken(MessageQueue.workspaceQueue),
- useValue: messageQueueService,
- },
- {
- provide: WorkspaceEventBroadcaster,
- useValue: { broadcast: jest.fn().mockResolvedValue(undefined) },
- },
- {
- provide: MetricsService,
- useValue: {
- incrementCounterBy: jest.fn(),
- recordHistogram: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<SdkClientGenerationService>(
- SdkClientGenerationService,
- );
- });
-
- describe('enqueueSdkClientGenerationForWorkspace', () => {
- const workspaceId = 'workspace-1';
- const apps = {
- twentyStandardFlatApplication: {
- id: 'std-app-id',
- universalIdentifier: 'twenty-standard',
- },
- workspaceCustomFlatApplication: {
- id: 'custom-app-id',
- universalIdentifier: 'workspace-custom',
- },
- };
-
- it('enqueues one job per application with dedup id and retry limit', async () => {
- applicationService.findWorkspaceTwentyStandardAndCustomApplicationOrThrow.mockResolvedValue(
- apps as never,
- );
-
- await service.enqueueSdkClientGenerationForWorkspace(workspaceId);
-
- expect(messageQueueService.add).toHaveBeenCalledTimes(2);
- expect(messageQueueService.add).toHaveBeenNthCalledWith(
- 1,
- GENERATE_SDK_CLIENT_JOB_NAME,
- {
- workspaceId,
- applicationId: 'std-app-id',
- applicationUniversalIdentifier: 'twenty-standard',
- trigger: 'workspace-activation',
- },
- {
- id: `sdk-client:${workspaceId}:std-app-id`,
- retryLimit: 3,
- },
- );
- expect(messageQueueService.add).toHaveBeenNthCalledWith(
- 2,
- GENERATE_SDK_CLIENT_JOB_NAME,
- {
- workspaceId,
- applicationId: 'custom-app-id',
- applicationUniversalIdentifier: 'workspace-custom',
- trigger: 'workspace-activation',
- },
- {
- id: `sdk-client:${workspaceId}:custom-app-id`,
- retryLimit: 3,
- },
- );
- });
-
- it('propagates errors thrown by the message queue service', async () => {
- applicationService.findWorkspaceTwentyStandardAndCustomApplicationOrThrow.mockResolvedValue(
- apps as never,
- );
- const failure = new Error('Redis unavailable');
-
- messageQueueService.add.mockRejectedValueOnce(failure);
-
- await expect(
- service.enqueueSdkClientGenerationForWorkspace(workspaceId),
- ).rejects.toBe(failure);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/search/__tests__/search.service.spec.ts b/packages/twenty-server/src/engine/core-modules/search/__tests__/search.service.spec.ts
deleted file mode 100644
index 9c94094fc2c..00000000000
--- a/packages/twenty-server/src/engine/core-modules/search/__tests__/search.service.spec.ts
+++ /dev/null
@@ -1,499 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { encodeCursorData } from 'src/engine/api/graphql/graphql-query-runner/utils/cursors.util';
-import {
- mockFlatFieldMetadataMaps,
- mockFlatObjectMetadatas,
-} from 'src/engine/core-modules/__mocks__/mockFlatObjectMetadatas';
-import { FileUrlService } from 'src/engine/core-modules/file/file-url/file-url.service';
-import { SearchService } from 'src/engine/core-modules/search/services/search.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-
-describe('SearchService', () => {
- let service: SearchService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- SearchService,
- { provide: GlobalWorkspaceOrmManager, useValue: {} },
- { provide: FileUrlService, useValue: {} },
- {
- provide: TwentyConfigService,
- useValue: {
- get: (key: string) =>
- key === 'SEARCH_ILIKE_FALLBACK_TIMEOUT_MS' ? 500 : false,
- },
- },
- ],
- }).compile();
-
- service = module.get<SearchService>(SearchService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('filterObjectMetadataItems', () => {
- it('should return searchable object metadata items', () => {
- const objectMetadataItems = service.filterObjectMetadataItems({
- flatObjectMetadatas: mockFlatObjectMetadatas,
- includedObjectNameSingulars: [],
- excludedObjectNameSingulars: [],
- });
-
- expect(objectMetadataItems).toEqual([
- mockFlatObjectMetadatas[0],
- mockFlatObjectMetadatas[1],
- mockFlatObjectMetadatas[2],
- ]);
- });
- it('should return searchable object metadata items without excluded ones', () => {
- const objectMetadataItems = service.filterObjectMetadataItems({
- flatObjectMetadatas: mockFlatObjectMetadatas,
- includedObjectNameSingulars: [],
- excludedObjectNameSingulars: ['company'],
- });
-
- expect(objectMetadataItems).toEqual([
- mockFlatObjectMetadatas[0],
- mockFlatObjectMetadatas[2],
- ]);
- });
- it('should return searchable object metadata items with included ones only', () => {
- const objectMetadataItems = service.filterObjectMetadataItems({
- flatObjectMetadatas: mockFlatObjectMetadatas,
- includedObjectNameSingulars: ['company'],
- excludedObjectNameSingulars: [],
- });
-
- expect(objectMetadataItems).toEqual([mockFlatObjectMetadatas[1]]);
- });
- it('should allow non-searchable objects when explicitly included', () => {
- const objectMetadataItems = service.filterObjectMetadataItems({
- flatObjectMetadatas: mockFlatObjectMetadatas,
- includedObjectNameSingulars: ['non-searchable-object'],
- excludedObjectNameSingulars: [],
- });
-
- expect(objectMetadataItems).toEqual([mockFlatObjectMetadatas[3]]);
- });
- it('should block objects with channel visibility constraints even when explicitly included', () => {
- const objectMetadataItems = service.filterObjectMetadataItems({
- flatObjectMetadatas: mockFlatObjectMetadatas,
- includedObjectNameSingulars: ['message'],
- excludedObjectNameSingulars: [],
- });
-
- expect(objectMetadataItems).toEqual([]);
- });
- });
-
- describe('getLabelIdentifierColumns', () => {
- it('should return the two label identifier columns for a person object metadata item', () => {
- const labelIdentifierColumns = service.getLabelIdentifierColumns(
- mockFlatObjectMetadatas[0],
- mockFlatFieldMetadataMaps,
- );
-
- expect(labelIdentifierColumns).toEqual(['nameFirstName', 'nameLastName']);
- });
- it('should return the label identifier column for a regular object metadata item', () => {
- const labelIdentifierColumns = service.getLabelIdentifierColumns(
- mockFlatObjectMetadatas[1],
- mockFlatFieldMetadataMaps,
- );
-
- expect(labelIdentifierColumns).toEqual(['name']);
- });
- });
-
- describe('getImageIdentifierColumns', () => {
- it('should return the FILES image identifier column for a person object metadata item', () => {
- const imageIdentifierColumns = service.getImageIdentifierColumns(
- mockFlatObjectMetadatas[0],
- mockFlatFieldMetadataMaps,
- );
-
- expect(imageIdentifierColumns).toEqual(['avatarFile']);
- });
- it('should select only the primaryLinkUrl column of the composite LINKS image identifier for a company object metadata item', () => {
- const imageIdentifierColumns = service.getImageIdentifierColumns(
- mockFlatObjectMetadatas[1],
- mockFlatFieldMetadataMaps,
- );
-
- expect(imageIdentifierColumns).toEqual(['domainNamePrimaryLinkUrl']);
- });
-
- it('should return the non-composite image identifier column for a regular object metadata item', () => {
- const imageIdentifierColumns = service.getImageIdentifierColumns(
- mockFlatObjectMetadatas[2],
- mockFlatFieldMetadataMaps,
- );
-
- expect(imageIdentifierColumns).toEqual(['imageIdentifierFieldName']);
- });
- });
-
- describe('sortSearchObjectResults', () => {
- it('should sort the search object results by tsRankCD', () => {
- const objectResults = [
- {
- objectNameSingular: 'person',
- objectLabelSingular: 'Person',
- tsRankCD: 2,
- tsRank: 1,
- recordId: '',
- label: '',
- imageUrl: '',
- },
- {
- objectNameSingular: 'company',
- objectLabelSingular: 'Company',
- tsRankCD: 1,
- tsRank: 1,
- recordId: '',
- label: '',
- imageUrl: '',
- },
- {
- objectNameSingular: 'regular-custom-object',
- objectLabelSingular: 'Regular Custom Object',
- tsRankCD: 3,
- tsRank: 1,
- recordId: '',
- label: '',
- imageUrl: '',
- },
- ];
-
- expect(service.sortSearchObjectResults([...objectResults])).toEqual([
- objectResults[2],
- objectResults[0],
- objectResults[1],
- ]);
- });
-
- it('should sort the search object results by tsRank, if tsRankCD is the same', () => {
- const objectResults = [
- {
- objectNameSingular: 'person',
- objectLabelSingular: 'Person',
- tsRankCD: 1,
- tsRank: 1,
- recordId: '',
- label: '',
- imageUrl: '',
- },
- {
- objectNameSingular: 'company',
- objectLabelSingular: 'Company',
- tsRankCD: 1,
- tsRank: 2,
- recordId: '',
- label: '',
- imageUrl: '',
- },
- {
- objectNameSingular: 'regular-custom-object',
- objectLabelSingular: 'Regular Custom Object',
- tsRankCD: 1,
- tsRank: 3,
- recordId: '',
- label: '',
- imageUrl: '',
- },
- ];
-
- expect(service.sortSearchObjectResults([...objectResults])).toEqual([
- objectResults[2],
- objectResults[1],
- objectResults[0],
- ]);
- });
-
- it('should sort the search object results by priority rank, if tsRankCD and tsRank are the same', () => {
- const objectResults = [
- {
- objectNameSingular: 'company',
- objectLabelSingular: 'Company',
- tsRankCD: 1,
- tsRank: 1,
- recordId: '',
- label: '',
- imageUrl: '',
- },
- {
- objectNameSingular: 'person',
- objectLabelSingular: 'Person',
- tsRankCD: 1,
- tsRank: 1,
- recordId: '',
- label: '',
- imageUrl: '',
- },
- {
- objectNameSingular: 'regular-custom-object',
- objectLabelSingular: 'Regular Custom Object',
- tsRankCD: 1,
- tsRank: 1,
- recordId: '',
- label: '',
- imageUrl: '',
- },
- ];
-
- expect(service.sortSearchObjectResults([...objectResults])).toEqual([
- objectResults[1],
- objectResults[0],
- objectResults[2],
- ]);
- });
- });
-
- describe('computeEdges', () => {
- it('should compute edges properly', () => {
- const sortedSlicedRecords = [
- {
- record: {
- objectNameSingular: 'company',
- objectLabelSingular: 'Company',
- tsRankCD: 0.9,
- tsRank: 0.9,
- recordId: 'companyId1',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.9, tsRank: 0.9 },
- lastRecordIdsPerObject: {
- company: 'companyId1',
- },
- }),
- },
- {
- record: {
- objectNameSingular: 'company',
- objectLabelSingular: 'Company',
- tsRankCD: 0.89,
- tsRank: 0.89,
- recordId: 'companyId2',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.89, tsRank: 0.89 },
- lastRecordIdsPerObject: {
- company: 'companyId2',
- },
- }),
- },
- {
- record: {
- objectNameSingular: 'person',
- objectLabelSingular: 'Person',
- tsRankCD: 0.87,
- tsRank: 0.87,
- recordId: 'personId1',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.87, tsRank: 0.87 },
- lastRecordIdsPerObject: {
- company: 'companyId2',
- person: 'personId1',
- },
- }),
- },
- {
- record: {
- objectNameSingular: 'person',
- objectLabelSingular: 'Person',
- tsRankCD: 0.87,
- tsRank: 0.87,
- recordId: 'personId2',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.87, tsRank: 0.87 },
- lastRecordIdsPerObject: {
- company: 'companyId2',
- person: 'personId2',
- },
- }),
- },
- {
- record: {
- objectNameSingular: 'opportunity',
- objectLabelSingular: 'Opportunity',
- tsRankCD: 0.87,
- tsRank: 0.87,
- recordId: 'opportunityId1',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.87, tsRank: 0.87 },
- lastRecordIdsPerObject: {
- company: 'companyId2',
- person: 'personId2',
- opportunity: 'opportunityId1',
- },
- }),
- },
- {
- record: {
- objectNameSingular: 'note',
- objectLabelSingular: 'Note',
- tsRankCD: 0.2,
- tsRank: 0.2,
- recordId: 'noteId1',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.2, tsRank: 0.2 },
- lastRecordIdsPerObject: {
- company: 'companyId2',
- person: 'personId2',
- opportunity: 'opportunityId1',
- note: 'noteId1',
- },
- }),
- },
- {
- record: {
- objectNameSingular: 'company',
- objectLabelSingular: 'Company',
- tsRankCD: 0.1,
- tsRank: 0.1,
- recordId: 'companyId3',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.1, tsRank: 0.1 },
- lastRecordIdsPerObject: {
- company: 'companyId3',
- person: 'personId2',
- opportunity: 'opportunityId1',
- note: 'noteId1',
- },
- }),
- },
- ];
-
- const edges = service.computeEdges({
- sortedRecords: sortedSlicedRecords.map((r) => r.record),
- });
-
- expect(edges.map((e) => e.cursor)).toEqual(
- sortedSlicedRecords.map((r) => r.expectedCursor),
- );
- });
-
- it('should compute pageInfo properly with an input after cursor', () => {
- const sortedSlicedRecords = [
- {
- record: {
- objectNameSingular: 'person',
- objectLabelSingular: 'Person',
- tsRankCD: 0.87,
- tsRank: 0.87,
- recordId: 'personId2',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.87, tsRank: 0.87 },
- lastRecordIdsPerObject: {
- company: 'companyId2',
- person: 'personId2',
- },
- }),
- },
- {
- record: {
- objectNameSingular: 'opportunity',
- objectLabelSingular: 'Opportunity',
- tsRankCD: 0.87,
- tsRank: 0.87,
- recordId: 'opportunityId1',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.87, tsRank: 0.87 },
- lastRecordIdsPerObject: {
- company: 'companyId2',
- person: 'personId2',
- opportunity: 'opportunityId1',
- },
- }),
- },
- {
- record: {
- objectNameSingular: 'note',
- objectLabelSingular: 'Note',
- tsRankCD: 0.2,
- tsRank: 0.2,
- recordId: 'noteId1',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.2, tsRank: 0.2 },
- lastRecordIdsPerObject: {
- company: 'companyId2',
- person: 'personId2',
- opportunity: 'opportunityId1',
- note: 'noteId1',
- },
- }),
- },
- {
- record: {
- objectNameSingular: 'company',
- objectLabelSingular: 'Company',
- tsRankCD: 0.1,
- tsRank: 0.1,
- recordId: 'companyId3',
- label: '',
- imageUrl: '',
- },
- expectedCursor: encodeCursorData({
- lastRanks: { tsRankCD: 0.1, tsRank: 0.1 },
- lastRecordIdsPerObject: {
- company: 'companyId3',
- person: 'personId2',
- opportunity: 'opportunityId1',
- note: 'noteId1',
- },
- }),
- },
- ];
-
- const afterCursor = encodeCursorData({
- lastRanks: { tsRankCD: 0.87, tsRank: 0.87 },
- lastRecordIdsPerObject: {
- company: 'companyId2',
- person: 'personId1',
- },
- });
-
- const edges = service.computeEdges({
- sortedRecords: sortedSlicedRecords.map((r) => r.record),
- after: afterCursor,
- });
-
- expect(edges.map((e) => e.cursor)).toEqual(
- sortedSlicedRecords.map((r) => r.expectedCursor),
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/secret-encryption/secret-encryption.service.spec.ts b/packages/twenty-server/src/engine/core-modules/secret-encryption/secret-encryption.service.spec.ts
deleted file mode 100644
index b50cf9b4608..00000000000
--- a/packages/twenty-server/src/engine/core-modules/secret-encryption/secret-encryption.service.spec.ts
+++ /dev/null
@@ -1,238 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type EncryptedString } from 'src/engine/core-modules/secret-encryption/branded-strings/encrypted-string.type';
-import { type PlaintextString } from 'src/engine/core-modules/secret-encryption/branded-strings/plaintext-string.type';
-import { EnvironmentConfigDriver } from 'src/engine/core-modules/twenty-config/drivers/environment-config.driver';
-
-import { SecretEncryptionService } from './secret-encryption.service';
-
-describe('SecretEncryptionService', () => {
- let service: SecretEncryptionService;
-
- const mockAppSecret = 'mock-app-secret-for-testing-purposes-12345678';
- const testValue = 'my-secret-api-key-123';
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- SecretEncryptionService,
- {
- provide: EnvironmentConfigDriver,
- useValue: {
- get: jest.fn().mockReturnValue(mockAppSecret),
- },
- },
- ],
- }).compile();
-
- service = module.get<SecretEncryptionService>(SecretEncryptionService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('encrypt and decrypt', () => {
- it('should encrypt and decrypt a value correctly', () => {
- const encrypted = service.encrypt(testValue);
- const decrypted = service.decrypt(encrypted);
-
- expect(decrypted).toBe(testValue);
- expect(encrypted).not.toBe(testValue);
- });
-
- it('should generate different encrypted values for the same input (due to random IV)', () => {
- const encrypted1 = service.encrypt(testValue);
- const encrypted2 = service.encrypt(testValue);
-
- expect(encrypted1).not.toBe(encrypted2);
-
- const decrypted1 = service.decrypt(encrypted1);
- const decrypted2 = service.decrypt(encrypted2);
-
- expect(decrypted1).toBe(testValue);
- expect(decrypted2).toBe(testValue);
- });
-
- it('should handle special characters in values', () => {
- const specialValue = 'api-key_WITH@special#chars!123$%^&*()';
-
- const encrypted = service.encrypt(specialValue);
- const decrypted = service.decrypt(encrypted);
-
- expect(decrypted).toBe(specialValue);
- });
-
- it('should handle empty strings', () => {
- const emptyValue = '';
-
- const encrypted = service.encrypt(emptyValue);
- const decrypted = service.decrypt(encrypted);
-
- expect(decrypted).toBe(emptyValue);
- });
-
- it('should handle long values', () => {
- const longValue = 'a'.repeat(1000);
-
- const encrypted = service.encrypt(longValue);
- const decrypted = service.decrypt(encrypted);
-
- expect(decrypted).toBe(longValue);
- });
-
- it('should handle unicode characters', () => {
- const unicodeValue = 'secret-with-émojis-🔐-and-中文';
-
- const encrypted = service.encrypt(unicodeValue);
- const decrypted = service.decrypt(encrypted);
-
- expect(decrypted).toBe(unicodeValue);
- });
- });
-
- describe('encrypt edge cases', () => {
- it('should return undefined values as-is', () => {
- const result = service.encrypt(undefined as unknown as string);
-
- expect(result).toBeUndefined();
- });
-
- it('should return null values as-is', () => {
- const result = service.encrypt(null as unknown as string);
-
- expect(result).toBeNull();
- });
- });
-
- describe('decrypt edge cases', () => {
- it('should return undefined values as-is', () => {
- const result = service.decrypt(undefined as unknown as string);
-
- expect(result).toBeUndefined();
- });
-
- it('should return null values as-is', () => {
- const result = service.decrypt(null as unknown as string);
-
- expect(result).toBeNull();
- });
- });
-
- describe('decryptAndMask', () => {
- const mask = '********';
-
- it('should return undefined values as-is', () => {
- const result = service.decryptAndMask({
- value: undefined as unknown as string,
- mask,
- });
-
- expect(result).toBeUndefined();
- });
-
- it('should return null values as-is', () => {
- const result = service.decryptAndMask({
- value: null as unknown as string,
- mask,
- });
-
- expect(result).toBeNull();
- });
-
- it('should return only mask for short secrets (length <= 10)', () => {
- const shortSecret = 'value';
- const encrypted = service.encrypt(shortSecret);
-
- const result = service.decryptAndMask({ value: encrypted, mask });
-
- // "value" has 5 chars, floor(5/10) = 0, min(5, 0) = 0, slice(0,0) = ""
- expect(result).toBe(mask);
- });
-
- it('should return partial value + mask for medium secrets (10 < length <= 50)', () => {
- const mediumSecret = 'sk-abc123def456';
- const encrypted = service.encrypt(mediumSecret);
-
- const result = service.decryptAndMask({ value: encrypted, mask });
-
- // "sk-abc123def456" has 15 chars, floor(15/10) = 1, min(5, 1) = 1
- expect(result).toBe(`s${mask}`);
- });
-
- it('should return partial value + mask for longer secrets', () => {
- const longerSecret = 'sk-abcdefghij1234567890';
- const encrypted = service.encrypt(longerSecret);
-
- const result = service.decryptAndMask({ value: encrypted, mask });
-
- // "sk-abcdefghij1234567890" has 23 chars, floor(23/10) = 2, min(5, 2) = 2
- expect(result).toBe(`sk${mask}`);
- });
-
- it('should cap visible chars at 5 for very long secrets', () => {
- const veryLongSecret = 'a'.repeat(100);
- const encrypted = service.encrypt(veryLongSecret);
-
- const result = service.decryptAndMask({ value: encrypted, mask });
-
- // 100 chars, floor(100/10) = 10, min(5, 10) = 5
- expect(result).toBe(`aaaaa${mask}`);
- });
-
- it('should handle empty secret values', () => {
- const emptySecret = '';
- const encrypted = service.encrypt(emptySecret);
-
- const result = service.decryptAndMask({ value: encrypted, mask });
-
- // "" has 0 chars, floor(0/10) = 0, min(5, 0) = 0
- expect(result).toBe(mask);
- });
- });
-
- describe('decryptVersionedOrThrow', () => {
- it('round-trips a v2 envelope', () => {
- const secret = 'sk-strict-secret-value';
- const encrypted = service.encryptVersioned(secret as PlaintextString);
-
- expect(service.decryptVersionedOrThrow(encrypted)).toBe(secret);
- });
-
- it('throws on a legacy non-v2 value instead of falling back to CTR', () => {
- const legacyCiphertext = service.encrypt(testValue) as EncryptedString;
-
- expect(() => service.decryptVersionedOrThrow(legacyCiphertext)).toThrow();
- });
-
- it('returns null/undefined values as-is', () => {
- expect(
- service.decryptVersionedOrThrow(null as unknown as EncryptedString),
- ).toBeNull();
- expect(
- service.decryptVersionedOrThrow(
- undefined as unknown as EncryptedString,
- ),
- ).toBeUndefined();
- });
- });
-
- describe('legacyDecryptVersionedWithFallback', () => {
- it('round-trips a v2 envelope', () => {
- const secret = 'sk-legacy-secret-value';
- const encrypted = service.encryptVersioned(secret as PlaintextString);
-
- expect(service.legacyDecryptVersionedWithFallback(encrypted)).toBe(
- secret,
- );
- });
-
- it('falls back to legacy CTR decryption for non-v2 values', () => {
- const legacyCiphertext = service.encrypt(testValue) as EncryptedString;
-
- expect(service.legacyDecryptVersionedWithFallback(legacyCiphertext)).toBe(
- testValue,
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/secure-http-client/__tests__/secure-http-client.service.spec.ts b/packages/twenty-server/src/engine/core-modules/secure-http-client/__tests__/secure-http-client.service.spec.ts
deleted file mode 100644
index 4a691b9eaf1..00000000000
--- a/packages/twenty-server/src/engine/core-modules/secure-http-client/__tests__/secure-http-client.service.spec.ts
+++ /dev/null
@@ -1,409 +0,0 @@
-import * as http from 'http';
-import * as https from 'https';
-
-import axiosRetry from 'axios-retry';
-
-import { SecureHttpClientService } from 'src/engine/core-modules/secure-http-client/secure-http-client.service';
-import { type TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-jest.mock('axios-retry', () => ({
- __esModule: true,
- default: jest.fn(),
-}));
-
-jest.mock('@lifeomic/axios-fetch', () => ({
- buildAxiosFetch: jest.fn(() => jest.fn()),
-}));
-
-import { buildAxiosFetch } from '@lifeomic/axios-fetch';
-
-const mockBuildAxiosFetch = jest.mocked(buildAxiosFetch);
-
-jest.mock(
- 'src/engine/core-modules/secure-http-client/utils/resolve-and-validate-hostname.util',
- () => ({
- resolveAndValidateHostname: jest.fn(),
- }),
-);
-
-import { resolveAndValidateHostname } from 'src/engine/core-modules/secure-http-client/utils/resolve-and-validate-hostname.util';
-
-const mockResolveAndValidate = jest.mocked(resolveAndValidateHostname);
-
-const createMockConfigService = (
- overrides: Record<string, unknown> = {},
-): TwentyConfigService => {
- const defaults: Record<string, unknown> = {
- OUTBOUND_HTTP_SAFE_MODE_ENABLED: false,
- };
- const config = { ...defaults, ...overrides };
-
- return {
- get: jest.fn((key: string) => config[key]),
- } as unknown as TwentyConfigService;
-};
-
-describe('SecureHttpClientService', () => {
- describe('getHttpClient', () => {
- it('should return a plain axios instance when safe mode is off', () => {
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getHttpClient();
-
- expect(client).toBeDefined();
- expect(client.defaults.httpAgent).toBeUndefined();
- expect(client.defaults.httpsAgent).toBeUndefined();
- });
-
- it('should return an axios instance with SSRF-safe agents when safe mode is on', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getHttpClient();
-
- expect(client).toBeDefined();
- expect(client.defaults.httpAgent).toBeInstanceOf(http.Agent);
- expect(client.defaults.httpsAgent).toBeInstanceOf(https.Agent);
- });
-
- it('should default maxRedirects to 5 when safe mode is on', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getHttpClient();
-
- expect(client.defaults.maxRedirects).toBe(5);
- });
-
- it('should cap maxRedirects when caller requests more', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getHttpClient({ maxRedirects: 100 });
-
- expect(client.defaults.maxRedirects).toBe(5);
- });
-
- it('should respect caller maxRedirects when lower than cap', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getHttpClient({ maxRedirects: 2 });
-
- expect(client.defaults.maxRedirects).toBe(2);
- });
-
- it('should not set maxRedirects when safe mode is off', () => {
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getHttpClient();
-
- expect(client.defaults.maxRedirects).toBeUndefined();
- });
-
- it('should pass through axios config like baseURL', () => {
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getHttpClient({
- baseURL: 'https://example.com/api',
- });
-
- expect(client.defaults.baseURL).toBe('https://example.com/api');
- });
-
- it('should configure axios-retry when retries is greater than 0', () => {
- jest.mocked(axiosRetry).mockClear();
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getHttpClient({
- retries: 2,
- shouldResetTimeout: true,
- });
-
- expect(axiosRetry).toHaveBeenCalledWith(client, {
- retries: 2,
- shouldResetTimeout: true,
- retryCondition: expect.any(Function),
- });
- });
-
- it('should not configure axios-retry when retries is 0', () => {
- jest.mocked(axiosRetry).mockClear();
- const service = new SecureHttpClientService(createMockConfigService());
-
- service.getHttpClient({ retries: 0 });
-
- expect(axiosRetry).not.toHaveBeenCalled();
- });
-
- it('should not leak retry config into axios defaults', () => {
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getHttpClient({
- retries: 2,
- shouldResetTimeout: true,
- baseURL: 'https://example.com',
- });
-
- expect(client.defaults.baseURL).toBe('https://example.com');
- expect(client.defaults).not.toHaveProperty('retries');
- expect(client.defaults).not.toHaveProperty('shouldResetTimeout');
- });
- });
-
- describe('getInternalHttpClient', () => {
- it('should return a plain axios instance regardless of safe mode', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getInternalHttpClient();
-
- expect(client).toBeDefined();
- });
-
- it('should pass through axios config like baseURL', () => {
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getInternalHttpClient({
- baseURL: 'http://localhost:3000',
- });
-
- expect(client.defaults.baseURL).toBe('http://localhost:3000');
- });
- });
-
- describe('protocol validation interceptor', () => {
- it('should allow http URLs when safe mode is on', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getHttpClient();
-
- const interceptorHandlers = (
- client.interceptors.request as unknown as {
- handlers: Array<{ fulfilled: Function }>;
- }
- ).handlers;
-
- const protocolInterceptor = interceptorHandlers[0].fulfilled;
-
- expect(() =>
- protocolInterceptor({ url: 'http://example.com/api' }),
- ).not.toThrow();
- });
-
- it('should allow https URLs when safe mode is on', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getHttpClient();
-
- const interceptorHandlers = (
- client.interceptors.request as unknown as {
- handlers: Array<{ fulfilled: Function }>;
- }
- ).handlers;
-
- const protocolInterceptor = interceptorHandlers[0].fulfilled;
-
- expect(() =>
- protocolInterceptor({ url: 'https://example.com/api' }),
- ).not.toThrow();
- });
-
- it('should reject ftp URLs when safe mode is on', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getHttpClient();
-
- const interceptorHandlers = (
- client.interceptors.request as unknown as {
- handlers: Array<{ fulfilled: Function }>;
- }
- ).handlers;
-
- const protocolInterceptor = interceptorHandlers[0].fulfilled;
-
- expect(() =>
- protocolInterceptor({ url: 'ftp://internal-server/data' }),
- ).toThrow('Protocol ftp: is not allowed');
- });
-
- it('should reject file URLs when safe mode is on', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getHttpClient();
-
- const interceptorHandlers = (
- client.interceptors.request as unknown as {
- handlers: Array<{ fulfilled: Function }>;
- }
- ).handlers;
-
- const protocolInterceptor = interceptorHandlers[0].fulfilled;
-
- expect(() => protocolInterceptor({ url: 'file:///etc/passwd' })).toThrow(
- 'Protocol file: is not allowed',
- );
- });
-
- it('should reject non-http baseURL when url is empty string', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
- const client = service.getHttpClient();
-
- const interceptorHandlers = (
- client.interceptors.request as unknown as {
- handlers: Array<{ fulfilled: Function }>;
- }
- ).handlers;
-
- const protocolInterceptor = interceptorHandlers[0].fulfilled;
-
- expect(() =>
- protocolInterceptor({
- url: '',
- baseURL: 'ftp://internal-server/data',
- }),
- ).toThrow('Protocol ftp: is not allowed');
- });
-
- it('should not add protocol interceptor when safe mode is off', () => {
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getHttpClient();
-
- const interceptorHandlers = (
- client.interceptors.request as unknown as {
- handlers: Array<{ fulfilled: Function }>;
- }
- ).handlers;
-
- expect(interceptorHandlers.length).toBe(0);
- });
- });
-
- describe('getValidatedHost', () => {
- it('should return the original hostname when safe mode is off', async () => {
- const service = new SecureHttpClientService(createMockConfigService());
-
- const result = await service.getValidatedHost(
- 'https://caldav.icloud.com/principals/',
- );
-
- expect(result).toBe('https://caldav.icloud.com/principals/');
- expect(mockResolveAndValidate).not.toHaveBeenCalled();
- });
-
- it('should validate and return resolved IP when safe mode is on', async () => {
- mockResolveAndValidate.mockResolvedValue('17.248.239.66');
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
-
- const result = await service.getValidatedHost(
- 'https://caldav.icloud.com/principals/',
- );
-
- expect(mockResolveAndValidate).toHaveBeenCalledWith(
- 'https://caldav.icloud.com/principals/',
- );
- expect(result).toBe('17.248.239.66');
- });
-
- it('should throw when hostname resolves to a private IP', async () => {
- mockResolveAndValidate.mockRejectedValue(
- new Error(
- 'Connection to internal IP address 192.168.1.1 is not allowed.',
- ),
- );
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
-
- await expect(
- service.getValidatedHost('https://my-local-server.local/'),
- ).rejects.toThrow('internal IP address');
- });
- });
-
- describe('createSsrfSafeFetch', () => {
- beforeEach(() => {
- mockBuildAxiosFetch.mockClear();
- });
-
- it('should return globalThis.fetch when safe mode is off', () => {
- const service = new SecureHttpClientService(createMockConfigService());
-
- const result = service.createSsrfSafeFetch();
-
- expect(result).toBe(globalThis.fetch);
- expect(mockBuildAxiosFetch).not.toHaveBeenCalled();
- });
-
- it('should wrap an SSRF-protected axios client when safe mode is on', () => {
- const service = new SecureHttpClientService(
- createMockConfigService({ OUTBOUND_HTTP_SAFE_MODE_ENABLED: true }),
- );
-
- service.createSsrfSafeFetch();
-
- expect(mockBuildAxiosFetch).toHaveBeenCalledTimes(1);
- const axiosClient = mockBuildAxiosFetch.mock.calls[0][0] as ReturnType<
- SecureHttpClientService['getHttpClient']
- >;
-
- expect(axiosClient.defaults.httpAgent).toBeInstanceOf(http.Agent);
- expect(axiosClient.defaults.httpsAgent).toBeInstanceOf(https.Agent);
- });
- });
-
- describe('logging interceptor', () => {
- it('should add a request interceptor when context is provided', () => {
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getHttpClient(undefined, {
- workspaceId: 'ws-123',
- source: 'webhook',
- });
-
- const interceptorHandlers = (
- client.interceptors.request as unknown as {
- handlers: Array<{ fulfilled: Function }>;
- }
- ).handlers;
-
- expect(interceptorHandlers.length).toBe(1);
- });
-
- it('should not add a request interceptor when context is not provided', () => {
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getHttpClient();
-
- const interceptorHandlers = (
- client.interceptors.request as unknown as {
- handlers: Array<{ fulfilled: Function }>;
- }
- ).handlers;
-
- expect(interceptorHandlers.length).toBe(0);
- });
-
- it('should pass config through the interceptor and return it', () => {
- const service = new SecureHttpClientService(createMockConfigService());
- const client = service.getHttpClient(undefined, {
- workspaceId: 'ws-456',
- source: 'workflow-http',
- userId: 'user-789',
- });
-
- const interceptorHandlers = (
- client.interceptors.request as unknown as {
- handlers: Array<{ fulfilled: Function }>;
- }
- ).handlers;
-
- const interceptorFn = interceptorHandlers[0].fulfilled;
- const mockConfig = { method: 'GET', url: 'https://example.com/api' };
-
- const result = interceptorFn(mockConfig);
-
- expect(result).toBe(mockConfig);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/server-route-trigger/__tests__/server-route-trigger.service.spec.ts b/packages/twenty-server/src/engine/core-modules/server-route-trigger/__tests__/server-route-trigger.service.spec.ts
deleted file mode 100644
index 72a0b748bf1..00000000000
--- a/packages/twenty-server/src/engine/core-modules/server-route-trigger/__tests__/server-route-trigger.service.spec.ts
+++ /dev/null
@@ -1,354 +0,0 @@
-import { type Request } from 'express';
-import { LOGIC_FUNCTION_HTTP_RESPONSE_MARKER } from 'twenty-shared/types';
-import { type Repository } from 'typeorm';
-
-import { type LogicFunctionExecuteResult } from 'src/engine/core-modules/logic-function/logic-function-drivers/interfaces/logic-function-driver.interface';
-import {
- LogicFunctionExecutionException,
- LogicFunctionExecutionExceptionCode,
- type LogicFunctionExecutorService,
-} from 'src/engine/core-modules/logic-function/logic-function-executor/logic-function-executor.service';
-import { LogicFunctionTriggerJob } from 'src/engine/core-modules/logic-function/logic-function-trigger/jobs/logic-function-trigger.job';
-import { type MessageQueueService } from 'src/engine/core-modules/message-queue/services/message-queue.service';
-import { ServerRouteTriggerExceptionCode } from 'src/engine/core-modules/server-route-trigger/exceptions/server-route-trigger.exception';
-import { ServerRouteTriggerService } from 'src/engine/core-modules/server-route-trigger/server-route-trigger.service';
-import { type LogicFunctionEntity } from 'src/engine/metadata-modules/logic-function/logic-function.entity';
-import {
- LogicFunctionException,
- LogicFunctionExceptionCode,
-} from 'src/engine/metadata-modules/logic-function/logic-function.exception';
-import { LogicFunctionExecutionStatus } from 'src/engine/metadata-modules/logic-function/dtos/logic-function-execution-result.dto';
-
-const RESOLVER_UID = 'b3c2f0a1-7d4e-4c9a-9f2b-2e1d6a4c8e10';
-const TARGET_UID = 'c4e2a9b1-7d4e-4c9a-9f2b-2e1d6a4c8e10';
-const TARGET_WORKSPACE_ID = '20202020-1c25-4d02-bf25-6aeccf7ea419';
-
-const buildExecuteResult = (
- data: object | null,
- error?: { errorMessage: string },
-): LogicFunctionExecuteResult => ({
- data,
- duration: 1,
- logs: '',
- status: error
- ? LogicFunctionExecutionStatus.ERROR
- : LogicFunctionExecutionStatus.SUCCESS,
- ...(error
- ? {
- error: {
- errorType: 'Error',
- errorMessage: error.errorMessage,
- stackTrace: '',
- },
- }
- : {}),
-});
-
-const buildRequest = (body: object | null = {}): Request =>
- ({
- method: 'POST',
- path: `/webhooks/server/${RESOLVER_UID}`,
- query: {},
- headers: {},
- rawBody: Buffer.from(JSON.stringify(body ?? {}), 'utf-8'),
- body,
- }) as unknown as Request;
-
-type QueryBuilderMock = {
- innerJoinAndSelect: jest.Mock;
- where: jest.Mock;
- andWhere: jest.Mock;
- getOne: jest.Mock;
-};
-
-const buildResolverRow = () => ({
- id: 'resolver-id',
- universalIdentifier: RESOLVER_UID,
- workspaceId: 'owner-ws',
- serverRouteTriggerSettings: { forwardedRequestHeaders: ['x-test'] },
- application: {
- applicationRegistration: { id: 'reg-1', ownerWorkspaceId: 'owner-ws' },
- },
-});
-
-describe('ServerRouteTriggerService', () => {
- let service: ServerRouteTriggerService;
- let logicFunctionRepository: {
- createQueryBuilder: jest.Mock;
- findOne: jest.Mock;
- };
- let logicFunctionExecutorService: jest.Mocked<
- Pick<LogicFunctionExecutorService, 'execute'>
- >;
- let messageQueueService: jest.Mocked<Pick<MessageQueueService, 'add'>>;
-
- let resolverRow: unknown;
- let queryBuilder: QueryBuilderMock;
-
- const buildQueryBuilderMock = (): QueryBuilderMock => {
- const qb: QueryBuilderMock = {
- innerJoinAndSelect: jest.fn(() => qb),
- where: jest.fn(() => qb),
- andWhere: jest.fn(() => qb),
- getOne: jest.fn(() => Promise.resolve(resolverRow)),
- };
-
- return qb;
- };
-
- const handle = () =>
- service.handle({
- request: buildRequest(),
- resolverLogicFunctionUniversalIdentifier: RESOLVER_UID,
- });
-
- beforeEach(() => {
- resolverRow = buildResolverRow();
- queryBuilder = buildQueryBuilderMock();
-
- logicFunctionRepository = {
- createQueryBuilder: jest.fn(() => queryBuilder),
- findOne: jest
- .fn()
- // resolver lookup
- .mockResolvedValueOnce({ id: 'resolver-id' })
- // target lookup before enqueueing
- .mockResolvedValueOnce({ id: 'target-id' }),
- };
- logicFunctionExecutorService = {
- execute: jest.fn().mockResolvedValueOnce(
- buildExecuteResult({
- workspaceId: TARGET_WORKSPACE_ID,
- targetLogicFunctionUniversalIdentifier: TARGET_UID,
- payload: { from: 'resolver' },
- }),
- ),
- };
-
- messageQueueService = {
- add: jest.fn().mockResolvedValue(undefined),
- };
-
- service = new ServerRouteTriggerService(
- logicFunctionRepository as unknown as Repository<LogicFunctionEntity>,
- logicFunctionExecutorService as unknown as LogicFunctionExecutorService,
- messageQueueService as unknown as MessageQueueService,
- );
- });
-
- it('runs the resolver synchronously, enqueues the target, and acks with 202', async () => {
- const result = await handle();
-
- expect(logicFunctionExecutorService.execute).toHaveBeenCalledTimes(1);
- expect(logicFunctionExecutorService.execute).toHaveBeenCalledWith(
- expect.objectContaining({
- logicFunctionId: 'resolver-id',
- workspaceId: 'owner-ws',
- }),
- );
- expect(messageQueueService.add).toHaveBeenCalledWith(
- LogicFunctionTriggerJob.name,
- {
- logicFunctionId: 'target-id',
- workspaceId: TARGET_WORKSPACE_ID,
- payload: { from: 'resolver' },
- },
- { retryLimit: 3 },
- );
- expect(result).toEqual(
- expect.objectContaining({
- statusCode: 202,
- body: { queued: true },
- }),
- );
- });
-
- it('queries the resolver by universalIdentifier and joins the application registration chain', async () => {
- await handle();
-
- expect(logicFunctionRepository.createQueryBuilder).toHaveBeenCalledWith(
- 'logicFunction',
- );
- expect(queryBuilder.innerJoinAndSelect).toHaveBeenCalledWith(
- 'logicFunction.application',
- 'application',
- );
- expect(queryBuilder.innerJoinAndSelect).toHaveBeenCalledWith(
- 'application.applicationRegistration',
- 'applicationRegistration',
- );
- expect(queryBuilder.where).toHaveBeenCalledWith(
- 'logicFunction.universalIdentifier = :universalIdentifier',
- { universalIdentifier: RESOLVER_UID },
- );
- });
-
- it('restricts the resolver query to server-route-exposed, owner-workspace functions', async () => {
- await handle();
-
- expect(queryBuilder.andWhere).toHaveBeenCalledWith(
- 'logicFunction.serverRouteTriggerSettings IS NOT NULL',
- );
- expect(queryBuilder.andWhere).toHaveBeenCalledWith(
- 'logicFunction.workspaceId = applicationRegistration.ownerWorkspaceId',
- );
- });
-
- it('scopes the target lookup to the resolver application registration', async () => {
- await handle();
-
- expect(logicFunctionRepository.findOne).toHaveBeenNthCalledWith(
- 2,
- expect.objectContaining({
- where: expect.objectContaining({
- universalIdentifier: TARGET_UID,
- workspaceId: TARGET_WORKSPACE_ID,
- application: { applicationRegistrationId: 'reg-1' },
- }),
- }),
- );
- });
-
- it('throws LOGIC_FUNCTION_NOT_FOUND and executes nothing when the query returns no server-route resolver', async () => {
- resolverRow = null;
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.LOGIC_FUNCTION_NOT_FOUND,
- });
- expect(logicFunctionExecutorService.execute).not.toHaveBeenCalled();
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('rejects and executes nothing when the resolver requires authentication', async () => {
- resolverRow = {
- ...buildResolverRow(),
- httpRouteTriggerSettings: { isAuthRequired: true },
- };
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.RESOLVER_REQUIRES_AUTHENTICATION,
- });
- expect(logicFunctionExecutorService.execute).not.toHaveBeenCalled();
- });
-
- it('answers the caller directly and enqueues nothing when the resolver returns an http response', async () => {
- logicFunctionExecutorService.execute.mockReset();
- logicFunctionExecutorService.execute.mockResolvedValueOnce(
- buildExecuteResult({
- [LOGIC_FUNCTION_HTTP_RESPONSE_MARKER]: true,
- status: 200,
- body: { challenge: 'abc123' },
- }),
- );
-
- const result = await handle();
-
- expect(result).toEqual({
- statusCode: 200,
- headers: {},
- body: { challenge: 'abc123' },
- });
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('throws RESOLVER_INVALID_RESULT when the resolver does not return a workspaceId', async () => {
- logicFunctionExecutorService.execute.mockReset();
- logicFunctionExecutorService.execute.mockResolvedValueOnce(
- buildExecuteResult({
- targetLogicFunctionUniversalIdentifier: TARGET_UID,
- }),
- );
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.RESOLVER_INVALID_RESULT,
- });
- });
-
- it('throws RESOLVER_INVALID_RESULT when the resolver does not return a targetLogicFunctionUniversalIdentifier', async () => {
- logicFunctionExecutorService.execute.mockReset();
- logicFunctionExecutorService.execute.mockResolvedValueOnce(
- buildExecuteResult({ workspaceId: TARGET_WORKSPACE_ID }),
- );
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.RESOLVER_INVALID_RESULT,
- });
- });
-
- it('throws USER_UNCAUGHT_ERROR when the resolver returns an error', async () => {
- logicFunctionExecutorService.execute.mockReset();
- logicFunctionExecutorService.execute.mockResolvedValueOnce(
- buildExecuteResult(null, { errorMessage: 'boom' }),
- );
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.SERVER_ROUTE_USER_UNCAUGHT_ERROR,
- });
- });
-
- it('throws LOGIC_FUNCTION_NOT_FOUND and enqueues nothing when the target is missing', async () => {
- logicFunctionRepository.findOne.mockReset();
- logicFunctionRepository.findOne
- .mockResolvedValueOnce({ id: 'resolver-id' })
- .mockResolvedValueOnce(null);
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.LOGIC_FUNCTION_NOT_FOUND,
- });
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('maps a LogicFunctionExecutionException(LOGIC_FUNCTION_NOT_FOUND) to the server-route not-found code', async () => {
- logicFunctionExecutorService.execute.mockReset();
- logicFunctionExecutorService.execute.mockRejectedValue(
- new LogicFunctionExecutionException(
- 'not found',
- LogicFunctionExecutionExceptionCode.LOGIC_FUNCTION_NOT_FOUND,
- ),
- );
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.LOGIC_FUNCTION_NOT_FOUND,
- });
- });
-
- it('maps a LogicFunctionExecutionException(RATE_LIMIT_EXCEEDED) to the server-route rate-limit code', async () => {
- logicFunctionExecutorService.execute.mockReset();
- logicFunctionExecutorService.execute.mockRejectedValue(
- new LogicFunctionExecutionException(
- 'too many requests',
- LogicFunctionExecutionExceptionCode.RATE_LIMIT_EXCEEDED,
- ),
- );
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.RATE_LIMIT_EXCEEDED,
- });
- });
-
- it('maps a LogicFunctionException(LOGIC_FUNCTION_DISABLED) to the server-route disabled code', async () => {
- logicFunctionExecutorService.execute.mockReset();
- logicFunctionExecutorService.execute.mockRejectedValue(
- new LogicFunctionException(
- 'application is stopped',
- LogicFunctionExceptionCode.LOGIC_FUNCTION_DISABLED,
- ),
- );
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.LOGIC_FUNCTION_DISABLED,
- });
- });
-
- it('does not leak the raw resolver executor error message to the caller', async () => {
- logicFunctionExecutorService.execute.mockReset();
- logicFunctionExecutorService.execute.mockRejectedValue(
- new Error('internal: connection to lambda-internal:5000 refused'),
- );
-
- await expect(handle()).rejects.toMatchObject({
- code: ServerRouteTriggerExceptionCode.SERVER_ROUTE_PLATFORM_ERROR,
- message: 'An unexpected error occurred while handling the server route',
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/sso/services/sso.service.spec.ts b/packages/twenty-server/src/engine/core-modules/sso/services/sso.service.spec.ts
deleted file mode 100644
index 071919717fe..00000000000
--- a/packages/twenty-server/src/engine/core-modules/sso/services/sso.service.spec.ts
+++ /dev/null
@@ -1,209 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { Repository } from 'typeorm';
-
-import { BillingService } from 'src/engine/core-modules/billing/services/billing.service';
-import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
-import { SSOService } from 'src/engine/core-modules/sso/services/sso.service';
-import { SSOException } from 'src/engine/core-modules/sso/sso.exception';
-import { WorkspaceSSOIdentityProviderEntity } from 'src/engine/core-modules/sso/workspace-sso-identity-provider.entity';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-
-describe('SSOService', () => {
- let service: SSOService;
- let repository: Repository<WorkspaceSSOIdentityProviderEntity>;
- let billingService: BillingService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- SSOService,
- {
- provide: getRepositoryToken(WorkspaceSSOIdentityProviderEntity),
- useClass: Repository,
- },
- {
- provide: BillingService,
- useValue: {
- hasEntitlement: jest.fn(),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: ExceptionHandlerService,
- useValue: {
- captureExceptions: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<SSOService>(SSOService);
- repository = module.get<Repository<WorkspaceSSOIdentityProviderEntity>>(
- getRepositoryToken(WorkspaceSSOIdentityProviderEntity),
- );
- billingService = module.get<BillingService>(BillingService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('createOIDCIdentityProvider', () => {
- it('should create an OIDC identity provider successfully', async () => {
- const workspaceId = 'workspace-123';
- const data = {
- issuer: 'https://example.com',
- clientID: 'client-id',
- clientSecret: 'client-secret',
- name: 'Test Provider',
- };
- const mockIssuer = { metadata: { issuer: 'https://example.com' } };
- const mockSavedProvider = {
- id: 'provider-123',
- type: 'OIDC',
- name: 'Test Provider',
- status: 'ACTIVE',
- issuer: 'https://example.com',
- };
-
- jest.spyOn(billingService, 'hasEntitlement').mockResolvedValue(true);
- jest
- .spyOn(service as any, 'getIssuerForOIDC')
- .mockResolvedValue(mockIssuer);
- jest
- .spyOn(repository, 'save')
- .mockResolvedValue(mockSavedProvider as any);
-
- const result = await service.createOIDCIdentityProvider(
- data,
- workspaceId,
- );
-
- expect(result).toEqual({
- id: 'provider-123',
- type: 'OIDC',
- name: 'Test Provider',
- status: 'ACTIVE',
- issuer: 'https://example.com',
- });
-
- expect(billingService.hasEntitlement).toHaveBeenCalledWith(
- workspaceId,
- 'SSO',
- );
- expect(repository.save).toHaveBeenCalledWith({
- type: 'OIDC',
- clientID: 'client-id',
- clientSecret: 'client-secret',
- issuer: 'https://example.com',
- name: 'Test Provider',
- workspaceId,
- });
- });
-
- it('should throw an exception when SSO is disabled', async () => {
- const workspaceId = 'workspace-123';
- const data = {
- issuer: 'https://example.com',
- clientID: 'client-id',
- clientSecret: 'client-secret',
- name: 'Test Provider',
- };
-
- jest.spyOn(billingService, 'hasEntitlement').mockResolvedValue(false);
-
- const result = await service.createOIDCIdentityProvider(
- data,
- workspaceId,
- );
-
- expect(result).toBeInstanceOf(SSOException);
- });
- });
-
- describe('deleteSSOIdentityProvider', () => {
- it('should delete the identity provider successfully', async () => {
- const identityProviderId = 'provider-123';
- const workspaceId = 'workspace-123';
- const mockProvider = { id: identityProviderId };
-
- jest.spyOn(repository, 'findOne').mockResolvedValue(mockProvider as any);
- jest.spyOn(repository, 'delete').mockResolvedValue(null as any);
-
- const result = await service.deleteSSOIdentityProvider(
- identityProviderId,
- workspaceId,
- );
-
- expect(result).toEqual({ identityProviderId: 'provider-123' });
- expect(repository.findOne).toHaveBeenCalledWith({
- where: { id: identityProviderId, workspaceId },
- });
- expect(repository.delete).toHaveBeenCalledWith({
- id: identityProviderId,
- });
- });
-
- it('should throw an exception if the identity provider does not exist', async () => {
- const identityProviderId = 'provider-123';
- const workspaceId = 'workspace-123';
-
- jest.spyOn(repository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.deleteSSOIdentityProvider(identityProviderId, workspaceId),
- ).rejects.toThrow(SSOException);
- });
- });
-
- describe('getAuthorizationUrlForSSO', () => {
- it('should return an authorization URL', async () => {
- const identityProviderId = 'provider-123';
- const searchParams = { client: 'web' };
- const mockIdentityProvider = {
- id: 'provider-123',
- type: 'OIDC',
- };
-
- jest
- .spyOn(repository, 'findOne')
- .mockResolvedValue(mockIdentityProvider as any);
- jest
- .spyOn(service as any, 'buildIssuerURL')
- .mockReturnValue('https://example.com/auth');
-
- const result = await service.getAuthorizationUrlForSSO(
- identityProviderId,
- searchParams,
- );
-
- expect(result).toEqual({
- id: 'provider-123',
- authorizationURL: 'https://example.com/auth',
- type: 'OIDC',
- });
-
- expect(repository.findOne).toHaveBeenCalledWith({
- where: { id: identityProviderId },
- });
- });
-
- it('should throw an exception if the identity provider is not found', async () => {
- const identityProviderId = 'provider-123';
- const searchParams = {};
-
- jest.spyOn(repository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.getAuthorizationUrlForSSO(identityProviderId, searchParams),
- ).rejects.toThrow(SSOException);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/throttler/throttler.service.spec.ts b/packages/twenty-server/src/engine/core-modules/throttler/throttler.service.spec.ts
deleted file mode 100644
index e8305462854..00000000000
--- a/packages/twenty-server/src/engine/core-modules/throttler/throttler.service.spec.ts
+++ /dev/null
@@ -1,148 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type CacheStorageService } from 'src/engine/core-modules/cache-storage/services/cache-storage.service';
-import { CacheStorageNamespace } from 'src/engine/core-modules/cache-storage/types/cache-storage-namespace.enum';
-import { ThrottlerException } from 'src/engine/core-modules/throttler/throttler.exception';
-import { ThrottlerService } from 'src/engine/core-modules/throttler/throttler.service';
-
-describe('ThrottlerService', () => {
- let service: ThrottlerService;
- let cacheStorageService: jest.Mocked<CacheStorageService>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ThrottlerService,
- {
- provide: CacheStorageNamespace.EngineWorkspace,
- useValue: {
- get: jest.fn(),
- set: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<ThrottlerService>(ThrottlerService);
- cacheStorageService = module.get(CacheStorageNamespace.EngineWorkspace);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('tokenBucketThrottleOrThrow', () => {
- const key = 'test-throttle-key';
- const maxTokens = 100;
- const timeWindow = 1000; // 1 second
-
- it('should allow request when tokens are available (first request)', async () => {
- cacheStorageService.get.mockResolvedValue(null);
-
- await service.tokenBucketThrottleOrThrow(key, 10, maxTokens, timeWindow);
-
- expect(cacheStorageService.get).toHaveBeenCalledWith(key);
- expect(cacheStorageService.set).toHaveBeenCalledWith(
- key,
- {
- tokens: 90, // maxTokens - tokensToConsume
- lastRefillAt: expect.any(Number),
- },
- timeWindow * 2,
- );
- });
-
- it('should allow request when sufficient tokens are available', async () => {
- const now = Date.now();
-
- cacheStorageService.get.mockResolvedValue({
- tokens: 50,
- lastRefillAt: now - 100,
- });
-
- await service.tokenBucketThrottleOrThrow(key, 10, maxTokens, timeWindow);
-
- expect(cacheStorageService.get).toHaveBeenCalledWith(key);
- expect(cacheStorageService.set).toHaveBeenCalledWith(
- key,
- {
- tokens: expect.any(Number),
- lastRefillAt: expect.any(Number),
- },
- timeWindow * 2,
- );
- });
-
- it('should throw ThrottlerException when tokens are insufficient', async () => {
- const now = Date.now();
-
- cacheStorageService.get.mockResolvedValue({
- tokens: 5,
- lastRefillAt: now,
- });
-
- await expect(
- service.tokenBucketThrottleOrThrow(key, 10, maxTokens, timeWindow),
- ).rejects.toThrow(ThrottlerException);
-
- await expect(
- service.tokenBucketThrottleOrThrow(key, 10, maxTokens, timeWindow),
- ).rejects.toThrow('Limit reached');
-
- expect(cacheStorageService.set).not.toHaveBeenCalled();
- });
-
- it('should refill tokens over time', async () => {
- const now = Date.now();
- const refillRate = maxTokens / timeWindow; // 100 tokens per 1000ms = 0.1 tokens/ms
- const timePassed = 500; // 500ms
- const expectedRefill = Math.floor(timePassed * refillRate); // 50 tokens
-
- cacheStorageService.get.mockResolvedValue({
- tokens: 20,
- lastRefillAt: now - timePassed,
- });
-
- jest.spyOn(Date, 'now').mockReturnValue(now);
-
- await service.tokenBucketThrottleOrThrow(key, 10, maxTokens, timeWindow);
-
- expect(cacheStorageService.set).toHaveBeenCalledWith(
- key,
- {
- tokens: 20 + expectedRefill - 10, // 20 + 50 - 10 = 60
- lastRefillAt: now,
- },
- timeWindow * 2,
- );
-
- jest.restoreAllMocks();
- });
-
- it('should cap tokens at maxTokens', async () => {
- const now = Date.now();
- const timePassed = 5000; // Long time passed, would refill beyond max
-
- cacheStorageService.get.mockResolvedValue({
- tokens: 80,
- lastRefillAt: now - timePassed,
- });
-
- jest.spyOn(Date, 'now').mockReturnValue(now);
-
- await service.tokenBucketThrottleOrThrow(key, 10, maxTokens, timeWindow);
-
- // Available tokens should be capped at maxTokens (100)
- expect(cacheStorageService.set).toHaveBeenCalledWith(
- key,
- {
- tokens: 90, // maxTokens (100) - tokensToConsume (10)
- lastRefillAt: now,
- },
- timeWindow * 2,
- );
-
- jest.restoreAllMocks();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/tool/services/__tests__/tool-output-spill.service.spec.ts b/packages/twenty-server/src/engine/core-modules/tool/services/__tests__/tool-output-spill.service.spec.ts
deleted file mode 100644
index 5d994c58711..00000000000
--- a/packages/twenty-server/src/engine/core-modules/tool/services/__tests__/tool-output-spill.service.spec.ts
+++ /dev/null
@@ -1,211 +0,0 @@
-import { FileFolder } from 'twenty-shared/types';
-
-import { type ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { type FileStorageService } from 'src/engine/core-modules/file-storage/services/file-storage.service';
-import { ToolOutputSpillService } from 'src/engine/core-modules/tool/services/tool-output-spill.service';
-import { MAX_INLINE_TOOL_OUTPUT_BYTES } from 'src/engine/core-modules/tool/tools/output-navigation-tool/constants/max-inline-tool-output-bytes.constant';
-import { type ToolOutput } from 'src/engine/core-modules/tool/types/tool-output.type';
-
-jest.mock(
- 'src/engine/core-modules/file-storage/services/file-storage.service',
- () => ({
- FileStorageService: class {},
- }),
-);
-jest.mock('src/engine/core-modules/application/application.service', () => ({
- ApplicationService: class {},
-}));
-
-const WORKSPACE_ID = 'workspace-1';
-
-const buildLargeOutput = (): ToolOutput => ({
- success: true,
- message: 'ok',
- result: {
- items: Array.from({ length: 2000 }, (_, index) => ({
- id: `record-${index}`,
- label: 'a-fairly-long-label-value-to-inflate-the-payload-size',
- })),
- },
-});
-
-describe('ToolOutputSpillService', () => {
- const writeFile = jest.fn();
- const findApplication = jest.fn();
-
- const service = new ToolOutputSpillService(
- { writeFile } as unknown as FileStorageService,
- {
- findWorkspaceTwentyStandardAndCustomApplicationOrThrow: findApplication,
- } as unknown as ApplicationService,
- );
-
- beforeEach(() => {
- jest.clearAllMocks();
- findApplication.mockResolvedValue({
- workspaceCustomFlatApplication: { universalIdentifier: 'app-uid' },
- });
- // Echo a persisted id that differs from the generated fileId so the test
- // catches the envelope exposing the wrong id (the nav tools retrieve by
- // savedFile.id, not by the generated uuid).
- writeFile.mockImplementation(({ fileId }: { fileId: string }) =>
- Promise.resolve({ id: `persisted-${fileId}` }),
- );
- });
-
- it('returns the output unchanged when under the byte budget', async () => {
- const output: ToolOutput = {
- success: true,
- message: 'ok',
- result: { id: 'small' },
- };
-
- const result = await service.spillIfTooLarge(
- output,
- { workspaceId: WORKSPACE_ID },
- { toolName: 'find_many_companies' },
- );
-
- expect(result).toBe(output);
- expect(writeFile).not.toHaveBeenCalled();
- });
-
- it('spills oversized output to an AgentChat file and returns an envelope', async () => {
- const result = await service.spillIfTooLarge(
- buildLargeOutput(),
- { workspaceId: WORKSPACE_ID },
- { toolName: 'find_many_companies' },
- );
-
- expect(writeFile).toHaveBeenCalledWith(
- expect.objectContaining({
- fileFolder: FileFolder.AgentChat,
- workspaceId: WORKSPACE_ID,
- applicationUniversalIdentifier: 'app-uid',
- settings: { isTemporaryFile: false, toDelete: false },
- }),
- );
-
- const writeFileArgs = writeFile.mock.calls[0][0] as {
- fileId: string;
- resourcePath: string;
- };
-
- const envelope = result.result as Record<string, unknown>;
- const outputRef = envelope.outputRef as Record<string, unknown>;
-
- expect(envelope.spilled).toBe(true);
- // The envelope must expose the persisted id (what the nav tools retrieve
- // by), not the generated fileId used to build the storage resourcePath.
- expect(outputRef.fileId).toBe(`persisted-${writeFileArgs.fileId}`);
- expect(writeFileArgs.resourcePath).toBe(
- `tool-output-spill/${writeFileArgs.fileId}.json`,
- );
- expect(outputRef.filename).toMatch(
- /^tool-output-find_many_companies-.+\.json$/,
- );
- expect(envelope.preview).toBeDefined();
- expect(envelope.hint).toContain('extract_json_paths');
- });
-
- it.each(['extract_json_paths', 'search_output'])(
- 'returns %s navigation output under the byte budget unchanged',
- async (toolName) => {
- const output: ToolOutput = {
- success: true,
- message: 'ok',
- result: { matches: ['small'] },
- };
-
- const result = await service.spillIfTooLarge(
- output,
- { workspaceId: WORKSPACE_ID },
- { toolName },
- );
-
- expect(result).toBe(output);
- expect(writeFile).not.toHaveBeenCalled();
- },
- );
-
- it.each(['extract_json_paths', 'search_output'])(
- 'caps oversized %s navigation output inline instead of spilling it',
- async (toolName) => {
- const output = buildLargeOutput();
- const serialized = JSON.stringify(output);
-
- const result = await service.spillIfTooLarge(
- output,
- { workspaceId: WORKSPACE_ID },
- { toolName },
- );
-
- expect(writeFile).not.toHaveBeenCalled();
-
- const capped = result.result as Record<string, unknown>;
- const content = capped.content as string;
-
- expect(capped.truncated).toBe(true);
- expect(capped.originalSizeBytes).toBe(Buffer.byteLength(serialized));
- expect(Buffer.byteLength(content)).toBeLessThanOrEqual(
- MAX_INLINE_TOOL_OUTPUT_BYTES,
- );
- expect(content.startsWith(serialized.slice(0, 100))).toBe(true);
- expect(content.endsWith(serialized.slice(-100))).toBe(true);
- expect(content).toContain('TRUNCATED');
- expect(content).toContain('offset');
- expect(result.message).toBe(output.message);
- },
- );
-
- it('truncates the output inline with a warning when the spill write fails', async () => {
- writeFile.mockRejectedValue(new Error('storage down'));
-
- const output = buildLargeOutput();
- const serialized = JSON.stringify(output);
-
- const result = await service.spillIfTooLarge(
- output,
- { workspaceId: WORKSPACE_ID },
- { toolName: 'find_many_companies' },
- );
-
- const truncated = result.result as Record<string, unknown>;
- const content = truncated.content as string;
-
- expect(truncated.truncated).toBe(true);
- expect(truncated.originalSizeBytes).toBe(Buffer.byteLength(serialized));
- expect(Buffer.byteLength(content)).toBeLessThanOrEqual(
- MAX_INLINE_TOOL_OUTPUT_BYTES,
- );
- expect(content.startsWith(serialized.slice(0, 100))).toBe(true);
- expect(content.endsWith(serialized.slice(-100))).toBe(true);
- expect(content).toContain(`${Buffer.byteLength(serialized)} bytes`);
- expect(Buffer.byteLength(JSON.stringify(result))).toBeLessThan(
- Buffer.byteLength(serialized),
- );
- expect(result.warnings).toEqual([
- 'Large output spill failed; the output was truncated inline.',
- ]);
- });
-
- it('keeps pre-existing warnings when the spill write fails', async () => {
- writeFile.mockRejectedValue(new Error('storage down'));
-
- const output: ToolOutput = {
- ...buildLargeOutput(),
- warnings: ['existing warning'],
- };
-
- const result = await service.spillIfTooLarge(
- output,
- { workspaceId: WORKSPACE_ID },
- { toolName: 'find_many_companies' },
- );
-
- expect(result.warnings).toEqual([
- 'existing warning',
- 'Large output spill failed; the output was truncated inline.',
- ]);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/cache/__tests__/config-cache.service.spec.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/cache/__tests__/config-cache.service.spec.ts
deleted file mode 100644
index cb7d2f3bd56..00000000000
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/cache/__tests__/config-cache.service.spec.ts
+++ /dev/null
@@ -1,196 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ConfigCacheService } from 'src/engine/core-modules/twenty-config/cache/config-cache.service';
-import { type ConfigVariables } from 'src/engine/core-modules/twenty-config/config-variables';
-
-describe('ConfigCacheService', () => {
- let service: ConfigCacheService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [ConfigCacheService],
- }).compile();
-
- service = module.get<ConfigCacheService>(ConfigCacheService);
- });
-
- afterEach(() => {
- service.onModuleDestroy();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('get and set', () => {
- it('should set and get a value from cache', () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const value = true;
-
- service.set(key, value);
- const result = service.get(key);
-
- expect(result).toBe(value);
- });
-
- it('should return undefined for non-existent key', () => {
- const result = service.get(
- 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables,
- );
-
- expect(result).toBeUndefined();
- });
-
- it('should handle different value types', () => {
- const booleanKey = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const stringKey = 'EMAIL_FROM_ADDRESS' as keyof ConfigVariables;
- const numberKey = 'CACHE_STORAGE_TTL' as keyof ConfigVariables;
-
- service.set(booleanKey, true);
- service.set(stringKey, '[email protected]');
- service.set(numberKey, 3600 * 24 * 7);
-
- expect(service.get(booleanKey)).toBe(true);
- expect(service.get(stringKey)).toBe('[email protected]');
- expect(service.get(numberKey)).toBe(3600 * 24 * 7);
- });
- });
-
- describe('negative lookup cache', () => {
- it('should check if a negative cache entry exists', () => {
- const key = 'TEST_KEY' as keyof ConfigVariables;
-
- service.markKeyAsMissing(key);
- const result = service.isKeyKnownMissing(key);
-
- expect(result).toBe(true);
- });
-
- it('should return false for negative cache entry check when not in cache', () => {
- const key = 'NON_EXISTENT_KEY' as keyof ConfigVariables;
-
- const result = service.isKeyKnownMissing(key);
-
- expect(result).toBe(false);
- });
- });
-
- describe('clear operations', () => {
- it('should clear specific key', () => {
- const key1 = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const key2 = 'EMAIL_FROM_ADDRESS' as keyof ConfigVariables;
-
- service.set(key1, true);
- service.set(key2, '[email protected]');
- service.clear(key1);
-
- expect(service.get(key1)).toBeUndefined();
- expect(service.get(key2)).toBe('[email protected]');
- });
-
- it('should clear all entries', () => {
- const key1 = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const key2 = 'EMAIL_FROM_ADDRESS' as keyof ConfigVariables;
-
- service.set(key1, true);
- service.set(key2, '[email protected]');
- service.clearAll();
-
- expect(service.get(key1)).toBeUndefined();
- expect(service.get(key2)).toBeUndefined();
- });
- });
-
- describe('getCacheInfo', () => {
- it('should return correct cache information', () => {
- const key1 = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const key2 = 'EMAIL_FROM_ADDRESS' as keyof ConfigVariables;
- const key3 = 'CACHE_STORAGE_TTL' as keyof ConfigVariables;
-
- service.set(key1, true);
- service.set(key2, '[email protected]');
- service.markKeyAsMissing(key3);
-
- const info = service.getCacheInfo();
-
- expect(info.foundConfigValues).toBe(2);
- expect(info.knownMissingKeys).toBe(1);
- expect(info.cacheKeys).toContain(key1);
- expect(info.cacheKeys).toContain(key2);
- expect(info.cacheKeys).not.toContain(key3);
- expect(service.isKeyKnownMissing(key3)).toBe(true);
- });
-
- it('should properly count cache entries', () => {
- const key1 = 'KEY1' as keyof ConfigVariables;
- const key2 = 'KEY2' as keyof ConfigVariables;
- const key3 = 'KEY3' as keyof ConfigVariables;
-
- // Add some values to the cache
- service.set(key1, 'value1');
- service.set(key2, 'value2');
- service.markKeyAsMissing(key3);
-
- const cacheInfo = service.getCacheInfo();
-
- expect(cacheInfo.foundConfigValues).toBe(2);
- expect(cacheInfo.knownMissingKeys).toBe(1);
- expect(cacheInfo.cacheKeys).toContain(key1);
- expect(cacheInfo.cacheKeys).toContain(key2);
- expect(service.isKeyKnownMissing(key3)).toBe(true);
- });
- });
-
- describe('module lifecycle', () => {
- it('should clear cache on module destroy', () => {
- const key = 'TEST_KEY' as keyof ConfigVariables;
-
- service.set(key, 'test');
-
- service.onModuleDestroy();
-
- expect(service.get(key)).toBeUndefined();
- });
- });
-
- describe('getAllKeys', () => {
- it('should return all keys from both positive and negative caches', () => {
- const positiveKey1 = 'POSITIVE_KEY1' as keyof ConfigVariables;
- const positiveKey2 = 'POSITIVE_KEY2' as keyof ConfigVariables;
- const negativeKey = 'NEGATIVE_KEY' as keyof ConfigVariables;
-
- // Set up keys
- service.set(positiveKey1, 'value1');
- service.set(positiveKey2, 'value2');
- service.markKeyAsMissing(negativeKey);
-
- const allKeys = service.getAllKeys();
-
- expect(allKeys).toContain(positiveKey1);
- expect(allKeys).toContain(positiveKey2);
- expect(allKeys).toContain(negativeKey);
- });
-
- it('should return empty array when no keys exist', () => {
- const allKeys = service.getAllKeys();
-
- expect(allKeys).toHaveLength(0);
- });
-
- it('should not have duplicates if a key somehow exists in both caches', () => {
- const key = 'DUPLICATE_KEY' as keyof ConfigVariables;
-
- // First add to positive cache
- service.set(key, 'value');
-
- // Then force it into negative cache (normally this would remove from positive)
- // We're bypassing normal behavior for testing edge cases
- service.addToMissingKeysForTesting(key);
-
- const allKeys = service.getAllKeys();
-
- // Should only appear once in the result
- expect(allKeys.filter((k) => k === key)).toHaveLength(1);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/conversion/__tests__/config-value-converter.service.spec.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/conversion/__tests__/config-value-converter.service.spec.ts
deleted file mode 100644
index ae968a12b47..00000000000
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/conversion/__tests__/config-value-converter.service.spec.ts
+++ /dev/null
@@ -1,671 +0,0 @@
-import { type LogLevel } from '@nestjs/common';
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type ConfigVariables } from 'src/engine/core-modules/twenty-config/config-variables';
-import { CONFIG_VARIABLES_INSTANCE_TOKEN } from 'src/engine/core-modules/twenty-config/constants/config-variables-instance-tokens.constants';
-import { ConfigValueConverterService } from 'src/engine/core-modules/twenty-config/conversion/config-value-converter.service';
-import { ConfigVariableType } from 'src/engine/core-modules/twenty-config/enums/config-variable-type.enum';
-import { ConfigVariablesGroup } from 'src/engine/core-modules/twenty-config/enums/config-variables-group.enum';
-import * as typeTransformersModule from 'src/engine/core-modules/twenty-config/utils/type-transformers.registry';
-import { TypedReflect } from 'src/utils/typed-reflect';
-
-jest.mock(
- 'src/engine/core-modules/twenty-config/utils/type-transformers.registry',
- () => {
- const createMockTransformer = () => ({
- toApp: jest.fn().mockImplementation((value) => value),
- toStorage: jest.fn().mockImplementation((value) => value),
- getValidators: jest.fn().mockReturnValue([]),
- getTransformers: jest.fn().mockReturnValue([]),
- });
-
- const mockRegistry = {
- boolean: createMockTransformer(),
- number: createMockTransformer(),
- string: createMockTransformer(),
- array: createMockTransformer(),
- enum: createMockTransformer(),
- json: createMockTransformer(),
- };
-
- return {
- typeTransformers: mockRegistry,
- };
- },
-);
-
-const typeTransformers = typeTransformersModule.typeTransformers as {
- boolean: {
- toApp: jest.Mock;
- toStorage: jest.Mock;
- getValidators: jest.Mock;
- getTransformers: jest.Mock;
- };
- number: {
- toApp: jest.Mock;
- toStorage: jest.Mock;
- getValidators: jest.Mock;
- getTransformers: jest.Mock;
- };
- string: {
- toApp: jest.Mock;
- toStorage: jest.Mock;
- getValidators: jest.Mock;
- getTransformers: jest.Mock;
- };
- array: {
- toApp: jest.Mock;
- toStorage: jest.Mock;
- getValidators: jest.Mock;
- getTransformers: jest.Mock;
- };
- enum: {
- toApp: jest.Mock;
- toStorage: jest.Mock;
- getValidators: jest.Mock;
- getTransformers: jest.Mock;
- };
- json: {
- toApp: jest.Mock;
- toStorage: jest.Mock;
- getValidators: jest.Mock;
- getTransformers: jest.Mock;
- };
-};
-
-describe('ConfigValueConverterService', () => {
- let service: ConfigValueConverterService;
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- Object.values(typeTransformers).forEach((transformer) => {
- transformer.toApp.mockImplementation((value) => value);
- transformer.toStorage.mockImplementation((value) => value);
- });
-
- const mockConfigVariables = {
- CACHE_STORAGE_TTL: 3600 * 24 * 7,
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ConfigValueConverterService,
- {
- provide: CONFIG_VARIABLES_INSTANCE_TOKEN,
- useValue: mockConfigVariables,
- },
- ],
- }).compile();
-
- service = module.get<ConfigValueConverterService>(
- ConfigValueConverterService,
- );
- });
-
- describe('convertDbValueToAppValue', () => {
- it('should use boolean transformer for boolean type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- AUTH_PASSWORD_ENABLED: {
- type: ConfigVariableType.BOOLEAN,
- group: ConfigVariablesGroup.ADVANCED_SETTINGS,
- description: 'Enable or disable password authentication for users',
- },
- });
-
- typeTransformers.boolean.toApp.mockReturnValueOnce(true);
-
- const result = service.convertDbValueToAppValue(
- 'true',
- 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.boolean.toApp).toHaveBeenCalledWith(
- 'true',
- undefined,
- );
- expect(result).toBe(true);
- });
-
- it('should use number transformer for number type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- CACHE_STORAGE_TTL: {
- type: ConfigVariableType.NUMBER,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Time-to-live for cache storage in seconds',
- },
- });
-
- typeTransformers.number.toApp.mockReturnValueOnce(3600 * 24 * 7);
-
- const result = service.convertDbValueToAppValue(
- '604800',
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.number.toApp).toHaveBeenCalledWith(
- '604800',
- undefined,
- );
- expect(result).toBe(3600 * 24 * 7);
- });
-
- it('should use string transformer for string type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- FRONTEND_URL: {
- type: ConfigVariableType.STRING,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Frontend URL',
- },
- });
-
- typeTransformers.string.toApp.mockReturnValueOnce(
- 'http://localhost:3000',
- );
-
- const result = service.convertDbValueToAppValue(
- 'http://localhost:3000',
- 'FRONTEND_URL' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.string.toApp).toHaveBeenCalledWith(
- 'http://localhost:3000',
- undefined,
- );
- expect(result).toBe('http://localhost:3000');
- });
-
- it('should use array transformer for array type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- LOG_LEVELS: {
- type: ConfigVariableType.ARRAY,
- group: ConfigVariablesGroup.LOGGING,
- description: 'Levels of logging to be captured',
- options: ['log', 'error', 'warn', 'debug', 'verbose'],
- },
- });
-
- const expectedResult = ['log', 'error', 'warn'] as unknown as LogLevel[];
-
- typeTransformers.array.toApp.mockReturnValueOnce(expectedResult);
-
- const result = service.convertDbValueToAppValue(
- 'log,error,warn',
- 'LOG_LEVELS' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.array.toApp).toHaveBeenCalledWith(
- 'log,error,warn',
- ['log', 'error', 'warn', 'debug', 'verbose'],
- );
- expect(result).toEqual(expectedResult);
- });
-
- it('should use enum transformer for enum type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- NODE_ENV: {
- type: ConfigVariableType.ENUM,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Node environment',
- options: ['development', 'production', 'test'],
- },
- });
-
- typeTransformers.enum.toApp.mockReturnValueOnce('development');
-
- const result = service.convertDbValueToAppValue(
- 'development',
- 'NODE_ENV' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.enum.toApp).toHaveBeenCalledWith('development', [
- 'development',
- 'production',
- 'test',
- ]);
- expect(result).toBe('development');
- });
-
- it('should infer type from default value when no metadata is available', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce(undefined);
-
- typeTransformers.number.toApp.mockReturnValueOnce(3600 * 24 * 7);
-
- const result = service.convertDbValueToAppValue(
- '604800',
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.number.toApp).toHaveBeenCalledWith(
- '604800',
- undefined,
- );
- expect(result).toBe(3600 * 24 * 7);
- });
-
- it('should return undefined for null or undefined input', () => {
- const result1 = service.convertDbValueToAppValue(
- null,
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
- const result2 = service.convertDbValueToAppValue(
- undefined,
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
-
- expect(result1).toBeUndefined();
- expect(result2).toBeUndefined();
- });
-
- it('should propagate errors from transformers with context', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- CACHE_STORAGE_TTL: {
- type: ConfigVariableType.NUMBER,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Time-to-live for cache storage in seconds',
- },
- });
-
- const error = new Error('Test error');
-
- typeTransformers.number.toApp.mockImplementationOnce(() => {
- throw error;
- });
-
- expect(() => {
- service.convertDbValueToAppValue(
- 'not-a-number',
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
- }).toThrow(
- `Failed to convert CACHE_STORAGE_TTL to app value: Test error`,
- );
- });
- });
-
- describe('convertAppValueToDbValue', () => {
- it('should use boolean transformer for boolean type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- AUTH_PASSWORD_ENABLED: {
- type: ConfigVariableType.BOOLEAN,
- group: ConfigVariablesGroup.ADVANCED_SETTINGS,
- description: 'Enable or disable password authentication for users',
- },
- });
-
- typeTransformers.boolean.toStorage.mockReturnValueOnce(true);
-
- const result = service.convertAppValueToDbValue(
- true,
- 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.boolean.toStorage).toHaveBeenCalledWith(
- true,
- undefined,
- );
- expect(result).toBe(true);
- });
-
- it('should use number transformer for number type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- CACHE_STORAGE_TTL: {
- type: ConfigVariableType.NUMBER,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Time-to-live for cache storage in seconds',
- },
- });
-
- typeTransformers.number.toStorage.mockReturnValueOnce(3600 * 24 * 7);
-
- const result = service.convertAppValueToDbValue(
- 3600 * 24 * 7,
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.number.toStorage).toHaveBeenCalledWith(
- 3600 * 24 * 7,
- undefined,
- );
- expect(result).toBe(3600 * 24 * 7);
- });
-
- it('should use string transformer for string type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- FRONTEND_URL: {
- type: ConfigVariableType.STRING,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Frontend URL',
- },
- });
-
- typeTransformers.string.toStorage.mockReturnValueOnce(
- 'http://localhost:3000',
- );
-
- const result = service.convertAppValueToDbValue(
- 'http://localhost:3000',
- 'FRONTEND_URL' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.string.toStorage).toHaveBeenCalledWith(
- 'http://localhost:3000',
- undefined,
- );
- expect(result).toBe('http://localhost:3000');
- });
-
- it('should use array transformer for array type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- LOG_LEVELS: {
- type: ConfigVariableType.ARRAY,
- group: ConfigVariablesGroup.LOGGING,
- description: 'Levels of logging to be captured',
- options: ['log', 'error', 'warn', 'debug', 'verbose'],
- },
- });
-
- const inputArray = ['log', 'error', 'warn'] as LogLevel[];
- const expectedResult = ['log', 'error', 'warn'];
-
- typeTransformers.array.toStorage.mockReturnValueOnce(expectedResult);
-
- const result = service.convertAppValueToDbValue(
- inputArray,
- 'LOG_LEVELS' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.array.toStorage).toHaveBeenCalledWith(
- inputArray,
- ['log', 'error', 'warn', 'debug', 'verbose'],
- );
- expect(result).toEqual(expectedResult);
- });
-
- it('should use enum transformer for enum type', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- NODE_ENV: {
- type: ConfigVariableType.ENUM,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Node environment',
- options: ['development', 'production', 'test'],
- },
- });
-
- typeTransformers.enum.toStorage.mockReturnValueOnce('development');
-
- const result = service.convertAppValueToDbValue(
- 'development',
- 'NODE_ENV' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.enum.toStorage).toHaveBeenCalledWith(
- 'development',
- ['development', 'production', 'test'],
- );
- expect(result).toBe('development');
- });
-
- it('should infer type from default value when no metadata is available', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce(undefined);
-
- typeTransformers.number.toStorage.mockReturnValueOnce(3600 * 24 * 7);
-
- const result = service.convertAppValueToDbValue(
- 3600 * 24 * 7,
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
-
- expect(typeTransformers.number.toStorage).toHaveBeenCalledWith(
- 3600 * 24 * 7,
- undefined,
- );
- expect(result).toBe(3600 * 24 * 7);
- });
-
- it('should return null for null or undefined input', () => {
- const result1 = service.convertAppValueToDbValue(
- null,
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
- const result2 = service.convertAppValueToDbValue(
- undefined,
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
-
- expect(result1).toBeNull();
- expect(result2).toBeNull();
- });
-
- it('should handle object serialization when no transformer is found', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- CUSTOM_OBJECT: {
- type: 'unknown-type' as ConfigVariableType,
- group: ConfigVariablesGroup.ADVANCED_SETTINGS,
- description: 'Custom object',
- },
- });
-
- const obj = { key: 'value' };
-
- const result = service.convertAppValueToDbValue(
- obj as any,
- 'CUSTOM_OBJECT' as keyof ConfigVariables,
- );
-
- expect(result).toEqual(obj);
- });
-
- it('should propagate errors from transformers with context', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- CACHE_STORAGE_TTL: {
- type: ConfigVariableType.NUMBER,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Time-to-live for cache storage in seconds',
- },
- });
-
- const error = new Error('Test error');
-
- typeTransformers.number.toStorage.mockImplementationOnce(() => {
- throw error;
- });
-
- expect(() => {
- service.convertAppValueToDbValue(
- 'not-a-number' as any,
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
- }).toThrow(`Failed to convert CACHE_STORAGE_TTL to DB value: Test error`);
- });
- });
-
- describe('convertAppValueToDbValue bidirectional validation', () => {
- it('should validate boolean values when converting to storage', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- AUTH_PASSWORD_ENABLED: {
- type: ConfigVariableType.BOOLEAN,
- group: ConfigVariablesGroup.ADVANCED_SETTINGS,
- description: 'Enable or disable password authentication for users',
- },
- });
-
- typeTransformers.boolean.toStorage.mockImplementationOnce(() => {
- throw new Error('Expected boolean, got string');
- });
-
- expect(() => {
- service.convertAppValueToDbValue(
- 'not-a-boolean' as any,
- 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables,
- );
- }).toThrow(
- 'Failed to convert AUTH_PASSWORD_ENABLED to DB value: Expected boolean, got string',
- );
- });
-
- it('should validate number values when converting to storage', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- CACHE_STORAGE_TTL: {
- type: ConfigVariableType.NUMBER,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Time-to-live for cache storage in seconds',
- },
- });
-
- typeTransformers.number.toStorage.mockImplementationOnce(() => {
- throw new Error('Expected number, got string');
- });
-
- expect(() => {
- service.convertAppValueToDbValue(
- 'invalid-ttl' as any,
- 'CACHE_STORAGE_TTL' as keyof ConfigVariables,
- );
- }).toThrow(
- 'Failed to convert CACHE_STORAGE_TTL to DB value: Expected number, got string',
- );
- });
-
- it('should validate string values when converting to storage', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- FRONTEND_URL: {
- type: ConfigVariableType.STRING,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Frontend URL',
- },
- });
-
- typeTransformers.string.toStorage.mockImplementationOnce(() => {
- throw new Error('Expected string, got object');
- });
-
- expect(() => {
- service.convertAppValueToDbValue(
- {} as any,
- 'FRONTEND_URL' as keyof ConfigVariables,
- );
- }).toThrow(
- 'Failed to convert FRONTEND_URL to DB value: Expected string, got object',
- );
- });
-
- it('should validate array values when converting to storage', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- LOG_LEVELS: {
- type: ConfigVariableType.ARRAY,
- group: ConfigVariablesGroup.LOGGING,
- description: 'Levels of logging to be captured',
- options: ['log', 'error', 'warn', 'debug', 'verbose'],
- },
- });
-
- typeTransformers.array.toStorage.mockImplementationOnce(() => {
- throw new Error('Expected array, got string');
- });
-
- expect(() => {
- service.convertAppValueToDbValue(
- 'not-an-array' as any,
- 'LOG_LEVELS' as keyof ConfigVariables,
- );
- }).toThrow(
- 'Failed to convert LOG_LEVELS to DB value: Expected array, got string',
- );
- });
-
- it('should validate enum values when converting to storage', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- NODE_ENV: {
- type: ConfigVariableType.ENUM,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Node environment',
- options: ['development', 'production', 'test'],
- },
- });
-
- typeTransformers.enum.toStorage.mockImplementationOnce(() => {
- throw new Error("Value 'invalid-env' is not a valid option for enum");
- });
-
- expect(() => {
- service.convertAppValueToDbValue(
- 'invalid-env' as any,
- 'NODE_ENV' as keyof ConfigVariables,
- );
- }).toThrow(
- "Failed to convert NODE_ENV to DB value: Value 'invalid-env' is not a valid option for enum",
- );
- });
-
- it('should validate enum values against options', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- NODE_ENV: {
- type: ConfigVariableType.ENUM,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Node environment',
- options: ['development', 'production', 'test'],
- },
- });
-
- typeTransformers.enum.toStorage.mockImplementation((value, options) => {
- if (!options?.includes(value)) {
- throw new Error(`Value '${value}' is not a valid option for enum`);
- }
-
- return value;
- });
-
- expect(
- service.convertAppValueToDbValue(
- 'development' as any,
- 'NODE_ENV' as keyof ConfigVariables,
- ),
- ).toBe('development');
-
- expect(() => {
- service.convertAppValueToDbValue(
- 'staging' as any,
- 'NODE_ENV' as keyof ConfigVariables,
- );
- }).toThrow(
- "Failed to convert NODE_ENV to DB value: Value 'staging' is not a valid option for enum",
- );
- });
-
- it('should filter array values based on options when converting to storage', () => {
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValueOnce({
- LOG_LEVELS: {
- type: ConfigVariableType.ARRAY,
- group: ConfigVariablesGroup.LOGGING,
- description: 'Levels of logging to be captured',
- options: ['log', 'error', 'warn', 'debug', 'verbose'],
- },
- });
-
- typeTransformers.array.toStorage.mockImplementation((value, options) => {
- if (!Array.isArray(value)) {
- throw new Error(`Expected array, got ${typeof value}`);
- }
-
- if (!options || !Array.isArray(options) || options.length === 0) {
- return value;
- }
-
- return value.filter((item) => options.includes(item));
- });
-
- const result = service.convertAppValueToDbValue(
- ['log', 'invalid-level', 'error'] as any,
- 'LOG_LEVELS' as keyof ConfigVariables,
- );
-
- expect(result).toEqual(['log', 'error']);
-
- expect(typeTransformers.array.toStorage).toHaveBeenCalledWith(
- ['log', 'invalid-level', 'error'],
- ['log', 'error', 'warn', 'debug', 'verbose'],
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/storage/__tests__/config-storage.service.spec.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/storage/__tests__/config-storage.service.spec.ts
deleted file mode 100644
index 1e52f7d0e20..00000000000
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/storage/__tests__/config-storage.service.spec.ts
+++ /dev/null
@@ -1,684 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { type DeleteResult, IsNull, type Repository } from 'typeorm';
-
-import {
- KeyValuePairEntity,
- KeyValuePairType,
-} from 'src/engine/core-modules/key-value-pair/key-value-pair.entity';
-import { SecretEncryptionService } from 'src/engine/core-modules/secret-encryption/secret-encryption.service';
-import { ConfigVariables } from 'src/engine/core-modules/twenty-config/config-variables';
-import { ConfigValueConverterService } from 'src/engine/core-modules/twenty-config/conversion/config-value-converter.service';
-import { EnvironmentConfigDriver } from 'src/engine/core-modules/twenty-config/drivers/environment-config.driver';
-import { ConfigVariableType } from 'src/engine/core-modules/twenty-config/enums/config-variable-type.enum';
-import { ConfigVariablesGroup } from 'src/engine/core-modules/twenty-config/enums/config-variables-group.enum';
-import { ConfigStorageService } from 'src/engine/core-modules/twenty-config/storage/config-storage.service';
-import {
- ConfigVariableException,
- ConfigVariableExceptionCode,
-} from 'src/engine/core-modules/twenty-config/twenty-config.exception';
-import { type UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { type WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { TypedReflect } from 'src/utils/typed-reflect';
-
-jest.mock('src/engine/core-modules/auth/auth.util', () => ({
- encryptText: jest.fn((text) => `${text}`),
- decryptText: jest.fn((text) => `${text}`),
-}));
-
-describe('ConfigStorageService', () => {
- let service: ConfigStorageService;
- let keyValuePairRepository: Repository<KeyValuePairEntity>;
- let configValueConverter: ConfigValueConverterService;
- let secretEncryptionService: SecretEncryptionService;
-
- const createMockKeyValuePair = (
- key: string,
- value: string,
- ): KeyValuePairEntity => ({
- id: '1',
- key,
- value: value as unknown as JSON,
- type: KeyValuePairType.CONFIG_VARIABLE,
- userId: null,
- workspaceId: null,
- applicationId: null,
- user: null as unknown as UserEntity,
- workspace: null as unknown as WorkspaceEntity,
- application: null,
- createdAt: new Date(),
- updatedAt: new Date(),
- textValueDeprecated: null,
- deletedAt: null,
- });
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ConfigStorageService,
- {
- provide: ConfigValueConverterService,
- useValue: {
- convertDbValueToAppValue: jest.fn(),
- convertAppValueToDbValue: jest.fn(),
- },
- },
- {
- provide: EnvironmentConfigDriver,
- useValue: {
- get: jest.fn().mockReturnValue('test-secret'),
- },
- },
- ConfigVariables,
- {
- provide: getRepositoryToken(KeyValuePairEntity),
- useValue: {
- findOne: jest.fn(),
- find: jest.fn(),
- update: jest.fn(),
- insert: jest.fn(),
- delete: jest.fn(),
- },
- },
- {
- provide: SecretEncryptionService,
- useValue: {
- decryptVersionedOrThrow: jest.fn((value) => value),
- encryptVersioned: jest.fn((value) => value),
- },
- },
- ],
- }).compile();
-
- service = module.get<ConfigStorageService>(ConfigStorageService);
- keyValuePairRepository = module.get<Repository<KeyValuePairEntity>>(
- getRepositoryToken(KeyValuePairEntity),
- );
- configValueConverter = module.get<ConfigValueConverterService>(
- ConfigValueConverterService,
- );
- secretEncryptionService = module.get<SecretEncryptionService>(
- SecretEncryptionService,
- );
-
- jest.clearAllMocks();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('get', () => {
- it('should return undefined when key not found', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
-
- jest.spyOn(keyValuePairRepository, 'findOne').mockResolvedValue(null);
-
- const result = await service.get(key);
-
- expect(result).toBeUndefined();
- expect(keyValuePairRepository.findOne).toHaveBeenCalledWith({
- where: {
- type: KeyValuePairType.CONFIG_VARIABLE,
- key: key as string,
- userId: IsNull(),
- workspaceId: IsNull(),
- },
- });
- });
-
- it('should return converted value when key found', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const storedValue = 'true';
- const convertedValue = true;
-
- const mockRecord = createMockKeyValuePair(key as string, storedValue);
-
- jest
- .spyOn(keyValuePairRepository, 'findOne')
- .mockResolvedValue(mockRecord);
-
- (
- configValueConverter.convertDbValueToAppValue as jest.Mock
- ).mockReturnValue(convertedValue);
-
- const result = await service.get(key);
-
- expect(result).toBe(convertedValue);
- expect(
- configValueConverter.convertDbValueToAppValue,
- ).toHaveBeenCalledWith(storedValue, key);
- });
-
- it('should handle conversion errors', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const error = new Error('Conversion error');
-
- const mockRecord = createMockKeyValuePair(key as string, 'invalid');
-
- jest
- .spyOn(keyValuePairRepository, 'findOne')
- .mockResolvedValue(mockRecord);
-
- (
- configValueConverter.convertDbValueToAppValue as jest.Mock
- ).mockImplementation(() => {
- throw error;
- });
-
- await expect(service.get(key)).rejects.toThrow(ConfigVariableException);
- await expect(service.get(key)).rejects.toMatchObject({
- code: ConfigVariableExceptionCode.VALIDATION_FAILED,
- });
- });
-
- it('should decrypt sensitive string values', async () => {
- const key = 'SENSITIVE_CONFIG' as keyof ConfigVariables;
- const encryptedValue = 'enc:v2:deadbeef:sensitive-value';
-
- const mockRecord = createMockKeyValuePair(key as string, encryptedValue);
-
- jest
- .spyOn(keyValuePairRepository, 'findOne')
- .mockResolvedValue(mockRecord);
-
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValue({
- [key]: {
- isSensitive: true,
- type: ConfigVariableType.STRING,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Test sensitive config',
- },
- });
-
- (
- configValueConverter.convertDbValueToAppValue as jest.Mock
- ).mockReturnValue(encryptedValue);
-
- const result = await service.get(key);
-
- expect(result).toBe(encryptedValue);
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledWith(encryptedValue);
- });
-
- it('should handle decryption errors gracefully', async () => {
- const key = 'SENSITIVE_CONFIG' as keyof ConfigVariables;
- const encryptedValue = 'encrypted-value';
- const convertedValue = 'converted-value';
-
- const mockRecord = createMockKeyValuePair(key as string, encryptedValue);
-
- jest
- .spyOn(keyValuePairRepository, 'findOne')
- .mockResolvedValue(mockRecord);
-
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValue({
- [key]: {
- isSensitive: true,
- type: ConfigVariableType.STRING,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Test sensitive config',
- },
- });
-
- (
- configValueConverter.convertDbValueToAppValue as jest.Mock
- ).mockReturnValue(convertedValue);
-
- const result = await service.get(key);
-
- expect(result).toBe(convertedValue);
- });
-
- it('should handle findOne errors', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const error = new Error('Database error');
-
- jest.spyOn(keyValuePairRepository, 'findOne').mockRejectedValue(error);
-
- await expect(service.get(key)).rejects.toThrow(ConfigVariableException);
- await expect(service.get(key)).rejects.toThrow(
- `Failed to retrieve config variable ${key}: Database error`,
- );
- await expect(service.get(key)).rejects.toMatchObject({
- code: ConfigVariableExceptionCode.INTERNAL_ERROR,
- });
- });
- });
-
- describe('set', () => {
- it('should update existing record', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const value = true;
- const convertedValue = 'true';
-
- const mockRecord = createMockKeyValuePair(key as string, 'false');
-
- jest
- .spyOn(keyValuePairRepository, 'findOne')
- .mockResolvedValue(mockRecord);
-
- (
- configValueConverter.convertAppValueToDbValue as jest.Mock
- ).mockReturnValue(convertedValue);
-
- await service.set(key, value);
-
- expect(keyValuePairRepository.update).toHaveBeenCalledWith(
- { id: mockRecord.id },
- { value: convertedValue },
- );
- });
-
- it('should insert new record when not found', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const value = true;
- const convertedValue = 'true';
-
- jest.spyOn(keyValuePairRepository, 'findOne').mockResolvedValue(null);
-
- (
- configValueConverter.convertAppValueToDbValue as jest.Mock
- ).mockReturnValue(convertedValue);
-
- await service.set(key, value);
-
- expect(keyValuePairRepository.insert).toHaveBeenCalledWith({
- key: key as string,
- value: convertedValue,
- userId: null,
- workspaceId: null,
- type: KeyValuePairType.CONFIG_VARIABLE,
- });
- });
-
- it('should handle conversion errors', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const value = 'not-a-boolean';
- const error = new Error('Invalid boolean value');
-
- (
- configValueConverter.convertAppValueToDbValue as jest.Mock
- ).mockImplementation(() => {
- throw error;
- });
-
- await expect(
- service.set(key, value as unknown as boolean),
- ).rejects.toThrow(ConfigVariableException);
- await expect(
- service.set(key, value as unknown as boolean),
- ).rejects.toMatchObject({
- code: ConfigVariableExceptionCode.VALIDATION_FAILED,
- });
- });
-
- it('should handle update errors', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const value = true;
- const convertedValue = 'true';
- const error = new Error('Update error');
-
- const mockRecord = createMockKeyValuePair(key as string, 'false');
-
- jest
- .spyOn(keyValuePairRepository, 'findOne')
- .mockResolvedValue(mockRecord);
-
- (
- configValueConverter.convertAppValueToDbValue as jest.Mock
- ).mockReturnValue(convertedValue);
-
- jest.spyOn(keyValuePairRepository, 'update').mockRejectedValue(error);
-
- await expect(service.set(key, value)).rejects.toThrow(
- ConfigVariableException,
- );
- await expect(service.set(key, value)).rejects.toThrow(
- `Failed to save config variable ${key}: Update error`,
- );
- await expect(service.set(key, value)).rejects.toMatchObject({
- code: ConfigVariableExceptionCode.INTERNAL_ERROR,
- });
- });
-
- it('should handle insert errors', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const value = true;
- const convertedValue = 'true';
- const error = new Error('Insert error');
-
- jest.spyOn(keyValuePairRepository, 'findOne').mockResolvedValue(null);
-
- (
- configValueConverter.convertAppValueToDbValue as jest.Mock
- ).mockReturnValue(convertedValue);
-
- jest.spyOn(keyValuePairRepository, 'insert').mockRejectedValue(error);
-
- await expect(service.set(key, value)).rejects.toThrow(
- ConfigVariableException,
- );
- await expect(service.set(key, value)).rejects.toThrow(
- `Failed to save config variable ${key}: Insert error`,
- );
- await expect(service.set(key, value)).rejects.toMatchObject({
- code: ConfigVariableExceptionCode.INTERNAL_ERROR,
- });
- });
-
- it('should encrypt sensitive string values', async () => {
- const key = 'SENSITIVE_CONFIG' as keyof ConfigVariables;
- const value = 'sensitive-value';
- const convertedValue = 'sensitive-value';
- const encryptedValue = 'sensitive-value';
-
- jest.spyOn(keyValuePairRepository, 'findOne').mockResolvedValue(null);
-
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValue({
- [key]: {
- isSensitive: true,
- type: ConfigVariableType.STRING,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Test sensitive config',
- },
- });
-
- (
- configValueConverter.convertAppValueToDbValue as jest.Mock
- ).mockReturnValue(convertedValue);
-
- await service.set(key, value);
-
- expect(keyValuePairRepository.insert).toHaveBeenCalledWith({
- key: key as string,
- value: encryptedValue,
- userId: null,
- workspaceId: null,
- type: KeyValuePairType.CONFIG_VARIABLE,
- });
- expect(secretEncryptionService.encryptVersioned).toHaveBeenCalledWith(
- convertedValue,
- );
- });
- });
-
- describe('delete', () => {
- it('should delete record', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
-
- await service.delete(key);
-
- expect(keyValuePairRepository.delete).toHaveBeenCalledWith({
- type: KeyValuePairType.CONFIG_VARIABLE,
- key: key as string,
- userId: IsNull(),
- workspaceId: IsNull(),
- });
- });
-
- it('should handle delete errors', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const error = new Error('Delete error');
-
- jest.spyOn(keyValuePairRepository, 'delete').mockRejectedValue(error);
-
- await expect(service.delete(key)).rejects.toThrow(
- ConfigVariableException,
- );
- await expect(service.delete(key)).rejects.toThrow(
- `Failed to delete config variable ${key}: Delete error`,
- );
- await expect(service.delete(key)).rejects.toMatchObject({
- code: ConfigVariableExceptionCode.INTERNAL_ERROR,
- });
- });
- });
-
- describe('loadAll', () => {
- it('should load and convert all config variables', async () => {
- const configVars: KeyValuePairEntity[] = [
- createMockKeyValuePair('AUTH_PASSWORD_ENABLED', 'true'),
- createMockKeyValuePair('EMAIL_FROM_ADDRESS', '[email protected]'),
- ];
-
- jest.spyOn(keyValuePairRepository, 'find').mockResolvedValue(configVars);
-
- (
- configValueConverter.convertDbValueToAppValue as jest.Mock
- ).mockImplementation((value, key) => {
- if (key === 'AUTH_PASSWORD_ENABLED') return true;
- if (key === 'EMAIL_FROM_ADDRESS') return '[email protected]';
-
- return value;
- });
-
- const result = await service.loadAll();
-
- expect(result.size).toBe(2);
- expect(result.get('AUTH_PASSWORD_ENABLED' as keyof ConfigVariables)).toBe(
- true,
- );
- expect(result.get('EMAIL_FROM_ADDRESS' as keyof ConfigVariables)).toBe(
- );
- });
-
- it('should skip invalid values but continue processing', async () => {
- const configVars: KeyValuePairEntity[] = [
- createMockKeyValuePair('AUTH_PASSWORD_ENABLED', 'invalid'),
- createMockKeyValuePair('EMAIL_FROM_ADDRESS', '[email protected]'),
- ];
-
- jest.spyOn(keyValuePairRepository, 'find').mockResolvedValue(configVars);
-
- (configValueConverter.convertDbValueToAppValue as jest.Mock)
- .mockImplementationOnce(() => {
- throw new Error('Invalid value');
- })
- .mockImplementationOnce((value) => value);
-
- const result = await service.loadAll();
-
- expect(result.size).toBe(1);
- expect(result.get('EMAIL_FROM_ADDRESS' as keyof ConfigVariables)).toBe(
- );
- });
-
- it('should handle find errors', async () => {
- const error = new Error('Find error');
-
- jest.spyOn(keyValuePairRepository, 'find').mockRejectedValue(error);
-
- await expect(service.loadAll()).rejects.toThrow(ConfigVariableException);
- await expect(service.loadAll()).rejects.toThrow(
- 'Failed to load all config variables: Find error',
- );
- await expect(service.loadAll()).rejects.toMatchObject({
- code: ConfigVariableExceptionCode.INTERNAL_ERROR,
- });
- });
-
- describe('Null Value Handling', () => {
- it('should handle null values in loadAll', async () => {
- const configVars: KeyValuePairEntity[] = [
- {
- ...createMockKeyValuePair('AUTH_PASSWORD_ENABLED', 'true'),
- value: null as unknown as JSON,
- },
- createMockKeyValuePair('EMAIL_FROM_ADDRESS', '[email protected]'),
- ];
-
- jest
- .spyOn(keyValuePairRepository, 'find')
- .mockResolvedValue(configVars);
-
- (
- configValueConverter.convertDbValueToAppValue as jest.Mock
- ).mockImplementation((value) => {
- if (value === null) throw new Error('Null value');
-
- return value;
- });
-
- const result = await service.loadAll();
-
- expect(result.size).toBe(1);
- expect(result.get('EMAIL_FROM_ADDRESS' as keyof ConfigVariables)).toBe(
- );
- expect(
- configValueConverter.convertDbValueToAppValue,
- ).toHaveBeenCalledTimes(1); // Only called for non-null value
- });
- });
-
- it('should decrypt sensitive string values in loadAll', async () => {
- const configVars: KeyValuePairEntity[] = [
- createMockKeyValuePair(
- 'SENSITIVE_CONFIG',
- 'enc:v2:deadbeef:sensitive-value',
- ),
- createMockKeyValuePair('NORMAL_CONFIG', 'normal-value'),
- ];
-
- jest.spyOn(keyValuePairRepository, 'find').mockResolvedValue(configVars);
- jest.spyOn(TypedReflect, 'getMetadata').mockReturnValue({
- SENSITIVE_CONFIG: {
- isSensitive: true,
- type: ConfigVariableType.STRING,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Test sensitive config',
- },
- NORMAL_CONFIG: {
- type: ConfigVariableType.STRING,
- group: ConfigVariablesGroup.SERVER_CONFIG,
- description: 'Test normal config',
- },
- });
-
- (
- configValueConverter.convertDbValueToAppValue as jest.Mock
- ).mockImplementation((value) => value);
-
- const result = await service.loadAll();
-
- expect(result.size).toBe(2);
- expect(result.get('SENSITIVE_CONFIG' as keyof ConfigVariables)).toBe(
- 'enc:v2:deadbeef:sensitive-value',
- );
- expect(result.get('NORMAL_CONFIG' as keyof ConfigVariables)).toBe(
- 'normal-value',
- );
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledWith('enc:v2:deadbeef:sensitive-value');
- });
- });
-
- describe('Edge Cases and Additional Scenarios', () => {
- describe('Type Safety', () => {
- it('should enforce correct types for boolean config variables', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const invalidValue = 'not-a-boolean';
-
- const mockRecord = createMockKeyValuePair(key as string, invalidValue);
-
- jest
- .spyOn(keyValuePairRepository, 'findOne')
- .mockResolvedValue(mockRecord);
-
- (
- configValueConverter.convertDbValueToAppValue as jest.Mock
- ).mockImplementation(() => {
- throw new Error('Invalid boolean value');
- });
-
- await expect(service.get(key)).rejects.toThrow(ConfigVariableException);
- await expect(service.get(key)).rejects.toMatchObject({
- code: ConfigVariableExceptionCode.VALIDATION_FAILED,
- });
- });
-
- it('should enforce correct types for string config variables', async () => {
- const key = 'EMAIL_FROM_ADDRESS' as keyof ConfigVariables;
- const invalidValue = '123'; // Not a valid email
-
- const mockRecord = createMockKeyValuePair(key as string, invalidValue);
-
- jest
- .spyOn(keyValuePairRepository, 'findOne')
- .mockResolvedValue(mockRecord);
-
- (
- configValueConverter.convertDbValueToAppValue as jest.Mock
- ).mockImplementation(() => {
- throw new Error('Invalid string value');
- });
-
- await expect(service.get(key)).rejects.toThrow(ConfigVariableException);
- await expect(service.get(key)).rejects.toMatchObject({
- code: ConfigVariableExceptionCode.VALIDATION_FAILED,
- });
- });
- });
-
- describe('Concurrent Operations', () => {
- it('should handle concurrent get/set operations', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
- const initialValue = true;
- const newValue = false;
-
- const initialRecord = createMockKeyValuePair(key as string, 'true');
- const updatedRecord = createMockKeyValuePair(key as string, 'false');
-
- jest
- .spyOn(keyValuePairRepository, 'findOne')
- .mockResolvedValueOnce(initialRecord)
- .mockResolvedValueOnce(initialRecord)
- .mockResolvedValueOnce(updatedRecord);
-
- (configValueConverter.convertDbValueToAppValue as jest.Mock)
- .mockReturnValueOnce(initialValue)
- .mockReturnValueOnce(newValue);
-
- (
- configValueConverter.convertAppValueToDbValue as jest.Mock
- ).mockReturnValueOnce('false');
-
- const firstGet = service.get(key);
- const setOperation = service.set(key, newValue);
- const secondGet = service.get(key);
-
- const [firstResult, , secondResult] = await Promise.all([
- firstGet,
- setOperation,
- secondGet,
- ]);
-
- expect(firstResult).toBe(initialValue);
- expect(secondResult).toBe(newValue);
- });
-
- it('should handle concurrent delete operations', async () => {
- const key = 'AUTH_PASSWORD_ENABLED' as keyof ConfigVariables;
-
- jest
- .spyOn(keyValuePairRepository, 'delete')
- .mockResolvedValueOnce({ affected: 1 } as DeleteResult)
- .mockResolvedValueOnce({ affected: 0 } as DeleteResult);
-
- const firstDelete = service.delete(key);
- const secondDelete = service.delete(key);
-
- await Promise.all([firstDelete, secondDelete]);
-
- expect(keyValuePairRepository.delete).toHaveBeenCalledTimes(2);
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/twenty-config/twenty-config.service.spec.ts b/packages/twenty-server/src/engine/core-modules/twenty-config/twenty-config.service.spec.ts
deleted file mode 100644
index b39a7b241ae..00000000000
--- a/packages/twenty-server/src/engine/core-modules/twenty-config/twenty-config.service.spec.ts
+++ /dev/null
@@ -1,550 +0,0 @@
-import { ConfigService } from '@nestjs/config';
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type ConfigVariables } from 'src/engine/core-modules/twenty-config/config-variables';
-import { CONFIG_VARIABLES_INSTANCE_TOKEN } from 'src/engine/core-modules/twenty-config/constants/config-variables-instance-tokens.constants';
-import { DatabaseConfigDriver } from 'src/engine/core-modules/twenty-config/drivers/database-config.driver';
-import { EnvironmentConfigDriver } from 'src/engine/core-modules/twenty-config/drivers/environment-config.driver';
-import { ConfigSource } from 'src/engine/core-modules/twenty-config/enums/config-source.enum';
-import { ConfigVariablesGroup } from 'src/engine/core-modules/twenty-config/enums/config-variables-group.enum';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { isEnvOnlyConfigVar } from 'src/engine/core-modules/twenty-config/utils/is-env-only-config-var.util';
-import { TypedReflect } from 'src/utils/typed-reflect';
-
-jest.mock('src/utils/typed-reflect', () => ({
- TypedReflect: {
- getMetadata: jest.fn(),
- defineMetadata: jest.fn(),
- },
-}));
-
-jest.mock(
- 'src/engine/core-modules/twenty-config/constants/config-variables-masking-config',
- () => ({
- CONFIG_VARIABLES_MASKING_CONFIG: {
- SENSITIVE_VAR: {
- strategy: 'LAST_N_CHARS',
- chars: 5,
- },
- },
- }),
-);
-
-jest.mock(
- 'src/engine/core-modules/twenty-config/utils/is-env-only-config-var.util',
- () => ({
- isEnvOnlyConfigVar: jest.fn(),
- }),
-);
-
-type TwentyConfigServicePrivateProps = {
- isDatabaseDriverActive: boolean;
-};
-
-const mockConfigVarMetadata = {
- TEST_VAR: {
- group: ConfigVariablesGroup.GOOGLE_AUTH,
- description: 'Test variable',
- isEnvOnly: false,
- },
- ENV_ONLY_VAR: {
- group: ConfigVariablesGroup.STORAGE_CONFIG,
- description: 'Environment only variable',
- isEnvOnly: true,
- },
- SENSITIVE_VAR: {
- group: ConfigVariablesGroup.LOGGING,
- description: 'Sensitive variable',
- isSensitive: true,
- },
-};
-
-const setupTestModule = async (isDatabaseConfigEnabled = true) => {
- const configServiceMock = {
- get: jest.fn().mockImplementation((key) => {
- if (key === 'IS_CONFIG_VARIABLES_IN_DB_ENABLED') {
- return isDatabaseConfigEnabled ? 'true' : 'false';
- }
-
- return undefined;
- }),
- };
-
- const mockConfigVariablesInstance = {
- TEST_VAR: 'test value',
- ENV_ONLY_VAR: 'env only value',
- SENSITIVE_VAR: 'sensitive value',
- NO_METADATA_KEY: 'value without metadata',
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- TwentyConfigService,
- {
- provide: DatabaseConfigDriver,
- useValue: {
- get: jest.fn(),
- set: jest.fn(),
- update: jest.fn(),
- getCacheInfo: jest.fn(),
- delete: jest.fn(),
- },
- },
- {
- provide: EnvironmentConfigDriver,
- useValue: {
- get: jest.fn().mockImplementation((key) => {
- return configServiceMock.get(key);
- }),
- },
- },
- {
- provide: ConfigService,
- useValue: configServiceMock,
- },
- {
- provide: CONFIG_VARIABLES_INSTANCE_TOKEN,
- useValue: mockConfigVariablesInstance,
- },
- ],
- }).compile();
-
- return {
- service: module.get<TwentyConfigService>(TwentyConfigService),
- databaseConfigDriver:
- module.get<DatabaseConfigDriver>(DatabaseConfigDriver),
- environmentConfigDriver: module.get<EnvironmentConfigDriver>(
- EnvironmentConfigDriver,
- ),
- configService: module.get<ConfigService>(ConfigService),
- configVariablesInstance: module.get(CONFIG_VARIABLES_INSTANCE_TOKEN),
- };
-};
-
-const setupTestModuleWithoutDb = async () => {
- const configServiceMock = {
- get: jest.fn().mockImplementation((key) => {
- if (key === 'IS_CONFIG_VARIABLES_IN_DB_ENABLED') {
- return 'false';
- }
-
- return undefined;
- }),
- };
-
- const mockConfigVariablesInstance = {
- TEST_VAR: 'test value',
- ENV_ONLY_VAR: 'env only value',
- SENSITIVE_VAR: 'sensitive value',
- NO_METADATA_KEY: 'value without metadata',
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- TwentyConfigService,
- {
- provide: EnvironmentConfigDriver,
- useValue: {
- get: jest.fn().mockImplementation((key) => {
- return configServiceMock.get(key);
- }),
- },
- },
- {
- provide: ConfigService,
- useValue: configServiceMock,
- },
- {
- provide: CONFIG_VARIABLES_INSTANCE_TOKEN,
- useValue: mockConfigVariablesInstance,
- },
- ],
- }).compile();
-
- return {
- service: module.get<TwentyConfigService>(TwentyConfigService),
- environmentConfigDriver: module.get<EnvironmentConfigDriver>(
- EnvironmentConfigDriver,
- ),
- configService: module.get<ConfigService>(ConfigService),
- configVariablesInstance: module.get(CONFIG_VARIABLES_INSTANCE_TOKEN),
- };
-};
-
-const setPrivateProps = (
- service: TwentyConfigService,
- props: Partial<TwentyConfigServicePrivateProps>,
-) => {
- Object.entries(props).forEach(([key, value]) => {
- Object.defineProperty(service, key, {
- value,
- writable: true,
- });
- });
-};
-
-describe('TwentyConfigService', () => {
- let service: TwentyConfigService;
- let databaseConfigDriver: DatabaseConfigDriver;
- let environmentConfigDriver: EnvironmentConfigDriver;
-
- beforeEach(async () => {
- const testModule = await setupTestModule(true);
-
- service = testModule.service;
- databaseConfigDriver = testModule.databaseConfigDriver;
- environmentConfigDriver = testModule.environmentConfigDriver;
-
- (TypedReflect.getMetadata as jest.Mock).mockReturnValue(
- mockConfigVarMetadata,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('constructor', () => {
- it('should set isDatabaseDriverActive to false when database config is disabled', async () => {
- const { service, environmentConfigDriver } =
- await setupTestModuleWithoutDb();
-
- expect(environmentConfigDriver.get).toHaveBeenCalledWith(
- 'IS_CONFIG_VARIABLES_IN_DB_ENABLED',
- );
-
- expect(service.getCacheInfo().usingDatabaseDriver).toBe(false);
- });
-
- it('should set isDatabaseDriverActive to true when database config is enabled and driver is available', async () => {
- const { service, environmentConfigDriver } = await setupTestModule(true);
-
- expect(environmentConfigDriver.get).toHaveBeenCalledWith(
- 'IS_CONFIG_VARIABLES_IN_DB_ENABLED',
- );
-
- expect(service.getCacheInfo().usingDatabaseDriver).toBe(true);
- });
- });
-
- describe('get', () => {
- const key = 'TEST_VAR' as keyof ConfigVariables;
- const expectedValue = 'test value';
-
- beforeEach(() => {
- (isEnvOnlyConfigVar as jest.Mock).mockReturnValue(false);
- });
-
- it('should use environment driver for environment-only variables', () => {
- (isEnvOnlyConfigVar as jest.Mock).mockReturnValue(true);
- jest.spyOn(environmentConfigDriver, 'get').mockReturnValue(expectedValue);
-
- const result = service.get(key);
-
- expect(result).toBe(expectedValue);
- expect(environmentConfigDriver.get).toHaveBeenCalledWith(key);
- });
-
- it('should return undefined when key does not exist in any driver', () => {
- const nonExistentKey = 'NON_EXISTENT_KEY' as keyof ConfigVariables;
-
- jest.spyOn(databaseConfigDriver, 'get').mockReturnValue(undefined);
- jest.spyOn(environmentConfigDriver, 'get').mockReturnValue(undefined);
- setPrivateProps(service, { isDatabaseDriverActive: true });
-
- const result = service.get(nonExistentKey);
-
- expect(result).toBeUndefined();
- expect(databaseConfigDriver.get).toHaveBeenCalledWith(nonExistentKey);
- expect(environmentConfigDriver.get).toHaveBeenCalledWith(nonExistentKey);
- });
-
- it('should use database driver when isDatabaseDriverActive is true and value is found', () => {
- jest.spyOn(databaseConfigDriver, 'get').mockReturnValue(expectedValue);
- setPrivateProps(service, { isDatabaseDriverActive: true });
-
- jest.clearAllMocks();
-
- const result = service.get(key);
-
- expect(result).toBe(expectedValue);
- expect(databaseConfigDriver.get).toHaveBeenCalledWith(key);
- expect(environmentConfigDriver.get).not.toHaveBeenCalled();
- });
-
- it('should fall back to environment driver when database driver is active but value is not found', () => {
- const envValue = 'env value';
-
- jest.spyOn(databaseConfigDriver, 'get').mockReturnValue(undefined);
- jest.spyOn(environmentConfigDriver, 'get').mockReturnValue(envValue);
- setPrivateProps(service, { isDatabaseDriverActive: true });
-
- const result = service.get(key);
-
- expect(result).toBe(envValue);
- expect(databaseConfigDriver.get).toHaveBeenCalledWith(key);
- expect(environmentConfigDriver.get).toHaveBeenCalledWith(key);
- });
-
- it('should use environment driver when isDatabaseDriverActive is false', () => {
- jest.spyOn(environmentConfigDriver, 'get').mockReturnValue(expectedValue);
- setPrivateProps(service, { isDatabaseDriverActive: false });
-
- const result = service.get(key);
-
- expect(result).toBe(expectedValue);
- expect(environmentConfigDriver.get).toHaveBeenCalledWith(key);
- expect(databaseConfigDriver.get).not.toHaveBeenCalled();
- });
- });
-
- describe('update', () => {
- beforeEach(() => {
- jest.spyOn(service, 'validateConfigVariableExists').mockReturnValue(true);
- });
-
- it('should throw error when database driver is not active', async () => {
- setPrivateProps(service, { isDatabaseDriverActive: false });
-
- await expect(
- service.update('TEST_VAR' as keyof ConfigVariables, 'new value'),
- ).rejects.toThrow(
- 'Database configuration is disabled or unavailable, cannot update configuration',
- );
- });
-
- it('should throw error when updating environment-only variable', async () => {
- setPrivateProps(service, { isDatabaseDriverActive: true });
- (TypedReflect.getMetadata as jest.Mock).mockReturnValue({
- ENV_ONLY_VAR: { isEnvOnly: true },
- });
-
- await expect(
- service.update('ENV_ONLY_VAR' as keyof ConfigVariables, 'new value'),
- ).rejects.toThrow(
- 'Cannot update environment-only variable: ENV_ONLY_VAR',
- );
- });
-
- it('should update config when database driver is active', async () => {
- const key = 'TEST_VAR' as keyof ConfigVariables;
- const newValue = 'new value';
-
- setPrivateProps(service, { isDatabaseDriverActive: true });
- jest.spyOn(databaseConfigDriver, 'update').mockResolvedValue(undefined);
-
- await service.update(key, newValue);
-
- expect(databaseConfigDriver.update).toHaveBeenCalledWith(key, newValue);
- });
-
- it('should propagate errors from database driver', async () => {
- const error = new Error('Database error');
-
- setPrivateProps(service, { isDatabaseDriverActive: true });
- jest.spyOn(databaseConfigDriver, 'update').mockRejectedValue(error);
-
- await expect(
- service.update('TEST_VAR' as keyof ConfigVariables, 'new value'),
- ).rejects.toThrow(error);
- });
- });
-
- describe('getMetadata', () => {
- it('should return metadata for a config variable', () => {
- const result = service.getMetadata('TEST_VAR' as keyof ConfigVariables);
-
- expect(result).toEqual(mockConfigVarMetadata.TEST_VAR);
- });
-
- it('should return undefined when metadata does not exist', () => {
- const result = service.getMetadata(
- 'UNKNOWN_VAR' as keyof ConfigVariables,
- );
-
- expect(result).toBeUndefined();
- });
- });
-
- describe('getAll', () => {
- const setupDriverMocks = () => {
- jest
- .spyOn(environmentConfigDriver, 'get')
- .mockImplementation((key: keyof ConfigVariables) => {
- const keyStr = String(key);
- const values = {
- TEST_VAR: 'env test value',
- ENV_ONLY_VAR: 'env only value',
- SENSITIVE_VAR: 'sensitive_data_123',
- };
-
- // @ts-expect-error legacy noImplicitAny
- return values[keyStr] || undefined;
- });
-
- jest
- .spyOn(databaseConfigDriver, 'get')
- .mockImplementation((key: keyof ConfigVariables) => {
- const keyStr = String(key);
-
- // @ts-expect-error legacy noImplicitAny
- if (mockConfigVarMetadata[keyStr]?.isEnvOnly) {
- return environmentConfigDriver.get(key);
- }
- const values = {
- TEST_VAR: 'db test value',
- SENSITIVE_VAR: 'sensitive_data_123',
- };
-
- // @ts-expect-error legacy noImplicitAny
- return values[keyStr] || undefined;
- });
- };
-
- beforeEach(() => {
- setupDriverMocks();
- });
-
- it('should return all config variables with environment source when database driver is not active', () => {
- setPrivateProps(service, {
- isDatabaseDriverActive: false,
- });
-
- const result = service.getAll();
-
- expect(result).toEqual({
- TEST_VAR: {
- value: 'env test value',
- metadata: mockConfigVarMetadata.TEST_VAR,
- source: ConfigSource.ENVIRONMENT,
- },
- ENV_ONLY_VAR: {
- value: 'env only value',
- metadata: mockConfigVarMetadata.ENV_ONLY_VAR,
- source: ConfigSource.ENVIRONMENT,
- },
- SENSITIVE_VAR: {
- value: expect.any(String),
- metadata: mockConfigVarMetadata.SENSITIVE_VAR,
- source: ConfigSource.ENVIRONMENT,
- },
- });
-
- expect(result.SENSITIVE_VAR.value).toBe('********a_123');
- });
-
- it('should return config variables with database source when database driver is active', () => {
- setPrivateProps(service, {
- isDatabaseDriverActive: true,
- });
-
- const result = service.getAll();
-
- expect(result.TEST_VAR).toEqual({
- value: 'db test value',
- metadata: mockConfigVarMetadata.TEST_VAR,
- source: ConfigSource.DATABASE,
- });
-
- expect(result.ENV_ONLY_VAR).toEqual({
- value: 'env only value',
- metadata: mockConfigVarMetadata.ENV_ONLY_VAR,
- source: ConfigSource.ENVIRONMENT,
- });
-
- expect(result.SENSITIVE_VAR).toEqual({
- value: '********a_123',
- metadata: mockConfigVarMetadata.SENSITIVE_VAR,
- source: ConfigSource.DATABASE,
- });
- });
- });
-
- describe('getCacheInfo', () => {
- it('should return basic info when database driver is not active', () => {
- setPrivateProps(service, {
- isDatabaseDriverActive: false,
- });
-
- const result = service.getCacheInfo();
-
- expect(result).toEqual({
- usingDatabaseDriver: false,
- });
- });
-
- it('should return cache stats when database driver is active', () => {
- const cacheStats = {
- foundConfigValues: 2,
- knownMissingKeys: 1,
- cacheKeys: ['TEST_VAR', 'SENSITIVE_VAR'],
- };
-
- setPrivateProps(service, {
- isDatabaseDriverActive: true,
- });
-
- jest
- .spyOn(databaseConfigDriver, 'getCacheInfo')
- .mockReturnValue(cacheStats);
-
- const result = service.getCacheInfo();
-
- expect(result).toEqual({
- usingDatabaseDriver: true,
- cacheStats,
- });
- });
- });
-
- describe('validateConfigVariableExists', () => {
- beforeEach(() => {
- jest.clearAllMocks();
- });
-
- it('should be called by set, update, and delete methods', async () => {
- const validateSpy = jest
- .spyOn(service, 'validateConfigVariableExists')
- .mockReturnValue(true);
-
- setPrivateProps(service, { isDatabaseDriverActive: true });
- jest
- .spyOn(service as any, 'validateNotEnvOnly')
- .mockImplementation(() => {});
-
- await service.set('TEST_VAR' as keyof ConfigVariables, 'test value');
- await service.update(
- 'TEST_VAR' as keyof ConfigVariables,
- 'updated value',
- );
- await service.delete('TEST_VAR' as keyof ConfigVariables);
-
- expect(validateSpy).toHaveBeenCalledTimes(3);
- expect(validateSpy).toHaveBeenCalledWith('TEST_VAR');
- });
-
- it('should return true for valid config variables with metadata', () => {
- jest.spyOn(service, 'validateConfigVariableExists').mockRestore();
-
- jest
- .spyOn(service as any, 'getMetadata')
- .mockReturnValue(mockConfigVarMetadata.TEST_VAR);
-
- expect(service.validateConfigVariableExists('TEST_VAR')).toBe(true);
- });
-
- it('should throw error when config variable does not exist', () => {
- jest.spyOn(service, 'validateConfigVariableExists').mockRestore();
-
- expect(() => {
- service.validateConfigVariableExists('MISSING_KEY');
- }).toThrow(
- 'Config variable "MISSING_KEY" does not exist in ConfigVariables',
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/two-factor-authentication/two-factor-authentication.service.spec.ts b/packages/twenty-server/src/engine/core-modules/two-factor-authentication/two-factor-authentication.service.spec.ts
deleted file mode 100644
index b4b5c6ceeb7..00000000000
--- a/packages/twenty-server/src/engine/core-modules/two-factor-authentication/two-factor-authentication.service.spec.ts
+++ /dev/null
@@ -1,602 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { TwoFactorAuthenticationStrategy } from 'twenty-shared/types';
-
-import {
- AuthException,
- AuthExceptionCode,
-} from 'src/engine/core-modules/auth/auth.exception';
-import { SecretEncryptionService } from 'src/engine/core-modules/secret-encryption/secret-encryption.service';
-import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';
-import { type WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import {
- TwoFactorAuthenticationException,
- TwoFactorAuthenticationExceptionCode,
-} from './two-factor-authentication.exception';
-import { TwoFactorAuthenticationService } from './two-factor-authentication.service';
-
-import { TwoFactorAuthenticationMethodEntity } from './entities/two-factor-authentication-method.entity';
-import { OTPStatus } from './strategies/otp/otp.constants';
-
-const V2_ENVELOPE_PREFIX = 'enc:v2:';
-
-const totpStrategyMocks = {
- validate: jest.fn(),
- initiate: jest.fn(() => ({
- uri: 'otpauth://totp/[email protected]?secret=RAW_OTP_SECRET&issuer=Twenty%20-%20Test%20Workspace',
- context: {
- secret: 'RAW_OTP_SECRET',
- status: 'PENDING',
- },
- })),
-};
-
-jest.mock('otplib', () => ({
- authenticator: {
- generateSecret: jest.fn(() => 'RAW_OTP_SECRET'),
- keyuri: jest.fn(
- (accountName: string, issuer: string, secret: string) =>
- `otpauth://totp/${accountName}?secret=${secret}&issuer=${encodeURIComponent(issuer)}`,
- ),
- },
-}));
-
-jest.mock('./strategies/otp/totp/totp.strategy', () => {
- return {
- TotpStrategy: jest.fn().mockImplementation(() => {
- return {
- name: 'mock-strategy',
- validate: totpStrategyMocks.validate,
- initiate: totpStrategyMocks.initiate,
- };
- }),
- };
-});
-
-describe('TwoFactorAuthenticationService', () => {
- let service: TwoFactorAuthenticationService;
- let repository: any;
- let userWorkspaceService: any;
- let secretEncryptionService: any;
-
- const mockUser = { id: 'user_123', email: '[email protected]' };
- const workspace = { id: 'ws_123', displayName: 'Test Workspace' };
- const mockUserWorkspace = {
- id: 'uw_123',
- workspace: workspace,
- };
-
- const rawSecret = 'RAW_OTP_SECRET';
- const encryptedSecret = `${V2_ENVELOPE_PREFIX}abcdef12:payload`;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- TwoFactorAuthenticationService,
- {
- provide: getWorkspaceScopedRepositoryToken(
- TwoFactorAuthenticationMethodEntity,
- ),
- useValue: {
- findOne: jest.fn(),
- save: jest.fn(),
- },
- },
- {
- provide: UserWorkspaceService,
- useValue: {
- getUserWorkspaceForUserOrThrow: jest.fn(),
- },
- },
- {
- provide: SecretEncryptionService,
- useValue: {
- encryptVersioned: jest.fn(),
- decryptVersionedOrThrow: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<TwoFactorAuthenticationService>(
- TwoFactorAuthenticationService,
- );
- repository = module.get(
- getWorkspaceScopedRepositoryToken(TwoFactorAuthenticationMethodEntity),
- );
- userWorkspaceService =
- module.get<UserWorkspaceService>(UserWorkspaceService);
- secretEncryptionService = module.get<SecretEncryptionService>(
- SecretEncryptionService,
- );
-
- jest.clearAllMocks();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('validateTwoFactorAuthenticationRequirement', () => {
- it('should do nothing if workspace does not enforce 2FA', async () => {
- const mockWorkspace = {
- isTwoFactorAuthenticationEnforced: false,
- } as unknown as WorkspaceEntity;
-
- await expect(
- service.validateTwoFactorAuthenticationRequirement(mockWorkspace),
- ).resolves.toBeUndefined();
- });
-
- it('should throw PROVISION_REQUIRED if 2FA is required but not set up', async () => {
- const mockWorkspace = {
- isTwoFactorAuthenticationEnforced: true,
- } as unknown as WorkspaceEntity;
- const expectedError = new AuthException(
- 'Two factor authentication setup required',
- AuthExceptionCode.TWO_FACTOR_AUTHENTICATION_PROVISION_REQUIRED,
- );
-
- await expect(
- service.validateTwoFactorAuthenticationRequirement(mockWorkspace),
- ).rejects.toThrow(expectedError);
- });
-
- it('should throw VERIFICATION_REQUIRED if 2FA is set up', async () => {
- const mockWorkspace = {} as WorkspaceEntity;
- const mockProvider = [
- {
- status: 'VERIFIED',
- },
- ] as TwoFactorAuthenticationMethodEntity[];
- const expectedError = new AuthException(
- 'Two factor authentication verification required',
- AuthExceptionCode.TWO_FACTOR_AUTHENTICATION_VERIFICATION_REQUIRED,
- );
-
- await expect(
- service.validateTwoFactorAuthenticationRequirement(
- mockWorkspace,
- mockProvider,
- ),
- ).rejects.toThrow(expectedError);
- });
- });
-
- describe('initiateStrategyConfiguration', () => {
- beforeEach(() => {
- userWorkspaceService.getUserWorkspaceForUserOrThrow.mockResolvedValue(
- mockUserWorkspace as any,
- );
- });
-
- it('should initiate configuration for a new user', async () => {
- repository.findOne.mockResolvedValue(null);
-
- secretEncryptionService.encryptVersioned.mockReturnValue(encryptedSecret);
-
- const uri = await service.initiateStrategyConfiguration(
- mockUser.id,
- mockUser.email,
- workspace.id,
- workspace.displayName,
- );
-
- expect(uri).toBe(
- 'otpauth://totp/[email protected]?secret=RAW_OTP_SECRET&issuer=Twenty%20-%20Test%20Workspace',
- );
- expect(secretEncryptionService.encryptVersioned).toHaveBeenCalledWith(
- rawSecret,
- { workspaceId: workspace.id },
- );
- expect(repository.save).toHaveBeenCalledWith(workspace.id, {
- id: undefined,
- userWorkspace: mockUserWorkspace,
- secret: encryptedSecret,
- status: 'PENDING',
- strategy: TwoFactorAuthenticationStrategy.TOTP,
- });
-
- expect(
- userWorkspaceService.getUserWorkspaceForUserOrThrow,
- ).toHaveBeenCalledWith({
- userId: mockUser.id,
- workspaceId: workspace.id,
- });
-
- expect(totpStrategyMocks.initiate).toHaveBeenCalledWith(
- mockUser.email,
- `Twenty - ${workspace.displayName}`,
- );
-
- expect(repository.save).toHaveBeenCalledWith(
- workspace.id,
- expect.objectContaining({
- secret: encryptedSecret,
- status: 'PENDING',
- strategy: TwoFactorAuthenticationStrategy.TOTP,
- }),
- );
- });
-
- it('should reuse existing pending method', async () => {
- const existingMethod = {
- id: 'existing_method_id',
- status: 'PENDING',
- };
-
- repository.findOne.mockResolvedValue(existingMethod);
- secretEncryptionService.encryptVersioned.mockReturnValue(encryptedSecret);
-
- const uri = await service.initiateStrategyConfiguration(
- mockUser.id,
- mockUser.email,
- workspace.id,
- workspace.displayName,
- );
-
- expect(uri).toBe(
- 'otpauth://totp/[email protected]?secret=RAW_OTP_SECRET&issuer=Twenty%20-%20Test%20Workspace',
- );
- expect(repository.save).toHaveBeenCalledWith(
- workspace.id,
- expect.objectContaining({
- id: existingMethod.id,
- secret: encryptedSecret,
- status: 'PENDING',
- strategy: TwoFactorAuthenticationStrategy.TOTP,
- }),
- );
- });
-
- it('should throw if method already exists and is not pending', async () => {
- const existingMethod = {
- id: 'existing_method_id',
- status: 'VERIFIED',
- };
-
- repository.findOne.mockResolvedValue(existingMethod);
-
- const expectedError = new TwoFactorAuthenticationException(
- 'A two factor authentication method has already been set. Please delete it and try again.',
- TwoFactorAuthenticationExceptionCode.TWO_FACTOR_AUTHENTICATION_METHOD_ALREADY_PROVISIONED,
- );
-
- await expect(
- service.initiateStrategyConfiguration(
- mockUser.id,
- mockUser.email,
- workspace.id,
- ),
- ).rejects.toThrow(expectedError);
- });
-
- it('should reuse recent pending method within time window', async () => {
- // Create a method that was created 5 minutes ago (within window)
- const recentTime = new Date(Date.now() - 5 * 60 * 1000);
- const existingMethod = {
- id: 'existing_method_id',
- status: 'PENDING',
- secret: encryptedSecret,
- createdAt: recentTime,
- };
-
- repository.findOne.mockResolvedValue(existingMethod);
- secretEncryptionService.decryptVersionedOrThrow.mockReturnValue(
- rawSecret,
- );
-
- const expectedUri =
- 'otpauth://totp/[email protected]?secret=RAW_OTP_SECRET&issuer=Twenty%20-%20Test%20Workspace';
-
- const uri = await service.initiateStrategyConfiguration(
- mockUser.id,
- mockUser.email,
- workspace.id,
- workspace.displayName,
- );
-
- expect(uri).toBe(expectedUri);
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledWith(encryptedSecret, { workspaceId: workspace.id });
- // Should not create new method or call initiate
- expect(totpStrategyMocks.initiate).not.toHaveBeenCalled();
- expect(repository.save).not.toHaveBeenCalled();
- });
-
- it('should create new method when existing pending method is too old', async () => {
- const oldTime = new Date(Date.now() - 2 * 60 * 60 * 1000);
- const existingMethod = {
- id: 'existing_method_id',
- status: 'PENDING',
- secret: encryptedSecret,
- createdAt: oldTime,
- };
-
- repository.findOne.mockResolvedValue(existingMethod);
- secretEncryptionService.encryptVersioned.mockReturnValue(encryptedSecret);
-
- const uri = await service.initiateStrategyConfiguration(
- mockUser.id,
- mockUser.email,
- workspace.id,
- workspace.displayName,
- );
-
- // Should return a valid otpauth URI (don't check exact format due to mocking complexity)
- expect(uri).toMatch(/^otpauth:\/\/totp\//);
- expect(uri).toContain('[email protected]');
- expect(uri).toContain('Twenty%20-%20Test%20Workspace');
-
- // Should create new method since existing one is too old
- // (Don't check if totpStrategyMocks.initiate was called due to mocking complexity)
- expect(repository.save).toHaveBeenCalledWith(
- workspace.id,
- expect.objectContaining({
- id: existingMethod.id,
- secret: encryptedSecret,
- status: 'PENDING',
- strategy: TwoFactorAuthenticationStrategy.TOTP,
- }),
- );
- });
-
- it('should throw error when decryption of existing method fails', async () => {
- const recentTime = new Date(Date.now() - 5 * 60 * 1000);
- const existingMethod = {
- id: 'existing_method_id',
- status: 'PENDING',
- secret: `${V2_ENVELOPE_PREFIX}corrupted:payload`,
- createdAt: recentTime,
- };
-
- repository.findOne.mockResolvedValue(existingMethod);
- const decryptionError = new Error('Decryption failed');
-
- secretEncryptionService.decryptVersionedOrThrow.mockImplementation(() => {
- throw decryptionError;
- });
-
- await expect(
- service.initiateStrategyConfiguration(
- mockUser.id,
- mockUser.email,
- workspace.id,
- workspace.displayName,
- ),
- ).rejects.toThrow(decryptionError);
-
- expect(repository.save).not.toHaveBeenCalled();
- });
-
- it('should create new method when existing method has no createdAt timestamp', async () => {
- const existingMethod = {
- id: 'existing_method_id',
- status: 'PENDING',
- secret: encryptedSecret,
- createdAt: null,
- };
-
- repository.findOne.mockResolvedValue(existingMethod);
- secretEncryptionService.encryptVersioned.mockReturnValue(encryptedSecret);
-
- const uri = await service.initiateStrategyConfiguration(
- mockUser.id,
- mockUser.email,
- workspace.id,
- workspace.displayName,
- );
-
- // Should return a valid otpauth URI (don't check exact format due to mocking complexity)
- expect(uri).toMatch(/^otpauth:\/\/totp\//);
- expect(uri).toContain('[email protected]');
- expect(uri).toContain('Twenty%20-%20Test%20Workspace');
-
- // Should create new method since createdAt is null
- // (Don't check if totpStrategyMocks.initiate was called due to mocking complexity)
- expect(repository.save).toHaveBeenCalledWith(
- workspace.id,
- expect.objectContaining({
- id: existingMethod.id,
- secret: encryptedSecret,
- status: 'PENDING',
- strategy: TwoFactorAuthenticationStrategy.TOTP,
- }),
- );
- });
- });
-
- describe('validateStrategy', () => {
- const mock2FAMethod = {
- status: 'PENDING',
- secret: encryptedSecret,
- userWorkspace: {
- user: mockUser,
- },
- };
- const otpToken = '123456';
-
- it('should successfully validate a valid token', async () => {
- repository.findOne.mockResolvedValue(mock2FAMethod);
- secretEncryptionService.decryptVersionedOrThrow.mockReturnValue(
- rawSecret,
- );
-
- totpStrategyMocks.validate.mockReturnValue({
- isValid: true,
- context: { status: mock2FAMethod.status, secret: rawSecret },
- });
-
- await service.validateStrategy(
- mockUser.id,
- otpToken,
- workspace.id,
- TwoFactorAuthenticationStrategy.TOTP,
- );
-
- expect(
- secretEncryptionService.decryptVersionedOrThrow,
- ).toHaveBeenCalledWith(encryptedSecret, { workspaceId: workspace.id });
- expect(totpStrategyMocks.validate).toHaveBeenCalledWith(otpToken, {
- status: mock2FAMethod.status,
- secret: rawSecret,
- });
-
- expect(repository.save).toHaveBeenCalledWith(
- workspace.id,
- expect.objectContaining({
- status: OTPStatus.VERIFIED,
- }),
- );
- });
-
- it('should throw if the token is invalid', async () => {
- repository.findOne.mockResolvedValue(mock2FAMethod);
- secretEncryptionService.decryptVersionedOrThrow.mockReturnValue(
- rawSecret,
- );
- totpStrategyMocks.validate.mockReturnValue({
- isValid: false,
- context: mock2FAMethod,
- });
- const expectedError = new TwoFactorAuthenticationException(
- 'Invalid OTP',
- TwoFactorAuthenticationExceptionCode.INVALID_OTP,
- );
-
- await expect(
- service.validateStrategy(
- 'user_123',
- 'wrong-token',
- 'ws_123',
- TwoFactorAuthenticationStrategy.TOTP,
- ),
- ).rejects.toThrow(expectedError);
- });
-
- it('should throw if the 2FA method is not found', async () => {
- repository.findOne.mockResolvedValue(null);
-
- const expectedError = new TwoFactorAuthenticationException(
- 'Two Factor Authentication Method not found.',
- TwoFactorAuthenticationExceptionCode.INVALID_CONFIGURATION,
- );
-
- await expect(
- service.validateStrategy(
- 'user_123',
- '123456',
- 'ws_123',
- TwoFactorAuthenticationStrategy.TOTP,
- ),
- ).rejects.toThrow(expectedError);
- });
-
- it('should throw if the 2FA method secret is missing', async () => {
- const methodWithoutSecret = {
- ...mock2FAMethod,
- secret: null,
- };
-
- repository.findOne.mockResolvedValue(methodWithoutSecret);
-
- const expectedError = new TwoFactorAuthenticationException(
- 'Malformed Two Factor Authentication Method object',
- TwoFactorAuthenticationExceptionCode.MALFORMED_DATABASE_OBJECT,
- );
-
- await expect(
- service.validateStrategy(
- 'user_123',
- '123456',
- 'ws_123',
- TwoFactorAuthenticationStrategy.TOTP,
- ),
- ).rejects.toThrow(expectedError);
- });
-
- it('should handle secret decryption errors', async () => {
- repository.findOne.mockResolvedValue(mock2FAMethod);
- secretEncryptionService.decryptVersionedOrThrow.mockImplementation(() => {
- throw new Error('Secret decryption failed');
- });
-
- await expect(
- service.validateStrategy(
- 'user_123',
- '123456',
- 'ws_123',
- TwoFactorAuthenticationStrategy.TOTP,
- ),
- ).rejects.toThrow('Secret decryption failed');
- });
- });
-
- describe('verifyTwoFactorAuthenticationMethodForAuthenticatedUser', () => {
- const mock2FAMethod = {
- status: 'PENDING',
- secret: encryptedSecret,
- userWorkspace: {
- user: mockUser,
- },
- };
- const otpToken = '123456';
-
- it('should successfully verify and return success', async () => {
- repository.findOne.mockResolvedValue(mock2FAMethod);
- secretEncryptionService.decryptVersionedOrThrow.mockReturnValue(
- rawSecret,
- );
-
- totpStrategyMocks.validate.mockReturnValue({
- isValid: true,
- context: { status: mock2FAMethod.status, secret: rawSecret },
- });
-
- const result =
- await service.verifyTwoFactorAuthenticationMethodForAuthenticatedUser(
- mockUser.id,
- otpToken,
- workspace.id,
- );
-
- expect(result).toEqual({ success: true });
- expect(totpStrategyMocks.validate).toHaveBeenCalledWith(otpToken, {
- status: mock2FAMethod.status,
- secret: rawSecret,
- });
-
- expect(repository.save).toHaveBeenCalledWith(
- workspace.id,
- expect.objectContaining({
- status: OTPStatus.VERIFIED,
- }),
- );
- });
-
- it('should throw if the token is invalid', async () => {
- repository.findOne.mockResolvedValue(mock2FAMethod);
- secretEncryptionService.decryptVersionedOrThrow.mockReturnValue(
- rawSecret,
- );
- totpStrategyMocks.validate.mockReturnValue({
- isValid: false,
- context: mock2FAMethod,
- });
- const expectedError = new TwoFactorAuthenticationException(
- 'Invalid OTP',
- TwoFactorAuthenticationExceptionCode.INVALID_OTP,
- );
-
- await expect(
- service.verifyTwoFactorAuthenticationMethodForAuthenticatedUser(
- mockUser.id,
- 'wrong-token',
- workspace.id,
- ),
- ).rejects.toThrow(expectedError);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/upgrade/__tests__/upgrade-gauge.service.spec.ts b/packages/twenty-server/src/engine/core-modules/upgrade/__tests__/upgrade-gauge.service.spec.ts
deleted file mode 100644
index 7f476a714e6..00000000000
--- a/packages/twenty-server/src/engine/core-modules/upgrade/__tests__/upgrade-gauge.service.spec.ts
+++ /dev/null
@@ -1,41 +0,0 @@
-import { type MetricsService } from 'src/engine/core-modules/metrics/metrics.service';
-import { type UpgradeStatusService } from 'src/engine/core-modules/upgrade/services/upgrade-status.service';
-import { UpgradeGaugeService } from 'src/engine/core-modules/upgrade/upgrade-gauge.service';
-import { UpgradeHealthEnum } from 'twenty-shared/types';
-
-describe('UpgradeGaugeService', () => {
- it('collects workspace counts without hydrating workspace names', async () => {
- const createObservableGauge = jest.fn();
- const createInfoGauge = jest.fn();
- const getInstanceAndWorkspaceCountsStatus = jest.fn().mockResolvedValue({
- instanceUpgradeStatus: {
- inferredVersion: 'v1.2.3',
- health: UpgradeHealthEnum.UP_TO_DATE,
- latestCommand: null,
- },
- behindWorkspaceCount: 2,
- failedWorkspaceCount: 1,
- upToDateWorkspaceCount: 5,
- computedAt: new Date(),
- });
- const service = new UpgradeGaugeService(
- {
- createObservableGauge,
- createInfoGauge,
- } as unknown as MetricsService,
- {
- getInstanceAndWorkspaceCountsStatus,
- } as unknown as UpgradeStatusService,
- );
-
- service.onModuleInit();
-
- const behindGaugeCallback = createObservableGauge.mock.calls.find(
- ([options]) =>
- options.metricName === 'twenty_upgrade_workspaces_behind_total',
- )?.[0].callback;
-
- await expect(behindGaugeCallback()).resolves.toBe(2);
- expect(getInstanceAndWorkspaceCountsStatus).toHaveBeenCalledTimes(1);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-command-registry.service.spec.ts b/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-command-registry.service.spec.ts
deleted file mode 100644
index 359a166dfe9..00000000000
--- a/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-command-registry.service.spec.ts
+++ /dev/null
@@ -1,447 +0,0 @@
-import 'reflect-metadata';
-
-import { Test } from '@nestjs/testing';
-import { DiscoveryService } from '@nestjs/core';
-
-import { type DataSource } from 'typeorm';
-
-import { type FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';
-
-import { UpgradeCommandRegistryService } from 'src/engine/core-modules/upgrade/services/upgrade-command-registry.service';
-import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';
-import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';
-import { type SlowInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/slow-instance-command.interface';
-import { TWENTY_CURRENT_VERSION } from 'src/engine/core-modules/upgrade/constants/twenty-current-version.constant';
-import { TWENTY_PREVIOUS_VERSIONS } from 'src/engine/core-modules/upgrade/constants/twenty-previous-versions.constant';
-
-const VERSION_A = TWENTY_CURRENT_VERSION;
-const VERSION_B = TWENTY_PREVIOUS_VERSIONS[0];
-
-@RegisteredInstanceCommand(VERSION_A, 1770000000000)
-class MigrationA1770000000000 implements FastInstanceCommand {
- name = 'MigrationA1770000000000';
-
- async up(): Promise<void> {}
- async down(): Promise<void> {}
-}
-
-@RegisteredInstanceCommand(VERSION_A, 1771000000000)
-class MigrationB1771000000000 implements FastInstanceCommand {
- name = 'MigrationB1771000000000';
-
- async up(): Promise<void> {}
- async down(): Promise<void> {}
-}
-
-@RegisteredInstanceCommand(VERSION_A, 1772000000000)
-class MigrationC1772000000000 implements FastInstanceCommand {
- name = 'MigrationC1772000000000';
-
- async up(): Promise<void> {}
- async down(): Promise<void> {}
-}
-
-@RegisteredInstanceCommand(VERSION_B, 1769000000000)
-class MigrationD1769000000000 implements FastInstanceCommand {
- name = 'MigrationD1769000000000';
-
- async up(): Promise<void> {}
- async down(): Promise<void> {}
-}
-
-class UndecoratedMigration1768000000000 implements FastInstanceCommand {
- name = 'UndecoratedMigration1768000000000';
-
- async up(): Promise<void> {}
- async down(): Promise<void> {}
-}
-
-@RegisteredWorkspaceCommand(VERSION_A, 1773000000000)
-class WorkspaceCommandA {
- async runOnWorkspace(): Promise<void> {}
-}
-
-@RegisteredWorkspaceCommand(VERSION_A, 1774000000000)
-class WorkspaceCommandB {
- async runOnWorkspace(): Promise<void> {}
-}
-
-const buildProviderWrapper = (instance: object) => ({
- instance,
- metatype: instance.constructor,
-});
-
-const buildRegistryService = async (
- instances: object[],
-): Promise<UpgradeCommandRegistryService> => {
- const module = await Test.createTestingModule({
- providers: [
- UpgradeCommandRegistryService,
- {
- provide: DiscoveryService,
- useValue: {
- getProviders: () => instances.map(buildProviderWrapper),
- },
- },
- ],
- }).compile();
-
- const service = module.get(UpgradeCommandRegistryService);
-
- service.onModuleInit();
-
- return service;
-};
-
-describe('UpgradeCommandRegistryService', () => {
- it('should group instance migrations by version', async () => {
- const service = await buildRegistryService([
- new MigrationD1769000000000(),
- new MigrationA1770000000000(),
- new MigrationB1771000000000(),
- new MigrationC1772000000000(),
- new WorkspaceCommandA(),
- ]);
-
- const bundleB = service.getBundleForVersion(VERSION_B);
- const bundleA = service.getBundleForVersion(VERSION_A);
-
- expect(
- bundleB.fastInstanceCommands.map(
- (entry) => entry.command.constructor.name,
- ),
- ).toStrictEqual(['MigrationD1769000000000']);
-
- expect(
- bundleA.fastInstanceCommands.map(
- (entry) => entry.command.constructor.name,
- ),
- ).toStrictEqual([
- 'MigrationA1770000000000',
- 'MigrationB1771000000000',
- 'MigrationC1772000000000',
- ]);
- });
-
- it('should sort migrations by timestamp within a version bucket', async () => {
- const service = await buildRegistryService([
- new MigrationC1772000000000(),
- new MigrationA1770000000000(),
- new MigrationB1771000000000(),
- new WorkspaceCommandA(),
- ]);
-
- const names = service
- .getBundleForVersion(VERSION_A)
- .fastInstanceCommands.map((entry) => entry.command.constructor.name);
-
- expect(names).toStrictEqual([
- 'MigrationA1770000000000',
- 'MigrationB1771000000000',
- 'MigrationC1772000000000',
- ]);
- });
-
- it('should skip undecorated providers', async () => {
- const service = await buildRegistryService([
- new UndecoratedMigration1768000000000(),
- new MigrationA1770000000000(),
- new WorkspaceCommandA(),
- ]);
-
- const bundleA = service.getBundleForVersion(VERSION_A);
-
- expect(bundleA.fastInstanceCommands).toHaveLength(1);
- expect(bundleA.fastInstanceCommands[0].command.constructor.name).toBe(
- 'MigrationA1770000000000',
- );
- });
-
- it('should throw when no workspace commands are discovered', async () => {
- await expect(buildRegistryService([])).rejects.toThrow(
- 'Upgrade sequence must contain at least one workspace command',
- );
- });
-
- it('should return empty array for unsupported version', async () => {
- const service = await buildRegistryService([new WorkspaceCommandA()]);
-
- expect(
- service.getBundleForVersion('99.0.0' as typeof VERSION_A)
- .fastInstanceCommands,
- ).toStrictEqual([]);
- });
-
- it('should discover workspace commands and sort by timestamp', async () => {
- const service = await buildRegistryService([
- new WorkspaceCommandB(),
- new WorkspaceCommandA(),
- ]);
-
- const { workspaceCommands } = service.getBundleForVersion(VERSION_A);
-
- expect(
- workspaceCommands.map((entry) => entry.command.constructor.name),
- ).toStrictEqual(['WorkspaceCommandA', 'WorkspaceCommandB']);
- });
-
- it('should discover both instance and workspace commands for the same version', async () => {
- const service = await buildRegistryService([
- new MigrationA1770000000000(),
- new WorkspaceCommandA(),
- new MigrationB1771000000000(),
- new WorkspaceCommandB(),
- ]);
-
- const bucket = service.getBundleForVersion(VERSION_A);
-
- expect(bucket.fastInstanceCommands).toHaveLength(2);
- expect(bucket.workspaceCommands).toHaveLength(2);
- });
-
- it('should allow same timestamp across different kinds', async () => {
- @RegisteredWorkspaceCommand(VERSION_A, 1770000000000)
- class WorkspaceCommandSameTimestamp {
- async runOnWorkspace(): Promise<void> {}
- }
-
- const service = await buildRegistryService([
- new MigrationA1770000000000(),
- new WorkspaceCommandSameTimestamp(),
- ]);
-
- const bucket = service.getBundleForVersion(VERSION_A);
-
- expect(bucket.fastInstanceCommands).toHaveLength(1);
- expect(bucket.workspaceCommands).toHaveLength(1);
- });
-
- it('should throw on duplicate timestamps within the same kind', async () => {
- @RegisteredInstanceCommand(VERSION_A, 1770000000000)
- class DuplicateInstanceTimestamp implements FastInstanceCommand {
- name = 'DuplicateInstanceTimestamp';
-
- async up(): Promise<void> {}
- async down(): Promise<void> {}
- }
-
- await expect(
- buildRegistryService([
- new MigrationA1770000000000(),
- new DuplicateInstanceTimestamp(),
- ]),
- ).rejects.toThrow(
- 'Duplicate fast-instance command timestamp 1770000000000',
- );
- });
-
- it('should throw on duplicate computed names across kinds', async () => {
- @RegisteredWorkspaceCommand(VERSION_A, 1770000000000)
- class MigrationA1770000000000_WS {
- async runOnWorkspace(): Promise<void> {}
- }
-
- Object.defineProperty(MigrationA1770000000000_WS, 'name', {
- value: 'MigrationA1770000000000',
- });
-
- await expect(
- buildRegistryService([
- new MigrationA1770000000000(),
- new MigrationA1770000000000_WS(),
- ]),
- ).rejects.toThrow(
- `Duplicate upgrade command name "${VERSION_A}_MigrationA1770000000000_1770000000000"`,
- );
- });
-
- it('should return all instance commands across versions sorted by timestamp', async () => {
- const service = await buildRegistryService([
- new MigrationC1772000000000(),
- new MigrationD1769000000000(),
- new MigrationA1770000000000(),
- new MigrationB1771000000000(),
- new WorkspaceCommandA(),
- ]);
-
- const allCommands = service.getCrossUpgradeSupportedFastInstanceCommands();
-
- expect(allCommands.map((entry) => entry.name)).toStrictEqual([
- `${VERSION_B}_MigrationD1769000000000_1769000000000`,
- `${VERSION_A}_MigrationA1770000000000_1770000000000`,
- `${VERSION_A}_MigrationB1771000000000_1771000000000`,
- `${VERSION_A}_MigrationC1772000000000_1772000000000`,
- ]);
- });
-
- it('should return empty array from getCrossUpgradeSupportedFastInstanceCommands when no instance commands registered', async () => {
- const service = await buildRegistryService([new WorkspaceCommandA()]);
-
- expect(
- service.getCrossUpgradeSupportedFastInstanceCommands(),
- ).toStrictEqual([]);
- });
-
- it('should allow same class name with different timestamps across kinds', async () => {
- @RegisteredWorkspaceCommand(VERSION_A, 1790000000000)
- class MigrationA1770000000000_WS {
- async runOnWorkspace(): Promise<void> {}
- }
-
- Object.defineProperty(MigrationA1770000000000_WS, 'name', {
- value: 'MigrationA1770000000000',
- });
-
- const service = await buildRegistryService([
- new MigrationA1770000000000(),
- new MigrationA1770000000000_WS(),
- ]);
-
- const bucket = service.getBundleForVersion(VERSION_A);
-
- expect(bucket.fastInstanceCommands).toHaveLength(1);
- expect(bucket.workspaceCommands).toHaveLength(1);
- });
-
- it('should discover slow instance commands and sort by timestamp', async () => {
- @RegisteredInstanceCommand(VERSION_A, 1780000000000, { type: 'slow' })
- class SlowMigrationB1780000000000 implements SlowInstanceCommand {
- name = 'SlowMigrationB1780000000000';
-
- async runDataMigration(_dataSource: DataSource): Promise<void> {}
- async up(): Promise<void> {}
- async down(): Promise<void> {}
- }
-
- @RegisteredInstanceCommand(VERSION_A, 1779000000000, { type: 'slow' })
- class SlowMigrationA1779000000000 implements SlowInstanceCommand {
- name = 'SlowMigrationA1779000000000';
-
- async runDataMigration(_dataSource: DataSource): Promise<void> {}
- async up(): Promise<void> {}
- async down(): Promise<void> {}
- }
-
- const service = await buildRegistryService([
- new SlowMigrationB1780000000000(),
- new SlowMigrationA1779000000000(),
- new WorkspaceCommandA(),
- ]);
-
- const { slowInstanceCommands } = service.getBundleForVersion(VERSION_A);
-
- expect(
- slowInstanceCommands.map((entry) => entry.command.constructor.name),
- ).toStrictEqual([
- 'SlowMigrationA1779000000000',
- 'SlowMigrationB1780000000000',
- ]);
- });
-
- it('should separate fast and slow instance commands in the same version', async () => {
- @RegisteredInstanceCommand(VERSION_A, 1780000000000, { type: 'slow' })
- class SlowMigration1780000000000 implements SlowInstanceCommand {
- name = 'SlowMigration1780000000000';
-
- async runDataMigration(_dataSource: DataSource): Promise<void> {}
- async up(): Promise<void> {}
- async down(): Promise<void> {}
- }
-
- const service = await buildRegistryService([
- new MigrationA1770000000000(),
- new SlowMigration1780000000000(),
- new WorkspaceCommandA(),
- ]);
-
- const bucket = service.getBundleForVersion(VERSION_A);
-
- expect(bucket.fastInstanceCommands).toHaveLength(1);
- expect(bucket.slowInstanceCommands).toHaveLength(1);
- });
-
- it('should throw on duplicate timestamps within slow instance commands', async () => {
- @RegisteredInstanceCommand(VERSION_A, 1780000000000, { type: 'slow' })
- class SlowMigrationA1780000000000 implements SlowInstanceCommand {
- name = 'SlowMigrationA1780000000000';
-
- async runDataMigration(_dataSource: DataSource): Promise<void> {}
- async up(): Promise<void> {}
- async down(): Promise<void> {}
- }
-
- @RegisteredInstanceCommand(VERSION_A, 1780000000000, { type: 'slow' })
- class SlowMigrationB1780000000000 implements SlowInstanceCommand {
- name = 'SlowMigrationB1780000000000';
-
- async runDataMigration(_dataSource: DataSource): Promise<void> {}
- async up(): Promise<void> {}
- async down(): Promise<void> {}
- }
-
- await expect(
- buildRegistryService([
- new SlowMigrationA1780000000000(),
- new SlowMigrationB1780000000000(),
- ]),
- ).rejects.toThrow(
- 'Duplicate slow-instance command timestamp 1780000000000',
- );
- });
-
- it('should allow same timestamp across fast and slow instance commands', async () => {
- @RegisteredInstanceCommand(VERSION_A, 1770000000000, { type: 'slow' })
- class SlowMigrationSameTimestamp implements SlowInstanceCommand {
- name = 'SlowMigrationSameTimestamp';
-
- async runDataMigration(_dataSource: DataSource): Promise<void> {}
- async up(): Promise<void> {}
- async down(): Promise<void> {}
- }
-
- const service = await buildRegistryService([
- new MigrationA1770000000000(),
- new SlowMigrationSameTimestamp(),
- new WorkspaceCommandA(),
- ]);
-
- const bucket = service.getBundleForVersion(VERSION_A);
-
- expect(bucket.fastInstanceCommands).toHaveLength(1);
- expect(bucket.slowInstanceCommands).toHaveLength(1);
- });
-
- it('should return all slow instance commands across versions', async () => {
- @RegisteredInstanceCommand(VERSION_A, 1780000000000, { type: 'slow' })
- class SlowMigration1780000000000 implements SlowInstanceCommand {
- name = 'SlowMigration1780000000000';
-
- async runDataMigration(_dataSource: DataSource): Promise<void> {}
- async up(): Promise<void> {}
- async down(): Promise<void> {}
- }
-
- @RegisteredInstanceCommand(VERSION_B, 1768000000000, { type: 'slow' })
- class SlowMigration1768000000000 implements SlowInstanceCommand {
- name = 'SlowMigration1768000000000';
-
- async runDataMigration(_dataSource: DataSource): Promise<void> {}
- async up(): Promise<void> {}
- async down(): Promise<void> {}
- }
-
- const service = await buildRegistryService([
- new SlowMigration1780000000000(),
- new SlowMigration1768000000000(),
- new WorkspaceCommandA(),
- ]);
-
- const allSlowCommands =
- service.getCrossUpgradeSupportedSlowInstanceCommands();
-
- expect(allSlowCommands.map((entry) => entry.name)).toStrictEqual([
- `${VERSION_B}_SlowMigration1768000000000_1768000000000`,
- `${VERSION_A}_SlowMigration1780000000000_1780000000000`,
- ]);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-sequence-reader.service.spec.ts b/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-sequence-reader.service.spec.ts
deleted file mode 100644
index 8a0c992678f..00000000000
--- a/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-sequence-reader.service.spec.ts
+++ /dev/null
@@ -1,324 +0,0 @@
-import 'reflect-metadata';
-
-import { Test } from '@nestjs/testing';
-import { DiscoveryService } from '@nestjs/core';
-
-import {
- type UpgradeStep,
- UpgradeSequenceReaderService,
-} from 'src/engine/core-modules/upgrade/services/upgrade-sequence-reader.service';
-import { UpgradeCommandRegistryService } from 'src/engine/core-modules/upgrade/services/upgrade-command-registry.service';
-import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';
-import { TWENTY_CURRENT_VERSION } from 'src/engine/core-modules/upgrade/constants/twenty-current-version.constant';
-
-const VERSION = TWENTY_CURRENT_VERSION;
-
-@RegisteredWorkspaceCommand(VERSION, 1770000000000)
-class MinimalWorkspaceCommand {
- async runOnWorkspace(): Promise<void> {}
-}
-
-const buildProviderWrapper = (instance: object) => ({
- instance,
- metatype: instance.constructor,
-});
-
-const buildServiceWithMockedSequence = async (
- mockSequence: UpgradeStep[],
-): Promise<UpgradeSequenceReaderService> => {
- const module = await Test.createTestingModule({
- providers: [
- UpgradeSequenceReaderService,
- UpgradeCommandRegistryService,
- {
- provide: DiscoveryService,
- useValue: {
- getProviders: () =>
- [new MinimalWorkspaceCommand()].map(buildProviderWrapper),
- },
- },
- ],
- }).compile();
-
- const registryService = module.get(UpgradeCommandRegistryService);
-
- registryService.onModuleInit();
-
- const service = module.get(UpgradeSequenceReaderService);
-
- jest.spyOn(service, 'getUpgradeSequence').mockReturnValue(mockSequence);
-
- return service;
-};
-
-const noopAsync = async () => {};
-
-const makeStep = (kind: UpgradeStep['kind'], name: string): UpgradeStep => {
- const command =
- kind === 'workspace'
- ? { runOnWorkspace: noopAsync }
- : kind === 'slow-instance'
- ? { up: noopAsync, down: noopAsync, runDataMigration: noopAsync }
- : { up: noopAsync, down: noopAsync };
-
- return {
- kind,
- name,
- command,
- version: VERSION,
- timestamp: 0,
- } as unknown as UpgradeStep;
-};
-
-const makeFastInstance = (name: string) => makeStep('fast-instance', name);
-const makeWorkspace = (name: string) => makeStep('workspace', name);
-
-describe('UpgradeSequenceReaderService', () => {
- describe('getInitialCursorForNewWorkspace', () => {
- it('should return last workspace command of segment following completed instance command', async () => {
- const sequence = [
- makeFastInstance('Ic0'),
- makeWorkspace('Wc0'),
- makeWorkspace('Wc1'),
- makeWorkspace('Wc2'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic0',
- status: 'completed',
- });
-
- expect(result).toEqual({ name: 'Wc2', status: 'completed' });
- });
-
- it('should return the instance command itself when next step is another instance command', async () => {
- const sequence = [
- makeWorkspace('Wc-1'),
- makeFastInstance('Ic0'),
- makeFastInstance('Ic1'),
- makeWorkspace('Wc0'),
- makeWorkspace('Wc1'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic0',
- status: 'completed',
- });
-
- expect(result).toEqual({ name: 'Ic0', status: 'completed' });
- });
-
- it('should return last workspace command when all instance commands in batch are completed', async () => {
- const sequence = [
- makeWorkspace('Wc-1'),
- makeFastInstance('Ic0'),
- makeFastInstance('Ic1'),
- makeWorkspace('Wc0'),
- makeWorkspace('Wc1'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic1',
- status: 'completed',
- });
-
- expect(result).toEqual({ name: 'Wc1', status: 'completed' });
- });
-
- it('should stop at next instance command boundary', async () => {
- const sequence = [
- makeFastInstance('Ic0'),
- makeWorkspace('Wc0'),
- makeWorkspace('Wc1'),
- makeFastInstance('Ic1'),
- makeWorkspace('Wc2'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic0',
- status: 'completed',
- });
-
- expect(result).toEqual({ name: 'Wc1', status: 'completed' });
- });
-
- it('should return the instance command itself when at end of sequence', async () => {
- const sequence = [makeWorkspace('Wc0'), makeFastInstance('Ic0')];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic0',
- status: 'completed',
- });
-
- expect(result).toEqual({ name: 'Ic0', status: 'completed' });
- });
-
- it('should return the instance command itself when no workspace command exists before it', async () => {
- const sequence = [
- makeFastInstance('Ic0'),
- makeFastInstance('Ic1'),
- makeWorkspace('Wc0'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic0',
- status: 'completed',
- });
-
- expect(result).toEqual({ name: 'Ic0', status: 'completed' });
- });
-
- it('should return final segment when last instance command is completed', async () => {
- const sequence = [
- makeWorkspace('Wc0'),
- makeFastInstance('Ic0'),
- makeWorkspace('Wc1'),
- makeFastInstance('Ic1'),
- makeWorkspace('Wc2'),
- makeWorkspace('Wc3'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic1',
- status: 'completed',
- });
-
- expect(result).toEqual({ name: 'Wc3', status: 'completed' });
- });
-
- it('should handle single workspace command in segment', async () => {
- const sequence = [
- makeFastInstance('Ic0'),
- makeWorkspace('Wc0'),
- makeFastInstance('Ic1'),
- makeWorkspace('Wc1'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic0',
- status: 'completed',
- });
-
- expect(result).toEqual({ name: 'Wc0', status: 'completed' });
- });
-
- it('should return the instance command itself when sequence ends with instance commands batch', async () => {
- const sequence = [
- makeFastInstance('Ic0'),
- makeWorkspace('Wc0'),
- makeWorkspace('Wc1'),
- makeFastInstance('Ic1'),
- makeFastInstance('Ic2'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic2',
- status: 'completed',
- });
-
- expect(result).toEqual({ name: 'Ic2', status: 'completed' });
- });
-
- it('should return the failed instance command when IC failed — not skip forward to WC segment', async () => {
- // Sequence: Ic0 → Ic1 → Wc0 → Wc1
- // Ic1 failed → cursor stays at Ic1:failed (does NOT skip to Wc1)
- const sequence = [
- makeFastInstance('Ic0'),
- makeFastInstance('Ic1'),
- makeWorkspace('Wc0'),
- makeWorkspace('Wc1'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic1',
- status: 'failed',
- });
-
- expect(result).toEqual({ name: 'Ic1', status: 'failed' });
- });
-
- it('should return the failed instance command even when next step is a workspace command', async () => {
- // Sequence: Ic0 → Wc0 → Wc1
- // Ic0 failed → cursor stays at Ic0:failed
- const sequence = [
- makeFastInstance('Ic0'),
- makeWorkspace('Wc0'),
- makeWorkspace('Wc1'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic0',
- status: 'failed',
- });
-
- expect(result).toEqual({ name: 'Ic0', status: 'failed' });
- });
-
- it('should return the failed mid-segment instance command', async () => {
- // Sequence: Ic0 → Ic1 → Ic2 → Wc0
- // Ic1 failed (Ic0 completed but Ic1 is the last attempted) → cursor at Ic1:failed
- const sequence = [
- makeFastInstance('Ic0'),
- makeFastInstance('Ic1'),
- makeFastInstance('Ic2'),
- makeWorkspace('Wc0'),
- ];
-
- const service = await buildServiceWithMockedSequence(sequence);
-
- const result = service.getInitialCursorForNewWorkspace({
- name: 'Ic1',
- status: 'failed',
- });
-
- expect(result).toEqual({ name: 'Ic1', status: 'failed' });
- });
- });
-
- describe('getUpgradeStepNames', () => {
- const sequence = [
- makeFastInstance('Ic0'),
- makeStep('slow-instance', 'Sic0'),
- makeWorkspace('Wc0'),
- ];
-
- it('should return every step name when no kind is requested', async () => {
- const service = await buildServiceWithMockedSequence(sequence);
-
- expect(service.getUpgradeStepNames()).toEqual(['Ic0', 'Sic0', 'Wc0']);
- });
-
- it('should keep only the requested kinds', async () => {
- const service = await buildServiceWithMockedSequence(sequence);
-
- expect(
- service.getUpgradeStepNames({
- 'fast-instance': true,
- 'slow-instance': true,
- }),
- ).toEqual(['Ic0', 'Sic0']);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-sequence-runner.service.spec.ts b/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-sequence-runner.service.spec.ts
deleted file mode 100644
index 99c0ba32c18..00000000000
--- a/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-sequence-runner.service.spec.ts
+++ /dev/null
@@ -1,139 +0,0 @@
-import { type WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';
-import { type CommandShutdownService } from 'src/database/commands/command-runners/command-shutdown.service';
-import { type InstanceCommandRunnerService } from 'src/engine/core-modules/upgrade/services/instance-command-runner.service';
-import { type UpgradeMigrationService } from 'src/engine/core-modules/upgrade/services/upgrade-migration.service';
-import {
- type UpgradeStep,
- type UpgradeSequenceReaderService,
-} from 'src/engine/core-modules/upgrade/services/upgrade-sequence-reader.service';
-import { UpgradeSequenceRunnerService } from 'src/engine/core-modules/upgrade/services/upgrade-sequence-runner.service';
-import { type WorkspaceCommandRunnerService } from 'src/engine/core-modules/upgrade/services/workspace-command-runner.service';
-import { type UpgradeAwareEntityMetadataAdapter } from 'src/engine/twenty-orm/upgrade-aware/upgrade-aware-entity-metadata.adapter';
-import { type WorkspaceVersionService } from 'src/engine/workspace-manager/workspace-version/services/workspace-version.service';
-
-const WORKSPACE_ID = 'workspace-1';
-
-const makeStep = (kind: UpgradeStep['kind'], name: string) =>
- ({
- kind,
- name,
- command: {},
- version: '1.0.0',
- timestamp: 0,
- }) as unknown as UpgradeStep;
-
-describe('UpgradeSequenceRunnerService shutdown handling', () => {
- let service: UpgradeSequenceRunnerService;
- let isShutdownRequested: jest.Mock<boolean, []>;
- let runFastInstanceCommand: jest.Mock;
- let iterate: jest.Mock;
-
- beforeEach(() => {
- isShutdownRequested = jest.fn().mockReturnValue(false);
- runFastInstanceCommand = jest.fn().mockResolvedValue({ status: 'success' });
- iterate = jest.fn().mockResolvedValue({
- success: [{ workspaceId: WORKSPACE_ID }],
- fail: [],
- interrupted: false,
- });
-
- const upgradeMigrationService = {
- getLastAttemptedCommandNameOrThrow: jest
- .fn()
- .mockResolvedValue({ name: 'step-1', status: 'failed' }),
- getWorkspaceLastAttemptedCommandNameOrThrow: jest
- .fn()
- .mockResolvedValue(new Map()),
- } as unknown as UpgradeMigrationService;
-
- const upgradeSequenceReaderService = {
- locateStepInSequenceOrThrow: jest.fn().mockReturnValue(0),
- getWorkspaceSegmentBounds: jest
- .fn()
- .mockReturnValue({ startCursor: 0, endCursor: 0 }),
- collectWorkspaceCommandsStartingFrom: jest
- .fn()
- .mockImplementation(({ fromWorkspaceCommand }) => [
- fromWorkspaceCommand,
- ]),
- getPendingWorkspaceCommands: jest.fn().mockReturnValue([]),
- } as unknown as UpgradeSequenceReaderService;
-
- service = new UpgradeSequenceRunnerService(
- upgradeMigrationService,
- { runFastInstanceCommand } as unknown as InstanceCommandRunnerService,
- {
- runWorkspaceCommands: jest.fn(),
- } as unknown as WorkspaceCommandRunnerService,
- upgradeSequenceReaderService,
- {
- refresh: jest.fn().mockResolvedValue(undefined),
- } as unknown as UpgradeAwareEntityMetadataAdapter,
- { iterate } as unknown as WorkspaceIteratorService,
- {
- getProvisionedWorkspaceIds: jest.fn().mockResolvedValue([WORKSPACE_ID]),
- } as unknown as WorkspaceVersionService,
- { isShutdownRequested } as unknown as CommandShutdownService,
- );
-
- jest.spyOn(service['logger'], 'log').mockImplementation();
- jest.spyOn(service['logger'], 'warn').mockImplementation();
- jest.spyOn(service['logger'], 'error').mockImplementation();
- });
-
- it('should run every step when no shutdown is requested', async () => {
- const sequence = [
- makeStep('fast-instance', 'step-1'),
- makeStep('fast-instance', 'step-2'),
- ];
-
- await service.run({ sequence, options: {} });
-
- expect(runFastInstanceCommand).toHaveBeenCalledTimes(2);
- });
-
- it('should stop before the next step when a shutdown is requested', async () => {
- const sequence = [
- makeStep('fast-instance', 'step-1'),
- makeStep('fast-instance', 'step-2'),
- ];
-
- isShutdownRequested.mockReturnValueOnce(false).mockReturnValue(true);
-
- await service.run({ sequence, options: {} });
-
- expect(runFastInstanceCommand).toHaveBeenCalledTimes(1);
- expect(runFastInstanceCommand).toHaveBeenCalledWith(
- expect.objectContaining({ name: 'step-1' }),
- );
- });
-
- it('should not advance to the next instance step when a workspace segment is interrupted', async () => {
- const sequence = [
- makeStep('workspace', 'workspace-step-1'),
- makeStep('fast-instance', 'instance-step-1'),
- ];
-
- iterate.mockResolvedValue({
- success: [{ workspaceId: WORKSPACE_ID }],
- fail: [],
- interrupted: true,
- });
-
- const report = await service.run({ sequence, options: {} });
-
- expect(runFastInstanceCommand).not.toHaveBeenCalled();
- expect(report).toEqual({ totalSuccesses: 1, totalFailures: 0 });
- });
-
- it('should advance to the next instance step when a workspace segment completes', async () => {
- const sequence = [
- makeStep('workspace', 'workspace-step-1'),
- makeStep('fast-instance', 'instance-step-1'),
- ];
-
- await service.run({ sequence, options: {} });
-
- expect(runFastInstanceCommand).toHaveBeenCalledTimes(1);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-status.service.spec.ts b/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-status.service.spec.ts
deleted file mode 100644
index 703ca8c59c6..00000000000
--- a/packages/twenty-server/src/engine/core-modules/upgrade/services/__tests__/upgrade-status.service.spec.ts
+++ /dev/null
@@ -1,699 +0,0 @@
-import { Test } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { UpgradeHealthEnum } from 'twenty-shared/types';
-import { isDefined } from 'twenty-shared/utils';
-
-import { TWENTY_CROSS_UPGRADE_SUPPORTED_VERSIONS } from 'src/engine/core-modules/upgrade/constants/twenty-cross-upgrade-supported-version.constant';
-import { UpgradeMigrationService } from 'src/engine/core-modules/upgrade/services/upgrade-migration.service';
-import { UpgradeSequenceReaderService } from 'src/engine/core-modules/upgrade/services/upgrade-sequence-reader.service';
-import { UpgradeStatusCacheService } from 'src/engine/core-modules/upgrade/services/upgrade-status-cache.service';
-import { UpgradeStatusService } from 'src/engine/core-modules/upgrade/services/upgrade-status.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-// The three most recent supported versions: the upgrade sequence only ever
-// covers supported versions, so fixtures built out of anything else describe a
-// state the server cannot reach.
-const [OLDEST_VERSION, MIDDLE_VERSION, NEWEST_VERSION] =
- TWENTY_CROSS_UPGRADE_SUPPORTED_VERSIONS.slice(-3);
-
-const OLDEST_INSTANCE_COMMAND = `${OLDEST_VERSION}_InstanceCommand_1772000001000`;
-const OLDEST_SLOW_INSTANCE_COMMAND = `${OLDEST_VERSION}_SlowInstanceCommand_1772000002000`;
-const OLDEST_FIRST_WORKSPACE_COMMAND = `${OLDEST_VERSION}_FirstWorkspaceCommand_1772000003000`;
-const OLDEST_SECOND_WORKSPACE_COMMAND = `${OLDEST_VERSION}_SecondWorkspaceCommand_1772000004000`;
-const MIDDLE_INSTANCE_COMMAND = `${MIDDLE_VERSION}_InstanceCommand_1776000001000`;
-const NEWEST_INSTANCE_COMMAND = `${NEWEST_VERSION}_InstanceCommand_1780000002000`;
-const NEWEST_WORKSPACE_COMMAND = `${NEWEST_VERSION}_WorkspaceCommand_1780000003000`;
-
-// Three version segments: the oldest has multiple workspace commands, the
-// middle one is instance-only, the newest ends the sequence with a workspace
-// command.
-const MOCK_SEQUENCE = [
- { kind: 'fast-instance', name: OLDEST_INSTANCE_COMMAND },
- { kind: 'slow-instance', name: OLDEST_SLOW_INSTANCE_COMMAND },
- { kind: 'workspace', name: OLDEST_FIRST_WORKSPACE_COMMAND },
- { kind: 'workspace', name: OLDEST_SECOND_WORKSPACE_COMMAND },
- { kind: 'fast-instance', name: MIDDLE_INSTANCE_COMMAND },
- { kind: 'fast-instance', name: NEWEST_INSTANCE_COMMAND },
- { kind: 'workspace', name: NEWEST_WORKSPACE_COMMAND },
-];
-
-// The newest supported version ships workspace commands only: nothing for the
-// instance cursor to land on.
-const MOCK_SEQUENCE_WITHOUT_TRAILING_INSTANCE_COMMAND = [
- { kind: 'fast-instance', name: MIDDLE_INSTANCE_COMMAND },
- { kind: 'workspace', name: NEWEST_WORKSPACE_COMMAND },
-];
-
-type WorkspaceRecord = {
- id: string;
- displayName: string | null;
-};
-
-describe('UpgradeStatusService', () => {
- let service: UpgradeStatusService;
- let sequence: { kind: string; name: string }[];
- let getLastAttemptedInstanceCommand: jest.Mock;
- let getWorkspaceLastAttemptedCommandName: jest.Mock;
- let workspaceFind: jest.Mock;
- let cacheGetComputedAt: jest.Mock;
- let cacheGetBehindWorkspaceIds: jest.Mock;
- let cacheGetFailedWorkspaceIds: jest.Mock;
- let cacheGetUpToDateWorkspaceCount: jest.Mock;
- let cacheWrite: jest.Mock;
- let cacheInvalidate: jest.Mock;
-
- const mockActiveWorkspaces = (workspaces: WorkspaceRecord[]) => {
- workspaceFind.mockResolvedValue(workspaces);
- };
-
- beforeEach(async () => {
- sequence = MOCK_SEQUENCE;
- getLastAttemptedInstanceCommand = jest.fn();
- getWorkspaceLastAttemptedCommandName = jest.fn();
- workspaceFind = jest.fn().mockResolvedValue([]);
- cacheGetComputedAt = jest.fn();
- cacheGetBehindWorkspaceIds = jest.fn().mockResolvedValue([]);
- cacheGetFailedWorkspaceIds = jest.fn().mockResolvedValue([]);
- cacheGetUpToDateWorkspaceCount = jest.fn().mockResolvedValue(0);
- cacheWrite = jest.fn().mockResolvedValue(undefined);
- cacheInvalidate = jest.fn().mockResolvedValue(undefined);
-
- const module = await Test.createTestingModule({
- providers: [
- UpgradeStatusService,
- {
- provide: UpgradeMigrationService,
- useValue: {
- getLastAttemptedInstanceCommand,
- getWorkspaceLastAttemptedCommandName,
- },
- },
- {
- provide: UpgradeSequenceReaderService,
- useValue: {
- getUpgradeSequence: () => sequence,
- getUpgradeStepNames: (kinds?: Record<string, true>) =>
- sequence
- .filter(
- (step) => !isDefined(kinds) || kinds[step.kind] === true,
- )
- .map((step) => step.name),
- },
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: { find: workspaceFind },
- },
- {
- provide: UpgradeStatusCacheService,
- useValue: {
- getComputedAt: cacheGetComputedAt,
- getBehindWorkspaceIds: cacheGetBehindWorkspaceIds,
- getFailedWorkspaceIds: cacheGetFailedWorkspaceIds,
- getUpToDateWorkspaceCount: cacheGetUpToDateWorkspaceCount,
- write: cacheWrite,
- invalidate: cacheInvalidate,
- },
- },
- ],
- }).compile();
-
- service = module.get(UpgradeStatusService);
- });
-
- describe('getInstanceStatus', () => {
- it('should return up-to-date when cursor is at last instance command', async () => {
- getLastAttemptedInstanceCommand.mockResolvedValue({
- name: NEWEST_INSTANCE_COMMAND,
- status: 'completed',
- executedByVersion: NEWEST_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-06-01T00:00:00Z'),
- });
-
- const result = await service.getInstanceStatus();
-
- expect(result.health).toBe(UpgradeHealthEnum.UP_TO_DATE);
- expect(result.inferredVersion).toBe(NEWEST_VERSION);
- });
-
- it('should return behind when cursor is before last instance command', async () => {
- getLastAttemptedInstanceCommand.mockResolvedValue({
- name: MIDDLE_INSTANCE_COMMAND,
- status: 'completed',
- executedByVersion: MIDDLE_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-06-01T00:00:00Z'),
- });
-
- const result = await service.getInstanceStatus();
-
- expect(result.health).toBe(UpgradeHealthEnum.BEHIND);
- expect(result.inferredVersion).toBe(MIDDLE_VERSION);
- });
-
- it('should return failed when latest instance command failed', async () => {
- getLastAttemptedInstanceCommand.mockResolvedValue({
- name: NEWEST_INSTANCE_COMMAND,
- status: 'failed',
- executedByVersion: NEWEST_VERSION,
- errorMessage: 'column does not exist',
- createdAt: new Date('2025-06-01T01:00:00Z'),
- });
-
- const result = await service.getInstanceStatus();
-
- expect(result.health).toBe(UpgradeHealthEnum.FAILED);
- expect(result.latestCommand?.errorMessage).toBe('column does not exist');
- });
-
- it('should return behind when no migrations exist', async () => {
- getLastAttemptedInstanceCommand.mockResolvedValue(null);
-
- const result = await service.getInstanceStatus();
-
- expect(result.health).toBe(UpgradeHealthEnum.BEHIND);
- expect(result.inferredVersion).toBeNull();
- expect(result.latestCommand).toBeNull();
- });
- });
-
- describe('getInstanceCompletedVersion', () => {
- const mockInstanceCursor = (
- cursor: { name: string; status: 'completed' | 'failed' } | null,
- ) => {
- getLastAttemptedInstanceCommand.mockResolvedValue(
- cursor === null
- ? null
- : {
- ...cursor,
- executedByVersion: NEWEST_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-06-01T00:00:00Z'),
- },
- );
- };
-
- it('should return null when no instance command has run', async () => {
- mockInstanceCursor(null);
-
- await expect(service.getInstanceCompletedVersion()).resolves.toBeNull();
- });
-
- it('should return the cursor version when completed at the last instance step of its segment', async () => {
- mockInstanceCursor({
- name: NEWEST_INSTANCE_COMMAND,
- status: 'completed',
- });
-
- await expect(service.getInstanceCompletedVersion()).resolves.toBe(
- NEWEST_VERSION,
- );
- });
-
- it('should ignore workspace steps of the same segment', async () => {
- mockInstanceCursor({
- name: OLDEST_SLOW_INSTANCE_COMMAND,
- status: 'completed',
- });
-
- await expect(service.getInstanceCompletedVersion()).resolves.toBe(
- OLDEST_VERSION,
- );
- });
-
- it('should return the previous version when the last instance step of the segment failed', async () => {
- mockInstanceCursor({ name: NEWEST_INSTANCE_COMMAND, status: 'failed' });
-
- await expect(service.getInstanceCompletedVersion()).resolves.toBe(
- MIDDLE_VERSION,
- );
- });
-
- it('should return null when earlier instance steps of the same segment remain', async () => {
- mockInstanceCursor({
- name: OLDEST_INSTANCE_COMMAND,
- status: 'completed',
- });
-
- await expect(service.getInstanceCompletedVersion()).resolves.toBeNull();
- });
-
- it('should reach a trailing version that declares no instance command', async () => {
- sequence = MOCK_SEQUENCE_WITHOUT_TRAILING_INSTANCE_COMMAND;
- mockInstanceCursor({
- name: MIDDLE_INSTANCE_COMMAND,
- status: 'completed',
- });
-
- await expect(service.getInstanceCompletedVersion()).resolves.toBe(
- NEWEST_VERSION,
- );
- });
-
- it('should not reach a trailing version whose instance command has not run', async () => {
- sequence = [
- { kind: 'fast-instance', name: MIDDLE_INSTANCE_COMMAND },
- { kind: 'fast-instance', name: NEWEST_INSTANCE_COMMAND },
- ];
- mockInstanceCursor({
- name: MIDDLE_INSTANCE_COMMAND,
- status: 'completed',
- });
-
- await expect(service.getInstanceCompletedVersion()).resolves.toBe(
- MIDDLE_VERSION,
- );
- });
-
- it('should throw when a step name carries no version prefix', async () => {
- sequence = [{ kind: 'fast-instance', name: 'NoVersionPrefixCommand' }];
- mockInstanceCursor({
- name: 'NoVersionPrefixCommand',
- status: 'completed',
- });
-
- await expect(service.getInstanceCompletedVersion()).rejects.toThrow(
- 'does not carry a version prefix',
- );
- });
-
- it('should throw when a step belongs to an unsupported version', async () => {
- const unsupportedCommand = '0.1.0_InstanceCommand_1700000000000';
-
- sequence = [{ kind: 'fast-instance', name: unsupportedCommand }];
- mockInstanceCursor({ name: unsupportedCommand, status: 'completed' });
-
- await expect(service.getInstanceCompletedVersion()).rejects.toThrow(
- 'is not one of the supported versions',
- );
- });
- });
-
- describe('getWorkspaceCompletedVersion', () => {
- const mockWorkspaceCursor = (
- cursor: { name: string; status: 'completed' | 'failed' } | null,
- ) => {
- getWorkspaceLastAttemptedCommandName.mockResolvedValue(
- cursor === null
- ? new Map()
- : new Map([
- [
- 'ws-1',
- {
- workspaceId: 'ws-1',
- ...cursor,
- executedByVersion: NEWEST_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-06-01T00:00:00Z'),
- isInitial: false,
- },
- ],
- ]),
- );
- };
-
- it('should return the cursor version when at the last step of its segment with completed status', async () => {
- mockWorkspaceCursor({
- name: NEWEST_WORKSPACE_COMMAND,
- status: 'completed',
- });
-
- await expect(service.getWorkspaceCompletedVersion('ws-1')).resolves.toBe(
- NEWEST_VERSION,
- );
- });
-
- it('should return the immediately previous version when the cursor is mid-segment', async () => {
- mockWorkspaceCursor({
- name: NEWEST_INSTANCE_COMMAND,
- status: 'completed',
- });
-
- await expect(service.getWorkspaceCompletedVersion('ws-1')).resolves.toBe(
- MIDDLE_VERSION,
- );
- });
-
- it('should return the previous version when the last step of the segment failed', async () => {
- mockWorkspaceCursor({ name: NEWEST_WORKSPACE_COMMAND, status: 'failed' });
-
- await expect(service.getWorkspaceCompletedVersion('ws-1')).resolves.toBe(
- MIDDLE_VERSION,
- );
- });
-
- it('should return the cursor version when completed at the end of an instance-only segment', async () => {
- mockWorkspaceCursor({
- name: MIDDLE_INSTANCE_COMMAND,
- status: 'completed',
- });
-
- await expect(service.getWorkspaceCompletedVersion('ws-1')).resolves.toBe(
- MIDDLE_VERSION,
- );
- });
-
- it('should return the previous version when an instance-only segment failed', async () => {
- mockWorkspaceCursor({ name: MIDDLE_INSTANCE_COMMAND, status: 'failed' });
-
- await expect(service.getWorkspaceCompletedVersion('ws-1')).resolves.toBe(
- OLDEST_VERSION,
- );
- });
-
- it('should return the cursor version when completed at the last of several workspace commands', async () => {
- mockWorkspaceCursor({
- name: OLDEST_SECOND_WORKSPACE_COMMAND,
- status: 'completed',
- });
-
- await expect(service.getWorkspaceCompletedVersion('ws-1')).resolves.toBe(
- OLDEST_VERSION,
- );
- });
-
- it('should not consider a segment completed while earlier workspace commands of the same segment remain', async () => {
- mockWorkspaceCursor({
- name: OLDEST_FIRST_WORKSPACE_COMMAND,
- status: 'completed',
- });
-
- await expect(
- service.getWorkspaceCompletedVersion('ws-1'),
- ).resolves.toBeNull();
- });
-
- it('should return null when the first segment failed with no previous segment', async () => {
- mockWorkspaceCursor({
- name: OLDEST_SECOND_WORKSPACE_COMMAND,
- status: 'failed',
- });
-
- await expect(
- service.getWorkspaceCompletedVersion('ws-1'),
- ).resolves.toBeNull();
- });
-
- it('should return null when the workspace has no cursor', async () => {
- mockWorkspaceCursor(null);
-
- await expect(
- service.getWorkspaceCompletedVersion('ws-1'),
- ).resolves.toBeNull();
- });
-
- it('should return null when the cursor is outside the supported sequence', async () => {
- mockWorkspaceCursor({
- name: '1.10.0_OutOfSequenceCommand_1700000000000',
- status: 'completed',
- });
-
- await expect(
- service.getWorkspaceCompletedVersion('ws-1'),
- ).resolves.toBeNull();
- });
- });
-
- describe('getWorkspaceStatuses', () => {
- it('should return up-to-date for workspace at last command', async () => {
- mockActiveWorkspaces([{ id: 'ws-1', displayName: 'Apple' }]);
-
- getWorkspaceLastAttemptedCommandName.mockResolvedValue(
- new Map([
- [
- 'ws-1',
- {
- workspaceId: 'ws-1',
- name: NEWEST_WORKSPACE_COMMAND,
- status: 'completed',
- executedByVersion: NEWEST_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-06-01T00:00:00Z'),
- },
- ],
- ]),
- );
-
- const results = await service.getWorkspaceStatuses();
-
- expect(results).toHaveLength(1);
- expect(results[0].health).toBe(UpgradeHealthEnum.UP_TO_DATE);
- });
-
- it('should return behind for workspace not at last command', async () => {
- mockActiveWorkspaces([
- { id: 'ws-1', displayName: 'Apple' },
- { id: 'ws-2', displayName: 'Google' },
- ]);
-
- getWorkspaceLastAttemptedCommandName.mockResolvedValue(
- new Map([
- [
- 'ws-1',
- {
- workspaceId: 'ws-1',
- name: NEWEST_WORKSPACE_COMMAND,
- status: 'completed',
- executedByVersion: NEWEST_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-06-01T00:00:00Z'),
- },
- ],
- [
- 'ws-2',
- {
- workspaceId: 'ws-2',
- name: MIDDLE_INSTANCE_COMMAND,
- status: 'completed',
- executedByVersion: MIDDLE_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-05-01T00:00:00Z'),
- },
- ],
- ]),
- );
-
- const results = await service.getWorkspaceStatuses();
-
- expect(results).toHaveLength(2);
- expect(results[0].health).toBe(UpgradeHealthEnum.UP_TO_DATE);
- expect(results[1].health).toBe(UpgradeHealthEnum.BEHIND);
- });
-
- it('should return behind for workspace with no migration history', async () => {
- mockActiveWorkspaces([{ id: 'ws-1', displayName: 'Apple' }]);
-
- getWorkspaceLastAttemptedCommandName.mockResolvedValue(new Map());
-
- const results = await service.getWorkspaceStatuses();
-
- expect(results).toHaveLength(1);
- expect(results[0].health).toBe(UpgradeHealthEnum.BEHIND);
- expect(results[0].latestCommand).toBeNull();
- });
-
- it('should return empty array when no workspaces exist', async () => {
- mockActiveWorkspaces([]);
- getWorkspaceLastAttemptedCommandName.mockResolvedValue(new Map());
-
- const results = await service.getWorkspaceStatuses();
-
- expect(results).toHaveLength(0);
- });
- });
-
- describe('getInstanceAndAllWorkspacesStatus', () => {
- it('should hydrate cached behind/failed ids with display names without calling getWorkspaceStatuses', async () => {
- const computedAt = new Date('2025-06-02T10:00:00Z');
-
- cacheGetComputedAt.mockResolvedValue(computedAt);
- cacheGetBehindWorkspaceIds.mockResolvedValue(['ws-2']);
- cacheGetFailedWorkspaceIds.mockResolvedValue(['ws-3']);
- cacheGetUpToDateWorkspaceCount.mockResolvedValue(5);
- getLastAttemptedInstanceCommand.mockResolvedValue({
- name: NEWEST_INSTANCE_COMMAND,
- status: 'completed',
- executedByVersion: NEWEST_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-06-01T00:00:00Z'),
- });
- workspaceFind.mockResolvedValue([
- { id: 'ws-2', displayName: 'Banana' },
- { id: 'ws-3', displayName: 'Cherry' },
- ]);
-
- const result = await service.getInstanceAndAllWorkspacesStatus();
-
- expect(result.workspacesBehind).toEqual([{ id: 'ws-2', name: 'Banana' }]);
- expect(result.workspacesFailed).toEqual([{ id: 'ws-3', name: 'Cherry' }]);
- expect(result.upToDateWorkspaceCount).toBe(5);
- expect(result.computedAt).toEqual(computedAt);
- expect(workspaceFind).toHaveBeenCalledTimes(1);
- expect(getWorkspaceLastAttemptedCommandName).not.toHaveBeenCalled();
- expect(cacheWrite).not.toHaveBeenCalled();
- });
-
- it('should fall back to a refresh when the cache marker is missing', async () => {
- cacheGetComputedAt.mockResolvedValue(null);
- getLastAttemptedInstanceCommand.mockResolvedValue(null);
- mockActiveWorkspaces([{ id: 'ws-1', displayName: 'Apple' }]);
- getWorkspaceLastAttemptedCommandName.mockResolvedValue(new Map());
-
- const result = await service.getInstanceAndAllWorkspacesStatus();
-
- expect(cacheWrite).toHaveBeenCalledTimes(1);
- expect(result.workspacesBehind).toEqual([{ id: 'ws-1', name: 'Apple' }]);
- });
-
- it('should use null name when a cached id is missing from the database', async () => {
- cacheGetComputedAt.mockResolvedValue(new Date());
- cacheGetBehindWorkspaceIds.mockResolvedValue(['ws-orphan']);
- getLastAttemptedInstanceCommand.mockResolvedValue(null);
-
- const result = await service.getInstanceAndAllWorkspacesStatus();
-
- expect(result.workspacesBehind).toEqual([
- { id: 'ws-orphan', name: null },
- ]);
- });
-
- it('should not query workspace names when both cached id sets are empty', async () => {
- cacheGetComputedAt.mockResolvedValue(new Date());
- getLastAttemptedInstanceCommand.mockResolvedValue(null);
-
- await service.getInstanceAndAllWorkspacesStatus();
-
- expect(workspaceFind).not.toHaveBeenCalled();
- });
- });
-
- describe('getInstanceAndWorkspaceCountsStatus', () => {
- it('should derive counts from cached ids without loading workspace names', async () => {
- const computedAt = new Date('2025-06-02T10:00:00Z');
-
- cacheGetComputedAt.mockResolvedValue(computedAt);
- cacheGetBehindWorkspaceIds.mockResolvedValue(['ws-1', 'ws-2']);
- cacheGetFailedWorkspaceIds.mockResolvedValue(['ws-3']);
- cacheGetUpToDateWorkspaceCount.mockResolvedValue(5);
- getLastAttemptedInstanceCommand.mockResolvedValue(null);
-
- const result = await service.getInstanceAndWorkspaceCountsStatus();
-
- expect(result).toEqual({
- instanceUpgradeStatus: {
- inferredVersion: null,
- health: UpgradeHealthEnum.BEHIND,
- latestCommand: null,
- },
- behindWorkspaceCount: 2,
- failedWorkspaceCount: 1,
- upToDateWorkspaceCount: 5,
- computedAt,
- });
- expect(workspaceFind).not.toHaveBeenCalled();
- expect(cacheWrite).not.toHaveBeenCalled();
- });
-
- it('should derive counts from a refresh when the cache marker is missing', async () => {
- cacheGetComputedAt.mockResolvedValue(null);
- getLastAttemptedInstanceCommand.mockResolvedValue(null);
- mockActiveWorkspaces([
- { id: 'ws-1', displayName: 'Apple' },
- { id: 'ws-2', displayName: 'Banana' },
- ]);
- getWorkspaceLastAttemptedCommandName.mockResolvedValue(
- new Map([
- [
- 'ws-2',
- {
- workspaceId: 'ws-2',
- name: NEWEST_WORKSPACE_COMMAND,
- status: 'failed',
- executedByVersion: NEWEST_VERSION,
- errorMessage: 'boom',
- createdAt: new Date('2025-06-01T00:00:00Z'),
- },
- ],
- ]),
- );
-
- const result = await service.getInstanceAndWorkspaceCountsStatus();
-
- expect(result.behindWorkspaceCount).toBe(1);
- expect(result.failedWorkspaceCount).toBe(1);
- expect(result.upToDateWorkspaceCount).toBe(0);
- expect(cacheWrite).toHaveBeenCalledTimes(1);
- });
- });
-
- describe('refreshInstanceAndAllWorkspacesStatus', () => {
- it('should partition workspaces by health, write to cache, and return the fresh payload', async () => {
- getLastAttemptedInstanceCommand.mockResolvedValue(null);
- mockActiveWorkspaces([
- { id: 'ws-1', displayName: 'Apple' },
- { id: 'ws-2', displayName: 'Banana' },
- { id: 'ws-3', displayName: 'Cherry' },
- ]);
- getWorkspaceLastAttemptedCommandName.mockResolvedValue(
- new Map([
- [
- 'ws-1',
- {
- workspaceId: 'ws-1',
- name: NEWEST_WORKSPACE_COMMAND,
- status: 'completed',
- executedByVersion: NEWEST_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-06-01T00:00:00Z'),
- },
- ],
- [
- 'ws-2',
- {
- workspaceId: 'ws-2',
- name: MIDDLE_INSTANCE_COMMAND,
- status: 'completed',
- executedByVersion: MIDDLE_VERSION,
- errorMessage: null,
- createdAt: new Date('2025-05-01T00:00:00Z'),
- },
- ],
- [
- 'ws-3',
- {
- workspaceId: 'ws-3',
- name: NEWEST_WORKSPACE_COMMAND,
- status: 'failed',
- executedByVersion: NEWEST_VERSION,
- errorMessage: 'boom',
- createdAt: new Date('2025-06-01T00:00:00Z'),
- },
- ],
- ]),
- );
-
- const result = await service.refreshInstanceAndAllWorkspacesStatus();
-
- expect(result.workspacesBehind).toEqual([{ id: 'ws-2', name: 'Banana' }]);
- expect(result.workspacesFailed).toEqual([{ id: 'ws-3', name: 'Cherry' }]);
- expect(result.upToDateWorkspaceCount).toBe(1);
-
- expect(cacheWrite).toHaveBeenCalledWith({
- behindWorkspaceIds: ['ws-2'],
- failedWorkspaceIds: ['ws-3'],
- upToDateWorkspaceCount: 1,
- computedAt: expect.any(Date),
- });
- });
- });
-
- describe('invalidateInstanceAndAllWorkspacesStatus', () => {
- it('should delegate to the cache service', async () => {
- await service.invalidateInstanceAndAllWorkspacesStatus();
-
- expect(cacheInvalidate).toHaveBeenCalledTimes(1);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/user-session/services/__tests__/user-session-cookie.service.spec.ts b/packages/twenty-server/src/engine/core-modules/user-session/services/__tests__/user-session-cookie.service.spec.ts
deleted file mode 100644
index f06bd6d21ac..00000000000
--- a/packages/twenty-server/src/engine/core-modules/user-session/services/__tests__/user-session-cookie.service.spec.ts
+++ /dev/null
@@ -1,60 +0,0 @@
-import { type Request } from 'express';
-
-import { type TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserSessionCookieService } from 'src/engine/core-modules/user-session/services/user-session-cookie.service';
-
-describe('UserSessionCookieService', () => {
- const buildService = (
- config: Record<string, unknown> = { AUTH_COOKIE_SESSIONS_ENABLED: true },
- ) =>
- new UserSessionCookieService({
- get: jest.fn((key: string) => config[key]),
- } as unknown as TwentyConfigService);
-
- const buildRequest = (cookieHeader?: string): Request =>
- ({ headers: cookieHeader ? { cookie: cookieHeader } : {} }) as Request;
-
- describe('hasSessionCookie', () => {
- it('should detect the secure cookie name', () => {
- expect(
- buildService().hasSessionCookie(
- buildRequest('__Host-twenty-session=sess_abc'),
- ),
- ).toBe(true);
- });
-
- it('should detect the legacy plain cookie name', () => {
- expect(
- buildService().hasSessionCookie(
- buildRequest('twenty-session=sess_abc'),
- ),
- ).toBe(true);
- });
-
- it('should ignore a cookie header carrying only unrelated cookies', () => {
- expect(
- buildService().hasSessionCookie(buildRequest('other=1; another=2')),
- ).toBe(false);
- });
-
- it('should report no cookie when the request carries none', () => {
- expect(buildService().hasSessionCookie(buildRequest())).toBe(false);
- });
-
- it('should report no cookie when cookie sessions are disabled', () => {
- expect(
- buildService({ AUTH_COOKIE_SESSIONS_ENABLED: false }).hasSessionCookie(
- buildRequest('__Host-twenty-session=sess_abc'),
- ),
- ).toBe(false);
- });
-
- it('should not match a cookie whose name merely ends with ours', () => {
- expect(
- buildService().hasSessionCookie(
- buildRequest('not-twenty-session=sess_abc'),
- ),
- ).toBe(false);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/user-session/services/user-session.service.spec.ts b/packages/twenty-server/src/engine/core-modules/user-session/services/user-session.service.spec.ts
deleted file mode 100644
index ff7c4bafd98..00000000000
--- a/packages/twenty-server/src/engine/core-modules/user-session/services/user-session.service.spec.ts
+++ /dev/null
@@ -1,922 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { randomUUID } from 'crypto';
-
-import { Repository } from 'typeorm';
-
-import { AppTokenEntity } from 'src/engine/core-modules/app-token/app-token.entity';
-import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
-import { JwtTokenTypeEnum } from 'src/engine/core-modules/auth/types/jwt-token-type.enum';
-import { CacheStorageNamespace } from 'src/engine/core-modules/cache-storage/types/cache-storage-namespace.enum';
-import { EventLogEmitterService } from 'src/engine/core-modules/event-logs/emit/event-log-emitter.service';
-import { JwtWrapperService } from 'src/engine/core-modules/jwt/services/jwt-wrapper.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserSessionCookieService } from 'src/engine/core-modules/user-session/services/user-session-cookie.service';
-import { UserSessionService } from 'src/engine/core-modules/user-session/services/user-session.service';
-import { UserSessionEntity } from 'src/engine/core-modules/user-session/user-session.entity';
-import { UserSessionRevokedReason } from 'src/engine/core-modules/user-session/types/user-session-revoked-reason.type';
-import { hashUserSessionToken } from 'src/engine/core-modules/user-session/utils/hash-user-session-token.util';
-import { AuthProviderEnum } from 'src/engine/core-modules/workspace/types/workspace.type';
-
-describe('UserSessionService', () => {
- let service: UserSessionService;
- let userSessionRepository: Repository<UserSessionEntity>;
- let appTokenRepository: Repository<AppTokenEntity>;
- let jwtWrapperService: JwtWrapperService;
-
- const cacheStorageService = {
- get: jest.fn(),
- set: jest.fn(),
- del: jest.fn(),
- mdel: jest.fn(),
- };
-
- const insertWorkspaceEvent = jest.fn();
-
- const mockConfig: Record<string, unknown> = {
- SESSION_ABSOLUTE_LIFETIME: '180d',
- SESSION_IDLE_TIMEOUT: '30d',
- SERVER_URL: 'http://crm.example.com',
- FRONTEND_URL: 'http://crm.example.com',
- AUTH_COOKIE_ALLOWED_ORIGINS: '',
- };
-
- const buildActiveSession = (
- overrides: Partial<UserSessionEntity> = {},
- ): UserSessionEntity =>
- ({
- id: randomUUID(),
- tokenHash: 'token-hash',
- userId: randomUUID(),
- workspaceId: randomUUID(),
- userWorkspaceId: randomUUID(),
- authProvider: AuthProviderEnum.Password,
- isImpersonating: false,
- impersonatorUserWorkspaceId: null,
- impersonatedUserWorkspaceId: null,
- userAgent: null,
- ipAddress: null,
- expiresAt: new Date(Date.now() + 24 * 60 * 60 * 1000),
- lastActiveAt: new Date(),
- revokedAt: null,
- revokedReason: null,
- createdAt: new Date(),
- updatedAt: new Date(),
- ...overrides,
- }) as UserSessionEntity;
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- UserSessionService,
- UserSessionCookieService,
- {
- provide: getRepositoryToken(UserSessionEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(AppTokenEntity),
- useClass: Repository,
- },
- {
- provide: CacheStorageNamespace.EngineAuthSession,
- useValue: cacheStorageService,
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn((key: string) => mockConfig[key]),
- },
- },
- {
- provide: JwtWrapperService,
- useValue: {
- verifyJwtToken: jest.fn(),
- decode: jest.fn(),
- },
- },
- {
- provide: EventLogEmitterService,
- useValue: {
- createContext: jest.fn(() => ({ insertWorkspaceEvent })),
- },
- },
- ],
- }).compile();
-
- service = module.get<UserSessionService>(UserSessionService);
- userSessionRepository = module.get<Repository<UserSessionEntity>>(
- getRepositoryToken(UserSessionEntity),
- );
- appTokenRepository = module.get<Repository<AppTokenEntity>>(
- getRepositoryToken(AppTokenEntity),
- );
- jwtWrapperService = module.get<JwtWrapperService>(JwtWrapperService);
- });
-
- describe('createSession', () => {
- it('should create a workspace session and emit a sign-in event', async () => {
- const sessionInput = {
- userId: randomUUID(),
- workspaceId: randomUUID(),
- userWorkspaceId: randomUUID(),
- authProvider: AuthProviderEnum.Password,
- origin: 'sign_in' as const,
- };
-
- jest
- .spyOn(userSessionRepository, 'create')
- .mockImplementation((entity) => entity as UserSessionEntity);
- jest
- .spyOn(userSessionRepository, 'save')
- .mockImplementation(async (entity) =>
- buildActiveSession(entity as Partial<UserSessionEntity>),
- );
-
- const { sessionToken, session } =
- await service.createSession(sessionInput);
-
- expect(sessionToken).toMatch(/^sess_/);
- expect(session.tokenHash).toEqual(hashUserSessionToken(sessionToken));
- expect(session.userId).toEqual(sessionInput.userId);
- expect(insertWorkspaceEvent).toHaveBeenCalledWith(
- 'AuthSession',
- expect.objectContaining({ action: 'user_signed_in' }),
- );
- });
-
- it('should not emit a sign-in event for renewal-bridge sessions', async () => {
- jest
- .spyOn(userSessionRepository, 'create')
- .mockImplementation((entity) => entity as UserSessionEntity);
- jest
- .spyOn(userSessionRepository, 'save')
- .mockImplementation(async (entity) =>
- buildActiveSession(entity as Partial<UserSessionEntity>),
- );
-
- await service.createSession({
- userId: randomUUID(),
- workspaceId: randomUUID(),
- userWorkspaceId: randomUUID(),
- authProvider: AuthProviderEnum.Password,
- origin: 'renewal_bridge',
- });
-
- expect(insertWorkspaceEvent).not.toHaveBeenCalled();
- });
-
- it('should cap impersonation sessions to a short lifetime', async () => {
- jest
- .spyOn(userSessionRepository, 'create')
- .mockImplementation((entity) => entity as UserSessionEntity);
- jest
- .spyOn(userSessionRepository, 'save')
- .mockImplementation(async (entity) => entity as UserSessionEntity);
-
- const { session } = await service.createSession({
- userId: randomUUID(),
- workspaceId: randomUUID(),
- userWorkspaceId: randomUUID(),
- authProvider: AuthProviderEnum.Impersonation,
- isImpersonating: true,
- impersonatorUserWorkspaceId: randomUUID(),
- impersonatedUserWorkspaceId: randomUUID(),
- origin: 'sign_in',
- });
-
- const oneDayFromNow = Date.now() + 24 * 60 * 60 * 1000;
-
- expect(session.expiresAt.getTime()).toBeLessThanOrEqual(
- oneDayFromNow + 1000,
- );
- });
-
- it('should reject a workspace session without a user workspace', async () => {
- await expect(
- service.createSession({
- userId: randomUUID(),
- workspaceId: randomUUID(),
- authProvider: AuthProviderEnum.Password,
- origin: 'sign_in',
- }),
- ).rejects.toThrow(AuthException);
- });
- });
-
- const mockPostCachingRevocationCheck = (
- session: UserSessionEntity | null,
- ) => {
- jest.spyOn(userSessionRepository, 'findOne').mockResolvedValue(session);
- };
-
- describe('resolveSession', () => {
- afterEach(() => {
- mockConfig.SESSION_IDLE_TIMEOUT = '30d';
- });
-
- it('should resolve an access payload from the database on cache miss', async () => {
- const session = buildActiveSession();
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(session);
- mockPostCachingRevocationCheck(session);
-
- const { payload } = await service.resolveSession('sess_token');
-
- expect(payload).toEqual(
- expect.objectContaining({
- type: JwtTokenTypeEnum.ACCESS,
- userId: session.userId,
- workspaceId: session.workspaceId,
- userWorkspaceId: session.userWorkspaceId,
- }),
- );
- expect(cacheStorageService.set).toHaveBeenCalled();
- });
-
- it('should resolve a workspace-agnostic payload for sessions without workspace', async () => {
- const session = buildActiveSession({
- workspaceId: null,
- userWorkspaceId: null,
- });
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(session);
- mockPostCachingRevocationCheck(session);
-
- const { payload } = await service.resolveSession('sess_token');
-
- expect(payload.type).toEqual(JwtTokenTypeEnum.WORKSPACE_AGNOSTIC);
- });
-
- it('should resolve from cache without hitting the database', async () => {
- const session = buildActiveSession();
-
- cacheStorageService.get.mockResolvedValue({
- sessionId: session.id,
- userId: session.userId,
- workspaceId: session.workspaceId,
- userWorkspaceId: session.userWorkspaceId,
- authProvider: session.authProvider,
- isImpersonating: false,
- impersonatorUserWorkspaceId: null,
- impersonatedUserWorkspaceId: null,
- expiresAt: session.expiresAt.toISOString(),
- lastActiveAt: new Date().toISOString(),
- authenticatedAt: session.createdAt.toISOString(),
- });
- const findOneBySpy = jest.spyOn(userSessionRepository, 'findOneBy');
-
- const { payload } = await service.resolveSession('sess_token');
-
- expect(payload.userId).toEqual(session.userId);
- expect(findOneBySpy).not.toHaveBeenCalled();
- });
-
- it('should reject a revoked session', async () => {
- cacheStorageService.get.mockResolvedValue(undefined);
- jest
- .spyOn(userSessionRepository, 'findOneBy')
- .mockResolvedValue(buildActiveSession({ revokedAt: new Date() }));
-
- await expect(service.resolveSession('sess_token')).rejects.toThrow(
- 'Session is invalid or has expired.',
- );
- });
-
- it('should reject a session past its absolute expiry', async () => {
- cacheStorageService.get.mockResolvedValue(undefined);
- jest
- .spyOn(userSessionRepository, 'findOneBy')
- .mockResolvedValue(
- buildActiveSession({ expiresAt: new Date(Date.now() - 1000) }),
- );
-
- await expect(service.resolveSession('sess_token')).rejects.toThrow(
- 'Session is invalid or has expired.',
- );
- });
-
- it('should reject an idle-expired session', async () => {
- const idleExpiredLastActiveAt = new Date(
- Date.now() - 31 * 24 * 60 * 60 * 1000,
- );
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest
- .spyOn(userSessionRepository, 'findOneBy')
- .mockResolvedValue(
- buildActiveSession({ lastActiveAt: idleExpiredLastActiveAt }),
- );
-
- await expect(service.resolveSession('sess_token')).rejects.toThrow(
- 'Session is invalid or has expired.',
- );
- });
-
- it('should reject an unknown session token', async () => {
- cacheStorageService.get.mockResolvedValue(undefined);
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(null);
-
- await expect(service.resolveSession('sess_unknown')).rejects.toThrow(
- 'Session is invalid or has expired.',
- );
- });
-
- it('should touch lastActiveAt when the touch interval elapsed', async () => {
- const staleLastActiveAt = new Date(Date.now() - 10 * 60 * 1000);
- const session = buildActiveSession({ lastActiveAt: staleLastActiveAt });
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(session);
- mockPostCachingRevocationCheck(session);
- const updateSpy = jest
- .spyOn(userSessionRepository, 'update')
- .mockResolvedValue({ affected: 1 } as never);
-
- await service.resolveSession('sess_token');
-
- expect(updateSpy).toHaveBeenCalledWith(
- expect.objectContaining({ id: session.id }),
- expect.objectContaining({ lastActiveAt: expect.any(Date) }),
- );
- });
-
- it('should touch lastActiveAt within an idle timeout shorter than the throttle', async () => {
- mockConfig.SESSION_IDLE_TIMEOUT = '1m';
-
- const session = buildActiveSession({
- lastActiveAt: new Date(Date.now() - 40 * 1000),
- });
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(session);
- mockPostCachingRevocationCheck(session);
- const updateSpy = jest
- .spyOn(userSessionRepository, 'update')
- .mockResolvedValue({ affected: 1 } as never);
-
- await service.resolveSession('sess_token');
-
- expect(updateSpy).toHaveBeenCalledWith(
- expect.objectContaining({ id: session.id }),
- expect.objectContaining({ lastActiveAt: expect.any(Date) }),
- );
- });
-
- it('should not touch lastActiveAt on every request', async () => {
- const session = buildActiveSession({ lastActiveAt: new Date() });
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(session);
- mockPostCachingRevocationCheck(session);
- const updateSpy = jest.spyOn(userSessionRepository, 'update');
-
- await service.resolveSession('sess_token');
-
- expect(updateSpy).not.toHaveBeenCalled();
- });
-
- it('should reject and drop the cache entry when the touch hits a revoked session', async () => {
- const staleLastActiveAt = new Date(Date.now() - 10 * 60 * 1000);
- const session = buildActiveSession({ lastActiveAt: staleLastActiveAt });
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(session);
- jest
- .spyOn(userSessionRepository, 'update')
- .mockResolvedValue({ affected: 0 } as never);
-
- await expect(service.resolveSession('sess_token')).rejects.toThrow(
- 'Session is invalid or has expired.',
- );
- expect(cacheStorageService.del).toHaveBeenCalled();
- });
-
- it('should reject when a revocation raced the cache write', async () => {
- const session = buildActiveSession();
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(session);
- mockPostCachingRevocationCheck(
- buildActiveSession({ id: session.id, revokedAt: new Date() }),
- );
-
- await expect(service.resolveSession('sess_token')).rejects.toThrow(
- 'Session is invalid or has expired.',
- );
- expect(cacheStorageService.del).toHaveBeenCalled();
- });
- });
-
- describe('revokeSessionByToken', () => {
- it('should revoke the session, drop the cache entry and emit an event', async () => {
- const session = buildActiveSession();
-
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(session);
- jest
- .spyOn(userSessionRepository, 'update')
- .mockResolvedValue({ affected: 1 } as never);
-
- const wasRevoked = await service.revokeSessionByToken(
- 'sess_token',
- UserSessionRevokedReason.UserSignOut,
- );
-
- expect(wasRevoked).toBe(true);
- expect(cacheStorageService.del).toHaveBeenCalledWith(session.tokenHash);
- expect(insertWorkspaceEvent).toHaveBeenCalledWith(
- 'AuthSession',
- expect.objectContaining({ action: 'user_signed_out' }),
- );
- });
-
- it('should be a no-op for an unknown token', async () => {
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(null);
-
- const wasRevoked = await service.revokeSessionByToken(
- 'sess_unknown',
- UserSessionRevokedReason.UserSignOut,
- );
-
- expect(wasRevoked).toBe(false);
- });
- });
-
- describe('revokeSessionByIdForUserWorkspace', () => {
- it('should scope the lookup to the requesting user and workspace', async () => {
- const sessionId = randomUUID();
- const userId = randomUUID();
- const workspaceId = randomUUID();
- const findOneBySpy = jest
- .spyOn(userSessionRepository, 'findOneBy')
- .mockResolvedValue(null);
-
- await expect(
- service.revokeSessionByIdForUserWorkspace({
- sessionId,
- userId,
- workspaceId,
- reason: UserSessionRevokedReason.UserRevoked,
- }),
- ).rejects.toThrow('Session not found');
-
- expect(findOneBySpy).toHaveBeenCalledWith({
- id: sessionId,
- userId,
- workspaceId,
- });
- });
-
- it('should revoke a session the user owns and drop its cache entry', async () => {
- const userId = randomUUID();
- const workspaceId = randomUUID();
- const session = buildActiveSession({ userId, tokenHash: 'owned-hash' });
-
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(session);
- jest
- .spyOn(userSessionRepository, 'update')
- .mockResolvedValue({ affected: 1 } as never);
-
- const wasRevoked = await service.revokeSessionByIdForUserWorkspace({
- sessionId: session.id,
- userId,
- workspaceId,
- reason: UserSessionRevokedReason.UserRevoked,
- });
-
- expect(wasRevoked).toBe(true);
- expect(cacheStorageService.del).toHaveBeenCalledWith('owned-hash');
- expect(insertWorkspaceEvent).toHaveBeenCalledWith(
- 'AuthSession',
- expect.objectContaining({ action: 'session_revoked' }),
- );
- });
- });
-
- describe('revokeAllSessionsForUser', () => {
- const mockRevokingQueryBuilder = (revokedSessions: UserSessionEntity[]) => {
- const queryBuilder = {
- update: jest.fn().mockReturnThis(),
- set: jest.fn().mockReturnThis(),
- where: jest.fn().mockReturnThis(),
- andWhere: jest.fn().mockReturnThis(),
- returning: jest.fn().mockReturnThis(),
- execute: jest.fn().mockResolvedValue({
- raw: revokedSessions.map(
- ({ id, tokenHash, userId, workspaceId }) => ({
- id,
- tokenHash,
- userId,
- workspaceId,
- }),
- ),
- }),
- };
-
- jest
- .spyOn(userSessionRepository, 'createQueryBuilder')
- .mockReturnValue(queryBuilder as never);
-
- return queryBuilder;
- };
-
- it('should revoke every active session except the excluded one', async () => {
- const userId = randomUUID();
- const exceptSessionId = randomUUID();
- const sessions = [
- buildActiveSession({ userId, tokenHash: 'hash-1' }),
- buildActiveSession({ userId, tokenHash: 'hash-2' }),
- ];
-
- const queryBuilder = mockRevokingQueryBuilder(sessions);
-
- const revokedCount = await service.revokeAllSessionsForUser({
- userId,
- exceptSessionId,
- reason: UserSessionRevokedReason.PasswordChanged,
- });
-
- expect(revokedCount).toBe(2);
- expect(queryBuilder.set).toHaveBeenCalledWith(
- expect.objectContaining({
- revokedReason: UserSessionRevokedReason.PasswordChanged,
- }),
- );
- expect(queryBuilder.where).toHaveBeenCalledWith(expect.any(String), {
- userId,
- });
- expect(queryBuilder.andWhere).toHaveBeenCalledWith(expect.any(String), {
- exceptSessionId,
- });
- expect(cacheStorageService.mdel).toHaveBeenCalledWith([
- 'hash-1',
- 'hash-2',
- ]);
- });
-
- it('should scope the update to the user rather than to pre-read ids', async () => {
- const userId = randomUUID();
- const queryBuilder = mockRevokingQueryBuilder([
- buildActiveSession({ userId, tokenHash: 'hash' }),
- ]);
-
- const findSpy = jest.spyOn(userSessionRepository, 'find');
-
- await service.revokeAllSessionsForUser({
- userId,
- reason: UserSessionRevokedReason.PasswordChanged,
- });
-
- expect(findSpy).not.toHaveBeenCalled();
- expect(queryBuilder.andWhere).not.toHaveBeenCalledWith(
- expect.any(String),
- expect.objectContaining({ exceptSessionId: expect.anything() }),
- );
- });
-
- it('should narrow to one workspace when given one, and stay account-wide otherwise', async () => {
- const userId = randomUUID();
- const workspaceId = randomUUID();
-
- const scopedQueryBuilder = mockRevokingQueryBuilder([
- buildActiveSession({ userId, tokenHash: 'hash' }),
- ]);
-
- await service.revokeAllSessionsForUser({
- userId,
- workspaceId,
- reason: UserSessionRevokedReason.UserRevoked,
- });
-
- expect(scopedQueryBuilder.andWhere).toHaveBeenCalledWith(
- expect.any(String),
- { workspaceId },
- );
-
- const accountWideQueryBuilder = mockRevokingQueryBuilder([
- buildActiveSession({ userId, tokenHash: 'hash' }),
- ]);
-
- // Password change must reach every workspace, so an absent workspaceId
- // has to stay unscoped rather than defaulting to one.
- await service.revokeAllSessionsForUser({
- userId,
- reason: UserSessionRevokedReason.PasswordChanged,
- });
-
- expect(accountWideQueryBuilder.andWhere).not.toHaveBeenCalledWith(
- expect.any(String),
- expect.objectContaining({ workspaceId: expect.anything() }),
- );
- });
-
- it('should report nothing revoked when no session matched', async () => {
- mockRevokingQueryBuilder([]);
-
- const revokedCount = await service.revokeAllSessionsForUser({
- userId: randomUUID(),
- reason: UserSessionRevokedReason.PasswordChanged,
- });
-
- expect(revokedCount).toBe(0);
- expect(insertWorkspaceEvent).not.toHaveBeenCalled();
- expect(cacheStorageService.mdel).not.toHaveBeenCalled();
- });
- });
-
- describe('issueSessionForTokenPair', () => {
- const buildTokenPair = () => ({
- accessOrWorkspaceAgnosticToken: {
- token: 'jwt-access-token',
- expiresAt: new Date(),
- },
- refreshToken: { token: 'jwt-refresh-token', expiresAt: new Date() },
- });
-
- const buildRequest = (cookieHeader?: string, origin?: string) =>
- ({
- headers: {
- ...(cookieHeader === undefined ? {} : { cookie: cookieHeader }),
- ...(origin === undefined ? {} : { origin }),
- 'user-agent': 'jest',
- },
- protocol: 'http',
- get: () => 'crm.example.com',
- ip: '127.0.0.1',
- res: { cookie: jest.fn(), clearCookie: jest.fn() },
- }) as never;
-
- const mockAccessPayload = () => {
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue({
- sub: 'user-id',
- userId: 'user-id',
- workspaceId: 'workspace-id',
- userWorkspaceId: 'user-workspace-id',
- authProvider: AuthProviderEnum.Password,
- type: JwtTokenTypeEnum.ACCESS,
- });
- };
-
- beforeEach(() => {
- mockConfig.AUTH_COOKIE_SESSIONS_ENABLED = true;
- });
-
- it('should be a no-op when cookie sessions are disabled', async () => {
- mockConfig.AUTH_COOKIE_SESSIONS_ENABLED = false;
-
- const createSessionSpy = jest.spyOn(service, 'createSession');
-
- await service.issueSessionForTokenPair({
- tokenPair: buildTokenPair(),
- request: buildRequest(),
- origin: 'sign_in',
- });
-
- expect(createSessionSpy).not.toHaveBeenCalled();
- });
-
- it('should mint a session and set the cookie on sign-in', async () => {
- mockAccessPayload();
-
- const session = buildActiveSession();
- const request = buildRequest();
-
- jest
- .spyOn(service, 'createSession')
- .mockResolvedValue({ sessionToken: 'sess_new', session });
-
- await service.issueSessionForTokenPair({
- tokenPair: buildTokenPair(),
- request,
- origin: 'sign_in',
- });
-
- expect(service.createSession).toHaveBeenCalledWith(
- expect.objectContaining({
- userId: 'user-id',
- workspaceId: 'workspace-id',
- userWorkspaceId: 'user-workspace-id',
- origin: 'sign_in',
- userAgent: 'jest',
- ipAddress: '127.0.0.1',
- }),
- );
- expect(
- (request as { res: { cookie: jest.Mock } }).res.cookie,
- ).toHaveBeenCalled();
- });
-
- it('should not set the cookie for a disallowed origin', async () => {
- mockAccessPayload();
-
- const createSessionSpy = jest.spyOn(service, 'createSession');
- const request = buildRequest(undefined, 'https://evil.example.org');
-
- await service.issueSessionForTokenPair({
- tokenPair: buildTokenPair(),
- request,
- origin: 'sign_in',
- });
-
- expect(createSessionSpy).not.toHaveBeenCalled();
- expect(
- (request as { res: { cookie: jest.Mock } }).res.cookie,
- ).not.toHaveBeenCalled();
- });
-
- it('should set the cookie for the origin the request arrived on', async () => {
- mockAccessPayload();
-
- jest.spyOn(service, 'createSession').mockResolvedValue({
- sessionToken: 'sess_new',
- session: buildActiveSession(),
- });
-
- const request = buildRequest(undefined, 'http://crm.example.com');
-
- await service.issueSessionForTokenPair({
- tokenPair: buildTokenPair(),
- request,
- origin: 'sign_in',
- });
-
- expect(
- (request as { res: { cookie: jest.Mock } }).res.cookie,
- ).toHaveBeenCalled();
- });
-
- it('should supersede the presented session on sign-in', async () => {
- mockAccessPayload();
-
- const presentedSession = buildActiveSession();
-
- jest
- .spyOn(userSessionRepository, 'findOneBy')
- .mockResolvedValue(presentedSession);
- jest
- .spyOn(userSessionRepository, 'update')
- .mockResolvedValue({ affected: 1 } as never);
- jest.spyOn(service, 'createSession').mockResolvedValue({
- sessionToken: 'sess_new',
- session: buildActiveSession(),
- });
-
- await service.issueSessionForTokenPair({
- tokenPair: buildTokenPair(),
- request: buildRequest('twenty-session=sess_old'),
- origin: 'sign_in',
- });
-
- expect(userSessionRepository.update).toHaveBeenCalledWith(
- expect.objectContaining({ id: presentedSession.id }),
- expect.objectContaining({
- revokedReason: UserSessionRevokedReason.Superseded,
- }),
- );
- expect(service.createSession).toHaveBeenCalled();
- });
-
- it('should not mint a new session on renewal when a valid one is presented', async () => {
- mockAccessPayload();
-
- const presentedSession = buildActiveSession({
- userId: 'user-id',
- workspaceId: 'workspace-id',
- userWorkspaceId: 'user-workspace-id',
- });
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest
- .spyOn(userSessionRepository, 'findOneBy')
- .mockResolvedValue(presentedSession);
- jest
- .spyOn(userSessionRepository, 'findOne')
- .mockResolvedValue(presentedSession);
- const createSessionSpy = jest.spyOn(service, 'createSession');
- const revokeSpy = jest.spyOn(service, 'revokeSessionByToken');
-
- await service.issueSessionForTokenPair({
- tokenPair: buildTokenPair(),
- request: buildRequest('twenty-session=sess_current'),
- origin: 'renewal_bridge',
- });
-
- expect(createSessionSpy).not.toHaveBeenCalled();
- expect(revokeSpy).not.toHaveBeenCalled();
- });
-
- it('should supersede a presented session scoped to another workspace', async () => {
- mockAccessPayload();
-
- const presentedSession = buildActiveSession({
- userId: 'user-id',
- workspaceId: 'another-workspace-id',
- userWorkspaceId: 'another-user-workspace-id',
- });
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest
- .spyOn(userSessionRepository, 'findOneBy')
- .mockResolvedValue(presentedSession);
- jest
- .spyOn(userSessionRepository, 'findOne')
- .mockResolvedValue(presentedSession);
- jest
- .spyOn(service, 'revokeSessionByToken')
- .mockResolvedValue(true as never);
- const createSessionSpy = jest
- .spyOn(service, 'createSession')
- .mockResolvedValue({
- sessionToken: 'sess_new',
- session: buildActiveSession(),
- } as never);
-
- await service.issueSessionForTokenPair({
- tokenPair: buildTokenPair(),
- request: buildRequest('twenty-session=sess_current'),
- origin: 'renewal_bridge',
- });
-
- expect(service.revokeSessionByToken).toHaveBeenCalled();
- expect(createSessionSpy).toHaveBeenCalled();
- });
-
- it('should mint a session on renewal when the presented one is invalid', async () => {
- mockAccessPayload();
-
- cacheStorageService.get.mockResolvedValue(undefined);
- jest.spyOn(userSessionRepository, 'findOneBy').mockResolvedValue(null);
- jest.spyOn(service, 'createSession').mockResolvedValue({
- sessionToken: 'sess_new',
- session: buildActiveSession(),
- });
-
- await service.issueSessionForTokenPair({
- tokenPair: buildTokenPair(),
- request: buildRequest('twenty-session=sess_stale'),
- origin: 'renewal_bridge',
- });
-
- expect(service.createSession).toHaveBeenCalledWith(
- expect.objectContaining({ origin: 'renewal_bridge' }),
- );
- });
-
- it('should never throw when session creation fails', async () => {
- mockAccessPayload();
-
- jest
- .spyOn(service, 'createSession')
- .mockRejectedValue(new Error('database is down'));
-
- await expect(
- service.issueSessionForTokenPair({
- tokenPair: buildTokenPair(),
- request: buildRequest(),
- origin: 'sign_in',
- }),
- ).resolves.toBeUndefined();
- });
- });
-
- describe('signOut', () => {
- it('should revoke the presented refresh token by jti', async () => {
- const refreshTokenId = randomUUID();
-
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockResolvedValue(undefined);
- jest.spyOn(jwtWrapperService, 'decode').mockReturnValue({
- type: JwtTokenTypeEnum.REFRESH,
- jti: refreshTokenId,
- });
- const updateSpy = jest
- .spyOn(appTokenRepository, 'update')
- .mockResolvedValue({ affected: 1 } as never);
-
- await service.signOut({ refreshToken: 'refresh-token' });
-
- expect(updateSpy).toHaveBeenCalledWith(
- expect.objectContaining({ id: refreshTokenId }),
- expect.objectContaining({ revokedAt: expect.any(Date) }),
- );
- });
-
- it('should swallow invalid refresh tokens', async () => {
- jest
- .spyOn(jwtWrapperService, 'verifyJwtToken')
- .mockRejectedValue(new Error('expired'));
- const updateSpy = jest.spyOn(appTokenRepository, 'update');
-
- await expect(
- service.signOut({ refreshToken: 'expired-token' }),
- ).resolves.toBeUndefined();
- expect(updateSpy).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/user-workspace/user-workspace.service.spec.ts b/packages/twenty-server/src/engine/core-modules/user-workspace/user-workspace.service.spec.ts
deleted file mode 100644
index 6c307f9feb3..00000000000
--- a/packages/twenty-server/src/engine/core-modules/user-workspace/user-workspace.service.spec.ts
+++ /dev/null
@@ -1,1082 +0,0 @@
-import { OpenRecordIn } from 'twenty-shared/types';
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { type DataSource, type Repository } from 'typeorm';
-
-import { type AppTokenEntity } from 'src/engine/core-modules/app-token/app-token.entity';
-import { type ApprovedAccessDomainEntity } from 'src/engine/core-modules/approved-access-domain/approved-access-domain.entity';
-import { ApprovedAccessDomainService } from 'src/engine/core-modules/approved-access-domain/services/approved-access-domain.service';
-import { CoreEntityCacheService } from 'src/engine/core-entity-cache/services/core-entity-cache.service';
-import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
-import { LoginTokenService } from 'src/engine/core-modules/auth/token/services/login-token.service';
-import { type AuthContextUser } from 'src/engine/core-modules/auth/types/auth-context.type';
-import { WorkspaceDomainsService } from 'src/engine/core-modules/domain/workspace-domains/services/workspace-domains.service';
-import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
-import { FileStorageService } from 'src/engine/core-modules/file-storage/services/file-storage.service';
-import { FileCorePictureService } from 'src/engine/core-modules/file/file-core-picture/services/file-core-picture.service';
-import { FileUrlService } from 'src/engine/core-modules/file/file-url/file-url.service';
-import { OnboardingService } from 'src/engine/core-modules/onboarding/onboarding.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { WorkspaceInvitationService } from 'src/engine/core-modules/workspace-invitation/services/workspace-invitation.service';
-import { WorkspaceDiscoverability } from 'src/engine/core-modules/workspace/types/workspace-discoverability.type';
-import { type WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
-import { PermissionsException } from 'src/engine/metadata-modules/permissions/permissions.exception';
-import { RoleTargetEntity } from 'src/engine/metadata-modules/role-target/role-target.entity';
-import { RoleValidationService } from 'src/engine/metadata-modules/role-validation/services/role-validation.service';
-import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type WorkspaceRepository } from 'src/engine/twenty-orm/repository/workspace.repository';
-
-describe('UserWorkspaceService', () => {
- let service: UserWorkspaceService;
- let userWorkspaceRepository: Repository<UserWorkspaceEntity>;
- let userRepository: Repository<UserEntity>;
- let workspaceInvitationService: WorkspaceInvitationService;
- let approvedAccessDomainService: ApprovedAccessDomainService;
- let globalWorkspaceOrmManager: GlobalWorkspaceOrmManager;
- let userRoleService: UserRoleService;
- let onboardingService: OnboardingService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- UserWorkspaceService,
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: {
- create: jest.fn(),
- save: jest.fn(),
- findOneBy: jest.fn(),
- countBy: jest.fn(),
- exists: jest.fn(),
- findOne: jest.fn(),
- findOneOrFail: jest.fn(),
- manager: {
- connection: { driver: { options: { type: 'postgres' } } },
- },
- metadata: { columns: [] },
- },
- },
- {
- provide: getRepositoryToken(UserEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(ObjectMetadataEntity),
- useValue: {
- findOneOrFail: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(RoleTargetEntity),
- useValue: {
- findOneOrFail: jest.fn(),
- },
- },
- {
- provide: RoleValidationService,
- useValue: {
- validateRoleAssignableToUsersOrThrow: jest.fn(),
- },
- },
- {
- provide: WorkspaceInvitationService,
- useValue: {
- invalidateWorkspaceInvitation: jest.fn(),
- findInvitationsByEmail: jest.fn(),
- },
- },
- {
- provide: WorkspaceDomainsService,
- useValue: {
- getWorkspaceUrls: jest.fn(),
- },
- },
- {
- provide: ApprovedAccessDomainService,
- useValue: {
- findValidatedApprovedAccessDomainWithWorkspacesAndSSOIdentityProvidersDomain:
- jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation(
- async (callback: () => any, _authContext?: any) => callback(),
- ),
- getRepository: jest.fn(),
- },
- },
- {
- provide: UserRoleService,
- useValue: {
- assignRoleToManyUserWorkspace: jest.fn(),
- },
- },
- {
- provide: FileCorePictureService,
- useValue: {},
- },
- {
- provide: FileUrlService,
- useValue: {},
- },
- {
- provide: FileStorageService,
- useValue: {
- copy: jest.fn(),
- },
- },
- {
- provide: LoginTokenService,
- useValue: {},
- },
- {
- provide: OnboardingService,
- useValue: {
- setOnboardingCreateProfilePending: jest.fn(),
- },
- },
- {
- provide: CoreEntityCacheService,
- useValue: {
- invalidate: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: FeatureFlagService,
- useValue: {
- isFeatureEnabled: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<UserWorkspaceService>(UserWorkspaceService);
- userWorkspaceRepository = module.get(
- getRepositoryToken(UserWorkspaceEntity),
- );
- userRepository = module.get(getRepositoryToken(UserEntity));
- workspaceInvitationService = module.get<WorkspaceInvitationService>(
- WorkspaceInvitationService,
- );
- approvedAccessDomainService = module.get<ApprovedAccessDomainService>(
- ApprovedAccessDomainService,
- );
- globalWorkspaceOrmManager = module.get<GlobalWorkspaceOrmManager>(
- GlobalWorkspaceOrmManager,
- );
- (globalWorkspaceOrmManager.getRepository as jest.Mock).mockResolvedValue({
- findOne: jest.fn(),
- update: jest.fn(),
- } as unknown as WorkspaceRepository<UserWorkspaceEntity>);
-
- userRoleService = module.get<UserRoleService>(UserRoleService);
- onboardingService = module.get<OnboardingService>(OnboardingService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('create', () => {
- it("should create a user workspace without a default avatar url if it's an existing user without any user workspace having a default avatar url", async () => {
- const userId = 'user-id';
- const workspaceId = 'workspace-id';
- const userWorkspace = {
- userId,
- workspaceId,
- } as UserWorkspaceEntity;
-
- jest
- .spyOn(userWorkspaceRepository, 'create')
- .mockReturnValue(userWorkspace);
- jest
- .spyOn(userWorkspaceRepository, 'save')
- .mockResolvedValue(userWorkspace);
-
- jest.spyOn(userWorkspaceRepository, 'findOne').mockResolvedValue(null);
-
- const result = await service.create({
- userId,
- workspaceId,
- isExistingUser: true,
- });
-
- expect(userWorkspaceRepository.create).toHaveBeenCalledWith({
- userId,
- workspaceId,
- defaultAvatarUrl: undefined,
- });
- expect(userWorkspaceRepository.save).toHaveBeenCalledWith(userWorkspace);
- expect(result).toEqual(userWorkspace);
- });
- it("should create a user workspace without a default avatar url if it's a new user without a picture url", async () => {
- const userId = 'user-id';
- const workspaceId = 'workspace-id';
- const userWorkspace = {
- userId,
- workspaceId,
- } as unknown as UserWorkspaceEntity;
-
- jest
- .spyOn(userWorkspaceRepository, 'create')
- .mockReturnValue(userWorkspace);
- jest
- .spyOn(userWorkspaceRepository, 'save')
- .mockResolvedValue(userWorkspace);
-
- const result = await service.create({
- userId,
- workspaceId,
- isExistingUser: false,
- pictureUrl: undefined,
- });
-
- expect(userWorkspaceRepository.save).toHaveBeenCalledWith(userWorkspace);
- expect(result).toEqual(userWorkspace);
- });
- });
-
- describe('createWorkspaceMember', () => {
- it('should create a workspace member', async () => {
- const workspaceId = 'workspace-id';
- const user = {
- id: 'user-id',
- email: '[email protected]',
- firstName: 'John',
- lastName: 'Doe',
- locale: 'en',
- isEmailVerified: false,
- disabled: false,
- canImpersonate: false,
- canAccessFullAdminPanel: false,
- createdAt: '2024-01-01T00:00:00.000Z',
- updatedAt: '2024-01-01T00:00:00.000Z',
- deletedAt: null,
- } as unknown as AuthContextUser;
- const mainDataSource = {
- query: jest.fn(),
- } as unknown as DataSource;
- const workspaceMember = [
- {
- id: 'workspace-member-id',
- nameFirstName: 'John',
- nameLastName: 'Doe',
- userId: 'user-id',
- userEmail: '[email protected]',
- },
- ];
- const workspaceMemberRepository = {
- insert: jest.fn(),
- find: jest
- .fn()
- .mockResolvedValueOnce([])
- .mockResolvedValue(workspaceMember),
- };
-
- jest
- .spyOn(mainDataSource, 'query')
- .mockResolvedValueOnce(undefined)
- .mockResolvedValueOnce(workspaceMember);
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(workspaceMemberRepository as any);
-
- jest.spyOn(userWorkspaceRepository, 'findOneOrFail').mockResolvedValue({
- defaultAvatarUrl: 'userWorkspace-avatar-url',
- } as UserWorkspaceEntity);
-
- await service.createWorkspaceMember(workspaceId, user);
-
- expect(workspaceMemberRepository.insert).toHaveBeenCalledWith({
- name: {
- firstName: user.firstName,
- lastName: user.lastName,
- },
- colorScheme: 'System',
- openRecordIn: OpenRecordIn.SIDE_PANEL,
- userId: user.id,
- userEmail: user.email,
- locale: 'en',
- avatarUrl: 'userWorkspace-avatar-url',
- });
- });
-
- it('should not create a workspace member when one already exists', async () => {
- const workspaceId = 'workspace-id';
- const user = {
- id: 'user-id',
- email: '[email protected]',
- firstName: 'John',
- lastName: 'Doe',
- locale: 'en',
- } as unknown as AuthContextUser;
- const workspaceMemberRepository = {
- insert: jest.fn(),
- find: jest
- .fn()
- .mockResolvedValue([{ id: 'existing-member-id', userId: 'user-id' }]),
- };
-
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(workspaceMemberRepository as any);
-
- await service.createWorkspaceMember(workspaceId, user);
-
- expect(workspaceMemberRepository.insert).not.toHaveBeenCalled();
- });
- });
-
- describe('addUserToWorkspaceIfUserNotInWorkspace', () => {
- it('should add user to workspace if not already in workspace', async () => {
- const user = {
- id: 'user-id',
- email: '[email protected]',
- createdAt: new Date('2024-01-01'),
- updatedAt: new Date('2024-01-01'),
- deletedAt: null,
- } as unknown as UserEntity;
- const workspace = {
- id: 'workspace-id',
- defaultRoleId: 'default-role-id',
- } as WorkspaceEntity;
- const userWorkspace = {
- id: 'user-workspace-id',
- userId: user.id,
- workspaceId: workspace.id,
- } as UserWorkspaceEntity;
-
- jest.spyOn(service, 'checkUserWorkspaceExists').mockResolvedValue(null);
- jest.spyOn(service, 'create').mockResolvedValue(userWorkspace);
- jest.spyOn(service, 'createWorkspaceMember').mockResolvedValue(undefined);
- jest
- .spyOn(userRoleService, 'assignRoleToManyUserWorkspace')
- .mockResolvedValue(undefined);
- jest
- .spyOn(workspaceInvitationService, 'invalidateWorkspaceInvitation')
- .mockResolvedValue(undefined);
-
- await service.addUserToWorkspaceIfUserNotInWorkspace(user, workspace);
-
- expect(service.checkUserWorkspaceExists).toHaveBeenCalledWith(
- user.id,
- workspace.id,
- );
- expect(service.create).toHaveBeenCalled();
- expect(service.create).toHaveBeenCalledWith({
- workspaceId: workspace.id,
- userId: user.id,
- isExistingUser: true,
- });
- expect(service.createWorkspaceMember).toHaveBeenCalledWith(
- workspace.id,
- expect.objectContaining({ id: user.id, email: user.email }),
- );
- expect(
- userRoleService.assignRoleToManyUserWorkspace,
- ).toHaveBeenCalledWith({
- workspaceId: workspace.id,
- userWorkspaceIds: [userWorkspace.id],
- roleId: workspace.defaultRoleId,
- });
- expect(
- workspaceInvitationService.invalidateWorkspaceInvitation,
- ).toHaveBeenCalledWith(workspace.id, user.email);
-
- expect(
- onboardingService.setOnboardingCreateProfilePending,
- ).toHaveBeenCalledWith({
- userId: user.id,
- workspaceId: workspace.id,
- value: true,
- });
- });
-
- it('should not add user to workspace if already in workspace', async () => {
- const user = {
- id: 'user-id',
- email: '[email protected]',
- createdAt: new Date('2024-01-01'),
- updatedAt: new Date('2024-01-01'),
- deletedAt: null,
- } as unknown as UserEntity;
- const workspace = {
- id: 'workspace-id',
- defaultRoleId: 'default-role-id',
- } as WorkspaceEntity;
- const userWorkspace = {
- id: 'user-workspace-id',
- userId: user.id,
- workspaceId: workspace.id,
- } as UserWorkspaceEntity;
-
- jest
- .spyOn(service, 'checkUserWorkspaceExists')
- .mockResolvedValue(userWorkspace);
- jest.spyOn(service, 'create').mockResolvedValue(userWorkspace);
- jest.spyOn(service, 'createWorkspaceMember').mockResolvedValue(undefined);
-
- await service.addUserToWorkspaceIfUserNotInWorkspace(user, workspace);
-
- expect(service.checkUserWorkspaceExists).toHaveBeenCalledWith(
- user.id,
- workspace.id,
- );
- expect(service.create).not.toHaveBeenCalled();
- expect(service.createWorkspaceMember).not.toHaveBeenCalled();
- });
-
- it('should throw an exception if workspace has no default role', async () => {
- const user = {
- id: 'user-id',
- email: '[email protected]',
- createdAt: new Date('2024-01-01'),
- updatedAt: new Date('2024-01-01'),
- deletedAt: null,
- } as unknown as UserEntity;
- const workspace = {
- id: 'workspace-id',
- defaultRoleId: undefined,
- } as unknown as WorkspaceEntity;
-
- jest.spyOn(service, 'checkUserWorkspaceExists').mockResolvedValue(null);
- jest
- .spyOn(service, 'create')
- .mockResolvedValue({} as UserWorkspaceEntity);
- jest.spyOn(service, 'createWorkspaceMember').mockResolvedValue(undefined);
-
- await expect(
- service.addUserToWorkspaceIfUserNotInWorkspace(user, workspace),
- ).rejects.toThrow(PermissionsException);
- });
- });
-
- describe('isWorkspaceCreator', () => {
- it('should treat the earliest membership as the creator, including soft-deleted ones', async () => {
- jest.spyOn(userWorkspaceRepository, 'findOne').mockResolvedValue({
- userId: 'creator-user-id',
- } as UserWorkspaceEntity);
-
- await expect(
- service.isWorkspaceCreator({
- userId: 'creator-user-id',
- workspaceId: 'workspace-id',
- }),
- ).resolves.toBe(true);
-
- expect(userWorkspaceRepository.findOne).toHaveBeenCalledWith({
- where: { workspaceId: 'workspace-id' },
- order: { createdAt: 'ASC' },
- withDeleted: true,
- });
- });
-
- it('should return false for a later member', async () => {
- jest.spyOn(userWorkspaceRepository, 'findOne').mockResolvedValue({
- userId: 'creator-user-id',
- } as UserWorkspaceEntity);
-
- await expect(
- service.isWorkspaceCreator({
- userId: 'second-user-id',
- workspaceId: 'workspace-id',
- }),
- ).resolves.toBe(false);
- });
- });
-
- describe('getUserCount', () => {
- it('should return the count of users in a workspace', async () => {
- const workspaceId = 'workspace-id';
- const count = 5;
-
- jest.spyOn(userWorkspaceRepository, 'countBy').mockResolvedValue(count);
-
- const result = await service.getUserCount(workspaceId);
-
- expect(userWorkspaceRepository.countBy).toHaveBeenCalledWith({
- workspaceId,
- });
- expect(result).toEqual(count);
- });
- });
-
- describe('checkUserWorkspaceExists', () => {
- it('should check if a user workspace exists', async () => {
- const userId = 'user-id';
- const workspaceId = 'workspace-id';
- const userWorkspace = {
- userId,
- workspaceId,
- } as unknown as UserWorkspaceEntity;
-
- jest
- .spyOn(userWorkspaceRepository, 'findOneBy')
- .mockResolvedValue(userWorkspace);
-
- const result = await service.checkUserWorkspaceExists(
- userId,
- workspaceId,
- );
-
- expect(userWorkspaceRepository.findOneBy).toHaveBeenCalledWith({
- userId,
- workspaceId,
- });
- expect(result).toEqual(userWorkspace);
- });
-
- it('should return null if user workspace does not exist', async () => {
- const userId = 'user-id';
- const workspaceId = 'workspace-id';
-
- jest.spyOn(userWorkspaceRepository, 'findOneBy').mockResolvedValue(null);
-
- const result = await service.checkUserWorkspaceExists(
- userId,
- workspaceId,
- );
-
- expect(userWorkspaceRepository.findOneBy).toHaveBeenCalledWith({
- userId,
- workspaceId,
- });
- expect(result).toBeNull();
- });
- });
-
- describe('checkUserWorkspaceExistsByEmail', () => {
- it('should check if a user workspace exists by email', async () => {
- const email = '[email protected]';
- const workspaceId = 'workspace-id';
-
- jest.spyOn(userWorkspaceRepository, 'exists').mockResolvedValue(true);
-
- const result = await service.checkUserWorkspaceExistsByEmail(
- email,
- workspaceId,
- );
-
- expect(userWorkspaceRepository.exists).toHaveBeenCalledWith({
- where: {
- workspaceId,
- user: {
- email,
- },
- },
- relations: {
- user: true,
- },
- });
- expect(result).toBe(true);
- });
- });
-
- describe('findAvailableWorkspacesByEmail', () => {
- it('should find available workspaces for an email', async () => {
- const email = '[email protected]';
- const workspace1 = {
- id: 'workspace-id-1',
- displayName: 'Workspace 1',
- logo: 'logo1.png',
- workspaceSSOIdentityProviders: [
- {
- id: 'sso-id-1',
- name: 'SSO Provider 1',
- issuer: 'issuer1',
- type: 'type1',
- status: 'Active',
- },
- {
- id: 'sso-id-2',
- name: 'SSO Provider 2',
- issuer: 'issuer2',
- type: 'type2',
- status: 'Inactive',
- },
- ],
- } as unknown as WorkspaceEntity;
- const workspace2 = {
- id: 'workspace-id-2',
- displayName: 'Workspace 2',
- logo: 'logo2.png',
- workspaceSSOIdentityProviders: [],
- } as unknown as WorkspaceEntity;
- const user = {
- email,
- userWorkspaces: [
- {
- workspaceId: workspace1.id,
- workspace: workspace1,
- },
- {
- workspaceId: workspace2.id,
- workspace: workspace2,
- },
- ],
- } as UserEntity;
-
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(user);
- jest
- .spyOn(
- approvedAccessDomainService,
- 'findValidatedApprovedAccessDomainWithWorkspacesAndSSOIdentityProvidersDomain',
- )
- .mockResolvedValue([]);
-
- jest
- .spyOn(workspaceInvitationService, 'findInvitationsByEmail')
- .mockResolvedValue([]);
-
- const result = await service.findAvailableWorkspacesByEmail(email);
-
- expect(userRepository.findOne).toHaveBeenCalledWith({
- where: {
- email,
- },
- relations: {
- userWorkspaces: {
- workspace: {
- workspaceSSOIdentityProviders: true,
- approvedAccessDomains: true,
- },
- },
- },
- });
-
- expect(result).toEqual({
- availableWorkspacesForSignIn: [
- { workspace: workspace1 },
- { workspace: workspace2 },
- ],
- availableWorkspacesForSignUp: [],
- });
- });
-
- it('should find available workspaces including approved domain workspace for an email', async () => {
- const email = '[email protected]';
- const workspace1 = {
- id: 'workspace-id-1',
- displayName: 'Workspace 1',
- logo: 'logo1.png',
- workspaceSSOIdentityProviders: [
- {
- id: 'sso-id-1',
- name: 'SSO Provider 1',
- issuer: 'issuer1',
- type: 'type1',
- status: 'Active',
- },
- {
- id: 'sso-id-2',
- name: 'SSO Provider 2',
- issuer: 'issuer2',
- type: 'type2',
- status: 'Inactive',
- },
- ],
- } as unknown as WorkspaceEntity;
- const workspace2 = {
- id: 'workspace-id-2',
- displayName: 'Workspace 2',
- logo: 'logo2.png',
- workspaceSSOIdentityProviders: [],
- workspaceDiscoverability: WorkspaceDiscoverability.PUBLIC,
- } as unknown as WorkspaceEntity;
-
- const user = {
- email,
- userWorkspaces: [
- {
- workspaceId: workspace1.id,
- workspace: workspace1,
- },
- ],
- } as UserEntity;
-
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(user);
- jest
- .spyOn(
- approvedAccessDomainService,
- 'findValidatedApprovedAccessDomainWithWorkspacesAndSSOIdentityProvidersDomain',
- )
- .mockResolvedValueOnce([
- {
- id: 'domain-id-2',
- workspaceId: workspace2.id,
- workspace: workspace2,
- isValidated: true,
- } as unknown as ApprovedAccessDomainEntity,
- ]);
-
- jest
- .spyOn(workspaceInvitationService, 'findInvitationsByEmail')
- .mockResolvedValue([]);
-
- const result = await service.findAvailableWorkspacesByEmail(email);
-
- expect(userRepository.findOne).toHaveBeenCalledWith({
- where: {
- email,
- },
- relations: {
- userWorkspaces: {
- workspace: {
- workspaceSSOIdentityProviders: true,
- approvedAccessDomains: true,
- },
- },
- },
- });
-
- expect(result).toEqual({
- availableWorkspacesForSignIn: [{ workspace: workspace1 }],
- availableWorkspacesForSignUp: [{ workspace: workspace2 }],
- });
- });
-
- it('should return workspace with approved access domain if user is not found', async () => {
- const email = '[email protected]';
- const workspace1 = {
- id: 'workspace-id-1',
- displayName: 'Workspace 1',
- logo: 'logo1.png',
- workspaceSSOIdentityProviders: [],
- workspaceDiscoverability: WorkspaceDiscoverability.PUBLIC,
- } as unknown as WorkspaceEntity;
-
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(null);
-
- jest
- .spyOn(
- approvedAccessDomainService,
- 'findValidatedApprovedAccessDomainWithWorkspacesAndSSOIdentityProvidersDomain',
- )
- .mockResolvedValueOnce([
- {
- id: 'domain-id-1',
- workspaceId: workspace1.id,
- workspace: workspace1,
- isValidated: true,
- } as unknown as ApprovedAccessDomainEntity,
- ]);
-
- jest
- .spyOn(workspaceInvitationService, 'findInvitationsByEmail')
- .mockResolvedValue([]);
-
- const result = await service.findAvailableWorkspacesByEmail(email);
-
- expect(result).toEqual({
- availableWorkspacesForSignIn: [],
- availableWorkspacesForSignUp: [{ workspace: workspace1 }],
- });
- });
-
- describe('workspaceDiscoverability', () => {
- const email = '[email protected]';
-
- const buildWorkspace = (
- id: string,
- workspaceDiscoverability: WorkspaceDiscoverability,
- ) =>
- ({
- id,
- displayName: id,
- workspaceSSOIdentityProviders: [],
- workspaceDiscoverability,
- }) as unknown as WorkspaceEntity;
-
- const mockSources = ({
- memberships = [],
- approvedAccessDomains = [],
- invitations = [],
- }: {
- memberships?: WorkspaceEntity[];
- approvedAccessDomains?: WorkspaceEntity[];
- invitations?: WorkspaceEntity[];
- }) => {
- jest.spyOn(userRepository, 'findOne').mockResolvedValue({
- email,
- userWorkspaces: memberships.map((workspace) => ({
- workspaceId: workspace.id,
- workspace,
- })),
- } as UserEntity);
-
- jest
- .spyOn(
- approvedAccessDomainService,
- 'findValidatedApprovedAccessDomainWithWorkspacesAndSSOIdentityProvidersDomain',
- )
- .mockResolvedValue(
- approvedAccessDomains.map(
- (workspace) =>
- ({
- id: `domain-${workspace.id}`,
- workspaceId: workspace.id,
- workspace,
- isValidated: true,
- }) as unknown as ApprovedAccessDomainEntity,
- ),
- );
-
- jest
- .spyOn(workspaceInvitationService, 'findInvitationsByEmail')
- .mockResolvedValue(
- invitations.map(
- (workspace) =>
- ({
- workspaceId: workspace.id,
- workspace,
- }) as unknown as AppTokenEntity,
- ),
- );
- };
-
- it('should list a membership unless the workspace is hidden', async () => {
- const publicWorkspace = buildWorkspace(
- 'public',
- WorkspaceDiscoverability.PUBLIC,
- );
- const membersAndInviteesWorkspace = buildWorkspace(
- 'members-and-invitees',
- WorkspaceDiscoverability.MEMBERS_AND_INVITEES,
- );
-
- mockSources({
- memberships: [
- publicWorkspace,
- membersAndInviteesWorkspace,
- buildWorkspace('hidden', WorkspaceDiscoverability.HIDDEN),
- ],
- });
-
- const result = await service.findAvailableWorkspacesByEmail(email);
-
- expect(result.availableWorkspacesForSignIn).toEqual([
- { workspace: publicWorkspace },
- { workspace: membersAndInviteesWorkspace },
- ]);
- });
-
- it('should surface a workspace by email domain only when it is public', async () => {
- const publicWorkspace = buildWorkspace(
- 'public',
- WorkspaceDiscoverability.PUBLIC,
- );
-
- mockSources({
- approvedAccessDomains: [
- publicWorkspace,
- buildWorkspace(
- 'members-and-invitees',
- WorkspaceDiscoverability.MEMBERS_AND_INVITEES,
- ),
- buildWorkspace('hidden', WorkspaceDiscoverability.HIDDEN),
- ],
- });
-
- const result = await service.findAvailableWorkspacesByEmail(email);
-
- expect(result.availableWorkspacesForSignUp).toEqual([
- { workspace: publicWorkspace },
- ]);
- });
-
- it('should list an invitation unless the workspace is hidden', async () => {
- const membersAndInviteesWorkspace = buildWorkspace(
- 'members-and-invitees',
- WorkspaceDiscoverability.MEMBERS_AND_INVITEES,
- );
-
- mockSources({
- invitations: [
- membersAndInviteesWorkspace,
- buildWorkspace('hidden', WorkspaceDiscoverability.HIDDEN),
- ],
- });
-
- const result = await service.findAvailableWorkspacesByEmail(email);
-
- expect(result.availableWorkspacesForSignUp).toEqual([
- expect.objectContaining({ workspace: membersAndInviteesWorkspace }),
- ]);
- });
-
- it('should keep a hidden workspace out of every source at once', async () => {
- const hiddenWorkspace = buildWorkspace(
- 'hidden',
- WorkspaceDiscoverability.HIDDEN,
- );
-
- mockSources({
- memberships: [hiddenWorkspace],
- approvedAccessDomains: [hiddenWorkspace],
- invitations: [hiddenWorkspace],
- });
-
- const result = await service.findAvailableWorkspacesByEmail(email);
-
- expect(result).toEqual({
- availableWorkspacesForSignIn: [],
- availableWorkspacesForSignUp: [],
- });
- });
- });
- });
-
- describe('findFirstWorkspaceByUserId', () => {
- it('should find the first workspace for a user', async () => {
- const userId = 'user-id';
- const workspace1 = {
- id: 'workspace-id',
- createdAt: '2025-01-02T00:00:00.000Z',
- } as unknown as WorkspaceEntity;
- const workspace2 = {
- id: 'workspace-id-2',
- createdAt: '2025-01-01T00:00:00.000Z',
- } as unknown as WorkspaceEntity;
- const user = {
- id: userId,
- userWorkspaces: [{ workspace: workspace1 }, { workspace: workspace2 }],
- } as unknown as UserEntity;
-
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(user);
-
- const result = await service.findFirstWorkspaceByUserId(userId);
-
- expect(userRepository.findOne).toHaveBeenCalledWith({
- where: {
- id: userId,
- },
- relations: { userWorkspaces: { workspace: true } },
- order: {
- userWorkspaces: {
- workspace: {
- createdAt: 'ASC',
- },
- },
- },
- });
- expect(result).toEqual(workspace1);
- });
-
- it('should throw an exception if no workspace is found', async () => {
- const userId = 'user-id';
- const user = {
- id: userId,
- workspaces: [],
- } as unknown as UserEntity;
-
- jest.spyOn(userRepository, 'findOne').mockResolvedValue(user);
-
- await expect(service.findFirstWorkspaceByUserId(userId)).rejects.toThrow(
- AuthException,
- );
- });
- });
-
- describe('getUserWorkspaceForUserOrThrow', () => {
- it('should get a user workspace or throw', async () => {
- const userId = 'user-id';
- const workspaceId = 'workspace-id';
- const userWorkspace = {
- userId,
- workspaceId,
- } as unknown as UserWorkspaceEntity;
-
- jest
- .spyOn(userWorkspaceRepository, 'findOne')
- .mockResolvedValue(userWorkspace);
-
- const result = await service.getUserWorkspaceForUserOrThrow({
- userId,
- workspaceId,
- });
-
- expect(userWorkspaceRepository.findOne).toHaveBeenCalledWith({
- where: {
- userId,
- workspaceId,
- },
- relations: ['twoFactorAuthenticationMethods'],
- });
- expect(result).toEqual(userWorkspace);
- });
-
- it('should throw an exception if user workspace is not found', async () => {
- const userId = 'user-id';
- const workspaceId = 'workspace-id';
-
- jest.spyOn(userWorkspaceRepository, 'findOne').mockResolvedValue(null);
-
- await expect(
- service.getUserWorkspaceForUserOrThrow({ userId, workspaceId }),
- ).rejects.toThrow('User workspace not found');
- });
- });
-
- describe('getWorkspaceMemberOrThrow', () => {
- it('should get a workspace member or throw', async () => {
- const workspaceMemberId = 'workspace-member-id';
- const workspaceId = 'workspace-id';
- const workspaceMember = {
- id: workspaceMemberId,
- } as WorkspaceEntity;
- const workspaceMemberRepository = {
- findOne: jest.fn().mockResolvedValue(workspaceMember),
- };
-
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(workspaceMemberRepository as any);
-
- const result = await service.getWorkspaceMemberOrThrow({
- workspaceMemberId,
- workspaceId,
- });
-
- expect(globalWorkspaceOrmManager.getRepository).toHaveBeenCalledWith(
- workspaceId,
- 'workspaceMember',
- {
- shouldBypassPermissionChecks: true,
- },
- );
- expect(workspaceMemberRepository.findOne).toHaveBeenCalledWith({
- where: {
- id: workspaceMemberId,
- },
- });
- expect(result).toEqual(workspaceMember);
- });
-
- it('should throw an exception if workspace member is not found', async () => {
- const workspaceMemberId = 'workspace-member-id';
- const workspaceId = 'workspace-id';
- const workspaceMemberRepository = {
- findOne: jest.fn().mockResolvedValue(null),
- };
-
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(workspaceMemberRepository as any);
-
- await expect(
- service.getWorkspaceMemberOrThrow({ workspaceMemberId, workspaceId }),
- ).rejects.toThrow('Workspace member not found');
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/user/services/__tests__/workspace-member-transpiler.service.spec.ts b/packages/twenty-server/src/engine/core-modules/user/services/__tests__/workspace-member-transpiler.service.spec.ts
deleted file mode 100644
index d32946aa3aa..00000000000
--- a/packages/twenty-server/src/engine/core-modules/user/services/__tests__/workspace-member-transpiler.service.spec.ts
+++ /dev/null
@@ -1,78 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { OpenRecordIn } from 'twenty-shared/types';
-
-import { FileUrlService } from 'src/engine/core-modules/file/file-url/file-url.service';
-import { type UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { WorkspaceMemberTranspiler } from 'src/engine/core-modules/user/services/workspace-member-transpiler.service';
-import { type WorkspaceMemberWorkspaceEntity } from 'src/modules/workspace-member/standard-objects/workspace-member.workspace-entity';
-
-const buildWorkspaceMemberEntity = (
- overrides: Partial<WorkspaceMemberWorkspaceEntity> = {},
-) =>
- ({
- id: '20202020-0687-4c41-b707-ed1bfca972a7',
- name: { firstName: 'Tim', lastName: 'Apple' },
- userEmail: '[email protected]',
- colorScheme: 'System',
- openRecordIn: OpenRecordIn.RECORD_PAGE,
- locale: 'en',
- avatarUrl: null,
- timeFormat: 'SYSTEM',
- timeZone: 'system',
- dateFormat: 'SYSTEM',
- calendarStartDay: 0,
- numberFormat: 'SYSTEM',
- ...overrides,
- }) as unknown as WorkspaceMemberWorkspaceEntity;
-
-const userWorkspace = {
- id: '20202020-9e3b-46d4-a556-88b9ddc2b034',
- workspaceId: '20202020-1c25-4d02-bf25-6aeccf7ea419',
-} as UserWorkspaceEntity;
-
-describe('WorkspaceMemberTranspiler', () => {
- let transpiler: WorkspaceMemberTranspiler;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkspaceMemberTranspiler,
- {
- provide: FileUrlService,
- useValue: { signFileByIdUrl: jest.fn().mockResolvedValue('') },
- },
- ],
- }).compile();
-
- transpiler = module.get<WorkspaceMemberTranspiler>(
- WorkspaceMemberTranspiler,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should preserve openRecordIn when the workspace member has one', async () => {
- const dto = await transpiler.toWorkspaceMemberDto({
- userWorkspace,
- workspaceMemberEntity: buildWorkspaceMemberEntity(),
- userWorkspaceRoles: [],
- });
-
- expect(dto.openRecordIn).toBe(OpenRecordIn.RECORD_PAGE);
- });
-
- it('should fall back to SIDE_PANEL when the workspace has not been upgraded yet', async () => {
- const dto = await transpiler.toWorkspaceMemberDto({
- userWorkspace,
- workspaceMemberEntity: buildWorkspaceMemberEntity({
- openRecordIn: undefined as unknown as string,
- }),
- userWorkspaceRoles: [],
- });
-
- expect(dto.openRecordIn).toBe(OpenRecordIn.SIDE_PANEL);
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/user/services/user.service.spec.ts b/packages/twenty-server/src/engine/core-modules/user/services/user.service.spec.ts
deleted file mode 100644
index fbad08c5c75..00000000000
--- a/packages/twenty-server/src/engine/core-modules/user/services/user.service.spec.ts
+++ /dev/null
@@ -1,487 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { WorkspaceActivationStatus } from 'twenty-shared/workspace';
-import { type Repository, type UpdateResult } from 'typeorm';
-
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
-import { type AuthContextUser } from 'src/engine/core-modules/auth/types/auth-context.type';
-import { WorkspaceDomainsService } from 'src/engine/core-modules/domain/workspace-domains/services/workspace-domains.service';
-import { EmailVerificationService } from 'src/engine/core-modules/email-verification/services/email-verification.service';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';
-import { UserService } from 'src/engine/core-modules/user/services/user.service';
-import { WorkspaceMemberTranspiler } from 'src/engine/core-modules/user/services/workspace-member-transpiler.service';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { WorkspaceService } from 'src/engine/core-modules/workspace/services/workspace.service';
-import { type WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import {
- PermissionsException,
- PermissionsExceptionCode,
-} from 'src/engine/metadata-modules/permissions/permissions.exception';
-import { CoreEntityCacheService } from 'src/engine/core-entity-cache/services/core-entity-cache.service';
-import { ConnectedAccountMetadataService } from 'src/engine/metadata-modules/connected-account/connected-account-metadata.service';
-import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type WorkspaceRepository } from 'src/engine/twenty-orm/repository/workspace.repository';
-import { type WorkspaceMemberWorkspaceEntity } from 'src/modules/workspace-member/standard-objects/workspace-member.workspace-entity';
-
-describe('UserService', () => {
- let service: UserService;
- let userRepository: Repository<UserEntity>;
- let workspaceService: WorkspaceService;
- let globalWorkspaceOrmManager: GlobalWorkspaceOrmManager;
- let userRoleService: UserRoleService;
-
- const mockWorkspaceMemberRepo = {
- findOne: jest.fn(),
- find: jest.fn(),
- delete: jest.fn(),
- } as unknown as WorkspaceRepository<WorkspaceMemberWorkspaceEntity>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- UserService,
- {
- provide: getRepositoryToken(UserEntity),
- useValue: {
- findOne: jest.fn(),
- save: jest.fn(),
- softDelete: jest.fn(),
- update: jest.fn(),
- manager: {
- connection: { driver: { options: { type: 'postgres' } } },
- },
- metadata: { columns: [] },
- },
- },
- {
- provide: WorkspaceService,
- useValue: {
- deleteWorkspace: jest.fn(),
- suspendWorkspace: jest.fn(),
- },
- },
- {
- provide: WorkspaceDomainsService,
- useValue: {
- getSubdomainAndCustomDomainFromWorkspaceFallbackOnDefaultSubdomain:
- jest.fn(),
- },
- },
- {
- provide: EmailVerificationService,
- useValue: { sendVerificationEmail: jest.fn() },
- },
- {
- provide: `MESSAGE_QUEUE_${MessageQueue.workspaceQueue}`,
- useValue: { add: jest.fn() },
- },
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getRepository: jest.fn(),
- executeInWorkspaceContext: jest
- .fn()
-
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- },
- },
- {
- provide: UserRoleService,
- useValue: {
- validateUserWorkspaceIsNotUniqueAdminOrThrow: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: {
- find: jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: ConnectedAccountMetadataService,
- useValue: {
- transferOwnership: jest.fn(),
- },
- },
- {
- provide: UserWorkspaceService,
- useValue: {
- deleteUserWorkspace: jest.fn(),
- },
- },
- {
- provide: ApplicationService,
- useValue: {},
- },
- {
- provide: CoreEntityCacheService,
- useValue: {
- invalidate: jest.fn(),
- },
- },
- {
- provide: WorkspaceMemberTranspiler,
- useValue: {
- generateSignedAvatarUrl: jest.fn().mockReturnValue(''),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn().mockReturnValue(false),
- },
- },
- ],
- }).compile();
-
- service = module.get<UserService>(UserService);
- userRepository = module.get<Repository<UserEntity>>(
- getRepositoryToken(UserEntity),
- );
- userRoleService = module.get<UserRoleService>(UserRoleService);
- globalWorkspaceOrmManager = module.get<GlobalWorkspaceOrmManager>(
- GlobalWorkspaceOrmManager,
- );
- workspaceService = module.get<WorkspaceService>(WorkspaceService);
- });
-
- describe('loadWorkspaceMember', () => {
- it('returns null when workspace is not provisioned', async () => {
- const res = await service.loadWorkspaceMember(
- { id: 'u1' } as Pick<AuthContextUser, 'id'>,
- { id: 'w1' } as WorkspaceEntity,
- );
-
- expect(res).toBeNull();
- expect(globalWorkspaceOrmManager.getRepository).not.toHaveBeenCalled();
- });
-
- it('fetches from workspace member repo when workspace active', async () => {
- jest.spyOn(mockWorkspaceMemberRepo, 'findOne').mockResolvedValue({
- id: 'wm1',
- userId: 'u1',
- } as WorkspaceMemberWorkspaceEntity);
-
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(mockWorkspaceMemberRepo);
-
- const res = await service.loadWorkspaceMember(
- { id: 'u1' } as Pick<AuthContextUser, 'id'>,
- {
- id: 'w1',
- activationStatus: WorkspaceActivationStatus.ACTIVE,
- } as WorkspaceEntity,
- );
-
- expect(globalWorkspaceOrmManager.getRepository).toHaveBeenCalledWith(
- 'w1',
- 'workspaceMember',
- {
- shouldBypassPermissionChecks: true,
- },
- );
- expect(mockWorkspaceMemberRepo.findOne).toHaveBeenCalledWith({
- where: { userId: 'u1' },
- });
- expect(res).toEqual({ id: 'wm1', userId: 'u1' });
- });
-
- it('fetches from workspace member repo when workspace is created', async () => {
- jest.spyOn(mockWorkspaceMemberRepo, 'findOne').mockResolvedValue({
- id: 'wm1',
- userId: 'u1',
- } as WorkspaceMemberWorkspaceEntity);
-
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(mockWorkspaceMemberRepo);
-
- const res = await service.loadWorkspaceMember(
- { id: 'u1' } as Pick<AuthContextUser, 'id'>,
- {
- id: 'w1',
- activationStatus: WorkspaceActivationStatus.CREATED,
- } as WorkspaceEntity,
- );
-
- expect(res).toEqual({ id: 'wm1', userId: 'u1' });
- });
- });
-
- describe('loadWorkspaceMembers', () => {
- it('returns [] when workspace is not provisioned', async () => {
- const res = await service.loadWorkspaceMembers({
- id: 'w1',
- activationStatus: WorkspaceActivationStatus.INACTIVE,
- } as WorkspaceEntity);
-
- expect(res).toEqual([]);
- expect(globalWorkspaceOrmManager.getRepository).not.toHaveBeenCalled();
- });
-
- it('fetches members withDeleted flag', async () => {
- jest
- .spyOn(mockWorkspaceMemberRepo, 'find')
- .mockResolvedValue([{ id: 'wm1' } as WorkspaceMemberWorkspaceEntity]);
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(mockWorkspaceMemberRepo);
-
- const res = await service.loadWorkspaceMembers(
- {
- id: 'w2',
- activationStatus: WorkspaceActivationStatus.ACTIVE,
- } as WorkspaceEntity,
- true,
- );
-
- expect(mockWorkspaceMemberRepo.find).toHaveBeenCalledWith({
- withDeleted: true,
- });
- expect(res).toEqual([{ id: 'wm1' }]);
- });
- });
-
- describe('loadDeletedWorkspaceMembersOnly', () => {
- it('returns [] when workspace is not provisioned', async () => {
- const res = await service.loadDeletedWorkspaceMembersOnly({
- id: 'w1',
- activationStatus: WorkspaceActivationStatus.INACTIVE,
- } as WorkspaceEntity);
-
- expect(res).toEqual([]);
- });
-
- it('fetches only deleted members with withDeleted:true', async () => {
- jest
- .spyOn(mockWorkspaceMemberRepo, 'find')
- .mockResolvedValue([
- { id: 'wm-del' } as WorkspaceMemberWorkspaceEntity,
- ]);
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(mockWorkspaceMemberRepo);
-
- await service.loadDeletedWorkspaceMembersOnly({
- id: 'w3',
- activationStatus: WorkspaceActivationStatus.ACTIVE,
- } as WorkspaceEntity);
-
- expect(mockWorkspaceMemberRepo.find).toHaveBeenCalledWith({
- where: { deletedAt: expect.any(Object) },
- withDeleted: true,
- });
- });
- });
-
- describe('findUserByEmailOrThrow', () => {
- it('returns user when found', async () => {
- const user = { id: 'u1', email: '[email protected]' } as UserEntity;
-
- (userRepository.findOne as jest.Mock).mockResolvedValue(user);
-
- await expect(service.findUserByEmailOrThrow('[email protected]')).resolves.toEqual(
- user,
- );
- });
-
- it('throws when not found', async () => {
- (userRepository.findOne as jest.Mock).mockResolvedValue(null);
- await expect(
- service.findUserByEmailOrThrow('[email protected]'),
- ).rejects.toBeTruthy();
- });
- });
-
- describe('findUserByEmail', () => {
- it('returns the user when found', async () => {
- const user: Partial<UserEntity> = { id: 'u1', email: '[email protected]' };
-
- (userRepository.findOne as jest.Mock).mockResolvedValue(user);
-
- const result = await service.findUserByEmail('[email protected]');
-
- expect(userRepository.findOne).toHaveBeenCalledWith({
- where: { email: '[email protected]' },
- });
- expect(result).toEqual(user);
- });
-
- it('returns null when not found', async () => {
- (userRepository.findOne as jest.Mock).mockResolvedValue(null);
- const result = await service.findUserByEmail('[email protected]');
-
- expect(result).toBeNull();
- });
- });
-
- describe('hasUserAccessToWorkspaceOrThrow', () => {
- it('resolves when user has access', async () => {
- (userRepository.findOne as jest.Mock).mockResolvedValue({ id: 'u1' });
- await expect(
- service.hasUserAccessToWorkspaceOrThrow('u1', 'w1'),
- ).resolves.toBeUndefined();
- expect(userRepository.findOne).toHaveBeenCalledWith({
- where: { id: 'u1', userWorkspaces: { workspaceId: 'w1' } },
- relations: { userWorkspaces: true },
- });
- });
-
- it('throws AuthException when user has no access', async () => {
- (userRepository.findOne as jest.Mock).mockResolvedValue(null);
- await expect(
- service.hasUserAccessToWorkspaceOrThrow('u2', 'w2'),
- ).rejects.toBeInstanceOf(AuthException);
- });
- });
-
- describe('markEmailAsVerified', () => {
- it('sets isEmailVerified and saves', async () => {
- const user = { id: 'u1', isEmailVerified: false } as UserEntity;
-
- (userRepository.findOne as jest.Mock).mockResolvedValue(user);
- (userRepository.save as jest.Mock).mockImplementation(
- async (u: UserEntity) => u,
- );
-
- const res = await service.markEmailAsVerified('u1');
-
- expect(userRepository.findOne).toHaveBeenCalledWith({
- where: { id: 'u1' },
- });
- expect(res.isEmailVerified).toBe(true);
- expect(userRepository.save).toHaveBeenCalledWith({
- id: 'u1',
- isEmailVerified: true,
- });
- });
-
- it('throws when user not found', async () => {
- (userRepository.findOne as jest.Mock).mockResolvedValue(null);
- await expect(service.markEmailAsVerified('nope')).rejects.toBeTruthy();
- });
- });
-
- describe('deleteUser', () => {
- const wmForUser = (userId: string) =>
- ({ id: 'wm-1', userId }) as WorkspaceMemberWorkspaceEntity;
-
- it('throws mapped PermissionsException when cannot unassign last admin', async () => {
- (userRepository.findOne as jest.Mock).mockResolvedValue({
- id: 'u1',
- userWorkspaces: [{ id: 'uw1', workspaceId: 'w1' }],
- });
-
- jest
- .spyOn(mockWorkspaceMemberRepo, 'find')
- .mockResolvedValue([
- wmForUser('u1'),
- { id: 'wm-2', userId: 'uX' } as WorkspaceMemberWorkspaceEntity,
- ]);
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(mockWorkspaceMemberRepo);
-
- jest
- .spyOn(userRoleService, 'validateUserWorkspaceIsNotUniqueAdminOrThrow')
- .mockRejectedValue(
- new PermissionsException(
- 'x',
- PermissionsExceptionCode.CANNOT_UNASSIGN_LAST_ADMIN,
- ),
- );
-
- await expect(service.deleteUser('u1')).rejects.toBeInstanceOf(
- PermissionsException,
- );
- await expect(service.deleteUser('u1')).rejects.toMatchObject({
- code: PermissionsExceptionCode.CANNOT_DELETE_LAST_ADMIN_USER,
- });
- });
-
- it('deletes workspace member and workspace when user is sole member', async () => {
- const mockedUserWorkspace = {
- id: 'uw2',
- workspaceId: 'w2',
- } as UserWorkspaceEntity;
-
- (userRepository.findOne as jest.Mock).mockResolvedValue({
- id: 'u2',
- userWorkspaces: [mockedUserWorkspace],
- });
-
- jest
- .spyOn(mockWorkspaceMemberRepo, 'find')
- .mockResolvedValue([wmForUser('u2')]);
- jest
- .spyOn(globalWorkspaceOrmManager, 'getRepository')
- .mockResolvedValue(mockWorkspaceMemberRepo);
-
- (userRepository.softDelete as jest.Mock).mockResolvedValue({
- affected: 1,
- raw: [],
- generatedMaps: [],
- } as UpdateResult);
-
- const res = await service.deleteUser('u2');
-
- expect(workspaceService.suspendWorkspace).toHaveBeenCalledWith('w2');
- expect(workspaceService.deleteWorkspace).toHaveBeenCalledWith('w2', true);
- expect(res).toMatchObject({ id: 'u2' });
- });
-
- it('throws when user not found', async () => {
- (userRepository.findOne as jest.Mock).mockResolvedValue(null);
- await expect(service.deleteUser('missing')).rejects.toBeTruthy();
- });
- });
-
- describe('findUserById', () => {
- it('returns the user when found', async () => {
- const user = { id: 'u42' } as UserEntity;
-
- (userRepository.findOne as jest.Mock).mockResolvedValue(user);
-
- const result = await service.findUserById('u42');
-
- expect(userRepository.findOne).toHaveBeenCalledWith({
- where: { id: 'u42' },
- });
- expect(result).toEqual(user);
- });
-
- it('returns null when not found', async () => {
- (userRepository.findOne as jest.Mock).mockResolvedValue(null);
-
- const result = await service.findUserById('missing');
-
- expect(result).toBeNull();
- });
- });
-
- describe('findUserByIdOrThrow', () => {
- it('returns user when found', async () => {
- const user = { id: 'u99' } as UserEntity;
-
- (userRepository.findOne as jest.Mock).mockResolvedValue(user);
-
- await expect(service.findUserByIdOrThrow('u99')).resolves.toEqual(user);
- });
-
- it('throws provided error when not found', async () => {
- (userRepository.findOne as jest.Mock).mockResolvedValue(null);
- const error = new Error('not found');
-
- await expect(service.findUserByIdOrThrow('nope', error)).rejects.toThrow(
- error,
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/services/__tests__/workflow-core-sync.service.spec.ts b/packages/twenty-server/src/engine/core-modules/workflow/services/__tests__/workflow-core-sync.service.spec.ts
deleted file mode 100644
index ddaf0796686..00000000000
--- a/packages/twenty-server/src/engine/core-modules/workflow/services/__tests__/workflow-core-sync.service.spec.ts
+++ /dev/null
@@ -1,117 +0,0 @@
-import { STANDARD_OBJECTS } from 'twenty-shared/metadata';
-import { type Repository } from 'typeorm';
-
-import { type GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type WorkspaceScopedRepository } from 'src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository';
-import { type WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { WorkflowCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-core-sync.service';
-import { type WorkflowEntity } from 'src/engine/core-modules/workflow/entities/workflow.entity';
-import { type WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { type WorkflowWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
-
-const CORE_WORKFLOW_ID_FIELD =
- STANDARD_OBJECTS.workflow.fields.coreWorkflowId.universalIdentifier;
-
-describe('WorkflowCoreSyncService', () => {
- const workspaceId = '20202020-1c25-4d02-bf25-6aeccf7ea419';
-
- let service: WorkflowCoreSyncService;
- let workflowRepository: { upsert: jest.Mock; delete: jest.Mock };
- let workspaceRepository: { findOne: jest.Mock };
- let globalWorkspaceOrmManager: { executeInWorkspaceContext: jest.Mock };
- let workspaceCacheService: { getOrRecompute: jest.Mock };
-
- const buildWorkflow = (
- overrides: Partial<WorkflowWorkspaceEntity> = {},
- ): WorkflowWorkspaceEntity =>
- ({
- id: '1dddc806-4144-5020-898f-b1ab287b89d5',
- name: 'My workflow',
- // Event payloads represent unset uuids as empty strings, not null.
- lastPublishedVersionId: '',
- coreWorkflowId: '',
- ...overrides,
- }) as unknown as WorkflowWorkspaceEntity;
-
- const mockFieldPresence = (present: boolean) =>
- workspaceCacheService.getOrRecompute.mockResolvedValue({
- flatFieldMetadataMaps: {
- byUniversalIdentifier: present ? { [CORE_WORKFLOW_ID_FIELD]: {} } : {},
- },
- });
-
- const upsertedRows = (): Array<{
- id: string;
- lastPublishedVersionId: string | null;
- }> => workflowRepository.upsert.mock.calls[0][1];
-
- beforeEach(() => {
- workflowRepository = { upsert: jest.fn(), delete: jest.fn() };
- workspaceRepository = {
- findOne: jest.fn().mockResolvedValue({
- id: workspaceId,
- workspaceCustomApplicationId: 'application-1',
- }),
- };
- globalWorkspaceOrmManager = {
- executeInWorkspaceContext: jest.fn().mockResolvedValue(undefined),
- };
- workspaceCacheService = { getOrRecompute: jest.fn() };
-
- service = new WorkflowCoreSyncService(
- workflowRepository as unknown as WorkspaceScopedRepository<WorkflowEntity>,
- workspaceRepository as unknown as Repository<WorkspaceEntity>,
- globalWorkspaceOrmManager as unknown as GlobalWorkspaceOrmManager,
- workspaceCacheService as unknown as WorkspaceCacheService,
- );
-
- jest.spyOn(service['logger'], 'warn').mockImplementation();
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('skips the core id write-back when the workspace lacks the coreWorkflowId field', async () => {
- mockFieldPresence(false);
-
- await expect(
- service.upsertToCore(workspaceId, [buildWorkflow()]),
- ).resolves.toBeUndefined();
-
- expect(workflowRepository.upsert).toHaveBeenCalledTimes(1);
- expect(
- globalWorkspaceOrmManager.executeInWorkspaceContext,
- ).not.toHaveBeenCalled();
- });
-
- it('generates an id, normalizes empty-string uuids and writes back for an unlinked workflow', async () => {
- mockFieldPresence(true);
-
- await service.upsertToCore(workspaceId, [buildWorkflow()]);
-
- expect(upsertedRows()[0].id).not.toBe('');
- expect(upsertedRows()[0].id.length).toBeGreaterThan(0);
- // lastPublishedVersionId ('') must be normalized to null for the uuid column.
- expect(upsertedRows()[0].lastPublishedVersionId).toBeNull();
- expect(
- globalWorkspaceOrmManager.executeInWorkspaceContext,
- ).toHaveBeenCalledTimes(1);
- });
-
- it('reuses the existing id and does not write back for a linked workflow', async () => {
- mockFieldPresence(true);
- const coreWorkflowId = 'e2b1c0d4-0000-4000-8000-000000000000';
-
- await service.upsertToCore(workspaceId, [
- buildWorkflow({
- coreWorkflowId,
- } as Partial<WorkflowWorkspaceEntity>),
- ]);
-
- expect(upsertedRows()[0].id).toBe(coreWorkflowId);
- expect(
- globalWorkspaceOrmManager.executeInWorkspaceContext,
- ).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/workflow/services/__tests__/workflow-version-core-sync.service.spec.ts b/packages/twenty-server/src/engine/core-modules/workflow/services/__tests__/workflow-version-core-sync.service.spec.ts
deleted file mode 100644
index 742c7412063..00000000000
--- a/packages/twenty-server/src/engine/core-modules/workflow/services/__tests__/workflow-version-core-sync.service.spec.ts
+++ /dev/null
@@ -1,123 +0,0 @@
-import { STANDARD_OBJECTS } from 'twenty-shared/metadata';
-import { type Repository } from 'typeorm';
-
-import { type GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type WorkspaceScopedRepository } from 'src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository';
-import { type WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { WorkflowVersionCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-version-core-sync.service';
-import { type WorkflowVersionEntity } from 'src/engine/core-modules/workflow/entities/workflow-version.entity';
-import { type WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
-
-const CORE_VERSION_ID_FIELD =
- STANDARD_OBJECTS.workflowVersion.fields.coreWorkflowVersionId
- .universalIdentifier;
-
-describe('WorkflowVersionCoreSyncService', () => {
- const workspaceId = '20202020-1c25-4d02-bf25-6aeccf7ea419';
-
- let service: WorkflowVersionCoreSyncService;
- let workflowVersionRepository: { upsert: jest.Mock; delete: jest.Mock };
- let workspaceRepository: { findOne: jest.Mock };
- let globalWorkspaceOrmManager: { executeInWorkspaceContext: jest.Mock };
- let workspaceCacheService: {
- getOrRecompute: jest.Mock;
- invalidateAndRecompute: jest.Mock;
- };
-
- const buildVersion = (
- overrides: Partial<WorkflowVersionWorkspaceEntity> = {},
- ): WorkflowVersionWorkspaceEntity =>
- ({
- id: '1dddc806-4144-5020-898f-b1ab287b89d5',
- workflowId: 'c95c78b4-48d2-56f6-8e15-36ff8572f1d8',
- status: 'DRAFT',
- trigger: null,
- steps: null,
- // Event payloads represent unset uuids as empty strings, not null.
- coreWorkflowVersionId: '',
- ...overrides,
- }) as unknown as WorkflowVersionWorkspaceEntity;
-
- const mockFieldPresence = (present: boolean) =>
- workspaceCacheService.getOrRecompute.mockResolvedValue({
- flatFieldMetadataMaps: {
- byUniversalIdentifier: present ? { [CORE_VERSION_ID_FIELD]: {} } : {},
- },
- });
-
- const upsertedRows = (): Array<{ id: string }> =>
- workflowVersionRepository.upsert.mock.calls[0][1];
-
- beforeEach(() => {
- workflowVersionRepository = { upsert: jest.fn(), delete: jest.fn() };
- workspaceRepository = {
- findOne: jest.fn().mockResolvedValue({
- id: workspaceId,
- workspaceCustomApplicationId: 'application-1',
- }),
- };
- globalWorkspaceOrmManager = {
- executeInWorkspaceContext: jest.fn().mockResolvedValue(undefined),
- };
- workspaceCacheService = {
- getOrRecompute: jest.fn(),
- invalidateAndRecompute: jest.fn().mockResolvedValue(undefined),
- };
-
- service = new WorkflowVersionCoreSyncService(
- workflowVersionRepository as unknown as WorkspaceScopedRepository<WorkflowVersionEntity>,
- workspaceRepository as unknown as Repository<WorkspaceEntity>,
- globalWorkspaceOrmManager as unknown as GlobalWorkspaceOrmManager,
- workspaceCacheService as unknown as WorkspaceCacheService,
- );
-
- jest.spyOn(service['logger'], 'warn').mockImplementation();
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('skips the core id write-back when the workspace lacks the coreWorkflowVersionId field', async () => {
- mockFieldPresence(false);
-
- await expect(
- service.upsertToCore(workspaceId, [buildVersion()]),
- ).resolves.toBeUndefined();
-
- expect(workflowVersionRepository.upsert).toHaveBeenCalledTimes(1);
- expect(
- globalWorkspaceOrmManager.executeInWorkspaceContext,
- ).not.toHaveBeenCalled();
- });
-
- it('generates an id and writes it back for an unlinked version (empty-string id)', async () => {
- mockFieldPresence(true);
-
- await service.upsertToCore(workspaceId, [buildVersion()]);
-
- // Empty-string coreWorkflowVersionId is treated as unlinked, not passed through.
- expect(upsertedRows()[0].id).not.toBe('');
- expect(upsertedRows()[0].id.length).toBeGreaterThan(0);
- expect(
- globalWorkspaceOrmManager.executeInWorkspaceContext,
- ).toHaveBeenCalledTimes(1);
- });
-
- it('reuses the existing id and does not write back for a linked version', async () => {
- mockFieldPresence(true);
- const coreWorkflowVersionId = 'e2b1c0d4-0000-4000-8000-000000000000';
-
- await service.upsertToCore(workspaceId, [
- buildVersion({
- coreWorkflowVersionId,
- } as Partial<WorkflowVersionWorkspaceEntity>),
- ]);
-
- expect(upsertedRows()[0].id).toBe(coreWorkflowVersionId);
- expect(
- globalWorkspaceOrmManager.executeInWorkspaceContext,
- ).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/workspace-invitation/services/workspace-invitation.service.spec.ts b/packages/twenty-server/src/engine/core-modules/workspace-invitation/services/workspace-invitation.service.spec.ts
deleted file mode 100644
index 28b514061b9..00000000000
--- a/packages/twenty-server/src/engine/core-modules/workspace-invitation/services/workspace-invitation.service.spec.ts
+++ /dev/null
@@ -1,469 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { type DeleteResult, Repository } from 'typeorm';
-
-import {
- AppTokenEntity,
- AppTokenType,
-} from 'src/engine/core-modules/app-token/app-token.entity';
-import { WorkspaceDomainsService } from 'src/engine/core-modules/domain/workspace-domains/services/workspace-domains.service';
-import { EmailService } from 'src/engine/core-modules/email/email.service';
-import { I18nService } from 'src/engine/core-modules/i18n/i18n.service';
-import { OnboardingService } from 'src/engine/core-modules/onboarding/onboarding.service';
-import { ThrottlerService } from 'src/engine/core-modules/throttler/throttler.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import {
- WorkspaceInvitationException,
- WorkspaceInvitationExceptionCode,
-} from 'src/engine/core-modules/workspace-invitation/workspace-invitation.exception';
-import { WorkspaceService } from 'src/engine/core-modules/workspace/services/workspace.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { RoleValidationService } from 'src/engine/metadata-modules/role-validation/services/role-validation.service';
-import { type WorkspaceMemberWorkspaceEntity } from 'src/modules/workspace-member/standard-objects/workspace-member.workspace-entity';
-
-import { FileUrlService } from 'src/engine/core-modules/file/file-url/file-url.service';
-import { WorkspaceInvitationService } from './workspace-invitation.service';
-
-// To fix a circular dependency issue
-jest.mock('src/engine/core-modules/workspace/services/workspace.service');
-
-// render() resolves through a streaming scheduler that never advances under the
-// globally enabled fake timers; the real render path is covered by
-// email-templates-rendering.spec.ts.
-jest.mock('twenty-emails', () => ({
- ...jest.requireActual('twenty-emails'),
- renderEmail: jest.fn().mockImplementation(async (_template, options) => {
- if (options?.plainText) {
- return 'Plain Text Email';
- }
-
- return '<html><body>HTML email content</body></html>';
- }),
-}));
-
-describe('WorkspaceInvitationService', () => {
- let service: WorkspaceInvitationService;
- let appTokenRepository: Repository<AppTokenEntity>;
- let userWorkspaceRepository: Repository<UserWorkspaceEntity>;
- let twentyConfigService: TwentyConfigService;
- let emailService: EmailService;
- let onboardingService: OnboardingService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkspaceInvitationService,
- {
- provide: getRepositoryToken(AppTokenEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useClass: Repository,
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useClass: Repository,
- },
- {
- provide: RoleValidationService,
- useValue: {
- validateRoleAssignableToUsersOrThrow: jest.fn(),
- },
- },
- {
- provide: WorkspaceDomainsService,
- useValue: {
- buildWorkspaceURL: jest
- .fn()
- .mockResolvedValue(new URL('http://localhost:3001')),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn(),
- },
- },
- {
- provide: EmailService,
- useValue: {
- send: jest.fn(),
- },
- },
- {
- provide: OnboardingService,
- useValue: {
- completeOnboardingInviteTeamStep: jest.fn(),
- isOnboardingInviteTeamPending: jest.fn().mockResolvedValue(false),
- },
- },
- {
- provide: WorkspaceService,
- useValue: {
- // Mock methods you expect WorkspaceInvitationService to call
- getDefaultWorkspace: jest
- .fn()
- .mockResolvedValue({ id: 'default-workspace-id' }),
- // Add other methods as needed
- },
- },
- {
- provide: I18nService,
- useValue: {
- getI18nInstance: jest.fn().mockReturnValue({
- _: jest.fn().mockReturnValue('mocked-translation'),
- }),
- },
- },
- {
- provide: FileUrlService,
- useValue: {
- signFileByIdUrl: jest
- .fn()
- .mockReturnValue('https://signed-url.com/logo.png'),
- },
- },
- {
- provide: ThrottlerService,
- useValue: {
- tokenBucketThrottleOrThrow: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<WorkspaceInvitationService>(
- WorkspaceInvitationService,
- );
- appTokenRepository = module.get<Repository<AppTokenEntity>>(
- getRepositoryToken(AppTokenEntity),
- );
- userWorkspaceRepository = module.get<Repository<UserWorkspaceEntity>>(
- getRepositoryToken(UserWorkspaceEntity),
- );
- twentyConfigService = module.get<TwentyConfigService>(TwentyConfigService);
- emailService = module.get<EmailService>(EmailService);
- onboardingService = module.get<OnboardingService>(OnboardingService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('createWorkspaceInvitation', () => {
- it('should create a workspace invitation successfully', async () => {
- const email = '[email protected]';
- const workspace = { id: 'workspace-id' } as WorkspaceEntity;
-
- jest.spyOn(appTokenRepository, 'findOne').mockResolvedValue(null);
- jest
- .spyOn(appTokenRepository, 'delete')
- .mockResolvedValue({} as DeleteResult);
-
- jest.spyOn(userWorkspaceRepository, 'exists').mockResolvedValue(false);
- jest
- .spyOn(service, 'generateInvitationToken')
- .mockResolvedValue({} as AppTokenEntity);
-
- await expect(
- service.createWorkspaceInvitation(email, workspace),
- ).resolves.not.toThrow();
- });
-
- it('should throw an exception if invitation already exists', async () => {
- const email = '[email protected]';
- const workspace = { id: 'workspace-id' } as WorkspaceEntity;
-
- jest
- .spyOn(appTokenRepository, 'findOne')
- .mockResolvedValue({} as AppTokenEntity);
-
- await expect(
- service.createWorkspaceInvitation(email, workspace),
- ).rejects.toThrow(WorkspaceInvitationException);
- });
- });
-
- describe('sendInvitations', () => {
- it('should send invitations successfully', async () => {
- const emails = ['[email protected]', '[email protected]'];
- const workspace = {
- id: 'workspace-id',
- inviteHash: 'invite-hash',
- displayName: 'Test Workspace',
- } as WorkspaceEntity;
- const sender = {
- userId: 'sender-user-id',
- userEmail: '[email protected]',
- name: { firstName: 'Sender' },
- locale: 'en',
- };
-
- jest.spyOn(service, 'createWorkspaceInvitation').mockResolvedValue({
- context: { email: '[email protected]' },
- value: 'token-value',
- type: AppTokenType.InvitationToken,
- } as AppTokenEntity);
- jest
- .spyOn(twentyConfigService, 'get')
- .mockReturnValue('http://localhost:3000');
- jest.spyOn(emailService, 'send').mockResolvedValue({} as any);
- jest
- .spyOn(onboardingService, 'completeOnboardingInviteTeamStep')
- .mockResolvedValue({} as any);
-
- const result = await service.sendInvitations(
- emails,
- workspace,
- sender as WorkspaceMemberWorkspaceEntity,
- );
-
- expect(result.success).toBe(true);
- expect(result.result.length).toBe(2);
- expect(emailService.send).toHaveBeenCalledTimes(2);
- expect(
- onboardingService.completeOnboardingInviteTeamStep,
- ).toHaveBeenCalledWith({
- userId: sender.userId,
- workspaceId: workspace.id,
- hasSentInvitations: true,
- });
- });
-
- it('should keep the invite-team step reversible when every invitation fails', async () => {
- const emails = ['[email protected]', '[email protected]'];
- const workspace = {
- id: 'workspace-id',
- inviteHash: 'invite-hash',
- displayName: 'Test Workspace',
- } as WorkspaceEntity;
- const sender = {
- userId: 'sender-user-id',
- userEmail: '[email protected]',
- name: { firstName: 'Sender' },
- locale: 'en',
- };
-
- jest
- .spyOn(service, 'createWorkspaceInvitation')
- .mockRejectedValue(
- new WorkspaceInvitationException(
- 'Invitation already exists',
- WorkspaceInvitationExceptionCode.INVITATION_ALREADY_EXIST,
- ),
- );
- jest
- .spyOn(twentyConfigService, 'get')
- .mockReturnValue('http://localhost:3000');
- jest.spyOn(emailService, 'send').mockResolvedValue({} as any);
- jest
- .spyOn(onboardingService, 'completeOnboardingInviteTeamStep')
- .mockResolvedValue({} as any);
-
- const result = await service.sendInvitations(
- emails,
- workspace,
- sender as WorkspaceMemberWorkspaceEntity,
- );
-
- expect(result.success).toBe(false);
- expect(result.result.length).toBe(0);
- expect(emailService.send).not.toHaveBeenCalled();
- expect(
- onboardingService.completeOnboardingInviteTeamStep,
- ).toHaveBeenCalledWith({
- userId: sender.userId,
- workspaceId: workspace.id,
- hasSentInvitations: false,
- });
- });
-
- it('should mint reward-eligible tokens when the invite-team step is pending', async () => {
- const workspace = {
- id: 'workspace-id',
- inviteHash: 'invite-hash',
- displayName: 'Test Workspace',
- } as WorkspaceEntity;
- const sender = {
- userId: 'sender-user-id',
- userEmail: '[email protected]',
- name: { firstName: 'Sender' },
- locale: 'en',
- };
-
- const createWorkspaceInvitationSpy = jest
- .spyOn(service, 'createWorkspaceInvitation')
- .mockResolvedValue({
- context: { email: '[email protected]' },
- value: 'token-value',
- type: AppTokenType.OnboardingInvitationToken,
- } as AppTokenEntity);
- jest
- .spyOn(onboardingService, 'isOnboardingInviteTeamPending')
- .mockResolvedValue(true);
- jest.spyOn(twentyConfigService, 'get').mockImplementation((key: any) => {
- if (key === 'IS_BILLING_ENABLED') return true;
- if (key === 'ONBOARDING_INVITE_TEAM_MAX_INVITES') return 10;
-
- return 'http://localhost:3000';
- });
- jest.spyOn(appTokenRepository, 'count').mockResolvedValue(0);
- jest.spyOn(emailService, 'send').mockResolvedValue({} as any);
-
- await service.sendInvitations(
- workspace,
- sender as WorkspaceMemberWorkspaceEntity,
- );
-
- expect(createWorkspaceInvitationSpy).toHaveBeenCalledWith(
- workspace,
- undefined,
- true,
- );
- });
-
- it('should downgrade to a regular invitation when the invite-team step is not pending', async () => {
- const workspace = {
- id: 'workspace-id',
- inviteHash: 'invite-hash',
- displayName: 'Test Workspace',
- } as WorkspaceEntity;
- const sender = {
- userId: 'sender-user-id',
- userEmail: '[email protected]',
- name: { firstName: 'Sender' },
- locale: 'en',
- };
-
- const createWorkspaceInvitationSpy = jest
- .spyOn(service, 'createWorkspaceInvitation')
- .mockResolvedValue({
- context: { email: '[email protected]' },
- value: 'token-value',
- type: AppTokenType.InvitationToken,
- } as AppTokenEntity);
- jest
- .spyOn(onboardingService, 'isOnboardingInviteTeamPending')
- .mockResolvedValue(false);
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: any) =>
- key === 'IS_BILLING_ENABLED' ? true : 'http://localhost:3000',
- );
- jest.spyOn(emailService, 'send').mockResolvedValue({} as any);
-
- await service.sendInvitations(
- workspace,
- sender as WorkspaceMemberWorkspaceEntity,
- );
-
- expect(createWorkspaceInvitationSpy).toHaveBeenCalledWith(
- workspace,
- undefined,
- false,
- );
- expect(
- onboardingService.isOnboardingInviteTeamPending,
- ).toHaveBeenCalledWith({
- userId: sender.userId,
- workspaceId: workspace.id,
- });
- });
-
- it('should downgrade to a regular invitation when billing is disabled', async () => {
- const workspace = {
- id: 'workspace-id',
- inviteHash: 'invite-hash',
- displayName: 'Test Workspace',
- } as WorkspaceEntity;
- const sender = {
- userEmail: '[email protected]',
- name: { firstName: 'Sender' },
- locale: 'en',
- };
-
- const createWorkspaceInvitationSpy = jest
- .spyOn(service, 'createWorkspaceInvitation')
- .mockResolvedValue({
- context: { email: '[email protected]' },
- value: 'token-value',
- type: AppTokenType.InvitationToken,
- } as AppTokenEntity);
- jest
- .spyOn(onboardingService, 'isOnboardingInviteTeamPending')
- .mockResolvedValue(true);
- jest
- .spyOn(twentyConfigService, 'get')
- .mockImplementation((key: any) =>
- key === 'IS_BILLING_ENABLED' ? false : 'http://localhost:3000',
- );
- const countSpy = jest.spyOn(appTokenRepository, 'count');
-
- jest.spyOn(emailService, 'send').mockResolvedValue({} as any);
-
- await service.sendInvitations(
- workspace,
- sender as WorkspaceMemberWorkspaceEntity,
- );
-
- expect(createWorkspaceInvitationSpy).toHaveBeenCalledWith(
- workspace,
- undefined,
- false,
- );
- expect(countSpy).not.toHaveBeenCalled();
- });
- });
-
- describe('resendWorkspaceInvitation', () => {
- it('should preserve onboarding eligibility when resending an onboarding invitation', async () => {
- const workspace = {
- id: 'workspace-id',
- inviteHash: 'invite-hash',
- displayName: 'Test Workspace',
- } as WorkspaceEntity;
- const sender = {
- userId: 'sender-user-id',
- userEmail: '[email protected]',
- name: { firstName: 'Sender' },
- locale: 'en',
- };
-
- jest.spyOn(appTokenRepository, 'findOne').mockResolvedValue({
- id: 'app-token-id',
- type: AppTokenType.OnboardingInvitationToken,
- context: { email: '[email protected]' },
- } as AppTokenEntity);
- jest.spyOn(appTokenRepository, 'delete').mockResolvedValue({} as any);
- const sendInvitationsSpy = jest
- .spyOn(service, 'sendInvitations')
- .mockResolvedValue({ success: true, errors: [], result: [] });
-
- await service.resendWorkspaceInvitation(
- 'app-token-id',
- workspace,
- sender as WorkspaceMemberWorkspaceEntity,
- );
-
- expect(sendInvitationsSpy).toHaveBeenCalledWith(
- workspace,
- sender,
- undefined,
- true,
- );
- expect(
- onboardingService.isOnboardingInviteTeamPending,
- ).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/core-modules/workspace/services/__tests__/workspace.service.spec.ts b/packages/twenty-server/src/engine/core-modules/workspace/services/__tests__/workspace.service.spec.ts
deleted file mode 100644
index 8d2636c3bd2..00000000000
--- a/packages/twenty-server/src/engine/core-modules/workspace/services/__tests__/workspace.service.spec.ts
+++ /dev/null
@@ -1,441 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getDataSourceToken, getRepositoryToken } from '@nestjs/typeorm';
-
-import { WorkspaceActivationStatus } from 'twenty-shared/workspace';
-import { IsNull, Not, type QueryRunner, type Repository } from 'typeorm';
-
-import { BillingSubscriptionService } from 'src/engine/core-modules/billing/services/billing-subscription.service';
-import { BillingService } from 'src/engine/core-modules/billing/services/billing.service';
-import { DnsManagerService } from 'src/engine/core-modules/dns-manager/services/dns-manager.service';
-import { CustomDomainManagerService } from 'src/engine/core-modules/domain/custom-domain-manager/services/custom-domain-manager.service';
-import { SubdomainManagerService } from 'src/engine/core-modules/domain/subdomain-manager/services/subdomain-manager.service';
-import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
-import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
-import { FileCorePictureService } from 'src/engine/core-modules/file/file-core-picture/services/file-core-picture.service';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { type MessageQueueService } from 'src/engine/core-modules/message-queue/services/message-queue.service';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';
-import { UserEntity } from 'src/engine/core-modules/user/user.entity';
-import { WorkspaceService } from 'src/engine/core-modules/workspace/services/workspace.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { createEmptyAllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-all-flat-entity-maps.constant';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { UpgradeMigrationService } from 'src/engine/core-modules/upgrade/services/upgrade-migration.service';
-import { UpgradeSequenceReaderService } from 'src/engine/core-modules/upgrade/services/upgrade-sequence-reader.service';
-import { AiModelRegistryService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
-import { PermissionsService } from 'src/engine/metadata-modules/permissions/permissions.service';
-import { CoreEntityCacheService } from 'src/engine/core-entity-cache/services/core-entity-cache.service';
-import { WorkspaceCacheStorageService } from 'src/engine/workspace-cache-storage/workspace-cache-storage.service';
-import { WorkspaceDataSourceService } from 'src/engine/workspace-datasource/workspace-datasource.service';
-import { PrefillLogicFunctionService } from 'src/engine/workspace-manager/standard-objects-prefill-data/services/prefill-logic-function.service';
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { PreInstalledAppsService } from 'src/engine/core-modules/application/pre-installed-apps/pre-installed-apps.service';
-import { SdkClientGenerationService } from 'src/engine/core-modules/sdk-client/sdk-client-generation.service';
-import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';
-import { WorkspaceManagerService } from 'src/engine/workspace-manager/workspace-manager.service';
-
-describe('WorkspaceService', () => {
- let service: WorkspaceService;
- let userWorkspaceRepository: Repository<UserWorkspaceEntity>;
- let userRepository: Repository<UserEntity>;
- let workspaceRepository: Repository<WorkspaceEntity>;
- let workspaceCacheStorageService: WorkspaceCacheStorageService;
- let messageQueueService: MessageQueueService;
- let dnsManagerService: DnsManagerService;
- let billingSubscriptionService: BillingSubscriptionService;
- let userWorkspaceService: UserWorkspaceService;
- let flatEntityMapsCacheService: WorkspaceManyOrAllFlatEntityMapsCacheService;
- let queryRunner: QueryRunner;
-
- beforeEach(async () => {
- queryRunner = {
- connect: jest.fn(),
- startTransaction: jest.fn(),
- commitTransaction: jest.fn(),
- rollbackTransaction: jest.fn(),
- release: jest.fn(),
- manager: {
- delete: jest.fn().mockResolvedValue({ affected: 0 }),
- },
- } as unknown as QueryRunner;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkspaceService,
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {
- findOne: jest.fn(),
- softDelete: jest.fn(),
- delete: jest.fn(),
- update: jest.fn(),
- manager: {
- connection: { driver: { options: { type: 'postgres' } } },
- },
- metadata: { columns: [] },
- },
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: {
- find: jest.fn(),
- softDelete: jest.fn(),
- delete: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(UserEntity),
- useValue: {
- softDelete: jest.fn(),
- },
- },
- {
- provide: BillingService,
- useValue: {
- isBillingEnabled: jest.fn().mockReturnValue(true),
- },
- },
- {
- provide: BillingSubscriptionService,
- useValue: {
- cancelSubscription: jest.fn(),
- assertSubscriptionCanceledOrNone: jest.fn(),
- },
- },
- ...[
- WorkspaceManagerService,
- DnsManagerService,
- CustomDomainManagerService,
- SubdomainManagerService,
- TwentyConfigService,
- ExceptionHandlerService,
- PermissionsService,
- FeatureFlagService,
- FileCorePictureService,
- AiModelRegistryService,
- ApplicationService,
- PreInstalledAppsService,
- SdkClientGenerationService,
- PrefillLogicFunctionService,
- WorkspaceMigrationValidateBuildAndRunService,
- UpgradeMigrationService,
- UpgradeSequenceReaderService,
- ].map((service) => ({
- provide: service,
- useValue: {},
- })),
- {
- provide: WorkspaceCacheStorageService,
- useValue: {
- flush: jest.fn(),
- },
- },
- {
- provide: WorkspaceDataSourceService,
- useValue: {
- deleteWorkspaceDBSchema: jest.fn(),
- },
- },
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- flushFlatEntityMaps: jest.fn(),
- getOrRecomputeManyOrAllFlatEntityMaps: jest
- .fn()
- .mockResolvedValue(createEmptyAllFlatEntityMaps()),
- },
- },
- {
- provide: UserWorkspaceService,
- useValue: {
- deleteUserWorkspace: jest.fn(),
- },
- },
- {
- provide: getQueueToken(MessageQueue.deleteCascadeQueue),
- useValue: {
- add: jest.fn(),
- },
- },
- {
- provide: CoreEntityCacheService,
- useValue: {
- invalidate: jest.fn(),
- },
- },
- {
- provide: getDataSourceToken(),
- useValue: {
- createQueryRunner: jest.fn().mockReturnValue(queryRunner),
- getRepository: jest.fn().mockReturnValue({
- find: jest.fn().mockResolvedValue([]),
- }),
- },
- },
- ],
- }).compile();
-
- service = module.get<WorkspaceService>(WorkspaceService);
- userWorkspaceRepository = module.get<Repository<UserWorkspaceEntity>>(
- getRepositoryToken(UserWorkspaceEntity),
- );
- userRepository = module.get<Repository<UserEntity>>(
- getRepositoryToken(UserEntity),
- );
- workspaceRepository = module.get<Repository<WorkspaceEntity>>(
- getRepositoryToken(WorkspaceEntity),
- );
- workspaceCacheStorageService = module.get<WorkspaceCacheStorageService>(
- WorkspaceCacheStorageService,
- );
- messageQueueService = module.get<MessageQueueService>(
- getQueueToken(MessageQueue.deleteCascadeQueue),
- );
- dnsManagerService = module.get<DnsManagerService>(DnsManagerService);
- dnsManagerService.deleteHostnameSilently = jest.fn();
- billingSubscriptionService = module.get<BillingSubscriptionService>(
- BillingSubscriptionService,
- );
- userWorkspaceService =
- module.get<UserWorkspaceService>(UserWorkspaceService);
- flatEntityMapsCacheService =
- module.get<WorkspaceManyOrAllFlatEntityMapsCacheService>(
- WorkspaceManyOrAllFlatEntityMapsCacheService,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('handleRemoveWorkspaceMember', () => {
- it('should soft delete the user workspace record', async () => {
- jest.spyOn(userWorkspaceRepository, 'find').mockResolvedValue([
- {
- userId: 'user-id',
- workspaceId: 'workspace-id',
- id: 'user-workspace-id',
- } as UserWorkspaceEntity,
- ]);
-
- await service.handleRemoveWorkspaceMember(
- 'workspace-id',
- 'user-id',
- true,
- );
-
- expect(userWorkspaceService.deleteUserWorkspace).toHaveBeenCalledWith({
- userWorkspaceId: 'user-workspace-id',
- softDelete: true,
- });
- expect(userWorkspaceRepository.delete).not.toHaveBeenCalled();
- expect(userRepository.softDelete).toHaveBeenCalledWith('user-id');
- });
-
- it('should destroy the user workspace record', async () => {
- jest.spyOn(userWorkspaceRepository, 'find').mockResolvedValue([
- {
- id: 'user-workspace-id',
- userId: 'user-id',
- workspaceId: 'workspace-id',
- } as UserWorkspaceEntity,
- ]);
-
- await service.handleRemoveWorkspaceMember(
- 'workspace-id',
- 'user-id',
- false,
- );
-
- expect(userWorkspaceService.deleteUserWorkspace).toHaveBeenCalledWith({
- userWorkspaceId: 'user-workspace-id',
- softDelete: false,
- });
- expect(userRepository.softDelete).toHaveBeenCalledWith('user-id');
- });
-
- it('should not soft delete the user record if there are other user workspace records', async () => {
- jest.spyOn(userWorkspaceRepository, 'find').mockResolvedValue([
- {
- id: 'remaining-user-workspace-id',
- userId: 'user-id',
- workspaceId: 'other-workspace-id',
- } as UserWorkspaceEntity,
- {
- id: 'user-workspace-id',
- userId: 'user-id',
- workspaceId: 'workspace-id',
- } as UserWorkspaceEntity,
- ]);
-
- await service.handleRemoveWorkspaceMember(
- 'workspace-id',
- 'user-id',
- false,
- );
-
- expect(userWorkspaceService.deleteUserWorkspace).toHaveBeenCalledWith({
- userWorkspaceId: 'user-workspace-id',
- softDelete: false,
- });
- expect(userWorkspaceService.deleteUserWorkspace).not.toHaveBeenCalledWith(
- {
- userWorkspaceId: 'remaining-user-workspace-id',
- softDelete: false,
- },
- );
- expect(userRepository.softDelete).not.toHaveBeenCalled();
- });
- });
-
- describe('deleteWorkspace', () => {
- it('should hard delete the workspace', async () => {
- const mockWorkspace = {
- id: 'workspace-id',
- metadataVersion: 0,
- } as WorkspaceEntity;
-
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace);
- jest.spyOn(userWorkspaceRepository, 'find').mockResolvedValue([]);
-
- await service.deleteWorkspace(mockWorkspace.id, false);
-
- expect(
- billingSubscriptionService.assertSubscriptionCanceledOrNone,
- ).toHaveBeenCalledWith(mockWorkspace.id);
- expect(workspaceCacheStorageService.flush).toHaveBeenCalledWith(
- mockWorkspace.id,
- );
- expect(messageQueueService.add).toHaveBeenCalled();
- expect(workspaceRepository.delete).toHaveBeenCalledWith(mockWorkspace.id);
- expect(workspaceRepository.softDelete).not.toHaveBeenCalled();
- });
-
- it('should retrieve field metadata before starting the deletion transaction', async () => {
- const mockWorkspace = {
- id: 'workspace-id',
- metadataVersion: 0,
- } as WorkspaceEntity;
-
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace);
- jest.spyOn(userWorkspaceRepository, 'find').mockResolvedValue([]);
-
- await service.deleteWorkspace(mockWorkspace.id, false);
-
- const cacheRetrieval = jest.mocked(
- flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps,
- );
-
- expect(cacheRetrieval).toHaveBeenCalledTimes(1);
- expect(cacheRetrieval.mock.invocationCallOrder[0]).toBeLessThan(
- (queryRunner.startTransaction as jest.Mock).mock.invocationCallOrder[0],
- );
- });
-
- it('should soft delete the workspace', async () => {
- const mockWorkspace = {
- id: 'workspace-id',
- metadataVersion: 0,
- } as WorkspaceEntity;
-
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace);
- jest.spyOn(userWorkspaceRepository, 'find').mockResolvedValue([]);
-
- await service.deleteWorkspace(mockWorkspace.id, true);
-
- expect(
- billingSubscriptionService.cancelSubscription,
- ).toHaveBeenCalledWith(mockWorkspace.id);
- expect(workspaceRepository.softDelete).toHaveBeenCalledWith({
- id: mockWorkspace.id,
- });
- expect(workspaceRepository.delete).not.toHaveBeenCalled();
- });
-
- it('should delete the custom domain when hard deleting a workspace with a custom domain', async () => {
- const customDomain = 'custom.example.com';
- const mockWorkspace = {
- id: 'workspace-id',
- metadataVersion: 0,
- customDomain,
- } as WorkspaceEntity;
-
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace);
- jest.spyOn(userWorkspaceRepository, 'find').mockResolvedValue([]);
-
- await service.deleteWorkspace(mockWorkspace.id, false);
-
- expect(dnsManagerService.deleteHostnameSilently).toHaveBeenCalledWith(
- customDomain,
- );
- });
-
- it('should not delete the custom domain when soft deleting a workspace with a custom domain', async () => {
- const customDomain = 'custom.example.com';
- const mockWorkspace = {
- id: 'workspace-id',
- metadataVersion: 0,
- customDomain,
- } as WorkspaceEntity;
-
- jest
- .spyOn(workspaceRepository, 'findOne')
- .mockResolvedValue(mockWorkspace);
- jest.spyOn(userWorkspaceRepository, 'find').mockResolvedValue([]);
-
- await service.deleteWorkspace(mockWorkspace.id, true);
-
- expect(dnsManagerService.deleteHostnameSilently).not.toHaveBeenCalled();
- expect(workspaceRepository.softDelete).toHaveBeenCalledWith({
- id: mockWorkspace.id,
- });
- });
- });
-
- describe('suspendWorkspace', () => {
- it('should only suspend workspaces that are not already suspended and not soft-deleted', async () => {
- jest
- .spyOn(workspaceRepository, 'update')
- .mockResolvedValue({ affected: 1 } as never);
-
- const hasBeenSuspended = await service.suspendWorkspace('workspace-id');
-
- expect(workspaceRepository.update).toHaveBeenCalledWith(
- {
- id: 'workspace-id',
- activationStatus: Not(WorkspaceActivationStatus.SUSPENDED),
- deletedAt: IsNull(),
- },
- expect.objectContaining({
- activationStatus: WorkspaceActivationStatus.SUSPENDED,
- }),
- );
- expect(hasBeenSuspended).toBe(true);
- });
-
- it('should report no suspension when the guarded update affects no rows', async () => {
- jest
- .spyOn(workspaceRepository, 'update')
- .mockResolvedValue({ affected: 0 } as never);
-
- const hasBeenSuspended = await service.suspendWorkspace('workspace-id');
-
- expect(hasBeenSuspended).toBe(false);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/dataloaders/__tests__/dataloader.service.spec.ts b/packages/twenty-server/src/engine/dataloaders/__tests__/dataloader.service.spec.ts
deleted file mode 100644
index ca642b87b57..00000000000
--- a/packages/twenty-server/src/engine/dataloaders/__tests__/dataloader.service.spec.ts
+++ /dev/null
@@ -1,43 +0,0 @@
-import { DataloaderService } from 'src/engine/dataloaders/dataloader.service';
-import { type FieldMetadataConnectionLoaderFactory } from 'src/engine/dataloaders/factories/field-metadata-connection-loader.factory';
-import { type IndexMetadataConnectionLoaderFactory } from 'src/engine/dataloaders/factories/index-metadata-connection-loader.factory';
-
-describe('DataloaderService', () => {
- it('delegates metadata connection loader creation to domain factories', () => {
- const fieldMetadataConnectionLoader = {} as ReturnType<
- FieldMetadataConnectionLoaderFactory['create']
- >;
- const indexMetadataConnectionLoader = {} as ReturnType<
- IndexMetadataConnectionLoaderFactory['create']
- >;
- const fieldMetadataConnectionLoaderFactory = {
- create: jest.fn(() => fieldMetadataConnectionLoader),
- } as unknown as FieldMetadataConnectionLoaderFactory;
- const indexMetadataConnectionLoaderFactory = {
- create: jest.fn(() => indexMetadataConnectionLoader),
- } as unknown as IndexMetadataConnectionLoaderFactory;
- const service = new DataloaderService(
- {} as never,
- {} as never,
- {} as never,
- {} as never,
- fieldMetadataConnectionLoaderFactory,
- indexMetadataConnectionLoaderFactory,
- );
-
- const loaders = service.createLoaders();
-
- expect(fieldMetadataConnectionLoaderFactory.create).toHaveBeenCalledTimes(
- 1,
- );
- expect(indexMetadataConnectionLoaderFactory.create).toHaveBeenCalledTimes(
- 1,
- );
- expect(loaders.fieldMetadataConnectionLoader).toBe(
- fieldMetadataConnectionLoader,
- );
- expect(loaders.indexMetadataConnectionLoader).toBe(
- indexMetadataConnectionLoader,
- );
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-actor-context.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-actor-context.service.spec.ts
deleted file mode 100644
index 76a846be969..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-actor-context.service.spec.ts
+++ /dev/null
@@ -1,133 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';
-import { AgentActorContextService } from 'src/engine/metadata-modules/ai/ai-agent-execution/services/agent-actor-context.service';
-import { AiExceptionCode } from 'src/engine/metadata-modules/ai/ai.exception';
-import {
- PermissionsException,
- PermissionsExceptionCode,
-} from 'src/engine/metadata-modules/permissions/permissions.exception';
-import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-
-describe('AgentActorContextService', () => {
- let service: AgentActorContextService;
- let userWorkspaceService: {
- getWorkspaceMember: jest.Mock;
- getUserWorkspaceForUser: jest.Mock;
- };
- let userRoleService: { getRoleIdForUserWorkspace: jest.Mock };
-
- const workspaceId = 'workspace-1';
- const workspaceMemberId = 'workspace-member-1';
-
- const runAsArgs = { workspaceMemberId, workspaceId };
-
- beforeEach(async () => {
- userWorkspaceService = {
- getWorkspaceMember: jest.fn().mockResolvedValue({
- id: workspaceMemberId,
- userId: 'user-1',
- name: { firstName: 'Ada', lastName: 'Lovelace' },
- }),
- getUserWorkspaceForUser: jest.fn().mockResolvedValue({
- id: 'user-workspace-1',
- userId: 'user-1',
- workspace: {
- id: workspaceId,
- createdAt: new Date(0),
- updatedAt: new Date(0),
- },
- user: {
- id: 'user-1',
- createdAt: new Date(0),
- updatedAt: new Date(0),
- },
- }),
- };
- userRoleService = {
- getRoleIdForUserWorkspace: jest.fn().mockResolvedValue('role-1'),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AgentActorContextService,
- { provide: UserWorkspaceService, useValue: userWorkspaceService },
- { provide: UserRoleService, useValue: userRoleService },
- { provide: GlobalWorkspaceOrmManager, useValue: {} },
- ],
- }).compile();
-
- service = module.get(AgentActorContextService);
- });
-
- it('reports a not-found error when the workspace member does not exist', async () => {
- userWorkspaceService.getWorkspaceMember.mockResolvedValue(null);
-
- await expect(
- service.buildRunAsWorkspaceMemberContext(runAsArgs),
- ).rejects.toMatchObject({
- code: AiExceptionCode.RUN_AS_WORKSPACE_MEMBER_NOT_FOUND,
- });
- });
-
- it('reports a not-found error when the member has no user workspace', async () => {
- userWorkspaceService.getUserWorkspaceForUser.mockResolvedValue(null);
-
- await expect(
- service.buildRunAsWorkspaceMemberContext(runAsArgs),
- ).rejects.toMatchObject({
- code: AiExceptionCode.RUN_AS_WORKSPACE_MEMBER_NOT_FOUND,
- });
- });
-
- it('reports a not-found error when the member has no role assigned', async () => {
- userRoleService.getRoleIdForUserWorkspace.mockRejectedValue(
- new PermissionsException(
- 'No role found for userWorkspace',
- PermissionsExceptionCode.NO_ROLE_FOUND_FOR_USER_WORKSPACE,
- ),
- );
-
- await expect(
- service.buildRunAsWorkspaceMemberContext(runAsArgs),
- ).rejects.toMatchObject({
- code: AiExceptionCode.RUN_AS_WORKSPACE_MEMBER_NOT_FOUND,
- });
- });
-
- it('lets an infrastructure failure keep its own error type', async () => {
- const databaseError = new Error('connection terminated unexpectedly');
-
- userWorkspaceService.getWorkspaceMember.mockRejectedValue(databaseError);
-
- await expect(
- service.buildRunAsWorkspaceMemberContext(runAsArgs),
- ).rejects.toBe(databaseError);
- });
-
- it('lets an unrelated permissions failure keep its own error type', async () => {
- const permissionsError = new PermissionsException(
- 'Permission denied',
- PermissionsExceptionCode.PERMISSION_DENIED,
- );
-
- userRoleService.getRoleIdForUserWorkspace.mockRejectedValue(
- permissionsError,
- );
-
- await expect(
- service.buildRunAsWorkspaceMemberContext(runAsArgs),
- ).rejects.toBe(permissionsError);
- });
-
- it('returns the member actor context, auth context and role', async () => {
- const result = await service.buildRunAsWorkspaceMemberContext(runAsArgs);
-
- expect(result.roleId).toBe('role-1');
- expect(result.authContext).toMatchObject({
- type: 'user',
- workspaceMemberId,
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-async-executor.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-async-executor.service.spec.ts
deleted file mode 100644
index e62fbb92ece..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-async-executor.service.spec.ts
+++ /dev/null
@@ -1,476 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { getRepositoryToken } from '@nestjs/typeorm';
-import { generateText } from 'ai';
-import { ToolCategory } from 'twenty-shared/ai';
-
-import { BillingUsageService } from 'src/engine/core-modules/billing/services/billing-usage.service';
-import { MetricsService } from 'src/engine/core-modules/metrics/metrics.service';
-import { ToolRegistryService } from 'src/engine/core-modules/tool-provider/services/tool-registry.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { AgentAsyncExecutorService } from 'src/engine/metadata-modules/ai/ai-agent-execution/services/agent-async-executor.service';
-import { AGENT_RUN_BASE_SYSTEM_PROMPT } from 'src/engine/metadata-modules/ai/ai-agent/constants/agent-run-base-system-prompt.const';
-import { STRUCTURED_OUTPUT_SYSTEM_PROMPT } from 'src/engine/metadata-modules/ai/ai-agent/constants/structured-output-system-prompt.const';
-import { type AgentEntity } from 'src/engine/metadata-modules/ai/ai-agent/entities/agent.entity';
-import { NATIVE_WEB_SEARCH_COST_PER_CALL_DOLLARS } from 'src/engine/metadata-modules/ai/ai-billing/constants/native-web-search-cost-per-call-dollars';
-import { AiBillingService } from 'src/engine/metadata-modules/ai/ai-billing/services/ai-billing.service';
-import { AiModelConfigService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-config.service';
-import { AiModelRegistryService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
-import { NativeToolBinderService } from 'src/engine/metadata-modules/ai/ai-models/services/native-tool-binder.service';
-import { RoleTargetEntity } from 'src/engine/metadata-modules/role-target/role-target.entity';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-
-jest.mock('ai', () => ({
- ...jest.requireActual('ai'),
- generateText: jest.fn().mockResolvedValue({
- text: '',
- steps: [],
- usage: {
- inputTokens: 0,
- outputTokens: 0,
- totalTokens: 0,
- inputTokenDetails: {
- noCacheTokens: 0,
- cacheReadTokens: 0,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 0, reasoningTokens: 0 },
- },
- }),
-}));
-
-const generateTextMock = generateText as jest.MockedFunction<
- typeof generateText
->;
-
-describe('AgentAsyncExecutorService — workflow agent role-scoped tool resolution', () => {
- let service: AgentAsyncExecutorService;
- let toolRegistry: {
- getToolsByCategories: jest.Mock;
- buildToolIndex: jest.Mock;
- };
- let roleTargetRepository: { findOne: jest.Mock };
- let aiBillingService: {
- decrementAndCheckAvailableCredits: jest.Mock;
- calculateCost: jest.Mock;
- emitAiTokenUsageEvent: jest.Mock;
- billNativeWebSearchUsage: jest.Mock;
- };
-
- const agentId = 'agent-1';
- const workspaceId = 'workspace-1';
- const agentRoleId = 'role-1';
-
- const buildAgent = (): AgentEntity =>
- ({
- id: agentId,
- workspaceId,
- modelId: 'openai/gpt-4.1',
- prompt: 'test prompt',
- modelConfiguration: {},
- }) as AgentEntity;
-
- const emptyUsage = {
- inputTokens: 0,
- outputTokens: 0,
- totalTokens: 0,
- inputTokenDetails: {
- noCacheTokens: 0,
- cacheReadTokens: 0,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 0, reasoningTokens: 0 },
- };
-
- beforeEach(async () => {
- toolRegistry = {
- getToolsByCategories: jest.fn().mockResolvedValue({}),
- buildToolIndex: jest.fn().mockResolvedValue([]),
- };
- roleTargetRepository = { findOne: jest.fn() };
- aiBillingService = {
- decrementAndCheckAvailableCredits: jest
- .fn()
- .mockResolvedValue({ hasNoMoreAvailableCredits: false }),
- calculateCost: jest.fn().mockReturnValue(0),
- emitAiTokenUsageEvent: jest.fn(),
- billNativeWebSearchUsage: jest.fn(),
- };
-
- generateTextMock.mockClear();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AgentAsyncExecutorService,
- {
- provide: AiModelRegistryService,
- useValue: {
- validateModelAvailability: jest.fn(),
- resolveModelForAgent: jest.fn().mockResolvedValue({
- modelId: 'openai/gpt-4.1',
- sdkPackage: '@ai-sdk/openai',
- model: {},
- }),
- },
- },
- {
- provide: AiModelConfigService,
- useValue: {
- getReasoningProviderOptions: jest.fn().mockReturnValue({}),
- },
- },
- { provide: ToolRegistryService, useValue: toolRegistry },
- {
- provide: NativeToolBinderService,
- useValue: {
- bind: jest.fn().mockReturnValue({}),
- },
- },
- { provide: AiBillingService, useValue: aiBillingService },
- {
- provide: BillingUsageService,
- useValue: {
- hasAvailableCreditsOrThrow: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: MetricsService,
- useValue: {
- incrementCounterForEvent: jest.fn(),
- },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(RoleTargetEntity),
- useValue: roleTargetRepository,
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: { findOneBy: jest.fn().mockResolvedValue(null) },
- },
- ],
- }).compile();
-
- service = module.get<AgentAsyncExecutorService>(AgentAsyncExecutorService);
- });
-
- it('preloads role-scoped tool schemas by default (workflow node)', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce({ roleId: agentRoleId });
-
- await service.executeAgent({
- agent: buildAgent(),
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- });
-
- expect(toolRegistry.getToolsByCategories).toHaveBeenCalledTimes(1);
- expect(toolRegistry.getToolsByCategories).toHaveBeenCalledWith(
- expect.objectContaining({
- roleId: agentRoleId,
- rolePermissionConfig: { intersectionOf: [agentRoleId] },
- requireExplicitObjectGrants: true,
- workspaceId,
- }),
- expect.objectContaining({ wrapWithErrorContext: false }),
- );
- expect(toolRegistry.buildToolIndex).not.toHaveBeenCalled();
- });
-
- it('loads tools lazily via a category-scoped catalog when toolLoadingStrategy is "lazy" (runAgent)', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce({ roleId: agentRoleId });
- toolRegistry.buildToolIndex.mockResolvedValueOnce([
- {
- name: 'find_many_people',
- category: ToolCategory.DATABASE_CRUD,
- objectName: 'person',
- operation: 'find_many',
- },
- { name: 'create_one_workflow', category: ToolCategory.WORKFLOW },
- ]);
-
- await service.executeAgent({
- agent: buildAgent(),
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- toolLoadingStrategy: 'lazy',
- });
-
- expect(toolRegistry.getToolsByCategories).not.toHaveBeenCalled();
- expect(toolRegistry.buildToolIndex).toHaveBeenCalledWith(
- workspaceId,
- agentRoleId,
- expect.any(Object),
- );
-
- const { system } = generateTextMock.mock.calls[0][0];
-
- expect(system).toContain('## Available Tools');
- expect(system).toContain('person');
- expect(system).not.toContain('Workflow Tools');
- expect(system).not.toContain('create_one_workflow');
- });
-
- it('intersects the agent role with the run-as role on the lazy path used by runAgent', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce({ roleId: agentRoleId });
- toolRegistry.buildToolIndex.mockResolvedValueOnce([]);
-
- await service.executeAgent({
- agent: buildAgent(),
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- runAsRoleId: 'run-as-role-id',
- toolLoadingStrategy: 'lazy',
- });
-
- expect(toolRegistry.buildToolIndex).toHaveBeenCalledWith(
- workspaceId,
- agentRoleId,
- expect.objectContaining({
- rolePermissionConfig: {
- intersectionOf: [agentRoleId, 'run-as-role-id'],
- },
- }),
- );
- });
-
- it('leaves the lazy path on its default role resolution without a run-as role', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce({ roleId: agentRoleId });
- toolRegistry.buildToolIndex.mockResolvedValueOnce([]);
-
- await service.executeAgent({
- agent: buildAgent(),
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- toolLoadingStrategy: 'lazy',
- });
-
- expect(toolRegistry.buildToolIndex).toHaveBeenCalledWith(
- workspaceId,
- agentRoleId,
- expect.objectContaining({ rolePermissionConfig: undefined }),
- );
- });
-
- it('does not resolve registry tools when the agent has no role (fail-closed)', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce(null);
-
- await service.executeAgent({
- agent: buildAgent(),
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- });
-
- expect(toolRegistry.getToolsByCategories).not.toHaveBeenCalled();
- });
-
- it('passes messages to generateText when messages are provided', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce({ roleId: agentRoleId });
-
- const messages = [
- { role: 'user' as const, content: 'Hello' },
- { role: 'assistant' as const, content: 'Hi' },
- { role: 'user' as const, content: 'Status?' },
- ];
-
- await service.executeAgent({
- agent: buildAgent(),
- messages,
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- });
-
- const generateTextArgs = generateTextMock.mock.calls[0][0];
-
- expect(generateTextArgs.messages).toEqual([
- { role: 'user', content: 'Hello' },
- { role: 'assistant', content: 'Hi' },
- { role: 'user', content: 'Status?' },
- ]);
- expect(generateTextArgs).not.toHaveProperty('prompt');
- });
-
- it('throws without calling the model when messages are empty', async () => {
- await expect(
- service.executeAgent({
- agent: buildAgent(),
- messages: [],
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- }),
- ).rejects.toThrow(/at least one message/);
-
- expect(generateTextMock).not.toHaveBeenCalled();
- });
-
- it('prefixes the system prompt with the caller-supplied base prompt', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce(null);
-
- await service.executeAgent({
- agent: buildAgent(),
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: 'caller base prompt',
- workspaceId,
- });
-
- expect(generateTextMock).toHaveBeenCalledWith(
- expect.objectContaining({
- system: 'caller base prompt\n\ntest prompt',
- }),
- );
- });
-
- it('uses the context-neutral structured output prompt regardless of the caller base prompt', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce(null);
- generateTextMock
- .mockResolvedValueOnce({
- text: 'execution result',
- steps: [],
- usage: emptyUsage,
- } as unknown as Awaited<ReturnType<typeof generateText>>)
- .mockResolvedValueOnce({
- text: '',
- steps: [],
- usage: emptyUsage,
- output: { summary: 'done' },
- } as unknown as Awaited<ReturnType<typeof generateText>>);
-
- await service.executeAgent({
- agent: {
- ...buildAgent(),
- responseFormat: {
- type: 'json',
- schema: { type: 'object', properties: {} },
- },
- } as AgentEntity,
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: AGENT_RUN_BASE_SYSTEM_PROMPT,
- workspaceId,
- });
-
- expect(generateTextMock).toHaveBeenCalledTimes(2);
- expect(generateTextMock.mock.calls[1][0].system).toBe(
- STRUCTURED_OUTPUT_SYSTEM_PROMPT,
- );
- expect(generateTextMock.mock.calls[1][0].system).not.toMatch(/workflow/i);
- });
-
- describe('cost folding', () => {
- const baseUsage = {
- inputTokens: 100,
- outputTokens: 50,
- totalTokens: 150,
- inputTokenDetails: {
- noCacheTokens: 100,
- cacheReadTokens: 0,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 50, reasoningTokens: 0 },
- };
-
- it('returns token cost only when no native web searches happened', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce({
- roleId: agentRoleId,
- });
- aiBillingService.calculateCost.mockReturnValue(0.0042);
- generateTextMock.mockResolvedValueOnce({
- text: '',
- steps: [{ toolCalls: [] }],
- usage: baseUsage,
- } as unknown as Awaited<ReturnType<typeof generateText>>);
-
- const result = await service.executeAgent({
- agent: buildAgent(),
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- });
-
- expect(result.nativeWebSearchCallCount).toBe(0);
- expect(result.totalCostInDollars).toBeCloseTo(0.0042, 6);
- expect(result.creditsUsedMicro).toBe(4200);
- });
-
- it('emits the token total without re-adding cache-creation tokens', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce({
- roleId: agentRoleId,
- });
- aiBillingService.calculateCost.mockReturnValue(0.0042);
- generateTextMock.mockResolvedValueOnce({
- text: '',
- steps: [
- {
- toolCalls: [],
- providerMetadata: {
- anthropic: { cacheCreationInputTokens: 30 },
- },
- },
- ],
- usage: {
- ...baseUsage,
- inputTokenDetails: {
- noCacheTokens: 60,
- cacheReadTokens: 10,
- cacheWriteTokens: 30,
- },
- },
- } as unknown as Awaited<ReturnType<typeof generateText>>);
-
- await service.executeAgent({
- agent: buildAgent(),
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- });
-
- expect(aiBillingService.emitAiTokenUsageEvent).toHaveBeenCalledTimes(1);
-
- const [, , emittedTotalTokens] =
- aiBillingService.emitAiTokenUsageEvent.mock.calls[0];
-
- expect(emittedTotalTokens).toBe(150);
- });
-
- it('folds native web search dollars into totalCostInDollars and creditsUsedMicro', async () => {
- roleTargetRepository.findOne.mockResolvedValueOnce({
- roleId: agentRoleId,
- });
- aiBillingService.calculateCost.mockReturnValue(0.01);
- generateTextMock.mockResolvedValueOnce({
- text: '',
- steps: [
- {
- toolCalls: [
- { toolName: 'web_search' },
- { toolName: 'web_search' },
- { toolName: 'some_other_tool' },
- ],
- },
- { toolCalls: [{ toolName: 'web_search' }] },
- ],
- usage: baseUsage,
- } as unknown as Awaited<ReturnType<typeof generateText>>);
-
- const result = await service.executeAgent({
- agent: buildAgent(),
- messages: [{ role: 'user', content: 'test' }],
- baseSystemPrompt: 'base system prompt',
- workspaceId,
- });
-
- const expectedSearchCost = 3 * NATIVE_WEB_SEARCH_COST_PER_CALL_DOLLARS;
-
- expect(result.nativeWebSearchCallCount).toBe(3);
- expect(result.totalCostInDollars).toBeCloseTo(
- 0.01 + expectedSearchCost,
- 6,
- );
- expect(result.creditsUsedMicro).toBe(
- Math.round((0.01 + expectedSearchCost) * 1_000_000),
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run.service.spec.ts
deleted file mode 100644
index f5478c82f37..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/__tests__/agent-run.service.spec.ts
+++ /dev/null
@@ -1,481 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type FlatWorkspace } from 'src/engine/core-modules/workspace/types/flat-workspace.type';
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { type FlatApplication } from 'src/engine/core-modules/application/types/flat-application.type';
-import { AgentActorContextService } from 'src/engine/metadata-modules/ai/ai-agent-execution/services/agent-actor-context.service';
-import { AgentAsyncExecutorService } from 'src/engine/metadata-modules/ai/ai-agent-execution/services/agent-async-executor.service';
-import { AgentRunService } from 'src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run.service';
-import { AGENT_RUN_BASE_SYSTEM_PROMPT } from 'src/engine/metadata-modules/ai/ai-agent/constants/agent-run-base-system-prompt.const';
-import { AgentEntity } from 'src/engine/metadata-modules/ai/ai-agent/entities/agent.entity';
-import {
- AiException,
- AiExceptionCode,
-} from 'src/engine/metadata-modules/ai/ai.exception';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-
-describe('AgentRunService', () => {
- let service: AgentRunService;
- let agentRepository: { findOne: jest.Mock };
- let applicationService: { findById: jest.Mock };
- let agentAsyncExecutorService: { executeAgent: jest.Mock };
- let agentActorContextService: {
- buildRunAsWorkspaceMemberContext: jest.Mock;
- };
-
- const workspace = { id: 'workspace-1' } as FlatWorkspace;
-
- const agent = { id: 'agent-1', applicationId: 'app-1' } as AgentEntity;
-
- const input = {
- agentUniversalIdentifier: 'agent-uid',
- prompt: 'Enrich record 123',
- };
-
- const callerApplication = { id: 'app-1' } as FlatApplication;
-
- const runAsActorContext = {
- source: 'AGENT',
- workspaceMemberId: 'workspace-member-1',
- };
-
- const runAsAuthContext = {
- type: 'user',
- workspace,
- userWorkspaceId: 'member-user-workspace-1',
- user: { id: 'user-1' },
- workspaceMemberId: 'workspace-member-1',
- workspaceMember: { id: 'workspace-member-1' },
- };
-
- beforeEach(async () => {
- agentRepository = { findOne: jest.fn().mockResolvedValue(agent) };
- applicationService = {
- findById: jest.fn().mockResolvedValue({ id: 'app-1' }),
- };
- agentAsyncExecutorService = {
- executeAgent: jest.fn().mockResolvedValue({
- result: { response: 'done' },
- hasNoMoreAvailableCredits: false,
- }),
- };
- agentActorContextService = {
- buildRunAsWorkspaceMemberContext: jest.fn().mockResolvedValue({
- actorContext: runAsActorContext,
- authContext: runAsAuthContext,
- roleId: 'member-role-1',
- }),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AgentRunService,
- {
- provide: AgentActorContextService,
- useValue: agentActorContextService,
- },
- {
- provide: AgentAsyncExecutorService,
- useValue: agentAsyncExecutorService,
- },
- {
- provide: ApplicationService,
- useValue: applicationService,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(AgentEntity),
- useValue: agentRepository,
- },
- ],
- }).compile();
-
- service = module.get(AgentRunService);
- });
-
- it('runs the agent found by its universal identifier and returns a success result', async () => {
- const result = await service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: null,
- input,
- });
-
- expect(agentRepository.findOne).toHaveBeenCalledWith(workspace.id, {
- where: {
- universalIdentifier: input.agentUniversalIdentifier,
- },
- });
- expect(applicationService.findById).toHaveBeenCalledWith(
- agent.applicationId,
- );
- expect(result).toEqual({
- result: { response: 'done' },
- error: null,
- success: true,
- });
- });
-
- it('builds the application auth context from the agent application', async () => {
- await service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: null,
- input,
- });
-
- expect(agentAsyncExecutorService.executeAgent).toHaveBeenCalledWith(
- expect.objectContaining({
- messages: [{ role: 'user', content: input.prompt }],
- authContext: {
- type: 'application',
- workspace,
- application: { id: 'app-1' },
- },
- }),
- );
- });
-
- it('does not resolve a run-as context when no workspace member is requested', async () => {
- await service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: null,
- input,
- });
-
- expect(
- agentActorContextService.buildRunAsWorkspaceMemberContext,
- ).not.toHaveBeenCalled();
- expect(agentAsyncExecutorService.executeAgent).toHaveBeenCalledWith(
- expect.objectContaining({
- actorContext: undefined,
- runAsRoleId: undefined,
- }),
- );
- });
-
- it('converts a prompt into a single user message', async () => {
- await service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- input,
- });
-
- expect(
- agentAsyncExecutorService.executeAgent.mock.calls[0][0].messages,
- ).toEqual([{ role: 'user', content: input.prompt }]);
- });
-
- it('runs as the requested workspace member with their auth context and role', async () => {
- await service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- callerApplication,
- input: { ...input, runAsWorkspaceMemberId: 'workspace-member-1' },
- });
-
- expect(
- agentActorContextService.buildRunAsWorkspaceMemberContext,
- ).toHaveBeenCalledWith({
- workspaceMemberId: 'workspace-member-1',
- workspaceId: workspace.id,
- });
- expect(agentAsyncExecutorService.executeAgent).toHaveBeenCalledWith(
- expect.objectContaining({
- actorContext: runAsActorContext,
- authContext: runAsAuthContext,
- runAsRoleId: 'member-role-1',
- userWorkspaceId: 'member-user-workspace-1',
- }),
- );
- });
-
- it('fails the run instead of falling back to the agent role when the member cannot be resolved', async () => {
- agentActorContextService.buildRunAsWorkspaceMemberContext.mockRejectedValue(
- new AiException(
- 'Workspace member not found',
- AiExceptionCode.RUN_AS_WORKSPACE_MEMBER_NOT_FOUND,
- ),
- );
-
- await expect(
- service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- callerApplication,
- input: { ...input, runAsWorkspaceMemberId: 'workspace-member-1' },
- }),
- ).rejects.toMatchObject({
- code: AiExceptionCode.RUN_AS_WORKSPACE_MEMBER_NOT_FOUND,
- });
-
- expect(agentAsyncExecutorService.executeAgent).not.toHaveBeenCalled();
- });
-
- it('passes messages to the executor when messages are provided instead of prompt', async () => {
- const messages = [
- { role: 'user' as const, content: 'Hello' },
- { role: 'assistant' as const, content: 'Hi there' },
- { role: 'user' as const, content: 'What is the status?' },
- ];
-
- await service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: null,
- input: {
- agentUniversalIdentifier: 'agent-uid',
- messages,
- },
- });
-
- const executeAgentArgs =
- agentAsyncExecutorService.executeAgent.mock.calls[0][0];
-
- expect(executeAgentArgs.messages).toEqual(messages);
- expect(executeAgentArgs.baseSystemPrompt).toBe(
- AGENT_RUN_BASE_SYSTEM_PROMPT,
- );
- expect(executeAgentArgs.toolLoadingStrategy).toBe('lazy');
- expect(executeAgentArgs.authContext).toEqual({
- type: 'application',
- workspace,
- application: { id: 'app-1' },
- });
- });
-
- it('throws when neither prompt nor messages are provided', async () => {
- await expect(
- service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- input: {
- agentUniversalIdentifier: 'agent-uid',
- },
- }),
- ).rejects.toThrow(/exactly one of prompt or messages/);
-
- expect(agentRepository.findOne).not.toHaveBeenCalled();
- expect(agentAsyncExecutorService.executeAgent).not.toHaveBeenCalled();
- });
-
- it('rejects running as a workspace member when the caller is not an application', async () => {
- await expect(
- service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: null,
- input: { ...input, runAsWorkspaceMemberId: 'workspace-member-1' },
- }),
- ).rejects.toThrow('requires an application access token');
-
- expect(
- agentActorContextService.buildRunAsWorkspaceMemberContext,
- ).not.toHaveBeenCalled();
- expect(agentAsyncExecutorService.executeAgent).not.toHaveBeenCalled();
- });
-
- it('rejects an application token issued for a user naming a different member', async () => {
- await expect(
- service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: 'workspace-member-2',
- callerApplication,
- input: { ...input, runAsWorkspaceMemberId: 'workspace-member-1' },
- }),
- ).rejects.toThrow('can only run an agent as that user');
-
- expect(
- agentActorContextService.buildRunAsWorkspaceMemberContext,
- ).not.toHaveBeenCalled();
- expect(agentAsyncExecutorService.executeAgent).not.toHaveBeenCalled();
- });
-
- it('rejects a user-bound application token whose member identity never resolved', async () => {
- await expect(
- service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: null,
- callerApplication,
- input: { ...input, runAsWorkspaceMemberId: 'workspace-member-1' },
- }),
- ).rejects.toThrow('can only run an agent as that user');
-
- expect(
- agentActorContextService.buildRunAsWorkspaceMemberContext,
- ).not.toHaveBeenCalled();
- expect(agentAsyncExecutorService.executeAgent).not.toHaveBeenCalled();
- });
-
- it('allows an application token with no user binding to name any member', async () => {
- await service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- callerApplication,
- input: { ...input, runAsWorkspaceMemberId: 'someone-elses-member-id' },
- });
-
- expect(
- agentActorContextService.buildRunAsWorkspaceMemberContext,
- ).toHaveBeenCalledWith({
- workspaceMemberId: 'someone-elses-member-id',
- workspaceId: workspace.id,
- });
- });
-
- it('rejects running an agent that belongs to another application', async () => {
- await expect(
- service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- callerApplication: { id: 'another-app' } as FlatApplication,
- input,
- }),
- ).rejects.toMatchObject({
- code: AiExceptionCode.RUN_AGENT_NOT_ALLOWED,
- });
-
- expect(agentAsyncExecutorService.executeAgent).not.toHaveBeenCalled();
- });
-
- it('allows an application to run its own agent', async () => {
- await service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- callerApplication,
- input,
- });
-
- expect(agentAsyncExecutorService.executeAgent).toHaveBeenCalled();
- });
-
- it('allows an application token issued for a user to run as that same user', async () => {
- await service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: 'workspace-member-1',
- callerApplication,
- input: { ...input, runAsWorkspaceMemberId: 'workspace-member-1' },
- });
-
- expect(
- agentActorContextService.buildRunAsWorkspaceMemberContext,
- ).toHaveBeenCalledWith({
- workspaceMemberId: 'workspace-member-1',
- workspaceId: workspace.id,
- });
- });
-
- it('throws when both prompt and messages are provided', async () => {
- await expect(
- service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- input: {
- agentUniversalIdentifier: 'agent-uid',
- prompt: 'Enrich record 123',
- messages: [{ role: 'user', content: 'Hello' }],
- },
- }),
- ).rejects.toThrow(/exactly one of prompt or messages/);
-
- expect(agentRepository.findOne).not.toHaveBeenCalled();
- expect(agentAsyncExecutorService.executeAgent).not.toHaveBeenCalled();
- });
-
- it('runs the agent with the programmatic base system prompt', async () => {
- await service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- input,
- });
-
- expect(agentAsyncExecutorService.executeAgent).toHaveBeenCalledWith(
- expect.objectContaining({
- baseSystemPrompt: AGENT_RUN_BASE_SYSTEM_PROMPT,
- toolLoadingStrategy: 'lazy',
- }),
- );
- });
-
- it('returns an error result when the workspace ran out of credits', async () => {
- agentAsyncExecutorService.executeAgent.mockResolvedValue({
- result: { response: 'partial' },
- hasNoMoreAvailableCredits: true,
- });
-
- const result = await service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: null,
- input,
- });
-
- expect(result).toEqual({
- result: null,
- error: 'AI agent stopped: no more available credits.',
- success: false,
- });
- });
-
- it('returns a generic error result when agent execution throws instead of bubbling GraphQL errors', async () => {
- agentAsyncExecutorService.executeAgent.mockRejectedValue(
- new Error('Failed to process successful response'),
- );
-
- const result = await service.run({
- workspace,
- requestUserWorkspaceId: 'user-workspace-1',
- requestWorkspaceMemberId: null,
- input,
- });
-
- expect(result).toEqual({
- result: null,
- error: 'Agent execution failed.',
- success: false,
- });
- });
-
- it('throws when no agent matches the identifier', async () => {
- agentRepository.findOne.mockResolvedValue(null);
-
- await expect(
- service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- input,
- }),
- ).rejects.toThrow(/not found/);
-
- expect(applicationService.findById).not.toHaveBeenCalled();
- expect(agentAsyncExecutorService.executeAgent).not.toHaveBeenCalled();
- });
-
- it("throws when the agent's application cannot be found", async () => {
- applicationService.findById.mockResolvedValue(null);
-
- await expect(
- service.run({
- workspace,
- requestUserWorkspaceId: null,
- requestWorkspaceMemberId: null,
- input,
- }),
- ).rejects.toThrow(/not found/);
-
- expect(agentAsyncExecutorService.executeAgent).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-role/agent-role.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-role/agent-role.service.spec.ts
deleted file mode 100644
index a53aeb6f749..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-role/agent-role.service.spec.ts
+++ /dev/null
@@ -1,450 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import {
- AiException,
- AiExceptionCode,
-} from 'src/engine/metadata-modules/ai/ai.exception';
-import { AgentEntity } from 'src/engine/metadata-modules/ai/ai-agent/entities/agent.entity';
-import { type ModelId } from 'src/engine/metadata-modules/ai/ai-models/types/model-id.type';
-import { type FlatRoleTarget } from 'src/engine/metadata-modules/flat-role-target/types/flat-role-target.type';
-import { RoleTargetEntity } from 'src/engine/metadata-modules/role-target/role-target.entity';
-import { RoleTargetService } from 'src/engine/metadata-modules/role-target/services/role-target.service';
-import { RoleEntity } from 'src/engine/metadata-modules/role/role.entity';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { type WorkspaceScopedRepository } from 'src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { AiAgentRoleService } from './ai-agent-role.service';
-
-describe('AiAgentRoleService', () => {
- let service: AiAgentRoleService;
- let agentRepository: WorkspaceScopedRepository<AgentEntity>;
- let roleRepository: WorkspaceScopedRepository<RoleEntity>;
- let roleTargetRepository: WorkspaceScopedRepository<RoleTargetEntity>;
- let roleTargetService: RoleTargetService;
- let workspaceCacheService: WorkspaceCacheService;
-
- const testWorkspaceId = 'test-workspace-id';
- let testAgent: AgentEntity;
- let testRole: RoleEntity;
- let testRole2: RoleEntity;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AiAgentRoleService,
- {
- provide: getWorkspaceScopedRepositoryToken(AgentEntity),
- useValue: {
- findOne: jest.fn(),
- find: jest.fn(),
- save: jest.fn(),
- },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(RoleEntity),
- useValue: {
- findOne: jest.fn(),
- save: jest.fn(),
- delete: jest.fn(),
- },
- },
- {
- provide: getWorkspaceScopedRepositoryToken(RoleTargetEntity),
- useValue: {
- findOne: jest.fn(),
- save: jest.fn(),
- delete: jest.fn(),
- find: jest.fn(),
- count: jest.fn(),
- },
- },
- {
- provide: RoleTargetService,
- useValue: {
- create: jest.fn(),
- delete: jest.fn(),
- },
- },
- {
- provide: WorkspaceCacheService,
- useValue: {
- invalidateAndRecompute: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<AiAgentRoleService>(AiAgentRoleService);
- agentRepository = module.get<WorkspaceScopedRepository<AgentEntity>>(
- getWorkspaceScopedRepositoryToken(AgentEntity),
- );
- roleRepository = module.get<WorkspaceScopedRepository<RoleEntity>>(
- getWorkspaceScopedRepositoryToken(RoleEntity),
- );
- roleTargetRepository = module.get<
- WorkspaceScopedRepository<RoleTargetEntity>
- >(getWorkspaceScopedRepositoryToken(RoleTargetEntity));
- roleTargetService = module.get<RoleTargetService>(RoleTargetService);
- workspaceCacheService = module.get<WorkspaceCacheService>(
- WorkspaceCacheService,
- );
-
- // Setup test data
- testAgent = {
- id: 'test-agent-id',
- name: 'Test Agent',
- description: 'Test agent for unit tests',
- prompt: 'You are a test agent',
- modelId: 'openai/gpt-4o' as ModelId,
- workspaceId: testWorkspaceId,
- createdAt: new Date(),
- updatedAt: new Date(),
- } as AgentEntity;
-
- testRole = {
- id: 'test-role-id',
- label: 'Test Role',
- description: 'Test role for unit tests',
- canUpdateAllSettings: false,
- canReadAllObjectRecords: true,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- canBeAssignedToAgents: true,
- canBeAssignedToUsers: true,
- canBeAssignedToApiKeys: true,
- workspaceId: testWorkspaceId,
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- } as RoleEntity;
-
- testRole2 = {
- id: 'test-role-2-id',
- label: 'Test Role 2',
- description: 'Second test role for unit tests',
- canUpdateAllSettings: true,
- canReadAllObjectRecords: true,
- canUpdateAllObjectRecords: true,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- canBeAssignedToAgents: true,
- canBeAssignedToUsers: true,
- canBeAssignedToApiKeys: true,
- workspaceId: testWorkspaceId,
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- } as RoleEntity;
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('assignRoleToAgent', () => {
- it('should successfully assign a role to an agent', async () => {
- // Arrange
- jest.spyOn(agentRepository, 'findOne').mockResolvedValue(testAgent);
- jest.spyOn(roleRepository, 'findOne').mockResolvedValue(testRole);
- jest.spyOn(roleTargetRepository, 'findOne').mockResolvedValue(null);
- jest
- .spyOn(roleTargetService, 'create')
- .mockResolvedValue({} as FlatRoleTarget);
-
- // Act
- await service.assignRoleToAgent({
- workspaceId: testWorkspaceId,
- agentId: testAgent.id,
- roleId: testRole.id,
- });
-
- // Assert
- expect(agentRepository.findOne).toHaveBeenCalledWith(testWorkspaceId, {
- where: { id: testAgent.id },
- });
- expect(roleRepository.findOne).toHaveBeenCalledWith(testWorkspaceId, {
- where: { id: testRole.id },
- });
- expect(roleTargetRepository.findOne).toHaveBeenCalledWith(
- testWorkspaceId,
- {
- where: {
- agentId: testAgent.id,
- roleId: testRole.id,
- },
- },
- );
- expect(roleTargetService.create).toHaveBeenCalledWith({
- createRoleTargetInput: {
- roleId: testRole.id,
- targetId: testAgent.id,
- targetMetadataForeignKey: 'agentId',
- },
- workspaceId: testWorkspaceId,
- });
- });
-
- it('should replace existing role when assigning a new role to an agent', async () => {
- // Arrange
- jest.spyOn(agentRepository, 'findOne').mockResolvedValue(testAgent);
- jest.spyOn(roleRepository, 'findOne').mockResolvedValue(testRole2);
- jest.spyOn(roleTargetRepository, 'findOne').mockResolvedValue(null);
- jest
- .spyOn(roleTargetService, 'create')
- .mockResolvedValue({} as FlatRoleTarget);
-
- // Act
- await service.assignRoleToAgent({
- workspaceId: testWorkspaceId,
- agentId: testAgent.id,
- roleId: testRole2.id,
- });
-
- // Assert
- expect(roleTargetService.create).toHaveBeenCalledWith({
- createRoleTargetInput: {
- roleId: testRole2.id,
- targetId: testAgent.id,
- targetMetadataForeignKey: 'agentId',
- },
- workspaceId: testWorkspaceId,
- });
- });
-
- it('should not create duplicate role target when assigning the same role', async () => {
- // Arrange
- const existingRoleTarget = {
- id: 'existing-role-target-id',
- roleId: testRole.id,
- agentId: testAgent.id,
- workspaceId: testWorkspaceId,
- createdAt: new Date(),
- updatedAt: new Date(),
- } as RoleTargetEntity;
-
- jest.spyOn(agentRepository, 'findOne').mockResolvedValue(testAgent);
- jest.spyOn(roleRepository, 'findOne').mockResolvedValue(testRole);
- jest
- .spyOn(roleTargetRepository, 'findOne')
- .mockResolvedValue(existingRoleTarget);
-
- // Act
- await service.assignRoleToAgent({
- workspaceId: testWorkspaceId,
- agentId: testAgent.id,
- roleId: testRole.id,
- });
-
- // Assert
- expect(roleTargetService.create).not.toHaveBeenCalled();
- });
-
- it('should throw AiException when agent does not exist', async () => {
- // Arrange
- const nonExistentAgentId = 'non-existent-agent-id';
-
- jest.spyOn(agentRepository, 'findOne').mockResolvedValue(null);
-
- // Act & Assert
- await expect(
- service.assignRoleToAgent({
- workspaceId: testWorkspaceId,
- agentId: nonExistentAgentId,
- roleId: testRole.id,
- }),
- ).rejects.toThrow(AiException);
-
- await expect(
- service.assignRoleToAgent({
- workspaceId: testWorkspaceId,
- agentId: nonExistentAgentId,
- roleId: testRole.id,
- }),
- ).rejects.toMatchObject({
- code: AiExceptionCode.AGENT_NOT_FOUND,
- message: `Agent with id ${nonExistentAgentId} not found in workspace`,
- });
- });
-
- it('should throw AiException when role does not exist', async () => {
- // Arrange
- const nonExistentRoleId = 'non-existent-role-id';
-
- jest.spyOn(agentRepository, 'findOne').mockResolvedValue(testAgent);
- jest.spyOn(roleRepository, 'findOne').mockResolvedValue(null);
-
- // Act & Assert
- await expect(
- service.assignRoleToAgent({
- workspaceId: testWorkspaceId,
- agentId: testAgent.id,
- roleId: nonExistentRoleId,
- }),
- ).rejects.toThrow(AiException);
-
- await expect(
- service.assignRoleToAgent({
- workspaceId: testWorkspaceId,
- agentId: testAgent.id,
- roleId: nonExistentRoleId,
- }),
- ).rejects.toMatchObject({
- code: AiExceptionCode.ROLE_NOT_FOUND,
- message: `Role with id ${nonExistentRoleId} not found in workspace`,
- });
- });
-
- it('should throw AiException when agent belongs to different workspace', async () => {
- // Arrange
- const differentWorkspaceId = 'different-workspace-id';
-
- jest.spyOn(agentRepository, 'findOne').mockResolvedValue(null);
-
- // Act & Assert
- await expect(
- service.assignRoleToAgent({
- workspaceId: differentWorkspaceId,
- agentId: testAgent.id,
- roleId: testRole.id,
- }),
- ).rejects.toThrow(AiException);
-
- await expect(
- service.assignRoleToAgent({
- workspaceId: differentWorkspaceId,
- agentId: testAgent.id,
- roleId: testRole.id,
- }),
- ).rejects.toMatchObject({
- code: AiExceptionCode.AGENT_NOT_FOUND,
- message: `Agent with id ${testAgent.id} not found in workspace`,
- });
- });
- });
-
- describe('removeRoleFromAgent', () => {
- it('should successfully remove role from agent', async () => {
- // Arrange
- const existingRoleTarget = {
- id: 'existing-role-target-id',
- roleId: testRole.id,
- agentId: testAgent.id,
- workspaceId: testWorkspaceId,
- createdAt: new Date(),
- updatedAt: new Date(),
- } as RoleTargetEntity;
-
- jest
- .spyOn(roleTargetRepository, 'findOne')
- .mockResolvedValue(existingRoleTarget);
- jest.spyOn(roleTargetService, 'delete').mockResolvedValue(undefined);
-
- // Act
- await service.removeRoleFromAgent({
- workspaceId: testWorkspaceId,
- agentId: testAgent.id,
- });
-
- // Assert
- expect(roleTargetRepository.findOne).toHaveBeenCalledWith(
- testWorkspaceId,
- {
- where: {
- agentId: testAgent.id,
- },
- },
- );
- expect(roleTargetService.delete).toHaveBeenCalledWith({
- id: existingRoleTarget.id,
- workspaceId: testWorkspaceId,
- });
- });
-
- it('should throw error when removing role from agent that has no role', async () => {
- // Arrange
- jest.spyOn(roleTargetRepository, 'findOne').mockResolvedValue(null);
-
- // Act & Assert
- await expect(
- service.removeRoleFromAgent({
- workspaceId: testWorkspaceId,
- agentId: testAgent.id,
- }),
- ).rejects.toThrow(AiException);
-
- await expect(
- service.removeRoleFromAgent({
- workspaceId: testWorkspaceId,
- agentId: testAgent.id,
- }),
- ).rejects.toMatchObject({
- code: AiExceptionCode.ROLE_NOT_FOUND,
- message: `Role target not found for agent ${testAgent.id}`,
- });
- });
- });
-
- describe('deleteAgentOnlyRoleIfUnused', () => {
- it('invalidates cached role permissions after deleting the role', async () => {
- const agentOnlyRole = {
- ...testRole,
- canBeAssignedToAgents: true,
- canBeAssignedToUsers: false,
- canBeAssignedToApiKeys: false,
- } as RoleEntity;
-
- jest.spyOn(roleRepository, 'findOne').mockResolvedValue(agentOnlyRole);
- jest.spyOn(roleTargetRepository, 'count').mockResolvedValue(0);
- jest
- .spyOn(roleRepository, 'delete')
- .mockResolvedValue({ raw: [], generatedMaps: [] });
- jest
- .spyOn(workspaceCacheService, 'invalidateAndRecompute')
- .mockResolvedValue();
-
- await service.deleteAgentOnlyRoleIfUnused({
- roleId: agentOnlyRole.id,
- roleTargetId: 'deleted-role-target-id',
- workspaceId: testWorkspaceId,
- });
-
- expect(roleRepository.delete).toHaveBeenCalledWith(testWorkspaceId, {
- id: agentOnlyRole.id,
- });
- expect(workspaceCacheService.invalidateAndRecompute).toHaveBeenCalledWith(
- testWorkspaceId,
- ['flatRoleMaps', 'flatRolePermissionFlagMaps'],
- );
- expect(
- (roleRepository.delete as jest.Mock).mock.invocationCallOrder[0],
- ).toBeLessThan(
- (workspaceCacheService.invalidateAndRecompute as jest.Mock).mock
- .invocationCallOrder[0],
- );
- });
-
- it('keeps the cache unchanged while the role is still assigned', async () => {
- const agentOnlyRole = {
- ...testRole,
- canBeAssignedToAgents: true,
- canBeAssignedToUsers: false,
- canBeAssignedToApiKeys: false,
- } as RoleEntity;
-
- jest.spyOn(roleRepository, 'findOne').mockResolvedValue(agentOnlyRole);
- jest.spyOn(roleTargetRepository, 'count').mockResolvedValue(1);
-
- await service.deleteAgentOnlyRoleIfUnused({
- roleId: agentOnlyRole.id,
- roleTargetId: 'deleted-role-target-id',
- workspaceId: testWorkspaceId,
- });
-
- expect(roleRepository.delete).not.toHaveBeenCalled();
- expect(
- workspaceCacheService.invalidateAndRecompute,
- ).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-billing/services/__tests__/ai-billing.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-billing/services/__tests__/ai-billing.service.spec.ts
deleted file mode 100644
index eef55b946a8..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-billing/services/__tests__/ai-billing.service.spec.ts
+++ /dev/null
@@ -1,432 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { USAGE_RECORDED } from 'src/engine/core-modules/usage/constants/usage-recorded.constant';
-import { UsageOperationType } from 'src/engine/core-modules/usage/enums/usage-operation-type.enum';
-import { UsageResourceType } from 'src/engine/core-modules/usage/enums/usage-resource-type.enum';
-import { UsageUnit } from 'src/engine/core-modules/usage/enums/usage-unit.enum';
-import { BillingService } from 'src/engine/core-modules/billing/services/billing.service';
-import { BillingUsageService } from 'src/engine/core-modules/billing/services/billing-usage.service';
-import { AiBillingService } from 'src/engine/metadata-modules/ai/ai-billing/services/ai-billing.service';
-import { ModelFamily } from 'src/engine/metadata-modules/ai/ai-models/types/model-family.enum';
-import { AiModelRegistryService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { WorkspaceEventEmitter } from 'src/engine/workspace-event-emitter/workspace-event-emitter';
-
-describe('AiBillingService', () => {
- let service: AiBillingService;
- let mockWorkspaceEventEmitter: jest.Mocked<WorkspaceEventEmitter>;
- let mockAiModelRegistryService: jest.Mocked<
- Pick<AiModelRegistryService, 'getEffectiveModelConfig'>
- >;
-
- const openaiModelConfig = {
- modelId: 'gpt-4o',
- label: 'GPT-4o',
- modelFamily: ModelFamily.GPT,
- sdkPackage: '@ai-sdk/openai',
- inputCostPerMillionTokens: 2.5,
- outputCostPerMillionTokens: 10.0,
- cachedInputCostPerMillionTokens: 1.25,
- };
-
- const anthropicModelConfig = {
- modelId: 'claude-sonnet-4-5-20250929',
- label: 'Claude Sonnet 4.5',
- modelFamily: ModelFamily.CLAUDE,
- sdkPackage: '@ai-sdk/anthropic',
- inputCostPerMillionTokens: 3.0,
- outputCostPerMillionTokens: 15.0,
- cachedInputCostPerMillionTokens: 0.3,
- cacheCreationCostPerMillionTokens: 3.75,
- };
-
- const defaultTokenDetails = {
- inputTokenDetails: {
- noCacheTokens: 0,
- cacheReadTokens: 0,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 0, reasoningTokens: 0 },
- };
-
- const mockTokenUsage = {
- inputTokens: 1000,
- outputTokens: 500,
- totalTokens: 1500,
- ...defaultTokenDetails,
- };
-
- beforeEach(async () => {
- const mockEventEmitterMethods = {
- emitCustomBatchEvent: jest.fn(),
- };
-
- const mockAiModelRegistryMethods = {
- getEffectiveModelConfig: jest.fn().mockReturnValue(openaiModelConfig),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AiBillingService,
- {
- provide: WorkspaceEventEmitter,
- useValue: mockEventEmitterMethods,
- },
- {
- provide: AiModelRegistryService,
- useValue: mockAiModelRegistryMethods,
- },
- {
- provide: BillingService,
- useValue: {
- isBillingEnabled: jest.fn().mockReturnValue(false),
- },
- },
- {
- provide: BillingUsageService,
- useValue: {
- decrementAvailableCreditsInCache: jest
- .fn()
- .mockResolvedValue(undefined),
- },
- },
- {
- provide: WorkspaceCacheService,
- useValue: {
- getOrRecompute: jest.fn().mockResolvedValue({
- currentBillingSubscription: {
- currentPeriodStart: new Date('2026-04-01T00:00:00Z'),
- },
- }),
- },
- },
- ],
- }).compile();
-
- service = module.get<AiBillingService>(AiBillingService);
- mockWorkspaceEventEmitter = module.get(WorkspaceEventEmitter);
- mockAiModelRegistryService = module.get(AiModelRegistryService);
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('calculateCost', () => {
- it('should calculate cost correctly for basic token usage', () => {
- const costInDollars = service.calculateCost('gpt-4o', {
- usage: mockTokenUsage,
- });
-
- // (1000/1M * 2.5) + (500/1M * 10.0) = 0.0025 + 0.005 = 0.0075
- expect(costInDollars).toBeCloseTo(0.0075);
- });
-
- it('should apply cached rate for OpenAI cached tokens', () => {
- const costInDollars = service.calculateCost('gpt-4o', {
- usage: {
- inputTokens: 1000,
- outputTokens: 500,
- totalTokens: 1500,
- inputTokenDetails: {
- noCacheTokens: 400,
- cacheReadTokens: 600,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 500, reasoningTokens: 0 },
- },
- });
-
- // OpenAI: inputTokens includes cached, so adjusted = 1000 - 600 = 400
- // inputCost = (400/1M * 2.5) = 0.001
- // cachedCost = (600/1M * 1.25) = 0.00075
- // outputCost = (500/1M * 10.0) = 0.005
- // total = 0.00675
- expect(costInDollars).toBeCloseTo(0.00675);
- });
-
- it('should not double-count cached and cache-creation tokens for Anthropic', () => {
- mockAiModelRegistryService.getEffectiveModelConfig.mockReturnValue(
- anthropicModelConfig as ReturnType<
- AiModelRegistryService['getEffectiveModelConfig']
- >,
- );
-
- const costInDollars = service.calculateCost(
- 'claude-sonnet-4-5-20250929',
- {
- usage: {
- // @ai-sdk/anthropic reports inputTokens as the FULL prompt:
- // noCache(400) + cacheRead(600) + cacheCreation(200) = 1200
- inputTokens: 1200,
- outputTokens: 500,
- totalTokens: 1700,
- inputTokenDetails: {
- noCacheTokens: 400,
- cacheReadTokens: 600,
- cacheWriteTokens: 200,
- },
- outputTokenDetails: { textTokens: 500, reasoningTokens: 0 },
- },
- cacheCreationTokens: 200,
- },
- );
-
- // inputTokens already includes cached + cache-creation, so the
- // full-rate portion is 1200 - 600 - 200 = 400
- // inputCost = (400/1M * 3.0) = 0.0012
- // cachedCost = (600/1M * 0.3) = 0.00018
- // cacheCreationCost = (200/1M * 3.75) = 0.00075
- // outputCost = (500/1M * 15.0) = 0.0075
- // total = 0.00963
- expect(costInDollars).toBeCloseTo(0.00963);
- });
-
- it('should charge reasoning tokens at the output rate without double-counting for OpenAI', () => {
- const costInDollars = service.calculateCost('gpt-4o', {
- usage: {
- inputTokens: 1000,
- outputTokens: 500,
- totalTokens: 2000,
- inputTokenDetails: {
- noCacheTokens: 0,
- cacheReadTokens: 0,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 0, reasoningTokens: 500 },
- },
- });
-
- // OpenAI: outputTokens (500) already includes reasoningTokens (500)
- // adjustedOutput = 500 - 500 = 0
- // inputCost = (1000/1M * 2.5) = 0.0025
- // outputCost = (0/1M * 10.0) = 0.0
- // reasoningCost = (500/1M * 10.0) = 0.005
- // total = 0.0075
- expect(costInDollars).toBeCloseTo(0.0075);
- });
-
- it('should use outputTokenDetails.reasoningTokens when present (SDK-aligned shape)', () => {
- const costInDollars = service.calculateCost('gpt-4o', {
- usage: {
- inputTokens: 1000,
- outputTokens: 500,
- totalTokens: 2000,
- inputTokenDetails: {
- noCacheTokens: 0,
- cacheReadTokens: 0,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 0, reasoningTokens: 500 },
- },
- });
-
- expect(costInDollars).toBeCloseTo(0.0075);
- });
-
- it('should use inputTokenDetails.cacheReadTokens when present (SDK-aligned shape)', () => {
- const costInDollars = service.calculateCost('gpt-4o', {
- usage: {
- inputTokens: 1000,
- outputTokens: 500,
- totalTokens: 1500,
- inputTokenDetails: {
- noCacheTokens: 400,
- cacheReadTokens: 600,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 500, reasoningTokens: 0 },
- },
- });
-
- expect(costInDollars).toBeCloseTo(0.00675);
- });
-
- it('should fall back to input rate when cachedInputCostPerMillionTokens is undefined', () => {
- mockAiModelRegistryService.getEffectiveModelConfig.mockReturnValue({
- ...openaiModelConfig,
- cachedInputCostPerMillionTokens: undefined,
- } as ReturnType<AiModelRegistryService['getEffectiveModelConfig']>);
-
- const costInDollars = service.calculateCost('gpt-4o', {
- usage: {
- inputTokens: 1000,
- outputTokens: 500,
- totalTokens: 1500,
- inputTokenDetails: {
- noCacheTokens: 400,
- cacheReadTokens: 600,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 500, reasoningTokens: 0 },
- },
- });
-
- // Falls back to full input rate for cached tokens
- // adjusted = 1000 - 600 = 400
- // inputCost = (400/1M * 2.5) = 0.001
- // cachedCost = (600/1M * 2.5) = 0.0015 (fallback to input rate)
- // outputCost = (500/1M * 10.0) = 0.005
- // total = 0.0075
- expect(costInDollars).toBeCloseTo(0.0075);
- });
-
- it('should use long context pricing when input exceeds threshold', () => {
- const anthropicWithLongContext = {
- ...anthropicModelConfig,
- longContextCost: {
- inputCostPerMillionTokens: 6.0,
- outputCostPerMillionTokens: 22.5,
- cachedInputCostPerMillionTokens: 0.6,
- cacheCreationCostPerMillionTokens: 7.5,
- thresholdTokens: 200_000,
- },
- };
-
- mockAiModelRegistryService.getEffectiveModelConfig.mockReturnValue(
- anthropicWithLongContext as ReturnType<
- AiModelRegistryService['getEffectiveModelConfig']
- >,
- );
-
- const costInDollars = service.calculateCost(
- 'claude-sonnet-4-5-20250929',
- {
- usage: {
- // Full prompt size = noCache(150k) + cacheRead(100k) = 250k
- inputTokens: 250_000,
- outputTokens: 1000,
- totalTokens: 251_000,
- cachedInputTokens: 100_000,
- inputTokenDetails: {
- noCacheTokens: 150_000,
- cacheReadTokens: 100_000,
- cacheWriteTokens: 0,
- },
- outputTokenDetails: { textTokens: 1000, reasoningTokens: 0 },
- },
- },
- );
-
- // Total input = 250k > 200k threshold -> long context rates
- // full-rate portion = 250k - 100k - 0 = 150k
- // inputCost = (150_000/1M * 6.0) = 0.9
- // cachedCost = (100_000/1M * 0.6) = 0.06
- // outputCost = (1000/1M * 22.5) = 0.0225
- // total = 0.9825
- expect(costInDollars).toBeCloseTo(0.9825);
- });
-
- it('should use standard pricing when input is below threshold', () => {
- const anthropicWithLongContext = {
- ...anthropicModelConfig,
- longContextCost: {
- inputCostPerMillionTokens: 6.0,
- outputCostPerMillionTokens: 22.5,
- cachedInputCostPerMillionTokens: 0.6,
- cacheCreationCostPerMillionTokens: 7.5,
- thresholdTokens: 200_000,
- },
- };
-
- mockAiModelRegistryService.getEffectiveModelConfig.mockReturnValue(
- anthropicWithLongContext as ReturnType<
- AiModelRegistryService['getEffectiveModelConfig']
- >,
- );
-
- const costInDollars = service.calculateCost(
- 'claude-sonnet-4-5-20250929',
- {
- usage: {
- inputTokens: 50_000,
- outputTokens: 1000,
- totalTokens: 51_000,
- ...defaultTokenDetails,
- },
- },
- );
-
- // Total input = 50k < 200k threshold -> standard rates
- // inputCost = (50_000/1M * 3.0) = 0.15
- // outputCost = (1000/1M * 15.0) = 0.015
- // total = 0.165
- expect(costInDollars).toBeCloseTo(0.165);
- });
- });
-
- describe('calculateAndBillUsage', () => {
- it('should calculate cost and emit billing event when model exists', async () => {
- await service.calculateAndBillUsage(
- 'gpt-4o',
- { usage: mockTokenUsage },
- 'workspace-1',
- UsageOperationType.AI_CHAT_TOKEN,
- 'agent-id-123',
- );
-
- expect(
- mockWorkspaceEventEmitter.emitCustomBatchEvent,
- ).toHaveBeenCalledWith(
- USAGE_RECORDED,
- [
- {
- resourceType: UsageResourceType.AI,
- operationType: UsageOperationType.AI_CHAT_TOKEN,
- creditsUsedMicro: 7500,
- quantity: 1500,
- unit: UsageUnit.TOKEN,
- resourceId: 'agent-id-123',
- resourceContext: 'gpt-4o',
- userWorkspaceId: null,
- },
- ],
- 'workspace-1',
- );
- });
-
- it('should not add cache-creation tokens to the emitted token quantity', async () => {
- mockAiModelRegistryService.getEffectiveModelConfig.mockReturnValue(
- anthropicModelConfig as ReturnType<
- AiModelRegistryService['getEffectiveModelConfig']
- >,
- );
-
- await service.calculateAndBillUsage(
- 'claude-sonnet-4-5-20250929',
- {
- usage: {
- // inputTokens is the full prompt: noCache(400) + cacheRead(600) +
- // cacheCreation(200), so quantity must be 1200 + 500, not + 200 again
- inputTokens: 1200,
- outputTokens: 500,
- totalTokens: 1700,
- inputTokenDetails: {
- noCacheTokens: 400,
- cacheReadTokens: 600,
- cacheWriteTokens: 200,
- },
- outputTokenDetails: { textTokens: 500, reasoningTokens: 0 },
- },
- cacheCreationTokens: 200,
- },
- 'workspace-1',
- UsageOperationType.AI_CHAT_TOKEN,
- 'agent-id-123',
- );
-
- expect(
- mockWorkspaceEventEmitter.emitCustomBatchEvent,
- ).toHaveBeenCalledWith(
- USAGE_RECORDED,
- [
- expect.objectContaining({
- creditsUsedMicro: 9630,
- quantity: 1700,
- }),
- ],
- 'workspace-1',
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/services/__tests__/agent-chat-event-publisher.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/services/__tests__/agent-chat-event-publisher.service.spec.ts
deleted file mode 100644
index 19e22aad8ec..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/services/__tests__/agent-chat-event-publisher.service.spec.ts
+++ /dev/null
@@ -1,76 +0,0 @@
-import { AgentChatEventPublisherService } from 'src/engine/metadata-modules/ai/ai-chat/services/agent-chat-event-publisher.service';
-
-describe('AgentChatEventPublisherService', () => {
- const buildService = () => {
- const redis = {
- rpush: jest.fn().mockResolvedValue(1),
- expire: jest.fn().mockResolvedValue(1),
- del: jest.fn().mockResolvedValue(1),
- };
- const subscriptionService = {
- publishToAgentChat: jest.fn().mockResolvedValue(undefined),
- };
- const service = new AgentChatEventPublisherService(
- subscriptionService as never,
- { getClient: () => redis } as never,
- );
-
- return { service, redis, subscriptionService };
- };
-
- it('accumulates stream chunks with a 1-based sequence number', async () => {
- const { service, redis, subscriptionService } = buildService();
-
- redis.rpush.mockResolvedValue(7);
-
- await service.publish({
- threadId: 'thread-id',
- workspaceId: 'workspace-id',
- event: { type: 'stream-chunk', chunk: { type: 'text-delta' } } as never,
- });
-
- expect(redis.rpush).toHaveBeenCalledWith(
- 'agent-chat-stream-chunks:thread-id',
- JSON.stringify({ type: 'text-delta' }),
- );
- expect(subscriptionService.publishToAgentChat).toHaveBeenCalledWith(
- expect.objectContaining({
- payload: {
- onAgentChatEvent: {
- threadId: 'thread-id',
- event: expect.objectContaining({ seq: 7 }),
- },
- },
- }),
- );
- });
-
- it.each(['message-persisted', 'credits-exhausted'] as const)(
- 'deletes the accumulated chunk list on terminal %s',
- async (type) => {
- const { service, redis } = buildService();
-
- await service.publish({
- threadId: 'thread-id',
- workspaceId: 'workspace-id',
- event: { type } as never,
- });
-
- expect(redis.del).toHaveBeenCalledWith(
- 'agent-chat-stream-chunks:thread-id',
- );
- },
- );
-
- it('keeps the chunk list on stream-error so catchup can replay the partial turn', async () => {
- const { service, redis } = buildService();
-
- await service.publish({
- threadId: 'thread-id',
- workspaceId: 'workspace-id',
- event: { type: 'stream-error', code: 'X', message: 'boom' } as never,
- });
-
- expect(redis.del).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/services/__tests__/system-prompt-builder.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/services/__tests__/system-prompt-builder.service.spec.ts
deleted file mode 100644
index 80699400de2..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/services/__tests__/system-prompt-builder.service.spec.ts
+++ /dev/null
@@ -1,107 +0,0 @@
-import { SystemPromptBuilderService } from 'src/engine/metadata-modules/ai/ai-chat/services/system-prompt-builder.service';
-
-describe('SystemPromptBuilderService', () => {
- const buildService = () =>
- new SystemPromptBuilderService({} as never, {} as never, {} as never);
-
- describe('buildUserContextSection', () => {
- it('omits the timezone line when timezone is the "system" sentinel', () => {
- const service = buildService();
-
- const result = service.buildUserContextSection({
- firstName: 'John',
- lastName: 'Doe',
- jobTitle: null,
- locale: 'en',
- timezone: 'system',
- });
-
- expect(result).not.toContain('Timezone:');
- expect(result).toContain('Current date:');
- });
-
- it('omits the job title line when the workspace member has none', () => {
- const service = buildService();
-
- const result = service.buildUserContextSection({
- firstName: 'John',
- lastName: 'Doe',
- jobTitle: '',
- locale: 'en',
- timezone: 'system',
- });
-
- expect(result).not.toContain('Job title:');
- });
-
- it('includes the job title line when the workspace member has one', () => {
- const service = buildService();
-
- const result = service.buildUserContextSection({
- firstName: 'John',
- lastName: 'Doe',
- jobTitle: 'Head of Marketing',
- locale: 'en',
- timezone: 'system',
- });
-
- expect(result).toContain('Job title: Head of Marketing');
- });
-
- it('includes the timezone line for a valid IANA timezone', () => {
- const service = buildService();
-
- const result = service.buildUserContextSection({
- firstName: 'John',
- lastName: 'Doe',
- jobTitle: null,
- locale: 'en',
- timezone: 'America/New_York',
- });
-
- expect(result).toContain('Timezone: America/New_York');
- expect(result).toContain('Current date:');
- });
- });
-
- describe('buildFullPrompt', () => {
- it('does not append a trailing blank line when the skill catalog is empty', () => {
- const result = buildService().buildFullPrompt([], [], []);
-
- expect(result.endsWith('\n')).toBe(false);
- });
- });
-
- describe('buildWorkspaceInstructionsSection', () => {
- it('projects canonical TipTap JSON to Markdown', () => {
- const result = buildService().buildWorkspaceInstructionsSection(
- JSON.stringify({
- type: 'doc',
- attrs: { schemaVersion: 1 },
- content: [
- {
- type: 'heading',
- attrs: { level: 2 },
- content: [{ type: 'text', text: 'Sales rules' }],
- },
- {
- type: 'paragraph',
- content: [{ type: 'text', text: 'Be concise.' }],
- },
- ],
- }),
- );
-
- expect(result).toContain('## Sales rules\n\nBe concise.');
- expect(result).not.toContain('"type":"doc"');
- });
-
- it('omits an empty canonical document', () => {
- expect(
- buildService().buildWorkspaceInstructionsSection(
- JSON.stringify({ type: 'doc', attrs: { schemaVersion: 1 } }),
- ),
- ).toBe('');
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/services/__tests__/workspace-setup-chat.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/services/__tests__/workspace-setup-chat.service.spec.ts
deleted file mode 100644
index 6223bd89e65..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-chat/services/__tests__/workspace-setup-chat.service.spec.ts
+++ /dev/null
@@ -1,542 +0,0 @@
-import { isDefined } from 'twenty-shared/utils';
-import { type WorkspaceCompanyEnrichment } from 'twenty-shared/workspace';
-import { QueryFailedError } from 'typeorm';
-import { v5 } from 'uuid';
-
-import { type WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { WorkspaceSetupChatOutcome } from 'src/engine/metadata-modules/ai/ai-chat/enums/workspace-setup-chat-outcome.enum';
-import { WorkspaceSetupChatService } from 'src/engine/metadata-modules/ai/ai-chat/services/workspace-setup-chat.service';
-import { tagAiChatStreamScope } from 'src/engine/metadata-modules/ai/ai-chat/utils/tag-ai-chat-stream-scope.util';
-
-jest.mock(
- 'src/engine/metadata-modules/ai/ai-chat/utils/tag-ai-chat-stream-scope.util',
- () => ({
- tagAiChatStreamScope: jest.fn(),
- }),
-);
-
-// Pinned: changing the namespace or the name derivation would orphan the setup
-// threads already created from it.
-const WORKSPACE_SETUP_CHAT_THREAD_ID_NAMESPACE =
- '1e9195f3-c26a-4bfc-961e-dc317b4badbd';
-
-const EXPECTED_THREAD_ID = v5(
- 'workspace-id:user-workspace-id',
- WORKSPACE_SETUP_CHAT_THREAD_ID_NAMESPACE,
-);
-
-describe('WorkspaceSetupChatService', () => {
- const workspace = {
- id: 'workspace-id',
- fastModel: 'fast-model-id',
- smartModel: 'smart-model-id',
- } as WorkspaceEntity;
-
- const startArguments = {
- userId: 'creator-user-id',
- userLocale: 'en',
- userWorkspaceId: 'user-workspace-id',
- workspace,
- companyContext: null,
- };
-
- beforeEach(() => {
- jest.clearAllMocks();
- });
-
- const buildService = () => {
- const workspaceMemberState: { locale: string | null } = {
- locale: 'fr-FR',
- };
-
- const twentyConfigService = {
- get: jest.fn().mockReturnValue(true),
- };
- const billingUsageService = {
- hasAvailableCredits: jest.fn().mockResolvedValue(true),
- };
- const aiModelRegistryService = {
- getAvailableModels: jest
- .fn()
- .mockReturnValue([{ modelId: 'smart-model-id' }]),
- };
- const userWorkspaceService = {
- isWorkspaceCreator: jest.fn().mockResolvedValue(true),
- };
- const translate = jest.fn().mockReturnValue('translated-workspace-setup');
- const i18nService = {
- getI18nInstance: jest.fn().mockReturnValue({ _: translate }),
- };
- const agentChatService = {
- findThreadById: jest.fn().mockResolvedValue(null),
- createThread: jest.fn().mockImplementation(({ id, title }) =>
- Promise.resolve({
- id,
- title,
- deletedAt: null,
- activeStreamId: null,
- }),
- ),
- unarchiveThread: jest.fn().mockImplementation(({ threadId }) =>
- Promise.resolve({
- id: threadId,
- deletedAt: null,
- activeStreamId: null,
- }),
- ),
- hasConversationMessages: jest.fn().mockResolvedValue(false),
- };
- const agentChatStreamingService = {
- reapDeadStream: jest.fn().mockResolvedValue(null),
- startHiddenKickoffStream: jest.fn().mockResolvedValue({
- streamId: 'stream-id',
- messageId: 'message-id',
- turnId: 'turn-id',
- }),
- };
- const globalWorkspaceOrmManager = {
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((callback: () => unknown) => callback()),
- getRepository: jest.fn().mockResolvedValue({
- findOne: jest
- .fn()
- .mockImplementation(() =>
- Promise.resolve(
- isDefined(workspaceMemberState.locale)
- ? { locale: workspaceMemberState.locale }
- : null,
- ),
- ),
- }),
- };
-
- const service = new WorkspaceSetupChatService(
- twentyConfigService as never,
- billingUsageService as never,
- aiModelRegistryService as never,
- userWorkspaceService as never,
- i18nService as never,
- agentChatService as never,
- agentChatStreamingService as never,
- globalWorkspaceOrmManager as never,
- );
-
- return {
- service,
- workspaceMemberState,
- twentyConfigService,
- billingUsageService,
- aiModelRegistryService,
- userWorkspaceService,
- i18nService,
- translate,
- agentChatService,
- agentChatStreamingService,
- globalWorkspaceOrmManager,
- };
- };
-
- it('should return unavailable without any thread interaction when the onboarding ai chat is disabled', async () => {
- const { service, twentyConfigService, agentChatService } = buildService();
-
- twentyConfigService.get.mockReturnValue(false);
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.UNAVAILABLE,
- thread: null,
- });
- expect(twentyConfigService.get).toHaveBeenCalledWith(
- 'IS_ONBOARDING_AI_CHAT_ENABLED',
- );
- expect(agentChatService.findThreadById).not.toHaveBeenCalled();
- expect(agentChatService.createThread).not.toHaveBeenCalled();
- });
-
- it('should return unavailable when the caller is not the workspace creator', async () => {
- const { service, userWorkspaceService, agentChatService } = buildService();
-
- userWorkspaceService.isWorkspaceCreator.mockResolvedValue(false);
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.UNAVAILABLE,
- thread: null,
- });
- expect(userWorkspaceService.isWorkspaceCreator).toHaveBeenCalledWith({
- userId: 'creator-user-id',
- workspaceId: 'workspace-id',
- });
- expect(agentChatService.createThread).not.toHaveBeenCalled();
- });
-
- it('should return unavailable when no ai models are available', async () => {
- const { service, aiModelRegistryService, agentChatService } =
- buildService();
-
- aiModelRegistryService.getAvailableModels.mockReturnValue([]);
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.UNAVAILABLE,
- thread: null,
- });
- expect(agentChatService.createThread).not.toHaveBeenCalled();
- });
-
- it('should return unavailable without creating a thread when the workspace has no available credits', async () => {
- const { service, billingUsageService, agentChatService } = buildService();
-
- billingUsageService.hasAvailableCredits.mockResolvedValue(false);
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.UNAVAILABLE,
- thread: null,
- });
- expect(agentChatService.createThread).not.toHaveBeenCalled();
- });
-
- it('should create the thread under its deterministic id with a translated title and start the hidden kickoff stream', async () => {
- const {
- service,
- i18nService,
- translate,
- agentChatService,
- agentChatStreamingService,
- } = buildService();
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(agentChatService.findThreadById).toHaveBeenCalledWith({
- threadId: EXPECTED_THREAD_ID,
- userWorkspaceId: 'user-workspace-id',
- workspaceId: 'workspace-id',
- });
- expect(i18nService.getI18nInstance).toHaveBeenCalledWith('fr-FR');
- expect(translate).toHaveBeenCalledWith(
- expect.objectContaining({ message: 'Workspace setup' }),
- );
- expect(agentChatService.createThread).toHaveBeenCalledWith({
- userWorkspaceId: 'user-workspace-id',
- workspaceId: 'workspace-id',
- id: EXPECTED_THREAD_ID,
- title: 'translated-workspace-setup',
- });
- expect(
- agentChatStreamingService.startHiddenKickoffStream,
- ).toHaveBeenCalledWith({
- thread: expect.objectContaining({ id: EXPECTED_THREAD_ID }),
- userWorkspaceId: 'user-workspace-id',
- workspace,
- text: expect.stringContaining(
- 'No information about the company that owns this workspace is available.',
- ),
- modelId: 'fast-model-id',
- });
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.STARTED,
- thread: expect.objectContaining({
- id: EXPECTED_THREAD_ID,
- title: 'translated-workspace-setup',
- }),
- });
- expect(tagAiChatStreamScope).toHaveBeenCalledWith({
- streamId: 'stream-id',
- turnId: 'turn-id',
- threadId: EXPECTED_THREAD_ID,
- workspaceId: 'workspace-id',
- });
- });
-
- it('should reuse the concurrently created thread when the insert hits a unique violation', async () => {
- const { service, agentChatService, agentChatStreamingService } =
- buildService();
-
- const concurrentlyCreatedThread = {
- id: EXPECTED_THREAD_ID,
- deletedAt: null,
- activeStreamId: null,
- };
-
- agentChatService.findThreadById
- .mockResolvedValueOnce(null)
- .mockResolvedValue(concurrentlyCreatedThread);
- agentChatService.createThread.mockRejectedValue(
- Object.assign(
- new QueryFailedError('INSERT', [], new Error('duplicate key')),
- { code: '23505' },
- ),
- );
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(agentChatService.createThread).toHaveBeenCalledTimes(1);
- expect(
- agentChatStreamingService.startHiddenKickoffStream,
- ).toHaveBeenCalledWith(
- expect.objectContaining({ thread: concurrentlyCreatedThread }),
- );
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.STARTED,
- thread: concurrentlyCreatedThread,
- });
- });
-
- it('should rethrow a create failure that is not a unique violation', async () => {
- const { service, agentChatService, agentChatStreamingService } =
- buildService();
-
- agentChatService.createThread.mockRejectedValue(
- new Error('connection lost'),
- );
-
- await expect(
- service.startWorkspaceSetupChat(startArguments),
- ).rejects.toThrow('connection lost');
-
- expect(
- agentChatStreamingService.startHiddenKickoffStream,
- ).not.toHaveBeenCalled();
- });
-
- it('should build the prompt with the workspace member locale rather than the user one', async () => {
- const { service, agentChatStreamingService } = buildService();
-
- await service.startWorkspaceSetupChat(startArguments);
-
- const kickoffText =
- agentChatStreamingService.startHiddenKickoffStream.mock.calls[0][0].text;
-
- expect(kickoffText).toContain(
- 'The user locale is French, please continue the discussion in that language.',
- );
- });
-
- it('should fall back to the calling user locale when the workspace member has none', async () => {
- const {
- service,
- workspaceMemberState,
- i18nService,
- agentChatStreamingService,
- } = buildService();
-
- workspaceMemberState.locale = null;
-
- await service.startWorkspaceSetupChat(startArguments);
-
- const kickoffText =
- agentChatStreamingService.startHiddenKickoffStream.mock.calls[0][0].text;
-
- expect(kickoffText).toContain('The user locale is English');
- expect(i18nService.getI18nInstance).toHaveBeenCalledWith('en');
- });
-
- it('should embed the company context and the proposal instructions in the hidden prompt', async () => {
- const { service, agentChatStreamingService } = buildService();
-
- const companyContext = {
- domain: 'acme.com',
- enrichedAt: '2026-07-21T10:00:00.000Z',
- name: 'Acme Inc',
- website: 'https://acme.com',
- industry: 'computer software',
- employeeCount: 250,
- size: '51-200',
- founded: 2015,
- headline: 'Anvils as a service',
- summary: 'Acme sells anvils to coyotes.',
- tags: ['saas', 'b2b'],
- locality: 'San Francisco',
- region: 'California',
- country: 'United States',
- } satisfies WorkspaceCompanyEnrichment;
-
- await service.startWorkspaceSetupChat({
- ...startArguments,
- companyContext,
- });
-
- const kickoffText =
- agentChatStreamingService.startHiddenKickoffStream.mock.calls[0][0].text;
-
- expect(kickoffText).toContain('Domain: acme.com');
- expect(kickoffText).toContain('Name: Acme Inc');
- expect(kickoffText).toContain('Industry: computer software');
- expect(kickoffText).toContain('tailored to their business');
- expect(kickoffText).toContain(
- 'Only propose until the user explicitly approves',
- );
- expect(kickoffText).toContain('metadata-building');
- expect(kickoffText).toContain(
- 'The user locale is French, please continue the discussion in that language.',
- );
- expect(kickoffText).not.toContain('No information about the company');
- });
-
- it('should return alreadyStarted without a credit check when the thread already has conversation messages', async () => {
- const {
- service,
- billingUsageService,
- agentChatService,
- agentChatStreamingService,
- } = buildService();
-
- const existingThread = {
- id: EXPECTED_THREAD_ID,
- deletedAt: null,
- activeStreamId: null,
- };
-
- agentChatService.findThreadById.mockResolvedValue(existingThread);
- agentChatService.hasConversationMessages.mockResolvedValue(true);
- billingUsageService.hasAvailableCredits.mockResolvedValue(false);
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.ALREADY_STARTED,
- thread: existingThread,
- });
- expect(billingUsageService.hasAvailableCredits).not.toHaveBeenCalled();
- expect(
- agentChatStreamingService.startHiddenKickoffStream,
- ).not.toHaveBeenCalled();
- });
-
- it('should not start a stream on an empty existing thread when credits ran out', async () => {
- const {
- service,
- billingUsageService,
- agentChatService,
- agentChatStreamingService,
- } = buildService();
-
- agentChatService.findThreadById.mockResolvedValue({
- id: EXPECTED_THREAD_ID,
- deletedAt: null,
- activeStreamId: null,
- });
- billingUsageService.hasAvailableCredits.mockResolvedValue(false);
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.UNAVAILABLE,
- thread: null,
- });
- expect(agentChatService.createThread).not.toHaveBeenCalled();
- expect(
- agentChatStreamingService.startHiddenKickoffStream,
- ).not.toHaveBeenCalled();
- });
-
- it('should return alreadyStarted without kicking off when the active stream is still alive', async () => {
- const { service, agentChatService, agentChatStreamingService } =
- buildService();
-
- const streamingThread = {
- id: EXPECTED_THREAD_ID,
- deletedAt: null,
- activeStreamId: 'active-stream-id',
- };
-
- agentChatService.findThreadById.mockResolvedValue(streamingThread);
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(agentChatStreamingService.reapDeadStream).toHaveBeenCalledWith({
- thread: streamingThread,
- workspaceId: 'workspace-id',
- });
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.ALREADY_STARTED,
- thread: streamingThread,
- });
- expect(agentChatService.hasConversationMessages).not.toHaveBeenCalled();
- expect(
- agentChatStreamingService.startHiddenKickoffStream,
- ).not.toHaveBeenCalled();
- });
-
- it('should kick off again when the active stream is dead', async () => {
- const { service, agentChatService, agentChatStreamingService } =
- buildService();
-
- const interruptedThread = {
- id: EXPECTED_THREAD_ID,
- deletedAt: null,
- activeStreamId: 'dead-stream-id',
- };
-
- agentChatService.findThreadById.mockResolvedValue(interruptedThread);
- agentChatStreamingService.reapDeadStream.mockResolvedValue({
- code: 'CONNECTION_LOST',
- message: 'interrupted',
- });
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(
- agentChatStreamingService.startHiddenKickoffStream,
- ).toHaveBeenCalledWith(
- expect.objectContaining({ thread: interruptedThread }),
- );
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.STARTED,
- thread: interruptedThread,
- });
- });
-
- it('should return alreadyStarted when the hidden kickoff stream claim is lost', async () => {
- const { service, agentChatStreamingService } = buildService();
-
- agentChatStreamingService.startHiddenKickoffStream.mockResolvedValue(null);
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.ALREADY_STARTED,
- thread: expect.objectContaining({ id: EXPECTED_THREAD_ID }),
- });
- expect(tagAiChatStreamScope).not.toHaveBeenCalled();
- });
-
- it('should unarchive an archived thread before kicking off', async () => {
- const { service, agentChatService, agentChatStreamingService } =
- buildService();
-
- agentChatService.findThreadById.mockResolvedValue({
- id: EXPECTED_THREAD_ID,
- deletedAt: new Date(),
- activeStreamId: null,
- });
-
- const result = await service.startWorkspaceSetupChat(startArguments);
-
- expect(agentChatService.unarchiveThread).toHaveBeenCalledWith({
- threadId: EXPECTED_THREAD_ID,
- userWorkspaceId: 'user-workspace-id',
- workspaceId: 'workspace-id',
- });
- expect(
- agentChatService.unarchiveThread.mock.invocationCallOrder[0],
- ).toBeLessThan(
- agentChatStreamingService.startHiddenKickoffStream.mock
- .invocationCallOrder[0],
- );
- expect(agentChatService.createThread).not.toHaveBeenCalled();
- expect(result).toEqual({
- outcome: WorkspaceSetupChatOutcome.STARTED,
- thread: expect.objectContaining({
- id: EXPECTED_THREAD_ID,
- deletedAt: null,
- }),
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/services/__tests__/ai-model-config.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/services/__tests__/ai-model-config.service.spec.ts
deleted file mode 100644
index 4073c0d123e..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/services/__tests__/ai-model-config.service.spec.ts
+++ /dev/null
@@ -1,218 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { AGENT_CONFIG } from 'src/engine/metadata-modules/ai/ai-agent/constants/agent-config.const';
-import {
- AI_SDK_ANTHROPIC,
- AI_SDK_OPENAI,
- AI_SDK_XAI,
-} from 'src/engine/metadata-modules/ai/ai-models/constants/ai-sdk-package.const';
-import { AiModelConfigService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-config.service';
-import {
- AiModelRegistryService,
- type RegisteredAiModel,
-} from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
-import { SdkProviderFactoryService } from 'src/engine/metadata-modules/ai/ai-models/services/sdk-provider-factory.service';
-
-const XAI_WEB_TOOL = { __tool: 'xai-web-search' };
-const XAI_X_TOOL = { __tool: 'xai-x-search' };
-const ANTHROPIC_WEB_TOOL = { __tool: 'anthropic-web-search' };
-const OPENAI_WEB_TOOL = { __tool: 'openai-web-search' };
-
-describe('AiModelConfigService.getNativeModelTools — tool-based native search', () => {
- let service: AiModelConfigService;
- let sdkProviderFactory: {
- getRawXaiProvider: jest.Mock;
- getRawAnthropicProvider: jest.Mock;
- getRawOpenAIProvider: jest.Mock;
- };
-
- const xaiModel: RegisteredAiModel = {
- modelId: 'xai/grok-4',
- sdkPackage: AI_SDK_XAI,
- model: {} as RegisteredAiModel['model'],
- providerName: 'xai',
- };
-
- beforeEach(async () => {
- sdkProviderFactory = {
- getRawXaiProvider: jest.fn().mockReturnValue({
- tools: {
- webSearch: jest.fn().mockReturnValue(XAI_WEB_TOOL),
- xSearch: jest.fn().mockReturnValue(XAI_X_TOOL),
- },
- }),
- getRawAnthropicProvider: jest.fn().mockReturnValue({
- tools: {
- webSearch_20250305: jest.fn().mockReturnValue(ANTHROPIC_WEB_TOOL),
- },
- }),
- getRawOpenAIProvider: jest.fn().mockReturnValue({
- tools: {
- webSearch: jest.fn().mockReturnValue(OPENAI_WEB_TOOL),
- },
- }),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AiModelConfigService,
- { provide: AiModelRegistryService, useValue: {} },
- { provide: SdkProviderFactoryService, useValue: sdkProviderFactory },
- ],
- }).compile();
-
- service = module.get<AiModelConfigService>(AiModelConfigService);
- });
-
- it('binds no tools when neither webSearch nor twitterSearch is enabled', () => {
- expect(
- service.getNativeModelTools(xaiModel, {
- webSearch: false,
- twitterSearch: false,
- }),
- ).toEqual({});
- });
-
- it('binds no tools when no options are passed (no implicit "auto" search)', () => {
- expect(service.getNativeModelTools(xaiModel, {})).toEqual({});
- });
-
- it('binds only the xAI web_search tool when only webSearch is enabled', () => {
- const tools = service.getNativeModelTools(xaiModel, {
- webSearch: true,
- twitterSearch: false,
- });
-
- expect(tools).toEqual({ web_search: XAI_WEB_TOOL });
- });
-
- it('binds only the xAI x_search tool when only twitterSearch is enabled', () => {
- const tools = service.getNativeModelTools(xaiModel, {
- webSearch: false,
- twitterSearch: true,
- });
-
- expect(tools).toEqual({ x_search: XAI_X_TOOL });
- });
-
- it('binds both xAI tools when webSearch and twitterSearch are enabled', () => {
- const tools = service.getNativeModelTools(xaiModel, {
- webSearch: true,
- twitterSearch: true,
- });
-
- expect(tools).toEqual({
- web_search: XAI_WEB_TOOL,
- x_search: XAI_X_TOOL,
- });
- });
-
- it('binds no tools when the xAI provider cannot be resolved', () => {
- sdkProviderFactory.getRawXaiProvider.mockReturnValueOnce(undefined);
-
- expect(
- service.getNativeModelTools(xaiModel, {
- webSearch: true,
- twitterSearch: true,
- }),
- ).toEqual({});
- });
-
- it('binds no tools when the model has no resolved providerName', () => {
- const modelWithoutProvider: RegisteredAiModel = {
- modelId: 'xai/grok-4',
- sdkPackage: AI_SDK_XAI,
- model: {} as RegisteredAiModel['model'],
- };
-
- expect(
- service.getNativeModelTools(modelWithoutProvider, {
- webSearch: true,
- twitterSearch: true,
- }),
- ).toEqual({});
- expect(sdkProviderFactory.getRawXaiProvider).not.toHaveBeenCalled();
- });
-
- it('binds the Anthropic web_search tool when webSearch is enabled', () => {
- const anthropicModel: RegisteredAiModel = {
- modelId: 'anthropic/claude-sonnet-4-6',
- sdkPackage: AI_SDK_ANTHROPIC,
- model: {} as RegisteredAiModel['model'],
- providerName: 'anthropic',
- };
-
- expect(
- service.getNativeModelTools(anthropicModel, { webSearch: true }),
- ).toEqual({ web_search: ANTHROPIC_WEB_TOOL });
- });
-
- it('binds the OpenAI web_search tool when webSearch is enabled', () => {
- const openaiModel: RegisteredAiModel = {
- modelId: 'openai/gpt-4.1',
- sdkPackage: AI_SDK_OPENAI,
- model: {} as RegisteredAiModel['model'],
- providerName: 'openai',
- };
-
- expect(
- service.getNativeModelTools(openaiModel, { webSearch: true }),
- ).toEqual({ web_search: OPENAI_WEB_TOOL });
- });
-});
-
-describe('AiModelConfigService.getReasoningProviderOptions', () => {
- let service: AiModelConfigService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AiModelConfigService,
- { provide: AiModelRegistryService, useValue: {} },
- { provide: SdkProviderFactoryService, useValue: {} },
- ],
- }).compile();
-
- service = module.get<AiModelConfigService>(AiModelConfigService);
- });
-
- it('enables Anthropic thinking for reasoning-capable models', () => {
- const anthropicModel: RegisteredAiModel = {
- modelId: 'anthropic/claude-sonnet-4-6',
- sdkPackage: AI_SDK_ANTHROPIC,
- model: {} as RegisteredAiModel['model'],
- supportsReasoning: true,
- };
-
- expect(service.getReasoningProviderOptions(anthropicModel)).toEqual({
- anthropic: {
- thinking: {
- type: 'enabled',
- budgetTokens: AGENT_CONFIG.REASONING_BUDGET_TOKENS,
- },
- },
- });
- });
-
- it('returns empty options for non-reasoning Anthropic models', () => {
- const anthropicModel: RegisteredAiModel = {
- modelId: 'anthropic/claude-haiku',
- sdkPackage: AI_SDK_ANTHROPIC,
- model: {} as RegisteredAiModel['model'],
- supportsReasoning: false,
- };
-
- expect(service.getReasoningProviderOptions(anthropicModel)).toEqual({});
- });
-
- it('returns empty options for xAI models (no reasoning provider options)', () => {
- const xaiModel: RegisteredAiModel = {
- modelId: 'xai/grok-4',
- sdkPackage: AI_SDK_XAI,
- model: {} as RegisteredAiModel['model'],
- supportsReasoning: true,
- };
-
- expect(service.getReasoningProviderOptions(xaiModel)).toEqual({});
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/services/__tests__/ai-model-registry.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/services/__tests__/ai-model-registry.service.spec.ts
deleted file mode 100644
index 4d883b7a756..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/services/__tests__/ai-model-registry.service.spec.ts
+++ /dev/null
@@ -1,194 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ConfigGroupHashService } from 'src/engine/core-modules/twenty-config/services/config-group-hash.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { AiModelPreferencesService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-preferences.service';
-import { AiModelRegistryService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
-import { ProviderConfigService } from 'src/engine/metadata-modules/ai/ai-models/services/provider-config.service';
-import { SdkProviderFactoryService } from 'src/engine/metadata-modules/ai/ai-models/services/sdk-provider-factory.service';
-import { AUTO_SELECT_SMART_MODEL_ID } from 'twenty-shared/constants';
-
-describe('AiModelRegistryService', () => {
- let service: AiModelRegistryService;
- let mockConfigService: jest.Mocked<TwentyConfigService>;
- let mockPreferencesService: {
- getPreferences: jest.Mock;
- getRecommendedModelIds: jest.Mock;
- };
-
- beforeEach(async () => {
- mockConfigService = {
- get: jest.fn().mockReturnValue({}),
- } as any;
-
- const mockProviderConfigService = {
- getResolvedProviders: jest.fn().mockReturnValue({}),
- };
-
- mockPreferencesService = {
- getPreferences: jest.fn().mockReturnValue({}),
- getRecommendedModelIds: jest.fn().mockReturnValue(new Set()),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AiModelRegistryService,
- {
- provide: TwentyConfigService,
- useValue: mockConfigService,
- },
- {
- provide: ProviderConfigService,
- useValue: mockProviderConfigService,
- },
- {
- provide: SdkProviderFactoryService,
- useValue: { clearCache: jest.fn() },
- },
- {
- provide: AiModelPreferencesService,
- useValue: mockPreferencesService,
- },
- {
- provide: ConfigGroupHashService,
- useValue: { computeHash: jest.fn().mockReturnValue('') },
- },
- ],
- }).compile();
-
- service = module.get<AiModelRegistryService>(AiModelRegistryService);
- });
-
- it('should throw when no models are available for AUTO_SELECT_SMART_MODEL_ID', () => {
- expect(() =>
- service.getEffectiveModelConfig(AUTO_SELECT_SMART_MODEL_ID),
- ).toThrow(
- 'No AI models are available. Configure at least one AI provider.',
- );
- });
-
- it('should return effective model config for AUTO_SELECT_SMART_MODEL_ID when models are available', () => {
- jest.spyOn(service, 'getAvailableModels').mockReturnValue([
- {
- modelId: 'openai/gpt-5.2',
- sdkPackage: '@ai-sdk/openai',
- model: {} as any,
- },
- ]);
-
- jest.spyOn(service, 'getModel').mockReturnValue({
- modelId: 'openai/gpt-5.2',
- sdkPackage: '@ai-sdk/openai',
- model: {} as any,
- });
-
- const result = service.getEffectiveModelConfig(AUTO_SELECT_SMART_MODEL_ID);
-
- expect(result).toBeDefined();
- expect(result.modelId).toBe('openai/gpt-5.2');
- expect(result.sdkPackage).toBe('@ai-sdk/openai');
- });
-
- it('should return effective model config for AUTO_SELECT_SMART_MODEL_ID with custom model', () => {
- jest.spyOn(service, 'getAvailableModels').mockReturnValue([
- {
- modelId: 'custom/mistral',
- sdkPackage: '@ai-sdk/openai-compatible',
- model: {} as any,
- },
- ]);
-
- jest.spyOn(service, 'getModel').mockReturnValue({
- modelId: 'custom/mistral',
- sdkPackage: '@ai-sdk/openai-compatible',
- model: {} as any,
- });
-
- const result = service.getEffectiveModelConfig(AUTO_SELECT_SMART_MODEL_ID);
-
- expect(result).toBeDefined();
- expect(result.modelId).toBe('custom/mistral');
- expect(result.sdkPackage).toBe('@ai-sdk/openai-compatible');
- expect(result.label).toBe('custom/mistral');
- expect(result.inputCostPerMillionTokens).toBe(0);
- expect(result.outputCostPerMillionTokens).toBe(0);
- });
-
- it('should return effective model config for custom model', () => {
- jest.spyOn(service, 'getModel').mockReturnValue({
- modelId: 'custom/mistral',
- sdkPackage: '@ai-sdk/openai-compatible',
- model: {} as any,
- });
-
- const result = service.getEffectiveModelConfig('custom/mistral');
-
- expect(result).toBeDefined();
- expect(result.modelId).toBe('custom/mistral');
- expect(result.sdkPackage).toBe('@ai-sdk/openai-compatible');
- expect(result.label).toBe('custom/mistral');
- expect(result.inputCostPerMillionTokens).toBe(0);
- expect(result.outputCostPerMillionTokens).toBe(0);
- });
-
- it('should throw error for non-existent model', () => {
- jest.spyOn(service, 'getModel').mockReturnValue(undefined);
-
- expect(() => service.getEffectiveModelConfig('non-existent-model')).toThrow(
- 'Model with ID non-existent-model not found',
- );
- });
-
- it('should find first available model from preferences list', () => {
- mockPreferencesService.getPreferences.mockReturnValue({
- defaultFastModels: [
- 'openai/gpt-5-mini',
- 'anthropic/claude-haiku-4-5-20251001',
- 'google/gemini-3-flash-preview',
- ],
- });
-
- const getModelSpy = jest
- .spyOn(service, 'getModel')
- .mockImplementation((modelId: string) => {
- if (modelId === 'anthropic/claude-haiku-4-5-20251001') {
- return {
- modelId: 'anthropic/claude-haiku-4-5-20251001',
- sdkPackage: '@ai-sdk/anthropic',
- model: {} as any,
- };
- }
-
- return undefined;
- });
-
- const result = service.getDefaultSpeedModel();
-
- expect(result).toBeDefined();
- expect(result.modelId).toBe('anthropic/claude-haiku-4-5-20251001');
- expect(getModelSpy).toHaveBeenCalledWith('openai/gpt-5-mini');
- expect(getModelSpy).toHaveBeenCalledWith(
- 'anthropic/claude-haiku-4-5-20251001',
- );
- });
-
- it('should fall back to any available model if none in list are available', () => {
- mockPreferencesService.getPreferences.mockReturnValue({
- defaultFastModels: ['model-a', 'model-b', 'model-c'],
- });
-
- jest.spyOn(service, 'getModel').mockReturnValue(undefined);
- jest.spyOn(service, 'getAvailableModels').mockReturnValue([
- {
- modelId: 'fallback-model',
- sdkPackage: '@ai-sdk/openai-compatible',
- model: {} as any,
- },
- ]);
-
- const result = service.getDefaultSpeedModel();
-
- expect(result).toBeDefined();
- expect(result.modelId).toBe('fallback-model');
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/services/__tests__/default-ai-catalog.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/services/__tests__/default-ai-catalog.service.spec.ts
deleted file mode 100644
index 109ce721284..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-models/services/__tests__/default-ai-catalog.service.spec.ts
+++ /dev/null
@@ -1,135 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { Readable } from 'stream';
-
-import { FileStorageDriverFactory } from 'src/engine/core-modules/file-storage/file-storage-driver.factory';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { DefaultAiCatalogService } from 'src/engine/metadata-modules/ai/ai-models/services/default-ai-catalog.service';
-
-const mockReadFile = jest.fn();
-
-describe('DefaultAiCatalogService', () => {
- let service: DefaultAiCatalogService;
- let mockConfigService: jest.Mocked<TwentyConfigService>;
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- mockConfigService = {
- get: jest.fn().mockReturnValue(undefined),
- } as any;
-
- const mockDriverFactory = {
- getCurrentDriver: jest.fn().mockReturnValue({ readFile: mockReadFile }),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- DefaultAiCatalogService,
- { provide: TwentyConfigService, useValue: mockConfigService },
- { provide: FileStorageDriverFactory, useValue: mockDriverFactory },
- ],
- }).compile();
-
- service = module.get(DefaultAiCatalogService);
- });
-
- describe('onModuleInit', () => {
- it('should use built-in catalog when AI_CATALOG_STORAGE_PATH is not set', async () => {
- await service.onModuleInit();
-
- const providers = service.getDefaultAiCatalog();
-
- expect(providers).toBeDefined();
- expect(Object.keys(providers).length).toBeGreaterThan(0);
- expect(mockReadFile).not.toHaveBeenCalled();
- });
-
- it('should load catalog from storage when AI_CATALOG_STORAGE_PATH is set', async () => {
- const catalog = JSON.stringify({
- customProvider: {
- npm: '@ai-sdk/openai',
- models: [
- {
- name: 'custom-model',
- label: 'Custom Model',
- inputCostPerMillionTokens: 1,
- outputCostPerMillionTokens: 2,
- contextWindowTokens: 4096,
- maxOutputTokens: 1024,
- },
- ],
- },
- });
-
- mockConfigService.get.mockImplementation((key: string) => {
- if (key === 'AI_CATALOG_STORAGE_PATH') return 'config/ai-catalog.json';
-
- return undefined;
- });
-
- mockReadFile.mockResolvedValue(Readable.from([Buffer.from(catalog)]));
-
- await service.onModuleInit();
-
- const providers = service.getDefaultAiCatalog();
-
- expect(Object.keys(providers)).toEqual(['customProvider']);
- expect(providers['customProvider'].name).toBe('customProvider');
- expect(providers['customProvider'].models?.[0].source).toBe('catalog');
- expect(mockReadFile).toHaveBeenCalledWith({
- filePath: 'config/ai-catalog.json',
- });
- });
-
- it('should reset catalog to empty object when storage read fails', async () => {
- mockConfigService.get.mockImplementation((key: string) => {
- if (key === 'AI_CATALOG_STORAGE_PATH') return 'config/ai-catalog.json';
-
- return undefined;
- });
-
- mockReadFile.mockRejectedValue(new Error('Network error'));
-
- await service.onModuleInit();
-
- expect(service.getDefaultAiCatalog()).toEqual({});
- });
-
- it('should reset catalog to empty object when storage returns invalid JSON', async () => {
- mockConfigService.get.mockImplementation((key: string) => {
- if (key === 'AI_CATALOG_STORAGE_PATH') return 'config/ai-catalog.json';
-
- return undefined;
- });
-
- mockReadFile.mockResolvedValue(
- Readable.from([Buffer.from('not valid json')]),
- );
-
- await service.onModuleInit();
-
- expect(service.getDefaultAiCatalog()).toEqual({});
- });
-
- it('should reset catalog to empty object when payload fails Zod validation', async () => {
- const invalidCatalog = JSON.stringify({
- badProvider: { models: 'not-an-array' },
- });
-
- mockConfigService.get.mockImplementation((key: string) => {
- if (key === 'AI_CATALOG_STORAGE_PATH') return 'config/ai-catalog.json';
-
- return undefined;
- });
-
- mockReadFile.mockResolvedValue(
- Readable.from([Buffer.from(invalidCatalog)]),
- );
-
- await service.onModuleInit();
-
- expect(service.getDefaultAiCatalog()).toEqual({});
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/index-metadata/services/__tests__/index-metadata.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/index-metadata/services/__tests__/index-metadata.service.spec.ts
deleted file mode 100644
index cbe6ff2d270..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/index-metadata/services/__tests__/index-metadata.service.spec.ts
+++ /dev/null
@@ -1,450 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { createEmptyFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-flat-entity-maps.constant';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { getFlatIndexMetadataMock } from 'src/engine/metadata-modules/flat-index-metadata/__mocks__/get-flat-index-metadata.mock';
-import { MAX_CUSTOM_INDEXES_PER_OBJECT } from 'twenty-shared/constants';
-import {
- IndexMetadataException,
- IndexMetadataExceptionCode,
-} from 'src/engine/metadata-modules/index-metadata/index-field-metadata.exception';
-import { IndexMetadataService } from 'src/engine/metadata-modules/index-metadata/services/index-metadata.service';
-import { IndexType } from 'src/engine/metadata-modules/index-metadata/types/indexType.types';
-import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';
-
-const WORKSPACE_ID = 'workspace-id';
-const OBJECT_ID = 'object-id';
-const OBJECT_UNIVERSAL_ID = 'object-universal-id';
-const APPLICATION_UNIVERSAL_ID = 'app-universal-id';
-
-const buildFlatObjectMetadataMaps = () => {
- const maps = createEmptyFlatEntityMaps() as ReturnType<
- typeof createEmptyFlatEntityMaps
- > & {
- byUniversalIdentifier: Record<string, unknown>;
- universalIdentifierById: Record<string, string>;
- };
-
- maps.byUniversalIdentifier = {
- [OBJECT_UNIVERSAL_ID]: {
- id: OBJECT_ID,
- universalIdentifier: OBJECT_UNIVERSAL_ID,
- nameSingular: 'company',
- isCustom: false,
- },
- };
- maps.universalIdentifierById = { [OBJECT_ID]: OBJECT_UNIVERSAL_ID };
-
- return maps;
-};
-
-const buildFlatFieldMetadataMaps = (
- fields: {
- id: string;
- universalIdentifier: string;
- name: string;
- type?: FieldMetadataType;
- }[],
-) => {
- const maps = createEmptyFlatEntityMaps() as ReturnType<
- typeof createEmptyFlatEntityMaps
- > & {
- byUniversalIdentifier: Record<string, unknown>;
- universalIdentifierById: Record<string, string>;
- };
-
- for (const field of fields) {
- maps.byUniversalIdentifier[field.universalIdentifier] = {
- id: field.id,
- universalIdentifier: field.universalIdentifier,
- name: field.name,
- label: field.name,
- type: field.type ?? FieldMetadataType.TEXT,
- objectMetadataId: OBJECT_ID,
- isUnique: false,
- isCustom: true,
- isActive: true,
- isSystem: false,
- isNullable: true,
- };
- maps.universalIdentifierById[field.id] = field.universalIdentifier;
- }
-
- return maps;
-};
-
-const buildFlatIndexMaps = (
- indexes: Array<{
- id: string;
- universalIdentifier: string;
- isCustom: boolean;
- }>,
-) => {
- const maps = createEmptyFlatEntityMaps() as ReturnType<
- typeof createEmptyFlatEntityMaps
- > & {
- byUniversalIdentifier: Record<string, unknown>;
- universalIdentifierById: Record<string, string>;
- };
-
- for (const index of indexes) {
- maps.byUniversalIdentifier[index.universalIdentifier] =
- getFlatIndexMetadataMock({
- id: index.id,
- universalIdentifier: index.universalIdentifier,
- objectMetadataId: OBJECT_ID,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_ID,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_ID,
- isCustom: index.isCustom,
- });
- maps.universalIdentifierById[index.id] = index.universalIdentifier;
- }
-
- return maps;
-};
-
-describe('IndexMetadataService', () => {
- let service: IndexMetadataService;
- let cacheService: jest.Mocked<WorkspaceManyOrAllFlatEntityMapsCacheService>;
- let migrationService: jest.Mocked<WorkspaceMigrationValidateBuildAndRunService>;
- let applicationService: jest.Mocked<ApplicationService>;
-
- const setupCacheReturn = ({
- fieldIds = [],
- customIndexCount = 0,
- }: {
- fieldIds?: {
- id: string;
- universalIdentifier: string;
- name: string;
- type?: FieldMetadataType;
- }[];
- customIndexCount?: number;
- } = {}) => {
- const indexes = Array.from({ length: customIndexCount }).map((_, i) => ({
- id: `idx-${i}`,
- universalIdentifier: `idx-universal-${i}`,
- isCustom: true,
- }));
-
- cacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatObjectMetadataMaps: buildFlatObjectMetadataMaps(),
- flatFieldMetadataMaps: buildFlatFieldMetadataMaps(fieldIds),
- flatIndexMaps: buildFlatIndexMaps(indexes),
- // oxlint-disable-next-line @typescript-eslint/no-explicit-any
- } as any);
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- IndexMetadataService,
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn(),
- invalidateFlatEntityMaps: jest.fn(),
- },
- },
- {
- provide: WorkspaceMigrationValidateBuildAndRunService,
- useValue: {
- validateBuildAndRunWorkspaceMigration: jest
- .fn()
- .mockResolvedValue({ status: 'success' }),
- },
- },
- {
- provide: ApplicationService,
- useValue: {
- findWorkspaceTwentyStandardAndCustomApplicationOrThrow: jest
- .fn()
- .mockResolvedValue({
- workspaceCustomFlatApplication: {
- universalIdentifier: APPLICATION_UNIVERSAL_ID,
- },
- }),
- },
- },
- ],
- }).compile();
-
- service = module.get(IndexMetadataService);
- cacheService = module.get(WorkspaceManyOrAllFlatEntityMapsCacheService);
- migrationService = module.get(WorkspaceMigrationValidateBuildAndRunService);
- applicationService = module.get(ApplicationService);
- });
-
- describe('createOne validation', () => {
- it('rejects empty fields', async () => {
- setupCacheReturn();
-
- await expect(
- service.createOne({
- workspaceId: WORKSPACE_ID,
- createIndexInput: {
- objectMetadataId: OBJECT_ID,
- fields: [],
- indexType: IndexType.BTREE,
- },
- }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.INDEX_FIELDS_REQUIRED,
- });
- });
-
- it('rejects duplicate (fieldMetadataId + subFieldName) pairs', async () => {
- setupCacheReturn();
-
- await expect(
- service.createOne({
- workspaceId: WORKSPACE_ID,
- createIndexInput: {
- objectMetadataId: OBJECT_ID,
- fields: [
- { fieldMetadataId: 'field-1' },
- { fieldMetadataId: 'field-1' },
- ],
- indexType: IndexType.BTREE,
- },
- }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.DUPLICATE_INDEX_FIELDS,
- });
- });
-
- it('rejects when object does not exist', async () => {
- setupCacheReturn();
-
- await expect(
- service.createOne({
- workspaceId: WORKSPACE_ID,
- createIndexInput: {
- objectMetadataId: 'unknown-object',
- fields: [{ fieldMetadataId: 'field-1' }],
- indexType: IndexType.BTREE,
- },
- }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.INDEX_OBJECT_NOT_FOUND,
- });
- });
-
- it('rejects composite-type fields without subFieldName', async () => {
- setupCacheReturn({
- fieldIds: [
- {
- id: 'field-currency',
- universalIdentifier: 'field-currency-universal',
- name: 'annualRevenue',
- type: FieldMetadataType.CURRENCY,
- },
- ],
- });
-
- await expect(
- service.createOne({
- workspaceId: WORKSPACE_ID,
- createIndexInput: {
- objectMetadataId: OBJECT_ID,
- fields: [{ fieldMetadataId: 'field-currency' }],
- indexType: IndexType.BTREE,
- },
- }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.INDEX_NOT_SUPPORTED_FOR_COMPOSITE_FIELD,
- });
-
- expect(
- migrationService.validateBuildAndRunWorkspaceMigration,
- ).not.toHaveBeenCalled();
- });
-
- it('rejects composite-type fields with an unknown subFieldName', async () => {
- setupCacheReturn({
- fieldIds: [
- {
- id: 'field-currency',
- universalIdentifier: 'field-currency-universal',
- name: 'annualRevenue',
- type: FieldMetadataType.CURRENCY,
- },
- ],
- });
-
- await expect(
- service.createOne({
- workspaceId: WORKSPACE_ID,
- createIndexInput: {
- objectMetadataId: OBJECT_ID,
- fields: [
- {
- fieldMetadataId: 'field-currency',
- subFieldName: 'notARealProp',
- },
- ],
- indexType: IndexType.BTREE,
- },
- }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.INDEX_NOT_SUPPORTED_FOR_COMPOSITE_FIELD,
- });
- });
-
- it('rejects subFieldName on a scalar field', async () => {
- setupCacheReturn({
- fieldIds: [
- {
- id: 'field-text',
- universalIdentifier: 'field-text-universal',
- name: 'someText',
- type: FieldMetadataType.TEXT,
- },
- ],
- });
-
- await expect(
- service.createOne({
- workspaceId: WORKSPACE_ID,
- createIndexInput: {
- objectMetadataId: OBJECT_ID,
- fields: [
- { fieldMetadataId: 'field-text', subFieldName: 'whatever' },
- ],
- indexType: IndexType.BTREE,
- },
- }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.INDEX_NOT_SUPPORTED_FOR_COMPOSITE_FIELD,
- });
- });
-
- it('rejects when a field does not belong to the object', async () => {
- setupCacheReturn();
-
- await expect(
- service.createOne({
- workspaceId: WORKSPACE_ID,
- createIndexInput: {
- objectMetadataId: OBJECT_ID,
- fields: [{ fieldMetadataId: 'unknown-field' }],
- indexType: IndexType.BTREE,
- },
- }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.INDEX_FIELD_NOT_FOUND_ON_OBJECT,
- });
- });
-
- it('rejects when custom index count is at the cap', async () => {
- setupCacheReturn({
- fieldIds: [
- {
- id: 'field-1',
- universalIdentifier: 'field-1-universal',
- name: 'someColumn',
- },
- ],
- customIndexCount: MAX_CUSTOM_INDEXES_PER_OBJECT,
- });
-
- await expect(
- service.createOne({
- workspaceId: WORKSPACE_ID,
- createIndexInput: {
- objectMetadataId: OBJECT_ID,
- fields: [{ fieldMetadataId: 'field-1' }],
- indexType: IndexType.BTREE,
- },
- }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.CUSTOM_INDEX_LIMIT_REACHED,
- });
-
- expect(
- applicationService.findWorkspaceTwentyStandardAndCustomApplicationOrThrow,
- ).not.toHaveBeenCalled();
- });
- });
-
- describe('deleteOne validation', () => {
- it('throws INDEX_NOT_FOUND (not the generic flat-entity error) for an unknown id', async () => {
- cacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatIndexMaps: buildFlatIndexMaps([]),
- // oxlint-disable-next-line @typescript-eslint/no-explicit-any
- } as any);
-
- await expect(
- service.deleteOne({ id: 'unknown-idx', workspaceId: WORKSPACE_ID }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.INDEX_NOT_FOUND,
- });
-
- expect(
- migrationService.validateBuildAndRunWorkspaceMigration,
- ).not.toHaveBeenCalled();
- });
-
- it('refuses to delete a system index', async () => {
- cacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatIndexMaps: buildFlatIndexMaps([
- {
- id: 'system-idx',
- universalIdentifier: 'system-idx-universal',
- isCustom: false,
- },
- ]),
- // oxlint-disable-next-line @typescript-eslint/no-explicit-any
- } as any);
-
- await expect(
- service.deleteOne({ id: 'system-idx', workspaceId: WORKSPACE_ID }),
- ).rejects.toMatchObject({
- code: IndexMetadataExceptionCode.CANNOT_DELETE_SYSTEM_INDEX,
- });
-
- expect(
- migrationService.validateBuildAndRunWorkspaceMigration,
- ).not.toHaveBeenCalled();
- });
-
- it('runs the migration when deleting a custom index', async () => {
- cacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatIndexMaps: buildFlatIndexMaps([
- {
- id: 'custom-idx',
- universalIdentifier: 'custom-idx-universal',
- isCustom: true,
- },
- ]),
- // oxlint-disable-next-line @typescript-eslint/no-explicit-any
- } as any);
-
- await service.deleteOne({
- id: 'custom-idx',
- workspaceId: WORKSPACE_ID,
- });
-
- expect(
- migrationService.validateBuildAndRunWorkspaceMigration,
- ).toHaveBeenCalledTimes(1);
- const call =
- migrationService.validateBuildAndRunWorkspaceMigration.mock.calls[0][0];
- expect(
- call.allFlatEntityOperationByMetadataName.index?.flatEntityToDelete,
- ).toHaveLength(1);
- });
- });
-
- it('IndexMetadataException can be thrown', () => {
- expect(
- new IndexMetadataException(
- 'msg',
- IndexMetadataExceptionCode.INDEX_NOT_FOUND,
- ),
- ).toBeInstanceOf(IndexMetadataException);
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-index-view-field-on-create-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-index-view-field-on-create-side-effect-handler.service.spec.ts
deleted file mode 100644
index 646e518bace..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-index-view-field-on-create-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,539 +0,0 @@
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { FieldIndexViewFieldOnCreateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/field-index-view-field-on-create-side-effect-handler.service';
-import {
- buildArgs,
- buildPendingFieldMetadata,
- computeViewFieldUniversalIdentifier,
- DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- filterByView,
- NAME_FIELD,
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- PRIORITY_FIELD,
- PRIORITY_FIELD_UNIVERSAL_IDENTIFIER,
- SYNCED_INDEX_VIEW,
-} from 'src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-view-field-on-create-side-effect-test-setup';
-
-describe('FieldIndexViewFieldOnCreateSideEffectHandlerService', () => {
- const handler =
- new (FieldIndexViewFieldOnCreateSideEffectHandlerService as unknown as new () => FieldIndexViewFieldOnCreateSideEffectHandlerService)();
-
- describe('object created in the same batch (default view assembly)', () => {
- it('should emit a visible view field at position 0 for the label identifier', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: NAME_FIELD,
- pendingFieldMetadatas: [NAME_FIELD, PRIORITY_FIELD],
- objectMetadataCreatedInBatch: true,
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields).toHaveLength(1);
- expect(viewFields[0].universalIdentifier).toBe(
- computeViewFieldUniversalIdentifier({
- viewUniversalIdentifier: DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- }),
- );
- expect(viewFields[0].viewUniversalIdentifier).toBe(
- DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- );
- expect(viewFields[0].position).toBe(0);
- expect(viewFields[0].isVisible).toBe(true);
- expect(viewFields[0].isSystemSideEffect).toBe(true);
- });
-
- it('should position a non-label caller field after the label identifier', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [NAME_FIELD, PRIORITY_FIELD],
- objectMetadataCreatedInBatch: true,
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields).toHaveLength(1);
-
- const [indexViewField] = filterByView(
- viewFields,
- DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- );
-
- expect(indexViewField.position).toBe(1);
- });
-
- it('should still emit when the pending INDEX view is a system side effect (object handler emission)', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: NAME_FIELD,
- pendingFieldMetadatas: [NAME_FIELD],
- objectMetadataCreatedInBatch: true,
- pendingViews: [
- {
- universalIdentifier: DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
- });
-
- // The engine owns the INDEX view, so the handler no longer defers to a
- // caller-provided one: it emits and lets the engine collision on the view
- // surface the conflict.
- it('should still emit when the caller provides the pending INDEX view (no override)', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: NAME_FIELD,
- pendingFieldMetadatas: [NAME_FIELD],
- objectMetadataCreatedInBatch: true,
- pendingViews: [
- {
- universalIdentifier: DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: false,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
- });
-
- // Parity with the existing-object path: a relation created in the same
- // batch as its object gets a visible INDEX view field too, otherwise the
- // same manifest yields different views depending on whether the object
- // pre-existed (twentyhq/core-team-issues#2749).
- it.each([
- ['relation', FieldMetadataType.RELATION],
- ['morph relation', FieldMetadataType.MORPH_RELATION],
- ])(
- 'should emit a visible view field for a %s field created in the same batch as its object',
- (_label, fieldMetadataType) => {
- const relationField = buildPendingFieldMetadata(
- 'assignee',
- fieldMetadataType,
- );
-
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: relationField,
- pendingFieldMetadatas: [NAME_FIELD, relationField],
- objectMetadataCreatedInBatch: true,
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields).toHaveLength(1);
- expect(viewFields[0].universalIdentifier).toBe(
- computeViewFieldUniversalIdentifier({
- viewUniversalIdentifier: DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier: relationField.universalIdentifier,
- }),
- );
- expect(viewFields[0].viewUniversalIdentifier).toBe(
- DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- );
- expect(viewFields[0].position).toBe(1);
- expect(viewFields[0].isVisible).toBe(true);
- expect(viewFields[0].isSystemSideEffect).toBe(true);
- },
- );
- });
-
- describe('field created on an existing object (historical createOneField behavior)', () => {
- it('should append a visible view field to the INDEX view resolved by its derived identifier', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW],
- viewFieldsInWorkspace: [
- {
- universalIdentifier: 'existing-vf-1',
- viewId: SYNCED_INDEX_VIEW.id,
- position: 0,
- isActive: true,
- },
- {
- universalIdentifier: 'existing-vf-2',
- viewId: SYNCED_INDEX_VIEW.id,
- position: 4,
- isActive: true,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields).toHaveLength(1);
- expect(viewFields[0].universalIdentifier).toBe(
- computeViewFieldUniversalIdentifier({
- viewUniversalIdentifier: SYNCED_INDEX_VIEW.universalIdentifier,
- fieldMetadataUniversalIdentifier: PRIORITY_FIELD_UNIVERSAL_IDENTIFIER,
- }),
- );
- expect(viewFields[0].viewUniversalIdentifier).toBe(
- SYNCED_INDEX_VIEW.universalIdentifier,
- );
- expect(viewFields[0].position).toBe(5);
- expect(viewFields[0].isVisible).toBe(true);
- expect(viewFields[0].isSystemSideEffect).toBe(true);
- });
-
- it('should ignore soft-deleted view fields when computing the append position', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW],
- viewFieldsInWorkspace: [
- {
- universalIdentifier: 'existing-vf-1',
- viewId: SYNCED_INDEX_VIEW.id,
- position: 0,
- isActive: true,
- },
- // A removed column: still in the flat maps but soft-deleted, its
- // position must not inflate the append position.
- {
- universalIdentifier: 'soft-deleted-vf',
- viewId: SYNCED_INDEX_VIEW.id,
- position: 9,
- isActive: true,
- deletedAt: '2024-01-01T00:00:00.000Z',
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields).toHaveLength(1);
- expect(viewFields[0].position).toBe(1);
- });
-
- it('should place the label identifier view field strictly below every existing one', () => {
- // Relabeling onto a field created in the same sync: existing positions
- // start above zero, the label lands one below the lowest.
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: NAME_FIELD,
- pendingFieldMetadatas: [NAME_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW],
- viewFieldsInWorkspace: [
- {
- universalIdentifier: 'existing-vf-1',
- viewId: SYNCED_INDEX_VIEW.id,
- position: 2,
- isActive: true,
- },
- {
- universalIdentifier: 'existing-vf-2',
- viewId: SYNCED_INDEX_VIEW.id,
- position: 5,
- isActive: true,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields).toHaveLength(1);
- expect(viewFields[0].isVisible).toBe(true);
- expect(viewFields[0].position).toBe(1);
- });
-
- it('should place the label identifier view field at position 0 on an empty INDEX view', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: NAME_FIELD,
- pendingFieldMetadatas: [NAME_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields).toHaveLength(1);
- expect(viewFields[0].isVisible).toBe(true);
- expect(viewFields[0].position).toBe(0);
- });
-
- it('should emit a visible view field for a relation field', () => {
- const relationField = buildPendingFieldMetadata(
- 'assignee',
- FieldMetadataType.RELATION,
- );
-
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: relationField,
- pendingFieldMetadatas: [relationField],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields).toHaveLength(1);
- expect(viewFields[0].isVisible).toBe(true);
- });
-
- // The emitted view field is engine-owned whatever the view provenance, so
- // manifest sync deletion inference never drops it.
- it('should emit an isSystemSideEffect view field on a manifest-owned INDEX view', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [
- { ...SYNCED_INDEX_VIEW, isSystemSideEffect: false },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields[0].isSystemSideEffect).toBe(true);
- });
-
- // View field groups only ever exist on record-page views, never on an INDEX
- // view, so the appended view field is always ungrouped.
- it('should emit an ungrouped view field', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {})[0]
- .viewFieldGroupUniversalIdentifier,
- ).toBeNull();
- });
-
- it('should noop when an INDEX view exists but not under its derived identifier (unreconciled workspace)', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [
- {
- ...SYNCED_INDEX_VIEW,
- universalIdentifier: 'c1c2c3c4-c5c6-4000-8000-000000000042',
- },
- ],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should emit a view field on a deactivated INDEX view', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [
- { ...SYNCED_INDEX_VIEW, isActive: false },
- {
- id: 'other-view-db-id',
- universalIdentifier: 'other-view-uid',
- key: null,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(viewFields).toHaveLength(1);
- expect(viewFields[0].viewUniversalIdentifier).toBe(
- DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- );
- expect(viewFields[0].isVisible).toBe(true);
- });
- });
-
- it('should not count engine-owned fields when positioning caller view fields', () => {
- const searchVectorField = buildPendingFieldMetadata(
- 'searchVector',
- FieldMetadataType.TS_VECTOR,
- true,
- );
-
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- // searchVector sits in the expanded matrix (emitted by a peer handler)
- // but must not shift the caller field positions.
- pendingFieldMetadatas: [NAME_FIELD, searchVectorField, PRIORITY_FIELD],
- objectMetadataCreatedInBatch: true,
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const [indexViewField] = filterByView(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {}),
- DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- );
-
- expect(indexViewField.position).toBe(1);
- });
-
- // A second writer claiming the same INDEX (view, field) pair is not deduped:
- // it is a genuine conflict left to surface downstream (engine collision, then
- // the flat view field validator on the pair). Record-page pairs ARE deduped.
- it('should still emit when a pending view field already covers the same INDEX (view, field) pair', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW],
- pendingViewFields: [
- {
- // e.g. emitted caller-side for a FIELDS widget targeting the view
- universalIdentifier: 'random-caller-vf-uid',
- viewUniversalIdentifier: SYNCED_INDEX_VIEW.universalIdentifier,
- fieldMetadataUniversalIdentifier:
- PRIORITY_FIELD_UNIVERSAL_IDENTIFIER,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {})[0]
- .fieldMetadataUniversalIdentifier,
- ).toBe(PRIORITY_FIELD_UNIVERSAL_IDENTIFIER);
- });
-
- it('should fail when the parent object cannot be resolved', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: NAME_FIELD,
- pendingFieldMetadatas: [NAME_FIELD],
- }),
- );
-
- expect(result.status).toBe('fail');
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-record-page-view-field-on-create-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-record-page-view-field-on-create-side-effect-handler.service.spec.ts
deleted file mode 100644
index 3c221679d12..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-record-page-view-field-on-create-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,319 +0,0 @@
-import { ViewType } from 'twenty-shared/types';
-
-import { FieldRecordPageViewFieldOnCreateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/field-record-page-view-field-on-create-side-effect-handler.service';
-import {
- buildArgs,
- computeViewFieldUniversalIdentifier,
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- filterByView,
- NAME_FIELD,
- OBJECT_UNIVERSAL_IDENTIFIER,
- PRIORITY_FIELD,
- PRIORITY_FIELD_UNIVERSAL_IDENTIFIER,
- SYNCED_FIELDS_WIDGET,
- SYNCED_INDEX_VIEW,
- SYNCED_RECORD_PAGE_VIEW,
-} from 'src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-view-field-on-create-side-effect-test-setup';
-
-describe('FieldRecordPageViewFieldOnCreateSideEffectHandlerService', () => {
- const handler =
- new (FieldRecordPageViewFieldOnCreateSideEffectHandlerService as unknown as new () => FieldRecordPageViewFieldOnCreateSideEffectHandlerService)();
-
- it('should fail when the parent object cannot be resolved', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: NAME_FIELD,
- pendingFieldMetadatas: [NAME_FIELD],
- }),
- );
-
- expect(result.status).toBe('fail');
- });
-
- describe('record-page view field emission', () => {
- it('should emit a record-page view field with the derived identifier on same-batch creation', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [NAME_FIELD, PRIORITY_FIELD],
- objectMetadataCreatedInBatch: true,
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const [recordPageViewField] = filterByView(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {}),
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- );
-
- expect(recordPageViewField).toMatchObject({
- universalIdentifier: computeViewFieldUniversalIdentifier({
- viewUniversalIdentifier:
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier: PRIORITY_FIELD_UNIVERSAL_IDENTIFIER,
- }),
- // The label identifier is excluded, so priority is first.
- position: 0,
- isVisible: true,
- isSystemSideEffect: true,
- viewFieldGroupUniversalIdentifier: null,
- });
- });
-
- // The engine always produces its system side effects: a caller-pending
- // view field for the same pair is a conflict the pair-uniqueness validator
- // surfaces to the caller, not something the engine yields to.
- it('should still emit when a pending view field already covers the same record-page (view, field) pair', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [NAME_FIELD, PRIORITY_FIELD],
- objectMetadataCreatedInBatch: true,
- pendingViewFields: [
- {
- universalIdentifier: 'caller-authored-record-page-vf-uid',
- viewUniversalIdentifier:
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- PRIORITY_FIELD_UNIVERSAL_IDENTIFIER,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const recordPageViewFields = filterByView(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {}),
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- );
-
- expect(recordPageViewFields).toHaveLength(1);
- expect(recordPageViewFields[0].universalIdentifier).toBe(
- computeViewFieldUniversalIdentifier({
- viewUniversalIdentifier:
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier: PRIORITY_FIELD_UNIVERSAL_IDENTIFIER,
- }),
- );
- });
-
- it('should not emit a record-page view field for the label identifier', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: NAME_FIELD,
- pendingFieldMetadatas: [NAME_FIELD, PRIORITY_FIELD],
- objectMetadataCreatedInBatch: true,
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- // Caller-defined custom record pages coexist with the system stack: the
- // engine still emits its record-page view field.
- it('should still emit a record-page view field when the batch carries a caller-authored record-page stack', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [NAME_FIELD, PRIORITY_FIELD],
- objectMetadataCreatedInBatch: true,
- pendingViews: [
- {
- universalIdentifier: 'app-authored-record-page-view-uid',
- isSystemSideEffect: false,
- type: ViewType.FIELDS_WIDGET,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- filterByView(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {}),
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- ),
- ).toHaveLength(1);
- });
-
- it('should follow the FIELDS widget visibility and append after existing view fields on an existing object', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW, SYNCED_RECORD_PAGE_VIEW],
- viewFieldsInWorkspace: [
- {
- universalIdentifier: 'existing-record-page-vf',
- viewId: SYNCED_RECORD_PAGE_VIEW.id,
- position: 3,
- isActive: true,
- },
- ],
- fieldsWidgetsInWorkspace: [
- {
- ...SYNCED_FIELDS_WIDGET,
- universalConfiguration: {
- ...SYNCED_FIELDS_WIDGET.universalConfiguration,
- newFieldDefaultVisibility: false,
- },
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const [recordPageViewField] = filterByView(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {}),
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- );
-
- expect(recordPageViewField).toMatchObject({
- isVisible: false,
- position: 4,
- isSystemSideEffect: true,
- viewFieldGroupUniversalIdentifier: null,
- });
- });
-
- it('should append into the last active view field group', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [
- SYNCED_INDEX_VIEW,
- {
- ...SYNCED_RECORD_PAGE_VIEW,
- viewFieldGroupUniversalIdentifiers: [
- 'group-uid-1',
- 'group-uid-2',
- ],
- },
- ],
- viewFieldsInWorkspace: [
- {
- universalIdentifier: 'grouped-vf',
- viewId: SYNCED_RECORD_PAGE_VIEW.id,
- viewFieldGroupUniversalIdentifier: 'group-uid-2',
- position: 7,
- isActive: true,
- },
- {
- universalIdentifier: 'ungrouped-vf',
- viewId: SYNCED_RECORD_PAGE_VIEW.id,
- position: 11,
- isActive: true,
- },
- ],
- viewFieldGroupsInWorkspace: [
- { universalIdentifier: 'group-uid-1', position: 0 },
- { universalIdentifier: 'group-uid-2', position: 1 },
- ],
- fieldsWidgetsInWorkspace: [SYNCED_FIELDS_WIDGET],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const [recordPageViewField] = filterByView(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {}),
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- );
-
- expect(recordPageViewField).toMatchObject({
- viewFieldGroupUniversalIdentifier: 'group-uid-2',
- position: 8,
- });
- });
-
- it('should not emit when no active FIELDS widget references the engine record-page view', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW, SYNCED_RECORD_PAGE_VIEW],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should not emit when the widget does not declare newFieldDefaultVisibility', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW, SYNCED_RECORD_PAGE_VIEW],
- fieldsWidgetsInWorkspace: [
- {
- ...SYNCED_FIELDS_WIDGET,
- universalConfiguration: {
- configurationType: 'FIELDS',
- viewUniversalIdentifier:
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- newFieldDefaultVisibility: null,
- },
- },
- ],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should not emit when the (view, field) pair is already synced whatever its identifier', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- triggerFieldMetadata: PRIORITY_FIELD,
- pendingFieldMetadatas: [PRIORITY_FIELD],
- objectMetadataInWorkspace: true,
- viewsInWorkspace: [SYNCED_INDEX_VIEW, SYNCED_RECORD_PAGE_VIEW],
- viewFieldsInWorkspace: [
- {
- // Underived incremental-path row for the same pair.
- universalIdentifier: 'legacy-v4-view-field-uid',
- viewId: SYNCED_RECORD_PAGE_VIEW.id,
- fieldMetadataUniversalIdentifier:
- PRIORITY_FIELD_UNIVERSAL_IDENTIFIER,
- position: 0,
- isActive: true,
- },
- ],
- fieldsWidgetsInWorkspace: [SYNCED_FIELDS_WIDGET],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-search-field-metadata-on-delete-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-search-field-metadata-on-delete-side-effect-handler.service.spec.ts
deleted file mode 100644
index a773f1251c5..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-search-field-metadata-on-delete-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,102 +0,0 @@
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-import { FieldSearchFieldMetadataOnDeleteSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/field-search-field-metadata-on-delete-side-effect-handler.service';
-
-const DELETED_FIELD_UNIVERSAL_IDENTIFIER =
- 'd1d2d3d4-d5d6-4000-8000-000000000001';
-const OTHER_FIELD_UNIVERSAL_IDENTIFIER = 'd1d2d3d4-d5d6-4000-8000-000000000002';
-const SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER =
- 'f1f2f3f4-f5f6-4000-8000-000000000001';
-const OTHER_SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER =
- 'f1f2f3f4-f5f6-4000-8000-000000000002';
-
-const buildArgs = ({
- searchFieldMetadataUniversalIdentifiers,
- relatedFlatEntityMaps,
-}: {
- searchFieldMetadataUniversalIdentifiers: string[];
- relatedFlatEntityMaps: object;
-}): BuildSideEffectsArgs<'fieldMetadata'> =>
- ({
- flatEntity: {
- universalIdentifier: DELETED_FIELD_UNIVERSAL_IDENTIFIER,
- searchFieldMetadataUniversalIdentifiers,
- },
- allFlatEntityOperationRecordByMetadataName: {},
- relatedFlatEntityMaps,
- context: {},
- }) as unknown as BuildSideEffectsArgs<'fieldMetadata'>;
-
-describe('FieldSearchFieldMetadataOnDeleteSideEffectHandlerService', () => {
- const handler =
- new (FieldSearchFieldMetadataOnDeleteSideEffectHandlerService as unknown as new () => FieldSearchFieldMetadataOnDeleteSideEffectHandlerService)();
-
- it('should cascade-delete every searchFieldMetadata row indexing the deleted field', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- searchFieldMetadataUniversalIdentifiers: [
- SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER,
- ],
- relatedFlatEntityMaps: {
- flatSearchFieldMetadataMaps: {
- byUniversalIdentifier: {
- [SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- DELETED_FIELD_UNIVERSAL_IDENTIFIER,
- },
- },
- },
- },
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.keys(
- result.operations.searchFieldMetadata?.flatEntityToDelete ?? {},
- ),
- ).toEqual([SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER]);
- });
-
- it('should not delete searchFieldMetadata rows indexing a different field', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- searchFieldMetadataUniversalIdentifiers: [],
- relatedFlatEntityMaps: {
- flatSearchFieldMetadataMaps: {
- byUniversalIdentifier: {
- [OTHER_SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier:
- OTHER_SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- OTHER_FIELD_UNIVERSAL_IDENTIFIER,
- },
- },
- },
- },
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should be a noop when the workspace has no searchFieldMetadata rows', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- searchFieldMetadataUniversalIdentifiers: [
- SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER,
- ],
- relatedFlatEntityMaps: {
- flatSearchFieldMetadataMaps: { byUniversalIdentifier: {} },
- },
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-system-view-fields-on-delete-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-system-view-fields-on-delete-side-effect-handler.service.spec.ts
deleted file mode 100644
index 91e00364bcd..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-system-view-fields-on-delete-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,102 +0,0 @@
-import { FieldSystemViewFieldsOnDeleteSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/field-system-view-fields-on-delete-side-effect-handler.service';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-
-const DELETED_FIELD_UNIVERSAL_IDENTIFIER =
- 'd1d2d3d4-d5d6-4000-8000-000000000001';
-const SYSTEM_VIEW_FIELD_UNIVERSAL_IDENTIFIER =
- 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const CALLER_VIEW_FIELD_UNIVERSAL_IDENTIFIER =
- 'a1a2a3a4-a5a6-4000-8000-000000000002';
-
-const buildArgs = ({
- viewFieldUniversalIdentifiers,
- viewFieldsInWorkspace = [],
-}: {
- viewFieldUniversalIdentifiers: string[];
- viewFieldsInWorkspace?: {
- universalIdentifier: string;
- isSystemSideEffect: boolean;
- }[];
-}): BuildSideEffectsArgs<'fieldMetadata'> =>
- ({
- flatEntity: {
- universalIdentifier: DELETED_FIELD_UNIVERSAL_IDENTIFIER,
- viewFieldUniversalIdentifiers,
- },
- allFlatEntityOperationRecordByMetadataName: {},
- relatedFlatEntityMaps: {
- flatViewFieldMaps: {
- byUniversalIdentifier: Object.fromEntries(
- viewFieldsInWorkspace.map((viewField) => [
- viewField.universalIdentifier,
- {
- ...viewField,
- fieldMetadataUniversalIdentifier:
- DELETED_FIELD_UNIVERSAL_IDENTIFIER,
- },
- ]),
- ),
- },
- },
- context: {},
- }) as unknown as BuildSideEffectsArgs<'fieldMetadata'>;
-
-describe('FieldSystemViewFieldsOnDeleteSideEffectHandlerService', () => {
- const handler =
- new (FieldSystemViewFieldsOnDeleteSideEffectHandlerService as unknown as new () => FieldSystemViewFieldsOnDeleteSideEffectHandlerService)();
-
- it('should cascade-delete every engine-owned view field displaying the deleted field', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- viewFieldUniversalIdentifiers: [
- SYSTEM_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- CALLER_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- ],
- viewFieldsInWorkspace: [
- {
- universalIdentifier: SYSTEM_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- },
- {
- universalIdentifier: CALLER_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: false,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.keys(result.operations.viewField?.flatEntityToDelete ?? {}),
- ).toEqual([SYSTEM_VIEW_FIELD_UNIVERSAL_IDENTIFIER]);
- });
-
- it('should noop when the field only has caller-owned view fields', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- viewFieldUniversalIdentifiers: [CALLER_VIEW_FIELD_UNIVERSAL_IDENTIFIER],
- viewFieldsInWorkspace: [
- {
- universalIdentifier: CALLER_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: false,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should noop when the field has no view field', () => {
- const result = handler.buildSideEffects(
- buildArgs({ viewFieldUniversalIdentifiers: [] }),
- );
-
- expect(result.status).toBe('noop');
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-view-field-on-create-side-effect-test-setup.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-view-field-on-create-side-effect-test-setup.ts
deleted file mode 100644
index 5e918ed64a3..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/field-metadata/services/__tests__/field-view-field-on-create-side-effect-test-setup.ts
+++ /dev/null
@@ -1,296 +0,0 @@
-import {
- SYSTEM_VIEW_KEYS,
- getFieldUniversalIdentifier,
- getSystemViewFieldUniversalIdentifier,
- getSystemViewUniversalIdentifier,
-} from 'twenty-shared/application';
-import { FieldMetadataType, ViewKey, ViewType } from 'twenty-shared/types';
-
-import { type AllFlatEntityOperationRecordByMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-operation-record-by-metadata-name.type';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-
-export const APPLICATION_UNIVERSAL_IDENTIFIER =
- 'a1a2a3a4-a5a6-4000-8000-000000000001';
-export const OBJECT_UNIVERSAL_IDENTIFIER =
- 'b1b2b3b4-b5b6-4000-8000-000000000001';
-
-export const computeFieldUniversalIdentifier = (name: string) =>
- getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name,
- });
-
-export const NAME_FIELD_UNIVERSAL_IDENTIFIER =
- computeFieldUniversalIdentifier('name');
-export const PRIORITY_FIELD_UNIVERSAL_IDENTIFIER =
- computeFieldUniversalIdentifier('priority');
-
-export const DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER =
- getSystemViewUniversalIdentifier({
- objectMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- viewKey: SYSTEM_VIEW_KEYS.INDEX,
- });
-
-export const DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER =
- getSystemViewUniversalIdentifier({
- objectMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- viewKey: SYSTEM_VIEW_KEYS.FIELDS_WIDGET,
- });
-
-export const computeViewFieldUniversalIdentifier = ({
- viewUniversalIdentifier,
- fieldMetadataUniversalIdentifier,
-}: {
- viewUniversalIdentifier: string;
- fieldMetadataUniversalIdentifier: string;
-}) =>
- getSystemViewFieldUniversalIdentifier({
- fieldMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- viewUniversalIdentifier,
- fieldMetadataUniversalIdentifier,
- });
-
-export type PendingFieldMetadata = {
- universalIdentifier: string;
- objectMetadataUniversalIdentifier: string;
- applicationUniversalIdentifier: string;
- name: string;
- type: FieldMetadataType;
- isSystemSideEffect: boolean;
-};
-
-export const buildPendingFieldMetadata = (
- name: string,
- type: FieldMetadataType = FieldMetadataType.TEXT,
- isSystemSideEffect = false,
-): PendingFieldMetadata => ({
- universalIdentifier: computeFieldUniversalIdentifier(name),
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- name,
- type,
- isSystemSideEffect,
-});
-
-export const NAME_FIELD = buildPendingFieldMetadata('name');
-export const PRIORITY_FIELD = buildPendingFieldMetadata(
- 'priority',
- FieldMetadataType.NUMBER,
-);
-
-export const OBJECT_METADATA = {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- nameSingular: 'ticket',
- labelIdentifierFieldMetadataUniversalIdentifier:
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
-};
-
-export type WorkspaceView = {
- id: string;
- universalIdentifier: string;
- key: ViewKey | null;
- type?: ViewType;
- isActive?: boolean;
- deletedAt?: string | null;
- isSystemSideEffect?: boolean;
- objectMetadataUniversalIdentifier?: string;
- viewFieldGroupUniversalIdentifiers?: string[];
-};
-
-export type WorkspaceViewField = {
- universalIdentifier: string;
- viewId: string;
- viewUniversalIdentifier?: string;
- fieldMetadataUniversalIdentifier?: string;
- viewFieldGroupUniversalIdentifier?: string | null;
- position: number;
- isActive: boolean;
- deletedAt?: string | null;
-};
-
-export type WorkspaceFieldsWidget = {
- universalIdentifier: string;
- isActive?: boolean;
- deletedAt?: string | null;
- universalConfiguration: {
- configurationType: string;
- viewUniversalIdentifier?: string | null;
- newFieldDefaultVisibility?: boolean | null;
- };
-};
-
-export type WorkspaceViewFieldGroup = {
- universalIdentifier: string;
- position: number;
- isActive?: boolean;
- deletedAt?: string | null;
-};
-
-export const buildArgs = ({
- triggerFieldMetadata,
- pendingFieldMetadatas = [],
- objectMetadataCreatedInBatch = false,
- pendingViews = [],
- pendingViewFields = [],
- objectMetadataInWorkspace = false,
- viewsInWorkspace = [],
- viewFieldsInWorkspace = [],
- fieldsWidgetsInWorkspace = [],
- viewFieldGroupsInWorkspace = [],
-}: {
- triggerFieldMetadata: PendingFieldMetadata;
- pendingFieldMetadatas?: PendingFieldMetadata[];
- objectMetadataCreatedInBatch?: boolean;
- pendingViews?: {
- universalIdentifier: string;
- isSystemSideEffect: boolean;
- type?: ViewType;
- objectMetadataUniversalIdentifier?: string;
- }[];
- pendingViewFields?: {
- universalIdentifier: string;
- viewUniversalIdentifier: string;
- fieldMetadataUniversalIdentifier: string;
- }[];
- objectMetadataInWorkspace?: boolean;
- viewsInWorkspace?: WorkspaceView[];
- viewFieldsInWorkspace?: WorkspaceViewField[];
- fieldsWidgetsInWorkspace?: WorkspaceFieldsWidget[];
- viewFieldGroupsInWorkspace?: WorkspaceViewFieldGroup[];
-}): BuildSideEffectsArgs<'fieldMetadata'> =>
- ({
- flatEntity: triggerFieldMetadata,
- allFlatEntityOperationRecordByMetadataName: {
- fieldMetadata: {
- flatEntityToCreate: Object.fromEntries(
- pendingFieldMetadatas.map((pendingFieldMetadata) => [
- pendingFieldMetadata.universalIdentifier,
- pendingFieldMetadata,
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- objectMetadata: {
- flatEntityToCreate: objectMetadataCreatedInBatch
- ? { [OBJECT_UNIVERSAL_IDENTIFIER]: OBJECT_METADATA }
- : {},
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- view: {
- flatEntityToCreate: Object.fromEntries(
- pendingViews.map((pendingView) => [
- pendingView.universalIdentifier,
- pendingView,
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- viewField: {
- flatEntityToCreate: Object.fromEntries(
- pendingViewFields.map((pendingViewField) => [
- pendingViewField.universalIdentifier,
- pendingViewField,
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- } as unknown as AllFlatEntityOperationRecordByMetadataName,
- relatedFlatEntityMaps: {
- flatObjectMetadataMaps: {
- byUniversalIdentifier: objectMetadataInWorkspace
- ? { [OBJECT_UNIVERSAL_IDENTIFIER]: OBJECT_METADATA }
- : {},
- },
- flatViewMaps: {
- byUniversalIdentifier: Object.fromEntries(
- viewsInWorkspace.map((view) => [
- view.universalIdentifier,
- {
- isActive: true,
- deletedAt: null,
- isSystemSideEffect: false,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- viewFieldGroupUniversalIdentifiers: [],
- ...view,
- // Mirrors fromViewEntityToFlatView: the view aggregates the
- // view fields pointing at it.
- viewFieldUniversalIdentifiers: viewFieldsInWorkspace
- .filter((viewField) => viewField.viewId === view.id)
- .map((viewField) => viewField.universalIdentifier),
- },
- ]),
- ),
- },
- flatViewFieldMaps: {
- byUniversalIdentifier: Object.fromEntries(
- viewFieldsInWorkspace.map((viewField) => [
- viewField.universalIdentifier,
- { viewFieldGroupUniversalIdentifier: null, ...viewField },
- ]),
- ),
- },
- flatViewFieldGroupMaps: {
- byUniversalIdentifier: Object.fromEntries(
- viewFieldGroupsInWorkspace.map((viewFieldGroup) => [
- viewFieldGroup.universalIdentifier,
- { isActive: true, deletedAt: null, ...viewFieldGroup },
- ]),
- ),
- },
- flatPageLayoutWidgetMaps: {
- byUniversalIdentifier: Object.fromEntries(
- fieldsWidgetsInWorkspace.map((fieldsWidget) => [
- fieldsWidget.universalIdentifier,
- { isActive: true, deletedAt: null, ...fieldsWidget },
- ]),
- ),
- },
- },
- context: {},
- }) as unknown as BuildSideEffectsArgs<'fieldMetadata'>;
-
-// Synced INDEX view: the 2-26 reconcile command re-owns every INDEX view to the
-// derived identifier, so the handler resolves it by that identifier alone.
-export const SYNCED_INDEX_VIEW: WorkspaceView = {
- id: 'view-db-id-1',
- universalIdentifier: DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- key: ViewKey.INDEX,
- isSystemSideEffect: true,
-};
-
-export const SYNCED_RECORD_PAGE_VIEW: WorkspaceView = {
- id: 'view-db-id-2',
- universalIdentifier: DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- key: null,
- type: ViewType.FIELDS_WIDGET,
- isSystemSideEffect: true,
-};
-
-export const SYNCED_FIELDS_WIDGET: WorkspaceFieldsWidget = {
- universalIdentifier: 'widget-uid-1',
- universalConfiguration: {
- configurationType: 'FIELDS',
- viewUniversalIdentifier: DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- newFieldDefaultVisibility: true,
- },
-};
-
-export const filterByView = <T extends { viewUniversalIdentifier: string }>(
- viewFields: T[],
- viewUniversalIdentifier: string,
-): T[] =>
- viewFields.filter(
- (viewField) =>
- viewField.viewUniversalIdentifier === viewUniversalIdentifier,
- );
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-index-view-label-identifier-on-update-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-index-view-label-identifier-on-update-side-effect-handler.service.spec.ts
deleted file mode 100644
index 075690cd424..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-index-view-label-identifier-on-update-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,163 +0,0 @@
-import {
- SYSTEM_VIEW_KEYS,
- getSystemViewUniversalIdentifier,
-} from 'twenty-shared/application';
-
-import { ObjectIndexViewLabelIdentifierOnUpdateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-index-view-label-identifier-on-update-side-effect-handler.service';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-
-const APPLICATION_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-const NAME_FIELD_UNIVERSAL_IDENTIFIER = 'd1d2d3d4-d5d6-4000-8000-000000000001';
-const CODE_FIELD_UNIVERSAL_IDENTIFIER = 'd1d2d3d4-d5d6-4000-8000-000000000002';
-
-const INDEX_VIEW_UNIVERSAL_IDENTIFIER = getSystemViewUniversalIdentifier({
- objectMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- viewKey: SYSTEM_VIEW_KEYS.INDEX,
-});
-
-const NAME_VIEW_FIELD_UNIVERSAL_IDENTIFIER =
- 'e1e2e3e4-e5e6-4000-8000-000000000001';
-const CODE_VIEW_FIELD_UNIVERSAL_IDENTIFIER =
- 'e1e2e3e4-e5e6-4000-8000-000000000002';
-
-const buildArgs = ({
- fromLabelIdentifier,
- toLabelIdentifier,
- viewFieldsInWorkspace = [],
-}: {
- fromLabelIdentifier: string | null;
- toLabelIdentifier: string | null;
- viewFieldsInWorkspace?: {
- universalIdentifier: string;
- fieldMetadataUniversalIdentifier: string;
- position: number;
- isVisible: boolean;
- }[];
-}): BuildSideEffectsArgs<'objectMetadata'> =>
- ({
- flatEntity: {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- labelIdentifierFieldMetadataUniversalIdentifier: toLabelIdentifier,
- },
- allFlatEntityOperationRecordByMetadataName: {},
- relatedFlatEntityMaps: {
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- [OBJECT_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- labelIdentifierFieldMetadataUniversalIdentifier:
- fromLabelIdentifier,
- },
- },
- },
- flatViewMaps: {
- byUniversalIdentifier: {
- [INDEX_VIEW_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- isActive: true,
- deletedAt: null,
- viewFieldUniversalIdentifiers: viewFieldsInWorkspace.map(
- (viewField) => viewField.universalIdentifier,
- ),
- },
- },
- },
- flatViewFieldMaps: {
- byUniversalIdentifier: Object.fromEntries(
- viewFieldsInWorkspace.map((viewField) => [
- viewField.universalIdentifier,
- {
- isActive: true,
- deletedAt: null,
- isSystemSideEffect: true,
- ...viewField,
- },
- ]),
- ),
- },
- },
- context: {},
- }) as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-
-const SYNCED_VIEW_FIELDS = [
- {
- universalIdentifier: NAME_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- position: 0,
- isVisible: true,
- },
- {
- universalIdentifier: CODE_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier: CODE_FIELD_UNIVERSAL_IDENTIFIER,
- position: 5,
- isVisible: false,
- },
-];
-
-describe('ObjectIndexViewLabelIdentifierOnUpdateSideEffectHandlerService', () => {
- const handler =
- new (ObjectIndexViewLabelIdentifierOnUpdateSideEffectHandlerService as unknown as new () => ObjectIndexViewLabelIdentifierOnUpdateSideEffectHandlerService)();
-
- it('should move the new label identifier view field below the lowest and make it visible', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: CODE_FIELD_UNIVERSAL_IDENTIFIER,
- viewFieldsInWorkspace: SYNCED_VIEW_FIELDS,
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const updatedCodeViewField = (result.operations.viewField
- ?.flatEntityToUpdate ?? {})[CODE_VIEW_FIELD_UNIVERSAL_IDENTIFIER];
-
- expect(updatedCodeViewField?.position).toBe(-1);
- expect(updatedCodeViewField?.isVisible).toBe(true);
- });
-
- it('should noop when the label identifier is unchanged', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- viewFieldsInWorkspace: SYNCED_VIEW_FIELDS,
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should noop when the new label identifier view field is already visible and strictly lowest', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: CODE_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- viewFieldsInWorkspace: SYNCED_VIEW_FIELDS,
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should noop when the new label identifier has no synced INDEX view field (created in the same sync)', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: CODE_FIELD_UNIVERSAL_IDENTIFIER,
- viewFieldsInWorkspace: [SYNCED_VIEW_FIELDS[0]],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-index-view-on-create-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-index-view-on-create-side-effect-handler.service.spec.ts
deleted file mode 100644
index 66a8897476b..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-index-view-on-create-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,295 +0,0 @@
-import {
- SYSTEM_VIEW_KEYS,
- getFieldUniversalIdentifier,
- getSystemViewFieldUniversalIdentifier,
- getSystemViewUniversalIdentifier,
-} from 'twenty-shared/application';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { type AllFlatEntityOperationRecordByMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-operation-record-by-metadata-name.type';
-import { ObjectIndexViewOnCreateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-index-view-on-create-side-effect-handler.service';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-
-const APPLICATION_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-const OTHER_OBJECT_UNIVERSAL_IDENTIFIER =
- 'b1b2b3b4-b5b6-4000-8000-000000000002';
-
-const computeFieldUniversalIdentifier = (name: string) =>
- getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name,
- });
-
-const NAME_FIELD_UNIVERSAL_IDENTIFIER = computeFieldUniversalIdentifier('name');
-// The subset of system fields the INDEX view displays: id/deletedAt/position are
-// filtered out by the view-field builder.
-const DISPLAYABLE_SYSTEM_FIELD_NAMES = [
- 'createdAt',
- 'updatedAt',
- 'createdBy',
- 'updatedBy',
-] as const;
-
-const DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER =
- getSystemViewUniversalIdentifier({
- objectMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- viewKey: SYSTEM_VIEW_KEYS.INDEX,
- });
-
-type PendingFieldMetadata = {
- universalIdentifier: string;
- objectMetadataUniversalIdentifier: string;
- name: string;
- type: FieldMetadataType;
-};
-
-const NAME_FIELD: PendingFieldMetadata = {
- universalIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'name',
- type: FieldMetadataType.TEXT,
-};
-
-const buildArgs = ({
- labelIdentifierFieldMetadataUniversalIdentifier = NAME_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas = [],
- pendingViewUniversalIdentifiers = [],
-}: {
- labelIdentifierFieldMetadataUniversalIdentifier?: string | null;
- pendingFieldMetadatas?: PendingFieldMetadata[];
- pendingViewUniversalIdentifiers?: string[];
-}): BuildSideEffectsArgs<'objectMetadata'> =>
- ({
- flatEntity: {
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- nameSingular: 'ticket',
- labelIdentifierFieldMetadataUniversalIdentifier,
- },
- allFlatEntityOperationRecordByMetadataName: {
- fieldMetadata: {
- flatEntityToCreate: Object.fromEntries(
- pendingFieldMetadatas.map((pendingFieldMetadata) => [
- pendingFieldMetadata.universalIdentifier,
- pendingFieldMetadata,
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- ...(pendingViewUniversalIdentifiers.length > 0 && {
- view: {
- flatEntityToCreate: Object.fromEntries(
- pendingViewUniversalIdentifiers.map((universalIdentifier) => [
- universalIdentifier,
- { universalIdentifier },
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- }),
- } as unknown as AllFlatEntityOperationRecordByMetadataName,
- relatedFlatEntityMaps: {},
- context: {},
- }) as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-
-describe('ObjectIndexViewOnCreateSideEffectHandlerService', () => {
- const handler =
- new (ObjectIndexViewOnCreateSideEffectHandlerService as unknown as new () => ObjectIndexViewOnCreateSideEffectHandlerService)();
-
- it('should provision the INDEX view and the system-field view fields only, positioned after the displayable caller fields', () => {
- const result = handler.buildSideEffects(
- buildArgs({ pendingFieldMetadatas: [NAME_FIELD] }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewUniversalIdentifiers = Object.keys(
- result.operations.view?.flatEntityToCreate ?? {},
- );
-
- expect(viewUniversalIdentifiers).toEqual([
- DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- ]);
- expect(
- (result.operations.view?.flatEntityToCreate ?? {})[
- DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER
- ]?.isSystemSideEffect,
- ).toBe(true);
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- // Only the 4 displayable system fields (id, deletedAt and position are
- // filtered out); the caller name view field is owned by the field creation
- // side effect handler.
- const expectedFieldUniversalIdentifiers =
- DISPLAYABLE_SYSTEM_FIELD_NAMES.map(computeFieldUniversalIdentifier);
-
- expect(
- viewFields
- .map((viewField) => viewField.fieldMetadataUniversalIdentifier)
- .sort(),
- ).toEqual([...expectedFieldUniversalIdentifiers].sort());
-
- // Positions are offset past the single displayable caller field (name),
- // whose view field the field handler emits at position 0.
- expect(
- viewFields.map((viewField) => viewField.position).sort((a, b) => a - b),
- ).toEqual([1, 2, 3, 4]);
-
- for (const viewField of viewFields) {
- expect(viewField.isSystemSideEffect).toBe(true);
- expect(viewField.universalIdentifier).toBe(
- getSystemViewFieldUniversalIdentifier({
- fieldMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- viewUniversalIdentifier: DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- viewField.fieldMetadataUniversalIdentifier,
- }),
- );
- }
- });
-
- it('should start system view field positions at 0 when there is no displayable caller field', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- labelIdentifierFieldMetadataUniversalIdentifier: null,
- pendingFieldMetadatas: [],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {})
- .map((viewField) => viewField.position)
- .sort((a, b) => a - b),
- ).toEqual([0, 1, 2, 3]);
- });
-
- // The engine is the sole owner of the INDEX view and always emits it; a
- // caller providing one with the same identifier is a conflict left to the
- // engine collision downstream, not silently deferred here.
- it('should still emit its own INDEX view even when the caller provides one with the same identifier', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- pendingFieldMetadatas: [NAME_FIELD],
- pendingViewUniversalIdentifiers: [
- DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.keys(result.operations.view?.flatEntityToCreate ?? {}),
- ).toEqual([DERIVED_INDEX_VIEW_UNIVERSAL_IDENTIFIER]);
- expect(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {}),
- ).toHaveLength(4);
- });
-
- it('should ignore caller fields belonging to other objects when computing the position offset', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- pendingFieldMetadatas: [
- NAME_FIELD,
- {
- universalIdentifier: 'c1c2c3c4-c5c6-4000-8000-000000000001',
- objectMetadataUniversalIdentifier:
- OTHER_OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'otherObjectField',
- type: FieldMetadataType.TEXT,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(
- viewFields.map((viewField) => viewField.fieldMetadataUniversalIdentifier),
- ).not.toContain('c1c2c3c4-c5c6-4000-8000-000000000001');
-
- // Offset is 1 (only the name field belongs to the created object), not 2.
- expect(
- viewFields.map((viewField) => viewField.position).sort((a, b) => a - b),
- ).toEqual([1, 2, 3, 4]);
- });
-
- // An object with no name field (e.g. a manifest object) has its label
- // identifier backed by the id system field; its view field must still be
- // strictly lowest, ahead of the displayable caller fields.
- it('should place the id label-identifier system view field at the strictly lowest position', () => {
- const idFieldUniversalIdentifier = computeFieldUniversalIdentifier('id');
- const callerField: PendingFieldMetadata = {
- universalIdentifier: computeFieldUniversalIdentifier('firstKey'),
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'firstKey',
- type: FieldMetadataType.TEXT,
- };
-
- const result = handler.buildSideEffects(
- buildArgs({
- labelIdentifierFieldMetadataUniversalIdentifier:
- idFieldUniversalIdentifier,
- pendingFieldMetadatas: [callerField],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const viewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- const idViewField = viewFields.find(
- (viewField) =>
- viewField.fieldMetadataUniversalIdentifier ===
- idFieldUniversalIdentifier,
- );
-
- expect(idViewField?.position).toBe(0);
- for (const viewField of viewFields) {
- if (
- viewField.fieldMetadataUniversalIdentifier !==
- idFieldUniversalIdentifier
- ) {
- expect(viewField.position).toBeGreaterThan(0);
- }
- }
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-record-page-label-identifier-on-update-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-record-page-label-identifier-on-update-side-effect-handler.service.spec.ts
deleted file mode 100644
index a9183b7b8d1..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-record-page-label-identifier-on-update-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,388 +0,0 @@
-import {
- SYSTEM_VIEW_KEYS,
- getSystemViewFieldUniversalIdentifier,
- getSystemViewUniversalIdentifier,
-} from 'twenty-shared/application';
-
-import { ObjectRecordPageLabelIdentifierOnUpdateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-record-page-label-identifier-on-update-side-effect-handler.service';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-
-const APPLICATION_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-const PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER =
- 'c1c2c3c4-c5c6-4000-8000-000000000001';
-const NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER =
- 'c1c2c3c4-c5c6-4000-8000-000000000002';
-
-const DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER =
- getSystemViewUniversalIdentifier({
- objectMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- viewKey: SYSTEM_VIEW_KEYS.FIELDS_WIDGET,
- });
-
-const NEW_LABEL_VIEW_FIELD_UNIVERSAL_IDENTIFIER =
- getSystemViewFieldUniversalIdentifier({
- fieldMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- viewUniversalIdentifier: DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier: NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- });
-
-const FIELDS_WIDGET = {
- universalIdentifier: 'widget-uid-1',
- isActive: true,
- deletedAt: null,
- universalConfiguration: {
- configurationType: 'FIELDS',
- viewUniversalIdentifier: DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- newFieldDefaultVisibility: true,
- },
-};
-
-const buildArgs = ({
- previousLabelIdentifier = PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- newLabelIdentifier = NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- recordPageView = {
- id: 'view-db-id-1',
- universalIdentifier: DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- deletedAt: null,
- },
- recordPageViewFields = [] as {
- universalIdentifier: string;
- fieldMetadataUniversalIdentifier: string;
- isSystemSideEffect?: boolean;
- position?: number;
- deletedAt?: string | null;
- viewFieldGroupUniversalIdentifier?: string | null;
- isActive?: boolean;
- }[],
- fieldsWidgets = [FIELDS_WIDGET],
- fieldMetadatasDeletedInBatch = [] as string[],
- viewFieldsPendingInBatch = [] as {
- universalIdentifier: string;
- viewUniversalIdentifier: string;
- fieldMetadataUniversalIdentifier: string;
- }[],
-} = {}): BuildSideEffectsArgs<'objectMetadata'> =>
- ({
- flatEntity: {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- labelIdentifierFieldMetadataUniversalIdentifier: newLabelIdentifier,
- },
- allFlatEntityOperationRecordByMetadataName: {
- fieldMetadata: {
- flatEntityToCreate: {},
- flatEntityToUpdate: {},
- flatEntityToDelete: Object.fromEntries(
- fieldMetadatasDeletedInBatch.map((fieldUniversalIdentifier) => [
- fieldUniversalIdentifier,
- { universalIdentifier: fieldUniversalIdentifier },
- ]),
- ),
- },
- ...(viewFieldsPendingInBatch.length > 0 && {
- viewField: {
- flatEntityToCreate: Object.fromEntries(
- viewFieldsPendingInBatch.map((pendingViewField) => [
- pendingViewField.universalIdentifier,
- pendingViewField,
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- }),
- },
- relatedFlatEntityMaps: {
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- [OBJECT_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- labelIdentifierFieldMetadataUniversalIdentifier:
- previousLabelIdentifier,
- },
- },
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- [PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- },
- [NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- },
- },
- },
- flatViewMaps: {
- byUniversalIdentifier: {
- [recordPageView.universalIdentifier]: {
- ...recordPageView,
- viewFieldUniversalIdentifiers: recordPageViewFields.map(
- (viewField) => viewField.universalIdentifier,
- ),
- viewFieldGroupUniversalIdentifiers: [],
- },
- },
- },
- flatViewFieldMaps: {
- byUniversalIdentifier: Object.fromEntries(
- recordPageViewFields.map((viewField) => [
- viewField.universalIdentifier,
- {
- isSystemSideEffect: true,
- position: 0,
- deletedAt: null,
- isActive: true,
- viewFieldGroupUniversalIdentifier: null,
- ...viewField,
- },
- ]),
- ),
- },
- flatViewFieldGroupMaps: { byUniversalIdentifier: {} },
- flatPageLayoutWidgetMaps: {
- byUniversalIdentifier: Object.fromEntries(
- fieldsWidgets.map((fieldsWidget) => [
- fieldsWidget.universalIdentifier,
- fieldsWidget,
- ]),
- ),
- },
- },
- context: {},
- }) as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-
-describe('ObjectRecordPageLabelIdentifierOnUpdateSideEffectHandlerService', () => {
- const handler =
- new (ObjectRecordPageLabelIdentifierOnUpdateSideEffectHandlerService as unknown as new () => ObjectRecordPageLabelIdentifierOnUpdateSideEffectHandlerService)();
-
- it('should delete the new label identifier engine view field and restore the previous one', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- recordPageViewFields: [
- {
- universalIdentifier: NEW_LABEL_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- position: 3,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const deletedViewFields = Object.values(
- result.operations.viewField?.flatEntityToDelete ?? {},
- );
-
- expect(deletedViewFields).toHaveLength(1);
- expect(deletedViewFields[0].universalIdentifier).toBe(
- NEW_LABEL_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- );
-
- const createdViewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(createdViewFields).toHaveLength(1);
- expect(createdViewFields[0]).toMatchObject({
- universalIdentifier: getSystemViewFieldUniversalIdentifier({
- fieldMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- viewUniversalIdentifier: DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- }),
- fieldMetadataUniversalIdentifier:
- PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- // Appended after the (deleted) view field at position 3.
- position: 4,
- });
- });
-
- it('should noop when the label identifier is unchanged', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- previousLabelIdentifier: NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- newLabelIdentifier: NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should noop when the object has no engine-owned record-page view', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- recordPageView: {
- id: 'view-db-id-1',
- universalIdentifier: 'not-the-derived-identifier',
- isSystemSideEffect: true,
- deletedAt: null,
- },
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should not delete a caller-owned view field displaying the new label identifier', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- recordPageViewFields: [
- {
- universalIdentifier: 'caller-owned-view-field-uid',
- fieldMetadataUniversalIdentifier:
- NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: false,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.values(result.operations.viewField?.flatEntityToDelete ?? {}),
- ).toHaveLength(0);
- });
-
- it('should not restore the previous label identifier when it is already displayed', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- recordPageViewFields: [
- {
- universalIdentifier: 'previous-label-view-field-uid',
- fieldMetadataUniversalIdentifier:
- PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- },
- ],
- }),
- );
-
- // Nothing to delete and nothing to restore: the handler emits no
- // operations at all.
- expect(result.status).toBe('noop');
- });
-
- it('should not restore a previous label identifier deleted in the same batch', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- recordPageViewFields: [
- {
- universalIdentifier: NEW_LABEL_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- },
- ],
- fieldMetadatasDeletedInBatch: [
- PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {}),
- ).toHaveLength(0);
- // The exclusion half still applies.
- expect(
- Object.values(result.operations.viewField?.flatEntityToDelete ?? {}),
- ).toHaveLength(1);
- });
-
- // The engine always produces its system side effects: a caller-pending view
- // field for the same pair is a conflict the pair-uniqueness validator
- // surfaces to the caller, not something the engine yields to.
- it('should restore the previous label identifier even when the batch declares a view field for the same pair', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- recordPageViewFields: [
- {
- universalIdentifier: NEW_LABEL_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- },
- ],
- viewFieldsPendingInBatch: [
- {
- universalIdentifier: 'caller-authored-view-field-uid',
- viewUniversalIdentifier:
- DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const restoredFlatViewFields = Object.values(
- result.operations.viewField?.flatEntityToCreate ?? {},
- );
-
- expect(restoredFlatViewFields).toHaveLength(1);
- expect(restoredFlatViewFields[0].fieldMetadataUniversalIdentifier).toBe(
- PREVIOUS_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- );
- expect(restoredFlatViewFields[0].isSystemSideEffect).toBe(true);
- });
-
- it('should not restore the previous label identifier when no active FIELDS widget references the view', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- recordPageViewFields: [
- {
- universalIdentifier: NEW_LABEL_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier:
- NEW_LABEL_FIELD_UNIVERSAL_IDENTIFIER,
- },
- ],
- fieldsWidgets: [],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.values(result.operations.viewField?.flatEntityToCreate ?? {}),
- ).toHaveLength(0);
- // The exclusion half still applies.
- expect(
- Object.values(result.operations.viewField?.flatEntityToDelete ?? {}),
- ).toHaveLength(1);
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-record-page-on-create-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-record-page-on-create-side-effect-handler.service.spec.ts
deleted file mode 100644
index 186dce29193..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-record-page-on-create-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,225 +0,0 @@
-import {
- SYSTEM_VIEW_KEYS,
- getSystemPageLayoutTabUniversalIdentifier,
- getSystemPageLayoutWidgetUniversalIdentifier,
- getSystemRecordPageLayoutUniversalIdentifier,
- getSystemViewUniversalIdentifier,
-} from 'twenty-shared/application';
-import { ViewType } from 'twenty-shared/types';
-
-import { type AllFlatEntityOperationRecordByMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-operation-record-by-metadata-name.type';
-import { ObjectRecordPageOnCreateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-record-page-on-create-side-effect-handler.service';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-import { WidgetConfigurationType } from 'src/engine/metadata-modules/page-layout-widget/enums/widget-configuration-type.type';
-import { PageLayoutType } from 'src/engine/metadata-modules/page-layout/enums/page-layout-type.enum';
-
-const APPLICATION_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-
-const OBJECT_METADATA = {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- labelSingular: 'Ticket',
- labelIdentifierFieldMetadataUniversalIdentifier: null,
-};
-
-const DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER =
- getSystemViewUniversalIdentifier({
- objectMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- viewKey: SYSTEM_VIEW_KEYS.FIELDS_WIDGET,
- });
-
-const DERIVED_PAGE_LAYOUT_UNIVERSAL_IDENTIFIER =
- getSystemRecordPageLayoutUniversalIdentifier({
- objectMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- });
-
-const buildArgs = ({
- pendingViews = [],
- pendingPageLayouts = [],
-}: {
- pendingViews?: {
- universalIdentifier: string;
- isSystemSideEffect: boolean;
- type: ViewType;
- objectMetadataUniversalIdentifier: string;
- }[];
- pendingPageLayouts?: {
- universalIdentifier: string;
- isSystemSideEffect: boolean;
- type: PageLayoutType;
- objectMetadataUniversalIdentifier: string;
- }[];
-} = {}): BuildSideEffectsArgs<'objectMetadata'> =>
- ({
- flatEntity: OBJECT_METADATA,
- allFlatEntityOperationRecordByMetadataName: {
- objectMetadata: {
- flatEntityToCreate: { [OBJECT_UNIVERSAL_IDENTIFIER]: OBJECT_METADATA },
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- fieldMetadata: {
- flatEntityToCreate: {},
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- view: {
- flatEntityToCreate: Object.fromEntries(
- pendingViews.map((pendingView) => [
- pendingView.universalIdentifier,
- pendingView,
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- pageLayout: {
- flatEntityToCreate: Object.fromEntries(
- pendingPageLayouts.map((pendingPageLayout) => [
- pendingPageLayout.universalIdentifier,
- pendingPageLayout,
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- } as unknown as AllFlatEntityOperationRecordByMetadataName,
- relatedFlatEntityMaps: {},
- context: {},
- }) as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-
-describe('ObjectRecordPageOnCreateSideEffectHandlerService', () => {
- const handler =
- new (ObjectRecordPageOnCreateSideEffectHandlerService as unknown as new () => ObjectRecordPageOnCreateSideEffectHandlerService)();
-
- it('should emit the full record-page stack with derived identifiers', () => {
- const result = handler.buildSideEffects(buildArgs());
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const views = Object.values(
- result.operations.view?.flatEntityToCreate ?? {},
- );
-
- expect(views).toHaveLength(1);
- expect(views[0]).toMatchObject({
- universalIdentifier: DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- key: null,
- type: ViewType.FIELDS_WIDGET,
- isSystemSideEffect: true,
- name: 'Ticket Record Page Fields',
- });
-
- const pageLayouts = Object.values(
- result.operations.pageLayout?.flatEntityToCreate ?? {},
- );
-
- expect(pageLayouts).toHaveLength(1);
- expect(pageLayouts[0]).toMatchObject({
- universalIdentifier: DERIVED_PAGE_LAYOUT_UNIVERSAL_IDENTIFIER,
- type: PageLayoutType.RECORD_PAGE,
- isSystemSideEffect: true,
- });
-
- const pageLayoutTabs = Object.values(
- result.operations.pageLayoutTab?.flatEntityToCreate ?? {},
- );
-
- expect(pageLayoutTabs).toHaveLength(5);
- expect(pageLayoutTabs.map((tab) => tab.title)).toEqual([
- 'Home',
- 'Timeline',
- 'Tasks',
- 'Notes',
- 'Files',
- ]);
- for (const pageLayoutTab of pageLayoutTabs) {
- expect(pageLayoutTab.universalIdentifier).toBe(
- getSystemPageLayoutTabUniversalIdentifier({
- objectMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- pageLayoutUniversalIdentifier:
- DERIVED_PAGE_LAYOUT_UNIVERSAL_IDENTIFIER,
- title: pageLayoutTab.title,
- }),
- );
- expect(pageLayoutTab.isSystemSideEffect).toBe(true);
- }
-
- const pageLayoutWidgets = Object.values(
- result.operations.pageLayoutWidget?.flatEntityToCreate ?? {},
- );
-
- expect(pageLayoutWidgets).toHaveLength(5);
- for (const pageLayoutWidget of pageLayoutWidgets) {
- expect(pageLayoutWidget.universalIdentifier).toBe(
- getSystemPageLayoutWidgetUniversalIdentifier({
- objectMetadataApplicationUniversalIdentifier:
- APPLICATION_UNIVERSAL_IDENTIFIER,
- pageLayoutTabUniversalIdentifier:
- pageLayoutWidget.pageLayoutTabUniversalIdentifier,
- title: pageLayoutWidget.title,
- }),
- );
- expect(pageLayoutWidget.isSystemSideEffect).toBe(true);
- }
-
- const fieldsWidget = pageLayoutWidgets.find(
- (pageLayoutWidget) =>
- pageLayoutWidget.universalConfiguration.configurationType ===
- WidgetConfigurationType.FIELDS,
- );
-
- expect(fieldsWidget?.universalConfiguration).toMatchObject({
- viewUniversalIdentifier: DERIVED_RECORD_PAGE_VIEW_UNIVERSAL_IDENTIFIER,
- newFieldDefaultVisibility: true,
- });
- });
-
- // Caller-defined custom record pages coexist with the system stack: the
- // engine emits its own whatever the batch carries.
- it('should still emit when the batch carries a caller-authored record-page stack for the object', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- pendingViews: [
- {
- universalIdentifier: 'app-authored-view-uid',
- isSystemSideEffect: false,
- type: ViewType.FIELDS_WIDGET,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- },
- ],
- pendingPageLayouts: [
- {
- universalIdentifier: 'app-authored-layout-uid',
- isSystemSideEffect: false,
- type: PageLayoutType.RECORD_PAGE,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.values(result.operations.view?.flatEntityToCreate ?? {}),
- ).toHaveLength(1);
- expect(
- Object.values(result.operations.pageLayout?.flatEntityToCreate ?? {}),
- ).toHaveLength(1);
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-search-vector-on-create-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-search-vector-on-create-side-effect-handler.service.spec.ts
deleted file mode 100644
index f11cfc5394e..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-search-vector-on-create-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,275 +0,0 @@
-import { getFieldUniversalIdentifier } from 'twenty-shared/application';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { type AllFlatEntityOperationRecordByMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-operation-record-by-metadata-name.type';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-import { ObjectSearchVectorOnCreateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-search-vector-on-create-side-effect-handler.service';
-
-const APPLICATION_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-
-const NAME_FIELD_UNIVERSAL_IDENTIFIER = getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'name',
-});
-
-const SEARCH_VECTOR_FIELD_UNIVERSAL_IDENTIFIER = getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'searchVector',
-});
-
-type PendingFieldMetadata = {
- universalIdentifier: string;
- type: FieldMetadataType;
-};
-
-const buildArgs = ({
- isSearchable,
- labelIdentifierFieldMetadataUniversalIdentifier,
- pendingFieldMetadatas = [],
- relatedFlatEntityMaps = {
- flatFieldMetadataMaps: { byUniversalIdentifier: {} },
- flatSearchFieldMetadataMaps: { byUniversalIdentifier: {} },
- flatIndexMaps: { byUniversalIdentifier: {} },
- },
-}: {
- isSearchable: boolean;
- labelIdentifierFieldMetadataUniversalIdentifier: string | null;
- pendingFieldMetadatas?: PendingFieldMetadata[];
- relatedFlatEntityMaps?: object;
-}): BuildSideEffectsArgs<'objectMetadata'> =>
- ({
- flatEntity: {
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- nameSingular: 'ticket',
- isSearchable,
- labelIdentifierFieldMetadataUniversalIdentifier,
- },
- allFlatEntityOperationRecordByMetadataName: {
- ...(pendingFieldMetadatas.length > 0 && {
- fieldMetadata: {
- flatEntityToCreate: Object.fromEntries(
- pendingFieldMetadatas.map((pendingFieldMetadata) => [
- pendingFieldMetadata.universalIdentifier,
- pendingFieldMetadata,
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- }),
- } as unknown as AllFlatEntityOperationRecordByMetadataName,
- relatedFlatEntityMaps,
- context: {},
- }) as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-
-const PENDING_TEXT_NAME_FIELD: PendingFieldMetadata = {
- universalIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- type: FieldMetadataType.TEXT,
-};
-
-describe('ObjectSearchVectorOnCreateSideEffectHandlerService', () => {
- const handler =
- new (ObjectSearchVectorOnCreateSideEffectHandlerService as unknown as new () => ObjectSearchVectorOnCreateSideEffectHandlerService)();
-
- it('should always provision the searchVector field and its GIN index, plus a searchFieldMetadata for a searchable object with a searchable label identifier', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- isSearchable: true,
- labelIdentifierFieldMetadataUniversalIdentifier:
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [PENDING_TEXT_NAME_FIELD],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const createdFieldUniversalIdentifiers = Object.keys(
- result.operations.fieldMetadata?.flatEntityToCreate ?? {},
- );
-
- expect(createdFieldUniversalIdentifiers).toEqual([
- SEARCH_VECTOR_FIELD_UNIVERSAL_IDENTIFIER,
- ]);
-
- expect(
- Object.keys(result.operations.index?.flatEntityToCreate ?? {}),
- ).toHaveLength(1);
-
- expect(
- Object.keys(
- result.operations.searchFieldMetadata?.flatEntityToCreate ?? {},
- ),
- ).toHaveLength(1);
- });
-
- it('should still provision the searchVector field and GIN index but no searchFieldMetadata when the object is not searchable', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- isSearchable: false,
- labelIdentifierFieldMetadataUniversalIdentifier:
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [PENDING_TEXT_NAME_FIELD],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.keys(result.operations.fieldMetadata?.flatEntityToCreate ?? {}),
- ).toHaveLength(1);
- expect(
- Object.keys(result.operations.index?.flatEntityToCreate ?? {}),
- ).toHaveLength(1);
- expect(result.operations.searchFieldMetadata).toBeUndefined();
- });
-
- it('should not provision a searchFieldMetadata for junction objects whose label identifier is the id field', () => {
- const idFieldUniversalIdentifier = getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'id',
- });
-
- const result = handler.buildSideEffects(
- buildArgs({
- isSearchable: true,
- labelIdentifierFieldMetadataUniversalIdentifier:
- idFieldUniversalIdentifier,
- pendingFieldMetadatas: [
- {
- universalIdentifier: idFieldUniversalIdentifier,
- type: FieldMetadataType.UUID,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(result.operations.searchFieldMetadata).toBeUndefined();
- });
-
- it('should not provision a searchFieldMetadata when the caller published a non-searchable field at the derived name identifier', () => {
- // The universal identifier derivation is name-based, so a caller-provided
- // `name` field of any type lands on the derived identifier. The handler must
- // resolve the actual type instead of assuming TEXT.
- const result = handler.buildSideEffects(
- buildArgs({
- isSearchable: true,
- labelIdentifierFieldMetadataUniversalIdentifier:
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [
- {
- universalIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- type: FieldMetadataType.NUMBER,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(result.operations.searchFieldMetadata).toBeUndefined();
- });
-
- it('should not provision a searchFieldMetadata when the label identifier field cannot be resolved', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- isSearchable: true,
- labelIdentifierFieldMetadataUniversalIdentifier:
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(result.operations.searchFieldMetadata).toBeUndefined();
- });
-
- it('should resolve the label identifier field type from the existing maps when it is not part of the pending operations', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- isSearchable: true,
- labelIdentifierFieldMetadataUniversalIdentifier:
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- relatedFlatEntityMaps: {
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- [NAME_FIELD_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- type: FieldMetadataType.TEXT,
- },
- },
- },
- flatSearchFieldMetadataMaps: { byUniversalIdentifier: {} },
- flatIndexMaps: { byUniversalIdentifier: {} },
- },
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.keys(
- result.operations.searchFieldMetadata?.flatEntityToCreate ?? {},
- ),
- ).toHaveLength(1);
- });
-
- it('should be deterministic across invocations', () => {
- const firstResult = handler.buildSideEffects(
- buildArgs({
- isSearchable: true,
- labelIdentifierFieldMetadataUniversalIdentifier:
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [PENDING_TEXT_NAME_FIELD],
- }),
- );
- const secondResult = handler.buildSideEffects(
- buildArgs({
- isSearchable: true,
- labelIdentifierFieldMetadataUniversalIdentifier:
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [PENDING_TEXT_NAME_FIELD],
- }),
- );
-
- if (firstResult.status !== 'success' || secondResult.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.keys(firstResult.operations.index?.flatEntityToCreate ?? {}),
- ).toEqual(
- Object.keys(secondResult.operations.index?.flatEntityToCreate ?? {}),
- );
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-search-vector-on-update-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-search-vector-on-update-side-effect-handler.service.spec.ts
deleted file mode 100644
index 363d031642b..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-search-vector-on-update-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,300 +0,0 @@
-import { getFieldUniversalIdentifier } from 'twenty-shared/application';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { type AllFlatEntityOperationRecordByMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-operation-record-by-metadata-name.type';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-import { ObjectSearchVectorOnUpdateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-search-vector-on-update-side-effect-handler.service';
-
-const APPLICATION_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-
-const NAME_FIELD_UNIVERSAL_IDENTIFIER = getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'name',
-});
-
-const TOTO_FIELD_UNIVERSAL_IDENTIFIER = getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'toto',
-});
-
-const SEARCH_VECTOR_FIELD_UNIVERSAL_IDENTIFIER = getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'searchVector',
-});
-
-const NAME_SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER =
- 'c1c2c3c4-c5c6-4000-8000-000000000001';
-
-type PendingFieldMetadata = {
- universalIdentifier: string;
- type: FieldMetadataType;
-};
-
-const SEARCH_VECTOR_FLAT_FIELD = {
- universalIdentifier: SEARCH_VECTOR_FIELD_UNIVERSAL_IDENTIFIER,
- type: FieldMetadataType.TS_VECTOR,
- name: 'searchVector',
-};
-
-const NAME_SEARCH_FIELD_METADATA = {
- universalIdentifier: NAME_SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- position: 0,
-};
-
-const buildArgs = ({
- isSearchable = true,
- toLabelIdentifier,
- fromLabelIdentifier,
- pendingFieldMetadatas = [],
- existingFlatFieldMetadataByUniversalIdentifier = {
- [SEARCH_VECTOR_FIELD_UNIVERSAL_IDENTIFIER]: SEARCH_VECTOR_FLAT_FIELD,
- },
- existingSearchFieldMetadataByUniversalIdentifier = {
- [NAME_SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER]:
- NAME_SEARCH_FIELD_METADATA,
- },
- existingObjectSearchFieldMetadataUniversalIdentifiers = [
- NAME_SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER,
- ],
- existingObjectFieldUniversalIdentifiers = [
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- SEARCH_VECTOR_FIELD_UNIVERSAL_IDENTIFIER,
- ],
-}: {
- isSearchable?: boolean;
- toLabelIdentifier: string | null;
- fromLabelIdentifier: string | null;
- pendingFieldMetadatas?: PendingFieldMetadata[];
- existingFlatFieldMetadataByUniversalIdentifier?: object;
- existingSearchFieldMetadataByUniversalIdentifier?: object;
- existingObjectSearchFieldMetadataUniversalIdentifiers?: string[];
- existingObjectFieldUniversalIdentifiers?: string[];
-}): BuildSideEffectsArgs<'objectMetadata'> =>
- ({
- flatEntity: {
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- nameSingular: 'ticket',
- isSearchable,
- labelIdentifierFieldMetadataUniversalIdentifier: toLabelIdentifier,
- },
- allFlatEntityOperationRecordByMetadataName: {
- ...(pendingFieldMetadatas.length > 0 && {
- fieldMetadata: {
- flatEntityToCreate: Object.fromEntries(
- pendingFieldMetadatas.map((pendingFieldMetadata) => [
- pendingFieldMetadata.universalIdentifier,
- pendingFieldMetadata,
- ]),
- ),
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- }),
- } as unknown as AllFlatEntityOperationRecordByMetadataName,
- relatedFlatEntityMaps: {
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- [OBJECT_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- labelIdentifierFieldMetadataUniversalIdentifier:
- fromLabelIdentifier,
- fieldUniversalIdentifiers: existingObjectFieldUniversalIdentifiers,
- searchFieldMetadataUniversalIdentifiers:
- existingObjectSearchFieldMetadataUniversalIdentifiers,
- },
- },
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: existingFlatFieldMetadataByUniversalIdentifier,
- },
- flatSearchFieldMetadataMaps: {
- byUniversalIdentifier: existingSearchFieldMetadataByUniversalIdentifier,
- },
- },
- context: {},
- }) as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-
-const PENDING_TEXT_TOTO_FIELD: PendingFieldMetadata = {
- universalIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- type: FieldMetadataType.TEXT,
-};
-
-describe('ObjectSearchVectorOnUpdateSideEffectHandlerService', () => {
- const handler =
- new (ObjectSearchVectorOnUpdateSideEffectHandlerService as unknown as new () => ObjectSearchVectorOnUpdateSideEffectHandlerService)();
-
- it('should provision a searchFieldMetadata for the new searchable label identifier while preserving the existing surface', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [PENDING_TEXT_TOTO_FIELD],
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const createdSearchFieldMetadatas =
- result.operations.searchFieldMetadata?.flatEntityToCreate ?? {};
-
- expect(Object.keys(createdSearchFieldMetadatas)).toHaveLength(1);
-
- const [createdSearchFieldMetadata] = Object.values(
- createdSearchFieldMetadatas,
- );
-
- expect(createdSearchFieldMetadata.fieldMetadataUniversalIdentifier).toBe(
- TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- );
- expect(
- createdSearchFieldMetadata.tsVectorFieldMetadataUniversalIdentifier,
- ).toBe(SEARCH_VECTOR_FIELD_UNIVERSAL_IDENTIFIER);
- // Appended after the pre-existing name row (position 0).
- expect(createdSearchFieldMetadata.position).toBe(1);
- });
-
- it('should resolve the new label identifier field type from the existing maps', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- existingFlatFieldMetadataByUniversalIdentifier: {
- [SEARCH_VECTOR_FIELD_UNIVERSAL_IDENTIFIER]: SEARCH_VECTOR_FLAT_FIELD,
- [TOTO_FIELD_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- type: FieldMetadataType.TEXT,
- },
- },
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.keys(
- result.operations.searchFieldMetadata?.flatEntityToCreate ?? {},
- ),
- ).toHaveLength(1);
- });
-
- it('should be a noop when the object is not searchable', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- isSearchable: false,
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [PENDING_TEXT_TOTO_FIELD],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should be a noop when the label identifier did not change', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [PENDING_TEXT_TOTO_FIELD],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should be a noop when the new label identifier is the system id field (junction object)', () => {
- const idFieldUniversalIdentifier = getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name: 'id',
- });
-
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: idFieldUniversalIdentifier,
- pendingFieldMetadatas: [
- {
- universalIdentifier: idFieldUniversalIdentifier,
- type: FieldMetadataType.UUID,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should be a noop when the new label identifier field is not a searchable type', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [
- {
- universalIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- type: FieldMetadataType.NUMBER,
- },
- ],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should be a noop when the new label identifier is already indexed', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [PENDING_TEXT_TOTO_FIELD],
- existingSearchFieldMetadataByUniversalIdentifier: {
- [NAME_SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER]:
- NAME_SEARCH_FIELD_METADATA,
- 'toto-search-row': {
- universalIdentifier: 'toto-search-row',
- fieldMetadataUniversalIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- position: 1,
- },
- },
- existingObjectSearchFieldMetadataUniversalIdentifiers: [
- NAME_SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER,
- 'toto-search-row',
- ],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should be a noop when the object has no searchVector field to attach to', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fromLabelIdentifier: NAME_FIELD_UNIVERSAL_IDENTIFIER,
- toLabelIdentifier: TOTO_FIELD_UNIVERSAL_IDENTIFIER,
- pendingFieldMetadatas: [PENDING_TEXT_TOTO_FIELD],
- existingFlatFieldMetadataByUniversalIdentifier: {},
- existingObjectFieldUniversalIdentifiers: [
- NAME_FIELD_UNIVERSAL_IDENTIFIER,
- ],
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-fields-on-create-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-fields-on-create-side-effect-handler.service.spec.ts
deleted file mode 100644
index 0de02862fc3..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-fields-on-create-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,89 +0,0 @@
-import { getFieldUniversalIdentifier } from 'twenty-shared/application';
-
-import { ObjectSystemFieldsOnCreateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-system-fields-on-create-side-effect-handler.service';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-
-const APPLICATION_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-
-const computeFieldUniversalIdentifier = (name: string) =>
- getFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- name,
- });
-
-const ALL_SYSTEM_FIELD_NAMES = [
- 'id',
- 'createdAt',
- 'updatedAt',
- 'deletedAt',
- 'createdBy',
- 'updatedBy',
- 'position',
-] as const;
-
-const buildArgs = (): BuildSideEffectsArgs<'objectMetadata'> =>
- ({
- flatEntity: {
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- nameSingular: 'ticket',
- labelIdentifierFieldMetadataUniversalIdentifier:
- computeFieldUniversalIdentifier('name'),
- },
- allFlatEntityOperationRecordByMetadataName: {},
- relatedFlatEntityMaps: {},
- context: {},
- }) as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-
-describe('ObjectSystemFieldsOnCreateSideEffectHandlerService', () => {
- const handler =
- new (ObjectSystemFieldsOnCreateSideEffectHandlerService as unknown as new () => ObjectSystemFieldsOnCreateSideEffectHandlerService)();
-
- it('should synthesize exactly the 7 reserved system fields, never the caller name nor searchVector', () => {
- const result = handler.buildSideEffects(buildArgs());
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const createdUniversalIdentifiers = Object.keys(
- result.operations.fieldMetadata?.flatEntityToCreate ?? {},
- );
-
- expect(createdUniversalIdentifiers).toHaveLength(7);
- expect(createdUniversalIdentifiers).not.toContain(
- computeFieldUniversalIdentifier('name'),
- );
- expect(createdUniversalIdentifiers).not.toContain(
- computeFieldUniversalIdentifier('searchVector'),
- );
-
- for (const name of ALL_SYSTEM_FIELD_NAMES) {
- expect(createdUniversalIdentifiers).toContain(
- computeFieldUniversalIdentifier(name),
- );
- }
-
- for (const createdFlatFieldMetadata of Object.values(
- result.operations.fieldMetadata?.flatEntityToCreate ?? {},
- )) {
- expect(createdFlatFieldMetadata.isSystemSideEffect).toBe(true);
- }
- });
-
- it('should emit nothing but field metadata', () => {
- const result = handler.buildSideEffects(buildArgs());
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(Object.keys(result.operations)).toEqual(['fieldMetadata']);
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-relations-on-create-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-relations-on-create-side-effect-handler.service.spec.ts
deleted file mode 100644
index 88fcea44394..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-relations-on-create-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,206 +0,0 @@
-import { getSystemRelationFieldUniversalIdentifier } from 'twenty-shared/application';
-import {
- DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS,
- STANDARD_OBJECTS,
-} from 'twenty-shared/metadata';
-
-import { type AllFlatEntityOperationRecordByMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-operation-record-by-metadata-name.type';
-import { getFlatObjectMetadataMock } from 'src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-import { ObjectSystemRelationsOnCreateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-system-relations-on-create-side-effect-handler.service';
-
-const APPLICATION_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const SOURCE_OBJECT_UNIVERSAL_IDENTIFIER =
- 'b1b2b3b4-b5b6-4000-8000-000000000001';
-
-const NAME_PLURAL_BY_STANDARD_OBJECT_NAME_SINGULAR: Record<string, string> = {
- timelineActivity: 'timelineActivities',
- attachment: 'attachments',
- noteTarget: 'noteTargets',
- taskTarget: 'taskTargets',
-};
-
-// The handler resolves the standard relation objects by their pinned standard
-// universal identifiers, so the mocks must carry them.
-const buildStandardTargetFlatObjectMetadatas = () =>
- DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS.map((nameSingular) =>
- getFlatObjectMetadataMock({
- universalIdentifier: STANDARD_OBJECTS[nameSingular].universalIdentifier,
- nameSingular,
- namePlural: NAME_PLURAL_BY_STANDARD_OBJECT_NAME_SINGULAR[nameSingular],
- labelSingular: nameSingular,
- labelPlural: NAME_PLURAL_BY_STANDARD_OBJECT_NAME_SINGULAR[nameSingular],
- }),
- );
-
-const SOURCE_FLAT_OBJECT_METADATA = getFlatObjectMetadataMock({
- universalIdentifier: SOURCE_OBJECT_UNIVERSAL_IDENTIFIER,
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- nameSingular: 'rocket',
- namePlural: 'rockets',
- labelSingular: 'Rocket',
- labelPlural: 'Rockets',
-});
-
-const buildArgs = ({
- standardTargetFlatObjectMetadatas = buildStandardTargetFlatObjectMetadatas(),
- callerFieldMetadataToCreateByUniversalIdentifier = {},
- existingFieldMetadataByUniversalIdentifier = {},
-}: {
- standardTargetFlatObjectMetadatas?: ReturnType<
- typeof buildStandardTargetFlatObjectMetadatas
- >;
- callerFieldMetadataToCreateByUniversalIdentifier?: Record<string, unknown>;
- existingFieldMetadataByUniversalIdentifier?: Record<string, unknown>;
-}): BuildSideEffectsArgs<'objectMetadata'> => {
- const objectByUniversalIdentifier: Record<string, unknown> = {};
-
- for (const flatObjectMetadata of standardTargetFlatObjectMetadatas) {
- objectByUniversalIdentifier[flatObjectMetadata.universalIdentifier] =
- flatObjectMetadata;
- }
-
- return {
- flatEntity: SOURCE_FLAT_OBJECT_METADATA,
- allFlatEntityOperationRecordByMetadataName: {
- fieldMetadata: {
- flatEntityToCreate: callerFieldMetadataToCreateByUniversalIdentifier,
- },
- } as unknown as AllFlatEntityOperationRecordByMetadataName,
- relatedFlatEntityMaps: {
- flatObjectMetadataMaps: {
- byUniversalIdentifier: objectByUniversalIdentifier,
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: existingFieldMetadataByUniversalIdentifier,
- },
- },
- context: {},
- } as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-};
-
-describe('ObjectSystemRelationsOnCreateSideEffectHandlerService', () => {
- const handler =
- new (ObjectSystemRelationsOnCreateSideEffectHandlerService as unknown as new () => ObjectSystemRelationsOnCreateSideEffectHandlerService)();
-
- const targets = buildStandardTargetFlatObjectMetadatas();
-
- const forwardUniversalIdentifierFor = (
- standardObjectUniversalIdentifier: string,
- ) =>
- getSystemRelationFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier: SOURCE_OBJECT_UNIVERSAL_IDENTIFIER,
- relationTargetObjectUniversalIdentifier:
- standardObjectUniversalIdentifier,
- });
-
- const reverseUniversalIdentifierFor = (objectUniversalIdentifier: string) =>
- getSystemRelationFieldUniversalIdentifier({
- applicationUniversalIdentifier: APPLICATION_UNIVERSAL_IDENTIFIER,
- objectUniversalIdentifier,
- relationTargetObjectUniversalIdentifier:
- SOURCE_OBJECT_UNIVERSAL_IDENTIFIER,
- });
-
- it('should provision a forward + reverse (both name-free, isSystemSideEffect) field pair and its index for all four standard relation objects', () => {
- const result = handler.buildSideEffects(buildArgs({}));
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const fieldMetadataToCreate =
- result.operations.fieldMetadata?.flatEntityToCreate ?? {};
- const indexToCreate = result.operations.index?.flatEntityToCreate ?? {};
-
- expect(Object.keys(fieldMetadataToCreate)).toHaveLength(
- DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS.length * 2,
- );
- expect(Object.keys(indexToCreate)).toHaveLength(
- DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS.length,
- );
-
- for (const target of targets) {
- const forwardUniversalIdentifier = forwardUniversalIdentifierFor(
- target.universalIdentifier,
- );
- const reverseUniversalIdentifier = reverseUniversalIdentifierFor(
- target.universalIdentifier,
- );
-
- const forwardField = fieldMetadataToCreate[forwardUniversalIdentifier];
- const reverseField = fieldMetadataToCreate[reverseUniversalIdentifier];
-
- expect(forwardField).toBeDefined();
- expect(reverseField).toBeDefined();
- expect(forwardField?.isSystemSideEffect).toBe(true);
- expect(reverseField?.isSystemSideEffect).toBe(true);
- expect(
- reverseField?.relationTargetObjectMetadataUniversalIdentifier,
- ).toBe(SOURCE_OBJECT_UNIVERSAL_IDENTIFIER);
- }
- });
-
- // The handler always emits its bundles: a caller field colliding on
- // universal identifier is not skipped but hard-fails at the engine merge
- // (RESERVED_SYSTEM_UNIVERSAL_IDENTIFIER collision).
- it('should emit all bundles even when a caller field collides on universal identifier', () => {
- const collidingTarget = targets[0];
- const collidingForwardUniversalIdentifier = forwardUniversalIdentifierFor(
- collidingTarget.universalIdentifier,
- );
-
- const result = handler.buildSideEffects(
- buildArgs({
- callerFieldMetadataToCreateByUniversalIdentifier: {
- [collidingForwardUniversalIdentifier]: {
- universalIdentifier: collidingForwardUniversalIdentifier,
- },
- },
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const fieldMetadataToCreate =
- result.operations.fieldMetadata?.flatEntityToCreate ?? {};
- const indexToCreate = result.operations.index?.flatEntityToCreate ?? {};
-
- expect(Object.keys(fieldMetadataToCreate)).toHaveLength(
- DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS.length * 2,
- );
- expect(Object.keys(indexToCreate)).toHaveLength(
- DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS.length,
- );
- expect(
- fieldMetadataToCreate[collidingForwardUniversalIdentifier],
- ).toBeDefined();
- });
-
- it('should fail with one error per missing standard relation object', () => {
- const [, , ...standardTargetFlatObjectMetadatasMissingFirstTwo] =
- buildStandardTargetFlatObjectMetadatas();
-
- const result = handler.buildSideEffects(
- buildArgs({
- standardTargetFlatObjectMetadatas:
- standardTargetFlatObjectMetadatasMissingFirstTwo,
- }),
- );
-
- expect(result.status).toBe('fail');
-
- if (result.status !== 'fail') {
- throw new Error('expected fail');
- }
-
- expect(result.errors).toHaveLength(2);
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-relations-on-update-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-relations-on-update-side-effect-handler.service.spec.ts
deleted file mode 100644
index 386ff2797ab..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-relations-on-update-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,93 +0,0 @@
-import { type AllFlatEntityOperationRecordByMetadataName } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-operation-record-by-metadata-name.type';
-import { getFlatObjectMetadataMock } from 'src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-import { ObjectSystemRelationsOnUpdateSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-system-relations-on-update-side-effect-handler.service';
-
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-
-const buildArgs = ({
- updatedNameSingular,
- updatedNamePlural,
- existingNameSingular = 'rocket',
- existingNamePlural = 'rockets',
- includeExisting = true,
-}: {
- updatedNameSingular: string;
- updatedNamePlural: string;
- existingNameSingular?: string;
- existingNamePlural?: string;
- includeExisting?: boolean;
-}): BuildSideEffectsArgs<'objectMetadata'> => {
- const existingFlatObjectMetadata = getFlatObjectMetadataMock({
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- nameSingular: existingNameSingular,
- namePlural: existingNamePlural,
- labelSingular: existingNameSingular,
- labelPlural: existingNamePlural,
- });
-
- const updatedFlatObjectMetadata = getFlatObjectMetadataMock({
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- nameSingular: updatedNameSingular,
- namePlural: updatedNamePlural,
- labelSingular: updatedNameSingular,
- labelPlural: updatedNamePlural,
- });
-
- return {
- flatEntity: updatedFlatObjectMetadata,
- allFlatEntityOperationRecordByMetadataName:
- {} as unknown as AllFlatEntityOperationRecordByMetadataName,
- relatedFlatEntityMaps: {
- flatObjectMetadataMaps: {
- byUniversalIdentifier: includeExisting
- ? { [OBJECT_UNIVERSAL_IDENTIFIER]: existingFlatObjectMetadata }
- : {},
- },
- flatFieldMetadataMaps: { byUniversalIdentifier: {} },
- flatIndexMaps: { byUniversalIdentifier: {} },
- },
- context: {},
- } as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-};
-
-describe('ObjectSystemRelationsOnUpdateSideEffectHandlerService', () => {
- const handler =
- new (ObjectSystemRelationsOnUpdateSideEffectHandlerService as unknown as new () => ObjectSystemRelationsOnUpdateSideEffectHandlerService)();
-
- it('should noop when the object name is unchanged', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- existingNameSingular: 'rocket',
- existingNamePlural: 'rockets',
- updatedNameSingular: 'rocket',
- updatedNamePlural: 'rockets',
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should fail when the existing object cannot be resolved from the maps', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- includeExisting: false,
- updatedNameSingular: 'house',
- updatedNamePlural: 'houses',
- }),
- );
-
- expect(result.status).toBe('fail');
- });
-
- it('should noop when a renamed object has no system side-effect morph relations to rename', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- updatedNameSingular: 'house',
- updatedNamePlural: 'houses',
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-side-effects-on-delete-side-effect-handler.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-side-effects-on-delete-side-effect-handler.service.spec.ts
deleted file mode 100644
index d34ed4d4c2d..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/__tests__/object-system-side-effects-on-delete-side-effect-handler.service.spec.ts
+++ /dev/null
@@ -1,365 +0,0 @@
-import { ObjectSystemSideEffectsOnDeleteSideEffectHandlerService } from 'src/engine/metadata-modules/metadata-side-effect/handlers/object-metadata/services/object-system-side-effects-on-delete-side-effect-handler.service';
-import { type BuildSideEffectsArgs } from 'src/engine/metadata-modules/metadata-side-effect/interfaces/base-metadata-side-effect-handler.service';
-
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-const OTHER_OBJECT_UNIVERSAL_IDENTIFIER =
- 'c1c2c3c4-c5c6-4000-8000-000000000001';
-
-const SYSTEM_FIELD_UNIVERSAL_IDENTIFIER =
- 'd1d2d3d4-d5d6-4000-8000-000000000001';
-const AUTHOR_FIELD_UNIVERSAL_IDENTIFIER =
- 'd1d2d3d4-d5d6-4000-8000-000000000002';
-const FORWARD_FIELD_UNIVERSAL_IDENTIFIER =
- 'd1d2d3d4-d5d6-4000-8000-000000000003';
-const REVERSE_FIELD_UNIVERSAL_IDENTIFIER =
- 'd1d2d3d4-d5d6-4000-8000-000000000004';
-const GIN_INDEX_UNIVERSAL_IDENTIFIER = 'e1e2e3e4-e5e6-4000-8000-000000000001';
-const REVERSE_INDEX_UNIVERSAL_IDENTIFIER =
- 'e1e2e3e4-e5e6-4000-8000-000000000002';
-const SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER =
- 'f1f2f3f4-f5f6-4000-8000-000000000001';
-const INDEX_VIEW_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const INDEX_VIEW_FIELD_UNIVERSAL_IDENTIFIER =
- 'a1a2a3a4-a5a6-4000-8000-000000000002';
-const CALLER_VIEW_UNIVERSAL_IDENTIFIER = 'a1a2a3a4-a5a6-4000-8000-000000000003';
-const CALLER_VIEW_FIELD_UNIVERSAL_IDENTIFIER =
- 'a1a2a3a4-a5a6-4000-8000-000000000004';
-
-type FieldFixture = {
- universalIdentifier: string;
- isSystemSideEffect: boolean;
- objectMetadataUniversalIdentifier?: string;
- relationTargetFieldMetadataUniversalIdentifier?: string | null;
- viewFieldUniversalIdentifiers?: string[];
-};
-
-type ViewFixture = {
- universalIdentifier: string;
- isSystemSideEffect: boolean;
- viewFieldUniversalIdentifiers?: string[];
- viewFieldGroupUniversalIdentifiers?: string[];
-};
-
-const buildFieldMetadataMaps = (fields: FieldFixture[]) => ({
- byUniversalIdentifier: Object.fromEntries(
- fields.map((field) => [
- field.universalIdentifier,
- {
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- relationTargetFieldMetadataUniversalIdentifier: null,
- viewFieldUniversalIdentifiers: [],
- ...field,
- },
- ]),
- ),
-});
-
-const buildArgs = ({
- fieldUniversalIdentifiers = [],
- indexMetadataUniversalIdentifiers = [],
- searchFieldMetadataUniversalIdentifiers = [],
- viewUniversalIdentifiers = [],
- relatedFlatEntityMaps = {},
-}: {
- fieldUniversalIdentifiers?: string[];
- indexMetadataUniversalIdentifiers?: string[];
- searchFieldMetadataUniversalIdentifiers?: string[];
- viewUniversalIdentifiers?: string[];
- relatedFlatEntityMaps?: object;
-}): BuildSideEffectsArgs<'objectMetadata'> =>
- ({
- flatEntity: {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- fieldUniversalIdentifiers,
- indexMetadataUniversalIdentifiers,
- searchFieldMetadataUniversalIdentifiers,
- viewUniversalIdentifiers,
- },
- allFlatEntityOperationRecordByMetadataName: {},
- relatedFlatEntityMaps: {
- flatObjectMetadataMaps: { byUniversalIdentifier: {} },
- flatFieldMetadataMaps: { byUniversalIdentifier: {} },
- flatIndexMaps: { byUniversalIdentifier: {} },
- flatSearchFieldMetadataMaps: { byUniversalIdentifier: {} },
- flatViewMaps: { byUniversalIdentifier: {} },
- flatViewFieldMaps: { byUniversalIdentifier: {} },
- flatViewFieldGroupMaps: { byUniversalIdentifier: {} },
- flatPageLayoutMaps: { byUniversalIdentifier: {} },
- flatPageLayoutTabMaps: { byUniversalIdentifier: {} },
- flatPageLayoutWidgetMaps: { byUniversalIdentifier: {} },
- ...relatedFlatEntityMaps,
- },
- context: {},
- }) as unknown as BuildSideEffectsArgs<'objectMetadata'>;
-
-describe('ObjectSystemSideEffectsOnDeleteSideEffectHandlerService', () => {
- const handler =
- new (ObjectSystemSideEffectsOnDeleteSideEffectHandlerService as unknown as new () => ObjectSystemSideEffectsOnDeleteSideEffectHandlerService)();
-
- it('should cascade-delete engine-owned fields, indexes and searchFieldMetadata while leaving author fields untouched', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fieldUniversalIdentifiers: [
- SYSTEM_FIELD_UNIVERSAL_IDENTIFIER,
- AUTHOR_FIELD_UNIVERSAL_IDENTIFIER,
- ],
- indexMetadataUniversalIdentifiers: [GIN_INDEX_UNIVERSAL_IDENTIFIER],
- searchFieldMetadataUniversalIdentifiers: [
- SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER,
- ],
- relatedFlatEntityMaps: {
- flatFieldMetadataMaps: buildFieldMetadataMaps([
- {
- universalIdentifier: SYSTEM_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- },
- {
- universalIdentifier: AUTHOR_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: false,
- },
- ]),
- flatIndexMaps: {
- byUniversalIdentifier: {
- [GIN_INDEX_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: GIN_INDEX_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- universalFlatIndexFieldMetadatas: [],
- },
- },
- },
- flatSearchFieldMetadataMaps: {
- byUniversalIdentifier: {
- [SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER,
- },
- },
- },
- },
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- const deletedFieldUniversalIdentifiers = Object.keys(
- result.operations.fieldMetadata?.flatEntityToDelete ?? {},
- );
-
- expect(deletedFieldUniversalIdentifiers).toEqual([
- SYSTEM_FIELD_UNIVERSAL_IDENTIFIER,
- ]);
- expect(deletedFieldUniversalIdentifiers).not.toContain(
- AUTHOR_FIELD_UNIVERSAL_IDENTIFIER,
- );
- expect(
- Object.keys(result.operations.index?.flatEntityToDelete ?? {}),
- ).toEqual([GIN_INDEX_UNIVERSAL_IDENTIFIER]);
- expect(
- Object.keys(
- result.operations.searchFieldMetadata?.flatEntityToDelete ?? {},
- ),
- ).toEqual([SEARCH_FIELD_METADATA_UNIVERSAL_IDENTIFIER]);
- });
-
- it('should cascade-delete the default-relation reverse morph field on a standard object and its join-column index', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- fieldUniversalIdentifiers: [FORWARD_FIELD_UNIVERSAL_IDENTIFIER],
- relatedFlatEntityMaps: {
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- [OTHER_OBJECT_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: OTHER_OBJECT_UNIVERSAL_IDENTIFIER,
- indexMetadataUniversalIdentifiers: [
- REVERSE_INDEX_UNIVERSAL_IDENTIFIER,
- ],
- },
- },
- },
- flatFieldMetadataMaps: buildFieldMetadataMaps([
- {
- universalIdentifier: FORWARD_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- relationTargetFieldMetadataUniversalIdentifier:
- REVERSE_FIELD_UNIVERSAL_IDENTIFIER,
- },
- {
- universalIdentifier: REVERSE_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- objectMetadataUniversalIdentifier:
- OTHER_OBJECT_UNIVERSAL_IDENTIFIER,
- },
- ]),
- flatIndexMaps: {
- byUniversalIdentifier: {
- [REVERSE_INDEX_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: REVERSE_INDEX_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- objectMetadataUniversalIdentifier:
- OTHER_OBJECT_UNIVERSAL_IDENTIFIER,
- universalFlatIndexFieldMetadatas: [
- {
- fieldMetadataUniversalIdentifier:
- REVERSE_FIELD_UNIVERSAL_IDENTIFIER,
- },
- ],
- },
- },
- },
- },
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.keys(result.operations.fieldMetadata?.flatEntityToDelete ?? {}),
- ).toEqual([
- FORWARD_FIELD_UNIVERSAL_IDENTIFIER,
- REVERSE_FIELD_UNIVERSAL_IDENTIFIER,
- ]);
- expect(
- Object.keys(result.operations.index?.flatEntityToDelete ?? {}),
- ).toEqual([REVERSE_INDEX_UNIVERSAL_IDENTIFIER]);
- });
-
- it('should not delete entities the object aggregators do not reference', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- relatedFlatEntityMaps: {
- flatFieldMetadataMaps: buildFieldMetadataMaps([
- {
- universalIdentifier: SYSTEM_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- objectMetadataUniversalIdentifier:
- OTHER_OBJECT_UNIVERSAL_IDENTIFIER,
- },
- ]),
- },
- }),
- );
-
- expect(result.status).toBe('noop');
- });
-
- it('should cascade-delete the engine-owned INDEX view and its view fields while leaving a caller-owned view untouched', () => {
- const result = handler.buildSideEffects(
- buildArgs({
- viewUniversalIdentifiers: [
- INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- CALLER_VIEW_UNIVERSAL_IDENTIFIER,
- ],
- relatedFlatEntityMaps: {
- flatViewMaps: {
- byUniversalIdentifier: Object.fromEntries(
- (
- [
- {
- universalIdentifier: INDEX_VIEW_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- viewFieldUniversalIdentifiers: [
- INDEX_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- ],
- },
- {
- universalIdentifier: CALLER_VIEW_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: false,
- viewFieldUniversalIdentifiers: [
- CALLER_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- ],
- },
- ] satisfies ViewFixture[]
- ).map((view) => [
- view.universalIdentifier,
- { viewFieldGroupUniversalIdentifiers: [], ...view },
- ]),
- ),
- },
- flatViewFieldMaps: {
- byUniversalIdentifier: {
- [INDEX_VIEW_FIELD_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: INDEX_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- },
- [CALLER_VIEW_FIELD_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: CALLER_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: false,
- },
- },
- },
- },
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(
- Object.keys(result.operations.view?.flatEntityToDelete ?? {}),
- ).toEqual([INDEX_VIEW_UNIVERSAL_IDENTIFIER]);
- expect(
- Object.keys(result.operations.viewField?.flatEntityToDelete ?? {}),
- ).toEqual([INDEX_VIEW_FIELD_UNIVERSAL_IDENTIFIER]);
- });
-
- it('should cascade-delete a system view field of a deleted field even when it lives on another object view', () => {
- const OTHER_OBJECT_VIEW_FIELD_UNIVERSAL_IDENTIFIER =
- 'a1a2a3a4-a5a6-4000-8000-000000000006';
-
- const result = handler.buildSideEffects(
- buildArgs({
- fieldUniversalIdentifiers: [FORWARD_FIELD_UNIVERSAL_IDENTIFIER],
- relatedFlatEntityMaps: {
- flatFieldMetadataMaps: buildFieldMetadataMaps([
- {
- universalIdentifier: FORWARD_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- relationTargetFieldMetadataUniversalIdentifier:
- REVERSE_FIELD_UNIVERSAL_IDENTIFIER,
- },
- {
- universalIdentifier: REVERSE_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- objectMetadataUniversalIdentifier:
- OTHER_OBJECT_UNIVERSAL_IDENTIFIER,
- viewFieldUniversalIdentifiers: [
- OTHER_OBJECT_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- ],
- },
- ]),
- flatViewFieldMaps: {
- byUniversalIdentifier: {
- [OTHER_OBJECT_VIEW_FIELD_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier:
- OTHER_OBJECT_VIEW_FIELD_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- },
- },
- },
- },
- }),
- );
-
- expect(result.status).toBe('success');
-
- if (result.status !== 'success') {
- throw new Error('expected success');
- }
-
- expect(result.operations.view).toBeUndefined();
- expect(
- Object.keys(result.operations.viewField?.flatEntityToDelete ?? {}),
- ).toEqual([OTHER_OBJECT_VIEW_FIELD_UNIVERSAL_IDENTIFIER]);
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/services/__tests__/metadata-side-effect-engine.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/services/__tests__/metadata-side-effect-engine.service.spec.ts
deleted file mode 100644
index 7c9b3cf7eab..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/metadata-side-effect/services/__tests__/metadata-side-effect-engine.service.spec.ts
+++ /dev/null
@@ -1,110 +0,0 @@
-import { MetadataSideEffectExceptionCode } from 'src/engine/metadata-modules/metadata-side-effect/exceptions/metadata-side-effect-exception-code';
-import { MetadataSideEffectEngineService } from 'src/engine/metadata-modules/metadata-side-effect/services/metadata-side-effect-engine.service';
-
-const RESERVED_VIEW_UNIVERSAL_IDENTIFIER =
- 'a1a2a3a4-a5a6-4000-8000-000000000001';
-const OBJECT_UNIVERSAL_IDENTIFIER = 'b1b2b3b4-b5b6-4000-8000-000000000001';
-
-const systemViewEmittingHandler = {
- operation: 'create',
- metadataName: 'objectMetadata',
- name: 'fakeSystemViewEmitter',
- buildSideEffects: () => ({
- status: 'success',
- operations: {
- view: {
- flatEntityToCreate: {
- [RESERVED_VIEW_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: RESERVED_VIEW_UNIVERSAL_IDENTIFIER,
- isSystemSideEffect: true,
- },
- },
- },
- },
- }),
-};
-
-const buildEngine = () => {
- const registry = {
- getRegisteredHandlerKeys: () => [
- { operation: 'create', metadataName: 'objectMetadata' },
- ],
- getHandlers: (operation: string, metadataName: string) =>
- operation === 'create' && metadataName === 'objectMetadata'
- ? [systemViewEmittingHandler]
- : [],
- };
-
- return new MetadataSideEffectEngineService(registry as never);
-};
-
-const buildInput = ({
- callerViewUniversalIdentifier,
-}: {
- callerViewUniversalIdentifier?: string;
-}) =>
- ({
- objectMetadata: {
- flatEntityToCreate: {
- [OBJECT_UNIVERSAL_IDENTIFIER]: {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- },
- },
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- view: {
- flatEntityToCreate:
- callerViewUniversalIdentifier === undefined
- ? {}
- : {
- [callerViewUniversalIdentifier]: {
- universalIdentifier: callerViewUniversalIdentifier,
- isSystemSideEffect: false,
- },
- },
- flatEntityToUpdate: {},
- flatEntityToDelete: {},
- },
- }) as never;
-
-describe('MetadataSideEffectEngineService reserved identifier collision', () => {
- it('should reject a caller-defined entity whose universal identifier collides with a system side effect one', () => {
- const engine = buildEngine();
-
- const result = engine.expandWithSideEffects({
- allFlatEntityOperationRecordByMetadataName: buildInput({
- callerViewUniversalIdentifier: RESERVED_VIEW_UNIVERSAL_IDENTIFIER,
- }),
- sideEffectRelatedFlatEntityMaps: {},
- context: {} as never,
- });
-
- expect(result.status).toBe('fail');
-
- if (result.status !== 'fail') {
- throw new Error('expected fail');
- }
-
- const viewFailures = result.report.view;
-
- expect(viewFailures).toHaveLength(1);
- expect(viewFailures[0].errors[0].code).toBe(
- MetadataSideEffectExceptionCode.RESERVED_SYSTEM_UNIVERSAL_IDENTIFIER,
- );
- });
-
- it('should let a caller-defined entity through when its universal identifier does not collide', () => {
- const engine = buildEngine();
-
- const result = engine.expandWithSideEffects({
- allFlatEntityOperationRecordByMetadataName: buildInput({
- callerViewUniversalIdentifier: 'c1c2c3c4-c5c6-4000-8000-000000000001',
- }),
- sideEffectRelatedFlatEntityMaps: {},
- context: {} as never,
- });
-
- expect(result.status).toBe('success');
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/object-permission/__tests__/object-permission.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/object-permission/__tests__/object-permission.service.spec.ts
deleted file mode 100644
index f5aa1ef8a1f..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/object-permission/__tests__/object-permission.service.spec.ts
+++ /dev/null
@@ -1,291 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { type UpsertObjectPermissionsInput } from 'src/engine/metadata-modules/object-permission/dtos/upsert-object-permissions.input';
-import { ObjectPermissionService } from 'src/engine/metadata-modules/object-permission/object-permission.service';
-import {
- PermissionsException,
- PermissionsExceptionCode,
-} from 'src/engine/metadata-modules/permissions/permissions.exception';
-import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';
-
-const createMockFlatRoleMaps = (roleId: string, isEditable: boolean) => ({
- byUniversalIdentifier: {
- [roleId]: {
- id: roleId,
- universalIdentifier: roleId,
- isEditable,
- canReadAllObjectRecords: true,
- canUpdateAllObjectRecords: true,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- },
- },
- universalIdentifierById: { [roleId]: roleId },
- byId: { [roleId]: { id: roleId, universalIdentifier: roleId, isEditable } },
-});
-
-const createMockFlatObjectMetadataMaps = (
- objectMetadataId: string,
- isSystem: boolean,
-) => ({
- byUniversalIdentifier: {
- [objectMetadataId]: {
- id: objectMetadataId,
- universalIdentifier: objectMetadataId,
- isSystem,
- },
- },
- universalIdentifierById: { [objectMetadataId]: objectMetadataId },
- byId: { [objectMetadataId]: { id: objectMetadataId, isSystem } },
-});
-
-describe('ObjectPermissionService', () => {
- let service: ObjectPermissionService;
- let workspaceManyOrAllFlatEntityMapsCacheService: jest.Mocked<WorkspaceManyOrAllFlatEntityMapsCacheService>;
- let workspaceMigrationValidateBuildAndRunService: jest.Mocked<WorkspaceMigrationValidateBuildAndRunService>;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ObjectPermissionService,
- {
- provide: ApplicationService,
- useValue: {
- findWorkspaceTwentyStandardAndCustomApplicationOrThrow: jest
- .fn()
- .mockResolvedValue({
- workspaceCustomFlatApplication: {
- id: 'app-id',
- universalIdentifier: 'app-universal-id',
- },
- }),
- },
- },
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn(),
- },
- },
- {
- provide: WorkspaceMigrationValidateBuildAndRunService,
- useValue: {
- validateBuildAndRunWorkspaceMigration: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<ObjectPermissionService>(ObjectPermissionService);
- workspaceManyOrAllFlatEntityMapsCacheService = module.get(
- WorkspaceManyOrAllFlatEntityMapsCacheService,
- );
- workspaceMigrationValidateBuildAndRunService = module.get(
- WorkspaceMigrationValidateBuildAndRunService,
- );
- });
-
- describe('upsertObjectPermissions', () => {
- const workspaceId = 'workspace-id';
- const roleId = 'role-id';
- const systemObjectMetadataId = 'system-object-id';
- const customObjectMetadataId = 'custom-object-id';
-
- it('should successfully create object permission for system object', async () => {
- const input: UpsertObjectPermissionsInput = {
- roleId,
- objectPermissions: [
- {
- objectMetadataId: systemObjectMetadataId,
- canReadObjectRecords: true,
- canUpdateObjectRecords: false,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- },
- ],
- };
-
- const permissionUniversalId = 'system-permission-universal-id';
- const freshFlatObjectPermission = {
- id: 'system-permission-id',
- universalIdentifier: permissionUniversalId,
- roleId,
- roleUniversalIdentifier: roleId,
- objectMetadataId: systemObjectMetadataId,
- objectMetadataUniversalIdentifier: systemObjectMetadataId,
- canReadObjectRecords: true,
- canUpdateObjectRecords: false,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- };
-
- workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps
- .mockResolvedValueOnce({
- flatObjectPermissionMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- byId: {},
- },
- flatRoleMaps: createMockFlatRoleMaps(roleId, true),
- flatObjectMetadataMaps: createMockFlatObjectMetadataMaps(
- systemObjectMetadataId,
- true,
- ),
- } as any)
- .mockResolvedValueOnce({
- flatObjectPermissionMaps: {
- byUniversalIdentifier: {
- [permissionUniversalId]: freshFlatObjectPermission,
- },
- universalIdentifierById: {
- [freshFlatObjectPermission.id]: permissionUniversalId,
- },
- byId: {
- [freshFlatObjectPermission.id]: freshFlatObjectPermission,
- },
- },
- } as any);
-
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration.mockResolvedValue(
- { status: 'success' } as any,
- );
-
- const result = await service.upsertObjectPermissions({
- workspaceId,
- input,
- });
-
- expect(result).toHaveLength(1);
- expect(result[0]).toMatchObject({
- objectMetadataId: systemObjectMetadataId,
- canReadObjectRecords: true,
- canUpdateObjectRecords: false,
- });
- expect(
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration,
- ).toHaveBeenCalled();
- });
-
- it('should successfully create object permission for custom (non-system) object', async () => {
- const input: UpsertObjectPermissionsInput = {
- roleId,
- objectPermissions: [
- {
- objectMetadataId: customObjectMetadataId,
- canReadObjectRecords: true,
- canUpdateObjectRecords: true,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- },
- ],
- };
-
- const permissionUniversalId = 'permission-universal-id';
- const freshFlatObjectPermission = {
- id: 'permission-id',
- universalIdentifier: permissionUniversalId,
- roleId,
- roleUniversalIdentifier: roleId,
- objectMetadataId: customObjectMetadataId,
- objectMetadataUniversalIdentifier: customObjectMetadataId,
- canReadObjectRecords: true,
- canUpdateObjectRecords: true,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- };
-
- workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps
- .mockResolvedValueOnce({
- flatObjectPermissionMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- byId: {},
- },
- flatRoleMaps: createMockFlatRoleMaps(roleId, true),
- flatObjectMetadataMaps: createMockFlatObjectMetadataMaps(
- customObjectMetadataId,
- false,
- ),
- } as any)
- .mockResolvedValueOnce({
- flatObjectPermissionMaps: {
- byUniversalIdentifier: {
- [permissionUniversalId]: freshFlatObjectPermission,
- },
- universalIdentifierById: {
- [freshFlatObjectPermission.id]: permissionUniversalId,
- },
- byId: {
- [freshFlatObjectPermission.id]: freshFlatObjectPermission,
- },
- },
- } as any);
-
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration.mockResolvedValue(
- { status: 'success' } as any,
- );
-
- const result = await service.upsertObjectPermissions({
- workspaceId,
- input,
- });
-
- expect(result).toHaveLength(1);
- expect(result[0]).toMatchObject({
- objectMetadataId: customObjectMetadataId,
- canReadObjectRecords: true,
- canUpdateObjectRecords: true,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- });
- expect(
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration,
- ).toHaveBeenCalled();
- });
-
- it('should throw PermissionsException when object metadata is not found', async () => {
- const input: UpsertObjectPermissionsInput = {
- roleId,
- objectPermissions: [
- {
- objectMetadataId: 'non-existent-object-id',
- canReadObjectRecords: true,
- canUpdateObjectRecords: false,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- },
- ],
- };
-
- workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatObjectPermissionMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- byId: {},
- },
- flatRoleMaps: createMockFlatRoleMaps(roleId, true),
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- byId: {},
- },
- } as any,
- );
-
- await expect(
- service.upsertObjectPermissions({
- workspaceId,
- input,
- }),
- ).rejects.toThrow(
- new PermissionsException(
- 'Object metadata id not found',
- PermissionsExceptionCode.OBJECT_METADATA_NOT_FOUND,
- ),
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/object-permission/field-permission/__tests__/field-permissions.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/object-permission/field-permission/__tests__/field-permissions.service.spec.ts
deleted file mode 100644
index 0d236c563dc..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/object-permission/field-permission/__tests__/field-permissions.service.spec.ts
+++ /dev/null
@@ -1,782 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { msg } from '@lingui/core/macro';
-import { type ObjectsPermissionsByRoleId } from 'twenty-shared/types';
-import { type Repository } from 'typeorm';
-
-import {
- fieldRelationMock,
- fieldTextMock,
- objectMetadataItemMock,
-} from 'src/engine/api/__mocks__/object-metadata-item.mock';
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { type UpsertFieldPermissionsInput } from 'src/engine/metadata-modules/object-permission/dtos/upsert-field-permissions.input';
-import { FieldPermissionEntity } from 'src/engine/metadata-modules/object-permission/field-permission/field-permission.entity';
-import { FieldPermissionService } from 'src/engine/metadata-modules/object-permission/field-permission/field-permission.service';
-import {
- PermissionsException,
- PermissionsExceptionCode,
- PermissionsExceptionMessage,
-} from 'src/engine/metadata-modules/permissions/permissions.exception';
-import { RoleEntity } from 'src/engine/metadata-modules/role/role.entity';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
-import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';
-import { getMockFieldMetadataEntity } from 'src/utils/__test__/get-field-metadata-entity.mock';
-
-const emptyFlatFieldPermissionMaps = {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- byId: {},
- idByUniversalIdentifier: {},
- universalIdentifiersByApplicationId: {},
-};
-
-describe('FieldPermissionService', () => {
- let service: FieldPermissionService;
- let fieldPermissionsRepository: jest.Mocked<
- Repository<FieldPermissionEntity>
- >;
- let roleRepository: jest.Mocked<Repository<RoleEntity>>;
- let fieldMetadataRepository: jest.Mocked<Repository<FieldMetadataEntity>>;
- let workspaceCacheService: jest.Mocked<WorkspaceCacheService>;
- let workspaceManyOrAllFlatEntityMapsCacheService: jest.Mocked<WorkspaceManyOrAllFlatEntityMapsCacheService>;
- let workspaceMigrationValidateBuildAndRunService: jest.Mocked<WorkspaceMigrationValidateBuildAndRunService>;
- let flatRoleMaps: {
- byUniversalIdentifier: Record<
- string,
- { id: string; isEditable: boolean; universalIdentifier: string }
- >;
- universalIdentifierById: Record<string, string>;
- byId: Record<string, unknown>;
- idByUniversalIdentifier: Record<string, string>;
- universalIdentifiersByApplicationId: Record<string, string[]>;
- };
-
- const testWorkspaceId = '20202020-0000-0000-0000-000000000000';
- const testRoleId = '20202020-0000-0000-0000-000000000001';
- const testObjectMetadataId = '20202020-0000-0000-0000-000000000002';
- const testFieldMetadataId = fieldTextMock.id;
-
- const mockRole: RoleEntity = {
- id: testRoleId,
- label: 'Test Role',
- description: 'Test role for unit tests',
- canUpdateAllSettings: false,
- canReadAllObjectRecords: true,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- workspaceId: testWorkspaceId,
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- } as RoleEntity;
-
- const mockRolesPermissions: ObjectsPermissionsByRoleId = {
- [testRoleId]: {
- [testObjectMetadataId]: {
- canReadObjectRecords: true,
- canUpdateObjectRecords: true,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- restrictedFields: {},
- rowLevelPermissionPredicates: [],
- rowLevelPermissionPredicateGroups: [],
- },
- [fieldRelationMock.objectMetadataId]: {
- canReadObjectRecords: true,
- canUpdateObjectRecords: true,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- restrictedFields: {},
- rowLevelPermissionPredicates: [],
- rowLevelPermissionPredicateGroups: [],
- },
- },
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- FieldPermissionService,
- {
- provide: getRepositoryToken(RoleEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(FieldPermissionEntity),
- useValue: {
- find: jest.fn(),
- upsert: jest.fn(),
- delete: jest.fn(),
- },
- },
- {
- provide: WorkspaceCacheService,
- useValue: {
- getOrRecompute: jest.fn(),
- invalidate: jest.fn(),
- invalidateAndRecompute: jest.fn(),
- },
- },
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(FieldMetadataEntity),
- useValue: {
- find: jest.fn(),
- },
- },
- {
- provide: ApplicationService,
- useValue: {
- findWorkspaceTwentyStandardAndCustomApplicationOrThrow: jest
- .fn()
- .mockResolvedValue({
- workspaceCustomFlatApplication: {
- id: 'app-id',
- universalIdentifier: 'app-universal-id',
- },
- }),
- },
- },
- {
- provide: WorkspaceMigrationValidateBuildAndRunService,
- useValue: {
- validateBuildAndRunWorkspaceMigration: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<FieldPermissionService>(FieldPermissionService);
- workspaceMigrationValidateBuildAndRunService = module.get(
- WorkspaceMigrationValidateBuildAndRunService,
- );
- fieldPermissionsRepository = module.get(
- getRepositoryToken(FieldPermissionEntity),
- );
- roleRepository = module.get(getRepositoryToken(RoleEntity));
- fieldMetadataRepository = module.get(
- getRepositoryToken(FieldMetadataEntity),
- );
- workspaceCacheService = module.get(WorkspaceCacheService);
- workspaceManyOrAllFlatEntityMapsCacheService = module.get(
- WorkspaceManyOrAllFlatEntityMapsCacheService,
- );
-
- // Setup default mocks
- roleRepository.findOne.mockResolvedValue(mockRole);
- fieldMetadataRepository.find.mockResolvedValue([
- fieldTextMock,
- fieldRelationMock,
- ]);
- (workspaceCacheService.getOrRecompute as jest.Mock).mockImplementation(
- (_workspaceId: string, keys: string[]) => {
- if (keys?.includes('flatFieldPermissionMaps')) {
- return Promise.resolve({
- flatFieldPermissionMaps: emptyFlatFieldPermissionMaps,
- });
- }
- if (keys?.includes('rolesPermissions')) {
- return Promise.resolve({ rolesPermissions: mockRolesPermissions });
- }
- return Promise.resolve({});
- },
- );
- const testFieldMetadata = getMockFieldMetadataEntity({
- ...fieldTextMock,
- label: 'Test Field',
- objectMetadataId: testObjectMetadataId,
- workspaceId: testWorkspaceId,
- id: testFieldMetadataId,
- });
-
- flatRoleMaps = {
- byUniversalIdentifier: {
- [testRoleId]: {
- id: testRoleId,
- isEditable: true,
- universalIdentifier: testRoleId,
- },
- },
- universalIdentifierById: { [testRoleId]: testRoleId },
- byId: {},
- idByUniversalIdentifier: {},
- universalIdentifiersByApplicationId: {},
- };
- workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatRoleMaps,
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- [testObjectMetadataId]: {
- ...objectMetadataItemMock,
- id: testObjectMetadataId,
- fieldIds: [testFieldMetadataId],
- indexMetadataIds: [],
- viewIds: [],
- universalIdentifier: testObjectMetadataId,
- applicationId: null,
- } as any,
- [fieldRelationMock.objectMetadataId]: {
- ...objectMetadataItemMock,
- id: fieldRelationMock.objectMetadataId,
- fieldIds: [fieldRelationMock.id],
- indexMetadataIds: [],
- viewIds: [],
- universalIdentifier: fieldRelationMock.objectMetadataId,
- applicationId: null,
- } as any,
- [fieldRelationMock.relationTargetObjectMetadataId!]: {
- ...objectMetadataItemMock,
- id: fieldRelationMock.relationTargetObjectMetadataId,
- fieldIds: [fieldRelationMock.relationTargetFieldMetadataId!],
- indexMetadataIds: [],
- viewIds: [],
- universalIdentifier:
- fieldRelationMock.relationTargetObjectMetadataId,
- applicationId: null,
- } as any,
- },
- universalIdentifierById: {
- [testObjectMetadataId]: testObjectMetadataId,
- [fieldRelationMock.objectMetadataId]:
- fieldRelationMock.objectMetadataId,
- [fieldRelationMock.relationTargetObjectMetadataId!]:
- fieldRelationMock.relationTargetObjectMetadataId!,
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- [testFieldMetadata.universalIdentifier]: testFieldMetadata as any,
- [fieldRelationMock.universalIdentifier]: fieldRelationMock as any,
- [fieldRelationMock.relationTargetFieldMetadataId!]: {
- ...fieldRelationMock,
- id: fieldRelationMock.relationTargetFieldMetadataId,
- universalIdentifier:
- fieldRelationMock.relationTargetFieldMetadataId,
- } as any,
- },
- universalIdentifierById: {
- [testFieldMetadataId]: testFieldMetadata.universalIdentifier,
- [fieldRelationMock.id]: fieldRelationMock.universalIdentifier,
- [fieldRelationMock.relationTargetFieldMetadataId!]:
- fieldRelationMock.relationTargetFieldMetadataId!,
- },
- universalIdentifiersByApplicationId: {},
- },
- } as any,
- );
- fieldPermissionsRepository.find.mockResolvedValue([]);
- fieldPermissionsRepository.upsert.mockResolvedValue({} as any);
- fieldPermissionsRepository.delete.mockResolvedValue({} as any);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('upsertFieldPermissions', () => {
- const createUpsertInput = (
- fieldPermissions: {
- canReadFieldValue?: boolean | null;
- canUpdateFieldValue?: boolean | null;
- objectMetadataId?: string;
- fieldMetadataId?: string;
- }[],
- ): UpsertFieldPermissionsInput => ({
- roleId: testRoleId,
- fieldPermissions: fieldPermissions.map((fieldPermission) => ({
- objectMetadataId: testObjectMetadataId,
- fieldMetadataId: testFieldMetadataId,
- ...fieldPermission,
- })),
- });
-
- describe('successful cases', () => {
- it('should successfully upsert field permissions', async () => {
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration.mockResolvedValue(
- { status: 'success' } as any,
- );
-
- const input = createUpsertInput([
- {
- canReadFieldValue: false,
- canUpdateFieldValue: false,
- },
- ]);
-
- const result = await service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- });
-
- expect(
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration,
- ).toHaveBeenCalledWith(
- expect.objectContaining({
- workspaceId: testWorkspaceId,
- isSystemBuild: false,
- allFlatEntityOperationByMetadataName: expect.objectContaining({
- fieldPermission: expect.objectContaining({
- flatEntityToCreate: expect.any(Array),
- flatEntityToUpdate: expect.any(Array),
- flatEntityToDelete: expect.any(Array),
- }),
- }),
- }),
- );
- expect(result).toEqual(expect.any(Array));
- expect(
- workspaceCacheService.invalidateAndRecompute,
- ).toHaveBeenCalledWith(testWorkspaceId, ['rolesPermissions']);
- });
-
- it('should delete field permissions when both canReadFieldValue and canUpdateFieldValue are null', async () => {
- const existingUniversalId = 'existing-fp-universal-id';
- const mapsWithOneCurrentPermission = {
- ...emptyFlatFieldPermissionMaps,
- byUniversalIdentifier: {
- [existingUniversalId]: {
- id: 'existing-fp-id',
- universalIdentifier: existingUniversalId,
- roleUniversalIdentifier: testRoleId,
- objectMetadataId: testObjectMetadataId,
- fieldMetadataId: testFieldMetadataId,
- canReadFieldValue: undefined,
- canUpdateFieldValue: false,
- applicationUniversalIdentifier: 'app-ui',
- objectMetadataUniversalIdentifier: testObjectMetadataId,
- fieldMetadataUniversalIdentifier: testFieldMetadataId,
- createdAt: new Date().toISOString(),
- updatedAt: new Date().toISOString(),
- },
- },
- universalIdentifierById: { 'existing-fp-id': existingUniversalId },
- };
- let flatFieldPermissionMapsCallCount = 0;
- (workspaceCacheService.getOrRecompute as jest.Mock).mockImplementation(
- (_w: string, keys: string[]) => {
- if (keys?.includes('flatFieldPermissionMaps')) {
- flatFieldPermissionMapsCallCount += 1;
- return Promise.resolve({
- flatFieldPermissionMaps:
- flatFieldPermissionMapsCallCount === 1
- ? mapsWithOneCurrentPermission
- : emptyFlatFieldPermissionMaps,
- });
- }
- if (keys?.includes('rolesPermissions')) {
- return Promise.resolve({
- rolesPermissions: mockRolesPermissions,
- });
- }
- return Promise.resolve({});
- },
- );
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration.mockResolvedValue(
- { status: 'success' } as any,
- );
-
- const input = createUpsertInput([
- {
- canReadFieldValue: null,
- canUpdateFieldValue: null,
- },
- ]);
-
- await service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- });
-
- expect(
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration,
- ).toHaveBeenCalledWith(
- expect.objectContaining({
- allFlatEntityOperationByMetadataName: expect.objectContaining({
- fieldPermission: expect.objectContaining({
- flatEntityToDelete: expect.arrayContaining([
- expect.objectContaining({
- universalIdentifier: existingUniversalId,
- }),
- ]),
- }),
- }),
- }),
- );
- });
-
- it('should not delete field permissions when one value is null and the other is false', async () => {
- const existingUniversalId = 'existing-fp-ui-2';
- const mapsWithOneCurrent = {
- ...emptyFlatFieldPermissionMaps,
- byUniversalIdentifier: {
- [existingUniversalId]: {
- id: 'existing-fp-id-2',
- universalIdentifier: existingUniversalId,
- roleUniversalIdentifier: testRoleId,
- objectMetadataId: testObjectMetadataId,
- fieldMetadataId: testFieldMetadataId,
- canReadFieldValue: false,
- canUpdateFieldValue: undefined,
- applicationUniversalIdentifier: 'app-ui',
- objectMetadataUniversalIdentifier: testObjectMetadataId,
- fieldMetadataUniversalIdentifier: testFieldMetadataId,
- createdAt: new Date().toISOString(),
- updatedAt: new Date().toISOString(),
- },
- },
- universalIdentifierById: { 'existing-fp-id-2': existingUniversalId },
- };
- let flatMapsCallCount = 0;
- (workspaceCacheService.getOrRecompute as jest.Mock).mockImplementation(
- (_w: string, keys: string[]) => {
- if (keys?.includes('flatFieldPermissionMaps')) {
- flatMapsCallCount += 1;
- return Promise.resolve({
- flatFieldPermissionMaps:
- flatMapsCallCount === 1
- ? mapsWithOneCurrent
- : emptyFlatFieldPermissionMaps,
- });
- }
- if (keys?.includes('rolesPermissions')) {
- return Promise.resolve({
- rolesPermissions: mockRolesPermissions,
- });
- }
- return Promise.resolve({});
- },
- );
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration.mockResolvedValue(
- { status: 'success' } as any,
- );
-
- const input = createUpsertInput([
- {
- canUpdateFieldValue: false,
- canReadFieldValue: null,
- },
- ]);
-
- await service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- });
-
- const callArg = workspaceMigrationValidateBuildAndRunService
- .validateBuildAndRunWorkspaceMigration.mock
- .calls[0][0] as unknown as {
- allFlatEntityOperationByMetadataName: {
- fieldPermission: { flatEntityToDelete: unknown[] };
- };
- };
- expect(
- callArg.allFlatEntityOperationByMetadataName.fieldPermission
- .flatEntityToDelete,
- ).toHaveLength(0);
- });
- });
-
- describe('relation cases', () => {
- it('should create two field permissions when a relation field permission is created', async () => {
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration.mockResolvedValue(
- { status: 'success' } as any,
- );
-
- const input = createUpsertInput([
- {
- canReadFieldValue: false,
- canUpdateFieldValue: false,
- fieldMetadataId: fieldRelationMock.id,
- objectMetadataId: fieldRelationMock.objectMetadataId,
- },
- ]);
-
- await service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- });
-
- const callArg = workspaceMigrationValidateBuildAndRunService
- .validateBuildAndRunWorkspaceMigration.mock
- .calls[0][0] as unknown as {
- allFlatEntityOperationByMetadataName: {
- fieldPermission: { flatEntityToCreate: unknown[] };
- };
- };
- expect(
- callArg.allFlatEntityOperationByMetadataName.fieldPermission
- .flatEntityToCreate,
- ).toHaveLength(2);
- });
- });
-
- describe('validation errors', () => {
- it('should throw error when canReadFieldValue is true', async () => {
- const input = createUpsertInput([
- {
- canReadFieldValue: true,
- canUpdateFieldValue: false,
- },
- ]);
-
- await expect(
- service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- }),
- ).rejects.toThrow(
- new PermissionsException(
- PermissionsExceptionMessage.ONLY_FIELD_RESTRICTION_ALLOWED,
- PermissionsExceptionCode.ONLY_FIELD_RESTRICTION_ALLOWED,
- ),
- );
- });
-
- it('should throw error when canUpdateFieldValue is true', async () => {
- const input = createUpsertInput([
- {
- canReadFieldValue: false,
- canUpdateFieldValue: true,
- },
- ]);
-
- await expect(
- service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- }),
- ).rejects.toThrow(
- new PermissionsException(
- PermissionsExceptionMessage.ONLY_FIELD_RESTRICTION_ALLOWED,
- PermissionsExceptionCode.ONLY_FIELD_RESTRICTION_ALLOWED,
- ),
- );
- });
-
- it('should throw error when object metadata is not found', async () => {
- workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatRoleMaps,
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- } as any,
- );
-
- const input = createUpsertInput([
- {
- objectMetadataId: 'non-existent-object',
- canReadFieldValue: false,
- canUpdateFieldValue: false,
- },
- ]);
-
- await expect(
- service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- }),
- ).rejects.toThrow(
- new PermissionsException(
- PermissionsExceptionMessage.OBJECT_METADATA_NOT_FOUND,
- PermissionsExceptionCode.OBJECT_METADATA_NOT_FOUND,
- ),
- );
- });
-
- it('should throw error when trying to add field permission on system object', async () => {
- const systemObjectMetadata = {
- ...objectMetadataItemMock,
- isSystem: true,
- };
-
- workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatRoleMaps,
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- [testObjectMetadataId]: {
- ...systemObjectMetadata,
- id: testObjectMetadataId,
- fieldIds: [],
- indexMetadataIds: [],
- viewIds: [],
- universalIdentifier: testObjectMetadataId,
- applicationId: null,
- } as any,
- },
- universalIdentifierById: {
- [testObjectMetadataId]: testObjectMetadataId,
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- } as any,
- );
-
- const input = createUpsertInput([
- {
- canReadFieldValue: false,
- canUpdateFieldValue: false,
- },
- ]);
-
- await expect(
- service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- }),
- ).rejects.toThrow(
- new PermissionsException(
- PermissionsExceptionMessage.CANNOT_ADD_FIELD_PERMISSION_ON_SYSTEM_OBJECT,
- PermissionsExceptionCode.CANNOT_ADD_FIELD_PERMISSION_ON_SYSTEM_OBJECT,
- ),
- );
- });
-
- it('should throw error when field metadata is not found', async () => {
- workspaceManyOrAllFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatRoleMaps,
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- [testObjectMetadataId]: {
- ...objectMetadataItemMock,
- id: testObjectMetadataId,
- fieldIds: [],
- indexMetadataIds: [],
- viewIds: [],
- universalIdentifier: testObjectMetadataId,
- applicationId: null,
- } as any,
- },
- universalIdentifierById: {
- [testObjectMetadataId]: testObjectMetadataId,
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- } as any,
- );
-
- const input = createUpsertInput([
- {
- fieldMetadataId: 'non-existent-field',
- canReadFieldValue: false,
- canUpdateFieldValue: false,
- },
- ]);
-
- await expect(
- service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- }),
- ).rejects.toThrow(
- new PermissionsException(
- PermissionsExceptionMessage.FIELD_METADATA_NOT_FOUND,
- PermissionsExceptionCode.FIELD_METADATA_NOT_FOUND,
- ),
- );
- });
-
- it('should throw error when object permission is not found', async () => {
- (workspaceCacheService.getOrRecompute as jest.Mock).mockImplementation(
- (_w: string, keys: string[]) => {
- if (keys?.includes('flatFieldPermissionMaps')) {
- return Promise.resolve({
- flatFieldPermissionMaps: emptyFlatFieldPermissionMaps,
- });
- }
- if (keys?.includes('rolesPermissions')) {
- return Promise.resolve({ rolesPermissions: {} });
- }
- return Promise.resolve({});
- },
- );
-
- const input = createUpsertInput([
- {
- canReadFieldValue: false,
- canUpdateFieldValue: false,
- },
- ]);
-
- await expect(
- service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- }),
- ).rejects.toThrow(
- new PermissionsException(
- PermissionsExceptionMessage.OBJECT_PERMISSION_NOT_FOUND,
- PermissionsExceptionCode.OBJECT_PERMISSION_NOT_FOUND,
- ),
- );
- });
- });
-
- describe('role validation errors', () => {
- it('should throw error when role is not editable', async () => {
- workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration.mockResolvedValue(
- {
- status: 'fail',
- report: {
- fieldPermission: [
- {
- code: PermissionsExceptionCode.ROLE_NOT_EDITABLE,
- message: 'Role is not editable',
- userFriendlyMessage: msg`This role cannot be modified.`,
- },
- ],
- },
- } as any,
- );
-
- const input = createUpsertInput([
- {
- canReadFieldValue: false,
- canUpdateFieldValue: false,
- },
- ]);
-
- await expect(
- service.upsertFieldPermissions({
- workspaceId: testWorkspaceId,
- input,
- }),
- ).rejects.toThrow(WorkspaceMigrationBuilderException);
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/permissions/__tests__/permissions.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/permissions/__tests__/permissions.service.spec.ts
deleted file mode 100644
index 478a53e3617..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/permissions/__tests__/permissions.service.spec.ts
+++ /dev/null
@@ -1,814 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import {
- PermissionFlagType,
- SystemPermissionFlag,
-} from 'twenty-shared/constants';
-
-import { ApiKeyRoleService } from 'src/engine/core-modules/api-key/services/api-key-role.service';
-import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';
-import { ApplicationException } from 'src/engine/core-modules/application/application.exception';
-import { createEmptyFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-flat-entity-maps.constant';
-import { type SyncableFlatEntity } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-from.type';
-import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
-import { addFlatEntityToFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/add-flat-entity-to-flat-entity-maps-or-throw.util';
-import { type FlatRolePermissionFlag } from 'src/engine/metadata-modules/flat-role-permission-flag/types/flat-role-permission-flag.type';
-import { type FlatRole } from 'src/engine/metadata-modules/flat-role/types/flat-role.type';
-import { PermissionsService } from 'src/engine/metadata-modules/permissions/permissions.service';
-import { RoleEntity } from 'src/engine/metadata-modules/role/role.entity';
-import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';
-import { type RolePermissionConfig } from 'src/engine/twenty-orm/types/role-permission-config';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-
-const buildFlatEntityMaps = <T extends SyncableFlatEntity>(
- entities: T[],
-): FlatEntityMaps<T> =>
- entities.reduce(
- (maps, entity) =>
- addFlatEntityToFlatEntityMapsOrThrow({
- flatEntity: entity,
- flatEntityMaps: maps,
- }),
- createEmptyFlatEntityMaps() as FlatEntityMaps<T>,
- );
-
-describe('PermissionsService', () => {
- let service: PermissionsService;
- let roleRepository: { find: jest.Mock };
- let workspaceCacheService: { getOrRecompute: jest.Mock };
- let userRoleService: { getRolesByUserWorkspaces: jest.Mock };
- let applicationRepository: { findOne: jest.Mock };
-
- beforeEach(async () => {
- roleRepository = {
- find: jest.fn(),
- };
- workspaceCacheService = {
- getOrRecompute: jest.fn(),
- };
- userRoleService = {
- getRolesByUserWorkspaces: jest.fn(),
- };
- applicationRepository = {
- findOne: jest.fn(),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- PermissionsService,
- {
- provide: getWorkspaceScopedRepositoryToken(RoleEntity),
- useValue: roleRepository,
- },
- {
- provide: ApiKeyRoleService,
- useValue: {},
- },
- {
- provide: UserRoleService,
- useValue: userRoleService,
- },
- {
- provide: WorkspaceCacheService,
- useValue: workspaceCacheService,
- },
- {
- provide: getRepositoryToken(ApplicationEntity),
- useValue: applicationRepository,
- },
- ],
- }).compile();
-
- service = module.get<PermissionsService>(PermissionsService);
- });
-
- describe('checkRolePermissions', () => {
- describe('canAccessAllTools for tool permissions', () => {
- it('should grant permission when canAccessAllTools is true for a tool permission', () => {
- const roleWithAllTools: Partial<RoleEntity> = {
- id: 'test-role-id',
- label: 'Test Role',
- description: 'Test role description',
- icon: 'IconTest',
- canAccessAllTools: true,
- canUpdateAllSettings: false,
- canReadAllObjectRecords: false,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- canBeAssignedToUsers: true,
- canBeAssignedToAgents: true,
- canBeAssignedToApiKeys: true,
- rolePermissionFlags: [],
- workspaceId: 'test-workspace-id',
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- };
-
- // Test all tool permissions
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.UPLOAD_FILE,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.DOWNLOAD_FILE,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.AI,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.VIEWS,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.SEND_EMAIL_TOOL,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.IMPORT_CSV,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.EXPORT_CSV,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.CONNECTED_ACCOUNTS,
- ),
- ).toBe(true);
- });
-
- it('should NOT grant settings permissions when canAccessAllTools is true', () => {
- const roleWithAllTools: Partial<RoleEntity> = {
- id: 'test-role-id',
- label: 'Test Role',
- description: 'Test role description',
- icon: 'IconTest',
- canAccessAllTools: true,
- canUpdateAllSettings: false,
- canReadAllObjectRecords: false,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- canBeAssignedToUsers: true,
- canBeAssignedToAgents: true,
- canBeAssignedToApiKeys: true,
- rolePermissionFlags: [],
- workspaceId: 'test-workspace-id',
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- };
-
- // Test that settings permissions are NOT granted
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.ROLES,
- ),
- ).toBe(false);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.WORKSPACE,
- ),
- ).toBe(false);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.DATA_MODEL,
- ),
- ).toBe(false);
- expect(
- service.checkRolePermissions(
- roleWithAllTools as RoleEntity,
- PermissionFlagType.SECURITY,
- ),
- ).toBe(false);
- });
- });
-
- describe('canUpdateAllSettings for settings permissions', () => {
- it('should grant permission when canUpdateAllSettings is true for a settings permission', () => {
- const roleWithAllSettings: Partial<RoleEntity> = {
- id: 'test-role-id',
- label: 'Test Role',
- description: 'Test role description',
- icon: 'IconTest',
- canAccessAllTools: false,
- canUpdateAllSettings: true,
- canReadAllObjectRecords: false,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- canBeAssignedToUsers: true,
- canBeAssignedToAgents: true,
- canBeAssignedToApiKeys: true,
- rolePermissionFlags: [],
- roleTargets: [],
- objectPermissions: [],
- fieldPermissions: [],
- workspaceId: 'test-workspace-id',
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- };
-
- // Test all settings permissions
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.ROLES,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.WORKSPACE,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.DATA_MODEL,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.SECURITY,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.WORKFLOWS,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.WORKSPACE_MEMBERS,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.API_KEYS_AND_WEBHOOKS,
- ),
- ).toBe(true);
- });
-
- it('should NOT grant tool permissions when canUpdateAllSettings is true', () => {
- const roleWithAllSettings: Partial<RoleEntity> = {
- id: 'test-role-id',
- label: 'Test Role',
- description: 'Test role description',
- icon: 'IconTest',
- canAccessAllTools: false,
- canUpdateAllSettings: true,
- canReadAllObjectRecords: false,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- canBeAssignedToUsers: true,
- canBeAssignedToAgents: true,
- canBeAssignedToApiKeys: true,
- rolePermissionFlags: [],
- roleTargets: [],
- objectPermissions: [],
- fieldPermissions: [],
- workspaceId: 'test-workspace-id',
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- };
-
- // Test that tool permissions are NOT granted
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.UPLOAD_FILE,
- ),
- ).toBe(false);
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.DOWNLOAD_FILE,
- ),
- ).toBe(false);
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.AI,
- ),
- ).toBe(false);
- expect(
- service.checkRolePermissions(
- roleWithAllSettings as RoleEntity,
- PermissionFlagType.VIEWS,
- ),
- ).toBe(false);
- });
- });
-
- describe('Granular permissions with rolePermissionFlags', () => {
- it('should grant specific tool permission when included in rolePermissionFlags even if canAccessAllTools is false', () => {
- const roleWithSpecificPermission: Partial<RoleEntity> = {
- id: 'test-role-id',
- label: 'Test Role',
- description: 'Test role description',
- icon: 'IconTest',
- canAccessAllTools: false,
- canUpdateAllSettings: false,
- canReadAllObjectRecords: false,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- canBeAssignedToUsers: true,
- canBeAssignedToAgents: true,
- canBeAssignedToApiKeys: true,
- rolePermissionFlags: [
- {
- id: 'permission-1',
- permissionFlag: {
- key: PermissionFlagType.UPLOAD_FILE,
- universalIdentifier: SystemPermissionFlag.UPLOAD_FILE,
- },
- roleId: 'test-role-id',
- workspaceId: 'test-workspace-id',
- createdAt: new Date(),
- updatedAt: new Date(),
- },
- ] as any,
- workspaceId: 'test-workspace-id',
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- };
-
- expect(
- service.checkRolePermissions(
- roleWithSpecificPermission as RoleEntity,
- PermissionFlagType.UPLOAD_FILE,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithSpecificPermission as RoleEntity,
- PermissionFlagType.DOWNLOAD_FILE,
- ),
- ).toBe(false);
- });
-
- it('should grant specific settings permission when included in rolePermissionFlags even if canUpdateAllSettings is false', () => {
- const roleWithSpecificPermission: Partial<RoleEntity> = {
- id: 'test-role-id',
- label: 'Test Role',
- description: 'Test role description',
- icon: 'IconTest',
- canAccessAllTools: false,
- canUpdateAllSettings: false,
- canReadAllObjectRecords: false,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- canBeAssignedToUsers: true,
- canBeAssignedToAgents: true,
- canBeAssignedToApiKeys: true,
- rolePermissionFlags: [
- {
- id: 'permission-1',
- permissionFlag: {
- key: PermissionFlagType.ROLES,
- universalIdentifier: SystemPermissionFlag.ROLES,
- },
- roleId: 'test-role-id',
- workspaceId: 'test-workspace-id',
- createdAt: new Date(),
- updatedAt: new Date(),
- },
- ] as any,
- workspaceId: 'test-workspace-id',
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- };
-
- expect(
- service.checkRolePermissions(
- roleWithSpecificPermission as RoleEntity,
- PermissionFlagType.ROLES,
- ),
- ).toBe(true);
- expect(
- service.checkRolePermissions(
- roleWithSpecificPermission as RoleEntity,
- PermissionFlagType.WORKSPACE,
- ),
- ).toBe(false);
- });
- });
-
- describe('No permissions', () => {
- it('should deny all permissions when neither canAccessAllTools nor canUpdateAllSettings are true and no specific permissions', () => {
- const roleWithNoPermissions: Partial<RoleEntity> = {
- id: 'test-role-id',
- label: 'Test Role',
- description: 'Test role description',
- icon: 'IconTest',
- canAccessAllTools: false,
- canUpdateAllSettings: false,
- canReadAllObjectRecords: false,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- canBeAssignedToUsers: true,
- canBeAssignedToAgents: true,
- canBeAssignedToApiKeys: true,
- rolePermissionFlags: [],
- roleTargets: [],
- objectPermissions: [],
- fieldPermissions: [],
- workspaceId: 'test-workspace-id',
- createdAt: new Date(),
- updatedAt: new Date(),
- isEditable: true,
- };
-
- // Tool permissions should be denied
- expect(
- service.checkRolePermissions(
- roleWithNoPermissions as RoleEntity,
- PermissionFlagType.UPLOAD_FILE,
- ),
- ).toBe(false);
- expect(
- service.checkRolePermissions(
- roleWithNoPermissions as RoleEntity,
- PermissionFlagType.AI,
- ),
- ).toBe(false);
-
- // Settings permissions should be denied
- expect(
- service.checkRolePermissions(
- roleWithNoPermissions as RoleEntity,
- PermissionFlagType.ROLES,
- ),
- ).toBe(false);
- expect(
- service.checkRolePermissions(
- roleWithNoPermissions as RoleEntity,
- PermissionFlagType.WORKSPACE,
- ),
- ).toBe(false);
- });
- });
- });
-
- describe.each([
- {
- evaluator: 'checkRolesPermissions' as const,
- permissionFlag: PermissionFlagType.DATA_MODEL,
- basePermission: 'canUpdateAllSettings' as const,
- },
- {
- evaluator: 'hasToolPermission' as const,
- permissionFlag: PermissionFlagType.HTTP_REQUEST_TOOL,
- basePermission: 'canAccessAllTools' as const,
- },
- ])(
- '$evaluator from workspace cache',
- ({ evaluator, permissionFlag, basePermission }) => {
- const workspaceId = 'test-workspace-id';
- const createFlatRole = ({
- id,
- hasBasePermission = false,
- rolePermissionFlagIds = [],
- }: {
- id: string;
- hasBasePermission?: boolean;
- rolePermissionFlagIds?: string[];
- }): FlatRole =>
- ({
- id,
- universalIdentifier: `${id}-universal-identifier`,
- canAccessAllTools: false,
- canUpdateAllSettings: false,
- rolePermissionFlagIds,
- [basePermission]: hasBasePermission,
- }) as FlatRole;
- const createFlatRolePermissionFlag = ({
- id,
- permissionFlagUniversalIdentifier,
- }: {
- id: string;
- permissionFlagUniversalIdentifier: string;
- }): FlatRolePermissionFlag =>
- ({
- id,
- universalIdentifier: `${id}-universal-identifier`,
- permissionFlagUniversalIdentifier,
- }) as FlatRolePermissionFlag;
- const mockCachedPermissions = ({
- roles,
- rolePermissionFlags = [],
- }: {
- roles: FlatRole[];
- rolePermissionFlags?: FlatRolePermissionFlag[];
- }) => {
- workspaceCacheService.getOrRecompute.mockResolvedValue({
- flatRoleMaps: buildFlatEntityMaps(roles),
- flatRolePermissionFlagMaps: buildFlatEntityMaps(rolePermissionFlags),
- });
- };
- const evaluate = (rolePermissionConfig: RolePermissionConfig) =>
- service[evaluator](rolePermissionConfig, workspaceId, permissionFlag);
-
- afterEach(() => {
- expect(roleRepository.find).not.toHaveBeenCalled();
- });
-
- it('preserves union and intersection semantics', async () => {
- const grantingRole = createFlatRole({
- id: 'granting-role-id',
- hasBasePermission: true,
- });
- const denyingRole = createFlatRole({
- id: 'denying-role-id',
- });
-
- mockCachedPermissions({
- roles: [grantingRole, denyingRole],
- });
-
- await expect(
- evaluate({ unionOf: [grantingRole.id, denyingRole.id] }),
- ).resolves.toBe(true);
- await expect(
- evaluate({ intersectionOf: [grantingRole.id, denyingRole.id] }),
- ).resolves.toBe(false);
- expect(workspaceCacheService.getOrRecompute).toHaveBeenCalledWith(
- workspaceId,
- ['flatRoleMaps', 'flatRolePermissionFlagMaps'],
- );
- });
-
- it('grants an explicitly assigned permission flag', async () => {
- const rolePermissionFlag = createFlatRolePermissionFlag({
- id: 'role-permission-flag-id',
- permissionFlagUniversalIdentifier:
- SystemPermissionFlag[permissionFlag],
- });
- const role = createFlatRole({
- id: 'role-id',
- rolePermissionFlagIds: [rolePermissionFlag.id],
- });
-
- mockCachedPermissions({
- roles: [role],
- rolePermissionFlags: [rolePermissionFlag],
- });
-
- await expect(evaluate({ unionOf: [role.id] })).resolves.toBe(true);
- });
-
- it('denies an unrelated permission flag', async () => {
- const rolePermissionFlag = createFlatRolePermissionFlag({
- id: 'role-permission-flag-id',
- permissionFlagUniversalIdentifier: SystemPermissionFlag.WORKSPACE,
- });
- const role = createFlatRole({
- id: 'role-id',
- rolePermissionFlagIds: [rolePermissionFlag.id],
- });
-
- mockCachedPermissions({
- roles: [role],
- rolePermissionFlags: [rolePermissionFlag],
- });
-
- await expect(evaluate({ unionOf: [role.id] })).resolves.toBe(false);
- });
-
- it('bypasses checks without loading the cache', async () => {
- await expect(
- evaluate({ shouldBypassPermissionChecks: true }),
- ).resolves.toBe(true);
- expect(workspaceCacheService.getOrRecompute).not.toHaveBeenCalled();
- });
-
- it('fails closed for invalid or missing roles', async () => {
- const role = createFlatRole({
- id: 'role-id',
- hasBasePermission: true,
- });
-
- mockCachedPermissions({ roles: [role] });
-
- await expect(evaluate({ unionOf: [] })).resolves.toBe(false);
- await expect(evaluate({ unionOf: [role.id, role.id] })).resolves.toBe(
- false,
- );
- await expect(
- evaluate({ unionOf: [role.id, 'missing-role-id'] }),
- ).resolves.toBe(false);
- });
-
- it('fails closed when the workspace cache is unavailable', async () => {
- workspaceCacheService.getOrRecompute.mockRejectedValue(
- new Error('Cache unavailable'),
- );
-
- await expect(evaluate({ unionOf: ['role-id'] })).resolves.toBe(false);
- });
- },
- );
-
- describe('userHasWorkspaceSettingPermission with an application acting for a user', () => {
- const workspaceId = 'test-workspace-id';
- const userWorkspaceId = 'test-user-workspace-id';
- const applicationId = 'test-application-id';
- const setting = PermissionFlagType.DATA_MODEL;
-
- const createFlatRole = ({
- id,
- canUpdateAllSettings,
- }: {
- id: string;
- canUpdateAllSettings: boolean;
- }): FlatRole =>
- ({
- id,
- universalIdentifier: `${id}-universal-identifier`,
- canAccessAllTools: false,
- canUpdateAllSettings,
- rolePermissionFlagIds: [],
- }) as unknown as FlatRole;
-
- const mockUserRole = (role: FlatRole) => {
- userRoleService.getRolesByUserWorkspaces.mockResolvedValue(
- new Map([
- [
- userWorkspaceId,
- [
- {
- id: role.id,
- canUpdateAllSettings: role.canUpdateAllSettings,
- canAccessAllTools: role.canAccessAllTools,
- rolePermissionFlags: [],
- } as unknown as RoleEntity,
- ],
- ],
- ]),
- );
- };
-
- const mockApplicationRole = (defaultRoleId: string | null) => {
- applicationRepository.findOne.mockResolvedValue({
- id: applicationId,
- defaultRoleId,
- });
- };
-
- const mockCachedRoles = (roles: FlatRole[]) => {
- workspaceCacheService.getOrRecompute.mockResolvedValue({
- flatRoleMaps: buildFlatEntityMaps(roles),
- flatRolePermissionFlagMaps: buildFlatEntityMaps([]),
- });
- };
-
- const check = () =>
- service.userHasWorkspaceSettingPermission({
- userWorkspaceId,
- workspaceId,
- setting,
- applicationId,
- });
-
- it('should deny when the application role denies, even though the user role grants', async () => {
- const userRole = createFlatRole({
- id: 'user-role-id',
- canUpdateAllSettings: true,
- });
- const applicationRole = createFlatRole({
- id: 'application-role-id',
- canUpdateAllSettings: false,
- });
-
- mockUserRole(userRole);
- mockApplicationRole(applicationRole.id);
- mockCachedRoles([userRole, applicationRole]);
-
- await expect(check()).resolves.toBe(false);
- });
-
- it('should deny when the user role denies, even though the application role grants', async () => {
- const userRole = createFlatRole({
- id: 'user-role-id',
- canUpdateAllSettings: false,
- });
- const applicationRole = createFlatRole({
- id: 'application-role-id',
- canUpdateAllSettings: true,
- });
-
- mockUserRole(userRole);
- mockApplicationRole(applicationRole.id);
- mockCachedRoles([userRole, applicationRole]);
-
- await expect(check()).resolves.toBe(false);
- });
-
- it('should grant when both roles grant', async () => {
- const userRole = createFlatRole({
- id: 'user-role-id',
- canUpdateAllSettings: true,
- });
- const applicationRole = createFlatRole({
- id: 'application-role-id',
- canUpdateAllSettings: true,
- });
-
- mockUserRole(userRole);
- mockApplicationRole(applicationRole.id);
- mockCachedRoles([userRole, applicationRole]);
-
- await expect(check()).resolves.toBe(true);
- });
-
- it('should fall back to the user role when the application declares none', async () => {
- const userRole = createFlatRole({
- id: 'user-role-id',
- canUpdateAllSettings: true,
- });
-
- mockUserRole(userRole);
- mockApplicationRole(null);
- roleRepository.find.mockResolvedValue([]);
-
- await expect(check()).resolves.toBe(true);
- });
-
- it('should grant when the application declares the user own role', async () => {
- const userRole = createFlatRole({
- id: 'user-role-id',
- canUpdateAllSettings: true,
- });
-
- mockUserRole(userRole);
- mockApplicationRole(userRole.id);
-
- await expect(check()).resolves.toBe(true);
- });
-
- it('should reject when the application no longer exists', async () => {
- mockUserRole(
- createFlatRole({ id: 'user-role-id', canUpdateAllSettings: true }),
- );
- applicationRepository.findOne.mockResolvedValue(null);
-
- await expect(check()).rejects.toThrow(ApplicationException);
- });
-
- it('should not consult the application when the request carries none', async () => {
- const userRole = createFlatRole({
- id: 'user-role-id',
- canUpdateAllSettings: true,
- });
-
- mockUserRole(userRole);
-
- await expect(
- service.userHasWorkspaceSettingPermission({
- userWorkspaceId,
- workspaceId,
- setting,
- }),
- ).resolves.toBe(true);
- expect(applicationRepository.findOne).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/role/services/__tests__/workspace-roles-permissions-cache.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/role/services/__tests__/workspace-roles-permissions-cache.service.spec.ts
deleted file mode 100644
index 99bcd76e56f..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/role/services/__tests__/workspace-roles-permissions-cache.service.spec.ts
+++ /dev/null
@@ -1,373 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import {
- PermissionFlagType,
- SystemPermissionFlag,
-} from 'twenty-shared/constants';
-import { STANDARD_OBJECTS } from 'twenty-shared/metadata';
-import { type Repository } from 'typeorm';
-
-import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
-import { FieldPermissionEntity } from 'src/engine/metadata-modules/object-permission/field-permission/field-permission.entity';
-import { ObjectPermissionEntity } from 'src/engine/metadata-modules/object-permission/object-permission.entity';
-import { RolePermissionFlagEntity } from 'src/engine/metadata-modules/role-permission-flag/role-permission-flag.entity';
-import { RoleEntity } from 'src/engine/metadata-modules/role/role.entity';
-import { WorkspaceRolesPermissionsCacheService } from 'src/engine/metadata-modules/role/services/workspace-roles-permissions-cache.service';
-import { RowLevelPermissionPredicateGroupEntity } from 'src/engine/metadata-modules/row-level-permission-predicate/entities/row-level-permission-predicate-group.entity';
-import { RowLevelPermissionPredicateEntity } from 'src/engine/metadata-modules/row-level-permission-predicate/entities/row-level-permission-predicate.entity';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { type WorkspaceScopedRepository } from 'src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository';
-
-const WORKSPACE_ID = '20202020-0000-4000-8000-000000000000';
-const ROLE_ID = '11111111-1111-4111-8111-111111111111';
-const WORKSPACE_MEMBER_OBJECT_METADATA_ID =
- '22222222-2222-4222-8222-222222222222';
-const WORKFLOW_OBJECT_METADATA_ID = '33333333-3333-4333-8333-333333333333';
-const PERSON_OBJECT_METADATA_ID = '44444444-4444-4444-8444-444444444444';
-const MESSAGE_OBJECT_METADATA_ID = '55555555-5555-4555-8555-555555555555';
-
-const createBaseRole = (
- overrides: Partial<RoleEntity> &
- Pick<RoleEntity, 'rolePermissionFlags' | 'objectPermissions'>,
-): RoleEntity =>
- ({
- id: ROLE_ID,
- label: 'Test role',
- workspaceId: WORKSPACE_ID,
- canUpdateAllSettings: false,
- canAccessAllTools: false,
- canReadAllObjectRecords: false,
- canUpdateAllObjectRecords: false,
- canSoftDeleteAllObjectRecords: false,
- canDestroyAllObjectRecords: false,
- description: null,
- icon: null,
- isEditable: true,
- canBeAssignedToUsers: true,
- canBeAssignedToAgents: true,
- canBeAssignedToApiKeys: true,
- fieldPermissions: [],
- rowLevelPermissionPredicates: [],
- rowLevelPermissionPredicateGroups: [],
- ...overrides,
- }) as RoleEntity;
-
-describe('WorkspaceRolesPermissionsCacheService', () => {
- let service: WorkspaceRolesPermissionsCacheService;
- let roleRepository: jest.Mocked<
- Pick<WorkspaceScopedRepository<RoleEntity>, 'find'>
- >;
- let objectMetadataRepository: jest.Mocked<
- Pick<Repository<ObjectMetadataEntity>, 'find'>
- >;
- let objectPermissionRepository: jest.Mocked<
- Pick<WorkspaceScopedRepository<ObjectPermissionEntity>, 'find'>
- >;
- let rolePermissionFlagRepository: jest.Mocked<
- Pick<Repository<RolePermissionFlagEntity>, 'find'>
- >;
-
- const workspaceObjectMetadataFixture: ObjectMetadataEntity[] = [
- {
- id: WORKSPACE_MEMBER_OBJECT_METADATA_ID,
- isSystem: true,
- universalIdentifier: STANDARD_OBJECTS.workspaceMember.universalIdentifier,
- labelIdentifierFieldMetadataId: null,
- } as ObjectMetadataEntity,
- {
- id: WORKFLOW_OBJECT_METADATA_ID,
- isSystem: true,
- universalIdentifier: STANDARD_OBJECTS.workflow.universalIdentifier,
- labelIdentifierFieldMetadataId: null,
- } as ObjectMetadataEntity,
- {
- id: PERSON_OBJECT_METADATA_ID,
- isSystem: false,
- universalIdentifier: STANDARD_OBJECTS.person.universalIdentifier,
- labelIdentifierFieldMetadataId: null,
- } as ObjectMetadataEntity,
- {
- id: MESSAGE_OBJECT_METADATA_ID,
- isSystem: true,
- universalIdentifier: STANDARD_OBJECTS.message.universalIdentifier,
- labelIdentifierFieldMetadataId: null,
- } as ObjectMetadataEntity,
- ];
-
- beforeEach(async () => {
- roleRepository = {
- find: jest.fn(),
- };
-
- objectMetadataRepository = {
- find: jest.fn().mockResolvedValue(workspaceObjectMetadataFixture),
- };
-
- objectPermissionRepository = {
- find: jest.fn().mockResolvedValue([]),
- };
-
- rolePermissionFlagRepository = {
- find: jest.fn().mockResolvedValue([]),
- };
- const fieldPermissionRepository = {
- find: jest.fn().mockResolvedValue([]),
- };
- const rowLevelPermissionPredicateRepository = {
- find: jest.fn().mockResolvedValue([]),
- };
- const rowLevelPermissionPredicateGroupRepository = {
- find: jest.fn().mockResolvedValue([]),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkspaceRolesPermissionsCacheService,
- {
- provide: getRepositoryToken(ObjectMetadataEntity),
- useValue: objectMetadataRepository,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(RoleEntity),
- useValue: roleRepository,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(ObjectPermissionEntity),
- useValue: objectPermissionRepository,
- },
- {
- provide: getRepositoryToken(RolePermissionFlagEntity),
- useValue: rolePermissionFlagRepository,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(FieldPermissionEntity),
- useValue: fieldPermissionRepository,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(
- RowLevelPermissionPredicateEntity,
- ),
- useValue: rowLevelPermissionPredicateRepository,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(
- RowLevelPermissionPredicateGroupEntity,
- ),
- useValue: rowLevelPermissionPredicateGroupRepository,
- },
- ],
- }).compile();
-
- service = module.get(WorkspaceRolesPermissionsCacheService);
- });
-
- describe('workspaceMember object', () => {
- it('should deny all record permissions when role has neither workspace members access nor update-all-settings', async () => {
- roleRepository.find.mockResolvedValue([
- createBaseRole({
- rolePermissionFlags: [],
- objectPermissions: [],
- }),
- ]);
-
- const result = await service.computeForCache(WORKSPACE_ID);
- const workspaceMemberPermissions =
- result[ROLE_ID][WORKSPACE_MEMBER_OBJECT_METADATA_ID];
-
- expect(workspaceMemberPermissions.canReadObjectRecords).toBe(true);
- expect(workspaceMemberPermissions.canUpdateObjectRecords).toBe(false);
- expect(workspaceMemberPermissions.canSoftDeleteObjectRecords).toBe(false);
- expect(workspaceMemberPermissions.canDestroyObjectRecords).toBe(false);
- });
-
- it('should grant all record permissions when role has WORKSPACE_MEMBERS permission flag', async () => {
- rolePermissionFlagRepository.find.mockResolvedValue([
- {
- roleId: ROLE_ID,
- permissionFlag: {
- key: PermissionFlagType.WORKSPACE_MEMBERS,
- universalIdentifier: SystemPermissionFlag.WORKSPACE_MEMBERS,
- },
- } as RolePermissionFlagEntity,
- ]);
-
- roleRepository.find.mockResolvedValue([
- createBaseRole({
- rolePermissionFlags: [],
- objectPermissions: [],
- }),
- ]);
-
- const result = await service.computeForCache(WORKSPACE_ID);
- const workspaceMemberPermissions =
- result[ROLE_ID][WORKSPACE_MEMBER_OBJECT_METADATA_ID];
-
- expect(workspaceMemberPermissions.canReadObjectRecords).toBe(true);
- expect(workspaceMemberPermissions.canUpdateObjectRecords).toBe(true);
- expect(workspaceMemberPermissions.canSoftDeleteObjectRecords).toBe(true);
- expect(workspaceMemberPermissions.canDestroyObjectRecords).toBe(true);
- });
-
- it('should grant all record permissions when role has canUpdateAllSettings', async () => {
- roleRepository.find.mockResolvedValue([
- createBaseRole({
- canUpdateAllSettings: true,
- rolePermissionFlags: [],
- objectPermissions: [],
- }),
- ]);
-
- const result = await service.computeForCache(WORKSPACE_ID);
- const workspaceMemberPermissions =
- result[ROLE_ID][WORKSPACE_MEMBER_OBJECT_METADATA_ID];
-
- expect(workspaceMemberPermissions.canReadObjectRecords).toBe(true);
- expect(workspaceMemberPermissions.canUpdateObjectRecords).toBe(true);
- });
- });
-
- describe('workflow object', () => {
- it('should deny all record permissions when role has neither workflows access nor update-all-settings', async () => {
- roleRepository.find.mockResolvedValue([
- createBaseRole({
- rolePermissionFlags: [],
- objectPermissions: [],
- }),
- ]);
-
- const result = await service.computeForCache(WORKSPACE_ID);
- const workflowPermissions = result[ROLE_ID][WORKFLOW_OBJECT_METADATA_ID];
-
- expect(workflowPermissions.canReadObjectRecords).toBe(false);
- expect(workflowPermissions.canUpdateObjectRecords).toBe(false);
- expect(workflowPermissions.canSoftDeleteObjectRecords).toBe(false);
- expect(workflowPermissions.canDestroyObjectRecords).toBe(false);
- });
-
- it('should grant all record permissions when role has WORKFLOWS permission flag', async () => {
- rolePermissionFlagRepository.find.mockResolvedValue([
- {
- roleId: ROLE_ID,
- permissionFlag: {
- key: PermissionFlagType.WORKFLOWS,
- universalIdentifier: SystemPermissionFlag.WORKFLOWS,
- },
- } as RolePermissionFlagEntity,
- ]);
-
- roleRepository.find.mockResolvedValue([
- createBaseRole({
- rolePermissionFlags: [],
- objectPermissions: [],
- }),
- ]);
-
- const result = await service.computeForCache(WORKSPACE_ID);
- const workflowPermissions = result[ROLE_ID][WORKFLOW_OBJECT_METADATA_ID];
-
- expect(workflowPermissions.canReadObjectRecords).toBe(true);
- expect(workflowPermissions.canUpdateObjectRecords).toBe(true);
- expect(workflowPermissions.canSoftDeleteObjectRecords).toBe(true);
- expect(workflowPermissions.canDestroyObjectRecords).toBe(true);
- });
- });
-
- describe('regular object (person)', () => {
- it('should apply object permission overrides when object is not system', async () => {
- objectPermissionRepository.find.mockResolvedValue([
- {
- roleId: ROLE_ID,
- objectMetadataId: PERSON_OBJECT_METADATA_ID,
- canReadObjectRecords: true,
- canUpdateObjectRecords: false,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- } as ObjectPermissionEntity,
- ]);
-
- roleRepository.find.mockResolvedValue([
- createBaseRole({
- rolePermissionFlags: [],
- objectPermissions: [],
- }),
- ]);
-
- const result = await service.computeForCache(WORKSPACE_ID);
- const personPermissions = result[ROLE_ID][PERSON_OBJECT_METADATA_ID];
-
- expect(personPermissions.canReadObjectRecords).toBe(true);
- expect(personPermissions.canUpdateObjectRecords).toBe(false);
- expect(personPermissions.canSoftDeleteObjectRecords).toBe(false);
- expect(personPermissions.canDestroyObjectRecords).toBe(false);
- });
-
- it('should use role-wide CRUD defaults when no object permission row exists', async () => {
- roleRepository.find.mockResolvedValue([
- createBaseRole({
- canReadAllObjectRecords: true,
- canUpdateAllObjectRecords: true,
- canSoftDeleteAllObjectRecords: true,
- canDestroyAllObjectRecords: true,
- rolePermissionFlags: [],
- objectPermissions: [],
- }),
- ]);
-
- const result = await service.computeForCache(WORKSPACE_ID);
- const personPermissions = result[ROLE_ID][PERSON_OBJECT_METADATA_ID];
-
- expect(personPermissions.canReadObjectRecords).toBe(true);
- expect(personPermissions.canUpdateObjectRecords).toBe(true);
- expect(personPermissions.canSoftDeleteObjectRecords).toBe(true);
- expect(personPermissions.canDestroyObjectRecords).toBe(true);
- });
- });
-
- describe('system object (message)', () => {
- it('should default to full access when no object permission override exists', async () => {
- roleRepository.find.mockResolvedValue([
- createBaseRole({
- rolePermissionFlags: [],
- objectPermissions: [],
- }),
- ]);
-
- const result = await service.computeForCache(WORKSPACE_ID);
- const messagePermissions = result[ROLE_ID][MESSAGE_OBJECT_METADATA_ID];
-
- expect(messagePermissions.canReadObjectRecords).toBe(true);
- expect(messagePermissions.canUpdateObjectRecords).toBe(true);
- expect(messagePermissions.canSoftDeleteObjectRecords).toBe(true);
- expect(messagePermissions.canDestroyObjectRecords).toBe(true);
- });
-
- it('should honor an explicit deny override instead of forcing system default', async () => {
- objectPermissionRepository.find.mockResolvedValue([
- {
- roleId: ROLE_ID,
- objectMetadataId: MESSAGE_OBJECT_METADATA_ID,
- canReadObjectRecords: false,
- canUpdateObjectRecords: false,
- canSoftDeleteObjectRecords: false,
- canDestroyObjectRecords: false,
- } as ObjectPermissionEntity,
- ]);
-
- roleRepository.find.mockResolvedValue([
- createBaseRole({
- rolePermissionFlags: [],
- objectPermissions: [],
- }),
- ]);
-
- const result = await service.computeForCache(WORKSPACE_ID);
- const messagePermissions = result[ROLE_ID][MESSAGE_OBJECT_METADATA_ID];
-
- expect(messagePermissions.canReadObjectRecords).toBe(false);
- expect(messagePermissions.canUpdateObjectRecords).toBe(false);
- expect(messagePermissions.canSoftDeleteObjectRecords).toBe(false);
- expect(messagePermissions.canDestroyObjectRecords).toBe(false);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/user-role/__tests__/user-role.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/user-role/__tests__/user-role.service.spec.ts
deleted file mode 100644
index 1703bba81f2..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/user-role/__tests__/user-role.service.spec.ts
+++ /dev/null
@@ -1,178 +0,0 @@
-import { type Repository } from 'typeorm';
-
-import { type UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { PermissionsExceptionCode } from 'src/engine/metadata-modules/permissions/permissions.exception';
-import { type RoleTargetService } from 'src/engine/metadata-modules/role-target/services/role-target.service';
-import { type RoleValidationService } from 'src/engine/metadata-modules/role-validation/services/role-validation.service';
-import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';
-import { type GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type WorkspaceScopedRepository } from 'src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository';
-import { type WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { type RoleTargetEntity } from 'src/engine/metadata-modules/role-target/role-target.entity';
-
-const workspaceId = 'workspace-id';
-const roleId = 'role-id';
-const workspaceMemberId = 'workspace-member-id';
-const targetUserWorkspaceId = 'target-user-workspace-id';
-const actingUserWorkspaceId = 'acting-user-workspace-id';
-
-const buildService = (options?: {
- workspaceMember?: { id: string; userId: string } | null;
- userWorkspace?: { id: string } | null;
-}) => {
- const workspaceMember =
- options?.workspaceMember === undefined
- ? { id: workspaceMemberId, userId: 'target-user-id' }
- : options.workspaceMember;
- const userWorkspace =
- options?.userWorkspace === undefined
- ? { id: targetUserWorkspaceId }
- : options.userWorkspace;
-
- const roleTargetRepository = {
- find: jest.fn().mockResolvedValue([]),
- };
- const userWorkspaceRepository = {
- find: jest.fn().mockResolvedValue([{ id: targetUserWorkspaceId }]),
- findOne: jest.fn().mockResolvedValue(userWorkspace),
- };
- const workspaceMemberRepository = {
- findOne: jest.fn().mockResolvedValue(workspaceMember),
- };
- const globalWorkspaceOrmManager = {
- executeInWorkspaceContext: jest.fn((callback: () => unknown) => callback()),
- getRepository: jest.fn().mockResolvedValue(workspaceMemberRepository),
- };
- const roleTargetService = {
- createMany: jest.fn().mockResolvedValue([]),
- };
- const workspaceCacheService = {
- getOrRecompute: jest.fn().mockResolvedValue({
- userWorkspaceRoleMap: { [targetUserWorkspaceId]: 'previous-role-id' },
- }),
- };
- const roleValidationService = {
- validateRoleAssignableToUsersOrThrow: jest
- .fn()
- .mockResolvedValue(undefined),
- };
-
- const service = new UserRoleService(
- roleTargetRepository as unknown as WorkspaceScopedRepository<RoleTargetEntity>,
- userWorkspaceRepository as unknown as Repository<UserWorkspaceEntity>,
- globalWorkspaceOrmManager as unknown as GlobalWorkspaceOrmManager,
- roleTargetService as unknown as RoleTargetService,
- workspaceCacheService as unknown as WorkspaceCacheService,
- roleValidationService as unknown as RoleValidationService,
- );
-
- return {
- service,
- roleTargetService,
- roleValidationService,
- userWorkspaceRepository,
- };
-};
-
-describe('UserRoleService', () => {
- describe('assignRoleToManyUserWorkspace', () => {
- it('rejects assignments that include the acting user workspace', async () => {
- const { service, roleTargetService } = buildService();
-
- await expect(
- service.assignRoleToManyUserWorkspace({
- workspaceId,
- userWorkspaceIds: [actingUserWorkspaceId],
- roleId,
- actingUserWorkspaceId,
- }),
- ).rejects.toMatchObject({
- code: PermissionsExceptionCode.CANNOT_UPDATE_SELF_ROLE,
- });
-
- expect(roleTargetService.createMany).not.toHaveBeenCalled();
- });
- });
-
- describe('assignRoleToWorkspaceMember', () => {
- it('resolves the member, validates assignability and assigns the role', async () => {
- const { service, roleTargetService, roleValidationService } =
- buildService();
-
- const result = await service.assignRoleToWorkspaceMember({
- workspaceId,
- workspaceMemberId,
- roleId,
- actingUserWorkspaceId,
- });
-
- expect(result.userWorkspaceId).toBe(targetUserWorkspaceId);
- expect(
- roleValidationService.validateRoleAssignableToUsersOrThrow,
- ).toHaveBeenCalledWith(roleId, workspaceId);
- expect(roleTargetService.createMany).toHaveBeenCalledWith(
- expect.objectContaining({
- workspaceId,
- createRoleTargetInputs: [
- expect.objectContaining({
- roleId,
- targetId: targetUserWorkspaceId,
- }),
- ],
- }),
- );
- });
-
- it('rejects assigning a role to the acting user themselves', async () => {
- const { service, roleTargetService } = buildService({
- userWorkspace: { id: actingUserWorkspaceId },
- });
-
- await expect(
- service.assignRoleToWorkspaceMember({
- workspaceId,
- workspaceMemberId,
- roleId,
- actingUserWorkspaceId,
- }),
- ).rejects.toMatchObject({
- code: PermissionsExceptionCode.CANNOT_UPDATE_SELF_ROLE,
- });
-
- expect(roleTargetService.createMany).not.toHaveBeenCalled();
- });
-
- it('throws when the workspace member does not exist', async () => {
- const { service } = buildService({ workspaceMember: null });
-
- await expect(
- service.assignRoleToWorkspaceMember({
- workspaceId,
- workspaceMemberId,
- roleId,
- }),
- ).rejects.toMatchObject({
- code: PermissionsExceptionCode.WORKSPACE_MEMBER_NOT_FOUND,
- });
- });
-
- it('propagates assignability rejections from role validation', async () => {
- const { service, roleValidationService, roleTargetService } =
- buildService();
-
- roleValidationService.validateRoleAssignableToUsersOrThrow.mockRejectedValue(
- new Error('Role cannot be assigned to users'),
- );
-
- await expect(
- service.assignRoleToWorkspaceMember({
- workspaceId,
- workspaceMemberId,
- roleId,
- }),
- ).rejects.toThrow('Role cannot be assigned to users');
-
- expect(roleTargetService.createMany).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/view-filter-group/services/tests/view-filter-group.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/view-filter-group/services/tests/view-filter-group.service.spec.ts
deleted file mode 100644
index fe088dc3449..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/view-filter-group/services/tests/view-filter-group.service.spec.ts
+++ /dev/null
@@ -1,178 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ViewFilterGroupLogicalOperator } from 'twenty-shared/types';
-
-import { ApplicationService } from 'src/engine/core-modules/application/application.service';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { ViewFilterGroupEntity } from 'src/engine/metadata-modules/view-filter-group/entities/view-filter-group.entity';
-import { ViewFilterGroupService } from 'src/engine/metadata-modules/view-filter-group/services/view-filter-group.service';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { type WorkspaceScopedRepository } from 'src/engine/twenty-orm/workspace-scoped-repository/workspace-scoped-repository';
-import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';
-
-describe('ViewFilterGroupService', () => {
- let viewFilterGroupService: ViewFilterGroupService;
- let viewFilterGroupRepository: WorkspaceScopedRepository<ViewFilterGroupEntity>;
-
- const mockViewFilterGroup = {
- id: 'view-filter-group-id',
- viewId: 'view-id',
- workspaceId: 'workspace-id',
- logicalOperator: ViewFilterGroupLogicalOperator.AND,
- positionInViewFilterGroup: 0,
- createdAt: new Date(),
- updatedAt: new Date(),
- deletedAt: null,
- } as ViewFilterGroupEntity;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ViewFilterGroupService,
- {
- provide: getWorkspaceScopedRepositoryToken(ViewFilterGroupEntity),
- useValue: {
- find: jest.fn(),
- findOne: jest.fn(),
- save: jest.fn(),
- delete: jest.fn(),
- },
- },
- {
- provide: WorkspaceMigrationValidateBuildAndRunService,
- useValue: {
- validateBuildAndRunWorkspaceMigration: jest.fn(),
- },
- },
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn(),
- invalidateFlatEntityMaps: jest.fn(),
- },
- },
- {
- provide: ApplicationService,
- useValue: {
- findWorkspaceTwentyStandardAndCustomApplicationOrThrow: jest.fn(),
- },
- },
- ],
- }).compile();
-
- viewFilterGroupService = module.get<ViewFilterGroupService>(
- ViewFilterGroupService,
- );
- viewFilterGroupRepository = module.get<
- WorkspaceScopedRepository<ViewFilterGroupEntity>
- >(getWorkspaceScopedRepositoryToken(ViewFilterGroupEntity));
- });
-
- it('should be defined', () => {
- expect(viewFilterGroupService).toBeDefined();
- });
-
- describe('findByWorkspaceId', () => {
- it('should return view filter groups for a workspace', async () => {
- const workspaceId = 'workspace-id';
- const expectedViewFilterGroups = [mockViewFilterGroup];
-
- jest
- .spyOn(viewFilterGroupRepository, 'find')
- .mockResolvedValue(expectedViewFilterGroups);
-
- const result =
- await viewFilterGroupService.findByWorkspaceId(workspaceId);
-
- expect(viewFilterGroupRepository.find).toHaveBeenCalledWith(workspaceId, {
- where: {
- deletedAt: expect.anything(),
- },
- order: { positionInViewFilterGroup: 'ASC', id: 'ASC' },
- relations: [
- 'workspace',
- 'view',
- 'viewFilters',
- 'parentViewFilterGroup',
- 'childViewFilterGroups',
- ],
- });
- expect(result).toEqual(expectedViewFilterGroups);
- });
- });
-
- describe('findByViewId', () => {
- it('should return view filter groups for a view', async () => {
- const workspaceId = 'workspace-id';
- const viewId = 'view-id';
- const expectedViewFilterGroups = [mockViewFilterGroup];
-
- jest
- .spyOn(viewFilterGroupRepository, 'find')
- .mockResolvedValue(expectedViewFilterGroups);
-
- const result = await viewFilterGroupService.findByViewId(
- workspaceId,
- viewId,
- );
-
- expect(viewFilterGroupRepository.find).toHaveBeenCalledWith(workspaceId, {
- where: {
- viewId,
- deletedAt: expect.anything(),
- },
- order: { positionInViewFilterGroup: 'ASC', id: 'ASC' },
- relations: [
- 'workspace',
- 'view',
- 'viewFilters',
- 'parentViewFilterGroup',
- 'childViewFilterGroups',
- ],
- });
- expect(result).toEqual(expectedViewFilterGroups);
- });
- });
-
- describe('findById', () => {
- it('should return a view filter group by id', async () => {
- const id = 'view-filter-group-id';
- const workspaceId = 'workspace-id';
-
- jest
- .spyOn(viewFilterGroupRepository, 'findOne')
- .mockResolvedValue(mockViewFilterGroup);
-
- const result = await viewFilterGroupService.findById(id, workspaceId);
-
- expect(viewFilterGroupRepository.findOne).toHaveBeenCalledWith(
- workspaceId,
- {
- where: {
- id,
- deletedAt: expect.anything(),
- },
- relations: [
- 'workspace',
- 'view',
- 'viewFilters',
- 'parentViewFilterGroup',
- 'childViewFilterGroups',
- ],
- },
- );
- expect(result).toEqual(mockViewFilterGroup);
- });
-
- it('should return null when view filter group is not found', async () => {
- const id = 'non-existent-id';
- const workspaceId = 'workspace-id';
-
- jest.spyOn(viewFilterGroupRepository, 'findOne').mockResolvedValue(null);
-
- const result = await viewFilterGroupService.findById(id, workspaceId);
-
- expect(result).toBeNull();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/metadata-modules/view/services/__tests__/view-query-params.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/view/services/__tests__/view-query-params.service.spec.ts
deleted file mode 100644
index 1625601876c..00000000000
--- a/packages/twenty-server/src/engine/metadata-modules/view/services/__tests__/view-query-params.service.spec.ts
+++ /dev/null
@@ -1,349 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import {
- FieldMetadataType,
- ViewFilterGroupLogicalOperator,
- ViewFilterOperand,
- ViewSortDirection,
- ViewType,
- ViewVisibility,
-} from 'twenty-shared/types';
-
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { ViewQueryParamsService } from 'src/engine/metadata-modules/view/services/view-query-params.service';
-import { ViewService } from 'src/engine/metadata-modules/view/services/view.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-
-describe('ViewQueryParamsService', () => {
- let viewQueryParamsService: ViewQueryParamsService;
- let viewService: jest.Mocked<ViewService>;
- let flatEntityMapsCacheService: jest.Mocked<WorkspaceManyOrAllFlatEntityMapsCacheService>;
-
- const mockWorkspaceId = 'workspace-id';
- const mockViewId = 'view-id';
- const mockObjectMetadataId = 'object-metadata-id';
- const mockFieldMetadataId = 'field-metadata-id';
-
- const mockFlatObjectMetadataMaps = {
- byUniversalIdentifier: {
- 'object-universal-id': {
- id: mockObjectMetadataId,
- nameSingular: 'company',
- namePlural: 'companies',
- labelSingular: 'Company',
- labelPlural: 'Companies',
- universalIdentifier: 'object-universal-id',
- },
- },
- universalIdentifierById: {
- [mockObjectMetadataId]: 'object-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- };
-
- const mockFlatFieldMetadataMaps = {
- byUniversalIdentifier: {
- 'field-universal-id': {
- id: mockFieldMetadataId,
- name: 'name',
- type: FieldMetadataType.TEXT,
- label: 'Name',
- options: null,
- universalIdentifier: 'field-universal-id',
- },
- },
- universalIdentifierById: {
- [mockFieldMetadataId]: 'field-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ViewQueryParamsService,
- {
- provide: ViewService,
- useValue: {
- findByIdWithRelations: jest.fn(),
- },
- },
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn(),
- },
- },
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getRepository: jest.fn(),
- },
- },
- ],
- }).compile();
-
- viewQueryParamsService = module.get<ViewQueryParamsService>(
- ViewQueryParamsService,
- );
- viewService = module.get(ViewService);
- flatEntityMapsCacheService = module.get(
- WorkspaceManyOrAllFlatEntityMapsCacheService,
- );
- });
-
- it('should be defined', () => {
- expect(viewQueryParamsService).toBeDefined();
- });
-
- describe('resolveViewToQueryParams', () => {
- it('should throw error when view is not found', async () => {
- viewService.findByIdWithRelations.mockResolvedValue(null);
-
- await expect(
- viewQueryParamsService.resolveViewToQueryParams(
- mockViewId,
- mockWorkspaceId,
- ),
- ).rejects.toThrow(`View with id ${mockViewId} not found`);
- });
-
- it('should return query params for a view without filters or sorts', async () => {
- const mockView = {
- id: mockViewId,
- name: 'All Companies',
- objectMetadataId: mockObjectMetadataId,
- type: ViewType.TABLE,
- visibility: ViewVisibility.WORKSPACE,
- viewFilters: [],
- viewFilterGroups: [],
- viewSorts: [],
- };
-
- viewService.findByIdWithRelations.mockResolvedValue(mockView as any);
- flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatObjectMetadataMaps: mockFlatObjectMetadataMaps,
- flatFieldMetadataMaps: mockFlatFieldMetadataMaps,
- } as any,
- );
-
- const result = await viewQueryParamsService.resolveViewToQueryParams(
- mockViewId,
- mockWorkspaceId,
- );
-
- expect(result.objectNameSingular).toBe('company');
- expect(result.filter).toEqual({});
- expect(result.orderBy).toEqual([]);
- expect(result.viewName).toBe('All Companies');
- expect(result.viewType).toBe(ViewType.TABLE);
- });
-
- it('should return query params with filters', async () => {
- const mockFilterGroupId = 'filter-group-id';
- const mockView = {
- id: mockViewId,
- name: 'Companies with Name',
- objectMetadataId: mockObjectMetadataId,
- type: ViewType.TABLE,
- visibility: ViewVisibility.WORKSPACE,
- viewFilters: [
- {
- id: 'filter-id',
- fieldMetadataId: mockFieldMetadataId,
- operand: ViewFilterOperand.CONTAINS,
- value: 'Acme',
- viewFilterGroupId: mockFilterGroupId,
- subFieldName: null,
- },
- ],
- viewFilterGroups: [
- {
- id: mockFilterGroupId,
- parentViewFilterGroupId: null,
- logicalOperator: ViewFilterGroupLogicalOperator.AND,
- },
- ],
- viewSorts: [],
- };
-
- viewService.findByIdWithRelations.mockResolvedValue(mockView as any);
- flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatObjectMetadataMaps: mockFlatObjectMetadataMaps,
- flatFieldMetadataMaps: mockFlatFieldMetadataMaps,
- } as any,
- );
-
- const result = await viewQueryParamsService.resolveViewToQueryParams(
- mockViewId,
- mockWorkspaceId,
- );
-
- expect(result.objectNameSingular).toBe('company');
- expect(result.viewName).toBe('Companies with Name');
- expect(result.filter).toBeDefined();
- });
-
- it('should return query params with sorts', async () => {
- const mockView = {
- id: mockViewId,
- name: 'Companies Sorted',
- objectMetadataId: mockObjectMetadataId,
- type: ViewType.TABLE,
- visibility: ViewVisibility.WORKSPACE,
- viewFilters: [],
- viewFilterGroups: [],
- viewSorts: [
- {
- id: 'sort-id',
- fieldMetadataId: mockFieldMetadataId,
- direction: ViewSortDirection.DESC,
- },
- ],
- };
-
- viewService.findByIdWithRelations.mockResolvedValue(mockView as any);
- flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatObjectMetadataMaps: mockFlatObjectMetadataMaps,
- flatFieldMetadataMaps: mockFlatFieldMetadataMaps,
- } as any,
- );
-
- const result = await viewQueryParamsService.resolveViewToQueryParams(
- mockViewId,
- mockWorkspaceId,
- );
-
- expect(result.objectNameSingular).toBe('company');
- expect(result.orderBy).toHaveLength(1);
- expect(result.orderBy[0]).toHaveProperty('name');
- });
-
- it('should skip filters for deleted fields', async () => {
- const deletedFieldId = 'deleted-field-id';
- const mockFilterGroupId = 'filter-group-id';
- const mockView = {
- id: mockViewId,
- name: 'View with deleted field filter',
- objectMetadataId: mockObjectMetadataId,
- type: ViewType.TABLE,
- visibility: ViewVisibility.WORKSPACE,
- viewFilters: [
- {
- id: 'filter-id',
- fieldMetadataId: deletedFieldId,
- operand: ViewFilterOperand.CONTAINS,
- value: 'test',
- viewFilterGroupId: mockFilterGroupId,
- subFieldName: null,
- },
- ],
- viewFilterGroups: [
- {
- id: mockFilterGroupId,
- parentViewFilterGroupId: null,
- logicalOperator: ViewFilterGroupLogicalOperator.AND,
- },
- ],
- viewSorts: [],
- };
-
- viewService.findByIdWithRelations.mockResolvedValue(mockView as any);
- flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatObjectMetadataMaps: mockFlatObjectMetadataMaps,
- flatFieldMetadataMaps: mockFlatFieldMetadataMaps,
- } as any,
- );
-
- const result = await viewQueryParamsService.resolveViewToQueryParams(
- mockViewId,
- mockWorkspaceId,
- );
-
- // Filter should be effectively empty because the field was deleted
- expect(result.filter).toEqual({ and: [] });
- });
-
- it('should resolve relation-traversal filters against the target field', async () => {
- const relationFieldId = 'relation-field-id';
- const targetFieldId = 'target-field-id';
- const mockFilterGroupId = 'filter-group-id';
-
- const flatFieldMetadataMapsWithRelation = {
- byUniversalIdentifier: {
- 'relation-universal-id': {
- id: relationFieldId,
- name: 'company',
- type: FieldMetadataType.RELATION,
- label: 'Company',
- options: null,
- universalIdentifier: 'relation-universal-id',
- },
- 'target-universal-id': {
- id: targetFieldId,
- name: 'name',
- type: FieldMetadataType.TEXT,
- label: 'Name',
- options: null,
- universalIdentifier: 'target-universal-id',
- },
- },
- universalIdentifierById: {
- [relationFieldId]: 'relation-universal-id',
- [targetFieldId]: 'target-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- };
-
- const mockView = {
- id: mockViewId,
- name: 'People at Acme',
- objectMetadataId: mockObjectMetadataId,
- type: ViewType.TABLE,
- visibility: ViewVisibility.WORKSPACE,
- viewFilters: [
- {
- id: 'filter-id',
- fieldMetadataId: relationFieldId,
- operand: ViewFilterOperand.CONTAINS,
- value: 'Acme',
- viewFilterGroupId: mockFilterGroupId,
- subFieldName: null,
- relationTargetFieldMetadataId: targetFieldId,
- },
- ],
- viewFilterGroups: [
- {
- id: mockFilterGroupId,
- parentViewFilterGroupId: null,
- logicalOperator: ViewFilterGroupLogicalOperator.AND,
- },
- ],
- viewSorts: [],
- };
-
- viewService.findByIdWithRelations.mockResolvedValue(mockView as any);
- flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatObjectMetadataMaps: mockFlatObjectMetadataMaps,
- flatFieldMetadataMaps: flatFieldMetadataMapsWithRelation,
- } as any,
- );
-
- const result = await viewQueryParamsService.resolveViewToQueryParams(
- mockViewId,
- mockWorkspaceId,
- );
-
- // Filter is nested under the relation field name, not flattened
- // against the FK column.
- expect(result.filter).toEqual({
- and: [{ company: { name: { ilike: '%Acme%' } } }],
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/subscriptions/__tests__/event-stream.service.spec.ts b/packages/twenty-server/src/engine/subscriptions/__tests__/event-stream.service.spec.ts
deleted file mode 100644
index 41baeee0be8..00000000000
--- a/packages/twenty-server/src/engine/subscriptions/__tests__/event-stream.service.spec.ts
+++ /dev/null
@@ -1,260 +0,0 @@
-import { type CacheStorageService } from 'src/engine/core-modules/cache-storage/services/cache-storage.service';
-import { type MetricsService } from 'src/engine/core-modules/metrics/metrics.service';
-import { EVENT_STREAM_TTL_MS } from 'src/engine/subscriptions/constants/event-stream-ttl.constant';
-import { EventStreamService } from 'src/engine/subscriptions/event-stream.service';
-
-const WORKSPACE_ID = 'workspace-id';
-const EVENT_STREAM_CHANNEL_ID = 'event-stream-channel-id';
-const EVENT_STREAM_KEY = `eventStream:${WORKSPACE_ID}:${EVENT_STREAM_CHANNEL_ID}`;
-const ACTIVE_STREAMS_KEY = `workspace:${WORKSPACE_ID}:activeStreams`;
-const ACTIVE_STREAM_EXPIRATIONS_KEY = 'activeStreamExpirations';
-const ACTIVE_STREAM_EXPIRATION_MEMBER = `${WORKSPACE_ID}:${EVENT_STREAM_CHANNEL_ID}`;
-
-describe('EventStreamService', () => {
- let cacheStorageService: jest.Mocked<CacheStorageService>;
- let service: EventStreamService;
-
- beforeEach(() => {
- jest.useFakeTimers();
- jest.setSystemTime(new Date('2026-07-26T12:00:00.000Z'));
-
- cacheStorageService = {
- del: jest.fn(),
- expire: jest.fn(),
- get: jest.fn(),
- set: jest.fn(),
- setAdd: jest.fn(),
- setRemove: jest.fn(),
- sortedSetAdd: jest.fn(),
- sortedSetRemove: jest.fn(),
- sortedSetRemoveByScoreAndCount: jest.fn(),
- } as unknown as jest.Mocked<CacheStorageService>;
-
- service = new EventStreamService(cacheStorageService, {
- createObservableGauge: jest.fn(),
- } as unknown as MetricsService);
- });
-
- afterEach(() => {
- jest.useRealTimers();
- });
-
- it('counts live streams without scanning Redis keys', async () => {
- cacheStorageService.sortedSetRemoveByScoreAndCount.mockResolvedValue(3);
-
- await expect(service.getTotalActiveStreamCount()).resolves.toBe(3);
- await expect(service.getTotalActiveStreamCount()).resolves.toBe(3);
-
- expect(
- cacheStorageService.sortedSetRemoveByScoreAndCount,
- ).toHaveBeenCalledTimes(1);
- expect(
- cacheStorageService.sortedSetRemoveByScoreAndCount,
- ).toHaveBeenCalledWith(ACTIVE_STREAM_EXPIRATIONS_KEY, 0, Date.now());
- });
-
- it('adds a stream to its functional and metric indexes on creation', async () => {
- cacheStorageService.get.mockResolvedValue(undefined);
-
- await service.createEventStream({
- workspaceId: WORKSPACE_ID,
- eventStreamChannelId: EVENT_STREAM_CHANNEL_ID,
- authContext: { userId: 'user-id' },
- });
-
- expect(cacheStorageService.set).toHaveBeenCalledWith(
- EVENT_STREAM_KEY,
- {
- authContext: { userId: 'user-id' },
- workspaceId: WORKSPACE_ID,
- queries: {},
- createdAt: Date.now(),
- },
- EVENT_STREAM_TTL_MS,
- );
- expect(cacheStorageService.setAdd).toHaveBeenCalledWith(
- ACTIVE_STREAMS_KEY,
- [EVENT_STREAM_CHANNEL_ID],
- EVENT_STREAM_TTL_MS,
- );
- expect(cacheStorageService.sortedSetAdd).toHaveBeenCalledWith(
- ACTIVE_STREAM_EXPIRATIONS_KEY,
- [
- {
- score: Date.now() + EVENT_STREAM_TTL_MS,
- value: ACTIVE_STREAM_EXPIRATION_MEMBER,
- },
- ],
- );
- });
-
- it('tracks a stream after a successful refresh', async () => {
- cacheStorageService.expire
- .mockResolvedValueOnce(true)
- .mockResolvedValueOnce(true);
-
- await expect(
- service.refreshEventStreamTTL({
- workspaceId: WORKSPACE_ID,
- eventStreamChannelId: EVENT_STREAM_CHANNEL_ID,
- }),
- ).resolves.toBe(true);
-
- expect(cacheStorageService.sortedSetAdd).toHaveBeenCalledWith(
- ACTIVE_STREAM_EXPIRATIONS_KEY,
- [
- {
- score: Date.now() + EVENT_STREAM_TTL_MS,
- value: ACTIVE_STREAM_EXPIRATION_MEMBER,
- },
- ],
- );
- expect(cacheStorageService.sortedSetRemove).not.toHaveBeenCalled();
- });
-
- it('does not track a stream whose key is missing during refresh', async () => {
- cacheStorageService.expire
- .mockResolvedValueOnce(false)
- .mockResolvedValueOnce(true);
-
- await expect(
- service.refreshEventStreamTTL({
- workspaceId: WORKSPACE_ID,
- eventStreamChannelId: EVENT_STREAM_CHANNEL_ID,
- }),
- ).resolves.toBe(false);
-
- expect(cacheStorageService.sortedSetAdd).not.toHaveBeenCalled();
- expect(cacheStorageService.sortedSetRemove).not.toHaveBeenCalled();
- });
-
- it('keeps a valid stream tracked when the workspace stream set is missing', async () => {
- cacheStorageService.expire
- .mockResolvedValueOnce(true)
- .mockResolvedValueOnce(false);
-
- await expect(
- service.refreshEventStreamTTL({
- workspaceId: WORKSPACE_ID,
- eventStreamChannelId: EVENT_STREAM_CHANNEL_ID,
- }),
- ).resolves.toBe(false);
-
- expect(cacheStorageService.sortedSetAdd).toHaveBeenCalledWith(
- ACTIVE_STREAM_EXPIRATIONS_KEY,
- [
- {
- score: Date.now() + EVENT_STREAM_TTL_MS,
- value: ACTIVE_STREAM_EXPIRATION_MEMBER,
- },
- ],
- );
- expect(cacheStorageService.sortedSetRemove).not.toHaveBeenCalled();
- });
-
- it('removes a destroyed stream from its functional and metric indexes', async () => {
- await service.destroyEventStream({
- workspaceId: WORKSPACE_ID,
- eventStreamChannelId: EVENT_STREAM_CHANNEL_ID,
- });
-
- expect(cacheStorageService.del).toHaveBeenCalledWith(EVENT_STREAM_KEY);
- expect(cacheStorageService.setRemove).toHaveBeenCalledWith(
- ACTIVE_STREAMS_KEY,
- [EVENT_STREAM_CHANNEL_ID],
- );
- expect(cacheStorageService.sortedSetRemove).toHaveBeenCalledWith(
- ACTIVE_STREAM_EXPIRATIONS_KEY,
- [ACTIVE_STREAM_EXPIRATION_MEMBER],
- );
- });
-
- it('removes stale streams from the functional and metric indexes', async () => {
- await service.removeFromActiveStreams(WORKSPACE_ID, [
- EVENT_STREAM_CHANNEL_ID,
- 'stale-stream-id',
- ]);
-
- expect(cacheStorageService.setRemove).toHaveBeenCalledWith(
- ACTIVE_STREAMS_KEY,
- [EVENT_STREAM_CHANNEL_ID, 'stale-stream-id'],
- );
- expect(cacheStorageService.sortedSetRemove).toHaveBeenCalledWith(
- ACTIVE_STREAM_EXPIRATIONS_KEY,
- [ACTIVE_STREAM_EXPIRATION_MEMBER, `${WORKSPACE_ID}:stale-stream-id`],
- );
- });
- describe('isAuthorized', () => {
- const USER_WORKSPACE_ID = 'user-workspace-id';
- const APPLICATION_ID = 'application-id';
-
- const check = (
- callerAuthContext: Record<string, string>,
- streamAuthContext: Record<string, string>,
- ) =>
- service.isAuthorized({
- streamData: { authContext: streamAuthContext } as never,
- authContext: callerAuthContext as never,
- });
-
- it('authorizes the same user on a stream carrying no application', async () => {
- await expect(
- check(
- { userWorkspaceId: USER_WORKSPACE_ID },
- { userWorkspaceId: USER_WORKSPACE_ID },
- ),
- ).resolves.toBe(true);
- });
-
- it('authorizes the same user carrying the same application', async () => {
- await expect(
- check(
- { userWorkspaceId: USER_WORKSPACE_ID, applicationId: APPLICATION_ID },
- { userWorkspaceId: USER_WORKSPACE_ID, applicationId: APPLICATION_ID },
- ),
- ).resolves.toBe(true);
- });
-
- it('denies the same user when the application is dropped', async () => {
- await expect(
- check(
- { userWorkspaceId: USER_WORKSPACE_ID },
- { userWorkspaceId: USER_WORKSPACE_ID, applicationId: APPLICATION_ID },
- ),
- ).resolves.toBe(false);
- });
-
- it('denies the same user carrying a different application', async () => {
- await expect(
- check(
- {
- userWorkspaceId: USER_WORKSPACE_ID,
- applicationId: 'other-application-id',
- },
- { userWorkspaceId: USER_WORKSPACE_ID, applicationId: APPLICATION_ID },
- ),
- ).resolves.toBe(false);
- });
-
- it('denies a different user', async () => {
- await expect(
- check(
- { userWorkspaceId: 'other-user-workspace-id' },
- { userWorkspaceId: USER_WORKSPACE_ID },
- ),
- ).resolves.toBe(false);
- });
-
- it('authorizes the same api key', async () => {
- await expect(
- check({ apiKeyId: 'api-key-id' }, { apiKeyId: 'api-key-id' }),
- ).resolves.toBe(true);
- });
-
- it('denies a request carrying no principal', async () => {
- await expect(
- check({}, { userWorkspaceId: USER_WORKSPACE_ID }),
- ).resolves.toBe(false);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/trash-cleanup/services/__tests__/trash-cleanup.service.spec.ts b/packages/twenty-server/src/engine/trash-cleanup/services/__tests__/trash-cleanup.service.spec.ts
deleted file mode 100644
index 26c4d37d3ad..00000000000
--- a/packages/twenty-server/src/engine/trash-cleanup/services/__tests__/trash-cleanup.service.spec.ts
+++ /dev/null
@@ -1,254 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { TrashCleanupService } from 'src/engine/trash-cleanup/services/trash-cleanup.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-
-describe('TrashCleanupService', () => {
- let service: TrashCleanupService;
- let mockFlatEntityMapsCacheService: any;
- let mockGlobalWorkspaceOrmManager: any;
-
- beforeEach(async () => {
- mockFlatEntityMapsCacheService = {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn(),
- };
-
- mockGlobalWorkspaceOrmManager = {
- getRepository: jest.fn(),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- TrashCleanupService,
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: mockFlatEntityMapsCacheService,
- },
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: mockGlobalWorkspaceOrmManager,
- },
- ],
- }).compile();
-
- service = module.get<TrashCleanupService>(TrashCleanupService);
-
- // Suppress logger output in tests
- jest.spyOn(service['logger'], 'log').mockImplementation();
- jest.spyOn(service['logger'], 'error').mockImplementation();
-
- jest.clearAllMocks();
- });
-
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- describe('cleanupWorkspaceTrash', () => {
- const createRepositoryMock = (name: string, initialCount: number) => {
- let remaining = initialCount;
- let counter = 0;
-
- return {
- find: jest.fn().mockImplementation(({ take }) => {
- const amount = Math.min(take ?? remaining, remaining);
- const records = Array.from({ length: amount }, () => ({
- id: `${name}-${counter++}`,
- }));
-
- remaining -= amount;
-
- return Promise.resolve(records);
- }),
- delete: jest.fn().mockResolvedValue(undefined),
- };
- };
-
- const setObjectMetadataCache = (
- entries: Array<{
- id: string;
- nameSingular: string;
- universalIdentifier: string;
- }>,
- ) => {
- const byUniversalIdentifier = entries.reduce<Record<string, any>>(
- (acc, { id, nameSingular, universalIdentifier }) => {
- acc[universalIdentifier] = {
- id,
- nameSingular,
- universalIdentifier,
- };
-
- return acc;
- },
- {},
- );
-
- const universalIdentifierById = entries.reduce<Record<string, string>>(
- (acc, { id, universalIdentifier }) => {
- acc[id] = universalIdentifier;
-
- return acc;
- },
- {},
- );
-
- mockFlatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue(
- {
- flatObjectMetadataMaps: {
- byUniversalIdentifier,
- universalIdentifierById,
- universalIdentifiersByApplicationId: {},
- },
- },
- );
- };
-
- it('should return deleted count when cleanup succeeds', async () => {
- setObjectMetadataCache([
- {
- id: 'obj-company',
- nameSingular: 'company',
- universalIdentifier: 'uni-company',
- },
- {
- id: 'obj-person',
- nameSingular: 'person',
- universalIdentifier: 'uni-person',
- },
- ]);
-
- const companyRepository = createRepositoryMock('company', 2);
- const personRepository = createRepositoryMock('person', 1);
-
- mockGlobalWorkspaceOrmManager.getRepository
- .mockResolvedValueOnce(companyRepository)
- .mockResolvedValueOnce(personRepository);
-
- const result = await service.cleanupWorkspaceTrash({
- workspaceId: 'workspace-id',
- trashRetentionDays: 14,
- });
-
- expect(result).toEqual(3);
- expect(companyRepository.find).toHaveBeenCalled();
- expect(personRepository.find).toHaveBeenCalled();
- expect(companyRepository.delete).toHaveBeenCalledTimes(1);
- expect(personRepository.delete).toHaveBeenCalledTimes(1);
-
- const findArgs = companyRepository.find.mock.calls[0][0];
-
- expect(findArgs.withDeleted).toBe(true);
- expect(findArgs.order).toEqual({ deletedAt: 'ASC' });
- });
-
- it('should return zero when no objects are found', async () => {
- setObjectMetadataCache([]);
-
- const result = await service.cleanupWorkspaceTrash({
- workspaceId: 'workspace-id',
- trashRetentionDays: 14,
- });
-
- expect(result).toEqual(0);
- expect(
- mockGlobalWorkspaceOrmManager.getRepository,
- ).not.toHaveBeenCalled();
- });
-
- it('should respect max records limit across objects', async () => {
- (service as any).maxRecordsPerWorkspace = 3;
- (service as any).batchSize = 3;
- setObjectMetadataCache([
- {
- id: 'obj-company',
- nameSingular: 'company',
- universalIdentifier: 'uni-company',
- },
- {
- id: 'obj-person',
- nameSingular: 'person',
- universalIdentifier: 'uni-person',
- },
- ]);
-
- const companyRepository = createRepositoryMock('company', 2);
- const personRepository = createRepositoryMock('person', 5);
-
- mockGlobalWorkspaceOrmManager.getRepository
- .mockResolvedValueOnce(companyRepository)
- .mockResolvedValueOnce(personRepository);
-
- const result = await service.cleanupWorkspaceTrash({
- workspaceId: 'workspace-id',
- trashRetentionDays: 14,
- });
-
- expect(result).toEqual(3);
- expect(companyRepository.delete).toHaveBeenCalledTimes(1);
- expect(personRepository.delete).toHaveBeenCalledTimes(1);
- const personDeleteArgs = personRepository.delete.mock.calls[0][0];
- const deletedIds =
- personDeleteArgs.id._value ?? personDeleteArgs.id.value;
-
- expect(deletedIds).toHaveLength(1);
- expect(personRepository.find).toHaveBeenCalledTimes(1);
- });
-
- it('should ignore objects without soft deleted records', async () => {
- setObjectMetadataCache([
- {
- id: 'obj-company',
- nameSingular: 'company',
- universalIdentifier: 'uni-company',
- },
- ]);
-
- const companyRepository = createRepositoryMock('company', 0);
-
- mockGlobalWorkspaceOrmManager.getRepository.mockResolvedValueOnce(
- companyRepository,
- );
-
- const result = await service.cleanupWorkspaceTrash({
- workspaceId: 'workspace-id',
- trashRetentionDays: 14,
- });
-
- expect(result).toEqual(0);
- expect(companyRepository.delete).not.toHaveBeenCalled();
- });
-
- it('should delete records across multiple batches', async () => {
- setObjectMetadataCache([
- {
- id: 'obj-company',
- nameSingular: 'company',
- universalIdentifier: 'uni-company',
- },
- ]);
-
- const companyRepository = createRepositoryMock('company', 5);
-
- mockGlobalWorkspaceOrmManager.getRepository.mockResolvedValueOnce(
- companyRepository,
- );
-
- (service as any).batchSize = 2;
- (service as any).maxRecordsPerWorkspace = 10;
-
- const result = await service.cleanupWorkspaceTrash({
- workspaceId: 'workspace-id',
- trashRetentionDays: 14,
- });
-
- expect(result).toEqual(5);
- expect(companyRepository.find).toHaveBeenCalledTimes(4);
- expect(companyRepository.delete).toHaveBeenCalledTimes(3);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/twenty-orm/workspace-schema-manager/__tests__/workspace-schema-manager.service.spec.ts b/packages/twenty-server/src/engine/twenty-orm/workspace-schema-manager/__tests__/workspace-schema-manager.service.spec.ts
deleted file mode 100644
index c3248808668..00000000000
--- a/packages/twenty-server/src/engine/twenty-orm/workspace-schema-manager/__tests__/workspace-schema-manager.service.spec.ts
+++ /dev/null
@@ -1,176 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type QueryRunner } from 'typeorm';
-
-import { WorkspaceSchemaColumnManagerService } from 'src/engine/twenty-orm/workspace-schema-manager/services/workspace-schema-column-manager.service';
-import { WorkspaceSchemaEnumManagerService } from 'src/engine/twenty-orm/workspace-schema-manager/services/workspace-schema-enum-manager.service';
-import { WorkspaceSchemaForeignKeyManagerService } from 'src/engine/twenty-orm/workspace-schema-manager/services/workspace-schema-foreign-key-manager.service';
-import { WorkspaceSchemaIndexManagerService } from 'src/engine/twenty-orm/workspace-schema-manager/services/workspace-schema-index-manager.service';
-import { WorkspaceSchemaTableManagerService } from 'src/engine/twenty-orm/workspace-schema-manager/services/workspace-schema-table-manager.service';
-import { WorkspaceSchemaManagerService } from 'src/engine/twenty-orm/workspace-schema-manager/workspace-schema-manager.service';
-
-describe('WorkspaceSchemaManager', () => {
- let service: WorkspaceSchemaManagerService;
- let mockQueryRunner: jest.Mocked<QueryRunner>;
- let tableManager: jest.Mocked<WorkspaceSchemaTableManagerService>;
- let columnManager: jest.Mocked<WorkspaceSchemaColumnManagerService>;
- let indexManager: jest.Mocked<WorkspaceSchemaIndexManagerService>;
- let enumManager: jest.Mocked<WorkspaceSchemaEnumManagerService>;
- let foreignKeyManager: jest.Mocked<WorkspaceSchemaForeignKeyManagerService>;
-
- beforeEach(async () => {
- // Prepare
- tableManager = {
- createTable: jest.fn(),
- dropTable: jest.fn(),
- renameTable: jest.fn(),
- tableExists: jest.fn(),
- } as any;
-
- columnManager = {
- addColumns: jest.fn(),
- dropColumn: jest.fn(),
- renameColumn: jest.fn(),
- columnExists: jest.fn(),
- } as any;
-
- indexManager = {
- createIndex: jest.fn(),
- dropIndex: jest.fn(),
- indexExists: jest.fn(),
- } as any;
-
- enumManager = {
- createEnum: jest.fn(),
- dropEnum: jest.fn(),
- alterEnumValues: jest.fn(),
- } as any;
-
- foreignKeyManager = {
- createForeignKey: jest.fn(),
- dropForeignKey: jest.fn(),
- } as any;
-
- mockQueryRunner = {
- query: jest.fn(),
- connect: jest.fn(),
- startTransaction: jest.fn(),
- commitTransaction: jest.fn(),
- rollbackTransaction: jest.fn(),
- release: jest.fn(),
- } as any;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkspaceSchemaManagerService,
- { provide: WorkspaceSchemaTableManagerService, useValue: tableManager },
- {
- provide: WorkspaceSchemaColumnManagerService,
- useValue: columnManager,
- },
- { provide: WorkspaceSchemaIndexManagerService, useValue: indexManager },
- { provide: WorkspaceSchemaEnumManagerService, useValue: enumManager },
- {
- provide: WorkspaceSchemaForeignKeyManagerService,
- useValue: foreignKeyManager,
- },
- ],
- }).compile();
-
- service = module.get<WorkspaceSchemaManagerService>(
- WorkspaceSchemaManagerService,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('constructor', () => {
- it('should be defined', () => {
- expect(service).toBeDefined();
- });
-
- it('should initialize all managers', () => {
- expect(service.tableManager).toBe(tableManager);
- expect(service.columnManager).toBe(columnManager);
- expect(service.indexManager).toBe(indexManager);
- expect(service.enumManager).toBe(enumManager);
- expect(service.foreignKeyManager).toBe(foreignKeyManager);
- });
- });
-
- describe('manager access', () => {
- it('should provide access to table manager', () => {
- // Act & Assert
- expect(service.tableManager).toBeInstanceOf(Object);
- expect(service.tableManager.createTable).toBeDefined();
- });
-
- it('should provide access to column manager', () => {
- // Act & Assert
- expect(service.columnManager).toBeInstanceOf(Object);
- expect(service.columnManager.addColumns).toBeDefined();
- });
-
- it('should provide access to index manager', () => {
- // Act & Assert
- expect(service.indexManager).toBeInstanceOf(Object);
- expect(service.indexManager.createIndex).toBeDefined();
- });
-
- it('should provide access to enum manager', () => {
- // Act & Assert
- expect(service.enumManager).toBeInstanceOf(Object);
- expect(service.enumManager.createEnum).toBeDefined();
- });
-
- it('should provide access to foreign key manager', () => {
- // Act & Assert
- expect(service.foreignKeyManager).toBeInstanceOf(Object);
- expect(service.foreignKeyManager.createForeignKey).toBeDefined();
- });
- });
-
- describe('integration scenarios', () => {
- it('should support creating a complete table structure', async () => {
- // Prepare
- const schemaName = 'workspace_test';
- const tableName = 'users';
-
- // Act
- await service.tableManager.createTable({
- queryRunner: mockQueryRunner,
- schemaName,
- tableName,
- columnDefinitions: [
- { name: 'id', type: 'uuid', isPrimary: true },
- { name: 'name', type: 'varchar', isNullable: false },
- { name: 'status', type: 'varchar' },
- ],
- });
-
- await service.enumManager.createEnum({
- queryRunner: mockQueryRunner,
- schemaName,
- enumName: 'user_status_enum',
- values: ['ACTIVE', 'INACTIVE'],
- });
-
- await service.indexManager.createIndex({
- queryRunner: mockQueryRunner,
- schemaName,
- tableName,
- index: {
- name: 'idx_users_name',
- columns: ['name'],
- },
- });
-
- // Assert
- expect(tableManager.createTable).toHaveBeenCalled();
- expect(enumManager.createEnum).toHaveBeenCalled();
- expect(indexManager.createIndex).toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/twenty-orm/workspace-schema-manager/services/__tests__/workspace-schema-enum-manager.service.spec.ts b/packages/twenty-server/src/engine/twenty-orm/workspace-schema-manager/services/__tests__/workspace-schema-enum-manager.service.spec.ts
deleted file mode 100644
index bea40d54cb7..00000000000
--- a/packages/twenty-server/src/engine/twenty-orm/workspace-schema-manager/services/__tests__/workspace-schema-enum-manager.service.spec.ts
+++ /dev/null
@@ -1,136 +0,0 @@
-import { type QueryRunner } from 'typeorm';
-
-import { WorkspaceSchemaEnumManagerService } from 'src/engine/twenty-orm/workspace-schema-manager/services/workspace-schema-enum-manager.service';
-import { type WorkspaceSchemaColumnDefinition } from 'src/engine/twenty-orm/workspace-schema-manager/types/workspace-schema-column-definition.type';
-
-// PostgreSQL truncates identifiers to 63 bytes (NAMEDATALEN - 1).
-const POSTGRES_MAX_IDENTIFIER_LENGTH = 63;
-
-// Extracts every double-quoted identifier from a SQL string.
-const getQuotedIdentifiers = (sql: string): string[] =>
- [...sql.matchAll(/"([^"]+)"/g)].map((match) => match[1]);
-
-describe('WorkspaceSchemaEnumManagerService', () => {
- let service: WorkspaceSchemaEnumManagerService;
- let queryRunner: jest.Mocked<
- Pick<QueryRunner, 'query' | 'isTransactionActive'>
- >;
- let executedSql: string[];
-
- beforeEach(() => {
- service = new WorkspaceSchemaEnumManagerService();
- executedSql = [];
- queryRunner = {
- isTransactionActive: true,
- query: jest.fn((sql: string) => {
- executedSql.push(sql);
-
- return Promise.resolve();
- }),
- } as unknown as jest.Mocked<
- Pick<QueryRunner, 'query' | 'isTransactionActive'>
- >;
- });
-
- describe('addEnumValue', () => {
- it('emits a plain ADD VALUE statement', async () => {
- await service.addEnumValue({
- queryRunner: queryRunner as unknown as QueryRunner,
- schemaName: 'workspace_adhj7eaegq93fzpgbfpdm8ok3',
- enumName: 'company_createdBySource_enum',
- value: 'AGENT',
- });
-
- expect(executedSql).toHaveLength(1);
- expect(executedSql[0]).toContain('ADD VALUE ');
- expect(executedSql[0]).not.toContain('IF NOT EXISTS');
- expect(executedSql[0]).toContain("'AGENT'");
- });
- });
-
- describe('upsertEnumValue', () => {
- it('emits ADD VALUE IF NOT EXISTS', async () => {
- await service.upsertEnumValue({
- queryRunner: queryRunner as unknown as QueryRunner,
- schemaName: 'workspace_adhj7eaegq93fzpgbfpdm8ok3',
- enumName: 'company_createdBySource_enum',
- value: 'AGENT',
- });
-
- expect(executedSql).toHaveLength(1);
- expect(executedSql[0]).toContain('ADD VALUE IF NOT EXISTS');
- expect(executedSql[0]).toContain("'AGENT'");
- });
- });
-
- describe('alterEnumValues', () => {
- it('should not generate an enum rename whose target collides with the source when the name exceeds the identifier length limit', async () => {
- // Real-world case: long object + field names produce an enum name over
- // 63 bytes. Naively appending `_old` truncates the suffix away and the
- // RENAME target collides with the existing type.
- const columnDefinition: WorkspaceSchemaColumnDefinition = {
- name: 'insuranceCoverageClassifications',
- type: 'enum',
- isArray: true,
- isNullable: true,
- };
-
- await service.alterEnumValues({
- queryRunner: queryRunner as unknown as QueryRunner,
- schemaName: 'workspace_adhj7eaegq93fzpgbfpdm8ok3',
- tableName: '_personalInsurancePolicyOrQuote',
- columnDefinition,
- enumValues: ['OPTION_1', 'OPTION_2', 'OPTION_3'],
- oldToNewEnumOptionMap: {},
- });
-
- const renameStatement = executedSql.find(
- (sql) => sql.includes('ALTER TYPE') && sql.includes('RENAME TO'),
- );
-
- expect(renameStatement).toBeDefined();
-
- const [sourceEnum, targetEnum] = getQuotedIdentifiers(
- renameStatement as string,
- ).slice(-2);
-
- expect(targetEnum.length).toBeLessThanOrEqual(
- POSTGRES_MAX_IDENTIFIER_LENGTH,
- );
- // Once Postgres truncates both to 63 bytes they must still differ,
- // otherwise the rename targets the type's own name.
- expect(targetEnum.slice(0, POSTGRES_MAX_IDENTIFIER_LENGTH)).not.toEqual(
- sourceEnum.slice(0, POSTGRES_MAX_IDENTIFIER_LENGTH),
- );
- });
-
- it('should keep every emitted identifier within the Postgres length limit for long names', async () => {
- const columnDefinition: WorkspaceSchemaColumnDefinition = {
- name: 'insuranceCoverageClassifications',
- type: 'enum',
- isArray: true,
- isNullable: true,
- };
-
- await service.alterEnumValues({
- queryRunner: queryRunner as unknown as QueryRunner,
- schemaName: 'workspace_adhj7eaegq93fzpgbfpdm8ok3',
- tableName: '_personalInsurancePolicyOrQuote',
- columnDefinition,
- enumValues: ['OPTION_1', 'OPTION_2'],
- oldToNewEnumOptionMap: { OPTION_1: 'OPTION_1' },
- });
-
- const temporaryIdentifiers = executedSql
- .flatMap(getQuotedIdentifiers)
- .filter((identifier) => identifier.endsWith('_old'));
-
- expect(temporaryIdentifiers.length).toBeGreaterThan(0);
- temporaryIdentifiers.forEach((identifier) =>
- expect(identifier.length).toBeLessThanOrEqual(
- POSTGRES_MAX_IDENTIFIER_LENGTH,
- ),
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-page-layout-widget-validator.service.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-page-layout-widget-validator.service.spec.ts
deleted file mode 100644
index 76e15b5f78b..00000000000
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-page-layout-widget-validator.service.spec.ts
+++ /dev/null
@@ -1,200 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { PageLayoutTabLayoutMode } from 'twenty-shared/types';
-
-import { createEmptyFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-flat-entity-maps.constant';
-import { FlatPageLayoutWidgetTypeValidatorService } from 'src/engine/metadata-modules/flat-page-layout-widget/services/flat-page-layout-widget-type-validator.service';
-import { type FlatPageLayoutWidget } from 'src/engine/metadata-modules/flat-page-layout-widget/types/flat-page-layout-widget.type';
-import { PageLayoutTabExceptionCode } from 'src/engine/metadata-modules/page-layout-tab/exceptions/page-layout-tab.exception';
-import { PageLayoutWidgetExceptionCode } from 'src/engine/metadata-modules/page-layout-widget/exceptions/page-layout-widget.exception';
-import { type UniversalFlatPageLayoutTab } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/universal-flat-page-layout-tab.type';
-import { FlatPageLayoutWidgetValidatorService } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-page-layout-widget-validator.service';
-
-const EXISTING_TAB_UNIVERSAL_IDENTIFIER =
- '00000000-0000-0000-0000-000000000aa1';
-const MISSING_TAB_UNIVERSAL_IDENTIFIER = '00000000-0000-0000-0000-000000000aa2';
-const DESTINATION_TAB_UNIVERSAL_IDENTIFIER =
- '00000000-0000-0000-0000-000000000aa3';
-const WIDGET_UNIVERSAL_IDENTIFIER = '00000000-0000-0000-0000-000000000111';
-
-const tab = (
- universalIdentifier = EXISTING_TAB_UNIVERSAL_IDENTIFIER,
- layoutMode = PageLayoutTabLayoutMode.VERTICAL_LIST,
-): UniversalFlatPageLayoutTab =>
- ({
- universalIdentifier,
- layoutMode,
- }) as unknown as UniversalFlatPageLayoutTab;
-
-const GRID_POSITION = {
- layoutMode: PageLayoutTabLayoutMode.GRID,
- row: 0,
- column: 0,
- rowSpan: 4,
- columnSpan: 4,
-};
-
-const widget = (
- universalIdentifier = WIDGET_UNIVERSAL_IDENTIFIER,
- pageLayoutTabUniversalIdentifier = EXISTING_TAB_UNIVERSAL_IDENTIFIER,
-): FlatPageLayoutWidget =>
- ({
- universalIdentifier,
- pageLayoutTabUniversalIdentifier,
- title: 'widget',
- type: 'FRONT_COMPONENT',
- gridPosition: { row: 0, column: 0, rowSpan: 12, columnSpan: 12 },
- position: { layoutMode: PageLayoutTabLayoutMode.VERTICAL_LIST, index: 0 },
- }) as unknown as FlatPageLayoutWidget;
-
-const mapsFrom = (entities: { universalIdentifier: string }[]): any => {
- const maps = createEmptyFlatEntityMaps() as any;
-
- for (const entity of entities) {
- maps.byUniversalIdentifier[entity.universalIdentifier] = entity;
- }
-
- return maps;
-};
-
-const buildUpdateArgs = ({
- update,
- tabs = [tab()],
- existingWidgets = [widget()],
-}: {
- update: Record<string, unknown>;
- tabs?: UniversalFlatPageLayoutTab[];
- existingWidgets?: FlatPageLayoutWidget[];
-}) =>
- ({
- universalIdentifier: WIDGET_UNIVERSAL_IDENTIFIER,
- flatEntityUpdate: update,
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPageLayoutTabMaps: mapsFrom(tabs),
- flatPageLayoutWidgetMaps: mapsFrom(existingWidgets),
- },
- additionalCacheDataMaps: { featureFlagsMap: {} },
- workspaceId: 'workspace-id',
- buildOptions: {} as never,
- }) as unknown as Parameters<
- FlatPageLayoutWidgetValidatorService['validateFlatPageLayoutWidgetUpdate']
- >[0];
-
-describe('FlatPageLayoutWidgetValidatorService', () => {
- let service: FlatPageLayoutWidgetValidatorService;
-
- beforeEach(async () => {
- const moduleRef: TestingModule = await Test.createTestingModule({
- providers: [
- FlatPageLayoutWidgetValidatorService,
- {
- provide: FlatPageLayoutWidgetTypeValidatorService,
- useValue: {
- validateFlatPageLayoutWidgetTypeSpecificitiesForCreation: () => [],
- validateFlatPageLayoutWidgetTypeSpecificitiesForUpdate: () => [],
- },
- },
- ],
- }).compile();
-
- service = moduleRef.get(FlatPageLayoutWidgetValidatorService);
- });
-
- describe('validateFlatPageLayoutWidgetUpdate', () => {
- it('rejects moving a widget to an unknown tab', async () => {
- const result = await service.validateFlatPageLayoutWidgetUpdate(
- buildUpdateArgs({
- update: {
- pageLayoutTabUniversalIdentifier: MISSING_TAB_UNIVERSAL_IDENTIFIER,
- },
- }),
- );
-
- expect(result.errors.map((error) => error.code)).toContain(
- PageLayoutTabExceptionCode.PAGE_LAYOUT_TAB_NOT_FOUND,
- );
- });
-
- it('rejects moving an overridden widget to an unknown tab', async () => {
- const result = await service.validateFlatPageLayoutWidgetUpdate(
- buildUpdateArgs({
- update: {
- universalOverrides: {
- pageLayoutTabUniversalIdentifier:
- MISSING_TAB_UNIVERSAL_IDENTIFIER,
- },
- },
- }),
- );
-
- expect(result.errors.map((error) => error.code)).toContain(
- PageLayoutTabExceptionCode.PAGE_LAYOUT_TAB_NOT_FOUND,
- );
- });
-
- it('accepts moving an overridden widget to a known tab and exposes the override target as the effective tab', async () => {
- const result = await service.validateFlatPageLayoutWidgetUpdate(
- buildUpdateArgs({
- update: {
- universalOverrides: {
- pageLayoutTabUniversalIdentifier:
- DESTINATION_TAB_UNIVERSAL_IDENTIFIER,
- },
- },
- tabs: [tab(), tab(DESTINATION_TAB_UNIVERSAL_IDENTIFIER)],
- }),
- );
-
- expect(result.errors.map((error) => error.code)).not.toContain(
- PageLayoutTabExceptionCode.PAGE_LAYOUT_TAB_NOT_FOUND,
- );
- expect(
- result.flatEntityMinimalInformation.pageLayoutTabUniversalIdentifier,
- ).toBe(DESTINATION_TAB_UNIVERSAL_IDENTIFIER);
- });
-
- it('rejects a position whose layout mode does not match its tab', async () => {
- const result = await service.validateFlatPageLayoutWidgetUpdate(
- buildUpdateArgs({
- update: { position: GRID_POSITION },
- }),
- );
-
- expect(result.errors.map((error) => error.code)).toContain(
- PageLayoutWidgetExceptionCode.INVALID_PAGE_LAYOUT_WIDGET_DATA,
- );
- });
-
- it('accepts a position whose layout mode matches a tab already flipped in the same build', async () => {
- const result = await service.validateFlatPageLayoutWidgetUpdate(
- buildUpdateArgs({
- update: { position: GRID_POSITION },
- tabs: [
- tab(
- EXISTING_TAB_UNIVERSAL_IDENTIFIER,
- PageLayoutTabLayoutMode.GRID,
- ),
- ],
- }),
- );
-
- expect(result.errors).toEqual([]);
- });
-
- it('accepts a null position against a tab of any layout mode', async () => {
- const result = await service.validateFlatPageLayoutWidgetUpdate(
- buildUpdateArgs({
- update: { position: null },
- tabs: [
- tab(
- EXISTING_TAB_UNIVERSAL_IDENTIFIER,
- PageLayoutTabLayoutMode.GRID,
- ),
- ],
- }),
- );
-
- expect(result.errors).toEqual([]);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-permission-flag-validator.service.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-permission-flag-validator.service.spec.ts
deleted file mode 100644
index 227a787e635..00000000000
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-permission-flag-validator.service.spec.ts
+++ /dev/null
@@ -1,326 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ALL_METADATA_NAME } from 'twenty-shared/metadata';
-
-import { createEmptyFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-flat-entity-maps.constant';
-import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
-import { type FlatRolePermissionFlag } from 'src/engine/metadata-modules/flat-role-permission-flag/types/flat-role-permission-flag.type';
-import { type FlatPermissionFlag } from 'src/engine/metadata-modules/flat-permission-flag/types/flat-permission-flag.type';
-import { type PermissionFlagPermissionType } from 'src/engine/metadata-modules/permission-flag/constants/permission-flag-permission-type.constant';
-import { PermissionFlagExceptionCode } from 'src/engine/metadata-modules/permission-flag/permission-flag.exception';
-import { TWENTY_STANDARD_APPLICATION } from 'src/engine/workspace-manager/twenty-standard-application/constants/twenty-standard-applications';
-import { FlatPermissionFlagValidatorService } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-permission-flag-validator.service';
-
-const buildFlatDefinition = (
- overrides: Partial<FlatPermissionFlag> = {},
-): FlatPermissionFlag =>
- ({
- id: '00000000-0000-0000-0000-000000000001',
- universalIdentifier: '00000000-0000-0000-0000-000000000001',
- key: 'TEST_FLAG',
- label: 'Test Flag',
- description: 'A flag for tests',
- icon: 'IconTest',
- permissionType: 'tool',
- workspaceId: 'workspace-id',
- applicationId: '00000000-0000-0000-0000-000000000aaa',
- applicationUniversalIdentifier: '00000000-0000-0000-0000-000000000aaa',
- createdAt: new Date().toISOString(),
- updatedAt: new Date().toISOString(),
- ...overrides,
- }) as unknown as FlatPermissionFlag;
-
-const buildEmptyMaps = (): FlatEntityMaps<FlatPermissionFlag> =>
- createEmptyFlatEntityMaps() as unknown as FlatEntityMaps<FlatPermissionFlag>;
-
-const buildEmptyRolePermissionFlagMaps =
- (): FlatEntityMaps<FlatRolePermissionFlag> =>
- createEmptyFlatEntityMaps() as unknown as FlatEntityMaps<FlatRolePermissionFlag>;
-
-const buildArgs = (
- flatEntityToValidate: FlatPermissionFlag,
- optimisticMaps: FlatEntityMaps<FlatPermissionFlag> = buildEmptyMaps(),
-) =>
- ({
- flatEntityToValidate,
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPermissionFlagMaps: optimisticMaps,
- },
- buildOptions: {} as never,
- }) as unknown as Parameters<
- FlatPermissionFlagValidatorService['validateFlatPermissionFlagCreation']
- >[0];
-
-describe('FlatPermissionFlagValidatorService', () => {
- let service: FlatPermissionFlagValidatorService;
-
- beforeEach(async () => {
- const moduleRef: TestingModule = await Test.createTestingModule({
- providers: [FlatPermissionFlagValidatorService],
- }).compile();
-
- service = moduleRef.get(FlatPermissionFlagValidatorService);
- });
-
- describe('validateFlatPermissionFlagCreation', () => {
- it('passes for a valid definition', () => {
- const result = service.validateFlatPermissionFlagCreation(
- buildArgs(buildFlatDefinition()),
- );
-
- expect(result.errors).toHaveLength(0);
- });
-
- it('rejects an empty key', () => {
- const result = service.validateFlatPermissionFlagCreation(
- buildArgs(buildFlatDefinition({ key: '' })),
- );
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.INVALID_PERMISSION_FLAG_KEY,
- ]);
- });
-
- it('rejects an unknown permission type', () => {
- const result = service.validateFlatPermissionFlagCreation(
- buildArgs(
- buildFlatDefinition({
- permissionType: 'invalid' as PermissionFlagPermissionType,
- }),
- ),
- );
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.INVALID_PERMISSION_FLAG_PERMISSION_TYPE,
- ]);
- });
-
- it('rejects a duplicate key in the same workspace', () => {
- const existing = buildFlatDefinition({
- universalIdentifier: '00000000-0000-0000-0000-000000000999',
- key: 'EXISTING_KEY',
- });
- const optimisticMaps = buildEmptyMaps();
- optimisticMaps.byUniversalIdentifier[existing.universalIdentifier] =
- existing;
-
- const result = service.validateFlatPermissionFlagCreation(
- buildArgs(buildFlatDefinition({ key: 'EXISTING_KEY' }), optimisticMaps),
- );
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.PERMISSION_FLAG_ALREADY_EXISTS,
- ]);
- });
-
- it('rejects a duplicate universal identifier', () => {
- const existing = buildFlatDefinition();
- const optimisticMaps = buildEmptyMaps();
- optimisticMaps.byUniversalIdentifier[existing.universalIdentifier] =
- existing;
-
- const result = service.validateFlatPermissionFlagCreation(
- buildArgs(
- buildFlatDefinition({
- id: '00000000-0000-0000-0000-000000000002',
- key: 'ANOTHER_TEST_FLAG',
- }),
- optimisticMaps,
- ),
- );
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.PERMISSION_FLAG_ALREADY_EXISTS,
- ]);
- });
- });
-
- describe('validateFlatPermissionFlagUpdate', () => {
- it('passes for a valid update', () => {
- const existing = buildFlatDefinition();
- const optimisticMaps = buildEmptyMaps();
- optimisticMaps.byUniversalIdentifier[existing.universalIdentifier] =
- existing;
-
- const result = service.validateFlatPermissionFlagUpdate({
- universalIdentifier: existing.universalIdentifier,
- flatEntityUpdate: { label: 'Updated Label' },
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPermissionFlagMaps: optimisticMaps,
- },
- buildOptions: {} as never,
- } as unknown as Parameters<
- FlatPermissionFlagValidatorService['validateFlatPermissionFlagUpdate']
- >[0]);
-
- expect(result.errors).toHaveLength(0);
- });
-
- it('rejects updating the immutable key field', () => {
- const existing = buildFlatDefinition({ key: 'ORIGINAL_KEY' });
- const optimisticMaps = buildEmptyMaps();
- optimisticMaps.byUniversalIdentifier[existing.universalIdentifier] =
- existing;
-
- const result = service.validateFlatPermissionFlagUpdate({
- universalIdentifier: existing.universalIdentifier,
- flatEntityUpdate: { key: 'NEW_KEY' },
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPermissionFlagMaps: optimisticMaps,
- },
- buildOptions: {} as never,
- } as unknown as Parameters<
- FlatPermissionFlagValidatorService['validateFlatPermissionFlagUpdate']
- >[0]);
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.PERMISSION_FLAG_KEY_IMMUTABLE,
- ]);
- });
-
- it('returns not-found if no existing definition matches the universalIdentifier', () => {
- const result = service.validateFlatPermissionFlagUpdate({
- universalIdentifier: '00000000-0000-0000-0000-deadbeefdead',
- flatEntityUpdate: { label: 'New Label' },
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPermissionFlagMaps: buildEmptyMaps(),
- },
- buildOptions: {} as never,
- } as unknown as Parameters<
- FlatPermissionFlagValidatorService['validateFlatPermissionFlagUpdate']
- >[0]);
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.PERMISSION_FLAG_NOT_FOUND,
- ]);
- });
-
- it('rejects updating a standard definition from a custom application', () => {
- const existing = buildFlatDefinition({
- applicationUniversalIdentifier:
- TWENTY_STANDARD_APPLICATION.universalIdentifier,
- });
- const optimisticMaps = buildEmptyMaps();
- optimisticMaps.byUniversalIdentifier[existing.universalIdentifier] =
- existing;
-
- const result = service.validateFlatPermissionFlagUpdate({
- universalIdentifier: existing.universalIdentifier,
- flatEntityUpdate: { label: 'Updated Label' },
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPermissionFlagMaps: optimisticMaps,
- },
- buildOptions: {
- isSystemBuild: false,
- applicationUniversalIdentifier:
- '00000000-0000-0000-0000-000000000aaa',
- },
- } as unknown as Parameters<
- FlatPermissionFlagValidatorService['validateFlatPermissionFlagUpdate']
- >[0]);
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.PERMISSION_FLAG_IS_STANDARD,
- ]);
- });
-
- it('rejects updating to an unknown permission type', () => {
- const existing = buildFlatDefinition();
- const optimisticMaps = buildEmptyMaps();
- optimisticMaps.byUniversalIdentifier[existing.universalIdentifier] =
- existing;
-
- const result = service.validateFlatPermissionFlagUpdate({
- universalIdentifier: existing.universalIdentifier,
- flatEntityUpdate: {
- permissionType: 'invalid' as PermissionFlagPermissionType,
- },
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPermissionFlagMaps: optimisticMaps,
- },
- buildOptions: {} as never,
- } as unknown as Parameters<
- FlatPermissionFlagValidatorService['validateFlatPermissionFlagUpdate']
- >[0]);
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.INVALID_PERMISSION_FLAG_PERMISSION_TYPE,
- ]);
- });
- });
-
- describe('validateFlatPermissionFlagDeletion', () => {
- it('passes for a valid deletion', () => {
- const existing = buildFlatDefinition();
- const optimisticMaps = buildEmptyMaps();
- optimisticMaps.byUniversalIdentifier[existing.universalIdentifier] =
- existing;
-
- const result = service.validateFlatPermissionFlagDeletion({
- flatEntityToValidate: existing,
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPermissionFlagMaps: optimisticMaps,
- flatRolePermissionFlagMaps: buildEmptyRolePermissionFlagMaps(),
- },
- buildOptions: {} as never,
- } as unknown as Parameters<
- FlatPermissionFlagValidatorService['validateFlatPermissionFlagDeletion']
- >[0]);
-
- expect(result.errors).toHaveLength(0);
- });
-
- it('returns not-found if no existing definition matches the universalIdentifier', () => {
- const result = service.validateFlatPermissionFlagDeletion({
- flatEntityToValidate: buildFlatDefinition({
- universalIdentifier: '00000000-0000-0000-0000-deadbeefdead',
- }),
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPermissionFlagMaps: buildEmptyMaps(),
- flatRolePermissionFlagMaps: buildEmptyRolePermissionFlagMaps(),
- },
- buildOptions: {} as never,
- } as unknown as Parameters<
- FlatPermissionFlagValidatorService['validateFlatPermissionFlagDeletion']
- >[0]);
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.PERMISSION_FLAG_NOT_FOUND,
- ]);
- });
-
- it('rejects deleting a standard definition from a custom application', () => {
- const existing = buildFlatDefinition({
- applicationUniversalIdentifier:
- TWENTY_STANDARD_APPLICATION.universalIdentifier,
- });
- const optimisticMaps = buildEmptyMaps();
- optimisticMaps.byUniversalIdentifier[existing.universalIdentifier] =
- existing;
-
- const result = service.validateFlatPermissionFlagDeletion({
- flatEntityToValidate: existing,
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatPermissionFlagMaps: optimisticMaps,
- flatRolePermissionFlagMaps: buildEmptyRolePermissionFlagMaps(),
- },
- buildOptions: {
- isSystemBuild: false,
- applicationUniversalIdentifier:
- '00000000-0000-0000-0000-000000000aaa',
- },
- } as unknown as Parameters<
- FlatPermissionFlagValidatorService['validateFlatPermissionFlagDeletion']
- >[0]);
-
- expect(result.errors.map((error) => error.code)).toEqual([
- PermissionFlagExceptionCode.PERMISSION_FLAG_IS_STANDARD,
- ]);
- });
- });
-
- // ALL_METADATA_NAME is referenced as a sanity check the metadata name exists
- it('uses the registered ALL_METADATA_NAME entry', () => {
- expect(ALL_METADATA_NAME.permissionFlag).toBe('permissionFlag');
- });
-});
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-view-filter-validator.service.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-view-filter-validator.service.spec.ts
deleted file mode 100644
index 55e1667b686..00000000000
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-view-filter-validator.service.spec.ts
+++ /dev/null
@@ -1,198 +0,0 @@
-import { FieldMetadataType, ViewFilterOperand } from 'twenty-shared/types';
-
-import { FlatViewFilterValidatorService } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-view-filter-validator.service';
-
-const VIEW_UNIVERSAL_IDENTIFIER = '00000000-0000-4000-8000-0000000000c1';
-const FIELD_UNIVERSAL_IDENTIFIER = '00000000-0000-4000-8000-0000000000d1';
-const VIEW_FILTER_UNIVERSAL_IDENTIFIER = '00000000-0000-4000-8000-0000000000e1';
-
-const mapsFrom = (
- entities: { universalIdentifier: string; [key: string]: unknown }[],
-) => ({
- byUniversalIdentifier: Object.fromEntries(
- entities.map((entity) => [entity.universalIdentifier, entity]),
- ),
-});
-
-const buildFlatViewFilter = ({
- operand,
- value,
- subFieldName = null,
-}: {
- operand: ViewFilterOperand;
- value: unknown;
- subFieldName?: string | null;
-}) => ({
- universalIdentifier: VIEW_FILTER_UNIVERSAL_IDENTIFIER,
- viewUniversalIdentifier: VIEW_UNIVERSAL_IDENTIFIER,
- fieldMetadataUniversalIdentifier: FIELD_UNIVERSAL_IDENTIFIER,
- viewFilterGroupUniversalIdentifier: null,
- relationTargetFieldMetadataUniversalIdentifier: null,
- operand,
- value,
- subFieldName,
-});
-
-const buildCreationArgs = ({
- fieldType,
- operand,
- value,
- subFieldName,
-}: {
- fieldType: FieldMetadataType;
- operand: ViewFilterOperand;
- value: unknown;
- subFieldName?: string | null;
-}) =>
- ({
- flatEntityToValidate: buildFlatViewFilter({ operand, value, subFieldName }),
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatViewFilterMaps: mapsFrom([]),
- flatViewMaps: mapsFrom([
- { universalIdentifier: VIEW_UNIVERSAL_IDENTIFIER },
- ]),
- flatFieldMetadataMaps: mapsFrom([
- {
- universalIdentifier: FIELD_UNIVERSAL_IDENTIFIER,
- type: fieldType,
- label: 'Expires At',
- },
- ]),
- flatViewFilterGroupMaps: mapsFrom([]),
- },
- }) as unknown as Parameters<
- FlatViewFilterValidatorService['validateFlatViewFilterCreation']
- >[0];
-
-const buildUpdateArgs = ({
- fieldType,
- operand,
- flatEntityUpdate,
-}: {
- fieldType: FieldMetadataType;
- operand: ViewFilterOperand;
- flatEntityUpdate: Record<string, unknown>;
-}) =>
- ({
- universalIdentifier: VIEW_FILTER_UNIVERSAL_IDENTIFIER,
- flatEntityUpdate,
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatViewFilterMaps: mapsFrom([
- buildFlatViewFilter({ operand, value: 'NEXT_30_DAY' }),
- ]),
- flatFieldMetadataMaps: mapsFrom([
- {
- universalIdentifier: FIELD_UNIVERSAL_IDENTIFIER,
- type: fieldType,
- label: 'Expires At',
- },
- ]),
- flatViewFilterGroupMaps: mapsFrom([]),
- },
- }) as unknown as Parameters<
- FlatViewFilterValidatorService['validateFlatViewFilterUpdate']
- >[0];
-
-describe('FlatViewFilterValidatorService', () => {
- let service: FlatViewFilterValidatorService;
-
- beforeEach(() => {
- service = new FlatViewFilterValidatorService();
- });
-
- describe('value validation on creation', () => {
- it('should accept a value still being filled in', () => {
- const result = service.validateFlatViewFilterCreation(
- buildCreationArgs({
- fieldType: FieldMetadataType.DATE,
- operand: ViewFilterOperand.IS_RELATIVE,
- value: '',
- }),
- );
-
- expect(result.errors).toEqual([]);
- });
-
- it('should not validate a value for an operand expecting none', () => {
- const result = service.validateFlatViewFilterCreation(
- buildCreationArgs({
- fieldType: FieldMetadataType.DATE,
- operand: ViewFilterOperand.IS_TODAY,
- value: 'anything',
- }),
- );
-
- expect(result.errors).toEqual([]);
- });
-
- it('should reject an unsupported operand on a MORPH_RELATION field', () => {
- const result = service.validateFlatViewFilterCreation(
- buildCreationArgs({
- fieldType: FieldMetadataType.MORPH_RELATION,
- operand: ViewFilterOperand.IS_RELATIVE,
- value: 'NEXT_30_DAY',
- }),
- );
-
- expect(result.errors).toHaveLength(1);
- expect(result.errors[0].message).toContain(
- 'is not supported on field type',
- );
- });
-
- it('should reject an unsupported operand on a RICH_TEXT field', () => {
- const result = service.validateFlatViewFilterCreation(
- buildCreationArgs({
- fieldType: FieldMetadataType.RICH_TEXT,
- operand: ViewFilterOperand.IS_RELATIVE,
- value: 'NEXT_30_DAY',
- }),
- );
-
- expect(result.errors).toHaveLength(1);
- expect(result.errors[0].message).toContain(
- 'is not supported on field type',
- );
- });
- });
-
- describe('value validation on update', () => {
- it('should reject an invalid value being written', () => {
- const result = service.validateFlatViewFilterUpdate(
- buildUpdateArgs({
- fieldType: FieldMetadataType.DATE,
- operand: ViewFilterOperand.IS_RELATIVE,
- flatEntityUpdate: {
- value: { direction: 'NEXT', amount: 30, unit: 'DAY' },
- },
- }),
- );
-
- expect(result.errors).toHaveLength(1);
- });
-
- it('should revalidate when the sub field changes the applicable schema', () => {
- const result = service.validateFlatViewFilterUpdate(
- buildUpdateArgs({
- fieldType: FieldMetadataType.CURRENCY,
- operand: ViewFilterOperand.IS,
- flatEntityUpdate: { subFieldName: 'currencyCode' },
- }),
- );
-
- expect(result.errors).toHaveLength(1);
- });
-
- it('should not validate the value when it is not part of the update', () => {
- const result = service.validateFlatViewFilterUpdate(
- buildUpdateArgs({
- fieldType: FieldMetadataType.DATE,
- operand: ViewFilterOperand.IS_RELATIVE,
- flatEntityUpdate: { positionInViewFilterGroup: 2 },
- }),
- );
-
- expect(result.errors).toEqual([]);
- });
- });
-});
diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-view-validator.service.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-view-validator.service.spec.ts
deleted file mode 100644
index 96739bc3118..00000000000
--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/__tests__/flat-view-validator.service.spec.ts
+++ /dev/null
@@ -1,188 +0,0 @@
-import { ViewKey, ViewType } from 'twenty-shared/types';
-
-import { FlatViewValidatorService } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-view-validator.service';
-
-const OBJECT_UNIVERSAL_IDENTIFIER = '00000000-0000-4000-8000-0000000000b1';
-const VIEW_UNIVERSAL_IDENTIFIER = '00000000-0000-4000-8000-0000000000c1';
-const OTHER_VIEW_UNIVERSAL_IDENTIFIER = '00000000-0000-4000-8000-0000000000c2';
-
-type TestFlatView = {
- universalIdentifier: string;
- objectMetadataUniversalIdentifier: string;
- key: ViewKey | null;
- type: ViewType;
- isSystemSideEffect: boolean;
- deletedAt: string | null;
-};
-
-const buildFlatView = (
- overrides: Partial<TestFlatView> = {},
-): TestFlatView => ({
- universalIdentifier: VIEW_UNIVERSAL_IDENTIFIER,
- objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- key: null,
- type: ViewType.TABLE,
- isSystemSideEffect: false,
- deletedAt: null,
- ...overrides,
-});
-
-const mapsFrom = (
- entities: { universalIdentifier: string; [key: string]: unknown }[],
-) => ({
- byUniversalIdentifier: Object.fromEntries(
- entities.map((entity) => [entity.universalIdentifier, entity]),
- ),
-});
-
-const buildCreationArgs = ({
- flatViewToValidate,
- existingFlatViews = [],
-}: {
- flatViewToValidate: TestFlatView;
- existingFlatViews?: TestFlatView[];
-}) =>
- ({
- flatEntityToValidate: flatViewToValidate,
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatViewMaps: mapsFrom(existingFlatViews),
- flatFieldMetadataMaps: mapsFrom([]),
- flatObjectMetadataMaps: mapsFrom([
- {
- universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,
- viewUniversalIdentifiers: existingFlatViews.map(
- (existingFlatView) => existingFlatView.universalIdentifier,
- ),
- },
- ]),
- },
- additionalCacheDataMaps: { featureFlagsMap: {} },
- }) as unknown as Parameters<
- FlatViewValidatorService['validateFlatViewCreation']
- >[0];
-
-const buildUpdateArgs = ({
- flatEntityUpdate,
- existingFlatView,
-}: {
- flatEntityUpdate: Record<string, unknown>;
- existingFlatView: TestFlatView;
-}) =>
- ({
- universalIdentifier: existingFlatView.universalIdentifier,
- flatEntityUpdate,
- optimisticFlatEntityMapsAndRelatedFlatEntityMaps: {
- flatViewMaps: mapsFrom([existingFlatView]),
- flatFieldMetadataMaps: mapsFrom([]),
- },
- additionalCacheDataMaps: { featureFlagsMap: {} },
- }) as unknown as Parameters<
- FlatViewValidatorService['validateFlatViewUpdate']
- >[0];
-
-describe('FlatViewValidatorService INDEX key reservation', () => {
- let service: FlatViewValidatorService;
-
- beforeEach(() => {
- service = new FlatViewValidatorService();
- });
-
- describe('creation', () => {
- it('rejects a caller-provided INDEX view', () => {
- const result = service.validateFlatViewCreation(
- buildCreationArgs({
- flatViewToValidate: buildFlatView({
- key: ViewKey.INDEX,
- isSystemSideEffect: false,
- }),
- }),
- );
-
- expect(result.errors).toHaveLength(1);
- expect(result.errors[0].message).toContain('reserved');
- });
-
- it('accepts an engine-emitted INDEX view', () => {
- const result = service.validateFlatViewCreation(
- buildCreationArgs({
- flatViewToValidate: buildFlatView({
- key: ViewKey.INDEX,
- isSystemSideEffect: true,
- }),
- }),
- );
-
- expect(result.errors).toEqual([]);
- });
-
- it('rejects a second INDEX view on the same object', () => {
- const result = service.validateFlatViewCreation(
- buildCreationArgs({
- flatViewToValidate: buildFlatView({
- key: ViewKey.INDEX,
- isSystemSideEffect: true,
- }),
- existingFlatViews: [
- buildFlatView({
- universalIdentifier: OTHER_VIEW_UNIVERSAL_IDENTIFIER,
- key: ViewKey.INDEX,
- isSystemSideEffect: true,
- }),
- ],
- }),
- );
-
- expect(result.errors).toHaveLength(1);
- expect(result.errors[0].message).toContain(
- 'already has a view with the INDEX key',
- );
- });
-
- it('ignores a soft-deleted INDEX view when checking the singleton', () => {
- const result = service.validateFlatViewCreation(
- buildCreationArgs({
- flatViewToValidate: buildFlatView({
- key: ViewKey.INDEX,
- isSystemSideEffect: true,
- }),
- existingFlatViews: [
- buildFlatView({
- universalIdentifier: OTHER_VIEW_UNIVERSAL_IDENTIFIER,
- key: ViewKey.INDEX,
- isSystemSideEffect: true,
- deletedAt: '2024-01-01T00:00:00.000Z',
- }),
- ],
- }),
- );
-
- expect(result.errors).toEqual([]);
- });
-
- it('accepts a caller-provided view without a key', () => {
- const result = service.validateFlatViewCreation(
- buildCreationArgs({
- flatViewToValidate: buildFlatView({ key: null }),
- }),
- );
-
- expect(result.errors).toEqual([]);
- });
- });
-
- describe('update', () => {
- it('accepts an update on an INDEX view', () => {
- const result = service.validateFlatViewUpdate(
- buildUpdateArgs({
- flatEntityUpdate: { name: 'Renamed default view' },
- existingFlatView: buildFlatView({
- key: ViewKey.INDEX,
- isSystemSideEffect: true,
- }),
- }),
- );
-
- expect(result.errors).toEqual([]);
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/drivers/caldav/services/__tests__/caldav-create-event.service.spec.ts b/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/drivers/caldav/services/__tests__/caldav-create-event.service.spec.ts
deleted file mode 100644
index 7631ed92a13..00000000000
--- a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/drivers/caldav/services/__tests__/caldav-create-event.service.spec.ts
+++ /dev/null
@@ -1,108 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-
-import { CalDavCreateEventService } from 'src/modules/calendar/calendar-event-creation-manager/drivers/caldav/services/caldav-create-event.service';
-import { CalendarEventCreationException } from 'src/modules/calendar/calendar-event-creation-manager/exceptions/calendar-event-creation.exception';
-import { type CalendarEventToCreate } from 'src/modules/calendar/calendar-event-creation-manager/types/calendar-event-to-create.type';
-import { CalDavClientProvider } from 'src/modules/calendar/calendar-event-import-manager/drivers/caldav/providers/caldav-client.provider';
-import { CalDavFetchEventsService } from 'src/modules/calendar/calendar-event-import-manager/drivers/caldav/services/caldav-fetch-events.service';
-
-const connectedAccount = {
- id: 'account-1',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
-};
-
-const baseInput: CalendarEventToCreate = {
- title: 'Sync',
- startsAt: '2026-07-01T14:00:00Z',
- endsAt: '2026-07-01T15:00:00Z',
- isFullDay: false,
- timeZone: 'UTC',
- attendees: [],
- sendInvitations: false,
- addConferencing: false,
-};
-
-const CALENDAR_URL = 'https://dav.example.com/calendars/jane/default/';
-
-describe('CalDavCreateEventService', () => {
- let service: CalDavCreateEventService;
- const createCalendarObject = jest.fn();
- const client = { createCalendarObject };
- const getClient = jest.fn();
- const listEventCalendars = jest.fn();
- const fetchEventsByHrefs = jest.fn();
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- CalDavCreateEventService,
- { provide: CalDavClientProvider, useValue: { getClient } },
- {
- provide: CalDavFetchEventsService,
- useValue: { listEventCalendars, fetchEventsByHrefs },
- },
- ],
- }).compile();
-
- service = module.get(CalDavCreateEventService);
-
- getClient.mockResolvedValue(client);
- listEventCalendars.mockResolvedValue([{ url: CALENDAR_URL }]);
- createCalendarObject.mockResolvedValue({});
- });
-
- afterEach(() => jest.clearAllMocks());
-
- it('keys the event on the server-returned href, not the locally reconstructed url', async () => {
- const serverHref = '/calendars/jane/default/server-assigned.ics';
-
- fetchEventsByHrefs.mockResolvedValue([
- { id: serverHref, iCalUid: 'whatever' },
- ]);
-
- const result = await service.createCalendarEvent(
- baseInput,
- connectedAccount,
- );
-
- expect(createCalendarObject).toHaveBeenCalledTimes(1);
- expect(fetchEventsByHrefs).toHaveBeenCalledWith(client, [
- expect.stringMatching(/^https:\/\/dav\.example\.com\/.*\.ics$/),
- ]);
- expect(result.id).toBe(serverHref);
- });
-
- it('falls back to the reconstructed href when the server copy is not retrievable', async () => {
- fetchEventsByHrefs.mockResolvedValue([]);
-
- const result = await service.createCalendarEvent(
- baseInput,
- connectedAccount,
- );
-
- expect(result.id).toMatch(
- /^https:\/\/dav\.example\.com\/calendars\/jane\/default\/.*\.ics$/,
- );
- });
-
- it('falls back to the reconstructed href when re-fetch fails, without failing the create', async () => {
- fetchEventsByHrefs.mockRejectedValue(new Error('network'));
-
- const result = await service.createCalendarEvent(
- baseInput,
- connectedAccount,
- );
-
- expect(result.id).toMatch(/\.ics$/);
- });
-
- it('throws when no writable calendar is available', async () => {
- listEventCalendars.mockResolvedValue([]);
-
- await expect(
- service.createCalendarEvent(baseInput, connectedAccount),
- ).rejects.toThrow(CalendarEventCreationException);
- });
-});
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/drivers/google-calendar/services/__tests__/google-calendar-create-event.service.spec.ts b/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/drivers/google-calendar/services/__tests__/google-calendar-create-event.service.spec.ts
deleted file mode 100644
index 78c0ff6f22c..00000000000
--- a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/drivers/google-calendar/services/__tests__/google-calendar-create-event.service.spec.ts
+++ /dev/null
@@ -1,132 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { google } from 'googleapis';
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-
-import { GoogleCalendarCreateEventService } from 'src/modules/calendar/calendar-event-creation-manager/drivers/google-calendar/services/google-calendar-create-event.service';
-import { CalendarEventCreationException } from 'src/modules/calendar/calendar-event-creation-manager/exceptions/calendar-event-creation.exception';
-import { type CalendarEventToCreate } from 'src/modules/calendar/calendar-event-creation-manager/types/calendar-event-to-create.type';
-import { GoogleOAuth2ClientProvider } from 'src/modules/connected-account/oauth2-client-manager/drivers/google/google-oauth2-client.provider';
-
-const connectedAccount = {
- id: 'account-1',
- provider: ConnectedAccountProvider.GOOGLE,
-};
-
-const baseInput: CalendarEventToCreate = {
- title: 'Sync',
- startsAt: '2026-07-01T14:00:00Z',
- endsAt: '2026-07-01T15:00:00Z',
- isFullDay: false,
- timeZone: 'UTC',
- attendees: [],
- sendInvitations: false,
- addConferencing: false,
-};
-
-describe('GoogleCalendarCreateEventService', () => {
- let service: GoogleCalendarCreateEventService;
- const insert = jest.fn();
- const get = jest.fn();
-
- beforeEach(async () => {
- jest
- .spyOn(google, 'calendar')
- .mockReturnValue({ events: { insert, get } } as never);
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- GoogleCalendarCreateEventService,
- {
- provide: GoogleOAuth2ClientProvider,
- useValue: { getClient: jest.fn().mockResolvedValue({}) },
- },
- ],
- }).compile();
-
- service = module.get(GoogleCalendarCreateEventService);
-
- insert.mockResolvedValue({
- data: {
- id: 'google-event-1',
- iCalUID: '[email protected]',
- summary: 'Sync',
- status: 'confirmed',
- start: { dateTime: '2026-07-01T14:00:00Z' },
- end: { dateTime: '2026-07-01T15:00:00Z' },
- },
- });
- });
-
- afterEach(() => {
- insert.mockReset();
- get.mockReset();
- jest.restoreAllMocks();
- });
-
- it('inserts the event without notifications or conferencing by default', async () => {
- const result = await service.createCalendarEvent(
- baseInput,
- connectedAccount,
- );
-
- expect(insert).toHaveBeenCalledWith(
- expect.objectContaining({
- calendarId: 'primary',
- conferenceDataVersion: 0,
- sendUpdates: 'none',
- requestBody: expect.objectContaining({ summary: 'Sync' }),
- }),
- );
- expect(get).not.toHaveBeenCalled();
- expect(result.id).toBe('google-event-1');
- expect(result.iCalUid).toBe('[email protected]');
- });
-
- it('notifies attendees and requests conferencing when enabled', async () => {
- await service.createCalendarEvent(
- { ...baseInput, sendInvitations: true, addConferencing: true },
- connectedAccount,
- );
-
- expect(insert).toHaveBeenCalledWith(
- expect.objectContaining({
- conferenceDataVersion: 1,
- sendUpdates: 'all',
- }),
- );
- });
-
- it('returns the Meet link from the insert response without re-fetching', async () => {
- insert.mockResolvedValue({
- data: {
- id: 'google-event-1',
- iCalUID: '[email protected]',
- status: 'confirmed',
- start: { dateTime: '2026-07-01T14:00:00Z' },
- end: { dateTime: '2026-07-01T15:00:00Z' },
- conferenceData: {
- entryPoints: [{ uri: 'https://meet.google.com/abc-defg-hij' }],
- },
- },
- });
-
- const result = await service.createCalendarEvent(
- { ...baseInput, addConferencing: true },
- connectedAccount,
- );
-
- expect(get).not.toHaveBeenCalled();
- expect(result.conferenceLinkUrl).toBe(
- 'https://meet.google.com/abc-defg-hij',
- );
- });
-
- it('wraps provider errors in a CalendarEventCreationException', async () => {
- insert.mockRejectedValue(new Error('boom'));
-
- await expect(
- service.createCalendarEvent(baseInput, connectedAccount),
- ).rejects.toThrow(CalendarEventCreationException);
- });
-});
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/drivers/microsoft-calendar/services/__tests__/microsoft-calendar-create-event.service.spec.ts b/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/drivers/microsoft-calendar/services/__tests__/microsoft-calendar-create-event.service.spec.ts
deleted file mode 100644
index c1cd4e9b535..00000000000
--- a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/drivers/microsoft-calendar/services/__tests__/microsoft-calendar-create-event.service.spec.ts
+++ /dev/null
@@ -1,80 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-
-import { MicrosoftCalendarCreateEventService } from 'src/modules/calendar/calendar-event-creation-manager/drivers/microsoft-calendar/services/microsoft-calendar-create-event.service';
-import { CalendarEventCreationException } from 'src/modules/calendar/calendar-event-creation-manager/exceptions/calendar-event-creation.exception';
-import { type CalendarEventToCreate } from 'src/modules/calendar/calendar-event-creation-manager/types/calendar-event-to-create.type';
-import { MicrosoftOAuth2ClientProvider } from 'src/modules/connected-account/oauth2-client-manager/drivers/microsoft/microsoft-oauth2-client.provider';
-
-const connectedAccount = {
- id: 'account-1',
- provider: ConnectedAccountProvider.MICROSOFT,
-};
-
-const baseInput: CalendarEventToCreate = {
- title: 'Sync',
- startsAt: '2026-07-01T14:00:00Z',
- endsAt: '2026-07-01T15:00:00Z',
- isFullDay: false,
- timeZone: 'UTC',
- attendees: [],
- sendInvitations: false,
- addConferencing: false,
-};
-
-describe('MicrosoftCalendarCreateEventService', () => {
- let service: MicrosoftCalendarCreateEventService;
- const post = jest.fn();
- const header = jest.fn();
- const request = { header, post };
- header.mockReturnValue(request);
- const api = jest.fn().mockReturnValue(request);
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- MicrosoftCalendarCreateEventService,
- {
- provide: MicrosoftOAuth2ClientProvider,
- useValue: { getClient: jest.fn().mockResolvedValue({ api }) },
- },
- ],
- }).compile();
-
- service = module.get(MicrosoftCalendarCreateEventService);
-
- post.mockResolvedValue({
- id: 'microsoft-event-1',
- iCalUId: '[email protected]',
- subject: 'Sync',
- start: { dateTime: '2026-07-01T14:00:00.0000000', timeZone: 'UTC' },
- end: { dateTime: '2026-07-01T15:00:00.0000000', timeZone: 'UTC' },
- });
- });
-
- afterEach(() => jest.clearAllMocks());
-
- it('posts the mapped event to the calendar events endpoint', async () => {
- const result = await service.createCalendarEvent(
- baseInput,
- connectedAccount,
- );
-
- expect(api).toHaveBeenCalledWith('/me/calendar/events');
- expect(header).toHaveBeenCalledWith('Prefer', 'outlook.timezone="UTC"');
- expect(post).toHaveBeenCalledWith(
- expect.objectContaining({ subject: 'Sync', isAllDay: false }),
- );
- expect(result.id).toBe('microsoft-event-1');
- expect(result.iCalUid).toBe('[email protected]');
- });
-
- it('wraps provider errors in a CalendarEventCreationException', async () => {
- post.mockRejectedValue(new Error('boom'));
-
- await expect(
- service.createCalendarEvent(baseInput, connectedAccount),
- ).rejects.toThrow(CalendarEventCreationException);
- });
-});
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/services/__tests__/calendar-event-composer.service.spec.ts b/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/services/__tests__/calendar-event-composer.service.spec.ts
deleted file mode 100644
index 697e725b7d2..00000000000
--- a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/services/__tests__/calendar-event-composer.service.spec.ts
+++ /dev/null
@@ -1,255 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-
-import { CalendarChannelEntity } from 'src/engine/metadata-modules/calendar-channel/entities/calendar-channel.entity';
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { CalendarEventComposerService } from 'src/modules/calendar/calendar-event-creation-manager/services/calendar-event-composer.service';
-import { type ComposeCalendarEventParams } from 'src/modules/calendar/calendar-event-creation-manager/types/compose-calendar-event-params.type';
-
-const GOOGLE_SCOPE = 'https://www.googleapis.com/auth/calendar.events';
-const WORKSPACE_ID = 'workspace-1';
-const ACCOUNT_ID = '11111111-1111-4111-8111-111111111111';
-
-const googleAccount = {
- id: ACCOUNT_ID,
- provider: ConnectedAccountProvider.GOOGLE,
- scopes: [GOOGLE_SCOPE],
- archivedAt: null,
-} as ConnectedAccountEntity;
-
-const calendarChannel = { id: 'channel-1' } as CalendarChannelEntity;
-
-const validParams: ComposeCalendarEventParams = {
- title: 'Sync',
- startsAt: '2026-07-01T14:00:00Z',
- endsAt: '2026-07-01T15:00:00Z',
- connectedAccountId: ACCOUNT_ID,
-};
-
-describe('CalendarEventComposerService', () => {
- let service: CalendarEventComposerService;
- const connectedAccountFindOne = jest.fn();
- const calendarChannelFindOne = jest.fn();
- const calendarChannelFind = jest.fn();
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- CalendarEventComposerService,
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: { findOne: connectedAccountFindOne },
- },
- {
- provide: getRepositoryToken(CalendarChannelEntity),
- useValue: {
- findOne: calendarChannelFindOne,
- find: calendarChannelFind,
- },
- },
- ],
- }).compile();
-
- service = module.get(CalendarEventComposerService);
-
- connectedAccountFindOne.mockResolvedValue(googleAccount);
- calendarChannelFindOne.mockResolvedValue(calendarChannel);
- });
-
- afterEach(() => jest.clearAllMocks());
-
- it('rejects an event without a title', async () => {
- const result = await service.composeCalendarEvent(
- { ...validParams, title: '' },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('rejects when endsAt is not after startsAt', async () => {
- const result = await service.composeCalendarEvent(
- { ...validParams, endsAt: validParams.startsAt },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('rejects a whitespace-only title', async () => {
- const result = await service.composeCalendarEvent(
- { ...validParams, title: ' ' },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('rejects a timed event without a UTC offset', async () => {
- const result = await service.composeCalendarEvent(
- {
- ...validParams,
- startsAt: '2026-07-01T14:00:00',
- endsAt: '2026-07-01T15:00:00',
- },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('rejects a date-only value for a timed event', async () => {
- const result = await service.composeCalendarEvent(
- { ...validParams, startsAt: '2026-07-01', endsAt: '2026-07-02' },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('rejects an all-day event whose start and end fall on the same day', async () => {
- const result = await service.composeCalendarEvent(
- {
- ...validParams,
- isFullDay: true,
- startsAt: '2026-07-01T00:00:00Z',
- endsAt: '2026-07-01T12:00:00Z',
- },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('accepts a valid multi-day all-day event', async () => {
- const result = await service.composeCalendarEvent(
- {
- ...validParams,
- isFullDay: true,
- startsAt: '2026-07-01',
- endsAt: '2026-07-03',
- },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(true);
- if (result.success) {
- expect(result.data.input.isFullDay).toBe(true);
- }
- });
-
- it('rejects an invalid time zone', async () => {
- const result = await service.composeCalendarEvent(
- { ...validParams, timeZone: 'Not/AZone' },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('rejects invalid attendee emails when sending invitations', async () => {
- const result = await service.composeCalendarEvent(
- {
- ...validParams,
- sendInvitations: true,
- attendees: 'not-an-email',
- },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('strips attendees entirely when invitations are not requested', async () => {
- const result = await service.composeCalendarEvent(
- {
- ...validParams,
- sendInvitations: false,
- attendees: '[email protected]',
- },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(true);
- if (result.success) {
- expect(result.data.input.attendees).toEqual([]);
- }
- });
-
- it('parses comma-separated attendees when sending invitations', async () => {
- const result = await service.composeCalendarEvent(
- {
- ...validParams,
- sendInvitations: true,
- },
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(true);
- if (result.success) {
- expect(result.data.input.attendees).toEqual([
- { email: '[email protected]' },
- { email: '[email protected]' },
- ]);
- }
- });
-
- it('fails when the connected account does not exist', async () => {
- connectedAccountFindOne.mockResolvedValue(null);
-
- const result = await service.composeCalendarEvent(
- validParams,
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('fails when the account is missing the calendar write scope', async () => {
- connectedAccountFindOne.mockResolvedValue({
- ...googleAccount,
- scopes: ['email'],
- });
-
- const result = await service.composeCalendarEvent(
- validParams,
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(false);
- });
-
- it('resolves the account and channel for a valid request', async () => {
- const result = await service.composeCalendarEvent(
- validParams,
- WORKSPACE_ID,
- );
-
- expect(result.success).toBe(true);
- if (result.success) {
- expect(result.data.connectedAccount.id).toBe(ACCOUNT_ID);
- expect(result.data.calendarChannel.id).toBe('channel-1');
- expect(result.data.input.timeZone).toBe('UTC');
- }
- });
-
- it('falls back to the first calendar-capable account when none is specified', async () => {
- calendarChannelFind.mockResolvedValue([
- { ...calendarChannel, connectedAccount: googleAccount },
- ]);
-
- const result = await service.composeCalendarEvent(
- { ...validParams, connectedAccountId: undefined },
- WORKSPACE_ID,
- );
-
- expect(calendarChannelFind).toHaveBeenCalled();
- expect(result.success).toBe(true);
- if (result.success) {
- expect(result.data.connectedAccount.id).toBe(ACCOUNT_ID);
- }
- });
-});
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/services/__tests__/create-calendar-event.service.spec.ts b/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/services/__tests__/create-calendar-event.service.spec.ts
deleted file mode 100644
index dfd32567468..00000000000
--- a/packages/twenty-server/src/modules/calendar/calendar-event-creation-manager/services/__tests__/create-calendar-event.service.spec.ts
+++ /dev/null
@@ -1,140 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-
-import { CalDavCreateEventService } from 'src/modules/calendar/calendar-event-creation-manager/drivers/caldav/services/caldav-create-event.service';
-import { GoogleCalendarCreateEventService } from 'src/modules/calendar/calendar-event-creation-manager/drivers/google-calendar/services/google-calendar-create-event.service';
-import { MicrosoftCalendarCreateEventService } from 'src/modules/calendar/calendar-event-creation-manager/drivers/microsoft-calendar/services/microsoft-calendar-create-event.service';
-import { CalendarEventCreationException } from 'src/modules/calendar/calendar-event-creation-manager/exceptions/calendar-event-creation.exception';
-import { CreateCalendarEventService } from 'src/modules/calendar/calendar-event-creation-manager/services/create-calendar-event.service';
-import { type ComposedCalendarEvent } from 'src/modules/calendar/calendar-event-creation-manager/types/composed-calendar-event.type';
-import { CalendarSaveEventsService } from 'src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service';
-import { type FetchedCalendarEvent } from 'src/modules/calendar/common/types/fetched-calendar-event';
-
-const composedEvent = (
- provider: ConnectedAccountProvider,
-): ComposedCalendarEvent =>
- ({
- input: {
- title: 'Sync',
- startsAt: '2026-07-01T14:00:00Z',
- endsAt: '2026-07-01T15:00:00Z',
- isFullDay: false,
- timeZone: 'UTC',
- attendees: [],
- sendInvitations: false,
- addConferencing: false,
- },
- connectedAccount: { id: 'account-1', provider },
- calendarChannel: { id: 'channel-1' },
- }) as unknown as ComposedCalendarEvent;
-
-const createdEvent = { id: 'event-1' } as FetchedCalendarEvent;
-
-describe('CreateCalendarEventService', () => {
- let service: CreateCalendarEventService;
- const googleCreate = jest.fn();
- const microsoftCreate = jest.fn();
- const calDavCreate = jest.fn();
- const saveCalendarEvents = jest.fn();
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- CreateCalendarEventService,
- {
- provide: GoogleCalendarCreateEventService,
- useValue: { createCalendarEvent: googleCreate },
- },
- {
- provide: MicrosoftCalendarCreateEventService,
- useValue: { createCalendarEvent: microsoftCreate },
- },
- {
- provide: CalDavCreateEventService,
- useValue: { createCalendarEvent: calDavCreate },
- },
- {
- provide: CalendarSaveEventsService,
- useValue: {
- saveCalendarEventsAndEnqueueContactCreationJob: saveCalendarEvents,
- },
- },
- ],
- }).compile();
-
- service = module.get(CreateCalendarEventService);
- });
-
- afterEach(() => jest.clearAllMocks());
-
- it('routes Google accounts to the Google driver', async () => {
- const data = composedEvent(ConnectedAccountProvider.GOOGLE);
-
- await service.createComposedCalendarEvent(data);
-
- expect(googleCreate).toHaveBeenCalledWith(
- data.input,
- data.connectedAccount,
- );
- expect(microsoftCreate).not.toHaveBeenCalled();
- });
-
- it('routes Microsoft accounts to the Microsoft driver', async () => {
- const data = composedEvent(ConnectedAccountProvider.MICROSOFT);
-
- await service.createComposedCalendarEvent(data);
-
- expect(microsoftCreate).toHaveBeenCalledWith(
- data.input,
- data.connectedAccount,
- );
- expect(googleCreate).not.toHaveBeenCalled();
- });
-
- it('routes CalDAV accounts to the CalDav driver', async () => {
- const data = composedEvent(ConnectedAccountProvider.IMAP_SMTP_CALDAV);
-
- await service.createComposedCalendarEvent(data);
-
- expect(calDavCreate).toHaveBeenCalledWith(
- data.input,
- data.connectedAccount,
- );
- expect(googleCreate).not.toHaveBeenCalled();
- expect(microsoftCreate).not.toHaveBeenCalled();
- });
-
- it('throws for unsupported providers', async () => {
- await expect(
- service.createComposedCalendarEvent(
- composedEvent(ConnectedAccountProvider.EMAIL_GROUP),
- ),
- ).rejects.toThrow(CalendarEventCreationException);
- });
-
- it('persists the created event through the save service', async () => {
- const data = composedEvent(ConnectedAccountProvider.GOOGLE);
-
- await service.persistCalendarEvent(createdEvent, data, 'workspace-1');
-
- expect(saveCalendarEvents).toHaveBeenCalledWith(
- [createdEvent],
- data.calendarChannel,
- data.connectedAccount,
- 'workspace-1',
- );
- });
-
- it('swallows persistence failures so the create still succeeds', async () => {
- saveCalendarEvents.mockRejectedValue(new Error('db down'));
-
- await expect(
- service.persistCalendarEvent(
- createdEvent,
- composedEvent(ConnectedAccountProvider.GOOGLE),
- 'workspace-1',
- ),
- ).resolves.toBeUndefined();
- });
-});
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/services/caldav-fetch-events.service.spec.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/services/caldav-fetch-events.service.spec.ts
deleted file mode 100644
index 5d3b2a39ac3..00000000000
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/caldav/services/caldav-fetch-events.service.spec.ts
+++ /dev/null
@@ -1,233 +0,0 @@
-import { type DAVClient } from 'tsdav';
-
-import { CalDavFetchEventsService } from 'src/modules/calendar/calendar-event-import-manager/drivers/caldav/services/caldav-fetch-events.service';
-
-const SERVER_URL = 'https://caldav.example.com';
-const PRIMARY_URL = `${SERVER_URL}/calendars/user/primary/`;
-const PERSONAL_URL = `${SERVER_URL}/calendars/user/personal/`;
-const HREF_A = `${PRIMARY_URL}event-a.ics`;
-const HREF_B = `${PRIMARY_URL}event-b.ics`;
-
-const buildICal = (uid: string, dtStart = '20260601T100000Z') =>
- [
- 'BEGIN:VCALENDAR',
- 'VERSION:2.0',
- 'BEGIN:VEVENT',
- `UID:${uid}`,
- `SUMMARY:${uid}`,
- `DTSTART:${dtStart}`,
- 'DTEND:20260601T110000Z',
- 'STATUS:CONFIRMED',
- 'END:VEVENT',
- 'END:VCALENDAR',
- ].join('\r\n');
-
-const buildClient = () => {
- const fetchCalendars = jest.fn();
- const syncCollection = jest.fn();
- const calendarMultiGet = jest.fn();
- const propfind = jest.fn();
-
- return {
- client: {
- serverUrl: SERVER_URL,
- fetchCalendars,
- syncCollection,
- calendarMultiGet,
- propfind,
- } as unknown as DAVClient,
- fetchCalendars,
- syncCollection,
- calendarMultiGet,
- propfind,
- };
-};
-
-describe('CalDavFetchEventsService', () => {
- let service: CalDavFetchEventsService;
-
- beforeEach(() => {
- service = new CalDavFetchEventsService();
- });
-
- describe('fetchChangedEventHrefs', () => {
- it('collects changed hrefs from sync-collection and ctag/etag calendars without fetching bodies', async () => {
- const c = buildClient();
-
- c.fetchCalendars.mockResolvedValue([
- {
- url: PRIMARY_URL,
- components: ['VEVENT'],
- reports: ['syncCollection'],
- },
- { url: PERSONAL_URL, components: ['VEVENT'], reports: [], ctag: 'c-1' },
- ]);
- c.syncCollection.mockResolvedValue([
- { href: HREF_A, status: 207, ok: true, props: {} },
- ]);
- c.propfind.mockResolvedValue([
- { href: HREF_B, status: 207, ok: true, props: { getetag: '"etag-b"' } },
- ]);
-
- const result = await service.fetchChangedEventHrefs(c.client);
-
- expect(result.changedHrefs.sort()).toEqual([HREF_A, HREF_B].sort());
- expect(result.cancelledHrefs).toEqual([]);
- expect(c.calendarMultiGet).not.toHaveBeenCalled();
- });
-
- it('separates cancelled (404) hrefs from changed ones in a sync-collection delta', async () => {
- const c = buildClient();
-
- c.fetchCalendars.mockResolvedValue([
- {
- url: PRIMARY_URL,
- components: ['VEVENT'],
- reports: ['syncCollection'],
- },
- ]);
- c.syncCollection.mockResolvedValue([
- { href: HREF_A, status: 207, ok: true, props: {} },
- { href: HREF_B, status: 404, ok: false, props: {} },
- ]);
-
- const result = await service.fetchChangedEventHrefs(c.client, {
- syncTokens: { [PRIMARY_URL]: 'token-prior' },
- });
-
- expect(result.changedHrefs).toEqual([HREF_A]);
- expect(result.cancelledHrefs).toEqual([HREF_B]);
- });
-
- it('skips network when the server CTag matches the stored CTag', async () => {
- const c = buildClient();
-
- c.fetchCalendars.mockResolvedValue([
- {
- url: PRIMARY_URL,
- components: ['VEVENT'],
- reports: [],
- ctag: 'unchanged',
- },
- ]);
-
- const storedEtags = { [HREF_A]: '"etag-a"' };
-
- const result = await service.fetchChangedEventHrefs(c.client, {
- syncTokens: {},
- ctags: { [PRIMARY_URL]: 'unchanged' },
- etags: { [PRIMARY_URL]: storedEtags },
- });
-
- expect(result.changedHrefs).toEqual([]);
- expect(c.propfind).not.toHaveBeenCalled();
- expect(result.syncCursor.etags).toEqual({ [PRIMARY_URL]: storedEtags });
- });
-
- it('separates changed from vanished hrefs in an etag diff', async () => {
- const c = buildClient();
-
- c.fetchCalendars.mockResolvedValue([
- {
- url: PRIMARY_URL,
- components: ['VEVENT'],
- reports: [],
- ctag: 'new-ctag',
- },
- ]);
- c.propfind.mockResolvedValue([
- {
- href: HREF_A,
- status: 207,
- ok: true,
- props: { getetag: '"etag-a-updated"' },
- },
- ]);
-
- const result = await service.fetchChangedEventHrefs(c.client, {
- syncTokens: {},
- ctags: { [PRIMARY_URL]: 'old-ctag' },
- etags: {
- [PRIMARY_URL]: { [HREF_A]: '"etag-a"', [HREF_B]: '"etag-b"' },
- },
- });
-
- expect(result.changedHrefs).toEqual([HREF_A]);
- expect(result.cancelledHrefs).toEqual([HREF_B]);
- });
-
- it('preserves the prior cursor entry for a calendar whose sync fails', async () => {
- const c = buildClient();
-
- c.fetchCalendars.mockResolvedValue([
- {
- url: PRIMARY_URL,
- components: ['VEVENT'],
- reports: ['syncCollection'],
- },
- ]);
- c.syncCollection.mockRejectedValue(new Error('network blip'));
-
- const result = await service.fetchChangedEventHrefs(c.client, {
- syncTokens: { [PRIMARY_URL]: 'token-prior' },
- });
-
- expect(result.changedHrefs).toEqual([]);
- expect(result.cancelledHrefs).toEqual([]);
- expect(result.syncCursor.syncTokens[PRIMARY_URL]).toBe('token-prior');
- });
-
- it('omits the sync-token on the first run so the server returns a full listing', async () => {
- const c = buildClient();
-
- c.fetchCalendars.mockResolvedValue([
- {
- url: PRIMARY_URL,
- components: ['VEVENT'],
- reports: ['syncCollection'],
- },
- ]);
- c.syncCollection.mockResolvedValue([
- { href: HREF_A, status: 207, ok: true, props: {} },
- ]);
-
- await service.fetchChangedEventHrefs(c.client);
-
- expect(c.syncCollection).toHaveBeenCalledWith(
- expect.not.objectContaining({ syncToken: expect.anything() }),
- );
- });
- });
-
- describe('fetchEventsByHrefs', () => {
- it('fetches bodies for the given hrefs grouped by calendar collection', async () => {
- const c = buildClient();
-
- c.calendarMultiGet.mockResolvedValue([
- { href: HREF_A, props: { calendarData: buildICal('uid-a') } },
- ]);
-
- const events = await service.fetchEventsByHrefs(c.client, [HREF_A]);
-
- expect(c.calendarMultiGet).toHaveBeenCalledWith(
- expect.objectContaining({ url: PRIMARY_URL, objectUrls: [HREF_A] }),
- );
- expect(events.map((event) => event.iCalUid)).toEqual(['uid-a']);
- });
-
- it('drops events that fall outside the import time window', async () => {
- const c = buildClient();
-
- c.calendarMultiGet.mockResolvedValue([
- {
- href: HREF_A,
- props: { calendarData: buildICal('uid-a', '20990101T100000Z') },
- },
- ]);
-
- const events = await service.fetchEventsByHrefs(c.client, [HREF_A]);
-
- expect(events).toEqual([]);
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/calendar/common/query-hooks/calendar-event/services/apply-calendar-events-visibility-restrictions.service.spec.ts b/packages/twenty-server/src/modules/calendar/common/query-hooks/calendar-event/services/apply-calendar-events-visibility-restrictions.service.spec.ts
deleted file mode 100644
index a680d2c19fd..00000000000
--- a/packages/twenty-server/src/modules/calendar/common/query-hooks/calendar-event/services/apply-calendar-events-visibility-restrictions.service.spec.ts
+++ /dev/null
@@ -1,385 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED } from 'twenty-shared/constants';
-
-import { CalendarChannelVisibility } from 'twenty-shared/types';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { CalendarChannelEntity } from 'src/engine/metadata-modules/calendar-channel/entities/calendar-channel.entity';
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type CalendarEventWorkspaceEntity } from 'src/modules/calendar/common/standard-objects/calendar-event.workspace-entity';
-
-import { ApplyCalendarEventsVisibilityRestrictionsService } from './apply-calendar-events-visibility-restrictions.service';
-
-const createMockCalendarEvent = (
- id: string,
- title: string,
- description: string,
-): CalendarEventWorkspaceEntity => ({
- id,
- title,
- description,
- isCanceled: false,
- isFullDay: false,
- startsAt: '2024-03-20T10:00:00Z',
- endsAt: '2024-03-20T11:00:00Z',
- location: '',
- conferenceLink: {
- primaryLinkLabel: '',
- primaryLinkUrl: '',
- secondaryLinks: null,
- },
- externalCreatedAt: '2024-03-20T09:00:00Z',
- externalUpdatedAt: '2024-03-20T09:00:00Z',
- deletedAt: null,
- createdAt: '2024-03-20T09:00:00Z',
- updatedAt: '2024-03-20T09:00:00Z',
- iCalUid: '',
- conferenceSolution: '',
- calendarChannelEventAssociations: [],
- calendarEventParticipants: [],
-});
-
-describe('ApplyCalendarEventsVisibilityRestrictionsService', () => {
- let service: ApplyCalendarEventsVisibilityRestrictionsService;
-
- const mockCalendarEventAssociationRepository = {
- find: jest.fn(),
- };
-
- const mockWorkspaceMemberRepository = {
- findOneByOrFail: jest.fn(),
- };
-
- const mockConnectedAccountRepository = {
- find: jest.fn(),
- };
-
- const mockUserWorkspaceRepository = {
- findOne: jest.fn(),
- };
-
- const mockCalendarChannelRepository = {
- find: jest.fn(),
- };
-
- const mockGlobalWorkspaceOrmManager = {
- getRepository: jest.fn().mockImplementation((workspaceId, name) => {
- if (name === 'calendarChannelEventAssociation') {
- return mockCalendarEventAssociationRepository;
- }
- if (name === 'workspaceMember') {
- return mockWorkspaceMemberRepository;
- }
- }),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplyCalendarEventsVisibilityRestrictionsService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: mockGlobalWorkspaceOrmManager,
- },
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: mockConnectedAccountRepository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: mockUserWorkspaceRepository,
- },
- {
- provide: getRepositoryToken(CalendarChannelEntity),
- useValue: mockCalendarChannelRepository,
- },
- ],
- }).compile();
-
- service = module.get<ApplyCalendarEventsVisibilityRestrictionsService>(
- ApplyCalendarEventsVisibilityRestrictionsService,
- );
-
- // Clear all mocks before each test
- jest.clearAllMocks();
- });
-
- it('should return calendar event without obfuscated title and description if the visibility is SHARE_EVERYTHING', async () => {
- const calendarEvents = [
- createMockCalendarEvent('1', 'Test Event', 'Test Description'),
- ];
-
- mockCalendarEventAssociationRepository.find.mockResolvedValue([
- {
- calendarEventId: '1',
- calendarChannelId: '1',
- },
- ]);
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- {
- id: '1',
- visibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- },
- ]);
-
- const result = await service.applyCalendarEventsVisibilityRestrictions(
- calendarEvents,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual(calendarEvents);
- expect(
- result.every(
- (item) =>
- item.title !== FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED &&
- item.description !== FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- ),
- ).toBe(true);
- expect(mockConnectedAccountRepository.find).not.toHaveBeenCalled();
- });
-
- it('should return calendar event with obfuscated title and description if the visibility is METADATA', async () => {
- const calendarEvents = [
- createMockCalendarEvent('1', 'Test Event', 'Test Description'),
- ];
-
- mockCalendarEventAssociationRepository.find.mockResolvedValue([
- {
- calendarEventId: '1',
- calendarChannelId: '1',
- },
- ]);
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- {
- id: '1',
- visibility: CalendarChannelVisibility.METADATA,
- },
- ]);
-
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- });
-
- mockConnectedAccountRepository.find.mockResolvedValue([]);
-
- const result = await service.applyCalendarEventsVisibilityRestrictions(
- calendarEvents,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual([
- {
- ...calendarEvents[0],
- title: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- description: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- ]);
- });
-
- it('should return calendar event without obfuscated title and description if the workspace member is the owner of the calendar event', async () => {
- const calendarEvents = [
- createMockCalendarEvent('1', 'Test Event', 'Test Description'),
- ];
-
- mockCalendarEventAssociationRepository.find.mockResolvedValue([
- {
- calendarEventId: '1',
- calendarChannelId: '1',
- },
- ]);
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- {
- id: '1',
- visibility: CalendarChannelVisibility.METADATA,
- },
- ]);
-
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- });
-
- mockConnectedAccountRepository.find.mockResolvedValue([{ id: '1' }]);
-
- const result = await service.applyCalendarEventsVisibilityRestrictions(
- calendarEvents,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual(calendarEvents);
- expect(
- result.every(
- (item) =>
- item.title !== FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED &&
- item.description !== FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- ),
- ).toBe(true);
- });
-
- it('should not return calendar event if visibility is not SHARE_EVERYTHING or METADATA and the workspace member is not the owner of the calendar event', async () => {
- const calendarEvents = [
- createMockCalendarEvent('1', 'Test Event', 'Test Description'),
- ];
-
- mockCalendarEventAssociationRepository.find.mockResolvedValue([
- {
- calendarEventId: '1',
- calendarChannelId: '1',
- },
- ]);
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- {
- id: '1',
- },
- ]);
-
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- });
-
- mockConnectedAccountRepository.find.mockResolvedValue([]);
-
- const result = await service.applyCalendarEventsVisibilityRestrictions(
- calendarEvents,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual([]);
- });
-
- it('should return all calendar events with the right visibility', async () => {
- const calendarEvents = [
- createMockCalendarEvent('1', 'Event 1', 'Description 1'),
- createMockCalendarEvent('2', 'Event 2', 'Description 2'),
- createMockCalendarEvent('3', 'Event 3', 'Description 3'),
- ];
-
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- });
-
- mockCalendarEventAssociationRepository.find.mockResolvedValue([
- {
- calendarEventId: '1',
- calendarChannelId: '1',
- },
- {
- calendarEventId: '2',
- calendarChannelId: '2',
- },
- {
- calendarEventId: '3',
- calendarChannelId: '3',
- },
- ]);
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- {
- id: '1',
- visibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- },
- {
- id: '2',
- visibility: CalendarChannelVisibility.METADATA,
- },
- {
- id: '3',
- visibility: CalendarChannelVisibility.METADATA,
- },
- ]);
-
- mockConnectedAccountRepository.find
- .mockResolvedValueOnce([]) // request for calendar event 3
- .mockResolvedValueOnce([{ id: '1' }]); // request for calendar event 2
-
- const result = await service.applyCalendarEventsVisibilityRestrictions(
- calendarEvents,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual([
- calendarEvents[0],
- calendarEvents[1],
- {
- ...calendarEvents[2],
- title: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- description: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- ]);
- });
-
- it('should return all calendar events with the right visibility when userId is undefined (api key request)', async () => {
- const calendarEvents = [
- createMockCalendarEvent('1', 'Event 1', 'Description 1'),
- createMockCalendarEvent('2', 'Event 2', 'Description 2'),
- createMockCalendarEvent('3', 'Event 3', 'Description 3'),
- ];
-
- mockCalendarEventAssociationRepository.find.mockResolvedValue([
- {
- calendarEventId: '1',
- calendarChannelId: '1',
- },
- {
- calendarEventId: '2',
- calendarChannelId: '2',
- },
- {
- calendarEventId: '3',
- calendarChannelId: '3',
- },
- ]);
-
- mockCalendarChannelRepository.find.mockResolvedValue([
- {
- id: '1',
- visibility: CalendarChannelVisibility.SHARE_EVERYTHING,
- },
- {
- id: '2',
- visibility: CalendarChannelVisibility.METADATA,
- },
- {
- id: '3',
- visibility: CalendarChannelVisibility.METADATA,
- },
- ]);
-
- // userId is undefined (api key request), so connected account check is skipped
- // METADATA events should be obfuscated
-
- const result = await service.applyCalendarEventsVisibilityRestrictions(
- calendarEvents,
- 'test-workspace-id',
- undefined,
- );
-
- expect(result).toEqual([
- calendarEvents[0],
- {
- ...calendarEvents[1],
- title: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- description: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- {
- ...calendarEvents[2],
- title: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- description: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- ]);
- expect(mockConnectedAccountRepository.find).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/modules/connected-account/email-alias-manager/services/email-alias-manager.service.spec.ts b/packages/twenty-server/src/modules/connected-account/email-alias-manager/services/email-alias-manager.service.spec.ts
deleted file mode 100644
index 749d2e4a591..00000000000
--- a/packages/twenty-server/src/modules/connected-account/email-alias-manager/services/email-alias-manager.service.spec.ts
+++ /dev/null
@@ -1,143 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { MessageChannelEntity } from 'src/engine/metadata-modules/message-channel/entities/message-channel.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { GoogleEmailAliasManagerService } from 'src/modules/connected-account/email-alias-manager/drivers/google/services/google-email-alias-manager.service';
-import { microsoftGraphMeResponseWithProxyAddresses } from 'src/modules/connected-account/email-alias-manager/drivers/microsoft/mocks/microsoft-api-examples';
-import { MicrosoftEmailAliasManagerService } from 'src/modules/connected-account/email-alias-manager/drivers/microsoft/services/microsoft-email-alias-manager.service';
-import { MicrosoftOAuth2ClientProvider } from 'src/modules/connected-account/oauth2-client-manager/drivers/microsoft/microsoft-oauth2-client.provider';
-
-import { EmailAliasManagerService } from './email-alias-manager.service';
-
-describe('Email Alias Manager Service', () => {
- let emailAliasManagerService: EmailAliasManagerService;
- let microsoftEmailAliasManagerService: MicrosoftEmailAliasManagerService;
- const mockConnectedAccountRepository = {
- // @ts-expect-error legacy noImplicitAny
- update: jest.fn().mockResolvedValue((arg) => arg),
- };
- const mockMessageChannelRepository = {
- exists: jest.fn().mockResolvedValue(true),
- };
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- },
- },
- EmailAliasManagerService,
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: mockConnectedAccountRepository,
- },
- {
- provide: getRepositoryToken(MessageChannelEntity),
- useValue: mockMessageChannelRepository,
- },
- {
- provide: GoogleEmailAliasManagerService,
- useValue: {},
- },
- MicrosoftEmailAliasManagerService,
- {
- provide: MicrosoftOAuth2ClientProvider,
- useValue: {
- getClient: jest.fn().mockResolvedValue({
- api: jest.fn().mockReturnValue({
- get: jest
- .fn()
- .mockResolvedValue(
- microsoftGraphMeResponseWithProxyAddresses,
- ),
- }),
- }),
- },
- },
- ],
- }).compile();
-
- emailAliasManagerService = module.get<EmailAliasManagerService>(
- EmailAliasManagerService,
- );
- microsoftEmailAliasManagerService =
- module.get<MicrosoftEmailAliasManagerService>(
- MicrosoftEmailAliasManagerService,
- );
- });
-
- it('Service should be defined', () => {
- expect(emailAliasManagerService).toBeDefined();
- });
-
- describe('Refresh handle aliases for Microsoft', () => {
- it('Should refresh Microsoft handle aliases successfully', async () => {
- const mockConnectedAccount: Partial<ConnectedAccountEntity> = {
- id: 'test-id',
- provider: ConnectedAccountProvider.MICROSOFT,
- };
-
- const expectedAliases = [
- ];
-
- jest.spyOn(microsoftEmailAliasManagerService, 'getHandleAliases');
-
- await emailAliasManagerService.refreshHandleAliases(
- mockConnectedAccount as ConnectedAccountEntity,
- 'test-workspace-id',
- );
-
- expect(
- microsoftEmailAliasManagerService.getHandleAliases,
- ).toHaveBeenCalledWith(mockConnectedAccount);
-
- expect(mockConnectedAccountRepository.update).toHaveBeenCalledWith(
- { id: mockConnectedAccount.id, workspaceId: 'test-workspace-id' },
- {
- handleAliases: expectedAliases,
- },
- );
- });
- });
-
- describe('Refresh handle aliases without a mailbox', () => {
- it('Should preserve existing aliases and skip the update when the account has no message channel', async () => {
- mockMessageChannelRepository.exists.mockResolvedValueOnce(false);
-
- const existingAliases = ['[email protected]'];
- const mockConnectedAccount: Partial<ConnectedAccountEntity> = {
- id: 'test-id',
- provider: ConnectedAccountProvider.GOOGLE,
- handleAliases: existingAliases,
- };
-
- jest.spyOn(microsoftEmailAliasManagerService, 'getHandleAliases');
-
- const result = await emailAliasManagerService.refreshHandleAliases(
- mockConnectedAccount as ConnectedAccountEntity,
- 'test-workspace-id',
- );
-
- expect(result).toEqual(existingAliases);
- expect(
- microsoftEmailAliasManagerService.getHandleAliases,
- ).not.toHaveBeenCalled();
- expect(mockConnectedAccountRepository.update).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/services/connected-account-refresh-tokens.service.spec.ts b/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/services/connected-account-refresh-tokens.service.spec.ts
deleted file mode 100644
index 9dd9e92c2e7..00000000000
--- a/packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/services/connected-account-refresh-tokens.service.spec.ts
+++ /dev/null
@@ -1,532 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-import { isDefined } from 'twenty-shared/utils';
-
-import { AppOAuthRefreshAccessTokenService } from 'src/engine/core-modules/application/connection-provider/refresh/services/app-oauth-refresh-tokens.service';
-import { SECRET_ENCRYPTION_ENVELOPE_V2_PREFIX } from 'src/engine/core-modules/secret-encryption/constants/secret-encryption.constant';
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import {
- ConnectedAccountRefreshAccessTokenException,
- ConnectedAccountRefreshAccessTokenExceptionCode,
-} from 'src/engine/metadata-modules/connected-account/exceptions/connected-account-refresh-tokens.exception';
-import { ConnectedAccountTokenEncryptionService } from 'src/engine/metadata-modules/connected-account/services/connected-account-token-encryption.service';
-import { GoogleAPIRefreshAccessTokenService } from 'src/modules/connected-account/refresh-tokens-manager/drivers/google/services/google-api-refresh-tokens.service';
-import { MicrosoftAPIRefreshAccessTokenService } from 'src/modules/connected-account/refresh-tokens-manager/drivers/microsoft/services/microsoft-api-refresh-tokens.service';
-
-import { PlaintextString } from 'src/engine/core-modules/secret-encryption/branded-strings';
-import { ConnectedAccountRefreshTokensService } from './connected-account-refresh-tokens.service';
-
-const FAKE_CIPHER_PREFIX = `${SECRET_ENCRYPTION_ENVELOPE_V2_PREFIX}keyid:`;
-
-describe('ConnectedAccountRefreshTokensService', () => {
- let service: ConnectedAccountRefreshTokensService;
- let googleAPIRefreshAccessTokenService: GoogleAPIRefreshAccessTokenService;
- let microsoftAPIRefreshAccessTokenService: MicrosoftAPIRefreshAccessTokenService;
- let connectedAccountRepository: { update: jest.Mock };
- let connectedAccountTokenEncryptionService: {
- decrypt: jest.Mock;
- encryptTokenPair: jest.Mock;
- };
-
- const mockWorkspaceId = 'workspace-123';
- const mockConnectedAccountId = 'account-456';
-
- const mockAccessTokenPlaintext = 'valid-access-token' as PlaintextString;
- const mockRefreshTokenPlaintext = 'valid-refresh-token' as PlaintextString;
- const mockNewAccessTokenPlaintext = 'new-access-token' as PlaintextString;
-
- const mockEncryptedAccessToken = `${FAKE_CIPHER_PREFIX}CIPHER(${mockAccessTokenPlaintext})`;
- const mockEncryptedRefreshToken = `${FAKE_CIPHER_PREFIX}CIPHER(${mockRefreshTokenPlaintext})`;
-
- // Real prefix/round-trip invariants are asserted in
- // connected-account-token-encryption.service.spec.ts.
- const buildSymmetricEncryptionStub = (): {
- decrypt: jest.Mock;
- encryptTokenPair: jest.Mock;
- } => {
- const wrap = (value: string) => `${FAKE_CIPHER_PREFIX}CIPHER(${value})`;
-
- return {
- decrypt: jest.fn(
- ({ ciphertext }: { ciphertext: string; workspaceId: string }) => {
- const match = ciphertext.match(
- new RegExp(`^${FAKE_CIPHER_PREFIX}CIPHER\\((.*)\\)$`),
- );
-
- if (!isDefined(match)) {
- throw new Error(
- `fake encryption stub: decrypt called with a non-CIPHER value: ${ciphertext}`,
- );
- }
-
- return match[1];
- },
- ),
- encryptTokenPair: jest.fn(
- ({
- accessToken,
- refreshToken,
- }: {
- accessToken: string;
- refreshToken: string | null;
- workspaceId: string;
- }) => ({
- encryptedAccessToken: wrap(accessToken),
- encryptedRefreshToken: isDefined(refreshToken)
- ? wrap(refreshToken)
- : null,
- }),
- ),
- };
- };
-
- beforeEach(async () => {
- connectedAccountTokenEncryptionService = buildSymmetricEncryptionStub();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ConnectedAccountRefreshTokensService,
- {
- provide: GoogleAPIRefreshAccessTokenService,
- useValue: {
- refreshTokens: jest.fn(),
- },
- },
- {
- provide: MicrosoftAPIRefreshAccessTokenService,
- useValue: {
- refreshTokens: jest.fn(),
- },
- },
- {
- provide: AppOAuthRefreshAccessTokenService,
- useValue: {
- refreshTokens: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: {
- update: jest.fn(),
- },
- },
- {
- provide: ConnectedAccountTokenEncryptionService,
- useValue: connectedAccountTokenEncryptionService,
- },
- ],
- }).compile();
-
- service = module.get<ConnectedAccountRefreshTokensService>(
- ConnectedAccountRefreshTokensService,
- );
- googleAPIRefreshAccessTokenService =
- module.get<GoogleAPIRefreshAccessTokenService>(
- GoogleAPIRefreshAccessTokenService,
- );
- microsoftAPIRefreshAccessTokenService =
- module.get<MicrosoftAPIRefreshAccessTokenService>(
- MicrosoftAPIRefreshAccessTokenService,
- );
- connectedAccountRepository = module.get(
- getRepositoryToken(ConnectedAccountEntity),
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('resolveTokens', () => {
- it('should reuse the cached encrypted tokens as-is when valid, skipping decrypt and the refresh call entirely', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.MICROSOFT,
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- lastCredentialsRefreshedAt: new Date(Date.now() - 30 * 60 * 1000), // 30 minutes ago
- } as ConnectedAccountEntity;
-
- const result = await service.resolveTokens(
- connectedAccount,
- mockWorkspaceId,
- );
-
- expect(result).toEqual({
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- });
- expect(
- connectedAccountTokenEncryptionService.decrypt,
- ).not.toHaveBeenCalled();
- expect(
- microsoftAPIRefreshAccessTokenService.refreshTokens,
- ).not.toHaveBeenCalled();
- expect(connectedAccountRepository.update).not.toHaveBeenCalled();
- });
-
- it('should decrypt the stored refresh token before sending to Microsoft, persist the re-encrypted tokens, and return them encrypted', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.MICROSOFT,
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- lastCredentialsRefreshedAt: new Date(Date.now() - 2 * 60 * 60 * 1000), // 2 hours ago
- } as ConnectedAccountEntity;
-
- const newPlaintextTokens = {
- accessToken: mockNewAccessTokenPlaintext,
- refreshToken: mockRefreshTokenPlaintext,
- };
-
- jest
- .spyOn(microsoftAPIRefreshAccessTokenService, 'refreshTokens')
- .mockResolvedValue(newPlaintextTokens);
-
- const result = await service.resolveTokens(
- connectedAccount,
- mockWorkspaceId,
- );
-
- const expectedEncryptedNewAccessToken = `${FAKE_CIPHER_PREFIX}CIPHER(${mockNewAccessTokenPlaintext})`;
- const expectedEncryptedNewRefreshToken = `${FAKE_CIPHER_PREFIX}CIPHER(${mockRefreshTokenPlaintext})`;
-
- expect(result).toEqual({
- accessToken: expectedEncryptedNewAccessToken,
- refreshToken: expectedEncryptedNewRefreshToken,
- });
- expect(
- microsoftAPIRefreshAccessTokenService.refreshTokens,
- ).toHaveBeenCalledWith(mockRefreshTokenPlaintext);
- expect(connectedAccountRepository.update).toHaveBeenCalledWith(
- { id: mockConnectedAccountId, workspaceId: mockWorkspaceId },
- expect.objectContaining({
- accessToken: expectedEncryptedNewAccessToken,
- refreshToken: expectedEncryptedNewRefreshToken,
- lastCredentialsRefreshedAt: expect.any(Date),
- }),
- );
- });
-
- it('should decrypt the stored refresh token before sending to Google, persist the re-encrypted tokens, and return them encrypted', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.GOOGLE,
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- lastCredentialsRefreshedAt: new Date(Date.now() - 2 * 60 * 60 * 1000), // 2 hours ago
- } as ConnectedAccountEntity;
-
- const newPlaintextTokens = {
- accessToken: mockNewAccessTokenPlaintext,
- refreshToken: mockRefreshTokenPlaintext,
- };
-
- jest
- .spyOn(googleAPIRefreshAccessTokenService, 'refreshTokens')
- .mockResolvedValue(newPlaintextTokens);
-
- const result = await service.resolveTokens(
- connectedAccount,
- mockWorkspaceId,
- );
-
- const expectedEncryptedNewAccessToken = `${FAKE_CIPHER_PREFIX}CIPHER(${mockNewAccessTokenPlaintext})`;
- const expectedEncryptedNewRefreshToken = `${FAKE_CIPHER_PREFIX}CIPHER(${mockRefreshTokenPlaintext})`;
-
- expect(result).toEqual({
- accessToken: expectedEncryptedNewAccessToken,
- refreshToken: expectedEncryptedNewRefreshToken,
- });
- expect(
- googleAPIRefreshAccessTokenService.refreshTokens,
- ).toHaveBeenCalledWith(mockRefreshTokenPlaintext);
- expect(connectedAccountRepository.update).toHaveBeenCalledWith(
- { id: mockConnectedAccountId, workspaceId: mockWorkspaceId },
- expect.objectContaining({
- accessToken: expectedEncryptedNewAccessToken,
- refreshToken: expectedEncryptedNewRefreshToken,
- lastCredentialsRefreshedAt: expect.any(Date),
- }),
- );
- });
-
- it('should treat null lastCredentialsRefreshedAt as expired and run the full decrypt → refresh → re-encrypt cycle', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.MICROSOFT,
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- lastCredentialsRefreshedAt: null,
- } as ConnectedAccountEntity;
-
- const newPlaintextTokens = {
- accessToken: mockNewAccessTokenPlaintext,
-
- refreshToken: mockRefreshTokenPlaintext,
- };
-
- jest
- .spyOn(microsoftAPIRefreshAccessTokenService, 'refreshTokens')
- .mockResolvedValue(newPlaintextTokens);
-
- const result = await service.resolveTokens(
- connectedAccount,
- mockWorkspaceId,
- );
-
- const expectedEncryptedNewAccessToken = `${FAKE_CIPHER_PREFIX}CIPHER(${mockNewAccessTokenPlaintext})`;
- const expectedEncryptedNewRefreshToken = `${FAKE_CIPHER_PREFIX}CIPHER(${mockRefreshTokenPlaintext})`;
-
- expect(result).toEqual({
- accessToken: expectedEncryptedNewAccessToken,
- refreshToken: expectedEncryptedNewRefreshToken,
- });
- expect(
- microsoftAPIRefreshAccessTokenService.refreshTokens,
- ).toHaveBeenCalledWith(mockRefreshTokenPlaintext);
- expect(connectedAccountRepository.update).toHaveBeenCalledWith(
- { id: mockConnectedAccountId, workspaceId: mockWorkspaceId },
- expect.objectContaining({
- accessToken: expectedEncryptedNewAccessToken,
- refreshToken: expectedEncryptedNewRefreshToken,
- lastCredentialsRefreshedAt: expect.any(Date),
- }),
- );
- });
-
- it('should return the encrypted access token and null refresh token when access token is valid but no refresh token exists', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.APP,
- accessToken: mockEncryptedAccessToken,
- refreshToken: null,
- lastCredentialsRefreshedAt: new Date(Date.now() - 30 * 60 * 1000),
- } as unknown as ConnectedAccountEntity;
-
- const result = await service.resolveTokens(
- connectedAccount,
- mockWorkspaceId,
- );
-
- expect(result).toEqual({
- accessToken: mockEncryptedAccessToken,
- refreshToken: null,
- });
- expect(
- connectedAccountTokenEncryptionService.decrypt,
- ).not.toHaveBeenCalled();
- expect(connectedAccountRepository.update).not.toHaveBeenCalled();
- });
-
- it('should throw when refresh token is missing and access token is expired', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.GOOGLE,
- accessToken: mockEncryptedAccessToken,
- refreshToken: null,
- lastCredentialsRefreshedAt: new Date(Date.now() - 2 * 60 * 60 * 1000),
- } as unknown as ConnectedAccountEntity;
-
- await expect(
- service.resolveTokens(connectedAccount, mockWorkspaceId),
- ).rejects.toThrow(
- new ConnectedAccountRefreshAccessTokenException(
- `No refresh token found for connected account ${mockConnectedAccountId} in workspace ${mockWorkspaceId}`,
- ConnectedAccountRefreshAccessTokenExceptionCode.REFRESH_TOKEN_NOT_FOUND,
- ),
- );
- });
-
- it('should throw exception when Microsoft refresh fails with invalid_grant', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.MICROSOFT,
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- lastCredentialsRefreshedAt: new Date(Date.now() - 2 * 60 * 60 * 1000), // 2 hours ago
- } as ConnectedAccountEntity;
-
- const invalidGrantError = new ConnectedAccountRefreshAccessTokenException(
- 'Microsoft OAuth error: invalid_grant - Token has been revoked',
- ConnectedAccountRefreshAccessTokenExceptionCode.INVALID_REFRESH_TOKEN,
- );
-
- jest
- .spyOn(microsoftAPIRefreshAccessTokenService, 'refreshTokens')
- .mockRejectedValue(invalidGrantError);
-
- await expect(
- service.resolveTokens(connectedAccount, mockWorkspaceId),
- ).rejects.toMatchObject({
- message: expect.stringContaining(
- 'Microsoft OAuth error: invalid_grant - Token has been revoked',
- ),
- code: ConnectedAccountRefreshAccessTokenExceptionCode.INVALID_REFRESH_TOKEN,
- });
- });
-
- it('should throw TEMPORARY_NETWORK_ERROR when refresh fails with network error', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.GOOGLE,
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- lastCredentialsRefreshedAt: new Date(Date.now() - 2 * 60 * 60 * 1000), // 2 hours ago
- } as ConnectedAccountEntity;
-
- const networkError = new ConnectedAccountRefreshAccessTokenException(
- 'Google refresh token network error: ECONNRESET - Network error',
- ConnectedAccountRefreshAccessTokenExceptionCode.TEMPORARY_NETWORK_ERROR,
- );
-
- jest
- .spyOn(googleAPIRefreshAccessTokenService, 'refreshTokens')
- .mockRejectedValue(networkError);
-
- await expect(
- service.resolveTokens(connectedAccount, mockWorkspaceId),
- ).rejects.toMatchObject({
- code: ConnectedAccountRefreshAccessTokenExceptionCode.TEMPORARY_NETWORK_ERROR,
- });
- });
- });
-
- describe('isAccessTokenStillValid', () => {
- it('should return true when lastCredentialsRefreshedAt is within the valid window (30 minutes ago)', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.MICROSOFT,
- lastCredentialsRefreshedAt: new Date(Date.now() - 30 * 60 * 1000), // 30 minutes ago
- } as ConnectedAccountEntity;
-
- const result = await service.isAccessTokenStillValid(connectedAccount);
-
- expect(result).toBe(true);
- });
-
- it('should return false when lastCredentialsRefreshedAt is outside the valid window (2 hours ago)', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.GOOGLE,
- lastCredentialsRefreshedAt: new Date(Date.now() - 2 * 60 * 60 * 1000), // 2 hours ago
- } as ConnectedAccountEntity;
-
- const result = await service.isAccessTokenStillValid(connectedAccount);
-
- expect(result).toBe(false);
- });
-
- it('should return false when lastCredentialsRefreshedAt is null', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.MICROSOFT,
- lastCredentialsRefreshedAt: null,
- } as ConnectedAccountEntity;
-
- const result = await service.isAccessTokenStillValid(connectedAccount);
-
- expect(result).toBe(false);
- });
-
- it('should return true for IMAP_SMTP_CALDAV provider regardless of lastCredentialsRefreshedAt', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- lastCredentialsRefreshedAt: null,
- } as ConnectedAccountEntity;
-
- const result = await service.isAccessTokenStillValid(connectedAccount);
-
- expect(result).toBe(true);
- });
-
- it('should return true for OIDC provider regardless of lastCredentialsRefreshedAt', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.OIDC,
- lastCredentialsRefreshedAt: null,
- } as ConnectedAccountEntity;
-
- const result = await service.isAccessTokenStillValid(connectedAccount);
-
- expect(result).toBe(true);
- });
-
- it('should return true for SAML provider regardless of lastCredentialsRefreshedAt', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.SAML,
- lastCredentialsRefreshedAt: null,
- } as ConnectedAccountEntity;
-
- const result = await service.isAccessTokenStillValid(connectedAccount);
-
- expect(result).toBe(true);
- });
- });
-
- describe('resolveTokens - OIDC/SAML', () => {
- it('should return existing encrypted tokens for OIDC as-is without attempting a refresh', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.OIDC,
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- lastCredentialsRefreshedAt: null,
- } as unknown as ConnectedAccountEntity;
-
- const result = await service.resolveTokens(
- connectedAccount,
- mockWorkspaceId,
- );
-
- expect(result).toEqual({
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- });
- expect(
- connectedAccountTokenEncryptionService.decrypt,
- ).not.toHaveBeenCalled();
- expect(
- googleAPIRefreshAccessTokenService.refreshTokens,
- ).not.toHaveBeenCalled();
- expect(
- microsoftAPIRefreshAccessTokenService.refreshTokens,
- ).not.toHaveBeenCalled();
- expect(connectedAccountRepository.update).not.toHaveBeenCalled();
- });
-
- it('should return existing encrypted tokens for SAML as-is without attempting a refresh', async () => {
- const connectedAccount = {
- id: mockConnectedAccountId,
- provider: ConnectedAccountProvider.SAML,
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- lastCredentialsRefreshedAt: null,
- } as unknown as ConnectedAccountEntity;
-
- const result = await service.resolveTokens(
- connectedAccount,
- mockWorkspaceId,
- );
-
- expect(result).toEqual({
- accessToken: mockEncryptedAccessToken,
- refreshToken: mockEncryptedRefreshToken,
- });
- expect(
- connectedAccountTokenEncryptionService.decrypt,
- ).not.toHaveBeenCalled();
- expect(
- googleAPIRefreshAccessTokenService.refreshTokens,
- ).not.toHaveBeenCalled();
- expect(
- microsoftAPIRefreshAccessTokenService.refreshTokens,
- ).not.toHaveBeenCalled();
- expect(connectedAccountRepository.update).not.toHaveBeenCalled();
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/connected-account/services/imap-smtp-caldav-apis.service.spec.ts b/packages/twenty-server/src/modules/connected-account/services/imap-smtp-caldav-apis.service.spec.ts
deleted file mode 100644
index cb3cd114380..00000000000
--- a/packages/twenty-server/src/modules/connected-account/services/imap-smtp-caldav-apis.service.spec.ts
+++ /dev/null
@@ -1,838 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import {
- CalendarChannelSyncStage,
- ConnectedAccountProvider,
- MessageChannelSyncStage,
-} from 'twenty-shared/types';
-
-import { CreateCalendarChannelService } from 'src/engine/core-modules/auth/services/create-calendar-channel.service';
-import { CreateMessageChannelService } from 'src/engine/core-modules/auth/services/create-message-channel.service';
-import {
- type EncryptedImapSmtpCaldavParams,
- type PlaintextImapSmtpCaldavParams,
-} from 'src/engine/core-modules/imap-smtp-caldav-connection/types/imap-smtp-caldav-connection.type';
-import { type EncryptedString } from 'src/engine/core-modules/secret-encryption/branded-strings/encrypted-string.type';
-import { type PlaintextString } from 'src/engine/core-modules/secret-encryption/branded-strings/plaintext-string.type';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { CalendarChannelEntity } from 'src/engine/metadata-modules/calendar-channel/entities/calendar-channel.entity';
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { MessageChannelEntity } from 'src/engine/metadata-modules/message-channel/entities/message-channel.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { CalendarChannelSyncStatusService } from 'src/modules/calendar/common/services/calendar-channel-sync-status.service';
-import { CalendarEventListFetchJob } from 'src/modules/calendar/calendar-event-import-manager/jobs/calendar-event-list-fetch.job';
-import { ConnectedAccountTokenEncryptionService } from 'src/engine/metadata-modules/connected-account/services/connected-account-token-encryption.service';
-import { AccountsToReconnectService } from 'src/modules/connected-account/services/accounts-to-reconnect.service';
-import { ImapSmtpCalDavAPIService } from 'src/modules/connected-account/services/imap-smtp-caldav-apis.service';
-import { MessageChannelSyncStatusService } from 'src/modules/messaging/common/services/message-channel-sync-status.service';
-import { MessagingMessageListFetchJob } from 'src/modules/messaging/message-import-manager/jobs/messaging-message-list-fetch.job';
-import { SyncMessageFoldersService } from 'src/modules/messaging/message-folder-manager/services/sync-message-folders.service';
-
-jest.mock('uuid', () => ({
- ...jest.requireActual('uuid'),
- v4: jest.fn(() => 'mocked-uuid'),
-}));
-
-jest.mock(
- 'src/engine/twenty-orm/storage/orm-workspace-context.storage',
- () => ({
- getWorkspaceContext: jest.fn(() => ({
- authContext: { type: 'user', workspace: { id: 'workspace-id' } },
- userWorkspaceRoleMap: {},
- apiKeyRoleMap: {},
- })),
- }),
-);
-
-jest.mock(
- 'src/engine/twenty-orm/utils/resolve-role-permission-config.util',
- () => ({
- resolveRolePermissionConfig: jest.fn(() => ({
- intersectionOf: ['role-id'],
- })),
- }),
-);
-
-describe('ImapSmtpCalDavAPIService', () => {
- let service: ImapSmtpCalDavAPIService;
-
- const mockTransactionManagerSave = jest.fn();
- const mockTransactionManagerUpdate = jest.fn();
- const mockTransactionManager = {
- getRepository: jest.fn().mockReturnValue({
- save: mockTransactionManagerSave,
- update: mockTransactionManagerUpdate,
- }),
- };
-
- const mockConnectedAccountRepository = {
- findOne: jest.fn(),
- save: jest.fn(),
- manager: {
- transaction: jest.fn((callback) => callback(mockTransactionManager)),
- },
- };
-
- const mockMessageChannelRepository = {
- findOne: jest.fn(),
- };
-
- const mockCalendarChannelRepository = {
- findOne: jest.fn(),
- };
-
- const mockUserWorkspaceRepository = {
- findOne: jest
- .fn()
- .mockResolvedValue({ id: 'user-workspace-id', userId: 'user-id' }),
- };
-
- const mockWorkspaceMemberRepository = {
- findOne: jest.fn().mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- }),
- };
-
- const mockCreateMessageChannelService = {
- createMessageChannel: jest.fn().mockResolvedValue('mocked-uuid'),
- };
-
- const mockCreateCalendarChannelService = {
- createCalendarChannel: jest.fn().mockResolvedValue('mocked-uuid'),
- };
-
- const mockMessageQueueService = {
- add: jest.fn(),
- };
-
- const mockCalendarQueueService = {
- add: jest.fn(),
- };
-
- const mockAccountsToReconnectService = {
- removeAccountToReconnect: jest.fn(),
- };
-
- const mockMessagingChannelSyncStatusService = {
- resetAndMarkAsMessagesListFetchPending: jest.fn(),
- };
-
- const mockCalendarChannelSyncStatusService = {
- resetAndMarkAsCalendarEventListFetchPending: jest.fn(),
- };
-
- const encryptPassword = (password: string): EncryptedString =>
- `enc:v2:${password}` as EncryptedString;
-
- const withEncryptedPasswords = (
- params: PlaintextImapSmtpCaldavParams,
- ): EncryptedImapSmtpCaldavParams => {
- const result: EncryptedImapSmtpCaldavParams = {};
-
- for (const protocol of ['IMAP', 'SMTP', 'CALDAV'] as const) {
- if (params[protocol]) {
- result[protocol] = {
- ...params[protocol],
- password: encryptPassword(params[protocol]!.password),
- };
- }
- }
-
- return result;
- };
-
- const mockConnectedAccountTokenEncryptionService = {
- encryptConnectionParameters: jest.fn(
- ({
- connectionParameters,
- }: {
- connectionParameters: PlaintextImapSmtpCaldavParams;
- workspaceId: string;
- }) => withEncryptedPasswords(connectionParameters),
- ),
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ImapSmtpCalDavAPIService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getRepository: jest
- .fn()
- .mockImplementation((_workspaceId, entity) => {
- if (entity === 'workspaceMember')
- return mockWorkspaceMemberRepository;
-
- return {};
- }),
- executeInWorkspaceContext: jest
- .fn()
-
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- },
- },
- {
- provide: CreateMessageChannelService,
- useValue: mockCreateMessageChannelService,
- },
- {
- provide: CreateCalendarChannelService,
- useValue: mockCreateCalendarChannelService,
- },
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: mockConnectedAccountRepository,
- },
- {
- provide: getRepositoryToken(MessageChannelEntity),
- useValue: mockMessageChannelRepository,
- },
- {
- provide: getRepositoryToken(CalendarChannelEntity),
- useValue: mockCalendarChannelRepository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: mockUserWorkspaceRepository,
- },
- {
- provide: SyncMessageFoldersService,
- useValue: {
- syncMessageFolders: jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: getQueueToken(MessageQueue.messagingQueue),
- useValue: mockMessageQueueService,
- },
- {
- provide: getQueueToken(MessageQueue.calendarQueue),
- useValue: mockCalendarQueueService,
- },
- {
- provide: AccountsToReconnectService,
- useValue: mockAccountsToReconnectService,
- },
- {
- provide: MessageChannelSyncStatusService,
- useValue: mockMessagingChannelSyncStatusService,
- },
- {
- provide: CalendarChannelSyncStatusService,
- useValue: mockCalendarChannelSyncStatusService,
- },
- {
- provide: ConnectedAccountTokenEncryptionService,
- useValue: mockConnectedAccountTokenEncryptionService,
- },
- ],
- }).compile();
-
- service = module.get<ImapSmtpCalDavAPIService>(ImapSmtpCalDavAPIService);
-
- jest.clearAllMocks();
- });
-
- describe('upsertConnectedAccount', () => {
- const baseInput = {
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- workspaceId: 'workspace-id',
- connectionParameters: {
- IMAP: {
- host: 'imap.example.com',
- port: 993,
- connectionSecurity: 'SSL_TLS',
- password: 'password' as PlaintextString,
- },
- SMTP: {
- host: 'smtp.example.com',
- port: 587,
- connectionSecurity: 'SSL_TLS',
- username: '[email protected]',
- password: 'password' as PlaintextString,
- },
- } as PlaintextImapSmtpCaldavParams,
- };
-
- it('should create new account with message channel when account does not exist and IMAP is configured', async () => {
- mockConnectedAccountRepository.findOne.mockResolvedValue(null);
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(baseInput);
-
- expect(mockTransactionManagerSave).toHaveBeenCalledWith({
- id: 'mocked-uuid',
- handle: '[email protected]',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- connectionParameters: withEncryptedPasswords(
- baseInput.connectionParameters,
- ),
- userWorkspaceId: 'user-workspace-id',
- workspaceId: 'workspace-id',
- authFailedAt: null,
- archivedAt: null,
- });
-
- expect(
- mockCreateMessageChannelService.createMessageChannel,
- ).toHaveBeenCalledWith({
- workspaceId: 'workspace-id',
- connectedAccountId: 'mocked-uuid',
- handle: '[email protected]',
- transactionManager: mockTransactionManager,
- });
-
- expect(
- mockCreateCalendarChannelService.createCalendarChannel,
- ).not.toHaveBeenCalled();
- });
-
- it('should preserve existing channels when updating account credentials', async () => {
- const existingAccount = {
- id: 'existing-account-id',
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- } as ConnectedAccountEntity;
-
- const existingMessageChannel = {
- id: 'existing-message-channel-id',
- connectedAccountId: 'existing-account-id',
- syncStage: MessageChannelSyncStage.MESSAGE_LIST_FETCH_PENDING,
- } as MessageChannelEntity;
-
- const existingCalendarChannel = {
- id: 'existing-calendar-channel-id',
- connectedAccountId: 'existing-account-id',
- syncStage: CalendarChannelSyncStage.CALENDAR_EVENT_LIST_FETCH_PENDING,
- } as CalendarChannelEntity;
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(existingAccount);
- mockMessageChannelRepository.findOne.mockResolvedValue(
- existingMessageChannel,
- );
- mockCalendarChannelRepository.findOne.mockResolvedValue(
- existingCalendarChannel,
- );
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- const inputWithConnectedAccountId = {
- ...baseInput,
- connectionParameters: {
- ...baseInput.connectionParameters,
- CALDAV: {
- host: 'caldav.example.com',
- port: 443,
- connectionSecurity: 'SSL_TLS',
- username: '[email protected]',
- password: 'password' as PlaintextString,
- },
- } as PlaintextImapSmtpCaldavParams,
- connectedAccountId: 'existing-account-id',
- };
-
- await service.upsertConnectedAccount(inputWithConnectedAccountId);
-
- expect(mockTransactionManagerSave).toHaveBeenCalledWith({
- id: 'existing-account-id',
- handle: '[email protected]',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- connectionParameters: withEncryptedPasswords(
- inputWithConnectedAccountId.connectionParameters,
- ),
- userWorkspaceId: 'user-workspace-id',
- workspaceId: 'workspace-id',
- authFailedAt: null,
- archivedAt: null,
- });
-
- expect(
- mockCreateMessageChannelService.createMessageChannel,
- ).not.toHaveBeenCalled();
- expect(
- mockCreateCalendarChannelService.createCalendarChannel,
- ).not.toHaveBeenCalled();
-
- expect(
- mockAccountsToReconnectService.removeAccountToReconnect,
- ).toHaveBeenCalledWith('user-id', 'workspace-id', 'existing-account-id');
-
- expect(
- mockMessagingChannelSyncStatusService.resetAndMarkAsMessagesListFetchPending,
- ).toHaveBeenCalledWith(['existing-message-channel-id'], 'workspace-id');
- expect(mockMessageQueueService.add).toHaveBeenCalledWith(
- MessagingMessageListFetchJob.name,
- {
- workspaceId: 'workspace-id',
- messageChannelId: 'existing-message-channel-id',
- },
- );
-
- expect(
- mockCalendarChannelSyncStatusService.resetAndMarkAsCalendarEventListFetchPending,
- ).toHaveBeenCalledWith(['existing-calendar-channel-id'], 'workspace-id');
- expect(mockCalendarQueueService.add).toHaveBeenCalledWith(
- CalendarEventListFetchJob.name,
- {
- workspaceId: 'workspace-id',
- calendarChannelId: 'existing-calendar-channel-id',
- },
- );
- });
-
- it('should re-enable sync on existing channels when reconnecting an archived account', async () => {
- const archivedAccount = {
- id: 'archived-account-id',
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- archivedAt: new Date('2026-01-01'),
- } as ConnectedAccountEntity;
-
- const existingMessageChannel = {
- id: 'existing-message-channel-id',
- connectedAccountId: 'archived-account-id',
- syncStage: MessageChannelSyncStage.MESSAGE_LIST_FETCH_PENDING,
- } as MessageChannelEntity;
-
- const existingCalendarChannel = {
- id: 'existing-calendar-channel-id',
- connectedAccountId: 'archived-account-id',
- syncStage: CalendarChannelSyncStage.CALENDAR_EVENT_LIST_FETCH_PENDING,
- } as CalendarChannelEntity;
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(archivedAccount);
- mockMessageChannelRepository.findOne.mockResolvedValue(
- existingMessageChannel,
- );
- mockCalendarChannelRepository.findOne.mockResolvedValue(
- existingCalendarChannel,
- );
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- const inputWithCalDav = {
- ...baseInput,
- connectionParameters: {
- ...baseInput.connectionParameters,
- CALDAV: {
- host: 'caldav.example.com',
- port: 443,
- connectionSecurity: 'SSL_TLS',
- username: '[email protected]',
- password: 'password' as PlaintextString,
- },
- } as PlaintextImapSmtpCaldavParams,
- };
-
- await service.upsertConnectedAccount(inputWithCalDav);
-
- expect(mockTransactionManagerSave).toHaveBeenCalledWith(
- expect.objectContaining({ archivedAt: null }),
- );
-
- expect(mockTransactionManagerUpdate).toHaveBeenCalledWith(
- { id: 'existing-message-channel-id', workspaceId: 'workspace-id' },
- { isSyncEnabled: true },
- );
- expect(mockTransactionManagerUpdate).toHaveBeenCalledWith(
- { id: 'existing-calendar-channel-id', workspaceId: 'workspace-id' },
- { isSyncEnabled: true },
- );
- });
-
- it('should leave channels in PENDING_CONFIGURATION untouched', async () => {
- const existingAccount = {
- id: 'existing-account-id',
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- } as ConnectedAccountEntity;
-
- const existingMessageChannel = {
- id: 'existing-message-channel-id',
- connectedAccountId: 'existing-account-id',
- syncStage: MessageChannelSyncStage.PENDING_CONFIGURATION,
- } as MessageChannelEntity;
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(existingAccount);
- mockMessageChannelRepository.findOne.mockResolvedValue(
- existingMessageChannel,
- );
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount({
- ...baseInput,
- existingAccount,
- });
-
- expect(
- mockMessagingChannelSyncStatusService.resetAndMarkAsMessagesListFetchPending,
- ).not.toHaveBeenCalled();
- expect(mockMessageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('should not run reconnect logic when creating a brand new account', async () => {
- mockConnectedAccountRepository.findOne.mockResolvedValue(null);
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(baseInput);
-
- expect(
- mockAccountsToReconnectService.removeAccountToReconnect,
- ).not.toHaveBeenCalled();
- expect(
- mockMessagingChannelSyncStatusService.resetAndMarkAsMessagesListFetchPending,
- ).not.toHaveBeenCalled();
- expect(
- mockCalendarChannelSyncStatusService.resetAndMarkAsCalendarEventListFetchPending,
- ).not.toHaveBeenCalled();
- expect(mockMessageQueueService.add).not.toHaveBeenCalled();
- expect(mockCalendarQueueService.add).not.toHaveBeenCalled();
- });
-
- it('should only create message channel when only IMAP is configured', async () => {
- const imapOnlyInput = {
- ...baseInput,
- connectionParameters: {
- IMAP: {
- host: 'imap.example.com',
- port: 993,
- connectionSecurity: 'SSL_TLS',
- password: 'password' as PlaintextString,
- },
- } as PlaintextImapSmtpCaldavParams,
- };
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(null);
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(imapOnlyInput);
-
- expect(
- mockCreateMessageChannelService.createMessageChannel,
- ).toHaveBeenCalled();
- expect(
- mockCreateCalendarChannelService.createCalendarChannel,
- ).not.toHaveBeenCalled();
- });
-
- it('should only create calendar channel when only CALDAV is configured', async () => {
- const caldavOnlyInput = {
- ...baseInput,
- connectionParameters: {
- CALDAV: {
- host: 'caldav.example.com',
- port: 443,
- connectionSecurity: 'SSL_TLS',
- username: '[email protected]',
- password: 'password' as PlaintextString,
- },
- } as PlaintextImapSmtpCaldavParams,
- };
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(null);
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(caldavOnlyInput);
-
- expect(
- mockCreateMessageChannelService.createMessageChannel,
- ).not.toHaveBeenCalled();
- expect(
- mockCreateCalendarChannelService.createCalendarChannel,
- ).toHaveBeenCalled();
- });
-
- it('should handle IMAP + SMTP configuration without CALDAV', async () => {
- const imapSmtpInput = {
- ...baseInput,
- connectionParameters: {
- IMAP: {
- host: 'imap.example.com',
- port: 993,
- connectionSecurity: 'SSL_TLS',
- password: 'password' as PlaintextString,
- },
- SMTP: {
- host: 'smtp.example.com',
- port: 587,
- connectionSecurity: 'SSL_TLS',
- username: '[email protected]',
- password: 'password' as PlaintextString,
- },
- } as PlaintextImapSmtpCaldavParams,
- };
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(null);
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(imapSmtpInput);
-
- expect(
- mockCreateMessageChannelService.createMessageChannel,
- ).toHaveBeenCalled();
- expect(
- mockCreateCalendarChannelService.createCalendarChannel,
- ).not.toHaveBeenCalled();
- });
-
- it('should handle full IMAP + SMTP + CALDAV configuration', async () => {
- const fullConfigInput = {
- ...baseInput,
- connectionParameters: {
- IMAP: {
- host: 'imap.example.com',
- port: 993,
- connectionSecurity: 'SSL_TLS',
- password: 'password' as PlaintextString,
- },
- SMTP: {
- host: 'smtp.example.com',
- port: 587,
- connectionSecurity: 'SSL_TLS',
- username: '[email protected]',
- password: 'password' as PlaintextString,
- },
- CALDAV: {
- host: 'caldav.example.com',
- port: 443,
- connectionSecurity: 'SSL_TLS',
- username: '[email protected]',
- password: 'password' as PlaintextString,
- },
- } as PlaintextImapSmtpCaldavParams,
- };
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(null);
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(fullConfigInput);
-
- expect(
- mockCreateMessageChannelService.createMessageChannel,
- ).toHaveBeenCalled();
- expect(
- mockCreateCalendarChannelService.createCalendarChannel,
- ).toHaveBeenCalled();
- });
-
- it('should handle account found by handle when connectedAccountId is not provided', async () => {
- const existingAccount = {
- id: 'existing-account-id',
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- } as ConnectedAccountEntity;
-
- mockConnectedAccountRepository.findOne.mockResolvedValueOnce(
- existingAccount,
- );
-
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(baseInput);
-
- expect(mockConnectedAccountRepository.findOne).toHaveBeenCalledWith({
- where: {
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- workspaceId: 'workspace-id',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- },
- });
-
- expect(mockTransactionManagerSave).toHaveBeenCalledWith({
- id: 'existing-account-id',
- handle: '[email protected]',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- connectionParameters: withEncryptedPasswords(
- baseInput.connectionParameters,
- ),
- userWorkspaceId: 'user-workspace-id',
- workspaceId: 'workspace-id',
- authFailedAt: null,
- archivedAt: null,
- });
- });
-
- it('should create a new row instead of overriding an account with the same handle under a different provider', async () => {
- mockConnectedAccountRepository.findOne.mockResolvedValue(null);
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(baseInput);
-
- expect(mockConnectedAccountRepository.findOne).toHaveBeenCalledWith({
- where: {
- handle: '[email protected]',
- userWorkspaceId: 'user-workspace-id',
- workspaceId: 'workspace-id',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- },
- });
-
- expect(mockTransactionManagerSave).toHaveBeenCalledWith(
- expect.objectContaining({
- id: 'mocked-uuid',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- }),
- );
- });
-
- it('should not create channels when neither IMAP nor CALDAV is configured', async () => {
- const smtpOnlyInput = {
- ...baseInput,
- connectionParameters: {
- SMTP: {
- host: 'smtp.example.com',
- port: 587,
- connectionSecurity: 'SSL_TLS',
- username: '[email protected]',
- password: 'password' as PlaintextString,
- },
- } as PlaintextImapSmtpCaldavParams,
- };
-
- mockConnectedAccountRepository.findOne.mockResolvedValue(null);
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(smtpOnlyInput);
-
- expect(
- mockCreateMessageChannelService.createMessageChannel,
- ).not.toHaveBeenCalled();
- expect(
- mockCreateCalendarChannelService.createCalendarChannel,
- ).not.toHaveBeenCalled();
- });
-
- it('should handle transaction correctly', async () => {
- mockConnectedAccountRepository.findOne.mockResolvedValue(null);
- mockMessageChannelRepository.findOne.mockResolvedValue(null);
- mockCalendarChannelRepository.findOne.mockResolvedValue(null);
- mockWorkspaceMemberRepository.findOne.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- await service.upsertConnectedAccount(baseInput);
-
- expect(
- mockConnectedAccountRepository.manager.transaction,
- ).toHaveBeenCalledWith(expect.any(Function));
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/contact-creation-manager/services/__tests__/create-company-and-contact.service.spec.ts b/packages/twenty-server/src/modules/contact-creation-manager/services/__tests__/create-company-and-contact.service.spec.ts
deleted file mode 100644
index 1ab28b84244..00000000000
--- a/packages/twenty-server/src/modules/contact-creation-manager/services/__tests__/create-company-and-contact.service.spec.ts
+++ /dev/null
@@ -1,406 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { FieldActorSource } from 'twenty-shared/types';
-
-import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { CreateCompanyAndPersonService } from 'src/modules/contact-creation-manager/services/create-company-and-contact.service';
-import { CreateCompanyService } from 'src/modules/contact-creation-manager/services/create-company.service';
-import { CreatePersonService } from 'src/modules/contact-creation-manager/services/create-person.service';
-import { type Contact } from 'src/modules/contact-creation-manager/types/contact.type';
-import { type PersonWorkspaceEntity } from 'src/modules/person/standard-objects/person.workspace-entity';
-
-describe('CreateCompanyAndPersonService', () => {
- let service: CreateCompanyAndPersonService;
-
- const mockConnectedAccount = {
- id: 'connected-account-1',
- accountOwner: {
- id: 'workspace-member-1',
- },
- } as unknown as ConnectedAccountEntity;
-
- beforeEach(async () => {
- const mockCreateCompaniesService = {
- createOrRestoreCompanies: jest.fn(),
- };
- const mockCreatePersonService = {
- restorePeople: jest.fn(),
- enrichPeopleNames: jest.fn(),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- CreateCompanyAndPersonService,
- {
- provide: CreateCompanyService,
- useValue: mockCreateCompaniesService,
- },
- {
- provide: CreatePersonService,
- useValue: mockCreatePersonService,
- },
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {},
- },
- {
- provide: ExceptionHandlerService,
- useValue: {},
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {
- findOne: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<CreateCompanyAndPersonService>(
- CreateCompanyAndPersonService,
- );
- });
-
- describe('computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate', () => {
- const mockContacts: Contact[] = [
- {
- handle: '[email protected]',
- displayName: 'John Doe',
- },
- {
- handle: '[email protected]',
- displayName: 'Jane Smith',
- },
- {
- handle: '[email protected]',
- displayName: 'Personal Contact',
- },
- ];
-
- const mockExistingPeople: PersonWorkspaceEntity[] = [
- {
- id: 'soft-deleted-person-1',
- emails: {
- primaryEmail: '[email protected]',
- additionalEmails: null,
- },
- deletedAt: new Date(),
- } as unknown as PersonWorkspaceEntity,
- {
- id: 'soft-deleted-person-2',
- emails: {
- primaryEmail: '[email protected]',
- additionalEmails: ['[email protected]'],
- },
- deletedAt: new Date(),
- } as unknown as PersonWorkspaceEntity,
- {
- id: 'active-person-3',
- emails: {
- primaryEmail: '[email protected]',
- additionalEmails: null,
- },
- deletedAt: null,
- } as unknown as PersonWorkspaceEntity,
- ];
-
- it('should identify contacts that need person creation for new contacts', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- mockContacts,
- mockExistingPeople,
- FieldActorSource.CALENDAR,
- mockConnectedAccount,
- null,
- );
-
- expect(result.contactsThatNeedPersonCreate).toHaveLength(1);
- expect(result.contactsThatNeedPersonCreate[0].handle).toBe(
- );
- });
-
- it('should identify contacts that need person restoration for soft-deleted contacts', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- mockContacts,
- mockExistingPeople,
- FieldActorSource.CALENDAR,
- mockConnectedAccount,
- null,
- );
-
- expect(result.contactsThatNeedPersonRestore).toHaveLength(2);
- expect(
- result.contactsThatNeedPersonRestore.map((c) => c.handle),
- ).toContain('[email protected]');
- expect(
- result.contactsThatNeedPersonRestore.map((c) => c.handle),
- ).toContain('[email protected]');
- });
-
- describe('peopleToEnrichNames', () => {
- const contact: Contact = {
- handle: '[email protected]',
- displayName: 'Félix Malfait',
- };
-
- const buildExistingPerson = (
- overrides: Record<string, unknown>,
- ): PersonWorkspaceEntity =>
- ({
- id: 'existing-person-1',
- emails: {
- primaryEmail: '[email protected]',
- additionalEmails: null,
- },
- name: { firstName: 'Félix', lastName: '' },
- createdBy: { source: FieldActorSource.EMAIL },
- deletedAt: null,
- ...overrides,
- }) as unknown as PersonWorkspaceEntity;
-
- it('should enrich an empty lastName on an EMAIL-created contact', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [contact],
- [buildExistingPerson({})],
- FieldActorSource.CALENDAR,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([
- {
- personId: 'existing-person-1',
- name: { firstName: 'Félix', lastName: 'Malfait' },
- },
- ]);
- });
-
- it('should enrich a contact created from CALENDAR too', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [contact],
- [
- buildExistingPerson({
- createdBy: {
- source: FieldActorSource.CALENDAR,
- } as PersonWorkspaceEntity['createdBy'],
- }),
- ],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toHaveLength(1);
- });
-
- it('should not overwrite an existing non-empty lastName', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [{ handle: '[email protected]', displayName: 'Felix Smith' }],
- [
- buildExistingPerson({
- name: { firstName: 'Félix', lastName: 'Malfait' },
- }),
- ],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([]);
- });
-
- it('should not touch a manually-created contact', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [contact],
- [
- buildExistingPerson({
- createdBy: {
- source: FieldActorSource.MANUAL,
- } as PersonWorkspaceEntity['createdBy'],
- }),
- ],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([]);
- });
-
- it('should not touch an IMPORT-created contact', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [contact],
- [
- buildExistingPerson({
- createdBy: {
- source: FieldActorSource.IMPORT,
- } as PersonWorkspaceEntity['createdBy'],
- }),
- ],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([]);
- });
-
- it('should skip enrichment when the new displayName provides no last name either', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [{ handle: '[email protected]', displayName: 'Félix' }],
- [buildExistingPerson({})],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([]);
- });
-
- it('should enrich a soft-deleted contact that will be restored in this same batch', () => {
- // Restore runs before enrich in createCompaniesAndPeople — by the time
- // the enrichment UPDATE fires, the row is no longer soft-deleted.
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [contact],
- [buildExistingPerson({ deletedAt: new Date() })],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([
- {
- personId: 'existing-person-1',
- name: { firstName: 'Félix', lastName: 'Malfait' },
- },
- ]);
- });
-
- it('should fill firstName when missing and preserve existing lastName', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [contact],
- [
- buildExistingPerson({
- name: { firstName: '', lastName: 'Malfait' },
- }),
- ],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([
- {
- personId: 'existing-person-1',
- name: { firstName: 'Félix', lastName: 'Malfait' },
- },
- ]);
- });
-
- it('should handle a person with a null name field', () => {
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [contact],
- [buildExistingPerson({ name: null })],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([
- {
- personId: 'existing-person-1',
- name: { firstName: 'Félix', lastName: 'Malfait' },
- },
- ]);
- });
-
- it('should not emit two enrichments when one Person matches both primary and additional emails in the batch', () => {
- const existingPersonWithMultipleEmails = buildExistingPerson({
- emails: {
- primaryEmail: '[email protected]',
- additionalEmails: ['[email protected]'],
- },
- });
-
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [
- { handle: '[email protected]', displayName: 'Félix Malfait' },
- {
- handle: '[email protected]',
- displayName: 'Félix Other',
- },
- ],
- [existingPersonWithMultipleEmails],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([
- {
- personId: 'existing-person-1',
- name: { firstName: 'Félix', lastName: 'Malfait' },
- },
- ]);
- });
-
- it('should merge partial enrichments across contacts mapping to the same Person', () => {
- const existingPersonWithMultipleEmails = buildExistingPerson({
- name: { firstName: '', lastName: '' },
- emails: {
- primaryEmail: '[email protected]',
- additionalEmails: ['[email protected]'],
- },
- });
-
- const result =
- service.computeContactsThatNeedPersonCreateAndRestoreAndWorkDomainNamesToCreate(
- [
- // First contact only carries a first name.
- { handle: '[email protected]', displayName: 'Félix' },
- // Second contact (additional email) carries both — the lastName
- // should fill in even though the firstName slot is already taken.
- {
- handle: '[email protected]',
- displayName: 'Félix Malfait',
- },
- ],
- [existingPersonWithMultipleEmails],
- FieldActorSource.EMAIL,
- mockConnectedAccount,
- null,
- );
-
- expect(result.peopleToEnrichNames).toEqual([
- {
- personId: 'existing-person-1',
- name: { firstName: 'Félix', lastName: 'Malfait' },
- },
- ]);
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/contact-creation-manager/services/__tests__/create-company.service.spec.ts b/packages/twenty-server/src/modules/contact-creation-manager/services/__tests__/create-company.service.spec.ts
deleted file mode 100644
index 2c434421084..00000000000
--- a/packages/twenty-server/src/modules/contact-creation-manager/services/__tests__/create-company.service.spec.ts
+++ /dev/null
@@ -1,292 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import {
- ConnectedAccountProvider,
- FieldActorSource,
-} from 'twenty-shared/types';
-import { STANDARD_OBJECTS } from 'twenty-shared/metadata';
-
-import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
-import { SecureHttpClientService } from 'src/engine/core-modules/secure-http-client/secure-http-client.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import {
- type CompanyToCreate,
- CreateCompanyService,
-} from 'src/modules/contact-creation-manager/services/create-company.service';
-
-describe('CreateCompanyService', () => {
- let service: CreateCompanyService;
- let mockCompanyRepository: any;
- let mockHttpService: any;
-
- const workspaceId = 'workspace-1';
-
- const companyToCreate1: CompanyToCreate = {
- domainName: 'example1.com',
- createdBySource: FieldActorSource.MANUAL,
- createdByContext: {
- provider: ConnectedAccountProvider.GOOGLE,
- },
- };
- const companyToCreate1withSlash: CompanyToCreate = {
- domainName: 'example1.com/',
- createdBySource: FieldActorSource.MANUAL,
- createdByContext: {
- provider: ConnectedAccountProvider.GOOGLE,
- },
- };
- const companyToCreate2: CompanyToCreate = {
- domainName: 'example2.com',
- createdBySource: FieldActorSource.MANUAL,
- createdByContext: {
- provider: ConnectedAccountProvider.GOOGLE,
- },
- };
- const companyToCreateExisting: CompanyToCreate = {
- domainName: 'existing-company.com',
- createdBySource: FieldActorSource.MANUAL,
- createdByContext: {
- provider: ConnectedAccountProvider.GOOGLE,
- },
- };
- const companyToRestore: CompanyToCreate = {
- domainName: 'soft-deleted-company.com',
- createdBySource: FieldActorSource.MANUAL,
- createdByContext: {
- provider: ConnectedAccountProvider.GOOGLE,
- },
- };
- const inputForCompanyToCreate1 = {
- address: {
- addressCity: undefined,
- },
- createdBy: {
- context: {
- provider: 'google',
- },
- name: '',
- source: 'MANUAL',
- workspaceMemberId: undefined,
- },
- domainName: {
- primaryLinkUrl: 'https://example1.com',
- },
- name: 'Example1',
- position: 1,
- };
-
- const inputForCompanyToCreate2 = {
- address: {
- addressCity: '',
- },
- createdBy: {
- context: {
- provider: 'google',
- },
- name: '',
- source: 'MANUAL',
- workspaceMemberId: undefined,
- },
- domainName: {
- primaryLinkUrl: 'https://example2.com',
- },
- name: 'BNQ',
- position: 2,
- };
-
- beforeEach(async () => {
- mockCompanyRepository = {
- find: jest.fn(),
- save: jest.fn(),
- maximum: jest.fn().mockResolvedValue(0),
- updateMany: jest.fn(),
- };
-
- mockHttpService = {
- get: jest.fn(),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- CreateCompanyService,
- {
- provide: SecureHttpClientService,
- useValue: {
- getHttpClient: jest.fn().mockReturnValue(mockHttpService),
- },
- },
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getRepository: jest.fn().mockResolvedValue(mockCompanyRepository),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- },
- },
- {
- provide: getRepositoryToken(ObjectMetadataEntity),
- useValue: {
- findOne: jest.fn().mockResolvedValue({
- id: 'mock-object-metadata-id',
- universalIdentifier: STANDARD_OBJECTS.company.universalIdentifier,
- workspaceId,
- nameSingular: 'company',
- namePlural: 'companies',
- labelSingular: 'Company',
- labelPlural: 'Companies',
- targetTableName: 'company',
- isRemote: false,
- isActive: true,
- isSystem: false,
- isAuditLogged: true,
- isSearchable: true,
- isLabelSyncedWithName: false,
- }),
- },
- },
- ],
- }).compile();
-
- service = module.get<CreateCompanyService>(CreateCompanyService);
- });
-
- describe('With no existing companies', () => {
- beforeEach(() => {
- mockCompanyRepository.find.mockResolvedValue([]);
- // it is useless to check results here, we can only check the input it was called with
- mockCompanyRepository.save.mockResolvedValue([]);
-
- mockCompanyRepository.updateMany.mockResolvedValue({
- raw: [],
- });
- });
-
- it('should successfully create a company', async () => {
- mockHttpService.get.mockResolvedValue({
- data: {
- name: 'Example1',
- city: undefined,
- },
- });
-
- await service.createOrRestoreCompanies([companyToCreate1], workspaceId);
-
- expect(mockCompanyRepository.find).toHaveBeenCalled();
- expect(mockCompanyRepository.save).toHaveBeenCalledWith([
- inputForCompanyToCreate1,
- ]);
- });
-
- it('should successfully two companies', async () => {
- mockHttpService.get
- .mockResolvedValueOnce({
- data: {
- name: 'Example1',
- city: undefined,
- },
- })
- .mockResolvedValueOnce({
- data: {
- name: 'BNQ',
- city: '',
- },
- });
-
- await service.createOrRestoreCompanies(
- [companyToCreate1, companyToCreate2],
- workspaceId,
- );
-
- expect(mockCompanyRepository.find).toHaveBeenCalled();
- expect(mockCompanyRepository.save).toHaveBeenCalledWith([
- inputForCompanyToCreate1,
- inputForCompanyToCreate2,
- ]);
- });
-
- it('should create only one of example.com & example.com/ ', async () => {
- await service.createOrRestoreCompanies(
- [companyToCreate1, companyToCreate1withSlash],
- workspaceId,
- );
-
- expect(mockCompanyRepository.find).toHaveBeenCalled();
- expect(mockCompanyRepository.save).toHaveBeenCalledWith(
- expect.arrayContaining([
- expect.objectContaining({
- domainName: {
- primaryLinkUrl: 'https://example1.com',
- },
- }),
- ]),
- );
- });
- });
-
- describe('With existing companies', () => {
- beforeEach(() => {
- mockCompanyRepository.find.mockResolvedValue([
- {
- id: 'existing-company-1',
- domainName: { primaryLinkUrl: 'https://existing-company.com' },
- },
- ]);
- mockCompanyRepository.save.mockResolvedValue([]);
- mockCompanyRepository.updateMany.mockResolvedValue({
- raw: [],
- });
- });
-
- it('should not create a company if it already exists', async () => {
- await service.createOrRestoreCompanies(
- [companyToCreateExisting],
- workspaceId,
- );
-
- expect(mockCompanyRepository.find).toHaveBeenCalled();
- expect(mockCompanyRepository.save).toHaveBeenCalledWith([]);
- });
- });
-
- describe('With existing companies and some deleted', () => {
- beforeEach(() => {
- mockCompanyRepository.find.mockResolvedValue([
- {
- id: 'soft-deleted-company-1',
- domainName: { primaryLinkUrl: 'https://soft-deleted-company.com' },
- deletedAt: new Date(),
- },
- ]);
- mockCompanyRepository.save.mockResolvedValue([]);
- mockCompanyRepository.updateMany.mockResolvedValue({
- raw: [
- {
- id: 'soft-deleted-company-1',
- domainNamePrimaryLinkUrl: 'https://soft-deleted-company.com',
- },
- ],
- });
- });
-
- it('should restore the soft deleted company', async () => {
- await service.createOrRestoreCompanies([companyToRestore], workspaceId);
-
- expect(mockCompanyRepository.find).toHaveBeenCalled();
- expect(mockCompanyRepository.save).toHaveBeenCalledWith([]);
- expect(mockCompanyRepository.updateMany).toHaveBeenCalledWith(
- [
- {
- criteria: 'soft-deleted-company-1',
- partialEntity: {
- deletedAt: null,
- },
- },
- ],
- undefined,
- ['domainNamePrimaryLinkUrl', 'id'],
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/bar-chart-data.service.spec.ts b/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/bar-chart-data.service.spec.ts
deleted file mode 100644
index 5f81d596bb8..00000000000
--- a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/bar-chart-data.service.spec.ts
+++ /dev/null
@@ -1,520 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { AggregateOperations, FieldMetadataType } from 'twenty-shared/types';
-
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { BarChartGroupMode } from 'src/engine/metadata-modules/page-layout-widget/enums/bar-chart-group-mode.enum';
-import { BarChartLayout } from 'src/engine/metadata-modules/page-layout-widget/enums/bar-chart-layout.enum';
-import { WidgetConfigurationType } from 'src/engine/metadata-modules/page-layout-widget/enums/widget-configuration-type.type';
-import { BAR_CHART_MAXIMUM_NUMBER_OF_BARS } from 'src/modules/dashboard/chart-data/constants/bar-chart-maximum-number-of-bars.constant';
-import { BarChartDataService } from 'src/modules/dashboard/chart-data/services/bar-chart-data.service';
-import { ChartDataQueryService } from 'src/modules/dashboard/chart-data/services/chart-data-query.service';
-import { ChartRelationLabelService } from 'src/modules/dashboard/chart-data/services/chart-relation-label.service';
-
-describe('BarChartDataService', () => {
- let service: BarChartDataService;
- let mockExecuteGroupByQuery: jest.Mock;
- let mockResolveRelationLabels: jest.Mock;
- let mockGetOrRecomputeManyOrAllFlatEntityMaps: jest.Mock;
-
- const workspaceId = 'test-workspace-id';
- const mockAuthContext = {
- type: 'system',
- workspace: { id: workspaceId },
- } as unknown as WorkspaceAuthContext;
- const objectMetadataId = 'test-object-id';
-
- const mockGroupByField = {
- id: 'group-by-field-id',
- name: 'status',
- label: 'Status',
- type: FieldMetadataType.TEXT,
- };
-
- const mockAggregateField = {
- id: 'aggregate-field-id',
- name: 'amount',
- label: 'Amount',
- type: FieldMetadataType.NUMBER,
- };
-
- const mockSelectField = {
- id: 'select-field-id',
- name: 'stage',
- label: 'Stage',
- type: FieldMetadataType.SELECT,
- options: [
- { value: 'open', label: 'Open', color: 'green', position: 0 },
- { value: 'closed', label: 'Closed', color: 'red', position: 1 },
- ],
- };
-
- const mockRelationField = {
- id: 'relation-field-id',
- name: 'agent',
- label: 'Agent',
- type: FieldMetadataType.RELATION,
- relationTargetObjectMetadataId: 'agent-object-id',
- };
-
- const mockObjectMetadata = {
- id: objectMetadataId,
- nameSingular: 'company',
- namePlural: 'companies',
- };
-
- beforeEach(async () => {
- mockExecuteGroupByQuery = jest.fn();
- mockResolveRelationLabels = jest.fn().mockResolvedValue({});
- mockGetOrRecomputeManyOrAllFlatEntityMaps = jest.fn().mockResolvedValue({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- 'test-object-universal-id': {
- ...mockObjectMetadata,
- universalIdentifier: 'test-object-universal-id',
- },
- },
- universalIdentifierById: {
- [objectMetadataId]: 'test-object-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- 'group-by-field-universal-id': {
- ...mockGroupByField,
- universalIdentifier: 'group-by-field-universal-id',
- },
- 'aggregate-field-universal-id': {
- ...mockAggregateField,
- universalIdentifier: 'aggregate-field-universal-id',
- },
- 'select-field-universal-id': {
- ...mockSelectField,
- universalIdentifier: 'select-field-universal-id',
- },
- 'relation-field-universal-id': {
- ...mockRelationField,
- universalIdentifier: 'relation-field-universal-id',
- },
- },
- universalIdentifierById: {
- [mockGroupByField.id]: 'group-by-field-universal-id',
- [mockAggregateField.id]: 'aggregate-field-universal-id',
- [mockSelectField.id]: 'select-field-universal-id',
- [mockRelationField.id]: 'relation-field-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- });
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- BarChartDataService,
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps:
- mockGetOrRecomputeManyOrAllFlatEntityMaps,
- },
- },
- {
- provide: ChartDataQueryService,
- useValue: {
- executeGroupByQuery: mockExecuteGroupByQuery,
- },
- },
- {
- provide: ChartRelationLabelService,
- useValue: {
- resolveRelationLabels: mockResolveRelationLabels,
- },
- },
- ],
- }).compile();
-
- service = module.get<BarChartDataService>(BarChartDataService);
- });
-
- describe('getBarChartData - One dimensional', () => {
- const baseConfiguration = {
- configurationType: WidgetConfigurationType.BAR_CHART,
- primaryAxisGroupByFieldMetadataId: mockGroupByField.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.COUNT,
- layout: BarChartLayout.VERTICAL,
- };
-
- it('should transform simple one-dimensional bar chart data', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Active'], aggregateValue: 10 },
- { groupByDimensionValues: ['Inactive'], aggregateValue: 5 },
- ]);
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: baseConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toHaveLength(2);
- expect(result.data[0]).toEqual({
- status: 'Active',
- amount: 10,
- });
- expect(result.data[1]).toEqual({
- status: 'Inactive',
- amount: 5,
- });
- expect(result.indexBy).toBe('status');
- expect(result.keys).toEqual(['amount']);
- expect(result.hasTooManyGroups).toBe(false);
- });
-
- it('should apply cumulative transform when isCumulative is true', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Jan'], aggregateValue: 10 },
- { groupByDimensionValues: ['Feb'], aggregateValue: 20 },
- { groupByDimensionValues: ['Mar'], aggregateValue: 30 },
- ]);
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- isCumulative: true,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toHaveLength(3);
- expect(result.data[0].amount).toBe(10);
- expect(result.data[1].amount).toBe(30);
- expect(result.data[2].amount).toBe(60);
- });
-
- it('should handle null values when omitNullValues is true', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: [null], aggregateValue: 5 },
- { groupByDimensionValues: ['Active'], aggregateValue: 10 },
- ]);
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- omitNullValues: true,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toHaveLength(1);
- expect(result.data[0].status).toBe('Active');
- });
-
- it('should format null values as "Not Set" when not omitting', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: [null], aggregateValue: 5 },
- { groupByDimensionValues: ['Active'], aggregateValue: 10 },
- ]);
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- omitNullValues: false,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toHaveLength(2);
- expect(result.data[0].status).toBe('Not Set');
- });
-
- it('should detect too many groups', async () => {
- const manyResults = Array.from(
- { length: BAR_CHART_MAXIMUM_NUMBER_OF_BARS + 5 },
- (_, i) => ({
- groupByDimensionValues: [`Group ${i}`],
- aggregateValue: i,
- }),
- );
-
- mockExecuteGroupByQuery.mockResolvedValue(manyResults);
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: baseConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.hasTooManyGroups).toBe(true);
- expect(result.data.length).toBeLessThanOrEqual(
- BAR_CHART_MAXIMUM_NUMBER_OF_BARS,
- );
- });
- });
-
- describe('getBarChartData - Two dimensional', () => {
- const twoDimConfiguration = {
- configurationType: WidgetConfigurationType.BAR_CHART,
- primaryAxisGroupByFieldMetadataId: mockGroupByField.id,
- secondaryAxisGroupByFieldMetadataId: mockSelectField.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.SUM,
- layout: BarChartLayout.VERTICAL,
- groupMode: BarChartGroupMode.STACKED,
- };
-
- beforeEach(() => {
- mockGetOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- 'test-object-universal-id': {
- ...mockObjectMetadata,
- universalIdentifier: 'test-object-universal-id',
- },
- },
- universalIdentifierById: {
- [objectMetadataId]: 'test-object-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- 'group-by-field-universal-id': {
- ...mockGroupByField,
- universalIdentifier: 'group-by-field-universal-id',
- },
- 'aggregate-field-universal-id': {
- ...mockAggregateField,
- universalIdentifier: 'aggregate-field-universal-id',
- },
- 'select-field-universal-id': {
- ...mockSelectField,
- universalIdentifier: 'select-field-universal-id',
- },
- },
- universalIdentifierById: {
- [mockGroupByField.id]: 'group-by-field-universal-id',
- [mockAggregateField.id]: 'aggregate-field-universal-id',
- [mockSelectField.id]: 'select-field-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- });
- });
-
- it('should transform two-dimensional bar chart data', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Jan', 'open'], aggregateValue: 100 },
- { groupByDimensionValues: ['Jan', 'closed'], aggregateValue: 50 },
- { groupByDimensionValues: ['Feb', 'open'], aggregateValue: 150 },
- { groupByDimensionValues: ['Feb', 'closed'], aggregateValue: 75 },
- ]);
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: twoDimConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toHaveLength(2);
- expect(result.keys).toContain('Open');
- expect(result.keys).toContain('Closed');
- expect(result.series).toHaveLength(2);
- });
-
- it('should apply cumulative transform to two-dimensional data', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Jan', 'open'], aggregateValue: 10 },
- { groupByDimensionValues: ['Jan', 'closed'], aggregateValue: 10 },
- { groupByDimensionValues: ['Feb', 'open'], aggregateValue: 20 },
- { groupByDimensionValues: ['Feb', 'closed'], aggregateValue: 20 },
- { groupByDimensionValues: ['Mar', 'open'], aggregateValue: 30 },
- { groupByDimensionValues: ['Mar', 'closed'], aggregateValue: 30 },
- ]);
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...twoDimConfiguration,
- isCumulative: true,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toHaveLength(3);
- expect(result.data[0]['Open']).toBe(10);
- expect(result.data[0]['Closed']).toBe(10);
- expect(result.data[1]['Open']).toBe(30);
- expect(result.data[1]['Closed']).toBe(30);
- expect(result.data[2]['Open']).toBe(60);
- expect(result.data[2]['Closed']).toBe(60);
- });
-
- it('should order keys correctly despite unordered raw results', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Oct 16', 'open'], aggregateValue: 100 },
- { groupByDimensionValues: ['Oct 17', 'closed'], aggregateValue: 200 },
- { groupByDimensionValues: ['Oct 21', 'open'], aggregateValue: 150 },
- { groupByDimensionValues: ['Oct 21', 'closed'], aggregateValue: 50 },
- ]);
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: twoDimConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.keys).toContain('Open');
- expect(result.keys).toContain('Closed');
- expect(result.data).toHaveLength(3);
- });
- });
-
- describe('Error handling', () => {
- it('should throw when object metadata is not found', async () => {
- mockGetOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatObjectMetadataMaps: { byId: {} },
- flatFieldMetadataMaps: { byId: {} },
- });
-
- await expect(
- service.getBarChartData({
- workspaceId,
- objectMetadataId: 'non-existent-id',
- configuration: {
- configurationType: WidgetConfigurationType.BAR_CHART,
- primaryAxisGroupByFieldMetadataId: mockGroupByField.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.COUNT,
- } as any,
- authContext: mockAuthContext,
- }),
- ).rejects.toThrow();
- });
-
- it('should throw when field metadata is not found', async () => {
- mockGetOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatObjectMetadataMaps: {
- byId: { [objectMetadataId]: mockObjectMetadata },
- },
- flatFieldMetadataMaps: { byId: {} },
- });
-
- await expect(
- service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- configurationType: WidgetConfigurationType.BAR_CHART,
- primaryAxisGroupByFieldMetadataId: 'non-existent-field',
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.COUNT,
- } as any,
- authContext: mockAuthContext,
- }),
- ).rejects.toThrow();
- });
- });
-
- describe('getBarChartData - Relation group by', () => {
- const relationConfiguration = {
- configurationType: WidgetConfigurationType.BAR_CHART,
- primaryAxisGroupByFieldMetadataId: mockRelationField.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.COUNT,
- layout: BarChartLayout.VERTICAL,
- };
-
- it('should use resolved labels on the axis and drop unresolved buckets', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 8 },
- { groupByDimensionValues: ['agent-id-2'], aggregateValue: 5 },
- ]);
- mockResolveRelationLabels.mockResolvedValue({
- primary: {
- labelByRecordId: new Map([['agent-id-1', 'Alice']]),
- unresolvedRecordIds: new Set(['agent-id-2']),
- },
- });
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: relationConfiguration as any,
- authContext: mockAuthContext,
- });
-
- const axisValues = result.data.map((item) => item[result.indexBy]);
-
- expect(axisValues).toContain('Alice');
- expect(axisValues).not.toContain('Unknown');
- expect(axisValues).not.toContain('agent-id-2');
- expect(result.data).toHaveLength(1);
- expect(result.formattedToRawLookup).toEqual({ Alice: 'agent-id-1' });
- });
-
- it('should compute hasTooManyGroups from the set reduced by dropped buckets', async () => {
- const rawResults = Array.from(
- { length: BAR_CHART_MAXIMUM_NUMBER_OF_BARS + 1 },
- (_, index) => ({
- groupByDimensionValues: [`agent-id-${index}`],
- aggregateValue: index + 1,
- }),
- );
- const unresolvedRecordIds = new Set([
- `agent-id-${BAR_CHART_MAXIMUM_NUMBER_OF_BARS}`,
- `agent-id-${BAR_CHART_MAXIMUM_NUMBER_OF_BARS - 1}`,
- ]);
- const labelByRecordId = new Map(
- rawResults
- .map((result) => String(result.groupByDimensionValues[0]))
- .filter((recordId) => !unresolvedRecordIds.has(recordId))
- .map((recordId) => [recordId, `Agent ${recordId}`]),
- );
-
- mockExecuteGroupByQuery.mockResolvedValue(rawResults);
- mockResolveRelationLabels.mockResolvedValue({
- primary: { labelByRecordId, unresolvedRecordIds },
- });
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: relationConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.hasTooManyGroups).toBe(false);
- expect(result.data).toHaveLength(BAR_CHART_MAXIMUM_NUMBER_OF_BARS - 1);
- });
-
- it('should keep raw values when no resolution is returned', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 8 },
- ]);
-
- const result = await service.getBarChartData({
- workspaceId,
- objectMetadataId,
- configuration: relationConfiguration as any,
- authContext: mockAuthContext,
- });
-
- const axisValues = result.data.map((item) => item[result.indexBy]);
-
- expect(axisValues).toContain('agent-id-1');
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/chart-data-query.service.spec.ts b/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/chart-data-query.service.spec.ts
deleted file mode 100644
index 7993c2e57bc..00000000000
--- a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/chart-data-query.service.spec.ts
+++ /dev/null
@@ -1,198 +0,0 @@
-import {
- AggregateOperations,
- FieldMetadataType,
- OrderByDirection,
- RelationType,
-} from 'twenty-shared/types';
-
-import { type CommonGroupByQueryRunnerService } from 'src/engine/api/common/common-query-runners/common-group-by-query-runner.service';
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
-import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
-import { GraphOrderBy } from 'src/engine/metadata-modules/page-layout-widget/enums/graph-order-by.enum';
-import { ChartDataQueryService } from 'src/modules/dashboard/chart-data/services/chart-data-query.service';
-
-const createMockFieldMetadata = (
- overrides: Partial<FlatFieldMetadata>,
-): FlatFieldMetadata =>
- ({
- id: 'test-field-id',
- name: 'testField',
- type: FieldMetadataType.TEXT,
- universalIdentifier: 'test-field-universal-id',
- ...overrides,
- }) as FlatFieldMetadata;
-
-const createMockObjectMetadata = (
- overrides: Partial<FlatObjectMetadata>,
-): FlatObjectMetadata =>
- ({
- id: 'test-object-id',
- nameSingular: 'testObject',
- namePlural: 'testObjects',
- fieldIds: [],
- universalIdentifier: 'test-object-universal-id',
- ...overrides,
- }) as FlatObjectMetadata;
-
-const buildFlatEntityMaps = <
- TEntity extends FlatFieldMetadata | FlatObjectMetadata,
->(
- entities: TEntity[],
-): FlatEntityMaps<TEntity> => ({
- byUniversalIdentifier: Object.fromEntries(
- entities.map((entity) => [entity.universalIdentifier as string, entity]),
- ),
- universalIdentifierById: Object.fromEntries(
- entities.map((entity) => [entity.id, entity.universalIdentifier as string]),
- ),
- universalIdentifiersByApplicationId: {},
-});
-
-describe('ChartDataQueryService', () => {
- const aggregateField = createMockFieldMetadata({
- id: 'amount-field-id',
- name: 'amount',
- type: FieldMetadataType.NUMBER,
- universalIdentifier: 'amount-field-universal-id',
- });
-
- const companyNameField = createMockFieldMetadata({
- id: 'company-name-field-id',
- name: 'name',
- type: FieldMetadataType.TEXT,
- universalIdentifier: 'company-name-universal-id',
- });
-
- const companyObject = createMockObjectMetadata({
- id: 'company-object-id',
- nameSingular: 'company',
- namePlural: 'companies',
- labelIdentifierFieldMetadataId: companyNameField.id,
- universalIdentifier: 'company-object-universal-id',
- });
-
- const companyRelationField = createMockFieldMetadata({
- id: 'company-relation-field-id',
- name: 'company',
- type: FieldMetadataType.RELATION,
- relationTargetObjectMetadataId: companyObject.id,
- universalIdentifier: 'company-relation-universal-id',
- settings: {
- relationType: RelationType.MANY_TO_ONE,
- joinColumnName: 'companyId',
- },
- } as Partial<FlatFieldMetadata>);
-
- const assigneeNameField = createMockFieldMetadata({
- id: 'assignee-name-field-id',
- name: 'name',
- type: FieldMetadataType.FULL_NAME,
- universalIdentifier: 'assignee-name-universal-id',
- });
-
- const assigneeObject = createMockObjectMetadata({
- id: 'assignee-object-id',
- nameSingular: 'workspaceMember',
- namePlural: 'workspaceMembers',
- labelIdentifierFieldMetadataId: assigneeNameField.id,
- universalIdentifier: 'assignee-object-universal-id',
- });
-
- const assigneeRelationField = createMockFieldMetadata({
- id: 'assignee-relation-field-id',
- name: 'assignee',
- type: FieldMetadataType.RELATION,
- relationTargetObjectMetadataId: assigneeObject.id,
- universalIdentifier: 'assignee-relation-universal-id',
- settings: {
- relationType: RelationType.MANY_TO_ONE,
- joinColumnName: 'assigneeId',
- },
- } as Partial<FlatFieldMetadata>);
-
- const sourceObject = createMockObjectMetadata({
- id: 'source-object-id',
- nameSingular: 'opportunity',
- namePlural: 'opportunities',
- fieldIds: [
- aggregateField.id,
- companyRelationField.id,
- assigneeRelationField.id,
- ],
- universalIdentifier: 'source-object-universal-id',
- });
-
- const flatObjectMetadataMaps = buildFlatEntityMaps([
- sourceObject,
- companyObject,
- assigneeObject,
- ]);
-
- const flatFieldMetadataMaps = buildFlatEntityMaps([
- aggregateField,
- companyRelationField,
- assigneeRelationField,
- companyNameField,
- assigneeNameField,
- ]);
-
- const executeMock = jest.fn();
-
- const service = new ChartDataQueryService({
- execute: executeMock,
- } as unknown as CommonGroupByQueryRunnerService);
-
- beforeEach(() => {
- jest.clearAllMocks();
- executeMock.mockResolvedValue({ results: [] });
- });
-
- const executeGroupByQueryForRelation = async (
- groupByFieldMetadataId: string,
- ) =>
- service.executeGroupByQuery({
- flatObjectMetadata: sourceObject,
- flatFieldMetadataMaps,
- flatObjectMetadataMaps,
- objectIdByNameSingular: {},
- authContext: {} as WorkspaceAuthContext,
- groupByFieldMetadataId,
- aggregateFieldMetadataId: aggregateField.id,
- aggregateOperation: AggregateOperations.SUM,
- userTimezone: 'UTC',
- firstDayOfTheWeek: 1,
- limit: 101,
- primaryAxisOrderBy: GraphOrderBy.FIELD_ASC,
- });
-
- it('should order by the target label then id when grouping by a bare relation', async () => {
- await executeGroupByQueryForRelation(companyRelationField.id);
-
- expect(executeMock).toHaveBeenCalledWith(
- expect.objectContaining({
- orderBy: [
- { company: { name: OrderByDirection.AscNullsLast } },
- { company: { id: OrderByDirection.AscNullsLast } },
- ],
- }),
- expect.anything(),
- );
- });
-
- it('should order by FULL_NAME subfields then id when grouping by a bare relation', async () => {
- await executeGroupByQueryForRelation(assigneeRelationField.id);
-
- expect(executeMock).toHaveBeenCalledWith(
- expect.objectContaining({
- orderBy: [
- { assignee: { name: { firstName: OrderByDirection.AscNullsLast } } },
- { assignee: { name: { lastName: OrderByDirection.AscNullsLast } } },
- { assignee: { id: OrderByDirection.AscNullsLast } },
- ],
- }),
- expect.anything(),
- );
- });
-});
diff --git a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/chart-relation-label.service.spec.ts b/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/chart-relation-label.service.spec.ts
deleted file mode 100644
index de69fff34e7..00000000000
--- a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/chart-relation-label.service.spec.ts
+++ /dev/null
@@ -1,358 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { formatResult } from 'src/engine/twenty-orm/utils/format-result.util';
-import { ChartRelationLabelService } from 'src/modules/dashboard/chart-data/services/chart-relation-label.service';
-
-jest.mock(
- 'src/engine/twenty-orm/storage/orm-workspace-context.storage',
- () => ({
- getWorkspaceContext: jest.fn(() => ({
- authContext: {},
- userWorkspaceRoleMap: {},
- apiKeyRoleMap: {},
- })),
- }),
-);
-
-jest.mock(
- 'src/engine/twenty-orm/utils/resolve-role-permission-config.util',
- () => ({
- resolveRolePermissionConfig: jest.fn(() => ({ shouldBypass: false })),
- }),
-);
-
-jest.mock('src/engine/twenty-orm/utils/format-result.util', () => ({
- formatResult: jest.fn((rawRow) => rawRow),
-}));
-
-jest.mock(
- 'src/engine/metadata-modules/flat-field-metadata/utils/is-morph-or-relation-flat-field-metadata.util',
- () => ({
- isMorphOrRelationFlatFieldMetadata: jest.fn(
- (fieldMetadata: FlatFieldMetadata) =>
- fieldMetadata.type === FieldMetadataType.RELATION ||
- fieldMetadata.type === FieldMetadataType.MORPH_RELATION,
- ),
- }),
-);
-
-const workspaceId = 'test-workspace-id';
-const mockAuthContext = {
- type: 'system',
- workspace: { id: workspaceId },
-} as unknown as WorkspaceAuthContext;
-
-const targetObjectMetadataId = 'agent-object-id';
-const labelFieldMetadataId = 'agent-name-field-id';
-const idFieldMetadataId = 'agent-id-field-id';
-
-const mockIdField = {
- id: idFieldMetadataId,
- name: 'id',
- type: FieldMetadataType.UUID,
- universalIdentifier: 'agent-id-field-universal-id',
-};
-
-const mockLabelField = {
- id: labelFieldMetadataId,
- name: 'name',
- type: FieldMetadataType.TEXT,
- universalIdentifier: 'agent-name-field-universal-id',
-};
-
-const mockTargetObjectMetadata = {
- id: targetObjectMetadataId,
- nameSingular: 'agent',
- labelIdentifierFieldMetadataId: labelFieldMetadataId,
- universalIdentifier: 'agent-object-universal-id',
- fieldIds: [idFieldMetadataId, labelFieldMetadataId],
-};
-
-const flatObjectMetadataMaps = {
- byUniversalIdentifier: {
- 'agent-object-universal-id': mockTargetObjectMetadata,
- },
- universalIdentifierById: {
- [targetObjectMetadataId]: 'agent-object-universal-id',
- },
- universalIdentifiersByApplicationId: {},
-} as never;
-
-const flatFieldMetadataMaps = {
- byUniversalIdentifier: {
- 'agent-id-field-universal-id': mockIdField,
- 'agent-name-field-universal-id': mockLabelField,
- },
- universalIdentifierById: {
- [idFieldMetadataId]: 'agent-id-field-universal-id',
- [labelFieldMetadataId]: 'agent-name-field-universal-id',
- },
- universalIdentifiersByApplicationId: {},
-} as never;
-
-const relationGroupByField = {
- id: 'relation-field-id',
- name: 'agent',
- type: FieldMetadataType.RELATION,
- relationTargetObjectMetadataId: targetObjectMetadataId,
-} as unknown as FlatFieldMetadata;
-
-describe('ChartRelationLabelService', () => {
- let service: ChartRelationLabelService;
- let mockGetRawMany: jest.Mock;
- let mockGetRepository: jest.Mock;
-
- beforeEach(async () => {
- mockGetRawMany = jest.fn().mockResolvedValue([]);
-
- const mockQueryBuilder = {
- select: jest.fn().mockReturnThis(),
- addSelect: jest.fn().mockReturnThis(),
- where: jest.fn().mockReturnThis(),
- getRawMany: mockGetRawMany,
- };
-
- mockGetRepository = jest.fn().mockResolvedValue({
- createQueryBuilder: jest.fn(() => mockQueryBuilder),
- });
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ChartRelationLabelService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- executeInWorkspaceContext: jest.fn((callback) => callback()),
- getRepository: mockGetRepository,
- },
- },
- ],
- }).compile();
-
- service = module.get<ChartRelationLabelService>(ChartRelationLabelService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should resolve labels for a bare relation axis', async () => {
- mockGetRawMany.mockResolvedValue([
- { id: 'agent-id-1', name: 'Alice' },
- { id: 'agent-id-2', name: 'Bob' },
- ]);
-
- const { primary } = await service.resolveRelationLabels({
- rawResults: [
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 3 },
- { groupByDimensionValues: ['agent-id-2'], aggregateValue: 1 },
- ],
- primaryAxis: { groupByField: relationGroupByField, subFieldName: null },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(primary?.labelByRecordId.get('agent-id-1')).toBe('Alice');
- expect(primary?.labelByRecordId.get('agent-id-2')).toBe('Bob');
- expect(primary?.unresolvedRecordIds.size).toBe(0);
- });
-
- it('should preserve the record id through the real formatResult so labels resolve', async () => {
- const actualFormatResult = jest.requireActual(
- 'src/engine/twenty-orm/utils/format-result.util',
- ).formatResult;
-
- (formatResult as jest.Mock).mockImplementationOnce((...args) =>
- actualFormatResult(...args),
- );
-
- mockGetRawMany.mockResolvedValue([{ id: 'agent-id-1', name: 'Alice' }]);
-
- const { primary } = await service.resolveRelationLabels({
- rawResults: [
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 3 },
- ],
- primaryAxis: { groupByField: relationGroupByField, subFieldName: null },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(primary?.labelByRecordId.get('agent-id-1')).toBe('Alice');
- expect(primary?.unresolvedRecordIds.size).toBe(0);
- });
-
- it('should suffix duplicate labels', async () => {
- mockGetRawMany.mockResolvedValue([
- { id: 'agent-id-1', name: 'John Smith' },
- { id: 'agent-id-2', name: 'John Smith' },
- ]);
-
- const { primary } = await service.resolveRelationLabels({
- rawResults: [
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 3 },
- { groupByDimensionValues: ['agent-id-2'], aggregateValue: 1 },
- ],
- primaryAxis: { groupByField: relationGroupByField, subFieldName: null },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(primary?.labelByRecordId.get('agent-id-1')).toBe('John Smith (1)');
- expect(primary?.labelByRecordId.get('agent-id-2')).toBe('John Smith (2)');
- });
-
- it('should mark records missing from the query result as unresolved', async () => {
- mockGetRawMany.mockResolvedValue([{ id: 'agent-id-1', name: 'Alice' }]);
-
- const { primary } = await service.resolveRelationLabels({
- rawResults: [
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 3 },
- { groupByDimensionValues: ['agent-id-2'], aggregateValue: 1 },
- ],
- primaryAxis: { groupByField: relationGroupByField, subFieldName: null },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(primary?.labelByRecordId.has('agent-id-2')).toBe(false);
- expect(primary?.unresolvedRecordIds).toEqual(new Set(['agent-id-2']));
- });
-
- it('should degrade to unresolved labels when the query throws', async () => {
- mockGetRepository.mockRejectedValue(new Error('permission denied'));
-
- const { primary } = await service.resolveRelationLabels({
- rawResults: [
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 3 },
- ],
- primaryAxis: { groupByField: relationGroupByField, subFieldName: null },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(primary?.labelByRecordId.has('agent-id-1')).toBe(false);
- expect(primary?.unresolvedRecordIds).toEqual(new Set(['agent-id-1']));
- });
-
- it('should not resolve an axis with a subFieldName', async () => {
- const resolutions = await service.resolveRelationLabels({
- rawResults: [{ groupByDimensionValues: ['Acme'], aggregateValue: 3 }],
- primaryAxis: { groupByField: relationGroupByField, subFieldName: 'name' },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(resolutions).toEqual({});
- expect(mockGetRepository).not.toHaveBeenCalled();
- });
-
- it('should not resolve a non-relation axis', async () => {
- const resolutions = await service.resolveRelationLabels({
- rawResults: [{ groupByDimensionValues: ['Active'], aggregateValue: 3 }],
- primaryAxis: {
- groupByField: {
- id: 'text-field-id',
- name: 'status',
- type: FieldMetadataType.TEXT,
- } as unknown as FlatFieldMetadata,
- subFieldName: null,
- },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(resolutions).toEqual({});
- expect(mockGetRepository).not.toHaveBeenCalled();
- });
-
- it('should issue a single query when both axes target the same object', async () => {
- mockGetRawMany.mockResolvedValue([
- { id: 'agent-id-1', name: 'Alice' },
- { id: 'agent-id-2', name: 'Bob' },
- ]);
-
- const { primary, secondary } = await service.resolveRelationLabels({
- rawResults: [
- {
- groupByDimensionValues: ['agent-id-1', 'agent-id-2'],
- aggregateValue: 3,
- },
- ],
- primaryAxis: { groupByField: relationGroupByField, subFieldName: null },
- secondaryAxis: { groupByField: relationGroupByField, subFieldName: null },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(mockGetRepository).toHaveBeenCalledTimes(1);
- expect(primary?.labelByRecordId.get('agent-id-1')).toBe('Alice');
- expect(secondary?.labelByRecordId.get('agent-id-2')).toBe('Bob');
- });
-
- it('should resolve labels when the group by field is a morph relation', async () => {
- mockGetRawMany.mockResolvedValue([{ id: 'agent-id-1', name: 'Alice' }]);
-
- const morphRelationGroupByField = {
- id: 'morph-relation-field-id',
- name: 'morphAgent',
- type: FieldMetadataType.MORPH_RELATION,
- relationTargetObjectMetadataId: targetObjectMetadataId,
- } as unknown as FlatFieldMetadata;
-
- const { primary } = await service.resolveRelationLabels({
- rawResults: [
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 3 },
- ],
- primaryAxis: {
- groupByField: morphRelationGroupByField,
- subFieldName: null,
- },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(primary?.labelByRecordId.get('agent-id-1')).toBe('Alice');
- expect(primary?.unresolvedRecordIds.size).toBe(0);
- });
-
- it('should treat a label falling back to the record id as unresolved', async () => {
- mockGetRawMany.mockResolvedValue([{ id: 'agent-id-1', name: null }]);
-
- const { primary } = await service.resolveRelationLabels({
- rawResults: [
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 3 },
- ],
- primaryAxis: { groupByField: relationGroupByField, subFieldName: null },
- workspaceId,
- authContext: mockAuthContext,
- flatObjectMetadataMaps,
- flatFieldMetadataMaps,
- });
-
- expect(primary?.labelByRecordId.has('agent-id-1')).toBe(false);
- expect(primary?.unresolvedRecordIds).toEqual(new Set(['agent-id-1']));
- });
-});
diff --git a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/line-chart-data.service.spec.ts b/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/line-chart-data.service.spec.ts
deleted file mode 100644
index a6893e38f86..00000000000
--- a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/line-chart-data.service.spec.ts
+++ /dev/null
@@ -1,479 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { AggregateOperations, FieldMetadataType } from 'twenty-shared/types';
-
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { WidgetConfigurationType } from 'src/engine/metadata-modules/page-layout-widget/enums/widget-configuration-type.type';
-import { LINE_CHART_MAXIMUM_NUMBER_OF_DATA_POINTS } from 'src/modules/dashboard/chart-data/constants/line-chart-maximum-number-of-data-points.constant';
-import { ChartDataQueryService } from 'src/modules/dashboard/chart-data/services/chart-data-query.service';
-import { ChartRelationLabelService } from 'src/modules/dashboard/chart-data/services/chart-relation-label.service';
-import { LineChartDataService } from 'src/modules/dashboard/chart-data/services/line-chart-data.service';
-
-describe('LineChartDataService', () => {
- let service: LineChartDataService;
- let mockExecuteGroupByQuery: jest.Mock;
- let mockResolveRelationLabels: jest.Mock;
-
- const workspaceId = 'test-workspace-id';
- const mockAuthContext = {
- type: 'system',
- workspace: { id: workspaceId },
- } as unknown as WorkspaceAuthContext;
- const objectMetadataId = 'test-object-id';
-
- const mockGroupByFieldX = {
- id: 'group-by-field-id',
- name: 'createdAt',
- label: 'Created At',
- type: FieldMetadataType.DATE_TIME,
- };
-
- const mockGroupByFieldXText = {
- id: 'group-by-field-text-id',
- name: 'stage',
- label: 'Stage',
- type: FieldMetadataType.TEXT,
- };
-
- const mockGroupByFieldY = {
- id: 'secondary-field-id',
- name: 'stage',
- label: 'Stage',
- type: FieldMetadataType.TEXT,
- };
-
- const mockRelationFieldY = {
- id: 'secondary-relation-field-id',
- name: 'agent',
- label: 'Agent',
- type: FieldMetadataType.RELATION,
- relationTargetObjectMetadataId: 'agent-object-id',
- };
-
- const mockAggregateField = {
- id: 'aggregate-field-id',
- name: 'amount',
- label: 'Amount',
- type: FieldMetadataType.NUMBER,
- };
-
- const mockObjectMetadata = {
- id: objectMetadataId,
- nameSingular: 'opportunity',
- namePlural: 'opportunities',
- };
-
- beforeEach(async () => {
- mockExecuteGroupByQuery = jest.fn();
- mockResolveRelationLabels = jest.fn().mockResolvedValue({});
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- LineChartDataService,
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest.fn().mockResolvedValue({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- 'test-object-universal-id': {
- ...mockObjectMetadata,
- universalIdentifier: 'test-object-universal-id',
- },
- },
- universalIdentifierById: {
- [objectMetadataId]: 'test-object-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- 'group-by-field-x-universal-id': {
- ...mockGroupByFieldX,
- universalIdentifier: 'group-by-field-x-universal-id',
- },
- 'group-by-field-x-text-universal-id': {
- ...mockGroupByFieldXText,
- universalIdentifier: 'group-by-field-x-text-universal-id',
- },
- 'group-by-field-y-universal-id': {
- ...mockGroupByFieldY,
- universalIdentifier: 'group-by-field-y-universal-id',
- },
- 'secondary-relation-field-universal-id': {
- ...mockRelationFieldY,
- universalIdentifier:
- 'secondary-relation-field-universal-id',
- },
- 'aggregate-field-universal-id': {
- ...mockAggregateField,
- universalIdentifier: 'aggregate-field-universal-id',
- },
- },
- universalIdentifierById: {
- [mockGroupByFieldX.id]: 'group-by-field-x-universal-id',
- [mockGroupByFieldXText.id]:
- 'group-by-field-x-text-universal-id',
- [mockGroupByFieldY.id]: 'group-by-field-y-universal-id',
- [mockRelationFieldY.id]:
- 'secondary-relation-field-universal-id',
- [mockAggregateField.id]: 'aggregate-field-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- }),
- },
- },
- {
- provide: ChartDataQueryService,
- useValue: {
- executeGroupByQuery: mockExecuteGroupByQuery,
- },
- },
- {
- provide: ChartRelationLabelService,
- useValue: {
- resolveRelationLabels: mockResolveRelationLabels,
- },
- },
- ],
- }).compile();
-
- service = module.get<LineChartDataService>(LineChartDataService);
- });
-
- describe('getLineChartData - One dimensional', () => {
- const baseConfiguration = {
- configurationType: WidgetConfigurationType.LINE_CHART,
- primaryAxisGroupByFieldMetadataId: mockGroupByFieldXText.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.SUM,
- };
-
- it('should transform simple one-dimensional line chart data', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Qualification'], aggregateValue: 150000 },
- { groupByDimensionValues: ['Proposal'], aggregateValue: 280000 },
- { groupByDimensionValues: ['Closed Won'], aggregateValue: 450000 },
- ]);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: baseConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.series).toHaveLength(1);
- expect(result.series[0].data).toEqual([
- { x: 'Qualification', y: 150000 },
- { x: 'Proposal', y: 280000 },
- { x: 'Closed Won', y: 450000 },
- ]);
- expect(result.hasTooManyGroups).toBe(false);
- });
-
- it('should apply cumulative transform when isCumulative is true', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Jan'], aggregateValue: 10 },
- { groupByDimensionValues: ['Feb'], aggregateValue: 20 },
- { groupByDimensionValues: ['Mar'], aggregateValue: 30 },
- ]);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- isCumulative: true,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.series[0].data).toEqual([
- { x: 'Jan', y: 10 },
- { x: 'Feb', y: 30 },
- { x: 'Mar', y: 60 },
- ]);
- });
-
- it('should handle null y values by keeping running total', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['a'], aggregateValue: 10 },
- { groupByDimensionValues: ['b'], aggregateValue: 0 },
- { groupByDimensionValues: ['c'], aggregateValue: 20 },
- ]);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- isCumulative: true,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.series[0].data).toEqual([
- { x: 'a', y: 10 },
- { x: 'b', y: 10 },
- { x: 'c', y: 30 },
- ]);
- });
-
- it('should handle empty results', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([]);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: baseConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.series).toHaveLength(1);
- expect(result.series[0].data).toEqual([]);
- expect(result.hasTooManyGroups).toBe(false);
- });
-
- it('should detect too many data points', async () => {
- const manyResults = Array.from(
- { length: LINE_CHART_MAXIMUM_NUMBER_OF_DATA_POINTS + 5 },
- (_, i) => ({
- groupByDimensionValues: [`Point ${i}`],
- aggregateValue: i * 100,
- }),
- );
-
- mockExecuteGroupByQuery.mockResolvedValue(manyResults);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: baseConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.hasTooManyGroups).toBe(true);
- });
- });
-
- describe('getLineChartData - Two dimensional', () => {
- const twoDimConfiguration = {
- configurationType: WidgetConfigurationType.LINE_CHART,
- primaryAxisGroupByFieldMetadataId: mockGroupByFieldX.id,
- secondaryAxisGroupByFieldMetadataId: mockGroupByFieldY.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.SUM,
- };
-
- it('should create multiple series from 2D groupBy results', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- {
- groupByDimensionValues: ['2024-01-01', 'Qualification'],
- aggregateValue: 50000,
- },
- {
- groupByDimensionValues: ['2024-01-01', 'Proposal'],
- aggregateValue: 75000,
- },
- {
- groupByDimensionValues: ['2024-02-01', 'Qualification'],
- aggregateValue: 60000,
- },
- {
- groupByDimensionValues: ['2024-02-01', 'Proposal'],
- aggregateValue: 90000,
- },
- ]);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: twoDimConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.series).toHaveLength(2);
- expect(result.series.every((s) => s.data.length === 2)).toBe(true);
- expect(result.hasTooManyGroups).toBe(false);
- });
-
- it('should label secondary relation series with resolved record names and drop unresolved series', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- {
- groupByDimensionValues: ['2024-01-01', 'agent-id-1'],
- aggregateValue: 8,
- },
- {
- groupByDimensionValues: ['2024-01-01', 'agent-id-2'],
- aggregateValue: 5,
- },
- ]);
- mockResolveRelationLabels.mockResolvedValue({
- secondary: {
- labelByRecordId: new Map([['agent-id-1', 'Alice']]),
- unresolvedRecordIds: new Set(['agent-id-2']),
- },
- });
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...twoDimConfiguration,
- secondaryAxisGroupByFieldMetadataId: mockRelationFieldY.id,
- } as any,
- authContext: mockAuthContext,
- });
-
- const seriesLabels = result.series.map((serie) => serie.label);
-
- expect(seriesLabels).toContain('Alice');
- expect(seriesLabels).not.toContain('Unknown');
- expect(Object.values(result.formattedToRawLookup)).toContain(
- 'agent-id-1',
- );
- expect(Object.values(result.formattedToRawLookup)).not.toContain(
- 'agent-id-2',
- );
- });
-
- it('should key the secondary lookup by prefixed series id only', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- {
- groupByDimensionValues: ['2024-01-01', 'agent-id-1'],
- aggregateValue: 8,
- },
- ]);
- mockResolveRelationLabels.mockResolvedValue({
- secondary: {
- labelByRecordId: new Map([['agent-id-1', 'Alice']]),
- unresolvedRecordIds: new Set(),
- },
- });
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...twoDimConfiguration,
- secondaryAxisGroupByFieldMetadataId: mockRelationFieldY.id,
- } as any,
- authContext: mockAuthContext,
- });
-
- const aliceSeries = result.series.find(
- (serie) => serie.label === 'Alice',
- );
-
- expect(aliceSeries).toBeDefined();
- expect(result.formattedToRawLookup[aliceSeries!.key]).toBe('agent-id-1');
- expect(result.formattedToRawLookup['Alice']).toBeUndefined();
- });
-
- it('should normalize sparse data (fill missing x values with 0)', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- {
- groupByDimensionValues: ['2024-01-01', 'Stage A'],
- aggregateValue: 100,
- },
- {
- groupByDimensionValues: ['2024-02-01', 'Stage A'],
- aggregateValue: 200,
- },
- {
- groupByDimensionValues: ['2024-01-01', 'Stage B'],
- aggregateValue: 150,
- },
- {
- groupByDimensionValues: ['2024-03-01', 'Stage B'],
- aggregateValue: 250,
- },
- ]);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: twoDimConfiguration as any,
- authContext: mockAuthContext,
- });
-
- const stageA = result.series.find((s) => s.label === 'Stage A');
-
- expect(stageA?.data).toHaveLength(3);
- expect(stageA?.data[0].y).toBe(100);
- expect(stageA?.data[1].y).toBe(200);
- expect(stageA?.data[2].y).toBe(0);
-
- const stageB = result.series.find((s) => s.label === 'Stage B');
-
- expect(stageB?.data).toHaveLength(3);
- expect(stageB?.data[0].y).toBe(150);
- expect(stageB?.data[1].y).toBe(0);
- expect(stageB?.data[2].y).toBe(250);
- });
-
- it('should apply cumulative transform to each series independently', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['2024-01-01', 'A'], aggregateValue: 10 },
- { groupByDimensionValues: ['2024-02-01', 'A'], aggregateValue: 20 },
- { groupByDimensionValues: ['2024-01-01', 'B'], aggregateValue: 100 },
- { groupByDimensionValues: ['2024-02-01', 'B'], aggregateValue: 200 },
- ]);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...twoDimConfiguration,
- isCumulative: true,
- } as any,
- authContext: mockAuthContext,
- });
-
- const seriesA = result.series.find((s) => s.label === 'A');
- const seriesB = result.series.find((s) => s.label === 'B');
-
- expect(seriesA?.data[0].y).toBe(10);
- expect(seriesA?.data[1].y).toBe(30);
- expect(seriesB?.data[0].y).toBe(100);
- expect(seriesB?.data[1].y).toBe(300);
- });
-
- it('should handle empty results', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([]);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: twoDimConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.series).toEqual([]);
- expect(result.hasTooManyGroups).toBe(false);
- });
-
- it('should skip results with missing dimension values', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['2024-01-01'], aggregateValue: 100 },
- {
- groupByDimensionValues: ['2024-02-01', 'Stage A'],
- aggregateValue: 200,
- },
- ]);
-
- const result = await service.getLineChartData({
- workspaceId,
- objectMetadataId,
- configuration: twoDimConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.series).toHaveLength(1);
- expect(result.series[0].data).toHaveLength(1);
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/pie-chart-data.service.spec.ts b/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/pie-chart-data.service.spec.ts
deleted file mode 100644
index 581e55c1324..00000000000
--- a/packages/twenty-server/src/modules/dashboard/chart-data/services/__tests__/pie-chart-data.service.spec.ts
+++ /dev/null
@@ -1,581 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { AggregateOperations, FieldMetadataType } from 'twenty-shared/types';
-
-import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { GraphOrderBy } from 'src/engine/metadata-modules/page-layout-widget/enums/graph-order-by.enum';
-import { WidgetConfigurationType } from 'src/engine/metadata-modules/page-layout-widget/enums/widget-configuration-type.type';
-import { PIE_CHART_MAXIMUM_NUMBER_OF_SLICES } from 'src/modules/dashboard/chart-data/constants/pie-chart-maximum-number-of-slices.constant';
-import { ChartDataQueryService } from 'src/modules/dashboard/chart-data/services/chart-data-query.service';
-import { ChartRelationLabelService } from 'src/modules/dashboard/chart-data/services/chart-relation-label.service';
-import { PieChartDataService } from 'src/modules/dashboard/chart-data/services/pie-chart-data.service';
-
-describe('PieChartDataService', () => {
- let service: PieChartDataService;
- let mockExecuteGroupByQuery: jest.Mock;
- let mockResolveRelationLabels: jest.Mock;
- let mockGetOrRecomputeManyOrAllFlatEntityMaps: jest.Mock;
-
- const workspaceId = 'test-workspace-id';
- const mockAuthContext = {
- type: 'system',
- workspace: { id: workspaceId } as any,
- } as unknown as WorkspaceAuthContext;
- const objectMetadataId = 'test-object-id';
-
- const mockGroupByField = {
- id: 'group-by-field-id',
- name: 'status',
- label: 'Status',
- type: FieldMetadataType.TEXT,
- };
-
- const mockSelectField = {
- id: 'select-field-id',
- name: 'stage',
- label: 'Stage',
- type: FieldMetadataType.SELECT,
- options: [
- { value: 'open', label: 'Open', color: 'green', position: 0 },
- { value: 'closed', label: 'Closed', color: 'red', position: 1 },
- ],
- };
-
- const mockAggregateField = {
- id: 'aggregate-field-id',
- name: 'id',
- label: 'Id',
- type: FieldMetadataType.UUID,
- };
-
- const mockRelationField = {
- id: 'relation-field-id',
- name: 'assignedAgent',
- label: 'Assigned Agent',
- type: FieldMetadataType.RELATION,
- };
-
- const mockObjectMetadata = {
- id: objectMetadataId,
- nameSingular: 'company',
- namePlural: 'companies',
- };
-
- beforeEach(async () => {
- mockExecuteGroupByQuery = jest.fn();
- mockResolveRelationLabels = jest.fn().mockResolvedValue({});
- mockGetOrRecomputeManyOrAllFlatEntityMaps = jest.fn().mockResolvedValue({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- 'test-object-universal-id': {
- ...mockObjectMetadata,
- universalIdentifier: 'test-object-universal-id',
- },
- },
- universalIdentifierById: {
- [objectMetadataId]: 'test-object-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- 'group-by-field-universal-id': {
- ...mockGroupByField,
- universalIdentifier: 'group-by-field-universal-id',
- },
- 'select-field-universal-id': {
- ...mockSelectField,
- universalIdentifier: 'select-field-universal-id',
- },
- 'aggregate-field-universal-id': {
- ...mockAggregateField,
- universalIdentifier: 'aggregate-field-universal-id',
- },
- 'relation-field-universal-id': {
- ...mockRelationField,
- universalIdentifier: 'relation-field-universal-id',
- },
- },
- universalIdentifierById: {
- [mockGroupByField.id]: 'group-by-field-universal-id',
- [mockSelectField.id]: 'select-field-universal-id',
- [mockAggregateField.id]: 'aggregate-field-universal-id',
- [mockRelationField.id]: 'relation-field-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- });
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- PieChartDataService,
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps:
- mockGetOrRecomputeManyOrAllFlatEntityMaps,
- },
- },
- {
- provide: ChartDataQueryService,
- useValue: {
- executeGroupByQuery: mockExecuteGroupByQuery,
- },
- },
- {
- provide: ChartRelationLabelService,
- useValue: {
- resolveRelationLabels: mockResolveRelationLabels,
- },
- },
- ],
- }).compile();
-
- service = module.get<PieChartDataService>(PieChartDataService);
- });
-
- describe('getPieChartData', () => {
- const baseConfiguration = {
- configurationType: WidgetConfigurationType.PIE_CHART,
- groupByFieldMetadataId: mockGroupByField.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.COUNT,
- displayLegend: true,
- };
-
- it('should transform simple pie chart data', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Active'], aggregateValue: 10 },
- { groupByDimensionValues: ['Inactive'], aggregateValue: 5 },
- ]);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: baseConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toHaveLength(2);
- expect(result.data[0]).toEqual({
- key: 'Active',
- value: 10,
- });
- expect(result.data[1]).toEqual({
- key: 'Inactive',
- value: 5,
- });
- expect(result.showLegend).toBe(true);
- expect(result.hasTooManyGroups).toBe(false);
- });
-
- it('should keep null group buckets aligned with their aggregate values', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: [null], aggregateValue: 2 },
- { groupByDimensionValues: ['Active'], aggregateValue: 5 },
- ]);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: baseConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toEqual([
- { key: 'Not Set', value: 2 },
- { key: 'Active', value: 5 },
- ]);
- expect(result.formattedToRawLookup?.['Not Set']).toBeUndefined();
- expect(result.formattedToRawLookup?.['Active']).toBe('Active');
- });
-
- it('should hide empty category when hideEmptyCategory is true', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: [null], aggregateValue: 2 },
- { groupByDimensionValues: ['Active'], aggregateValue: 5 },
- ]);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- hideEmptyCategory: true,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toHaveLength(1);
- expect(result.data[0].key).toBe('Active');
- });
-
- it('should resolve relation labels from the buckets surviving hideEmptyCategory', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: [null], aggregateValue: 2 },
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 0 },
- { groupByDimensionValues: ['agent-id-2'], aggregateValue: 5 },
- ]);
-
- await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- hideEmptyCategory: true,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(mockResolveRelationLabels).toHaveBeenCalledWith(
- expect.objectContaining({
- rawResults: [
- { groupByDimensionValues: ['agent-id-2'], aggregateValue: 5 },
- ],
- }),
- );
- });
-
- it('should drop unresolved relation buckets while keeping resolved and Not Set slices', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: [null], aggregateValue: 2 },
- { groupByDimensionValues: ['agent-id-1'], aggregateValue: 8 },
- { groupByDimensionValues: ['agent-id-2'], aggregateValue: 5 },
- ]);
- mockResolveRelationLabels.mockResolvedValue({
- primary: {
- labelByRecordId: new Map([['agent-id-1', 'Alice']]),
- unresolvedRecordIds: new Set(['agent-id-2']),
- },
- });
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- groupByFieldMetadataId: mockRelationField.id,
- } as any,
- authContext: mockAuthContext,
- });
-
- const keys = result.data.map((item) => item.key);
-
- expect(keys).toContain('Alice');
- expect(keys).toContain('Not Set');
- expect(keys).not.toContain('Unknown');
- expect(keys).not.toContain('agent-id-2');
- expect(result.data).toHaveLength(2);
- });
-
- it('should flag too many groups and limit slices', async () => {
- const manyResults = Array.from(
- { length: PIE_CHART_MAXIMUM_NUMBER_OF_SLICES + 5 },
- (_, index) => ({
- groupByDimensionValues: [`Group ${index}`],
- aggregateValue: index + 1,
- }),
- );
-
- mockExecuteGroupByQuery.mockResolvedValue(manyResults);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: baseConfiguration as any,
- authContext: mockAuthContext,
- });
-
- expect(result.hasTooManyGroups).toBe(true);
- expect(result.data).toHaveLength(PIE_CHART_MAXIMUM_NUMBER_OF_SLICES);
- });
-
- it('should keep the highest-value slices when ordering by value with too many groups', async () => {
- const extraSlices = 5;
- const manyResults = Array.from(
- { length: PIE_CHART_MAXIMUM_NUMBER_OF_SLICES + extraSlices },
- (_, index) => ({
- groupByDimensionValues: [`Group ${index}`],
- aggregateValue: index + 1,
- }),
- );
-
- mockExecuteGroupByQuery.mockResolvedValue(manyResults);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- orderBy: GraphOrderBy.VALUE_DESC,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data).toHaveLength(PIE_CHART_MAXIMUM_NUMBER_OF_SLICES);
- expect(result.data[0].value).toBe(
- PIE_CHART_MAXIMUM_NUMBER_OF_SLICES + extraSlices,
- );
- const smallestSurvivingValue = Math.min(
- ...result.data.map((slice) => slice.value),
- );
-
- expect(smallestSurvivingValue).toBe(extraSlices + 1);
- });
-
- it('should respect displayLegend configuration', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Active'], aggregateValue: 10 },
- ]);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- displayLegend: false,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.showLegend).toBe(false);
- });
-
- it('should respect displayDataLabel configuration', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Active'], aggregateValue: 10 },
- ]);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- displayDataLabel: true,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.showDataLabels).toBe(true);
- });
-
- it('should respect showCenterMetric configuration', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['Active'], aggregateValue: 10 },
- ]);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- showCenterMetric: false,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.showCenterMetric).toBe(false);
- });
-
- it('should format select field values using option labels', async () => {
- mockGetOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- 'test-object-universal-id': {
- ...mockObjectMetadata,
- universalIdentifier: 'test-object-universal-id',
- },
- },
- universalIdentifierById: {
- [objectMetadataId]: 'test-object-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- 'select-field-universal-id': {
- ...mockSelectField,
- universalIdentifier: 'select-field-universal-id',
- },
- 'aggregate-field-universal-id': {
- ...mockAggregateField,
- universalIdentifier: 'aggregate-field-universal-id',
- },
- },
- universalIdentifierById: {
- [mockSelectField.id]: 'select-field-universal-id',
- [mockAggregateField.id]: 'aggregate-field-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- });
-
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: ['open'], aggregateValue: 10 },
- { groupByDimensionValues: ['closed'], aggregateValue: 5 },
- ]);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- ...baseConfiguration,
- groupByFieldMetadataId: mockSelectField.id,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data[0].key).toBe('Open');
- expect(result.data[1].key).toBe('Closed');
- });
- });
-
- describe('Error handling', () => {
- it('should throw when configuration type is not PIE_CHART', async () => {
- await expect(
- service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- configurationType: WidgetConfigurationType.BAR_CHART,
- groupByFieldMetadataId: mockGroupByField.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.COUNT,
- } as any,
- authContext: mockAuthContext,
- }),
- ).rejects.toThrow();
- });
-
- it('should throw when object metadata is not found', async () => {
- mockGetOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- });
-
- await expect(
- service.getPieChartData({
- workspaceId,
- objectMetadataId: 'non-existent-id',
- configuration: {
- configurationType: WidgetConfigurationType.PIE_CHART,
- groupByFieldMetadataId: mockGroupByField.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.COUNT,
- } as any,
- authContext: mockAuthContext,
- }),
- ).rejects.toThrow();
- });
-
- it('should throw when field metadata is not found', async () => {
- mockGetOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- 'test-object-universal-id': {
- ...mockObjectMetadata,
- universalIdentifier: 'test-object-universal-id',
- },
- },
- universalIdentifierById: {
- [objectMetadataId]: 'test-object-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {},
- universalIdentifierById: {},
- universalIdentifiersByApplicationId: {},
- },
- });
-
- await expect(
- service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- configurationType: WidgetConfigurationType.PIE_CHART,
- groupByFieldMetadataId: 'non-existent-field',
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.COUNT,
- } as any,
- authContext: mockAuthContext,
- }),
- ).rejects.toThrow();
- });
- });
-
- describe('Boolean field formatting', () => {
- const booleanField = {
- id: 'boolean-field-id',
- name: 'isActive',
- label: 'Is Active',
- type: FieldMetadataType.BOOLEAN,
- };
-
- beforeEach(() => {
- mockGetOrRecomputeManyOrAllFlatEntityMaps.mockResolvedValue({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- 'test-object-universal-id': {
- ...mockObjectMetadata,
- universalIdentifier: 'test-object-universal-id',
- },
- },
- universalIdentifierById: {
- [objectMetadataId]: 'test-object-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: {
- 'boolean-field-universal-id': {
- ...booleanField,
- universalIdentifier: 'boolean-field-universal-id',
- },
- 'aggregate-field-universal-id': {
- ...mockAggregateField,
- universalIdentifier: 'aggregate-field-universal-id',
- },
- },
- universalIdentifierById: {
- [booleanField.id]: 'boolean-field-universal-id',
- [mockAggregateField.id]: 'aggregate-field-universal-id',
- },
- universalIdentifiersByApplicationId: {},
- },
- });
- });
-
- it('should format boolean values as Yes/No', async () => {
- mockExecuteGroupByQuery.mockResolvedValue([
- { groupByDimensionValues: [true], aggregateValue: 10 },
- { groupByDimensionValues: [false], aggregateValue: 5 },
- ]);
-
- const result = await service.getPieChartData({
- workspaceId,
- objectMetadataId,
- configuration: {
- configurationType: WidgetConfigurationType.PIE_CHART,
- groupByFieldMetadataId: booleanField.id,
- aggregateFieldMetadataId: mockAggregateField.id,
- aggregateOperation: AggregateOperations.COUNT,
- } as any,
- authContext: mockAuthContext,
- });
-
- expect(result.data[0].key).toBe('Yes');
- expect(result.data[1].key).toBe('No');
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/emailing/services/__tests__/campaign-variable.service.spec.ts b/packages/twenty-server/src/modules/emailing/services/__tests__/campaign-variable.service.spec.ts
deleted file mode 100644
index ef54995364c..00000000000
--- a/packages/twenty-server/src/modules/emailing/services/__tests__/campaign-variable.service.spec.ts
+++ /dev/null
@@ -1,168 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS } from 'twenty-shared/metadata';
-import { FieldMetadataType } from 'twenty-shared/types';
-
-import { EmailingDomainException } from 'src/engine/core-modules/emailing-domain/exceptions/emailing-domain.exception';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { CampaignVariableService } from 'src/modules/emailing/services/campaign-variable.service';
-import { type PersonWorkspaceEntity } from 'src/modules/person/standard-objects/person.workspace-entity';
-
-const field = (
- id: string,
- name: string,
- label: string,
- type: FieldMetadataType,
- overrides: Record<string, unknown> = {},
-) => ({
- id,
- universalIdentifier: `universal-${id}`,
- name,
- label,
- type,
- isSystem: false,
- isActive: true,
- ...overrides,
-});
-
-const personFields = [
- field('field-1', 'name', 'Name', FieldMetadataType.FULL_NAME),
- field('field-2', 'emails', 'Emails', FieldMetadataType.EMAILS),
- field('field-3', 'city', 'City', FieldMetadataType.TEXT),
- field('field-4', 'tier', 'Tier', FieldMetadataType.SELECT, {
- options: [
- { value: 'ENTERPRISE', label: 'Enterprise' },
- { value: 'STARTER', label: 'Starter' },
- ],
- }),
- field('field-5', 'signupDate', 'Signup date', FieldMetadataType.DATE_TIME),
- field('field-6', 'searchVector', 'Search vector', FieldMetadataType.TEXT, {
- isSystem: true,
- }),
- field('field-7', 'company', 'Company', FieldMetadataType.RELATION),
-];
-
-const buildFlatMaps = () => ({
- flatObjectMetadataMaps: {
- byUniversalIdentifier: {
- [STANDARD_OBJECT_UNIVERSAL_IDENTIFIERS.person]: {
- id: 'person-object-id',
- nameSingular: 'person',
- fieldIds: personFields.map((personField) => personField.id),
- },
- },
- },
- flatFieldMetadataMaps: {
- byUniversalIdentifier: Object.fromEntries(
- personFields.map((personField) => [
- personField.universalIdentifier,
- personField,
- ]),
- ),
- universalIdentifierById: Object.fromEntries(
- personFields.map((personField) => [
- personField.id,
- personField.universalIdentifier,
- ]),
- ),
- },
-});
-
-describe('CampaignVariableService', () => {
- let service: CampaignVariableService;
-
- const workspaceId = 'workspace-1';
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- CampaignVariableService,
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- getOrRecomputeManyOrAllFlatEntityMaps: jest
- .fn()
- .mockResolvedValue(buildFlatMaps()),
- },
- },
- ],
- }).compile();
-
- service = module.get(CampaignVariableService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('should derive variables from person field metadata', async () => {
- const { definitions, knownVariableNames } =
- await service.getPersonCampaignVariables(workspaceId);
-
- expect(definitions.map((definition) => definition.name)).toEqual([
- 'name.firstName',
- 'name.lastName',
- 'city',
- 'tier',
- 'signupDate',
- ]);
-
- expect(knownVariableNames.has('fullName')).toBe(true);
- expect(knownVariableNames.has('personId')).toBe(true);
-
- expect(knownVariableNames.has('firstName')).toBe(false);
-
- expect(knownVariableNames.has('searchVector')).toBe(false);
- expect(knownVariableNames.has('company')).toBe(false);
- });
-
- it('should build values for a person, formatting by field type', async () => {
- const person = {
- id: 'person-1',
- name: { firstName: 'Ada', lastName: 'Lovelace' },
- emails: { primaryEmail: '[email protected]' },
- city: 'London',
- tier: 'ENTERPRISE',
- signupDate: '2026-03-04T10:30:00.000Z',
- } as unknown as PersonWorkspaceEntity;
-
- const variables = await service.buildVariablesForPerson(
- workspaceId,
- person,
- );
-
- expect(variables).toMatchObject({
- 'name.firstName': 'Ada',
- 'name.lastName': 'Lovelace',
- city: 'London',
- tier: 'Enterprise',
- signupDate: '2026-03-04',
- fullName: 'Ada Lovelace',
- personId: 'person-1',
- });
-
- expect(variables).not.toHaveProperty('firstName');
- });
-
- it('should resolve every variable to an empty string without a person', async () => {
- const variables = await service.buildVariablesForPerson(workspaceId, null);
-
- expect(variables.city).toBe('');
- expect(variables.fullName).toBe('');
- expect(variables.personId).toBe('');
- });
-
- it('should accept known variables and reject unknown ones', async () => {
- await expect(
- service.assertKnownVariables(workspaceId, ['city', 'name.firstName']),
- ).resolves.toBeUndefined();
-
- await expect(
- service.assertKnownVariables(workspaceId, ['city', 'firstNam']),
- ).rejects.toThrow(EmailingDomainException);
-
- await expect(
- service.assertKnownVariables(workspaceId, ['firstNam']),
- ).rejects.toThrow(/Unknown campaign variables: firstNam/);
- });
-});
diff --git a/packages/twenty-server/src/modules/emailing/services/__tests__/message-campaign-draft.service.spec.ts b/packages/twenty-server/src/modules/emailing/services/__tests__/message-campaign-draft.service.spec.ts
deleted file mode 100644
index 860c8f4cb83..00000000000
--- a/packages/twenty-server/src/modules/emailing/services/__tests__/message-campaign-draft.service.spec.ts
+++ /dev/null
@@ -1,297 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { MessageCampaignStatus } from 'twenty-shared/types';
-
-import {
- EmailingDomainException,
- EmailingDomainExceptionCode,
-} from 'src/engine/core-modules/emailing-domain/exceptions/emailing-domain.exception';
-import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { CampaignVariableService } from 'src/modules/emailing/services/campaign-variable.service';
-import { MessageCampaignDraftService } from 'src/modules/emailing/services/message-campaign-draft.service';
-
-describe('MessageCampaignDraftService', () => {
- let service: MessageCampaignDraftService;
- let assertKnownVariables: jest.Mock;
- let campaignRepository: {
- findOne: jest.Mock;
- insert: jest.Mock;
- update: jest.Mock;
- };
-
- const workspaceId = 'workspace-1';
- const userWorkspaceId = 'user-workspace-1';
- const campaignId = '20202020-0000-4000-8000-000000000001';
-
- const validDocument = {
- type: 'doc',
- content: [
- {
- type: 'paragraph',
- content: [
- { type: 'text', text: 'Hello ' },
- { type: 'variableTag', attrs: { variable: '{{firstName}}' } },
- ],
- },
- ],
- };
-
- beforeEach(async () => {
- assertKnownVariables = jest.fn().mockResolvedValue(undefined);
- campaignRepository = {
- findOne: jest.fn().mockResolvedValue({
- id: campaignId,
- name: 'Monthly newsletter',
- status: MessageCampaignStatus.DRAFT,
- }),
- insert: jest.fn().mockResolvedValue(undefined),
- update: jest.fn().mockResolvedValue({ affected: 1 }),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- MessageCampaignDraftService,
- {
- provide: CampaignVariableService,
- useValue: { assertKnownVariables },
- },
- {
- provide: UserRoleService,
- useValue: {
- getRoleIdForUserWorkspace: jest.fn().mockResolvedValue('role-1'),
- },
- },
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getRepository: jest.fn().mockResolvedValue(campaignRepository),
- executeInWorkspaceContext: jest.fn(
- (callback: () => Promise<unknown>) => callback(),
- ),
- },
- },
- ],
- }).compile();
-
- service = module.get(MessageCampaignDraftService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('creating', () => {
- it('should insert a draft with name, subject and stamped body', async () => {
- const result = await service.saveDraft({
- workspaceId,
- userWorkspaceId,
- name: 'Launch announcement',
- subject: 'Hi {{firstName}}, we launched',
- body: validDocument,
- });
-
- expect(result.created).toBe(true);
- expect(result.campaignName).toBe('Launch announcement');
- expect(result.variablesUsed).toEqual(['firstName']);
-
- const [inserted] = campaignRepository.insert.mock.calls[0];
-
- expect(inserted.name).toBe('Launch announcement');
- expect(inserted.subject).toBe('Hi {{firstName}}, we launched');
- expect(inserted.status).toBe(MessageCampaignStatus.DRAFT);
-
- const storedDocument = JSON.parse(inserted.bodyTemplate);
-
- expect(storedDocument.attrs.schemaVersion).toBe(1);
- expect(storedDocument.attrs.canvasTheme).toBeDefined();
- expect(campaignRepository.update).not.toHaveBeenCalled();
- });
-
- it('should create an empty draft with a default name', async () => {
- const result = await service.saveDraft({ workspaceId, userWorkspaceId });
-
- expect(result.created).toBe(true);
- expect(result.campaignName).toBe('Untitled campaign');
-
- const [inserted] = campaignRepository.insert.mock.calls[0];
-
- expect(inserted.subject).toBeUndefined();
- expect(inserted.bodyTemplate).toBeUndefined();
- expect(assertKnownVariables).not.toHaveBeenCalled();
- });
-
- it('should validate subject variables on create', async () => {
- assertKnownVariables.mockRejectedValue(
- new EmailingDomainException(
- 'Unknown campaign variables: frstName',
- EmailingDomainExceptionCode.MESSAGE_CAMPAIGN_NOT_SENDABLE,
- ),
- );
-
- await expect(
- service.saveDraft({
- workspaceId,
- userWorkspaceId,
- subject: 'Hi {{frstName}}',
- }),
- ).rejects.toThrow(/Unknown campaign variables/);
-
- expect(campaignRepository.insert).not.toHaveBeenCalled();
- });
- });
-
- describe('editing', () => {
- it('should update only the provided fields', async () => {
- const result = await service.saveDraft({
- workspaceId,
- userWorkspaceId,
- campaignId,
- subject: 'New subject',
- });
-
- expect(result.created).toBe(false);
- expect(result.campaignName).toBe('Monthly newsletter');
-
- const [criteria, update] = campaignRepository.update.mock.calls[0];
-
- expect(criteria).toEqual({
- id: campaignId,
- status: MessageCampaignStatus.DRAFT,
- });
- expect(update).toEqual({ subject: 'New subject' });
- });
-
- it('should stamp and write a body update', async () => {
- await service.saveDraft({
- workspaceId,
- userWorkspaceId,
- campaignId,
- body: validDocument,
- });
-
- const [, update] = campaignRepository.update.mock.calls[0];
- const storedDocument = JSON.parse(update.bodyTemplate);
-
- expect(storedDocument.attrs.schemaVersion).toBe(1);
- expect(storedDocument.attrs.canvasTheme).toBeDefined();
- });
-
- it('should keep an explicit theme instead of stamping defaults', async () => {
- await service.saveDraft({
- workspaceId,
- userWorkspaceId,
- campaignId,
- body: {
- ...validDocument,
- attrs: { canvasTheme: { bodyBackground: '#101010', width: '480px' } },
- },
- });
-
- const [, update] = campaignRepository.update.mock.calls[0];
- const storedDocument = JSON.parse(update.bodyTemplate);
-
- expect(storedDocument.attrs.canvasTheme.bodyBackground).toBe('#101010');
- });
-
- it('should reject an edit with nothing to update', async () => {
- await expect(
- service.saveDraft({ workspaceId, userWorkspaceId, campaignId }),
- ).rejects.toThrow(/Nothing to update/);
-
- expect(campaignRepository.update).not.toHaveBeenCalled();
- });
-
- it('should reject a document with an unknown block type without writing', async () => {
- await expect(
- service.saveDraft({
- workspaceId,
- userWorkspaceId,
- campaignId,
- body: {
- type: 'doc',
- content: [{ type: 'countdownTimer', attrs: {} }],
- },
- }),
- ).rejects.toThrow(EmailingDomainException);
-
- expect(campaignRepository.update).not.toHaveBeenCalled();
- });
-
- it('should reject unknown variables without writing', async () => {
- assertKnownVariables.mockRejectedValue(
- new EmailingDomainException(
- 'Unknown campaign variables: firstNam',
- EmailingDomainExceptionCode.MESSAGE_CAMPAIGN_NOT_SENDABLE,
- ),
- );
-
- await expect(
- service.saveDraft({
- workspaceId,
- userWorkspaceId,
- campaignId,
- body: {
- type: 'doc',
- content: [
- {
- type: 'paragraph',
- content: [{ type: 'text', text: 'Hi {{firstNam}}' }],
- },
- ],
- },
- }),
- ).rejects.toThrow(/Unknown campaign variables: firstNam/);
-
- expect(assertKnownVariables).toHaveBeenCalledWith(workspaceId, [
- 'firstNam',
- ]);
- expect(campaignRepository.update).not.toHaveBeenCalled();
- });
-
- it('should reject when the campaign does not exist', async () => {
- campaignRepository.findOne.mockResolvedValue(null);
-
- await expect(
- service.saveDraft({
- workspaceId,
- userWorkspaceId,
- campaignId,
- subject: 'New subject',
- }),
- ).rejects.toThrow(/not found/);
- });
-
- it('should reject when the campaign already left DRAFT', async () => {
- campaignRepository.findOne.mockResolvedValue({
- id: campaignId,
- name: 'Monthly newsletter',
- status: MessageCampaignStatus.SENT,
- });
-
- await expect(
- service.saveDraft({
- workspaceId,
- userWorkspaceId,
- campaignId,
- subject: 'New subject',
- }),
- ).rejects.toThrow(/only draft campaigns/);
-
- expect(campaignRepository.update).not.toHaveBeenCalled();
- });
-
- it('should surface a lost race against a concurrent send', async () => {
- campaignRepository.update.mockResolvedValue({ affected: 0 });
-
- await expect(
- service.saveDraft({
- workspaceId,
- userWorkspaceId,
- campaignId,
- subject: 'New subject',
- }),
- ).rejects.toThrow(/no longer an editable draft/);
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging-webhooks/services/__tests__/ses-outbound-sending-state-handler.service.spec.ts b/packages/twenty-server/src/modules/messaging-webhooks/services/__tests__/ses-outbound-sending-state-handler.service.spec.ts
deleted file mode 100644
index 079fb7d83d8..00000000000
--- a/packages/twenty-server/src/modules/messaging-webhooks/services/__tests__/ses-outbound-sending-state-handler.service.spec.ts
+++ /dev/null
@@ -1,84 +0,0 @@
-import { EmailingDomainTenantStatus } from 'src/engine/core-modules/emailing-domain/drivers/types/emailing-domain-tenant-status.type';
-import { type EmailingDomainTenantStatusService } from 'src/engine/core-modules/emailing-domain/services/emailing-domain-tenant-status.service';
-import { SesOutboundSendingStateHandlerService } from 'src/modules/messaging-webhooks/services/ses-outbound-sending-state-handler.service';
-import { type SesEventBridgeNotification } from 'src/modules/messaging-webhooks/types/ses-event-bridge-notification.type';
-
-describe('SesOutboundSendingStateHandlerService.handle', () => {
- const setUp = () => {
- const emailingDomainTenantStatusService = {
- setTenantStatusForWorkspace: jest.fn().mockResolvedValue(undefined),
- } as unknown as EmailingDomainTenantStatusService;
- const service = new SesOutboundSendingStateHandlerService(
- emailingDomainTenantStatusService,
- );
-
- return { service, emailingDomainTenantStatusService };
- };
-
- // SES emits `Sending Status Enabled|Disabled` against three resource scopes
- // (tenant / configuration-set / identity). The handler must mirror the
- // status onto the workspace's DB column regardless of which scope produced
- // the event, since every twenty-managed resource shares the same prefix.
- describe.each([
- {
- scope: 'tenant ARN with opaque tenant-id segment',
- arn: 'arn:aws:ses:us-east-1:123456789012:tenant/twenty-workspace-ws1/9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d',
- },
- {
- scope: 'configuration-set ARN',
- arn: 'arn:aws:ses:us-east-1:123456789012:configuration-set/twenty-workspace-ws1',
- },
- {
- scope: 'identity ARN',
- arn: 'arn:aws:ses:us-east-1:123456789012:identity/twenty-workspace-ws1',
- },
- ])('on a $scope', ({ arn }) => {
- it.each([
- {
- detailType: 'Sending Status Disabled' as const,
- expected: EmailingDomainTenantStatus.PAUSED,
- },
- {
- detailType: 'Sending Status Enabled' as const,
- expected: EmailingDomainTenantStatus.ACTIVE,
- },
- ])(
- 'mirrors "$detailType" to tenantStatus=$expected',
- async ({ detailType, expected }) => {
- const { service, emailingDomainTenantStatusService } = setUp();
-
- const event: SesEventBridgeNotification = {
- source: 'aws.ses',
- 'detail-type': detailType,
- resources: [arn],
- };
-
- await service.handle(event);
-
- expect(
- emailingDomainTenantStatusService.setTenantStatusForWorkspace,
- ).toHaveBeenCalledWith('ws1', expected);
- },
- );
- });
-
- // Security-critical: a foreign SES resource that lands on the shared SNS
- // topic must not be allowed to flip our tenantStatus column. The
- // workspaceId resolver returns null for any ARN that doesn't carry the
- // twenty-managed name prefix; the handler must noop in that case.
- it('does not update any workspace when the ARN does not carry the twenty-managed prefix', async () => {
- const { service, emailingDomainTenantStatusService } = setUp();
-
- await service.handle({
- source: 'aws.ses',
- 'detail-type': 'Sending Status Disabled',
- resources: [
- 'arn:aws:ses:us-east-1:123456789012:tenant/some-other-prefix/abc',
- ],
- });
-
- expect(
- emailingDomainTenantStatusService.setTenantStatusForWorkspace,
- ).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/common/query-hooks/message/apply-messages-visibility-restrictions.service.spec.ts b/packages/twenty-server/src/modules/messaging/common/query-hooks/message/apply-messages-visibility-restrictions.service.spec.ts
deleted file mode 100644
index dc5358f7a44..00000000000
--- a/packages/twenty-server/src/modules/messaging/common/query-hooks/message/apply-messages-visibility-restrictions.service.spec.ts
+++ /dev/null
@@ -1,415 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED } from 'twenty-shared/constants';
-
-import { MessageChannelVisibility } from 'twenty-shared/types';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { MessageChannelEntity } from 'src/engine/metadata-modules/message-channel/entities/message-channel.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type MessageWorkspaceEntity } from 'src/modules/messaging/common/standard-objects/message.workspace-entity';
-
-import { ApplyMessagesVisibilityRestrictionsService } from './apply-messages-visibility-restrictions.service';
-
-const createMockMessage = (
- id: string,
- subject: string,
- text: string,
-): MessageWorkspaceEntity => ({
- id,
- subject,
- text,
- headerMessageId: '',
- receivedAt: new Date('2024-03-20T10:00:00Z'),
- messageThreadId: '',
- messageThread: null,
- messageChannelMessageAssociations: [],
- messageParticipants: [],
- messageCampaign: null,
- messageCampaignId: null,
- deliveryStatus: null,
- isDraft: false,
- deletedAt: null,
- createdAt: '2024-03-20T09:00:00Z',
- updatedAt: '2024-03-20T09:00:00Z',
-});
-
-describe('ApplyMessagesVisibilityRestrictionsService', () => {
- let service: ApplyMessagesVisibilityRestrictionsService;
-
- const mockMessageChannelMessageAssociationRepository = {
- find: jest.fn(),
- };
-
- const mockWorkspaceMemberRepository = {
- findOneByOrFail: jest.fn(),
- };
-
- const mockConnectedAccountRepository = {
- find: jest.fn(),
- };
-
- const mockUserWorkspaceRepository = {
- findOne: jest.fn(),
- };
-
- const mockMessageChannelRepository = {
- find: jest.fn(),
- };
-
- const mockGlobalWorkspaceOrmManager = {
- getRepository: jest.fn().mockImplementation((workspaceId, name) => {
- if (name === 'messageChannelMessageAssociation') {
- return mockMessageChannelMessageAssociationRepository;
- }
- if (name === 'workspaceMember') {
- return mockWorkspaceMemberRepository;
- }
- }),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ApplyMessagesVisibilityRestrictionsService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: mockGlobalWorkspaceOrmManager,
- },
- {
- provide: getRepositoryToken(ConnectedAccountEntity),
- useValue: mockConnectedAccountRepository,
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: mockUserWorkspaceRepository,
- },
- {
- provide: getRepositoryToken(MessageChannelEntity),
- useValue: mockMessageChannelRepository,
- },
- ],
- }).compile();
-
- service = module.get<ApplyMessagesVisibilityRestrictionsService>(
- ApplyMessagesVisibilityRestrictionsService,
- );
-
- jest.clearAllMocks();
- });
-
- it('should return message without obfuscated subject and text if the visibility is SHARE_EVERYTHING', async () => {
- const messages = [
- createMockMessage('messageId', 'Test Subject', 'Test Message'),
- ];
-
- mockMessageChannelMessageAssociationRepository.find.mockResolvedValue([
- {
- messageId: 'messageId',
- messageChannelId: 'messageChannelId',
- },
- ]);
-
- mockMessageChannelRepository.find.mockResolvedValue([
- {
- id: 'messageChannelId',
- visibility: MessageChannelVisibility.SHARE_EVERYTHING,
- },
- ]);
-
- const result = await service.applyMessagesVisibilityRestrictions(
- messages,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual(messages);
- expect(
- result.every(
- (item) =>
- item.subject === 'Test Subject' && item.text === 'Test Message',
- ),
- ).toBe(true);
- expect(mockConnectedAccountRepository.find).not.toHaveBeenCalled();
- });
-
- it('should return message without obfuscated subject and with obfuscated text if the visibility is SUBJECT', async () => {
- const messages = [
- createMockMessage('messageId', 'Test Subject', 'Test Message'),
- ];
-
- mockMessageChannelMessageAssociationRepository.find.mockResolvedValue([
- {
- messageId: 'messageId',
- messageChannelId: 'messageChannelId',
- },
- ]);
-
- mockMessageChannelRepository.find.mockResolvedValue([
- {
- id: 'messageChannelId',
- visibility: MessageChannelVisibility.SUBJECT,
- },
- ]);
-
- mockConnectedAccountRepository.find.mockResolvedValue([]);
-
- mockWorkspaceMemberRepository.findOneByOrFail.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
-
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- const result = await service.applyMessagesVisibilityRestrictions(
- messages,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual([
- {
- ...messages[0],
- text: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- ]);
- });
-
- it('should return message with obfuscated subject and text if the visibility is METADATA', async () => {
- const messages = [
- createMockMessage('messageId', 'Test Subject', 'Test Message'),
- ];
-
- mockMessageChannelMessageAssociationRepository.find.mockResolvedValue([
- {
- messageId: 'messageId',
- messageChannelId: 'messageChannelId',
- },
- ]);
-
- mockMessageChannelRepository.find.mockResolvedValue([
- {
- id: 'messageChannelId',
- visibility: MessageChannelVisibility.METADATA,
- },
- ]);
-
- mockConnectedAccountRepository.find.mockResolvedValue([]);
-
- mockWorkspaceMemberRepository.findOneByOrFail.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
-
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- const result = await service.applyMessagesVisibilityRestrictions(
- messages,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual([
- {
- ...messages[0],
- subject: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- text: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- ]);
- });
-
- it('should return message without obfuscated subject and text if the visibility is METADATA and the workspace member is the channel owner', async () => {
- const messages = [
- createMockMessage('messageId', 'Test Subject', 'Test Message'),
- ];
-
- mockMessageChannelMessageAssociationRepository.find.mockResolvedValue([
- {
- messageId: 'messageId',
- messageChannelId: 'messageChannelId',
- },
- ]);
-
- mockMessageChannelRepository.find.mockResolvedValue([
- {
- id: 'messageChannelId',
- visibility: MessageChannelVisibility.METADATA,
- },
- ]);
-
- mockWorkspaceMemberRepository.findOneByOrFail.mockResolvedValue({
- id: 'workspace-member-account-owner-id',
- userId: 'user-id',
- });
-
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- mockConnectedAccountRepository.find.mockResolvedValue([{ id: '1' }]);
-
- const result = await service.applyMessagesVisibilityRestrictions(
- messages,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual(messages);
- expect(
- result.every(
- (item) =>
- item.subject === 'Test Subject' && item.text === 'Test Message',
- ),
- ).toBe(true);
- });
-
- it('should not return message if visibility is not SHARE_EVERYTHING, SUBJECT or METADATA and the workspace member is not the channel owner', async () => {
- const messages = [
- createMockMessage('messageId', 'Test Subject', 'Test Message'),
- ];
-
- mockMessageChannelMessageAssociationRepository.find.mockResolvedValue([
- {
- messageId: 'messageId',
- messageChannelId: 'messageChannelId',
- },
- ]);
-
- mockMessageChannelRepository.find.mockResolvedValue([
- {
- id: 'messageChannelId',
- },
- ]);
-
- mockWorkspaceMemberRepository.findOneByOrFail.mockResolvedValue({
- id: 'workspace-member-not-account-owner-id',
- userId: 'user-id',
- });
-
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- mockConnectedAccountRepository.find.mockResolvedValue([]);
-
- const result = await service.applyMessagesVisibilityRestrictions(
- messages,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual([]);
- });
-
- it('should return all messages with the right visibility', async () => {
- const messages = [
- createMockMessage('1', 'Subject 1', 'Message 1'),
- createMockMessage('2', 'Subject 2', 'Message 2'),
- createMockMessage('3', 'Subject 3', 'Message 3'),
- ];
-
- mockMessageChannelMessageAssociationRepository.find.mockResolvedValue([
- { messageId: '1', messageChannelId: '1' },
- { messageId: '2', messageChannelId: '2' },
- { messageId: '3', messageChannelId: '3' },
- ]);
-
- mockMessageChannelRepository.find.mockResolvedValue([
- { id: '1', visibility: MessageChannelVisibility.SHARE_EVERYTHING },
- { id: '2', visibility: MessageChannelVisibility.SUBJECT },
- { id: '3', visibility: MessageChannelVisibility.METADATA },
- ]);
-
- mockWorkspaceMemberRepository.findOneByOrFail.mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- });
-
- mockUserWorkspaceRepository.findOne.mockResolvedValue({
- id: 'user-workspace-id',
- userId: 'user-id',
- });
-
- mockConnectedAccountRepository.find
- .mockResolvedValueOnce([]) // request for message 3
- .mockResolvedValueOnce([]); // request for message 2
-
- const result = await service.applyMessagesVisibilityRestrictions(
- messages,
- 'test-workspace-id',
- 'user-id',
- );
-
- expect(result).toEqual([
- messages[0],
- {
- ...messages[1],
- text: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- {
- ...messages[2],
- subject: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- text: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- ]);
- });
-
- it('should return all messages with the right visibility when userId is undefined (api key request)', async () => {
- const messages = [
- createMockMessage('1', 'Subject 1', 'Message 1'),
- createMockMessage('2', 'Subject 2', 'Message 2'),
- createMockMessage('3', 'Subject 3', 'Message 3'),
- ];
-
- mockMessageChannelMessageAssociationRepository.find.mockResolvedValue([
- { messageId: '1', messageChannelId: '1' },
- { messageId: '2', messageChannelId: '2' },
- { messageId: '3', messageChannelId: '3' },
- ]);
-
- mockMessageChannelRepository.find.mockResolvedValue([
- { id: '1', visibility: MessageChannelVisibility.SHARE_EVERYTHING },
- { id: '2', visibility: MessageChannelVisibility.SUBJECT },
- { id: '3', visibility: MessageChannelVisibility.METADATA },
- ]);
-
- mockWorkspaceMemberRepository.findOneByOrFail.mockResolvedValue({
- id: 'workspace-member-id',
- });
-
- mockConnectedAccountRepository.find
- .mockResolvedValueOnce([]) // request for message 3
- .mockResolvedValueOnce([]); // request for message 2
-
- const result = await service.applyMessagesVisibilityRestrictions(
- messages,
- 'test-workspace-id',
- undefined,
- );
-
- expect(result).toEqual([
- messages[0],
- {
- ...messages[1],
- text: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- {
- ...messages[2],
- subject: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- text: FIELD_RESTRICTED_ADDITIONAL_PERMISSIONS_REQUIRED,
- },
- ]);
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/message-folder-manager/drivers/imap/services/__tests__/imap-get-all-folders.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-folder-manager/drivers/imap/services/__tests__/imap-get-all-folders.service.spec.ts
deleted file mode 100644
index 49de268d761..00000000000
--- a/packages/twenty-server/src/modules/messaging/message-folder-manager/drivers/imap/services/__tests__/imap-get-all-folders.service.spec.ts
+++ /dev/null
@@ -1,236 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { type ImapFlow, type ListResponse } from 'imapflow';
-import {
- ConnectedAccountProvider,
- MessageFolderImportPolicy,
-} from 'twenty-shared/types';
-
-import { type ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { type MessageChannelEntity } from 'src/engine/metadata-modules/message-channel/entities/message-channel.entity';
-import { ImapGetAllFoldersService } from 'src/modules/messaging/message-folder-manager/drivers/imap/services/imap-get-all-folders.service';
-import { ImapClientProvider } from 'src/modules/messaging/message-import-manager/drivers/imap/providers/imap-client.provider';
-import { ImapFindSentFolderService } from 'src/modules/messaging/message-import-manager/drivers/imap/services/imap-find-sent-folder.service';
-
-const createMockMailbox = (
- overrides: Partial<ListResponse> & Pick<ListResponse, 'path'>,
-): ListResponse => ({
- pathAsListed: overrides.path,
- name: overrides.path.split('.').pop() ?? overrides.path,
- delimiter: '.',
- parent: [],
- parentPath: '',
- flags: new Set<string>(),
- listed: true,
- subscribed: true,
- ...overrides,
-});
-
-const CONNECTED_ACCOUNT: Pick<
- ConnectedAccountEntity,
- 'id' | 'provider' | 'connectionParameters' | 'handle' | 'workspaceId'
-> = {
- id: 'account-1',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- connectionParameters: {},
- handle: '[email protected]',
- workspaceId: 'workspace-1',
-};
-
-const MESSAGE_CHANNEL: Pick<MessageChannelEntity, 'messageFolderImportPolicy'> =
- {
- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,
- };
-
-describe('ImapGetAllFoldersService', () => {
- let service: ImapGetAllFoldersService;
- let mockImapClient: jest.Mocked<Pick<ImapFlow, 'list' | 'status'>>;
- let imapFindSentFolderService: jest.Mocked<ImapFindSentFolderService>;
-
- beforeEach(async () => {
- mockImapClient = {
- list: jest.fn().mockResolvedValue([]),
- status: jest.fn(),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ImapGetAllFoldersService,
- {
- provide: ImapClientProvider,
- useValue: {
- getClient: jest.fn().mockResolvedValue(mockImapClient),
- closeClient: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: ImapFindSentFolderService,
- useValue: {
- findSentFolder: jest.fn().mockResolvedValue(null),
- },
- },
- ],
- }).compile();
-
- service = module.get(ImapGetAllFoldersService);
- imapFindSentFolderService = module.get(ImapFindSentFolderService);
- });
-
- describe('Noselect folder handling', () => {
- it('should not issue STATUS against a \\Noselect folder', async () => {
- const mailboxList = [
- createMockMailbox({ path: 'INBOX' }),
- createMockMailbox({
- path: 'INBOX.Others',
- flags: new Set(['\\Noselect']),
- }),
- createMockMailbox({
- path: 'INBOX.Others.Sub1',
- name: 'Sub1',
- parentPath: 'INBOX.Others',
- }),
- ];
-
- mockImapClient.list.mockResolvedValue(mailboxList);
- mockImapClient.status.mockImplementation(async (path: string) => {
- const uidMap: Record<string, bigint> = {
- INBOX: BigInt(1),
- 'INBOX.Others.Sub1': BigInt(2),
- };
-
- if (path in uidMap) {
- return { uidValidity: uidMap[path] } as any;
- }
- throw new Error(`Mailbox doesn't exist: ${path}`);
- });
-
- const result = await service.getAllMessageFolders(
- CONNECTED_ACCOUNT,
- MESSAGE_CHANNEL,
- );
-
- expect(mockImapClient.status).not.toHaveBeenCalledWith(
- 'INBOX.Others',
- expect.anything(),
- );
-
- const paths = result.map((f) => f.externalId?.split(':')[0]);
-
- expect(paths).toContain('INBOX');
- expect(paths).toContain('INBOX.Others.Sub1');
- expect(paths).not.toContain('INBOX.Others');
- });
-
- it('should preserve parent references for children of \\Noselect folders', async () => {
- const mailboxList = [
- createMockMailbox({
- path: 'INBOX.Others',
- flags: new Set(['\\Noselect']),
- }),
- createMockMailbox({
- path: 'INBOX.Others.Sub1',
- name: 'Sub1',
- parentPath: 'INBOX.Others',
- }),
- createMockMailbox({
- path: 'INBOX.Others.Sub2',
- name: 'Sub2',
- parentPath: 'INBOX.Others',
- }),
- ];
-
- mockImapClient.list.mockResolvedValue(mailboxList);
- mockImapClient.status.mockImplementation(async (path: string) => {
- const uidMap: Record<string, bigint> = {
- 'INBOX.Others.Sub1': BigInt(10),
- 'INBOX.Others.Sub2': BigInt(11),
- };
-
- return { uidValidity: uidMap[path] } as any;
- });
-
- const result = await service.getAllMessageFolders(
- CONNECTED_ACCOUNT,
- MESSAGE_CHANNEL,
- );
-
- expect(result).toHaveLength(2);
-
- for (const folder of result) {
- expect(folder.parentFolderId).toBe('INBOX.Others');
- }
- });
-
- it('should exclude \\Noselect sent folder from results and skip STATUS', async () => {
- const mailboxList = [
- createMockMailbox({ path: 'INBOX' }),
- createMockMailbox({
- path: 'Sent',
- flags: new Set(['\\Noselect']),
- }),
- ];
-
- mockImapClient.list.mockResolvedValue(mailboxList);
- mockImapClient.status.mockImplementation(async () => {
- return { uidValidity: BigInt(1) } as any;
- });
-
- imapFindSentFolderService.findSentFolder.mockResolvedValue({
- path: 'Sent',
- name: 'Sent',
- });
-
- const result = await service.getAllMessageFolders(
- CONNECTED_ACCOUNT,
- MESSAGE_CHANNEL,
- );
-
- expect(mockImapClient.status).not.toHaveBeenCalledWith(
- 'Sent',
- expect.anything(),
- );
- expect(result.find((f) => f.isSentFolder)).toBeUndefined();
- });
-
- it.each([['\\Noselect'], ['\\NoSelect'], ['\\NOSELECT'], ['\\noselect']])(
- 'should treat %s as non-selectable (RFC 3501 attribute names are case-insensitive)',
- async (flagSpelling) => {
- const mailboxList = [
- createMockMailbox({ path: 'INBOX' }),
- createMockMailbox({
- path: 'Shared Folders',
- flags: new Set([flagSpelling]),
- }),
- createMockMailbox({
- path: 'Shared Folders/team/INBOX',
- name: 'INBOX',
- parentPath: 'Shared Folders/team',
- }),
- ];
-
- mockImapClient.list.mockResolvedValue(mailboxList);
- mockImapClient.status.mockImplementation(async (path: string) => {
- if (path === 'Shared Folders') {
- throw new Error(`Mailbox doesn't exist: ${path}`);
- }
-
- return { uidValidity: BigInt(1) } as any;
- });
-
- const result = await service.getAllMessageFolders(
- CONNECTED_ACCOUNT,
- MESSAGE_CHANNEL,
- );
-
- expect(mockImapClient.status).not.toHaveBeenCalledWith(
- 'Shared Folders',
- expect.anything(),
- );
-
- const paths = result.map((f) => f.externalId?.split(':')[0]);
-
- expect(paths).not.toContain('Shared Folders');
- },
- );
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/imap/services/imap-get-message-list.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/imap/services/imap-get-message-list.service.spec.ts
deleted file mode 100644
index 2924d3e6f22..00000000000
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/imap/services/imap-get-message-list.service.spec.ts
+++ /dev/null
@@ -1,277 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import {
- ConnectedAccountProvider,
- MessageFolderImportPolicy,
- MessageFolderPendingSyncAction,
-} from 'twenty-shared/types';
-
-import { type MessageFolder } from 'src/modules/messaging/message-folder-manager/interfaces/message-folder-driver.interface';
-
-import { type EncryptedString } from 'src/engine/core-modules/secret-encryption/branded-strings/encrypted-string.type';
-import { type ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { ImapClientProvider } from 'src/modules/messaging/message-import-manager/drivers/imap/providers/imap-client.provider';
-import { ImapGetMessageListService } from 'src/modules/messaging/message-import-manager/drivers/imap/services/imap-get-message-list.service';
-import { ImapMessageListFetchErrorHandler } from 'src/modules/messaging/message-import-manager/drivers/imap/services/imap-message-list-fetch-error-handler.service';
-import { ImapSyncService } from 'src/modules/messaging/message-import-manager/drivers/imap/services/imap-sync.service';
-
-const createMockFolder = (
- overrides: Partial<MessageFolder> &
- Pick<MessageFolder, 'name' | 'externalId' | 'isSynced'>,
-): MessageFolder => ({
- id: `folder-${overrides.externalId}`,
- syncCursor: null,
- isSentFolder: false,
- parentFolderId: null,
- pendingSyncAction: MessageFolderPendingSyncAction.NONE,
- ...overrides,
-});
-
-describe('ImapGetMessageListService', () => {
- let service: ImapGetMessageListService;
- let imapClientProvider: ImapClientProvider;
- let imapSyncService: ImapSyncService;
-
- const mockConnectedAccount: Pick<
- ConnectedAccountEntity,
- | 'provider'
- | 'accessToken'
- | 'refreshToken'
- | 'id'
- | 'handle'
- | 'connectionParameters'
- | 'workspaceId'
- > = {
- id: 'connected-account-id',
- provider: ConnectedAccountProvider.IMAP_SMTP_CALDAV,
- accessToken: 'access-token' as EncryptedString,
- refreshToken: 'refresh-token' as EncryptedString,
- handle: '[email protected]',
- connectionParameters: {},
- workspaceId: 'workspace-id',
- };
-
- const mockImapClient = {
- getMailboxLock: jest.fn().mockResolvedValue({ release: jest.fn() }),
- mailbox: {
- uidValidity: 12345,
- uidNext: 100,
- highestModseq: '1000',
- },
- capabilities: new Set(['CONDSTORE']),
- status: jest.fn().mockResolvedValue({
- uidValidity: 12345,
- uidNext: 100,
- highestModseq: '1000',
- }),
- };
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ImapGetMessageListService,
- {
- provide: ImapClientProvider,
- useValue: {
- getClient: jest.fn().mockResolvedValue(mockImapClient),
- closeClient: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: ImapSyncService,
- useValue: {
- syncFolder: jest.fn().mockResolvedValue({ messageUids: [1, 2, 3] }),
- },
- },
- {
- provide: ImapMessageListFetchErrorHandler,
- useValue: {
- handleError: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<ImapGetMessageListService>(ImapGetMessageListService);
- imapClientProvider = module.get<ImapClientProvider>(ImapClientProvider);
- imapSyncService = module.get<ImapSyncService>(ImapSyncService);
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('folder filtering based on import policy', () => {
- it('should only process synced folders when SELECTED_FOLDERS policy is set', async () => {
- const syncedFolder = createMockFolder({
- name: 'INBOX',
- externalId: 'INBOX:1',
- isSynced: true,
- });
-
- const nonSyncedFolder = createMockFolder({
- name: 'Personal',
- externalId: 'Personal:1',
- isSynced: false,
- });
-
- const result = await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.SELECTED_FOLDERS,
- },
- messageFolders: [syncedFolder, nonSyncedFolder],
- });
-
- expect(result).toHaveLength(1);
- expect(result[0].folderId).toBe(syncedFolder.id);
- });
-
- it('should process all folders when ALL_FOLDERS policy is set', async () => {
- const syncedFolder = createMockFolder({
- name: 'INBOX',
- externalId: 'INBOX:1',
- isSynced: true,
- });
-
- const nonSyncedFolder = createMockFolder({
- name: 'Personal',
- externalId: 'Personal:1',
- isSynced: false,
- });
-
- const result = await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,
- },
- messageFolders: [syncedFolder, nonSyncedFolder],
- });
-
- expect(result).toHaveLength(2);
- expect(result.map((r) => r.folderId)).toEqual([
- syncedFolder.id,
- nonSyncedFolder.id,
- ]);
- });
-
- it('should return empty array when SELECTED_FOLDERS policy and no folders are synced', async () => {
- const nonSyncedFolder1 = createMockFolder({
- name: 'Personal',
- externalId: 'Personal:1',
- isSynced: false,
- });
-
- const nonSyncedFolder2 = createMockFolder({
- name: 'Work',
- externalId: 'Work:1',
- isSynced: false,
- });
-
- const result = await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.SELECTED_FOLDERS,
- },
- messageFolders: [nonSyncedFolder1, nonSyncedFolder2],
- });
-
- expect(result).toHaveLength(0);
- });
-
- it('should process all non-synced folders when ALL_FOLDERS policy is set', async () => {
- const nonSyncedFolder1 = createMockFolder({
- name: 'Personal',
- externalId: 'Personal:1',
- isSynced: false,
- });
-
- const nonSyncedFolder2 = createMockFolder({
- name: 'Work',
- externalId: 'Work:1',
- isSynced: false,
- });
-
- const result = await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,
- },
- messageFolders: [nonSyncedFolder1, nonSyncedFolder2],
- });
-
- expect(result).toHaveLength(2);
- });
-
- it('should always close the IMAP client regardless of policy', async () => {
- const folder = createMockFolder({
- name: 'INBOX',
- externalId: 'INBOX:1',
- isSynced: true,
- });
-
- await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,
- },
- messageFolders: [folder],
- });
-
- expect(imapClientProvider.closeClient).toHaveBeenCalledTimes(1);
- });
- });
-
- describe('incremental sync skip', () => {
- const syncedFolder = createMockFolder({
- name: 'INBOX',
- externalId: 'INBOX:12345',
- isSynced: true,
- syncCursor: JSON.stringify({
- highestUid: 99,
- uidValidity: 12345,
- modSeq: '1000',
- }),
- });
-
- const runSync = () =>
- service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,
- },
- messageFolders: [syncedFolder],
- });
-
- it('skips folders whose cursor already covers the latest UID', async () => {
- const [result] = await runSync();
-
- expect(imapSyncService.syncFolder).not.toHaveBeenCalled();
- expect(result.messageExternalIds).toEqual([]);
- });
-
- it('does not skip when the server omits UIDNEXT on STATUS', async () => {
- mockImapClient.status.mockResolvedValueOnce({
- uidValidity: 12345,
- highestModseq: '1000',
- });
-
- const [result] = await runSync();
-
- expect(imapSyncService.syncFolder).toHaveBeenCalledTimes(1);
- expect(result.messageExternalIds).not.toEqual([]);
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-message-list.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-message-list.service.spec.ts
deleted file mode 100644
index 6a1b35a753c..00000000000
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-message-list.service.spec.ts
+++ /dev/null
@@ -1,236 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import {
- ConnectedAccountProvider,
- MessageFolderImportPolicy,
- MessageFolderPendingSyncAction,
-} from 'twenty-shared/types';
-
-import { type MessageFolder } from 'src/modules/messaging/message-folder-manager/interfaces/message-folder-driver.interface';
-
-import { MicrosoftOAuth2ClientProvider } from 'src/modules/connected-account/oauth2-client-manager/drivers/microsoft/microsoft-oauth2-client.provider';
-import { type ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { MicrosoftGetMessageListService } from 'src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-message-list.service';
-import { MicrosoftMessageListFetchErrorHandler } from 'src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-message-list-fetch-error-handler.service';
-
-const createMockFolder = (
- overrides: Partial<MessageFolder> &
- Pick<MessageFolder, 'name' | 'externalId' | 'isSynced'>,
-): MessageFolder => ({
- id: `folder-${overrides.externalId}`,
- syncCursor: null,
- isSentFolder: false,
- parentFolderId: null,
- pendingSyncAction: MessageFolderPendingSyncAction.NONE,
- ...overrides,
-});
-
-describe('MicrosoftGetMessageListService', () => {
- let service: MicrosoftGetMessageListService;
- let microsoftOAuth2ClientProvider: MicrosoftOAuth2ClientProvider;
-
- const mockConnectedAccount: Pick<
- ConnectedAccountEntity,
- 'provider' | 'id' | 'handle'
- > = {
- id: 'connected-account-id',
- provider: ConnectedAccountProvider.MICROSOFT,
- handle: '[email protected]',
- };
-
- const createMockMicrosoftClient = () => ({
- api: jest.fn().mockReturnThis(),
- version: jest.fn().mockReturnThis(),
- headers: jest.fn().mockReturnThis(),
- post: jest
- .fn()
- .mockImplementation((batchRequestBody: { requests: { id: string }[] }) =>
- Promise.resolve({
- responses: batchRequestBody.requests.map((request) => ({
- id: request.id,
- status: 200,
- body: {
- value: [{ id: 'msg-1' }, { id: 'msg-2' }],
- '@odata.deltaLink':
- 'https://graph.microsoft.com/beta/delta?token=abc',
- },
- })),
- }),
- ),
- });
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- MicrosoftGetMessageListService,
- {
- provide: MicrosoftOAuth2ClientProvider,
- useValue: {
- getClient: jest.fn(),
- },
- },
- {
- provide: MicrosoftMessageListFetchErrorHandler,
- useValue: {
- handleError: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get<MicrosoftGetMessageListService>(
- MicrosoftGetMessageListService,
- );
- microsoftOAuth2ClientProvider = module.get<MicrosoftOAuth2ClientProvider>(
- MicrosoftOAuth2ClientProvider,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- describe('folder filtering based on import policy', () => {
- it('should only process synced folders when SELECTED_FOLDERS policy is set', async () => {
- const mockClient = createMockMicrosoftClient();
-
- (microsoftOAuth2ClientProvider.getClient as jest.Mock).mockResolvedValue(
- mockClient,
- );
-
- const syncedFolder = createMockFolder({
- name: 'Inbox',
- externalId: 'inbox-id',
- isSynced: true,
- });
-
- const nonSyncedFolder = createMockFolder({
- name: 'Personal',
- externalId: 'personal-id',
- isSynced: false,
- });
-
- const result = await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.SELECTED_FOLDERS,
- },
- messageFolders: [syncedFolder, nonSyncedFolder],
- });
-
- expect(result).toHaveLength(1);
- expect(result[0].folderId).toBe(syncedFolder.id);
- expect(microsoftOAuth2ClientProvider.getClient).toHaveBeenCalledTimes(1);
- });
-
- it('should process all folders when ALL_FOLDERS policy is set', async () => {
- const mockClient = createMockMicrosoftClient();
-
- (microsoftOAuth2ClientProvider.getClient as jest.Mock).mockResolvedValue(
- mockClient,
- );
-
- const syncedFolder = createMockFolder({
- name: 'Inbox',
- externalId: 'inbox-id',
- isSynced: true,
- });
-
- const nonSyncedFolder = createMockFolder({
- name: 'Personal',
- externalId: 'personal-id',
- isSynced: false,
- });
-
- const result = await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,
- },
- messageFolders: [syncedFolder, nonSyncedFolder],
- });
-
- expect(result).toHaveLength(2);
- expect(result.map((r) => r.folderId)).toEqual([
- syncedFolder.id,
- nonSyncedFolder.id,
- ]);
- });
-
- it('should return empty array when SELECTED_FOLDERS policy and no folders are synced', async () => {
- const nonSyncedFolder1 = createMockFolder({
- name: 'Personal',
- externalId: 'personal-id',
- isSynced: false,
- });
-
- const nonSyncedFolder2 = createMockFolder({
- name: 'Work',
- externalId: 'work-id',
- isSynced: false,
- });
-
- const result = await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.SELECTED_FOLDERS,
- },
- messageFolders: [nonSyncedFolder1, nonSyncedFolder2],
- });
-
- expect(result).toEqual([]);
- });
-
- it('should process all non-synced folders when ALL_FOLDERS policy is set', async () => {
- const mockClient = createMockMicrosoftClient();
-
- (microsoftOAuth2ClientProvider.getClient as jest.Mock).mockResolvedValue(
- mockClient,
- );
-
- const nonSyncedFolder1 = createMockFolder({
- name: 'Personal',
- externalId: 'personal-id',
- isSynced: false,
- });
-
- const nonSyncedFolder2 = createMockFolder({
- name: 'Work',
- externalId: 'work-id',
- isSynced: false,
- });
-
- const result = await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,
- },
- messageFolders: [nonSyncedFolder1, nonSyncedFolder2],
- });
-
- expect(result).toHaveLength(2);
- });
-
- it('should return empty array when ALL_FOLDERS policy but messageFolders array is empty', async () => {
- const result = await service.getMessageLists({
- connectedAccount: mockConnectedAccount,
- messageChannel: {
- syncCursor: '',
- id: 'channel-1',
- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,
- },
- messageFolders: [],
- });
-
- expect(result).toEqual([]);
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.service.spec.ts
deleted file mode 100644
index 4182136620d..00000000000
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.service.spec.ts
+++ /dev/null
@@ -1,203 +0,0 @@
-import { Logger } from '@nestjs/common';
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import {
- ConnectedAccountProvider,
- MessageParticipantRole,
-} from 'twenty-shared/types';
-
-import {
- microsoftGraphBatchWithHtmlMessagesResponse,
- microsoftGraphBatchWithTwoMessagesResponse,
-} from 'src/modules/messaging/message-import-manager/drivers/microsoft/mocks/microsoft-api-examples';
-import { MicrosoftFetchByBatchService } from 'src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-fetch-by-batch.service';
-import { type MicrosoftGraphBatchResponse } from 'src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.interface';
-import { MicrosoftGetMessagesService } from 'src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.service';
-import { MicrosoftMessagesImportErrorHandler } from 'src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-messages-import-error-handler.service';
-
-describe('Microsoft get messages service', () => {
- let service: MicrosoftGetMessagesService;
-
- beforeEach(async () => {
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- MicrosoftGetMessagesService,
- {
- provide: MicrosoftMessagesImportErrorHandler,
- useValue: { handleError: jest.fn() },
- },
- {
- provide: MicrosoftFetchByBatchService,
- useValue: { fetchAllByBatches: jest.fn() },
- },
- {
- provide: Logger,
- useValue: { log: jest.fn(), error: jest.fn() },
- },
- ],
- }).compile();
-
- service = module.get<MicrosoftGetMessagesService>(
- MicrosoftGetMessagesService,
- );
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('Should be defined', () => {
- expect(service).toBeDefined();
- });
-
- it('Should format batch responses as messages', () => {
- const batchResponses: MicrosoftGraphBatchResponse[] =
- microsoftGraphBatchWithTwoMessagesResponse;
- const connectedAccount = {
- id: 'connected-account-id',
- provider: ConnectedAccountProvider.MICROSOFT,
- accessToken: 'access-token',
- refreshToken: 'refresh-token',
- handle: '[email protected]',
- handleAliases: [] as string[],
- workspaceId: 'workspace-id',
- };
- const messages = service.formatBatchResponsesAsMessages(
- batchResponses,
- connectedAccount,
- );
-
- expect(messages).toHaveLength(2);
-
- const responseExample1 =
- microsoftGraphBatchWithTwoMessagesResponse[0].responses[0];
-
- expect(
- messages.find(
- (message) =>
- message.externalId ===
- 'AAkALgAAAAAAHYQDEapmEc2byACqAC-EWg0AGnUPtcQC-Eiwmc39SmMpPgAAAiVYkAAA',
- ),
- ).toStrictEqual({
- externalId:
- 'AAkALgAAAAAAHYQDEapmEc2byACqAC-EWg0AGnUPtcQC-Eiwmc39SmMpPgAAAiVYkAAA',
- subject: responseExample1.body.subject,
- receivedAt: new Date(responseExample1.body.receivedDateTime),
- text: responseExample1.body.body.content,
- headerMessageId: responseExample1.body.internetMessageId,
- messageThreadExternalId: responseExample1.body.conversationId,
- direction: 'OUTGOING',
- participants: [
- {
- displayName: 'John l',
- handle: '[email protected]',
- role: MessageParticipantRole.FROM,
- },
- {
- displayName: 'Walker',
- handle: '[email protected]',
- role: MessageParticipantRole.TO,
- },
- ],
- isDraft: false,
- attachments: [],
- messageFolderExternalIds: responseExample1.body.parentFolderId
- ? [responseExample1.body.parentFolderId]
- : [],
- messageHeaders: [],
- });
-
- const responseExample2 =
- microsoftGraphBatchWithTwoMessagesResponse[0].responses[1];
-
- expect(
- messages.filter(
- (message) =>
- message.externalId ===
- 'AAkALgAAAAAAHYQDEapmEc2byACqAC-EWg0AGnUPtcQC-Eiwmc39SmMpPgAAA8ZAfgAA',
- )[0],
- ).toStrictEqual({
- externalId:
- 'AAkALgAAAAAAHYQDEapmEc2byACqAC-EWg0AGnUPtcQC-Eiwmc39SmMpPgAAA8ZAfgAA',
- subject: responseExample2.body.subject,
- receivedAt: new Date(responseExample2.body.receivedDateTime),
- text: responseExample2.body.body.content,
- headerMessageId: responseExample2.body.internetMessageId,
- messageThreadExternalId: responseExample2.body.conversationId,
- direction: 'INCOMING',
- participants: [
- {
- displayName: 'Microsoft',
- handle: '[email protected]',
- role: MessageParticipantRole.FROM,
- },
- {
- displayName: 'Walker',
- handle: '[email protected]',
- role: MessageParticipantRole.TO,
- },
- {
- displayName: 'Antoine',
- handle: '[email protected]',
- role: MessageParticipantRole.CC,
- },
- {
- displayName: '[email protected]',
- handle: '[email protected]',
- role: MessageParticipantRole.CC,
- },
- ],
- isDraft: false,
- attachments: [],
- messageFolderExternalIds: responseExample2.body.parentFolderId
- ? [responseExample2.body.parentFolderId]
- : [],
- messageHeaders: [],
- });
- });
-
- it('Should convert html responses to text', () => {
- const batchResponses: MicrosoftGraphBatchResponse[] =
- microsoftGraphBatchWithHtmlMessagesResponse;
- const connectedAccount = {
- id: 'connected-account-id',
- provider: ConnectedAccountProvider.MICROSOFT,
- accessToken: 'access-token',
- refreshToken: 'refresh-token',
- handle: '[email protected]',
- handleAliases: [] as string[],
- workspaceId: 'workspace-id',
- };
- const messages = service.formatBatchResponsesAsMessages(
- batchResponses,
- connectedAccount,
- );
-
- const responseExample =
- microsoftGraphBatchWithHtmlMessagesResponse[0].responses[0];
-
- expect(messages[0]).toStrictEqual({
- externalId: responseExample.body.id,
- subject: responseExample.body.subject,
- receivedAt: new Date(responseExample.body.receivedDateTime),
- text: 'test 4',
- headerMessageId: responseExample.body.internetMessageId,
- messageThreadExternalId: responseExample.body.conversationId,
- direction: 'OUTGOING',
- participants: [
- {
- displayName: responseExample.body.sender.emailAddress.name,
- handle:
- responseExample.body.sender.emailAddress.address.toLowerCase(),
- role: MessageParticipantRole.FROM,
- },
- ],
- isDraft: false,
- attachments: [],
- messageFolderExternalIds: responseExample.body.parentFolderId
- ? [responseExample.body.parentFolderId]
- : [],
- messageHeaders: [],
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-import-exception-handler.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-import-exception-handler.service.spec.ts
deleted file mode 100644
index 0b99c181934..00000000000
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-import-exception-handler.service.spec.ts
+++ /dev/null
@@ -1,181 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { MessageChannelSyncStatus } from 'twenty-shared/types';
-
-import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
-import {
- ConnectedAccountRefreshAccessTokenException,
- ConnectedAccountRefreshAccessTokenExceptionCode,
-} from 'src/engine/metadata-modules/connected-account/exceptions/connected-account-refresh-tokens.exception';
-import { MessageChannelEntity } from 'src/engine/metadata-modules/message-channel/entities/message-channel.entity';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { MessageChannelSyncStatusService } from 'src/modules/messaging/common/services/message-channel-sync-status.service';
-import {
- MessageImportExceptionHandlerService,
- MessageImportSyncStep,
-} from 'src/modules/messaging/message-import-manager/services/messaging-import-exception-handler.service';
-import { MessagingMonitoringService } from 'src/modules/messaging/monitoring/services/messaging-monitoring.service';
-
-describe('MessageImportExceptionHandlerService — refresh code dispatch', () => {
- let service: MessageImportExceptionHandlerService;
- let messageChannelSyncStatusService: {
- markAsFailed: jest.Mock;
- markAsMessagesListFetchPending: jest.Mock;
- markAsMessagesImportPending: jest.Mock;
- resetAndMarkAsMessagesListFetchPending: jest.Mock;
- };
- let messageChannelRepository: { increment: jest.Mock; update: jest.Mock };
- let messagingMonitoringService: { track: jest.Mock };
- let exceptionHandlerService: { captureExceptions: jest.Mock };
-
- const workspaceId = 'workspace-1';
- const messageChannel = {
- id: 'channel-1',
- throttleFailureCount: 0,
- connectedAccountId: 'connected-account-1',
- };
-
- beforeEach(async () => {
- messageChannelSyncStatusService = {
- markAsFailed: jest.fn(),
- markAsMessagesListFetchPending: jest.fn(),
- markAsMessagesImportPending: jest.fn(),
- resetAndMarkAsMessagesListFetchPending: jest.fn(),
- };
- messageChannelRepository = { increment: jest.fn(), update: jest.fn() };
- messagingMonitoringService = { track: jest.fn() };
- exceptionHandlerService = { captureExceptions: jest.fn() };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- MessageImportExceptionHandlerService,
- {
- provide: getWorkspaceScopedRepositoryToken(MessageChannelEntity),
- useValue: messageChannelRepository,
- },
- {
- provide: MessageChannelSyncStatusService,
- useValue: messageChannelSyncStatusService,
- },
- { provide: ExceptionHandlerService, useValue: exceptionHandlerService },
- {
- provide: MessagingMonitoringService,
- useValue: messagingMonitoringService,
- },
- ],
- }).compile();
-
- service = module.get(MessageImportExceptionHandlerService);
- });
-
- it('should mark channel FAILED_INSUFFICIENT_PERMISSIONS and fire monitoring on REFRESH_TOKEN_NOT_FOUND', async () => {
- await service.handleDriverException(
- new ConnectedAccountRefreshAccessTokenException(
- 'refresh token missing',
- ConnectedAccountRefreshAccessTokenExceptionCode.REFRESH_TOKEN_NOT_FOUND,
- ),
- MessageImportSyncStep.MESSAGE_LIST_FETCH,
- messageChannel,
- workspaceId,
- );
-
- expect(messageChannelSyncStatusService.markAsFailed).toHaveBeenCalledWith(
- [messageChannel.id],
- workspaceId,
- MessageChannelSyncStatus.FAILED_INSUFFICIENT_PERMISSIONS,
- );
- expect(messagingMonitoringService.track).toHaveBeenCalledWith(
- expect.objectContaining({
- eventName: 'refresh_token.error.insufficient_permissions',
- workspaceId,
- connectedAccountId: messageChannel.connectedAccountId,
- messageChannelId: messageChannel.id,
- message: expect.stringContaining('REFRESH_TOKEN_NOT_FOUND'),
- }),
- );
- });
-
- it('should fire monitoring on INVALID_REFRESH_TOKEN', async () => {
- await service.handleDriverException(
- new ConnectedAccountRefreshAccessTokenException(
- 'refresh rejected',
- ConnectedAccountRefreshAccessTokenExceptionCode.INVALID_REFRESH_TOKEN,
- ),
- MessageImportSyncStep.MESSAGES_IMPORT_ONGOING,
- messageChannel,
- workspaceId,
- );
-
- expect(messagingMonitoringService.track).toHaveBeenCalledTimes(1);
- expect(messageChannelSyncStatusService.markAsFailed).toHaveBeenCalledWith(
- [messageChannel.id],
- workspaceId,
- MessageChannelSyncStatus.FAILED_INSUFFICIENT_PERMISSIONS,
- );
- });
-
- it('should NOT fire monitoring on TEMPORARY_NETWORK_ERROR and should throttle instead', async () => {
- await service.handleDriverException(
- new ConnectedAccountRefreshAccessTokenException(
- 'temp',
- ConnectedAccountRefreshAccessTokenExceptionCode.TEMPORARY_NETWORK_ERROR,
- ),
- MessageImportSyncStep.MESSAGE_LIST_FETCH,
- messageChannel,
- workspaceId,
- );
-
- expect(messagingMonitoringService.track).not.toHaveBeenCalled();
- expect(messageChannelRepository.increment).toHaveBeenCalled();
- expect(
- messageChannelSyncStatusService.markAsMessagesListFetchPending,
- ).toHaveBeenCalled();
- });
-
- it('should mark FAILED_UNKNOWN on ACCESS_TOKEN_NOT_FOUND (matches pre-refactor fall-through)', async () => {
- await service.handleDriverException(
- new ConnectedAccountRefreshAccessTokenException(
- 'no access token',
- ConnectedAccountRefreshAccessTokenExceptionCode.ACCESS_TOKEN_NOT_FOUND,
- ),
- MessageImportSyncStep.MESSAGE_LIST_FETCH,
- messageChannel,
- workspaceId,
- );
-
- expect(messageChannelSyncStatusService.markAsFailed).toHaveBeenCalledWith(
- [messageChannel.id],
- workspaceId,
- MessageChannelSyncStatus.FAILED_UNKNOWN,
- );
- expect(exceptionHandlerService.captureExceptions).toHaveBeenCalledWith(
- expect.any(Array),
- expect.objectContaining({
- additionalData: expect.objectContaining({
- messageChannelId: messageChannel.id,
- syncStep: MessageImportSyncStep.MESSAGE_LIST_FETCH,
- }),
- }),
- );
- expect(messagingMonitoringService.track).not.toHaveBeenCalled();
- });
-
- it('should mark FAILED_UNKNOWN on PROVIDER_NOT_SUPPORTED', async () => {
- await service.handleDriverException(
- new ConnectedAccountRefreshAccessTokenException(
- 'provider down',
- ConnectedAccountRefreshAccessTokenExceptionCode.PROVIDER_NOT_SUPPORTED,
- ),
- MessageImportSyncStep.MESSAGE_LIST_FETCH,
- messageChannel,
- workspaceId,
- );
-
- expect(messageChannelSyncStatusService.markAsFailed).toHaveBeenCalledWith(
- [messageChannel.id],
- workspaceId,
- MessageChannelSyncStatus.FAILED_UNKNOWN,
- );
- expect(messagingMonitoringService.track).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-messages-import.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-messages-import.service.spec.ts
deleted file mode 100644
index a3884c88b59..00000000000
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-messages-import.service.spec.ts
+++ /dev/null
@@ -1,314 +0,0 @@
-import { Logger, type Provider } from '@nestjs/common';
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import {
- ConnectedAccountProvider,
- MessageChannelSyncStage,
- MessageFolderImportPolicy,
-} from 'twenty-shared/types';
-
-import { CacheStorageService } from 'src/engine/core-modules/cache-storage/services/cache-storage.service';
-import { CacheStorageNamespace } from 'src/engine/core-modules/cache-storage/types/cache-storage-namespace.enum';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { BlocklistRepository } from 'src/modules/blocklist/repositories/blocklist.repository';
-import { EmailAliasManagerService } from 'src/modules/connected-account/email-alias-manager/services/email-alias-manager.service';
-import { type ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { MessageChannelSyncStatusService } from 'src/modules/messaging/common/services/message-channel-sync-status.service';
-import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
-import { MessagingGetMessagesService } from 'src/modules/messaging/message-import-manager/services/messaging-get-messages.service';
-import { MessageImportExceptionHandlerService } from 'src/modules/messaging/message-import-manager/services/messaging-import-exception-handler.service';
-import { MessagingMessagesImportService } from 'src/modules/messaging/message-import-manager/services/messaging-messages-import.service';
-import { MessagingSaveMessagesAndEnqueueContactCreationService } from 'src/modules/messaging/message-import-manager/services/messaging-save-messages-and-enqueue-contact-creation.service';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { MessagingMonitoringService } from 'src/modules/messaging/monitoring/services/messaging-monitoring.service';
-import { MessageChannelEntity } from 'src/engine/metadata-modules/message-channel/entities/message-channel.entity';
-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-
-describe('MessagingMessagesImportService', () => {
- let service: MessagingMessagesImportService;
- let messageChannelSyncStatusService: MessageChannelSyncStatusService;
- let emailAliasManagerService: EmailAliasManagerService;
- let messagingGetMessagesService: MessagingGetMessagesService;
- let saveMessagesService: MessagingSaveMessagesAndEnqueueContactCreationService;
-
- const workspaceId = 'workspace-id';
- let mockMessageChannel: Pick<
- MessageChannelEntity,
- | 'id'
- | 'syncStage'
- | 'connectedAccountId'
- | 'handle'
- | 'messageFolders'
- | 'messageFolderImportPolicy'
- >;
- let mockConnectedAccount: ConnectedAccountEntity;
- let providersBase: Provider[];
-
- beforeEach(async () => {
- mockConnectedAccount = {
- id: 'connected-account-id',
- provider: ConnectedAccountProvider.GOOGLE,
- handle: '[email protected]',
- refreshToken: 'refresh-token',
- accessToken: 'old-access-token',
- userWorkspaceId: 'user-workspace-id',
- handleAliases: ['[email protected]', '[email protected]'],
- } as ConnectedAccountEntity;
-
- mockMessageChannel = {
- id: 'message-channel-id',
- syncStage: MessageChannelSyncStage.MESSAGES_IMPORT_SCHEDULED,
- connectedAccountId: mockConnectedAccount.id,
- handle: '[email protected]',
- messageFolders: [],
- messageFolderImportPolicy: MessageFolderImportPolicy.ALL_FOLDERS,
- };
-
- providersBase = [
- MessagingMessagesImportService,
- {
- provide: CacheStorageService,
- useValue: {
- setAdd: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: MessageChannelSyncStatusService,
- useValue: {
- markAsMessagesImportOngoing: jest.fn().mockResolvedValue(undefined),
- markAsMessageSyncCompleted: jest.fn().mockResolvedValue(undefined),
- markAsMessagesImportPending: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: MessagingMonitoringService,
- useValue: {
- track: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: 'BlocklistRepository',
- useValue: {
- getByWorkspaceMemberId: jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: BlocklistRepository,
- useValue: {
- getByWorkspaceMemberId: jest.fn().mockResolvedValue([]),
- },
- },
- {
- provide: EmailAliasManagerService,
- useValue: {
- refreshHandleAliases: jest
- .fn()
- .mockResolvedValue(['[email protected]', '[email protected]']),
- },
- },
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getRepository: jest.fn().mockResolvedValue({
- update: jest.fn().mockResolvedValue(undefined),
- findOne: jest.fn().mockResolvedValue({
- id: 'workspace-member-id',
- userId: 'user-id',
- }),
- }),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- },
- },
- {
- provide: getRepositoryToken(MessageChannelEntity),
- useValue: {
- update: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: MessagingGetMessagesService,
- useValue: {
- getMessages: jest.fn().mockResolvedValue([
- {
- id: 'message-1',
- },
- {
- id: 'message-2',
- },
- ]),
- },
- },
- {
- provide: MessagingSaveMessagesAndEnqueueContactCreationService,
- useValue: {
- saveMessagesAndEnqueueContactCreation: jest
- .fn()
- .mockResolvedValue(undefined),
- },
- },
- {
- provide: MessageImportExceptionHandlerService,
- useValue: {
- handleDriverException: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: getRepositoryToken(UserWorkspaceEntity),
- useValue: {
- findOne: jest.fn().mockResolvedValue({ userId: 'user-id' }),
- },
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: {
- findOne: jest
- .fn()
- .mockResolvedValue({ isInternalMessagesImportEnabled: false }),
- },
- },
- {
- provide: TwentyConfigService,
- useValue: {
- get: jest.fn().mockReturnValue(400),
- },
- },
- ];
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ...providersBase,
- {
- provide: CacheStorageNamespace.ModuleMessaging,
- useValue: {
- setPop: jest
- .fn()
- .mockResolvedValue(['message-id-1', 'message-id-2']),
- setAdd: jest.fn().mockResolvedValue(undefined),
- },
- },
- ],
- })
- .overrideProvider(Logger)
- .useValue({ log: jest.fn() })
- .compile();
-
- service = module.get<MessagingMessagesImportService>(
- MessagingMessagesImportService,
- );
-
- messageChannelSyncStatusService =
- module.get<MessageChannelSyncStatusService>(
- MessageChannelSyncStatusService,
- );
- emailAliasManagerService = module.get<EmailAliasManagerService>(
- EmailAliasManagerService,
- );
- messagingGetMessagesService = module.get<MessagingGetMessagesService>(
- MessagingGetMessagesService,
- );
-
- saveMessagesService =
- module.get<MessagingSaveMessagesAndEnqueueContactCreationService>(
- MessagingSaveMessagesAndEnqueueContactCreationService,
- );
- });
-
- it('should fails if SyncStage is not MESSAGES_IMPORT_SCHEDULED', async () => {
- mockMessageChannel.syncStage =
- MessageChannelSyncStage.MESSAGES_IMPORT_PENDING;
-
- await expect(
- service.processMessageBatchImport(
- mockMessageChannel as MessageChannelEntity,
- mockConnectedAccount,
- workspaceId,
- ),
- ).resolves.toBeFalsy();
- });
-
- it('should process message batch import successfully', async () => {
- await service.processMessageBatchImport(
- mockMessageChannel as MessageChannelEntity,
- mockConnectedAccount,
- workspaceId,
- );
- expect(
- messageChannelSyncStatusService.markAsMessagesImportOngoing,
- ).toHaveBeenCalledWith([mockMessageChannel.id], workspaceId);
-
- expect(
- emailAliasManagerService.refreshHandleAliases,
- ).not.toHaveBeenCalled();
- expect(messagingGetMessagesService.getMessages).toHaveBeenCalledWith(
- ['message-id-1', 'message-id-2'],
- mockConnectedAccount,
- mockMessageChannel,
- );
- expect(
- saveMessagesService.saveMessagesAndEnqueueContactCreation,
- ).toHaveBeenCalled();
- expect(
- messageChannelSyncStatusService.markAsMessagesImportPending,
- ).toHaveBeenCalledTimes(0);
- });
-
- it('should process message batch import of more than MESSAGING_GMAIL_USERS_MESSAGES_GET_BATCH_SIZE successfully', async () => {
- const arrayMessagesBig = Array.from(
- { length: 401 },
- (_, index) => `message-id-${index + 1}`,
- );
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- ...providersBase,
- {
- provide: CacheStorageNamespace.ModuleMessaging,
- useValue: {
- setPop: jest.fn().mockResolvedValue(arrayMessagesBig),
- setAdd: jest.fn().mockResolvedValue(undefined),
- },
- },
- ],
- })
- .overrideProvider(Logger)
- .useValue({ log: jest.fn() })
- .compile();
-
- service = module.get<MessagingMessagesImportService>(
- MessagingMessagesImportService,
- );
-
- messageChannelSyncStatusService =
- module.get<MessageChannelSyncStatusService>(
- MessageChannelSyncStatusService,
- );
- emailAliasManagerService = module.get<EmailAliasManagerService>(
- EmailAliasManagerService,
- );
- messagingGetMessagesService = module.get<MessagingGetMessagesService>(
- MessagingGetMessagesService,
- );
-
- saveMessagesService =
- module.get<MessagingSaveMessagesAndEnqueueContactCreationService>(
- MessagingSaveMessagesAndEnqueueContactCreationService,
- );
-
- await service.processMessageBatchImport(
- mockMessageChannel as MessageChannelEntity,
- mockConnectedAccount,
- workspaceId,
- );
-
- expect(
- messageChannelSyncStatusService.markAsMessagesImportPending,
- ).toHaveBeenCalledTimes(1);
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-save-messages-and-enqueue-contact-creation.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-save-messages-and-enqueue-contact-creation.service.spec.ts
deleted file mode 100644
index 3b4f9294bdf..00000000000
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-save-messages-and-enqueue-contact-creation.service.spec.ts
+++ /dev/null
@@ -1,429 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import {
- FieldActorSource,
- MessageChannelContactAutoCreationPolicy,
- MessageParticipantRole,
-} from 'twenty-shared/types';
-
-import { type MessageChannelEntity } from 'src/engine/metadata-modules/message-channel/entities/message-channel.entity';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { MessageQueueService } from 'src/engine/core-modules/message-queue/services/message-queue.service';
-import { getQueueToken } from 'src/engine/core-modules/message-queue/utils/get-queue-token.util';
-import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
-import { CreateCompanyAndContactJob } from 'src/modules/contact-creation-manager/jobs/create-company-and-contact.job';
-import { MessageDirection } from 'src/modules/messaging/common/enums/message-direction.enum';
-import { MessagingMessageFolderAssociationService } from 'src/modules/messaging/message-import-manager/services/messaging-message-folder-association.service';
-import { MessagingMessageService } from 'src/modules/messaging/message-import-manager/services/messaging-message.service';
-import { MessagingSaveMessagesAndEnqueueContactCreationService } from 'src/modules/messaging/message-import-manager/services/messaging-save-messages-and-enqueue-contact-creation.service';
-import { type MessageWithParticipants } from 'src/modules/messaging/message-import-manager/types/message';
-import { MessagingMessageParticipantService } from 'src/modules/messaging/message-participant-manager/services/messaging-message-participant.service';
-
-describe('MessagingSaveMessagesAndEnqueueContactCreationService', () => {
- let service: MessagingSaveMessagesAndEnqueueContactCreationService;
- let messageQueueService: MessageQueueService;
- let messageService: MessagingMessageService;
- let messageParticipantService: MessagingMessageParticipantService;
-
- let datasourceInstance: { transaction: jest.Mock };
-
- const workspaceId = 'workspace-id';
-
- const mockConnectedAccount: ConnectedAccountEntity = {
- id: 'connected-account-id',
- handle: '[email protected]',
- handleAliases: ['[email protected]', '[email protected]'],
- } as ConnectedAccountEntity;
-
- const mockMessageChannel: MessageChannelEntity = {
- id: 'message-channel-id',
- isContactAutoCreationEnabled: true,
- contactAutoCreationPolicy:
- MessageChannelContactAutoCreationPolicy.SENT_AND_RECEIVED,
- excludeNonProfessionalEmails: true,
- excludeGroupEmails: true,
- } as MessageChannelEntity;
-
- const mockMessages: MessageWithParticipants[] = [
- {
- externalId: 'message-1',
- headerMessageId: 'header-message-id-1',
- subject: 'Test Subject 1',
- text: 'Test content 1',
- receivedAt: new Date(),
- attachments: [],
- isDraft: false,
- messageThreadExternalId: 'thread-1',
- direction: MessageDirection.OUTGOING,
- participants: [
- {
- role: MessageParticipantRole.FROM,
- handle: '[email protected]',
- displayName: 'Test User',
- },
- {
- role: MessageParticipantRole.TO,
- handle: '[email protected]',
- displayName: 'Contact',
- },
- ],
- },
- {
- externalId: 'message-2',
- headerMessageId: 'header-message-id-2',
- subject: 'Test Subject 2',
- text: 'Test content 2',
- receivedAt: new Date(),
- attachments: [],
- isDraft: false,
- messageThreadExternalId: 'thread-1',
- direction: MessageDirection.INCOMING,
- participants: [
- {
- role: MessageParticipantRole.FROM,
- handle: '[email protected]',
- displayName: 'Contact',
- },
- {
- role: MessageParticipantRole.TO,
- handle: '[email protected]',
- displayName: 'Test User',
- },
- {
- role: MessageParticipantRole.TO,
- handle: '[email protected]',
- displayName: 'Personal',
- },
- {
- role: MessageParticipantRole.TO,
- handle: '[email protected]',
- displayName: 'Group email',
- },
- ],
- },
- ];
-
- beforeEach(async () => {
- datasourceInstance = {
- transaction: jest.fn().mockImplementation(async (callback) => {
- return callback({});
- }),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- MessagingSaveMessagesAndEnqueueContactCreationService,
- {
- provide: MessageQueueService,
- useValue: {
- add: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: getQueueToken(MessageQueue.contactCreationQueue),
- useValue: {
- add: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: getRepositoryToken(ObjectMetadataEntity),
- useValue: {
- findOneOrFail: jest.fn(),
- },
- },
- {
- provide: MessagingMessageService,
- useValue: {
- saveMessagesWithinTransaction: jest.fn().mockResolvedValue({
- messageExternalIdsAndIdsMap: new Map([
- ['message-1', 'db-message-id-1'],
- ['message-2', 'db-message-id-2'],
- ]),
- messageExternalIdToMessageThreadIdMap: new Map([
- ['message-1', 'db-thread-id-1'],
- ['message-2', 'db-thread-id-1'],
- ]),
- createdMessages: [
- { id: 'db-message-id-1' },
- { id: 'db-message-id-2' },
- ],
- }),
- },
- },
- {
- provide: MessagingMessageParticipantService,
- useValue: {
- saveMessageParticipants: jest.fn().mockResolvedValue(undefined),
- },
- },
- {
- provide: MessagingMessageFolderAssociationService,
- useValue: {
- saveMessageFolderAssociations: jest
- .fn()
- .mockResolvedValue(undefined),
- },
- },
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: {
- getGlobalWorkspaceDataSource: jest
- .fn()
- .mockResolvedValue(datasourceInstance),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- },
- },
- ],
- }).compile();
-
- service = module.get<MessagingSaveMessagesAndEnqueueContactCreationService>(
- MessagingSaveMessagesAndEnqueueContactCreationService,
- );
- messageQueueService = module.get<MessageQueueService>(
- getQueueToken(MessageQueue.contactCreationQueue),
- );
- messageService = module.get<MessagingMessageService>(
- MessagingMessageService,
- );
- messageParticipantService = module.get<MessagingMessageParticipantService>(
- MessagingMessageParticipantService,
- );
- });
-
- it('should save messages and enqueue contact creation', async () => {
- const result = await service.saveMessagesAndEnqueueContactCreation(
- mockMessages,
- mockMessageChannel,
- mockConnectedAccount,
- workspaceId,
- );
-
- expect(messageService.saveMessagesWithinTransaction).toHaveBeenCalledWith(
- mockMessages,
- mockMessageChannel.id,
- expect.any(Object),
- workspaceId,
- );
-
- expect(
- messageParticipantService.saveMessageParticipants,
- ).toHaveBeenCalled();
- expect(messageQueueService.add).toHaveBeenCalled();
-
- expect(result?.messageExternalIdsAndIdsMap.get('message-1')).toBe(
- 'db-message-id-1',
- );
- expect(result?.messageExternalIdToMessageThreadIdMap.get('message-1')).toBe(
- 'db-thread-id-1',
- );
- });
-
- it('should not enqueue contact creation when it is disabled', async () => {
- await service.saveMessagesAndEnqueueContactCreation(
- mockMessages,
- {
- ...mockMessageChannel,
- isContactAutoCreationEnabled: false,
- },
- mockConnectedAccount,
- workspaceId,
- );
-
- expect(messageService.saveMessagesWithinTransaction).toHaveBeenCalled();
- expect(messageQueueService.add).not.toHaveBeenCalled();
- });
-
- it('should create external contacts', async () => {
- await service.saveMessagesAndEnqueueContactCreation(
- [
- {
- ...mockMessages[1],
- participants: [
- {
- role: MessageParticipantRole.FROM,
- handle: '[email protected]',
- displayName: 'participant email',
- },
- ],
- },
- ],
- mockMessageChannel,
- mockConnectedAccount,
- workspaceId,
- );
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- CreateCompanyAndContactJob.name,
- {
- workspaceId,
- connectedAccount: mockConnectedAccount,
- source: FieldActorSource.EMAIL,
- contactsToCreate: [
- {
- handle: '[email protected]',
- displayName: 'participant email',
- role: MessageParticipantRole.FROM,
- shouldCreateContact: true,
- messageId: 'db-message-id-2',
- },
- ],
- },
- );
- });
-
- it('should not create personal emails contacts', async () => {
- await service.saveMessagesAndEnqueueContactCreation(
- [
- {
- ...mockMessages[0],
- participants: [
- {
- role: MessageParticipantRole.FROM,
- handle: '[email protected]',
- displayName: 'participant personal email',
- },
- ],
- },
- ],
- mockMessageChannel,
- mockConnectedAccount,
- workspaceId,
- );
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- CreateCompanyAndContactJob.name,
- {
- workspaceId,
- connectedAccount: mockConnectedAccount,
- source: FieldActorSource.EMAIL,
- contactsToCreate: [],
- },
- );
- });
- it('should not create contacts for non-sender group email participants when excludeGroupEmails is enabled', async () => {
- await service.saveMessagesAndEnqueueContactCreation(
- [
- {
- ...mockMessages[1],
- participants: [
- {
- role: MessageParticipantRole.FROM,
- handle: '[email protected]',
- displayName: 'Tim',
- },
- {
- role: MessageParticipantRole.REPLY_TO,
- handle: '[email protected]',
- displayName: 'Instagram',
- },
- {
- role: MessageParticipantRole.CC,
- handle: '[email protected]',
- displayName: 'Support',
- },
- ],
- },
- ],
- mockMessageChannel,
- mockConnectedAccount,
- workspaceId,
- );
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- CreateCompanyAndContactJob.name,
- {
- workspaceId,
- connectedAccount: mockConnectedAccount,
- source: FieldActorSource.EMAIL,
- contactsToCreate: [
- {
- handle: '[email protected]',
- displayName: 'Tim',
- role: MessageParticipantRole.FROM,
- shouldCreateContact: true,
- messageId: 'db-message-id-2',
- },
- ],
- },
- );
- });
-
- it('should not create contact if the participant is the connected account', async () => {
- const mockMessagesWithConnectedAccount = [
- {
- ...mockMessages[0],
- participants: [
- {
- role: MessageParticipantRole.FROM,
- handle: '[email protected]',
- displayName: 'participant that is the Connected Account',
- },
- ],
- },
- ];
-
- await service.saveMessagesAndEnqueueContactCreation(
- mockMessagesWithConnectedAccount,
- mockMessageChannel,
- {
- ...mockConnectedAccount,
- handle: '[email protected]',
- },
- workspaceId,
- );
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- CreateCompanyAndContactJob.name,
- {
- workspaceId,
- connectedAccount: {
- ...mockConnectedAccount,
- handle: '[email protected]',
- },
- source: FieldActorSource.EMAIL,
- contactsToCreate: [],
- },
- );
- });
-
- it('should not create contacts for unsent drafts', async () => {
- await service.saveMessagesAndEnqueueContactCreation(
- [
- {
- ...mockMessages[0],
- isDraft: true,
- participants: [
- {
- role: MessageParticipantRole.FROM,
- handle: '[email protected]',
- displayName: 'Test User',
- },
- {
- role: MessageParticipantRole.TO,
- handle: '[email protected]',
- displayName: 'Prospect',
- },
- ],
- },
- ],
- mockMessageChannel,
- mockConnectedAccount,
- workspaceId,
- );
-
- expect(messageQueueService.add).toHaveBeenCalledWith(
- CreateCompanyAndContactJob.name,
- {
- workspaceId,
- connectedAccount: mockConnectedAccount,
- source: FieldActorSource.EMAIL,
- contactsToCreate: [],
- },
- );
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/message-outbound-manager/drivers/gmail/services/__tests__/gmail-message-outbound.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-outbound-manager/drivers/gmail/services/__tests__/gmail-message-outbound.service.spec.ts
deleted file mode 100644
index 27d2098e2bf..00000000000
--- a/packages/twenty-server/src/modules/messaging/message-outbound-manager/drivers/gmail/services/__tests__/gmail-message-outbound.service.spec.ts
+++ /dev/null
@@ -1,167 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { google } from 'googleapis';
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-
-import { GoogleOAuth2ClientProvider } from 'src/modules/connected-account/oauth2-client-manager/drivers/google/google-oauth2-client.provider';
-import { GmailMessageOutboundService } from 'src/modules/messaging/message-outbound-manager/drivers/gmail/services/gmail-message-outbound.service';
-
-jest.mock('nodemailer/lib/mail-composer', () => {
- return jest.fn().mockImplementation(() => ({
- compile: jest.fn().mockReturnValue({
- build: jest.fn().mockResolvedValue(Buffer.from('mocked-email-content')),
- }),
- }));
-});
-
-describe('GmailMessageOutboundService', () => {
- let service: GmailMessageOutboundService;
-
- const mockSend = jest.fn().mockResolvedValue({ data: { id: 'message-id' } });
- const mockCreateDraft = jest
- .fn()
- .mockResolvedValue({ data: { id: 'draft-id' } });
-
- const mockGmailClient = {
- users: {
- messages: {
- send: mockSend,
- },
- drafts: {
- create: mockCreateDraft,
- },
- getProfile: jest
- .fn()
- .mockResolvedValue({ data: { emailAddress: '[email protected]' } }),
- },
- };
-
- const mockPeopleClient = {
- people: {
- get: jest.fn().mockResolvedValue({
- data: {
- names: [
- {
- displayName: 'Test User',
- },
- ],
- },
- }),
- },
- };
-
- const mockOAuth2Client = {};
-
- beforeEach(async () => {
- jest.spyOn(google, 'gmail').mockReturnValue(mockGmailClient as never);
- jest.spyOn(google, 'people').mockReturnValue(mockPeopleClient as never);
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- GmailMessageOutboundService,
- {
- provide: GoogleOAuth2ClientProvider,
- useValue: {
- getClient: jest.fn().mockResolvedValue(mockOAuth2Client),
- },
- },
- ],
- }).compile();
-
- service = module.get<GmailMessageOutboundService>(
- GmailMessageOutboundService,
- );
- });
-
- afterEach(() => {
- mockSend.mockClear();
- mockCreateDraft.mockClear();
- jest.restoreAllMocks();
- });
-
- it('should send multipart/alternative email with both text and HTML parts via Gmail', async () => {
- const sendMessageInput = {
- subject: 'Test HTML Email',
- body: 'This is plain text content',
- html: '<p>This is <strong>HTML</strong> content</p>',
- attachments: [],
- };
-
- const connectedAccount = {
- id: 'connected-account-id',
- provider: ConnectedAccountProvider.GOOGLE,
- } as any;
-
- await service.sendMessage(sendMessageInput, connectedAccount);
-
- expect(mockSend).toHaveBeenCalledTimes(1);
- expect(mockSend).toHaveBeenCalledWith({
- userId: 'me',
- requestBody: {
- raw: Buffer.from('mocked-email-content').toString('base64url'),
- },
- });
- });
-
- it('should send email with attachments via Gmail', async () => {
- const sendMessageInput = {
- subject: 'Test Email with Attachments',
- body: 'Plain text',
- html: '<p>HTML content</p>',
- attachments: [
- {
- filename: 'test.pdf',
- content: Buffer.from('test-pdf-content'),
- contentType: 'application/pdf',
- },
- ],
- };
-
- const connectedAccount = {
- id: 'connected-account-id',
- provider: ConnectedAccountProvider.GOOGLE,
- } as any;
-
- await service.sendMessage(sendMessageInput, connectedAccount);
-
- expect(mockSend).toHaveBeenCalledTimes(1);
- expect(mockSend).toHaveBeenCalledWith({
- userId: 'me',
- requestBody: {
- raw: Buffer.from('mocked-email-content').toString('base64url'),
- },
- });
- });
-
- it('should create Gmail drafts in the existing thread when a thread id is provided', async () => {
- const sendMessageInput = {
- subject: 'Re: Existing thread',
- body: 'Plain text',
- html: '<p>HTML content</p>',
- attachments: [],
- inReplyTo: '<[email protected]>',
- threadExternalId: 'gmail-thread-id',
- };
-
- const connectedAccount = {
- id: 'connected-account-id',
- provider: ConnectedAccountProvider.GOOGLE,
- } as any;
-
- await service.createDraft(sendMessageInput, connectedAccount);
-
- expect(mockCreateDraft).toHaveBeenCalledTimes(1);
- expect(mockCreateDraft).toHaveBeenCalledWith({
- userId: 'me',
- requestBody: {
- message: {
- raw: Buffer.from('mocked-email-content').toString('base64url'),
- threadId: 'gmail-thread-id',
- },
- },
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/messaging/message-outbound-manager/drivers/microsoft/services/__tests__/microsoft-message-outbound.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-outbound-manager/drivers/microsoft/services/__tests__/microsoft-message-outbound.service.spec.ts
deleted file mode 100644
index 0cc88609dca..00000000000
--- a/packages/twenty-server/src/modules/messaging/message-outbound-manager/drivers/microsoft/services/__tests__/microsoft-message-outbound.service.spec.ts
+++ /dev/null
@@ -1,123 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { ConnectedAccountProvider } from 'twenty-shared/types';
-
-import { MicrosoftOAuth2ClientProvider } from 'src/modules/connected-account/oauth2-client-manager/drivers/microsoft/microsoft-oauth2-client.provider';
-import { MicrosoftMessageOutboundService } from 'src/modules/messaging/message-outbound-manager/drivers/microsoft/services/microsoft-message-outbound.service';
-
-describe('MicrosoftMessageOutboundService', () => {
- let service: MicrosoftMessageOutboundService;
-
- const messagesRequest = {
- filter: jest.fn().mockReturnThis(),
- select: jest.fn().mockReturnThis(),
- top: jest.fn().mockReturnThis(),
- get: jest.fn(),
- post: jest.fn(),
- };
-
- const replyRequest = {
- post: jest.fn(),
- };
-
- const draftRequest = {
- patch: jest.fn(),
- };
-
- const mockMicrosoftClient = {
- api: jest.fn((path: string) => {
- switch (path) {
- case '/me/messages':
- return messagesRequest;
- case '/me/messages/parent-message-id/createReply':
- return replyRequest;
- case '/me/messages/reply-draft-id':
- return draftRequest;
- default:
- throw new Error(`Unexpected Microsoft Graph path: ${path}`);
- }
- }),
- };
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- messagesRequest.filter.mockReturnThis();
- messagesRequest.select.mockReturnThis();
- messagesRequest.top.mockReturnThis();
- messagesRequest.get.mockResolvedValue({
- value: [{ id: 'parent-message-id' }],
- });
- replyRequest.post.mockResolvedValue({
- id: 'reply-draft-id',
- internetMessageId: '<[email protected]>',
- conversationId: 'conversation-id',
- });
- draftRequest.patch.mockResolvedValue({
- id: 'reply-draft-id',
- internetMessageId: '<[email protected]>',
- conversationId: 'conversation-id',
- });
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- MicrosoftMessageOutboundService,
- {
- provide: MicrosoftOAuth2ClientProvider,
- useValue: {
- getClient: jest.fn().mockResolvedValue(mockMicrosoftClient),
- },
- },
- ],
- }).compile();
-
- service = module.get<MicrosoftMessageOutboundService>(
- MicrosoftMessageOutboundService,
- );
- });
-
- it('creates Microsoft drafts as replies when a parent internet message id is provided', async () => {
- const connectedAccount = {
- id: 'connected-account-id',
- provider: ConnectedAccountProvider.MICROSOFT,
- } as any;
-
- await service.createDraft(
- {
- subject: 'Re: Existing thread',
- body: 'Plain text',
- html: '<p>HTML content</p>',
- attachments: [],
- inReplyTo: "<parent'[email protected]>",
- },
- connectedAccount,
- );
-
- expect(mockMicrosoftClient.api).toHaveBeenCalledWith('/me/messages');
- expect(messagesRequest.filter).toHaveBeenCalledWith(
- "internetMessageId eq '<parent''[email protected]>'",
- );
- expect(messagesRequest.select).toHaveBeenCalledWith('id');
- expect(messagesRequest.top).toHaveBeenCalledWith(1);
-
- expect(mockMicrosoftClient.api).toHaveBeenCalledWith(
- '/me/messages/parent-message-id/createReply',
- );
- expect(replyRequest.post).toHaveBeenCalledWith({});
-
- expect(mockMicrosoftClient.api).toHaveBeenCalledWith(
- '/me/messages/reply-draft-id',
- );
- expect(draftRequest.patch).toHaveBeenCalledWith(
- expect.objectContaining({
- subject: 'Re: Existing thread',
- body: {
- contentType: 'HTML',
- content: '<p>HTML content</p>',
- },
- }),
- );
- expect(messagesRequest.post).not.toHaveBeenCalled();
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/common/workspace-services/__tests__/workflow-common.workspace-service.spec.ts b/packages/twenty-server/src/modules/workflow/common/workspace-services/__tests__/workflow-common.workspace-service.spec.ts
deleted file mode 100644
index 2cc88f6d2f4..00000000000
--- a/packages/twenty-server/src/modules/workflow/common/workspace-services/__tests__/workflow-common.workspace-service.spec.ts
+++ /dev/null
@@ -1,140 +0,0 @@
-import { FeatureFlagKey } from 'twenty-shared/types';
-
-import { type FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
-import { type WorkflowVersionCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-version-core-sync.service';
-import { type GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-
-const WORKSPACE_ID = 'workspace-1';
-const WORKFLOW_VERSION_ID = 'workflow-version-1';
-const CORE_WORKFLOW_VERSION_ID = 'core-workflow-version-1';
-
-const workspaceTrigger = { name: 'workspace trigger', type: 'MANUAL' };
-const workspaceSteps = [{ id: 'workspace-step' }];
-
-const coreTrigger = { name: 'core trigger', type: 'DATABASE_EVENT' };
-const coreSteps = [{ id: 'core-step' }];
-
-const buildService = ({
- isCoreReadEnabled,
- coreVersion = null,
- coreWorkflowVersionId = CORE_WORKFLOW_VERSION_ID,
-}: {
- isCoreReadEnabled: boolean;
- coreVersion?: unknown;
- coreWorkflowVersionId?: string | null;
-}) => {
- const workspaceVersion = {
- id: WORKFLOW_VERSION_ID,
- workflowId: 'workflow-1',
- name: 'Draft',
- trigger: workspaceTrigger,
- steps: workspaceSteps,
- status: 'DRAFT',
- coreWorkflowVersionId,
- };
-
- const isFeatureEnabled = jest.fn().mockResolvedValue(isCoreReadEnabled);
- const findCoreVersionById = jest.fn().mockResolvedValue(coreVersion);
-
- const globalWorkspaceOrmManager = {
- executeInWorkspaceContext: (fn: () => unknown) => fn(),
- getRepository: jest.fn().mockResolvedValue({
- findOne: jest.fn().mockResolvedValue(workspaceVersion),
- }),
- } as unknown as GlobalWorkspaceOrmManager;
-
- const service = new WorkflowCommonWorkspaceService(
- globalWorkspaceOrmManager,
- undefined as unknown as never,
- undefined as unknown as never,
- undefined as unknown as never,
- { findCoreVersionById } as unknown as WorkflowVersionCoreSyncService,
- { isFeatureEnabled } as unknown as FeatureFlagService,
- );
-
- return { service, isFeatureEnabled, findCoreVersionById };
-};
-
-describe('WorkflowCommonWorkspaceService', () => {
- describe('getWorkflowVersionOrFail core read overlay', () => {
- it('returns workspace content when the core read flag is off', async () => {
- const { service, isFeatureEnabled, findCoreVersionById } = buildService({
- isCoreReadEnabled: false,
- });
-
- const result = await service.getWorkflowVersionOrFail({
- workspaceId: WORKSPACE_ID,
- workflowVersionId: WORKFLOW_VERSION_ID,
- });
-
- expect(isFeatureEnabled).toHaveBeenCalledWith(
- FeatureFlagKey.IS_WORKFLOW_VERSION_IN_CORE_ENABLED,
- WORKSPACE_ID,
- );
- expect(findCoreVersionById).not.toHaveBeenCalled();
- expect(result.trigger).toEqual(workspaceTrigger);
- expect(result.steps).toEqual(workspaceSteps);
- expect(result.status).toBe('DRAFT');
- });
-
- it('overlays trigger, steps and status from core when the flag is on and the core row exists', async () => {
- const { service, findCoreVersionById } = buildService({
- isCoreReadEnabled: true,
- coreVersion: {
- triggers: [coreTrigger],
- steps: coreSteps,
- status: 'ACTIVE',
- },
- });
-
- const result = await service.getWorkflowVersionOrFail({
- workspaceId: WORKSPACE_ID,
- workflowVersionId: WORKFLOW_VERSION_ID,
- });
-
- expect(findCoreVersionById).toHaveBeenCalledWith(
- WORKSPACE_ID,
- CORE_WORKFLOW_VERSION_ID,
- );
- expect(result.trigger).toEqual(coreTrigger);
- expect(result.steps).toEqual(coreSteps);
- expect(result.status).toBe('ACTIVE');
-
- // identity stays from the workspace row: core has neither of these
- expect(result.id).toBe(WORKFLOW_VERSION_ID);
- expect(result.name).toBe('Draft');
- });
-
- it('falls back to workspace content when the flag is on but the core row is missing', async () => {
- const { service } = buildService({
- isCoreReadEnabled: true,
- coreVersion: null,
- });
-
- const result = await service.getWorkflowVersionOrFail({
- workspaceId: WORKSPACE_ID,
- workflowVersionId: WORKFLOW_VERSION_ID,
- });
-
- expect(result.trigger).toEqual(workspaceTrigger);
- expect(result.steps).toEqual(workspaceSteps);
- expect(result.status).toBe('DRAFT');
- });
-
- it('skips the core read when the version has no soft-ref', async () => {
- const { service, findCoreVersionById } = buildService({
- isCoreReadEnabled: true,
- coreWorkflowVersionId: null,
- });
-
- const result = await service.getWorkflowVersionOrFail({
- workspaceId: WORKSPACE_ID,
- workflowVersionId: WORKFLOW_VERSION_ID,
- });
-
- expect(findCoreVersionById).not.toHaveBeenCalled();
- expect(result.trigger).toEqual(workspaceTrigger);
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/__tests__/workflow-validation.workspace-service.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/__tests__/workflow-validation.workspace-service.spec.ts
deleted file mode 100644
index 54ece9957d7..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-validation/__tests__/workflow-validation.workspace-service.spec.ts
+++ /dev/null
@@ -1,534 +0,0 @@
-import { type WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { type WorkflowSchemaWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-schema/workflow-schema.workspace-service';
-import { type OutputSchema } from 'src/modules/workflow/workflow-builder/workflow-schema/types/output-schema.type';
-import { WorkflowValidationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-validation/workflow-validation.workspace-service';
-import {
- type WorkflowAiAgentAction,
- type WorkflowCodeAction,
- type WorkflowFindRecordsAction,
- type WorkflowHttpRequestAction,
- type WorkflowIteratorAction,
- type WorkflowLogicFunctionAction,
-} from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import {
- type WorkflowTrigger,
- WorkflowTriggerType,
-} from 'src/modules/workflow/workflow-trigger/types/workflow-trigger.type';
-import { WorkflowActionType } from 'twenty-shared/workflow';
-
-const WORKSPACE_ID = 'workspace-id';
-
-const ERROR_HANDLING_OPTIONS = {
- retryOnFailure: { value: false },
- continueOnFailure: { value: false },
-};
-
-const buildService = ({
- objectIdByNameSingular = {},
- logicFunction = null,
-}: {
- objectIdByNameSingular?: Record<string, string>;
- logicFunction?: object | null;
-} = {}) => {
- const workflowCommonWorkspaceService = {
- getWorkflowVersionOrFail: jest.fn(),
- getFlatEntityMaps: jest.fn().mockResolvedValue({ objectIdByNameSingular }),
- getLogicFunctionById: jest
- .fn()
- .mockResolvedValue(logicFunction ?? undefined),
- } as unknown as jest.Mocked<WorkflowCommonWorkspaceService>;
-
- const workflowSchemaWorkspaceService = {
- computeStepOutputSchema: jest.fn().mockResolvedValue(undefined),
- } as unknown as jest.Mocked<WorkflowSchemaWorkspaceService>;
-
- return new WorkflowValidationWorkspaceService(
- workflowCommonWorkspaceService,
- workflowSchemaWorkspaceService,
- );
-};
-
-const buildAiAgentStep = (input: {
- agentId?: string;
- prompt?: string;
-}): WorkflowAiAgentAction => ({
- id: 'ai-agent-step',
- name: 'AI Agent',
- type: WorkflowActionType.AI_AGENT,
- valid: true,
- settings: {
- input,
- outputSchema: {
- result: { isLeaf: true, type: 'string', label: 'result', value: '' },
- },
- errorHandlingOptions: ERROR_HANDLING_OPTIONS,
- },
-});
-
-const buildHttpRequestStep = (
- outputSchema: OutputSchema = {},
-): WorkflowHttpRequestAction => ({
- id: 'http-request-step',
- name: 'HTTP Request',
- type: WorkflowActionType.HTTP_REQUEST,
- valid: true,
- settings: {
- input: {
- url: 'https://example.com',
- method: 'GET',
- headers: {},
- body: {},
- },
- outputSchema,
- errorHandlingOptions: ERROR_HANDLING_OPTIONS,
- },
-});
-
-const buildWebhookTrigger = (outputSchema: object = {}): WorkflowTrigger =>
- ({
- type: WorkflowTriggerType.WEBHOOK,
- name: 'Webhook',
- settings: {
- outputSchema,
- httpMethod: 'GET',
- authentication: null,
- },
- }) as unknown as WorkflowTrigger;
-
-const buildFindRecordsStep = (
- objectName: string,
-): WorkflowFindRecordsAction => ({
- id: 'find-records-step',
- name: 'Find Records',
- type: WorkflowActionType.FIND_RECORDS,
- valid: true,
- settings: {
- input: { objectName },
- outputSchema: {},
- errorHandlingOptions: ERROR_HANDLING_OPTIONS,
- },
-});
-
-const buildCodeStep = (expectedOutputSchema?: object): WorkflowCodeAction => ({
- id: 'code-step',
- name: 'Code',
- type: WorkflowActionType.CODE,
- valid: true,
- settings: {
- input: {
- logicFunctionId: 'logic-function-id',
- logicFunctionInput: {},
- },
- outputSchema: {},
- ...(expectedOutputSchema ? { expectedOutputSchema } : {}),
- errorHandlingOptions: ERROR_HANDLING_OPTIONS,
- },
-});
-
-const FIND_RECORDS_OUTPUT_SCHEMA = {
- first: {
- isLeaf: false,
- label: 'First',
- value: {
- _outputSchemaType: 'RECORD',
- object: { objectMetadataId: 'company-metadata-id', label: 'Company' },
- fields: {
- name: {
- isLeaf: true,
- type: 'TEXT',
- label: 'Company Name',
- value: 'Acme',
- fieldMetadataId: 'company-name-id',
- isCompositeSubField: false,
- },
- },
- },
- },
- all: {
- isLeaf: true,
- label: 'All',
- value: 'Returns an array of records',
- type: 'array',
- },
- totalCount: {
- isLeaf: true,
- label: 'Total Count',
- value: 42,
- type: 'number',
- },
-};
-
-const buildFindRecordsStepWithOutputSchema = (
- outputSchema: object,
-): WorkflowFindRecordsAction => ({
- id: 'find-records-step',
- name: 'Find Records',
- type: WorkflowActionType.FIND_RECORDS,
- valid: true,
- settings: {
- input: { objectName: 'company' },
- outputSchema: outputSchema as OutputSchema,
- errorHandlingOptions: ERROR_HANDLING_OPTIONS,
- },
-});
-
-const buildIteratorStep = (items: string | unknown[]): WorkflowIteratorAction =>
- ({
- id: 'iterator-step',
- name: 'Iterator',
- type: WorkflowActionType.ITERATOR,
- valid: true,
- settings: {
- input: { items, initialLoopStepIds: ['body-step'] },
- errorHandlingOptions: ERROR_HANDLING_OPTIONS,
- },
- }) as unknown as WorkflowIteratorAction;
-
-const buildLogicFunctionDefinition = (
- properties: Record<string, { type: string; label: string }>,
-): object => ({
- workflowActionTriggerSettings: {
- outputSchema: [{ type: 'object', label: 'Output', properties }],
- },
-});
-
-const buildLogicFunctionStep = (
- expectedOutputSchema?: object,
-): WorkflowLogicFunctionAction => ({
- id: 'logic-function-step',
- name: 'Logic Function',
- type: WorkflowActionType.LOGIC_FUNCTION,
- valid: true,
- settings: {
- input: {
- logicFunctionId: 'logic-function-id',
- logicFunctionInput: {},
- },
- outputSchema: {},
- ...(expectedOutputSchema ? { expectedOutputSchema } : {}),
- errorHandlingOptions: ERROR_HANDLING_OPTIONS,
- },
-});
-
-describe('WorkflowValidationWorkspaceService', () => {
- it('should flag an AI Agent step that has no agent selected', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildAiAgentStep({})],
- });
-
- expect(result.errors.map((issue) => issue.code)).toContain(
- 'AI_AGENT_MISSING_AGENT',
- );
- });
-
- it('should not flag an AI Agent step that has an agent selected', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildAiAgentStep({ agentId: 'agent-1' })],
- });
-
- expect(result.errors.map((issue) => issue.code)).not.toContain(
- 'AI_AGENT_MISSING_AGENT',
- );
- });
-
- it('should flag a record step targeting an object that does not exist in the workspace', async () => {
- const service = buildService({ objectIdByNameSingular: {} });
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildFindRecordsStep('ghost')],
- });
-
- expect(
- result.errors.some((issue) =>
- issue.message.includes('does not exist in this workspace'),
- ),
- ).toBe(true);
- });
-
- it('should not flag a record step targeting an existing object', async () => {
- const service = buildService({
- objectIdByNameSingular: { person: 'object-id-1' },
- });
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildFindRecordsStep('person')],
- });
-
- expect(
- result.errors.some((issue) =>
- issue.message.includes('does not exist in this workspace'),
- ),
- ).toBe(false);
- });
-
- it('should error about a code step that has no output schema', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildCodeStep()],
- });
-
- expect(result.errors.map((issue) => issue.code)).toContain(
- 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- );
- });
-
- it('should not warn about a code step that declares an expected output schema', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildCodeStep({ greeting: 'hello' })],
- });
-
- expect(result.warnings.map((issue) => issue.code)).not.toContain(
- 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- );
- });
-
- it('should error about a logic function step with no output schema from any source', async () => {
- const service = buildService({ logicFunction: null });
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildLogicFunctionStep()],
- });
-
- expect(result.errors.map((issue) => issue.code)).toContain(
- 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- );
- });
-
- it('should not warn about a logic function step whose definition declares an output schema', async () => {
- const service = buildService({
- logicFunction: buildLogicFunctionDefinition({
- result: { type: 'string', label: 'result' },
- }),
- });
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildLogicFunctionStep()],
- });
-
- expect(result.warnings.map((issue) => issue.code)).not.toContain(
- 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- );
- });
-
- it('should not warn about a logic function step that declares an expected output schema on the step', async () => {
- const service = buildService({ logicFunction: null });
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildLogicFunctionStep({ greeting: 'hello' })],
- });
-
- expect(result.warnings.map((issue) => issue.code)).not.toContain(
- 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- );
- });
-
- it('should warn when the logic function step expected output schema does not match the declared output schema', async () => {
- const service = buildService({
- logicFunction: buildLogicFunctionDefinition({
- result: { type: 'string', label: 'result' },
- }),
- });
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildLogicFunctionStep({ result: 123 })],
- });
-
- expect(result.warnings.map((issue) => issue.code)).toContain(
- 'LOGIC_FUNCTION_OUTPUT_SCHEMA_MISMATCH',
- );
- });
-
- it('should not warn when the logic function step expected output schema matches the declared output schema', async () => {
- const service = buildService({
- logicFunction: buildLogicFunctionDefinition({
- result: { type: 'string', label: 'result' },
- }),
- });
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildLogicFunctionStep({ result: 'hello' })],
- });
-
- expect(result.warnings.map((issue) => issue.code)).not.toContain(
- 'LOGIC_FUNCTION_OUTPUT_SCHEMA_MISMATCH',
- );
- });
-
- it('should error about an HTTP request step that has no output schema', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildHttpRequestStep({})],
- });
-
- expect(result.errors.map((issue) => issue.code)).toContain(
- 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- );
- });
-
- it('should not error about an HTTP request step that declares an output schema', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [
- buildHttpRequestStep({
- status: { isLeaf: true, type: 'number', label: 'status', value: 200 },
- }),
- ],
- });
-
- expect(result.errors.map((issue) => issue.code)).not.toContain(
- 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- );
- });
-
- it('should warn when a variable-consuming step references no variable', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildHttpRequestStep({})],
- });
-
- expect(result.warnings.map((issue) => issue.code)).toContain(
- 'STEP_HAS_NO_VARIABLE_REFERENCE',
- );
- });
-
- it('should not warn about a missing variable reference when the step references a variable', async () => {
- const service = buildService();
-
- const httpRequestStepWithVariable = buildHttpRequestStep({});
-
- httpRequestStepWithVariable.settings.input.body = {
- name: '{{trigger.body.name}}',
- };
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [httpRequestStepWithVariable],
- });
-
- expect(result.warnings.map((issue) => issue.code)).not.toContain(
- 'STEP_HAS_NO_VARIABLE_REFERENCE',
- );
- });
-
- it('should error about a webhook trigger that has no output schema', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: buildWebhookTrigger({}),
- steps: [buildFindRecordsStep('person')],
- });
-
- expect(result.errors.map((issue) => issue.code)).toContain(
- 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- );
- });
-
- it('should not error about a webhook trigger that declares an output schema', async () => {
- const service = buildService({
- objectIdByNameSingular: { person: 'object-id-1' },
- });
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: buildWebhookTrigger({
- body: { isLeaf: false, type: 'object', label: 'body', value: {} },
- }),
- steps: [buildFindRecordsStep('person')],
- });
-
- expect(result.errors.map((issue) => issue.code)).not.toContain(
- 'CODE_STEP_MISSING_OUTPUT_SCHEMA',
- );
- });
-
- it('should flag an iterator whose items reference a non-array path and suggest array paths', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [
- buildFindRecordsStepWithOutputSchema(FIND_RECORDS_OUTPUT_SCHEMA),
- buildIteratorStep('{{find-records-step.first}}'),
- ],
- });
-
- const iteratorIssue = result.errors.find(
- (issue) => issue.code === 'ITERATOR_ITEMS_NOT_ARRAY',
- );
-
- expect(iteratorIssue).toBeDefined();
- expect(iteratorIssue?.suggestions).toContain('find-records-step.all');
- });
-
- it('should not flag an iterator whose items reference an array path', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [
- buildFindRecordsStepWithOutputSchema(FIND_RECORDS_OUTPUT_SCHEMA),
- buildIteratorStep('{{find-records-step.all}}'),
- ],
- });
-
- expect(result.errors.map((issue) => issue.code)).not.toContain(
- 'ITERATOR_ITEMS_NOT_ARRAY',
- );
- });
-
- it('should not flag an iterator that iterates over an inline array', async () => {
- const service = buildService();
-
- const result = await service.validateWorkflowDefinition({
- workspaceId: WORKSPACE_ID,
- trigger: null,
- steps: [buildIteratorStep(['one', 'two'])],
- });
-
- expect(result.errors.map((issue) => issue.code)).not.toContain(
- 'ITERATOR_ITEMS_NOT_ARRAY',
- );
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-edge/__tests__/workflow-version-edge.workspace-service.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-edge/__tests__/workflow-version-edge.workspace-service.spec.ts
deleted file mode 100644
index 56b9739ee55..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-edge/__tests__/workflow-version-edge.workspace-service.spec.ts
+++ /dev/null
@@ -1,818 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { TRIGGER_STEP_ID, WorkflowActionType } from 'twenty-shared/workflow';
-
-import { WorkflowVersionCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-version-core-sync.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type WorkspaceRepository } from 'src/engine/twenty-orm/repository/workspace.repository';
-import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkflowVersionEdgeWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-edge/workflow-version-edge.workspace-service';
-import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import { WorkflowTriggerType } from 'src/modules/workflow/workflow-trigger/types/workflow-trigger.type';
-
-type MockWorkspaceRepository = Partial<
- WorkspaceRepository<WorkflowVersionWorkspaceEntity>
-> & {
- findOne: jest.Mock;
- update: jest.Mock;
-};
-
-const mockWorkflowVersionId = 'workflow-version-id';
-const mockWorkspaceId = 'workspace-id';
-
-const mockSteps = [
- {
- id: 'step-1',
- type: WorkflowActionType.FORM,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- nextStepIds: ['step-2'],
- },
- {
- id: 'step-2',
- type: WorkflowActionType.SEND_EMAIL,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- nextStepIds: [],
- },
- {
- id: 'step-3',
- type: WorkflowActionType.SEND_EMAIL,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- nextStepIds: [],
- },
-] as WorkflowAction[];
-
-const mockTrigger = {
- type: WorkflowTriggerType.MANUAL,
- settings: {},
- nextStepIds: ['step-1'],
-};
-
-const mockWorkflowVersion = {
- id: mockWorkflowVersionId,
- trigger: mockTrigger,
- steps: mockSteps,
- status: 'DRAFT',
-} as WorkflowVersionWorkspaceEntity;
-
-describe('WorkflowVersionEdgeWorkspaceService', () => {
- let globalWorkspaceOrmManager: jest.Mocked<GlobalWorkspaceOrmManager>;
- let workflowCommonWorkspaceService: jest.Mocked<WorkflowCommonWorkspaceService>;
- let service: WorkflowVersionEdgeWorkspaceService;
- let mockWorkflowVersionWorkspaceRepository: MockWorkspaceRepository;
-
- beforeEach(async () => {
- mockWorkflowVersionWorkspaceRepository = {
- findOne: jest.fn(),
- update: jest.fn(),
- };
-
- mockWorkflowVersionWorkspaceRepository.findOne.mockResolvedValue(
- mockWorkflowVersion,
- );
-
- globalWorkspaceOrmManager = {
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation(async (callback: () => any, _authContext?: any) =>
- callback(),
- ),
- getRepository: jest
- .fn()
- .mockResolvedValue(mockWorkflowVersionWorkspaceRepository),
- } as unknown as jest.Mocked<GlobalWorkspaceOrmManager>;
-
- workflowCommonWorkspaceService = {
- getWorkflowVersionOrFail: jest
- .fn()
- .mockResolvedValue(mockWorkflowVersion),
- } as unknown as jest.Mocked<WorkflowCommonWorkspaceService>;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkflowVersionEdgeWorkspaceService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: globalWorkspaceOrmManager,
- },
- {
- provide: WorkflowCommonWorkspaceService,
- useValue: workflowCommonWorkspaceService,
- },
- {
- provide: WorkflowVersionCoreSyncService,
- useValue: {
- writeWorkflowVersionAndMirror: jest.fn(
- async (_workspaceId: string, write: any) => {
- await write(mockWorkflowVersionWorkspaceRepository, {});
- },
- ),
- mirrorWorkflowVersionWrite: jest.fn(),
- invalidateAutomatedTriggerMaps: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get(WorkflowVersionEdgeWorkspaceService);
- });
-
- describe('createWorkflowVersionEdge', () => {
- it('should throw if target does not exists', async () => {
- const call = async () =>
- await service.createWorkflowVersionEdge({
- source: TRIGGER_STEP_ID,
- target: 'not-existing-step',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- await expect(call).rejects.toThrow(
- `Target step 'not-existing-step' not found in workflowVersion '${mockWorkflowVersionId}'`,
- );
- });
-
- it('should throw if trigger is not found', async () => {
- const mockWorkflowVersionWithoutTrigger = {
- ...mockWorkflowVersion,
- trigger: null,
- } as WorkflowVersionWorkspaceEntity;
-
- workflowCommonWorkspaceService.getWorkflowVersionOrFail.mockResolvedValue(
- mockWorkflowVersionWithoutTrigger,
- );
-
- const call = async () =>
- await service.createWorkflowVersionEdge({
- source: TRIGGER_STEP_ID,
- target: 'step-1',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- await expect(call).rejects.toThrow(
- `Trigger not found in workflowVersion '${mockWorkflowVersionId}'`,
- );
- });
-
- describe('with source is the trigger', () => {
- it('should create an edge between trigger and step-1', async () => {
- const result = await service.createWorkflowVersionEdge({
- source: TRIGGER_STEP_ID,
- target: 'step-3',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- workflowCommonWorkspaceService.getWorkflowVersionOrFail,
- ).toHaveBeenCalledWith({
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).toHaveBeenCalledWith(
- mockWorkflowVersionId,
- {
- trigger: {
- ...mockTrigger,
- nextStepIds: ['step-1', 'step-3'],
- },
- },
- undefined,
- expect.anything(),
- );
-
- expect(result).toEqual({
- triggerDiff: [
- {
- path: ['trigger', 'nextStepIds', 1],
- type: 'CREATE',
- value: 'step-3',
- },
- ],
- stepsDiff: [],
- });
- });
-
- it('should not duplicate stepIds if edge already exists', async () => {
- const result = await service.createWorkflowVersionEdge({
- source: TRIGGER_STEP_ID,
- target: 'step-1',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).not.toHaveBeenCalled();
-
- expect(result).toEqual({
- triggerDiff: [],
- stepsDiff: [],
- });
- });
- });
-
- describe('with source is a step', () => {
- describe('with iterator step', () => {
- const mockIteratorStep = {
- id: 'iterator-step',
- type: WorkflowActionType.ITERATOR,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- input: {
- initialLoopStepIds: ['step-1'],
- },
- },
- nextStepIds: ['step-2'],
- } as WorkflowAction;
-
- beforeEach(() => {
- const mockStepsWithIterator = [...mockSteps, mockIteratorStep];
- const mockWorkflowVersionWithIterator = {
- ...mockWorkflowVersion,
- steps: mockStepsWithIterator,
- } as WorkflowVersionWorkspaceEntity;
-
- workflowCommonWorkspaceService.getWorkflowVersionOrFail.mockResolvedValue(
- mockWorkflowVersionWithIterator,
- );
- });
-
- it('should add target to initialLoopStepIds when isConnectedToLoop is true', async () => {
- const result = await service.createWorkflowVersionEdge({
- source: 'iterator-step',
- target: 'step-3',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- sourceConnectionOptions: {
- connectedStepType: WorkflowActionType.ITERATOR,
- settings: {
- isConnectedToLoop: true,
- },
- },
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).toHaveBeenCalledWith(
- mockWorkflowVersionId,
- {
- steps: expect.arrayContaining([
- expect.objectContaining({
- id: 'iterator-step',
- settings: expect.objectContaining({
- input: expect.objectContaining({
- initialLoopStepIds: ['step-1', 'step-3'],
- }),
- }),
- }),
- ]),
- },
- undefined,
- expect.anything(),
- );
-
- expect(result).toEqual({
- stepsDiff: [
- {
- path: [
- 'steps',
- 3,
- 'settings',
- 'input',
- 'initialLoopStepIds',
- 1,
- ],
- type: 'CREATE',
- value: 'step-3',
- },
- ],
- triggerDiff: [],
- });
- });
-
- it('should not duplicate target in initialLoopStepIds when it already exists', async () => {
- const result = await service.createWorkflowVersionEdge({
- source: 'iterator-step',
- target: 'step-1',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- sourceConnectionOptions: {
- connectedStepType: WorkflowActionType.ITERATOR,
- settings: {
- isConnectedToLoop: true,
- },
- },
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).not.toHaveBeenCalled();
-
- expect(result).toEqual({
- stepsDiff: [],
- triggerDiff: [],
- });
- });
-
- it('should throw if source is not an iterator but connection options are for iterator', async () => {
- const call = async () =>
- await service.createWorkflowVersionEdge({
- source: 'step-1',
- target: 'step-3',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- sourceConnectionOptions: {
- connectedStepType: WorkflowActionType.ITERATOR,
- settings: {
- isConnectedToLoop: true,
- },
- },
- });
-
- await expect(call).rejects.toThrow(
- `Source step 'step-1' is not an iterator`,
- );
- });
-
- it('should create normal edge when isConnectedToLoop is false', async () => {
- const result = await service.createWorkflowVersionEdge({
- source: 'iterator-step',
- target: 'step-3',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- sourceConnectionOptions: {
- connectedStepType: WorkflowActionType.ITERATOR,
- settings: {
- isConnectedToLoop: false,
- },
- },
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).toHaveBeenCalledWith(
- mockWorkflowVersionId,
- {
- steps: expect.arrayContaining([
- expect.objectContaining({
- id: 'iterator-step',
- nextStepIds: ['step-2', 'step-3'],
- }),
- ]),
- },
- undefined,
- expect.anything(),
- );
-
- expect(result).toEqual({
- stepsDiff: [
- {
- path: ['steps', 3, 'nextStepIds', 1],
- type: 'CREATE',
- value: 'step-3',
- },
- ],
- triggerDiff: [],
- });
- });
- });
-
- it('should create an edge between step-2 and step-3', async () => {
- const result = await service.createWorkflowVersionEdge({
- source: 'step-2',
- target: 'step-3',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).toHaveBeenCalledWith(
- mockWorkflowVersionId,
- {
- steps: mockSteps.map((step) => {
- if (step.id === 'step-2') {
- return {
- ...step,
- nextStepIds: ['step-3'],
- };
- }
-
- return step;
- }),
- },
- undefined,
- expect.anything(),
- );
-
- expect(result).toEqual({
- stepsDiff: [
- {
- path: ['steps', 1, 'nextStepIds', 0],
- type: 'CREATE',
- value: 'step-3',
- },
- ],
- triggerDiff: [],
- });
- });
-
- it('should not duplicate if edge already exist between 2 steps', async () => {
- const result = await service.createWorkflowVersionEdge({
- source: 'step-1',
- target: 'step-2',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).not.toHaveBeenCalled();
-
- expect(result).toEqual({
- stepsDiff: [],
- triggerDiff: [],
- });
- });
-
- it('should throw if source step does not exists', async () => {
- const call = async () =>
- await service.createWorkflowVersionEdge({
- source: 'not-existing-step',
- target: 'step-2',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- await expect(call).rejects.toThrow(
- `Source step 'not-existing-step' not found in workflowVersion '${mockWorkflowVersionId}'`,
- );
- });
- });
- });
-
- describe('deleteWorkflowVersionEdge', () => {
- it('should throw if target does not exists', async () => {
- const call = async () =>
- await service.deleteWorkflowVersionEdge({
- source: TRIGGER_STEP_ID,
- target: 'not-existing-step',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- await expect(call).rejects.toThrow(
- `Target step 'not-existing-step' not found in workflowVersion '${mockWorkflowVersionId}'`,
- );
- });
-
- describe('with source is the trigger', () => {
- it('should delete an edge between trigger and step-1', async () => {
- const result = await service.deleteWorkflowVersionEdge({
- source: TRIGGER_STEP_ID,
- target: 'step-1',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- workflowCommonWorkspaceService.getWorkflowVersionOrFail,
- ).toHaveBeenCalledWith({
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).toHaveBeenCalledWith(
- mockWorkflowVersionId,
- {
- trigger: {
- ...mockTrigger,
- nextStepIds: [],
- },
- },
- undefined,
- expect.anything(),
- );
-
- expect(result).toEqual({
- triggerDiff: [
- {
- oldValue: 'step-1',
- path: ['trigger', 'nextStepIds', 0],
- type: 'REMOVE',
- },
- ],
- stepsDiff: [],
- });
- });
-
- it('should not delete if edge does not exists', async () => {
- const result = await service.deleteWorkflowVersionEdge({
- source: TRIGGER_STEP_ID,
- target: 'step-2',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- workflowCommonWorkspaceService.getWorkflowVersionOrFail,
- ).toHaveBeenCalledWith({
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).not.toHaveBeenCalled();
-
- expect(result).toEqual({
- stepsDiff: [],
- triggerDiff: [],
- });
- });
- });
-
- describe('with source is a step', () => {
- it('should delete an existing edge between two steps', async () => {
- const result = await service.deleteWorkflowVersionEdge({
- source: 'step-1',
- target: 'step-2',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).toHaveBeenCalledWith(
- mockWorkflowVersionId,
- {
- steps: mockSteps.map((step) => {
- if (step.id === 'step-1') {
- return {
- ...step,
- nextStepIds: [],
- };
- }
-
- return step;
- }),
- },
- undefined,
- expect.anything(),
- );
-
- expect(result).toEqual({
- stepsDiff: [
- {
- oldValue: 'step-2',
- path: ['steps', 0, 'nextStepIds', 0],
- type: 'REMOVE',
- },
- ],
- triggerDiff: [],
- });
- });
-
- it('should not delete if edge does not exist', async () => {
- const result = await service.deleteWorkflowVersionEdge({
- source: 'step-1',
- target: 'step-3',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).not.toHaveBeenCalledWith();
-
- expect(result).toEqual({
- stepsDiff: [],
- triggerDiff: [],
- });
- });
-
- it('should throw if source step does not exists', async () => {
- const call = async () =>
- await service.deleteWorkflowVersionEdge({
- source: 'not-existing-step',
- target: 'step-2',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- await expect(call).rejects.toThrow(
- `Source step 'not-existing-step' not found in workflowVersion '${mockWorkflowVersionId}'`,
- );
- });
- });
-
- describe('with sourceConnectionOptions', () => {
- describe('with iterator step', () => {
- const mockIteratorStep = {
- id: 'iterator-step',
- type: WorkflowActionType.ITERATOR,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- input: {
- initialLoopStepIds: ['step-2', 'step-3'],
- },
- },
- nextStepIds: ['step-1'],
- } as WorkflowAction;
-
- const mockStepsWithIterator = [mockIteratorStep, ...mockSteps];
-
- const mockWorkflowVersionWithIterator = {
- ...mockWorkflowVersion,
- steps: mockStepsWithIterator,
- };
-
- beforeEach(() => {
- workflowCommonWorkspaceService.getWorkflowVersionOrFail.mockResolvedValue(
- mockWorkflowVersionWithIterator,
- );
- });
-
- it('should throw if source step is not an iterator when connectedStepType is ITERATOR', async () => {
- const call = async () =>
- await service.deleteWorkflowVersionEdge({
- source: 'step-1',
- target: 'step-2',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- sourceConnectionOptions: {
- connectedStepType: WorkflowActionType.ITERATOR,
- settings: {
- isConnectedToLoop: true,
- },
- },
- });
-
- await expect(call).rejects.toThrow(
- `Source step 'step-1' is not an iterator`,
- );
- });
-
- it('should remove target from initialLoopStepIds when isConnectedToLoop is true', async () => {
- const result = await service.deleteWorkflowVersionEdge({
- source: 'iterator-step',
- target: 'step-2',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- sourceConnectionOptions: {
- connectedStepType: WorkflowActionType.ITERATOR,
- settings: {
- isConnectedToLoop: true,
- },
- },
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).toHaveBeenCalledWith(
- mockWorkflowVersionId,
- {
- steps: expect.arrayContaining([
- expect.objectContaining({
- id: 'iterator-step',
- settings: expect.objectContaining({
- input: expect.objectContaining({
- initialLoopStepIds: ['step-3'],
- }),
- }),
- }),
- ]),
- },
- undefined,
- expect.anything(),
- );
-
- expect(result).toEqual({
- stepsDiff: [
- {
- oldValue: 'step-2',
- path: [
- 'steps',
- 0,
- 'settings',
- 'input',
- 'initialLoopStepIds',
- 0,
- ],
- type: 'CHANGE',
- value: 'step-3',
- },
- {
- oldValue: 'step-3',
- path: [
- 'steps',
- 0,
- 'settings',
- 'input',
- 'initialLoopStepIds',
- 1,
- ],
- type: 'REMOVE',
- },
- ],
- triggerDiff: [],
- });
- });
-
- it('should not update if target is not in initialLoopStepIds when isConnectedToLoop is true', async () => {
- const result = await service.deleteWorkflowVersionEdge({
- source: 'iterator-step',
- target: 'step-1',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- sourceConnectionOptions: {
- connectedStepType: WorkflowActionType.ITERATOR,
- settings: {
- isConnectedToLoop: true,
- },
- },
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).not.toHaveBeenCalled();
-
- expect(result).toEqual({
- stepsDiff: [],
- triggerDiff: [],
- });
- });
-
- it('should remove target from nextStepIds when isConnectedToLoop is false', async () => {
- const result = await service.deleteWorkflowVersionEdge({
- source: 'iterator-step',
- target: 'step-1',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- sourceConnectionOptions: {
- connectedStepType: WorkflowActionType.ITERATOR,
- settings: {
- isConnectedToLoop: false,
- },
- },
- });
-
- expect(
- mockWorkflowVersionWorkspaceRepository.update,
- ).toHaveBeenCalledWith(
- mockWorkflowVersionId,
- {
- steps: expect.arrayContaining([
- expect.objectContaining({
- id: 'iterator-step',
- nextStepIds: [],
- }),
- ]),
- },
- undefined,
- expect.anything(),
- );
-
- expect(result).toEqual({
- stepsDiff: [
- {
- oldValue: 'step-1',
- path: ['steps', 0, 'nextStepIds', 0],
- type: 'REMOVE',
- },
- ],
- triggerDiff: [],
- });
- });
- });
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/__tests__/workflow-version-step-operations.workspace-service.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/__tests__/workflow-version-step-operations.workspace-service.spec.ts
deleted file mode 100644
index e49ad60f008..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/__tests__/workflow-version-step-operations.workspace-service.spec.ts
+++ /dev/null
@@ -1,484 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-import { getRepositoryToken } from '@nestjs/typeorm';
-
-import { WorkflowActionType } from 'twenty-shared/workflow';
-import { SEED_WORKFLOW_ACTION_TRIGGER_SETTINGS } from 'twenty-shared/logic-function';
-
-import { AiAgentRoleService } from 'src/engine/metadata-modules/ai/ai-agent-role/ai-agent-role.service';
-import { AgentService } from 'src/engine/metadata-modules/ai/ai-agent/agent.service';
-import { AiModelRegistryService } from 'src/engine/metadata-modules/ai/ai-models/services/ai-model-registry.service';
-import { WorkflowVersionCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-version-core-sync.service';
-import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity';
-import { createEmptyAllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/constant/create-empty-all-flat-entity-maps.constant';
-import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
-import { LogicFunctionRuntime } from 'src/engine/metadata-modules/logic-function/logic-function.entity';
-import { LogicFunctionFromSourceService } from 'src/engine/metadata-modules/logic-function/services/logic-function-from-source.service';
-import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
-import { RoleTargetEntity } from 'src/engine/metadata-modules/role-target/role-target.entity';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { getWorkspaceScopedRepositoryToken } from 'src/engine/twenty-orm/workspace-scoped-repository/get-workspace-scoped-repository-token.util';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { CodeStepBuildService } from 'src/modules/workflow/workflow-builder/workflow-version-step/code-step/services/code-step-build.service';
-import { WorkflowVersionStepOperationsWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step-operations.workspace-service';
-import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-
-const mockWorkspaceId = 'workspace-id';
-
-describe('WorkflowVersionStepOperationsWorkspaceService', () => {
- let service: WorkflowVersionStepOperationsWorkspaceService;
- let globalWorkspaceOrmManager: jest.Mocked<GlobalWorkspaceOrmManager>;
- let logicFunctionFromSourceService: jest.Mocked<LogicFunctionFromSourceService>;
- let codeStepBuildService: jest.Mocked<CodeStepBuildService>;
- let agentService: jest.Mocked<AgentService>;
- let roleTargetRepository: jest.Mocked<any>;
- let objectMetadataRepository: jest.Mocked<any>;
- let workflowCommonWorkspaceService: jest.Mocked<WorkflowCommonWorkspaceService>;
- let aiAgentRoleService: jest.Mocked<AiAgentRoleService>;
- let workspaceCacheService: jest.Mocked<WorkspaceCacheService>;
- let aiModelRegistryService: jest.Mocked<AiModelRegistryService>;
- let workspaceRepository: jest.Mocked<any>;
-
- beforeEach(async () => {
- codeStepBuildService = {
- seedCodeStepFiles: jest.fn().mockResolvedValue({
- sourceHandlerPath: 'workflow/logic-fn-id/src/index.ts',
- builtHandlerPath: 'workflow/logic-fn-id/src/index.mjs',
- checksum: 'seed-checksum',
- }),
- createCodeStepLogicFunction: jest.fn().mockResolvedValue({
- id: 'new-function-id',
- name: 'Test Function',
- description: 'Test Description',
- workspaceId: mockWorkspaceId,
- createdAt: new Date().toISOString(),
- updatedAt: new Date().toISOString(),
- deletedAt: null,
- runtime: LogicFunctionRuntime.NODE22,
- timeoutSeconds: 30,
- sourceHandlerPath: 'src/index.ts',
- builtHandlerPath: 'index.mjs',
- handlerName: 'main',
- checksum: null,
- toolTriggerSettings: null,
- workflowActionTriggerSettings: SEED_WORKFLOW_ACTION_TRIGGER_SETTINGS,
- universalIdentifier: 'universal-id',
- applicationId: 'application-id',
- cronTriggerSettings: null,
- databaseEventTriggerSettings: null,
- httpRouteTriggerSettings: null,
- }),
- copySourceAndBuiltForNewCodeStep: jest.fn().mockResolvedValue(undefined),
- duplicateCodeStepLogicFunction: jest.fn().mockResolvedValue({
- id: 'new-function-id',
- name: 'Test Function',
- description: 'Test Description',
- workspaceId: mockWorkspaceId,
- createdAt: new Date().toISOString(),
- updatedAt: new Date().toISOString(),
- deletedAt: null,
- runtime: LogicFunctionRuntime.NODE22,
- timeoutSeconds: 30,
- sourceHandlerPath: 'src/index.ts',
- builtHandlerPath: 'index.mjs',
- handlerName: 'main',
- checksum: null,
- toolTriggerSettings: null,
- workflowActionTriggerSettings: null,
- universalIdentifier: 'universal-id',
- applicationId: 'application-id',
- cronTriggerSettings: null,
- databaseEventTriggerSettings: null,
- httpRouteTriggerSettings: null,
- }),
- } as unknown as jest.Mocked<CodeStepBuildService>;
-
- logicFunctionFromSourceService = {
- deleteOneWithSource: jest.fn().mockResolvedValue(undefined),
- } as unknown as jest.Mocked<LogicFunctionFromSourceService>;
-
- agentService = {
- deleteManyAgents: jest.fn().mockResolvedValue([]),
- findOneAgentById: jest.fn(),
- createOneAgent: jest.fn(),
- } as unknown as jest.Mocked<AgentService>;
-
- roleTargetRepository = {
- findOne: jest.fn(),
- count: jest.fn(),
- };
-
- objectMetadataRepository = {
- findOne: jest.fn(),
- };
-
- workflowCommonWorkspaceService = {
- getObjectMetadataItemWithFieldsMaps: jest.fn(),
- } as unknown as jest.Mocked<WorkflowCommonWorkspaceService>;
-
- aiAgentRoleService = {
- deleteAgentOnlyRoleIfUnused: jest.fn(),
- } as unknown as jest.Mocked<AiAgentRoleService>;
-
- globalWorkspaceOrmManager = {
- getRepository: jest.fn(),
- } as unknown as jest.Mocked<GlobalWorkspaceOrmManager>;
- workspaceCacheService = {
- flush: jest.fn(),
- } as unknown as jest.Mocked<WorkspaceCacheService>;
-
- aiModelRegistryService = {
- getEffectiveModelConfig: jest.fn(),
- validateModelAvailability: jest.fn(),
- } as unknown as jest.Mocked<AiModelRegistryService>;
-
- workspaceRepository = {
- findOneBy: jest.fn().mockResolvedValue(null),
- };
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkflowVersionStepOperationsWorkspaceService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: globalWorkspaceOrmManager,
- },
- {
- provide: LogicFunctionFromSourceService,
- useValue: logicFunctionFromSourceService,
- },
- {
- provide: CodeStepBuildService,
- useValue: codeStepBuildService,
- },
- {
- provide: AgentService,
- useValue: agentService,
- },
- {
- provide: getWorkspaceScopedRepositoryToken(RoleTargetEntity),
- useValue: roleTargetRepository,
- },
- {
- provide: getRepositoryToken(ObjectMetadataEntity),
- useValue: objectMetadataRepository,
- },
- {
- provide: getRepositoryToken(WorkspaceEntity),
- useValue: workspaceRepository,
- },
- {
- provide: AiModelRegistryService,
- useValue: aiModelRegistryService,
- },
- {
- provide: WorkflowCommonWorkspaceService,
- useValue: workflowCommonWorkspaceService,
- },
- {
- provide: AiAgentRoleService,
- useValue: aiAgentRoleService,
- },
- {
- provide: WorkspaceCacheService,
- useValue: workspaceCacheService,
- },
- {
- provide: WorkspaceManyOrAllFlatEntityMapsCacheService,
- useValue: {
- flushFlatEntityMaps: jest.fn(),
- getOrRecomputeManyOrAllFlatEntityMaps: jest
- .fn()
- .mockResolvedValue(createEmptyAllFlatEntityMaps()),
- },
- },
- {
- provide: WorkflowVersionCoreSyncService,
- useValue: {
- writeWorkflowVersionAndMirror: jest.fn(
- async (_workspaceId: string, write: any) => {
- const scopedRepository =
- (await globalWorkspaceOrmManager.getRepository(
- _workspaceId,
- 'workflowVersion',
- { shouldBypassPermissionChecks: true },
- )) ?? {};
-
- return write(scopedRepository, {});
- },
- ),
- mirrorWorkflowVersionWrite: jest.fn(),
- invalidateAutomatedTriggerMaps: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get(WorkflowVersionStepOperationsWorkspaceService);
- });
-
- describe('runWorkflowVersionStepDeletionSideEffects', () => {
- it('should delete logic function when deleting code step', async () => {
- const step = {
- id: 'step-id',
- name: 'Code Step',
- type: WorkflowActionType.CODE,
- valid: true,
- nextStepIds: [],
- settings: {
- input: {
- logicFunctionId: '550e8400-e29b-41d4-a716-446655440000',
- },
- outputSchema: {},
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- } as unknown as WorkflowAction;
-
- await service.runWorkflowVersionStepDeletionSideEffects({
- step,
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- logicFunctionFromSourceService.deleteOneWithSource,
- ).toHaveBeenCalledWith({
- id: '550e8400-e29b-41d4-a716-446655440000',
- workspaceId: mockWorkspaceId,
- });
- });
-
- it('should delete agent when deleting AI agent step', async () => {
- const step = {
- id: 'step-id',
- name: 'AI Agent Step',
- type: WorkflowActionType.AI_AGENT,
- valid: true,
- nextStepIds: [],
- settings: {
- input: {
- agentId: 'agent-id',
- prompt: '',
- },
- outputSchema: {},
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- } as unknown as WorkflowAction;
-
- await service.runWorkflowVersionStepDeletionSideEffects({
- step,
- workspaceId: mockWorkspaceId,
- });
-
- expect(agentService.deleteManyAgents).toHaveBeenCalledWith({
- ids: ['agent-id'],
- workspaceId: mockWorkspaceId,
- });
- });
-
- it('should delete attached role when it is agent-only and unassigned elsewhere', async () => {
- const step = {
- id: 'step-id',
- name: 'AI Agent Step',
- type: WorkflowActionType.AI_AGENT,
- valid: true,
- nextStepIds: [],
- settings: {
- input: {
- agentId: 'agent-id',
- prompt: '',
- },
- outputSchema: {},
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- } as unknown as WorkflowAction;
-
- roleTargetRepository.findOne.mockResolvedValue({
- id: 'role-target-id',
- roleId: 'role-id',
- });
-
- await service.runWorkflowVersionStepDeletionSideEffects({
- step,
- workspaceId: mockWorkspaceId,
- });
-
- expect(agentService.deleteManyAgents).toHaveBeenCalledWith({
- ids: ['agent-id'],
- workspaceId: mockWorkspaceId,
- });
- expect(
- aiAgentRoleService.deleteAgentOnlyRoleIfUnused,
- ).toHaveBeenCalledWith({
- roleId: 'role-id',
- roleTargetId: 'role-target-id',
- workspaceId: mockWorkspaceId,
- });
- });
- });
-
- describe('runStepCreationSideEffectsAndBuildStep', () => {
- it('should create code step with logic function and seed input fields', async () => {
- const result = await service.runStepCreationSideEffectsAndBuildStep({
- type: WorkflowActionType.CODE,
- workspaceId: mockWorkspaceId,
- workflowVersionId: 'workflow-version-id',
- });
-
- expect(result.builtStep.type).toBe(WorkflowActionType.CODE);
- const codeResult = result.builtStep as unknown as {
- settings: {
- input: {
- logicFunctionId: string;
- logicFunctionInput: Record<string, unknown>;
- };
- };
- };
-
- expect(codeResult.settings.input.logicFunctionId).toBe('new-function-id');
- expect(codeResult.settings.input.logicFunctionInput).toEqual({
- a: null,
- b: null,
- });
- });
-
- it('should create form step', async () => {
- const result = await service.runStepCreationSideEffectsAndBuildStep({
- type: WorkflowActionType.FORM,
- workspaceId: mockWorkspaceId,
- workflowVersionId: 'workflow-version-id',
- });
-
- expect(result.builtStep.type).toBe(WorkflowActionType.FORM);
- expect(result.builtStep.settings.input).toEqual([]);
- });
- });
-
- describe('createStepForDuplicate', () => {
- it('should duplicate code step with new logic function', async () => {
- const originalStep = {
- id: 'original-id',
- type: WorkflowActionType.CODE,
- name: 'Original Step',
- valid: true,
- settings: {
- input: {
- logicFunctionId: 'function-id',
- },
- },
- nextStepIds: ['next-step'],
- } as unknown as WorkflowAction;
-
- const clonedStep = await service.cloneStep({
- step: originalStep,
- workspaceId: mockWorkspaceId,
- });
- const duplicateStep = service.markStepAsDuplicate({
- step: clonedStep,
- });
-
- expect(duplicateStep.id).not.toBe('original-id');
- expect(duplicateStep.name).toBe('Original Step (Duplicate)');
- const codeResult = duplicateStep as unknown as {
- settings: {
- input: {
- logicFunctionId: string;
- };
- };
- };
-
- expect(codeResult.settings.input.logicFunctionId).toBe('new-function-id');
-
- expect(duplicateStep.nextStepIds).toEqual([]);
- expect(
- codeStepBuildService.duplicateCodeStepLogicFunction,
- ).toHaveBeenCalledWith({
- existingLogicFunctionId: 'function-id',
- workspaceId: mockWorkspaceId,
- });
- });
-
- it('should duplicate non-code step', async () => {
- const originalStep = {
- id: 'original-id',
- type: WorkflowActionType.FORM,
- name: 'Original Step',
- valid: true,
- settings: {
- input: [],
- },
- nextStepIds: ['next-step'],
- } as unknown as WorkflowAction;
-
- const clonedStep = await service.cloneStep({
- step: originalStep,
- workspaceId: mockWorkspaceId,
- });
- const duplicateStep = service.markStepAsDuplicate({
- step: clonedStep,
- });
-
- expect(duplicateStep.id).not.toBe('original-id');
- expect(duplicateStep.name).toBe('Original Step (Duplicate)');
- expect(duplicateStep.settings).toEqual(originalStep.settings);
- expect(duplicateStep.nextStepIds).toEqual([]);
- });
-
- it('should duplicate iterator step with cleared initialLoopStepIds', async () => {
- const originalStep = {
- id: 'original-iterator-id',
- type: WorkflowActionType.ITERATOR,
- name: 'Iterator Step',
- valid: true,
- position: { x: 100, y: 200 },
- settings: {
- input: {
- items: ['item1', 'item2', 'item3'],
- initialLoopStepIds: ['loop-step-1', 'loop-step-2'],
- },
- outputSchema: {},
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- nextStepIds: ['next-step'],
- } as unknown as WorkflowAction;
-
- const clonedStep = await service.cloneStep({
- step: originalStep,
- workspaceId: mockWorkspaceId,
- });
-
- expect(clonedStep.id).not.toBe('original-iterator-id');
- expect(clonedStep.type).toBe(WorkflowActionType.ITERATOR);
- expect(clonedStep.nextStepIds).toEqual([]);
- expect(clonedStep.position).toEqual({ x: 100, y: 200 });
-
- const iteratorResult = clonedStep as unknown as {
- settings: {
- input: {
- items: string[];
- initialLoopStepIds: string[];
- };
- };
- };
-
- expect(iteratorResult.settings.input.items).toEqual([
- 'item1',
- 'item2',
- 'item3',
- ]);
-
- expect(iteratorResult.settings.input.initialLoopStepIds).toEqual([]);
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/__tests__/workflow-version-step.workspace-service.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/__tests__/workflow-version-step.workspace-service.spec.ts
deleted file mode 100644
index 67a4f2e8227..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/workflow-version-step/__tests__/workflow-version-step.workspace-service.spec.ts
+++ /dev/null
@@ -1,383 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { TRIGGER_STEP_ID, WorkflowActionType } from 'twenty-shared/workflow';
-
-import { WorkflowVersionCoreSyncService } from 'src/engine/core-modules/workflow/services/workflow-version-core-sync.service';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { type WorkspaceRepository } from 'src/engine/twenty-orm/repository/workspace.repository';
-import { type WorkflowVersionWorkspaceEntity } from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
-import { WorkflowCommonWorkspaceService } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';
-import { WorkflowSchemaWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-schema/workflow-schema.workspace-service';
-import { WorkflowVersionStepCreationWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step-creation.workspace-service';
-import { WorkflowVersionStepDeletionWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step-deletion.workspace-service';
-import { WorkflowVersionStepHelpersWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step-helpers.workspace-service';
-import { WorkflowVersionStepOperationsWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step-operations.workspace-service';
-import { WorkflowVersionStepUpdateWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step-update.workspace-service';
-import { WorkflowVersionStepWorkspaceService } from 'src/modules/workflow/workflow-builder/workflow-version-step/workflow-version-step.workspace-service';
-import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import { WorkflowTriggerType } from 'src/modules/workflow/workflow-trigger/types/workflow-trigger.type';
-
-jest.mock(
- 'src/modules/workflow/workflow-builder/utils/compute-workflow-version-step-updates.util',
- () => ({
- computeWorkflowVersionStepChanges: jest.fn(),
- }),
-);
-
-type MockWorkspaceRepository = Partial<
- WorkspaceRepository<WorkflowVersionWorkspaceEntity>
-> & {
- findOne: jest.Mock;
- update: jest.Mock;
-};
-
-const mockWorkflowVersionId = 'workflow-version-id';
-const mockWorkspaceId = 'workspace-id';
-
-const mockSteps = [
- {
- id: 'step-1',
- type: WorkflowActionType.FORM,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- nextStepIds: ['step-2'],
- },
- {
- id: 'step-2',
- type: WorkflowActionType.SEND_EMAIL,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- nextStepIds: [],
- },
- {
- id: 'step-3',
- type: WorkflowActionType.SEND_EMAIL,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- nextStepIds: [],
- },
-] as WorkflowAction[];
-
-const mockTrigger = {
- type: WorkflowTriggerType.MANUAL,
- settings: {},
- nextStepIds: ['step-1'],
-};
-
-const mockWorkflowVersion = {
- id: mockWorkflowVersionId,
- trigger: mockTrigger,
- steps: mockSteps,
- status: 'DRAFT',
-} as WorkflowVersionWorkspaceEntity;
-
-describe('WorkflowVersionStepWorkspaceService', () => {
- let globalWorkspaceOrmManager: jest.Mocked<GlobalWorkspaceOrmManager>;
- let service: WorkflowVersionStepWorkspaceService;
- let mockWorkflowVersionWorkspaceRepository: MockWorkspaceRepository;
- let mockComputeWorkflowVersionStepChanges: jest.Mock;
-
- beforeEach(async () => {
- const {
- computeWorkflowVersionStepChanges,
- } = require('src/modules/workflow/workflow-builder/utils/compute-workflow-version-step-updates.util');
-
- mockComputeWorkflowVersionStepChanges =
- computeWorkflowVersionStepChanges as jest.Mock;
-
- mockWorkflowVersionWorkspaceRepository = {
- findOne: jest.fn(),
- update: jest.fn(),
- };
-
- mockWorkflowVersionWorkspaceRepository.findOne.mockResolvedValue(
- mockWorkflowVersion,
- );
-
- globalWorkspaceOrmManager = {
- getRepository: jest
- .fn()
- .mockResolvedValue(mockWorkflowVersionWorkspaceRepository),
- executeInWorkspaceContext: jest
- .fn()
-
- .mockImplementation((fn: () => any, _authContext?: any) => fn()),
- } as unknown as jest.Mocked<GlobalWorkspaceOrmManager>;
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkflowVersionStepWorkspaceService,
- WorkflowVersionStepHelpersWorkspaceService,
- WorkflowVersionStepCreationWorkspaceService,
- WorkflowVersionStepUpdateWorkspaceService,
- WorkflowVersionStepDeletionWorkspaceService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: globalWorkspaceOrmManager,
- },
- {
- provide: WorkflowSchemaWorkspaceService,
- useValue: {
- enrichOutputSchema: jest
- .fn()
- .mockImplementation((args) => args.step),
- },
- },
- {
- provide: WorkflowVersionStepOperationsWorkspaceService,
- useValue: {
- runStepCreationSideEffectsAndBuildStep: jest
- .fn()
- .mockImplementation(({ type }) => ({
- builtStep: {
- id: 'new-step-id',
- type,
- settings: {},
- nextStepIds: [],
- },
- additionalCreatedSteps: [],
- })),
- runWorkflowVersionStepDeletionSideEffects: jest.fn(),
- cloneStep: jest.fn().mockImplementation(({ step }) => ({
- ...step,
- id: 'cloned-step-id',
- })),
- markStepAsDuplicate: jest
- .fn()
- .mockImplementation(({ step }) => step),
- createDraftStep: jest.fn().mockImplementation(({ step }) => step),
- },
- },
- {
- provide: WorkflowCommonWorkspaceService,
- useValue: {
- getWorkflowVersionOrFail: jest
- .fn()
- .mockResolvedValue(mockWorkflowVersion),
- },
- },
- {
- provide: WorkflowVersionCoreSyncService,
- useValue: {
- writeWorkflowVersionAndMirror: jest.fn(
- async (_workspaceId: string, write: any) => {
- await write(mockWorkflowVersionWorkspaceRepository, {});
- },
- ),
- mirrorWorkflowVersionWrite: jest.fn(),
- invalidateAutomatedTriggerMaps: jest.fn(),
- },
- },
- ],
- }).compile();
-
- service = module.get(WorkflowVersionStepWorkspaceService);
- });
-
- describe('createWorkflowVersionStep', () => {
- it('should create a step linked to trigger', async () => {
- const mockChanges = {
- triggerDiff: [
- {
- type: 'CHANGE',
- path: ['nextStepIds'],
- value: ['step-1', 'new-step-id'],
- },
- ],
- stepsDiff: [
- {
- type: 'CREATE',
- path: [],
- value: { id: 'new-step-id', type: 'FORM' },
- },
- ],
- };
-
- mockComputeWorkflowVersionStepChanges.mockReturnValue(mockChanges);
-
- const result = await service.createWorkflowVersionStep({
- input: {
- stepType: WorkflowActionType.FORM,
- parentStepId: TRIGGER_STEP_ID,
- nextStepId: undefined,
- workflowVersionId: mockWorkflowVersionId,
- },
- workspaceId: mockWorkspaceId,
- });
-
- expect(mockWorkflowVersionWorkspaceRepository.update).toHaveBeenCalled();
- expect(mockComputeWorkflowVersionStepChanges).toHaveBeenCalled();
-
- expect(result).toEqual(mockChanges);
- expect(result.triggerDiff).toBeDefined();
- expect(result.stepsDiff).toBeDefined();
- });
-
- it('should create a step between a trigger and a step', async () => {
- const mockChanges = {
- triggerDiff: [
- { type: 'CHANGE', path: ['nextStepIds'], value: ['new-step-id'] },
- ],
- stepsDiff: [
- {
- type: 'CREATE',
- path: [],
- value: {
- id: 'new-step-id',
- type: 'FORM',
- nextStepIds: ['step-1'],
- },
- },
- ],
- };
-
- mockComputeWorkflowVersionStepChanges.mockReturnValue(mockChanges);
-
- const result = await service.createWorkflowVersionStep({
- input: {
- stepType: WorkflowActionType.FORM,
- parentStepId: TRIGGER_STEP_ID,
- nextStepId: 'step-1',
- workflowVersionId: mockWorkflowVersionId,
- },
- workspaceId: mockWorkspaceId,
- });
-
- expect(mockWorkflowVersionWorkspaceRepository.update).toHaveBeenCalled();
- expect(mockComputeWorkflowVersionStepChanges).toHaveBeenCalled();
-
- expect(result).toEqual(mockChanges);
- expect(result.triggerDiff).toBeDefined();
- expect(result.stepsDiff).toBeDefined();
- });
-
- it('should create a step between two steps', async () => {
- const mockChanges = {
- triggerDiff: [],
- stepsDiff: [
- { type: 'CHANGE', path: [0, 'nextStepIds'], value: ['new-step-id'] },
- {
- type: 'CREATE',
- path: [],
- value: {
- id: 'new-step-id',
- type: 'FORM',
- nextStepIds: ['step-2'],
- },
- },
- ],
- };
-
- mockComputeWorkflowVersionStepChanges.mockReturnValue(mockChanges);
-
- const result = await service.createWorkflowVersionStep({
- input: {
- stepType: WorkflowActionType.FORM,
- parentStepId: 'step-1',
- nextStepId: 'step-2',
- workflowVersionId: mockWorkflowVersionId,
- },
- workspaceId: mockWorkspaceId,
- });
-
- expect(mockWorkflowVersionWorkspaceRepository.update).toHaveBeenCalled();
- expect(mockComputeWorkflowVersionStepChanges).toHaveBeenCalled();
-
- expect(result).toEqual(mockChanges);
- expect(result.triggerDiff).toBeDefined();
- expect(result.stepsDiff).toBeDefined();
- });
-
- it('should create a step without parent or children', async () => {
- const mockChanges = {
- triggerDiff: [],
- stepsDiff: [
- {
- type: 'CREATE',
- path: [],
- value: { id: 'new-step-id', type: 'FORM' },
- },
- ],
- };
-
- mockComputeWorkflowVersionStepChanges.mockReturnValue(mockChanges);
-
- const result = await service.createWorkflowVersionStep({
- input: {
- stepType: WorkflowActionType.FORM,
- parentStepId: undefined,
- nextStepId: undefined,
- workflowVersionId: mockWorkflowVersionId,
- },
- workspaceId: mockWorkspaceId,
- });
-
- expect(mockWorkflowVersionWorkspaceRepository.update).toHaveBeenCalled();
- expect(mockComputeWorkflowVersionStepChanges).toHaveBeenCalled();
-
- expect(result).toEqual(mockChanges);
- expect(result.triggerDiff).toBeDefined();
- expect(result.stepsDiff).toBeDefined();
- });
- });
-
- describe('deleteWorkflowVersionStep', () => {
- it('should delete step linked to trigger', async () => {
- const mockChanges = {
- triggerDiff: [
- { type: 'CHANGE', path: ['nextStepIds'], value: ['step-2'] },
- ],
- stepsDiff: [{ type: 'REMOVE', path: [0] }],
- };
-
- mockComputeWorkflowVersionStepChanges.mockReturnValue(mockChanges);
-
- const result = await service.deleteWorkflowVersionStep({
- stepIdToDelete: 'step-1',
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(mockWorkflowVersionWorkspaceRepository.update).toHaveBeenCalled();
- expect(mockComputeWorkflowVersionStepChanges).toHaveBeenCalled();
-
- expect(result).toEqual(mockChanges);
- expect(result.triggerDiff).toBeDefined();
- expect(result.stepsDiff).toBeDefined();
- });
-
- it('should delete trigger', async () => {
- const mockChanges = {
- triggerDiff: [{ type: 'REMOVE', path: [] }],
- stepsDiff: [],
- };
-
- mockComputeWorkflowVersionStepChanges.mockReturnValue(mockChanges);
-
- const result = await service.deleteWorkflowVersionStep({
- stepIdToDelete: TRIGGER_STEP_ID,
- workflowVersionId: mockWorkflowVersionId,
- workspaceId: mockWorkspaceId,
- });
-
- expect(mockWorkflowVersionWorkspaceRepository.update).toHaveBeenCalled();
- expect(mockComputeWorkflowVersionStepChanges).toHaveBeenCalled();
-
- expect(result).toEqual(mockChanges);
- expect(result.triggerDiff).toBeDefined();
- expect(result.stepsDiff).toBeDefined();
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-core-consistency/services/__tests__/workflow-core-consistency.service.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-core-consistency/services/__tests__/workflow-core-consistency.service.spec.ts
deleted file mode 100644
index 0b4bed8fe02..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-core-consistency/services/__tests__/workflow-core-consistency.service.spec.ts
+++ /dev/null
@@ -1,265 +0,0 @@
-import { type DataSource } from 'typeorm';
-
-import { type ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
-import { type MetricsService } from 'src/engine/core-modules/metrics/metrics.service';
-import { MetricsKeys } from 'src/engine/core-modules/metrics/types/metrics-keys.type';
-import { type WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { AutomatedTriggerType } from 'src/modules/workflow/common/standard-objects/workflow-automated-trigger.workspace-entity';
-import { WorkflowCoreConsistencyService } from 'src/modules/workflow/workflow-core-consistency/services/workflow-core-consistency.service';
-
-const workspaceId = '20202020-1c25-4d02-bf25-6aeccf7ea419';
-const schema = 'workspace_test';
-
-type Counts = { unlinked: number; missingCore: number; fieldMismatch: number };
-
-describe('WorkflowCoreConsistencyService', () => {
- let service: WorkflowCoreConsistencyService;
- let coreDataSource: { query: jest.Mock };
- let workspaceCacheService: { getOrRecompute: jest.Mock };
- let metricsService: { incrementCounterBy: jest.Mock };
- let exceptionHandlerService: { captureExceptions: jest.Mock };
-
- let shouldCheck: boolean;
- let workflowCounts: Counts;
- let workflowOrphan: number;
- let versionCounts: Counts;
- let versionOrphan: number;
- let triggerRows: Array<{
- workflowId: string;
- type: string;
- settings: unknown;
- }>;
- let cacheByWorkflowId: Record<string, unknown>;
-
- const zero = (): Counts => ({
- unlinked: 0,
- missingCore: 0,
- fieldMismatch: 0,
- });
-
- beforeEach(() => {
- shouldCheck = true;
- workflowCounts = zero();
- workflowOrphan = 0;
- versionCounts = zero();
- versionOrphan = 0;
- triggerRows = [];
- cacheByWorkflowId = {};
-
- coreDataSource = {
- query: jest.fn().mockImplementation((sql: string) => {
- if (sql.includes('FROM core."workspace"')) {
- return Promise.resolve([{ workspaceId, databaseSchema: schema }]);
- }
- if (sql.includes('AS "shouldCheck"')) {
- return Promise.resolve([{ shouldCheck }]);
- }
- if (sql.includes('AS "orphanCore"')) {
- return Promise.resolve([
- {
- orphanCore: sql.includes('workflowVersion')
- ? versionOrphan
- : workflowOrphan,
- },
- ]);
- }
- if (sql.includes('AS unlinked')) {
- return Promise.resolve([
- sql.includes('workflowVersion') ? versionCounts : workflowCounts,
- ]);
- }
- if (sql.includes('workflowAutomatedTrigger')) {
- return Promise.resolve(triggerRows);
- }
-
- return Promise.resolve([]);
- }),
- };
- workspaceCacheService = {
- getOrRecompute: jest.fn().mockImplementation(() =>
- Promise.resolve({
- workflowAutomatedTriggerMaps: { byWorkflowId: cacheByWorkflowId },
- }),
- ),
- };
- metricsService = { incrementCounterBy: jest.fn() };
- exceptionHandlerService = { captureExceptions: jest.fn() };
-
- service = new WorkflowCoreConsistencyService(
- coreDataSource as unknown as DataSource,
- workspaceCacheService as unknown as WorkspaceCacheService,
- metricsService as unknown as MetricsService,
- exceptionHandlerService as unknown as ExceptionHandlerService,
- );
-
- jest.spyOn(service['logger'], 'warn').mockImplementation();
- });
-
- afterEach(() => {
- jest.clearAllMocks();
- });
-
- it('emits nothing for a fully consistent workspace', async () => {
- await service.runConsistencyCheck();
-
- expect(metricsService.incrementCounterBy).not.toHaveBeenCalled();
- expect(exceptionHandlerService.captureExceptions).not.toHaveBeenCalled();
- });
-
- it('emits a drift count per dimension for workflow drift', async () => {
- workflowCounts = { unlinked: 2, missingCore: 0, fieldMismatch: 1 };
-
- await service.runConsistencyCheck();
-
- expect(metricsService.incrementCounterBy).toHaveBeenCalledWith({
- key: MetricsKeys.WorkflowCoreConsistencyWorkflowDrift,
- amount: 2,
- attributes: { driftType: 'unlinked' },
- });
- expect(metricsService.incrementCounterBy).toHaveBeenCalledWith({
- key: MetricsKeys.WorkflowCoreConsistencyWorkflowDrift,
- amount: 1,
- attributes: { driftType: 'fieldMismatch' },
- });
- });
-
- it('emits version drift including orphan core rows', async () => {
- versionCounts = { unlinked: 0, missingCore: 3, fieldMismatch: 0 };
- versionOrphan = 1;
-
- await service.runConsistencyCheck();
-
- expect(metricsService.incrementCounterBy).toHaveBeenCalledWith({
- key: MetricsKeys.WorkflowCoreConsistencyVersionDrift,
- amount: 3,
- attributes: { driftType: 'missingCore' },
- });
- expect(metricsService.incrementCounterBy).toHaveBeenCalledWith({
- key: MetricsKeys.WorkflowCoreConsistencyVersionDrift,
- amount: 1,
- attributes: { driftType: 'orphanCore' },
- });
- });
-
- it('flags an automated trigger present in the cache but not the table', async () => {
- cacheByWorkflowId = {
- wf1: {
- workflowId: 'wf1',
- workflowVersionId: 'v1',
- type: AutomatedTriggerType.CRON,
- settings: { pattern: '* * * * *' },
- },
- };
- triggerRows = [];
-
- await service.runConsistencyCheck();
-
- expect(metricsService.incrementCounterBy).toHaveBeenCalledWith({
- key: MetricsKeys.WorkflowCoreConsistencyAutomatedTriggerDrift,
- amount: 1,
- attributes: { driftType: 'inCacheNotTable' },
- });
- });
-
- it('flags an automated trigger present in the table but not the cache', async () => {
- triggerRows = [
- {
- workflowId: 'wf1',
- type: AutomatedTriggerType.DATABASE_EVENT,
- settings: { eventName: 'person.created' },
- },
- ];
- cacheByWorkflowId = {};
-
- await service.runConsistencyCheck();
-
- expect(metricsService.incrementCounterBy).toHaveBeenCalledWith({
- key: MetricsKeys.WorkflowCoreConsistencyAutomatedTriggerDrift,
- amount: 1,
- attributes: { driftType: 'inTableNotCache' },
- });
- });
-
- it('flags an automated trigger whose settings differ between table and cache', async () => {
- cacheByWorkflowId = {
- wf1: {
- workflowId: 'wf1',
- workflowVersionId: 'v1',
- type: AutomatedTriggerType.DATABASE_EVENT,
- settings: { eventName: 'person.created' },
- },
- };
- triggerRows = [
- {
- workflowId: 'wf1',
- type: AutomatedTriggerType.DATABASE_EVENT,
- settings: { eventName: 'company.created' },
- },
- ];
-
- await service.runConsistencyCheck();
-
- expect(metricsService.incrementCounterBy).toHaveBeenCalledWith({
- key: MetricsKeys.WorkflowCoreConsistencyAutomatedTriggerDrift,
- amount: 1,
- attributes: { driftType: 'mismatch' },
- });
- });
-
- it('enumerates active and suspended workspaces instead of workspaces having core rows', async () => {
- await service.runConsistencyCheck();
-
- expect(coreDataSource.query).toHaveBeenCalledWith(
- expect.stringContaining(`"activationStatus" IN ('ACTIVE', 'SUSPENDED')`),
- );
- expect(coreDataSource.query).toHaveBeenCalledWith(
- expect.stringContaining(`"databaseSchema" IS NOT NULL`),
- );
- });
-
- it('gates on source workflows OR core rows so orphan core rows are still checked', async () => {
- await service.runConsistencyCheck();
-
- expect(coreDataSource.query).toHaveBeenCalledWith(
- expect.stringContaining(`OR EXISTS (SELECT 1 FROM core."workflow"`),
- [workspaceId],
- );
- });
-
- it('skips workspaces that have no workflow rows', async () => {
- shouldCheck = false;
- workflowCounts = { unlinked: 5, missingCore: 0, fieldMismatch: 0 };
-
- await service.runConsistencyCheck();
-
- expect(metricsService.incrementCounterBy).not.toHaveBeenCalled();
- expect(workspaceCacheService.getOrRecompute).not.toHaveBeenCalled();
- });
-
- it('excludes soft-deleted rows from the automated trigger comparison', async () => {
- await service.runConsistencyCheck();
-
- expect(coreDataSource.query).toHaveBeenCalledWith(
- expect.stringContaining(
- `"workflowAutomatedTrigger" WHERE "deletedAt" IS NULL`,
- ),
- );
- });
-
- it('isolates a per-workspace failure and reports it to Sentry', async () => {
- coreDataSource.query.mockImplementation((sql: string) => {
- if (sql.includes('FROM core."workspace"')) {
- return Promise.resolve([{ workspaceId, databaseSchema: schema }]);
- }
-
- return Promise.reject(new Error('boom'));
- });
-
- await expect(service.runConsistencyCheck()).resolves.toBeUndefined();
-
- expect(exceptionHandlerService.captureExceptions).toHaveBeenCalledWith(
- [expect.any(Error)],
- { workspace: { id: workspaceId } },
- );
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/workspace-services/__tests__/workflow-executor.workspace-service.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/workspace-services/__tests__/workflow-executor.workspace-service.spec.ts
deleted file mode 100644
index 628097aa04e..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-executor/workspace-services/__tests__/workflow-executor.workspace-service.spec.ts
+++ /dev/null
@@ -1,731 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import {
- getWorkflowRunContext,
- StepStatus,
- WorkflowActionType,
-} from 'twenty-shared/workflow';
-
-import { BillingUsageService } from 'src/engine/core-modules/billing/services/billing-usage.service';
-import { BillingService } from 'src/engine/core-modules/billing/services/billing.service';
-import { ExceptionHandlerService } from 'src/engine/core-modules/exception-handler/exception-handler.service';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { MetricsService } from 'src/engine/core-modules/metrics/metrics.service';
-import { USAGE_RECORDED } from 'src/engine/core-modules/usage/constants/usage-recorded.constant';
-import { UsageOperationType } from 'src/engine/core-modules/usage/enums/usage-operation-type.enum';
-import { UsageResourceType } from 'src/engine/core-modules/usage/enums/usage-resource-type.enum';
-import { UsageUnit } from 'src/engine/core-modules/usage/enums/usage-unit.enum';
-import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
-import { WorkspaceEventEmitter } from 'src/engine/workspace-event-emitter/workspace-event-emitter';
-import { WorkflowActionFactory } from 'src/modules/workflow/workflow-executor/factories/workflow-action.factory';
-import { shouldExecuteStep } from 'src/modules/workflow/workflow-executor/utils/should-execute-step.util';
-import { shouldFailSafely } from 'src/modules/workflow/workflow-executor/utils/should-fail-safely.util';
-import { shouldSkipStepExecution } from 'src/modules/workflow/workflow-executor/utils/should-skip-step-execution.util';
-import { type WorkflowAction } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
-import { WorkflowExecutorWorkspaceService } from 'src/modules/workflow/workflow-executor/workspace-services/workflow-executor.workspace-service';
-import { WorkflowRunWorkspaceService } from 'src/modules/workflow/workflow-runner/workflow-run/workflow-run.workspace-service';
-
-jest.mock(
- 'src/modules/workflow/workflow-executor/utils/should-execute-step.util',
- () => {
- const actual = jest.requireActual(
- 'src/modules/workflow/workflow-executor/utils/should-execute-step.util',
- );
-
- return {
- ...actual,
- shouldExecuteStep: jest.fn().mockReturnValue(true),
- };
- },
-);
-
-jest.mock(
- 'src/modules/workflow/workflow-executor/utils/should-fail-safely.util',
- () => ({
- shouldFailSafely: jest.fn().mockReturnValue(false),
- }),
-);
-
-jest.mock(
- 'src/modules/workflow/workflow-executor/utils/should-skip-step-execution.util',
- () => ({
- shouldSkipStepExecution: jest.fn().mockReturnValue(false),
- }),
-);
-
-describe('WorkflowExecutorWorkspaceService', () => {
- let service: WorkflowExecutorWorkspaceService;
- let workflowActionFactory: WorkflowActionFactory;
- let workspaceEventEmitter: WorkspaceEventEmitter;
- let workflowRunWorkspaceService: WorkflowRunWorkspaceService;
-
- const mockWorkflowExecutor = {
- execute: jest.fn().mockResolvedValue({ result: { success: true } }),
- };
-
- const mockWorkspaceEventEmitter = {
- emitCustomBatchEvent: jest.fn(),
- };
-
- const mockWorkflowRunWorkspaceService = {
- endWorkflowRun: jest.fn(),
- updateWorkflowRunStepInfo: jest.fn(),
- getWorkflowRunOrFail: jest.fn(),
- };
-
- const mockBillingService = {
- isBillingEnabled: jest.fn().mockReturnValue(true),
- };
-
- const mockBillingUsageService = {
- hasAvailableCredits: jest.fn().mockResolvedValue(true),
- decrementAvailableCreditsInCache: jest.fn().mockResolvedValue(undefined),
- };
-
- const mockExceptionHandlerService = {
- captureExceptions: jest.fn(),
- };
-
- const mockMetricsService = {
- incrementCounterForEvent: jest.fn(),
- };
-
- const mockMessageQueueService = {
- add: jest.fn(),
- };
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkflowExecutorWorkspaceService,
- {
- provide: WorkflowActionFactory,
- useValue: {
- get: jest.fn().mockReturnValue(mockWorkflowExecutor),
- },
- },
- {
- provide: WorkspaceEventEmitter,
- useValue: mockWorkspaceEventEmitter,
- },
- {
- provide: WorkflowRunWorkspaceService,
- useValue: mockWorkflowRunWorkspaceService,
- },
- {
- provide: BillingService,
- useValue: mockBillingService,
- },
- {
- provide: BillingUsageService,
- useValue: mockBillingUsageService,
- },
- {
- provide: WorkspaceCacheService,
- useValue: {
- getOrRecompute: jest.fn().mockResolvedValue({
- currentBillingSubscription: {
- currentPeriodStart: new Date('2026-04-01T00:00:00Z'),
- },
- }),
- },
- },
- {
- provide: ExceptionHandlerService,
- useValue: mockExceptionHandlerService,
- },
- {
- provide: `MESSAGE_QUEUE_${MessageQueue.workflowQueue}`,
- useValue: mockMessageQueueService,
- },
- {
- provide: MetricsService,
- useValue: mockMetricsService,
- },
- ],
- }).compile();
-
- service = module.get<WorkflowExecutorWorkspaceService>(
- WorkflowExecutorWorkspaceService,
- );
- workflowActionFactory = module.get<WorkflowActionFactory>(
- WorkflowActionFactory,
- );
- workspaceEventEmitter = module.get<WorkspaceEventEmitter>(
- WorkspaceEventEmitter,
- );
- workflowRunWorkspaceService = module.get<WorkflowRunWorkspaceService>(
- WorkflowRunWorkspaceService,
- );
- });
-
- describe('execute', () => {
- const mockWorkflowRunId = 'workflow-run-id';
- const mockWorkspaceId = 'workspace-id';
- const mockSteps = [
- {
- id: 'step-1',
- type: WorkflowActionType.CODE,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- nextStepIds: ['step-2'],
- },
- {
- id: 'step-2',
- type: WorkflowActionType.SEND_EMAIL,
- settings: {
- errorHandlingOptions: {
- continueOnFailure: { value: false },
- retryOnFailure: { value: false },
- },
- },
- nextStepIds: [],
- },
- ] as WorkflowAction[];
-
- const mockStepInfos = {
- trigger: { result: {}, status: StepStatus.SUCCESS },
- 'step-1': { status: StepStatus.NOT_STARTED },
- 'step-2': { status: StepStatus.NOT_STARTED },
- };
-
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockReturnValue({
- state: { flow: { steps: mockSteps }, stepInfos: mockStepInfos },
- workflowId: 'workflow-id',
- });
-
- it('should execute a step and continue to the next step on success', async () => {
- const mockStepResult = {
- result: { stepOutput: 'success' },
- };
-
- mockWorkflowExecutor.execute.mockResolvedValueOnce(mockStepResult);
-
- await service.executeFromSteps({
- workflowRunId: mockWorkflowRunId,
- stepIds: ['step-1'],
- workspaceId: mockWorkspaceId,
- });
-
- expect(workflowActionFactory.get).toHaveBeenCalledWith(
- WorkflowActionType.CODE,
- );
-
- expect(mockWorkflowExecutor.execute).toHaveBeenCalledWith({
- currentStepId: 'step-1',
- steps: mockSteps,
- context: getWorkflowRunContext(mockStepInfos),
- runInfo: {
- workflowRunId: mockWorkflowRunId,
- workspaceId: mockWorkspaceId,
- },
- });
-
- expect(workspaceEventEmitter.emitCustomBatchEvent).toHaveBeenCalledWith(
- USAGE_RECORDED,
- [
- {
- resourceType: UsageResourceType.WORKFLOW,
- operationType: UsageOperationType.WORKFLOW_EXECUTION,
- creditsUsedMicro: 100,
- quantity: 1,
- unit: UsageUnit.INVOCATION,
- resourceId: 'workflow-id',
- periodStart: new Date('2026-04-01T00:00:00.000Z'),
- },
- ],
- 'workspace-id',
- );
-
- expect(
- workflowRunWorkspaceService.updateWorkflowRunStepInfo,
- ).toHaveBeenCalledTimes(4);
-
- expect(
- workflowRunWorkspaceService.updateWorkflowRunStepInfo,
- ).toHaveBeenNthCalledWith(1, {
- stepId: 'step-1',
- stepInfo: {
- status: StepStatus.RUNNING,
- },
- workflowRunId: mockWorkflowRunId,
- workspaceId: 'workspace-id',
- });
-
- expect(
- workflowRunWorkspaceService.updateWorkflowRunStepInfo,
- ).toHaveBeenNthCalledWith(2, {
- stepId: 'step-1',
- stepInfo: {
- ...mockStepResult,
- status: StepStatus.SUCCESS,
- },
- workflowRunId: mockWorkflowRunId,
- workspaceId: 'workspace-id',
- });
-
- // execute second step
- expect(workflowActionFactory.get).toHaveBeenCalledWith(
- WorkflowActionType.SEND_EMAIL,
- );
- });
-
- it('should handle step execution errors', async () => {
- mockWorkflowExecutor.execute.mockRejectedValueOnce(
- new Error('Step execution failed'),
- );
-
- await service.executeFromSteps({
- workflowRunId: mockWorkflowRunId,
- stepIds: ['step-1'],
- workspaceId: mockWorkspaceId,
- });
-
- expect(workspaceEventEmitter.emitCustomBatchEvent).not.toHaveBeenCalled();
-
- expect(
- workflowRunWorkspaceService.updateWorkflowRunStepInfo,
- ).toHaveBeenCalledTimes(2);
-
- expect(
- workflowRunWorkspaceService.updateWorkflowRunStepInfo,
- ).toHaveBeenNthCalledWith(1, {
- stepId: 'step-1',
- stepInfo: {
- status: StepStatus.RUNNING,
- },
- workflowRunId: mockWorkflowRunId,
- workspaceId: 'workspace-id',
- });
-
- expect(
- workflowRunWorkspaceService.updateWorkflowRunStepInfo,
- ).toHaveBeenNthCalledWith(2, {
- stepId: 'step-1',
- stepInfo: {
- error: 'Step execution failed',
- status: StepStatus.FAILED,
- },
- workflowRunId: mockWorkflowRunId,
- workspaceId: 'workspace-id',
- });
- });
-
- it('should handle pending events', async () => {
- const mockPendingEvent = {
- pendingEvent: true,
- };
-
- mockWorkflowExecutor.execute.mockResolvedValueOnce(mockPendingEvent);
-
- await service.executeFromSteps({
- workflowRunId: mockWorkflowRunId,
- stepIds: ['step-1'],
- workspaceId: mockWorkspaceId,
- });
-
- expect(
- workflowRunWorkspaceService.updateWorkflowRunStepInfo,
- ).toHaveBeenCalledTimes(2);
-
- expect(
- workflowRunWorkspaceService.updateWorkflowRunStepInfo,
- ).toHaveBeenNthCalledWith(1, {
- stepId: 'step-1',
- stepInfo: {
- status: StepStatus.RUNNING,
- },
- workflowRunId: mockWorkflowRunId,
- workspaceId: 'workspace-id',
- });
-
- expect(
- workflowRunWorkspaceService.updateWorkflowRunStepInfo,
- ).toHaveBeenNthCalledWith(2, {
- stepId: 'step-1',
- stepInfo: {
- status: StepStatus.PENDING,
- },
- workflowRunId: mockWorkflowRunId,
- workspaceId: 'workspace-id',
- });
-
- // No recursive call to execute should happen
- expect(workflowActionFactory.get).not.toHaveBeenCalledWith(
- WorkflowActionType.SEND_EMAIL,
- );
- });
-
- it('should not emit billing event for skipped steps', async () => {
- (shouldExecuteStep as jest.Mock).mockReturnValue(false);
- (shouldSkipStepExecution as jest.Mock).mockReturnValue(true);
-
- await service.executeFromSteps({
- workflowRunId: mockWorkflowRunId,
- stepIds: ['step-1'],
- workspaceId: mockWorkspaceId,
- });
-
- expect(workflowActionFactory.get).not.toHaveBeenCalled();
- expect(workspaceEventEmitter.emitCustomBatchEvent).not.toHaveBeenCalled();
-
- (shouldExecuteStep as jest.Mock).mockReturnValue(true);
- (shouldSkipStepExecution as jest.Mock).mockReturnValue(false);
- });
-
- it('should not emit billing event for fail-safely steps', async () => {
- (shouldExecuteStep as jest.Mock).mockReturnValue(false);
- (shouldFailSafely as jest.Mock).mockReturnValue(true);
-
- await service.executeFromSteps({
- workflowRunId: mockWorkflowRunId,
- stepIds: ['step-1'],
- workspaceId: mockWorkspaceId,
- });
-
- expect(workflowActionFactory.get).not.toHaveBeenCalled();
- expect(workspaceEventEmitter.emitCustomBatchEvent).not.toHaveBeenCalled();
-
- (shouldExecuteStep as jest.Mock).mockReturnValue(true);
- (shouldFailSafely as jest.Mock).mockReturnValue(false);
- });
-
- it('should return if step should not be executed', async () => {
- (shouldExecuteStep as jest.Mock).mockReturnValueOnce(false);
-
- await service.executeFromSteps({
- workflowRunId: mockWorkflowRunId,
- stepIds: ['step-1'],
- workspaceId: mockWorkspaceId,
- });
-
- expect(workflowActionFactory.get).not.toHaveBeenCalled();
- });
-
- it('should queue another job when max executed step count is reached', async () => {
- const mockStepResult = {
- result: { stepOutput: 'success' },
- };
-
- mockWorkflowExecutor.execute.mockResolvedValueOnce(mockStepResult);
-
- await service.executeFromSteps({
- workflowRunId: mockWorkflowRunId,
- stepIds: ['step-1'],
- workspaceId: mockWorkspaceId,
- executedStepsCount: 21, // exceeds MAX_EXECUTED_STEPS_COUNT (20)
- });
-
- expect(mockMessageQueueService.add).toHaveBeenCalledWith(
- 'RunWorkflowJob',
- {
- workspaceId: mockWorkspaceId,
- workflowRunId: mockWorkflowRunId,
- lastExecutedStepId: 'step-1',
- },
- { id: mockWorkflowRunId, allowDuplicatedPrefixes: true },
- );
-
- // Should not execute the next step (step-2) in the same job
- expect(workflowActionFactory.get).toHaveBeenCalledTimes(1);
- expect(workflowActionFactory.get).toHaveBeenCalledWith(
- WorkflowActionType.CODE,
- );
- });
- });
-
- describe('getNextStepIdsToExecute', () => {
- it('should return nextStepIds for a regular step', async () => {
- const step = {
- id: 'step-1',
- type: WorkflowActionType.CODE,
- nextStepIds: ['step-2', 'step-3'],
- settings: {},
- } as WorkflowAction;
-
- const result = await service.getNextStepIdsToExecute({
- executedStep: step,
- executedStepOutput: { result: {} },
- });
-
- expect(result).toEqual({
- nextStepIdsToExecute: ['step-2', 'step-3'],
- });
- });
-
- it('should return initialLoopStepIds for an iterator that has not processed all items', async () => {
- const step = {
- id: 'iterator-1',
- type: WorkflowActionType.ITERATOR,
- nextStepIds: ['after-loop'],
- settings: {
- input: {
- initialLoopStepIds: ['loop-step-1'],
- },
- },
- } as WorkflowAction;
-
- const result = await service.getNextStepIdsToExecute({
- executedStep: step,
- executedStepOutput: {
- result: { hasProcessedAllItems: false },
- },
- });
-
- expect(result).toEqual({
- nextStepIdsToExecute: ['loop-step-1'],
- });
- });
-
- it('should return nextStepIds for an iterator that has processed all items', async () => {
- const step = {
- id: 'iterator-1',
- type: WorkflowActionType.ITERATOR,
- nextStepIds: ['after-loop'],
- settings: {
- input: {
- initialLoopStepIds: ['loop-step-1'],
- },
- },
- } as WorkflowAction;
-
- const result = await service.getNextStepIdsToExecute({
- executedStep: step,
- executedStepOutput: {
- result: { hasProcessedAllItems: true },
- },
- });
-
- expect(result).toEqual({
- nextStepIdsToExecute: ['after-loop'],
- });
- });
-
- it('should return matching branch nextStepIds and non-matching branch nextStepIds to skip for if-else', async () => {
- const step = {
- id: 'if-else-1',
- type: WorkflowActionType.IF_ELSE,
- nextStepIds: [],
- settings: {
- input: {
- branches: [
- {
- id: 'branch-if',
- filterGroupId: 'fg1',
- nextStepIds: ['step-a'],
- },
- {
- id: 'branch-else',
- nextStepIds: ['step-b'],
- },
- ],
- stepFilterGroups: [],
- stepFilters: [],
- },
- },
- } as unknown as WorkflowAction;
-
- const result = await service.getNextStepIdsToExecute({
- executedStep: step,
- executedStepOutput: {
- result: { matchingBranchId: 'branch-if' },
- },
- });
-
- expect(result).toEqual({
- nextStepIdsToExecute: ['step-a'],
- nextStepIdsToSkip: ['step-b'],
- });
- });
-
- it('should return loop children as nextStepIdsToFailSafely for a fail-safe iterator', async () => {
- const step = {
- id: 'iterator-1',
- type: WorkflowActionType.ITERATOR,
- nextStepIds: ['after-loop'],
- settings: {
- input: {
- initialLoopStepIds: ['loop-step-1'],
- },
- },
- } as WorkflowAction;
-
- const result = await service.getNextStepIdsToExecute({
- executedStep: step,
- executedStepOutput: {
- shouldFailSafely: true,
- },
- });
-
- expect(result).toEqual({
- nextStepIdsToFailSafely: ['loop-step-1'],
- });
- });
-
- it('should return loop children as nextStepIdsToSkip for a skipped iterator', async () => {
- const step = {
- id: 'iterator-1',
- type: WorkflowActionType.ITERATOR,
- nextStepIds: ['after-loop'],
- settings: {
- input: {
- initialLoopStepIds: ['loop-step-1'],
- },
- },
- } as WorkflowAction;
-
- const result = await service.getNextStepIdsToExecute({
- executedStep: step,
- executedStepOutput: {
- shouldSkipStepExecution: true,
- },
- });
-
- expect(result).toEqual({
- nextStepIdsToSkip: ['loop-step-1'],
- });
- });
-
- it('should return nextStepIdsToFailSafely for all branches when if-else is fail-safe', async () => {
- const step = {
- id: 'if-else-1',
- type: WorkflowActionType.IF_ELSE,
- nextStepIds: [],
- settings: {
- input: {
- branches: [
- {
- id: 'branch-if',
- filterGroupId: 'fg1',
- nextStepIds: ['step-a'],
- },
- {
- id: 'branch-else',
- nextStepIds: ['step-b'],
- },
- ],
- stepFilterGroups: [],
- stepFilters: [],
- },
- },
- } as unknown as WorkflowAction;
-
- const result = await service.getNextStepIdsToExecute({
- executedStep: step,
- executedStepOutput: {
- shouldFailSafely: true,
- },
- });
-
- expect(result).toEqual({
- nextStepIdsToFailSafely: ['step-a', 'step-b'],
- });
- });
-
- it('should return nextStepIdsToSkip for all branches when if-else has no matching branch', async () => {
- const step = {
- id: 'if-else-1',
- type: WorkflowActionType.IF_ELSE,
- nextStepIds: [],
- settings: {
- input: {
- branches: [
- {
- id: 'branch-if',
- filterGroupId: 'fg1',
- nextStepIds: ['step-a'],
- },
- {
- id: 'branch-else',
- nextStepIds: ['step-b'],
- },
- ],
- stepFilterGroups: [],
- stepFilters: [],
- },
- },
- } as unknown as WorkflowAction;
-
- const result = await service.getNextStepIdsToExecute({
- executedStep: step,
- executedStepOutput: {
- shouldSkipStepExecution: true,
- },
- });
-
- expect(result).toEqual({
- nextStepIdsToSkip: ['step-a', 'step-b'],
- });
- });
-
- it('should skip multiple non-matching branches for if-else with many branches', async () => {
- const step = {
- id: 'if-else-1',
- type: WorkflowActionType.IF_ELSE,
- nextStepIds: [],
- settings: {
- input: {
- branches: [
- {
- id: 'branch-1',
- filterGroupId: 'fg1',
- nextStepIds: ['step-a'],
- },
- {
- id: 'branch-2',
- filterGroupId: 'fg2',
- nextStepIds: ['step-b'],
- },
- {
- id: 'branch-else',
- nextStepIds: ['step-c'],
- },
- ],
- stepFilterGroups: [],
- stepFilters: [],
- },
- },
- } as unknown as WorkflowAction;
-
- const result = await service.getNextStepIdsToExecute({
- executedStep: step,
- executedStepOutput: {
- result: { matchingBranchId: 'branch-2' },
- },
- });
-
- expect(result).toEqual({
- nextStepIdsToExecute: ['step-b'],
- nextStepIdsToSkip: ['step-a', 'step-c'],
- });
- });
- });
-
- describe('sendWorkflowNodeRunEvent', () => {
- it('should emit a billing event', async () => {
- await service['sendWorkflowNodeRunEvent']('workspace-id', 'workflow-id');
-
- expect(workspaceEventEmitter.emitCustomBatchEvent).toHaveBeenCalledWith(
- USAGE_RECORDED,
- [
- {
- resourceType: UsageResourceType.WORKFLOW,
- operationType: UsageOperationType.WORKFLOW_EXECUTION,
- creditsUsedMicro: 100,
- quantity: 1,
- unit: UsageUnit.INVOCATION,
- resourceId: 'workflow-id',
- periodStart: new Date('2026-04-01T00:00:00.000Z'),
- },
- ],
- 'workspace-id',
- );
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/workspace-services/__tests__/workflow-handle-staled-runs.workspace-service.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/workspace-services/__tests__/workflow-handle-staled-runs.workspace-service.spec.ts
deleted file mode 100644
index 5888cae017f..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run-queue/workspace-services/__tests__/workflow-handle-staled-runs.workspace-service.spec.ts
+++ /dev/null
@@ -1,569 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { StepStatus } from 'twenty-shared/workflow';
-
-import { CacheStorageNamespace } from 'src/engine/core-modules/cache-storage/types/cache-storage-namespace.enum';
-import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
-import { MetricsService } from 'src/engine/core-modules/metrics/metrics.service';
-import { MetricsKeys } from 'src/engine/core-modules/metrics/types/metrics-keys.type';
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { WorkflowRunStatus } from 'src/modules/workflow/common/standard-objects/workflow-run.workspace-entity';
-import { WorkflowHandleStaledRunsWorkspaceService } from 'src/modules/workflow/workflow-runner/workflow-run-queue/workspace-services/workflow-handle-staled-runs.workspace-service';
-import { WorkflowThrottlingWorkspaceService } from 'src/modules/workflow/workflow-runner/workflow-run-queue/workspace-services/workflow-throttling.workspace-service';
-import { WorkflowRunWorkspaceService } from 'src/modules/workflow/workflow-runner/workflow-run/workflow-run.workspace-service';
-
-const mockRepository = {
- count: jest.fn(),
- find: jest.fn(),
- update: jest.fn().mockResolvedValue(undefined),
-};
-
-const mockGlobalWorkspaceOrmManager = {
- getRepository: jest.fn().mockResolvedValue(mockRepository),
- executeInWorkspaceContext: jest
- .fn()
- // oxlint-disable-next-line typescript/no-explicit-any
- .mockImplementation((fn: () => any) => fn()),
-};
-
-const mockWorkflowThrottlingWorkspaceService = {
- recomputeWorkflowRunNotStartedCount: jest.fn().mockResolvedValue(undefined),
-};
-
-const mockWorkflowRunWorkspaceService = {
- endWorkflowRun: jest.fn().mockResolvedValue(undefined),
- getWorkflowRunOrFail: jest.fn(),
-};
-
-const mockMessageQueueService = {
- getInFlightJobs: jest.fn().mockResolvedValue([]),
-};
-
-const mockMetricsService = {
- incrementCounterForEvent: jest.fn().mockResolvedValue(undefined),
-};
-
-const mockCacheStorageService = {
- get: jest.fn().mockResolvedValue(undefined),
- set: jest.fn().mockResolvedValue(undefined),
-};
-
-// Mirrors QUERY_MAX_RECORDS, the per-batch cap the service applies. Kept as a
-// local literal rather than imported from twenty-shared/constants to avoid a
-// jest circular-init issue with config-variables loading the same barrel.
-const QUERY_MAX_RECORDS = 200;
-
-const buildStaledRuns = (count: number, startIndex = 0) =>
- Array.from({ length: count }, (_, index) => ({
- id: `run-${startIndex + index}`,
- }));
-
-describe('WorkflowHandleStaledRunsWorkspaceService', () => {
- let service: WorkflowHandleStaledRunsWorkspaceService;
-
- const workspaceId = 'workspace-1';
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- WorkflowHandleStaledRunsWorkspaceService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: mockGlobalWorkspaceOrmManager,
- },
- {
- provide: WorkflowThrottlingWorkspaceService,
- useValue: mockWorkflowThrottlingWorkspaceService,
- },
- {
- provide: WorkflowRunWorkspaceService,
- useValue: mockWorkflowRunWorkspaceService,
- },
- {
- provide: `MESSAGE_QUEUE_${MessageQueue.workflowQueue}`,
- useValue: mockMessageQueueService,
- },
- {
- provide: MetricsService,
- useValue: mockMetricsService,
- },
- {
- provide: CacheStorageNamespace.ModuleWorkflow,
- useValue: mockCacheStorageService,
- },
- ],
- }).compile();
-
- mockWorkflowRunWorkspaceService.endWorkflowRun
- .mockReset()
- .mockResolvedValue(undefined);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockReset();
- mockMessageQueueService.getInFlightJobs.mockReset().mockResolvedValue([]);
- mockCacheStorageService.get.mockReset().mockResolvedValue(undefined);
- mockCacheStorageService.set.mockReset().mockResolvedValue(undefined);
-
- service = module.get<WorkflowHandleStaledRunsWorkspaceService>(
- WorkflowHandleStaledRunsWorkspaceService,
- );
- });
-
- it('should do nothing when there are no staled runs', async () => {
- mockRepository.count.mockResolvedValueOnce(0);
-
- await service.handleStaledRunsForWorkspace(workspaceId);
-
- expect(mockRepository.find).not.toHaveBeenCalled();
- expect(mockRepository.update).not.toHaveBeenCalled();
- expect(
- mockWorkflowThrottlingWorkspaceService.recomputeWorkflowRunNotStartedCount,
- ).not.toHaveBeenCalled();
- });
-
- it('should reset a single batch and recompute the not-started count once', async () => {
- const staledRuns = buildStaledRuns(3);
-
- mockRepository.count.mockResolvedValueOnce(3);
- mockRepository.find.mockResolvedValueOnce(staledRuns);
-
- await service.handleStaledRunsForWorkspace(workspaceId);
-
- expect(mockRepository.update).toHaveBeenCalledTimes(1);
- expect(mockRepository.update).toHaveBeenCalledWith(
- ['run-0', 'run-1', 'run-2'],
- {
- enqueuedAt: null,
- status: WorkflowRunStatus.NOT_STARTED,
- },
- );
- expect(
- mockWorkflowThrottlingWorkspaceService.recomputeWorkflowRunNotStartedCount,
- ).toHaveBeenCalledTimes(1);
- expect(
- mockWorkflowThrottlingWorkspaceService.recomputeWorkflowRunNotStartedCount,
- ).toHaveBeenCalledWith(workspaceId);
- });
-
- it('should never fetch more than QUERY_MAX_RECORDS ids per update', async () => {
- mockRepository.count.mockResolvedValueOnce(QUERY_MAX_RECORDS);
- mockRepository.find.mockResolvedValueOnce(
- buildStaledRuns(QUERY_MAX_RECORDS),
- );
-
- await service.handleStaledRunsForWorkspace(workspaceId);
-
- expect(mockRepository.find).toHaveBeenCalledWith(
- expect.objectContaining({ take: QUERY_MAX_RECORDS }),
- );
- expect(mockRepository.update.mock.calls[0][0]).toHaveLength(
- QUERY_MAX_RECORDS,
- );
- });
-
- it('should drain a multi-batch backlog based on the initial count', async () => {
- // 450 staled runs => 3 batches (200, 200, 50)
- mockRepository.count.mockResolvedValueOnce(450);
- mockRepository.find
- .mockResolvedValueOnce(buildStaledRuns(QUERY_MAX_RECORDS))
- .mockResolvedValueOnce(buildStaledRuns(QUERY_MAX_RECORDS))
- .mockResolvedValueOnce(buildStaledRuns(50));
-
- await service.handleStaledRunsForWorkspace(workspaceId);
-
- expect(mockRepository.find).toHaveBeenCalledTimes(3);
- expect(mockRepository.update).toHaveBeenCalledTimes(3);
- expect(mockRepository.update.mock.calls[0][0]).toHaveLength(
- QUERY_MAX_RECORDS,
- );
- expect(mockRepository.update.mock.calls[1][0]).toHaveLength(
- QUERY_MAX_RECORDS,
- );
- expect(mockRepository.update.mock.calls[2][0]).toHaveLength(50);
-
- // Recompute runs exactly once, after the whole backlog is drained
- expect(
- mockWorkflowThrottlingWorkspaceService.recomputeWorkflowRunNotStartedCount,
- ).toHaveBeenCalledTimes(1);
- });
-
- describe('handleStuckStoppingRunsForWorkspace', () => {
- it('should do nothing when there are no stuck stopping runs', async () => {
- mockRepository.find.mockResolvedValueOnce([]);
-
- await service.handleStuckStoppingRunsForWorkspace(workspaceId);
-
- expect(
- mockWorkflowRunWorkspaceService.endWorkflowRun,
- ).not.toHaveBeenCalled();
- });
-
- it('should finalize each stuck stopping run to STOPPED', async () => {
- mockRepository.find.mockResolvedValueOnce(buildStaledRuns(3));
-
- await service.handleStuckStoppingRunsForWorkspace(workspaceId);
-
- expect(
- mockWorkflowRunWorkspaceService.endWorkflowRun,
- ).toHaveBeenCalledTimes(3);
- expect(
- mockWorkflowRunWorkspaceService.endWorkflowRun,
- ).toHaveBeenCalledWith({
- workflowRunId: 'run-0',
- workspaceId,
- status: WorkflowRunStatus.STOPPED,
- });
- });
-
- it('should page through a multi-page backlog until a short page', async () => {
- mockRepository.find
- .mockResolvedValueOnce(buildStaledRuns(QUERY_MAX_RECORDS))
- .mockResolvedValueOnce(
- buildStaledRuns(QUERY_MAX_RECORDS, QUERY_MAX_RECORDS),
- )
- .mockResolvedValueOnce(buildStaledRuns(50, 2 * QUERY_MAX_RECORDS));
-
- await service.handleStuckStoppingRunsForWorkspace(workspaceId);
-
- expect(mockRepository.find).toHaveBeenCalledTimes(3);
- expect(mockRepository.find).toHaveBeenCalledWith(
- expect.objectContaining({ take: QUERY_MAX_RECORDS }),
- );
- expect(
- mockWorkflowRunWorkspaceService.endWorkflowRun,
- ).toHaveBeenCalledTimes(2 * QUERY_MAX_RECORDS + 50);
- });
-
- it('should keep finalizing remaining runs when one fails', async () => {
- mockRepository.find.mockResolvedValueOnce(buildStaledRuns(3));
- mockWorkflowRunWorkspaceService.endWorkflowRun
- .mockRejectedValueOnce(new Error('boom'))
- .mockResolvedValue(undefined);
-
- await service.handleStuckStoppingRunsForWorkspace(workspaceId);
-
- expect(
- mockWorkflowRunWorkspaceService.endWorkflowRun,
- ).toHaveBeenCalledTimes(3);
- });
-
- it('should advance past a fully failed page instead of starving later runs', async () => {
- mockRepository.find
- .mockResolvedValueOnce(buildStaledRuns(QUERY_MAX_RECORDS))
- .mockResolvedValueOnce(buildStaledRuns(50, QUERY_MAX_RECORDS));
- // Whole first page fails, later runs still get finalized
- mockWorkflowRunWorkspaceService.endWorkflowRun.mockImplementation(
- ({ workflowRunId }: { workflowRunId: string }) => {
- const index = Number(workflowRunId.replace('run-', ''));
-
- return index < QUERY_MAX_RECORDS
- ? Promise.reject(new Error('boom'))
- : Promise.resolve(undefined);
- },
- );
-
- await service.handleStuckStoppingRunsForWorkspace(workspaceId);
-
- expect(mockRepository.find).toHaveBeenCalledTimes(2);
- expect(
- mockWorkflowRunWorkspaceService.endWorkflowRun,
- ).toHaveBeenCalledTimes(QUERY_MAX_RECORDS + 50);
- expect(
- mockWorkflowRunWorkspaceService.endWorkflowRun,
- ).toHaveBeenCalledWith({
- workflowRunId: `run-${QUERY_MAX_RECORDS}`,
- workspaceId,
- status: WorkflowRunStatus.STOPPED,
- });
- });
- });
-
- describe('handleStuckRunningRunsForWorkspace', () => {
- const buildRunningWorkflowRun = ({
- id = 'run-0',
- steps,
- stepInfos,
- }: {
- id?: string;
- // oxlint-disable-next-line typescript/no-explicit-any
- steps: any[];
- // oxlint-disable-next-line typescript/no-explicit-any
- stepInfos: Record<string, any>;
- }) => ({
- id,
- status: WorkflowRunStatus.RUNNING,
- updatedAt: '2026-07-15T00:00:00.000Z',
- state: { flow: { steps }, stepInfos },
- });
-
- const expectNoWorkflowRunEnded = () => {
- expect(
- mockWorkflowRunWorkspaceService.endWorkflowRun,
- ).not.toHaveBeenCalled();
- };
-
- it('should do nothing when there are no stuck running nor flagged runs', async () => {
- mockRepository.find.mockResolvedValueOnce([]);
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(mockMessageQueueService.getInFlightJobs).not.toHaveBeenCalled();
- expect(mockCacheStorageService.set).not.toHaveBeenCalled();
- expectNoWorkflowRunEnded();
- });
-
- it('should not flag runs that still have an in-flight job matched by id prefix', async () => {
- mockRepository.find.mockResolvedValueOnce([{ id: 'run-0' }]);
- mockMessageQueueService.getInFlightJobs.mockResolvedValueOnce([
- { id: 'run-0-8a521c10-92b1-4013-a4a7-71f20b1a4a4a', data: {} },
- ]);
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail,
- ).not.toHaveBeenCalled();
- expect(mockCacheStorageService.set).toHaveBeenCalledWith(
- expect.any(String),
- {},
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should not flag runs whose pre-deploy job is matched by job data', async () => {
- mockRepository.find.mockResolvedValueOnce([{ id: 'run-0' }]);
- mockMessageQueueService.getInFlightJobs.mockResolvedValueOnce([
- { id: '12345', data: { workspaceId, workflowRunId: 'run-0' } },
- ]);
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail,
- ).not.toHaveBeenCalled();
- expect(mockCacheStorageService.set).toHaveBeenCalledWith(
- expect.any(String),
- {},
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should flag a run with an orphaned running step without ending it', async () => {
- mockRepository.find.mockResolvedValueOnce([{ id: 'run-0' }]);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockResolvedValueOnce(
- buildRunningWorkflowRun({
- steps: [{ id: 'step-1', type: 'CODE', nextStepIds: [] }],
- stepInfos: { 'step-1': { status: StepStatus.RUNNING } },
- }),
- );
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(mockMetricsService.incrementCounterForEvent).toHaveBeenCalledWith(
- expect.objectContaining({
- key: MetricsKeys.WorkflowRunStuckRunningDetected,
- }),
- );
- expect(mockCacheStorageService.set).toHaveBeenCalledWith(
- expect.any(String),
- { 'run-0': expect.any(String) },
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should not flag runs waiting on a pending step', async () => {
- mockRepository.find.mockResolvedValueOnce([{ id: 'run-0' }]);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockResolvedValueOnce(
- buildRunningWorkflowRun({
- steps: [{ id: 'step-1', type: 'DELAY', nextStepIds: [] }],
- stepInfos: { 'step-1': { status: StepStatus.PENDING } },
- }),
- );
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(
- mockMetricsService.incrementCounterForEvent,
- ).not.toHaveBeenCalled();
- expect(mockCacheStorageService.set).toHaveBeenCalledWith(
- expect.any(String),
- {},
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should flag a run with a failed branch even when another branch is pending', async () => {
- mockRepository.find.mockResolvedValueOnce([{ id: 'run-0' }]);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockResolvedValueOnce(
- buildRunningWorkflowRun({
- steps: [
- { id: 'step-1', type: 'CODE', nextStepIds: [] },
- { id: 'step-2', type: 'DELAY', nextStepIds: [] },
- ],
- stepInfos: {
- 'step-1': { status: StepStatus.FAILED },
- 'step-2': { status: StepStatus.PENDING },
- },
- }),
- );
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(mockMetricsService.incrementCounterForEvent).toHaveBeenCalledWith(
- expect.objectContaining({
- key: MetricsKeys.WorkflowRunStuckRunningDetected,
- }),
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should flag a run whose job was lost between two steps', async () => {
- mockRepository.find.mockResolvedValueOnce([{ id: 'run-0' }]);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockResolvedValueOnce(
- buildRunningWorkflowRun({
- steps: [
- { id: 'step-1', type: 'CODE', nextStepIds: ['step-2'] },
- { id: 'step-2', type: 'CODE', nextStepIds: [] },
- ],
- stepInfos: {
- 'step-1': { status: StepStatus.SUCCESS },
- 'step-2': { status: StepStatus.NOT_STARTED },
- },
- }),
- );
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(mockMetricsService.incrementCounterForEvent).toHaveBeenCalledWith(
- expect.objectContaining({
- key: MetricsKeys.WorkflowRunStuckRunningDetected,
- }),
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should not flag runs that progressed since the query', async () => {
- mockRepository.find.mockResolvedValueOnce([{ id: 'run-0' }]);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockResolvedValueOnce(
- {
- id: 'run-0',
- status: WorkflowRunStatus.COMPLETED,
- },
- );
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(
- mockMetricsService.incrementCounterForEvent,
- ).not.toHaveBeenCalled();
- expect(mockCacheStorageService.set).toHaveBeenCalledWith(
- expect.any(String),
- {},
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should keep a still-stuck flagged run without counting it again', async () => {
- mockCacheStorageService.get.mockResolvedValueOnce({
- 'run-0': '2026-07-16T00:00:00.000Z',
- });
- mockRepository.find.mockResolvedValueOnce([{ id: 'run-0' }]);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockResolvedValueOnce(
- buildRunningWorkflowRun({
- steps: [{ id: 'step-1', type: 'CODE', nextStepIds: [] }],
- stepInfos: { 'step-1': { status: StepStatus.RUNNING } },
- }),
- );
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(
- mockMetricsService.incrementCounterForEvent,
- ).not.toHaveBeenCalled();
- expect(mockCacheStorageService.set).toHaveBeenCalledWith(
- expect.any(String),
- { 'run-0': '2026-07-16T00:00:00.000Z' },
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should record a false positive when a flagged run ended on its own', async () => {
- mockCacheStorageService.get.mockResolvedValueOnce({
- 'run-0': '2026-07-16T00:00:00.000Z',
- });
- mockRepository.find.mockResolvedValueOnce([]);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockResolvedValueOnce(
- {
- id: 'run-0',
- status: WorkflowRunStatus.COMPLETED,
- },
- );
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(mockMetricsService.incrementCounterForEvent).toHaveBeenCalledWith(
- expect.objectContaining({
- key: MetricsKeys.WorkflowRunStuckRunningFalsePositive,
- }),
- );
- expect(mockCacheStorageService.set).toHaveBeenCalledWith(
- expect.any(String),
- {},
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should record a false positive when a flagged run got a new queue job', async () => {
- mockCacheStorageService.get.mockResolvedValueOnce({
- 'run-0': '2026-07-16T00:00:00.000Z',
- });
- mockRepository.find.mockResolvedValueOnce([]);
- mockMessageQueueService.getInFlightJobs.mockResolvedValueOnce([
- { id: 'run-0-8a521c10-92b1-4013-a4a7-71f20b1a4a4a', data: {} },
- ]);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail.mockResolvedValueOnce(
- buildRunningWorkflowRun({
- steps: [{ id: 'step-1', type: 'CODE', nextStepIds: [] }],
- stepInfos: { 'step-1': { status: StepStatus.RUNNING } },
- }),
- );
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(mockMetricsService.incrementCounterForEvent).toHaveBeenCalledWith(
- expect.objectContaining({
- key: MetricsKeys.WorkflowRunStuckRunningFalsePositive,
- }),
- );
- expect(mockCacheStorageService.set).toHaveBeenCalledWith(
- expect.any(String),
- {},
- );
- expectNoWorkflowRunEnded();
- });
-
- it('should keep checking remaining runs when one check fails', async () => {
- mockRepository.find.mockResolvedValueOnce([
- { id: 'run-0' },
- { id: 'run-1' },
- ]);
- mockWorkflowRunWorkspaceService.getWorkflowRunOrFail
- .mockRejectedValueOnce(new Error('boom'))
- .mockResolvedValueOnce(
- buildRunningWorkflowRun({
- id: 'run-1',
- steps: [{ id: 'step-1', type: 'CODE', nextStepIds: [] }],
- stepInfos: { 'step-1': { status: StepStatus.RUNNING } },
- }),
- );
-
- await service.handleStuckRunningRunsForWorkspace(workspaceId);
-
- expect(mockCacheStorageService.set).toHaveBeenCalledWith(
- expect.any(String),
- { 'run-1': expect.any(String) },
- );
- expectNoWorkflowRunEnded();
- });
- });
-});
diff --git a/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/__tests__/automated-trigger.workspace-service.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/__tests__/automated-trigger.workspace-service.spec.ts
deleted file mode 100644
index a336c72bd4f..00000000000
--- a/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/__tests__/automated-trigger.workspace-service.spec.ts
+++ /dev/null
@@ -1,144 +0,0 @@
-import { Test, type TestingModule } from '@nestjs/testing';
-
-import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspace-datasource/global-workspace-orm.manager';
-import { AutomatedTriggerType } from 'src/modules/workflow/common/standard-objects/workflow-automated-trigger.workspace-entity';
-import { AutomatedTriggerWorkspaceService } from 'src/modules/workflow/workflow-trigger/automated-trigger/automated-trigger.workspace-service';
-
-const mockRepository = {
- insert: jest.fn().mockResolvedValue(undefined),
- delete: jest.fn().mockResolvedValue(undefined),
-};
-
-const mockGlobalWorkspaceOrmManager = {
- getRepository: jest.fn().mockResolvedValue(mockRepository),
- executeInWorkspaceContext: jest
- .fn()
- .mockImplementation((fn: () => any) => fn()),
-};
-
-describe('AutomatedTriggerWorkspaceService', () => {
- let service: AutomatedTriggerWorkspaceService;
-
- beforeEach(async () => {
- jest.clearAllMocks();
-
- const module: TestingModule = await Test.createTestingModule({
- providers: [
- AutomatedTriggerWorkspaceService,
- {
- provide: GlobalWorkspaceOrmManager,
- useValue: mockGlobalWorkspaceOrmManager,
- },
- ],
- }).compile();
-
- service = module.get<AutomatedTriggerWorkspaceService>(
- AutomatedTriggerWorkspaceService,
- );
- });
-
- describe('addAutomatedTrigger', () => {
- const workspaceId = 'workspace-1';
- const workflowId = 'workflow-1';
- const cronSettings = { pattern: '* * * * *' };
- const databaseEventSettings = {
- eventName: 'company.created',
- fields: [],
- };
-
- it('should insert a CRON trigger', async () => {
- await service.addAutomatedTrigger({
- workflowId,
- type: AutomatedTriggerType.CRON,
- settings: cronSettings,
- workspaceId,
- });
-
- expect(mockRepository.insert).toHaveBeenCalledWith({
- type: AutomatedTriggerType.CRON,
- settings: cronSettings,
- workflowId,
- });
- });
-
- it('should insert a DATABASE_EVENT trigger', async () => {
- await service.addAutomatedTrigger({
- workflowId,
- type: AutomatedTriggerType.DATABASE_EVENT,
- settings: databaseEventSettings,
- workspaceId,
- });
-
- expect(mockRepository.insert).toHaveBeenCalledWith({
- type: AutomatedTriggerType.DATABASE_EVENT,
- settings: databaseEventSettings,
- workflowId,
- });
- });
-
- it('should use entityManager when provided', async () => {
- const mockEntityManager = {} as any;
-
- await service.addAutomatedTrigger({
- workflowId,
- type: AutomatedTriggerType.CRON,
- settings: cronSettings,
- workspaceId,
- entityManager: mockEntityManager,
- });
-
- expect(mockRepository.insert).toHaveBeenCalledWith(
- { type: AutomatedTriggerType.CRON, settings: cronSettings, workflowId },
- mockEntityManager,
- );
- expect(
- mockGlobalWorkspaceOrmManager.executeInWorkspaceContext,
- ).not.toHaveBeenCalled();
- });
-
- it('should use executeInWorkspaceContext when no entityManager provided', async () => {
- await service.addAutomatedTrigger({
- workflowId,
- type: AutomatedTriggerType.CRON,
- settings: cronSettings,
- workspaceId,
- });
-
- expect(
- mockGlobalWorkspaceOrmManager.executeInWorkspaceContext,
- ).toHaveBeenCalled();
- });
- });
-
- describe('deleteAutomatedTrigger', () => {
- const workspaceId = 'workspace-1';
- const workflowId = 'workflow-1';
-
- it('should delete trigger by workflowId', async () => {
- await service.deleteAutomatedTrigger({
- workflowId,
- workspaceId,
- });
-
- expect(mockRepository.delete).toHaveBeenCalledWith({ workflowId });
- });
-
- it('should use entityManager when provided', async () => {
- const mockEntityManager = {} as any;
-
- await service.deleteAutomatedTrigger({
- workflowId,
- workspaceId,
- entityManager: mockEntityManager,
- });
-
- expect(mockRepository.delete).toHaveBeenCalledWith(
- { workflowId },
- mockEntityManager,
- );
- expect(
- mockGlobalWorkspaceOrmManager.executeInWorkspaceContext,
- ).not.toHaveBeenCalled();
- });
- });
-});