Skip to content

The open alternative to Salesforce, designed for AI.

fix(front): strip float noise from percentage draft values (#26401)

Belkouchea56e3badc72e
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/computeDraftValueFromFieldValue.test.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/computeDraftValueFromFieldValue.test.ts
new file mode 100644
index 00000000000..badf70c9605
--- /dev/null
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/__tests__/computeDraftValueFromFieldValue.test.ts
@@ -0,0 +1,69 @@
+import { type FieldDefinition } from '@/object-record/record-field/ui/types/FieldDefinition';
+import { type FieldNumberMetadata } from '@/object-record/record-field/ui/types/FieldMetadata';
+import { computeDraftValueFromFieldValue } from '@/object-record/record-field/ui/utils/computeDraftValueFromFieldValue';
+import { FieldMetadataType } from '~/generated-metadata/graphql';
+
+const percentageFieldDefinition: Pick<
+ FieldDefinition<FieldNumberMetadata>,
+ 'type' | 'metadata'
+> = {
+ type: FieldMetadataType.NUMBER,
+ metadata: {
+ fieldName: 'conversionRate',
+ placeHolder: '',
+ settings: { type: 'percentage' },
+ },
+};
+
+const numberFieldDefinition: Pick<
+ FieldDefinition<FieldNumberMetadata>,
+ 'type' | 'metadata'
+> = {
+ type: FieldMetadataType.NUMBER,
+ metadata: {
+ fieldName: 'employees',
+ placeHolder: '',
+ settings: { type: 'number' },
+ },
+};
+
+describe('computeDraftValueFromFieldValue', () => {
+ it('should convert a percentage value to a draft without float noise', () => {
+ expect(
+ computeDraftValueFromFieldValue({
+ fieldDefinition: percentageFieldDefinition,
+ fieldValue: 0.29,
+ }),
+ ).toBe('29');
+ expect(
+ computeDraftValueFromFieldValue({
+ fieldDefinition: percentageFieldDefinition,
+ fieldValue: 0.07,
+ }),
+ ).toBe('7');
+ expect(
+ computeDraftValueFromFieldValue({
+ fieldDefinition: percentageFieldDefinition,
+ fieldValue: 0.12345,
+ }),
+ ).toBe('12.345');
+ });
+
+ it('should return an empty draft for an empty percentage value', () => {
+ expect(
+ computeDraftValueFromFieldValue({
+ fieldDefinition: percentageFieldDefinition,
+ fieldValue: null,
+ }),
+ ).toBe('');
+ });
+
+ it('should keep a plain number value as is', () => {
+ expect(
+ computeDraftValueFromFieldValue({
+ fieldDefinition: numberFieldDefinition,
+ fieldValue: 0.29,
+ }),
+ ).toBe(0.29);
+ });
+});
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/computeDraftValueFromFieldValue.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/computeDraftValueFromFieldValue.ts
index 58e3bd6dde3..ecfb26d66f7 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/computeDraftValueFromFieldValue.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/computeDraftValueFromFieldValue.ts
@@ -16,6 +16,8 @@ import { isDefined } from 'twenty-shared/utils';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
import { stripSimpleQuotesFromString } from '~/utils/string/stripSimpleQuotesFromString';
+const PERCENTAGE_DRAFT_VALUE_PRECISION = 15;
+
type computeDraftValueFromFieldValueParams<FieldValue> = {
fieldDefinition: Pick<FieldDefinition<FieldMetadata>, 'type' | 'metadata'>;
fieldValue: FieldValue;
@@ -87,8 +89,8 @@ export const computeDraftValueFromFieldValue = <FieldValue>({
) {
return (isUndefinedOrNull(fieldValue)
? ''
- : (
- fieldValue * 100
+ : parseFloat(
+ (fieldValue * 100).toPrecision(PERCENTAGE_DRAFT_VALUE_PRECISION),
).toString()) as unknown as FieldInputDraftValue<FieldValue>;
}