The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Fix app front component widget showing "No Data" after install (#27976)
martmulla573e84edad4
diff --git a/packages/twenty-front/src/modules/metadata-store/effect-components/MetadataStoreSSEEffect.tsx b/packages/twenty-front/src/modules/metadata-store/effect-components/MetadataStoreSSEEffect.tsxindex 6e2513b14f6..419303c6e46 100644--- a/packages/twenty-front/src/modules/metadata-store/effect-components/MetadataStoreSSEEffect.tsx+++ b/packages/twenty-front/src/modules/metadata-store/effect-components/MetadataStoreSSEEffect.tsx@@ -2,12 +2,24 @@ import { useListenToMetadataOperationBrowserEvent } from '@/browser-event/hooks/import { useCleanMorphRelationsTargetingObjectMetadataId } from '@/metadata-store/hooks/useCleanMorphRelationsTargetingObjectMetadataId';import { useUpdateMetadataStoreDraft } from '@/metadata-store/hooks/useUpdateMetadataStoreDraft';import { type MetadataEntityKey } from '@/metadata-store/states/metadataStoreState';+import { type FlatPageLayoutWidget } from '@/metadata-store/types/FlatPageLayoutWidget';import { type MetadataEntityTypeMap } from '@/metadata-store/types/MetadataEntityTypeMap';+import { addTypenamesToFlatPageLayoutWidget } from '@/metadata-store/utils/addTypenamesToFlatPageLayoutWidget';import { mapAllMetadataNameToEntityKey } from '@/metadata-store/utils/mapAllMetadataNameToEntityKey';import { isDefined } from 'twenty-shared/utils';type AnyMetadataEntity = MetadataEntityTypeMap[MetadataEntityKey];+const toMetadataStoreItem = (+ entityKey: MetadataEntityKey,+ record: Record<string, unknown>,+): AnyMetadataEntity =>+ entityKey === 'pageLayoutWidgets'+ ? addTypenamesToFlatPageLayoutWidget(+ record as unknown as FlatPageLayoutWidget,+ )+ : (record as unknown as AnyMetadataEntity);+export const MetadataStoreSSEEffect = () => {const { addToDraft, removeFromDraft, applyChanges } =useUpdateMetadataStoreDraft();@@ -29,8 +41,10 @@ export const MetadataStoreSSEEffect = () => {addToDraft({key: entityKey,items: [- eventDetail.operation- .createdRecord as unknown as AnyMetadataEntity,+ toMetadataStoreItem(+ entityKey,+ eventDetail.operation.createdRecord,+ ),],collectionHash,});@@ -40,8 +54,10 @@ export const MetadataStoreSSEEffect = () => {addToDraft({key: entityKey,items: [- eventDetail.operation- .updatedRecord as unknown as AnyMetadataEntity,+ toMetadataStoreItem(+ entityKey,+ eventDetail.operation.updatedRecord,+ ),],collectionHash,});diff --git a/packages/twenty-front/src/modules/metadata-store/utils/__tests__/addTypenamesToFlatPageLayoutWidget.test.ts b/packages/twenty-front/src/modules/metadata-store/utils/__tests__/addTypenamesToFlatPageLayoutWidget.test.tsnew file mode 100644index 00000000000..b071b3ba0f9--- /dev/null+++ b/packages/twenty-front/src/modules/metadata-store/utils/__tests__/addTypenamesToFlatPageLayoutWidget.test.ts@@ -0,0 +1,108 @@+import { type FlatPageLayoutWidget } from '@/metadata-store/types/FlatPageLayoutWidget';+import { addTypenamesToFlatPageLayoutWidget } from '@/metadata-store/utils/addTypenamesToFlatPageLayoutWidget';+import { isFieldWidget } from '@/page-layout/widgets/field/utils/isFieldWidget';+import { isWidgetConfigurationOfType } from '@/side-panel/pages/page-layout/utils/isWidgetConfigurationOfType';+import {+ FieldDisplayMode,+ PageLayoutTabLayoutMode,+ WidgetConfigurationType,+ WidgetType,+} from '~/generated-metadata/graphql';++const buildMetadataEventWidget = (+ widgetProperties: Partial<FlatPageLayoutWidget>,+): FlatPageLayoutWidget =>+ ({+ id: 'widget-id',+ applicationId: 'application-id',+ universalIdentifier: 'widget-universal-identifier',+ isSystemSideEffect: false,+ pageLayoutTabId: 'tab-id',+ title: 'Widget',+ type: WidgetType.FRONT_COMPONENT,+ isActive: true,+ objectMetadataId: null,+ createdAt: '2026-01-01T00:00:00.000Z',+ updatedAt: '2026-01-01T00:00:00.000Z',+ deletedAt: null,+ configuration: {+ configurationType: WidgetConfigurationType.FRONT_COMPONENT,+ frontComponentId: 'front-component-id',+ },+ position: {+ layoutMode: PageLayoutTabLayoutMode.VERTICAL_LIST,+ index: 0,+ },+ ...widgetProperties,+ }) as FlatPageLayoutWidget;++describe('addTypenamesToFlatPageLayoutWidget', () => {+ it('should let a front component widget from a metadata event be read as one', () => {+ const widget = addTypenamesToFlatPageLayoutWidget(+ buildMetadataEventWidget({}),+ );++ expect(+ isWidgetConfigurationOfType(+ widget.configuration,+ 'FrontComponentConfiguration',+ ),+ ).toBe(true);+ expect(widget.configuration).toEqual({+ __typename: 'FrontComponentConfiguration',+ configurationType: WidgetConfigurationType.FRONT_COMPONENT,+ frontComponentId: 'front-component-id',+ });+ });++ it('should let a field widget from a metadata event be read as one', () => {+ const widget = addTypenamesToFlatPageLayoutWidget(+ buildMetadataEventWidget({+ type: WidgetType.FIELD,+ configuration: {+ configurationType: WidgetConfigurationType.FIELD,+ fieldMetadataId: 'field-metadata-id',+ fieldDisplayMode: FieldDisplayMode.FIELD,+ } as FlatPageLayoutWidget['configuration'],+ }),+ );++ expect(isFieldWidget(widget)).toBe(true);+ });++ it.each([+ [PageLayoutTabLayoutMode.GRID, 'PageLayoutWidgetGridPosition'],+ [+ PageLayoutTabLayoutMode.VERTICAL_LIST,+ 'PageLayoutWidgetVerticalListPosition',+ ],+ [PageLayoutTabLayoutMode.CANVAS, 'PageLayoutWidgetCanvasPosition'],+ ])('should type a %s position as %s', (layoutMode, expectedTypename) => {+ const widget = addTypenamesToFlatPageLayoutWidget(+ buildMetadataEventWidget({+ position: { layoutMode } as FlatPageLayoutWidget['position'],+ }),+ );++ expect(widget.position?.__typename).toBe(expectedTypename);+ });++ it('should keep a widget without position untouched apart from its configuration', () => {+ const widget = addTypenamesToFlatPageLayoutWidget(+ buildMetadataEventWidget({ position: null }),+ );++ expect(widget.position).toBeNull();+ expect(widget.configuration.__typename).toBe('FrontComponentConfiguration');+ });++ it('should return the same widget when it already comes from GraphQL', () => {+ const graphqlWidget = addTypenamesToFlatPageLayoutWidget(+ buildMetadataEventWidget({}),+ );++ expect(addTypenamesToFlatPageLayoutWidget(graphqlWidget)).toBe(+ graphqlWidget,+ );+ });+});diff --git a/packages/twenty-front/src/modules/metadata-store/utils/addTypenamesToFlatPageLayoutWidget.ts b/packages/twenty-front/src/modules/metadata-store/utils/addTypenamesToFlatPageLayoutWidget.tsnew file mode 100644index 00000000000..64b2f7167b2--- /dev/null+++ b/packages/twenty-front/src/modules/metadata-store/utils/addTypenamesToFlatPageLayoutWidget.ts@@ -0,0 +1,43 @@+import { type FlatPageLayoutWidget } from '@/metadata-store/types/FlatPageLayoutWidget';+import { PAGE_LAYOUT_WIDGET_POSITION_TYPENAME_BY_LAYOUT_MODE } from '@/page-layout/constants/PageLayoutWidgetPositionTypenameByLayoutMode';+import { WIDGET_CONFIGURATION_TYPENAME_BY_CONFIGURATION_TYPE } from '@/page-layout/constants/WidgetConfigurationTypenameByConfigurationType';+import { isDefined } from 'twenty-shared/utils';+import { type PageLayoutWidgetPosition } from '~/generated-metadata/graphql';++export const addTypenamesToFlatPageLayoutWidget = (+ flatPageLayoutWidget: FlatPageLayoutWidget,+): FlatPageLayoutWidget => {+ const { configuration, position } = flatPageLayoutWidget;++ const isConfigurationTyped =+ !isDefined(configuration) || isDefined(configuration.__typename);+ const isPositionTyped =+ !isDefined(position) || isDefined(position.__typename);++ if (isConfigurationTyped && isPositionTyped) {+ return flatPageLayoutWidget;+ }++ return {+ ...flatPageLayoutWidget,+ __typename: 'PageLayoutWidget',+ configuration: isConfigurationTyped+ ? configuration+ : ({+ ...configuration,+ __typename:+ WIDGET_CONFIGURATION_TYPENAME_BY_CONFIGURATION_TYPE[+ configuration.configurationType+ ],+ } as FlatPageLayoutWidget['configuration']),+ position: isPositionTyped+ ? position+ : ({+ ...position,+ __typename:+ PAGE_LAYOUT_WIDGET_POSITION_TYPENAME_BY_LAYOUT_MODE[+ position.layoutMode+ ],+ } as PageLayoutWidgetPosition),+ };+};diff --git a/packages/twenty-front/src/modules/page-layout/constants/PageLayoutWidgetPositionTypenameByLayoutMode.ts b/packages/twenty-front/src/modules/page-layout/constants/PageLayoutWidgetPositionTypenameByLayoutMode.tsnew file mode 100644index 00000000000..a1907b7624e--- /dev/null+++ b/packages/twenty-front/src/modules/page-layout/constants/PageLayoutWidgetPositionTypenameByLayoutMode.ts@@ -0,0 +1,14 @@+import {+ PageLayoutTabLayoutMode,+ type PageLayoutWidgetPosition,+} from '~/generated-metadata/graphql';++export const PAGE_LAYOUT_WIDGET_POSITION_TYPENAME_BY_LAYOUT_MODE = {+ [PageLayoutTabLayoutMode.GRID]: 'PageLayoutWidgetGridPosition',+ [PageLayoutTabLayoutMode.VERTICAL_LIST]:+ 'PageLayoutWidgetVerticalListPosition',+ [PageLayoutTabLayoutMode.CANVAS]: 'PageLayoutWidgetCanvasPosition',+} as const satisfies Record<+ PageLayoutTabLayoutMode,+ NonNullable<PageLayoutWidgetPosition['__typename']>+>;diff --git a/packages/twenty-front/src/modules/page-layout/constants/WidgetConfigurationTypenameByConfigurationType.ts b/packages/twenty-front/src/modules/page-layout/constants/WidgetConfigurationTypenameByConfigurationType.tsnew file mode 100644index 00000000000..dc383fcae83--- /dev/null+++ b/packages/twenty-front/src/modules/page-layout/constants/WidgetConfigurationTypenameByConfigurationType.ts@@ -0,0 +1,44 @@+import {+ type WidgetConfiguration,+ WidgetConfigurationType,+} from '~/generated-metadata/graphql';++export const WIDGET_CONFIGURATION_TYPENAME_BY_CONFIGURATION_TYPE = {+ [WidgetConfigurationType.AGGREGATE_CHART]: 'AggregateChartConfiguration',+ [WidgetConfigurationType.BAR_CHART]: 'BarChartConfiguration',+ [WidgetConfigurationType.CALENDAR]: 'CalendarConfiguration',+ [WidgetConfigurationType.CALL_RECORDING_SUMMARY]:+ 'CallRecordingSummaryConfiguration',+ [WidgetConfigurationType.CALL_RECORDING_TRANSCRIPT]:+ 'CallRecordingTranscriptConfiguration',+ [WidgetConfigurationType.CHAT]: 'ChatConfiguration',+ [WidgetConfigurationType.CHAT_THREADS]: 'ChatThreadsConfiguration',+ [WidgetConfigurationType.EMAILS]: 'EmailsConfiguration',+ [WidgetConfigurationType.EMAIL_THREAD]: 'EmailThreadConfiguration',+ [WidgetConfigurationType.FIELD]: 'FieldConfiguration',+ [WidgetConfigurationType.FIELDS]: 'FieldsConfiguration',+ [WidgetConfigurationType.FIELD_RICH_TEXT]: 'FieldRichTextConfiguration',+ [WidgetConfigurationType.FILES]: 'FilesConfiguration',+ [WidgetConfigurationType.FORM_FIELD]: 'FormFieldConfiguration',+ [WidgetConfigurationType.FRONT_COMPONENT]: 'FrontComponentConfiguration',+ [WidgetConfigurationType.IFRAME]: 'IframeConfiguration',+ [WidgetConfigurationType.LINE_CHART]: 'LineChartConfiguration',+ [WidgetConfigurationType.MESSAGE_CAMPAIGN_BODY]:+ 'MessageCampaignBodyConfiguration',+ [WidgetConfigurationType.MESSAGE_CAMPAIGN_DETAILS]:+ 'MessageCampaignDetailsConfiguration',+ [WidgetConfigurationType.NOTES]: 'NotesConfiguration',+ [WidgetConfigurationType.PIE_CHART]: 'PieChartConfiguration',+ [WidgetConfigurationType.RECORD_TABLE]: 'RecordTableConfiguration',+ [WidgetConfigurationType.STANDALONE_RICH_TEXT]:+ 'StandaloneRichTextConfiguration',+ [WidgetConfigurationType.TASKS]: 'TasksConfiguration',+ [WidgetConfigurationType.TIMELINE]: 'TimelineConfiguration',+ [WidgetConfigurationType.VIEW]: 'ViewConfiguration',+ [WidgetConfigurationType.WORKFLOW]: 'WorkflowConfiguration',+ [WidgetConfigurationType.WORKFLOW_RUN]: 'WorkflowRunConfiguration',+ [WidgetConfigurationType.WORKFLOW_VERSION]: 'WorkflowVersionConfiguration',+} as const satisfies Record<+ WidgetConfigurationType,+ NonNullable<WidgetConfiguration['__typename']>+>;diff --git a/packages/twenty-front/src/modules/page-layout/states/selectors/__tests__/pageLayoutWidgetsByTabIdSelector.test.ts b/packages/twenty-front/src/modules/page-layout/states/selectors/__tests__/pageLayoutWidgetsByTabIdSelector.test.tsnew file mode 100644index 00000000000..69c09196e09--- /dev/null+++ b/packages/twenty-front/src/modules/page-layout/states/selectors/__tests__/pageLayoutWidgetsByTabIdSelector.test.ts@@ -0,0 +1,52 @@+import { createStore } from 'jotai';++import { metadataStoreState } from '@/metadata-store/states/metadataStoreState';+import { pageLayoutWidgetsByTabIdSelector } from '@/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector';+import { isWidgetConfigurationOfType } from '@/side-panel/pages/page-layout/utils/isWidgetConfigurationOfType';+import {+ PageLayoutTabLayoutMode,+ WidgetConfigurationType,+ WidgetType,+} from '~/generated-metadata/graphql';++describe('pageLayoutWidgetsByTabIdSelector', () => {+ it('should read a front component widget cached from a metadata event as one', () => {+ const store = createStore();++ store.set(metadataStoreState.atomFamily('pageLayoutWidgets'), {+ current: [+ {+ id: 'front-component-widget',+ pageLayoutTabId: 'app-tab',+ title: 'App widget',+ type: WidgetType.FRONT_COMPONENT,+ isActive: true,+ configuration: {+ configurationType: WidgetConfigurationType.FRONT_COMPONENT,+ frontComponentId: 'front-component-id',+ },+ position: {+ layoutMode: PageLayoutTabLayoutMode.VERTICAL_LIST,+ index: 0,+ },+ },+ ],+ draft: [],+ status: 'up-to-date',+ currentCollectionHash: 'server-collection-hash',+ });++ const [widget] =+ store.get(pageLayoutWidgetsByTabIdSelector.atom).get('app-tab') ?? [];++ expect(+ isWidgetConfigurationOfType(+ widget?.configuration,+ 'FrontComponentConfiguration',+ ),+ ).toBe(true);+ expect(widget?.position?.__typename).toBe(+ 'PageLayoutWidgetVerticalListPosition',+ );+ });+});diff --git a/packages/twenty-front/src/modules/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector.ts b/packages/twenty-front/src/modules/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector.tsindex fcedcbb98e8..74c61d9f223 100644--- a/packages/twenty-front/src/modules/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector.ts+++ b/packages/twenty-front/src/modules/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector.ts@@ -1,5 +1,6 @@import { metadataStoreState } from '@/metadata-store/states/metadataStoreState';import { type FlatPageLayoutWidget } from '@/metadata-store/types/FlatPageLayoutWidget';+import { addTypenamesToFlatPageLayoutWidget } from '@/metadata-store/utils/addTypenamesToFlatPageLayoutWidget';import { createAtomSelector } from '@/ui/utilities/state/jotai/utils/createAtomSelector';import { isDefined } from 'twenty-shared/utils';@@ -13,7 +14,8 @@ export const pageLayoutWidgetsByTabIdSelector = createAtomSelector<const widgetsByTabId = new Map<string, FlatPageLayoutWidget[]>();- for (const widget of allFlatWidgets) {+ for (const flatWidget of allFlatWidgets) {+ const widget = addTypenamesToFlatPageLayoutWidget(flatWidget);const existing = widgetsByTabId.get(widget.pageLayoutTabId);if (isDefined(existing)) {diff --git a/packages/twenty-front/src/modules/side-panel/pages/page-layout/constants/GraphConfigurationTypeToConfigTypename.ts b/packages/twenty-front/src/modules/side-panel/pages/page-layout/constants/GraphConfigurationTypeToConfigTypename.tsdeleted file mode 100644index 1ec98dd8a79..00000000000--- a/packages/twenty-front/src/modules/side-panel/pages/page-layout/constants/GraphConfigurationTypeToConfigTypename.ts+++ /dev/null@@ -1,10 +0,0 @@-import { WidgetConfigurationType } from '~/generated-metadata/graphql';--export const GRAPH_CONFIGURATION_TYPE_TO_CONFIG_TYPENAME: Partial<- Record<WidgetConfigurationType, string>-> = {- [WidgetConfigurationType.BAR_CHART]: 'BarChartConfiguration',- [WidgetConfigurationType.LINE_CHART]: 'LineChartConfiguration',- [WidgetConfigurationType.PIE_CHART]: 'PieChartConfiguration',- [WidgetConfigurationType.AGGREGATE_CHART]: 'AggregateChartConfiguration',-} as const;diff --git a/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/useUpdateGraphTypeConfig.ts b/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/useUpdateGraphTypeConfig.tsindex 289f64de3c7..aaaeadbb44e 100644--- a/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/useUpdateGraphTypeConfig.ts+++ b/packages/twenty-front/src/modules/side-panel/pages/page-layout/hooks/useUpdateGraphTypeConfig.ts@@ -1,4 +1,4 @@-import { GRAPH_CONFIGURATION_TYPE_TO_CONFIG_TYPENAME } from '@/side-panel/pages/page-layout/constants/GraphConfigurationTypeToConfigTypename';+import { WIDGET_CONFIGURATION_TYPENAME_BY_CONFIGURATION_TYPE } from '@/page-layout/constants/WidgetConfigurationTypenameByConfigurationType';import { type ChartConfiguration } from '@/side-panel/pages/page-layout/types/ChartConfiguration';import { GraphType } from '@/side-panel/pages/page-layout/types/GraphType';import { convertAggregateOperationForDateField } from '@/side-panel/pages/page-layout/utils/convertAggregateOperationForDateField';@@ -80,7 +80,9 @@ export const useGetConfigToUpdateAfterGraphTypeChange = ({let configToUpdate = {__typename:- GRAPH_CONFIGURATION_TYPE_TO_CONFIG_TYPENAME[newConfigurationType],+ WIDGET_CONFIGURATION_TYPENAME_BY_CONFIGURATION_TYPE[+ newConfigurationType+ ],configurationType: newConfigurationType,} as Partial<ChartConfiguration>;