Skip to content

The open alternative to Salesforce, designed for AI.

Add actor field to any filter (#26334)

BOHEUSa75ed7d0628c
diff --git a/packages/twenty-shared/src/utils/filter/turnAnyFieldFilterIntoRecordGqlFilter.ts b/packages/twenty-shared/src/utils/filter/turnAnyFieldFilterIntoRecordGqlFilter.ts
index 59b2e8355b5..6f4e4e8c9f7 100644
--- a/packages/twenty-shared/src/utils/filter/turnAnyFieldFilterIntoRecordGqlFilter.ts
+++ b/packages/twenty-shared/src/utils/filter/turnAnyFieldFilterIntoRecordGqlFilter.ts
@@ -82,6 +82,17 @@ export const turnAnyFieldFilterIntoRecordGqlFilter = ({
} satisfies RecordFilter);
break;
}
+ case FieldMetadataType.ACTOR: {
+ anyFieldRecordFilters.push({
+ ...createAnyFieldRecordFilterBaseProperties({
+ filterValue,
+ fieldMetadataItem: field,
+ }),
+ operand: ViewFilterOperand.CONTAINS,
+ type: 'ACTOR',
+ } satisfies RecordFilter);
+ break;
+ }
case FieldMetadataType.ARRAY: {
anyFieldRecordFilters.push({
...createAnyFieldRecordFilterBaseProperties({
diff --git a/packages/twenty-shared/src/utils/filter/utils/__tests__/turnAnyFieldFilterIntoRecordGqlFilter.test.ts b/packages/twenty-shared/src/utils/filter/utils/__tests__/turnAnyFieldFilterIntoRecordGqlFilter.test.ts
index 8002b6270d4..468f0ed8485 100644
--- a/packages/twenty-shared/src/utils/filter/utils/__tests__/turnAnyFieldFilterIntoRecordGqlFilter.test.ts
+++ b/packages/twenty-shared/src/utils/filter/utils/__tests__/turnAnyFieldFilterIntoRecordGqlFilter.test.ts
@@ -43,6 +43,13 @@ const arrayFieldMetadataItem: PartialFieldMetadataItem = {
name: 'arrayField',
};
+const actorFieldMetadataItem: PartialFieldMetadataItem = {
+ ...baseFieldMetadataItem,
+ id: 'actor-field-id',
+ type: FieldMetadataType.ACTOR,
+ name: 'actorField',
+};
+
const emailsFieldMetadataItem: PartialFieldMetadataItem = {
...baseFieldMetadataItem,
id: 'emails-field-id',
@@ -144,6 +151,7 @@ const mockObjectMetadataItemWithAllFields = {
linksFieldMetadataItem,
fullNameFieldMetadataItem,
arrayFieldMetadataItem,
+ actorFieldMetadataItem,
emailsFieldMetadataItem,
phonesFieldMetadataItem,
numberFieldMetadataItem,
@@ -296,6 +304,57 @@ describe('turnAnyFieldFilterIntoRecordGqlFilter', () => {
});
});
+ describe('ACTOR field type', () => {
+ it('should generate correct filter for actor field', () => {
+ const filterValue = 'test';
+
+ const result = turnAnyFieldFilterIntoRecordGqlFilter({
+ filterValue,
+ fields: [actorFieldMetadataItem],
+ });
+
+ expect(result.recordGqlOperationFilter.or).toContainEqual({
+ or: [
+ {
+ [actorFieldMetadataItem.name]: {
+ name: {
+ ilike: `%${filterValue}%`,
+ },
+ },
+ },
+ ],
+ });
+ });
+
+ it('should also match on actor source when filter value corresponds to a source', () => {
+ const filterValue = 'manual';
+
+ const result = turnAnyFieldFilterIntoRecordGqlFilter({
+ filterValue,
+ fields: [actorFieldMetadataItem],
+ });
+
+ expect(result.recordGqlOperationFilter.or).toContainEqual({
+ or: [
+ {
+ [actorFieldMetadataItem.name]: {
+ name: {
+ ilike: `%${filterValue}%`,
+ },
+ },
+ },
+ {
+ [actorFieldMetadataItem.name]: {
+ source: {
+ in: ['MANUAL'],
+ },
+ },
+ },
+ ],
+ });
+ });
+ });
+
describe('ARRAY field type', () => {
it('should generate correct filter for array field', () => {
const filterValue = 'test';