The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Remove the Workflow version column from the workflow runs index (#27974)
Thomas Trompetteaaee94d72dde
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-upgrade-version-command.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-upgrade-version-command.module.tsindex 1454e289d7e..183755b21af 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-upgrade-version-command.module.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-upgrade-version-command.module.ts@@ -6,6 +6,7 @@ import { RemoveCampaignListStatColumnsCommand } from 'src/database/commands/upgrimport { AddCampaignListViewCommand } from 'src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1791979361904-add-campaign-list-view.command';import { RenameDevelopersSettingsCommandMenuItemCommand } from 'src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1791988325586-rename-developers-settings-command-menu-item.command';import { BackfillMorphRelationHeadsCommand } from 'src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1791998420300-backfill-morph-relation-heads.command';+import { RemoveWorkflowRunIndexWorkflowVersionColumnCommand } from 'src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1792051845780-remove-workflow-run-index-workflow-version-column.command';import { ApplicationModule } from 'src/engine/core-modules/application/application.module';import { WorkspaceCacheModule } from 'src/engine/workspace-cache/workspace-cache.module';import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspace-migration/workspace-migration.module';@@ -23,6 +24,7 @@ import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspaceAddCampaignListViewCommand,RenameDevelopersSettingsCommandMenuItemCommand,BackfillMorphRelationHeadsCommand,+ RemoveWorkflowRunIndexWorkflowVersionColumnCommand,],})export class V2_48_UpgradeVersionCommandModule {}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1792051845780-remove-workflow-run-index-workflow-version-column.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1792051845780-remove-workflow-run-index-workflow-version-column.command.tsnew file mode 100644index 00000000000..9abad91d35b--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/2-48-workspace-command-1792051845780-remove-workflow-run-index-workflow-version-column.command.ts@@ -0,0 +1,76 @@+import { Command } from 'nest-commander';+import { TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER } from 'twenty-shared/application';++import { ProvisionedWorkspaceCommandRunner } from 'src/database/commands/command-runners/provisioned-workspace.command-runner';+import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';+import { type RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspace.command-runner';+import { findStandardWorkflowRunIndexWorkflowVersionViewFields } from 'src/database/commands/upgrade-version-command/2-48/utils/find-standard-workflow-run-index-workflow-version-view-fields.util';+import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';+import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';++@RegisteredWorkspaceCommand('2.48.0', 1792051845780)+@Command({+ name: 'upgrade:2-48:remove-workflow-run-index-workflow-version-column',+ description:+ 'Remove the standard "Workflow version" column from the workflow runs index view',+})+export class RemoveWorkflowRunIndexWorkflowVersionColumnCommand extends ProvisionedWorkspaceCommandRunner {+ constructor(+ protected readonly workspaceIteratorService: WorkspaceIteratorService,+ private readonly workspaceCacheService: WorkspaceCacheService,+ private readonly workspaceMigrationValidateBuildAndRunService: WorkspaceMigrationValidateBuildAndRunService,+ ) {+ super(workspaceIteratorService);+ }++ override async runOnWorkspace(args: RunOnWorkspaceArgs): Promise<void> {+ await this.up(args);+ }++ async up({ workspaceId, options }: RunOnWorkspaceArgs): Promise<void> {+ const flatMaps = await this.workspaceCacheService.getOrRecompute(+ workspaceId,+ ['flatViewMaps', 'flatViewFieldMaps'],+ );++ const viewFieldsToDelete =+ findStandardWorkflowRunIndexWorkflowVersionViewFields(flatMaps);++ if (viewFieldsToDelete.length === 0) {+ return;+ }++ this.logger.log(+ `${options.dryRun ? '[DRY RUN] ' : ''}Workspace ${workspaceId}: removing the workflow runs "Workflow version" column`,+ );++ if (options.dryRun) {+ return;+ }++ const result =+ await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunLegacyWorkspaceMigration(+ {+ workspaceId,+ isSystemBuild: true,+ applicationUniversalIdentifier:+ TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER,+ allFlatEntityOperationByMetadataName: {+ viewField: {+ flatEntityToCreate: [],+ flatEntityToDelete: viewFieldsToDelete,+ flatEntityToUpdate: [],+ },+ },+ },+ );++ if (result.status === 'fail') {+ throw new WorkspaceMigrationBuilderException(result);+ }+ }++ async down(_args: RunOnWorkspaceArgs): Promise<void> {}+}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/utils/find-standard-workflow-run-index-workflow-version-view-fields.util.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/utils/find-standard-workflow-run-index-workflow-version-view-fields.util.tsnew file mode 100644index 00000000000..7312f5523fc--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-48/utils/find-standard-workflow-run-index-workflow-version-view-fields.util.ts@@ -0,0 +1,36 @@+import { TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER } from 'twenty-shared/application';+import { STANDARD_OBJECTS } from 'twenty-shared/metadata';+import { isDefined } from 'twenty-shared/utils';++import { type AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';+import { findManyFlatEntityByUniversalIdentifierInUniversalFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-many-flat-entity-by-universal-identifier-in-universal-flat-entity-maps.util';+import { type FlatViewField } from 'src/engine/metadata-modules/flat-view-field/types/flat-view-field.type';++export const findStandardWorkflowRunIndexWorkflowVersionViewFields = ({+ flatViewMaps,+ flatViewFieldMaps,+}: Pick<+ AllFlatEntityMaps,+ 'flatViewMaps' | 'flatViewFieldMaps'+>): FlatViewField[] => {+ const flatView =+ flatViewMaps.byUniversalIdentifier[+ STANDARD_OBJECTS.workflowRun.views.allWorkflowRuns.universalIdentifier+ ];++ if (!isDefined(flatView)) {+ return [];+ }++ return findManyFlatEntityByUniversalIdentifierInUniversalFlatEntityMaps({+ flatEntityMaps: flatViewFieldMaps,+ universalIdentifiers: flatView.viewFieldUniversalIdentifiers,+ }).filter(+ (flatViewField) =>+ flatViewField.fieldMetadataUniversalIdentifier ===+ STANDARD_OBJECTS.workflowRun.fields.workflowVersion+ .universalIdentifier &&+ flatViewField.applicationUniversalIdentifier ===+ TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER,+ );+};