The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
refactor(i18n) - share the message-id hash and the translatable registry [1/6] (#24300)
Félix Malfaitac81e8d35f96
diff --git a/packages/twenty-sdk/src/cli/utilities/translations/__tests__/application-translations.spec.ts b/packages/twenty-sdk/src/cli/utilities/translations/__tests__/application-translations.spec.tsindex 9c609e38b4d..c6d6b7f65dd 100644--- a/packages/twenty-sdk/src/cli/utilities/translations/__tests__/application-translations.spec.ts+++ b/packages/twenty-sdk/src/cli/utilities/translations/__tests__/application-translations.spec.ts@@ -7,7 +7,7 @@ import { describe, expect, it } from 'vitest';import { getTranslationCatalogKey } from '@/sdk/front-component/translations/message';import { collectTranslatableStrings } from '@/cli/utilities/translations/collect-translatable-strings';import { compileApplicationTranslations } from '@/cli/utilities/translations/compile-application-translations';-import { generateMessageId } from '@/cli/utilities/translations/generate-message-id';+import { generateMessageId } from 'twenty-shared/i18n';import { type Manifest } from 'twenty-shared/application';const buildManifest = (overrides: Record<string, unknown>): Manifest =>@@ -61,6 +61,44 @@ describe('collectTranslatableStrings', () => {'Name',]);});++ // Pins every manifest collection the shared registry maps, so a change to+ // TRANSLATABLE_PROPERTIES_BY_METADATA_NAME that silently drops a collection+ // shows up here rather than as an app shipping untranslatable strings.+ it('collects every translatable property of every mapped manifest collection', () => {+ const manifest = buildManifest({+ objects: [+ {+ labelSingular: 'Rocket',+ labelPlural: 'Rockets',+ description: 'A rocket',+ },+ ],+ fields: [{ label: 'Thrust', description: 'Newtons' }],+ views: [{ name: 'All Rockets' }],+ pageLayoutTabs: [{ title: 'Telemetry' }],+ commandMenuItems: [{ label: 'Launch Rocket', shortLabel: 'Launch' }],+ navigationMenuItems: [{ name: 'Missions' }],+ pageLayouts: [+ { tabs: [{ title: 'Overview', widgets: [{ title: 'Fuel level' }] }] },+ ],+ });++ expect(collectTranslatableStrings(manifest)).toEqual([+ 'A rocket',+ 'All Rockets',+ 'Fuel level',+ 'Launch',+ 'Launch Rocket',+ 'Missions',+ 'Newtons',+ 'Overview',+ 'Rocket',+ 'Rockets',+ 'Telemetry',+ 'Thrust',+ ]);+ });});describe('compileApplicationTranslations', () => {diff --git a/packages/twenty-sdk/src/cli/utilities/translations/collect-translatable-strings.ts b/packages/twenty-sdk/src/cli/utilities/translations/collect-translatable-strings.tsindex 8476cfdad4c..aba239a006f 100644--- a/packages/twenty-sdk/src/cli/utilities/translations/collect-translatable-strings.ts+++ b/packages/twenty-sdk/src/cli/utilities/translations/collect-translatable-strings.ts@@ -1,13 +1,21 @@import { type Manifest } from 'twenty-shared/application';+import {+ TRANSLATABLE_PROPERTIES_BY_METADATA_NAME,+ type TranslatableMetadataName,+} from 'twenty-shared/i18n';-const TRANSLATABLE_KEYS_BY_MANIFEST_KEY: Record<string, readonly string[]> = {- objects: ['labelSingular', 'labelPlural', 'description'],- fields: ['label', 'description'],- views: ['name'],- pageLayoutTabs: ['title'],- commandMenuItems: ['label', 'shortLabel'],- navigationMenuItems: ['name'],-};+// Which manifest collection carries which metadata entity. The properties to+// extract are not listed here on purpose: they come from the shared registry,+// so the SDK cannot drift from what the server actually resolves at runtime.+// Metadata names with no manifest collection (viewFieldGroup) are simply absent.+const MANIFEST_KEY_BY_METADATA_NAME = {+ objectMetadata: 'objects',+ fieldMetadata: 'fields',+ view: 'views',+ pageLayoutTab: 'pageLayoutTabs',+ commandMenuItem: 'commandMenuItems',+ navigationMenuItem: 'navigationMenuItems',+} as const satisfies Partial<Record<TranslatableMetadataName, keyof Manifest>>;export const collectTranslatableStrings = (manifest: Manifest): string[] => {const strings = new Set<string>();@@ -18,25 +26,32 @@ export const collectTranslatableStrings = (manifest: Manifest): string[] => {}};- for (const [manifestKey, fieldKeys] of Object.entries(- TRANSLATABLE_KEYS_BY_MANIFEST_KEY,- )) {- const entities = (manifest as unknown as Record<string, unknown>)[- manifestKey- ];+ const addEntityStrings = (+ entity: unknown,+ metadataName: TranslatableMetadataName,+ ) => {+ if (entity === null || typeof entity !== 'object') {+ return;+ }++ for (const property of TRANSLATABLE_PROPERTIES_BY_METADATA_NAME[+ metadataName+ ]) {+ addString((entity as Record<string, unknown>)[property]);+ }+ };++ for (const [metadataName, manifestKey] of Object.entries(+ MANIFEST_KEY_BY_METADATA_NAME,+ ) as [TranslatableMetadataName, keyof Manifest][]) {+ const entities = manifest[manifestKey];if (!Array.isArray(entities)) {continue;}for (const entity of entities) {- if (entity === null || typeof entity !== 'object') {- continue;- }-- for (const fieldKey of fieldKeys) {- addString((entity as Record<string, unknown>)[fieldKey]);- }+ addEntityStrings(entity, metadataName);}}@@ -44,10 +59,10 @@ export const collectTranslatableStrings = (manifest: Manifest): string[] => {// flat pageLayoutTabs array, so walk the tree to reach them.for (const pageLayout of manifest.pageLayouts ?? []) {for (const tab of pageLayout.tabs ?? []) {- addString(tab.title);+ addEntityStrings(tab, 'pageLayoutTab');for (const widget of tab.widgets ?? []) {- addString(widget.title);+ addEntityStrings(widget, 'pageLayoutWidget');}}}diff --git a/packages/twenty-sdk/src/cli/utilities/translations/compile-application-translations.ts b/packages/twenty-sdk/src/cli/utilities/translations/compile-application-translations.tsindex 52b7f144a15..73f61f99910 100644--- a/packages/twenty-sdk/src/cli/utilities/translations/compile-application-translations.ts+++ b/packages/twenty-sdk/src/cli/utilities/translations/compile-application-translations.ts@@ -4,7 +4,7 @@ import path from 'path';import { parseTranslationCatalogKey } from '@/sdk/front-component/translations/message';import { pathExists, readJson } from '@/cli/utilities/file/fs-utils';import { LOCALES_DIR } from '@/cli/utilities/translations/constants';-import { generateMessageId } from '@/cli/utilities/translations/generate-message-id';+import { generateMessageId } from 'twenty-shared/i18n';import { type TranslationsManifest } from 'twenty-shared/application';import {APP_LOCALES,diff --git a/packages/twenty-sdk/src/cli/utilities/translations/generate-message-id.ts b/packages/twenty-sdk/src/cli/utilities/translations/generate-message-id.tsdeleted file mode 100644index 15216bc8c5c..00000000000--- a/packages/twenty-sdk/src/cli/utilities/translations/generate-message-id.ts+++ /dev/null@@ -1,9 +0,0 @@-import { createHash } from 'node:crypto';--const UNIT_SEPARATOR = '\u001F';--export const generateMessageId = (message: string, context = ''): string =>- createHash('sha256')- .update(message + UNIT_SEPARATOR + (context || ''))- .digest('base64')- .slice(0, 6);diff --git a/packages/twenty-server/src/engine/core-modules/i18n/utils/__tests__/translate-standard-label.util.spec.ts b/packages/twenty-server/src/engine/core-modules/i18n/utils/__tests__/translate-standard-label.util.spec.tsindex 3601bfbdd11..dc94c5c5813 100644--- a/packages/twenty-server/src/engine/core-modules/i18n/utils/__tests__/translate-standard-label.util.spec.ts+++ b/packages/twenty-server/src/engine/core-modules/i18n/utils/__tests__/translate-standard-label.util.spec.ts@@ -1,9 +1,9 @@import { type I18n } from '@lingui/core';-import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';+import { generateMessageId } from 'twenty-shared/i18n';import { translateStandardLabel } from 'src/engine/core-modules/i18n/utils/translate-standard-label.util';-jest.mock('src/engine/core-modules/i18n/utils/generateMessageId');+jest.mock('twenty-shared/i18n');const mockGenerateMessageId = generateMessageId as jest.MockedFunction<typeof generateMessageIddiff --git a/packages/twenty-server/src/engine/core-modules/i18n/utils/generateMessageId.ts b/packages/twenty-server/src/engine/core-modules/i18n/utils/generateMessageId.tsdeleted file mode 100644index 24bb133c3bf..00000000000--- a/packages/twenty-server/src/engine/core-modules/i18n/utils/generateMessageId.ts+++ /dev/null@@ -1,11 +0,0 @@-import crypto from 'crypto';--const UNIT_SEPARATOR = '\u001F';--export function generateMessageId(msg: string, context = '') {- return crypto- .createHash('sha256')- .update(msg + UNIT_SEPARATOR + (context || ''))- .digest('base64')- .slice(0, 6);-}diff --git a/packages/twenty-server/src/engine/core-modules/i18n/utils/translate-standard-label.util.ts b/packages/twenty-server/src/engine/core-modules/i18n/utils/translate-standard-label.util.tsindex 58725960fe2..67828098690 100644--- a/packages/twenty-server/src/engine/core-modules/i18n/utils/translate-standard-label.util.ts+++ b/packages/twenty-server/src/engine/core-modules/i18n/utils/translate-standard-label.util.ts@@ -2,7 +2,7 @@ import { type I18n } from '@lingui/core';import { isNonEmptyString } from '@sniptt/guards';import { isDefined } from 'twenty-shared/utils';-import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';+import { generateMessageId } from 'twenty-shared/i18n';export const translateStandardLabel = ({sourceValue,diff --git a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/translate-tool-label.util.ts b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/translate-tool-label.util.tsindex 615ab5d793b..a9535b08d4a 100644--- a/packages/twenty-server/src/engine/core-modules/tool-provider/utils/translate-tool-label.util.ts+++ b/packages/twenty-server/src/engine/core-modules/tool-provider/utils/translate-tool-label.util.ts@@ -1,7 +1,7 @@import { type APP_LOCALES, SOURCE_LOCALE } from 'twenty-shared/translations';import { type I18nService } from 'src/engine/core-modules/i18n/i18n.service';-import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';+import { generateMessageId } from 'twenty-shared/i18n';export const translateToolLabel = (source: string,diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/__tests__/__snapshots__/overridable-and-translatable-properties.constant.spec.ts.snap b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/__tests__/__snapshots__/overridable-and-translatable-properties.constant.spec.ts.snapindex a9d0b5832d6..8fb950e14c6 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/__tests__/__snapshots__/overridable-and-translatable-properties.constant.spec.ts.snap+++ b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/__tests__/__snapshots__/overridable-and-translatable-properties.constant.spec.ts.snap@@ -98,43 +98,33 @@ exports[`registry-derived override property maps derives the overridable propertexports[`registry-derived override property maps derives the translatable properties for every metadata entity 1`] = `{- "agent": [],- "applicationVariable": [],- "commandMenuItem": [],- "connectionProvider": [],+ "commandMenuItem": [+ "label",+ "shortLabel",+ ],"fieldMetadata": [- "description","label",+ "description",+ ],+ "navigationMenuItem": [+ "name",],- "fieldPermission": [],- "frontComponent": [],- "index": [],- "logicFunction": [],- "navigationMenuItem": [],"objectMetadata": [- "description",- "labelPlural","labelSingular",+ "labelPlural",+ "description",+ ],+ "pageLayoutTab": [+ "title",+ ],+ "pageLayoutWidget": [+ "title",+ ],+ "view": [+ "name",+ ],+ "viewFieldGroup": [+ "name",],- "objectPermission": [],- "pageLayout": [],- "pageLayoutTab": [],- "pageLayoutWidget": [],- "permissionFlag": [],- "role": [],- "rolePermissionFlag": [],- "roleTarget": [],- "rowLevelPermissionPredicate": [],- "rowLevelPermissionPredicateGroup": [],- "searchFieldMetadata": [],- "skill": [],- "view": [],- "viewField": [],- "viewFieldGroup": [],- "viewFilter": [],- "viewFilterGroup": [],- "viewGroup": [],- "viewSort": [],- "webhook": [],}`;diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.ts b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.tsindex 66d10da3121..f8156c52ed3 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.ts@@ -1,3 +1,7 @@+import {+ type TranslatableMetadataName,+ type TranslatablePropertyName,+} from 'twenty-shared/i18n';import { type AllMetadataName } from 'twenty-shared/metadata';import { type UnwrapWasRemovedInUpgrade } from 'src/engine/core-modules/upgrade/decorators/was-removed-in-upgrade.decorator';@@ -40,7 +44,6 @@ type MetadataEntityPropertyConfiguration<: boolean;toCompare: boolean;isOverridable?: boolean;- translatable?: boolean;};};@@ -61,7 +64,6 @@ export const ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME = {toStringify: false,universalProperty: undefined,isOverridable: true,- translatable: true,},icon: {toCompare: true,@@ -95,7 +97,6 @@ export const ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME = {toStringify: false,universalProperty: undefined,isOverridable: true,- translatable: true,},name: { toCompare: true, toStringify: false, universalProperty: undefined },options: {@@ -192,7 +193,6 @@ export const ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME = {toStringify: false,universalProperty: undefined,isOverridable: true,- translatable: true,},icon: {toCompare: true,@@ -215,14 +215,12 @@ export const ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME = {toStringify: false,universalProperty: undefined,isOverridable: true,- translatable: true,},labelSingular: {toCompare: true,toStringify: false,universalProperty: undefined,isOverridable: true,- translatable: true,},namePlural: {toCompare: true,@@ -1316,7 +1314,11 @@ export const ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME = {toStringify: false,universalProperty: 'folderUniversalIdentifier',},- name: { toCompare: true, toStringify: false, universalProperty: undefined },+ name: {+ toCompare: true,+ toStringify: false,+ universalProperty: undefined,+ },link: { toCompare: true, toStringify: false, universalProperty: undefined },icon: { toCompare: true, toStringify: false, universalProperty: undefined },color: {@@ -1911,11 +1913,8 @@ export type MetadataEntityOverridablePropertyName<T extends AllMetadataName> =(typeof ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME)[T]>;-type FilterTranslatableKeys<TConfig> = {- [P in keyof TConfig]: TConfig[P] extends { translatable: true } ? P : never;-}[keyof TConfig];-+// Which properties are translatable is owned by twenty-shared, because the+// application SDK extracts against the same list at build time and the two+// silently drifted when each side kept its own copy.export type MetadataEntityTranslatablePropertyName<T extends AllMetadataName> =- FilterTranslatableKeys<- (typeof ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME)[T]- >;+ T extends TranslatableMetadataName ? TranslatablePropertyName<T> : never;diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-translatable-properties-by-metadata-name.constant.ts b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-translatable-properties-by-metadata-name.constant.tsindex ea607a16c0b..f10233d6781 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-translatable-properties-by-metadata-name.constant.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-translatable-properties-by-metadata-name.constant.ts@@ -1,32 +1,8 @@-import {- ALL_METADATA_NAME,- type AllMetadataName,-} from 'twenty-shared/metadata';--import {- ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME,- type MetadataEntityTranslatablePropertyName,-} from 'src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant';--const computeTranslatableProperties = <T extends AllMetadataName>(- metadataName: T,-): MetadataEntityTranslatablePropertyName<T>[] => {- const config =- ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME[metadataName];-- return (Object.entries(config) as [string, { translatable?: boolean }][])- .filter(([_, conf]) => conf.translatable === true)- .map(([property]) => property as MetadataEntityTranslatablePropertyName<T>);-};--export const ALL_TRANSLATABLE_PROPERTIES_BY_METADATA_NAME = Object.values(- ALL_METADATA_NAME,-).reduce(- (acc, metadataName) => ({- ...acc,- [metadataName]: computeTranslatableProperties(metadataName),- }),- {} as {- [P in AllMetadataName]: MetadataEntityTranslatablePropertyName<P>[];- },-);+import { TRANSLATABLE_PROPERTIES_BY_METADATA_NAME } from 'twenty-shared/i18n';+import { type AllMetadataName } from 'twenty-shared/metadata';++// Widened from the shared literal so it can be indexed by any metadata name;+// entities with no translatable properties are simply absent.+export const ALL_TRANSLATABLE_PROPERTIES_BY_METADATA_NAME: Partial<+ Record<AllMetadataName, readonly string[]>+> = TRANSLATABLE_PROPERTIES_BY_METADATA_NAME;diff --git a/packages/twenty-server/src/engine/metadata-modules/page-layout-tab/utils/__tests__/resolve-page-layout-tab-title.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/page-layout-tab/utils/__tests__/resolve-page-layout-tab-title.util.spec.tsindex 9dd1b243b3d..4b3230c85c3 100644--- a/packages/twenty-server/src/engine/metadata-modules/page-layout-tab/utils/__tests__/resolve-page-layout-tab-title.util.spec.ts+++ b/packages/twenty-server/src/engine/metadata-modules/page-layout-tab/utils/__tests__/resolve-page-layout-tab-title.util.spec.ts@@ -1,9 +1,9 @@import { type I18n } from '@lingui/core';-import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';+import { generateMessageId } from 'twenty-shared/i18n';import { resolvePageLayoutTabTitle } from 'src/engine/metadata-modules/page-layout-tab/utils/resolve-page-layout-tab-title.util';-jest.mock('src/engine/core-modules/i18n/utils/generateMessageId');+jest.mock('twenty-shared/i18n');const mockGenerateMessageId = generateMessageId as jest.MockedFunction<typeof generateMessageIddiff --git a/packages/twenty-server/src/engine/metadata-modules/page-layout-widget/utils/__tests__/resolve-page-layout-widget-title.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/page-layout-widget/utils/__tests__/resolve-page-layout-widget-title.util.spec.tsindex 18a781b437f..54a9d79dece 100644--- a/packages/twenty-server/src/engine/metadata-modules/page-layout-widget/utils/__tests__/resolve-page-layout-widget-title.util.spec.ts+++ b/packages/twenty-server/src/engine/metadata-modules/page-layout-widget/utils/__tests__/resolve-page-layout-widget-title.util.spec.ts@@ -1,9 +1,9 @@import { type I18n } from '@lingui/core';-import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';+import { generateMessageId } from 'twenty-shared/i18n';import { resolvePageLayoutWidgetTitle } from 'src/engine/metadata-modules/page-layout-widget/utils/resolve-page-layout-widget-title.util';-jest.mock('src/engine/core-modules/i18n/utils/generateMessageId');+jest.mock('twenty-shared/i18n');const mockGenerateMessageId = generateMessageId as jest.MockedFunction<typeof generateMessageIddiff --git a/packages/twenty-server/src/engine/metadata-modules/utils/resolve-effective-entity-property.util.ts b/packages/twenty-server/src/engine/metadata-modules/utils/resolve-effective-entity-property.util.tsindex 0b1af5b5826..d1147b1a1b5 100644--- a/packages/twenty-server/src/engine/metadata-modules/utils/resolve-effective-entity-property.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/utils/resolve-effective-entity-property.util.ts@@ -4,7 +4,10 @@ import { SOURCE_LOCALE } from 'twenty-shared/translations';import { isDefined } from 'twenty-shared/utils';import { translateStandardLabel } from 'src/engine/core-modules/i18n/utils/translate-standard-label.util';-import { type MetadataEntityOverridablePropertyName } from 'src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant';+import {+ type MetadataEntityOverridablePropertyName,+ type MetadataEntityTranslatablePropertyName,+} from 'src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant';import { ALL_TRANSLATABLE_PROPERTIES_BY_METADATA_NAME } from 'src/engine/metadata-modules/flat-entity/constant/all-translatable-properties-by-metadata-name.constant';import { type EffectiveEntityI18nContext } from 'src/engine/metadata-modules/utils/effective-entity-i18n-context.type';import { type MetadataPresentationOverrides } from 'src/engine/metadata-modules/utils/metadata-presentation-overrides.type';@@ -19,12 +22,20 @@ export const resolveEffectiveEntityProperty = <T extends AllMetadataName>({metadataName: T;baseValue: string | null | undefined;overrides: MetadataPresentationOverrides<T> | null | undefined;- property: MetadataEntityOverridablePropertyName<T> & string;+ // A property is resolvable if it is overridable, translatable, or both:+ // navigationMenuItem.name is translated but never renamed, so keying this on+ // "overridable" alone would lock it out of the shared resolution path.+ property: (+ | MetadataEntityOverridablePropertyName<T>+ | MetadataEntityTranslatablePropertyName<T>+ ) &+ string;i18nContext: EffectiveEntityI18nContext;}): string => {- const isTranslatable = (- ALL_TRANSLATABLE_PROPERTIES_BY_METADATA_NAME[metadataName] as string[]- ).includes(property);+ const translatableProperties: readonly string[] =+ ALL_TRANSLATABLE_PROPERTIES_BY_METADATA_NAME[metadataName] ?? [];++ const isTranslatable = translatableProperties.includes(property);const overrideValue = (overrides as Record<string, unknown> | null | undefineddiff --git a/packages/twenty-server/src/engine/metadata-modules/view-field-group/utils/__tests__/resolve-view-field-group-name.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/view-field-group/utils/__tests__/resolve-view-field-group-name.util.spec.tsindex 661d8c2bf37..13dbe1a8f31 100644--- a/packages/twenty-server/src/engine/metadata-modules/view-field-group/utils/__tests__/resolve-view-field-group-name.util.spec.ts+++ b/packages/twenty-server/src/engine/metadata-modules/view-field-group/utils/__tests__/resolve-view-field-group-name.util.spec.ts@@ -1,9 +1,9 @@import { type I18n } from '@lingui/core';-import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';+import { generateMessageId } from 'twenty-shared/i18n';import { resolveViewFieldGroupName } from 'src/engine/metadata-modules/view-field-group/utils/resolve-view-field-group-name.util';-jest.mock('src/engine/core-modules/i18n/utils/generateMessageId');+jest.mock('twenty-shared/i18n');const mockGenerateMessageId = generateMessageId as jest.MockedFunction<typeof generateMessageIddiff --git a/packages/twenty-server/src/engine/metadata-modules/view/services/view.service.ts b/packages/twenty-server/src/engine/metadata-modules/view/services/view.service.tsindex cd573f2c8ff..5c606f66b4c 100644--- a/packages/twenty-server/src/engine/metadata-modules/view/services/view.service.ts+++ b/packages/twenty-server/src/engine/metadata-modules/view/services/view.service.ts@@ -6,7 +6,7 @@ import { isDefined } from 'twenty-shared/utils';import { ApplicationService } from 'src/engine/core-modules/application/application.service';import { I18nService } from 'src/engine/core-modules/i18n/i18n.service';-import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';+import { generateMessageId } from 'twenty-shared/i18n';import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';import { findFlatEntityByIdInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps-or-throw.util';import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps.util';diff --git a/packages/twenty-server/test/integration/graphql/suites/workspace/custom-application-translation.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/workspace/custom-application-translation.integration-spec.tsindex 5d19ef8d2d2..494880a8425 100644--- a/packages/twenty-server/test/integration/graphql/suites/workspace/custom-application-translation.integration-spec.ts+++ b/packages/twenty-server/test/integration/graphql/suites/workspace/custom-application-translation.integration-spec.ts@@ -12,7 +12,7 @@ import { jestExpectToBeDefined } from 'test/utils/jest-expect-to-be-defined.utilimport { SOURCE_LOCALE } from 'twenty-shared/translations';import { isDefined } from 'twenty-shared/utils';-import { generateMessageId } from 'src/engine/core-modules/i18n/utils/generateMessageId';+import { generateMessageId } from 'twenty-shared/i18n';const client = request(`http://localhost:${APP_PORT}`);diff --git a/packages/twenty-shared/src/i18n/__tests__/generate-message-id.spec.ts b/packages/twenty-shared/src/i18n/__tests__/generate-message-id.spec.tsnew file mode 100644index 00000000000..114b0dd00ee--- /dev/null+++ b/packages/twenty-shared/src/i18n/__tests__/generate-message-id.spec.ts@@ -0,0 +1,30 @@+import { generateMessageId } from '@/i18n/generate-message-id';++// These ids are not arbitrary: each pair below was lifted from the+// `js-lingui-id` comments in twenty-server's committed en.po, so this suite+// asserts our implementation still agrees with what the Lingui CLI actually+// emits. If it goes red, every persisted metadata label has silently stopped+// resolving against its catalog.+describe('generateMessageId', () => {+ it.each([+ ['A company', 'kZR6+h'],+ ['12HRS', '0eYXBl'],+ ['{fieldType} fields cannot be unique.', 'ZkHTHm'],+ ])('matches the Lingui-generated id for %p', (message, expectedId) => {+ expect(generateMessageId(message)).toBe(expectedId);+ });++ it('returns a six-character id', () => {+ expect(generateMessageId('Export View')).toHaveLength(6);+ });++ it('treats an omitted context and an empty context as the same message', () => {+ expect(generateMessageId('Export')).toBe(generateMessageId('Export', ''));+ });++ it('distinguishes the same message under different contexts', () => {+ expect(generateMessageId('Export', 'commandMenuItem.shortLabel')).not.toBe(+ generateMessageId('Export', 'view.name'),+ );+ });+});diff --git a/packages/twenty-shared/src/i18n/generate-message-id.ts b/packages/twenty-shared/src/i18n/generate-message-id.tsnew file mode 100644index 00000000000..3f5f6e21361--- /dev/null+++ b/packages/twenty-shared/src/i18n/generate-message-id.ts@@ -0,0 +1,20 @@+import { createHash } from 'node:crypto';++// Lingui's generated-id scheme. Catalogs are emitted with `printLinguiId: true`,+// so a source string persisted in metadata can be hashed back into its catalog+// key at read time.+//+// The server and the application SDK must produce byte-identical ids: the SDK+// writes app catalogs keyed by this hash at build time and the server reads them+// at request time. Drift between the two silently untranslates every installed+// application, which is why this lives here rather than in either package.+//+// This pulls `node:crypto`, so `twenty-shared/i18n` is a Node-only subpath.+// Nothing in twenty-front imports it.+const UNIT_SEPARATOR = String.fromCharCode(0x1f);++export const generateMessageId = (message: string, context = ''): string =>+ createHash('sha256')+ .update(message + UNIT_SEPARATOR + (context || ''))+ .digest('base64')+ .slice(0, 6);diff --git a/packages/twenty-shared/src/i18n/index.ts b/packages/twenty-shared/src/i18n/index.tsindex dba39688367..a364e6b1d3d 100644--- a/packages/twenty-shared/src/i18n/index.ts+++ b/packages/twenty-shared/src/i18n/index.ts@@ -9,3 +9,9 @@export type { LocaleMessagesMap } from './create-i18n-instance-factory';export { createI18nInstanceFactory } from './create-i18n-instance-factory';+export { generateMessageId } from './generate-message-id';+export type {+ TranslatableMetadataName,+ TranslatablePropertyName,+} from './translatable-properties-by-metadata-name';+export { TRANSLATABLE_PROPERTIES_BY_METADATA_NAME } from './translatable-properties-by-metadata-name';diff --git a/packages/twenty-shared/src/i18n/translatable-properties-by-metadata-name.ts b/packages/twenty-shared/src/i18n/translatable-properties-by-metadata-name.tsnew file mode 100644index 00000000000..e7da8eaf2b1--- /dev/null+++ b/packages/twenty-shared/src/i18n/translatable-properties-by-metadata-name.ts@@ -0,0 +1,26 @@+import { type AllMetadataName } from '@/metadata/types/all-metadata-name.type';++// The single source of truth for which provider-owned metadata properties are+// translatable. twenty-server resolves them against a catalog at request time+// and derives MetadataEntityTranslatablePropertyName from this list; twenty-sdk+// extracts them out of an application manifest at build time.+//+// The two used to keep separate lists and drifted: a property missing from one+// side is a string that is either extracted and never read, or read and never+// extracted, and both failure modes are silent.+export const TRANSLATABLE_PROPERTIES_BY_METADATA_NAME = {+ objectMetadata: ['labelSingular', 'labelPlural', 'description'],+ fieldMetadata: ['label', 'description'],+ view: ['name'],+ viewFieldGroup: ['name'],+ pageLayoutTab: ['title'],+ pageLayoutWidget: ['title'],+ commandMenuItem: ['label', 'shortLabel'],+ navigationMenuItem: ['name'],+} as const satisfies Partial<Record<AllMetadataName, readonly string[]>>;++export type TranslatableMetadataName =+ keyof typeof TRANSLATABLE_PROPERTIES_BY_METADATA_NAME;++export type TranslatablePropertyName<T extends TranslatableMetadataName> =+ (typeof TRANSLATABLE_PROPERTIES_BY_METADATA_NAME)[T][number];diff --git a/packages/twenty-shared/vite.config.ts b/packages/twenty-shared/vite.config.tsindex 61af2f2bc0f..d7daf0fc0ef 100644--- a/packages/twenty-shared/vite.config.ts+++ b/packages/twenty-shared/vite.config.ts@@ -49,6 +49,10 @@ export default defineConfig(() => {external: [...Object.keys((packageJson as any).dependencies || {}),'typescript',+ // `twenty-shared/i18n` hashes message ids with node:crypto. Keep the+ // builtin external so rollup emits a plain import instead of trying+ // to bundle or polyfill it.+ 'node:crypto',],output: [{