Skip to content

The open alternative to Salesforce, designed for AI.

feat: raise FILES field max number of values from 10 to 60 (#20950)

Félix Malfaitac89d2ff565a
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/__tests__/validate-files-flat-field-metadata.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/__tests__/validate-files-flat-field-metadata.util.spec.ts
index fb88af2116b..686857a44af 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/__tests__/validate-files-flat-field-metadata.util.spec.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/__tests__/validate-files-flat-field-metadata.util.spec.ts
@@ -57,7 +57,7 @@ describe('validateFilesFlatFieldMetadata', () => {
[
{
"code": "INVALID_FIELD_INPUT",
- "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
]
`);
@@ -74,16 +74,16 @@ describe('validateFilesFlatFieldMetadata', () => {
[
{
"code": "INVALID_FIELD_INPUT",
- "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
]
`);
});
- it('should return error when maxNumberOfValues exceeds max (11)', () => {
+ it('should return error when maxNumberOfValues exceeds max (61)', () => {
const errors = callValidator(
createFlatEntityToValidate({
- universalSettings: { maxNumberOfValues: 11 },
+ universalSettings: { maxNumberOfValues: 61 },
}),
);
@@ -91,7 +91,7 @@ describe('validateFilesFlatFieldMetadata', () => {
[
{
"code": "INVALID_FIELD_INPUT",
- "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
]
`);
diff --git a/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/__snapshots__/create-one-files-field-metadata.integration-spec.ts.snap b/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/__snapshots__/create-one-files-field-metadata.integration-spec.ts.snap
index 1ea50279f4e..a9cc83a3202 100644
--- a/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/__snapshots__/create-one-files-field-metadata.integration-spec.ts.snap
+++ b/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/__snapshots__/create-one-files-field-metadata.integration-spec.ts.snap
@@ -66,8 +66,8 @@ exports[`createOne FILES field metadata - failing should fail to create files fi
"errors": [
{
"code": "INVALID_FIELD_INPUT",
- "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
],
"flatEntityMinimalInformation": {
@@ -86,14 +86,14 @@ exports[`createOne FILES field metadata - failing should fail to create files fi
"fieldMetadata": 1,
"totalErrors": 1,
},
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
"message": "Multiple validation errors occurred while creating fields",
"name": "GraphQLError",
}
`;
-exports[`createOne FILES field metadata - failing should fail to create files field with maxNumberOfValues = 11 (exceeds max) 1`] = `
+exports[`createOne FILES field metadata - failing should fail to create files field with maxNumberOfValues = 61 (exceeds max) 1`] = `
{
"extensions": {
"code": "METADATA_VALIDATION_FAILED",
@@ -103,8 +103,8 @@ exports[`createOne FILES field metadata - failing should fail to create files fi
"errors": [
{
"code": "INVALID_FIELD_INPUT",
- "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
],
"flatEntityMinimalInformation": {
@@ -123,7 +123,7 @@ exports[`createOne FILES field metadata - failing should fail to create files fi
"fieldMetadata": 1,
"totalErrors": 1,
},
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
"message": "Multiple validation errors occurred while creating fields",
"name": "GraphQLError",
@@ -140,8 +140,8 @@ exports[`createOne FILES field metadata - failing should fail to create files fi
"errors": [
{
"code": "INVALID_FIELD_INPUT",
- "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
],
"flatEntityMinimalInformation": {
@@ -160,7 +160,7 @@ exports[`createOne FILES field metadata - failing should fail to create files fi
"fieldMetadata": 1,
"totalErrors": 1,
},
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
"message": "Multiple validation errors occurred while creating fields",
"name": "GraphQLError",
diff --git a/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/__snapshots__/update-one-files-field-metadata.integration-spec.ts.snap b/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/__snapshots__/update-one-files-field-metadata.integration-spec.ts.snap
index fa00aba4d0a..af113f14346 100644
--- a/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/__snapshots__/update-one-files-field-metadata.integration-spec.ts.snap
+++ b/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/__snapshots__/update-one-files-field-metadata.integration-spec.ts.snap
@@ -10,8 +10,8 @@ exports[`updateOne FILES field metadata - failing should fail to update files fi
"errors": [
{
"code": "INVALID_FIELD_INPUT",
- "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
],
"flatEntityMinimalInformation": {
@@ -30,14 +30,14 @@ exports[`updateOne FILES field metadata - failing should fail to update files fi
"fieldMetadata": 1,
"totalErrors": 1,
},
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
"message": "Multiple validation errors occurred while updating field",
"name": "GraphQLError",
}
`;
-exports[`updateOne FILES field metadata - failing should fail to update files field settings with maxNumberOfValues = 11 (exceeds max) 1`] = `
+exports[`updateOne FILES field metadata - failing should fail to update files field settings with maxNumberOfValues = 61 (exceeds max) 1`] = `
{
"extensions": {
"code": "METADATA_VALIDATION_FAILED",
@@ -47,8 +47,8 @@ exports[`updateOne FILES field metadata - failing should fail to update files fi
"errors": [
{
"code": "INVALID_FIELD_INPUT",
- "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "message": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
],
"flatEntityMinimalInformation": {
@@ -67,7 +67,7 @@ exports[`updateOne FILES field metadata - failing should fail to update files fi
"fieldMetadata": 1,
"totalErrors": 1,
},
- "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 10",
+ "userFriendlyMessage": "maxNumberOfValues must be defined in settings and be a number greater than 0 and less than or equal to 60",
},
"message": "Multiple validation errors occurred while updating field",
"name": "GraphQLError",
diff --git a/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/create-one-files-field-metadata.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/create-one-files-field-metadata.integration-spec.ts
index 25334577603..98b8e1f156d 100644
--- a/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/create-one-files-field-metadata.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/create-one-files-field-metadata.integration-spec.ts
@@ -90,15 +90,15 @@ describe('createOne FILES field metadata - successful', () => {
expect(data.createOneField.settings).toEqual({ maxNumberOfValues: 5 });
});
- it('should create files field with maxNumberOfValues = 10 (max allowed)', async () => {
+ it('should create files field with maxNumberOfValues = 60 (max allowed)', async () => {
const { data, errors } = await createOneFieldMetadata({
expectToFail: false,
input: {
objectMetadataId: createdObjectMetadataId,
- name: 'filesFieldTen',
- label: 'Files Field Ten',
+ name: 'filesFieldSixty',
+ label: 'Files Field Sixty',
type: FieldMetadataType.FILES,
- settings: { maxNumberOfValues: 10 },
+ settings: { maxNumberOfValues: 60 },
},
gqlFields: `
id
@@ -113,7 +113,7 @@ describe('createOne FILES field metadata - successful', () => {
expect(data).not.toBeNull();
expect(data.createOneField).toBeDefined();
expect(data.createOneField.type).toBe(FieldMetadataType.FILES);
- expect(data.createOneField.settings).toEqual({ maxNumberOfValues: 10 });
+ expect(data.createOneField.settings).toEqual({ maxNumberOfValues: 60 });
});
});
@@ -165,7 +165,7 @@ describe('createOne FILES field metadata - failing', () => {
expectOneNotInternalServerErrorSnapshot({ errors });
});
- it('should fail to create files field with maxNumberOfValues = 11 (exceeds max)', async () => {
+ it('should fail to create files field with maxNumberOfValues = 61 (exceeds max)', async () => {
const { errors } = await createOneFieldMetadata({
expectToFail: true,
input: {
@@ -173,7 +173,7 @@ describe('createOne FILES field metadata - failing', () => {
name: 'filesFieldExceeds',
label: 'Files Field Exceeds',
type: FieldMetadataType.FILES,
- settings: { maxNumberOfValues: 11 },
+ settings: { maxNumberOfValues: 61 },
},
});
diff --git a/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/update-one-files-field-metadata.integration-spec.ts b/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/update-one-files-field-metadata.integration-spec.ts
index cfb0fe3fa69..a35e8c7f559 100644
--- a/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/update-one-files-field-metadata.integration-spec.ts
+++ b/packages/twenty-server/test/integration/metadata/suites/field-metadata/atomic/update-one-files-field-metadata.integration-spec.ts
@@ -214,13 +214,13 @@ describe('updateOne FILES field metadata - failing', () => {
expectOneNotInternalServerErrorSnapshot({ errors });
});
- it('should fail to update files field settings with maxNumberOfValues = 11 (exceeds max)', async () => {
+ it('should fail to update files field settings with maxNumberOfValues = 61 (exceeds max)', async () => {
const { errors } = await updateOneFieldMetadata({
expectToFail: true,
input: {
idToUpdate: createdFieldMetadataId,
updatePayload: {
- settings: { maxNumberOfValues: 11 },
+ settings: { maxNumberOfValues: 61 },
},
},
});
diff --git a/packages/twenty-shared/src/constants/FilesFieldMaxNumberOfValues.ts b/packages/twenty-shared/src/constants/FilesFieldMaxNumberOfValues.ts
index 9111b9f7c70..b02acbfff3c 100644
--- a/packages/twenty-shared/src/constants/FilesFieldMaxNumberOfValues.ts
+++ b/packages/twenty-shared/src/constants/FilesFieldMaxNumberOfValues.ts
@@ -1 +1 @@
-export const FILES_FIELD_MAX_NUMBER_OF_VALUES = 10;
+export const FILES_FIELD_MAX_NUMBER_OF_VALUES = 60;