Skip to content

The open alternative to Salesforce, designed for AI.

Show the junction toggle for custom junction objects (#29570)

Charles Bochetae84c97463cf
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/__tests__/isJunctionLikeObject.test.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/__tests__/isJunctionLikeObject.test.ts
new file mode 100644
index 00000000000..a95de8e4626
--- /dev/null
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/__tests__/isJunctionLikeObject.test.ts
@@ -0,0 +1,82 @@
+import { type FieldMetadataItemRelation } from '@/object-metadata/types/FieldMetadataItemRelation';
+import { isJunctionLikeObject } from '@/object-record/record-field/ui/utils/junction/isJunctionLikeObject';
+import { RelationType } from '~/generated-metadata/graphql';
+
+const buildRelation = (type: RelationType): FieldMetadataItemRelation => ({
+ type,
+ sourceFieldMetadata: { id: 'source-field-id', name: 'source' },
+ targetFieldMetadata: { id: 'target-field-id', name: 'target' },
+ sourceObjectMetadata: {
+ id: 'source-object-id',
+ nameSingular: 'source',
+ namePlural: 'sources',
+ },
+ targetObjectMetadata: {
+ id: 'target-object-id',
+ nameSingular: 'target',
+ namePlural: 'targets',
+ },
+});
+
+const scalarField = {
+ isSystem: false,
+ isSystemSideEffect: false,
+ relation: null,
+ morphRelations: null,
+};
+
+const manyToOneField = {
+ ...scalarField,
+ relation: buildRelation(RelationType.MANY_TO_ONE),
+};
+
+const oneToManyField = {
+ ...scalarField,
+ relation: buildRelation(RelationType.ONE_TO_MANY),
+};
+
+describe('isJunctionLikeObject', () => {
+ it('accepts an object whose relations are all many-to-one', () => {
+ expect(
+ isJunctionLikeObject([scalarField, manyToOneField, manyToOneField]),
+ ).toBe(true);
+ });
+
+ it('rejects an object with a user-defined one-to-many relation', () => {
+ expect(isJunctionLikeObject([manyToOneField, oneToManyField])).toBe(false);
+ });
+
+ it('rejects an object with a one-to-many morph relation', () => {
+ expect(
+ isJunctionLikeObject([
+ manyToOneField,
+ {
+ ...scalarField,
+ morphRelations: [
+ buildRelation(RelationType.MANY_TO_ONE),
+ buildRelation(RelationType.ONE_TO_MANY),
+ ],
+ },
+ ]),
+ ).toBe(false);
+ });
+
+ it('ignores the default one-to-many relations the engine adds to custom objects', () => {
+ expect(
+ isJunctionLikeObject([
+ manyToOneField,
+ manyToOneField,
+ { ...oneToManyField, isSystemSideEffect: true },
+ ]),
+ ).toBe(true);
+ });
+
+ it('ignores system fields', () => {
+ expect(
+ isJunctionLikeObject([
+ manyToOneField,
+ { ...oneToManyField, isSystem: true },
+ ]),
+ ).toBe(true);
+ });
+});
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/isJunctionLikeObject.ts b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/isJunctionLikeObject.ts
new file mode 100644
index 00000000000..dfbb6d3eac2
--- /dev/null
+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/utils/junction/isJunctionLikeObject.ts
@@ -0,0 +1,18 @@
+import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
+import { getFieldRelations } from '@/object-record/record-field/ui/utils/junction/getFieldRelations';
+import { RelationType } from '~/generated-metadata/graphql';
+
+export const isJunctionLikeObject = (
+ fields: Pick<
+ FieldMetadataItem,
+ 'isSystem' | 'isSystemSideEffect' | 'relation' | 'morphRelations'
+ >[],
+) =>
+ fields.every(
+ (field) =>
+ field.isSystem ||
+ field.isSystemSideEffect ||
+ getFieldRelations(field).every(
+ ({ type }) => type === RelationType.MANY_TO_ONE,
+ ),
+ );
diff --git a/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx b/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx
index 7156b35198e..8ac58082970 100644
--- a/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx
+++ b/packages/twenty-front/src/modules/settings/data-model/fields/forms/morph-relation/components/SettingsDataModelFieldRelationJunctionForm.tsx
@@ -8,7 +8,7 @@ import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadata
import { useObjectMetadataItems } from '@/object-metadata/hooks/useObjectMetadataItems';
import { useFieldMetadataItemById } from '@/object-metadata/hooks/useFieldMetadataItemById';
import { findFieldMetadataItemByFieldMetadataId } from '@/object-metadata/utils/findFieldMetadataItemByFieldMetadataId';
-import { getFieldRelations } from '@/object-record/record-field/ui/utils/junction/getFieldRelations';
+import { isJunctionLikeObject } from '@/object-record/record-field/ui/utils/junction/isJunctionLikeObject';
import { isValidJunctionTargetField } from '@/object-record/record-field/ui/utils/junction/isValidJunctionTargetField';
import { SettingsOptionCardContentSelect } from '@/settings/components/SettingsOptions/SettingsOptionCardContentSelect';
import { SettingsOptionCardContentSwitch } from '@/settings/components/SettingsOptions/SettingsOptionCardContentSwitch';
@@ -109,17 +109,10 @@ export const SettingsDataModelFieldRelationJunctionForm = ({
({ value }) => value === selectedJunctionTargetFieldId,
);
- const isJunctionLikeObject = junctionObjectMetadataItem.fields.every(
- (field) =>
- field.isSystem === true ||
- getFieldRelations(field).every(
- ({ type }) => type === RelationType.MANY_TO_ONE,
- ),
- );
-
if (
!isJunctionConfigEnabled &&
- (junctionFieldOptions.length === 0 || !isJunctionLikeObject)
+ (junctionFieldOptions.length === 0 ||
+ !isJunctionLikeObject(junctionObjectMetadataItem.fields))
) {
return null;
}