The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Skip istanbul and cache the Vite optimizer in Storybook test runs (#28307)
Raphaël Bosib10da8dc0809
diff --git a/.github/workflows/ci-front-storybook-test.yaml b/.github/workflows/ci-front-storybook-test.yamlindex 158403d5bf6..823d632f957 100644--- a/.github/workflows/ci-front-storybook-test.yaml+++ b/.github/workflows/ci-front-storybook-test.yaml@@ -41,6 +41,11 @@ jobs:key: ${{ env.STORYBOOK_BUILD_CACHE_KEY_FOR_RESTORE_ACTION }}- name: Clean stale storybook vitest cacherun: rm -rf packages/twenty-front/node_modules/.cache/storybook+ - name: Cache storybook vitest dependency optimizer+ uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0+ with:+ path: packages/twenty-front/node_modules/.cache/storybook+ key: v4-storybook-vitest-deps-twenty-front-${{ inputs.scope }}-${{ hashFiles('yarn.lock', 'packages/twenty-front/vite.config.ts', 'packages/twenty-front/vitest.config.ts', 'packages/twenty-front/.storybook/main.ts') }}- name: Build dependenciesrun: |npx nx build twenty-shareddiff --git a/.github/workflows/ci-ui.yaml b/.github/workflows/ci-ui.yamlindex 7ee0f55b99d..25d0ea66285 100644--- a/.github/workflows/ci-ui.yaml+++ b/.github/workflows/ci-ui.yaml@@ -89,6 +89,13 @@ jobs:uses: ./.github/actions/yarn-install- name: Build dependenciesrun: npx nx build twenty-shared+ - name: Cache storybook vitest dependency optimizer+ uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0+ with:+ path: |+ packages/twenty-ui/node_modules/.cache/storybook+ packages/twenty-ui/node_modules/.vite+ key: v4-storybook-vitest-deps-twenty-ui-${{ hashFiles('yarn.lock', 'packages/twenty-ui/vite.config.ts', 'packages/twenty-ui/vitest.config.ts', 'packages/twenty-ui/.storybook/main.ts') }}- name: Resolve Playwright versionid: playwright-versionrun: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> "$GITHUB_OUTPUT"diff --git a/knip.json b/knip.jsonindex 16290f0d346..0041d3b993f 100644--- a/knip.json+++ b/knip.json@@ -72,6 +72,7 @@"ignore": ["src/locales/generated/**", ".eloqnt/config.ts"],"ignoreDependencies": ["@babel/preset-typescript",+ "@storybook/addon-coverage","buffer","emojibase-data","esbuild",@@ -86,7 +87,7 @@"packages/twenty-ui": {"entry": ["scripts/**/*.ts", "docs/**/*.ts"],"ignore": ["src/styles/abstracts/**"],- "ignoreDependencies": ["@swc/core"]+ "ignoreDependencies": ["@storybook/addon-coverage", "@swc/core"]}}}diff --git a/nx.json b/nx.jsonindex 4d4e0095204..b6712d1ac18 100644--- a/nx.json+++ b/nx.json@@ -193,7 +193,7 @@"outputs": ["{projectRoot}/coverage/storybook"],"options": {"cwd": "{projectRoot}",- "command": "vitest run --coverage --shard={args.shard}",+ "command": "STORYBOOK_COVERAGE=true vitest run --coverage --shard={args.shard}","shard": "1/1"}},diff --git a/packages/twenty-front-component-renderer/vitest.storybook.config.ts b/packages/twenty-front-component-renderer/vitest.storybook.config.tsindex a8f83444ccc..a8d90164bae 100644--- a/packages/twenty-front-component-renderer/vitest.storybook.config.ts+++ b/packages/twenty-front-component-renderer/vitest.storybook.config.ts@@ -38,7 +38,8 @@ export default defineConfig({plugins: [storybookTest({configDir: path.join(dirname, '.storybook'),- storybookScript: 'yarn storybook --no-open --port 6008',+ storybookScript: 'npx storybook dev -p 6008 --no-open',+ storybookUrl: 'http://localhost:6008',}),],test: {diff --git a/packages/twenty-front/.storybook/main.ts b/packages/twenty-front/.storybook/main.tsindex de451ed57c4..7c9f1bcc934 100644--- a/packages/twenty-front/.storybook/main.ts+++ b/packages/twenty-front/.storybook/main.ts@@ -28,6 +28,8 @@ const computeStoriesGlob = () => {return ['../src/**/*.docs.mdx', '../src/**/*.stories.@(js|jsx|ts|tsx)'];};+const isCoverageEnabled = process.env.STORYBOOK_COVERAGE === 'true';+const config: StorybookConfig = {stories: computeStoriesGlob(),@@ -43,7 +45,7 @@ const config: StorybookConfig = {addons: ['@storybook-community/storybook-addon-cookie','@storybook/addon-links',- '@storybook/addon-coverage',+ ...(isCoverageEnabled ? ['@storybook/addon-coverage'] : []),'storybook-addon-pseudo-states','storybook-addon-mock-date','@storybook/addon-vitest',diff --git a/packages/twenty-front/vitest.config.ts b/packages/twenty-front/vitest.config.tsindex 302f62b355c..45d0c675f4a 100644--- a/packages/twenty-front/vitest.config.ts+++ b/packages/twenty-front/vitest.config.ts@@ -31,7 +31,7 @@ export default defineConfig({configDir: path.join(dirname, '.storybook'),...(process.env.STORYBOOK_URL? { storybookUrl: process.env.STORYBOOK_URL }- : { storybookScript: 'yarn storybook --no-open' }),+ : { storybookScript: 'npx storybook dev -p 6006 --no-open' }),}),...(shouldCaptureArgosScreenshots? [diff --git a/packages/twenty-ui/.storybook/main.ts b/packages/twenty-ui/.storybook/main.tsindex e40e91920fa..0cf07dfc14f 100644--- a/packages/twenty-ui/.storybook/main.ts+++ b/packages/twenty-ui/.storybook/main.ts@@ -9,7 +9,7 @@ const dirname =: path.dirname(fileURLToPath(import.meta.url));const isVitest = Boolean(process.env.VITEST);-const isDocumentationBuild = process.env.STORYBOOK_DOCS === 'true';+const isCoverageEnabled = process.env.STORYBOOK_COVERAGE === 'true';const config: StorybookConfig = {stories: ['../src/**/*.@(mdx|stories.@(js|jsx|ts|tsx))'],@@ -17,7 +17,7 @@ const config: StorybookConfig = {addons: ['@storybook-community/storybook-addon-cookie','@storybook/addon-links',- ...(isDocumentationBuild ? [] : ['@storybook/addon-coverage']),+ ...(isCoverageEnabled ? ['@storybook/addon-coverage'] : []),'@storybook/addon-a11y','storybook-addon-pseudo-states','@storybook/addon-vitest',diff --git a/packages/twenty-ui/project.json b/packages/twenty-ui/project.jsonindex 77903f37ce5..6ff6e2e0aee 100644--- a/packages/twenty-ui/project.json+++ b/packages/twenty-ui/project.json@@ -164,7 +164,7 @@"configurations": {"test": {},"docs": {- "command": "STORYBOOK_DOCS=true NODE_OPTIONS='--max-old-space-size=10240' storybook build --disable-telemetry"+ "command": "NODE_OPTIONS='--max-old-space-size=10240' storybook build --disable-telemetry"}}},@@ -183,7 +183,7 @@},"storybook:test": {"options": {- "command": "vitest run --coverage --shard={args.shard} --project storybook --project reduced-motion"+ "command": "STORYBOOK_COVERAGE=true vitest run --coverage --shard={args.shard} --project storybook --project reduced-motion"}},"storybook:test:no-coverage": {diff --git a/packages/twenty-ui/vitest.config.ts b/packages/twenty-ui/vitest.config.tsindex df082b32a5c..2c7e9daec4f 100644--- a/packages/twenty-ui/vitest.config.ts+++ b/packages/twenty-ui/vitest.config.ts@@ -53,7 +53,10 @@ export default defineConfig({configDir: path.join(dirname, '.storybook'),...(process.env.STORYBOOK_URL? { storybookUrl: process.env.STORYBOOK_URL }- : { storybookScript: 'yarn storybook --no-open --port 6008' }),+ : {+ storybookScript: 'npx storybook dev -p 6008 --no-open',+ storybookUrl: 'http://localhost:6008',+ }),}),argosVitestPlugin({uploadToArgos: !!process.env.ARGOS_TOKEN,