Skip to content

The open alternative to Salesforce, designed for AI.

feat(workflow): remove the See Active Version command menu item from workspaces (#25938)

Thomas Trompetteb304b7e78e24
diff --git a/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts b/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts
index 4ab854c36bb..c34384269ff 100644
--- a/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts
+++ b/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts
@@ -579,28 +579,6 @@ export const mockedCommandMenuItems: CommandMenuItemFieldsFragment[] =
"shortLabel": "Test",
"navigationTargetObjectMetadataId": null
},
- {
- "__typename": "CommandMenuItem",
- "id": "4f3a8f2d-ad8c-4c29-8306-0bdc22eac6b9",
- "applicationId": "0be210aa-685b-4c31-9a2a-010b44eacaf5",
- "workflowVersionId": null,
- "frontComponentId": null,
- "engineComponentKey": "SEE_ACTIVE_VERSION_WORKFLOW",
- "position": 27,
- "isPinned": false,
- "payload": null,
- "hotKeys": null,
- "conditionalAvailabilityExpression": "includesEvery(selectedRecords, \"statuses\", \"ACTIVE\") and includesEvery(selectedRecords, \"statuses\", \"DRAFT\") and noneDefined(selectedRecords, \"deletedAt\")",
- "availabilityType": "RECORD_SELECTION",
- "availabilityObjectMetadataId": "7fa7fa3c-2efd-4689-9048-559222d3b80d",
- "pageLayoutId": null,
- "isActive": true,
- "frontComponent": null,
- "label": "See Active Version",
- "icon": "IconVersions",
- "shortLabel": "See Active Version",
- "navigationTargetObjectMetadataId": null
- },
{
"__typename": "CommandMenuItem",
"id": "adecf949-bbbd-4fb5-a8d2-fb6f7cb78770",
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-upgrade-version-command.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-upgrade-version-command.module.ts
index 042723176f5..2ebc541bd43 100644
--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-upgrade-version-command.module.ts
+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-upgrade-version-command.module.ts
@@ -9,6 +9,7 @@ import { MakeStandardChildObjectsInheritedCommand } from 'src/database/commands/
import { BackfillTimelineActivityMessageCampaignIndexesCommand } from 'src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789461462000-backfill-timeline-activity-message-campaign-indexes.command';
import { MakeNotesAndTasksInheritTheirTargetsCommand } from 'src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789373200002-make-notes-and-tasks-inherit-their-targets.command';
import { MoveMessageCampaignCommandsToCampaignFlagCommand } from 'src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789468244000-move-message-campaign-commands-to-campaign-flag.command';
+import { RemoveSeeActiveVersionCommandMenuItemCommand } from 'src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789470915878-remove-see-active-version-command-menu-item.command';
import { ApplicationModule } from 'src/engine/core-modules/application/application.module';
import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
import { WorkspaceSchemaManagerModule } from 'src/engine/twenty-orm/workspace-schema-manager/workspace-schema-manager.module';
@@ -34,6 +35,7 @@ import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspace
MakeNotesAndTasksInheritTheirTargetsCommand,
BackfillTimelineActivityMessageCampaignIndexesCommand,
MoveMessageCampaignCommandsToCampaignFlagCommand,
+ RemoveSeeActiveVersionCommandMenuItemCommand,
],
})
export class V2_41_UpgradeVersionCommandModule {}
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789470915878-remove-see-active-version-command-menu-item.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789470915878-remove-see-active-version-command-menu-item.command.ts
new file mode 100644
index 00000000000..536deccb814
--- /dev/null
+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-41/2-41-workspace-command-1789470915878-remove-see-active-version-command-menu-item.command.ts
@@ -0,0 +1,114 @@
+import { Command } from 'nest-commander';
+
+import { isDefined } from 'twenty-shared/utils';
+
+import { ProvisionedWorkspaceCommandRunner } from 'src/database/commands/command-runners/provisioned-workspace.command-runner';
+import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';
+import { type RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspace.command-runner';
+import { ApplicationService } from 'src/engine/core-modules/application/application.service';
+import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';
+import { EngineComponentKey } from 'src/engine/metadata-modules/command-menu-item/enums/engine-component-key.enum';
+import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';
+import { findFlatEntityByUniversalIdentifier } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-universal-identifier.util';
+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
+import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';
+
+const SEE_ACTIVE_VERSION_WORKFLOW_UNIVERSAL_IDENTIFIER =
+ '31790508-75ff-4e4c-a768-83bd1b0718e0';
+
+@RegisteredWorkspaceCommand('2.41.0', 1789470915878)
+@Command({
+ name: 'upgrade:2-41:remove-see-active-version-command-menu-item',
+ description:
+ 'Remove the See Active Version workflow command menu item from existing workspaces',
+})
+export class RemoveSeeActiveVersionCommandMenuItemCommand extends ProvisionedWorkspaceCommandRunner {
+ constructor(
+ protected readonly workspaceIteratorService: WorkspaceIteratorService,
+ private readonly applicationService: ApplicationService,
+ private readonly workspaceMigrationValidateBuildAndRunService: WorkspaceMigrationValidateBuildAndRunService,
+ private readonly workspaceCacheService: WorkspaceCacheService,
+ ) {
+ super(workspaceIteratorService);
+ }
+
+ override async runOnWorkspace({
+ workspaceId,
+ options,
+ }: RunOnWorkspaceArgs): Promise<void> {
+ const isDryRun = options.dryRun ?? false;
+
+ const { flatCommandMenuItemMaps } =
+ await this.workspaceCacheService.getOrRecompute(workspaceId, [
+ 'flatCommandMenuItemMaps',
+ ]);
+
+ const itemToDelete = findFlatEntityByUniversalIdentifier<FlatCommandMenuItem>(
+ {
+ flatEntityMaps: flatCommandMenuItemMaps,
+ universalIdentifier: SEE_ACTIVE_VERSION_WORKFLOW_UNIVERSAL_IDENTIFIER,
+ },
+ );
+
+ if (!isDefined(itemToDelete)) {
+ this.logger.log(
+ `See Active Version command menu item does not exist for workspace ${workspaceId}, skipping`,
+ );
+
+ return;
+ }
+
+ if (
+ itemToDelete.engineComponentKey !==
+ EngineComponentKey.SEE_ACTIVE_VERSION_WORKFLOW
+ ) {
+ throw new Error(
+ `Command menu item ${SEE_ACTIVE_VERSION_WORKFLOW_UNIVERSAL_IDENTIFIER} in workspace ${workspaceId} carries engine component key ${itemToDelete.engineComponentKey}, refusing to delete`,
+ );
+ }
+
+ this.logger.log(
+ `${isDryRun ? '[DRY RUN] ' : ''}Removing the See Active Version command menu item for workspace ${workspaceId}`,
+ );
+
+ if (isDryRun) {
+ return;
+ }
+
+ const { twentyStandardFlatApplication } =
+ await this.applicationService.findWorkspaceTwentyStandardAndCustomApplicationOrThrow(
+ { workspaceId },
+ );
+
+ const validateAndBuildResult =
+ await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(
+ {
+ isSystemBuild: true,
+ applicationUniversalIdentifier:
+ twentyStandardFlatApplication.universalIdentifier,
+ workspaceId,
+ allFlatEntityOperationByMetadataName: {
+ commandMenuItem: {
+ flatEntityToCreate: [],
+ flatEntityToDelete: [itemToDelete],
+ flatEntityToUpdate: [],
+ },
+ },
+ },
+ );
+
+ if (validateAndBuildResult.status === 'fail') {
+ throw new Error(
+ `Failed to remove the See Active Version command menu item for workspace ${workspaceId}: ${JSON.stringify(
+ validateAndBuildResult,
+ null,
+ 2,
+ )}`,
+ );
+ }
+
+ this.logger.log(
+ `Removed the See Active Version command menu item for workspace ${workspaceId}`,
+ );
+ }
+}
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts
index db43298567c..4700abea6ed 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts
@@ -544,29 +544,6 @@ export const STANDARD_COMMAND_MENU_ITEMS = {
engineComponentKey: EngineComponentKey.TEST_WORKFLOW,
hotKeys: null,
},
- seeActiveVersionWorkflow: {
- universalIdentifier: '31790508-75ff-4e4c-a768-83bd1b0718e0',
- label: i18nLabel(
- msg({ message: `See Active Version`, context: 'commandMenuItem.label' }),
- ),
- icon: 'IconVersions',
- isPinned: false,
- position: 27,
- shortLabel: i18nLabel(
- msg({
- message: `See Active Version`,
- context: 'commandMenuItem.shortLabel',
- }),
- ),
- availabilityType: CommandMenuItemAvailabilityType.RECORD_SELECTION,
- conditionalAvailabilityExpression:
- 'includesEvery(selectedRecords, "statuses", "ACTIVE") and includesEvery(selectedRecords, "statuses", "DRAFT") and noneDefined(selectedRecords, "deletedAt")',
- availabilityObjectMetadataUniversalIdentifier:
- STANDARD_OBJECTS.workflow.universalIdentifier,
- frontComponentUniversalIdentifier: null,
- engineComponentKey: EngineComponentKey.SEE_ACTIVE_VERSION_WORKFLOW,
- hotKeys: null,
- },
seeRunsWorkflow: {
universalIdentifier: 'e57efc2d-00a2-493a-b76c-f2dabd23a5eb',
label: i18nLabel(