Skip to content

The open alternative to Salesforce, designed for AI.

refactor: share floating reference scale calculation (#25762)

Thomas des Francsb3adebbe9162
diff --git a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellEditMode.tsx b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellEditMode.tsx
index 1953bb05ef8..536d3209073 100644
--- a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellEditMode.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellEditMode.tsx
@@ -1,3 +1,4 @@
+import { getFloatingReferenceScale } from '@/ui/layout/overlay/utils/getFloatingReferenceScale';
import { RecordFieldComponentInstanceContext } from '@/object-record/record-field/ui/states/contexts/RecordFieldComponentInstanceContext';
import { recordFieldInputIsFieldInErrorComponentState } from '@/object-record/record-field/ui/states/recordFieldInputIsFieldInErrorComponentState';
import { recordFieldInputLayoutDirectionComponentState } from '@/object-record/record-field/ui/states/recordFieldInputLayoutDirectionComponentState';
@@ -74,11 +75,8 @@ export const RecordInlineCellEditMode = ({
strategy: 'fixed',
middleware: [
flip(),
- offset(({ rects, elements }) => {
- const referenceScale =
- elements.reference instanceof HTMLElement
- ? rects.reference.width / elements.reference.offsetWidth
- : 1;
+ offset((state) => {
+ const referenceScale = getFloatingReferenceScale(state);
return {
mainAxis: (isCentered ? -26 : -29) * referenceScale,
diff --git a/packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellEditMode.tsx b/packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellEditMode.tsx
index 5cef6d7eee9..6f25774cc54 100644
--- a/packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellEditMode.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellEditMode.tsx
@@ -1,3 +1,4 @@
+import { getFloatingReferenceScale } from '@/ui/layout/overlay/utils/getFloatingReferenceScale';
import { useIsFieldInputOnly } from '@/object-record/record-field/ui/hooks/useIsFieldInputOnly';
import { RecordFieldComponentInstanceContext } from '@/object-record/record-field/ui/states/contexts/RecordFieldComponentInstanceContext';
import { recordFieldInputIsFieldInErrorComponentState } from '@/object-record/record-field/ui/states/recordFieldInputIsFieldInErrorComponentState';
@@ -80,11 +81,8 @@ export const RecordTableCellEditMode = ({
strategy: 'fixed',
middleware: [
flip(),
- offset(({ rects, elements }) => {
- const referenceScale =
- elements.reference instanceof HTMLElement
- ? rects.reference.width / elements.reference.offsetWidth
- : 1;
+ offset((state) => {
+ const referenceScale = getFloatingReferenceScale(state);
return {
mainAxis: -33 * referenceScale,
diff --git a/packages/twenty-front/src/modules/ui/layout/overlay/utils/getFloatingReferenceScale.ts b/packages/twenty-front/src/modules/ui/layout/overlay/utils/getFloatingReferenceScale.ts
new file mode 100644
index 00000000000..e23054f1093
--- /dev/null
+++ b/packages/twenty-front/src/modules/ui/layout/overlay/utils/getFloatingReferenceScale.ts
@@ -0,0 +1,9 @@
+import { type MiddlewareState } from '@floating-ui/react';
+
+export const getFloatingReferenceScale = ({
+ rects,
+ elements,
+}: Pick<MiddlewareState, 'rects' | 'elements'>) =>
+ elements.reference instanceof HTMLElement
+ ? rects.reference.width / elements.reference.offsetWidth
+ : 1;