The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix: remove add record on workflow runs/versions (#18448)
Charles Bochetb421efbff73c
diff --git a/packages/twenty-front/src/modules/object-record/record-table/components/RecordTableNoRecordGroupAddNew.tsx b/packages/twenty-front/src/modules/object-record/record-table/components/RecordTableNoRecordGroupAddNew.tsxindex d342dfe7b75..189458073fe 100644--- a/packages/twenty-front/src/modules/object-record/record-table/components/RecordTableNoRecordGroupAddNew.tsx+++ b/packages/twenty-front/src/modules/object-record/record-table/components/RecordTableNoRecordGroupAddNew.tsx@@ -4,6 +4,7 @@ import { useUpsertRecordsInStore } from '@/object-record/record-store/hooks/useUimport { useRecordTableContextOrThrow } from '@/object-record/record-table/contexts/RecordTableContext';import { useCreateNewIndexRecord } from '@/object-record/record-table/hooks/useCreateNewIndexRecord';import { RecordTableActionRow } from '@/object-record/record-table/record-table-row/components/RecordTableActionRow';+import { isRecordTableCreateDisabled } from '@/object-record/record-table/utils/isRecordTableCreateDisabled';import { useLoadRecordsToVirtualRows } from '@/object-record/record-table/virtualization/hooks/useLoadRecordsToVirtualRows';import { totalNumberOfRecordsToVirtualizeComponentState } from '@/object-record/record-table/virtualization/states/totalNumberOfRecordsToVirtualizeComponentState';import { useAtomComponentSelectorValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentSelectorValue';@@ -65,6 +66,10 @@ export const RecordTableNoRecordGroupAddNew = () => {return null;}+ if (isRecordTableCreateDisabled(objectMetadataItem.nameSingular)) {+ return null;+ }+return (<RecordTableActionRowonClick={handleButtonClick}diff --git a/packages/twenty-front/src/modules/object-record/record-table/empty-state/components/RecordTableEmptyStateDisplay.tsx b/packages/twenty-front/src/modules/object-record/record-table/empty-state/components/RecordTableEmptyStateDisplay.tsxindex f9d114b8408..e477d94917a 100644--- a/packages/twenty-front/src/modules/object-record/record-table/empty-state/components/RecordTableEmptyStateDisplay.tsx+++ b/packages/twenty-front/src/modules/object-record/record-table/empty-state/components/RecordTableEmptyStateDisplay.tsx@@ -2,6 +2,7 @@ import { useObjectPermissionsForObject } from '@/object-record/hooks/useObjectPeimport { isObjectMetadataReadOnly } from '@/object-record/read-only/utils/isObjectMetadataReadOnly';import { hasAnySoftDeleteFilterOnViewComponentSelector } from '@/object-record/record-filter/states/hasAnySoftDeleteFilterOnView';import { useRecordTableContextOrThrow } from '@/object-record/record-table/contexts/RecordTableContext';+import { isRecordTableCreateDisabled } from '@/object-record/record-table/utils/isRecordTableCreateDisabled';import { useScrollWrapperHTMLElement } from '@/ui/utilities/scroll/hooks/useScrollWrapperHTMLElement';import { useAtomComponentSelectorValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentSelectorValue';import { styled } from '@linaria/react';@@ -17,6 +18,9 @@ import {} from 'twenty-ui/layout';const StyledEmptyPlaceholderOuterContainer = styled.div`+ height: 100%;+ width: 100%;+> * {align-items: flex-start;}@@ -77,7 +81,8 @@ export const RecordTableEmptyStateDisplay = ({'buttonComponent' in props && props.buttonComponent}{'buttonTitle' in props &&!isReadOnly &&- !hasAnySoftDeleteFilterOnView && (+ !hasAnySoftDeleteFilterOnView &&+ !isRecordTableCreateDisabled(objectMetadataItem.nameSingular) && (<ButtonIcon={props.ButtonIcon}title={props.buttonTitle}diff --git a/packages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableHeaderLabelIdentifierCellPlusButton.tsx b/packages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableHeaderLabelIdentifierCellPlusButton.tsxindex e1454fb952d..a8f7f8decb5 100644--- a/packages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableHeaderLabelIdentifierCellPlusButton.tsx+++ b/packages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableHeaderLabelIdentifierCellPlusButton.tsx@@ -2,6 +2,7 @@ import { isObjectMetadataReadOnly } from '@/object-record/read-only/utils/isObjeimport { hasAnySoftDeleteFilterOnViewComponentSelector } from '@/object-record/record-filter/states/hasAnySoftDeleteFilterOnView';import { useRecordTableContextOrThrow } from '@/object-record/record-table/contexts/RecordTableContext';import { useCreateNewIndexRecord } from '@/object-record/record-table/hooks/useCreateNewIndexRecord';+import { isRecordTableCreateDisabled } from '@/object-record/record-table/utils/isRecordTableCreateDisabled';import { useAtomComponentSelectorValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentSelectorValue';import { styled } from '@linaria/react';import { IconPlus } from 'twenty-ui/display';@@ -45,7 +46,8 @@ export const RecordTableHeaderLabelIdentifierCellPlusButton = () => {!isMobile &&!isReadOnly &&hasObjectUpdatePermissions &&- !hasAnySoftDeleteFilterOnView && (+ !hasAnySoftDeleteFilterOnView &&+ !isRecordTableCreateDisabled(objectMetadataItem.nameSingular) && (<StyledHeaderIcon><LightIconButtonIcon={IconPlus}diff --git a/packages/twenty-front/src/modules/object-record/record-table/record-table-section/components/RecordTableRecordGroupSectionAddNew.tsx b/packages/twenty-front/src/modules/object-record/record-table/record-table-section/components/RecordTableRecordGroupSectionAddNew.tsxindex fd1f78ed771..4e76bab0c22 100644--- a/packages/twenty-front/src/modules/object-record/record-table/record-table-section/components/RecordTableRecordGroupSectionAddNew.tsx+++ b/packages/twenty-front/src/modules/object-record/record-table/record-table-section/components/RecordTableRecordGroupSectionAddNew.tsx@@ -5,6 +5,7 @@ import { recordIndexGroupFieldMetadataItemComponentState } from '@/object-recordimport { useRecordTableContextOrThrow } from '@/object-record/record-table/contexts/RecordTableContext';import { useCreateNewIndexRecord } from '@/object-record/record-table/hooks/useCreateNewIndexRecord';import { RecordTableActionRow } from '@/object-record/record-table/record-table-row/components/RecordTableActionRow';+import { isRecordTableCreateDisabled } from '@/object-record/record-table/utils/isRecordTableCreateDisabled';import { useAtomFamilyStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomFamilyStateValue';import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';import { t } from '@lingui/core/macro';@@ -42,6 +43,10 @@ export const RecordTableRecordGroupSectionAddNew = () => {return null;}+ if (isRecordTableCreateDisabled(objectMetadataItem.nameSingular)) {+ return null;+ }+return (<RecordTableActionRowLeftIcon={IconPlus}diff --git a/packages/twenty-front/src/modules/object-record/record-table/utils/isRecordTableCreateDisabled.ts b/packages/twenty-front/src/modules/object-record/record-table/utils/isRecordTableCreateDisabled.tsnew file mode 100644index 00000000000..5726ad9d9c1--- /dev/null+++ b/packages/twenty-front/src/modules/object-record/record-table/utils/isRecordTableCreateDisabled.ts@@ -0,0 +1,14 @@+import { CoreObjectNameSingular } from 'twenty-shared/types';++const OBJECTS_WITHOUT_MANUAL_RECORD_CREATION: readonly CoreObjectNameSingular[] =+ [CoreObjectNameSingular.WorkflowRun, CoreObjectNameSingular.WorkflowVersion];++export const isRecordTableCreateDisabled = (+ objectNameSingular: string,+): boolean => {+ const isDisabled = OBJECTS_WITHOUT_MANUAL_RECORD_CREATION.includes(+ objectNameSingular as CoreObjectNameSingular,+ );++ return isDisabled;+};