The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix(front): render +N button for right-edge-clipped chips in expandable list (#22748)
Thomas Trompetteb682162f31a9
diff --git a/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/display/components/MultiSelectFieldDisplay.tsx b/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/display/components/MultiSelectFieldDisplay.tsxindex a0aeff5c084..aeebb5ad87f 100644--- a/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/display/components/MultiSelectFieldDisplay.tsx+++ b/packages/twenty-front/src/modules/object-record/record-field/ui/meta-types/display/components/MultiSelectFieldDisplay.tsx@@ -1,6 +1,5 @@import { useFieldFocus } from '@/object-record/record-field/ui/hooks/useFieldFocus';import { useMultiSelectFieldDisplay } from '@/object-record/record-field/ui/meta-types/hooks/useMultiSelectFieldDisplay';-import { MultiSelectDisplay } from '@/ui/field/display/components/MultiSelectDisplay';import { ExpandableList } from '@/ui/layout/expandable-list/components/ExpandableList';import { Tag } from 'twenty-ui/data-display';import { isDefined } from 'twenty-shared/utils';@@ -18,7 +17,7 @@ export const MultiSelectFieldDisplay = () => {if (!isDefined(selectedOptions)) return null;- return isFocused ? (+ return (<ExpandableList isChipCountDisplayed={isFocused}>{selectedOptions.map((selectedOption, index) => (<Tag@@ -28,10 +27,5 @@ export const MultiSelectFieldDisplay = () => {/>))}</ExpandableList>- ) : (- <MultiSelectDisplay- values={fieldValue}- options={fieldDefinition.metadata.options}- />);};diff --git a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellAnchoredPortal.tsx b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellAnchoredPortal.tsxindex 659e6fd08cb..7cc01cc8edd 100644--- a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellAnchoredPortal.tsx+++ b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellAnchoredPortal.tsx@@ -10,7 +10,7 @@ import {type RecordUpdateHook,type RecordUpdateHookParams,} from '@/object-record/record-field/ui/contexts/FieldContext';-import { FieldFocusContextProvider } from '@/object-record/record-field/ui/contexts/FieldFocusContextProvider';+import { FieldFocusStaticFocusedProvider } from '@/object-record/record-field/ui/contexts/FieldFocusContextProvider';import { RecordFieldComponentInstanceContext } from '@/object-record/record-field/ui/states/contexts/RecordFieldComponentInstanceContext';import { isJunctionRelationForbidden } from '@/object-record/record-field/ui/utils/junction/isJunctionRelationForbidden';import { RecordInlineCellAnchoredPortalContext } from '@/object-record/record-inline-cell/components/RecordInlineCellAnchoredPortalContext';@@ -90,7 +90,7 @@ export const RecordInlineCellAnchoredPortal = ({}return (- <FieldFocusContextProvider isFocused={true}>+ <FieldFocusStaticFocusedProvider><FieldContext.Providerkey={recordId + fieldMetadataItem.id}value={{@@ -128,6 +128,6 @@ export const RecordInlineCellAnchoredPortal = ({)}</></FieldContext.Provider>- </FieldFocusContextProvider>+ </FieldFocusStaticFocusedProvider>);};diff --git a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellHoveredPortalContent.tsx b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellHoveredPortalContent.tsxindex eae8e62fecd..f2b687b8d97 100644--- a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellHoveredPortalContent.tsx+++ b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellHoveredPortalContent.tsx@@ -17,6 +17,7 @@ const StyledRecordTableCellHoveredPortalContent = styled.div<{const StyledInlineCellBaseContainer = styled.div<{ readonly: boolean }>`align-items: center;+ background: ${themeCssVariables.background.primary};box-sizing: border-box;display: flex;gap: ${themeCssVariables.spacing[1]};diff --git a/packages/twenty-front/src/modules/ui/layout/expandable-list/utils/isFirstOverflowingChildElement.ts b/packages/twenty-front/src/modules/ui/layout/expandable-list/utils/isFirstOverflowingChildElement.tsindex a942a700de9..089c407a1e7 100644--- a/packages/twenty-front/src/modules/ui/layout/expandable-list/utils/isFirstOverflowingChildElement.ts+++ b/packages/twenty-front/src/modules/ui/layout/expandable-list/utils/isFirstOverflowingChildElement.ts@@ -11,6 +11,7 @@ export const isFirstOverflowingChildElement = ({// First element is always displayed.isDefined(childElement.previousElementSibling) &&containerElement.scrollWidth > containerElement.clientWidth &&- childElement.offsetLeft > containerElement.clientWidth &&+ childElement.offsetLeft + childElement.offsetWidth >+ containerElement.clientWidth &&(childElement.previousElementSibling as HTMLElement).offsetLeft <containerElement.clientWidth;