The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Record-level sharing 4/5: All records permission and ownership transfer (#27058)
Félix Malfaitb9290c323de0
diff --git a/packages/twenty-docs/developers/extend/apps/data/objects.mdx b/packages/twenty-docs/developers/extend/apps/data/objects.mdxindex 06fd087c33e..55a2ef3ef63 100644--- a/packages/twenty-docs/developers/extend/apps/data/objects.mdx+++ b/packages/twenty-docs/developers/extend/apps/data/objects.mdx@@ -89,7 +89,7 @@ export default defineObject({- A parent grants access under its complete policy, the one a query of the parent applies: the reader's permission on the parent object, the row-level restrictions of their role and the parent's own readability. A record never shows through a parent its reader could not query. Subscriptions, webhooks, workflows and logic functions decide what an event of an `INHERITED` record reaches by that same policy.- The share rows on the record itself grant access exactly as on a `PRIVATE` record. Its creator gets one when the record is created while record sharing is enabled, so whoever created a record keeps seeing it, and a record whose parent fields are all empty is visible to those it was shared with directly.- An `INHERITED` object that names no usable parent field behaves like a `PRIVATE` one.-- `sharingReach` sets how far a record of the object can be shared by name: `ObjectSharingReach.WORKSPACE` (the default, a record can be shared with anyone in the workspace, even someone whose role cannot access the object or whose row-level filter hides the record; they get that record only, to view or edit) or `ObjectSharingReach.ROLE_ACCESS` (shares never go beyond role and row-level permissions). Pick `ROLE_ACCESS` for sensitive objects where no access must mean no access. It only applies while record sharing is enabled in the workspace, and only to objects whose records can be shared: `MetadataReadability.OPEN`, `PRIVATE` and `INHERITED` objects that are not system objects. `APPLICATION` and `SYSTEM` objects are never shared.+- `sharingReach` sets how far a record of the object can be shared by name: `ObjectSharingReach.WORKSPACE` (the default, a record can be shared with anyone in the workspace, even someone whose role cannot access the object or whose row-level filter hides the record; they get that record only, to view or edit) or `ObjectSharingReach.ROLE_ACCESS` (shares never go beyond role and row-level permissions). Pick `ROLE_ACCESS` for sensitive objects where no access must mean no access. Roles that can update all settings see every record of an `OPEN` object whatever its sharing restrictions; their object permissions and row-level filters still apply. It only applies while record sharing is enabled in the workspace, and only to objects whose records can be shared: `MetadataReadability.OPEN`, `PRIVATE` and `INHERITED` objects that are not system objects. `APPLICATION` and `SYSTEM` objects are never shared.- `color` sets the accent color of the object in the UI. Omit it and Twenty picks one for the object.- `imageIdentifierFieldMetadataUniversalIdentifier` names the field whose value is shown as the record avatar. Omit it to let Twenty pick the default.- `isLabelSyncedWithName`, on an object or on a field, keeps the API name in sync with the label when the label is edited in Settings. It defaults to `false`, so a renamed label leaves the name untouched.diff --git a/packages/twenty-front/src/modules/side-panel/pages/share-record/components/SidePanelShareRecordContent.tsx b/packages/twenty-front/src/modules/side-panel/pages/share-record/components/SidePanelShareRecordContent.tsxindex bacd68b61bc..f5f55ac2d8e 100644--- a/packages/twenty-front/src/modules/side-panel/pages/share-record/components/SidePanelShareRecordContent.tsx+++ b/packages/twenty-front/src/modules/side-panel/pages/share-record/components/SidePanelShareRecordContent.tsx@@ -242,7 +242,11 @@ export const SidePanelShareRecordContent = ({</StyledDescription></>) : (- <StyledDescription>{t`Only the creator of this record and people with full access to it can change who has access.`}</StyledDescription>+ <StyledDescription>+ {sharing.isOpenByDefault+ ? t`Only the creator of this record, people with full access to it and admins can change who has access.`+ : t`Only the creator of this record and people with full access to it can change who has access.`}+ </StyledDescription>)))}</SidePanelList>diff --git a/packages/twenty-front/src/modules/side-panel/pages/share-record/components/__tests__/SidePanelShareRecordContent.test.tsx b/packages/twenty-front/src/modules/side-panel/pages/share-record/components/__tests__/SidePanelShareRecordContent.test.tsxindex 65c359ca815..7600a42df18 100644--- a/packages/twenty-front/src/modules/side-panel/pages/share-record/components/__tests__/SidePanelShareRecordContent.test.tsx+++ b/packages/twenty-front/src/modules/side-panel/pages/share-record/components/__tests__/SidePanelShareRecordContent.test.tsx@@ -418,6 +418,24 @@ describe('Share record side panel', () => {},);+ it('tells viewers of a record open by default who can change its access', async () => {+ renderSharing({+ sharing: {+ ...sharing,+ isOpenByDefault: true,+ viewerAccessLevel: RecordShareAccessLevel.READ,+ roles: [],+ },+ });+ await waitFor(() =>+ expect(+ screen.getByText(+ 'Only the creator of this record, people with full access to it and admins can change who has access.',+ ),+ ).toBeVisible(),+ );+ });+it('marks the default access of a record open by default and lets owners restrict it', async () => {const user = userEvent.setup();renderSharing({diff --git a/packages/twenty-server/src/database/commands/agent-history/__tests__/agent-history-migration.postgres.spec.ts b/packages/twenty-server/src/database/commands/agent-history/__tests__/agent-history-migration.postgres.spec.tsindex c0c5f511631..01c9946c81c 100644--- a/packages/twenty-server/src/database/commands/agent-history/__tests__/agent-history-migration.postgres.spec.ts+++ b/packages/twenty-server/src/database/commands/agent-history/__tests__/agent-history-migration.postgres.spec.ts@@ -117,6 +117,7 @@ const SCHEMA = getWorkspaceSchemaName(WORKSPACE_ID);billingEntitlements: {},userWorkspaceRoleMap: {},apiKeyRoleMap: {},+ roleIdsWithAllRecordsAccess: [],eventEmitterService: { emitDatabaseBatchEvent },recordStock: {assertRecordStockAvailable: jest.fn().mockResolvedValue(undefined),diff --git a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/database-event/__tests__/call-database-event-trigger-jobs.job.spec.ts b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/database-event/__tests__/call-database-event-trigger-jobs.job.spec.tsindex 671c9660d77..72f0bf74b9e 100644--- a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/database-event/__tests__/call-database-event-trigger-jobs.job.spec.ts+++ b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/database-event/__tests__/call-database-event-trigger-jobs.job.spec.ts@@ -173,6 +173,7 @@ describe('CallDatabaseEventTriggerJobsJob', () => {idByUniversalIdentifier: {},},rolesPermissions: buildRolesPermissions(),+ roleIdsWithAllRecordsAccess: [],flatRowLevelPermissionPredicateMaps: createEmptyFlatEntityMaps(),flatRowLevelPermissionPredicateGroupMaps: createEmptyFlatEntityMaps(),flatFieldMetadataMaps,diff --git a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/database-event/call-database-event-trigger-jobs.job.ts b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/database-event/call-database-event-trigger-jobs.job.tsindex 97ba3558b7d..34c731e0d0d 100644--- a/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/database-event/call-database-event-trigger-jobs.job.ts+++ b/packages/twenty-server/src/engine/core-modules/logic-function/logic-function-trigger/triggers/database-event/call-database-event-trigger-jobs.job.ts@@ -50,6 +50,7 @@ export class CallDatabaseEventTriggerJobsJob {flatLogicFunctionMaps,flatApplicationMaps,rolesPermissions,+ roleIdsWithAllRecordsAccess,flatRowLevelPermissionPredicateMaps,flatRowLevelPermissionPredicateGroupMaps,flatFieldMetadataMaps,@@ -59,6 +60,7 @@ export class CallDatabaseEventTriggerJobsJob {'flatLogicFunctionMaps','flatApplicationMaps','rolesPermissions',+ 'roleIdsWithAllRecordsAccess','flatRowLevelPermissionPredicateMaps','flatRowLevelPermissionPredicateGroupMaps','flatFieldMetadataMaps',@@ -129,6 +131,7 @@ export class CallDatabaseEventTriggerJobsJob {roleId: applicationRoleId,owningApplicationId: application.id,rolesPermissions,+ roleIdsWithAllRecordsAccess,flatRowLevelPermissionPredicateMaps,flatRowLevelPermissionPredicateGroupMaps,flatFieldMetadataMaps,diff --git a/packages/twenty-server/src/engine/core-modules/record-share/constants/everyone-row-access-policy-subject.constant.ts b/packages/twenty-server/src/engine/core-modules/record-share/constants/everyone-row-access-policy-subject.constant.tsindex b609482fb90..31dd2bc3998 100644--- a/packages/twenty-server/src/engine/core-modules/record-share/constants/everyone-row-access-policy-subject.constant.ts+++ b/packages/twenty-server/src/engine/core-modules/record-share/constants/everyone-row-access-policy-subject.constant.ts@@ -8,6 +8,7 @@ export const EVERYONE_ROW_ACCESS_POLICY_SUBJECT: RowAccessPolicySubject = {isSystemContext: false,objectsPermissions: undefined,principalIds: [EVERYONE_PRINCIPAL_ID],+ canAccessAllRecords: false,isOwningApplication: () => false,resolveRowLevelPermissionRecordFilter: () => null,};diff --git a/packages/twenty-server/src/engine/core-modules/record-share/record-share-ownership-transfer.module.ts b/packages/twenty-server/src/engine/core-modules/record-share/record-share-ownership-transfer.module.tsnew file mode 100644index 00000000000..4beb43d1efd--- /dev/null+++ b/packages/twenty-server/src/engine/core-modules/record-share/record-share-ownership-transfer.module.ts@@ -0,0 +1,13 @@+import { Module } from '@nestjs/common';++import { RecordShareStorageModule } from 'src/engine/core-modules/record-share/record-share-storage.module';+import { RecordShareOwnershipTransferService } from 'src/engine/core-modules/record-share/services/record-share-ownership-transfer.service';+import { UserRoleModule } from 'src/engine/metadata-modules/user-role/user-role.module';+import { WorkspaceCacheModule } from 'src/engine/workspace-cache/workspace-cache.module';++@Module({+ imports: [RecordShareStorageModule, UserRoleModule, WorkspaceCacheModule],+ providers: [RecordShareOwnershipTransferService],+ exports: [RecordShareOwnershipTransferService],+})+export class RecordShareOwnershipTransferModule {}diff --git a/packages/twenty-server/src/engine/core-modules/record-share/services/record-access-policy.service.ts b/packages/twenty-server/src/engine/core-modules/record-share/services/record-access-policy.service.tsindex d56740a51e6..c28efcc1198 100644--- a/packages/twenty-server/src/engine/core-modules/record-share/services/record-access-policy.service.ts+++ b/packages/twenty-server/src/engine/core-modules/record-share/services/record-access-policy.service.ts@@ -22,7 +22,7 @@ import { resolveNamedPrincipalIds } from 'src/engine/core-modules/record-share/uimport { resolveRecordIdsRestrictedForPrincipals } from 'src/engine/core-modules/record-share/utils/resolve-record-ids-restricted-for-principals.util';import { resolveRecordIdsSharedWithPrincipals } from 'src/engine/core-modules/record-share/utils/resolve-record-ids-shared-with-principals.util';import { isRecordGrantBeyondRoleAllowed } from 'src/engine/core-modules/record-share/utils/is-record-grant-beyond-role-allowed.util';-import { isRecordShareExceptionObject } from 'src/engine/core-modules/record-share/utils/is-record-share-exception-object.util';+import { shouldEnforceRecordShareExceptions } from 'src/engine/core-modules/record-share/utils/should-enforce-record-share-exceptions.util';import { resolveRecordShareGateKind } from 'src/engine/core-modules/record-share/utils/resolve-record-share-gate-kind.util';import { MAX_INHERITED_READABILITY_DEPTH } from 'src/engine/core-modules/record-share/constants/max-inherited-readability-depth.constant';import { resolveRequiredRecordShareAccessLevels } from 'src/engine/core-modules/record-share/utils/resolve-required-record-share-access-levels.util';@@ -265,11 +265,13 @@ export class RecordAccessPolicyService {private async areRecordShareExceptionsEnforced({workspaceId,objectMetadata,+ subject,}: SnapshotEvaluation): Promise<boolean> {- return (- isRecordShareExceptionObject(objectMetadata) &&- (await this.isRecordSharingEnabled(workspaceId))- );+ return shouldEnforceRecordShareExceptions({+ flatObjectMetadata: objectMetadata,+ isRecordSharingEnabled: await this.isRecordSharingEnabled(workspaceId),+ canAccessAllRecords: subject.canAccessAllRecords,+ });}private async resolveSnapshotIdsNotRestrictedForSubject(diff --git a/packages/twenty-server/src/engine/core-modules/record-share/services/record-share-ownership-transfer.service.ts b/packages/twenty-server/src/engine/core-modules/record-share/services/record-share-ownership-transfer.service.tsnew file mode 100644index 00000000000..7bf8b9e856f--- /dev/null+++ b/packages/twenty-server/src/engine/core-modules/record-share/services/record-share-ownership-transfer.service.ts@@ -0,0 +1,105 @@+/* @license Enterprise */++import { Injectable } from '@nestjs/common';++import { isDefined } from 'twenty-shared/utils';++import { isRecordShareExceptionObject } from 'src/engine/core-modules/record-share/utils/is-record-share-exception-object.util';+import { RecordShareStorageService } from 'src/engine/core-modules/record-share/services/record-share-storage.service';+import { type UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';+import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';++@Injectable()+export class RecordShareOwnershipTransferService {+ constructor(+ private readonly userRoleService: UserRoleService,+ private readonly recordShareStorageService: RecordShareStorageService,+ private readonly workspaceCacheService: WorkspaceCacheService,+ ) {}++ // Records a departing member could manage would otherwise only stay+ // manageable through roles with access to all records. Every path that+ // removes a member from a workspace that stays active must call this.+ async transferRecordSharesToCustodian({+ removedUserWorkspace,+ removedWorkspaceMemberId,+ actingUserWorkspaceId,+ }: {+ removedUserWorkspace: UserWorkspaceEntity;+ removedWorkspaceMemberId: string;+ actingUserWorkspaceId?: string;+ }): Promise<void> {+ const { workspaceId } = removedUserWorkspace;+ const objectMetadataIds =+ await this.findTransferableObjectMetadataIds(workspaceId);++ if (objectMetadataIds.length === 0) {+ return;+ }++ const toWorkspaceMemberId = await this.resolveCustodianWorkspaceMemberId({+ removedUserWorkspace,+ actingUserWorkspaceId,+ });++ await this.recordShareStorageService.transferMemberGrants({+ workspaceId,+ objectMetadataIds,+ fromWorkspaceMemberId: removedWorkspaceMemberId,+ toWorkspaceMemberId,+ });+ }++ // Only records that access to all records already reaches change hands:+ // private objects such as chats and workflow runs stay with their creator+ private async findTransferableObjectMetadataIds(+ workspaceId: string,+ ): Promise<string[]> {+ const { flatObjectMetadataMaps } =+ await this.workspaceCacheService.getOrRecompute(workspaceId, [+ 'flatObjectMetadataMaps',+ ]);++ return Object.values(flatObjectMetadataMaps.byUniversalIdentifier)+ .filter(isDefined)+ .filter(isRecordShareExceptionObject)+ .map((flatObjectMetadata) => flatObjectMetadata.id);+ }++ private async resolveCustodianWorkspaceMemberId({+ removedUserWorkspace,+ actingUserWorkspaceId,+ }: {+ removedUserWorkspace: UserWorkspaceEntity;+ actingUserWorkspaceId?: string;+ }): Promise<string | undefined> {+ const custodianUserWorkspace =+ await this.userRoleService.resolveCustodianUserWorkspace({+ removedUserWorkspace,+ actingUserWorkspaceId,+ });++ if (!isDefined(custodianUserWorkspace)) {+ return undefined;+ }++ const { flatWorkspaceMemberMaps } =+ await this.workspaceCacheService.getOrRecompute(+ removedUserWorkspace.workspaceId,+ ['flatWorkspaceMemberMaps'],+ );++ // The cache keeps soft-deleted members, so idByUserId may point at one+ const custodianWorkspaceMember = Object.values(+ flatWorkspaceMemberMaps.byId,+ ).find(+ (workspaceMember) =>+ isDefined(workspaceMember) &&+ workspaceMember.userId === custodianUserWorkspace.userId &&+ !isDefined(workspaceMember.deletedAt),+ );++ return custodianWorkspaceMember?.id;+ }+}diff --git a/packages/twenty-server/src/engine/core-modules/record-share/services/record-share-storage.service.ts b/packages/twenty-server/src/engine/core-modules/record-share/services/record-share-storage.service.tsindex 503c8d76325..449592d1992 100644--- a/packages/twenty-server/src/engine/core-modules/record-share/services/record-share-storage.service.ts+++ b/packages/twenty-server/src/engine/core-modules/record-share/services/record-share-storage.service.ts@@ -4,9 +4,16 @@ import { getWorkspaceSchemaName } from 'src/engine/workspace-datasource/utils/geimport { escapeIdentifier } from 'src/engine/workspace-manager/workspace-migration/utils/remove-sql-injection.util';import { Injectable } from '@nestjs/common';+import chunk from 'lodash.chunk';++import { QUERY_MAX_RECORDS } from 'twenty-shared/constants';import { isDefined } from 'twenty-shared/utils';-import { In, type EntityManager, type FindOptionsWhere } from 'typeorm';-import { RecordShareRowCause } from 'twenty-shared/types';+import { In, Not, type EntityManager, type FindOptionsWhere } from 'typeorm';+import {+ RecordShareAccessLevel,+ RecordSharePrincipalType,+ RecordShareRowCause,+} from 'twenty-shared/types';import {RecordShareException,@@ -151,6 +158,104 @@ export class RecordShareStorageService {);}+ // Without a custodian the departing member's grants are only dropped+ async transferMemberGrants({+ workspaceId,+ objectMetadataIds,+ fromWorkspaceMemberId,+ toWorkspaceMemberId,+ }: {+ workspaceId: string;+ objectMetadataIds: string[];+ fromWorkspaceMemberId: string;+ toWorkspaceMemberId: string | undefined;+ }): Promise<void> {+ const transferableRowCauses = In([+ RecordShareRowCause.OWNER,+ RecordShareRowCause.MANUAL,+ ]);++ await this.workspaceOrmManager.executeInWorkspaceContext(+ () =>+ this.workspaceOrmManager.runInWorkspaceTransaction((transactionScope) =>+ this.withRepository(+ { workspaceId, transactionScope },+ async (repository) => {+ const fromMember = {+ objectMetadataId: In(objectMetadataIds),+ principalType: RecordSharePrincipalType.WORKSPACE_MEMBER,+ principalId: fromWorkspaceMemberId,+ rowCause: transferableRowCauses,+ };++ if (isDefined(toWorkspaceMemberId)) {+ const fullGrants = await repository.find({+ where: {+ ...fromMember,+ accessLevel: RecordShareAccessLevel.FULL,+ },+ });+ const fullGrantKeys = new Set(+ fullGrants.map(buildRecordShareRowKey),+ );++ for (const fullGrantsChunk of chunk(+ fullGrants,+ QUERY_MAX_RECORDS,+ )) {+ await repository.insert(+ fullGrantsChunk.map((grant) => ({+ objectMetadataId: grant.objectMetadataId,+ recordId: grant.recordId,+ principalType: grant.principalType,+ principalId: toWorkspaceMemberId,+ accessLevel: grant.accessLevel,+ rowCause: grant.rowCause,+ sourceId: grant.sourceId,+ })),+ { onConflictDoNothing: true },+ );++ // The insert skips the rows the custodian already holds on+ // these records, which are raised to full access instead+ const custodianGrantIdsToRaise = (+ await repository.find({+ where: {+ principalType:+ RecordSharePrincipalType.WORKSPACE_MEMBER,+ principalId: toWorkspaceMemberId,+ recordId: In(+ fullGrantsChunk.map(+ (fullGrant) => fullGrant.recordId,+ ),+ ),+ rowCause: transferableRowCauses,+ accessLevel: Not(RecordShareAccessLevel.FULL),+ },+ })+ )+ .filter((grant) =>+ fullGrantKeys.has(buildRecordShareRowKey(grant)),+ )+ .map((grant) => grant.id);++ if (custodianGrantIdsToRaise.length > 0) {+ await repository.update(+ { id: In(custodianGrantIdsToRaise) },+ { accessLevel: RecordShareAccessLevel.FULL },+ );+ }+ }+ }++ await repository.delete(fromMember);+ },+ ),+ ),+ buildSystemAuthContext(workspaceId),+ );+ }+async findByRecordIds({workspaceId,objectMetadataId,@@ -215,3 +320,8 @@ export class RecordShareStorageService {);}}++const buildRecordShareRowKey = (+ recordShare: Pick<RecordShare, 'objectMetadataId' | 'recordId' | 'rowCause'>,+) =>+ `${recordShare.objectMetadataId}:${recordShare.recordId}:${recordShare.rowCause}`;diff --git a/packages/twenty-server/src/engine/core-modules/record-share/services/record-sharing.service.ts b/packages/twenty-server/src/engine/core-modules/record-share/services/record-sharing.service.tsindex 2aa843bc11d..cd22142c122 100644--- a/packages/twenty-server/src/engine/core-modules/record-share/services/record-sharing.service.ts+++ b/packages/twenty-server/src/engine/core-modules/record-share/services/record-sharing.service.ts@@ -34,6 +34,7 @@ import { type RecordShareInput } from 'src/engine/core-modules/record-share/typeimport { type RecordShare } from 'src/engine/core-modules/record-share/types/record-share.type';import { isRecordGrantBeyondRoleAllowed } from 'src/engine/core-modules/record-share/utils/is-record-grant-beyond-role-allowed.util';import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';+import { canRolesAccessAllRecords } from 'src/engine/core-modules/record-share/utils/can-roles-access-all-records.util';import { isRecordShareExceptionObject } from 'src/engine/core-modules/record-share/utils/is-record-share-exception-object.util';import { isRecordShareableObject } from 'src/engine/core-modules/record-share/utils/is-record-shareable-object.util';import { resolveRecordGeneralAccess } from 'src/engine/core-modules/record-share/utils/resolve-record-general-access.util';@@ -46,6 +47,7 @@ import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-objectimport { type OperationType } from 'src/engine/twenty-orm/repository/permissions.utils';import { type WorkspaceTransactionScope } from 'src/engine/twenty-orm/types/workspace-transaction-scope.type';import { buildSystemAuthContext } from 'src/engine/twenty-orm/utils/build-system-auth-context.util';+import { resolveRoleIdsFromAuthContext } from 'src/engine/twenty-orm/utils/resolve-role-ids-from-auth-context.util';import { resolvePrincipalIdsFromAuthContext } from 'src/engine/twenty-orm/utils/resolve-principal-ids-from-auth-context.util';import { WorkspaceOrmManager } from 'src/engine/twenty-orm/workspace-orm.manager';import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';@@ -420,17 +422,18 @@ export class RecordSharingService {transactionScope?: WorkspaceTransactionScope;}) {const workspaceId = authContext.workspace.id;- const { userWorkspaceRoleMap, apiKeyRoleMap } =+ const { userWorkspaceRoleMap, apiKeyRoleMap, roleIdsWithAllRecordsAccess } =await this.workspaceCacheService.getOrRecompute(workspaceId, ['userWorkspaceRoleMap','apiKeyRoleMap',+ 'roleIdsWithAllRecordsAccess',]);- const principalIds =- resolvePrincipalIdsFromAuthContext({- authContext,- userWorkspaceRoleMap,- apiKeyRoleMap,- }) ?? [];+ const roleMaps = { authContext, userWorkspaceRoleMap, apiKeyRoleMap };+ const principalIds = resolvePrincipalIdsFromAuthContext(roleMaps) ?? [];+ const canAccessAllRecords = canRolesAccessAllRecords({+ roleIds: resolveRoleIdsFromAuthContext(roleMaps),+ roleIdsWithAllRecordsAccess,+ });const shares = await this.recordShareStorageService.findByRecordIds({workspaceId,objectMetadataId,@@ -455,7 +458,8 @@ export class RecordSharingService {implicitAccessLevels: sharingObject.isRecordShareExceptionObject? [generalAccess.accessLevel,- creatorWorkspaceMemberId === authContext.workspaceMemberId+ creatorWorkspaceMemberId === authContext.workspaceMemberId ||+ canAccessAllRecords? RecordShareAccessLevel.FULL: null,]@@ -639,11 +643,13 @@ export class RecordSharingService {const {rolesPermissions,+ roleIdsWithAllRecordsAccess,flatRowLevelPermissionPredicateMaps,flatRowLevelPermissionPredicateGroupMaps,flatFieldMetadataMaps,} = await this.workspaceCacheService.getOrRecompute(workspaceId, ['rolesPermissions',+ 'roleIdsWithAllRecordsAccess','flatRowLevelPermissionPredicateMaps','flatRowLevelPermissionPredicateGroupMaps','flatFieldMetadataMaps',@@ -683,6 +689,7 @@ export class RecordSharingService {roleId,owningApplicationId: undefined,rolesPermissions,+ roleIdsWithAllRecordsAccess,flatRowLevelPermissionPredicateMaps,flatRowLevelPermissionPredicateGroupMaps,flatFieldMetadataMaps,diff --git a/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/can-roles-access-all-records.util.spec.ts b/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/can-roles-access-all-records.util.spec.tsnew file mode 100644index 00000000000..bc0d8c09061--- /dev/null+++ b/packages/twenty-server/src/engine/core-modules/record-share/utils/__tests__/can-roles-access-all-records.util.spec.ts@@ -0,0 +1,17 @@+import { canRolesAccessAllRecords } from 'src/engine/core-modules/record-share/utils/can-roles-access-all-records.util';++describe('canRolesAccessAllRecords', () => {+ const roleIdsWithAllRecordsAccess = ['admin', 'auditor'];++ it.each([+ [['admin'], true],+ [['admin', 'auditor'], true],+ [['admin', 'member'], false],+ [['member'], false],+ [[], false],+ ])('decides access for roles %j', (roleIds, expected) => {+ expect(+ canRolesAccessAllRecords({ roleIds, roleIdsWithAllRecordsAccess }),+ ).toBe(expected);+ });+});diff --git a/packages/twenty-server/src/engine/core-modules/record-share/utils/build-record-share-gate.util.ts b/packages/twenty-server/src/engine/core-modules/record-share/utils/build-record-share-gate.util.tsindex 27c6ff119fb..7c106776504 100644--- a/packages/twenty-server/src/engine/core-modules/record-share/utils/build-record-share-gate.util.ts+++ b/packages/twenty-server/src/engine/core-modules/record-share/utils/build-record-share-gate.util.ts@@ -12,9 +12,9 @@ import {} from 'src/engine/core-modules/record-share/utils/build-inherited-readability-condition.util';import { buildRecordShareCondition } from 'src/engine/core-modules/record-share/utils/build-record-share-condition.util';import { buildRecordShareExceptionCondition } from 'src/engine/core-modules/record-share/utils/build-record-share-exception-condition.util';-import { isRecordShareExceptionObject } from 'src/engine/core-modules/record-share/utils/is-record-share-exception-object.util';import { isOpenWhenDetachedObject } from 'src/engine/core-modules/record-share/utils/is-open-when-detached-object.util';import { resolveInheritedReadabilityParents } from 'src/engine/core-modules/record-share/utils/resolve-inherited-readability-parents.util';+import { shouldEnforceRecordShareExceptions } from 'src/engine/core-modules/record-share/utils/should-enforce-record-share-exceptions.util';import { resolveRequiredRecordShareAccessLevels } from 'src/engine/core-modules/record-share/utils/resolve-required-record-share-access-levels.util';import {type RowAccessPolicy,@@ -45,8 +45,11 @@ export const buildRecordShareGate = ({});switch (gateKind) {case 'open':- return context.environment.isRecordSharingEnabled &&- isRecordShareExceptionObject(target.flatObjectMetadata)+ return shouldEnforceRecordShareExceptions({+ flatObjectMetadata: target.flatObjectMetadata,+ isRecordSharingEnabled: context.environment.isRecordSharingEnabled,+ canAccessAllRecords: context.subject.canAccessAllRecords,+ })? buildRecordShareExceptionGate(context, target): { kind: 'open' };case 'deny':diff --git a/packages/twenty-server/src/engine/core-modules/record-share/utils/build-role-row-access-policy-subject.util.ts b/packages/twenty-server/src/engine/core-modules/record-share/utils/build-role-row-access-policy-subject.util.tsindex 90f4f306283..5058ab7c0f3 100644--- a/packages/twenty-server/src/engine/core-modules/record-share/utils/build-role-row-access-policy-subject.util.ts+++ b/packages/twenty-server/src/engine/core-modules/record-share/utils/build-role-row-access-policy-subject.util.ts@@ -5,6 +5,7 @@ import { type ObjectsPermissionsByRoleId } from 'twenty-shared/types';import { isDefined } from 'twenty-shared/utils';import { type UserWorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';+import { canRolesAccessAllRecords } from 'src/engine/core-modules/record-share/utils/can-roles-access-all-records.util';import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';import { type FlatRowLevelPermissionPredicateMaps } from 'src/engine/metadata-modules/row-level-permission-predicate/types/flat-row-level-permission-predicate-maps.type';@@ -16,6 +17,7 @@ export const buildRoleRowAccessPolicySubject = ({roleId,owningApplicationId,rolesPermissions,+ roleIdsWithAllRecordsAccess,flatRowLevelPermissionPredicateMaps,flatRowLevelPermissionPredicateGroupMaps,flatFieldMetadataMaps,@@ -24,6 +26,7 @@ export const buildRoleRowAccessPolicySubject = ({roleId: string | undefined;owningApplicationId: string | undefined;rolesPermissions: ObjectsPermissionsByRoleId;+ roleIdsWithAllRecordsAccess: string[];flatRowLevelPermissionPredicateMaps: FlatRowLevelPermissionPredicateMaps;flatRowLevelPermissionPredicateGroupMaps: FlatRowLevelPermissionPredicateGroupMaps;flatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata>;@@ -37,6 +40,10 @@ export const buildRoleRowAccessPolicySubject = ({? rolesPermissions[roleId]: undefined,principalIds: [EVERYONE_PRINCIPAL_ID, ...roleIds],+ canAccessAllRecords: canRolesAccessAllRecords({+ roleIds,+ roleIdsWithAllRecordsAccess,+ }),isOwningApplication: (objectMetadata) =>isDefined(owningApplicationId) &&objectMetadata.applicationId === owningApplicationId,diff --git a/packages/twenty-server/src/engine/core-modules/record-share/utils/can-roles-access-all-records.util.ts b/packages/twenty-server/src/engine/core-modules/record-share/utils/can-roles-access-all-records.util.tsnew file mode 100644index 00000000000..c2ca364fb03--- /dev/null+++ b/packages/twenty-server/src/engine/core-modules/record-share/utils/can-roles-access-all-records.util.ts@@ -0,0 +1,15 @@+/* @license Enterprise */++import { isNonEmptyArray } from 'twenty-shared/utils';++// Several roles combine as an intersection, so every one of them needs the+// permission for the restrictions to be lifted+export const canRolesAccessAllRecords = ({+ roleIds,+ roleIdsWithAllRecordsAccess,+}: {+ roleIds: string[];+ roleIdsWithAllRecordsAccess: string[];+}): boolean =>+ isNonEmptyArray(roleIds) &&+ roleIds.every((roleId) => roleIdsWithAllRecordsAccess.includes(roleId));diff --git a/packages/twenty-server/src/engine/core-modules/record-share/utils/should-enforce-record-share-exceptions.util.ts b/packages/twenty-server/src/engine/core-modules/record-share/utils/should-enforce-record-share-exceptions.util.tsnew file mode 100644index 00000000000..aeefc4efc42--- /dev/null+++ b/packages/twenty-server/src/engine/core-modules/record-share/utils/should-enforce-record-share-exceptions.util.ts@@ -0,0 +1,17 @@+/* @license Enterprise */++import { isRecordShareExceptionObject } from 'src/engine/core-modules/record-share/utils/is-record-share-exception-object.util';+import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';++export const shouldEnforceRecordShareExceptions = ({+ flatObjectMetadata,+ isRecordSharingEnabled,+ canAccessAllRecords,+}: {+ flatObjectMetadata: Pick<FlatObjectMetadata, 'readability' | 'isSystem'>;+ isRecordSharingEnabled: boolean;+ canAccessAllRecords: boolean;+}): boolean =>+ isRecordSharingEnabled &&+ !canAccessAllRecords &&+ isRecordShareExceptionObject(flatObjectMetadata);diff --git a/packages/twenty-server/src/engine/core-modules/user/services/user.service.ts b/packages/twenty-server/src/engine/core-modules/user/services/user.service.tsindex f60b8378c54..b26f889d80f 100644--- a/packages/twenty-server/src/engine/core-modules/user/services/user.service.ts+++ b/packages/twenty-server/src/engine/core-modules/user/services/user.service.ts@@ -43,6 +43,7 @@ import {PermissionsExceptionCode,PermissionsExceptionMessage,} from 'src/engine/metadata-modules/permissions/permissions.exception';+import { RecordShareOwnershipTransferService } from 'src/engine/core-modules/record-share/services/record-share-ownership-transfer.service';import { ConnectedAccountOwnershipTransferService } from 'src/engine/metadata-modules/connected-account/services/connected-account-ownership-transfer.service';import { AgentChatThreadWorkspaceEntity } from 'src/engine/metadata-modules/ai/ai-history/standard-objects/agent-chat-thread.workspace-entity';import { AgentHistoryRepository } from 'src/engine/metadata-modules/ai/ai-history/repositories/agent-history-repository';@@ -58,6 +59,7 @@ export class UserService {@InjectRepository(UserEntity)private readonly userRepository: Repository<UserEntity>,private readonly connectedAccountOwnershipTransferService: ConnectedAccountOwnershipTransferService,+ private readonly recordShareOwnershipTransferService: RecordShareOwnershipTransferService,private readonly workspaceDomainsService: WorkspaceDomainsService,private readonly emailVerificationService: EmailVerificationService,private readonly workspaceService: WorkspaceService,@@ -387,6 +389,14 @@ export class UserService {},);+ await this.recordShareOwnershipTransferService.transferRecordSharesToCustodian(+ {+ removedUserWorkspace: userWorkspace,+ removedWorkspaceMemberId: workspaceMember.id,+ actingUserWorkspaceId,+ },+ );+await this.workspaceOrmManager.executeInWorkspaceContext(async () => {const workspaceMemberRepository =this.workspaceOrmManager.getRepository<WorkspaceMemberWorkspaceEntity>(diff --git a/packages/twenty-server/src/engine/core-modules/user/user.module.ts b/packages/twenty-server/src/engine/core-modules/user/user.module.tsindex a696f02b60f..9e23966d28e 100644--- a/packages/twenty-server/src/engine/core-modules/user/user.module.ts+++ b/packages/twenty-server/src/engine/core-modules/user/user.module.ts@@ -20,6 +20,7 @@ import { UserEntity } from 'src/engine/core-modules/user/user.entity';import { UserResolver } from 'src/engine/core-modules/user/user.resolver';import { WorkspaceModule } from 'src/engine/core-modules/workspace/workspace.module';import { AgentHistoryModule } from 'src/engine/metadata-modules/ai/ai-history/ai-history.module';+import { RecordShareOwnershipTransferModule } from 'src/engine/core-modules/record-share/record-share-ownership-transfer.module';import { ConnectedAccountMetadataModule } from 'src/engine/metadata-modules/connected-account/connected-account-metadata.module';import { PermissionsModule } from 'src/engine/metadata-modules/permissions/permissions.module';import { UserRoleModule } from 'src/engine/metadata-modules/user-role/user-role.module';@@ -39,6 +40,7 @@ import { UserService } from './services/user.service';UserWorkspaceModule,UserRoleModule,ConnectedAccountMetadataModule,+ RecordShareOwnershipTransferModule,AgentHistoryModule,FeatureFlagModule,PermissionsModule,diff --git a/packages/twenty-server/src/engine/metadata-modules/connected-account/services/connected-account-ownership-transfer.service.ts b/packages/twenty-server/src/engine/metadata-modules/connected-account/services/connected-account-ownership-transfer.service.tsindex afc901bdf86..6b237388679 100644--- a/packages/twenty-server/src/engine/metadata-modules/connected-account/services/connected-account-ownership-transfer.service.ts+++ b/packages/twenty-server/src/engine/metadata-modules/connected-account/services/connected-account-ownership-transfer.service.ts@@ -1,20 +1,14 @@import { Injectable } from '@nestjs/common';-import { InjectRepository } from '@nestjs/typeorm';--import { Not, Repository } from 'typeorm';import { isDefined } from 'twenty-shared/utils';-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';+import { type UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';import { ConnectedAccountMetadataService } from 'src/engine/metadata-modules/connected-account/connected-account-metadata.service';import { UserRoleService } from 'src/engine/metadata-modules/user-role/user-role.service';-import { STANDARD_ROLE } from 'src/engine/workspace-manager/twenty-standard-application/constants/standard-role.constant';@Injectable()export class ConnectedAccountOwnershipTransferService {constructor(- @InjectRepository(UserWorkspaceEntity)- private readonly userWorkspaceRepository: Repository<UserWorkspaceEntity>,private readonly userRoleService: UserRoleService,private readonly connectedAccountMetadataService: ConnectedAccountMetadataService,) {}@@ -30,67 +24,18 @@ export class ConnectedAccountOwnershipTransferService {removedUserWorkspace: UserWorkspaceEntity;actingUserWorkspaceId?: string;}) {- const custodianUserWorkspaceId =- await this.resolveConnectedAccountsCustodianUserWorkspaceId({+ const custodianUserWorkspace =+ await this.userRoleService.resolveCustodianUserWorkspace({removedUserWorkspace,actingUserWorkspaceId,});- if (isDefined(custodianUserWorkspaceId)) {+ if (isDefined(custodianUserWorkspace)) {await this.connectedAccountMetadataService.transferOwnership({fromUserWorkspaceId: removedUserWorkspace.id,- toUserWorkspaceId: custodianUserWorkspaceId,+ toUserWorkspaceId: custodianUserWorkspace.id,workspaceId: removedUserWorkspace.workspaceId,});}}-- private async resolveConnectedAccountsCustodianUserWorkspaceId({- removedUserWorkspace,- actingUserWorkspaceId,- }: {- removedUserWorkspace: UserWorkspaceEntity;- actingUserWorkspaceId?: string;- }): Promise<string | undefined> {- const otherUserWorkspaces = await this.userWorkspaceRepository.find({- where: {- workspaceId: removedUserWorkspace.workspaceId,- id: Not(removedUserWorkspace.id),- },- order: { createdAt: 'ASC' },- });-- if (otherUserWorkspaces.length === 0) {- return undefined;- }-- const actingUserWorkspace = otherUserWorkspaces.find(- (otherUserWorkspace) => otherUserWorkspace.id === actingUserWorkspaceId,- );-- if (isDefined(actingUserWorkspace)) {- return actingUserWorkspace.id;- }-- const rolesByUserWorkspaceId =- await this.userRoleService.getRolesByUserWorkspaces({- userWorkspaceIds: otherUserWorkspaces.map(- (otherUserWorkspace) => otherUserWorkspace.id,- ),- workspaceId: removedUserWorkspace.workspaceId,- });-- const oldestAdminUserWorkspace = otherUserWorkspaces.find(- (otherUserWorkspace) =>- rolesByUserWorkspaceId- .get(otherUserWorkspace.id)- ?.some(- (role) =>- role.universalIdentifier ===- STANDARD_ROLE.admin.universalIdentifier,- ),- );-- return (oldestAdminUserWorkspace ?? otherUserWorkspaces[0]).id;- }}diff --git a/packages/twenty-server/src/engine/metadata-modules/role/role.module.ts b/packages/twenty-server/src/engine/metadata-modules/role/role.module.tsindex fef8a6089bf..485f7c5083c 100644--- a/packages/twenty-server/src/engine/metadata-modules/role/role.module.ts+++ b/packages/twenty-server/src/engine/metadata-modules/role/role.module.ts@@ -24,6 +24,7 @@ import { RoleResolver } from 'src/engine/metadata-modules/role/role.resolver';import { RoleService } from 'src/engine/metadata-modules/role/role.service';import { WorkspaceFlatRoleMapCacheService } from 'src/engine/metadata-modules/role/services/workspace-flat-role-map-cache.service';import { RoleToolWorkspaceService } from 'src/engine/metadata-modules/role/tools/services/role-tool.workspace-service';+import { WorkspaceRoleIdsWithAllRecordsAccessCacheService } from 'src/engine/metadata-modules/role/services/workspace-role-ids-with-all-records-access-cache.service';import { WorkspaceRolesPermissionsCacheService } from 'src/engine/metadata-modules/role/services/workspace-roles-permissions-cache.service';import { RowLevelPermissionPredicateGroupEntity } from 'src/engine/metadata-modules/row-level-permission-predicate/entities/row-level-permission-predicate-group.entity';import { RowLevelPermissionPredicateEntity } from 'src/engine/metadata-modules/row-level-permission-predicate/entities/row-level-permission-predicate.entity';@@ -72,6 +73,7 @@ import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspaceWorkspaceFlatRoleTargetMapCacheService,WorkspaceMigrationGraphqlApiExceptionInterceptor,WorkspaceRolesPermissionsCacheService,+ WorkspaceRoleIdsWithAllRecordsAccessCacheService,provideWorkspaceScopedRepository(RoleEntity),provideWorkspaceScopedRepository(RoleTargetEntity),provideWorkspaceScopedRepository(AgentEntity),diff --git a/packages/twenty-server/src/engine/metadata-modules/role/services/__tests__/workspace-role-ids-with-all-records-access-cache.service.spec.ts b/packages/twenty-server/src/engine/metadata-modules/role/services/__tests__/workspace-role-ids-with-all-records-access-cache.service.spec.tsnew file mode 100644index 00000000000..863519ffb5d--- /dev/null+++ b/packages/twenty-server/src/engine/metadata-modules/role/services/__tests__/workspace-role-ids-with-all-records-access-cache.service.spec.ts@@ -0,0 +1,17 @@+import { WorkspaceRoleIdsWithAllRecordsAccessCacheService } from 'src/engine/metadata-modules/role/services/workspace-role-ids-with-all-records-access-cache.service';++describe('WorkspaceRoleIdsWithAllRecordsAccessCacheService', () => {+ it('lists the roles that administer every setting', () => {+ expect(+ new WorkspaceRoleIdsWithAllRecordsAccessCacheService().computeForCache({+ workspaceId: 'workspace',+ rows: {+ role: [+ { id: 'admin', canUpdateAllSettings: true },+ { id: 'member', canUpdateAllSettings: false },+ ],+ },+ } as never),+ ).toEqual(['admin']);+ });+});diff --git a/packages/twenty-server/src/engine/metadata-modules/role/services/workspace-role-ids-with-all-records-access-cache.service.ts b/packages/twenty-server/src/engine/metadata-modules/role/services/workspace-role-ids-with-all-records-access-cache.service.tsnew file mode 100644index 00000000000..455a2f69563--- /dev/null+++ b/packages/twenty-server/src/engine/metadata-modules/role/services/workspace-role-ids-with-all-records-access-cache.service.ts@@ -0,0 +1,30 @@+import { Injectable } from '@nestjs/common';++import { WorkspaceCacheProvider } from 'src/engine/workspace-cache/interfaces/workspace-cache-provider.service';++import { WorkspaceCache } from 'src/engine/workspace-cache/decorators/workspace-cache.decorator';+import { type WorkspaceCacheProviderContext } from 'src/engine/workspace-cache/types/workspace-cache-provider-context.type';+import { type WorkspaceCacheRowsRequirement } from 'src/engine/workspace-cache/types/workspace-cache-rows-requirement.type';++const ROLE_IDS_WITH_ALL_RECORDS_ACCESS_ROWS_REQUIREMENT = {+ role: ['id', 'canUpdateAllSettings'],+} as const satisfies WorkspaceCacheRowsRequirement;++@Injectable()+@WorkspaceCache('roleIdsWithAllRecordsAccess', { packingPonderation: 1 })+export class WorkspaceRoleIdsWithAllRecordsAccessCacheService extends WorkspaceCacheProvider<+ string[]+> {+ override readonly rowsRequirement =+ ROLE_IDS_WITH_ALL_RECORDS_ACCESS_ROWS_REQUIREMENT;++ computeForCache({+ rows,+ }: WorkspaceCacheProviderContext<+ typeof ROLE_IDS_WITH_ALL_RECORDS_ACCESS_ROWS_REQUIREMENT+ >): string[] {+ return rows.role+ .filter((role) => role.canUpdateAllSettings)+ .map((role) => role.id);+ }+}diff --git a/packages/twenty-server/src/engine/metadata-modules/user-role/user-role.service.ts b/packages/twenty-server/src/engine/metadata-modules/user-role/user-role.service.tsindex e143d67e029..6a09bd611cf 100644--- a/packages/twenty-server/src/engine/metadata-modules/user-role/user-role.service.ts+++ b/packages/twenty-server/src/engine/metadata-modules/user-role/user-role.service.ts@@ -2,7 +2,7 @@ import { InjectRepository } from '@nestjs/typeorm';import { msg } from '@lingui/core/macro';import { isDefined } from 'twenty-shared/utils';-import { In, Repository } from 'typeorm';+import { In, Not, Repository } from 'typeorm';import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';import {@@ -429,4 +429,52 @@ export class UserRoleService {);}}++ async resolveCustodianUserWorkspace({+ removedUserWorkspace,+ actingUserWorkspaceId,+ }: {+ removedUserWorkspace: UserWorkspaceEntity;+ actingUserWorkspaceId?: string;+ }): Promise<UserWorkspaceEntity | undefined> {+ const otherUserWorkspaces = await this.userWorkspaceRepository.find({+ where: {+ workspaceId: removedUserWorkspace.workspaceId,+ id: Not(removedUserWorkspace.id),+ },+ order: { createdAt: 'ASC' },+ });++ if (otherUserWorkspaces.length === 0) {+ return undefined;+ }++ const actingUserWorkspace = otherUserWorkspaces.find(+ (otherUserWorkspace) => otherUserWorkspace.id === actingUserWorkspaceId,+ );++ if (isDefined(actingUserWorkspace)) {+ return actingUserWorkspace;+ }++ const rolesByUserWorkspaceId = await this.getRolesByUserWorkspaces({+ userWorkspaceIds: otherUserWorkspaces.map(+ (otherUserWorkspace) => otherUserWorkspace.id,+ ),+ workspaceId: removedUserWorkspace.workspaceId,+ });++ const oldestAdminUserWorkspace = otherUserWorkspaces.find(+ (otherUserWorkspace) =>+ rolesByUserWorkspaceId+ .get(otherUserWorkspace.id)+ ?.some(+ (role) =>+ role.universalIdentifier ===+ STANDARD_ROLE.admin.universalIdentifier,+ ),+ );++ return oldestAdminUserWorkspace ?? otherUserWorkspaces[0];+ }}diff --git a/packages/twenty-server/src/engine/subscriptions/object-record-event/__tests__/object-record-event-publisher.spec.ts b/packages/twenty-server/src/engine/subscriptions/object-record-event/__tests__/object-record-event-publisher.spec.tsindex f427084a30f..51bfef2fcd3 100644--- a/packages/twenty-server/src/engine/subscriptions/object-record-event/__tests__/object-record-event-publisher.spec.ts+++ b/packages/twenty-server/src/engine/subscriptions/object-record-event/__tests__/object-record-event-publisher.spec.ts@@ -226,6 +226,7 @@ describe('ObjectRecordEventPublisher', () => {idByUniversalIdentifier: {},},featureFlagsMap: overrides.featureFlagsMap ?? {},+ roleIdsWithAllRecordsAccess: [],});const createCacheMock = (diff --git a/packages/twenty-server/src/engine/subscriptions/object-record-event/object-record-event-publisher.ts b/packages/twenty-server/src/engine/subscriptions/object-record-event/object-record-event-publisher.tsindex cea1e7f1fd8..93deb209b7d 100644--- a/packages/twenty-server/src/engine/subscriptions/object-record-event/object-record-event-publisher.ts+++ b/packages/twenty-server/src/engine/subscriptions/object-record-event/object-record-event-publisher.ts@@ -55,6 +55,7 @@ import { buildRowLevelPermissionRecordFilter } from 'src/engine/twenty-orm/utilsimport { computePermissionIntersection } from 'src/engine/twenty-orm/utils/compute-permission-intersection.util';import { type RowAccessPolicySubject } from 'src/engine/twenty-orm/types/row-access-policy.type';import { isRecordMatchingRLSRowLevelPermissionPredicate } from 'src/engine/twenty-orm/utils/is-record-matching-rls-row-level-permission-predicate.util';+import { canRolesAccessAllRecords } from 'src/engine/core-modules/record-share/utils/can-roles-access-all-records.util';import { resolveRoleIdsForUser } from 'src/engine/twenty-orm/utils/resolve-role-ids-for-user.util';import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';import { WorkspaceEventBatch } from 'src/engine/workspace-event-emitter/types/workspace-event-batch.type';@@ -66,6 +67,7 @@ type StreamPermissionsContext = {flatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata>;userWorkspaceRoleMap: UserWorkspaceRoleMap;rolesPermissions: ObjectsPermissionsByRoleId;+ roleIdsWithAllRecordsAccess: string[];flatApplicationMaps: FlatApplicationCacheMaps;isRecordSharingEnabled: boolean;};@@ -556,6 +558,11 @@ export class ObjectRecordEventPublisher {subscriberAuthContext.workspaceMemberId,...roleIds,].filter(isDefined),+ canAccessAllRecords: canRolesAccessAllRecords({+ roleIds,+ roleIdsWithAllRecordsAccess:+ permissionsContext.roleIdsWithAllRecordsAccess,+ }),isOwningApplication: (objectMetadata) =>isDefined(objectMetadata.applicationId) &&subscriberAuthContext.applicationId === objectMetadata.applicationId,@@ -688,6 +695,7 @@ export class ObjectRecordEventPublisher {flatFieldMetadataMaps,userWorkspaceRoleMap,rolesPermissions,+ roleIdsWithAllRecordsAccess,flatApplicationMaps,featureFlagsMap,} = await this.workspaceCacheService.getOrRecompute(workspaceId, [@@ -696,6 +704,7 @@ export class ObjectRecordEventPublisher {'flatFieldMetadataMaps','userWorkspaceRoleMap','rolesPermissions',+ 'roleIdsWithAllRecordsAccess','flatApplicationMaps','featureFlagsMap',]);@@ -706,6 +715,7 @@ export class ObjectRecordEventPublisher {flatFieldMetadataMaps,userWorkspaceRoleMap,rolesPermissions,+ roleIdsWithAllRecordsAccess,flatApplicationMaps,isRecordSharingEnabled:featureFlagsMap[FeatureFlagKey.IS_RECORD_LEVEL_SHARING_ENABLED] ??diff --git a/packages/twenty-server/src/engine/twenty-orm/datasource/workspace-data-source.service.ts b/packages/twenty-server/src/engine/twenty-orm/datasource/workspace-data-source.service.tsindex 78160f5007b..e9462467d4a 100644--- a/packages/twenty-server/src/engine/twenty-orm/datasource/workspace-data-source.service.ts+++ b/packages/twenty-server/src/engine/twenty-orm/datasource/workspace-data-source.service.ts@@ -122,6 +122,7 @@ export class WorkspaceDataSourceServicefeatureFlagsMap: workspaceContext.featureFlagsMap,billingEntitlements: workspaceContext.billingEntitlements,userWorkspaceRoleMap: workspaceContext.userWorkspaceRoleMap,+ roleIdsWithAllRecordsAccess: workspaceContext.roleIdsWithAllRecordsAccess,apiKeyRoleMap: workspaceContext.apiKeyRoleMap,eventEmitterService: this.workspaceEventEmitter,recordStock: this.workspaceRecordStockService,diff --git a/packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-internal-context.interface.ts b/packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-internal-context.interface.tsindex 81b44f70c44..8d84389a582 100644--- a/packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-internal-context.interface.ts+++ b/packages/twenty-server/src/engine/twenty-orm/interfaces/workspace-internal-context.interface.ts@@ -25,6 +25,7 @@ export interface WorkspaceInternalContext {featureFlagsMap: Record<FeatureFlagKey, boolean>;billingEntitlements: BillingEntitlements;userWorkspaceRoleMap: UserWorkspaceRoleMap;+ roleIdsWithAllRecordsAccess: string[];apiKeyRoleMap: Record<string, string>;eventEmitterService: Pick<WorkspaceEventEmitter, 'emitDatabaseBatchEvent'>;recordStock: Pick<diff --git a/packages/twenty-server/src/engine/twenty-orm/repository/workspace-repository.ts b/packages/twenty-server/src/engine/twenty-orm/repository/workspace-repository.tsindex 19e985259e5..4eb5fc06084 100644--- a/packages/twenty-server/src/engine/twenty-orm/repository/workspace-repository.ts+++ b/packages/twenty-server/src/engine/twenty-orm/repository/workspace-repository.ts@@ -31,6 +31,7 @@ import {validateOperationIsPermittedOrThrow,} from 'src/engine/twenty-orm/repository/permissions.utils';import { type WorkspaceInternalContext } from 'src/engine/twenty-orm/interfaces/workspace-internal-context.interface';+import { canRolesAccessAllRecords } from 'src/engine/core-modules/record-share/utils/can-roles-access-all-records.util';import { type InheritedReadabilityChildRecords } from 'src/engine/core-modules/record-share/types/inherited-readability-child-records.type';import { type InheritedReadabilityChildrenParent } from 'src/engine/core-modules/record-share/types/inherited-readability-children-parent.type';import { type InheritedReadabilityColumnParent } from 'src/engine/core-modules/record-share/types/inherited-readability-column-parent.type';@@ -56,6 +57,7 @@ import {import { isChildRecordBoundAtDeletion } from 'src/engine/twenty-orm/utils/is-child-record-bound-at-deletion.util';import { isOwningApplicationAuthContext } from 'src/engine/twenty-orm/utils/is-owning-application-auth-context.util';import { resolvePrincipalIdsFromAuthContext } from 'src/engine/twenty-orm/utils/resolve-principal-ids-from-auth-context.util';+import { resolveRoleIdsFromAuthContext } from 'src/engine/twenty-orm/utils/resolve-role-ids-from-auth-context.util';import { resolveInheritedReadabilityChildLinks } from 'src/engine/core-modules/record-share/utils/resolve-inherited-readability-child-links.util';import { resolveInheritedReadabilityParents } from 'src/engine/core-modules/record-share/utils/resolve-inherited-readability-parents.util';import { resolveRowLevelPermissionRecordFilter } from 'src/engine/twenty-orm/utils/resolve-row-level-permission-record-filter.util';@@ -2229,13 +2231,20 @@ export class WorkspaceRepository<TEntity extends ObjectLiteral = ObjectRecord> {}private resolveRowAccessPolicySubject(): RowAccessPolicySubject {+ const roleMaps = {+ authContext: this.options.authContext,+ userWorkspaceRoleMap: this.options.internalContext.userWorkspaceRoleMap,+ apiKeyRoleMap: this.options.internalContext.apiKeyRoleMap,+ };+return {isSystemContext: this.options.authContext?.type === 'system',objectsPermissions: this.options.objectRecordsPermissions,- principalIds: resolvePrincipalIdsFromAuthContext({- authContext: this.options.authContext,- userWorkspaceRoleMap: this.options.internalContext.userWorkspaceRoleMap,- apiKeyRoleMap: this.options.internalContext.apiKeyRoleMap,+ principalIds: resolvePrincipalIdsFromAuthContext(roleMaps),+ canAccessAllRecords: canRolesAccessAllRecords({+ roleIds: resolveRoleIdsFromAuthContext(roleMaps),+ roleIdsWithAllRecordsAccess:+ this.options.internalContext.roleIdsWithAllRecordsAccess,}),isOwningApplication: (objectMetadata) =>isOwningApplicationAuthContext({diff --git a/packages/twenty-server/src/engine/twenty-orm/storage/orm-workspace-context.storage.ts b/packages/twenty-server/src/engine/twenty-orm/storage/orm-workspace-context.storage.tsindex 3c91d69d169..b98ad073e2a 100644--- a/packages/twenty-server/src/engine/twenty-orm/storage/orm-workspace-context.storage.ts+++ b/packages/twenty-server/src/engine/twenty-orm/storage/orm-workspace-context.storage.ts@@ -25,6 +25,7 @@ export type ORMWorkspaceContext = {featureFlagsMap: Record<FeatureFlagKey, boolean>;billingEntitlements: BillingEntitlements;permissionsPerRoleId: ObjectsPermissionsByRoleId;+ roleIdsWithAllRecordsAccess: string[];userWorkspaceRoleMap: UserWorkspaceRoleMap;apiKeyRoleMap: Record<string, string>;flatRowLevelPermissionPredicateMaps: FlatRowLevelPermissionPredicateMaps;diff --git a/packages/twenty-server/src/engine/twenty-orm/types/row-access-policy.type.ts b/packages/twenty-server/src/engine/twenty-orm/types/row-access-policy.type.tsindex 9ca322d41a1..da891d76d9f 100644--- a/packages/twenty-server/src/engine/twenty-orm/types/row-access-policy.type.ts+++ b/packages/twenty-server/src/engine/twenty-orm/types/row-access-policy.type.ts@@ -22,6 +22,7 @@ export type RowAccessPolicySubject = {isSystemContext: boolean;objectsPermissions: ObjectsPermissions | undefined;principalIds: string[] | undefined;+ canAccessAllRecords: boolean;isOwningApplication: (objectMetadata: FlatObjectMetadata) => boolean;resolveRowLevelPermissionRecordFilter: (objectMetadata: FlatObjectMetadata,diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/build-row-access-policy.util.spec.ts b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/build-row-access-policy.util.spec.tsindex 4ea43ff4df1..0fb2d6bff94 100644--- a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/build-row-access-policy.util.spec.ts+++ b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/build-row-access-policy.util.spec.ts@@ -67,6 +67,7 @@ const readEverything: RowAccessPolicySubject = {isSystemContext: false,objectsPermissions: undefined,principalIds: ['member-1'],+ canAccessAllRecords: false,isOwningApplication: () => false,resolveRowLevelPermissionRecordFilter: () => null,};@@ -178,6 +179,25 @@ describe('buildRowAccessPolicy', () => {);});+ it('lifts the restrictions of an OPEN object for a subject with access to all records', () => {+ expect(+ buildRowAccessPolicy({+ subject: { ...readEverything, canAccessAllRecords: true },+ environment: { ...environment, isRecordSharingEnabled: true },+ tableAlias: 'note',+ flatObjectMetadata: note,+ operationType: 'select',+ depth: 0,+ }),+ ).toEqual({ kind: 'open' });+ });++ it('keeps PRIVATE records gated for a subject with access to all records', () => {+ expect(+ gatedSql({ ...readEverything, canAccessAllRecords: true }, person),+ ).toContain('recordShare');+ });+it('keeps an OPEN system object open when record sharing is enabled', () => {expect(buildRowAccessPolicy({diff --git a/packages/twenty-server/src/engine/twenty-orm/workspace-orm.manager.ts b/packages/twenty-server/src/engine/twenty-orm/workspace-orm.manager.tsindex 7287ef718d3..5e39dc60504 100644--- a/packages/twenty-server/src/engine/twenty-orm/workspace-orm.manager.ts+++ b/packages/twenty-server/src/engine/twenty-orm/workspace-orm.manager.ts@@ -140,6 +140,7 @@ export class WorkspaceOrmManager {featureFlagsMap,billingEntitlements,rolesPermissions: permissionsPerRoleId,+ roleIdsWithAllRecordsAccess,userWorkspaceRoleMap,apiKeyRoleMap,flatRowLevelPermissionPredicateMaps,@@ -151,6 +152,7 @@ export class WorkspaceOrmManager {'featureFlagsMap','billingEntitlements','rolesPermissions',+ 'roleIdsWithAllRecordsAccess','userWorkspaceRoleMap','apiKeyRoleMap','flatRowLevelPermissionPredicateMaps',@@ -182,6 +184,7 @@ export class WorkspaceOrmManager {featureFlagsMap,billingEntitlements,permissionsPerRoleId,+ roleIdsWithAllRecordsAccess,userWorkspaceRoleMap,apiKeyRoleMap,};@@ -228,6 +231,7 @@ export class WorkspaceOrmManager {featureFlagsMap: {} as ORMWorkspaceContext['featureFlagsMap'],billingEntitlements,permissionsPerRoleId: {},+ roleIdsWithAllRecordsAccess: [],userWorkspaceRoleMap: {},apiKeyRoleMap: {},};diff --git a/packages/twenty-server/src/engine/workspace-cache/types/workspace-cache-key.type.ts b/packages/twenty-server/src/engine/workspace-cache/types/workspace-cache-key.type.tsindex 88774464b5f..0b3e7730b69 100644--- a/packages/twenty-server/src/engine/workspace-cache/types/workspace-cache-key.type.ts+++ b/packages/twenty-server/src/engine/workspace-cache/types/workspace-cache-key.type.ts@@ -26,6 +26,7 @@ import { type UsageLimits } from 'src/engine/core-modules/usage-limit/types/usagexport type AdditionalCacheDataMaps = {featureFlagsMap: Record<FeatureFlagKey, boolean>;rolesPermissions: ObjectsPermissionsByRoleId;+ roleIdsWithAllRecordsAccess: string[];userWorkspaceRoleMap: UserWorkspaceRoleMap;apiKeyRoleMap: Record<string, string>;apiKeyMap: Record<string, FlatApiKey>;diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/services/workspace-migration-runner.service.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/services/workspace-migration-runner.service.tsindex 5b74da63a6e..4ce0de5b6e3 100644--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/services/workspace-migration-runner.service.ts+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-runner/services/workspace-migration-runner.service.ts@@ -81,6 +81,7 @@ export class WorkspaceMigrationRunnerService {if (shouldInvalidateRoleMapCache || shouldInvalidateRolesPermissionsCache) {legacyCacheKeyNames.push('rolesPermissions',+ 'roleIdsWithAllRecordsAccess','userWorkspaceRoleMap','flatRoleTargetMaps','apiKeyRoleMap',diff --git a/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/__tests__/workflow-database-event-trigger.listener.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/__tests__/workflow-database-event-trigger.listener.spec.tsindex 835ca63bd98..3d31099db58 100644--- a/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/__tests__/workflow-database-event-trigger.listener.spec.ts+++ b/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/__tests__/workflow-database-event-trigger.listener.spec.ts@@ -444,6 +444,7 @@ describe('WorkflowDatabaseEventTriggerListener', () => {},flatRoleMaps: { byUniversalIdentifier: {} },rolesPermissions: {},+ roleIdsWithAllRecordsAccess: [],flatRowLevelPermissionPredicateMaps:createEmptyFlatEntityMaps(),flatRowLevelPermissionPredicateGroupMaps:@@ -516,6 +517,7 @@ describe('WorkflowDatabaseEventTriggerListener', () => {},flatRoleMaps: { byUniversalIdentifier: {} },rolesPermissions: {},+ roleIdsWithAllRecordsAccess: [],flatRowLevelPermissionPredicateMaps:createEmptyFlatEntityMaps(),flatRowLevelPermissionPredicateGroupMaps:diff --git a/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/workflow-database-event-trigger.listener.ts b/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/workflow-database-event-trigger.listener.tsindex 2f6e87f6b6c..b71285658e7 100644--- a/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/workflow-database-event-trigger.listener.ts+++ b/packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/workflow-database-event-trigger.listener.ts@@ -418,6 +418,7 @@ export class WorkflowDatabaseEventTriggerListener {flatApplicationMaps,flatRoleMaps,rolesPermissions,+ roleIdsWithAllRecordsAccess,flatRowLevelPermissionPredicateMaps,flatRowLevelPermissionPredicateGroupMaps,flatFieldMetadataMaps,@@ -425,6 +426,7 @@ export class WorkflowDatabaseEventTriggerListener {'flatApplicationMaps','flatRoleMaps','rolesPermissions',+ 'roleIdsWithAllRecordsAccess','flatRowLevelPermissionPredicateMaps','flatRowLevelPermissionPredicateGroupMaps','flatFieldMetadataMaps',@@ -447,6 +449,7 @@ export class WorkflowDatabaseEventTriggerListener {})?.id,owningApplicationId: standardApplication?.id,rolesPermissions,+ roleIdsWithAllRecordsAccess,flatRowLevelPermissionPredicateMaps,flatRowLevelPermissionPredicateGroupMaps,flatFieldMetadataMaps,diff --git a/packages/twenty-server/src/modules/workspace-member/query-hooks/workspace-member-delete-one.post-query.hook.ts b/packages/twenty-server/src/modules/workspace-member/query-hooks/workspace-member-delete-one.post-query.hook.tsindex 41a86813a90..d3b260f4c03 100644--- a/packages/twenty-server/src/modules/workspace-member/query-hooks/workspace-member-delete-one.post-query.hook.ts+++ b/packages/twenty-server/src/modules/workspace-member/query-hooks/workspace-member-delete-one.post-query.hook.ts@@ -7,6 +7,7 @@ import { type WorkspacePostQueryHookInstance } from 'src/engine/api/graphql/workimport { WorkspaceQueryHook } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/decorators/workspace-query-hook.decorator';import { WorkspaceQueryHookType } from 'src/engine/api/graphql/workspace-query-runner/workspace-query-hook/types/workspace-query-hook.type';+import { RecordShareOwnershipTransferService } from 'src/engine/core-modules/record-share/services/record-share-ownership-transfer.service';import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';@@ -33,6 +34,7 @@ export class WorkspaceMemberDeleteOnePostQueryHook implements WorkspacePostQueryprivate readonly userWorkspaceRepository: Repository<UserWorkspaceEntity>,private readonly userWorkspaceService: UserWorkspaceService,private readonly connectedAccountOwnershipTransferService: ConnectedAccountOwnershipTransferService,+ private readonly recordShareOwnershipTransferService: RecordShareOwnershipTransferService,@InjectAgentHistoryRepository('agentChatThread')private readonly agentChatThreadRepository: AgentHistoryRepository<AgentChatThreadWorkspaceEntity>,) {}@@ -100,6 +102,17 @@ export class WorkspaceMemberDeleteOnePostQueryHook implements WorkspacePostQuery},);+ await this.recordShareOwnershipTransferService.transferRecordSharesToCustodian(+ {+ removedUserWorkspace: userWorkspace,+ removedWorkspaceMemberId: workspaceMember.id,+ actingUserWorkspaceId:+ 'userWorkspaceId' in authContext+ ? authContext.userWorkspaceId+ : undefined,+ },+ );+await this.userWorkspaceService.deleteUserWorkspace({userWorkspaceId: userWorkspace.id,workspaceId: workspace.id,diff --git a/packages/twenty-server/src/modules/workspace-member/query-hooks/workspace-member-query-hook.module.ts b/packages/twenty-server/src/modules/workspace-member/query-hooks/workspace-member-query-hook.module.tsindex 5100bdfceca..7bc14b16221 100644--- a/packages/twenty-server/src/modules/workspace-member/query-hooks/workspace-member-query-hook.module.ts+++ b/packages/twenty-server/src/modules/workspace-member/query-hooks/workspace-member-query-hook.module.ts@@ -6,6 +6,7 @@ import { FeatureFlagModule } from 'src/engine/core-modules/feature-flag/feature-import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';import { UserWorkspaceModule } from 'src/engine/core-modules/user-workspace/user-workspace.module';import { AgentHistoryModule } from 'src/engine/metadata-modules/ai/ai-history/ai-history.module';+import { RecordShareOwnershipTransferModule } from 'src/engine/core-modules/record-share/record-share-ownership-transfer.module';import { ConnectedAccountMetadataModule } from 'src/engine/metadata-modules/connected-account/connected-account-metadata.module';import { WorkspaceMemberCreateManyPreQueryHook } from 'src/modules/workspace-member/query-hooks/workspace-member-create-many.pre-query.hook';import { WorkspaceMemberCreateOnePreQueryHook } from 'src/modules/workspace-member/query-hooks/workspace-member-create-one.pre-query.hook';@@ -36,6 +37,7 @@ import { WorkspaceMemberUpdateManyPreQueryHook } from 'src/modules/workspace-memFeatureFlagModule,UserWorkspaceModule,ConnectedAccountMetadataModule,+ RecordShareOwnershipTransferModule,AgentHistoryModule,TypeOrmModule.forFeature([UserWorkspaceEntity]),],diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/chat-thread-sharing.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/chat-thread-sharing.integration-spec.tsindex 900dc9e2212..aabf119e8ba 100644--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/chat-thread-sharing.integration-spec.ts+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/chat-thread-sharing.integration-spec.ts@@ -981,6 +981,7 @@ describe('Conversations through the record API', () => {isSystemContext: false,objectsPermissions: rolesPermissions[roleId],principalIds: [EVERYONE_PRINCIPAL_ID, workspaceMemberId, roleId],+ canAccessAllRecords: false,isOwningApplication: () => false,resolveRowLevelPermissionRecordFilter: () => null,});diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/inherited-through-children-readability-object-records-permissions.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/inherited-through-children-readability-object-records-permissions.integration-spec.tsindex ea2860dffcd..d57e1f1c7f5 100644--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/inherited-through-children-readability-object-records-permissions.integration-spec.ts+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/inherited-through-children-readability-object-records-permissions.integration-spec.ts@@ -429,6 +429,7 @@ describe('inheritedThroughChildrenReadabilityObjectRecordsPermissions', () => {WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,memberRole.id,],+ canAccessAllRecords: false,isOwningApplication: () => false,resolveRowLevelPermissionRecordFilter: () => null,});@@ -649,6 +650,7 @@ describe('inheritedThroughChildrenReadabilityObjectRecordsPermissions', () => {WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,memberRole.id,],+ canAccessAllRecords: false,isOwningApplication: () => false,resolveRowLevelPermissionRecordFilter: () => null,});@@ -815,6 +817,7 @@ describe('inheritedThroughChildrenReadabilityObjectRecordsPermissions', () => {WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,memberRole.id,],+ canAccessAllRecords: false,isOwningApplication: () => false,resolveRowLevelPermissionRecordFilter: () => null,});diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-level-sharing-restricted-record-surfaces.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-level-sharing-restricted-record-surfaces.integration-spec.tsindex 19695172729..d64962e743d 100644--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-level-sharing-restricted-record-surfaces.integration-spec.ts+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-level-sharing-restricted-record-surfaces.integration-spec.ts@@ -350,6 +350,7 @@ describe('A restricted record on an object open by default', () => {WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,memberRole.id,],+ canAccessAllRecords: false,isOwningApplication: () => false,resolveRowLevelPermissionRecordFilter: () => null,});diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-sharing-all-records-access.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-sharing-all-records-access.integration-spec.tsnew file mode 100644index 00000000000..322083244da--- /dev/null+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-sharing-all-records-access.integration-spec.ts@@ -0,0 +1,407 @@+import { randomUUID } from 'node:crypto';++import { parse } from 'graphql';+import {+ FeatureFlagKey,+ FieldMetadataType,+ RecordShareAccessLevel,+ RecordSharePrincipalType,+ RecordShareRowCause,+} from 'twenty-shared/types';++import { createOneOperationFactory } from 'test/integration/graphql/utils/create-one-operation-factory.util';+import { destroyManyOperationFactory } from 'test/integration/graphql/utils/destroy-many-operation-factory.util';+import { findManyOperationFactory } from 'test/integration/graphql/utils/find-many-operation-factory.util';+import { makeGraphqlApiRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';+import { findManyObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata.util';+import { createOneRole } from 'test/integration/metadata/suites/role/utils/create-one-role.util';+import { deleteOneRole } from 'test/integration/metadata/suites/role/utils/delete-one-role.util';+import { findOneRoleByLabel } from 'test/integration/metadata/suites/role/utils/find-one-role-by-label.util';+import { updateOneRole } from 'test/integration/metadata/suites/role/utils/update-one-role.util';+import { updateWorkspaceMemberRole } from 'test/integration/metadata/suites/role/utils/update-workspace-member-role.util';+import { createOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata.util';+import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';+import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';+import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';+import { makeMetadataApiRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';+import { updateFeatureFlag } from 'test/integration/metadata/suites/utils/update-feature-flag.util';+import { getAppProviderByClassName } from 'test/integration/utils/get-app-provider-by-class-name.util';+import { getCoreRepository } from 'test/integration/utils/get-core-repository.util';++import { type RecordSharePrincipalInput } from 'src/engine/core-modules/record-share/dtos/record-sharing.dto';+import { type RecordShareOwnershipTransferService } from 'src/engine/core-modules/record-share/services/record-share-ownership-transfer.service';+import { type RecordShareStorageService } from 'src/engine/core-modules/record-share/services/record-share-storage.service';+import { UserWorkspaceEntity } from 'src/engine/core-modules/user-workspace/user-workspace.entity';+import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';+import { USER_WORKSPACE_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-user-workspaces.util';+import { WORKSPACE_MEMBER_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/workspace-member-data-seeds.constant';++const OBJECT_NAME = 'allRecordsAccessRecord';+const OBJECT_PLURAL = 'allRecordsAccessRecords';+const RESTRICTED_RECORD_ID = randomUUID();+const SHARED_RECORD_ID = randomUUID();+const workspaceId = SEED_APPLE_WORKSPACE_ID;+const EVERYONE = { everyone: true };+const fields =+ 'viewerAccessLevel generalAccessLevel shares { principalId rowCause accessLevel }';+const READ_SHARING = parse(+ `query RecordSharing($target: RecordSharingTargetInput!) { recordSharing(target: $target) { ${fields} } }`,+);+const SET_SHARE = parse(+ `mutation SetShare($target: RecordSharingTargetInput!, $principal: RecordSharePrincipalInput!, $enabled: Boolean!, $accessLevel: RecordShareAccessLevel) { setRecordShare(target: $target, principal: $principal, enabled: $enabled, accessLevel: $accessLevel) { ${fields} } }`,+);++describe('Access to all records and ownership transfer', () => {+ let objectMetadataId: string;+ let shares: RecordShareStorageService;++ const target = (recordId: string) => ({ objectMetadataId, recordId });++ const setRecordSharingEnabled = (value: boolean) =>+ updateFeatureFlag({+ featureFlag: FeatureFlagKey.IS_RECORD_LEVEL_SHARING_ENABLED,+ value,+ expectToFail: false,+ });++ const setShare = ({+ recordId,+ principal,+ enabled,+ accessLevel = RecordShareAccessLevel.READ,+ token,+ }: {+ recordId: string;+ principal: RecordSharePrincipalInput;+ enabled: boolean;+ accessLevel?: RecordShareAccessLevel;+ token: string;+ }) =>+ makeMetadataApiRequest(+ {+ query: SET_SHARE,+ variables: {+ target: target(recordId),+ principal,+ enabled,+ accessLevel,+ },+ },+ token,+ );++ const findRecordIds = async (token: string) => {+ const response = await makeGraphqlApiRequest(+ findManyOperationFactory({+ objectMetadataSingularName: OBJECT_NAME,+ objectMetadataPluralName: OBJECT_PLURAL,+ gqlFields: 'id',+ filter: { id: { in: [RESTRICTED_RECORD_ID, SHARED_RECORD_ID] } },+ }),+ token,+ );++ expect(response.body.errors).toBeUndefined();++ return response.body.data[OBJECT_PLURAL].edges+ .map(({ node }: { node: { id: string } }) => node.id)+ .sort();+ };++ const findMemberGrants = async (workspaceMemberId: string) =>+ (+ await shares.findByRecordIds({+ workspaceId,+ objectMetadataId,+ recordIds: [RESTRICTED_RECORD_ID, SHARED_RECORD_ID],+ })+ )+ .filter(+ (share) =>+ share.principalType === RecordSharePrincipalType.WORKSPACE_MEMBER &&+ share.principalId === workspaceMemberId,+ )+ .map(({ recordId, accessLevel, rowCause }) => ({+ recordId,+ accessLevel,+ rowCause,+ }));++ beforeAll(async () => {+ shares = getAppProviderByClassName<RecordShareStorageService>(+ 'RecordShareStorageService',+ );+ const { data } = await createOneObjectMetadata({+ input: {+ nameSingular: OBJECT_NAME,+ namePlural: OBJECT_PLURAL,+ labelSingular: 'All records access record',+ labelPlural: 'All records access records',+ icon: 'IconShare',+ isLabelSyncedWithName: false,+ },+ });++ objectMetadataId = data.createOneObject.id;+ await createOneFieldMetadata({+ input: {+ name: 'name',+ label: 'Name',+ type: FieldMetadataType.TEXT,+ objectMetadataId,+ isLabelSyncedWithName: false,+ },+ });+ await setRecordSharingEnabled(true);+ });++ beforeEach(async () => {+ await shares.deleteByRecordIds({+ workspaceId,+ objectMetadataId,+ recordIds: [RESTRICTED_RECORD_ID, SHARED_RECORD_ID],+ });+ await makeGraphqlApiRequest(+ destroyManyOperationFactory({+ objectMetadataSingularName: OBJECT_NAME,+ objectMetadataPluralName: OBJECT_PLURAL,+ gqlFields: 'id',+ filter: { id: { in: [RESTRICTED_RECORD_ID, SHARED_RECORD_ID] } },+ }),+ );++ for (const recordId of [RESTRICTED_RECORD_ID, SHARED_RECORD_ID]) {+ const created = await makeGraphqlApiRequest(+ createOneOperationFactory({+ objectMetadataSingularName: OBJECT_NAME,+ gqlFields: 'id',+ data: { id: recordId, name: 'Created by Jony' },+ }),+ APPLE_JONY_MEMBER_ACCESS_TOKEN,+ );++ expect(created.body.errors).toBeUndefined();++ const restricted = await setShare({+ recordId,+ principal: EVERYONE,+ enabled: false,+ token: APPLE_JONY_MEMBER_ACCESS_TOKEN,+ });++ expect(restricted.body.errors).toBeUndefined();+ }+ });++ afterAll(async () => {+ await setRecordSharingEnabled(false);+ await shares.deleteByRecordIds({+ workspaceId,+ objectMetadataId,+ recordIds: [RESTRICTED_RECORD_ID, SHARED_RECORD_ID],+ });+ await updateOneObjectMetadata({+ input: {+ idToUpdate: objectMetadataId,+ updatePayload: { isActive: false },+ },+ expectToFail: false,+ });+ await deleteOneObjectMetadata({ input: { idToDelete: objectMetadataId } });+ });++ it('should show restricted records to admins and no one else', async () => {+ expect(await findRecordIds(APPLE_JANE_ADMIN_ACCESS_TOKEN)).toEqual(+ [RESTRICTED_RECORD_ID, SHARED_RECORD_ID].sort(),+ );+ expect(await findRecordIds(APPLE_PHIL_GUEST_ACCESS_TOKEN)).toEqual([]);+ });++ it('should let admins manage access to restricted records', async () => {+ const sharing = await makeMetadataApiRequest(+ {+ query: READ_SHARING,+ variables: { target: target(RESTRICTED_RECORD_ID) },+ },+ APPLE_JANE_ADMIN_ACCESS_TOKEN,+ );++ expect(sharing.body.errors).toBeUndefined();+ expect(sharing.body.data.recordSharing.viewerAccessLevel).toBe(+ RecordShareAccessLevel.FULL,+ );++ const shared = await setShare({+ recordId: RESTRICTED_RECORD_ID,+ principal: { workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL },+ enabled: true,+ token: APPLE_JANE_ADMIN_ACCESS_TOKEN,+ });++ expect(shared.body.errors).toBeUndefined();+ expect(await findRecordIds(APPLE_PHIL_GUEST_ACCESS_TOKEN)).toEqual([+ RESTRICTED_RECORD_ID,+ ]);+ });++ it('should show restricted records to any role that can update all settings', async () => {+ const guestRoleId = (await findOneRoleByLabel({ label: 'Guest' })).id;+ const { data } = await createOneRole({+ expectToFail: false,+ input: {+ label: `Restricted records auditor ${randomUUID()}`,+ canUpdateAllSettings: false,+ canAccessAllTools: false,+ canReadAllObjectRecords: true,+ canUpdateAllObjectRecords: false,+ canSoftDeleteAllObjectRecords: false,+ canDestroyAllObjectRecords: false,+ },+ });+ const auditorRoleId = data.createOneRole.id;+ const assignRoleToPhil = (roleId: string) =>+ updateWorkspaceMemberRole({+ expectToFail: false,+ input: {+ workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL,+ roleId,+ },+ });++ try {+ await assignRoleToPhil(auditorRoleId);+ expect(await findRecordIds(APPLE_PHIL_GUEST_ACCESS_TOKEN)).toEqual([]);++ await updateOneRole({+ expectToFail: false,+ input: {+ idToUpdate: auditorRoleId,+ updatePayload: { canUpdateAllSettings: true },+ },+ });+ expect(await findRecordIds(APPLE_PHIL_GUEST_ACCESS_TOKEN)).toEqual(+ [RESTRICTED_RECORD_ID, SHARED_RECORD_ID].sort(),+ );+ } finally {+ try {+ await assignRoleToPhil(guestRoleId);+ } finally {+ await deleteOneRole({+ expectToFail: false,+ input: { idToDelete: auditorRoleId },+ });+ }+ }+ });++ it('should lift restrictions for everyone while record sharing is off', async () => {+ await setRecordSharingEnabled(false);++ try {+ expect(await findRecordIds(APPLE_PHIL_GUEST_ACCESS_TOKEN)).toEqual(+ [RESTRICTED_RECORD_ID, SHARED_RECORD_ID].sort(),+ );+ } finally {+ await setRecordSharingEnabled(true);+ }+ });++ it('should hand the records a removed member managed to the custodian', async () => {+ await setShare({+ recordId: SHARED_RECORD_ID,+ principal: { workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL },+ enabled: true,+ accessLevel: RecordShareAccessLevel.FULL,+ token: APPLE_JONY_MEMBER_ACCESS_TOKEN,+ });+ await setShare({+ recordId: RESTRICTED_RECORD_ID,+ principal: { workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL },+ enabled: true,+ token: APPLE_JONY_MEMBER_ACCESS_TOKEN,+ });+ await setShare({+ recordId: SHARED_RECORD_ID,+ principal: { workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.JANE },+ enabled: true,+ token: APPLE_JONY_MEMBER_ACCESS_TOKEN,+ });++ const { objects } = await findManyObjectMetadata({+ expectToFail: false,+ input: { filter: {}, paging: { first: 1000 } },+ gqlFields: 'id nameSingular',+ });+ const chatThreadObjectMetadataId = objects.find(+ (object) => object.nameSingular === 'agentChatThread',+ )!.id;+ const privateChatThreadId = randomUUID();++ await shares.insertMany({+ workspaceId,+ recordShares: [+ {+ objectMetadataId: chatThreadObjectMetadataId,+ recordId: privateChatThreadId,+ principalType: RecordSharePrincipalType.WORKSPACE_MEMBER,+ principalId: WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL,+ accessLevel: RecordShareAccessLevel.FULL,+ rowCause: RecordShareRowCause.OWNER,+ sourceId: privateChatThreadId,+ },+ ],+ });++ try {+ await getAppProviderByClassName<RecordShareOwnershipTransferService>(+ 'RecordShareOwnershipTransferService',+ ).transferRecordSharesToCustodian({+ removedUserWorkspace: await getCoreRepository<UserWorkspaceEntity>(+ UserWorkspaceEntity,+ ).findOneByOrFail({ id: USER_WORKSPACE_DATA_SEED_IDS.PHIL }),+ removedWorkspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL,+ actingUserWorkspaceId: USER_WORKSPACE_DATA_SEED_IDS.JANE,+ });++ expect(+ await findMemberGrants(WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL),+ ).toEqual([]);+ expect(+ await findMemberGrants(WORKSPACE_MEMBER_DATA_SEED_IDS.JANE),+ ).toEqual([+ {+ recordId: SHARED_RECORD_ID,+ accessLevel: RecordShareAccessLevel.FULL,+ rowCause: RecordShareRowCause.MANUAL,+ },+ ]);+ expect(+ await findMemberGrants(WORKSPACE_MEMBER_DATA_SEED_IDS.JONY),+ ).toEqual(+ expect.arrayContaining([+ {+ recordId: RESTRICTED_RECORD_ID,+ accessLevel: RecordShareAccessLevel.FULL,+ rowCause: RecordShareRowCause.OWNER,+ },+ ]),+ );++ const chatThreadShares = await shares.findByRecordIds({+ workspaceId,+ objectMetadataId: chatThreadObjectMetadataId,+ recordIds: [privateChatThreadId],+ });++ expect(chatThreadShares.map(({ principalId }) => principalId)).toEqual([+ WORKSPACE_MEMBER_DATA_SEED_IDS.PHIL,+ ]);+ } finally {+ await shares.deleteByRecordIds({+ workspaceId,+ objectMetadataId: chatThreadObjectMetadataId,+ recordIds: [privateChatThreadId],+ });+ }+ });+});diff --git a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-sharing-beyond-role.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-sharing-beyond-role.integration-spec.tsindex 51d4a6b5cb5..8b3da7c8eaa 100644--- a/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-sharing-beyond-role.integration-spec.ts+++ b/packages/twenty-server/test/integration/graphql/suites/object-records-permissions/record-sharing-beyond-role.integration-spec.ts@@ -480,6 +480,7 @@ describe('Records shared beyond the role that can access their object', () => {WORKSPACE_MEMBER_DATA_SEED_IDS.JONY,memberRoleId,],+ canAccessAllRecords: false,isOwningApplication: () => false,resolveRowLevelPermissionRecordFilter: () => null,});