The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Remove message and calendar target read rollout flag (#26625)
Félix Malfaitbadeb684ed91
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql b/packages/twenty-client-sdk/src/metadata/generated/schema.graphqlindex 393e3fe3a2c..256f21538c5 100644--- a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql@@ -2059,7 +2059,6 @@ enum FeatureFlagKey {IS_REST_METADATA_API_NEW_FORMAT_DIRECTIS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLEDIS_WORKFLOW_CORE_INDEX_PAGE_ENABLED- IS_MESSAGE_CALENDAR_TARGET_READ_ENABLEDIS_RECORD_SHARING_ENABLEDIS_AI_CHAT_SHARING_DROPDOWN_ENABLEDIS_INITIAL_OBJECT_VIEW_ENABLEDdiff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.ts b/packages/twenty-client-sdk/src/metadata/generated/schema.tsindex 64f6d2a706a..ba758d3d5eb 100644--- a/packages/twenty-client-sdk/src/metadata/generated/schema.ts+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.ts@@ -1669,7 +1669,7 @@ export interface FeatureFlag {__typename: 'FeatureFlag'}-export type FeatureFlagKey = 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_UNIQUE_INDEXES_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_JUNCTION_RELATIONS_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT' | 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED' | 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED' | 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED' | 'IS_RECORD_SHARING_ENABLED' | 'IS_AI_CHAT_SHARING_DROPDOWN_ENABLED' | 'IS_INITIAL_OBJECT_VIEW_ENABLED' | 'IS_WEBHOOK_RATE_LIMIT_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_EXECUTION_QUOTA_ENABLED' | 'IS_RECORD_CREATION_FORM_ENABLED'+export type FeatureFlagKey = 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_UNIQUE_INDEXES_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_JUNCTION_RELATIONS_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT' | 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED' | 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED' | 'IS_RECORD_SHARING_ENABLED' | 'IS_AI_CHAT_SHARING_DROPDOWN_ENABLED' | 'IS_INITIAL_OBJECT_VIEW_ENABLED' | 'IS_WEBHOOK_RATE_LIMIT_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_EXECUTION_QUOTA_ENABLED' | 'IS_RECORD_CREATION_FORM_ENABLED'export interface WorkspaceUrls {customUrl?: Scalars['String']@@ -11202,7 +11202,6 @@ export const enumFeatureFlagKey = {IS_REST_METADATA_API_NEW_FORMAT_DIRECT: 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT' as const,IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED: 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED' as const,IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED: 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED' as const,- IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED: 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED' as const,IS_RECORD_SHARING_ENABLED: 'IS_RECORD_SHARING_ENABLED' as const,IS_AI_CHAT_SHARING_DROPDOWN_ENABLED: 'IS_AI_CHAT_SHARING_DROPDOWN_ENABLED' as const,IS_INITIAL_OBJECT_VIEW_ENABLED: 'IS_INITIAL_OBJECT_VIEW_ENABLED' as const,diff --git a/packages/twenty-front/src/generated-admin/graphql.ts b/packages/twenty-front/src/generated-admin/graphql.tsindex 653a06f4964..399fed76113 100644--- a/packages/twenty-front/src/generated-admin/graphql.ts+++ b/packages/twenty-front/src/generated-admin/graphql.ts@@ -484,7 +484,6 @@ export enum FeatureFlagKey {IS_JSON_FILTER_ENABLED = 'IS_JSON_FILTER_ENABLED',IS_JUNCTION_RELATIONS_ENABLED = 'IS_JUNCTION_RELATIONS_ENABLED',IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED = 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED',- IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED = 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED',IS_MESSAGE_CAMPAIGN_ENABLED = 'IS_MESSAGE_CAMPAIGN_ENABLED',IS_RECORD_CREATION_FORM_ENABLED = 'IS_RECORD_CREATION_FORM_ENABLED',IS_RECORD_SHARING_ENABLED = 'IS_RECORD_SHARING_ENABLED',diff --git a/packages/twenty-front/src/generated-metadata/graphql.ts b/packages/twenty-front/src/generated-metadata/graphql.tsindex 0cbb121f641..0f6463cbbee 100644--- a/packages/twenty-front/src/generated-metadata/graphql.ts+++ b/packages/twenty-front/src/generated-metadata/graphql.ts@@ -2116,7 +2116,6 @@ export enum FeatureFlagKey {IS_JSON_FILTER_ENABLED = 'IS_JSON_FILTER_ENABLED',IS_JUNCTION_RELATIONS_ENABLED = 'IS_JUNCTION_RELATIONS_ENABLED',IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED = 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED',- IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED = 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED',IS_MESSAGE_CAMPAIGN_ENABLED = 'IS_MESSAGE_CAMPAIGN_ENABLED',IS_RECORD_CREATION_FORM_ENABLED = 'IS_RECORD_CREATION_FORM_ENABLED',IS_RECORD_SHARING_ENABLED = 'IS_RECORD_SHARING_ENABLED',diff --git a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.tsindex aa05a0d67d6..dfc04ec1b14 100644--- a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts+++ b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts@@ -42,10 +42,6 @@ export const SETTINGS_ADMIN_FEATURE_FLAG_METADATA: Partial<label: msg`Workflow index page`,description: msg`Use the dedicated workflow index page to browse workflows and their versions.`,},- [FeatureFlagKey.IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED]: {- label: msg`Message and calendar target reads`,- description: msg`Use target relations to find messages and calendar events linked to records.`,- },[FeatureFlagKey.IS_RECORD_SHARING_ENABLED]: {label: msg`Record sharing`,description: msg`Allow sharing individual records with workspace members.`,diff --git a/packages/twenty-server/src/engine/core-modules/target/services/__tests__/message-calendar-target-readiness.service.spec.ts b/packages/twenty-server/src/engine/core-modules/target/services/__tests__/message-calendar-target-readiness.service.spec.tsnew file mode 100644index 00000000000..26ebcc4e5ad--- /dev/null+++ b/packages/twenty-server/src/engine/core-modules/target/services/__tests__/message-calendar-target-readiness.service.spec.ts@@ -0,0 +1,86 @@+import { Test } from '@nestjs/testing';++import { STANDARD_OBJECTS } from 'twenty-shared/metadata';++import { MessageCalendarTargetReadinessService } from 'src/engine/core-modules/target/services/message-calendar-target-readiness.service';+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';++const WORKSPACE_ID = '20202020-1c25-4d02-bf25-6aeccf7ea419';+const RECORD_ID = '20202020-9b8b-4d9b-a555-9ca96a4fccb1';+const TARGET_OBJECT_IDENTIFIERS = [+ STANDARD_OBJECTS.messageThreadTarget.universalIdentifier,+ STANDARD_OBJECTS.calendarEventTarget.universalIdentifier,+];++describe('MessageCalendarTargetReadinessService', () => {+ let service: MessageCalendarTargetReadinessService;+ const getOrRecompute = jest.fn();++ const setAvailableTargetObjects = (universalIdentifiers: string[]) => {+ getOrRecompute.mockResolvedValue({+ flatObjectMetadataMaps: {+ byUniversalIdentifier: Object.fromEntries(+ universalIdentifiers.map((universalIdentifier) => [+ universalIdentifier,+ { universalIdentifier },+ ]),+ ),+ },+ });+ };++ beforeEach(async () => {+ const module = await Test.createTestingModule({+ providers: [+ MessageCalendarTargetReadinessService,+ { provide: WorkspaceCacheService, useValue: { getOrRecompute } },+ ],+ }).compile();++ service = module.get(MessageCalendarTargetReadinessService);+ setAvailableTargetObjects(TARGET_OBJECT_IDENTIFIERS);+ });++ it.each([+ ['person', 'targetPersonId'],+ ['company', 'targetCompanyId'],+ ['opportunity', 'targetOpportunityId'],+ ])(+ 'uses target reads for %s without a feature flag',+ async (objectNameSingular, fieldName) => {+ await expect(+ service.resolveTargetFilter({+ objectNameSingular,+ recordId: RECORD_ID,+ workspaceId: WORKSPACE_ID,+ }),+ ).resolves.toEqual({ fieldName, recordId: RECORD_ID });+ },+ );++ it.each([+ { name: 'both objects are missing', universalIdentifiers: [] },+ {+ name: 'calendar targets are missing',+ universalIdentifiers: [TARGET_OBJECT_IDENTIFIERS[0]],+ },+ {+ name: 'message targets are missing',+ universalIdentifiers: [TARGET_OBJECT_IDENTIFIERS[1]],+ },+ ])('retains legacy reads when $name', async ({ universalIdentifiers }) => {+ setAvailableTargetObjects(universalIdentifiers);++ await expect(service.isReady(WORKSPACE_ID)).resolves.toBe(false);+ });++ it('retains the related-person fallback for custom objects', async () => {+ await expect(+ service.resolveTargetFilter({+ objectNameSingular: 'pet',+ recordId: RECORD_ID,+ workspaceId: WORKSPACE_ID,+ }),+ ).resolves.toBeUndefined();+ });+});diff --git a/packages/twenty-server/src/engine/core-modules/target/services/message-calendar-target-readiness.service.ts b/packages/twenty-server/src/engine/core-modules/target/services/message-calendar-target-readiness.service.tsindex 3b5963ffe67..228fe948315 100644--- a/packages/twenty-server/src/engine/core-modules/target/services/message-calendar-target-readiness.service.ts+++ b/packages/twenty-server/src/engine/core-modules/target/services/message-calendar-target-readiness.service.ts@@ -1,10 +1,8 @@import { Injectable } from '@nestjs/common';import { STANDARD_OBJECTS } from 'twenty-shared/metadata';-import { FeatureFlagKey } from 'twenty-shared/types';import { isDefined } from 'twenty-shared/utils';-import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';import {getTargetFieldNameForObjectRecord,type TargetFilter,@@ -13,10 +11,7 @@ import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/works@Injectable()export class MessageCalendarTargetReadinessService {- constructor(- private readonly featureFlagService: FeatureFlagService,- private readonly workspaceCacheService: WorkspaceCacheService,- ) {}+ constructor(private readonly workspaceCacheService: WorkspaceCacheService) {}async resolveTargetFilter({objectNameSingular,@@ -37,17 +32,8 @@ export class MessageCalendarTargetReadinessService {}async isReady(workspaceId: string): Promise<boolean> {- const isReadEnabled = await this.featureFlagService.isFeatureEnabled(- FeatureFlagKey.IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED,- workspaceId,- );-- if (!isReadEnabled) {- return false;- }-- // A premature flag flip on a workspace whose metadata sync has not run- // must degrade to legacy reads, not break the timeline relation join.+ // During workspace upgrades the target objects may not exist yet;+ // retain legacy reads until metadata sync creates both junctions.const { flatObjectMetadataMaps } =await this.workspaceCacheService.getOrRecompute(workspaceId, ['flatObjectMetadataMaps',diff --git a/packages/twenty-server/src/engine/core-modules/target/target.module.ts b/packages/twenty-server/src/engine/core-modules/target/target.module.tsindex 06bf7b7f6ef..7c0242f977a 100644--- a/packages/twenty-server/src/engine/core-modules/target/target.module.ts+++ b/packages/twenty-server/src/engine/core-modules/target/target.module.ts@@ -1,11 +1,10 @@import { Module } from '@nestjs/common';-import { FeatureFlagModule } from 'src/engine/core-modules/feature-flag/feature-flag.module';import { MessageCalendarTargetReadinessService } from 'src/engine/core-modules/target/services/message-calendar-target-readiness.service';import { WorkspaceCacheModule } from 'src/engine/workspace-cache/workspace-cache.module';@Module({- imports: [FeatureFlagModule, WorkspaceCacheModule],+ imports: [WorkspaceCacheModule],providers: [MessageCalendarTargetReadinessService],exports: [MessageCalendarTargetReadinessService],})diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.tsindex 867fffab05a..8860f893a2b 100644--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts@@ -6,7 +6,6 @@ const tableName = 'featureFlag';const DEFAULT_SEEDED_FEATURE_FLAGS: Partial<Record<FeatureFlagKey, boolean>> = {[FeatureFlagKey.IS_UNIQUE_INDEXES_ENABLED]: false,[FeatureFlagKey.IS_JUNCTION_RELATIONS_ENABLED]: true,- [FeatureFlagKey.IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED]: true,[FeatureFlagKey.IS_MESSAGE_CAMPAIGN_ENABLED]: true,[FeatureFlagKey.IS_RECORD_SHARING_ENABLED]: true,[FeatureFlagKey.IS_AI_CHAT_SHARING_DROPDOWN_ENABLED]: false,diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-calendar-target-data-seeds.constant.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-calendar-target-data-seeds.constant.tsindex 32237196460..15aa931e4bc 100644--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-calendar-target-data-seeds.constant.ts+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/constants/message-calendar-target-data-seeds.constant.ts@@ -6,12 +6,8 @@ import { type MessageParticipantDataSeed } from 'src/engine/workspace-manager/deimport { OPPORTUNITY_DATA_SEEDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/opportunity-data-seeds.constant';import { PERSON_DATA_SEEDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/person-data-seeds.constant';-// Timeline reads resolve through the target junctions once-// IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED is on, and reconciliation only runs-// on sync paths, so seeded workspaces must seed the rows reconciliation would-// have produced: per parent, a Person target for each participant person, a-// Company target for each of their companies, and an Opportunity target for-// each opportunity they are the point of contact of.+// Raw seeds bypass participant reconciliation, so seeded timelines need the+// person, company, and point-of-contact opportunity targets it would create.type TargetColumnsDataSeed = {targetPersonId: string | null;diff --git a/packages/twenty-server/test/integration/graphql/suites/timeline-from-object-record.integration-spec.ts b/packages/twenty-server/test/integration/graphql/suites/timeline-from-object-record.integration-spec.tsindex da5451000d7..a12218de277 100644--- a/packages/twenty-server/test/integration/graphql/suites/timeline-from-object-record.integration-spec.ts+++ b/packages/twenty-server/test/integration/graphql/suites/timeline-from-object-record.integration-spec.ts@@ -7,8 +7,6 @@ import { makeGraphqlApiRequest } from 'test/integration/graphql/utils/make-graphimport { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';-import { updateFeatureFlag } from 'test/integration/metadata/suites/utils/update-feature-flag.util';-import { FeatureFlagKey } from 'twenty-shared/types';const PAGE_SIZE = 50;@@ -209,12 +207,6 @@ describe('timeline from object record resolvers (integration)', () => {let personWithEvents: { id: string; companyId: string };beforeAll(async () => {- await updateFeatureFlag({- featureFlag: FeatureFlagKey.IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED,- value: true,- expectToFail: false,- });-await createTimelineRecord('company', {id: TIMELINE_COMPANY_ID,name: 'Timeline Source Company',diff --git a/packages/twenty-shared/src/types/FeatureFlagKey.ts b/packages/twenty-shared/src/types/FeatureFlagKey.tsindex d7e853748d6..86870f0c2ea 100644--- a/packages/twenty-shared/src/types/FeatureFlagKey.ts+++ b/packages/twenty-shared/src/types/FeatureFlagKey.ts@@ -8,7 +8,6 @@ export enum FeatureFlagKey {IS_REST_METADATA_API_NEW_FORMAT_DIRECT = 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT',IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED = 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED',IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED = 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED',- IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED = 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED',IS_RECORD_SHARING_ENABLED = 'IS_RECORD_SHARING_ENABLED',IS_AI_CHAT_SHARING_DROPDOWN_ENABLED = 'IS_AI_CHAT_SHARING_DROPDOWN_ENABLED',IS_INITIAL_OBJECT_VIEW_ENABLED = 'IS_INITIAL_OBJECT_VIEW_ENABLED',