Skip to content

The open alternative to Salesforce, designed for AI.

Only offer Export records on index pages (#27017)

Félix Malfaitc15ab57b7c03
diff --git a/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts b/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts
index 21408e9b063..b9b6073720f 100644
--- a/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts
+++ b/packages/twenty-front/src/testing/mock-data/generated/metadata/command-menu-items/mock-command-menu-items-data.ts
@@ -216,7 +216,7 @@ export const mockedCommandMenuItems: CommandMenuItemFieldsFragment[] =
"isPinned": false,
"payload": null,
"hotKeys": null,
- "conditionalAvailabilityExpression": "permissionFlags.EXPORT_CSV",
+ "conditionalAvailabilityExpression": "pageType == \"INDEX_PAGE\" and permissionFlags.EXPORT_CSV",
"availabilityType": "RECORD_SELECTION",
"availabilityObjectMetadataId": null,
"pageLayoutId": null,
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/2-45-upgrade-version-command.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/2-45-upgrade-version-command.module.ts
new file mode 100644
index 00000000000..21789bae4e0
--- /dev/null
+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/2-45-upgrade-version-command.module.ts
@@ -0,0 +1,16 @@
+import { Module } from '@nestjs/common';
+
+import { WorkspaceIteratorModule } from 'src/database/commands/command-runners/workspace-iterator.module';
+import { RestrictExportRecordsToIndexPageCommand } from 'src/database/commands/upgrade-version-command/2-45/2-45-workspace-command-1790837443029-restrict-export-records-to-index-page.command';
+import { WorkspaceCacheModule } from 'src/engine/workspace-cache/workspace-cache.module';
+import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspace-migration/workspace-migration.module';
+
+@Module({
+ imports: [
+ WorkspaceCacheModule,
+ WorkspaceIteratorModule,
+ WorkspaceMigrationModule,
+ ],
+ providers: [RestrictExportRecordsToIndexPageCommand],
+})
+export class V2_45_UpgradeVersionCommandModule {}
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/2-45-workspace-command-1790837443029-restrict-export-records-to-index-page.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/2-45-workspace-command-1790837443029-restrict-export-records-to-index-page.command.ts
new file mode 100644
index 00000000000..ac74284a885
--- /dev/null
+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/2-45-workspace-command-1790837443029-restrict-export-records-to-index-page.command.ts
@@ -0,0 +1,90 @@
+import { Command } from 'nest-commander';
+import { TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER } from 'twenty-shared/application';
+import { isNonEmptyArray } from 'twenty-shared/utils';
+
+import { ProvisionedWorkspaceCommandRunner } from 'src/database/commands/command-runners/provisioned-workspace.command-runner';
+import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';
+import { type RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspace.command-runner';
+import { buildExportRecordsAvailabilityUpdate } from 'src/database/commands/upgrade-version-command/2-45/utils/build-export-records-availability-update.util';
+import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';
+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';
+import { WorkspaceMigrationBuilderException } from 'src/engine/workspace-manager/workspace-migration/exceptions/workspace-migration-builder-exception';
+import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';
+
+@RegisteredWorkspaceCommand('2.45.0', 1790837443029)
+@Command({
+ name: 'upgrade:2-45:restrict-export-records-to-index-page',
+ description:
+ 'Only offer the Export records command on index pages, not on record pages',
+})
+export class RestrictExportRecordsToIndexPageCommand extends ProvisionedWorkspaceCommandRunner {
+ constructor(
+ protected readonly workspaceIteratorService: WorkspaceIteratorService,
+ private readonly workspaceCacheService: WorkspaceCacheService,
+ private readonly workspaceMigrationValidateBuildAndRunService: WorkspaceMigrationValidateBuildAndRunService,
+ ) {
+ super(workspaceIteratorService);
+ }
+
+ override async runOnWorkspace(args: RunOnWorkspaceArgs): Promise<void> {
+ await this.up(args);
+ }
+
+ async up(args: RunOnWorkspaceArgs): Promise<void> {
+ await this.syncAvailability(args, 'up');
+ }
+
+ async down(args: RunOnWorkspaceArgs): Promise<void> {
+ await this.syncAvailability(args, 'down');
+ }
+
+ private async syncAvailability(
+ { workspaceId, options }: RunOnWorkspaceArgs,
+ direction: 'up' | 'down',
+ ): Promise<void> {
+ const { flatCommandMenuItemMaps } =
+ await this.workspaceCacheService.getOrRecompute(workspaceId, [
+ 'flatCommandMenuItemMaps',
+ ]);
+
+ const commandMenuItemsToUpdate = buildExportRecordsAvailabilityUpdate({
+ flatCommandMenuItemsByUniversalIdentifier:
+ flatCommandMenuItemMaps.byUniversalIdentifier,
+ now: new Date().toISOString(),
+ direction,
+ });
+
+ if (!isNonEmptyArray(commandMenuItemsToUpdate)) {
+ return;
+ }
+
+ this.logger.log(
+ `${options.dryRun ? '[DRY RUN] ' : ''}Workspace ${workspaceId}: updating the Export records command menu item`,
+ );
+
+ if (options.dryRun) {
+ return;
+ }
+
+ const result =
+ await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunLegacyWorkspaceMigration(
+ {
+ workspaceId,
+ isSystemBuild: true,
+ applicationUniversalIdentifier:
+ TWENTY_STANDARD_APPLICATION_UNIVERSAL_IDENTIFIER,
+ allFlatEntityOperationByMetadataName: {
+ commandMenuItem: {
+ flatEntityToCreate: [],
+ flatEntityToDelete: [],
+ flatEntityToUpdate: commandMenuItemsToUpdate,
+ },
+ },
+ },
+ );
+
+ if (result.status === 'fail') {
+ throw new WorkspaceMigrationBuilderException(result);
+ }
+ }
+}
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/utils/__tests__/build-export-records-availability-update.util.spec.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/utils/__tests__/build-export-records-availability-update.util.spec.ts
new file mode 100644
index 00000000000..40c6f160ee4
--- /dev/null
+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/utils/__tests__/build-export-records-availability-update.util.spec.ts
@@ -0,0 +1,96 @@
+import { isDefined } from 'twenty-shared/utils';
+
+import { buildExportRecordsAvailabilityUpdate } from 'src/database/commands/upgrade-version-command/2-45/utils/build-export-records-availability-update.util';
+import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';
+import { computeTwentyStandardApplicationAllFlatEntityMaps } from 'src/engine/workspace-manager/twenty-standard-application/utils/twenty-standard-application-all-flat-entity-maps.constant';
+
+const NOW = '2026-10-01T12:00:00.000Z';
+const EXPORT_RECORDS_UNIVERSAL_IDENTIFIER =
+ 'c6f5c54d-d52b-4e75-8188-2190d77126f2';
+const PREVIOUS_EXPRESSION = 'permissionFlags.EXPORT_CSV';
+const NEXT_EXPRESSION =
+ 'pageType == "INDEX_PAGE" and permissionFlags.EXPORT_CSV';
+
+const { allFlatEntityMaps } = computeTwentyStandardApplicationAllFlatEntityMaps(
+ {
+ now: '2026-09-30T12:00:00.000Z',
+ workspaceId: '20202020-1111-4111-8111-111111111111',
+ twentyStandardApplicationId: '20202020-2222-4222-8222-222222222222',
+ },
+);
+
+const buildExportRecords = (
+ conditionalAvailabilityExpression: string,
+): FlatCommandMenuItem => {
+ const exportRecords =
+ allFlatEntityMaps.flatCommandMenuItemMaps.byUniversalIdentifier[
+ EXPORT_RECORDS_UNIVERSAL_IDENTIFIER
+ ];
+
+ if (!isDefined(exportRecords)) {
+ throw new Error('Standard Export records command menu item missing');
+ }
+
+ return { ...exportRecords, conditionalAvailabilityExpression };
+};
+
+const buildUpdate = (
+ exportRecords: FlatCommandMenuItem,
+ direction: 'up' | 'down',
+) =>
+ buildExportRecordsAvailabilityUpdate({
+ flatCommandMenuItemsByUniversalIdentifier: {
+ [EXPORT_RECORDS_UNIVERSAL_IDENTIFIER]: exportRecords,
+ },
+ now: NOW,
+ direction,
+ });
+
+describe('buildExportRecordsAvailabilityUpdate', () => {
+ it('matches the standard application expression', () => {
+ expect(
+ allFlatEntityMaps.flatCommandMenuItemMaps.byUniversalIdentifier[
+ EXPORT_RECORDS_UNIVERSAL_IDENTIFIER
+ ]?.conditionalAvailabilityExpression,
+ ).toBe(NEXT_EXPRESSION);
+ });
+
+ it('restricts Export to the index page on up', () => {
+ const exportRecords = buildExportRecords(PREVIOUS_EXPRESSION);
+
+ expect(buildUpdate(exportRecords, 'up')).toEqual([
+ {
+ ...exportRecords,
+ conditionalAvailabilityExpression: NEXT_EXPRESSION,
+ updatedAt: NOW,
+ },
+ ]);
+ });
+
+ it('restores the previous expression on down', () => {
+ const exportRecords = buildExportRecords(NEXT_EXPRESSION);
+
+ expect(buildUpdate(exportRecords, 'down')).toEqual([
+ {
+ ...exportRecords,
+ conditionalAvailabilityExpression: PREVIOUS_EXPRESSION,
+ updatedAt: NOW,
+ },
+ ]);
+ });
+
+ it('skips items already migrated or carrying another expression', () => {
+ expect(buildUpdate(buildExportRecords(NEXT_EXPRESSION), 'up')).toEqual([]);
+ expect(buildUpdate(buildExportRecords('isInSidePanel'), 'up')).toEqual([]);
+ });
+
+ it('skips workspaces without the item', () => {
+ expect(
+ buildExportRecordsAvailabilityUpdate({
+ flatCommandMenuItemsByUniversalIdentifier: {},
+ now: NOW,
+ direction: 'up',
+ }),
+ ).toEqual([]);
+ });
+});
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/utils/build-export-records-availability-update.util.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/utils/build-export-records-availability-update.util.ts
new file mode 100644
index 00000000000..6b7ceb19ff5
--- /dev/null
+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-45/utils/build-export-records-availability-update.util.ts
@@ -0,0 +1,49 @@
+import { isDefined } from 'twenty-shared/utils';
+
+import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';
+
+const EXPORT_RECORDS_UNIVERSAL_IDENTIFIER =
+ 'c6f5c54d-d52b-4e75-8188-2190d77126f2';
+
+const PREVIOUS_EXPORT_RECORDS_EXPRESSION = 'permissionFlags.EXPORT_CSV';
+
+const NEXT_EXPORT_RECORDS_EXPRESSION =
+ 'pageType == "INDEX_PAGE" and permissionFlags.EXPORT_CSV';
+
+export const buildExportRecordsAvailabilityUpdate = ({
+ flatCommandMenuItemsByUniversalIdentifier,
+ now,
+ direction,
+}: {
+ flatCommandMenuItemsByUniversalIdentifier: Record<
+ string,
+ FlatCommandMenuItem | undefined
+ >;
+ now: string;
+ direction: 'up' | 'down';
+}): FlatCommandMenuItem[] => {
+ const exportRecords =
+ flatCommandMenuItemsByUniversalIdentifier[
+ EXPORT_RECORDS_UNIVERSAL_IDENTIFIER
+ ];
+
+ const [fromExpression, toExpression] =
+ direction === 'up'
+ ? [PREVIOUS_EXPORT_RECORDS_EXPRESSION, NEXT_EXPORT_RECORDS_EXPRESSION]
+ : [NEXT_EXPORT_RECORDS_EXPRESSION, PREVIOUS_EXPORT_RECORDS_EXPRESSION];
+
+ if (
+ !isDefined(exportRecords) ||
+ exportRecords.conditionalAvailabilityExpression !== fromExpression
+ ) {
+ return [];
+ }
+
+ return [
+ {
+ ...exportRecords,
+ conditionalAvailabilityExpression: toExpression,
+ updatedAt: now,
+ },
+ ];
+};
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts
index fbe8829e48b..84cca9fad73 100644
--- a/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts
+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-command-provider.module.ts
@@ -37,6 +37,7 @@ import { V2_40_UpgradeVersionCommandModule } from 'src/database/commands/upgrade
import { V2_41_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-41/2-41-upgrade-version-command.module';
import { V2_42_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-42/2-42-upgrade-version-command.module';
import { V2_44_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-44/2-44-upgrade-version-command.module';
+import { V2_45_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-45/2-45-upgrade-version-command.module';
import { V2_4_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-4/2-4-upgrade-version-command.module';
import { V2_5_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-5/2-5-upgrade-version-command.module';
import { V2_7_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-version-command/2-7/2-7-upgrade-version-command.module';
@@ -87,6 +88,7 @@ import { V2_9_UpgradeVersionCommandModule } from 'src/database/commands/upgrade-
V2_42_UpgradeVersionCommandModule,
V2_43_UpgradeVersionCommandModule,
V2_44_UpgradeVersionCommandModule,
+ V2_45_UpgradeVersionCommandModule,
],
})
export class WorkspaceCommandProviderModule {}
diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts
index a242645c9db..9e9f1526bd4 100644
--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts
+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts
@@ -209,7 +209,8 @@ export const STANDARD_COMMAND_MENU_ITEMS = {
msg({ message: `Export`, context: 'commandMenuItem.shortLabel' }),
),
availabilityType: CommandMenuItemAvailabilityType.RECORD_SELECTION,
- conditionalAvailabilityExpression: 'permissionFlags.EXPORT_CSV',
+ conditionalAvailabilityExpression:
+ 'pageType == "INDEX_PAGE" and permissionFlags.EXPORT_CSV',
availabilityObjectMetadataUniversalIdentifier: null,
frontComponentUniversalIdentifier: null,
engineComponentKey: EngineComponentKey.EXPORT_RECORDS,