The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix: respect standard object rename across all locales (Closes #18650) (#18652)
Assad Roblescb4efb1d0ed2
diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/__tests__/resolve-object-metadata-standard-override.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/__tests__/resolve-object-metadata-standard-override.util.spec.tsindex 74cf2f3f581..21aa6aa5b1f 100644--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/__tests__/resolve-object-metadata-standard-override.util.spec.ts+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/__tests__/resolve-object-metadata-standard-override.util.spec.ts@@ -319,7 +319,7 @@ describe('resolveObjectMetadataStandardOverride', () => {).toBe('overridden-icon');});- it('should not use direct override for non-SOURCE_LOCALE', () => {+ it('should use direct override for non-SOURCE_LOCALE', () => {const objectMetadata = {labelSingular: 'Standard Label',labelPlural: 'Standard Labels',@@ -332,9 +332,6 @@ describe('resolveObjectMetadataStandardOverride', () => {},};- mockGenerateMessageId.mockReturnValue('generated-message-id');- mockI18n._.mockReturnValue('generated-message-id');-const result = resolveObjectMetadataStandardOverride(objectMetadata,'labelSingular',@@ -342,7 +339,7 @@ describe('resolveObjectMetadataStandardOverride', () => {mockI18n,);- expect(result).toBe('Standard Label');+ expect(result).toBe('Overridden Label');});it('should not use undefined override for SOURCE_LOCALE', () => {diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/resolve-object-metadata-standard-override.util.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/resolve-object-metadata-standard-override.util.tsindex be6702f7d75..1522768ec5c 100644--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/resolve-object-metadata-standard-override.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/resolve-object-metadata-standard-override.util.ts@@ -45,10 +45,7 @@ export const resolveObjectMetadataStandardOverride = (}}- if (- safeLocale === SOURCE_LOCALE &&- isNonEmptyString(objectMetadata.standardOverrides?.[labelKey])- ) {+ if (isNonEmptyString(objectMetadata.standardOverrides?.[labelKey])) {return objectMetadata.standardOverrides[labelKey] ?? '';}