Skip to content

The open alternative to Salesforce, designed for AI.

Disable permission tab when empty (#19630)

martmullcd10f3cbd908
diff --git a/packages/twenty-front/src/pages/settings/applications/SettingsApplicationDetails.tsx b/packages/twenty-front/src/pages/settings/applications/SettingsApplicationDetails.tsx
index d8849c40ba9..7bc8dafa64f 100644
--- a/packages/twenty-front/src/pages/settings/applications/SettingsApplicationDetails.tsx
+++ b/packages/twenty-front/src/pages/settings/applications/SettingsApplicationDetails.tsx
@@ -53,12 +53,23 @@ export const SettingsApplicationDetails = () => {
const tabs: SingleTabProps[] = [
{ id: 'about', title: t`About`, Icon: IconInfoCircle },
{ id: 'content', title: t`Content`, Icon: IconBox },
- { id: 'permissions', title: t`Permissions`, Icon: IconLock },
+ {
+ id: 'permissions',
+ title: t`Permissions`,
+ Icon: IconLock,
+ tooltipContent: !isDefined(application?.defaultRoleId)
+ ? t`No permission defined for this application`
+ : undefined,
+ disabled: !isDefined(application?.defaultRoleId),
+ },
{
id: 'settings',
title: t`Settings`,
Icon: IconSettings,
- tooltipContent: t`No variables to set for this application`,
+ tooltipContent:
+ (application?.applicationVariables ?? []).length === 0
+ ? t`No variables to set for this application`
+ : undefined,
disabled: (application?.applicationVariables ?? []).length === 0,
},
...(isDefined(settingsCustomTabFrontComponentId)
diff --git a/packages/twenty-front/src/pages/settings/applications/tabs/SettingsApplicationPermissionsTab.tsx b/packages/twenty-front/src/pages/settings/applications/tabs/SettingsApplicationPermissionsTab.tsx
index 2abf34c9cb1..9904b1d4cf0 100644
--- a/packages/twenty-front/src/pages/settings/applications/tabs/SettingsApplicationPermissionsTab.tsx
+++ b/packages/twenty-front/src/pages/settings/applications/tabs/SettingsApplicationPermissionsTab.tsx
@@ -18,10 +18,7 @@ import {
import { STANDARD_OBJECTS } from 'twenty-shared/metadata';
import { isDefined } from 'twenty-shared/utils';
import { v4 as uuidv4 } from 'uuid';
-import {
- FieldMetadataType,
- type PermissionFlagType,
-} from '~/generated-metadata/graphql';
+import { FieldMetadataType } from '~/generated-metadata/graphql';
import { findObjectNameByUniversalIdentifier } from '~/pages/settings/applications/utils/findObjectNameByUniversalIdentifier';