Skip to content

The open alternative to Salesforce, designed for AI.

fix(shared): reject scheme-relative backslash urls in isSafeUrl (#26397)

Belkouchecd17c4891782
diff --git a/packages/twenty-shared/src/utils/url/__tests__/getSafeUrl.test.ts b/packages/twenty-shared/src/utils/url/__tests__/getSafeUrl.test.ts
new file mode 100644
index 00000000000..a2989ade256
--- /dev/null
+++ b/packages/twenty-shared/src/utils/url/__tests__/getSafeUrl.test.ts
@@ -0,0 +1,51 @@
+import { getSafeUrl } from '@/utils/url/getSafeUrl';
+
+describe('getSafeUrl', () => {
+ it('returns safe absolute urls unchanged', () => {
+ expect(getSafeUrl('https://twenty.com')).toBe('https://twenty.com');
+ expect(getSafeUrl('http://twenty.com/path?q=1#h')).toBe(
+ 'http://twenty.com/path?q=1#h',
+ );
+ expect(getSafeUrl('mailto:[email protected]')).toBe(
+ 'mailto:[email protected]',
+ );
+ expect(getSafeUrl('tel:+33123456789')).toBe('tel:+33123456789');
+ });
+
+ it('keeps same-origin relative paths', () => {
+ expect(getSafeUrl('/')).toBe('/');
+ expect(getSafeUrl('/settings/profile')).toBe('/settings/profile');
+ expect(getSafeUrl('/objects/people?view=1#top')).toBe(
+ '/objects/people?view=1#top',
+ );
+ });
+
+ it('prepends https to scheme-less hosts', () => {
+ expect(getSafeUrl('twenty.com')).toBe('https://twenty.com');
+ expect(getSafeUrl('example.com/path')).toBe('https://example.com/path');
+ });
+
+ it('rejects dangerous schemes', () => {
+ expect(getSafeUrl('javascript:alert(1)')).toBeUndefined();
+ expect(getSafeUrl('JavaScript:alert(1)')).toBeUndefined();
+ expect(
+ getSafeUrl('data:text/html,<script>alert(1)</script>'),
+ ).toBeUndefined();
+ expect(getSafeUrl('vbscript:msgbox(1)')).toBeUndefined();
+ });
+
+ it('rejects scheme-relative urls that leave the current origin', () => {
+ expect(getSafeUrl('//evil.com')).toBeUndefined();
+ expect(getSafeUrl('/\\evil.com')).toBeUndefined();
+ expect(getSafeUrl('/\\\\evil.com')).toBeUndefined();
+ expect(getSafeUrl('/\\/evil.com')).toBeUndefined();
+ expect(getSafeUrl('/\t\\evil.com')).toBeUndefined();
+ });
+
+ it('returns undefined for empty or nullish values', () => {
+ expect(getSafeUrl('')).toBeUndefined();
+ expect(getSafeUrl(' ')).toBeUndefined();
+ expect(getSafeUrl(undefined)).toBeUndefined();
+ expect(getSafeUrl(null)).toBeUndefined();
+ });
+});
diff --git a/packages/twenty-shared/src/utils/url/__tests__/isSafeUrl.test.ts b/packages/twenty-shared/src/utils/url/__tests__/isSafeUrl.test.ts
new file mode 100644
index 00000000000..eb7a04472d8
--- /dev/null
+++ b/packages/twenty-shared/src/utils/url/__tests__/isSafeUrl.test.ts
@@ -0,0 +1,35 @@
+import { isSafeUrl } from '@/utils/url/isSafeUrl';
+
+describe('isSafeUrl', () => {
+ it('accepts same-origin relative paths', () => {
+ expect(isSafeUrl('/')).toBe(true);
+ expect(isSafeUrl('/settings')).toBe(true);
+ expect(isSafeUrl('/objects/people?view=1#top')).toBe(true);
+ });
+
+ it('accepts absolute urls with a safe protocol', () => {
+ expect(isSafeUrl('https://example.com')).toBe(true);
+ expect(isSafeUrl('http://example.com/path')).toBe(true);
+ expect(isSafeUrl('mailto:[email protected]')).toBe(true);
+ expect(isSafeUrl('tel:+33612345678')).toBe(true);
+ });
+
+ it('rejects unsafe protocols', () => {
+ expect(isSafeUrl('javascript:alert(1)')).toBe(false);
+ expect(isSafeUrl('data:text/html,<script>alert(1)</script>')).toBe(false);
+ expect(isSafeUrl('vbscript:msgbox(1)')).toBe(false);
+ });
+
+ it('rejects scheme-relative urls that leave the current origin', () => {
+ expect(isSafeUrl('//evil.com')).toBe(false);
+ expect(isSafeUrl('/\\evil.com')).toBe(false);
+ expect(isSafeUrl('/\\\\evil.com')).toBe(false);
+ expect(isSafeUrl('/\\/evil.com')).toBe(false);
+ expect(isSafeUrl('/\t\\evil.com')).toBe(false);
+ });
+
+ it('rejects unparsable input', () => {
+ expect(isSafeUrl('')).toBe(false);
+ expect(isSafeUrl('not a url')).toBe(false);
+ });
+});
diff --git a/packages/twenty-shared/src/utils/url/getSafeUrl.ts b/packages/twenty-shared/src/utils/url/getSafeUrl.ts
index e7b5269728a..4e217ea209e 100644
--- a/packages/twenty-shared/src/utils/url/getSafeUrl.ts
+++ b/packages/twenty-shared/src/utils/url/getSafeUrl.ts
@@ -11,6 +11,10 @@ export const getSafeUrl = (
return url;
}
+ if (url.startsWith('/')) {
+ return undefined;
+ }
+
const withScheme = `https://${url}`;
return isSafeUrl(withScheme) ? withScheme : undefined;
diff --git a/packages/twenty-shared/src/utils/url/isSafeUrl.ts b/packages/twenty-shared/src/utils/url/isSafeUrl.ts
index c2df3e69575..699bea4a5d9 100644
--- a/packages/twenty-shared/src/utils/url/isSafeUrl.ts
+++ b/packages/twenty-shared/src/utils/url/isSafeUrl.ts
@@ -1,8 +1,17 @@
const SAFE_URL_PROTOCOLS = ['http:', 'https:', 'mailto:', 'tel:'];
+const SAME_ORIGIN_PROBE_BASE_URL = 'https://same-origin-probe.invalid';
+
export const isSafeUrl = (url: string): boolean => {
- if (url.startsWith('/') && !url.startsWith('//')) {
- return true;
+ if (url.startsWith('/')) {
+ try {
+ return (
+ new URL(url, SAME_ORIGIN_PROBE_BASE_URL).origin ===
+ SAME_ORIGIN_PROBE_BASE_URL
+ );
+ } catch {
+ return false;
+ }
}
try {
diff --git a/packages/twenty-ui/src/utilities/utils/__tests__/getSafeUrl.test.ts b/packages/twenty-ui/src/utilities/utils/__tests__/getSafeUrl.test.ts
index 65b91a86e80..d8fdca4a97f 100644
--- a/packages/twenty-ui/src/utilities/utils/__tests__/getSafeUrl.test.ts
+++ b/packages/twenty-ui/src/utilities/utils/__tests__/getSafeUrl.test.ts
@@ -18,6 +18,14 @@ describe('getSafeUrl', () => {
expect(getSafeUrl('twenty.com')).toBe('https://twenty.com');
});
+ it('rejects scheme-relative urls that leave the current origin', () => {
+ expect(getSafeUrl('//evil.com')).toBeUndefined();
+ expect(getSafeUrl('/\\evil.com')).toBeUndefined();
+ expect(getSafeUrl('/\\\\evil.com')).toBeUndefined();
+ expect(getSafeUrl('/\\/evil.com')).toBeUndefined();
+ expect(getSafeUrl('/\t\\evil.com')).toBeUndefined();
+ });
+
it('rejects dangerous schemes', () => {
expect(getSafeUrl('javascript:alert(1)')).toBeUndefined();
expect(getSafeUrl('JavaScript:alert(1)')).toBeUndefined();
diff --git a/packages/twenty-ui/src/utilities/utils/getSafeUrl.ts b/packages/twenty-ui/src/utilities/utils/getSafeUrl.ts
index 5ff0513ae99..ef042966bd4 100644
--- a/packages/twenty-ui/src/utilities/utils/getSafeUrl.ts
+++ b/packages/twenty-ui/src/utilities/utils/getSafeUrl.ts
@@ -1,8 +1,17 @@
const SAFE_URL_PROTOCOLS = ['http:', 'https:', 'mailto:', 'tel:'];
+const SAME_ORIGIN_PROBE_BASE_URL = 'https://same-origin-probe.invalid';
+
const isSafeUrl = (url: string): boolean => {
- if (url.startsWith('/') && !url.startsWith('//')) {
- return true;
+ if (url.startsWith('/')) {
+ try {
+ return (
+ new URL(url, SAME_ORIGIN_PROBE_BASE_URL).origin ===
+ SAME_ORIGIN_PROBE_BASE_URL
+ );
+ } catch {
+ return false;
+ }
}
try {
@@ -25,6 +34,10 @@ export const getSafeUrl = (
return url;
}
+ if (url.startsWith('/')) {
+ return undefined;
+ }
+
const withScheme = `https://${url}`;
return isSafeUrl(withScheme) ? withScheme : undefined;