The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Show component preview in AI publication approvals (#29407)
Weikod1847dd2f80e
diff --git a/packages/twenty-front/src/modules/ai/components/AiChatAskCard.tsx b/packages/twenty-front/src/modules/ai/components/AiChatAskCard.tsxindex 32c5e420899..bf5a3a49c91 100644--- a/packages/twenty-front/src/modules/ai/components/AiChatAskCard.tsx+++ b/packages/twenty-front/src/modules/ai/components/AiChatAskCard.tsx@@ -7,9 +7,13 @@ import { type AgentChatPendingToolCall } from '@/ai/types/AgentChatPendingToolCatype AiChatAskCardProps = {pendingToolCall: AgentChatPendingToolCall;+ isActive?: boolean;};-export const AiChatAskCard = ({ pendingToolCall }: AiChatAskCardProps) => {+export const AiChatAskCard = ({+ pendingToolCall,+ isActive = true,+}: AiChatAskCardProps) => {switch (pendingToolCall.kind) {case 'question':case 'questions':@@ -26,6 +30,7 @@ export const AiChatAskCard = ({ pendingToolCall }: AiChatAskCardProps) => {<AiChatToolCallApprovalCardtoolCallId={pendingToolCall.toolCallId}proposal={pendingToolCall.proposal}+ isActive={isActive}/>);default:diff --git a/packages/twenty-front/src/modules/ai/components/AiChatFrontComponentPreview.tsx b/packages/twenty-front/src/modules/ai/components/AiChatFrontComponentPreview.tsxindex c99bc64f675..8fef97e03a0 100644--- a/packages/twenty-front/src/modules/ai/components/AiChatFrontComponentPreview.tsx+++ b/packages/twenty-front/src/modules/ai/components/AiChatFrontComponentPreview.tsx@@ -1,32 +1,8 @@-import { styled } from '@linaria/react';-import { useLingui } from '@lingui/react/macro';-import { useCallback, useState } from 'react';-import { FrontComponentSourceRenderer } from 'twenty-front-component-renderer';-import { PageLayoutType } from 'twenty-shared/types';-import { isDefined } from 'twenty-shared/utils';-import { Badge } from 'twenty-ui/primitives/data-display';-import { themeCssVariables, useThemeColorScheme } from 'twenty-ui/theme';--import { AiChatFrontComponentPreviewEffect } from '@/ai/components/AiChatFrontComponentPreviewEffect';+import { AiChatFrontComponentPreviewContent } from '@/ai/components/AiChatFrontComponentPreviewContent';import { useAiChatFrontComponentPreview } from '@/ai/hooks/useAiChatFrontComponentPreview';import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';import { FeatureFlagKey } from '~/generated-metadata/graphql';-const StyledPreview = styled.div`- border: 1px solid ${themeCssVariables.border.color.medium};- border-radius: ${themeCssVariables.border.radius.md};- display: flex;- flex-direction: column;- gap: ${themeCssVariables.spacing[2]};- overflow: hidden;- padding: ${themeCssVariables.spacing[2]};-`;--const StyledContent = styled.div`- height: calc(3 * ${themeCssVariables.spacing[30]});- width: 100%;-`;-type AiChatFrontComponentPreviewProps = {draftId: string;};@@ -39,65 +15,25 @@ export const AiChatFrontComponentPreview = ({);return isEnabled ? (- <AiChatFrontComponentPreviewContent key={draftId} draftId={draftId} />+ <AiChatFrontComponentPreviewLoader key={draftId} draftId={draftId} />) : null;};-type AiChatFrontComponentPreviewContentProps = AiChatFrontComponentPreviewProps;+type AiChatFrontComponentPreviewLoaderProps = AiChatFrontComponentPreviewProps;-const AiChatFrontComponentPreviewContent = ({+const AiChatFrontComponentPreviewLoader = ({draftId,-}: AiChatFrontComponentPreviewContentProps) => {- const { t } = useLingui();- const colorScheme = useThemeColorScheme();+}: AiChatFrontComponentPreviewLoaderProps) => {const { preview, error, loadPreview, reportPreviewError } =useAiChatFrontComponentPreview(draftId);- const [isReady, setIsReady] = useState(false);- const handleReady = useCallback(() => setIsReady(true), []);return (- <StyledPreview>- <AiChatFrontComponentPreviewEffect loadPreview={loadPreview} />- <div>- <Badge>{t`Sample data`}</Badge>- {isDefined(preview) && (- <Badge>- {preview.pageLayoutType === PageLayoutType.DASHBOARD- ? t`Dashboard widget`- : t`Record page widget`}- </Badge>- )}- </div>- {isDefined(preview) && (- <>- {!preview.isCurrent && (- <span>{t`A newer revision exists. Open the latest preview to save.`}</span>- )}- {isDefined(preview.publishedComponentId) && (- <span>{t`Saved to Workspace app`}</span>- )}- <StyledContent- role="region"- aria-label={t`Component preview with sample data`}- >- <FrontComponentSourceRenderer- componentId={draftId}- componentSource={preview.componentSource}- sharedDependenciesSource={preview.sharedDependenciesSource}- mockQueryResult={preview.mockQueryResult}- colorScheme={colorScheme}- onReady={handleReady}- onError={reportPreviewError}- />- </StyledContent>- </>- )}- {!isReady && !isDefined(error) && (- <span role="status">- {isDefined(preview) ? t`Rendering preview…` : t`Loading preview…`}- </span>- )}- {isDefined(error) && <span role="alert">{error}</span>}- </StyledPreview>+ <AiChatFrontComponentPreviewContent+ draftId={draftId}+ preview={preview}+ error={error}+ loadPreview={loadPreview}+ reportPreviewError={reportPreviewError}+ />);};diff --git a/packages/twenty-front/src/modules/ai/components/AiChatFrontComponentPreviewContent.tsx b/packages/twenty-front/src/modules/ai/components/AiChatFrontComponentPreviewContent.tsxnew file mode 100644index 00000000000..31db724a46b--- /dev/null+++ b/packages/twenty-front/src/modules/ai/components/AiChatFrontComponentPreviewContent.tsx@@ -0,0 +1,92 @@+import { styled } from '@linaria/react';+import { useLingui } from '@lingui/react/macro';+import { useCallback, useState } from 'react';+import { FrontComponentSourceRenderer } from 'twenty-front-component-renderer';+import { PageLayoutType } from 'twenty-shared/types';+import { isDefined } from 'twenty-shared/utils';+import { Badge } from 'twenty-ui/primitives/data-display';+import { themeCssVariables, useThemeColorScheme } from 'twenty-ui/theme';++import { AiChatFrontComponentPreviewEffect } from '@/ai/components/AiChatFrontComponentPreviewEffect';+import { type useAiChatFrontComponentPreview } from '@/ai/hooks/useAiChatFrontComponentPreview';++const StyledPreview = styled.div`+ border: 1px solid ${themeCssVariables.border.color.medium};+ border-radius: ${themeCssVariables.border.radius.md};+ display: flex;+ flex-direction: column;+ gap: ${themeCssVariables.spacing[2]};+ overflow: hidden;+ padding: ${themeCssVariables.spacing[2]};+`;++const StyledContent = styled.div`+ height: calc(3 * ${themeCssVariables.spacing[30]});+ width: 100%;+`;++type AiChatFrontComponentPreviewContentProps = {+ draftId: string;+} & Pick<+ ReturnType<typeof useAiChatFrontComponentPreview>,+ 'preview' | 'error' | 'loadPreview' | 'reportPreviewError'+>;++export const AiChatFrontComponentPreviewContent = ({+ draftId,+ preview,+ error,+ loadPreview,+ reportPreviewError,+}: AiChatFrontComponentPreviewContentProps) => {+ const { t } = useLingui();+ const colorScheme = useThemeColorScheme();+ const [isReady, setIsReady] = useState(false);+ const handleReady = useCallback(() => setIsReady(true), []);++ return (+ <StyledPreview>+ <AiChatFrontComponentPreviewEffect loadPreview={loadPreview} />+ <div>+ <Badge>{t`Sample data`}</Badge>+ {isDefined(preview) && (+ <Badge>+ {preview.pageLayoutType === PageLayoutType.DASHBOARD+ ? t`Dashboard widget`+ : t`Record page widget`}+ </Badge>+ )}+ </div>+ {isDefined(preview) && (+ <>+ {!preview.isCurrent && (+ <span>{t`A newer revision exists. Open the latest preview to save.`}</span>+ )}+ {isDefined(preview.publishedComponentId) && (+ <span>{t`Saved to Workspace app`}</span>+ )}+ <StyledContent+ role="region"+ aria-label={t`Component preview with sample data`}+ >+ <FrontComponentSourceRenderer+ componentId={draftId}+ componentSource={preview.componentSource}+ sharedDependenciesSource={preview.sharedDependenciesSource}+ mockQueryResult={preview.mockQueryResult}+ colorScheme={colorScheme}+ onReady={handleReady}+ onError={reportPreviewError}+ />+ </StyledContent>+ </>+ )}+ {!isReady && !isDefined(error) && (+ <span role="status">+ {isDefined(preview) ? t`Rendering preview…` : t`Loading preview…`}+ </span>+ )}+ {isDefined(error) && <span role="alert">{error}</span>}+ </StyledPreview>+ );+};diff --git a/packages/twenty-front/src/modules/ai/components/AiChatPendingAskGate.tsx b/packages/twenty-front/src/modules/ai/components/AiChatPendingAskGate.tsxindex 8d0d59a4a46..4d1fd765741 100644--- a/packages/twenty-front/src/modules/ai/components/AiChatPendingAskGate.tsx+++ b/packages/twenty-front/src/modules/ai/components/AiChatPendingAskGate.tsx@@ -100,7 +100,10 @@ export const AiChatPendingAskGate = ({)}{pendingToolCalls.map((pendingToolCall, index) => (<div key={pendingToolCall.toolCallId} hidden={index !== currentIndex}>- <AiChatAskCard pendingToolCall={pendingToolCall} />+ <AiChatAskCard+ pendingToolCall={pendingToolCall}+ isActive={index === currentIndex}+ /></div>))}</StyledGate>diff --git a/packages/twenty-front/src/modules/ai/components/AiChatToolCallApprovalCard.tsx b/packages/twenty-front/src/modules/ai/components/AiChatToolCallApprovalCard.tsxindex 529d3184622..ed62bf8da3d 100644--- a/packages/twenty-front/src/modules/ai/components/AiChatToolCallApprovalCard.tsx+++ b/packages/twenty-front/src/modules/ai/components/AiChatToolCallApprovalCard.tsx@@ -1,18 +1,34 @@-import { type ProposedToolCall } from 'twenty-shared/ai';+import {+ isFrontComponentProposedToolCall,+ type ProposedToolCall,+} from 'twenty-shared/ai';import { AiChatToolCallApprovalArgumentsCard } from '@/ai/components/internal/AiChatToolCallApprovalArgumentsCard';import { AiChatToolCallApprovalEmailCard } from '@/ai/components/internal/AiChatToolCallApprovalEmailCard';+import { AiChatToolCallApprovalFrontComponentCard } from '@/ai/components/internal/AiChatToolCallApprovalFrontComponentCard';type AiChatToolCallApprovalCardProps = {toolCallId: string;proposal: ProposedToolCall;+ isActive?: boolean;};export const AiChatToolCallApprovalCard = ({toolCallId,proposal,-}: AiChatToolCallApprovalCardProps) =>- proposal.template === 'email' ? (+ isActive = true,+}: AiChatToolCallApprovalCardProps) => {+ if (isFrontComponentProposedToolCall(proposal)) {+ return (+ <AiChatToolCallApprovalFrontComponentCard+ toolCallId={toolCallId}+ proposal={proposal}+ isActive={isActive}+ />+ );+ }++ return proposal.template === 'email' ? (<AiChatToolCallApprovalEmailCardtoolCallId={toolCallId}proposal={proposal}@@ -23,3 +39,4 @@ export const AiChatToolCallApprovalCard = ({proposal={proposal}/>);+};diff --git a/packages/twenty-front/src/modules/ai/components/__stories__/AiChatToolCallApprovalCard.stories.tsx b/packages/twenty-front/src/modules/ai/components/__stories__/AiChatToolCallApprovalCard.stories.tsxnew file mode 100644index 00000000000..9b4c042075b--- /dev/null+++ b/packages/twenty-front/src/modules/ai/components/__stories__/AiChatToolCallApprovalCard.stories.tsx@@ -0,0 +1,241 @@+import { type Meta, type StoryObj } from '@storybook/react-vite';+import { http, HttpResponse } from 'msw';+import { getWorker } from 'msw-storybook-addon';+import { expect, userEvent, waitFor, within } from 'storybook/test';+import {+ PUBLISH_FRONT_COMPONENT_TOOL_NAME,+ PROPOSE_TOOL_CALL_TOOL_NAME,+ type ProposedToolCall,+ type ExtendedUIMessagePart,+} from 'twenty-shared/ai';+import { ComponentDecorator } from 'twenty-ui/testing';++import { AiChatPendingAskGate } from '@/ai/components/AiChatPendingAskGate';+import { AGENT_CHAT_REFETCH_MESSAGES_EVENT_NAME } from '@/ai/constants/AgentChatRefetchMessagesEventName';+import { agentChatDisplayedThreadState } from '@/ai/states/agentChatDisplayedThreadState';+import { agentChatMessagesFamilyState } from '@/ai/states/agentChatMessagesFamilyState';+import { REST_API_BASE_URL } from '@/apollo/constants/RestApiBaseUrl';+import { dispatchBrowserEvent } from '@/browser-event/utils/dispatchBrowserEvent';+import { jotaiStore } from '@/ui/utilities/state/jotai/jotaiStore';+import { AiChatToolCallApprovalCard } from '@/ai/components/AiChatToolCallApprovalCard';+import {+ frontComponentPreviewHandlers,+ getFrontComponentPreviewMock,+ seedFrontComponentPreviewWorkspace,+} from '@/ai/components/__mocks__/aiChatFrontComponentPreviewMocks';+import { MemoryRouterDecorator } from '~/testing/decorators/MemoryRouterDecorator';+import { RootDecorator } from '~/testing/decorators/RootDecorator';+import { ToastDecorator } from '~/testing/decorators/ToastDecorator';++const PROPOSAL: ProposedToolCall = {+ toolName: PUBLISH_FRONT_COMPONENT_TOOL_NAME,+ toolLabel: 'Publish Front Component',+ summary: 'Save this counter to the Workspace app',+ arguments: { draftId: 'current', checksum: 'a'.repeat(64) },+ template: 'frontComponent',+};++const meta: Meta<typeof AiChatToolCallApprovalCard> = {+ title: 'Modules/AI/AiChatToolCallApprovalCard',+ component: AiChatToolCallApprovalCard,+ decorators: [+ RootDecorator,+ ToastDecorator,+ MemoryRouterDecorator,+ ComponentDecorator,+ ],+ beforeEach: () => seedFrontComponentPreviewWorkspace(),+ parameters: {+ container: { width: 600 },+ msw: { handlers: frontComponentPreviewHandlers },+ },+ args: {+ toolCallId: 'publish-call',+ proposal: PROPOSAL,+ },+};++export default meta;+type Story = StoryObj<typeof AiChatToolCallApprovalCard>;++export const ComponentPreview: Story = {+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ await expect(await canvas.findByText('Sample data')).toBeVisible();+ await userEvent.click(+ await canvas.findByRole(+ 'button',+ { name: 'Count: 0' },+ { timeout: 30000 },+ ),+ );+ await expect(+ await canvas.findByRole('button', { name: 'Count: 1' }),+ ).toBeVisible();+ await expect(+ canvas.queryByRole('textbox', { name: 'Arguments' }),+ ).not.toBeInTheDocument();+ await expect(canvas.getByRole('button', { name: 'Approve' })).toBeEnabled();+ await expect(canvas.getByRole('button', { name: 'Reject' })).toBeVisible();+ await userEvent.click(canvas.getByRole('button', { name: 'Add feedback' }));+ await userEvent.type(+ canvas.getByRole('textbox', { name: 'Feedback' }),+ 'Make it smaller',+ );+ await expect(+ canvas.getByRole('button', { name: 'Count: 1' }),+ ).toBeVisible();+ },+};++export const SupersededPreview: Story = {+ args: {+ proposal: {+ ...PROPOSAL,+ arguments: { ...PROPOSAL.arguments, draftId: 'superseded' },+ },+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ await expect(+ await canvas.findByText(+ 'A newer revision exists. Open the latest preview to save.',+ ),+ ).toBeVisible();+ await expect(+ canvas.getByRole('button', { name: 'Approve' }),+ ).toBeDisabled();+ await expect(canvas.getByRole('button', { name: 'Reject' })).toBeEnabled();+ },+};++export const UnavailablePreview: Story = {+ args: {+ proposal: {+ ...PROPOSAL,+ arguments: { ...PROPOSAL.arguments, draftId: 'unavailable' },+ },+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ await expect(await canvas.findByRole('alert')).toHaveTextContent(+ 'Could not load preview.',+ );+ await expect(+ canvas.getByRole('button', { name: 'Approve' }),+ ).toBeDisabled();+ await expect(canvas.getByRole('button', { name: 'Reject' })).toBeEnabled();+ },+};++export const DisabledFeature: Story = {+ beforeEach: () => seedFrontComponentPreviewWorkspace(false),+ play: UnavailablePreview.play,+};++export const SupersededAfterRefresh: Story = {+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ await canvas.findByRole('button', { name: 'Count: 0' }, { timeout: 30000 });+ await expect(canvas.getByRole('button', { name: 'Approve' })).toBeEnabled();+ getWorker().use(+ http.get(`${REST_API_BASE_URL}/ai-front-components/drafts/:draftId`, () =>+ HttpResponse.json(getFrontComponentPreviewMock('superseded')),+ ),+ );+ dispatchBrowserEvent(AGENT_CHAT_REFETCH_MESSAGES_EVENT_NAME);+ await expect(+ await canvas.findByText(+ 'A newer revision exists. Open the latest preview to save.',+ ),+ ).toBeVisible();+ await expect(+ canvas.getByRole('button', { name: 'Approve' }),+ ).toBeDisabled();+ },+};++const requestedDraftIds: string[] = [];++export const PendingRequests: Story = {+ render: () => (+ <AiChatPendingAskGate>+ <span>No pending requests</span>+ </AiChatPendingAskGate>+ ),+ beforeEach: () => {+ requestedDraftIds.length = 0;+ getWorker().use(+ http.get(+ `${REST_API_BASE_URL}/ai-front-components/drafts/:draftId`,+ ({ params }) => {+ requestedDraftIds.push(String(params.draftId));+ return HttpResponse.json(+ getFrontComponentPreviewMock(String(params.draftId)),+ );+ },+ ),+ );+ const previousThread = jotaiStore.get(agentChatDisplayedThreadState.atom);+ const messagesAtom = agentChatMessagesFamilyState.atomFamily({+ threadId: 'approval-preview-story',+ });+ const previousMessages = jotaiStore.get(messagesAtom);+ jotaiStore.set(+ agentChatDisplayedThreadState.atom,+ 'approval-preview-story',+ );+ jotaiStore.set(messagesAtom, [+ {+ id: 'pending-publications',+ role: 'assistant',+ parts: ['current', 'record-page'].map(+ (draftId): ExtendedUIMessagePart => ({+ type: `tool-${PROPOSE_TOOL_CALL_TOOL_NAME}`,+ toolCallId: draftId,+ state: 'output-available',+ input: {},+ output: {+ success: true,+ result: {+ status: 'pending',+ proposal: {+ ...PROPOSAL,+ arguments: { ...PROPOSAL.arguments, draftId },+ },+ },+ },+ }),+ ),+ },+ ]);+ return () => {+ jotaiStore.set(agentChatDisplayedThreadState.atom, previousThread);+ jotaiStore.set(messagesAtom, previousMessages);+ };+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);+ await canvas.findByRole('button', { name: 'Count: 0' }, { timeout: 30000 });+ await expect(requestedDraftIds).toEqual(['current']);+ await userEvent.click(canvas.getByRole('button', { name: 'Add feedback' }));+ await userEvent.type(+ canvas.getByRole('textbox', { name: 'Feedback' }),+ 'Keep this feedback',+ );+ await userEvent.click(canvas.getByRole('button', { name: 'Next request' }));+ await canvas.findByText('Record page widget');+ await expect(requestedDraftIds).toEqual(['current', 'record-page']);+ await expect(canvas.getAllByText('Sample data')).toHaveLength(1);+ await userEvent.click(+ canvas.getByRole('button', { name: 'Previous request' }),+ );+ await waitFor(() =>+ expect(requestedDraftIds).toEqual(['current', 'record-page', 'current']),+ );+ await expect(canvas.getByRole('textbox', { name: 'Feedback' })).toHaveValue(+ 'Keep this feedback',+ );+ await canvas.findByRole('button', { name: 'Count: 0' }, { timeout: 30000 });+ },+};diff --git a/packages/twenty-front/src/modules/ai/components/__tests__/AiChatToolCallApprovalCard.test.tsx b/packages/twenty-front/src/modules/ai/components/__tests__/AiChatToolCallApprovalCard.test.tsxindex 47091339fd0..6fc4812353d 100644--- a/packages/twenty-front/src/modules/ai/components/__tests__/AiChatToolCallApprovalCard.test.tsx+++ b/packages/twenty-front/src/modules/ai/components/__tests__/AiChatToolCallApprovalCard.test.tsx@@ -50,6 +50,21 @@ jest.mock('@/ai/components/internal/AiChatToolCallApprovalEmailCard', () => ({AiChatToolCallApprovalEmailCard: () => null,}));+jest.mock('@/ai/components/AiChatFrontComponentPreviewContent', () => ({+ AiChatFrontComponentPreviewContent: ({ draftId }: { draftId: string }) => (+ <div role="region" aria-label={`Preview of ${draftId}`} />+ ),+}));++const mockUsePreview = jest.fn();+jest.mock('@/ai/hooks/useAiChatFrontComponentPreview', () => ({+ useAiChatFrontComponentPreview: (draftId: string) => mockUsePreview(draftId),+}));+const mockIsFeatureEnabled = jest.fn();+jest.mock('@/workspace/hooks/useIsFeatureEnabled', () => ({+ useIsFeatureEnabled: () => mockIsFeatureEnabled(),+}));+const PROPOSAL: ProposedToolCall = {toolName: 'http_request',toolLabel: 'HTTP request',@@ -58,11 +73,21 @@ const PROPOSAL: ProposedToolCall = {template: 'generic',};-const renderCard = (proposal: ProposedToolCall = PROPOSAL) =>+const renderCard = ({+ proposal = PROPOSAL,+ isActive = true,+}: {+ proposal?: ProposedToolCall;+ isActive?: boolean;+} = {}) =>render(<I18nProvider i18n={i18n}><Provider store={createStore()}>- <AiChatToolCallApprovalCard toolCallId="call-1" proposal={proposal} />+ <AiChatToolCallApprovalCard+ toolCallId="call-1"+ proposal={proposal}+ isActive={isActive}+ /></Provider></I18nProvider>,);@@ -71,6 +96,10 @@ describe('AiChatToolCallApprovalCard', () => {beforeEach(() => {answerAgentChatToolCall.mockReset();refreshFrontComponents.mockReset();+ mockUsePreview+ .mockReset()+ .mockReturnValue({ preview: { isCurrent: true } });+ mockIsFeatureEnabled.mockReset().mockReturnValue(true);});it('shows what the call does and which tool it runs', () => {@@ -102,23 +131,6 @@ describe('AiChatToolCallApprovalCard', () => {expect(screen.getByRole('button', { name: 'Reject' })).toBeDisabled();});- it('keeps arguments read-only when the proposal disallows editing', async () => {- const user = userEvent.setup();- renderCard({ ...PROPOSAL, areArgumentsEditable: false });-- const argumentsInput = screen.getByRole('textbox', { name: 'Arguments' });- expect(argumentsInput).toBeDisabled();- await user.type(argumentsInput, '{"method":"DELETE"}');- await user.click(screen.getByRole('button', { name: 'Approve' }));-- expect(answerAgentChatToolCall).toHaveBeenCalledTimes(1);- expect(answerAgentChatToolCall).toHaveBeenCalledWith(- expect.objectContaining({- response: { decision: 'approve', arguments: PROPOSAL.arguments },- }),- );- });-it('cannot approve arguments that are not a JSON object', () => {renderCard();@@ -169,12 +181,14 @@ describe('AiChatToolCallApprovalCard', () => {});renderCard({- toolName: 'create_one_person',- toolLabel: 'Create person',- summary: 'Add the new contact',- arguments: { name: { firstName: 'Ada', lastName: 'Lovelace' } },- template: 'recordCreate',- objectNameSingular: 'person',+ proposal: {+ toolName: 'create_one_person',+ toolLabel: 'Create person',+ summary: 'Add the new contact',+ arguments: { name: { firstName: 'Ada', lastName: 'Lovelace' } },+ template: 'recordCreate',+ objectNameSingular: 'person',+ },});await user.click(screen.getByRole('button', { name: 'Set first name' }));@@ -241,39 +255,141 @@ describe('AiChatToolCallApprovalCard', () => {},});});- it('keeps the component revision read-only and refreshes after approval completes', async () => {- const user = userEvent.setup();- let completeApproval: (answered: boolean) => void = () => {};- answerAgentChatToolCall.mockReturnValue(- new Promise<boolean>((resolve) => {- completeApproval = resolve;- }),- );- const argumentsToApprove = {- draftId: 'approved-draft',- checksum: 'a'.repeat(64),- };+ it.each(['frontComponent', 'generic'] as const)(+ 'shows a %s publication preview and approves its unchanged revision',+ async (template) => {+ const user = userEvent.setup();+ let completeApproval: (answered: boolean) => void = () => {};+ answerAgentChatToolCall.mockReturnValue(+ new Promise<boolean>((resolve) => {+ completeApproval = resolve;+ }),+ );+ const argumentsToApprove = {+ draftId: 'approved-draft',+ checksum: 'a'.repeat(64),+ };+ renderCard({+ proposal: {+ ...PROPOSAL,+ toolName: PUBLISH_FRONT_COMPONENT_TOOL_NAME,+ toolLabel: 'Save component',+ summary: 'Save Renewals as a dashboard component',+ arguments: argumentsToApprove,+ template,+ },+ });++ expect(+ screen.getByRole('region', { name: 'Preview of approved-draft' }),+ ).toBeInTheDocument();+ expect(+ screen.queryByRole('textbox', { name: 'Arguments' }),+ ).not.toBeInTheDocument();+ expect(+ screen.queryByText(argumentsToApprove.checksum),+ ).not.toBeInTheDocument();+ await user.click(screen.getByRole('button', { name: 'Approve' }));+ expect(answerAgentChatToolCall).toHaveBeenCalledWith(+ expect.objectContaining({+ response: { decision: 'approve', arguments: argumentsToApprove },+ }),+ );+ expect(refreshFrontComponents).not.toHaveBeenCalled();+ await act(async () => completeApproval(true));+ await waitFor(() =>+ expect(refreshFrontComponents).toHaveBeenCalledTimes(1),+ );+ },+ );++ it('keeps ordinary tool arguments visible even when they contain a draft ID', () => {renderCard({- ...PROPOSAL,- toolName: PUBLISH_FRONT_COMPONENT_TOOL_NAME,- toolLabel: 'Save component',- summary: 'Save Renewals as a dashboard component',- arguments: argumentsToApprove,- areArgumentsEditable: false,+ proposal: { ...PROPOSAL, arguments: { draftId: 'other-tool-draft' } },});- expect(screen.getByRole('textbox', { name: 'Arguments' })).toBeDisabled();- await user.click(screen.getByRole('button', { name: 'Approve' }));- expect(answerAgentChatToolCall).toHaveBeenCalledWith(- expect.objectContaining({- response: { decision: 'approve', arguments: argumentsToApprove },- }),+ expect(screen.queryByRole('region')).not.toBeInTheDocument();+ expect(screen.getByRole('textbox', { name: 'Arguments' })).toHaveValue(+ JSON.stringify({ draftId: 'other-tool-draft' }, null, 2),);- expect(refreshFrontComponents).not.toHaveBeenCalled();- await act(async () => completeApproval(true));- await waitFor(() =>- expect(refreshFrontComponents).toHaveBeenCalledTimes(1),+ });++ it.each([undefined, '', 42])(+ 'does not load a preview for invalid draft ID %s',+ (draftId) => {+ renderCard({+ proposal: {+ ...PROPOSAL,+ toolName: PUBLISH_FRONT_COMPONENT_TOOL_NAME,+ arguments: { draftId },+ },+ });++ expect(screen.queryByRole('region')).not.toBeInTheDocument();+ expect(screen.getByRole('alert')).toHaveTextContent(+ 'Could not load preview.',+ );+ expect(screen.getByRole('button', { name: 'Approve' })).toBeDisabled();+ },+ );++ it.each([+ { state: 'loading', preview: undefined, error: undefined },+ { state: 'superseded', preview: { isCurrent: false }, error: undefined },+ {+ state: 'failed',+ preview: { isCurrent: true },+ error: 'Could not load preview.',+ },+ ])(+ 'blocks approval when the preview is $state',+ async ({ preview, error }) => {+ mockUsePreview.mockReturnValue({ preview, error });+ renderCard({+ proposal: {+ ...PROPOSAL,+ template: 'frontComponent',+ arguments: { draftId: 'current' },+ },+ });++ expect(screen.getByRole('button', { name: 'Approve' })).toBeDisabled();+ expect(screen.getByRole('button', { name: 'Reject' })).toBeEnabled();+ await userEvent.click(screen.getByRole('button', { name: 'Approve' }));+ expect(answerAgentChatToolCall).not.toHaveBeenCalled();+ },+ );++ it('blocks approval and explains an unavailable feature', () => {+ mockIsFeatureEnabled.mockReturnValue(false);+ renderCard({+ proposal: {+ ...PROPOSAL,+ template: 'frontComponent',+ arguments: { draftId: 'current' },+ },+ });++ expect(screen.getByRole('alert')).toHaveTextContent(+ 'Could not load preview.',);+ expect(screen.getByRole('button', { name: 'Approve' })).toBeDisabled();+ expect(screen.getByRole('button', { name: 'Reject' })).toBeEnabled();+ expect(screen.queryByRole('region')).not.toBeInTheDocument();+ });++ it('does not mount the preview loader for an inactive approval', () => {+ renderCard({+ proposal: {+ ...PROPOSAL,+ template: 'frontComponent',+ arguments: { draftId: 'hidden' },+ },+ isActive: false,+ });++ expect(mockUsePreview).not.toHaveBeenCalled();+ expect(screen.queryByRole('region')).not.toBeInTheDocument();});it.each([@@ -298,7 +414,13 @@ describe('AiChatToolCallApprovalCard', () => {completeAnswer = resolve;}),);- renderCard({ ...PROPOSAL, toolName });+ renderCard({+ proposal: {+ ...PROPOSAL,+ toolName,+ arguments: { draftId: 'current', checksum: 'a'.repeat(64) },+ },+ });await user.click(screen.getByRole('button', { name: decision }));await act(async () => completeAnswer(isAnswered));expect(answerAgentChatToolCall).toHaveBeenCalledTimes(1);diff --git a/packages/twenty-front/src/modules/ai/components/__tests__/AiChatToolCallApprovalEmailCard.test.tsx b/packages/twenty-front/src/modules/ai/components/__tests__/AiChatToolCallApprovalEmailCard.test.tsxindex 7cb32ee3f50..752c9b1aff0 100644--- a/packages/twenty-front/src/modules/ai/components/__tests__/AiChatToolCallApprovalEmailCard.test.tsx+++ b/packages/twenty-front/src/modules/ai/components/__tests__/AiChatToolCallApprovalEmailCard.test.tsx@@ -20,6 +20,10 @@ jest.mock('@/ai/components/internal/AiChatToolCallApprovalArgumentsCard',() => ({ AiChatToolCallApprovalArgumentsCard: () => null }),);+jest.mock(+ '@/ai/components/internal/AiChatToolCallApprovalFrontComponentCard',+ () => ({ AiChatToolCallApprovalFrontComponentCard: () => null }),+);jest.mock('@/activities/emails/editor/constants/InlineEmailBodyEditorProfile',() => ({ INLINE_EMAIL_BODY_EDITOR_PROFILE: {} }),@@ -141,26 +145,6 @@ describe('AiChatToolCallApprovalCard for an email', () => {expect(screen.getByRole('button', { name: 'Discard' })).toBeDisabled();});- it('keeps the subject unchanged when the proposal disallows editing', async () => {- const user = userEvent.setup();- renderCard({ ...PROPOSAL, areArgumentsEditable: false });-- const subject = screen.getByRole('textbox', { name: 'Subject' });- expect(subject).toBeDisabled();- await user.type(subject, 'Changed subject');- await user.click(screen.getByRole('button', { name: 'Send' }));-- expect(answerAgentChatToolCall).toHaveBeenCalledWith(- expect.objectContaining({- response: {- decision: 'approve',- toolName: 'send_email',- arguments: EMAIL_ARGUMENTS,- },- }),- );- });-it('saves the email as a draft through the alternative tool', async () => {const user = userEvent.setup();answerAgentChatToolCall.mockResolvedValue(true);diff --git a/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalArgumentsCard.tsx b/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalArgumentsCard.tsxindex fafe6eebe08..d5c0044817d 100644--- a/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalArgumentsCard.tsx+++ b/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalArgumentsCard.tsx@@ -91,14 +91,14 @@ export const AiChatToolCallApprovalArgumentsCard = ({objectNameSingular={objectNameSingular}values={toolArguments ?? proposal.arguments}recordId={recordId}- readonly={isAnswering || proposal.areArgumentsEditable === false}+ readonly={isAnswering}onChange={handleRecordFieldChange}/>)}{template === 'generic' && (<AiChatToolCallApprovalArgumentsEditordefaultArguments={proposal.arguments}- readonly={isAnswering || proposal.areArgumentsEditable === false}+ readonly={isAnswering}onChange={setToolArguments}/>)}diff --git a/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalEmailCard.tsx b/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalEmailCard.tsxindex 7267403b439..594fbd4e308 100644--- a/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalEmailCard.tsx+++ b/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalEmailCard.tsx@@ -152,7 +152,7 @@ export const AiChatToolCallApprovalEmailCard = ({<AiChatApprovalEmailReviewdraft={draft}onDraftChange={setDraft}- disabled={isAnswering || proposal.areArgumentsEditable === false}+ disabled={isAnswering}/></AiChatToolCallApprovalCardLayout>);diff --git a/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalFrontComponentCard.tsx b/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalFrontComponentCard.tsxnew file mode 100644index 00000000000..d70b71b5f12--- /dev/null+++ b/packages/twenty-front/src/modules/ai/components/internal/AiChatToolCallApprovalFrontComponentCard.tsx@@ -0,0 +1,103 @@+import { useLingui } from '@lingui/react/macro';+import { isNonEmptyString } from '@sniptt/guards';+import { type ProposedToolCall } from 'twenty-shared/ai';+import { isDefined } from 'twenty-shared/utils';+import { IconCheck, IconX } from 'twenty-ui/icon';+import { Button } from 'twenty-ui/primitives/input';++import { AiChatFrontComponentPreviewContent } from '@/ai/components/AiChatFrontComponentPreviewContent';+import { AiChatToolCallApprovalCardLayout } from '@/ai/components/internal/AiChatToolCallApprovalCardLayout';+import { useAiChatFrontComponentPreview } from '@/ai/hooks/useAiChatFrontComponentPreview';+import { useAnswerToolCallApproval } from '@/ai/hooks/useAnswerToolCallApproval';+import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';+import { FeatureFlagKey } from '~/generated-metadata/graphql';++type AiChatToolCallApprovalFrontComponentCardProps = {+ toolCallId: string;+ proposal: ProposedToolCall;+ isActive: boolean;+};++export const AiChatToolCallApprovalFrontComponentCard = ({+ toolCallId,+ proposal,+ isActive,+}: AiChatToolCallApprovalFrontComponentCardProps) => {+ const approval = useAnswerToolCallApproval({ toolCallId, proposal });++ return isActive ? (+ <AiChatToolCallApprovalFrontComponentContent+ proposal={proposal}+ approval={approval}+ />+ ) : null;+};++type AiChatToolCallApprovalFrontComponentContentProps = {+ proposal: ProposedToolCall;+ approval: ReturnType<typeof useAnswerToolCallApproval>;+};++const AiChatToolCallApprovalFrontComponentContent = ({+ proposal,+ approval,+}: AiChatToolCallApprovalFrontComponentContentProps) => {+ const { t } = useLingui();+ const isEnabled = useIsFeatureEnabled(+ FeatureFlagKey.IS_AI_CHAT_COMPONENT_BUILDER_ENABLED,+ );+ const draftId = isNonEmptyString(proposal.arguments.draftId)+ ? proposal.arguments.draftId+ : '';+ const { preview, error, loadPreview, reportPreviewError } =+ useAiChatFrontComponentPreview(draftId);+ const { pendingResponse, isAnswering, approve, reject } = approval;+ const canLoadPreview = isEnabled && isNonEmptyString(draftId);+ const canApprove = canLoadPreview && preview?.isCurrent && !isDefined(error);++ return (+ <AiChatToolCallApprovalCardLayout+ label={proposal.toolLabel}+ summary={proposal.summary}+ approval={approval}+ actions={+ <>+ <Button+ size="sm"+ variant="ghost"+ startIcon={<IconX />}+ disabled={isAnswering}+ loading={pendingResponse?.decision === 'reject'}+ onClick={reject}+ >+ {t`Reject`}+ </Button>+ <Button+ size="sm"+ variant="solid"+ color="accent"+ startIcon={<IconCheck />}+ disabled={isAnswering || !canApprove}+ loading={pendingResponse?.decision === 'approve'}+ onClick={() => approve({ arguments: proposal.arguments })}+ >+ {t`Approve`}+ </Button>+ </>+ }+ >+ {canLoadPreview ? (+ <AiChatFrontComponentPreviewContent+ key={draftId}+ draftId={draftId}+ preview={preview}+ error={error}+ loadPreview={loadPreview}+ reportPreviewError={reportPreviewError}+ />+ ) : (+ <span role="alert">{t`Could not load preview.`}</span>+ )}+ </AiChatToolCallApprovalCardLayout>+ );+};diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/__tests__/propose-tool-call.pausing-tool.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/__tests__/propose-tool-call.pausing-tool.spec.tsindex b9ddc8feb3d..00ca044d958 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/__tests__/propose-tool-call.pausing-tool.spec.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/__tests__/propose-tool-call.pausing-tool.spec.ts@@ -1,3 +1,5 @@+import { PUBLISH_FRONT_COMPONENT_TOOL_NAME } from 'twenty-shared/ai';+import { PROPOSE_TOOL_CALL_PAUSING_TOOL } from 'src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/propose-tool-call.pausing-tool';const RECORD_ID = '20202020-1c25-4d02-bf25-6aeccf7ea419';@@ -42,37 +44,46 @@ const buildFoundRecordOutput = (record: Record<string, unknown>) => ({});describe('PROPOSE_TOOL_CALL_PAUSING_TOOL', () => {- it('keeps the proposed arguments when the tool disallows editing', async () => {- const proposal = {- toolName: 'save_snapshot',- toolLabel: 'Save component',- summary: 'Save the reviewed component',- template: 'generic' as const,- areArgumentsEditable: false,- arguments: { draftId: RECORD_ID, checksum: 'reviewed-checksum' },- };- const call = PROPOSE_TOOL_CALL_PAUSING_TOOL.parseCall(proposal, {- success: true,- result: { status: 'pending', proposal },- });- const executeTool = jest- .fn()- .mockResolvedValue({ success: true, message: 'Saved' });+ it.each([+ {+ template: 'frontComponent',+ toolName: PUBLISH_FRONT_COMPONENT_TOOL_NAME,+ },+ { template: 'frontComponent', toolName: 'save_snapshot' },+ { template: 'generic', toolName: PUBLISH_FRONT_COMPONENT_TOOL_NAME },+ ] as const)(+ 'keeps the proposed revision for $template/$toolName when approval supplies another draft and checksum',+ async ({ template, toolName }) => {+ const proposal = {+ toolName,+ toolLabel: 'Save component',+ summary: 'Save the reviewed component',+ template,+ arguments: { draftId: RECORD_ID, checksum: 'reviewed-checksum' },+ };+ const call = PROPOSE_TOOL_CALL_PAUSING_TOOL.parseCall(proposal, {+ success: true,+ result: { status: 'pending', proposal },+ });+ const executeTool = jest+ .fn()+ .mockResolvedValue({ success: true, message: 'Saved' });- await call!.complete({- output: {- decision: 'approve',- arguments: { draftId: 'another-draft', checksum: 'another-checksum' },- },- context: { executeTool },- });+ await call!.complete({+ output: {+ decision: 'approve',+ arguments: { draftId: 'another-draft', checksum: 'another-checksum' },+ },+ context: { executeTool },+ });- expect(executeTool).toHaveBeenCalledTimes(1);- expect(executeTool).toHaveBeenCalledWith({- toolName: 'save_snapshot',- args: proposal.arguments,- });- });+ expect(executeTool).toHaveBeenCalledTimes(1);+ expect(executeTool).toHaveBeenCalledWith({+ toolName,+ args: proposal.arguments,+ });+ },+ );it.each([['an unknown decision', { decision: 'maybe' }],diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/propose-tool-call.pausing-tool.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/propose-tool-call.pausing-tool.tsindex 4c31e5a15d2..760a6da2bdd 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/propose-tool-call.pausing-tool.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/propose-tool-call.pausing-tool.ts@@ -3,6 +3,7 @@ import isEqual from 'lodash.isequal';import {buildFallbackProposedToolCall,PROPOSED_TOOL_CALL_TEMPLATES,+ isFrontComponentProposedToolCall,type ProposeToolCallToolInput,type ProposeToolCallToolResult,type ProposedToolCall,@@ -55,7 +56,6 @@ const proposedToolCallSchema: z.ZodType<ProposedToolCall> = z.object({arguments: z.record(z.string(), z.unknown()),template: z.enum(PROPOSED_TOOL_CALL_TEMPLATES),alternativeToolNames: z.array(z.string()).optional(),- areArgumentsEditable: z.boolean().optional(),objectNameSingular: z.string().optional(),recordId: z.string().optional(),currentValues: z.record(z.string(), z.unknown()).optional(),@@ -133,7 +133,7 @@ const buildApprovedArguments = (proposal: ProposedToolCall,editedArguments: Record<string, unknown> | undefined,): Record<string, unknown> => {- if (proposal.areArgumentsEditable === false) {+ if (isFrontComponentProposedToolCall(proposal)) {return proposal.arguments;}diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/utils/__tests__/resolve-proposed-tool-call.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/utils/__tests__/resolve-proposed-tool-call.util.spec.tsindex 3f98c1515f4..3332e3a68f1 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/utils/__tests__/resolve-proposed-tool-call.util.spec.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/utils/__tests__/resolve-proposed-tool-call.util.spec.ts@@ -1,3 +1,5 @@+import { ToolCategory } from 'twenty-shared/ai';+import { PUBLISH_FRONT_COMPONENT_TOOL } from 'src/engine/metadata-modules/ai/ai-front-component/constants/publish-front-component-tool.constant';import { type ToolIndexEntry } from 'src/engine/core-modules/tool-provider/types/tool-index-entry.type';import { resolveProposedToolCall } from 'src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/utils/resolve-proposed-tool-call.util';@@ -33,8 +35,20 @@ const EMAIL_BODY = {content: [{ type: 'paragraph', content: [{ type: 'text', text: 'Hi' }] }],};+const PUBLISH_TOOL_ENTRY: ToolIndexEntry = {+ ...PUBLISH_FRONT_COMPONENT_TOOL,+ label: 'Save component',+ description: '',+ category: ToolCategory.ACTION,+ executionRef: {+ kind: 'static',+ toolId: PUBLISH_FRONT_COMPONENT_TOOL.name,+ },+};+const findTool = async (toolName: string) =>[+ PUBLISH_TOOL_ENTRY,buildCrudEntry('create_one_opportunity', 'create_one'),buildCrudEntry('update_one_opportunity', 'update_one'),buildCrudEntry('delete_one_opportunity', 'delete_one'),@@ -64,36 +78,53 @@ const foundRecord = (record: Record<string, unknown>) =>});describe('resolveProposedToolCall', () => {- it('takes the component publication editing policy from the registered tool', async () => {- const tool: ToolIndexEntry = {- ...PUBLISH_FRONT_COMPONENT_TOOL,- label: 'Save component',- description: '',- category: 'ACTION' as ToolIndexEntry['category'],- executionRef: {- kind: 'static',- toolId: PUBLISH_FRONT_COMPONENT_TOOL.name,- },- };+ it('takes the component publication template from the registered tool', async () => {const resolution = await resolveProposedToolCall({input: {- toolName: tool.name,+ toolName: PUBLISH_TOOL_ENTRY.name,arguments: { draftId: RECORD_ID, checksum: 'reviewed-checksum' },summary: 'Save the reviewed component',},- findTool: async () => tool,+ findTool,executeTool: jest.fn(),});expect(resolution).toMatchObject({proposal: {- toolName: tool.name,- areArgumentsEditable: false,+ toolName: PUBLISH_TOOL_ENTRY.name,+ template: 'frontComponent',arguments: { draftId: RECORD_ID, checksum: 'reviewed-checksum' },},});});+ it.each([+ { draftId: undefined, checksum: 'reviewed-checksum' },+ { draftId: '', checksum: 'reviewed-checksum' },+ { draftId: 42, checksum: 'reviewed-checksum' },+ { draftId: RECORD_ID, checksum: undefined },+ { draftId: RECORD_ID, checksum: '' },+ { draftId: RECORD_ID, checksum: 42 },+ ])(+ 'refuses a component publication with invalid arguments %j',+ async (toolArguments) => {+ const resolution = await resolveProposedToolCall({+ input: {+ toolName: PUBLISH_TOOL_ENTRY.name,+ arguments: toolArguments,+ summary: 'Save the reviewed component',+ },+ findTool,+ executeTool: jest.fn(),+ });++ expect(resolution).toEqual({+ error:+ 'arguments.draftId and arguments.checksum must identify the component draft.',+ });+ },+ );+it('refuses a tool the proposer cannot call', async () => {expect(await resolveProposedToolCall({diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/utils/resolve-proposed-tool-call.util.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/utils/resolve-proposed-tool-call.util.tsindex 7f2b3242548..5b7f8f82910 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/utils/resolve-proposed-tool-call.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/pausing-tools/utils/resolve-proposed-tool-call.util.ts@@ -92,21 +92,29 @@ export const resolveProposedToolCall = async ({};}- const {- template = 'generic',- alternativeToolNames,- areArgumentsEditable,- } = toolIndexEntry.approval ?? {};+ const { template = 'generic', alternativeToolNames } =+ toolIndexEntry.approval ?? {};const baseProposal = {toolName,toolLabel: toolIndexEntry.label,summary,arguments: input.arguments,- ...(isDefined(areArgumentsEditable) ? { areArgumentsEditable } : {}),...(isNonEmptyArray(alternativeToolNames) ? { alternativeToolNames } : {}),};switch (template) {+ case 'frontComponent': {+ const { draftId, checksum } = baseProposal.arguments;++ if (!isNonEmptyString(draftId) || !isNonEmptyString(checksum)) {+ return {+ error:+ 'arguments.draftId and arguments.checksum must identify the component draft.',+ };+ }++ return { proposal: { ...baseProposal, template } };+ }case 'email':return buildEmailProposal(baseProposal);case 'recordCreate':diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-front-component/constants/publish-front-component-tool.constant.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-front-component/constants/publish-front-component-tool.constant.tsindex 123ca6c9ed5..223b111f0cb 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-front-component/constants/publish-front-component-tool.constant.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-front-component/constants/publish-front-component-tool.constant.ts@@ -4,5 +4,5 @@ import { type ToolIndexEntry } from 'src/engine/core-modules/tool-provider/typesexport const PUBLISH_FRONT_COMPONENT_TOOL = {name: PUBLISH_FRONT_COMPONENT_TOOL_NAME,- approval: { template: 'generic', areArgumentsEditable: false },+ approval: { template: 'frontComponent' },} as const satisfies Pick<ToolIndexEntry, 'name' | 'approval'>;diff --git a/packages/twenty-shared/src/ai/constants/proposed-tool-call-templates.const.ts b/packages/twenty-shared/src/ai/constants/proposed-tool-call-templates.const.tsindex 264c231367f..97e33bfe878 100644--- a/packages/twenty-shared/src/ai/constants/proposed-tool-call-templates.const.ts+++ b/packages/twenty-shared/src/ai/constants/proposed-tool-call-templates.const.ts@@ -3,5 +3,6 @@ export const PROPOSED_TOOL_CALL_TEMPLATES = ['recordUpdate','recordDelete','email',+ 'frontComponent','generic',] as const;diff --git a/packages/twenty-shared/src/ai/index.ts b/packages/twenty-shared/src/ai/index.tsindex 06d412d09d4..bafaf644f71 100644--- a/packages/twenty-shared/src/ai/index.ts+++ b/packages/twenty-shared/src/ai/index.ts@@ -121,6 +121,7 @@ export { isAiModelTier } from './utils/is-ai-model-tier.util';export { isAiSdkPackage } from './utils/is-ai-sdk-package.util';export { isCompleteWorkspaceSetupToolPart } from './utils/is-complete-workspace-setup-tool-part.util';export { isDataResidency } from './utils/is-data-residency.util';+export { isFrontComponentProposedToolCall } from './utils/is-front-component-proposed-tool-call.util';export { isNoReplyToolPart } from './utils/is-no-reply-tool-part.util';export { isPausingToolPart } from './utils/is-pausing-tool-part.util';export { isSilentAgentChatMessageParts } from './utils/is-silent-agent-chat-message-parts.util';diff --git a/packages/twenty-shared/src/ai/types/ProposedToolCall.ts b/packages/twenty-shared/src/ai/types/ProposedToolCall.tsindex 51a687452fd..099778bc7dc 100644--- a/packages/twenty-shared/src/ai/types/ProposedToolCall.ts+++ b/packages/twenty-shared/src/ai/types/ProposedToolCall.ts@@ -9,7 +9,6 @@ export type ProposedToolCall = {arguments: Record<string, unknown>;template: ProposedToolCallTemplate;alternativeToolNames?: string[];- areArgumentsEditable?: boolean;objectNameSingular?: string;recordId?: string;currentValues?: Record<string, unknown>;diff --git a/packages/twenty-shared/src/ai/types/ToolApproval.ts b/packages/twenty-shared/src/ai/types/ToolApproval.tsindex 6c672bed621..5017e08c70d 100644--- a/packages/twenty-shared/src/ai/types/ToolApproval.ts+++ b/packages/twenty-shared/src/ai/types/ToolApproval.ts@@ -5,5 +5,4 @@ import { type ProposedToolCallTemplate } from '@/ai/types/ProposedToolCallTemplaexport type ToolApproval = {template: ProposedToolCallTemplate;alternativeToolNames?: string[];- areArgumentsEditable?: boolean;};diff --git a/packages/twenty-shared/src/ai/utils/is-front-component-proposed-tool-call.util.ts b/packages/twenty-shared/src/ai/utils/is-front-component-proposed-tool-call.util.tsnew file mode 100644index 00000000000..c8530b71cea--- /dev/null+++ b/packages/twenty-shared/src/ai/utils/is-front-component-proposed-tool-call.util.ts@@ -0,0 +1,10 @@+import { PUBLISH_FRONT_COMPONENT_TOOL_NAME } from '@/ai/constants/publish-front-component-tool-name.const';+import { type ProposedToolCall } from '@/ai/types/ProposedToolCall';++// Stored publication proposals may predate the frontComponent template.+export const isFrontComponentProposedToolCall = ({+ template,+ toolName,+}: Pick<ProposedToolCall, 'template' | 'toolName'>): boolean =>+ template === 'frontComponent' ||+ (template === 'generic' && toolName === PUBLISH_FRONT_COMPONENT_TOOL_NAME);