Skip to content

The open alternative to Salesforce, designed for AI.

Use serialize-javascript for JSON-LD serialization on twenty-website (#21223)

Abdullah.d3a1781a5939
diff --git a/packages/twenty-website/package.json b/packages/twenty-website/package.json
index b06a4fa264b..37ed49cddc2 100644
--- a/packages/twenty-website/package.json
+++ b/packages/twenty-website/package.json
@@ -33,6 +33,7 @@
"react-dom": "19.2.3",
"react-markdown": "^10.1.0",
"remark-gfm": "^4.0.1",
+ "serialize-javascript": "^6.0.2",
"sharp": "^0.33.5",
"stripe": "^20.3.1",
"three": "^0.183.2",
@@ -51,6 +52,7 @@
"@types/node": "^20",
"@types/react": "^19",
"@types/react-dom": "^19",
+ "@types/serialize-javascript": "^5.0.4",
"@types/three": "^0.183.1",
"babel-plugin-react-compiler": "1.0.0",
"jest": "29.7.0",
diff --git a/packages/twenty-website/src/lib/seo/JsonLd.tsx b/packages/twenty-website/src/lib/seo/JsonLd.tsx
index c26817204d4..395f2ca5888 100644
--- a/packages/twenty-website/src/lib/seo/JsonLd.tsx
+++ b/packages/twenty-website/src/lib/seo/JsonLd.tsx
@@ -1,3 +1,5 @@
+import serialize from 'serialize-javascript';
+
type JsonLdPrimitive = boolean | number | string | null;
export type JsonLdValue =
@@ -5,13 +7,10 @@ export type JsonLdValue =
| JsonLdValue[]
| { [key: string]: JsonLdValue | undefined };
-const serializeJsonLd = (data: JsonLdValue): string =>
- JSON.stringify(data).replace(/</g, '\\u003c');
-
export function JsonLd({ data }: { data: JsonLdValue }) {
return (
<script
- dangerouslySetInnerHTML={{ __html: serializeJsonLd(data) }}
+ dangerouslySetInnerHTML={{ __html: serialize(data, { isJSON: true }) }}
type="application/ld+json"
/>
);
diff --git a/yarn.lock b/yarn.lock
index 975d6917b7d..a25c9213b9d 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -23398,6 +23398,13 @@ __metadata:
languageName: node
linkType: hard
+"@types/serialize-javascript@npm:^5.0.4":
+ version: 5.0.4
+ resolution: "@types/serialize-javascript@npm:5.0.4"
+ checksum: 10c0/606e2e65a5958df2379ad6d12edc883faa358eb9edbc86a6852545d5bb62ec212aec4c4741ee67d1842d00a9f537ee786070b74ee6d7a1b92c27c4f3afc5508d
+ languageName: node
+ linkType: hard
+
"@types/serve-index@npm:^1.9.1":
version: 1.9.4
resolution: "@types/serve-index@npm:1.9.4"
@@ -56044,6 +56051,7 @@ __metadata:
"@types/node": "npm:^20"
"@types/react": "npm:^19"
"@types/react-dom": "npm:^19"
+ "@types/serialize-javascript": "npm:^5.0.4"
"@types/three": "npm:^0.183.1"
"@wyw-in-js/babel-preset": "npm:^0.8.1"
babel-plugin-react-compiler: "npm:1.0.0"
@@ -56057,6 +56065,7 @@ __metadata:
react-dom: "npm:19.2.3"
react-markdown: "npm:^10.1.0"
remark-gfm: "npm:^4.0.1"
+ serialize-javascript: "npm:^6.0.2"
sharp: "npm:^0.33.5"
stripe: "npm:^20.3.1"
three: "npm:^0.183.2"