The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Fix transcript status placement in the call recording transcript widget (#28401)
nitind434a733d066
diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/CallRecordingTranscriptBody.tsx b/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/CallRecordingTranscriptBody.tsxindex 0be91a82c12..cfa861bec90 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/CallRecordingTranscriptBody.tsx+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/CallRecordingTranscriptBody.tsx@@ -1,5 +1,6 @@import { CallRecordingAudioPlayer } from '@/page-layout/widgets/call-recording-transcript/components/CallRecordingAudioPlayer';import { type CallRecordingPlaybackMedia } from '@/page-layout/widgets/call-recording/types/CallRecordingPlaybackMedia';+import { CallRecordingStatusDisplay } from '@/page-layout/widgets/call-recording/components/CallRecordingStatusDisplay';import { CallRecordingWidgetEmptyStateDisplay } from '@/page-layout/widgets/call-recording/components/CallRecordingWidgetEmptyStateDisplay';import { CallRecordingWidgetForbiddenDisplay } from '@/page-layout/widgets/call-recording/components/CallRecordingWidgetForbiddenDisplay';import { type WidgetCallRecordingCandidate } from '@/page-layout/widgets/call-recording/types/WidgetCallRecordingCandidate';@@ -15,13 +16,25 @@ import { styled } from '@linaria/react';import { t } from '@lingui/core/macro';import { useState } from 'react';import { type CallRecordingParsedTranscriptEntry } from 'twenty-shared/types';-import { isDefined } from 'twenty-shared/utils';+import { isDefined, isNonEmptyArray } from 'twenty-shared/utils';+import { themeCssVariables } from 'twenty-ui/theme';-const StyledRecordingLayout = styled.div`- display: grid;- flex: 1;+const StyledRecordingLayout = styled.div<{ hasTranscriptEntries: boolean }>`+ display: ${({ hasTranscriptEntries }) =>+ hasTranscriptEntries ? 'grid' : 'flex'};+ flex: ${({ hasTranscriptEntries }) => (hasTranscriptEntries ? '1' : 'none')};+ flex-direction: column;grid-template-rows: auto minmax(0, 1fr);- min-height: 0;+ min-height: ${({ hasTranscriptEntries }) =>+ hasTranscriptEntries ? '0' : '100%'};+`;++const StyledStatusBelowMedia = styled.div`+ display: flex;+ flex: 1;+ flex-direction: column;+ justify-content: center;+ padding: ${themeCssVariables.spacing[6]} 0;`;type CallRecordingTranscriptBodyProps = {@@ -52,6 +65,25 @@ export const CallRecordingTranscriptBody = ({INITIAL_CALL_RECORDING_TRANSCRIPT_PLAYBACK_POSITION,);+ const [pinnedPlaybackMedia, setPinnedPlaybackMedia] = useState(playbackMedia);++ const isPinnedPlaybackMediaCurrent =+ pinnedPlaybackMedia?.fileId === playbackMedia?.fileId &&+ pinnedPlaybackMedia?.kind === playbackMedia?.kind;++ if (!isPinnedPlaybackMediaCurrent) {+ setPinnedPlaybackMedia(playbackMedia);+ }++ const displayedPlaybackMedia = isPinnedPlaybackMediaCurrent+ ? pinnedPlaybackMedia+ : playbackMedia;++ const handleRetry = async () => {+ await refetchCallRecording();+ setPinnedPlaybackMedia(undefined);+ };+if (isDefined(restriction)) {return <CallRecordingWidgetForbiddenDisplay restriction={restriction} />;}@@ -74,7 +106,7 @@ export const CallRecordingTranscriptBody = ({);}- if (!isDefined(playbackMedia)) {+ if (!isDefined(displayedPlaybackMedia)) {return (<CallRecordingTranscriptContentcallRecording={callRecording}@@ -83,6 +115,25 @@ export const CallRecordingTranscriptBody = ({);}+ const mediaPlayer =+ displayedPlaybackMedia.kind === 'video' ? (+ <CallRecordingVideoPlayer+ key={displayedPlaybackMedia.fileId}+ ref={setMediaElement}+ src={displayedPlaybackMedia.url}+ onRetry={handleRetry}+ />+ ) : (+ <CallRecordingAudioPlayer+ key={displayedPlaybackMedia.fileId}+ ref={setMediaElement}+ src={displayedPlaybackMedia.url}+ onRetry={handleRetry}+ />+ );++ const hasTranscriptEntries = isNonEmptyArray(transcriptEntries);+const playback = isDefined(mediaElement)? {position: entryPlaybackPosition,@@ -94,32 +145,27 @@ export const CallRecordingTranscriptBody = ({: undefined;return (- <StyledRecordingLayout>+ <StyledRecordingLayout hasTranscriptEntries={hasTranscriptEntries}><CallRecordingTranscriptPlaybackEffectmediaElement={mediaElement}timedItems={transcriptEntries}onPlaybackPositionChange={setEntryPlaybackPosition}/>- {playbackMedia.kind === 'video' ? (- <CallRecordingVideoPlayer- key={playbackMedia.url}- ref={setMediaElement}- src={playbackMedia.url}- onRetry={refetchCallRecording}+ {mediaPlayer}+ {hasTranscriptEntries ? (+ <CallRecordingTranscriptContent+ callRecording={callRecording}+ transcriptEntries={transcriptEntries}+ playback={playback}/>) : (- <CallRecordingAudioPlayer- key={playbackMedia.url}- ref={setMediaElement}- src={playbackMedia.url}- onRetry={refetchCallRecording}- />+ <StyledStatusBelowMedia>+ <CallRecordingStatusDisplay+ callRecording={callRecording}+ artifactType="transcript"+ />+ </StyledStatusBelowMedia>)}- <CallRecordingTranscriptContent- callRecording={callRecording}- transcriptEntries={transcriptEntries}- playback={playback}- /></StyledRecordingLayout>);};diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/CallRecordingTranscriptContent.tsx b/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/CallRecordingTranscriptContent.tsxindex 1c1b246f9d5..519d63c5320 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/CallRecordingTranscriptContent.tsx+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/CallRecordingTranscriptContent.tsx@@ -7,6 +7,7 @@ import { type CallRecordingParsedTranscriptEntry } from 'twenty-shared/types';import { isNonEmptyArray } from 'twenty-shared/utils';const StyledEmptyStateScrollContainer = styled.div`+ flex: 1;min-height: 0;overflow-y: auto;`;diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/__stories__/CallRecordingTranscriptBody.stories.tsx b/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/__stories__/CallRecordingTranscriptBody.stories.tsxindex 75ea1c91809..fed7960d122 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/__stories__/CallRecordingTranscriptBody.stories.tsx+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording-transcript/components/__stories__/CallRecordingTranscriptBody.stories.tsx@@ -261,6 +261,11 @@ const audioCallRecording: WidgetCallRecordingCandidate = {],};+const recordedPendingTranscriptCallRecording: WidgetCallRecordingCandidate = {+ ...recordedCallRecording,+ transcript: { status: 'PENDING' },+};+const unplayableRecordedCallRecording: WidgetCallRecordingCandidate = {...recordedCallRecording,video: [@@ -474,6 +479,22 @@ export const WithVideo: Story = {},};+export const WithVideoPendingTranscript: Story = {+ args: {+ callRecording: recordedPendingTranscriptCallRecording,+ loading: false,+ error: undefined,+ restriction: undefined,+ },+ play: async ({ canvasElement }) => {+ const canvas = within(canvasElement);++ await canvas.findByText('Preparing Transcript');++ expect(canvasElement.querySelector('video')).toBeInTheDocument();+ },+};+export const PlaybackError: Story = {args: {callRecording: unplayableRecordedCallRecording,diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingForWidget.ts b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingForWidget.tsindex 97c95e2396e..2388228cb25 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingForWidget.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingForWidget.ts@@ -84,7 +84,9 @@ export const useCallRecordingForWidget = ({return {callRecording,- loading: callRecordingIdLoading || callRecordingLoading,+ loading:+ (callRecordingIdLoading && !isDefined(callRecordingId)) ||+ (callRecordingLoading && !isDefined(callRecording)),error: callRecordingIdError ?? callRecordingError,restriction,refetchCallRecording,diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingWidgetCount.ts b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingWidgetCount.tsindex a587282b439..9262ae9d162 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingWidgetCount.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/hooks/useCallRecordingWidgetCount.ts@@ -50,7 +50,7 @@ export const useCallRecordingWidgetCount = ({return {callRecordingsCount:callRecordingsTotalCount ?? callRecordingCountRecords.length,- loading,+ loading: loading && !isDefined(callRecordingsTotalCount),error,refetchCallRecordingsCount,};diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/types/CallRecordingPlaybackMedia.ts b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/types/CallRecordingPlaybackMedia.tsindex 6377dbf3ebf..46a38cc0cb2 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/types/CallRecordingPlaybackMedia.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/types/CallRecordingPlaybackMedia.ts@@ -1,4 +1,5 @@export type CallRecordingPlaybackMedia = {+ fileId: string;url: string;kind: 'video' | 'audio';};diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/__tests__/getCallRecordingPlaybackMedia.test.ts b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/__tests__/getCallRecordingPlaybackMedia.test.tsindex abbd54fc596..21d4a961782 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/__tests__/getCallRecordingPlaybackMedia.test.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/__tests__/getCallRecordingPlaybackMedia.test.ts@@ -15,13 +15,13 @@ describe('getCallRecordingPlaybackMedia', () => {it('returns video when only video is available', () => {expect(getCallRecordingPlaybackMedia({ video: [makeFile(VIDEO_URL)] }),- ).toEqual({ url: VIDEO_URL, kind: 'video' });+ ).toEqual({ fileId: 'recording-file', url: VIDEO_URL, kind: 'video' });});it('returns audio when only audio is available', () => {expect(getCallRecordingPlaybackMedia({ audio: [makeFile(AUDIO_URL)] }),- ).toEqual({ url: AUDIO_URL, kind: 'audio' });+ ).toEqual({ fileId: 'recording-file', url: AUDIO_URL, kind: 'audio' });});it('prefers video when both are available', () => {@@ -30,7 +30,7 @@ describe('getCallRecordingPlaybackMedia', () => {video: [makeFile(VIDEO_URL)],audio: [makeFile(AUDIO_URL)],}),- ).toEqual({ url: VIDEO_URL, kind: 'video' });+ ).toEqual({ fileId: 'recording-file', url: VIDEO_URL, kind: 'video' });});it.each([@@ -53,7 +53,7 @@ describe('getCallRecordingPlaybackMedia', () => {video: [makeFile(url)],audio: [makeFile(AUDIO_URL)],}),- ).toEqual({ url: AUDIO_URL, kind: 'audio' });+ ).toEqual({ fileId: 'recording-file', url: AUDIO_URL, kind: 'audio' });},);@@ -62,12 +62,12 @@ describe('getCallRecordingPlaybackMedia', () => {getCallRecordingPlaybackMedia({video: [makeFile(), makeFile(' '), makeFile(VIDEO_URL)],}),- ).toEqual({ url: VIDEO_URL, kind: 'video' });+ ).toEqual({ fileId: 'recording-file', url: VIDEO_URL, kind: 'video' });expect(getCallRecordingPlaybackMedia({audio: [makeFile(), makeFile(' '), makeFile(AUDIO_URL)],}),- ).toEqual({ url: AUDIO_URL, kind: 'audio' });+ ).toEqual({ fileId: 'recording-file', url: AUDIO_URL, kind: 'audio' });});it('returns undefined when both files have blank urls', () => {diff --git a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/getCallRecordingPlaybackMedia.ts b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/getCallRecordingPlaybackMedia.tsindex 01003d90eba..f07df388302 100644--- a/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/getCallRecordingPlaybackMedia.ts+++ b/packages/twenty-front/src/modules/page-layout/widgets/call-recording/utils/getCallRecordingPlaybackMedia.ts@@ -10,12 +10,12 @@ export const getCallRecordingPlaybackMedia = (| undefined,): CallRecordingPlaybackMedia | undefined => {for (const kind of PLAYBACK_MEDIA_PRIORITY) {- const url = callRecording?.[kind]?.find((file) =>+ const playableFile = callRecording?.[kind]?.find((file) =>isNonEmptyString(file.url?.trim()),- )?.url;+ );- if (isNonEmptyString(url)) {- return { url, kind };+ if (isNonEmptyString(playableFile?.url)) {+ return { fileId: playableFile.fileId, url: playableFile.url, kind };}}