Skip to content

The open alternative to Salesforce, designed for AI.

rename sync-completion methods to avoid confusion with stage setters (#22138)

neo773dc371ef6e783
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts
index 6eb0a48162c..a67dbff139d 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts
@@ -72,7 +72,7 @@ export class CalendarEventsImportService {
);
if (!eventIdsToFetch || eventIdsToFetch.length === 0) {
- await this.calendarChannelSyncStatusService.markAsCompletedAndMarkAsCalendarEventListFetchPending(
+ await this.calendarChannelSyncStatusService.markAsCalendarEventSyncCompleted(
[calendarChannel.id],
workspaceId,
);
@@ -170,7 +170,7 @@ export class CalendarEventsImportService {
);
if (eventIdsToFetch.length < CALENDAR_EVENT_IMPORT_BATCH_SIZE) {
- await this.calendarChannelSyncStatusService.markAsCompletedAndMarkAsCalendarEventListFetchPending(
+ await this.calendarChannelSyncStatusService.markAsCalendarEventSyncCompleted(
[calendarChannel.id],
workspaceId,
);
diff --git a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-fetch-events.service.ts b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-fetch-events.service.ts
index 23cb8b5d381..cbbb4a46233 100644
--- a/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-fetch-events.service.ts
+++ b/packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-fetch-events.service.ts
@@ -87,7 +87,7 @@ export class CalendarFetchEventsService {
workspaceId,
);
} else {
- await this.calendarChannelSyncStatusService.markAsCompletedAndMarkAsCalendarEventListFetchPending(
+ await this.calendarChannelSyncStatusService.markAsCalendarEventSyncCompleted(
[calendarChannel.id],
workspaceId,
);
diff --git a/packages/twenty-server/src/modules/calendar/common/services/calendar-channel-sync-status.service.ts b/packages/twenty-server/src/modules/calendar/common/services/calendar-channel-sync-status.service.ts
index 730164b0dd5..6748f2df597 100644
--- a/packages/twenty-server/src/modules/calendar/common/services/calendar-channel-sync-status.service.ts
+++ b/packages/twenty-server/src/modules/calendar/common/services/calendar-channel-sync-status.service.ts
@@ -206,7 +206,7 @@ export class CalendarChannelSyncStatusService {
);
}
- public async markAsCompletedAndMarkAsCalendarEventListFetchPending(
+ public async markAsCalendarEventSyncCompleted(
calendarChannelIds: string[],
workspaceId: string,
) {
diff --git a/packages/twenty-server/src/modules/messaging/common/services/message-channel-sync-status.service.ts b/packages/twenty-server/src/modules/messaging/common/services/message-channel-sync-status.service.ts
index 8df3f9c0f65..753950110b7 100644
--- a/packages/twenty-server/src/modules/messaging/common/services/message-channel-sync-status.service.ts
+++ b/packages/twenty-server/src/modules/messaging/common/services/message-channel-sync-status.service.ts
@@ -217,7 +217,7 @@ export class MessageChannelSyncStatusService {
);
}
- public async markAsCompletedAndMarkAsMessagesListFetchPending(
+ public async markAsMessageSyncCompleted(
messageChannelIds: string[],
workspaceId: string,
) {
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-messages-import.service.spec.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-messages-import.service.spec.ts
index d56efe6819d..a3884c88b59 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-messages-import.service.spec.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-messages-import.service.spec.ts
@@ -78,9 +78,7 @@ describe('MessagingMessagesImportService', () => {
provide: MessageChannelSyncStatusService,
useValue: {
markAsMessagesImportOngoing: jest.fn().mockResolvedValue(undefined),
- markAsCompletedAndMarkAsMessagesListFetchPending: jest
- .fn()
- .mockResolvedValue(undefined),
+ markAsMessageSyncCompleted: jest.fn().mockResolvedValue(undefined),
markAsMessagesImportPending: jest.fn().mockResolvedValue(undefined),
},
},
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-list-fetch.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-list-fetch.service.ts
index 48d1ab64bb7..f3ac6c4e85d 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-list-fetch.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-list-fetch.service.ts
@@ -251,7 +251,7 @@ export class MessagingMessageListFetchService {
);
if (totalMessagesToImportCount === 0) {
- await this.messageChannelSyncStatusService.markAsCompletedAndMarkAsMessagesListFetchPending(
+ await this.messageChannelSyncStatusService.markAsMessageSyncCompleted(
[freshMessageChannel.id],
workspaceId,
);
diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts
index 6ca701aee19..7312fdd023d 100644
--- a/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts
+++ b/packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts
@@ -108,7 +108,7 @@ export class MessagingMessagesImportService {
);
if (!messageIdsToFetch?.length) {
- await this.messageChannelSyncStatusService.markAsCompletedAndMarkAsMessagesListFetchPending(
+ await this.messageChannelSyncStatusService.markAsMessageSyncCompleted(
[messageChannel.id],
workspaceId,
);
@@ -214,7 +214,7 @@ export class MessagingMessagesImportService {
}
if (messageIdsToFetch.length < messagesGetBatchSize) {
- await this.messageChannelSyncStatusService.markAsCompletedAndMarkAsMessagesListFetchPending(
+ await this.messageChannelSyncStatusService.markAsMessageSyncCompleted(
[messageChannel.id],
workspaceId,
);