The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Reject object names that are not stable under camelCase (#28978)
Félix Malfaitdd5a144a1723
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-name.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-name.util.tsindex 90d45a09f33..d14bfb3a669 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-name.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-name.util.ts@@ -9,6 +9,7 @@ import { type ObjectMetadataMinimalInformation } from 'src/engine/metadata-modulimport { ObjectMetadataExceptionCode } from 'src/engine/metadata-modules/object-metadata/object-metadata.exception';import { IDENTIFIER_MIN_CHAR_LENGTH } from 'src/engine/metadata-modules/utils/constants/identifier-min-char-length.constants';import { type UniversalFlatObjectMetadata } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/universal-flat-object-metadata.type';+import { camelCase } from 'src/utils/camel-case';const STARTS_WITH_LOWER_CASE_AND_CONTAINS_ONLY_CAPS_AND_LOWER_LETTERS_AND_NUMBER_STRING_REGEX =/^[a-z][a-zA-Z0-9]*$/;@@ -50,6 +51,16 @@ export const validateFlatObjectMetadataNames = ({userFriendlyMessage: msg`Name is not valid: it must start with lowercase letter and contain only alphanumeric letters`,value: name,});+ } else if (camelCase(name) !== name) {+ // GraphQL resolver and type names are derived through camelCase+ const camelCasedName = camelCase(name);++ errors.push({+ code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,+ message: `Name is not valid: it must be camelCase, e.g. "${camelCasedName}"`,+ userFriendlyMessage: msg`Name is not valid: it must be camelCase, e.g. "${camelCasedName}"`,+ value: name,+ });}if (RESERVED_METADATA_NAME_KEYWORDS.includes(name)) {diff --git a/packages/twenty-server/test/integration/metadata/suites/object-metadata/common/object-metadata-names-failing-tests-cases.ts b/packages/twenty-server/test/integration/metadata/suites/object-metadata/common/object-metadata-names-failing-tests-cases.tsindex c32f5169bde..590920fa289 100644--- a/packages/twenty-server/test/integration/metadata/suites/object-metadata/common/object-metadata-names-failing-tests-cases.ts+++ b/packages/twenty-server/test/integration/metadata/suites/object-metadata/common/object-metadata-names-failing-tests-cases.ts@@ -71,6 +71,30 @@ export const OBJECT_METADATA_NAMES_FAILING_TEST_CASES: EachTestingContext<Failin},},},+ {+ title: 'when nameSingular changes under camelCase',+ context: {+ input: { nameSingular: 'demandeGRU' },+ expected: {+ errorCode: 'METADATA_VALIDATION_FAILED',+ objectValidationMessages: [+ 'Name is not valid: it must be camelCase, e.g. "demandeGru"',+ ],+ },+ },+ },+ {+ title: 'when namePlural changes under camelCase',+ context: {+ input: { namePlural: 'demandesGRU' },+ expected: {+ errorCode: 'METADATA_VALIDATION_FAILED',+ objectValidationMessages: [+ 'Name is not valid: it must be camelCase, e.g. "demandesGru"',+ ],+ },+ },+ },{title: 'when namePlural is an empty string',context: {diff --git a/packages/twenty-server/test/integration/rest/utils/metadata-rest-api.util.ts b/packages/twenty-server/test/integration/rest/utils/metadata-rest-api.util.tsindex 1f6a1b4e215..7f2ee7c27c7 100644--- a/packages/twenty-server/test/integration/rest/utils/metadata-rest-api.util.ts+++ b/packages/twenty-server/test/integration/rest/utils/metadata-rest-api.util.ts@@ -1,3 +1,4 @@+import { faker } from '@faker-js/faker';import { createOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata.util';import { deleteOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/delete-one-field-metadata.util';import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';@@ -8,7 +9,7 @@ import { FieldMetadataType } from 'twenty-shared/types';export const NON_EXISTENT_UUID = '00000000-0000-4000-8000-000000000000';export const uniqueSuffix = (): string =>- Math.random().toString(36).slice(2, 10);+ faker.string.alpha({ length: 8, casing: 'lower' });export type CreateTestObjectInput = {nameSingular: string;