Skip to content

The open alternative to Salesforce, designed for AI.

perf(server): build universal identifier lookups once per cache rebuild (#27134)

Charles Bochetdeec1466a74f
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/services/workspace-flat-command-menu-item-map-cache.service.ts b/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/services/workspace-flat-command-menu-item-map-cache.service.ts
index f6abb773c32..d28a0d5b771 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/services/workspace-flat-command-menu-item-map-cache.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/services/workspace-flat-command-menu-item-map-cache.service.ts
@@ -44,6 +44,12 @@ export class WorkspaceFlatCommandMenuItemMapCacheService extends MetadataFlatEnt
createIdToUniversalIdentifierMap(frontComponents);
const pageLayoutIdToUniversalIdentifierMap =
createIdToUniversalIdentifierMap(pageLayouts);
+ const objectMetadataUniversalIdentifierById = Object.fromEntries(
+ objectMetadataIdToUniversalIdentifierMap,
+ );
+ const pageLayoutUniversalIdentifierById = Object.fromEntries(
+ pageLayoutIdToUniversalIdentifierMap,
+ );
const flatCommandMenuItemMaps = createEmptyFlatEntityMaps();
@@ -55,6 +61,8 @@ export class WorkspaceFlatCommandMenuItemMapCacheService extends MetadataFlatEnt
objectMetadataIdToUniversalIdentifierMap,
frontComponentIdToUniversalIdentifierMap,
pageLayoutIdToUniversalIdentifierMap,
+ objectMetadataUniversalIdentifierById,
+ pageLayoutUniversalIdentifierById,
});
addFlatEntityToFlatEntityMapsThroughMutationOrThrow({
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/from-command-menu-item-entity-to-flat-command-menu-item.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/from-command-menu-item-entity-to-flat-command-menu-item.util.ts
index 80732f27e88..fb4c87b41f4 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/from-command-menu-item-entity-to-flat-command-menu-item.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-command-menu-item/utils/from-command-menu-item-entity-to-flat-command-menu-item.util.ts
@@ -6,13 +6,19 @@ import { fromEntityToScalarEntity } from 'src/engine/metadata-modules/flat-entit
import { type FromEntityToFlatEntityArgs } from 'src/engine/workspace-cache/types/from-entity-to-flat-entity-args.type';
import { resolveManyToOneRelationIdsToUniversalIdentifiers } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/utils/resolve-many-to-one-relation-ids-to-universal-identifiers.util';
+type FromCommandMenuItemEntityToFlatCommandMenuItemArgs =
+ FromEntityToFlatEntityArgs<'commandMenuItem'> & {
+ objectMetadataUniversalIdentifierById: Partial<Record<string, string>>;
+ pageLayoutUniversalIdentifierById: Partial<Record<string, string>>;
+ };
+
export const fromCommandMenuItemEntityToFlatCommandMenuItem = (
- args: FromEntityToFlatEntityArgs<'commandMenuItem'>,
+ args: FromCommandMenuItemEntityToFlatCommandMenuItemArgs,
): FlatCommandMenuItem => {
const {
entity: commandMenuItemEntity,
- objectMetadataIdToUniversalIdentifierMap,
- pageLayoutIdToUniversalIdentifierMap,
+ objectMetadataUniversalIdentifierById,
+ pageLayoutUniversalIdentifierById,
} = args;
const commandMenuItemScalarEntity = fromEntityToScalarEntity({
@@ -29,12 +35,8 @@ export const fromCommandMenuItemEntityToFlatCommandMenuItem = (
const universalOverrides = isDefined(commandMenuItemEntity.overrides)
? fromCommandMenuItemOverridesToUniversalOverrides({
overrides: commandMenuItemEntity.overrides,
- objectMetadataUniversalIdentifierById: Object.fromEntries(
- objectMetadataIdToUniversalIdentifierMap.entries(),
- ),
- pageLayoutUniversalIdentifierById: Object.fromEntries(
- pageLayoutIdToUniversalIdentifierMap.entries(),
- ),
+ objectMetadataUniversalIdentifierById,
+ pageLayoutUniversalIdentifierById,
shouldThrowOnMissingIdentifier: false,
})
: null;
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-page-layout-widget/services/workspace-flat-page-layout-widget-map-cache.service.ts b/packages/twenty-server/src/engine/metadata-modules/flat-page-layout-widget/services/workspace-flat-page-layout-widget-map-cache.service.ts
index 701ebc0a484..80af4857ac4 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-page-layout-widget/services/workspace-flat-page-layout-widget-map-cache.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-page-layout-widget/services/workspace-flat-page-layout-widget-map-cache.service.ts
@@ -44,6 +44,9 @@ export class WorkspaceFlatPageLayoutWidgetMapCacheService extends MetadataFlatEn
createIdToUniversalIdentifierMap(applications);
const pageLayoutTabIdToUniversalIdentifierMap =
createIdToUniversalIdentifierMap(pageLayoutTabs);
+ const pageLayoutTabUniversalIdentifierById = Object.fromEntries(
+ pageLayoutTabIdToUniversalIdentifierMap,
+ );
const objectMetadataIdToUniversalIdentifierMap =
createIdToUniversalIdentifierMap(objectMetadatas);
const fieldMetadataUniversalIdentifierById = Object.fromEntries(
@@ -66,6 +69,7 @@ export class WorkspaceFlatPageLayoutWidgetMapCacheService extends MetadataFlatEn
pageLayoutTabIdToUniversalIdentifierMap,
objectMetadataIdToUniversalIdentifierMap,
fieldMetadataUniversalIdentifierById,
+ pageLayoutTabUniversalIdentifierById,
frontComponentUniversalIdentifierById,
viewUniversalIdentifierById,
});
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-page-layout-widget/utils/from-page-layout-widget-entity-to-flat-page-layout-widget.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-page-layout-widget/utils/from-page-layout-widget-entity-to-flat-page-layout-widget.util.ts
index 051c8ca1a48..5f7e921533c 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-page-layout-widget/utils/from-page-layout-widget-entity-to-flat-page-layout-widget.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-page-layout-widget/utils/from-page-layout-widget-entity-to-flat-page-layout-widget.util.ts
@@ -10,6 +10,7 @@ import { resolveManyToOneRelationIdsToUniversalIdentifiers } from 'src/engine/wo
type FromPageLayoutWidgetEntityToFlatPageLayoutWidgetArgs =
FromEntityToFlatEntityArgs<'pageLayoutWidget'> & {
fieldMetadataUniversalIdentifierById: Partial<Record<string, string>>;
+ pageLayoutTabUniversalIdentifierById: Partial<Record<string, string>>;
frontComponentUniversalIdentifierById?: Partial<Record<string, string>>;
viewFieldGroupUniversalIdentifierById?: Partial<Record<string, string>>;
viewUniversalIdentifierById?: Partial<Record<string, string>>;
@@ -20,8 +21,8 @@ export const fromPageLayoutWidgetEntityToFlatPageLayoutWidget = (
): FlatPageLayoutWidget => {
const {
entity: pageLayoutWidgetEntity,
- pageLayoutTabIdToUniversalIdentifierMap,
fieldMetadataUniversalIdentifierById,
+ pageLayoutTabUniversalIdentifierById,
frontComponentUniversalIdentifierById,
viewFieldGroupUniversalIdentifierById,
viewUniversalIdentifierById,
@@ -47,10 +48,6 @@ export const fromPageLayoutWidgetEntityToFlatPageLayoutWidget = (
viewUniversalIdentifierById,
});
- const pageLayoutTabUniversalIdentifierById = Object.fromEntries(
- pageLayoutTabIdToUniversalIdentifierMap.entries(),
- );
-
const universalOverrides = isDefined(pageLayoutWidgetEntity.overrides)
? fromPageLayoutWidgetOverridesToUniversalOverrides({
overrides: pageLayoutWidgetEntity.overrides,
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-view-field/services/workspace-flat-view-field-map-cache.service.ts b/packages/twenty-server/src/engine/metadata-modules/flat-view-field/services/workspace-flat-view-field-map-cache.service.ts
index 365ecdb68b9..8374080317a 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-view-field/services/workspace-flat-view-field-map-cache.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-view-field/services/workspace-flat-view-field-map-cache.service.ts
@@ -44,6 +44,9 @@ export class WorkspaceFlatViewFieldMapCacheService extends MetadataFlatEntityMap
createIdToUniversalIdentifierMap(views);
const viewFieldGroupIdToUniversalIdentifierMap =
createIdToUniversalIdentifierMap(viewFieldGroups);
+ const viewFieldGroupUniversalIdentifierById = Object.fromEntries(
+ viewFieldGroupIdToUniversalIdentifierMap,
+ );
const flatViewFieldMaps = createEmptyFlatEntityMaps();
@@ -54,6 +57,7 @@ export class WorkspaceFlatViewFieldMapCacheService extends MetadataFlatEntityMap
fieldMetadataIdToUniversalIdentifierMap,
viewIdToUniversalIdentifierMap,
viewFieldGroupIdToUniversalIdentifierMap,
+ viewFieldGroupUniversalIdentifierById,
});
addFlatEntityToFlatEntityMapsThroughMutationOrThrow({
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-view-field/utils/from-view-field-entity-to-flat-view-field.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-view-field/utils/from-view-field-entity-to-flat-view-field.util.ts
index 73bba4d7f14..2466c05170e 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-view-field/utils/from-view-field-entity-to-flat-view-field.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-view-field/utils/from-view-field-entity-to-flat-view-field.util.ts
@@ -6,10 +6,15 @@ import { fromViewFieldOverridesToUniversalOverrides } from 'src/engine/metadata-
import { type FromEntityToFlatEntityArgs } from 'src/engine/workspace-cache/types/from-entity-to-flat-entity-args.type';
import { resolveManyToOneRelationIdsToUniversalIdentifiers } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/utils/resolve-many-to-one-relation-ids-to-universal-identifiers.util';
+type FromViewFieldEntityToFlatViewFieldArgs =
+ FromEntityToFlatEntityArgs<'viewField'> & {
+ viewFieldGroupUniversalIdentifierById: Partial<Record<string, string>>;
+ };
+
export const fromViewFieldEntityToFlatViewField = (
- args: FromEntityToFlatEntityArgs<'viewField'>,
+ args: FromViewFieldEntityToFlatViewFieldArgs,
): FlatViewField => {
- const { entity: viewFieldEntity, viewFieldGroupIdToUniversalIdentifierMap } =
+ const { entity: viewFieldEntity, viewFieldGroupUniversalIdentifierById } =
args;
const viewFieldScalarEntity = fromEntityToScalarEntity({
@@ -23,10 +28,6 @@ export const fromViewFieldEntityToFlatViewField = (
...args,
});
- const viewFieldGroupUniversalIdentifierById = Object.fromEntries(
- viewFieldGroupIdToUniversalIdentifierMap.entries(),
- );
-
const universalOverrides = isDefined(viewFieldEntity.overrides)
? fromViewFieldOverridesToUniversalOverrides({
overrides: viewFieldEntity.overrides,
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-view/services/workspace-flat-view-map-cache.service.ts b/packages/twenty-server/src/engine/metadata-modules/flat-view/services/workspace-flat-view-map-cache.service.ts
index c80a0799bf3..aab05a6cf53 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-view/services/workspace-flat-view-map-cache.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-view/services/workspace-flat-view-map-cache.service.ts
@@ -76,6 +76,9 @@ export class WorkspaceFlatViewMapCacheService extends MetadataFlatEntityMapsCach
createIdToUniversalIdentifierMap(objectMetadatas);
const fieldMetadataIdToUniversalIdentifierMap =
createIdToUniversalIdentifierMap(fieldMetadatas);
+ const fieldMetadataUniversalIdentifierById = Object.fromEntries(
+ fieldMetadataIdToUniversalIdentifierMap,
+ );
const flatViewMaps = createEmptyFlatEntityMaps();
@@ -97,6 +100,7 @@ export class WorkspaceFlatViewMapCacheService extends MetadataFlatEntityMapsCach
applicationIdToUniversalIdentifierMap,
objectMetadataIdToUniversalIdentifierMap,
fieldMetadataIdToUniversalIdentifierMap,
+ fieldMetadataUniversalIdentifierById,
});
addFlatEntityToFlatEntityMapsThroughMutationOrThrow({
diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-view-entity-to-flat-view.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-view-entity-to-flat-view.util.ts
index 57ebb1148f8..19cd2a2b150 100644
--- a/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-view-entity-to-flat-view.util.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/flat-view/utils/from-view-entity-to-flat-view.util.ts
@@ -6,10 +6,14 @@ import { fromViewOverridesToUniversalOverrides } from 'src/engine/metadata-modul
import { type FromEntityToFlatEntityArgs } from 'src/engine/workspace-cache/types/from-entity-to-flat-entity-args.type';
import { resolveManyToOneRelationIdsToUniversalIdentifiers } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/utils/resolve-many-to-one-relation-ids-to-universal-identifiers.util';
+type FromViewEntityToFlatViewArgs = FromEntityToFlatEntityArgs<'view'> & {
+ fieldMetadataUniversalIdentifierById: Partial<Record<string, string>>;
+};
+
export const fromViewEntityToFlatView = (
- args: FromEntityToFlatEntityArgs<'view'>,
+ args: FromViewEntityToFlatViewArgs,
): FlatView => {
- const { entity: viewEntity, fieldMetadataIdToUniversalIdentifierMap } = args;
+ const { entity: viewEntity, fieldMetadataUniversalIdentifierById } = args;
const viewScalarEntity = fromEntityToScalarEntity({
metadataName: 'view',
@@ -25,9 +29,7 @@ export const fromViewEntityToFlatView = (
const universalOverrides = isDefined(viewEntity.overrides)
? fromViewOverridesToUniversalOverrides({
overrides: viewEntity.overrides,
- fieldMetadataUniversalIdentifierById: Object.fromEntries(
- fieldMetadataIdToUniversalIdentifierMap.entries(),
- ),
+ fieldMetadataUniversalIdentifierById,
shouldThrowOnMissingIdentifier: false,
})
: null;