The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
feat(run-agent): scope run-as to the member's role and keep the application on the context (#24089)
Abdul Rahmandfac4a8f7846
diff --git a/packages/twenty-docs/developers/extend/apps/logic/skills-and-agents.mdx b/packages/twenty-docs/developers/extend/apps/logic/skills-and-agents.mdxindex 6237863f2c4..fe4cde90276 100644--- a/packages/twenty-docs/developers/extend/apps/logic/skills-and-agents.mdx+++ b/packages/twenty-docs/developers/extend/apps/logic/skills-and-agents.mdx@@ -178,10 +178,13 @@ const { result } = await runAgent({});```-The run is then restricted to what **both** the agent's role and the member's-role allow, records it creates are attributed to that member, and the member's-row-level permissions apply. Omit the field for autonomous runs (scheduled-jobs, database-event triggers): those keep the agent's own role.+The run then acts with the **member's own role**: it can do whatever that+member can do and nothing more, records it creates are attributed to them, and+their row-level permissions apply. The agent's role does not participate — it+is the app's default for runs with nobody behind them. Omit the field for+autonomous runs (scheduled jobs, database-event triggers): those keep the+agent's own role. The acting application stays attached to the run's context+for provenance, without narrowing the member's permissions.Your app is responsible for mapping the person who triggered the run to aworkspace member. Naming one requires an app access token, and what a token maydiff --git a/packages/twenty-server/src/engine/core-modules/auth/types/workspace-auth-context.type.ts b/packages/twenty-server/src/engine/core-modules/auth/types/workspace-auth-context.type.tsindex 501ccd91dd8..81e5cbacd7b 100644--- a/packages/twenty-server/src/engine/core-modules/auth/types/workspace-auth-context.type.ts+++ b/packages/twenty-server/src/engine/core-modules/auth/types/workspace-auth-context.type.ts@@ -24,6 +24,7 @@ export interface UserWorkspaceAuthContext extends BaseWorkspaceAuthContext {workspaceMemberId: NonNullable<RawAuthContext['workspaceMemberId']>;workspaceMember: NonNullable<RawAuthContext['workspaceMember']>;application?: NonNullable<RawAuthContext['application']>;+ viaApplication?: NonNullable<RawAuthContext['application']>;}export interface ApplicationWorkspaceAuthContext extends BaseWorkspaceAuthContext {diff --git a/packages/twenty-server/src/engine/core-modules/auth/utils/__tests__/build-user-auth-context.util.spec.ts b/packages/twenty-server/src/engine/core-modules/auth/utils/__tests__/build-user-auth-context.util.spec.tsnew file mode 100644index 00000000000..23217f06967--- /dev/null+++ b/packages/twenty-server/src/engine/core-modules/auth/utils/__tests__/build-user-auth-context.util.spec.ts@@ -0,0 +1,44 @@+import { type RawAuthContext } from 'src/engine/core-modules/auth/types/raw-auth-context.type';+import { buildUserAuthContext } from 'src/engine/core-modules/auth/utils/build-user-auth-context.util';++const baseInput = {+ workspace: { id: 'workspace-1' } as NonNullable<RawAuthContext['workspace']>,+ userWorkspaceId: 'user-workspace-1',+ user: { id: 'user-1' } as NonNullable<RawAuthContext['user']>,+ workspaceMemberId: 'workspace-member-1',+ workspaceMember: { id: 'workspace-member-1' } as NonNullable<+ RawAuthContext['workspaceMember']+ >,+};++const application = {+ id: 'app-1',+ defaultRoleId: 'app-role-1',+} as NonNullable<RawAuthContext['application']>;++describe('buildUserAuthContext', () => {+ it('builds a user context without either application field by default', () => {+ const context = buildUserAuthContext(baseInput);++ expect(context.type).toBe('user');+ expect('application' in context).toBe(false);+ expect('viaApplication' in context).toBe(false);+ });++ it('carries a user-bound application on the application field', () => {+ const context = buildUserAuthContext({ ...baseInput, application });++ expect(context.application).toBe(application);+ expect('viaApplication' in context).toBe(false);+ });++ it('carries run-as provenance on viaApplication without touching application', () => {+ const context = buildUserAuthContext({+ ...baseInput,+ viaApplication: application,+ });++ expect(context.viaApplication).toBe(application);+ expect('application' in context).toBe(false);+ });+});diff --git a/packages/twenty-server/src/engine/core-modules/auth/utils/build-user-auth-context.util.ts b/packages/twenty-server/src/engine/core-modules/auth/utils/build-user-auth-context.util.tsindex 40878ed3412..04e588dc1fa 100644--- a/packages/twenty-server/src/engine/core-modules/auth/utils/build-user-auth-context.util.ts+++ b/packages/twenty-server/src/engine/core-modules/auth/utils/build-user-auth-context.util.ts@@ -10,6 +10,7 @@ type UserAuthContextInput = {workspaceMemberId: NonNullable<RawAuthContext['workspaceMemberId']>;workspaceMember: NonNullable<RawAuthContext['workspaceMember']>;application?: RawAuthContext['application'];+ viaApplication?: RawAuthContext['application'];};export const buildUserAuthContext = (@@ -23,5 +24,8 @@ export const buildUserAuthContext = (workspaceMemberId: input.workspaceMemberId,workspaceMember: input.workspaceMember,...(isDefined(input.application) ? { application: input.application } : {}),+ ...(isDefined(input.viaApplication)+ ? { viaApplication: input.viaApplication }+ : {}),};};diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-actor-context.service.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-actor-context.service.tsindex c021a2721c3..1a5b108cc89 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-actor-context.service.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-actor-context.service.ts@@ -4,6 +4,7 @@ import { type ActorMetadata, FieldActorSource } from 'twenty-shared/types';import { isDefined } from 'twenty-shared/utils';import { buildCreatedByFromFullNameMetadata } from 'src/engine/core-modules/actor/utils/build-created-by-from-full-name-metadata.util';+import { type FlatApplication } from 'src/engine/core-modules/application/types/flat-application.type';import { buildUserAuthContext } from 'src/engine/core-modules/auth/utils/build-user-auth-context.util';import { fromUserEntityToFlat } from 'src/engine/core-modules/user/utils/from-user-entity-to-flat.util';import { UserWorkspaceService } from 'src/engine/core-modules/user-workspace/user-workspace.service';@@ -126,9 +127,11 @@ export class AgentActorContextService {async buildRunAsWorkspaceMemberContext({workspaceMemberId,workspaceId,+ viaApplication,}: {workspaceMemberId: string;workspaceId: string;+ viaApplication?: FlatApplication;}): Promise<RunAsWorkspaceMemberContext> {const workspaceMember = await this.userWorkspaceService.getWorkspaceMember({workspaceMemberId,@@ -174,6 +177,7 @@ export class AgentActorContextService {user: fromUserEntityToFlat(userWorkspace.user),workspaceMemberId: workspaceMember.id,workspaceMember,+ viaApplication,}),roleId,};diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run.service.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run.service.tsindex 3c9a3fd5978..0995fbeb645 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run.service.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/services/agent-run.service.ts@@ -108,6 +108,7 @@ export class AgentRunService {requestUserWorkspaceId,requestWorkspaceMemberId,workspaceId: workspace.id,+ application,});const authContext: WorkspaceAuthContext = runAsContext?.authContext ?? {@@ -166,12 +167,14 @@ export class AgentRunService {requestUserWorkspaceId,requestWorkspaceMemberId,workspaceId,+ application,}: {runAsWorkspaceMemberId?: string;callerApplication?: FlatApplication;requestUserWorkspaceId: string | null;requestWorkspaceMemberId: string | null;workspaceId: string;+ application: FlatApplication;}): Promise<RunAsWorkspaceMemberContext | undefined> {if (!isDefined(runAsWorkspaceMemberId)) {return undefined;@@ -197,6 +200,7 @@ export class AgentRunService {return this.agentActorContextService.buildRunAsWorkspaceMemberContext({workspaceMemberId: runAsWorkspaceMemberId,workspaceId,+ viaApplication: application,});}}diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/__tests__/build-agent-role-permission-config.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/__tests__/build-agent-role-permission-config.util.spec.tsindex c313e843cbf..c3eefefa7d0 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/__tests__/build-agent-role-permission-config.util.spec.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/__tests__/build-agent-role-permission-config.util.spec.ts@@ -7,16 +7,16 @@ describe('buildAgentRolePermissionConfig', () => {).toEqual({ intersectionOf: ['agent-role-id'] });});- it('intersects with the run-as role, agent role first', () => {+ it('uses the member role alone in run-as mode', () => {expect(buildAgentRolePermissionConfig({agentRoleId: 'agent-role-id',runAsRoleId: 'run-as-role-id',}),- ).toEqual({ intersectionOf: ['agent-role-id', 'run-as-role-id'] });+ ).toEqual({ intersectionOf: ['run-as-role-id'] });});- it('does not repeat the role when the member already has the agent role', () => {+ it('does not involve the agent role even when the member holds it', () => {expect(buildAgentRolePermissionConfig({agentRoleId: 'agent-role-id',diff --git a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/build-agent-role-permission-config.util.ts b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/build-agent-role-permission-config.util.tsindex 59396fc2558..43a9ec664eb 100644--- a/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/build-agent-role-permission-config.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/ai/ai-agent-execution/utils/build-agent-role-permission-config.util.ts@@ -9,9 +9,9 @@ export const buildAgentRolePermissionConfig = ({agentRoleId: string;runAsRoleId?: string;}): RolePermissionConfig => {- if (!isDefined(runAsRoleId) || runAsRoleId === agentRoleId) {- return { intersectionOf: [agentRoleId] };+ if (isDefined(runAsRoleId)) {+ return { intersectionOf: [runAsRoleId] };}- return { intersectionOf: [agentRoleId, runAsRoleId] };+ return { intersectionOf: [agentRoleId] };};diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/resolve-role-ids-from-auth-context.util.spec.ts b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/resolve-role-ids-from-auth-context.util.spec.tsindex 25f92d2c7cc..9b79a08ce88 100644--- a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/resolve-role-ids-from-auth-context.util.spec.ts+++ b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/resolve-role-ids-from-auth-context.util.spec.ts@@ -53,6 +53,15 @@ describe('resolveRoleIdsFromAuthContext', () => {]);});+ it('should ignore viaApplication: run-as provenance never narrows permissions', () => {+ const runAsContext = {+ ...buildUserContext(),+ viaApplication: { defaultRoleId: APPLICATION_ROLE_ID },+ } as WorkspaceAuthContext;++ expect(resolve(runAsContext)).toEqual([USER_ROLE_ID]);+ });+it('should resolve nothing when the user has no role, even with an application', () => {const contextWithUnknownUserWorkspace = {...buildUserContext({ defaultRoleId: APPLICATION_ROLE_ID }),