The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Stop Chip from clipping its start and end elements (#28065)
Raphaël Bosie01ce170d8e3
diff --git a/packages/twenty-front/src/modules/ai/components/internal/AiChatEmailRecipientsRow.tsx b/packages/twenty-front/src/modules/ai/components/internal/AiChatEmailRecipientsRow.tsxindex d4d721468dc..7e48d223387 100644--- a/packages/twenty-front/src/modules/ai/components/internal/AiChatEmailRecipientsRow.tsx+++ b/packages/twenty-front/src/modules/ai/components/internal/AiChatEmailRecipientsRow.tsx@@ -94,7 +94,7 @@ export const AiChatEmailRecipientsRow = ({endElement={disabled ? undefined : (<LightIconButton- size="sm"+ size="xs"aria-label={t`Remove ${address}`}onClick={() =>onChange(diff --git a/packages/twenty-ui/src/primitives/data-display/Chip/Chip.module.scss b/packages/twenty-ui/src/primitives/data-display/Chip/Chip.module.scssindex 40d3f88261b..cea711681b9 100644--- a/packages/twenty-ui/src/primitives/data-display/Chip/Chip.module.scss+++ b/packages/twenty-ui/src/primitives/data-display/Chip/Chip.module.scss@@ -21,8 +21,8 @@& > svg {flex-shrink: 0;}- &[data-truncate] {- overflow: hidden;+ &[data-truncate] > .label {+ min-inline-size: 0;}&[data-size='md'] {block-size: var(--t-spacing-4);diff --git a/packages/twenty-ui/src/primitives/data-display/Chip/Chip.module.scss.d.ts b/packages/twenty-ui/src/primitives/data-display/Chip/Chip.module.scss.d.tsindex 2614dbbb3a6..8f65c754816 100644--- a/packages/twenty-ui/src/primitives/data-display/Chip/Chip.module.scss.d.ts+++ b/packages/twenty-ui/src/primitives/data-display/Chip/Chip.module.scss.d.ts@@ -1,5 +1,6 @@declare const classNames: {readonly chip: 'chip';+ readonly label: 'label';readonly endElementDivider: 'endElementDivider';};export default classNames;diff --git a/packages/twenty-ui/src/primitives/data-display/Chip/Chip.tsx b/packages/twenty-ui/src/primitives/data-display/Chip/Chip.tsxindex 1955ec0f206..00ce16603d2 100644--- a/packages/twenty-ui/src/primitives/data-display/Chip/Chip.tsx+++ b/packages/twenty-ui/src/primitives/data-display/Chip/Chip.tsx@@ -65,6 +65,7 @@ export const Chip = ({<OverflowingTextWithTooltip{...textProps}render={<span />}+ className={styles.label}style={size === 'md' ? MEDIUM_LABEL_STYLE : undefined}truncate={truncate}tooltipDelay={tooltipDelay}diff --git a/packages/twenty-ui/src/primitives/data-display/Chip/__stories__/Chip.stories.tsx b/packages/twenty-ui/src/primitives/data-display/Chip/__stories__/Chip.stories.tsxindex 629d6b483e0..270657d96bf 100644--- a/packages/twenty-ui/src/primitives/data-display/Chip/__stories__/Chip.stories.tsx+++ b/packages/twenty-ui/src/primitives/data-display/Chip/__stories__/Chip.stories.tsx@@ -247,7 +247,16 @@ export const ContentAndSlots: Story = {play: async ({ canvasElement }) => {const canvas = within(canvasElement);await expect(canvas.getByText('Rich content')).toBeVisible();- await userEvent.click(canvas.getByRole('button', { name: 'Remove' }));+ const removeButton = canvas.getByRole('button', { name: 'Remove' });+ const chip = removeButton.parentElement;+ if (!isDefined(chip)) {+ throw new Error('Chip end element must have a root');+ }+ await userEvent.tab();+ await expect(removeButton).toHaveFocus();+ await expect(getComputedStyle(removeButton).outlineStyle).toBe('solid');+ await expect(getComputedStyle(chip).overflow).toBe('visible');+ await userEvent.click(removeButton);},};@@ -320,6 +329,13 @@ export const TruncationAndTooltip: Story = {}await expect(content.scrollWidth).toBeGreaterThan(content.clientWidth);await expect(getComputedStyle(content).textOverflow).toBe('ellipsis');+ const chip = content.parentElement;+ if (!isDefined(chip)) {+ throw new Error('Chip content must have a root');+ }+ await expect(content.getBoundingClientRect().right).toBeLessThanOrEqual(+ chip.getBoundingClientRect().right,+ );await userEvent.hover(content);await expect(await within(document.body).findByRole('tooltip'),