The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix(e2e): reach Settings via workspace dropdown to unbreak merge queue (#21528)
Charles Bochete4a0dfe26285
diff --git a/packages/twenty-e2e-testing/lib/pom/leftMenu.ts b/packages/twenty-e2e-testing/lib/pom/leftMenu.tsindex ee5d2ddc3fe..8f2a79d492c 100644--- a/packages/twenty-e2e-testing/lib/pom/leftMenu.ts+++ b/packages/twenty-e2e-testing/lib/pom/leftMenu.ts@@ -22,7 +22,7 @@ export class LeftMenu {this.workspaceDropdown = page.getByTestId('workspace-dropdown');this.leftMenu = page.getByRole('button').first();this.searchSubTab = page.getByText('Search');- this.settingsTab = page.getByRole('button', { name: 'Settings' });+ this.settingsTab = page.getByRole('link', { name: 'Settings' });this.peopleTab = page.getByRole('link', { name: 'People' });this.companiesTab = page.getByRole('link', { name: 'Companies' });this.opportunitiesTab = page.getByRole('link', { name: 'Opportunities' });@@ -56,6 +56,7 @@ export class LeftMenu {}async goToSettings() {+ await this.workspaceDropdown.click();await this.settingsTab.click();}diff --git a/packages/twenty-e2e-testing/tests/authentication/signup_invite_email.spec.ts b/packages/twenty-e2e-testing/tests/authentication/signup_invite_email.spec.tsindex 884fd556a50..75e1790b964 100644--- a/packages/twenty-e2e-testing/tests/authentication/signup_invite_email.spec.ts+++ b/packages/twenty-e2e-testing/tests/authentication/signup_invite_email.spec.ts@@ -45,7 +45,7 @@ test('Sign up with invite link via email', async ({});await test.step('Delete account from workspace', async () => {- await expect(page.getByRole('button', { name: 'Settings' })).toBeVisible();+ await expect(page.getByTestId('workspace-dropdown')).toBeVisible();await leftMenu.goToSettings();await settingsPage.goToProfileSection();await profileSection.deleteAccount();diff --git a/packages/twenty-e2e-testing/tests/create-kanban-view.spec.ts b/packages/twenty-e2e-testing/tests/create-kanban-view.spec.tsindex 52c58e90f00..31122f071ae 100644--- a/packages/twenty-e2e-testing/tests/create-kanban-view.spec.ts+++ b/packages/twenty-e2e-testing/tests/create-kanban-view.spec.ts@@ -1,7 +1,8 @@import { expect, test } from '../lib/fixtures/screenshot';test.describe.serial('Create Kanban View', () => {test('Create Industry Select Field', async ({ page }) => {- await page.getByRole('button', { name: 'Settings' }).click();+ await page.getByTestId('workspace-dropdown').click();+ await page.getByRole('link', { name: 'Settings' }).click();await page.getByRole('link', { name: 'Data model' }).click();await page.getByRole('link', { name: 'Opportunities' }).click();await expect(page.getByRole('button', { name: 'New Field' })).toBeVisible();