The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Fix "Go to roles settings" command (#23105)
Mariee5fc5054cc5d
diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/2-23-upgrade-version-command.module.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/2-23-upgrade-version-command.module.tsindex 2877a87d393..25755594f8d 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/2-23-upgrade-version-command.module.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/2-23-upgrade-version-command.module.ts@@ -6,6 +6,7 @@ import { AddWorkflowCoreSoftRefFieldCommand } from 'src/database/commands/upgradimport { BackfillWorkflowCoreLinksCommand } from 'src/database/commands/upgrade-version-command/2-23/2-23-workspace-command-1784286707000-backfill-workflow-core-links.command';import { ReconcileSystemRelationFieldUniversalIdentifierCommand } from 'src/database/commands/upgrade-version-command/2-23/2-23-workspace-command-1784565136000-reconcile-system-relation-field-universal-identifier.command';import { UpgradePeopleDataLabsApplicationCommand } from 'src/database/commands/upgrade-version-command/2-23/2-23-workspace-command-1784565137000-upgrade-people-data-labs-application.command';+import { FixGoToRolesSettingsCommandMenuItemPathCommand } from 'src/database/commands/upgrade-version-command/2-23/2-23-workspace-command-1784566000000-fix-go-to-roles-settings-command-menu-item-path.command';import { ApplicationUpgradeModule } from 'src/engine/core-modules/application/application-upgrade/application-upgrade.module';import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity';import { ApplicationModule } from 'src/engine/core-modules/application/application.module';@@ -29,6 +30,7 @@ import { WorkspaceMigrationModule } from 'src/engine/workspace-manager/workspaceBackfillWorkflowCoreLinksCommand,ReconcileSystemRelationFieldUniversalIdentifierCommand,UpgradePeopleDataLabsApplicationCommand,+ FixGoToRolesSettingsCommandMenuItemPathCommand,],})export class V2_23_UpgradeVersionCommandModule {}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/2-23-workspace-command-1784566000000-fix-go-to-roles-settings-command-menu-item-path.command.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/2-23-workspace-command-1784566000000-fix-go-to-roles-settings-command-menu-item-path.command.tsnew file mode 100644index 00000000000..8206f01634c--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/2-23-workspace-command-1784566000000-fix-go-to-roles-settings-command-menu-item-path.command.ts@@ -0,0 +1,96 @@+import { Command } from 'nest-commander';++import { ProvisionedWorkspaceCommandRunner } from 'src/database/commands/command-runners/provisioned-workspace.command-runner';+import { WorkspaceIteratorService } from 'src/database/commands/command-runners/workspace-iterator.service';+import { type RunOnWorkspaceArgs } from 'src/database/commands/command-runners/workspace.command-runner';+import { buildFixGoToRolesSettingsCommandMenuItemPathSyncOperations } from 'src/database/commands/upgrade-version-command/2-23/utils/build-fix-go-to-roles-settings-command-menu-item-path-sync-operations.util';+import { ApplicationService } from 'src/engine/core-modules/application/application.service';+import { RegisteredWorkspaceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-workspace-command.decorator';+import { WorkspaceCacheService } from 'src/engine/workspace-cache/services/workspace-cache.service';+import { WorkspaceMigrationValidateBuildAndRunService } from 'src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service';++@RegisteredWorkspaceCommand('2.23.0', 1784566000000)+@Command({+ name: 'upgrade:2-23:fix-go-to-roles-settings-command-menu-item-path',+ description:+ 'Point the "Go to Roles Settings" navigation command menu item at /settings/members#roles for existing workspaces',+})+export class FixGoToRolesSettingsCommandMenuItemPathCommand extends ProvisionedWorkspaceCommandRunner {+ constructor(+ protected readonly workspaceIteratorService: WorkspaceIteratorService,+ private readonly applicationService: ApplicationService,+ private readonly workspaceCacheService: WorkspaceCacheService,+ private readonly workspaceMigrationValidateBuildAndRunService: WorkspaceMigrationValidateBuildAndRunService,+ ) {+ super(workspaceIteratorService);+ }++ override async runOnWorkspace({+ workspaceId,+ options,+ }: RunOnWorkspaceArgs): Promise<void> {+ const isDryRun = options.dryRun ?? false;++ const { flatCommandMenuItemMaps } =+ await this.workspaceCacheService.getOrRecompute(workspaceId, [+ 'flatCommandMenuItemMaps',+ ]);++ const commandMenuItemOperations =+ buildFixGoToRolesSettingsCommandMenuItemPathSyncOperations({+ existingFlatCommandMenuItemMaps: flatCommandMenuItemMaps,+ now: new Date().toISOString(),+ });++ const commandMenuItemsToUpdate =+ commandMenuItemOperations.flatEntityToUpdate;++ if (commandMenuItemsToUpdate.length === 0) {+ this.logger.log(+ `"Go to Roles Settings" command menu item path already synced for workspace ${workspaceId}, skipping`,+ );++ return;+ }++ this.logger.log(+ `${isDryRun ? '[DRY RUN] ' : ''}Fixing "Go to Roles Settings" command menu item path for workspace ${workspaceId}`,+ );++ if (isDryRun) {+ return;+ }++ const { twentyStandardFlatApplication } =+ await this.applicationService.findWorkspaceTwentyStandardAndCustomApplicationOrThrow(+ { workspaceId },+ );++ const validateAndBuildResult =+ await this.workspaceMigrationValidateBuildAndRunService.validateBuildAndRunWorkspaceMigration(+ {+ isSystemBuild: true,+ workspaceId,+ applicationUniversalIdentifier:+ twentyStandardFlatApplication.universalIdentifier,+ allFlatEntityOperationByMetadataName: {+ commandMenuItem: commandMenuItemOperations,+ },+ },+ );++ if (validateAndBuildResult.status === 'fail') {+ this.logger.error(+ `Failed to fix "Go to Roles Settings" command menu item path:\n${JSON.stringify(validateAndBuildResult, null, 2)}`,+ );++ throw new Error(+ `Failed to fix "Go to Roles Settings" command menu item path for workspace ${workspaceId}`,+ );+ }++ this.logger.log(+ `Successfully fixed "Go to Roles Settings" command menu item path for workspace ${workspaceId}`,+ );+ }+}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/utils/build-fix-go-to-roles-settings-command-menu-item-path-sync-operations.util.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/utils/build-fix-go-to-roles-settings-command-menu-item-path-sync-operations.util.tsnew file mode 100644index 00000000000..69cbf24b05a--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-23/utils/build-fix-go-to-roles-settings-command-menu-item-path-sync-operations.util.ts@@ -0,0 +1,55 @@+import { isDefined } from 'twenty-shared/utils';++import { type FlatCommandMenuItem } from 'src/engine/metadata-modules/flat-command-menu-item/types/flat-command-menu-item.type';+import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';+import { type FlatEntityToCreateDeleteUpdate } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-to-create-delete-update.type';+import { STANDARD_COMMAND_MENU_ITEMS } from 'src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant';++export const LEGACY_GO_TO_ROLES_SETTINGS_PATH = '/settings/roles';++export const GO_TO_ROLES_SETTINGS_PATH = '/settings/members#roles';++const GO_TO_ROLES_SETTINGS_COMMAND_MENU_ITEM_UNIVERSAL_IDENTIFIER =+ STANDARD_COMMAND_MENU_ITEMS.goToSettingsRoles.universalIdentifier;++export const buildFixGoToRolesSettingsCommandMenuItemPathSyncOperations = ({+ existingFlatCommandMenuItemMaps,+ now,+}: {+ existingFlatCommandMenuItemMaps: FlatEntityMaps<FlatCommandMenuItem>;+ now: string;+}): FlatEntityToCreateDeleteUpdate<'commandMenuItem'> => {+ const existingGoToRolesSettingsCommandMenuItem =+ existingFlatCommandMenuItemMaps.byUniversalIdentifier[+ GO_TO_ROLES_SETTINGS_COMMAND_MENU_ITEM_UNIVERSAL_IDENTIFIER+ ];++ const existingPath =+ existingGoToRolesSettingsCommandMenuItem?.payload &&+ 'path' in existingGoToRolesSettingsCommandMenuItem.payload+ ? existingGoToRolesSettingsCommandMenuItem.payload.path+ : undefined;++ if (+ !isDefined(existingGoToRolesSettingsCommandMenuItem) ||+ existingPath !== LEGACY_GO_TO_ROLES_SETTINGS_PATH+ ) {+ return {+ flatEntityToCreate: [],+ flatEntityToDelete: [],+ flatEntityToUpdate: [],+ };+ }++ return {+ flatEntityToCreate: [],+ flatEntityToDelete: [],+ flatEntityToUpdate: [+ {+ ...existingGoToRolesSettingsCommandMenuItem,+ payload: { path: GO_TO_ROLES_SETTINGS_PATH },+ updatedAt: now,+ },+ ],+ };+};diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.tsindex dbe8886c8b7..e031574310a 100644--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-command-menu-item.constant.ts@@ -872,7 +872,7 @@ export const STANDARD_COMMAND_MENU_ITEMS = {frontComponentUniversalIdentifier: null,engineComponentKey: EngineComponentKey.NAVIGATION,hotKeys: null,- payload: { path: '/settings/roles' },+ payload: { path: '/settings/members#roles' },},goToSettingsDomains: {universalIdentifier: '2d071684-fb5e-4222-b560-4c7ab2597fb4',