The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Let applications disable object permission actions on their objects (#28985)
Charles Bochete8d8d17232be
diff --git a/packages/twenty-agent-skills/references/develop-app/data-model.md b/packages/twenty-agent-skills/references/develop-app/data-model.mdindex 84415991a25..d7c11504d22 100644--- a/packages/twenty-agent-skills/references/develop-app/data-model.md+++ b/packages/twenty-agent-skills/references/develop-app/data-model.md@@ -120,6 +120,7 @@ When adding permissions:- Grant the smallest useful scope.- Keep sensitive objects and fields out of broad roles.- Check whether the app introduces side effects through logic functions before granting write access.+- To keep some permissions from being granted on an object, set `disabledObjectPermissionActions` on `defineObject()`, for example `['canDestroyObjectRecords']`. Allowed values are the object permission flags: `'canReadObjectRecords'`, `'canUpdateObjectRecords'`, `'canSoftDeleteObjectRecords'` and `'canDestroyObjectRecords'`. It only blocks granting them on that object; roles granting an action on all objects are unaffected.- For sensitive objects, set `sharingReach: ObjectSharingReach.ROLE_ACCESS` on `defineObject()` (imported from `twenty-sdk/define`) so records can only be shared with people whose role already reaches them. The default, `ObjectSharingReach.WORKSPACE`, lets a record be shared with anyone in the workspace. It only matters while record sharing is enabled, and objects with `APPLICATION` or `SYSTEM` readability are never shared.## Verificationdiff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql b/packages/twenty-client-sdk/src/metadata/generated/schema.graphqlindex b5a87df4303..990436790fb 100644--- a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql@@ -3485,6 +3485,7 @@ type Object {color: StringcreatedAt: DateTime!description: String+ disabledObjectPermissionActions: [String!]duplicateCriteria: [[String!]!]fields("""Specify to filter the records returned."""diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.ts b/packages/twenty-client-sdk/src/metadata/generated/schema.tsindex 4c6ed6e2e45..ca245cc1402 100644--- a/packages/twenty-client-sdk/src/metadata/generated/schema.ts+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.ts@@ -2525,6 +2525,7 @@ export interface Object {color?: Scalars['String']createdAt: Scalars['DateTime']description?: Scalars['String']+ disabledObjectPermissionActions?: Scalars['String'][]duplicateCriteria?: Scalars['String'][][]fields: ObjectFieldsConnectionfieldsList: Field[]@@ -6967,6 +6968,7 @@ export interface ObjectGenqlSelection{color?: boolean | numbercreatedAt?: boolean | numberdescription?: boolean | number+ disabledObjectPermissionActions?: boolean | numberduplicateCriteria?: boolean | numberfields?: (ObjectFieldsConnectionGenqlSelection & { __args: {/** Specify to filter the records returned. */diff --git a/packages/twenty-client-sdk/src/metadata/generated/types.ts b/packages/twenty-client-sdk/src/metadata/generated/types.tsindex c8a6544737b..46e5a7a2d72 100644--- a/packages/twenty-client-sdk/src/metadata/generated/types.ts+++ b/packages/twenty-client-sdk/src/metadata/generated/types.ts@@ -9361,6 +9361,9 @@ export default {"description": [1],+ "disabledObjectPermissionActions": [+ 1+ ],"duplicateCriteria": [1],diff --git a/packages/twenty-docs/developers/extend/apps/data/objects.mdx b/packages/twenty-docs/developers/extend/apps/data/objects.mdxindex 9f2dbcf2714..4a6417e8d3e 100644--- a/packages/twenty-docs/developers/extend/apps/data/objects.mdx+++ b/packages/twenty-docs/developers/extend/apps/data/objects.mdx@@ -113,6 +113,7 @@ export default defineObject({- The share rows on the record itself grant access exactly as on a `PRIVATE` record. Its creator gets one when the record is created while record sharing is enabled, so whoever created a record keeps seeing it, and a record whose parent fields are all empty is visible to those it was shared with directly.- An `INHERITED` object that names no usable parent field behaves like a `PRIVATE` one.- `sharingReach` sets how far a record of the object can be shared by name: `ObjectSharingReach.WORKSPACE` (the default, a record can be shared with anyone in the workspace, even someone whose role cannot access the object or whose row-level filter hides the record; they get that record only, to view or edit) or `ObjectSharingReach.ROLE_ACCESS` (shares never go beyond role and row-level permissions). Pick `ROLE_ACCESS` for sensitive objects where no access must mean no access. Roles that can update all settings see every record of an `OPEN` object whatever its sharing restrictions; their object permissions and row-level filters still apply. It only applies while record sharing is enabled in the workspace, and only to objects whose records can be shared: `MetadataReadability.OPEN`, `PRIVATE` and `INHERITED` objects that are not system objects. `APPLICATION` and `SYSTEM` objects are never shared.+- `disabledObjectPermissionActions` lists object permissions that cannot be granted on the object: any of `'canReadObjectRecords'`, `'canUpdateObjectRecords'`, `'canSoftDeleteObjectRecords'` and `'canDestroyObjectRecords'`, the same flags a role sets per object. Saving an object permission that grants one of them on this object fails, for example `disabledObjectPermissionActions: ['canDestroyObjectRecords']` keeps any role from being given destroy on it specifically. It does not change what roles granting an action on all objects can do.- `color` sets the accent color of the object in the UI. Omit it and Twenty picks one for the object.- `imageIdentifierFieldMetadataUniversalIdentifier` names the field whose value is shown as the record avatar. Omit it to let Twenty pick the default.- `isLabelSyncedWithName`, on an object or on a field, keeps the API name in sync with the label when the label is edited in Settings. It defaults to `false`, so a renamed label leaves the name untouched.diff --git a/packages/twenty-front/src/generated-metadata/graphql.ts b/packages/twenty-front/src/generated-metadata/graphql.tsindex f38b4eeacd1..cd9857f5562 100644--- a/packages/twenty-front/src/generated-metadata/graphql.ts+++ b/packages/twenty-front/src/generated-metadata/graphql.ts@@ -5123,6 +5123,7 @@ export type Object = {color?: Maybe<Scalars['String']['output']>;createdAt: Scalars['DateTime']['output'];description?: Maybe<Scalars['String']['output']>;+ disabledObjectPermissionActions?: Maybe<Array<Scalars['String']['output']>>;duplicateCriteria?: Maybe<Array<Array<Scalars['String']['output']>>>;fields: ObjectFieldsConnection;fieldsList: Array<Field>;diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-52/utils/__tests__/build-global-chat-command-menu-item-updates.util.spec.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-52/utils/__tests__/build-global-chat-command-menu-item-updates.util.spec.tsindex dfc390c4bb9..e60bb9c58ee 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/2-52/utils/__tests__/build-global-chat-command-menu-item-updates.util.spec.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-52/utils/__tests__/build-global-chat-command-menu-item-updates.util.spec.ts@@ -102,6 +102,7 @@ const CHAT_OBJECT_METADATA: FlatObjectMetadata = {writability: MetadataWritability.OPEN,sharingReach: ObjectSharingReach.WORKSPACE,readabilityParentFieldUniversalIdentifiers: null,+ disabledObjectPermissionActions: null,openRecordIn: ObjectOpenRecordIn.USER_CHOICE,shortcut: null,duplicateCriteria: null,diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-53/2-53-instance-command-fast-1793111477950-add-object-metadata-disabled-object-permission-actions.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-53/2-53-instance-command-fast-1793111477950-add-object-metadata-disabled-object-permission-actions.tsnew file mode 100644index 00000000000..5fdc2f61583--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-53/2-53-instance-command-fast-1793111477950-add-object-metadata-disabled-object-permission-actions.ts@@ -0,0 +1,15 @@+import { QueryRunner } from 'typeorm';++import { RegisteredInstanceCommand } from 'src/engine/core-modules/upgrade/decorators/registered-instance-command.decorator';+import { FastInstanceCommand } from 'src/engine/core-modules/upgrade/interfaces/fast-instance-command.interface';++@RegisteredInstanceCommand('2.53.0', 1793111477950)+export class AddObjectMetadataDisabledObjectPermissionActionsFastInstanceCommand implements FastInstanceCommand {+ public async up(queryRunner: QueryRunner): Promise<void> {+ await queryRunner.query('ALTER TABLE "core"."objectMetadata" ADD "disabledObjectPermissionActions" jsonb');+ }++ public async down(queryRunner: QueryRunner): Promise<void> {+ await queryRunner.query('ALTER TABLE "core"."objectMetadata" DROP COLUMN "disabledObjectPermissionActions"');+ }+}diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/2-53/add-object-metadata-disabled-object-permission-actions-upgrade-command-name.constant.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/2-53/add-object-metadata-disabled-object-permission-actions-upgrade-command-name.constant.tsnew file mode 100644index 00000000000..9f89883bedb--- /dev/null+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/2-53/add-object-metadata-disabled-object-permission-actions-upgrade-command-name.constant.ts@@ -0,0 +1,2 @@+export const ADD_OBJECT_METADATA_DISABLED_OBJECT_PERMISSION_ACTIONS_UPGRADE_COMMAND_NAME =+ '2.53.0_AddObjectMetadataDisabledObjectPermissionActionsFastInstanceCommand_1793111477950';diff --git a/packages/twenty-server/src/database/commands/upgrade-version-command/instance-commands.constant.ts b/packages/twenty-server/src/database/commands/upgrade-version-command/instance-commands.constant.tsindex d09e639aaff..6e0f2f533a3 100644--- a/packages/twenty-server/src/database/commands/upgrade-version-command/instance-commands.constant.ts+++ b/packages/twenty-server/src/database/commands/upgrade-version-command/instance-commands.constant.ts@@ -258,6 +258,7 @@ import { BackfillRoleAgentChatChannelAccessSlowInstanceCommand } from 'src/databimport { AddAgentChatChannelNavigationMenuItemFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-51/2-51-instance-command-fast-1792686749823-add-agent-chat-channel-navigation-menu-item';import { AddParticipantHandleFieldToMessageChannelFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-52/2-52-instance-command-fast-1792907887530-add-participant-handle-field-to-message-channel';import { AddCustomConfigToConnectionProviderFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-52/2-52-instance-command-fast-1793032438836-add-custom-config-to-connection-provider';+import { AddObjectMetadataDisabledObjectPermissionActionsFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-53/2-53-instance-command-fast-1793111477950-add-object-metadata-disabled-object-permission-actions';import { AddMessagingProviderFastInstanceCommand } from 'src/database/commands/upgrade-version-command/2-52/2-52-instance-command-fast-1793032438837-add-messaging-provider';export const INSTANCE_COMMANDS = [@@ -520,4 +521,5 @@ export const INSTANCE_COMMANDS = [AddParticipantHandleFieldToMessageChannelFastInstanceCommand,AddCustomConfigToConnectionProviderFastInstanceCommand,AddMessagingProviderFastInstanceCommand,+ AddObjectMetadataDisabledObjectPermissionActionsFastInstanceCommand,];diff --git a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/__mocks__/mockPersonObjectMetadata.ts b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/__mocks__/mockPersonObjectMetadata.tsindex a3f0ef19bd7..db27fb1dc18 100644--- a/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/__mocks__/mockPersonObjectMetadata.ts+++ b/packages/twenty-server/src/engine/api/graphql/graphql-query-runner/__mocks__/mockPersonObjectMetadata.ts@@ -178,6 +178,7 @@ export const mockPersonFlatObjectMetadata = (writability: MetadataWritability.OPEN,readability: MetadataReadability.OPEN,readabilityParentFieldUniversalIdentifiers: null,+ disabledObjectPermissionActions: null,sharingReach: ObjectSharingReach.WORKSPACE,openRecordIn: ObjectOpenRecordIn.USER_CHOICE,applicationUniversalIdentifier: 'test-application-id',diff --git a/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/__tests__/from-flat-object-metadata-to-object-manifest.util.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/__tests__/from-flat-object-metadata-to-object-manifest.util.spec.tsindex 0c226b8af57..7cb794e7d79 100644--- a/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/__tests__/from-flat-object-metadata-to-object-manifest.util.spec.ts+++ b/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/__tests__/from-flat-object-metadata-to-object-manifest.util.spec.ts@@ -34,6 +34,7 @@ const OBJECT_MANIFEST: Required<ObjectManifest> = {writability: MetadataWritability.APPLICATION,readability: MetadataReadability.INHERITED,readabilityParentFieldUniversalIdentifiers: [PARENT_FIELD_UID],+ disabledObjectPermissionActions: ['canDestroyObjectRecords'],sharingReach: ObjectSharingReach.WORKSPACE,openRecordIn: ObjectOpenRecordIn.RECORD_PAGE,labelIdentifierFieldMetadataUniversalIdentifier: LABEL_FIELD_UID,diff --git a/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/from-flat-object-metadata-to-object-manifest.util.ts b/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/from-flat-object-metadata-to-object-manifest.util.tsindex eefa7514b20..60fa0a0a7fe 100644--- a/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/from-flat-object-metadata-to-object-manifest.util.ts+++ b/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/from-flat-object-metadata-to-object-manifest.util.ts@@ -35,6 +35,12 @@ export const fromFlatObjectMetadataToObjectManifest = ({readability: flatObjectMetadata.readability,readabilityParentFieldUniversalIdentifiers:flatObjectMetadata.readabilityParentFieldUniversalIdentifiers,+ ...(isDefined(flatObjectMetadata.disabledObjectPermissionActions)+ ? {+ disabledObjectPermissionActions:+ flatObjectMetadata.disabledObjectPermissionActions,+ }+ : {}),sharingReach: flatObjectMetadata.sharingReach,openRecordIn: flatObjectMetadata.openRecordIn,labelIdentifierFieldMetadataUniversalIdentifier,diff --git a/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/from-object-manifest-to-universal-flat-object-metadata.util.ts b/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/from-object-manifest-to-universal-flat-object-metadata.util.tsindex e1289c999f7..2a816aa57b0 100644--- a/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/from-object-manifest-to-universal-flat-object-metadata.util.ts+++ b/packages/twenty-server/src/engine/core-modules/application/application-manifest/converters/from-object-manifest-to-universal-flat-object-metadata.util.ts@@ -39,6 +39,8 @@ export const fromObjectManifestToUniversalFlatObjectMetadata = ({readability: objectManifest.readability ?? MetadataReadability.OPEN,readabilityParentFieldUniversalIdentifiers:objectManifest.readabilityParentFieldUniversalIdentifiers ?? null,+ disabledObjectPermissionActions:+ objectManifest.disabledObjectPermissionActions ?? null,sharingReach: objectManifest.sharingReach ?? ObjectSharingReach.WORKSPACE,isAuditLogged: true,isSearchable: objectManifest.isSearchable ?? true,diff --git a/packages/twenty-server/src/engine/core-modules/application/application-manifest/utils/__tests__/export-covers-compared-properties.spec.ts b/packages/twenty-server/src/engine/core-modules/application/application-manifest/utils/__tests__/export-covers-compared-properties.spec.tsindex 581b47de0b0..f5e0eade2c1 100644--- a/packages/twenty-server/src/engine/core-modules/application/application-manifest/utils/__tests__/export-covers-compared-properties.spec.ts+++ b/packages/twenty-server/src/engine/core-modules/application/application-manifest/utils/__tests__/export-covers-compared-properties.spec.ts@@ -355,6 +355,7 @@ const EXPORTED_KINDS: ExportedKind[] = [description: 'An object',icon: 'IconBox',color: 'blue',+ disabledObjectPermissionActions: ['canDestroyObjectRecords'],imageIdentifierFieldMetadataUniversalIdentifier: FIELD_UID,labelIdentifierFieldMetadataUniversalIdentifier: FIELD_UID,}),diff --git a/packages/twenty-server/src/engine/core-modules/event-emitter/utils/__tests__/object-record-changed-values.spec.ts b/packages/twenty-server/src/engine/core-modules/event-emitter/utils/__tests__/object-record-changed-values.spec.tsindex e2c1863c3e1..e85eed1cbdc 100644--- a/packages/twenty-server/src/engine/core-modules/event-emitter/utils/__tests__/object-record-changed-values.spec.ts+++ b/packages/twenty-server/src/engine/core-modules/event-emitter/utils/__tests__/object-record-changed-values.spec.ts@@ -52,6 +52,7 @@ const mockObjectMetadata: FlatObjectMetadata = {writability: MetadataWritability.OPEN,readability: MetadataReadability.OPEN,readabilityParentFieldUniversalIdentifiers: null,+ disabledObjectPermissionActions: null,sharingReach: ObjectSharingReach.WORKSPACE,openRecordIn: ObjectOpenRecordIn.USER_CHOICE,labelIdentifierFieldMetadataId: null,diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/__tests__/__snapshots__/all-universal-flat-entity-properties-to-compare-and-stringify.constant.spec.ts.snap b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/__tests__/__snapshots__/all-universal-flat-entity-properties-to-compare-and-stringify.constant.spec.ts.snapindex 8198853c7dd..4218fb43641 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/__tests__/__snapshots__/all-universal-flat-entity-properties-to-compare-and-stringify.constant.spec.ts.snap+++ b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/__tests__/__snapshots__/all-universal-flat-entity-properties-to-compare-and-stringify.constant.spec.ts.snap@@ -225,6 +225,7 @@ exports[`ALL_UNIVERSAL_FLAT_ENTITY_PROPERTIES_TO_COMPARE_AND_STRINGIFY should ma"isUIEditable","writability","readability",+ "disabledObjectPermissionActions","readabilityParentFieldUniversalIdentifiers","sharingReach","isUICreatable",@@ -233,6 +234,7 @@ exports[`ALL_UNIVERSAL_FLAT_ENTITY_PROPERTIES_TO_COMPARE_AND_STRINGIFY should ma],"propertiesToStringify": ["overrides",+ "disabledObjectPermissionActions","readabilityParentFieldUniversalIdentifiers","duplicateCriteria",],diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.ts b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.tsindex f59fa7b1b30..d0ad6dcc10d 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.ts@@ -278,6 +278,11 @@ export const ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME = {toStringify: false,universalProperty: undefined,},+ disabledObjectPermissionActions: {+ toCompare: true,+ toStringify: true,+ universalProperty: undefined,+ },readabilityParentFieldUniversalIdentifiers: {toCompare: true,toStringify: true,diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/flat-entity-update.type-test.ts b/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/flat-entity-update.type-test.tsindex 0cb6269befe..c0e363b6056 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/flat-entity-update.type-test.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-entity/types/__tests__/flat-entity-update.type-test.ts@@ -63,6 +63,7 @@ type Assertions = [| 'writability'| 'readability'| 'readabilityParentFieldUniversalIdentifiers'+ | 'disabledObjectPermissionActions'| 'sharingReach'>>,diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock.ts b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock.tsindex ecb43c99c4b..072f86e14da 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock.ts@@ -38,6 +38,7 @@ export const getFlatObjectMetadataMock = (writability: MetadataWritability.OPEN,readability: MetadataReadability.OPEN,readabilityParentFieldUniversalIdentifiers: null,+ disabledObjectPermissionActions: null,sharingReach: ObjectSharingReach.WORKSPACE,color: null,id: faker.string.uuid(),diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-create-object-input-to-flat-object-metadata-and-flat-field-metadatas-to-create.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-create-object-input-to-flat-object-metadata-and-flat-field-metadatas-to-create.util.tsindex 1da5fe05406..a8d60328592 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-create-object-input-to-flat-object-metadata-and-flat-field-metadatas-to-create.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-create-object-input-to-flat-object-metadata-and-flat-field-metadatas-to-create.util.ts@@ -79,6 +79,7 @@ export const fromCreateObjectInputToFlatObjectMetadataAndFlatFieldMetadatasToCrewritability: MetadataWritability.OPEN,readability: MetadataReadability.OPEN,readabilityParentFieldUniversalIdentifiers: null,+ disabledObjectPermissionActions: null,sharingReach: ObjectSharingReach.WORKSPACE,isSystem: false,labelPlural: capitalize(createObjectInput.labelPlural),diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-flat-object-metadata-to-object-metadata-dto.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-flat-object-metadata-to-object-metadata-dto.util.tsindex 73384adb4ce..3752eec6785 100644--- a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-flat-object-metadata-to-object-metadata-dto.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-flat-object-metadata-to-object-metadata-dto.util.ts@@ -24,6 +24,7 @@ export const fromFlatObjectMetadataToObjectMetadataDto = (openRecordIn,readability,readabilityParentFieldUniversalIdentifiers,+ disabledObjectPermissionActions,sharingReach,writability,isSystem,@@ -53,6 +54,7 @@ export const fromFlatObjectMetadataToObjectMetadataDto = (openRecordIn,readability,readabilityParentFieldUniversalIdentifiers,+ disabledObjectPermissionActions,// Metadata cached before the column existed lacks it until recomputed,// and the access policy treats that as staying within the rolesharingReach: sharingReach ?? ObjectSharingReach.WORKSPACE,diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/__tests__/validate-flat-object-metadata-disabled-object-permission-actions.util.spec.ts b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/__tests__/validate-flat-object-metadata-disabled-object-permission-actions.util.spec.tsnew file mode 100644index 00000000000..aa967ff6b44--- /dev/null+++ b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/__tests__/validate-flat-object-metadata-disabled-object-permission-actions.util.spec.ts@@ -0,0 +1,59 @@+import { validateFlatObjectMetadataDisabledObjectPermissionActions } from 'src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-disabled-object-permission-actions.util';+import { ObjectMetadataExceptionCode } from 'src/engine/metadata-modules/object-metadata/object-metadata.exception';++describe('validateFlatObjectMetadataDisabledObjectPermissionActions', () => {+ it('should accept known actions and an unset value', () => {+ expect(+ validateFlatObjectMetadataDisabledObjectPermissionActions({+ disabledObjectPermissionActions: [+ 'canUpdateObjectRecords',+ 'canDestroyObjectRecords',+ ],+ }),+ ).toEqual([]);+ expect(+ validateFlatObjectMetadataDisabledObjectPermissionActions({+ disabledObjectPermissionActions: null,+ }),+ ).toEqual([]);+ });++ it('should reject an unknown action', () => {+ expect(+ validateFlatObjectMetadataDisabledObjectPermissionActions({+ disabledObjectPermissionActions: [+ 'canDestroyObjectRecords',+ 'canShareObjectRecords',+ ],+ }),+ ).toEqual([+ expect.objectContaining({+ code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,+ value: 'canShareObjectRecords',+ }),+ ]);+ });++ it('should reject a value that is not a list', () => {+ expect(+ validateFlatObjectMetadataDisabledObjectPermissionActions({+ disabledObjectPermissionActions: { canDestroyObjectRecords: true },+ }),+ ).toHaveLength(1);+ });++ it('should reject a repeated action', () => {+ expect(+ validateFlatObjectMetadataDisabledObjectPermissionActions({+ disabledObjectPermissionActions: [+ 'canDestroyObjectRecords',+ 'canDestroyObjectRecords',+ ],+ }),+ ).toEqual([+ expect.objectContaining({+ code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,+ }),+ ]);+ });+});diff --git a/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-disabled-object-permission-actions.util.ts b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-disabled-object-permission-actions.util.tsnew file mode 100644index 00000000000..e04314cec7c--- /dev/null+++ b/packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-disabled-object-permission-actions.util.ts@@ -0,0 +1,58 @@+import { msg } from '@lingui/core/macro';+import { OBJECT_PERMISSION_ACTIONS } from 'twenty-shared/application';+import { isDefined } from 'twenty-shared/utils';++import { type FlatObjectMetadataValidationError } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata-validation-error.type';+import { ObjectMetadataExceptionCode } from 'src/engine/metadata-modules/object-metadata/object-metadata.exception';++export const validateFlatObjectMetadataDisabledObjectPermissionActions = ({+ disabledObjectPermissionActions,+}: {+ disabledObjectPermissionActions: unknown;+}): FlatObjectMetadataValidationError[] => {+ if (!isDefined(disabledObjectPermissionActions)) {+ return [];+ }++ if (!Array.isArray(disabledObjectPermissionActions)) {+ return [+ {+ code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,+ message: 'Disabled object permission actions must be a list',+ userFriendlyMessage: msg`Disabled object permission actions must be a list`,+ value: disabledObjectPermissionActions,+ },+ ];+ }++ const errors: FlatObjectMetadataValidationError[] = [];+ const objectPermissionActions: readonly string[] = OBJECT_PERMISSION_ACTIONS;++ for (const action of disabledObjectPermissionActions) {+ if (+ typeof action !== 'string' ||+ !objectPermissionActions.includes(action)+ ) {+ errors.push({+ code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,+ message: `Unknown disabled object permission action "${action}"`,+ userFriendlyMessage: msg`Unknown disabled object permission action`,+ value: action,+ });+ }+ }++ if (+ new Set(disabledObjectPermissionActions).size !==+ disabledObjectPermissionActions.length+ ) {+ errors.push({+ code: ObjectMetadataExceptionCode.INVALID_OBJECT_INPUT,+ message: 'Disabled object permission actions must not repeat',+ userFriendlyMessage: msg`Disabled object permission actions must not repeat`,+ value: disabledObjectPermissionActions,+ });+ }++ return errors;+};diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/object-metadata.dto.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/object-metadata.dto.tsindex 7c1024c51f9..47008851c4b 100644--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/object-metadata.dto.ts+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/object-metadata.dto.ts@@ -11,6 +11,7 @@ import {ObjectOpenRecordIn,ObjectSharingReach,} from 'twenty-shared/types';+import { type ObjectPermissionAction } from 'twenty-shared/application';import { type AuthoredOverrides } from 'src/engine/metadata-modules/overrides/types/authored-overrides.type';import { type WorkspaceEntityDuplicateCriteria } from 'src/engine/api/graphql/workspace-query-builder/types/workspace-entity-duplicate-criteria.type';@@ -90,6 +91,9 @@ export class ObjectMetadataDTO {@Field(() => [UUIDScalarType], { nullable: true })readabilityParentFieldUniversalIdentifiers: string[] | null;+ @Field(() => [String], { nullable: true })+ disabledObjectPermissionActions?: ObjectPermissionAction[] | null;+@Field(() => ObjectSharingReach)sharingReach: ObjectSharingReach;@Field(() => MetadataWritability)diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.entity.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.entity.tsindex c0251f29cc9..e207fa8e84e 100644--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.entity.ts+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.entity.ts@@ -16,7 +16,9 @@ import {ObjectOpenRecordIn,ObjectSharingReach,} from 'twenty-shared/types';+import { type ObjectPermissionAction } from 'twenty-shared/application';+import { ADD_OBJECT_METADATA_DISABLED_OBJECT_PERMISSION_ACTIONS_UPGRADE_COMMAND_NAME } from 'src/database/commands/upgrade-version-command/2-53/add-object-metadata-disabled-object-permission-actions-upgrade-command-name.constant';import { ADD_OBJECT_METADATA_SHARING_REACH_UPGRADE_COMMAND_NAME } from 'src/database/commands/upgrade-version-command/2-45/add-object-metadata-sharing-reach-upgrade-command-name.constant';import { ADD_METADATA_OVERRIDES_COLUMN_UPGRADE_COMMAND_NAME } from 'src/database/commands/upgrade-version-command/2-19/add-metadata-overrides-column-upgrade-command-name.constant';import { ADD_METADATA_WRITABILITY_UPGRADE_COMMAND_NAME } from 'src/database/commands/upgrade-version-command/2-32/add-metadata-writability-upgrade-command-name.constant';@@ -187,6 +189,15 @@ export class ObjectMetadataEntity})sharingReach: ObjectSharingReach;+ @WasIntroducedInUpgrade({+ upgradeCommandName:+ ADD_OBJECT_METADATA_DISABLED_OBJECT_PERMISSION_ACTIONS_UPGRADE_COMMAND_NAME,+ })+ @Column({ type: 'jsonb', nullable: true })+ disabledObjectPermissionActions: JsonbProperty<+ ObjectPermissionAction[]+ > | null;+@Column({ default: true })isAuditLogged: boolean;diff --git a/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/from-object-metadata-entity-to-object-metadata-dto.util.ts b/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/from-object-metadata-entity-to-object-metadata-dto.util.tsindex bd12a823032..c4adf35e249 100644--- a/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/from-object-metadata-entity-to-object-metadata-dto.util.ts+++ b/packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/from-object-metadata-entity-to-object-metadata-dto.util.ts@@ -44,6 +44,7 @@ export const fromObjectMetadataEntityToObjectMetadataDto = (readability: entity.readability,readabilityParentFieldUniversalIdentifiers:entity.readabilityParentFieldUniversalIdentifiers,+ disabledObjectPermissionActions: entity.disabledObjectPermissionActions,sharingReach: entity.sharingReach ?? ObjectSharingReach.WORKSPACE,writability: entity.writability,isLabelSyncedWithName: entity.isLabelSyncedWithName,diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/get-column-name-to-field-metadata-id.util.spec.ts b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/get-column-name-to-field-metadata-id.util.spec.tsindex d8fc0251d57..bfc73fa3174 100644--- a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/get-column-name-to-field-metadata-id.util.spec.ts+++ b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/get-column-name-to-field-metadata-id.util.spec.ts@@ -51,6 +51,7 @@ describe('getColumnNameToFieldMetadataIdMap', () => {writability: MetadataWritability.OPEN,readability: MetadataReadability.OPEN,readabilityParentFieldUniversalIdentifiers: null,+ disabledObjectPermissionActions: null,sharingReach: ObjectSharingReach.WORKSPACE,openRecordIn: ObjectOpenRecordIn.USER_CHOICE,labelIdentifierFieldMetadataId: null,diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/get-field-metadata-id-to-column-names-map.util.spec.ts b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/get-field-metadata-id-to-column-names-map.util.spec.tsindex a42ff80f6af..a2f8955a5b2 100644--- a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/get-field-metadata-id-to-column-names-map.util.spec.ts+++ b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/get-field-metadata-id-to-column-names-map.util.spec.ts@@ -51,6 +51,7 @@ describe('getFieldMetadataIdToColumnNamesMap', () => {writability: MetadataWritability.OPEN,readability: MetadataReadability.OPEN,readabilityParentFieldUniversalIdentifiers: null,+ disabledObjectPermissionActions: null,sharingReach: ObjectSharingReach.WORKSPACE,openRecordIn: ObjectOpenRecordIn.USER_CHOICE,labelIdentifierFieldMetadataId: null,diff --git a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/is-record-matching-rls-row-level-permission-predicate.util.spec.ts b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/is-record-matching-rls-row-level-permission-predicate.util.spec.tsindex ebb4ecb5dc6..4604152deb6 100644--- a/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/is-record-matching-rls-row-level-permission-predicate.util.spec.ts+++ b/packages/twenty-server/src/engine/twenty-orm/utils/__tests__/is-record-matching-rls-row-level-permission-predicate.util.spec.ts@@ -54,6 +54,7 @@ describe('isRecordMatchingRLSRowLevelPermissionPredicate', () => {writability: MetadataWritability.OPEN,readability: MetadataReadability.OPEN,readabilityParentFieldUniversalIdentifiers: null,+ disabledObjectPermissionActions: null,sharingReach: ObjectSharingReach.WORKSPACE,openRecordIn: ObjectOpenRecordIn.USER_CHOICE,labelIdentifierFieldMetadataId: null,diff --git a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/object-metadata/create-standard-object-flat-metadata.util.ts b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/object-metadata/create-standard-object-flat-metadata.util.tsindex 5bfbfa4389a..db03fae4b76 100644--- a/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/object-metadata/create-standard-object-flat-metadata.util.ts+++ b/packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/object-metadata/create-standard-object-flat-metadata.util.ts@@ -135,6 +135,7 @@ export const createStandardObjectFlatMetadata = <writability,readability,readabilityParentFieldUniversalIdentifiers,+ disabledObjectPermissionActions: null,sharingReach: ObjectSharingReach.WORKSPACE,openRecordIn,isLabelSyncedWithName: false,diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/universal-flat-entity-update.test-type.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/universal-flat-entity-update.test-type.tsindex 3209ac87aac..5be53a8cbbb 100644--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/universal-flat-entity-update.test-type.ts+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/__tests__/universal-flat-entity-update.test-type.ts@@ -48,6 +48,7 @@ type Assertions = [| 'writability'| 'readability'| 'readabilityParentFieldUniversalIdentifiers'+ | 'disabledObjectPermissionActions'| 'sharingReach'>>,diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/utils/__tests__/__snapshots__/delete-flat-entity-foreign-key-aggregators.util.spec.ts.snap b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/utils/__tests__/__snapshots__/delete-flat-entity-foreign-key-aggregators.util.spec.ts.snapindex 212bd161949..cf574082df4 100644--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/utils/__tests__/__snapshots__/delete-flat-entity-foreign-key-aggregators.util.spec.ts.snap+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/universal-flat-entity/utils/__tests__/__snapshots__/delete-flat-entity-foreign-key-aggregators.util.spec.ts.snap@@ -50,6 +50,7 @@ exports[`deleteFlatEntityForeignKeyAggregators should strip raw workspace-scoped"commandMenuItemUniversalIdentifiers": [],"createdAt": "2024-01-01T00:00:00.000Z","description": "default flat object metadata description",+ "disabledObjectPermissionActions": null,"duplicateCriteria": null,"fieldPermissionUniversalIdentifiers": [],"fieldUniversalIdentifiers": [diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-object-metadata-validator.service.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-object-metadata-validator.service.tsindex a8708d2c36e..eba98af613e 100644--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-object-metadata-validator.service.ts+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-object-metadata-validator.service.ts@@ -5,6 +5,7 @@ import { ALL_METADATA_NAME } from 'twenty-shared/metadata';import { isDefined } from 'twenty-shared/utils';import { findFlatEntityByUniversalIdentifier } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-universal-identifier.util';+import { validateFlatObjectMetadataDisabledObjectPermissionActions } from 'src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-disabled-object-permission-actions.util';import { validateFlatObjectMetadataNameAndLabels } from 'src/engine/metadata-modules/flat-object-metadata/validators/utils/validate-flat-object-metadata-name-and-labels.util';import { ObjectMetadataExceptionCode } from 'src/engine/metadata-modules/object-metadata/object-metadata.exception';import { belongsToTwentyStandardApp } from 'src/engine/metadata-modules/utils/belongs-to-twenty-standard-app.util';@@ -82,6 +83,9 @@ export class FlatObjectMetadataValidatorService {universalFlatObjectMetadataToValidate: updatedFlatObjectMetadata,buildOptions,}),+ ...validateFlatObjectMetadataDisabledObjectPermissionActions(+ updatedFlatObjectMetadata,+ ),);// TODO remove this once we migrated labelIdentifierFieldMetadataId as non nullableif (@@ -217,6 +221,9 @@ export class FlatObjectMetadataValidatorService {universalFlatObjectMetadataToValidate: flatObjectMetadataToValidate,buildOptions,}),+ ...validateFlatObjectMetadataDisabledObjectPermissionActions(+ flatObjectMetadataToValidate,+ ),);return objectValidationResult;diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-object-permission-validator.service.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-object-permission-validator.service.tsindex 814cc9d9238..57d5fe73f88 100644--- a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-object-permission-validator.service.ts+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/services/flat-object-permission-validator.service.ts@@ -10,6 +10,7 @@ import { FailedFlatEntityValidation } from 'src/engine/workspace-manager/workspaimport { getEmptyFlatEntityValidationError } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/utils/get-flat-entity-validation-error.util';import { FlatEntityUpdateValidationArgs } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/types/universal-flat-entity-update-validation-args.type';import { UniversalFlatEntityValidationArgs } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/types/universal-flat-entity-validation-args.type';+import { validateObjectPermissionGrantsNoDisabledAction } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-object-permission-grants-no-disabled-action.util';import { validateRoleBelongsToCallerApplication } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-role-belongs-to-caller-application.util';@Injectable()@@ -93,6 +94,13 @@ export class FlatObjectPermissionValidatorService {});}+ validationResult.errors.push(+ ...validateObjectPermissionGrantsNoDisabledAction({+ flatObjectPermission: flatObjectPermissionToValidate,+ flatObjectMetadata: referencedObjectMetadata,+ }),+ );+const duplicateForSameRoleAndObject = Object.values(optimisticFlatObjectPermissionMaps.byUniversalIdentifier,).filter(@@ -201,6 +209,17 @@ export class FlatObjectPermissionValidatorService {}}+ validationResult.errors.push(+ ...validateObjectPermissionGrantsNoDisabledAction({+ flatObjectPermission: updatedFlatObjectPermission,+ flatObjectMetadata: findFlatEntityByUniversalIdentifier({+ universalIdentifier:+ updatedFlatObjectPermission.objectMetadataUniversalIdentifier,+ flatEntityMaps: flatObjectMetadataMaps,+ }),+ }),+ );+const duplicateForSameRoleAndObject = Object.values(optimisticFlatObjectPermissionMaps.byUniversalIdentifier,).filter(diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/__tests__/validate-object-permission-grants-no-disabled-action.util.spec.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/__tests__/validate-object-permission-grants-no-disabled-action.util.spec.tsnew file mode 100644index 00000000000..4dd35f79d13--- /dev/null+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/__tests__/validate-object-permission-grants-no-disabled-action.util.spec.ts@@ -0,0 +1,52 @@+import { getFlatObjectMetadataMock } from 'src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock';+import { type UniversalFlatObjectPermission } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/universal-flat-object-permission.type';+import { validateObjectPermissionGrantsNoDisabledAction } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-object-permission-grants-no-disabled-action.util';++const OBJECT_UNIVERSAL_IDENTIFIER = 'invoice-universal-identifier';++const buildObjectPermission = (+ overrides: Partial<UniversalFlatObjectPermission>,+): UniversalFlatObjectPermission => ({+ universalIdentifier: 'object-permission-universal-identifier',+ applicationUniversalIdentifier: 'application-universal-identifier',+ roleUniversalIdentifier: 'role-universal-identifier',+ objectMetadataUniversalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,+ canReadObjectRecords: true,+ canUpdateObjectRecords: null,+ canSoftDeleteObjectRecords: null,+ canDestroyObjectRecords: null,+ createdAt: '2026-10-27T00:00:00.000Z',+ updatedAt: '2026-10-27T00:00:00.000Z',+ ...overrides,+});++const invoice = getFlatObjectMetadataMock({+ universalIdentifier: OBJECT_UNIVERSAL_IDENTIFIER,+ disabledObjectPermissionActions: ['canDestroyObjectRecords'],+});++describe('validateObjectPermissionGrantsNoDisabledAction', () => {+ it('should reject granting an action the object disables', () => {+ expect(+ validateObjectPermissionGrantsNoDisabledAction({+ flatObjectPermission: buildObjectPermission({+ canDestroyObjectRecords: true,+ }),+ flatObjectMetadata: invoice,+ }),+ ).toEqual([expect.objectContaining({ value: 'canDestroyObjectRecords' })]);+ });++ it('should accept turning a disabled action off or leaving it unset', () => {+ for (const canDestroyObjectRecords of [false, null]) {+ expect(+ validateObjectPermissionGrantsNoDisabledAction({+ flatObjectPermission: buildObjectPermission({+ canDestroyObjectRecords,+ }),+ flatObjectMetadata: invoice,+ }),+ ).toEqual([]);+ }+ });+});diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-object-permission-grants-no-disabled-action.util.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-object-permission-grants-no-disabled-action.util.tsnew file mode 100644index 00000000000..1f5781a2cf6--- /dev/null+++ b/packages/twenty-server/src/engine/workspace-manager/workspace-migration/workspace-migration-builder/validators/utils/validate-object-permission-grants-no-disabled-action.util.ts@@ -0,0 +1,28 @@+import { msg, t } from '@lingui/core/macro';+import { type ObjectPermissionAction } from 'twenty-shared/application';++import { PermissionsExceptionCode } from 'src/engine/metadata-modules/permissions/permissions.exception';+import { type UniversalFlatObjectMetadata } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/universal-flat-object-metadata.type';+import { type UniversalFlatObjectPermission } from 'src/engine/workspace-manager/workspace-migration/universal-flat-entity/types/universal-flat-object-permission.type';+import { type FlatEntityValidationError } from 'src/engine/workspace-manager/workspace-migration/workspace-migration-builder/builders/types/failed-flat-entity-validation.type';++export const validateObjectPermissionGrantsNoDisabledAction = ({+ flatObjectPermission,+ flatObjectMetadata,+}: {+ flatObjectPermission: Pick<+ UniversalFlatObjectPermission,+ ObjectPermissionAction | 'objectMetadataUniversalIdentifier'+ >;+ flatObjectMetadata:+ | Pick<UniversalFlatObjectMetadata, 'disabledObjectPermissionActions'>+ | undefined;+}): FlatEntityValidationError[] =>+ (flatObjectMetadata?.disabledObjectPermissionActions ?? [])+ .filter((action) => flatObjectPermission[action])+ .map((action) => ({+ code: PermissionsExceptionCode.INVALID_SETTING,+ message: t`${action} is disabled on object ${flatObjectPermission.objectMetadataUniversalIdentifier}`,+ userFriendlyMessage: msg`This permission is disabled on the object and cannot be granted`,+ value: action,+ }));diff --git a/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/successful-sync-application-workspace-migration.integration-spec.ts.snap b/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/successful-sync-application-workspace-migration.integration-spec.ts.snapindex 8e78bf253f6..dc9707d091e 100644--- a/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/successful-sync-application-workspace-migration.integration-spec.ts.snap+++ b/packages/twenty-server/test/integration/metadata/suites/application/__snapshots__/successful-sync-application-workspace-migration.integration-spec.ts.snap@@ -153,6 +153,7 @@ exports[`syncApplication should delete old field and create equivalent one when"color": null,"createdAt": Any<String>,"description": "A support ticket",+ "disabledObjectPermissionActions": null,"duplicateCriteria": null,"icon": "IconTicket","imageIdentifierFieldMetadataUniversalIdentifier": null,@@ -1898,6 +1899,7 @@ exports[`syncApplication should return workspace migration actions on initial sy"color": null,"createdAt": Any<String>,"description": "A support ticket",+ "disabledObjectPermissionActions": null,"duplicateCriteria": null,"icon": "IconTicket","imageIdentifierFieldMetadataUniversalIdentifier": null,diff --git a/packages/twenty-shared/src/application/objectManifestType.ts b/packages/twenty-shared/src/application/objectManifestType.tsindex 6feb2ed7272..16dd3c2c6df 100644--- a/packages/twenty-shared/src/application/objectManifestType.ts+++ b/packages/twenty-shared/src/application/objectManifestType.ts@@ -1,3 +1,4 @@+import { type ObjectPermissionAction } from '@/application/objectPermissionActionType';import { type ObjectFieldManifest } from '@/application/objectFieldManifest.type';import { type SyncableEntityOptions } from '@/application/syncableEntityOptionsType';import { type MetadataReadability } from '@/types/MetadataReadability';@@ -20,6 +21,7 @@ export type ObjectManifest = SyncableEntityOptions & {writability?: MetadataWritability;readability?: MetadataReadability;readabilityParentFieldUniversalIdentifiers?: string[] | null;+ disabledObjectPermissionActions?: ObjectPermissionAction[];sharingReach?: ObjectSharingReach;openRecordIn?: ObjectOpenRecordIn;fields: ObjectFieldManifest[];