Skip to content

The open alternative to Salesforce, designed for AI.

List every record form field with its visibility (#27390)

Thomas Trompetteec0c34f6a42a
diff --git a/packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordFormFieldMetadataItems.ts b/packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordFormFields.ts
similarity index 54%
rename from packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordFormFieldMetadataItems.ts
rename to packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordFormFields.ts
index 9aa29d6b709..9a6b50ae61d 100644
--- a/packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordFormFieldMetadataItems.ts
+++ b/packages/twenty-front/src/modules/object-record/record-form/hooks/useRecordFormFields.ts
@@ -1,34 +1,28 @@
import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';
-import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
-import { useObjectPermissionsForObject } from '@/object-record/hooks/useObjectPermissionsForObject';
-import { computeRecordFormFieldMetadataItems } from '@/object-record/record-form/utils/computeRecordFormFieldMetadataItems';
+import { type RecordFormField } from '@/object-record/record-form/types/RecordFormField';
+import { computeRecordFormFields } from '@/object-record/record-form/utils/computeRecordFormFields';
import { recordFormPageLayoutByObjectMetadataIdFamilySelector } from '@/page-layout/states/selectors/recordFormPageLayoutByObjectMetadataIdFamilySelector';
import { useAtomFamilySelectorValue } from '@/ui/utilities/state/jotai/hooks/useAtomFamilySelectorValue';
import { isDefined } from 'twenty-shared/utils';
-export const useRecordFormFieldMetadataItems = ({
+export const useRecordFormFields = ({
objectMetadataItem,
}: {
objectMetadataItem: EnrichedObjectMetadataItem;
-}): { recordFormFieldMetadataItems: FieldMetadataItem[] } => {
+}): { recordFormFields: RecordFormField[] } => {
const recordFormPageLayout = useAtomFamilySelectorValue(
recordFormPageLayoutByObjectMetadataIdFamilySelector,
{ objectMetadataId: objectMetadataItem.id },
);
- const objectPermissions = useObjectPermissionsForObject(
- objectMetadataItem.id,
- );
-
if (!isDefined(recordFormPageLayout)) {
- return { recordFormFieldMetadataItems: [] };
+ return { recordFormFields: [] };
}
return {
- recordFormFieldMetadataItems: computeRecordFormFieldMetadataItems({
+ recordFormFields: computeRecordFormFields({
recordFormPageLayout,
fieldMetadataItems: objectMetadataItem.fields,
- restrictedFields: objectPermissions.restrictedFields,
}),
};
};
diff --git a/packages/twenty-front/src/modules/object-record/record-form/types/RecordFormField.ts b/packages/twenty-front/src/modules/object-record/record-form/types/RecordFormField.ts
new file mode 100644
index 00000000000..730c4074c95
--- /dev/null
+++ b/packages/twenty-front/src/modules/object-record/record-form/types/RecordFormField.ts
@@ -0,0 +1,10 @@
+import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
+import { type PageLayoutWidget } from '@/page-layout/types/PageLayoutWidget';
+
+export type RecordFormField<
+ TFieldMetadataItem extends Pick<FieldMetadataItem, 'id'> = FieldMetadataItem,
+> = {
+ fieldMetadataItem: TFieldMetadataItem;
+ widgets: Pick<PageLayoutWidget, 'id' | 'isActive'>[];
+ isVisible: boolean;
+};
diff --git a/packages/twenty-front/src/modules/object-record/record-form/utils/__tests__/computeRecordFormFieldMetadataItems.test.ts b/packages/twenty-front/src/modules/object-record/record-form/utils/__tests__/computeRecordFormFieldMetadataItems.test.ts
deleted file mode 100644
index 9d6c19a78da..00000000000
--- a/packages/twenty-front/src/modules/object-record/record-form/utils/__tests__/computeRecordFormFieldMetadataItems.test.ts
+++ /dev/null
@@ -1,168 +0,0 @@
-import { computeRecordFormFieldMetadataItems } from '@/object-record/record-form/utils/computeRecordFormFieldMetadataItems';
-import {
- PageLayoutTabLayoutMode,
- WidgetConfigurationType,
- WidgetType,
-} from '~/generated-metadata/graphql';
-
-const buildFieldMetadataItem = (id: string, name: string) => ({ id, name });
-
-const buildFormFieldWidget = ({
- fieldMetadataId,
- index,
- isActive = true,
- type = WidgetType.FORM_FIELD,
-}: {
- fieldMetadataId: string;
- index: number;
- isActive?: boolean;
- type?: WidgetType;
-}) => ({
- id: `widget-${fieldMetadataId}`,
- isActive,
- type,
- position: {
- layoutMode: PageLayoutTabLayoutMode.VERTICAL_LIST,
- index,
- },
- configuration: {
- configurationType: WidgetConfigurationType.FORM_FIELD,
- fieldMetadataId,
- },
-});
-
-const buildPageLayout = (
- tabs: {
- position: number;
- isActive?: boolean;
- widgets: ReturnType<typeof buildFormFieldWidget>[];
- }[],
-) => ({
- tabs: tabs.map((tab) => ({
- isActive: tab.isActive ?? true,
- position: tab.position,
- widgets: tab.widgets,
- })),
-});
-
-const NAME_FIELD = buildFieldMetadataItem('field-name', 'name');
-const CODE_FIELD = buildFieldMetadataItem('field-code', 'code');
-const CITY_FIELD = buildFieldMetadataItem('field-city', 'city');
-
-describe('computeRecordFormFieldMetadataItems', () => {
- it('should order fields by their widget index', () => {
- const result = computeRecordFormFieldMetadataItems({
- recordFormPageLayout: buildPageLayout([
- {
- position: 10,
- widgets: [
- buildFormFieldWidget({ fieldMetadataId: 'field-code', index: 1 }),
- buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
- ],
- },
- ]),
- fieldMetadataItems: [NAME_FIELD, CODE_FIELD],
- restrictedFields: {},
- });
-
- expect(result.map((field) => field.name)).toEqual(['name', 'code']);
- });
-
- it('should keep every tab contiguous rather than interleaving their indexes', () => {
- const result = computeRecordFormFieldMetadataItems({
- recordFormPageLayout: buildPageLayout([
- {
- position: 20,
- widgets: [
- buildFormFieldWidget({ fieldMetadataId: 'field-city', index: 0 }),
- ],
- },
- {
- position: 10,
- widgets: [
- buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
- buildFormFieldWidget({ fieldMetadataId: 'field-code', index: 1 }),
- ],
- },
- ]),
- fieldMetadataItems: [NAME_FIELD, CODE_FIELD, CITY_FIELD],
- restrictedFields: {},
- });
-
- expect(result.map((field) => field.name)).toEqual(['name', 'code', 'city']);
- });
-
- it('should drop inactive widgets, inactive tabs and non form field widgets', () => {
- const result = computeRecordFormFieldMetadataItems({
- recordFormPageLayout: buildPageLayout([
- {
- position: 10,
- widgets: [
- buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
- buildFormFieldWidget({
- fieldMetadataId: 'field-code',
- index: 1,
- isActive: false,
- }),
- buildFormFieldWidget({
- fieldMetadataId: 'field-city',
- index: 2,
- type: WidgetType.FIELDS,
- }),
- ],
- },
- {
- position: 20,
- isActive: false,
- widgets: [
- buildFormFieldWidget({ fieldMetadataId: 'field-city', index: 0 }),
- ],
- },
- ]),
- fieldMetadataItems: [NAME_FIELD, CODE_FIELD, CITY_FIELD],
- restrictedFields: {},
- });
-
- expect(result.map((field) => field.name)).toEqual(['name']);
- });
-
- it('should drop widgets whose field is not on the object', () => {
- const result = computeRecordFormFieldMetadataItems({
- recordFormPageLayout: buildPageLayout([
- {
- position: 10,
- widgets: [
- buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
- buildFormFieldWidget({ fieldMetadataId: 'field-gone', index: 1 }),
- ],
- },
- ]),
- fieldMetadataItems: [NAME_FIELD],
- restrictedFields: {},
- });
-
- expect(result.map((field) => field.name)).toEqual(['name']);
- });
-
- it('should drop fields the user cannot update, keeping explicitly allowed and unrestricted ones', () => {
- const result = computeRecordFormFieldMetadataItems({
- recordFormPageLayout: buildPageLayout([
- {
- position: 10,
- widgets: [
- buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
- buildFormFieldWidget({ fieldMetadataId: 'field-code', index: 1 }),
- buildFormFieldWidget({ fieldMetadataId: 'field-city', index: 2 }),
- ],
- },
- ]),
- fieldMetadataItems: [NAME_FIELD, CODE_FIELD, CITY_FIELD],
- restrictedFields: {
- 'field-code': { canRead: true, canUpdate: false },
- 'field-city': { canRead: true, canUpdate: true },
- },
- });
-
- expect(result.map((field) => field.name)).toEqual(['name', 'city']);
- });
-});
diff --git a/packages/twenty-front/src/modules/object-record/record-form/utils/__tests__/computeRecordFormFields.test.ts b/packages/twenty-front/src/modules/object-record/record-form/utils/__tests__/computeRecordFormFields.test.ts
new file mode 100644
index 00000000000..9adb0839efd
--- /dev/null
+++ b/packages/twenty-front/src/modules/object-record/record-form/utils/__tests__/computeRecordFormFields.test.ts
@@ -0,0 +1,391 @@
+import { computeRecordFormFields } from '@/object-record/record-form/utils/computeRecordFormFields';
+import {
+ FieldMetadataType,
+ PageLayoutTabLayoutMode,
+ RelationType,
+ WidgetConfigurationType,
+ WidgetType,
+} from '~/generated-metadata/graphql';
+
+const buildFieldMetadataItem = (
+ id: string,
+ name: string,
+ overrides: Partial<{
+ type: FieldMetadataType;
+ isActive: boolean;
+ isSystem: boolean;
+ isUIEditable: boolean;
+ settings: unknown;
+ morphRelations: { sourceFieldMetadata: { id: string; name: string } }[];
+ }> = {},
+) => ({
+ id,
+ name,
+ type: FieldMetadataType.TEXT,
+ isActive: true,
+ isSystem: false,
+ isUIEditable: true,
+ settings: null,
+ morphRelations: null,
+ ...overrides,
+});
+
+const buildFormFieldWidget = ({
+ fieldMetadataId,
+ index,
+ isActive = true,
+ type = WidgetType.FORM_FIELD,
+ id = `widget-${fieldMetadataId}`,
+}: {
+ fieldMetadataId: string;
+ index: number;
+ isActive?: boolean;
+ type?: WidgetType;
+ id?: string;
+}) => ({
+ id,
+ isActive,
+ type,
+ position: {
+ layoutMode: PageLayoutTabLayoutMode.VERTICAL_LIST,
+ index,
+ },
+ configuration: {
+ configurationType: WidgetConfigurationType.FORM_FIELD,
+ fieldMetadataId,
+ },
+});
+
+const buildPageLayout = (
+ tabs: {
+ position: number;
+ isActive?: boolean;
+ widgets: ReturnType<typeof buildFormFieldWidget>[];
+ }[],
+) => ({
+ tabs: tabs.map((tab) => ({
+ isActive: tab.isActive ?? true,
+ position: tab.position,
+ widgets: tab.widgets,
+ })),
+});
+
+const summarize = (
+ recordFormFields: ReturnType<typeof computeRecordFormFields>,
+) =>
+ recordFormFields.map(({ fieldMetadataItem, widgets, isVisible }) => ({
+ name: fieldMetadataItem.name,
+ widgets: widgets.map(({ id, isActive }) => [id, isActive]),
+ isVisible,
+ }));
+
+const NAME_FIELD = buildFieldMetadataItem('field-name', 'name');
+const CODE_FIELD = buildFieldMetadataItem('field-code', 'code');
+const CITY_FIELD = buildFieldMetadataItem('field-city', 'city');
+
+describe('computeRecordFormFields', () => {
+ it('should order fields by their widget index', () => {
+ const result = computeRecordFormFields({
+ recordFormPageLayout: buildPageLayout([
+ {
+ position: 10,
+ widgets: [
+ buildFormFieldWidget({ fieldMetadataId: 'field-code', index: 1 }),
+ buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
+ ],
+ },
+ ]),
+ fieldMetadataItems: [NAME_FIELD, CODE_FIELD],
+ });
+
+ expect(result.map(({ fieldMetadataItem }) => fieldMetadataItem)).toEqual([
+ NAME_FIELD,
+ CODE_FIELD,
+ ]);
+ });
+
+ it('should keep every tab contiguous rather than interleaving their indexes', () => {
+ const result = computeRecordFormFields({
+ recordFormPageLayout: buildPageLayout([
+ {
+ position: 20,
+ widgets: [
+ buildFormFieldWidget({ fieldMetadataId: 'field-city', index: 0 }),
+ ],
+ },
+ {
+ position: 10,
+ widgets: [
+ buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
+ buildFormFieldWidget({ fieldMetadataId: 'field-code', index: 1 }),
+ ],
+ },
+ ]),
+ fieldMetadataItems: [NAME_FIELD, CODE_FIELD, CITY_FIELD],
+ });
+
+ expect(result.map((field) => field.fieldMetadataItem.name)).toEqual([
+ 'name',
+ 'code',
+ 'city',
+ ]);
+ });
+
+ it('should keep a hidden widget at its position, marked as not visible', () => {
+ const result = computeRecordFormFields({
+ recordFormPageLayout: buildPageLayout([
+ {
+ position: 10,
+ widgets: [
+ buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
+ buildFormFieldWidget({
+ fieldMetadataId: 'field-code',
+ index: 1,
+ isActive: false,
+ }),
+ buildFormFieldWidget({ fieldMetadataId: 'field-city', index: 2 }),
+ ],
+ },
+ ]),
+ fieldMetadataItems: [NAME_FIELD, CODE_FIELD, CITY_FIELD],
+ });
+
+ expect(summarize(result)).toEqual([
+ {
+ name: 'name',
+ widgets: [['widget-field-name', true]],
+ isVisible: true,
+ },
+ {
+ name: 'code',
+ widgets: [['widget-field-code', false]],
+ isVisible: false,
+ },
+ {
+ name: 'city',
+ widgets: [['widget-field-city', true]],
+ isVisible: true,
+ },
+ ]);
+ });
+
+ it('should merge the widgets of a field into one entry, placed at its first visible widget', () => {
+ const result = computeRecordFormFields({
+ recordFormPageLayout: buildPageLayout([
+ {
+ position: 10,
+ widgets: [
+ buildFormFieldWidget({
+ fieldMetadataId: 'field-name',
+ index: 0,
+ isActive: false,
+ id: 'hidden-name-widget',
+ }),
+ buildFormFieldWidget({ fieldMetadataId: 'field-code', index: 1 }),
+ buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 2 }),
+ buildFormFieldWidget({
+ fieldMetadataId: 'field-city',
+ index: 3,
+ isActive: false,
+ }),
+ buildFormFieldWidget({
+ fieldMetadataId: 'field-city',
+ index: 4,
+ isActive: false,
+ id: 'second-city-widget',
+ }),
+ ],
+ },
+ ]),
+ fieldMetadataItems: [NAME_FIELD, CODE_FIELD, CITY_FIELD],
+ });
+
+ expect(summarize(result)).toEqual([
+ {
+ name: 'code',
+ widgets: [['widget-field-code', true]],
+ isVisible: true,
+ },
+ {
+ name: 'name',
+ widgets: [
+ ['hidden-name-widget', false],
+ ['widget-field-name', true],
+ ],
+ isVisible: true,
+ },
+ {
+ name: 'city',
+ widgets: [
+ ['widget-field-city', false],
+ ['second-city-widget', false],
+ ],
+ isVisible: false,
+ },
+ ]);
+ });
+
+ it('should merge the widgets of every morph target into the morph field', () => {
+ const ownerField = buildFieldMetadataItem('field-owner-person', 'owner', {
+ type: FieldMetadataType.MORPH_RELATION,
+ settings: { relationType: RelationType.MANY_TO_ONE },
+ morphRelations: [
+ {
+ sourceFieldMetadata: {
+ id: 'field-owner-person',
+ name: 'ownerPerson',
+ },
+ },
+ {
+ sourceFieldMetadata: {
+ id: 'field-owner-company',
+ name: 'ownerCompany',
+ },
+ },
+ ],
+ });
+
+ const result = computeRecordFormFields({
+ recordFormPageLayout: buildPageLayout([
+ {
+ position: 10,
+ widgets: [
+ buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
+ buildFormFieldWidget({
+ fieldMetadataId: 'field-owner-person',
+ index: 1,
+ isActive: false,
+ }),
+ buildFormFieldWidget({
+ fieldMetadataId: 'field-owner-company',
+ index: 2,
+ isActive: false,
+ }),
+ ],
+ },
+ ]),
+ fieldMetadataItems: [NAME_FIELD, ownerField],
+ });
+
+ expect(summarize(result)).toEqual([
+ {
+ name: 'name',
+ widgets: [['widget-field-name', true]],
+ isVisible: true,
+ },
+ {
+ name: 'owner',
+ widgets: [
+ ['widget-field-owner-person', false],
+ ['widget-field-owner-company', false],
+ ],
+ isVisible: false,
+ },
+ ]);
+ });
+
+ it('should drop inactive tabs, non form field widgets and widgets of deleted fields', () => {
+ const result = computeRecordFormFields({
+ recordFormPageLayout: buildPageLayout([
+ {
+ position: 10,
+ widgets: [
+ buildFormFieldWidget({ fieldMetadataId: 'field-name', index: 0 }),
+ buildFormFieldWidget({ fieldMetadataId: 'field-gone', index: 1 }),
+ buildFormFieldWidget({
+ fieldMetadataId: 'field-city',
+ index: 2,
+ type: WidgetType.FIELDS,
+ }),
+ ],
+ },
+ {
+ position: 20,
+ isActive: false,
+ widgets: [
+ buildFormFieldWidget({ fieldMetadataId: 'field-code', index: 0 }),
+ ],
+ },
+ ]),
+ fieldMetadataItems: [NAME_FIELD, CODE_FIELD, CITY_FIELD],
+ });
+
+ expect(result.map((field) => field.fieldMetadataItem.name)).toEqual([
+ 'name',
+ ]);
+ });
+
+ it('should only keep hidden widgets whose field the form can offer', () => {
+ const hiddenFieldMetadataItems = [
+ buildFieldMetadataItem('field-inactive', 'inactive', {
+ isActive: false,
+ }),
+ buildFieldMetadataItem('field-system', 'system', { isSystem: true }),
+ buildFieldMetadataItem('field-rating', 'rating', {
+ type: FieldMetadataType.RATING,
+ }),
+ buildFieldMetadataItem('field-people', 'people', {
+ type: FieldMetadataType.RELATION,
+ settings: { relationType: RelationType.ONE_TO_MANY },
+ }),
+ buildFieldMetadataItem('field-company', 'company', {
+ type: FieldMetadataType.RELATION,
+ settings: { relationType: RelationType.MANY_TO_ONE },
+ }),
+ buildFieldMetadataItem('field-legacy', 'legacy', {
+ settings: 'not-an-object',
+ }),
+ ];
+
+ const result = computeRecordFormFields({
+ recordFormPageLayout: buildPageLayout([
+ {
+ position: 10,
+ widgets: hiddenFieldMetadataItems.map(({ id }, index) =>
+ buildFormFieldWidget({
+ fieldMetadataId: id,
+ index,
+ isActive: false,
+ }),
+ ),
+ },
+ ]),
+ fieldMetadataItems: hiddenFieldMetadataItems,
+ });
+
+ expect(result.map((field) => field.fieldMetadataItem.name)).toEqual([
+ 'company',
+ 'legacy',
+ ]);
+ });
+
+ it('should keep visible widgets whatever their field', () => {
+ const visibleFieldMetadataItems = [
+ buildFieldMetadataItem('field-system', 'system', { isSystem: true }),
+ buildFieldMetadataItem('field-rating', 'rating', {
+ type: FieldMetadataType.RATING,
+ }),
+ buildFieldMetadataItem('field-files', 'files', {
+ type: FieldMetadataType.FILES,
+ }),
+ ];
+
+ const result = computeRecordFormFields({
+ recordFormPageLayout: buildPageLayout([
+ {
+ position: 10,
+ widgets: visibleFieldMetadataItems.map(({ id }, index) =>
+ buildFormFieldWidget({ fieldMetadataId: id, index }),
+ ),
+ },
+ ]),
+ fieldMetadataItems: visibleFieldMetadataItems,
+ });
+
+ expect(result.map((field) => field.fieldMetadataItem.name)).toEqual([
+ 'system',
+ 'rating',
+ 'files',
+ ]);
+ });
+});
diff --git a/packages/twenty-front/src/modules/object-record/record-form/utils/computeRecordFormFieldMetadataItems.ts b/packages/twenty-front/src/modules/object-record/record-form/utils/computeRecordFormFieldMetadataItems.ts
deleted file mode 100644
index 664b1f1d2fd..00000000000
--- a/packages/twenty-front/src/modules/object-record/record-form/utils/computeRecordFormFieldMetadataItems.ts
+++ /dev/null
@@ -1,91 +0,0 @@
-import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
-import { getFieldPermissions } from '@/object-metadata/utils/getFieldPermissions';
-import { type PageLayoutTab } from '@/page-layout/types/PageLayoutTab';
-import { type PageLayoutWidget } from '@/page-layout/types/PageLayoutWidget';
-import { type RestrictedFieldsPermissions } from 'twenty-shared/types';
-import { isDefined } from 'twenty-shared/utils';
-import {
- PageLayoutTabLayoutMode,
- WidgetConfigurationType,
- WidgetType,
-} from '~/generated-metadata/graphql';
-
-type RecordFormWidget = Pick<
- PageLayoutWidget,
- 'isActive' | 'type' | 'position' | 'configuration'
->;
-
-type RecordFormTab = Pick<PageLayoutTab, 'isActive' | 'position'> & {
- widgets?: RecordFormWidget[] | null;
-};
-
-type RecordFormLayout = { tabs: RecordFormTab[] };
-
-const getVerticalListIndex = (pageLayoutWidget: RecordFormWidget): number => {
- const { position } = pageLayoutWidget;
-
- return isDefined(position) &&
- position.layoutMode === PageLayoutTabLayoutMode.VERTICAL_LIST &&
- 'index' in position
- ? position.index
- : 0;
-};
-
-const getFormFieldMetadataId = (
- pageLayoutWidget: RecordFormWidget,
-): string | undefined => {
- const { configuration } = pageLayoutWidget;
-
- return configuration.configurationType ===
- WidgetConfigurationType.FORM_FIELD && 'fieldMetadataId' in configuration
- ? configuration.fieldMetadataId
- : undefined;
-};
-
-export const computeRecordFormFieldMetadataItems = <
- TFieldMetadataItem extends Pick<FieldMetadataItem, 'id'>,
->({
- recordFormPageLayout,
- fieldMetadataItems,
- restrictedFields,
-}: {
- recordFormPageLayout: RecordFormLayout;
- fieldMetadataItems: TFieldMetadataItem[];
- restrictedFields: RestrictedFieldsPermissions;
-}): TFieldMetadataItem[] => {
- const fieldMetadataItemById = new Map(
- fieldMetadataItems
- .filter(
- (fieldMetadataItem) =>
- getFieldPermissions({
- objectPermissions: { restrictedFields },
- fieldMetadataId: fieldMetadataItem.id,
- }).canUpdateField,
- )
- .map((fieldMetadataItem) => [fieldMetadataItem.id, fieldMetadataItem]),
- );
-
- return [...recordFormPageLayout.tabs]
- .filter((pageLayoutTab) => pageLayoutTab.isActive)
- .sort((tabA, tabB) => tabA.position - tabB.position)
- .flatMap((pageLayoutTab) =>
- [...(pageLayoutTab.widgets ?? [])]
- .filter(
- (pageLayoutWidget) =>
- pageLayoutWidget.isActive &&
- pageLayoutWidget.type === WidgetType.FORM_FIELD,
- )
- .sort(
- (widgetA, widgetB) =>
- getVerticalListIndex(widgetA) - getVerticalListIndex(widgetB),
- ),
- )
- .map((pageLayoutWidget) => {
- const fieldMetadataId = getFormFieldMetadataId(pageLayoutWidget);
-
- return isDefined(fieldMetadataId)
- ? fieldMetadataItemById.get(fieldMetadataId)
- : undefined;
- })
- .filter(isDefined);
-};
diff --git a/packages/twenty-front/src/modules/object-record/record-form/utils/computeRecordFormFields.ts b/packages/twenty-front/src/modules/object-record/record-form/utils/computeRecordFormFields.ts
new file mode 100644
index 00000000000..915ba172b59
--- /dev/null
+++ b/packages/twenty-front/src/modules/object-record/record-form/utils/computeRecordFormFields.ts
@@ -0,0 +1,158 @@
+import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
+import { type FieldMetadataItemRelation } from '@/object-metadata/types/FieldMetadataItemRelation';
+import { type RecordFormField } from '@/object-record/record-form/types/RecordFormField';
+import { type PageLayoutTab } from '@/page-layout/types/PageLayoutTab';
+import { type PageLayoutWidget } from '@/page-layout/types/PageLayoutWidget';
+import groupBy from 'lodash.groupby';
+import uniqBy from 'lodash.uniqby';
+import {
+ isDefined,
+ isFieldMetadataEligibleForRecordForm,
+} from 'twenty-shared/utils';
+import {
+ PageLayoutTabLayoutMode,
+ WidgetConfigurationType,
+ WidgetType,
+} from '~/generated-metadata/graphql';
+
+type RecordFormWidget = Pick<
+ PageLayoutWidget,
+ 'id' | 'isActive' | 'type' | 'position' | 'configuration'
+>;
+
+type RecordFormTab = Pick<PageLayoutTab, 'isActive' | 'position'> & {
+ widgets?: RecordFormWidget[] | null;
+};
+
+type RecordFormLayout = { tabs: RecordFormTab[] };
+
+type RecordFormFieldMetadataItem = Pick<
+ FieldMetadataItem,
+ 'id' | 'name' | 'type' | 'isActive' | 'isSystem' | 'isUIEditable' | 'settings'
+> & {
+ morphRelations?:
+ | Pick<FieldMetadataItemRelation, 'sourceFieldMetadata'>[]
+ | null;
+};
+
+const getVerticalListIndex = (pageLayoutWidget: RecordFormWidget): number => {
+ const { position } = pageLayoutWidget;
+
+ return isDefined(position) &&
+ position.layoutMode === PageLayoutTabLayoutMode.VERTICAL_LIST &&
+ 'index' in position
+ ? position.index
+ : 0;
+};
+
+const getFormFieldMetadataId = (
+ pageLayoutWidget: RecordFormWidget,
+): string | undefined => {
+ const { configuration } = pageLayoutWidget;
+
+ return configuration.configurationType ===
+ WidgetConfigurationType.FORM_FIELD && 'fieldMetadataId' in configuration
+ ? configuration.fieldMetadataId
+ : undefined;
+};
+
+const isFieldMetadataItemEligibleForRecordForm = (
+ fieldMetadataItem: RecordFormFieldMetadataItem,
+): boolean =>
+ isFieldMetadataEligibleForRecordForm({
+ fieldName: fieldMetadataItem.name,
+ fieldType: fieldMetadataItem.type,
+ isActive: fieldMetadataItem.isActive === true,
+ isSystem: fieldMetadataItem.isSystem === true,
+ isUIEditable: fieldMetadataItem.isUIEditable !== false,
+ relationType: fieldMetadataItem.settings?.relationType,
+ });
+
+export const computeRecordFormFields = <
+ TFieldMetadataItem extends RecordFormFieldMetadataItem,
+>({
+ recordFormPageLayout,
+ fieldMetadataItems,
+}: {
+ recordFormPageLayout: RecordFormLayout;
+ fieldMetadataItems: TFieldMetadataItem[];
+}): RecordFormField<TFieldMetadataItem>[] => {
+ const fieldMetadataItemByFormFieldMetadataId = new Map<
+ string,
+ TFieldMetadataItem
+ >();
+
+ for (const fieldMetadataItem of fieldMetadataItems) {
+ const formFieldMetadataIds = [
+ fieldMetadataItem.id,
+ ...(fieldMetadataItem.morphRelations ?? []).map(
+ (morphRelation) => morphRelation.sourceFieldMetadata.id,
+ ),
+ ];
+
+ for (const formFieldMetadataId of formFieldMetadataIds) {
+ if (!fieldMetadataItemByFormFieldMetadataId.has(formFieldMetadataId)) {
+ fieldMetadataItemByFormFieldMetadataId.set(
+ formFieldMetadataId,
+ fieldMetadataItem,
+ );
+ }
+ }
+ }
+
+ const formFieldWidgetEntries = [...recordFormPageLayout.tabs]
+ .filter((pageLayoutTab) => pageLayoutTab.isActive)
+ .sort((tabA, tabB) => tabA.position - tabB.position)
+ .flatMap((pageLayoutTab) =>
+ [...(pageLayoutTab.widgets ?? [])]
+ .filter(
+ (pageLayoutWidget) => pageLayoutWidget.type === WidgetType.FORM_FIELD,
+ )
+ .sort(
+ (widgetA, widgetB) =>
+ getVerticalListIndex(widgetA) - getVerticalListIndex(widgetB),
+ ),
+ )
+ .flatMap((pageLayoutWidget) => {
+ const formFieldMetadataId = getFormFieldMetadataId(pageLayoutWidget);
+ const fieldMetadataItem = isDefined(formFieldMetadataId)
+ ? fieldMetadataItemByFormFieldMetadataId.get(formFieldMetadataId)
+ : undefined;
+
+ return isDefined(fieldMetadataItem)
+ ? [{ pageLayoutWidget, fieldMetadataItem }]
+ : [];
+ });
+
+ const formFieldWidgetEntriesByFieldMetadataId = groupBy(
+ formFieldWidgetEntries,
+ ({ fieldMetadataItem }) => fieldMetadataItem.id,
+ );
+
+ const visibleFieldMetadataIds = new Set(
+ formFieldWidgetEntries
+ .filter(({ pageLayoutWidget }) => pageLayoutWidget.isActive)
+ .map(({ fieldMetadataItem }) => fieldMetadataItem.id),
+ );
+
+ return uniqBy(
+ formFieldWidgetEntries.filter(
+ ({ pageLayoutWidget, fieldMetadataItem }) =>
+ pageLayoutWidget.isActive ||
+ !visibleFieldMetadataIds.has(fieldMetadataItem.id),
+ ),
+ ({ fieldMetadataItem }) => fieldMetadataItem.id,
+ )
+ .map(({ pageLayoutWidget, fieldMetadataItem }) => ({
+ fieldMetadataItem,
+ widgets: formFieldWidgetEntriesByFieldMetadataId[
+ fieldMetadataItem.id
+ ].map((formFieldWidgetEntry) => formFieldWidgetEntry.pageLayoutWidget),
+ isVisible: pageLayoutWidget.isActive,
+ }))
+ .filter(
+ ({ fieldMetadataItem, isVisible }) =>
+ isVisible ||
+ isFieldMetadataItemEligibleForRecordForm(fieldMetadataItem),
+ );
+};
diff --git a/packages/twenty-front/src/modules/page-layout/states/pageLayoutsWithRelationsSelector.ts b/packages/twenty-front/src/modules/page-layout/states/pageLayoutsWithRelationsSelector.ts
index d90cf6f5b8e..d0b91a95fce 100644
--- a/packages/twenty-front/src/modules/page-layout/states/pageLayoutsWithRelationsSelector.ts
+++ b/packages/twenty-front/src/modules/page-layout/states/pageLayoutsWithRelationsSelector.ts
@@ -1,7 +1,7 @@
import { metadataStoreState } from '@/metadata-store/states/metadataStoreState';
import { type FlatPageLayout } from '@/metadata-store/types/FlatPageLayout';
import { type FlatPageLayoutTab } from '@/metadata-store/types/FlatPageLayoutTab';
-import { type FlatPageLayoutWidget } from '@/metadata-store/types/FlatPageLayoutWidget';
+import { pageLayoutWidgetsByTabIdSelector } from '@/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector';
import { type PageLayout } from '@/page-layout/types/PageLayout';
import { createAtomSelector } from '@/ui/utilities/state/jotai/utils/createAtomSelector';
import { isDefined } from 'twenty-shared/utils';
@@ -15,15 +15,9 @@ export const pageLayoutsWithRelationsSelector = createAtomSelector<
.current as FlatPageLayout[];
const allFlatTabs = get(metadataStoreState, 'pageLayoutTabs')
.current as FlatPageLayoutTab[];
- const allFlatWidgets = get(metadataStoreState, 'pageLayoutWidgets')
- .current as FlatPageLayoutWidget[];
-
- const activeFlatWidgets = allFlatWidgets.filter(
- (widget) => widget.isActive,
- );
+ const widgetsByTabId = get(pageLayoutWidgetsByTabIdSelector);
const tabsByPageLayoutId = new Map<string, FlatPageLayoutTab[]>();
- const widgetsByTabId = new Map<string, FlatPageLayoutWidget[]>();
for (const tab of allFlatTabs) {
const existing = tabsByPageLayoutId.get(tab.pageLayoutId);
@@ -35,21 +29,13 @@ export const pageLayoutsWithRelationsSelector = createAtomSelector<
}
}
- for (const widget of activeFlatWidgets) {
- const existing = widgetsByTabId.get(widget.pageLayoutTabId);
-
- if (isDefined(existing)) {
- existing.push(widget);
- } else {
- widgetsByTabId.set(widget.pageLayoutTabId, [widget]);
- }
- }
-
return flatPageLayouts.map((flatPageLayout) => ({
...flatPageLayout,
tabs: (tabsByPageLayoutId.get(flatPageLayout.id) ?? []).map((tab) => ({
...tab,
- widgets: widgetsByTabId.get(tab.id) ?? [],
+ widgets: (widgetsByTabId.get(tab.id) ?? []).filter(
+ (widget) => widget.isActive,
+ ),
})),
}));
},
diff --git a/packages/twenty-front/src/modules/page-layout/states/selectors/__tests__/recordFormPageLayoutByObjectMetadataIdFamilySelector.test.ts b/packages/twenty-front/src/modules/page-layout/states/selectors/__tests__/recordFormPageLayoutByObjectMetadataIdFamilySelector.test.ts
new file mode 100644
index 00000000000..17d5d899345
--- /dev/null
+++ b/packages/twenty-front/src/modules/page-layout/states/selectors/__tests__/recordFormPageLayoutByObjectMetadataIdFamilySelector.test.ts
@@ -0,0 +1,68 @@
+import { createStore } from 'jotai';
+
+import { metadataStoreState } from '@/metadata-store/states/metadataStoreState';
+import { pageLayoutsWithRelationsSelector } from '@/page-layout/states/pageLayoutsWithRelationsSelector';
+import { recordFormPageLayoutByObjectMetadataIdFamilySelector } from '@/page-layout/states/selectors/recordFormPageLayoutByObjectMetadataIdFamilySelector';
+import { PageLayoutType } from '~/generated-metadata/graphql';
+
+const OBJECT_METADATA_ID = 'company-object';
+
+const buildWidget = (id: string, isActive: boolean) => ({
+ id,
+ pageLayoutTabId: 'record-form-tab',
+ isActive,
+});
+
+describe('recordFormPageLayoutByObjectMetadataIdFamilySelector', () => {
+ it('should keep the hidden widgets that record page layouts leave out', () => {
+ const store = createStore();
+
+ store.set(metadataStoreState.atomFamily('pageLayouts'), {
+ current: [
+ {
+ id: 'record-form',
+ type: PageLayoutType.RECORD_FORM,
+ objectMetadataId: OBJECT_METADATA_ID,
+ isSystemSideEffect: true,
+ },
+ ],
+ draft: [],
+ status: 'up-to-date',
+ });
+ store.set(metadataStoreState.atomFamily('pageLayoutTabs'), {
+ current: [{ id: 'record-form-tab', pageLayoutId: 'record-form' }],
+ draft: [],
+ status: 'up-to-date',
+ });
+ store.set(metadataStoreState.atomFamily('pageLayoutWidgets'), {
+ current: [
+ buildWidget('visible-widget', true),
+ buildWidget('hidden-widget', false),
+ ],
+ draft: [],
+ status: 'up-to-date',
+ });
+
+ const recordFormPageLayout = store.get(
+ recordFormPageLayoutByObjectMetadataIdFamilySelector.selectorFamily({
+ objectMetadataId: OBJECT_METADATA_ID,
+ }),
+ );
+ const [pageLayoutWithRelations] = store.get(
+ pageLayoutsWithRelationsSelector.atom,
+ );
+
+ expect(
+ recordFormPageLayout?.tabs[0].widgets?.map(({ id, isActive }) => [
+ id,
+ isActive,
+ ]),
+ ).toEqual([
+ ['visible-widget', true],
+ ['hidden-widget', false],
+ ]);
+ expect(
+ pageLayoutWithRelations.tabs[0].widgets?.map(({ id }) => id),
+ ).toEqual(['visible-widget']);
+ });
+});
diff --git a/packages/twenty-front/src/modules/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector.ts b/packages/twenty-front/src/modules/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector.ts
new file mode 100644
index 00000000000..fcedcbb98e8
--- /dev/null
+++ b/packages/twenty-front/src/modules/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector.ts
@@ -0,0 +1,28 @@
+import { metadataStoreState } from '@/metadata-store/states/metadataStoreState';
+import { type FlatPageLayoutWidget } from '@/metadata-store/types/FlatPageLayoutWidget';
+import { createAtomSelector } from '@/ui/utilities/state/jotai/utils/createAtomSelector';
+import { isDefined } from 'twenty-shared/utils';
+
+export const pageLayoutWidgetsByTabIdSelector = createAtomSelector<
+ Map<string, FlatPageLayoutWidget[]>
+>({
+ key: 'pageLayoutWidgetsByTabIdSelector',
+ get: ({ get }) => {
+ const allFlatWidgets = get(metadataStoreState, 'pageLayoutWidgets')
+ .current as FlatPageLayoutWidget[];
+
+ const widgetsByTabId = new Map<string, FlatPageLayoutWidget[]>();
+
+ for (const widget of allFlatWidgets) {
+ const existing = widgetsByTabId.get(widget.pageLayoutTabId);
+
+ if (isDefined(existing)) {
+ existing.push(widget);
+ } else {
+ widgetsByTabId.set(widget.pageLayoutTabId, [widget]);
+ }
+ }
+
+ return widgetsByTabId;
+ },
+});
diff --git a/packages/twenty-front/src/modules/page-layout/states/selectors/recordFormPageLayoutByObjectMetadataIdFamilySelector.ts b/packages/twenty-front/src/modules/page-layout/states/selectors/recordFormPageLayoutByObjectMetadataIdFamilySelector.ts
index c2b698c52d9..3cd57a06cd6 100644
--- a/packages/twenty-front/src/modules/page-layout/states/selectors/recordFormPageLayoutByObjectMetadataIdFamilySelector.ts
+++ b/packages/twenty-front/src/modules/page-layout/states/selectors/recordFormPageLayoutByObjectMetadataIdFamilySelector.ts
@@ -1,6 +1,8 @@
import { pageLayoutsWithRelationsSelector } from '@/page-layout/states/pageLayoutsWithRelationsSelector';
+import { pageLayoutWidgetsByTabIdSelector } from '@/page-layout/states/selectors/pageLayoutWidgetsByTabIdSelector';
import { type PageLayout } from '@/page-layout/types/PageLayout';
import { createAtomFamilySelector } from '@/ui/utilities/state/jotai/utils/createAtomFamilySelector';
+import { isDefined } from 'twenty-shared/utils';
import { PageLayoutType } from '~/generated-metadata/graphql';
export const recordFormPageLayoutByObjectMetadataIdFamilySelector =
@@ -24,6 +26,21 @@ export const recordFormPageLayoutByObjectMetadataIdFamilySelector =
(pageLayout) => !pageLayout.isSystemSideEffect,
);
- return customRecordFormPageLayout ?? recordFormPageLayouts[0];
+ const recordFormPageLayout =
+ customRecordFormPageLayout ?? recordFormPageLayouts[0];
+
+ if (!isDefined(recordFormPageLayout)) {
+ return undefined;
+ }
+
+ const widgetsByTabId = get(pageLayoutWidgetsByTabIdSelector);
+
+ return {
+ ...recordFormPageLayout,
+ tabs: recordFormPageLayout.tabs.map((tab) => ({
+ ...tab,
+ widgets: widgetsByTabId.get(tab.id) ?? [],
+ })),
+ };
},
});
diff --git a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/SidePanelRecordCreationFormPage.tsx b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/SidePanelRecordCreationFormPage.tsx
index e2d62e0f9b0..1ac03fb7cce 100644
--- a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/SidePanelRecordCreationFormPage.tsx
+++ b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/SidePanelRecordCreationFormPage.tsx
@@ -7,9 +7,11 @@ import { useHotkeysOnFocusedElement } from '@/ui/utilities/hotkey/hooks/useHotke
import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';
import { useObjectMetadataItemById } from '@/object-metadata/hooks/useObjectMetadataItemById';
import { useObjectMetadataItems } from '@/object-metadata/hooks/useObjectMetadataItems';
+import { getFieldPermissions } from '@/object-metadata/utils/getFieldPermissions';
+import { useObjectPermissionsForObject } from '@/object-record/hooks/useObjectPermissionsForObject';
import { RecordFormFieldInputs } from '@/object-record/record-form/components/RecordFormFieldInputs';
import { useRecordCreationFormSettle } from '@/object-record/record-form/hooks/useRecordCreationFormSettle';
-import { useRecordFormFieldMetadataItems } from '@/object-record/record-form/hooks/useRecordFormFieldMetadataItems';
+import { useRecordFormFields } from '@/object-record/record-form/hooks/useRecordFormFields';
import { computeRecordFormCreateRecordInput } from '@/object-record/record-form/utils/computeRecordFormCreateRecordInput';
import { type ObjectRecord } from '@/object-record/types/ObjectRecord';
import { recordCreationFormDraftComponentState } from '@/side-panel/pages/record-creation-form/states/recordCreationFormDraftComponentState';
@@ -114,9 +116,22 @@ const SidePanelRecordCreationForm = ({
const draftRecord = recordCreationFormDraft ?? initialDraftRecord;
- const { recordFormFieldMetadataItems } = useRecordFormFieldMetadataItems({
- objectMetadataItem,
- });
+ const { recordFormFields } = useRecordFormFields({ objectMetadataItem });
+ const objectPermissions = useObjectPermissionsForObject(
+ objectMetadataItem.id,
+ );
+
+ const editableRecordFormFields = recordFormFields.filter(
+ ({ fieldMetadataItem }) =>
+ getFieldPermissions({
+ objectPermissions,
+ fieldMetadataId: fieldMetadataItem.id,
+ }).canUpdateField,
+ );
+
+ const visibleFieldMetadataItems = editableRecordFormFields
+ .filter((recordFormField) => recordFormField.isVisible)
+ .map((recordFormField) => recordFormField.fieldMetadataItem);
const computeViolations = (draftRecordToCheck: Partial<ObjectRecord>) =>
computeDraftValidationRuleViolations({
@@ -172,7 +187,7 @@ const SidePanelRecordCreationForm = ({
requestId,
draftRecord: computeRecordFormCreateRecordInput({
draftRecord,
- fieldMetadataItems: recordFormFieldMetadataItems,
+ fieldMetadataItems: objectMetadataItem.fields,
objectMetadataItems,
}),
});
@@ -207,7 +222,7 @@ const SidePanelRecordCreationForm = ({
<StyledContent>
<RecordFormFieldInputs
objectMetadataItem={objectMetadataItem}
- fieldMetadataItems={recordFormFieldMetadataItems}
+ fieldMetadataItems={visibleFieldMetadataItems}
draftRecord={draftRecord}
onFieldValueChange={handleFieldValueChange}
onFieldValueClear={handleFieldValueClear}
diff --git a/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__tests__/SidePanelRecordCreationFormPage.test.tsx b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__tests__/SidePanelRecordCreationFormPage.test.tsx
new file mode 100644
index 00000000000..0ea39317c8f
--- /dev/null
+++ b/packages/twenty-front/src/modules/side-panel/pages/record-creation-form/components/__tests__/SidePanelRecordCreationFormPage.test.tsx
@@ -0,0 +1,233 @@
+import { i18n } from '@lingui/core';
+import { I18nProvider } from '@lingui/react';
+import { render, screen } from '@testing-library/react';
+import { Provider as JotaiProvider } from 'jotai';
+import { type createElement, type Fragment, type ReactNode } from 'react';
+import { MemoryRouter } from 'react-router-dom';
+
+import { metadataStoreState } from '@/metadata-store/states/metadataStoreState';
+import { SidePanelRecordCreationFormPage } from '@/side-panel/pages/record-creation-form/components/SidePanelRecordCreationFormPage';
+import { recordCreationFormRequestComponentState } from '@/side-panel/pages/record-creation-form/states/recordCreationFormRequestComponentState';
+import { SidePanelPageComponentInstanceContext } from '@/side-panel/states/contexts/SidePanelPageComponentInstanceContext';
+import {
+ jotaiStore,
+ resetJotaiStore,
+} from '@/ui/utilities/state/jotai/jotaiStore';
+import {
+ FieldMetadataType,
+ PageLayoutTabLayoutMode,
+ PageLayoutType,
+ WidgetConfigurationType,
+ WidgetType,
+} from '~/generated-metadata/graphql';
+
+const REQUEST_ID = 'creation-request';
+const OBJECT_METADATA_ID = 'company-object';
+const PAGE_LAYOUT_ID = 'company-record-form';
+const PAGE_LAYOUT_TAB_ID = 'company-record-form-fields';
+
+const buildTextField = (name: string, label: string) => ({
+ id: `field-${name}`,
+ universalIdentifier: `field-${name}`,
+ name,
+ label,
+ type: FieldMetadataType.TEXT,
+ icon: 'IconAbc',
+ isActive: true,
+ isSystem: false,
+ isUIEditable: true,
+ isNullable: true,
+ settings: null,
+});
+
+const NAME_FIELD = buildTextField('name', 'Name');
+const DOMAIN_FIELD = buildTextField('domain', 'Domain');
+const NICKNAME_FIELD = buildTextField('nickname', 'Nickname');
+const SECRET_FIELD = buildTextField('secret', 'Secret');
+const INTERNAL_NOTE_FIELD = buildTextField('internalNote', 'Internal note');
+
+const COMPANY_OBJECT = {
+ id: OBJECT_METADATA_ID,
+ nameSingular: 'company',
+ namePlural: 'companies',
+ labelSingular: 'Company',
+ labelPlural: 'Companies',
+ fields: [
+ NAME_FIELD,
+ DOMAIN_FIELD,
+ NICKNAME_FIELD,
+ SECRET_FIELD,
+ INTERNAL_NOTE_FIELD,
+ ],
+};
+
+const settleRecordCreationDraft = jest.fn();
+
+jest.mock('@/object-metadata/hooks/useObjectMetadataItemById', () => ({
+ useObjectMetadataItemById: () => ({ objectMetadataItem: COMPANY_OBJECT }),
+}));
+
+jest.mock('@/object-metadata/hooks/useObjectMetadataItems', () => ({
+ useObjectMetadataItems: () => ({ objectMetadataItems: [COMPANY_OBJECT] }),
+}));
+
+jest.mock('@/object-record/hooks/useObjectPermissionsForObject', () => ({
+ useObjectPermissionsForObject: () => ({
+ restrictedFields: {
+ 'field-secret': { canRead: true, canUpdate: false },
+ 'field-internalNote': { canRead: true, canUpdate: false },
+ },
+ }),
+}));
+
+jest.mock(
+ '@/object-record/record-form/hooks/useRecordCreationFormSettle',
+ () => ({
+ useRecordCreationFormSettle: () => ({ settleRecordCreationDraft }),
+ }),
+);
+
+jest.mock('@/validation-rules/hooks/useValidationRules', () => ({
+ useValidationRules: () => ({ validationRules: [] }),
+}));
+
+jest.mock('@/ui/utilities/hotkey/hooks/useHotkeysOnFocusedElement', () => ({
+ useHotkeysOnFocusedElement: () => undefined,
+}));
+
+jest.mock(
+ '@/object-record/record-form/components/RecordFormFieldInputs',
+ () => {
+ const ReactForMock = require('react') as {
+ createElement: typeof createElement;
+ Fragment: typeof Fragment;
+ };
+
+ return {
+ RecordFormFieldInputs: ({
+ fieldMetadataItems,
+ draftRecord,
+ onFieldValueChange,
+ }: {
+ fieldMetadataItems: { id: string; name: string; label: string }[];
+ draftRecord: Record<string, unknown>;
+ onFieldValueChange: (gqlFieldName: string, value: string) => void;
+ }) =>
+ ReactForMock.createElement(
+ ReactForMock.Fragment,
+ null,
+ fieldMetadataItems.map((fieldMetadataItem) =>
+ ReactForMock.createElement('input', {
+ key: fieldMetadataItem.id,
+ 'aria-label': fieldMetadataItem.label,
+ value: (draftRecord[fieldMetadataItem.name] as string) ?? '',
+ onChange: (event: { target: { value: string } }) =>
+ onFieldValueChange(fieldMetadataItem.name, event.target.value),
+ }),
+ ),
+ ),
+ };
+ },
+);
+
+const buildFormFieldWidget = (
+ fieldMetadataId: string,
+ index: number,
+ isActive: boolean,
+) => ({
+ id: `widget-${fieldMetadataId}`,
+ pageLayoutTabId: PAGE_LAYOUT_TAB_ID,
+ title: '',
+ type: WidgetType.FORM_FIELD,
+ isActive,
+ position: {
+ __typename: 'PageLayoutWidgetVerticalListPosition',
+ layoutMode: PageLayoutTabLayoutMode.VERTICAL_LIST,
+ index,
+ },
+ configuration: {
+ configurationType: WidgetConfigurationType.FORM_FIELD,
+ fieldMetadataId,
+ },
+});
+
+const seedRecordFormPageLayout = () => {
+ jotaiStore.set(metadataStoreState.atomFamily('pageLayouts'), {
+ current: [
+ {
+ id: PAGE_LAYOUT_ID,
+ type: PageLayoutType.RECORD_FORM,
+ objectMetadataId: OBJECT_METADATA_ID,
+ isSystemSideEffect: true,
+ },
+ ],
+ draft: [],
+ status: 'up-to-date',
+ });
+ jotaiStore.set(metadataStoreState.atomFamily('pageLayoutTabs'), {
+ current: [
+ {
+ id: PAGE_LAYOUT_TAB_ID,
+ pageLayoutId: PAGE_LAYOUT_ID,
+ isActive: true,
+ position: 0,
+ layoutMode: PageLayoutTabLayoutMode.VERTICAL_LIST,
+ },
+ ],
+ draft: [],
+ status: 'up-to-date',
+ });
+ jotaiStore.set(metadataStoreState.atomFamily('pageLayoutWidgets'), {
+ current: [
+ buildFormFieldWidget(NAME_FIELD.id, 0, true),
+ buildFormFieldWidget(DOMAIN_FIELD.id, 1, true),
+ buildFormFieldWidget(NICKNAME_FIELD.id, 2, false),
+ buildFormFieldWidget(SECRET_FIELD.id, 3, false),
+ buildFormFieldWidget(INTERNAL_NOTE_FIELD.id, 4, true),
+ ],
+ draft: [],
+ status: 'up-to-date',
+ });
+};
+
+const Wrapper = ({ children }: { children: ReactNode }) => (
+ <JotaiProvider store={jotaiStore}>
+ <I18nProvider i18n={i18n}>
+ <SidePanelPageComponentInstanceContext.Provider
+ value={{ instanceId: REQUEST_ID }}
+ >
+ <MemoryRouter>{children}</MemoryRouter>
+ </SidePanelPageComponentInstanceContext.Provider>
+ </I18nProvider>
+ </JotaiProvider>
+);
+
+const renderPage = () =>
+ render(<SidePanelRecordCreationFormPage />, { wrapper: Wrapper });
+
+describe('SidePanelRecordCreationFormPage', () => {
+ beforeEach(() => {
+ jest.clearAllMocks();
+ resetJotaiStore();
+ seedRecordFormPageLayout();
+ jotaiStore.set(
+ recordCreationFormRequestComponentState.atomFamily({
+ instanceId: REQUEST_ID,
+ }),
+ {
+ requestId: REQUEST_ID,
+ objectMetadataId: OBJECT_METADATA_ID,
+ initialDraftRecord: {},
+ },
+ );
+ });
+
+ it('shows the visible fields the user can update', () => {
+ renderPage();
+
+ expect(screen.getByLabelText('Name')).toBeInTheDocument();
+ expect(screen.getByLabelText('Domain')).toBeInTheDocument();
+ expect(screen.queryByLabelText('Internal note')).not.toBeInTheDocument();
+ expect(screen.queryByLabelText('Nickname')).not.toBeInTheDocument();
+ });
+});