The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Fix flaky 2FA encryption test for AES-256-CBC wrong-key behavior (#18126)
Félix Malfaitec57d3fe0f4f
diff --git a/packages/twenty-server/src/engine/core-modules/two-factor-authentication/utils/simple-secret-encryption.util.spec.ts b/packages/twenty-server/src/engine/core-modules/two-factor-authentication/utils/simple-secret-encryption.util.spec.tsindex e45cb60609e..9a025e3c682 100644--- a/packages/twenty-server/src/engine/core-modules/two-factor-authentication/utils/simple-secret-encryption.util.spec.ts+++ b/packages/twenty-server/src/engine/core-modules/two-factor-authentication/utils/simple-secret-encryption.util.spec.ts@@ -82,12 +82,19 @@ describe('SimpleSecretEncryptionUtil', () => {expect(decrypted).toBe(specialSecret);});- it('should fail to decrypt with wrong purpose', async () => {+ it('should not recover original secret with wrong purpose', async () => {const encrypted = await util.encryptSecret(testSecret, testPurpose);- await expect(- util.decryptSecret(encrypted, 'wrong-purpose'),- ).rejects.toThrow();+ // AES-256-CBC may either throw (invalid padding) or produce garbage.+ // Both outcomes are acceptable — the key property is that the original+ // secret is never returned.+ try {+ const decrypted = await util.decryptSecret(encrypted, 'wrong-purpose');++ expect(decrypted).not.toBe(testSecret);+ } catch {+ // Expected: wrong key produced invalid padding+ }});it('should fail to decrypt malformed encrypted data', async () => {