Skip to content

The open alternative to Salesforce, designed for AI.

fix(front): run a single Monaco instance across the app (#23855)

Félix Malfaitf4d5500fc480
diff --git a/packages/twenty-front/.storybook/preview.tsx b/packages/twenty-front/.storybook/preview.tsx
index 76297520058..1d2b2de6f7e 100644
--- a/packages/twenty-front/.storybook/preview.tsx
+++ b/packages/twenty-front/.storybook/preview.tsx
@@ -24,6 +24,10 @@ import { RootDecorator } from '../src/testing/decorators/RootDecorator';
import { resetJotaiStore } from '../src/modules/ui/utilities/state/jotai/jotaiStore';
// oxlint-disable-next-line no-restricted-imports
import { UserContext } from '../src/modules/users/contexts/UserContext';
+// Stories rendering CodeEditor / GraphiQL need Monaco's worker factory, which
+// the app normally sets up in src/index.tsx.
+// oxlint-disable-next-line no-restricted-imports
+import '../src/modules/app/utils/setupMonacoEnvironment';
import 'react-loading-skeleton/dist/skeleton.css';
import 'twenty-ui/style.css';
diff --git a/packages/twenty-front/src/index.tsx b/packages/twenty-front/src/index.tsx
index 7707173bfaf..23c414a6221 100644
--- a/packages/twenty-front/src/index.tsx
+++ b/packages/twenty-front/src/index.tsx
@@ -1,6 +1,7 @@
import ReactDOM from 'react-dom/client';
import { App } from '@/app/components/App';
+import '@/app/utils/setupMonacoEnvironment';
import { migrateTokenPairCookieToLocalStorage } from '@/auth/utils/migrateTokenPairCookieToLocalStorage';
import { hydrateMetadataStore } from '@/metadata-store/storage/metadataStoreStorage';
import '@fontsource/dm-mono/400.css';
diff --git a/packages/twenty-front/src/modules/app/utils/setupMonacoEnvironment.ts b/packages/twenty-front/src/modules/app/utils/setupMonacoEnvironment.ts
new file mode 100644
index 00000000000..6d3b62e226d
--- /dev/null
+++ b/packages/twenty-front/src/modules/app/utils/setupMonacoEnvironment.ts
@@ -0,0 +1,44 @@
+import { type Environment } from 'monaco-editor';
+import EditorWorker from 'monaco-editor/esm/vs/editor/editor.worker.js?worker';
+import CssWorker from 'monaco-editor/esm/vs/language/css/css.worker.js?worker';
+import HtmlWorker from 'monaco-editor/esm/vs/language/html/html.worker.js?worker';
+import JsonWorker from 'monaco-editor/esm/vs/language/json/json.worker.js?worker';
+import TypeScriptWorker from 'monaco-editor/esm/vs/language/typescript/ts.worker.js?worker';
+import GraphqlWorker from 'monaco-graphql/esm/graphql.worker.js?worker';
+
+// Monaco resolves every language worker through this single global, shared by
+// all editors on the page (GraphiQL's and CodeEditor's alike), so it has to be
+// set up once for the whole app rather than per feature.
+//
+// Every label Monaco can ask for must be mapped: an unmapped label silently
+// falls back to the generic editor worker, which carries no language service.
+// Requests to it then reject with "Missing requestHandler or method: <method>"
+// (`resetSchema`, `findDocumentColors`, `getCodeFixesAtPosition`, ...) and the
+// language features go quietly dead.
+const monacoEnvironment: Environment = {
+ getWorker: (_workerId, label) => {
+ switch (label) {
+ case 'json':
+ return new JsonWorker();
+ case 'css':
+ case 'scss':
+ case 'less':
+ return new CssWorker();
+ case 'html':
+ case 'handlebars':
+ case 'razor':
+ return new HtmlWorker();
+ case 'typescript':
+ case 'javascript':
+ return new TypeScriptWorker();
+ case 'graphql':
+ return new GraphqlWorker();
+ default:
+ return new EditorWorker();
+ }
+ },
+};
+
+(
+ globalThis as unknown as { MonacoEnvironment?: Environment }
+).MonacoEnvironment = monacoEnvironment;
diff --git a/packages/twenty-front/src/modules/settings/mcp-and-apis/components/GraphQLPlayground.tsx b/packages/twenty-front/src/modules/settings/mcp-and-apis/components/GraphQLPlayground.tsx
index 7fea4751a1d..151e8025a8d 100644
--- a/packages/twenty-front/src/modules/settings/mcp-and-apis/components/GraphQLPlayground.tsx
+++ b/packages/twenty-front/src/modules/settings/mcp-and-apis/components/GraphQLPlayground.tsx
@@ -1,4 +1,3 @@
-import '@/settings/mcp-and-apis/utils/setupGraphiqlMonacoWorkers';
import {
isPlaygroundApiKeyFresh,
playgroundApiKeyState,
diff --git a/packages/twenty-front/src/modules/settings/mcp-and-apis/utils/setupGraphiqlMonacoWorkers.ts b/packages/twenty-front/src/modules/settings/mcp-and-apis/utils/setupGraphiqlMonacoWorkers.ts
deleted file mode 100644
index b3c9c3700df..00000000000
--- a/packages/twenty-front/src/modules/settings/mcp-and-apis/utils/setupGraphiqlMonacoWorkers.ts
+++ /dev/null
@@ -1,22 +0,0 @@
-import { type Environment } from 'monaco-editor';
-import EditorWorker from 'monaco-editor/esm/vs/editor/editor.worker.js?worker';
-import JsonWorker from 'monaco-editor/esm/vs/language/json/json.worker.js?worker';
-import GraphqlWorker from 'monaco-graphql/esm/graphql.worker.js?worker';
-
-// GraphiQL 5's Monaco editors need a worker factory; without it Monaco throws "Cannot read properties of undefined (reading 'toUrl')".
-const monacoEnvironment: Environment = {
- getWorker: (_workerId, label) => {
- switch (label) {
- case 'json':
- return new JsonWorker();
- case 'graphql':
- return new GraphqlWorker();
- default:
- return new EditorWorker();
- }
- },
-};
-
-(
- globalThis as unknown as { MonacoEnvironment?: Environment }
-).MonacoEnvironment = monacoEnvironment;
diff --git a/packages/twenty-ui/src/input/CodeEditor/CodeEditor.tsx b/packages/twenty-ui/src/input/CodeEditor/CodeEditor.tsx
index 35130ba8b29..ec1c8f71cfc 100644
--- a/packages/twenty-ui/src/input/CodeEditor/CodeEditor.tsx
+++ b/packages/twenty-ui/src/input/CodeEditor/CodeEditor.tsx
@@ -1,4 +1,8 @@
-import Editor, { type EditorProps, type Monaco } from '@monaco-editor/react';
+import Editor, {
+ loader,
+ type EditorProps,
+ type Monaco,
+} from '@monaco-editor/react';
import { Loader } from '@ui/feedback/Loader/Loader';
import { BASE_CODE_EDITOR_THEME_ID } from '@ui/input/CodeEditor/constants/BaseCodeEditorThemeId';
import { getBaseCodeEditorTheme } from '@ui/input/CodeEditor/utils/getBaseCodeEditorTheme';
@@ -18,6 +22,34 @@ import styles from './CodeEditor.module.scss';
type CodeEditorVariant = 'default' | 'with-header' | 'borderless';
type CodeEditorContentPadding = 'default' | 'comfortable';
+// Left alone, `@monaco-editor/loader` downloads Monaco from a CDN at runtime,
+// which puts a second Monaco — pinned to a different version than the one we
+// bundle — on the page next to the one GraphiQL uses. The two then fight over
+// the single global `MonacoEnvironment` and end up talking to each other's
+// workers over an incompatible protocol. Point the loader at the bundled
+// instance so there is exactly one Monaco (and one that also works offline /
+// in self-hosted deployments, unlike the CDN).
+//
+// The import stays dynamic so Monaco is still only fetched when a code editor
+// is actually rendered, instead of weighing down every chunk importing this
+// component.
+//
+// Contract: the bundled ESM Monaco (unlike the CDN AMD build) resolves its
+// language workers through `globalThis.MonacoEnvironment`, which the host app
+// must set up before an editor mounts — worker wiring is bundler-specific, so
+// it can't live in this library. twenty-front does this in
+// `src/modules/app/utils/setupMonacoEnvironment.ts`; without it, language
+// services (validation, intellisense) are silently unavailable.
+let monacoLoaderConfiguration: Promise<void> | undefined;
+
+const configureMonacoLoader = () => {
+ monacoLoaderConfiguration ??= import('monaco-editor').then((monaco) => {
+ loader.config({ monaco });
+ });
+
+ return monacoLoaderConfiguration;
+};
+
const setCodeEditorTheme = (
monaco: Monaco,
theme: ThemeType,
@@ -67,6 +99,8 @@ export const CodeEditor = ({
editor.IStandaloneCodeEditor | undefined
>(undefined);
const [isEditorFocused, setIsEditorFocused] = useState(false);
+ const [isMonacoLoaderConfigured, setIsMonacoLoaderConfigured] =
+ useState(false);
const [autoHeightContentHeight, setAutoHeightContentHeight] = useState<
number | undefined
>(undefined);
@@ -124,6 +158,20 @@ export const CodeEditor = ({
}
};
+ useEffect(() => {
+ let isStillMounted = true;
+
+ configureMonacoLoader().then(() => {
+ if (isStillMounted) {
+ setIsMonacoLoaderConfigured(true);
+ }
+ });
+
+ return () => {
+ isStillMounted = false;
+ };
+ }, []);
+
useEffect(() => {
if (!isDefined(monaco)) {
return;
@@ -161,7 +209,7 @@ export const CodeEditor = ({
};
}, [editor, shouldAutoHeight]);
- return isLoading ? (
+ return isLoading || !isMonacoLoaderConfigured ? (
<div
className={styles.editorLoader}
data-variant={variant}