The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
feat(ai): separate chat sharing UI from backend rollout (#26581)
Félix Malfaitf5b41d837c40
diff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql b/packages/twenty-client-sdk/src/metadata/generated/schema.graphqlindex ee3fb0b7dd6..d062c2977fe 100644--- a/packages/twenty-client-sdk/src/metadata/generated/schema.graphql+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.graphql@@ -2061,6 +2061,7 @@ enum FeatureFlagKey {IS_WORKFLOW_CORE_INDEX_PAGE_ENABLEDIS_MESSAGE_CALENDAR_TARGET_READ_ENABLEDIS_RECORD_SHARING_ENABLED+ IS_AI_CHAT_SHARING_DROPDOWN_ENABLEDIS_INITIAL_OBJECT_VIEW_ENABLEDIS_WEBHOOK_RATE_LIMIT_ENABLEDIS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLEDdiff --git a/packages/twenty-client-sdk/src/metadata/generated/schema.ts b/packages/twenty-client-sdk/src/metadata/generated/schema.tsindex 5ef47abe4d5..e0f15b23b7e 100644--- a/packages/twenty-client-sdk/src/metadata/generated/schema.ts+++ b/packages/twenty-client-sdk/src/metadata/generated/schema.ts@@ -1668,7 +1668,7 @@ export interface FeatureFlag {__typename: 'FeatureFlag'}-export type FeatureFlagKey = 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_UNIQUE_INDEXES_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_JUNCTION_RELATIONS_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT' | 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED' | 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED' | 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED' | 'IS_RECORD_SHARING_ENABLED' | 'IS_INITIAL_OBJECT_VIEW_ENABLED' | 'IS_WEBHOOK_RATE_LIMIT_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_EXECUTION_QUOTA_ENABLED' | 'IS_RECORD_CREATION_FORM_ENABLED'+export type FeatureFlagKey = 'IS_ASYNC_CSV_EXPORT_ENABLED' | 'IS_UNIQUE_INDEXES_ENABLED' | 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED' | 'IS_JSON_FILTER_ENABLED' | 'IS_MESSAGE_CAMPAIGN_ENABLED' | 'IS_JUNCTION_RELATIONS_ENABLED' | 'IS_REST_METADATA_API_NEW_FORMAT_DIRECT' | 'IS_LOGIC_FUNCTION_PREBUILT_MODE_ENABLED' | 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED' | 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED' | 'IS_RECORD_SHARING_ENABLED' | 'IS_AI_CHAT_SHARING_DROPDOWN_ENABLED' | 'IS_INITIAL_OBJECT_VIEW_ENABLED' | 'IS_WEBHOOK_RATE_LIMIT_ENABLED' | 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' | 'IS_EXECUTION_QUOTA_ENABLED' | 'IS_RECORD_CREATION_FORM_ENABLED'export interface WorkspaceUrls {customUrl?: Scalars['String']@@ -11194,6 +11194,7 @@ export const enumFeatureFlagKey = {IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED: 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED' as const,IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED: 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED' as const,IS_RECORD_SHARING_ENABLED: 'IS_RECORD_SHARING_ENABLED' as const,+ IS_AI_CHAT_SHARING_DROPDOWN_ENABLED: 'IS_AI_CHAT_SHARING_DROPDOWN_ENABLED' as const,IS_INITIAL_OBJECT_VIEW_ENABLED: 'IS_INITIAL_OBJECT_VIEW_ENABLED' as const,IS_WEBHOOK_RATE_LIMIT_ENABLED: 'IS_WEBHOOK_RATE_LIMIT_ENABLED' as const,IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED: 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED' as const,diff --git a/packages/twenty-front/src/generated-admin/graphql.ts b/packages/twenty-front/src/generated-admin/graphql.tsindex 1c219957158..653a06f4964 100644--- a/packages/twenty-front/src/generated-admin/graphql.ts+++ b/packages/twenty-front/src/generated-admin/graphql.ts@@ -475,6 +475,7 @@ export type FeatureFlag = {};export enum FeatureFlagKey {+ IS_AI_CHAT_SHARING_DROPDOWN_ENABLED = 'IS_AI_CHAT_SHARING_DROPDOWN_ENABLED',IS_ASYNC_CSV_EXPORT_ENABLED = 'IS_ASYNC_CSV_EXPORT_ENABLED',IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED = 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED',IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED = 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED',diff --git a/packages/twenty-front/src/generated-metadata/graphql.ts b/packages/twenty-front/src/generated-metadata/graphql.tsindex c3569992b77..f0bf5d849ad 100644--- a/packages/twenty-front/src/generated-metadata/graphql.ts+++ b/packages/twenty-front/src/generated-metadata/graphql.ts@@ -2107,6 +2107,7 @@ export type FeatureFlag = {};export enum FeatureFlagKey {+ IS_AI_CHAT_SHARING_DROPDOWN_ENABLED = 'IS_AI_CHAT_SHARING_DROPDOWN_ENABLED',IS_ASYNC_CSV_EXPORT_ENABLED = 'IS_ASYNC_CSV_EXPORT_ENABLED',IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED = 'IS_CONFIGURABLE_SEARCH_FIELDS_ENABLED',IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED = 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED',diff --git a/packages/twenty-front/src/modules/ai/components/AiChatSharingDropdown.tsx b/packages/twenty-front/src/modules/ai/components/AiChatSharingDropdown.tsxindex c154d5b024d..0f816476925 100644--- a/packages/twenty-front/src/modules/ai/components/AiChatSharingDropdown.tsx+++ b/packages/twenty-front/src/modules/ai/components/AiChatSharingDropdown.tsx@@ -4,6 +4,8 @@ import { getAppPath } from 'twenty-shared/utils';import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';import { RecordSharingDropdown } from '@/object-record/record-sharing/components/RecordSharingDropdown';+import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';+import { FeatureFlagKey } from '~/generated-metadata/graphql';type AiChatSharingDropdownProps = { threadId: string };@@ -11,9 +13,17 @@ export const AiChatSharingDropdown = ({threadId,}: AiChatSharingDropdownProps) => {const { t } = useLingui();+ const isAiChatSharingDropdownEnabled = useIsFeatureEnabled(+ FeatureFlagKey.IS_AI_CHAT_SHARING_DROPDOWN_ENABLED,+ );const { objectMetadataItem } = useObjectMetadataItem({objectNameSingular: 'agentChatThread',});++ if (!isAiChatSharingDropdownEnabled) {+ return null;+ }+return (<RecordSharingDropdowntarget={{ objectMetadataId: objectMetadataItem.id, recordId: threadId }}diff --git a/packages/twenty-front/src/modules/ai/components/__stories__/AiChatSharingDropdown.stories.tsx b/packages/twenty-front/src/modules/ai/components/__stories__/AiChatSharingDropdown.stories.tsxnew file mode 100644index 00000000000..9b1e20a58ec--- /dev/null+++ b/packages/twenty-front/src/modules/ai/components/__stories__/AiChatSharingDropdown.stories.tsx@@ -0,0 +1,247 @@+import { MockedProvider } from '@apollo/client/testing/react';+import { type Meta, type StoryObj } from '@storybook/react-vite';+import { expect, fn, userEvent, waitFor, within } from 'storybook/test';+import { isDefined } from 'twenty-shared/utils';+import { ComponentDecorator } from 'twenty-ui/testing';++import { AiChatSharingDropdown } from '@/ai/components/AiChatSharingDropdown';+import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';+import { currentWorkspaceMembersState } from '@/auth/states/currentWorkspaceMembersState';+import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';+import { RecordSharingDropdown } from '@/object-record/record-sharing/components/RecordSharingDropdown';+import { jotaiStore } from '@/ui/utilities/state/jotai/jotaiStore';+import {+ FeatureFlagKey,+ GetRecordSharingDocument,+} from '~/generated-metadata/graphql';+import { ToastDecorator } from '~/testing/decorators/ToastDecorator';+import {+ mockCurrentWorkspace,+ mockedWorkspaceMemberData,+} from '~/testing/mock-data/users';+import { getMockObjectMetadataItemOrThrow } from '~/testing/utils/getMockObjectMetadataItemOrThrow';+import { setTestObjectMetadataItemsInMetadataStore } from '~/testing/utils/setTestObjectMetadataItemsInMetadataStore';++const THREAD_METADATA = {+ ...getMockObjectMetadataItemOrThrow('note'),+ nameSingular: 'agentChatThread',+ namePlural: 'agentChatThreads',+};+const THREAD_ID = 'shared-thread';+const NOTE_TARGET = { objectMetadataId: 'note', recordId: 'shared-note' };+const sharingResponse = fn((isEnabled: boolean) => ({+ data: {+ recordSharing: {+ __typename: 'RecordSharingDTO',+ isEnabled,+ hasInheritedAccess: false,+ viewerAccessLevel: 'FULL',+ permissions: {+ __typename: 'RecordPermissionsDTO',+ canRead: true,+ canUpdate: true,+ canDelete: false,+ canSoftDelete: false,+ },+ shares: [+ {+ __typename: 'RecordSharingGrantDTO',+ id: 'owner-grant',+ principalId: mockedWorkspaceMemberData.id,+ principalType: 'WORKSPACE_MEMBER',+ rowCause: 'OWNER',+ accessLevel: 'FULL',+ },+ ],+ roles: [],+ },+ },+}));++const setDropdownFlag = (enabled?: boolean) => {+ jotaiStore.set(currentWorkspaceState.atom, (workspace) => ({+ ...mockCurrentWorkspace,+ ...workspace,+ featureFlags: [+ ...(workspace?.featureFlags ?? []).filter(+ ({ key }) => key !== FeatureFlagKey.IS_AI_CHAT_SHARING_DROPDOWN_ENABLED,+ ),+ ...(isDefined(enabled)+ ? [+ {+ key: FeatureFlagKey.IS_AI_CHAT_SHARING_DROPDOWN_ENABLED,+ value: enabled,+ },+ ]+ : []),+ ],+ }));+};++type SharingStoryProps = {+ isBackendEnabled: boolean;+ isDropdownEnabled?: boolean;+ isChat: boolean;+};++const SharingStory = ({ isBackendEnabled, isChat }: SharingStoryProps) => (+ <MockedProvider+ mocks={[+ {+ request: {+ query: GetRecordSharingDocument,+ variables: {+ target: isChat+ ? { objectMetadataId: THREAD_METADATA.id, recordId: THREAD_ID }+ : NOTE_TARGET,+ },+ },+ maxUsageCount: Infinity,+ delay: 0,+ result: () => sharingResponse(isBackendEnabled),+ },+ ]}+ >+ {isChat ? (+ <AiChatSharingDropdown threadId={THREAD_ID} />+ ) : (+ <RecordSharingDropdown+ target={NOTE_TARGET}+ title="Share note"+ recordUrl="https://example.com/note/shared-note"+ />+ )}+ </MockedProvider>+);++const meta = {+ title: 'Modules/AI/AiChatSharingDropdown',+ component: SharingStory,+ decorators: [ComponentDecorator, ToastDecorator],+ parameters: { container: { width: 600, height: 600 } },+ args: { isBackendEnabled: true, isDropdownEnabled: true, isChat: true },+ beforeEach: ({ args }) => {+ sharingResponse.mockClear();+ setTestObjectMetadataItemsInMetadataStore(jotaiStore, [THREAD_METADATA]);+ jotaiStore.set(currentWorkspaceMemberState.atom, mockedWorkspaceMemberData);+ jotaiStore.set(currentWorkspaceMembersState.atom, [+ mockedWorkspaceMemberData,+ ]);+ jotaiStore.set(currentWorkspaceState.atom, {+ ...mockCurrentWorkspace,+ featureFlags: [+ {+ key: FeatureFlagKey.IS_RECORD_SHARING_ENABLED,+ value: args.isBackendEnabled,+ },+ ],+ });+ setDropdownFlag(args.isDropdownEnabled);+ },+} satisfies Meta<typeof SharingStory>;+export default meta;+type Story = StoryObj<typeof meta>;++export const Enabled: Story = {+ play: async ({ canvasElement }) => {+ const page = within(canvasElement.ownerDocument.body);+ await userEvent.click(await page.findByRole('button', { name: 'Share' }));+ await expect(+ await page.findByRole('menu', { name: 'Share conversation' }),+ ).toBeVisible();+ await expect(+ await page.findByRole('menuitem', { name: 'Restricted' }),+ ).toBeVisible();+ await expect(+ page.getByRole('menuitem', { name: 'You Owner' }),+ ).toBeVisible();+ await expect(+ page.getByRole('menuitem', { name: 'Copy link' }),+ ).toBeVisible();+ await userEvent.keyboard('{Escape}');+ },+};++export const Disabled: Story = {+ args: { isDropdownEnabled: false },+ play: async ({ canvasElement, args }) => {+ const page = within(canvasElement.ownerDocument.body);+ await expect(+ page.queryByRole('button', { name: 'Share' }),+ ).not.toBeInTheDocument();+ setDropdownFlag(true);+ await page.findByRole('button', { name: 'Share' });+ setDropdownFlag(args.isDropdownEnabled);+ await waitFor(() =>+ expect(+ page.queryByRole('button', { name: 'Share' }),+ ).not.toBeInTheDocument(),+ );+ },+};++export const MissingFlag: Story = {+ args: { isDropdownEnabled: undefined },+ play: Disabled.play,+};++export const BackendDisabled: Story = {+ args: { isBackendEnabled: false },+ play: async ({ canvasElement }) => {+ const page = within(canvasElement.ownerDocument.body);+ await waitFor(() => expect(sharingResponse).toHaveBeenCalledWith(false));+ await expect(+ page.queryByRole('button', { name: 'Share' }),+ ).not.toBeInTheDocument();+ },+};++export const OtherObjectsRemainAvailable: Story = {+ args: { isChat: false, isDropdownEnabled: false },+ play: async ({ canvasElement }) => {+ const page = within(canvasElement.ownerDocument.body);+ await userEvent.click(await page.findByRole('button', { name: 'Share' }));+ await expect(+ await page.findByRole('menu', { name: 'Share note' }),+ ).toBeVisible();+ await expect(+ await page.findByRole('menuitem', { name: 'Restricted' }),+ ).toBeVisible();+ await userEvent.keyboard('{Escape}');+ },+};++export const DisableWhileOpen: Story = {+ play: async ({ canvasElement }) => {+ const page = within(canvasElement.ownerDocument.body);+ await userEvent.click(await page.findByRole('button', { name: 'Share' }));+ await expect(+ await page.findByRole('menu', { name: 'Share conversation' }),+ ).toBeVisible();+ setDropdownFlag(false);+ await waitFor(() => {+ expect(+ page.queryByRole('button', { name: 'Share' }),+ ).not.toBeInTheDocument();+ expect(+ page.queryByRole('menu', { name: 'Share conversation' }),+ ).not.toBeInTheDocument();+ });+ setDropdownFlag(true);+ const trigger = await page.findByRole('button', {+ name: 'Share',+ expanded: false,+ });+ await userEvent.click(trigger);+ await expect(+ await page.findByRole('menu', { name: 'Share conversation' }),+ ).toBeVisible();+ await userEvent.keyboard('{Escape}');+ await waitFor(() =>+ expect(+ page.queryByRole('menu', { name: 'Share conversation' }),+ ).not.toBeInTheDocument(),+ );+ await expect(trigger).toHaveFocus();+ },+};diff --git a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.tsindex 3ca4a49b339..aa05a0d67d6 100644--- a/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts+++ b/packages/twenty-front/src/modules/settings/admin-panel/constants/SettingsAdminFeatureFlagMetadata.ts@@ -50,6 +50,10 @@ export const SETTINGS_ADMIN_FEATURE_FLAG_METADATA: Partial<label: msg`Record sharing`,description: msg`Allow sharing individual records with workspace members.`,},+ [FeatureFlagKey.IS_AI_CHAT_SHARING_DROPDOWN_ENABLED]: {+ label: msg`AI chat sharing dropdown`,+ description: msg`Show the sharing dropdown on AI conversations when record sharing is enabled.`,+ },[FeatureFlagKey.IS_WEBHOOK_RATE_LIMIT_ENABLED]: {label: msg`Webhook rate limits`,description: msg`Limit the rate of outgoing webhook deliveries.`,diff --git a/packages/twenty-server/src/engine/core-modules/record-share/services/__tests__/record-sharing-feature.service.spec.ts b/packages/twenty-server/src/engine/core-modules/record-share/services/__tests__/record-sharing-feature.service.spec.tsindex 33f9b1c90ce..f978c55e245 100644--- a/packages/twenty-server/src/engine/core-modules/record-share/services/__tests__/record-sharing-feature.service.spec.ts+++ b/packages/twenty-server/src/engine/core-modules/record-share/services/__tests__/record-sharing-feature.service.spec.ts@@ -16,10 +16,12 @@ const setup = async ({readability = MetadataReadability.SYSTEM,flag = true,entitled = false,+ chatDropdownFlag,}: {readability?: MetadataReadability;flag?: boolean;entitled?: boolean;+ chatDropdownFlag?: boolean;} = {}) => {const provider = new TestEntitlementProvider();provider.hasRecordSharingEntitlement.mockResolvedValue(entitled);@@ -41,7 +43,10 @@ const setup = async ({},},},- featureFlagsMap: { IS_RECORD_SHARING_ENABLED: flag },+ featureFlagsMap: {+ IS_RECORD_SHARING_ENABLED: flag,+ IS_AI_CHAT_SHARING_DROPDOWN_ENABLED: chatDropdownFlag,+ },billingEntitlements: {},}),},@@ -53,6 +58,21 @@ const setup = async ({};describe('record-sharing rollout entitlement compatibility', () => {+ it.each([undefined, false, true])(+ 'keeps backend sharing and activated permissions independent of the chat dropdown flag (%s)',+ async (chatDropdownFlag) => {+ const { module, service } = await setup({+ readability: MetadataReadability.PRIVATE,+ chatDropdownFlag,+ });++ expect(await service.isRecordSharingEnabled('workspace')).toBe(true);+ expect(await service.isLegacyRecordAccessOpen('workspace')).toBe(false);++ await module.close();+ },+ );+it('honors an effective self-hosted entitlement even with an empty billing cache', async () => {const { module, provider, service } = await setup({ entitled: true });expect(await service.isLegacyRecordAccessOpen('workspace')).toBe(false);diff --git a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.tsindex 5f5fc2b867e..867fffab05a 100644--- a/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts+++ b/packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts@@ -9,6 +9,7 @@ const DEFAULT_SEEDED_FEATURE_FLAGS: Partial<Record<FeatureFlagKey, boolean>> = {[FeatureFlagKey.IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED]: true,[FeatureFlagKey.IS_MESSAGE_CAMPAIGN_ENABLED]: true,[FeatureFlagKey.IS_RECORD_SHARING_ENABLED]: true,+ [FeatureFlagKey.IS_AI_CHAT_SHARING_DROPDOWN_ENABLED]: false,[FeatureFlagKey.IS_INITIAL_OBJECT_VIEW_ENABLED]: false,[FeatureFlagKey.IS_EXECUTION_QUOTA_ENABLED]: true,[FeatureFlagKey.IS_RECORD_CREATION_FORM_ENABLED]: true,diff --git a/packages/twenty-shared/src/types/FeatureFlagKey.ts b/packages/twenty-shared/src/types/FeatureFlagKey.tsindex 0dba761b25e..d7e853748d6 100644--- a/packages/twenty-shared/src/types/FeatureFlagKey.ts+++ b/packages/twenty-shared/src/types/FeatureFlagKey.ts@@ -10,6 +10,7 @@ export enum FeatureFlagKey {IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED = 'IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED',IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED = 'IS_MESSAGE_CALENDAR_TARGET_READ_ENABLED',IS_RECORD_SHARING_ENABLED = 'IS_RECORD_SHARING_ENABLED',+ IS_AI_CHAT_SHARING_DROPDOWN_ENABLED = 'IS_AI_CHAT_SHARING_DROPDOWN_ENABLED',IS_INITIAL_OBJECT_VIEW_ENABLED = 'IS_INITIAL_OBJECT_VIEW_ENABLED',IS_WEBHOOK_RATE_LIMIT_ENABLED = 'IS_WEBHOOK_RATE_LIMIT_ENABLED',IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED = 'IS_DEFERRED_WORKSPACE_MIGRATION_ACTIONS_ENABLED',