The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
feat(front): serve the core workflows index on the workflows object route (#24939)
Thomas Trompettef62ff4d3e482
diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/folder/components/NavigationMenuItemFolderSubItem.tsx b/packages/twenty-front/src/modules/navigation-menu-item/display/folder/components/NavigationMenuItemFolderSubItem.tsxindex 8aa33d441bf..9dcd359b0fa 100644--- a/packages/twenty-front/src/modules/navigation-menu-item/display/folder/components/NavigationMenuItemFolderSubItem.tsx+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/folder/components/NavigationMenuItemFolderSubItem.tsx@@ -1,6 +1,7 @@+import { useLingui } from '@lingui/react/macro';import { type ReactNode } from 'react';import { useNavigate } from 'react-router-dom';-import { NavigationMenuItemType } from 'twenty-shared/types';+import { FeatureFlagKey, NavigationMenuItemType } from 'twenty-shared/types';import { isDefined } from 'twenty-shared/utils';import { type NavigationMenuItem } from '~/generated-metadata/graphql';@@ -13,8 +14,10 @@ import { getNavigationMenuItemObjectNameSingular } from '@/navigation-menu-item/import { getObjectMetadataForNavigationMenuItem } from '@/navigation-menu-item/display/object/utils/getObjectMetadataForNavigationMenuItem';import { getObjectNavigationMenuItemSecondaryLabel } from '@/navigation-menu-item/display/object/utils/getObjectNavigationMenuItemSecondaryLabel';import { getNavigationMenuItemComputedLink } from '@/navigation-menu-item/display/utils/getNavigationMenuItemComputedLink';+import { isCoreWorkflowsObjectNavigationMenuItem } from '@/navigation-menu-item/display/utils/isCoreWorkflowsObjectNavigationMenuItem';import { getNavigationMenuItemLabel } from '@/navigation-menu-item/display/utils/getNavigationMenuItemLabel';import { objectMetadataItemsSelector } from '@/object-metadata/states/objectMetadataItemsSelector';+import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';import type { EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';import { NavigationDrawerSubItem } from '@/ui/navigation/navigation-drawer/components/NavigationDrawerSubItem';import { getNavigationSubItemLeftAdornment } from '@/ui/navigation/navigation-drawer/utils/getNavigationSubItemLeftAdornment';@@ -47,8 +50,12 @@ export const NavigationMenuItemFolderSubItem = ({onClick,onNavigationMenuItemClick,}: NavigationMenuItemFolderSubItemProps) => {+ const { t } = useLingui();const isEditHighlightedInNavigationMenu =useIsNavigationMenuItemEditHighlighted(navigationMenuItem);+ const isWorkflowCoreIndexPageEnabled = useIsFeatureEnabled(+ FeatureFlagKey.IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED,+ );const objectMetadataItems = useAtomStateValue(objectMetadataItemsSelector);const views = useAtomStateValue(viewsSelector);const lastVisitedViewPerObjectMetadataItem = useAtomStateValue(@@ -110,16 +117,27 @@ export const NavigationMenuItemFolderSubItem = ({navigate(computedLink);});+ const isCoreWorkflowsIndexItem = isCoreWorkflowsObjectNavigationMenuItem({+ navigationMenuItemType: navigationMenuItem.type,+ objectNameSingular,+ isWorkflowCoreIndexPageEnabled,+ });++ const viewSecondaryLabel =+ navigationMenuItem.type === NavigationMenuItemType.VIEW+ ? getObjectNavigationMenuItemSecondaryLabel({+ objectMetadataItems,+ navigationMenuItemObjectNameSingular: objectNameSingular ?? '',+ })+ : undefined;++ const secondaryLabel = isCoreWorkflowsIndexItem+ ? t`System`+ : viewSecondaryLabel;+return (<NavigationDrawerSubItem- secondaryLabel={- navigationMenuItem.type !== NavigationMenuItemType.VIEW- ? undefined- : getObjectNavigationMenuItemSecondaryLabel({- objectMetadataItems,- navigationMenuItemObjectNameSingular: objectNameSingular ?? '',- })- }+ secondaryLabel={secondaryLabel}label={label}Icon={() => (<NavigationMenuItemIcon navigationMenuItem={navigationMenuItem} />diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/object/components/NavigationDrawerItemForObjectMetadataItem.tsx b/packages/twenty-front/src/modules/navigation-menu-item/display/object/components/NavigationDrawerItemForObjectMetadataItem.tsxindex 751d2d10eb5..0ee025bdf00 100644--- a/packages/twenty-front/src/modules/navigation-menu-item/display/object/components/NavigationDrawerItemForObjectMetadataItem.tsx+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/object/components/NavigationDrawerItemForObjectMetadataItem.tsx@@ -8,12 +8,14 @@ import { recordIdentifierToObjectRecordIdentifier } from '@/navigation-menu-itemimport { useIdentifyActiveNavigationMenuItems } from '@/navigation-menu-item/display/hooks/useIdentifyActiveNavigationMenuItems';import { getNavigationMenuItemComputedLink } from '@/navigation-menu-item/display/utils/getNavigationMenuItemComputedLink';import { getNavigationMenuItemLabel } from '@/navigation-menu-item/display/utils/getNavigationMenuItemLabel';+import { isCoreWorkflowsObjectNavigationMenuItem } from '@/navigation-menu-item/display/utils/isCoreWorkflowsObjectNavigationMenuItem';import { ObjectIconWithViewOverlay } from '@/navigation-menu-item/display/view/components/ObjectIconWithViewOverlay';import { lastVisitedViewPerObjectMetadataItemState } from '@/navigation/states/lastVisitedViewPerObjectMetadataItemState';import { objectMetadataItemsSelector } from '@/object-metadata/states/objectMetadataItemsSelector';import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';import { getObjectColorWithFallback } from '@/object-metadata/utils/getObjectColorWithFallback';import { getObjectPermissionsForObject } from '@/object-metadata/utils/getObjectPermissionsForObject';+import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';import { useObjectPermissions } from '@/object-record/hooks/useObjectPermissions';import { NavigationDrawerItem } from '@/ui/navigation/navigation-drawer/components/NavigationDrawerItem';import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';@@ -23,6 +25,7 @@ import { useNavigate } from 'react-router-dom';import {AppPath,CoreObjectNameSingular,+ FeatureFlagKey,NavigationMenuItemType,} from 'twenty-shared/types';import { getAppPath, isDefined } from 'twenty-shared/utils';@@ -168,11 +171,25 @@ export const NavigationDrawerItemForObjectMetadataItem = ({const iconThemeColor = !isRecord ? objectNavItemColor : undefined;- const secondaryLabel =+ const isWorkflowCoreIndexPageEnabled = useIsFeatureEnabled(+ FeatureFlagKey.IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED,+ );++ const isCoreWorkflowsIndexItem = isCoreWorkflowsObjectNavigationMenuItem({+ navigationMenuItemType: navigationMenuItem?.type,+ objectNameSingular: objectMetadataItem.nameSingular,+ isWorkflowCoreIndexPageEnabled,+ });++ const objectSecondaryLabel =isRecord || isViewWithResolvedView? objectMetadataItem.labelSingular: undefined;+ const secondaryLabel = isCoreWorkflowsIndexItem+ ? t`System`+ : objectSecondaryLabel;+const showInaccessibleLock =isLayoutCustomizationModeEnabled && !canReadObjectRecords;diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/utils/__tests__/isCoreWorkflowsObjectNavigationMenuItem.test.ts b/packages/twenty-front/src/modules/navigation-menu-item/display/utils/__tests__/isCoreWorkflowsObjectNavigationMenuItem.test.tsnew file mode 100644index 00000000000..75dbcdfd4fe--- /dev/null+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/utils/__tests__/isCoreWorkflowsObjectNavigationMenuItem.test.ts@@ -0,0 +1,54 @@+import { NavigationMenuItemType } from 'twenty-shared/types';++import { isCoreWorkflowsObjectNavigationMenuItem } from '@/navigation-menu-item/display/utils/isCoreWorkflowsObjectNavigationMenuItem';++describe('isCoreWorkflowsObjectNavigationMenuItem', () => {+ it('should match an OBJECT item on the workflow object when the flag is on', () => {+ expect(+ isCoreWorkflowsObjectNavigationMenuItem({+ navigationMenuItemType: NavigationMenuItemType.OBJECT,+ objectNameSingular: 'workflow',+ isWorkflowCoreIndexPageEnabled: true,+ }),+ ).toBe(true);+ });++ it('should not match when the flag is off', () => {+ expect(+ isCoreWorkflowsObjectNavigationMenuItem({+ navigationMenuItemType: NavigationMenuItemType.OBJECT,+ objectNameSingular: 'workflow',+ isWorkflowCoreIndexPageEnabled: false,+ }),+ ).toBe(false);+ });++ it('should not match VIEW items on the workflow object', () => {+ expect(+ isCoreWorkflowsObjectNavigationMenuItem({+ navigationMenuItemType: NavigationMenuItemType.VIEW,+ objectNameSingular: 'workflow',+ isWorkflowCoreIndexPageEnabled: true,+ }),+ ).toBe(false);+ });++ it('should not match OBJECT items on other objects', () => {+ expect(+ isCoreWorkflowsObjectNavigationMenuItem({+ navigationMenuItemType: NavigationMenuItemType.OBJECT,+ objectNameSingular: 'company',+ isWorkflowCoreIndexPageEnabled: true,+ }),+ ).toBe(false);+ });++ it('should not match when the item type is unknown', () => {+ expect(+ isCoreWorkflowsObjectNavigationMenuItem({+ objectNameSingular: 'workflow',+ isWorkflowCoreIndexPageEnabled: true,+ }),+ ).toBe(false);+ });+});diff --git a/packages/twenty-front/src/modules/navigation-menu-item/display/utils/isCoreWorkflowsObjectNavigationMenuItem.ts b/packages/twenty-front/src/modules/navigation-menu-item/display/utils/isCoreWorkflowsObjectNavigationMenuItem.tsnew file mode 100644index 00000000000..2f931bff7ed--- /dev/null+++ b/packages/twenty-front/src/modules/navigation-menu-item/display/utils/isCoreWorkflowsObjectNavigationMenuItem.ts@@ -0,0 +1,18 @@+import { NavigationMenuItemType } from 'twenty-shared/types';++import { isCoreWorkflowsIndexEnabled } from '@/object-core/workflows/utils/isCoreWorkflowsIndexEnabled';++export const isCoreWorkflowsObjectNavigationMenuItem = ({+ navigationMenuItemType,+ objectNameSingular,+ isWorkflowCoreIndexPageEnabled,+}: {+ navigationMenuItemType?: NavigationMenuItemType;+ objectNameSingular?: string | null;+ isWorkflowCoreIndexPageEnabled: boolean;+}) =>+ navigationMenuItemType === NavigationMenuItemType.OBJECT &&+ isCoreWorkflowsIndexEnabled({+ objectNameSingular,+ isWorkflowCoreIndexPageEnabled,+ });diff --git a/packages/twenty-front/src/modules/object-core/workflows/utils/isCoreWorkflowsIndexEnabled.ts b/packages/twenty-front/src/modules/object-core/workflows/utils/isCoreWorkflowsIndexEnabled.tsnew file mode 100644index 00000000000..0afe4069269--- /dev/null+++ b/packages/twenty-front/src/modules/object-core/workflows/utils/isCoreWorkflowsIndexEnabled.ts@@ -0,0 +1,11 @@+import { CoreObjectNameSingular } from 'twenty-shared/types';++export const isCoreWorkflowsIndexEnabled = ({+ objectNameSingular,+ isWorkflowCoreIndexPageEnabled,+}: {+ objectNameSingular?: string | null;+ isWorkflowCoreIndexPageEnabled: boolean;+}) =>+ isWorkflowCoreIndexPageEnabled &&+ objectNameSingular === CoreObjectNameSingular.Workflow;diff --git a/packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx b/packages/twenty-front/src/pages/object-record/RecordIndexPage.tsxindex 48e93966ccb..c481153d04d 100644--- a/packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx+++ b/packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx@@ -3,10 +3,20 @@ import { contextStoreCurrentObjectMetadataItemIdComponentState } from '@/contextimport { ContextStoreComponentInstanceContext } from '@/context-store/states/contexts/ContextStoreComponentInstanceContext';import { useObjectMetadataItems } from '@/object-metadata/hooks/useObjectMetadataItems';import { RecordIndexContainerGater } from '@/object-record/record-index/components/RecordIndexContainerGater';+import { isCoreWorkflowsIndexEnabled } from '@/object-core/workflows/utils/isCoreWorkflowsIndexEnabled';import { RecordIndexSkeletonLoader } from '@/object-record/record-index/components/RecordIndexSkeletonLoader';import { PageContainer } from '@/ui/layout/page/components/PageContainer';import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';+import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';import { isUndefined } from '@sniptt/guards';+import { lazy, Suspense } from 'react';+import { FeatureFlagKey } from 'twenty-shared/types';++const WorkflowCoreIndexPage = lazy(() =>+ import('~/pages/object-core/WorkflowCoreIndexPage').then((module) => ({+ default: module.WorkflowCoreIndexPage,+ })),+);export const RecordIndexPage = () => {const contextStoreCurrentObjectMetadataItemId = useAtomComponentStateValue(@@ -16,6 +26,10 @@ export const RecordIndexPage = () => {const { objectMetadataItems } = useObjectMetadataItems();+ const isWorkflowCoreIndexPageEnabled = useIsFeatureEnabled(+ FeatureFlagKey.IS_WORKFLOW_CORE_INDEX_PAGE_ENABLED,+ );+if (isUndefined(contextStoreCurrentObjectMetadataItemId)) {return <RecordIndexSkeletonLoader />;}@@ -29,6 +43,19 @@ export const RecordIndexPage = () => {return <RecordIndexSkeletonLoader />;}+ if (+ isCoreWorkflowsIndexEnabled({+ objectNameSingular: objectMetadataItem.nameSingular,+ isWorkflowCoreIndexPageEnabled,+ })+ ) {+ return (+ <Suspense fallback={<RecordIndexSkeletonLoader />}>+ <WorkflowCoreIndexPage />+ </Suspense>+ );+ }+return (<PageContainer><ContextStoreComponentInstanceContext.Provider