The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
fix(workflow): create a record when a relation variable resolves to null (#25000)
Thomas Trompettefa11fa057996
diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/format-workflow-record-relation-fields.util.spec.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/format-workflow-record-relation-fields.util.spec.tsnew file mode 100644index 00000000000..adaec9c0f37--- /dev/null+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/format-workflow-record-relation-fields.util.spec.ts@@ -0,0 +1,109 @@+import { FieldMetadataType, RelationType } from 'twenty-shared/types';++import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';+import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';+import { type ObjectMetadataInfo } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';+import { formatWorkflowRecordRelationFields } from 'src/modules/workflow/workflow-executor/utils/format-workflow-record-relation-fields.util';++const ASSIGNEE_ID = 'e1c3f8a0-0000-4000-8000-000000000000';++const assigneeFlatFieldMetadata = {+ id: 'assignee-field-metadata-id',+ universalIdentifier: 'assignee-field-universal-identifier',+ name: 'assignee',+ type: FieldMetadataType.RELATION,+ settings: { relationType: RelationType.MANY_TO_ONE },+ relationTargetObjectMetadataId: 'workspace-member-object-metadata-id',+} satisfies Partial<FlatFieldMetadata<FieldMetadataType.RELATION>>;++const titleFlatFieldMetadata = {+ id: 'title-field-metadata-id',+ universalIdentifier: 'title-field-universal-identifier',+ name: 'title',+ type: FieldMetadataType.TEXT,+} satisfies Partial<FlatFieldMetadata<FieldMetadataType.TEXT>>;++const taskFlatObjectMetadata = {+ id: 'task-object-metadata-id',+ universalIdentifier: 'task-object-universal-identifier',+ nameSingular: 'task',+ namePlural: 'tasks',+ fieldIds: [assigneeFlatFieldMetadata.id, titleFlatFieldMetadata.id],+} satisfies Partial<FlatObjectMetadata>;++const buildFlatEntityMaps = (+ flatEntities: { id: string; universalIdentifier: string }[],+) => ({+ byUniversalIdentifier: Object.fromEntries(+ flatEntities.map((flatEntity) => [+ flatEntity.universalIdentifier,+ flatEntity,+ ]),+ ),+ universalIdentifierById: Object.fromEntries(+ flatEntities.map((flatEntity) => [+ flatEntity.id,+ flatEntity.universalIdentifier,+ ]),+ ),+ universalIdentifiersByApplicationId: {},+});++const objectMetadataInfo = {+ flatObjectMetadata: taskFlatObjectMetadata,+ flatFieldMetadataMaps: buildFlatEntityMaps([+ assigneeFlatFieldMetadata,+ titleFlatFieldMetadata,+ ]),+ flatObjectMetadataMaps: buildFlatEntityMaps([taskFlatObjectMetadata]),+} as unknown as ObjectMetadataInfo;++const format = (record: Record<string, unknown>) =>+ formatWorkflowRecordRelationFields(record, objectMetadataInfo)+ .formattedRecord;++describe('formatWorkflowRecordRelationFields', () => {+ it('maps a relation wrapped as an id object to its join column', () => {+ expect(format({ assignee: { id: ASSIGNEE_ID } })).toEqual({+ assigneeId: ASSIGNEE_ID,+ });+ });++ it.each([[null], [{ id: null }], [{ id: null, name: 'Unassigned' }]])(+ 'nullifies the join column when the relation resolves to %p',+ (value) => {+ expect(format({ title: 'Follow up', assignee: value })).toEqual({+ title: 'Follow up',+ assigneeId: null,+ });+ },+ );++ it('keeps an explicitly provided join column over a null relation', () => {+ expect(format({ assignee: { id: null }, assigneeId: ASSIGNEE_ID })).toEqual(+ {+ assigneeId: ASSIGNEE_ID,+ },+ );+ });++ it('writes no join column when the relation id is undefined', () => {+ expect(Object.keys(format({ assignee: { id: undefined } }))).toEqual([+ 'assignee',+ ]);+ });++ it('keeps an empty id so it is rejected downstream', () => {+ expect(format({ assignee: { id: '' } })).toEqual({ assigneeId: '' });+ });++ it('leaves nested relation operations untouched', () => {+ const record = { assignee: { connect: { where: { id: ASSIGNEE_ID } } } };++ expect(format(record)).toEqual(record);+ });++ it('leaves non-relation fields untouched', () => {+ expect(format({ title: null })).toEqual({ title: null });+ });+});diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/format-workflow-record-relation-fields.util.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/format-workflow-record-relation-fields.util.tsindex aa9b186f0ef..2d597f1e0d2 100644--- a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/format-workflow-record-relation-fields.util.ts+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/format-workflow-record-relation-fields.util.ts@@ -1,4 +1,4 @@-import { isObject, isString } from '@sniptt/guards';+import { isObject, isString, isUndefined } from '@sniptt/guards';import { FieldMetadataType, RelationType } from 'twenty-shared/types';import { isDefined } from 'twenty-shared/utils';@@ -8,6 +8,7 @@ import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/import { isFlatFieldMetadataOfType } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-flat-field-metadata-of-type.util';import { getMorphNameFromMorphFieldMetadataName } from 'src/engine/metadata-modules/flat-object-metadata/utils/get-morph-name-from-morph-field-metadata-name.util';import { type ObjectMetadataInfo } from 'src/modules/workflow/common/workspace-services/workflow-common.workspace-service';+import { isNullRelationValue } from 'src/modules/workflow/workflow-executor/utils/is-null-relation-value.util';type MorphRelationTargetJoinColumn = {joinColumnName: string;@@ -191,9 +192,11 @@ const formatWorkflowRecordSimpleRelationFields = (continue;}- const legacyId = extractLegacyRelationId(value);+ const joinColumnValue = isNullRelationValue(value)+ ? null+ : extractLegacyRelationId(value);- if (!isDefined(legacyId)) {+ if (isUndefined(joinColumnValue)) {formattedRecord[key] = value;continue;}@@ -203,7 +206,7 @@ const formatWorkflowRecordSimpleRelationFields = (});if (!isDefined(record[joinColumnName])) {- formattedRecord[joinColumnName] = legacyId;+ formattedRecord[joinColumnName] = joinColumnValue;}}diff --git a/packages/twenty-server/src/modules/workflow/workflow-executor/utils/is-null-relation-value.util.ts b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/is-null-relation-value.util.tsnew file mode 100644index 00000000000..356de0faae2--- /dev/null+++ b/packages/twenty-server/src/modules/workflow/workflow-executor/utils/is-null-relation-value.util.ts@@ -0,0 +1,5 @@+import { isObject } from '@sniptt/guards';++export const isNullRelationValue = (value: unknown): boolean =>+ value === null ||+ (isObject(value) && (value as Record<string, unknown>).id === null);