The open alternative to Salesforce, designed for AI.
TypeScript crmcrm-systemcustomergood-first-issuegraphqlhacktoberfestjavascriptmarketingmonoreponestjsopen-sourcepostgresqlreactreactjssalestypescriptweb
Give the mobile record header a proper title treatment (#24251)
Félix Malfaitfdeef833c82b
diff --git a/packages/twenty-front/src/modules/command-menu-item/display/components/PinnedCommandMenuItemButtons.tsx b/packages/twenty-front/src/modules/command-menu-item/display/components/PinnedCommandMenuItemButtons.tsxindex e8938267723..b48a0f227eb 100644--- a/packages/twenty-front/src/modules/command-menu-item/display/components/PinnedCommandMenuItemButtons.tsx+++ b/packages/twenty-front/src/modules/command-menu-item/display/components/PinnedCommandMenuItemButtons.tsx@@ -63,14 +63,9 @@ export const PinnedCommandMenuItemButtons = ({const isSidePanelFooter =containerType === CommandMenuItemContainerType.SidePanelFooter;- // A record header keeps its breadcrumb on mobile, so its actions stay icons- // and leave the record name room. Index and standalone headers drop their- // title there, which frees the width for one label.- const isRecordPageHeader =- containerType === CommandMenuItemContainerType.ShowPageHeader;-- const shouldLabelSingleCommandMenuItem =- isSidePanelFooter || (isMobile && !isRecordPageHeader);+ // Every header keeps its title on mobile, so its actions stay icon-only and+ // leave the title room. The side panel footer has a full row to itself.+ const shouldLabelSingleCommandMenuItem = isSidePanelFooter;const pinnedCommandMenuItems = useMemo(() => commandMenuItems.filter((item) => item.isPinned === true),@@ -82,7 +77,7 @@ export const PinnedCommandMenuItemButtons = ({: null;const shouldHideCommandMenuItemLabel = (commandMenuItemId: string) =>- (isMobile && isRecordPageHeader) ||+ (isMobile && !isSidePanelFooter) ||(shouldLabelSingleCommandMenuItem &&commandMenuItemId !== labelledCommandMenuItemId);diff --git a/packages/twenty-front/src/modules/object-record/record-show/components/ObjectRecordShowPageBreadcrumb.tsx b/packages/twenty-front/src/modules/object-record/record-show/components/ObjectRecordShowPageBreadcrumb.tsxindex 409a0f387d8..f9907647244 100644--- a/packages/twenty-front/src/modules/object-record/record-show/components/ObjectRecordShowPageBreadcrumb.tsx+++ b/packages/twenty-front/src/modules/object-record/record-show/components/ObjectRecordShowPageBreadcrumb.tsx@@ -1,3 +1,4 @@+import { allowRequestsToTwentyIconsState } from '@/client-config/states/allowRequestsToTwentyIcons';import { useNumberFormat } from '@/localization/hooks/useNumberFormat';import { ObjectMetadataIcon } from '@/object-metadata/components/ObjectMetadataIcon';import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';@@ -9,13 +10,19 @@ import { useRecordShowContainerActions } from '@/object-record/record-show/hooksimport { useRecordShowPageGroupByBreadcrumbInfo } from '@/object-record/record-show/hooks/useRecordShowPageGroupByBreadcrumbInfo';import { useRecordShowPagePagination } from '@/object-record/record-show/hooks/useRecordShowPagePagination';import { getRecordShowPageBreadcrumbPaginationLabel } from '@/object-record/record-show/utils/getRecordShowPageBreadcrumbPaginationLabel';+import { recordStoreIdentifierFamilySelector } from '@/object-record/record-store/states/selectors/recordStoreIdentifierFamilySelector';import { RecordTitleCell } from '@/object-record/record-title-cell/components/RecordTitleCell';import { RecordTitleCellContainerType } from '@/object-record/record-title-cell/types/RecordTitleCellContainerType';import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';+import { useAtomFamilySelectorValue } from '@/ui/utilities/state/jotai/hooks/useAtomFamilySelectorValue';+import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';import { styled } from '@linaria/react';import { useState } from 'react';import { FieldMetadataType } from 'twenty-shared/types';+import { isDefined } from 'twenty-shared/utils';+import { Avatar } from 'twenty-ui/data-display';import { themeCssVariables } from 'twenty-ui/theme-constants';+import { getAbsoluteImageUrl } from '~/utils/image/getAbsoluteImageUrl';const StyledEditableTitleContainer = styled.div`align-items: center;@@ -40,12 +47,27 @@ const StyledBreadcrumbPrefixObjectIcon = styled.div`opacity: 0.64;`;-const StyledTitle = styled.div`+const StyledTitle = styled.div<{ isEmphasized: boolean }>`+ font-size: ${({ isEmphasized }) =>+ isEmphasized ? themeCssVariables.font.size.md : 'inherit'};+ font-weight: ${({ isEmphasized }) =>+ isEmphasized ? themeCssVariables.font.weight.semiBold : 'inherit'};max-width: 100%;overflow: hidden;width: fit-content;`;+const StyledAvatarContainer = styled.div`+ align-items: center;+ background: ${themeCssVariables.background.transparent.light};+ border-radius: ${themeCssVariables.border.radius.sm};+ display: flex;+ flex-shrink: 0;+ justify-content: center;+ margin-right: ${themeCssVariables.spacing[0.5]};+ padding: ${themeCssVariables.spacing[1]};+`;+const StyledPaginationInformation = styled.span`color: ${themeCssVariables.font.color.tertiary};`;@@ -77,6 +99,18 @@ export const ObjectRecordShowPageBreadcrumb = ({objectNameSingular,});+ const allowRequestsToTwentyIcons = useAtomStateValue(+ allowRequestsToTwentyIconsState,+ );++ const recordIdentifier = useAtomFamilySelectorValue(+ recordStoreIdentifierFamilySelector,+ {+ recordId: objectRecordId,+ allowRequestsToTwentyIcons,+ },+ );+const { useUpdateOneObjectRecordMutation } = useRecordShowContainerActions({objectNameSingular,});@@ -117,7 +151,19 @@ export const ObjectRecordShowPageBreadcrumb = ({return (<StyledEditableTitleContainer data-testid="top-bar-title">- {!isMobile && (+ {isMobile ? (+ isDefined(recordIdentifier) && (+ <StyledAvatarContainer>+ <Avatar+ avatarUrl={getAbsoluteImageUrl(recordIdentifier.avatarUrl)}+ placeholder={recordIdentifier.name}+ placeholderColorSeed={objectRecordId}+ size="md"+ type={recordIdentifier.avatarType}+ />+ </StyledAvatarContainer>+ )+ ) : (<StyledEditableTitlePrefixonClick={() => {navigateToIndexView();@@ -130,7 +176,7 @@ export const ObjectRecordShowPageBreadcrumb = ({<span>{' / '}</span></StyledEditableTitlePrefix>)}- <StyledTitle>+ <StyledTitle isEmphasized={isMobile}><FieldContext.Providervalue={{recordId: objectRecordId,@@ -155,7 +201,7 @@ export const ObjectRecordShowPageBreadcrumb = ({}}><RecordTitleCell- sizeVariant="xs"+ sizeVariant={isMobile ? 'sm' : 'xs'}containerType={RecordTitleCellContainerType.PageHeader}/></FieldContext.Provider>diff --git a/packages/twenty-front/src/modules/side-panel/components/SidePanelToggleButton.tsx b/packages/twenty-front/src/modules/side-panel/components/SidePanelToggleButton.tsxindex ea80d512923..29bec9384f5 100644--- a/packages/twenty-front/src/modules/side-panel/components/SidePanelToggleButton.tsx+++ b/packages/twenty-front/src/modules/side-panel/components/SidePanelToggleButton.tsx@@ -79,7 +79,7 @@ export const SidePanelToggleButton = () => {<IconButtonIcon={IconDotsVertical}dataTestId="page-header-side-panel-button"- size={isMobile ? 'medium' : 'small'}+ size="small"variant="primary"accent="default"ariaLabel={ariaLabel}diff --git a/packages/twenty-front/src/modules/ui/layout/page/components/PageCardHeader.tsx b/packages/twenty-front/src/modules/ui/layout/page/components/PageCardHeader.tsxindex faace30806d..628e2760037 100644--- a/packages/twenty-front/src/modules/ui/layout/page/components/PageCardHeader.tsx+++ b/packages/twenty-front/src/modules/ui/layout/page/components/PageCardHeader.tsx@@ -92,10 +92,7 @@ export const PageCardHeader = ({const isMobile = useIsMobile();const isNavigationDrawerExpanded = useNavigationDrawerExpanded();- // Uncentered headers drop the title on mobile to fit a labelled action.- const hasTitleContent =- (!isMobile || centerTitle) &&- (isDefined(icon) || isDefined(title) || isDefined(tag));+ const hasTitleContent = isDefined(icon) || isDefined(title) || isDefined(tag);const shouldCenterTitle = centerTitle && hasTitleContent;const titleContent = (