Skip to content

Connect, collaborate, and grow with a community of TypeScript developers

fix(TrackChallenge): Warning caused by conditional rendering of mock … (#629)

Aakash38f0faf0a56f
diff --git a/apps/web/src/app/[locale]/tracks/_components/track-challenge-card.tsx b/apps/web/src/app/[locale]/tracks/_components/track-challenge-card.tsx
index bacd0bd4..e991f421 100644
--- a/apps/web/src/app/[locale]/tracks/_components/track-challenge-card.tsx
+++ b/apps/web/src/app/[locale]/tracks/_components/track-challenge-card.tsx
@@ -11,6 +11,11 @@ interface TrackChallengeProps {
mock?: boolean;
}
+interface MockComponentProps {
+ challenge: TrackChallengeProps['challenge'];
+ mock?: TrackChallengeProps['mock'];
+}
+
const COLORS_BY_DIFFICULTY = {
BEGINNER: 'text-difficulty-beginner dark:text-difficulty-beginner-dark',
EASY: 'text-difficulty-easy dark:text-difficulty-easy-dark',
@@ -27,8 +32,22 @@ const BGS_BY_DIFFICULTY = {
EXTREME: 'to-difficulty-extreme/20 dark:to-difficulty-extreme-dark/20',
} as const;
-export function TrackChallenge({ challenge, className, mock }: TrackChallengeProps) {
+const MockComponent = ({ challenge, mock }: MockComponentProps) => {
+ if (!mock) {
+ return null;
+ }
+ return (
+ <>
+ <input className="peer hidden appearance-none" type="checkbox" id={challenge.id.toString()} />
+ <div className="h-5 w-5 rounded-full border border-black/70 bg-black/10 duration-75 peer-checked:border-transparent peer-checked:bg-green-600/80 dark:border-white/50 dark:bg-white/10 peer-checked:dark:bg-green-300/80" />
+ <Check className="absolute left-1 my-auto h-3 w-3 scale-0 stroke-[4] text-white duration-300 peer-checked:scale-100 dark:text-black" />
+ </>
+ );
+};
+
+export function TrackChallenge({ challenge, className }: TrackChallengeProps) {
const isMobile = useIsMobile();
+
return (
<label
htmlFor={challenge.id.toString()}
@@ -47,17 +66,7 @@ export function TrackChallenge({ challenge, className, mock }: TrackChallengePro
)}
>
<div className="relative flex items-center gap-3 text-xs sm:text-base">
- {mock == true && (
- <>
- <input
- className="peer hidden appearance-none"
- type="checkbox"
- id={challenge.id.toString()}
- />
- <div className="h-5 w-5 rounded-full border border-black/70 bg-black/10 duration-75 peer-checked:border-transparent peer-checked:bg-green-600/80 dark:border-white/50 dark:bg-white/10 peer-checked:dark:bg-green-300/80" />
- <Check className="absolute left-1 my-auto h-3 w-3 scale-0 stroke-[4] text-white duration-300 peer-checked:scale-100 dark:text-black" />
- </>
- )}
+ <MockComponent challenge={challenge} mock />
{challenge.name}
</div>
<div