Skip to content

Connect, collaborate, and grow with a community of TypeScript developers

fix: preliminary accessibility issues in editor (#1687)

Josh Goldberg ✨6385a8f4064c
diff --git a/apps/aot/src/app/events/[year]/[day]/_components/description/index.tsx b/apps/aot/src/app/events/[year]/[day]/_components/description/index.tsx
index 70bfc8eb..9400987d 100644
--- a/apps/aot/src/app/events/[year]/[day]/_components/description/index.tsx
+++ b/apps/aot/src/app/events/[year]/[day]/_components/description/index.tsx
@@ -89,7 +89,7 @@ export function Description({ challenge }: Props) {
'rounded-full',
)}
>
- <Share className="h-4 w-4" />
+ <Share aria-label="Share" className="h-4 w-4" />
</div>
</TooltipTrigger>
<TooltipContent>
@@ -135,7 +135,7 @@ export function Description({ challenge }: Props) {
);
}}
>
- <BookmarkIcon className="h-4 w-4" />
+ <BookmarkIcon aria-label="Bookmark" className="h-4 w-4" />
</Button>
</TooltipTrigger>
<TooltipContent>
diff --git a/apps/aot/src/app/events/[year]/[day]/_components/editor-shortcuts/editor-shortcuts-button.tsx b/apps/aot/src/app/events/[year]/[day]/_components/editor-shortcuts/editor-shortcuts-button.tsx
index 5fe1f835..c64edcd1 100644
--- a/apps/aot/src/app/events/[year]/[day]/_components/editor-shortcuts/editor-shortcuts-button.tsx
+++ b/apps/aot/src/app/events/[year]/[day]/_components/editor-shortcuts/editor-shortcuts-button.tsx
@@ -15,7 +15,11 @@ export function EditorShortcutsButton() {
<DialogTrigger>
<Tooltip>
<TooltipTrigger asChild>
- <SquareSlash className="stroke-zinc-500 stroke-1 hover:stroke-zinc-400" size={20} />
+ <SquareSlash
+ aria-label="Shortcuts"
+ className="stroke-zinc-500 stroke-1 hover:stroke-zinc-400"
+ size={20}
+ />
</TooltipTrigger>
<TooltipContent className="px-2 py-1">Shortcuts</TooltipContent>
</Tooltip>
diff --git a/apps/aot/src/app/events/[year]/[day]/_components/reset-editor-button.tsx b/apps/aot/src/app/events/[year]/[day]/_components/reset-editor-button.tsx
index 0f5d56e6..1db91122 100644
--- a/apps/aot/src/app/events/[year]/[day]/_components/reset-editor-button.tsx
+++ b/apps/aot/src/app/events/[year]/[day]/_components/reset-editor-button.tsx
@@ -16,7 +16,7 @@ const ResetEditorButton = () => {
const { dispatch } = useResetEditor();
return (
<AlertDialog>
- <AlertDialogTrigger name="reset">
+ <AlertDialogTrigger aria-label="Reset" name="reset">
<Tooltip>
<TooltipTrigger asChild>
<RotateCcw className="stroke-zinc-500 stroke-1 hover:stroke-zinc-400" size={20} />
diff --git a/apps/aot/src/app/events/[year]/[day]/_components/settings/settings-button.tsx b/apps/aot/src/app/events/[year]/[day]/_components/settings/settings-button.tsx
index 1396d2c1..f0965c73 100644
--- a/apps/aot/src/app/events/[year]/[day]/_components/settings/settings-button.tsx
+++ b/apps/aot/src/app/events/[year]/[day]/_components/settings/settings-button.tsx
@@ -15,7 +15,11 @@ export function SettingsButton() {
<DialogTrigger>
<Tooltip>
<TooltipTrigger asChild>
- <Settings className="stroke-zinc-500 stroke-1 hover:stroke-zinc-400" size={20} />
+ <Settings
+ aria-label="Settings"
+ className="stroke-zinc-500 stroke-1 hover:stroke-zinc-400"
+ size={20}
+ />
</TooltipTrigger>
<TooltipContent className="px-2 py-1">Settings</TooltipContent>
</Tooltip>
diff --git a/apps/aot/src/app/events/[year]/[day]/fullscreen-button.tsx b/apps/aot/src/app/events/[year]/[day]/fullscreen-button.tsx
index 8c11311c..684495d5 100644
--- a/apps/aot/src/app/events/[year]/[day]/fullscreen-button.tsx
+++ b/apps/aot/src/app/events/[year]/[day]/fullscreen-button.tsx
@@ -49,9 +49,17 @@ export function FullscreenButton() {
onClick={handleToggleFullscreen}
>
{fssettings.isFullscreen ? (
- <Minimize2 className="stroke-zinc-500 stroke-1 hover:stroke-zinc-400" size={20} />
+ <Minimize2
+ aria-label="Minimize"
+ className="stroke-zinc-500 stroke-1 hover:stroke-zinc-400"
+ size={20}
+ />
) : (
- <Maximize2 className="stroke-zinc-500 stroke-1 hover:stroke-zinc-400" size={20} />
+ <Maximize2
+ aria-label="Maximize"
+ className="stroke-zinc-500 stroke-1 hover:stroke-zinc-400"
+ size={20}
+ />
)}
</button>
</TooltipTrigger>
diff --git a/apps/aot/src/app/globals.css b/apps/aot/src/app/globals.css
index be1d4ed6..88ae9fea 100644
--- a/apps/aot/src/app/globals.css
+++ b/apps/aot/src/app/globals.css
@@ -22,7 +22,7 @@
--border: 240 5.9% 90%;
--input: 240 5.9% 90%;
- --primary: 211 61% 48%;
+ --primary: 211 61% 47%;
--primary-foreground: 0 0% 98%;
--secondary: 240 4.8% 95.9%;
@@ -70,7 +70,7 @@
--border: 240 3.7% 15.9%;
--input: 240 3.7% 15.9%;
- --primary: 211 61% 48%;
+ --primary: 211 61% 47%;
--primary-foreground: 0 0% 98%;
--secondary: 240 3.7% 15.9%;
diff --git a/apps/web/src/styles/globals.css b/apps/web/src/styles/globals.css
index 7fb7ed7e..a688bbab 100644
--- a/apps/web/src/styles/globals.css
+++ b/apps/web/src/styles/globals.css
@@ -22,7 +22,7 @@
--border: 240 5.9% 90%;
--input: 240 5.9% 90%;
- --primary: 211 61% 48%;
+ --primary: 211 61% 47%;
--primary-foreground: 0 0% 98%;
--secondary: 240 4.8% 95.9%;
@@ -76,7 +76,7 @@
--border: 240 3.7% 15.9%;
--input: 240 3.7% 15.9%;
- --primary: 211 61% 48%;
+ --primary: 211 61% 47%;
--primary-foreground: 0 0% 98%;
--secondary: 240 3.7% 15.9%;