Skip to content

Connect, collaborate, and grow with a community of TypeScript developers

get-rid of icons imported from lucide-react & re-export icons from @repo/ui/icons instead (#591)

Subham Bhattacharya67084661086d
diff --git a/apps/web/package.json b/apps/web/package.json
index a833e95b..b7cd26c7 100644
--- a/apps/web/package.json
+++ b/apps/web/package.json
@@ -43,7 +43,6 @@
"date-fns": "^2.30.0",
"framer-motion": "^10.12.22",
"lodash": "^4.17.21",
- "lucide-react": "^0.260.0",
"lz-string": "^1.5.0",
"monaco-vim": "^0.4.0",
"next": "^13.4.19",
diff --git a/apps/web/src/app/_components/feature-card.tsx b/apps/web/src/app/_components/feature-card.tsx
index aea68eba..3c7dc8c5 100644
--- a/apps/web/src/app/_components/feature-card.tsx
+++ b/apps/web/src/app/_components/feature-card.tsx
@@ -10,7 +10,7 @@ import {
type MotionStyle,
type MotionValue,
} from 'framer-motion';
-import { Reply } from 'lucide-react';
+import { Reply } from '@repo/ui/icons';
import { useTheme } from 'next-themes';
import Image, { type StaticImageData } from 'next/image';
import { useEffect, useState, type MouseEvent } from 'react';
diff --git a/apps/web/src/app/_components/hero.tsx b/apps/web/src/app/_components/hero.tsx
index 81dcd640..c799bcc1 100644
--- a/apps/web/src/app/_components/hero.tsx
+++ b/apps/web/src/app/_components/hero.tsx
@@ -1,9 +1,8 @@
-import { Github, Mail } from '@repo/ui/icons';
+import { Github, Mail, Twitter } from '@repo/ui/icons';
import Link from 'next/link';
import { Balancer } from 'react-wrap-balancer';
import { Button } from '@repo/ui';
import { HeroIllustration } from './hero-illustration';
-import { Twitter } from 'lucide-react';
function TypeHeroLogo() {
return (
diff --git a/apps/web/src/app/challenge/_components/comments/index.tsx b/apps/web/src/app/challenge/_components/comments/index.tsx
index c984a4a0..da4eab9b 100644
--- a/apps/web/src/app/challenge/_components/comments/index.tsx
+++ b/apps/web/src/app/challenge/_components/comments/index.tsx
@@ -11,10 +11,16 @@ import {
Toggle,
toast,
} from '@repo/ui';
-import { ChevronDown, ChevronLeft, ChevronRight, MessageCircle } from '@repo/ui/icons';
+import {
+ ChevronDown,
+ ChevronLeft,
+ ChevronRight,
+ MessageCircle,
+ ArrowDownNarrowWide,
+ ArrowUpNarrowWide,
+} from '@repo/ui/icons';
import { useQuery, useQueryClient } from '@tanstack/react-query';
import clsx from 'clsx';
-import { ArrowDownNarrowWide, ArrowUpNarrowWide } from 'lucide-react';
import { useRef, useState } from 'react';
import { Comment } from './comment';
import { CommentInput } from './comment-input';
diff --git a/apps/web/src/app/challenge/_components/fullscreen.tsx b/apps/web/src/app/challenge/_components/fullscreen.tsx
index c7cafe38..f665845c 100644
--- a/apps/web/src/app/challenge/_components/fullscreen.tsx
+++ b/apps/web/src/app/challenge/_components/fullscreen.tsx
@@ -1,6 +1,5 @@
import { Tooltip, TooltipContent, TooltipTrigger } from '@repo/ui';
-import { Maximize2 } from '@repo/ui/icons';
-import { Minimize2 } from 'lucide-react';
+import { Maximize2, Minimize2 } from '@repo/ui/icons';
import { useEffect } from 'react';
import { create } from 'zustand';
diff --git a/apps/web/src/app/explore/_components/view-more-button.tsx b/apps/web/src/app/explore/_components/view-more-button.tsx
index 14c9dc68..57335e6d 100644
--- a/apps/web/src/app/explore/_components/view-more-button.tsx
+++ b/apps/web/src/app/explore/_components/view-more-button.tsx
@@ -1,7 +1,7 @@
'use client';
import { Button } from '@repo/ui';
-import { ChevronRight } from 'lucide-react';
+import { ChevronRight } from '@repo/ui/icons';
import { useRouter } from 'next/navigation';
export const BUTTON_BY_TAGS = {
diff --git a/apps/web/src/components/user/dashboard/index.tsx b/apps/web/src/components/user/dashboard/index.tsx
index a2731a6d..57242c2d 100644
--- a/apps/web/src/components/user/dashboard/index.tsx
+++ b/apps/web/src/components/user/dashboard/index.tsx
@@ -12,7 +12,7 @@ import {
VerticalTabsList,
VerticalTabsTrigger,
} from '@repo/ui';
-import { Bookmark, ChevronRightSquare, MessagesSquare, Play, Settings } from 'lucide-react';
+import { Bookmark, ChevronRightSquare, MessagesSquare, Play, Settings } from '@repo/ui/icons';
import Link from 'next/link';
import { ReactMarkdown } from 'react-markdown/lib/react-markdown';
import { getRelativeTime } from '~/utils/relativeTime';
diff --git a/packages/ui/src/icons.ts b/packages/ui/src/icons.ts
index 5e4082ec..e54ca283 100644
--- a/packages/ui/src/icons.ts
+++ b/packages/ui/src/icons.ts
@@ -44,4 +44,10 @@ export {
User,
X,
RotateCcw,
+ Twitter,
+ Minimize2,
+ ArrowDownNarrowWide,
+ ArrowUpNarrowWide,
+ ChevronRightSquare,
+ MessagesSquare,
} from 'lucide-react';
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 72bf9899..8d4634ef 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -279,9 +279,6 @@ importers:
lodash:
specifier: ^4.17.21
version: 4.17.21
- lucide-react:
- specifier: ^0.260.0
- version: 0.260.0([email protected])
lz-string:
specifier: ^1.5.0
version: 1.5.0
@@ -679,7 +676,7 @@ importers:
dependencies:
'@next/eslint-plugin-next':
specifier: canary
- version: 13.4.20-canary.11
+ version: 13.4.20-canary.15
'@repo/tsconfig':
specifier: workspace:*
version: link:../config-typescript
@@ -691,7 +688,7 @@ importers:
'@vercel/style-guide':
specifier: ^4.0.2
eslint:
specifier: ^8.40.0
version: 8.45.0
@@ -1766,8 +1763,8 @@ packages:
glob: 7.1.7
dev: true
- resolution: {integrity: sha512-MMxuj/UUae3IwBZDiOZ2nJkFoJyVG5T5SMTjpw2aIAG/fRbHDMWfcAL8hiUmaflwdgLDJsC/jlXZodXzrCgY8A==}
+ resolution: {integrity: sha512-Bolwt8DYYASzNADy9XIu/q5tLp+/9pVL3DWuaSWpb4UvaJMgyHIgmi+5pM5oRQiC7BwBDErnTBdiEmaP7zl/dQ==}
dependencies:
glob: 7.1.7
dev: false
@@ -4366,7 +4363,7 @@ packages:
yoga-wasm-web: 0.3.0
dev: false
resolution: {integrity: sha512-FroL+oOePzhw7n/I+f7zr4WNroGHT/+2TlW6WH9+CVSjMNsEyu7Qstj2mI5gWIBjT1Y2ZImKPppCzI2cIYmNZw==}
engines: {node: '>=16'}
peerDependencies:
@@ -4386,7 +4383,7 @@ packages:
dependencies:
'@babel/core': 7.22.10
'@babel/eslint-parser': 7.22.10(@babel/[email protected])([email protected])
- '@next/eslint-plugin-next': 13.4.20-canary.11
+ '@next/eslint-plugin-next': 13.4.20-canary.15
'@rushstack/eslint-patch': 1.3.2
'@typescript-eslint/eslint-plugin': 5.59.1(@typescript-eslint/[email protected])([email protected])([email protected])
'@typescript-eslint/parser': 5.62.0([email protected])([email protected])