Skip to content

Connect, collaborate, and grow with a community of TypeScript developers

fix: typecheck test cases on reset

bautistaaa71624b8405fe
diff --git a/packages/monaco/src/editor-hooks.ts b/packages/monaco/src/editor-hooks.ts
index 240e0174..205cd3dd 100644
--- a/packages/monaco/src/editor-hooks.ts
+++ b/packages/monaco/src/editor-hooks.ts
@@ -8,7 +8,7 @@ class EditorEvents extends EventTarget {
const event = new EditorEvents();
type EventNames = 'resetCode';
-export function useResetEditor(): {
+export function useResetEditor(deps: unknown[] = []): {
subscribe: (eventName: EventNames, cb: () => void) => void;
dispatch: (eventName: EventNames) => void;
} {
@@ -19,7 +19,7 @@ export function useResetEditor(): {
};
event.addEventListener(eventName, fnc);
return () => event.removeEventListener(eventName, fnc);
- }, []);
+ }, [...deps]);
}
function dispatch(eventName: EventNames) {
diff --git a/packages/monaco/src/split-editor.tsx b/packages/monaco/src/split-editor.tsx
index f4a273b9..86b32fa1 100644
--- a/packages/monaco/src/split-editor.tsx
+++ b/packages/monaco/src/split-editor.tsx
@@ -210,9 +210,8 @@ export default function SplitEditor({
}
}
}
- const monacoAndEditorStateReady = monaco && userEditorState;
- useResetEditor().subscribe('resetCode', () => {
- if (monacoAndEditorStateReady) {
+ useResetEditor([monaco, userEditorState]).subscribe('resetCode', () => {
+ if (monaco && userEditorState) {
typeCheck();
onMount?.tests?.(userEditorState, monaco);
}