Connect, collaborate, and grow with a community of TypeScript developers
dispose inlay provider on unmount (#1265)
Alexander Durhamc53a2a981578
diff --git a/packages/monaco/src/split-editor.tsx b/packages/monaco/src/split-editor.tsxindex 0ea056e8..8ff1aad4 100644--- a/packages/monaco/src/split-editor.tsx+++ b/packages/monaco/src/split-editor.tsx@@ -90,6 +90,7 @@ export default function SplitEditor({const testPanelSection = useRef<HTMLDivElement>(null);const monacoRef = useRef<typeof import('monaco-editor')>();const editorRef = useRef<monacoType.editor.IStandaloneCodeEditor>();+ const inlayHintsProviderDisposableRef = useRef<monacoType.IDisposable>();useEffect(() => {const saveHandler = (e: KeyboardEvent) => {@@ -113,6 +114,7 @@ export default function SplitEditor({return () => {document.removeEventListener('keydown', saveHandler);+ inlayHintsProviderDisposableRef.current?.dispose();};}, []);@@ -320,11 +322,13 @@ export default function SplitEditor({const getTsWorker = await monaco.languages.typescript.getTypeScriptWorker();const tsWorker = await getTsWorker(model.uri);- monaco.languages.registerInlayHintsProvider(+ const inlayHintsProviderDisposable = monaco.languages.registerInlayHintsProvider('typescript',createTwoslashInlayProvider(monaco, tsWorker),);+ inlayHintsProviderDisposableRef.current = inlayHintsProviderDisposable;+if (hasImports(code)) {const actualCode = code.split('\n')