Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Address valgrind warnings.

Kishore Nallan0508700ca3da
diff --git a/src/array.cpp b/src/array.cpp
index b5805cf2..203e0cf3 100644
--- a/src/array.cpp
+++ b/src/array.cpp
@@ -66,7 +66,7 @@ bool array::insert(size_t index, const uint32_t* values, size_t num_values) {
uint32_t *curr_array = uncompress(length+num_values);
memmove(&curr_array[index+num_values], &curr_array[index], sizeof(uint32_t)*(length-index));
- uint32_t m, M;
+ uint32_t m = min, M = max;
for(size_t i=0; i<num_values; i++) {
uint32_t value = values[i];
diff --git a/src/sorted_array.cpp b/src/sorted_array.cpp
index 9dadc51c..5bb22620 100644
--- a/src/sorted_array.cpp
+++ b/src/sorted_array.cpp
@@ -20,21 +20,6 @@ void sorted_array::load(const uint32_t *sorted_array, const uint32_t array_lengt
}
size_t sorted_array::append(uint32_t value) {
- uint32_t size_required = sorted_append_size_required(value, length+1);
- size_t min_expected_size = size_required + FOR_ELE_SIZE;
-
- /*LOG(INFO) << "value: " << value << ", new_length: " << length+1 << ", size_bytes: " << size_bytes
- << ", size_required: " << size_required << ", min_expected_size: " << min_expected_size;
-
- if(value == 0 && size_bytes == 28) {
- uint32_t* arr = uncompress();
- for(size_t i=0; i<length; i++) {
- LOG(INFO) << "ele: " << arr[i];
- }
-
- delete [] arr;
- }*/
-
if(value < max) {
// we will have to re-encode the whole sequence again
uint32_t* arr = uncompress(length+1);
@@ -57,6 +42,9 @@ size_t sorted_array::append(uint32_t value) {
return i;
} else {
+ uint32_t size_required = sorted_append_size_required(value, length+1);
+ size_t min_expected_size = size_required + FOR_ELE_SIZE;
+
if(size_bytes < min_expected_size) {
// grow the array first
size_t new_size = min_expected_size * FOR_GROWTH_FACTOR;