Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix crash in `_get_reference_collection_names` in case of malformed filter query.

Harpreet Sangar0e9cf7ed69a4
diff --git a/src/collection_manager.cpp b/src/collection_manager.cpp
index f9b3720a..107bc1a7 100644
--- a/src/collection_manager.cpp
+++ b/src/collection_manager.cpp
@@ -893,12 +893,17 @@ void CollectionManager::_get_reference_collection_names(const std::string& filte
if (c == ' ' || c == '(' || c == ')') {
i++;
} else if (c == '&' || c == '|') {
+ if (i + 1 >= size || (c == '&' && filter_query[i+1] != '&') || (c == '|' && filter_query[i+1] != '|')) {
+ reference_collection_names.clear();
+ return;
+ }
i += 2;
} else {
// Reference filter would start with $ symbol.
if (c == '$') {
auto open_paren_pos = filter_query.find('(', ++i);
if (open_paren_pos == std::string::npos) {
+ reference_collection_names.clear();
return;
}
@@ -917,8 +922,18 @@ void CollectionManager::_get_reference_collection_names(const std::string& filte
parenthesis_count--;
}
}
+
+ if (parenthesis_count != 0) {
+ reference_collection_names.clear();
+ return;
+ }
} else {
- while (filter_query[++i] != ':');
+ while (i + 1 < size && filter_query[++i] != ':');
+ if (i >= size) {
+ reference_collection_names.clear();
+ return;
+ }
+
bool in_backtick = false;
do {
c = filter_query[++i];
diff --git a/test/collection_manager_test.cpp b/test/collection_manager_test.cpp
index 421ca276..7d9ab31f 100644
--- a/test/collection_manager_test.cpp
+++ b/test/collection_manager_test.cpp
@@ -1357,10 +1357,18 @@ TEST_F(CollectionManagerTest, GetReferenceCollectionNames) {
CollectionManager::_get_reference_collection_names(filter_query, reference_collection_names);
ASSERT_TRUE(reference_collection_names.empty());
+ filter_query = "foo";
+ CollectionManager::_get_reference_collection_names(filter_query, reference_collection_names);
+ ASSERT_TRUE(reference_collection_names.empty());
+
filter_query = "foo:bar";
CollectionManager::_get_reference_collection_names(filter_query, reference_collection_names);
ASSERT_TRUE(reference_collection_names.empty());
+ filter_query = "$foo(bar:baz) & age: <5";
+ CollectionManager::_get_reference_collection_names(filter_query, reference_collection_names);
+ ASSERT_TRUE(reference_collection_names.empty());
+
filter_query = "$foo(bar:baz)";
std::vector<std::string> result = {"foo"};
CollectionManager::_get_reference_collection_names(filter_query, reference_collection_names);