Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix handling invalid images

ozanarmagan127d0b49e8d3
diff --git a/src/image_embedder.cpp b/src/image_embedder.cpp
index a347811d..0b6b5213 100644
--- a/src/image_embedder.cpp
+++ b/src/image_embedder.cpp
@@ -10,7 +10,10 @@ embedding_res_t CLIPImageEmbedder::embed(const std::string& encoded_image) {
auto processed_image_op = image_processor_.process_image(encoded_image);
if (!processed_image_op.ok()) {
- return embedding_res_t(processed_image_op.code(), processed_image_op.error());
+ nlohmann::json error_json;
+ error_json["error"] = processed_image_op.error();
+ results[i] = embedding_res_t(processed_image_op.code(), error_json);
+ return embedding_res_t(processed_image_op.code(), error_json);
}
auto processed_image = processed_image_op.get();
@@ -58,7 +61,9 @@ std::vector<embedding_res_t> CLIPImageEmbedder::batch_embed(const std::vector<st
auto processed_image_op = image_processor_.process_image(input);
if (!processed_image_op.ok()) {
- results[i] = embedding_res_t(processed_image_op.code(), processed_image_op.error());
+ nlohmann::json error_json;
+ error_json["error"] = processed_image_op.error();
+ results[i] = embedding_res_t(processed_image_op.code(), error_json);
i++;
continue;
}
@@ -67,6 +72,17 @@ std::vector<embedding_res_t> CLIPImageEmbedder::batch_embed(const std::vector<st
i++;
}
+
+ // no valid images
+ if (processed_images.empty()) {
+ std::vector<embedding_res_t> result_vector(inputs.size());
+ for (int i = 0; i < inputs.size(); i++) {
+ result_vector[i] = results[i];
+ }
+
+ return result_vector;
+ }
+
// create input tensor
std::vector<int64_t> input_shape = {static_cast<int64_t>(processed_images.size()), 3, 224, 224};
std::vector<const char*> input_names = {"input_ids", "pixel_values", "attention_mask"};
diff --git a/src/image_processor.cpp b/src/image_processor.cpp
index 707031d9..e9a942b3 100644
--- a/src/image_processor.cpp
+++ b/src/image_processor.cpp
@@ -36,8 +36,7 @@ Option<processed_image_t> CLIPImageProcessor::process_image(const std::string& i
LOG(INFO) << "Running image processor";
try {
output_tensors = session_->Run(Ort::RunOptions{nullptr}, input_names.data(), &input_tensor, 1, output_names.data(), output_names.size());
- } catch (const std::exception& e) {
- LOG(INFO) << "Error while running image processor: " << e.what();
+ } catch (...) {
return Option<processed_image_t>(400, "Error while processing image");
}