Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Add comments.

Harpreet Sangar2a1feae0ee2d
diff --git a/include/collection.h b/include/collection.h
index 4e08d4da..dc8f41db 100644
--- a/include/collection.h
+++ b/include/collection.h
@@ -457,6 +457,7 @@ public:
Option<bool> get_filter_ids(const std::string & filter_query, filter_result_t& filter_result) const;
+ /// Get approximate count of docs matching a reference filter on foo collection when $foo(...) filter is encountered.
Option<bool> get_approximate_reference_filter_ids(const std::string& filter_query,
uint32_t& filter_ids_length) const;
diff --git a/include/field.h b/include/field.h
index dd0033eb..a4ac81b8 100644
--- a/include/field.h
+++ b/include/field.h
@@ -594,12 +594,6 @@ struct filter {
filter_node_t*& root);
};
-struct filter_tree_metrics {
- int filter_exp_count;
- int and_operator_count;
- int or_operator_count;
-};
-
struct filter_node_t {
filter filter_exp;
FILTER_OPERATOR filter_operator;
diff --git a/include/index.h b/include/index.h
index 43ec2f28..9f170a4d 100644
--- a/include/index.h
+++ b/include/index.h
@@ -486,8 +486,15 @@ private:
const int64_t& range_end_value,
uint32_t& filter_ids_length) const;
- Option<bool> recursive_filter(filter_node_t* const root,
- filter_result_t& result,
+ /// Traverses through filter tree to get the filter_result.
+ ///
+ /// \param filter_tree_root
+ /// \param filter_result
+ /// \param collection_name Name of the collection to which current index belongs. Used to find the reference field in other collection.
+ /// \param context_ids_length Number of docs matching the search query.
+ /// \param context_ids Array of doc ids matching the search query.
+ Option<bool> recursive_filter(filter_node_t* const filter_tree_root,
+ filter_result_t& filter_result,
const std::string& collection_name = "",
const uint32_t& context_ids_length = 0,
uint32_t* const& context_ids = nullptr) const;
@@ -700,6 +707,7 @@ public:
const std::string& collection_name,
const std::string& reference_helper_field_name) const;
+ /// Get approximate count of docs matching a reference filter on foo collection when $foo(...) filter is encountered.
Option<bool> get_approximate_reference_filter_ids_with_lock(filter_node_t* const filter_tree_root,
uint32_t& filter_ids_length) const;