Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Fix single list block intersection.

Kishore Nallan325c8ef103be
diff --git a/src/posting.cpp b/src/posting.cpp
index 7acef8bf..f5b9c81d 100644
--- a/src/posting.cpp
+++ b/src/posting.cpp
@@ -156,7 +156,7 @@ compact_posting_list_t* compact_posting_list_t::create(uint32_t num_ids, const u
}
posting_list_t* compact_posting_list_t::to_full_posting_list() {
- posting_list_t* pl = new posting_list_t(1024);
+ posting_list_t* pl = new posting_list_t(512);
size_t i = 0;
while(i < length) {
diff --git a/src/posting_list.cpp b/src/posting_list.cpp
index 9eda281e..47ae7ade 100644
--- a/src/posting_list.cpp
+++ b/src/posting_list.cpp
@@ -688,6 +688,16 @@ bool posting_list_t::block_intersect(const std::vector<posting_list_t*>& posting
case 1:
while(its[0].valid()) {
iter_state.ids.push_back(its[0].id());
+
+ std::vector<block_t*> block_vec(1);
+ std::vector<uint32_t> index_vec(1);
+
+ block_vec[0] = its[0].block();
+ index_vec[0] = its[0].index();
+
+ iter_state.blocks.emplace_back(block_vec);
+ iter_state.indices.emplace_back(index_vec);
+
its[0].next();
if(iter_state.ids.size() == batch_size) {
@@ -702,7 +712,7 @@ bool posting_list_t::block_intersect(const std::vector<posting_list_t*>& posting
iter_state.ids.push_back(its[0].id());
std::vector<block_t*> block_vec(2);
- std::vector<uint32_t> index_vec(its.size());
+ std::vector<uint32_t> index_vec(2);
block_vec[0] = its[0].block();
block_vec[1] = its[1].block();
diff --git a/test/posting_list_test.cpp b/test/posting_list_test.cpp
index ff10de7f..2444c2f5 100644
--- a/test/posting_list_test.cpp
+++ b/test/posting_list_test.cpp
@@ -650,9 +650,25 @@ TEST(PostingListTest, IntersectionBasics) {
has_more = posting_list_t::block_intersect(single_item_list, 2, its3, iter_state3);
ASSERT_TRUE(has_more);
ASSERT_EQ(2, iter_state3.ids.size());
+ ASSERT_EQ(0, iter_state3.ids[0]);
+ ASSERT_EQ(2, iter_state3.ids[1]);
+ ASSERT_EQ(2, iter_state3.blocks.size());
+ ASSERT_EQ(1, iter_state3.blocks[0].size());
+ ASSERT_EQ(1, iter_state3.blocks[1].size());
+ ASSERT_EQ(2, iter_state3.indices.size());
+ ASSERT_EQ(1, iter_state3.indices[0].size());
+ ASSERT_EQ(0, iter_state3.indices[0][0]);
+ ASSERT_EQ(1, iter_state3.indices[1][0]);
+
has_more = posting_list_t::block_intersect(single_item_list, 2, its3, iter_state3);
ASSERT_FALSE(has_more);
ASSERT_EQ(2, iter_state3.ids.size());
+ ASSERT_EQ(2, iter_state3.blocks.size());
+ ASSERT_EQ(1, iter_state3.blocks[0].size());
+ ASSERT_EQ(1, iter_state3.blocks[1].size());
+ ASSERT_EQ(2, iter_state3.indices.size());
+ ASSERT_EQ(1, iter_state3.indices[0].size());
+ ASSERT_EQ(1, iter_state3.indices[1].size());
// empty intersection list
std::vector<posting_list_t*> empty_list;
@@ -665,6 +681,8 @@ TEST(PostingListTest, IntersectionBasics) {
has_more = posting_list_t::block_intersect(empty_list, 1, its4, iter_state4);
ASSERT_FALSE(has_more);
ASSERT_EQ(0, iter_state4.ids.size());
+ ASSERT_EQ(0, iter_state4.blocks.size());
+ ASSERT_EQ(0, iter_state4.indices.size());
}
TEST(PostingListTest, ResultsAndOffsetsBasics) {