Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Remove limit of 10 filter values to compute filter iterator. (#1739)

Harpreet Sangar35e6a097afc6
diff --git a/src/filter_result_iterator.cpp b/src/filter_result_iterator.cpp
index 05fc4fd1..39cb0bcf 100644
--- a/src/filter_result_iterator.cpp
+++ b/src/filter_result_iterator.cpp
@@ -985,11 +985,6 @@ void filter_result_iterator_t::init() {
seq_ids = std::vector<uint32_t>(id_lists.size(), UINT32_MAX);
- if (a_filter.values.size() > 10) {
- compute_iterators();
- return;
- }
-
if (a_filter.apply_not_equals) {
auto const& num_ids = index->seq_ids->num_ids();
approx_filter_ids_length = approx_filter_ids_length >= num_ids ? num_ids : (num_ids - approx_filter_ids_length);
@@ -1112,11 +1107,6 @@ void filter_result_iterator_t::init() {
seq_ids = std::vector<uint32_t>(id_lists.size(), UINT32_MAX);
- if (a_filter.values.size() > 10) {
- compute_iterators();
- return;
- }
-
if (a_filter.apply_not_equals) {
auto const& num_ids = index->seq_ids->num_ids();
approx_filter_ids_length = approx_filter_ids_length >= num_ids ? num_ids : (num_ids - approx_filter_ids_length);
@@ -1511,11 +1501,6 @@ void filter_result_iterator_t::init() {
approx_filter_ids_length += approx_filter_value_match;
}
- if (a_filter.values.size() > 10) {
- compute_iterators();
- return;
- }
-
if (a_filter.apply_not_equals) {
auto const& num_ids = index->seq_ids->num_ids();
approx_filter_ids_length = approx_filter_ids_length >= num_ids ? num_ids : (num_ids - approx_filter_ids_length);
diff --git a/test/filter_test.cpp b/test/filter_test.cpp
index 092da45b..e44dc6d6 100644
--- a/test/filter_test.cpp
+++ b/test/filter_test.cpp
@@ -463,25 +463,6 @@ TEST_F(FilterTest, FilterTreeIterator) {
ASSERT_EQ(filter_result_iterator_t::invalid, iter_string_multi_value_test.validity);
delete filter_tree_root;
- filter_tree_root = nullptr;
- filter_op = filter::parse_filter_query("tags: [gold, gold, gold, gold, gold, gold, gold, gold, gold, gold, gold]",
- coll->get_schema(), store, doc_id_prefix,
- filter_tree_root);
- ASSERT_TRUE(filter_op.ok());
-
- auto iter_string_multi_value_test_2 = filter_result_iterator_t(coll->get_name(), coll->_get_index(), filter_tree_root);
- ASSERT_TRUE(iter_string_multi_value_test_2.init_status().ok());
- ASSERT_TRUE(iter_string_multi_value_test_2._get_is_filter_result_initialized());
-
- expected = {0, 2, 4};
- for (auto const& i : expected) {
- ASSERT_EQ(filter_result_iterator_t::valid, iter_string_multi_value_test_2.validity);
- ASSERT_EQ(i, iter_string_multi_value_test_2.seq_id);
- iter_string_multi_value_test_2.next();
- }
- ASSERT_EQ(filter_result_iterator_t::invalid, iter_string_multi_value_test_2.validity);
- delete filter_tree_root;
-
filter_tree_root = nullptr;
filter_op = filter::parse_filter_query("tags:= bronze", coll->get_schema(), store, doc_id_prefix,
filter_tree_root);