Skip to content

Open Source alternative to Algolia + Pinecone and an Easier-to-Use alternative to ElasticSearch ⚡ 🔍 ✨ Fast, typo tolerant, in-memory fuzzy Search Engine for building delightful search experiences

Rename mutate_query_string -> remove_matched_tokens

Kishore Nallan36a26f3f407b
diff --git a/include/index.h b/include/index.h
index 8d8171b2..29953e72 100644
--- a/include/index.h
+++ b/include/index.h
@@ -72,7 +72,7 @@ struct override_t {
std::vector<drop_hit_t> drop_hits;
std::string filter_by;
- bool mutate_query_string = false;
+ bool remove_matched_tokens = false;
override_t() {}
@@ -149,12 +149,12 @@ struct override_t {
}
}
- if(override_json.count("mutate_query_string") != 0) {
- if (!override_json["mutate_query_string"].is_boolean()) {
- return Option<bool>(400, "The `mutate_query_string` must be a boolean.");
+ if(override_json.count("remove_matched_tokens") != 0) {
+ if (!override_json["remove_matched_tokens"].is_boolean()) {
+ return Option<bool>(400, "The `remove_matched_tokens` must be a boolean.");
}
- override.mutate_query_string = override_json["mutate_query_string"].get<bool>();
+ override.remove_matched_tokens = override_json["remove_matched_tokens"].get<bool>();
}
if(!id.empty()) {
diff --git a/src/index.cpp b/src/index.cpp
index 12e871e6..d0f34d3c 100644
--- a/src/index.cpp
+++ b/src/index.cpp
@@ -1725,7 +1725,7 @@ void Index::static_filter_query_eval(const override_t* override,
return ;
}
- if(override->mutate_query_string) {
+ if(override->remove_matched_tokens) {
query.replace(query.find(override->rule.query), override->rule.query.size(), "");
if(StringUtils::trim(query).empty()) {
tokens = {"*"};
@@ -1851,7 +1851,7 @@ void Index::process_filter_overrides(const std::vector<const override_t*>& filte
bool resolved_override = resolve_override(rule_parts, exact_rule_match, query_tokens, token_order,
absorbed_tokens, field_override_ids, field_override_ids_len);
- if(resolved_override && override->mutate_query_string) {
+ if(resolved_override && override->remove_matched_tokens) {
std::vector<std::string> new_tokens;
for(auto& token: query_tokens) {
if(absorbed_tokens.count(token) == 0) {
@@ -1879,7 +1879,7 @@ void Index::process_filter_overrides(const std::vector<const override_t*>& filte
resolved_override = resolve_override(rule_parts, exact_rule_match, syn_tokens, token_order, absorbed_tokens,
synonym_override_ids, synonym_override_ids_len);
- if(resolved_override && override->mutate_query_string) {
+ if(resolved_override && override->remove_matched_tokens) {
std::vector<std::string> new_tokens;
for (auto& token: syn_tokens) {
if (absorbed_tokens.count(token) == 0) {
diff --git a/test/collection_override_test.cpp b/test/collection_override_test.cpp
index bd8c91fd..6702b087 100644
--- a/test/collection_override_test.cpp
+++ b/test/collection_override_test.cpp
@@ -848,7 +848,7 @@ TEST_F(CollectionOverrideTest, DynamicFilteringExactMatchBasics) {
{"match", override_t::MATCH_EXACT}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", "category: {category}"}
};
@@ -865,7 +865,7 @@ TEST_F(CollectionOverrideTest, DynamicFilteringExactMatchBasics) {
{"match", override_t::MATCH_EXACT}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", "category: {category} && brand: {brand}"}
};
@@ -902,7 +902,7 @@ TEST_F(CollectionOverrideTest, DynamicFilteringExactMatchBasics) {
{"match", override_t::MATCH_EXACT}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", ""}
};
@@ -919,7 +919,7 @@ TEST_F(CollectionOverrideTest, DynamicFilteringExactMatchBasics) {
{"match", override_t::MATCH_EXACT}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", {"foo", "bar"}}
};
@@ -983,7 +983,7 @@ TEST_F(CollectionOverrideTest, DynamicFilteringMultiplePlaceholders) {
{"match", override_t::MATCH_CONTAINS}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", "brand: {brand} && color: {color}"}
};
@@ -1063,7 +1063,7 @@ TEST_F(CollectionOverrideTest, DynamicFilteringTokensBetweenPlaceholders) {
{"match", override_t::MATCH_CONTAINS}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", "brand: {brand} && color: {color}"}
};
@@ -1136,7 +1136,7 @@ TEST_F(CollectionOverrideTest, DynamicFilteringWithSynonyms) {
{"match", override_t::MATCH_EXACT}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", "category: {category}"}
};
@@ -1204,7 +1204,7 @@ TEST_F(CollectionOverrideTest, StaticFiltering) {
{"match", override_t::MATCH_CONTAINS}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", "price:> 100"}
};
@@ -1222,7 +1222,7 @@ TEST_F(CollectionOverrideTest, StaticFiltering) {
{"match", override_t::MATCH_EXACT}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", "price:< 100"}
};
@@ -1306,7 +1306,7 @@ TEST_F(CollectionOverrideTest, FilteringWithAndWithoutQueryStringMutation) {
{"match", override_t::MATCH_CONTAINS}
}
},
- {"mutate_query_string", false},
+ {"remove_matched_tokens", false},
{"filter_by", "price:> 200"}
};
@@ -1334,7 +1334,7 @@ TEST_F(CollectionOverrideTest, FilteringWithAndWithoutQueryStringMutation) {
{"match", override_t::MATCH_CONTAINS}
}
},
- {"mutate_query_string", true},
+ {"remove_matched_tokens", true},
{"filter_by", "price:> 200"}
};